[dpdk-dev] [v3 PATCH] usertools: show valid hugepage sizes if user requests an invalid hugepage size

If user requests a hugepage size which is not supported by the system, currently user gets an error message saying that the requested size is not a valid system huge page size. In addition to this if we display the valid hugepage sizes it will be convenient for the user to request the right size ne

Re: [dpdk-dev] [PATCH] bus/pci: fix probing for non-netuio bound devices

> Subject: [PATCH] bus/pci: fix probing for non-netuio bound devices > > External email: Use caution opening links or attachments > > > Implement rte_pci_map_device() to distinguish between the devices bound > to netuio and NDIS devices. > Only return success for the netuio devices. > > Suggest

[dpdk-dev] [PATCH v3] log: support custom log function

By default, the dpdk log is out to stdout/stderr and syslog. The rte_openlog_stream could set an external FILE* stream, but it asks the consumer to give it a FILE* pointer. For C++ or other languages, it's hard to get a libc FILE*. Support to set a hook is another choice for this scenario. Signed

[dpdk-dev] [PATCH] bus/pci: fix probing for non-netuio bound devices

Implement rte_pci_map_device() to distinguish between the devices bound to netuio and NDIS devices. Only return success for the netuio devices. Suggested-by: Dmitry Kozlyuk Signed-off-by: Pallavi Kadam Reviewed-by: Ranjit Menon --- drivers/bus/pci/windows/pci.c | 15 +++ 1 file cha

[dpdk-dev] [PATCH v13 4/4] examples/ifpga: add example for ifpga APIs

This example application shows how to use ifpga APIs. A set of OPAE APIs are implemented based on these ifpga APIs. You can test each OPAE API by running corresponding command. A guide is also added to show how to run the example. Signed-off-by: Wei Huang Acked-by: Tianfei Zhang Acked-by: Rosen

[dpdk-dev] [PATCH v13 3/4] raw/ifpga: add miscellaneous APIs

Below miscellaneous APIs are used to implement OPAE application. 1. rte_pmd_ifpga_get_pci_bus() get PCI bus ifpga driver registered. 2. rte_pmd_ifpga_partial_reconfigure() do partial reconfiguration. 3. rte_pmd_ifpga_cleanup() free software resources allocated by driver. 4. rte_pmd_ifpga_set_rsu_st

[dpdk-dev] [PATCH v13 2/4] raw/ifpga: add APIs to get fpga information

There are some information data can be got from FPGA, they are implemented in below APIs: 1. rte_pmd_ifpga_get_property() get properties of FPGA (include BMC). 2. rte_pmd_ifpga_get_phy_info() get information of PHY connect to FPGA. 3. rte_pmd_ifpga_get_rsu_status() get status of rsu process. Signe

[dpdk-dev] [PATCH v13 1/4] raw/ifpga: add fpga rsu APIs

RSU (Remote System Update) depends on secure manager which may be different on various implementations, so a new secure manager device is implemented for adapting such difference. There are five APIs added: 1. rte_pmd_ifpga_get_dev_id() get raw device ID of ifpga device from PCI address like 'Domai

[dpdk-dev] [PATCH v13 0/4] raw/ifpga: add extra OPAE APIs

Cyborg is part of OpenStack, it needs some OPAE APIs to manage devices with Intel FPGA. The first three patches implement extra APIs to meet Cyborg requirement. The last patch add an example to show how to use these APIs. Main changes from v12: - implement ifpga APIs in rte_pmd_ifpga.c Wei Huang

Re: [dpdk-dev] [PATCH v3] app/testpmd: fix meter commands help strings

Acked-by: Xiaoyun Li -Original Message- From: Yigit, Ferruh Sent: Tuesday, February 9, 2021 22:15 To: Li, Xiaoyun ; Singh, Jasvinder ; Wu, Jingjing ; Adrien Mazarguil ; Dumitrescu, Cristian Cc: Yigit, Ferruh ; dev@dpdk.org; sta...@dpdk.org Subject: [PATCH v3] app/testpmd: fix meter

Re: [dpdk-dev] [PATCH] eal: fix detection of static or shared DPDK builds

Hi Bruce, Thanks for the fix. I do see the issue mentioned when using DPDK shared libs with OVS and this patch fixes it. However, I saw the issue only for system installed DPDK but not for directory installed DPDK. > I saw this issue with OVS, where I was getting weird failures about ports n

Re: [dpdk-dev] [PATCH] guides: add a testing guide for developing tests

"Kinsella, Ray" writes: > On 08/02/2021 16:52, Aaron Conole wrote: >> The DPDK testing infrastructure includes a comprehensive set of >> libraries, utilities, and CI integrations for developers to test >> their code changes. This isn't well documented, however. >> >> Document the basics for add

Re: [dpdk-dev] [PATCH] dpdk-kmods/windows: Add Intel 40GbE Ethernet adapter device IDs to netuio INF

On Mon, Feb 01, 2021 at 04:49:58PM -0800, Pallavi Kadam wrote: > Add Intel 40GbE Ethernet adapter device IDs to netuio inf file > in order to enable them on Windows. > > Signed-off-by: Pallavi Kadam > Reviewed-by: Ranjit Menon > --- > windows/netuio/netuio.inf | 28

Re: [dpdk-dev] |FAILURE| pw devtools: add llx format specifier check

0-day Robot writes: > From: ro...@bytheb.org > > Test-Label: travis-robot > Test-Status: FAILURE > > > _travis build: failed_ > Build URL: /build/216558092 Sorry for the noise here. We hooked up some new features for the robot and introduced a misconfiguration. It should be fixed shortly, and

[dpdk-dev] |FAILURE| pw app/testpmd: remove unused struct member

From: ro...@bytheb.org Test-Label: travis-robot Test-Status: FAILURE _travis build: failed_ Build URL: /build/216558679

[dpdk-dev] |FAILURE| pw devtools: add llx format specifier check

From: ro...@bytheb.org Test-Label: travis-robot Test-Status: FAILURE _travis build: failed_ Build URL: /build/216558092

Re: [dpdk-dev] [PATCH] devtools: add llx format specifier check

09/02/2021 16:26, Ferruh Yigit: > %llx tends to be wrong when used for fixed size, like uint64_t, > variables, adding a warning to double check them. > > Signed-off-by: Ferruh Yigit > --- > + # check %llx usage > + awk -v FOLDERS='lib drivers app examples' \ > + -v EXPRESSIONS

Re: [dpdk-dev] [dpdklab] Re: [dpdk-ci] [CI] SPDK compilation failures @ DPDK community lab

Hi everyone, I will adjust the branches and watch over the first few pipelines to make sure everything goes smoothly. Thanks for the update, Brandon On Tue, Feb 9, 2021 at 10:13 AM Aaron Conole wrote: > > "Zawadzki, Tomasz" writes: > > > Hi Lincoln, > > > > > > > > That patch in question is no

[dpdk-dev] [PATCH v2] app/testpmd: remove unused struct member

The tx_queue member of the fwd_lcore struct is unused as it is already part of the fwd_stream structure. Deleting helps improve code readability. Signed-off-by: Kathleen Capella Reviewed-by: Honnappa Nagarahalli Acked-by: Thomas Monjalon --- app/test-pmd/testpmd.h | 1 - 1 file changed, 1 dele

Re: [dpdk-dev] [PATCH v3] app/testpmd: fix meter commands help strings

> -Original Message- > From: Yigit, Ferruh > Sent: Tuesday, February 9, 2021 2:15 PM > To: Li, Xiaoyun ; Singh, Jasvinder > ; Wu, Jingjing ; Adrien > Mazarguil ; Dumitrescu, Cristian > > Cc: Yigit, Ferruh ; dev@dpdk.org; sta...@dpdk.org > Subject: [PATCH v3] app/testpmd: fix meter comm

[dpdk-dev] [PATCH] devtools: add llx format specifier check

%llx tends to be wrong when used for fixed size, like uint64_t, variables, adding a warning to double check them. Signed-off-by: Ferruh Yigit --- Cc: David Marchand Cc: Aaron Conole --- devtools/checkpatches.sh | 8 1 file changed, 8 insertions(+) diff --git a/devtools/checkpatches.s

Re: [dpdk-dev] [dpdk-ci] [CI] SPDK compilation failures @ DPDK community lab

"Zawadzki, Tomasz" writes: > Hi Lincoln, > > > > That patch in question is now merged to branch v21.01.x. > Good to know - I do still see a failure in the IOL job (even from a few hours ago). I suppose the lab side might need some adjustment, too? > > The builds performed for latest SPDK and

[dpdk-dev] [PATCH] log/linux: make default output stderr

In Linux by default DPDK log goes to stdout, as well as syslog. It is possible for an application to change the library output stream via 'rte_openlog_stream()' API, to set it to stderr, it can be used as: rte_openlog_stream(stderr); But still updating the default log output to 'stderr'. Bugzill

Re: [dpdk-dev] [PATCH] vhost: fix packed ring dequeue offloading

On 2/5/21 8:47 AM, Marvin Liu wrote: > When vhost doing dequeue offloading, will parse ethernet and l3/l4 > header of the packet. Then vhost will set corresponded value in mbuf corresponding* > attributes. Thus mean offloading action should after packet data copy. It means* > > Fixes: 75ed5

Re: [dpdk-dev] [PATCH v6 2/2] bus/pci: support MMIO in PCI ioport accessors

On 1/29/2021 3:18 AM, 谢华伟(此时此刻） wrote: From: "huawei.xhw" With IO BAR, we get PIO(programmed IO) address. With MMIO BAR, we get mapped virtual address. We distinguish PIO(Programmed IO) and MMIO(memory mapped IO) by their address like how kernel does. ioread/write8/16/32 is provided to access

Re: [dpdk-dev] [dpdk-stable] [PATCH] eal: don't log uninitialized string

> On Jan 6, 2021, at 4:35 AM, David Marchand wrote: > > On Fri, Dec 11, 2020 at 6:07 PM Andrew Boyer > wrote: >> >> Our Coverity scan pointed out that path[] is never initialized. >> The official DPDK Coverity has not reported this so there is >> no public CID for i

[dpdk-dev] [PATCH v3] app/testpmd: fix meter commands help strings

Helps strings syntax is "command : description", the 'command' part was missing, updated command help strings. Fixes: 281eeb8afc55 ("app/testpmd: add commands for metering and policing") Fixes: 30ffb4e67ee3 ("app/testpmd: add commands traffic metering and policing") Fixes: e63b50162aa3 ("app/testp

Re: [dpdk-dev] [PATCH] telemetry: mark init function as internal-only

05/02/2021 22:23, Bruce Richardson: > The "rte_telemetry_init()" function is for use by "rte_eal_init()" and > should not be part of the public API. Mark it as internal only. > > Fixes: 6dd571fd07c3 ("telemetry: introduce new functionality") > Cc: sta...@dpdk.org > > Signed-off-by: Bruce Richards

Re: [dpdk-dev] [PATCH] eal: fix return value comment

On 06-Jun-20 10:17 AM, wangyunjian wrote: From: Yunjian Wang Fix few comments and add detailed comments for return value. Fixes: 279b581c897d ("vfio: expose functions") Cc: sta...@dpdk.org Signed-off-by: Yunjian Wang --- Acked-by: Anatoly Burakov -- Thanks, Anatoly

Re: [dpdk-dev] [PATCH] eal: fix detection of static or shared DPDK builds

On Mon, Feb 08, 2021 at 04:33:19PM +, Bruce Richardson wrote: > When checking the loading of EAL shared lib to see if we have a shared > DPDK build, we only want to include part of the ABI version in the check > rather than the whole thing. For example, with ABI version 21.1 for DPDK > release

Re: [dpdk-dev] [PATCH v5] build: kni cross-compilation support

On Tue, Feb 09, 2021 at 12:07:13PM +, Juraj Linkeš wrote: > > > > -Original Message- > > From: Bruce Richardson > > Sent: Tuesday, February 9, 2021 12:51 PM > > To: Juraj Linkeš > > Cc: tho...@monjalon.net; ruifeng.w...@arm.com; > > honnappa.nagaraha...@arm.com; jerinjac...@gmail.co

Re: [dpdk-dev] [dpdk-stable] [PATCH] eal: fix querying DPDK version at runtime

On Tue, Feb 09, 2021 at 01:34:40PM +0100, Thomas Monjalon wrote: > 05/02/2021 22:26, Bruce Richardson: > > On Fri, Feb 05, 2021 at 09:05:43PM +0100, Thomas Monjalon wrote: > > > 05/02/2021 20:39, Bruce Richardson: > > > > For using a DPDK application, such as OVS, which is dynamically linked, > >

Re: [dpdk-dev] [dpdk-stable] [PATCH] eal: fix querying DPDK version at runtime

05/02/2021 22:26, Bruce Richardson: > On Fri, Feb 05, 2021 at 09:05:43PM +0100, Thomas Monjalon wrote: > > 05/02/2021 20:39, Bruce Richardson: > > > For using a DPDK application, such as OVS, which is dynamically linked, > > > the > > > DPDK version in use should always report the actual version,

Re: [dpdk-dev] [PATCH v5] build: kni cross-compilation support

> -Original Message- > From: Bruce Richardson > Sent: Tuesday, February 9, 2021 12:51 PM > To: Juraj Linkeš > Cc: tho...@monjalon.net; ruifeng.w...@arm.com; > honnappa.nagaraha...@arm.com; jerinjac...@gmail.com; > hemant.agra...@nxp.com; ferruh.yi...@intel.com; abo...@pensando.io; > dev

Re: [dpdk-dev] dpdk-20.11 is really released as LTS?

On Tue, Feb 09, 2021 at 02:25:19PM +0330, hamidreza Kheirabadi wrote: > Hi, > I used previous versions of dpdk (like 18.05) in my project very well. > Recently I decided to migrate to 20.11 but I have lots of problems with it. > I built it with meson and ninja as described in docs but no .ko has be

Re: [dpdk-dev] [PATCH v5] build: kni cross-compilation support

On Tue, Feb 09, 2021 at 09:47:05AM +0100, Juraj Linkeš wrote: > The kni linux module is using a custom target for building, which > doesn't take into account any cross compilation arguments. The arguments > in question are ARCH, CROSS_COMPILE (for gcc, clang) and CC, LD (for > clang). Get those fro

Re: [dpdk-dev] [v2 PATCH] usertools: show valid hugepage sizes if user requests an invalid hugepage size

On 02-Dec-20 11:06 AM, Sarosh Arif wrote: If user requests a hugepage size which is not supported by the system, currently user gets an error message saying that the requested size is not a valid system huge page size. In addition to this if we display the valid hugepage sizes it will be convenie

Re: [dpdk-dev] [PATCH v2] app/testpmd: fix meter commands help strings

On 2/9/2021 2:35 AM, Li, Xiaoyun wrote: Hi -Original Message- From: Yigit, Ferruh Sent: Monday, February 8, 2021 23:15 To: Li, Xiaoyun ; Singh, Jasvinder ; Wu, Jingjing ; Adrien Mazarguil ; Dumitrescu, Cristian Cc: Yigit, Ferruh ; dev@dpdk.org; sta...@dpdk.org Subject: [PATCH v2] app/

[dpdk-dev] dpdk-20.11 is really released as LTS?

Hi, I used previous versions of dpdk (like 18.05) in my project very well. Recently I decided to migrate to 20.11 but I have lots of problems with it. I built it with meson and ninja as described in docs but no .ko has been built. The structure of examples also changed and was replaced by a single

[dpdk-dev] [PATCH] net/octeontx2: fix vlan filter on port

From: Satheesh Paul This patch fixes incorrect MCAM key preparation when creating MCAM entry to allow VLAN IDs after vlan filtering is enabled on port. Fixes: ba1b3b081e ("net/octeontx2: support VLAN offloads") Cc: sta...@dpdk.org Signed-off-by: Satheesh Paul --- drivers/net/octeontx2/otx2_vl

[dpdk-dev] [PATCH v5] build: kni cross-compilation support

The kni linux module is using a custom target for building, which doesn't take into account any cross compilation arguments. The arguments in question are ARCH, CROSS_COMPILE (for gcc, clang) and CC, LD (for clang). Get those from the cross file and pass them to the custom target. The user supplie

Re: [dpdk-dev] [PATCH] doc: fix mark action zero value description in mlx5 guide

Hi, > -Original Message- > From: Viacheslav Ovsiienko > Sent: Friday, February 5, 2021 2:15 PM > To: dev@dpdk.org > Cc: Raslan Darawsheh ; Matan Azrad > ; sta...@dpdk.org > Subject: [PATCH] doc: fix mark action zero value description in mlx5 guide > > The zero value in flow MARK action is

Re: [dpdk-dev] [dpdk-announce] release candidate 21.02-rc3

All, Update the test status for Intel part. Validation test are almost finished. # Basic Intel(R) NIC testing * Build or compile: *Build: cover the build test combination with latest GCC/Clang/ICC version and the popular OS revision such as Ubuntu20.04, CentOS 8.3, C