[dpdk-dev] [PATCH] config/arm: add qualcomm config

2021-02-05 Thread Honnappa Nagarahalli
Add Qualcomm config back which was deleted. Fixes: 91c730fd4e09 ("config/arm: remove unused or superfluous variables") Cc: juraj.lin...@pantheon.tech Signed-off-by: Honnappa Nagarahalli Reviewed-by: Ruifeng Wang --- config/arm/meson.build | 15 +++ 1 file changed, 15 insertions(+)

Re: [dpdk-dev] [PATCH] eal: fix querying DPDK version at runtime

2021-02-05 Thread Bruce Richardson
On Fri, Feb 05, 2021 at 09:05:43PM +0100, Thomas Monjalon wrote: > 05/02/2021 20:39, Bruce Richardson: > > For using a DPDK application, such as OVS, which is dynamically linked, the > > DPDK version in use should always report the actual version, not the > > version used at build time. This incorr

[dpdk-dev] [PATCH] telemetry: mark init function as internal-only

2021-02-05 Thread Bruce Richardson
The "rte_telemetry_init()" function is for use by "rte_eal_init()" and should not be part of the public API. Mark it as internal only. Fixes: 6dd571fd07c3 ("telemetry: introduce new functionality") Cc: sta...@dpdk.org Signed-off-by: Bruce Richardson --- doc/guides/rel_notes/release_21_02.rst |

Re: [dpdk-dev] [PATCH] app/testpmd: remove duplicated offload display

2021-02-05 Thread Lance Richardson
On Fri, Feb 5, 2021 at 9:27 AM Ferruh Yigit wrote: > > "show port cap all|" was to display offload configuration of > port(s). > > But later two other commands added to show same information in more > accurate way: > show port (port_id) rx_offload configuration > show port (port_id) tx_offload c

Re: [dpdk-dev] [PATCH v2 6/13] net/ionic: clean up Tx queue version support

2021-02-05 Thread Thomas Monjalon
05/02/2021 21:26, Andrew Boyer: > > On Feb 5, 2021, at 3:20 PM, Thomas Monjalon wrote: > > 29/01/2021 23:44, Andrew Boyer: > >> The ionic PMD only supports Tx queue version 1 or greater. > >> Version 1 introduced a new SGL format with support for more > >> fragments per descriptor. > >> > >> Add

[dpdk-dev] [dpdk-announce] release candidate 21.02-rc3

2021-02-05 Thread Thomas Monjalon
A new DPDK release candidate is ready for testing: https://git.dpdk.org/dpdk/tag/?id=v21.02-rc3 There are 80 new patches in this snapshot. Release notes: https://doc.dpdk.org/guides/rel_notes/release_21_02.html Please test and report issues on bugs.dpdk.org. You may share some re

Re: [dpdk-dev] [PATCH v2 6/13] net/ionic: clean up Tx queue version support

2021-02-05 Thread Andrew Boyer
> On Feb 5, 2021, at 3:20 PM, Thomas Monjalon wrote: > > 29/01/2021 23:44, Andrew Boyer: >> The ionic PMD only supports Tx queue version 1 or greater. >> Version 1 introduced a new SGL format with support for more >> fragments per descriptor. >> >> Add release notes and an explanation to the

Re: [dpdk-dev] [PATCH v2 6/13] net/ionic: clean up Tx queue version support

2021-02-05 Thread Thomas Monjalon
29/01/2021 23:44, Andrew Boyer: > The ionic PMD only supports Tx queue version 1 or greater. > Version 1 introduced a new SGL format with support for more > fragments per descriptor. > > Add release notes and an explanation to the docs. > > Signed-off-by: Andrew Boyer > --- > +* **Updated the Pe

Re: [dpdk-dev] [PATCH] testpmd: remove unused member from lcore structure

2021-02-05 Thread Thomas Monjalon
About the title: - the prefix should be app/testpmd - it is not exactly an lcore structure I would propose: app/testpmd: remove unused struct member 05/02/2021 20:08, Kathleen Capella: > The tx_queue member of the fwd_lcore struct is unused as it is already > part of the fwd_stream

Re: [dpdk-dev] [PATCH] eal: fix querying DPDK version at runtime

2021-02-05 Thread Thomas Monjalon
05/02/2021 20:39, Bruce Richardson: > For using a DPDK application, such as OVS, which is dynamically linked, the > DPDK version in use should always report the actual version, not the > version used at build time. This incorrect behaviour can be seen by > building OVS against one version of DPDK a

[dpdk-dev] [PATCH] eal: fix querying DPDK version at runtime

2021-02-05 Thread Bruce Richardson
For using a DPDK application, such as OVS, which is dynamically linked, the DPDK version in use should always report the actual version, not the version used at build time. This incorrect behaviour can be seen by building OVS against one version of DPDK and running it against a later one. Using "ov

Re: [dpdk-dev] [PATCH v2] log: support custom log function

2021-02-05 Thread Dmitry Kozlyuk
On Sat, 6 Feb 2021 01:42:04 +0800, Li Feng wrote: > Currently, the dpdk log is out to stdout/stderr and syslog. > The rte_openlog_stream could set an external FILE* stream, but it asks the > consumer to give it a FILE* pointer. > For C++ or other languages, it's hard to get a libc FILE*. > > Supp

[dpdk-dev] [PATCH] testpmd: remove unused member from lcore structure

2021-02-05 Thread Kathleen Capella
The tx_queue member of the fwd_lcore struct is unused as it is already part of the fwd_stream structure. Deleting helps improve code readability. Signed-off-by: Kathleen Capella Reviewed-by: Honnappa Nagarahalli --- app/test-pmd/testpmd.h | 1 - 1 file changed, 1 deletion(-) diff --git a/app/t

Re: [dpdk-dev] [PATCH v2 2/2] builtools: remove build flag for header includes check

2021-02-05 Thread Thomas Monjalon
04/02/2021 11:26, Bruce Richardson: > On Thu, Feb 04, 2021 at 11:05:20AM +0100, David Marchand wrote: > > Previous patch just removes the last case of direct inclusion of the > > generic/ headers. > > > > Signed-off-by: David Marchand > > --- > Acked-by: Bruce Richardson I think this patch is b

Re: [dpdk-dev] [v3 PATCH] usertools: show an error message if unable to reserve requested hugepages

2021-02-05 Thread Thomas Monjalon
08/01/2021 10:06, Sarosh Arif: > Sometimes the system is unable to reserve the requested hugepages because > enough space is not available in the RAM. In that case, currently the > script displays no error message hence the user can be under the delusion > that the hugepages requested are all succe

Re: [dpdk-dev] [v2 PATCH] usertools: show valid hugepage sizes if user requests an invalid hugepage size

2021-02-05 Thread Thomas Monjalon
02/12/2020 12:06, Sarosh Arif: > If user requests a hugepage size which is not supported by the system, > currently user gets an error message saying that the requested size > is not a valid system huge page size. In addition to this if we display > the valid hugepage sizes it will be convenient fo

Re: [dpdk-dev] [PATCH v2] usertools: show hugepages on POWER systems

2021-02-05 Thread Thomas Monjalon
02/12/2020 21:57, David Christensen: > The IBM PowerNV systems include NUMA nodes that don't have associated > CPUs or hugepage memory. Here is an example on an IBM AC922 system: > > $ lscpu > ... > NUMA node0 CPU(s): 0-63 > NUMA node8 CPU(s): 64-127 > NUMA node252 CPU(s): > ... > > $ numast

Re: [dpdk-dev] [PATCH v3] net/ixgbe: fix UDP zero checksum error

2021-02-05 Thread Paolo Valerio
Hi Haiyue, Haiyue Wang writes: > There is an 82599 errata that UDP frames with a zero checksum are > incorrectly marked as checksum invalid by the hardware. This was > leading to misleading PKT_RX_L4_CKSUM_BAD flag. > > This patch changes the bad UDP checksum to PKT_RX_L4_CKSUM_UNKNOWN, > so th

[dpdk-dev] [PATCH v2] log: support custom log function

2021-02-05 Thread Li Feng
Currently, the dpdk log is out to stdout/stderr and syslog. The rte_openlog_stream could set an external FILE* stream, but it asks the consumer to give it a FILE* pointer. For C++ or other languages, it's hard to get a libc FILE*. Support to set a hook method is another choice for this scenario.

Re: [dpdk-dev] [PATCH v1] license: remove pmdinfogen from exceptions

2021-02-05 Thread Thomas Monjalon
04/02/2021 11:28, John McNamara: > The C based pmdinfogen tool has been replaced by a Python > based tool with a BSD license. As such, we no longer need > to call out a licence exception for pmdinfogen. > > Signed-off-by: John McNamara reporting acks from another thread: Acked-by: Bruce Richards

Re: [dpdk-dev] [PATCH] license: remove exception for old pmdinfogen

2021-02-05 Thread Thomas Monjalon
04/02/2021 11:35, Mcnamara, John: > From: Thomas Monjalon > > > > The C version of pmdinfogen was replaced by a Python implementation. > > The license exception can be removed. > > Ignore my similar version. > > Acked-by: John McNamara Actually I prefer the wording of your version. I keep the

Re: [dpdk-dev] [PATCH] maintainers: update for testpmd

2021-02-05 Thread Thomas Monjalon
04/02/2021 11:27, Ferruh Yigit: > On 2/4/2021 10:04 AM, Bernard Iremonger wrote: > > remove Bernard Iremonger > > remove Wenzhuo Lu > > > > Signed-off-by: Bernard Iremonger > > Acked-by: Ferruh Yigit Applied. Would be nice to find new volunteers to maintain testpmd.

Re: [dpdk-dev] [PATCH] cryptodev: support multiple cipher block sizes

2021-02-05 Thread Zhang, Roy Fan
Hi Matan, It is a good idea to be able to show the varied block sizes of each PMD/algo. > -Original Message- > From: Matan Azrad > Sent: Thursday, February 4, 2021 2:34 PM > To: dev@dpdk.org > Cc: akhil.go...@nxp.com; Doherty, Declan ; > Somalapuram Amaranath ; Ruifeng Wang > ; Ajit Khap

Re: [dpdk-dev] [PATCH] devtools: remove ethdev ABI exception

2021-02-05 Thread Thomas Monjalon
01/02/2021 20:03, Ferruh Yigit: > On 2/1/2021 6:08 PM, David Marchand wrote: > > Now that the ethernet driver dev_ops structure definition is not > > exported anymore, there is no need for an exception. > > abidiff will only consider structures defined in the installed headers > > (passed with --he

Re: [dpdk-dev] [PATCH] mempool: fix invalid panic on dump or audit

2021-02-05 Thread Thomas Monjalon
04/02/2021 14:33, Andrew Rybchenko: > On 2/3/21 12:01 PM, Olivier Matz wrote: > > When doing a mempool dump or an audit, the application can panic because > > the length of the cache is greater than the flush threshold, which is > > seen as a fatal error. But this can temporarily happen when the me

Re: [dpdk-dev] [PATCH] log: support custom log function

2021-02-05 Thread Stephen Hemminger
On Fri, 5 Feb 2021 20:22:36 +0800 Feng Li wrote: > David Marchand 于2021年2月5日周五 下午7:56写道: > > > > On Fri, Feb 5, 2021 at 12:25 PM Li Feng wrote: > > > > > > Currently, the dpdk log is out to stdout/stderr and syslog. > > > We should support to output the log to another please, e.g. file or > >

Re: [dpdk-dev] [PATCH] config: increase default maximum number of NUMA nodes

2021-02-05 Thread Thomas Monjalon
04/02/2021 10:56, Bruce Richardson: > On Wed, Feb 03, 2021 at 10:18:18PM +0100, Thomas Monjalon wrote: > > AMD CPU can present a high number of NUMA nodes. > > The default should be 32 for better compatibility. > > > > Signed-off-by: Thomas Monjalon > > --- > Seems reasonable. > > Acked-by: Bruc

Re: [dpdk-dev] [PATCH] net/mlx5: fix TCP flag field modification

2021-02-05 Thread Slava Ovsiienko
> -Original Message- > From: Alexander Kozyrev > Sent: Friday, February 5, 2021 5:03 > To: dev@dpdk.org > Cc: sta...@dpdk.org; Raslan Darawsheh ; Slava > Ovsiienko ; Matan Azrad ; > Ori Kam > Subject: [PATCH] net/mlx5: fix TCP flag field modification > > Wrong modification field ID is us

Re: [dpdk-dev] [PATCH v4 7/7] examples/vhost_crypto: enhance getopt_long usage

2021-02-05 Thread Zhang, Roy Fan
> -Original Message- > From: Ibtisam Tariq > Sent: Thursday, February 4, 2021 7:34 AM > To: maxime.coque...@redhat.com; Xia, Chenbo ; > Dumitrescu, Cristian ; Singh, Jasvinder > ; Mcnamara, John > ; Pattan, Reshma ; > Ananyev, Konstantin ; Kovacevic, Marko > > Cc: dev@dpdk.org; Ibtisam Ta

Re: [dpdk-dev] [PATCH] log: support custom log function

2021-02-05 Thread Feng Li
David Marchand 于2021年2月5日周五 下午7:56写道: > > On Fri, Feb 5, 2021 at 12:25 PM Li Feng wrote: > > > > Currently, the dpdk log is out to stdout/stderr and syslog. > > We should support to output the log to another please, e.g. file or > > glog. > > Why not use rte_openlog_stream() / rte_log_get_stream(

Re: [dpdk-dev] [PATCH] log: support custom log function

2021-02-05 Thread Feng Li
Li Feng 于2021年2月5日周五 下午7:24写道: > > Currently, the dpdk log is out to stdout/stderr and syslog. > We should support to output the log to another please, e.g. file or > glog. Sorry, sed 's/please/place/g'. > > Signed-off-by: Li Feng > --- > lib/librte_eal/common/eal_private.h | 10 -- > li

[dpdk-dev] Hubspot Users List

2021-02-05 Thread Neca Rivera
Hi, I had a chance to search you on the web and thought to check if you would be interested in acquiring *Hubspot *user’s database? Some of the recently validated user contact details include: InfusionSoft, SharpSpring, Marketo, SEMrush, Adobe Campaign, Pardot, Sendinblue and many more. Pl

Re: [dpdk-dev] [PATCH] log: support custom log function

2021-02-05 Thread Stephen Hemminger
On Fri, 5 Feb 2021 12:55:48 +0100 David Marchand wrote: > On Fri, Feb 5, 2021 at 12:25 PM Li Feng wrote: > > > > Currently, the dpdk log is out to stdout/stderr and syslog. > > We should support to output the log to another please, e.g. file or > > glog. > > Why not use rte_openlog_stream() /

Re: [dpdk-dev] [RFC PATCH v4] build: kni cross-compilation support

2021-02-05 Thread Bruce Richardson
On Fri, Feb 05, 2021 at 04:04:32PM +0100, Juraj Linkeš wrote: > The kni linux module is using a custom target for building, which > doesn't take into account any cross compilation arguments. The arguments > in question are ARCH, CROSS_COMPILE (for gcc, clang) and CC, LD (for > clang). Get those fro

[dpdk-dev] [RFC PATCH v4] build: kni cross-compilation support

2021-02-05 Thread Juraj Linkeš
The kni linux module is using a custom target for building, which doesn't take into account any cross compilation arguments. The arguments in question are ARCH, CROSS_COMPILE (for gcc, clang) and CC, LD (for clang). Get those from the cross file and pass them to the custom target. The user supplie

Re: [dpdk-dev] [RFC PATCH v3] build: kni cross-compilation support

2021-02-05 Thread Juraj Linkeš
> -Original Message- > From: Bruce Richardson > Sent: Friday, February 5, 2021 3:53 PM > To: Juraj Linkeš > Cc: tho...@monjalon.net; ruifeng.w...@arm.com; > honnappa.nagaraha...@arm.com; jerinjac...@gmail.com; > hemant.agra...@nxp.com; ferruh.yi...@intel.com; abo...@pensando.io; > dev@d

Re: [dpdk-dev] [RFC PATCH v3] build: kni cross-compilation support

2021-02-05 Thread Bruce Richardson
On Fri, Feb 05, 2021 at 03:46:37PM +0100, Juraj Linkeš wrote: > The kni linux module is using a custom target for building, which > doesn't take into account any cross compilation arguments. The arguments > in question are ARCH, CROSS_COMPILE (for gcc, clang) and CC, LD (for > clang). Get those fro

[dpdk-dev] [RFC PATCH v3] build: kni cross-compilation support

2021-02-05 Thread Juraj Linkeš
The kni linux module is using a custom target for building, which doesn't take into account any cross compilation arguments. The arguments in question are ARCH, CROSS_COMPILE (for gcc, clang) and CC, LD (for clang). Get those from the cross file and pass them to the custom target. The user supplie

[dpdk-dev] [PATCH] app/testpmd: remove duplicated offload display

2021-02-05 Thread Ferruh Yigit
"show port cap all|" was to display offload configuration of port(s). But later two other commands added to show same information in more accurate way: show port (port_id) rx_offload configuration show port (port_id) tx_offload configuration These new commands can both show port and queue level

Re: [dpdk-dev] [PATCH] log: support custom log function

2021-02-05 Thread Dmitry Kozlyuk
On Fri, 5 Feb 2021 20:22:36 +0800, Feng Li wrote: > David Marchand 于2021年2月5日周五 下午7:56写道: > > > > On Fri, Feb 5, 2021 at 12:25 PM Li Feng wrote: > > > > > > Currently, the dpdk log is out to stdout/stderr and syslog. > > > We should support to output the log to another please, e.g. file or > >

[dpdk-dev] [PATCH] app/testpmd: fix meter commands help strings

2021-02-05 Thread Ferruh Yigit
Helps strings syntax is "command : description", the 'command' part was missing, updated command help strings. Fixes: 281eeb8afc55 ("app/testpmd: add commands for metering and policing") Fixes: 30ffb4e67ee3 ("app/testpmd: add commands traffic metering and policing") Fixes: e63b50162aa3 ("app/testp

Re: [dpdk-dev] [PATCH] net/mlx5: fix Tx queue size adjustment

2021-02-05 Thread Thomas Monjalon
05/02/2021 13:43, Viacheslav Ovsiienko: > The inline data size alignments should be taken into account > either to conform the rdma-core implementation of sending > queue size calculation. > > Fixes: 7e14d144f2ea ("net/mlx5: fix Tx queue size created with DevX") > > Signed-off-by: Viacheslav Ovsi

[dpdk-dev] [PATCH] net/mlx5: fix Tx queue size adjustment

2021-02-05 Thread Viacheslav Ovsiienko
The inline data size alignments should be taken into account either to conform the rdma-core implementation of sending queue size calculation. Fixes: 7e14d144f2ea ("net/mlx5: fix Tx queue size created with DevX") Signed-off-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5_devx.c | 13

[dpdk-dev] [PATCH] doc: fix mark action zero value description in mlx5 guide

2021-02-05 Thread Viacheslav Ovsiienko
The zero value in flow MARK action is reported in Rx datapath as tagged with zero FDIR ID. Once packet is marked in flow engine it will be always reported as tagged. For metadata only the zero value means there is "no metadata" in the packet and the metadata flag is not set for the case. Fixes: 3c

Re: [dpdk-dev] [PATCH] log: support custom log function

2021-02-05 Thread David Marchand
On Fri, Feb 5, 2021 at 12:25 PM Li Feng wrote: > > Currently, the dpdk log is out to stdout/stderr and syslog. > We should support to output the log to another please, e.g. file or > glog. Why not use rte_openlog_stream() / rte_log_get_stream() ? -- David Marchand

Re: [dpdk-dev] [PATCH] net/ionic: fix Tx fragment limits

2021-02-05 Thread Ferruh Yigit
On 2/4/2021 8:37 PM, Andrew Boyer wrote: The reported nb_seg_max should include the main fragment in the descriptor and the fragments in the accompanying SGL. Update the Tx prep check as well. These were missed when updating to the v1 Tx queue structures. Fixes: 786c64763b50 ("net/ionic: clean

[dpdk-dev] [PATCH] log: support custom log function

2021-02-05 Thread Li Feng
Currently, the dpdk log is out to stdout/stderr and syslog. We should support to output the log to another please, e.g. file or glog. Signed-off-by: Li Feng --- lib/librte_eal/common/eal_private.h | 10 -- lib/librte_eal/include/rte_eal.h| 22 ++ lib/librte_eal/li

Re: [dpdk-dev] [PATCH] net/enic: fix a typo in debug message

2021-02-05 Thread Ferruh Yigit
On 2/5/2021 1:35 AM, Hyong Youb Kim wrote: A debug message for filter API is using a wrong flag. Use the correct one. Fixes: 936a9b9975e7 ("net/enic: flow API debug") Cc: sta...@dpdk.org Reported-by: Hanoch Haim Signed-off-by: Hyong Youb Kim Reviewed-by: John Daley Applied to dpdk-next-net

Re: [dpdk-dev] [RFC PATCH v2] build: kni cross-compilation support

2021-02-05 Thread Thomas Monjalon
05/02/2021 10:38, Bruce Richardson: > On Fri, Feb 05, 2021 at 09:26:05AM +, Juraj Linkeš wrote: > > From: Bruce Richardson > > > The block for cross-compiling is fairly large and complex, so I'm > > > wondering how > > > we can simplify things a bit. If we had multiple kernel modules I'd > >

Re: [dpdk-dev] [RFC PATCH v2] build: kni cross-compilation support

2021-02-05 Thread Bruce Richardson
On Fri, Feb 05, 2021 at 09:26:05AM +, Juraj Linkeš wrote: > > > > -Original Message- > > From: Bruce Richardson > > Sent: Thursday, February 4, 2021 6:34 PM > > To: Juraj Linkeš > > Cc: tho...@monjalon.net; ruifeng.w...@arm.com; > > honnappa.nagaraha...@arm.com; jerinjac...@gmail.co

Re: [dpdk-dev] [RFC PATCH v2] build: kni cross-compilation support

2021-02-05 Thread Bruce Richardson
On Fri, Feb 05, 2021 at 09:26:05AM +, Juraj Linkeš wrote: > > > > -Original Message- > > From: Bruce Richardson > > Sent: Thursday, February 4, 2021 6:34 PM > > To: Juraj Linkeš > > Cc: tho...@monjalon.net; ruifeng.w...@arm.com; > > honnappa.nagaraha...@arm.com; jerinjac...@gmail.co

Re: [dpdk-dev] [PATCH v5 0/9] ethdev: support SubFunction representor

2021-02-05 Thread Andrew Rybchenko
On 2/5/21 12:13 PM, Xueming(Steven) Li wrote: > >> -Original Message- >> From: Andrew Rybchenko >> Sent: Friday, February 5, 2021 3:35 PM >> To: Xueming(Steven) Li >> Cc: dev@dpdk.org; Slava Ovsiienko ; Asaf Penso >> ; Thomas Monjalon >> >> Subject: Re: [dpdk-dev] [PATCH v5 0/9] ethdev

Re: [dpdk-dev] [RFC PATCH v2] build: kni cross-compilation support

2021-02-05 Thread Juraj Linkeš
> -Original Message- > From: Bruce Richardson > Sent: Thursday, February 4, 2021 6:34 PM > To: Juraj Linkeš > Cc: tho...@monjalon.net; ruifeng.w...@arm.com; > honnappa.nagaraha...@arm.com; jerinjac...@gmail.com; > hemant.agra...@nxp.com; ferruh.yi...@intel.com; abo...@pensando.io; > dev

Re: [dpdk-dev] [PATCH v5 0/9] ethdev: support SubFunction representor

2021-02-05 Thread Xueming(Steven) Li
>-Original Message- >From: Andrew Rybchenko >Sent: Friday, February 5, 2021 3:35 PM >To: Xueming(Steven) Li >Cc: dev@dpdk.org; Slava Ovsiienko ; Asaf Penso >; Thomas Monjalon > >Subject: Re: [dpdk-dev] [PATCH v5 0/9] ethdev: support SubFunction representor > >On 2/4/21 5:15 PM, Xueming(

[dpdk-dev] [PATCH] net/mlx5/linux: fix missing firmware version copying

2021-02-05 Thread Kamil Vojanec
This patch fixes a bug where firmware version was not copied from ibv_device_attr structure into mlx5_dev_attr structure, resulting in inability to read firmware version. Signed-off-by: Kamil Vojanec --- drivers/net/mlx5/linux/mlx5_os.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers