[dpdk-dev] [Bug 554] shutdown_api/test_change_thresholds: Port config all rxpt, rxht, rxwt are invalid

2021-01-28 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=554 Zhang, RobinX (robinx.zh...@intel.com) changed: What|Removed |Added Resolution|--- |WONTFIX C

Re: [dpdk-dev] [PATCH v12 4/4] examples/ifpga: add example for ifpga opae API

2021-01-28 Thread Huang, Wei
Hi, -Original Message- From: Ferruh Yigit Sent: Thursday, January 28, 2021 21:35 To: Huang, Wei ; dev@dpdk.org; Xu, Rosen ; Zhang, Qi Z Cc: sta...@dpdk.org; Zhang, Tianfei Subject: Re: [dpdk-dev] [PATCH v12 4/4] examples/ifpga: add example for ifpga opae API On 1/26/2021 6:45 AM, We

Re: [dpdk-dev] [dpdk-stable] [PATCH v12 3/4] raw/ifpga: add fpga helper function

2021-01-28 Thread Huang, Wei
Hi, -Original Message- From: Ferruh Yigit Sent: Thursday, January 28, 2021 21:30 To: Huang, Wei ; dev@dpdk.org; Xu, Rosen ; Zhang, Qi Z Cc: sta...@dpdk.org; Zhang, Tianfei Subject: Re: [dpdk-stable] [PATCH v12 3/4] raw/ifpga: add fpga helper function On 1/26/2021 6:45 AM, Wei Huang w

Re: [dpdk-dev] [PATCH v12 1/4] raw/ifpga: add fpga rsu function

2021-01-28 Thread Huang, Wei
-Original Message- From: Ferruh Yigit Sent: Thursday, January 28, 2021 21:25 To: Huang, Wei ; dev@dpdk.org; Xu, Rosen ; Zhang, Qi Z Cc: sta...@dpdk.org; Zhang, Tianfei ; Ray Kinsella ; Hemant Agrawal Subject: Re: [dpdk-dev] [PATCH v12 1/4] raw/ifpga: add fpga rsu function On 1/26/2

[dpdk-dev] How to Enable Mellanox Driver Compilation with DPDK20.11

2021-01-28 Thread Truring Team
Hi Team , Can someone help me to figure out how to enable the Mellanox Driver flag in meson.build file , so that dpdk 20.11 compiles with mlx driver enabled. Best Regards Puneet

Re: [dpdk-dev] [PATCH] net/bnxt: fix mbuf flags for PTP packets

2021-01-28 Thread Ajit Khaparde
On Wed, Jan 27, 2021 at 7:30 PM Kalesh A P wrote: > > From: Kalesh AP > > Commit "899f06130724" broke the update of mbuf flags for PTP packets. > "mbuf->ol_flags" is overwritten in bnxt_set_ol_flags() function. > > Fixes: 899f06130724 ("net/bnxt: add Rx logic for 58818 chips") > > Signed-off-by:

[dpdk-dev] [PATCH v3 3/3] ring: refactor ring library

2021-01-28 Thread Feifei Wang
For legacy modes, rename ring_generic/c11 to ring_generic/c11_pvt. Furthermore, add new file ring_elem_pvt.h which includes ring_do_eq/deq and ring element copy/delete APIs. For other modes, rename xx_c11_mem to xx_elem_pvt. Move all private APIs into these new header files. Finally, the external

[dpdk-dev] [PATCH v3 2/3] ring: add rte prefix before update tail API

2021-01-28 Thread Feifei Wang
Add __rte prefix before update_tail API because it is a internal function. Signed-off-by: Feifei Wang Reviewed-by: Honnappa Nagarahalli Reviewed-by: Ruifeng Wang Acked-by: Konstantin Ananyev --- lib/librte_ring/rte_ring_c11_mem.h | 4 ++-- lib/librte_ring/rte_ring_elem.h| 4 ++-- lib/libr

[dpdk-dev] [PATCH v3 1/3] test/ring: reduce iteration numbers to make test duration shorter

2021-01-28 Thread Feifei Wang
When testing ring performance in the case that multiple lcores are mapped to the same physical core, e.g. --lcores '(0-3)@10', it takes a very long time to wait for the "enqueue_dequeue_bulk_helper" to finish. This is because too much iteration numbers and extremely low efficiency for enqueue and d

[dpdk-dev] [PATCH v3 0/3] refactoring ring library

2021-01-28 Thread Feifei Wang
Do some work for ring refactoring, which includes: 1. add rte prefix before update tail API 2. Move all private APIs into new header files v2: 1. add rte_ prefixes for private files (Konstantin) v3: 1. fix compile issue of file name bug Feifei Wang (3): test/ring: reduce iteration numbers to m

Re: [dpdk-dev] [PATCH] net/i40e: fix X722 FDIR field mask

2021-01-28 Thread Zhang, AlvinX
Hi Beilei, > -Original Message- > From: Xing, Beilei > Sent: Friday, January 29, 2021 11:34 AM > To: Zhang, AlvinX ; Guo, Jia ; > Zhang, Qi Z > Cc: dev@dpdk.org > Subject: RE: [PATCH] net/i40e: fix X722 FDIR field mask > > > > > -Original Message- > > From: Zhang,Alvin > > Se

Re: [dpdk-dev] [PATCH v1 1/2] app/test: remove unnecessary barriers for ring stress test

2021-01-28 Thread Stephen Hemminger
On Fri, 29 Jan 2021 03:17:50 + Honnappa Nagarahalli wrote: > > > > > > > > > > > > Hi Feifei, > > > > > > > > > > > > > > The variable "wrk_cmd" is a signal to control threads from running > > > > > and stopping. When worker lcores load "wrk_cmd == > > WRK_CMD_RUN", > > > > > they

Re: [dpdk-dev] [PATCH] net/i40e: fix X722 FDIR field mask

2021-01-28 Thread Zhou, JunX W
Tested-by: Zhou, Jun -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Zhang,Alvin Sent: Friday, January 29, 2021 10:09 AM To: Guo, Jia ; Xing, Beilei ; Zhang, Qi Z Cc: dev@dpdk.org Subject: [dpdk-dev] [PATCH] net/i40e: fix X722 FDIR field mask From: Alvin Zhang

Re: [dpdk-dev] [PATCH] net/i40e: fix X722 FDIR field mask

2021-01-28 Thread Zhang, AlvinX
Hi Beilei, Thanks for your review. In theory, RSS does have the same issue, but in fact, there is no command to set the mask bit of these field when configuring RSS. BR, Alvin > -Original Message- > From: Xing, Beilei > Sent: Friday, January 29, 2021 11:34 AM > To: Zhang, AlvinX ; Gu

Re: [dpdk-dev] [PATCH] net/i40e: fix X722 FDIR field mask

2021-01-28 Thread Xing, Beilei
> -Original Message- > From: Zhang,Alvin > Sent: Friday, January 29, 2021 10:09 AM > To: Guo, Jia ; Xing, Beilei ; Zhang, > Qi Z > Cc: dev@dpdk.org > Subject: [PATCH] net/i40e: fix X722 FDIR field mask > > From: Alvin Zhang > > The absolute field offsets of IPv4 or IPv6 header are r

Re: [dpdk-dev] [PATCH v6 0/2] support both PIO and MMIO BAR for legacy device in virtio PMD

2021-01-28 Thread 谢华伟(此时此刻)
Hi ferruh and maxime: v6 changes: send v6. Let us discuss if merge in this or early next release. Sorry that forget to reply to previous message id. - change to DEBUG level for IO bar detection in pci_uio_ioport_map - rework the code in iobar branch - fixes commit message forma

[dpdk-dev] [PATCH v6 2/2] bus/pci: support MMIO in PCI ioport accessors

2021-01-28 Thread 谢华伟(此时此刻)
From: "huawei.xhw" With IO BAR, we get PIO(programmed IO) address. With MMIO BAR, we get mapped virtual address. We distinguish PIO(Programmed IO) and MMIO(memory mapped IO) by their address like how kernel does. ioread/write8/16/32 is provided to access PIO/MMIO. By the way, for virtio on arch

[dpdk-dev] [PATCH v6 1/2] bus/pci: use PCI standard sysfs entry to get PIO address

2021-01-28 Thread 谢华伟(此时此刻)
From: "huawei.xhw" Currently virtio PMD asssumes legacy device uses PIO bar. There are three ways to get PIO(PortIO) address for virtio legacy device. under igb_uio, get pio address from uio/uio# sysfs attribute under uio_pci_generic: for X86, get PIO address from /proc/ioport

[dpdk-dev] [PATCH v6 0/2] support both PIO and MMIO BAR for legacy device in virtio PMD

2021-01-28 Thread 谢华伟(此时此刻)
From: "huawei.xhw" virtio PMD assumes legacy device only supports PIO BAR resource. This is wrong. As we need to create lots of devices, as PIO resource on x86 is very limited, we expose MMIO(memory IO) BAR. Kernel supports both PIO and MMIO BAR for legacy virtio-pci device, and for all other

Re: [dpdk-dev] [PATCH v1 1/2] app/test: remove unnecessary barriers for ring stress test

2021-01-28 Thread Honnappa Nagarahalli
> > > > > > > Hi Feifei, > > > > > > > > > > > The variable "wrk_cmd" is a signal to control threads from running > > > > and stopping. When worker lcores load "wrk_cmd == > WRK_CMD_RUN", > > > > they > > > start > > > > running and when worker lcores load "wrk_cmd == WRK_CMD_STOP", > > > they >

Re: [dpdk-dev] ixgbe and UDP with zero checksum

2021-01-28 Thread Wang, Haiyue
Hi Paolo, > -Original Message- > From: Wang, Haiyue > Sent: Friday, January 29, 2021 10:02 > To: Paolo Valerio > Cc: Guo, Jia ; Aaron Conole ; > dev@dpdk.org > Subject: RE: ixgbe and UDP with zero checksum > > > -Original Message- > > From: Paolo Valerio > > Sent: Thursday, Jan

Re: [dpdk-dev] [PATCH v2] net/iavf: fix vector mapping with queue

2021-01-28 Thread Zhang, Qi Z
> -Original Message- > From: dev On Behalf Of Jingjing Wu > Sent: Thursday, January 28, 2021 11:00 PM > To: dev@dpdk.org > Cc: Wu, Jingjing ; Xing, Beilei > ; > sta...@dpdk.org > Subject: [dpdk-dev] [PATCH v2] net/iavf: fix vector mapping with queue > > Fix the vector mapping with que

[dpdk-dev] [PATCH] net/i40e: fix X722 FDIR field mask

2021-01-28 Thread Zhang,Alvin
From: Alvin Zhang The absolute field offsets of IPv4 or IPv6 header are related to hardware configuration. The X710 and X722 have different hardware configurations, and users can even modify the hardware configuration. Therefore, The default values cannot be used when calculating mask offset. co

Re: [dpdk-dev] ixgbe and UDP with zero checksum

2021-01-28 Thread Wang, Haiyue
> -Original Message- > From: Paolo Valerio > Sent: Thursday, January 28, 2021 05:35 > To: Wang, Haiyue > Cc: Guo, Jia ; Aaron Conole ; > dev@dpdk.org > Subject: RE: ixgbe and UDP with zero checksum > > "Wang, Haiyue" writes: > > > Hi Paolo, > > > >> -Original Message- > >> Fro

[dpdk-dev] [PATCH] net/i40e: fix X722 FDIR field mask

2021-01-28 Thread Zhang,Alvin
From: Alvin Zhang The absolute field offsets of IPv4 or IPv6 header are related to hardware configuration. The X710 and X722 have different hardware configurations, and users can even modify the hardware configuration. Therefore, The default values cannot be used when calculating mask offset. co

Re: [dpdk-dev] [PATCH 14/14] net/hns3: support LSC event report

2021-01-28 Thread oulijun
在 2021/1/29 7:41, Ferruh Yigit 写道: On 1/22/2021 10:18 AM, Lijun Ou wrote: From: Chengwen Feng This patch support LSC(Link Status Change) event report. There is a user config for lsc, 'dev->data->dev_conf.intr_conf.lsc', which seems not taken into account. Frist of all, thank you for yo

Re: [dpdk-dev] [PATCH v5] app/testpmd: fix setting maximum packet length

2021-01-28 Thread Lance Richardson
On Tue, Jan 26, 2021 at 6:01 AM Ferruh Yigit wrote: > > On 1/26/2021 3:45 AM, Lance Richardson wrote: > > On Mon, Jan 25, 2021 at 7:44 PM Ferruh Yigit wrote: > >> > + if (rx_offloads != port->dev_conf.rxmode.offloads) { > + uint16_t qid; > + > +

Re: [dpdk-dev] [PATCH v2 4/5] doc: update release notes for hns3

2021-01-28 Thread oulijun
在 2021/1/28 22:46, Ferruh Yigit 写道: On 1/28/2021 12:43 PM, Lijun Ou wrote: Add TM(Traffic Management) feature with hns3 in release notes. It includes: 1. configure port's peak rate with PF 2. configure TC's peak rate with PF Fixes: c09c7847d892 ("net/hns3: support traffic management") Cc: st

Re: [dpdk-dev] [PATCH v2 2/5] net/hns3: add FEC feature for hns3.ini

2021-01-28 Thread oulijun
在 2021/1/28 22:12, Thomas Monjalon 写道: 28/01/2021 13:43, Lijun Ou: The hns3 PMD add FEC features implementation in 20.11. Therefore, need to update the hns3.ini for supporting. Fixes: 9bf2ea8dbc65 ("net/hns3: support FEC") Cc: sta...@dpdk.org Signed-off-by: Lijun Ou --- doc/guides/nics/f

[dpdk-dev] [PATCH v6 12/12] net/octeontx_ep: transmit data path function added

2021-01-28 Thread Nalla Pradeep
1. Packet transmit function for both otx and otx2 are added. 2. Flushing transmit(command) queue when pending commands are more than maximum allowed value (currently 16). 3. Scatter gather support if the packet spans multiple buffers. Signed-off-by: Nalla Pradeep --- drivers/net/octeontx_ep/o

[dpdk-dev] [PATCH v6 10/12] net/octeontx_ep: added dev start and stop

2021-01-28 Thread Nalla Pradeep
Dev start and stop operations are added. To accomplish this internal functions to enable or disable io queues are incorporated. Signed-off-by: Nalla Pradeep --- drivers/net/octeontx_ep/otx2_ep_vf.c| 107 drivers/net/octeontx_ep/otx_ep_common.h | 8 ++ drivers/net/octeo

[dpdk-dev] [PATCH v6 09/12] net/octeontx_ep: setting up iq and oq registers

2021-01-28 Thread Nalla Pradeep
Configuring hardware registers with command queue(iq) and driver output queue(oq) parameters. List of parameters configured for IQ after making sure it is idle 1. Base address 2. Instruction size 3. Disabling interrupts for fastpath List of parameters configured for OQ after making sure it is idle

[dpdk-dev] [PATCH v6 11/12] net/octeontx_ep: receive data path function added

2021-01-28 Thread Nalla Pradeep
Function to deliver packets from DROQ to application is added. It also fills DROQ with receive buffers timely such that device can fill them with incoming packets. Signed-off-by: Nalla Pradeep --- drivers/net/octeontx_ep/otx_ep_common.h | 1 + drivers/net/octeontx_ep/otx_ep_ethdev.c | 3 + d

[dpdk-dev] [PATCH v6 02/12] net/octeontx_ep: add build and doc infrastructure

2021-01-28 Thread Nalla Pradeep
Adding bare minimum PMD library and doc build infrastructure and claim the maintainership for octeontx end point PMD. Signed-off-by: Nalla Pradeep --- MAINTAINERS | 9 doc/guides/nics/features/octeontx_ep.ini | 10 + doc/guides/nics/index.rst

[dpdk-dev] [PATCH v6 07/12] net/octeontx_ep: added rxq setup and release

2021-01-28 Thread Nalla Pradeep
Receive queue setup involves allocating memory for the queue, initializing data structure representing the queue and filling queue with receive buffers of rx descriptor count. Receive queues are referred as droq. Hardware fills the receive buffers in queue with the packet. In receive queue release

[dpdk-dev] [PATCH v6 08/12] net/octeontx_ep: added tx queue setup and release

2021-01-28 Thread Nalla Pradeep
Transmit queue setup involves allocating memory for the command queue considering tx descriptor count and initializing data structure representing the queue. Transmit queue release function frees the command queue. Signed-off-by: Nalla Pradeep --- drivers/net/octeontx_ep/otx_ep_common.h | 88 ++

[dpdk-dev] [PATCH v6 05/12] net/octeontx_ep: added basic device setup

2021-01-28 Thread Nalla Pradeep
Functions to setup device, basic input queue and output queue registers are added. Signed-off-by: Nalla Pradeep --- drivers/net/octeontx_ep/meson.build | 2 + drivers/net/octeontx_ep/otx2_ep_vf.c| 131 + drivers/net/octeontx_ep/otx2_ep_vf.h| 11 ++ drivers/net/

[dpdk-dev] [PATCH v6 06/12] net/octeontx_ep: add dev info get and configure

2021-01-28 Thread Nalla Pradeep
Add device information get and device configure operations. Signed-off-by: Nalla Pradeep --- doc/guides/nics/features/octeontx_ep.ini | 1 + drivers/net/octeontx_ep/otx_ep_common.h | 14 drivers/net/octeontx_ep/otx_ep_ethdev.c | 81 +++- drivers/net/octeontx_ep/otx_ep

[dpdk-dev] [PATCH v6 04/12] net/octeontx_ep: add device init and uninit

2021-01-28 Thread Nalla Pradeep
Add basic init and uninit function which includes initializing fields of ethdev private structure. Signed-off-by: Nalla Pradeep --- drivers/net/octeontx_ep/otx_ep_common.h | 24 +++- drivers/net/octeontx_ep/otx_ep_ethdev.c | 75 +++-- 2 files changed, 93 insertions(+), 6

[dpdk-dev] [PATCH v6 03/12] net/octeontx_ep: add ethdev probe and remove

2021-01-28 Thread Nalla Pradeep
add basic PCIe ethdev probe and remove. Signed-off-by: Nalla Pradeep --- drivers/common/octeontx2/otx2_common.h | 2 + drivers/net/octeontx_ep/meson.build | 2 + drivers/net/octeontx_ep/otx_ep_common.h | 14 +++ drivers/net/octeontx_ep/otx_ep_ethdev.c | 56 + d

[dpdk-dev] [PATCH v6 01/12] raw/octeontx_ep: changed device id

2021-01-28 Thread Nalla Pradeep
Device id to be probed by octeontx_ep raw device pmd is changed from B203 to B204. B203 is for octeontx_ep net device pmd to probe. Signed-off-by: Nalla Pradeep --- drivers/common/octeontx2/otx2_common.h| 3 ++- drivers/raw/octeontx2_ep/otx2_ep_rawdev.c | 6 +++--- 2 files changed, 5 inserti

[dpdk-dev] [PATCH v6 00/12] Octeon Tx/Tx2 Endpoint pmd

2021-01-28 Thread Nalla Pradeep
v2: Fixed review comments from sburla at marvell v3: Fixed review comments from jerinj at marvell v4: Fixed MAITAINERS file v5: Fixed review comments from Ferruh yigit at intel v6: Created separate patch for octeontx_ep raw driver changes. Used pmd specific log types instead of 'RTE_LOG

Re: [dpdk-dev] [PATCH 00/14] Misc updates for hns3

2021-01-28 Thread Ferruh Yigit
On 1/22/2021 10:18 AM, Lijun Ou wrote: This series add a new feature LSC event report and two bugfixes as well as some cleanup patches. Chengchang Tang (2): net/hns3: reconstruct the Rx interrupt map net/hns3: fix interrupt resources in Rx interrupt mode Chengwen Feng (1): net/hns3: su

Re: [dpdk-dev] [PATCH 14/14] net/hns3: support LSC event report

2021-01-28 Thread Ferruh Yigit
On 1/22/2021 10:18 AM, Lijun Ou wrote: From: Chengwen Feng This patch support LSC(Link Status Change) event report. There is a user config for lsc, 'dev->data->dev_conf.intr_conf.lsc', which seems not taken into account. Also 'RTE_PCI_DRV_INTR_LSC' should be set in 'rte_pci_driver.drv_flag

Re: [dpdk-dev] [dpdk-stable] [PATCH v4 3/6] power: rename public structs

2021-01-28 Thread Thomas Monjalon
21/01/2021 18:21, David Hunt: > --- a/lib/librte_power/version.map > +++ b/lib/librte_power/version.map > + # added in 21.02 > + rte_power_guest_channel_receive_msg; > + rte_power_guest_channel_send_msg; This should be in the previous patch otherwise it does not compile.

Re: [dpdk-dev] [PATCH] app/testpmd: fix the sample RSS issue

2021-01-28 Thread Ferruh Yigit
On 1/26/2021 3:49 AM, Jiawei Wang wrote: When the RSS with null key was set in sample actions list, it caused the segmentation fault since the RSS key pointer was NULL while did the memory copy. This patch adds the RSS key NULL pointer checking before copying to fix the segmentation fault issue.

Re: [dpdk-dev] [PATCH v1] power: vm power manager should respect core mask

2021-01-28 Thread Thomas Monjalon
15/01/2021 13:52, David Hunt: > when vm_power_manager is started, it takes over power management on > all cores. This should be limited to cores defined in the core mask. > > When initialising, if a core is not on the coremask, skip it. Applies > to both initialisation and exit. > > Signed-off-by

Re: [dpdk-dev] [dpdk-stable] [PATCH v5] app/testpmd: fix setting maximum packet length

2021-01-28 Thread Ferruh Yigit
On 1/28/2021 9:36 PM, Lance Richardson wrote: On Tue, Jan 26, 2021 at 6:01 AM Ferruh Yigit wrote: On 1/26/2021 3:45 AM, Lance Richardson wrote: On Mon, Jan 25, 2021 at 7:44 PM Ferruh Yigit wrote: + if (rx_offloads != port->dev_conf.rxmode.offloads) { + uint16_t qid; +

Re: [dpdk-dev] [PATCH] buildtools: fix archive extraction for LLVM 8

2021-01-28 Thread Thomas Monjalon
28/01/2021 20:05, Dmitry Kozlyuk: > "llvm-ar xv lib.a" from LLVM 8 doesn't print extracted object file > names. The effect of "v" is not formally specified either. > Use "llvm-ar t" to get archive member names. > > Reported-by: XuemingX Zhang > > Signed-off-by: Dmitry Kozlyuk Applied, thanks

Re: [dpdk-dev] [PATCH v3 0/2] fix mingw build error

2021-01-28 Thread Thomas Monjalon
28/01/2021 13:28, David Marchand: > On Wed, Jan 27, 2021 at 3:47 PM Leyi Rong wrote: > > > > This patchset fix mingw build error when avx512 is introduced. > > > > --- > > v2: > > - Set i40e_avx512_cc_support to false to avoid the build error under > > windows with mingw. > > > > Leyi Rong (2):

Re: [dpdk-dev] [PATCH v3 0/3] AVX512 vPMD on i40e

2021-01-28 Thread Thomas Monjalon
28/01/2021 21:35, Dmitry Kozlyuk: > On Tue, 26 Jan 2021 16:51:19 +, Ferruh Yigit wrote: > > On 1/26/2021 4:48 PM, Thomas Monjalon wrote: > > > 26/01/2021 17:39, Ferruh Yigit: > > >> On 1/26/2021 4:22 PM, Thomas Monjalon wrote: > > >>> 26/01/2021 17:17, Rong, Leyi: > > >> On 1/20/2021

[dpdk-dev] [Bug 619] i40e build on windows broken

2021-01-28 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=619 Thomas Monjalon (tho...@monjalon.net) changed: What|Removed |Added CC||tho...@monjalon.net

Re: [dpdk-dev] [PATCH v3 0/3] AVX512 vPMD on i40e

2021-01-28 Thread Dmitry Kozlyuk
On Tue, 26 Jan 2021 16:51:19 +, Ferruh Yigit wrote: > On 1/26/2021 4:48 PM, Thomas Monjalon wrote: > > 26/01/2021 17:39, Ferruh Yigit: > >> On 1/26/2021 4:22 PM, Thomas Monjalon wrote: > >>> 26/01/2021 17:17, Rong, Leyi: > >> On 1/20/2021 11:21 PM, Ferruh Yigit wrote: > >> > >

Re: [dpdk-dev] [PATCH] net/octeontx: fix max Rx packet length corruption

2021-01-28 Thread Harman Kalra
On Tue, Jan 26, 2021 at 02:22:43PM +0530, sk...@marvell.com wrote: > From: Sunil Kumar Kori > > Maximum Rx packet length is getting updated twice which > corrupts actual value. > > Fixes: 3151e6a687a3 ("net/octeontx: support MTU") > Cc: sta...@dpdk.org > > Signed-off-by: Sunil Kumar Kori Than

[dpdk-dev] [PATCH] examples/pipeline: fix CLI segfault

2021-01-28 Thread Cristian Dumitrescu
Cannot dereference pointer for token[1] unless valid. Fixes: 5074e1d551 ("examples/pipeline: add configuration commands") Cc: sta...@dpdk.org Signed-off-by: Cristian Dumitrescu --- examples/pipeline/cli.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/pipeline/cli.

[dpdk-dev] [PATCH] buildtools: fix archive extraction for LLVM 8

2021-01-28 Thread Dmitry Kozlyuk
"llvm-ar xv lib.a" from LLVM 8 doesn't print extracted object file names. The effect of "v" is not formally specified either. Use "llvm-ar t" to get archive member names. Reported-by: XuemingX Zhang Signed-off-by: Dmitry Kozlyuk --- buildtools/gen-pmdinfo-cfile.py | 11 ++- 1 file chan

[dpdk-dev] [PATCH] port: add ring SWX port

2021-01-28 Thread Cristian Dumitrescu
Add the ring input/output port type for the SWX pipeline. Signed-off-by: Cristian Dumitrescu --- doc/api/doxy-api-index.md | 1 + examples/pipeline/cli.c | 131 examples/pipeline/obj.c | 76 +++ examples/pipeline/obj.h | 21 ++ l

Re: [dpdk-dev] [PATCH v6 8/8] ci: add checking of includes to CI builds

2021-01-28 Thread Bruce Richardson
On Thu, Jan 28, 2021 at 11:41:44AM +, Bruce Richardson wrote: > On Thu, Jan 28, 2021 at 12:12:44PM +0100, Thomas Monjalon wrote: > > 27/01/2021 18:33, Bruce Richardson: > > > For CI builds, turn on the checking of includes. > > > > > > Signed-off-by: Bruce Richardson Acked-by: > > > Aaron Con

Re: [dpdk-dev] [PATCH] [RFC, v2]: adds support PPS(packet per second) on meter

2021-01-28 Thread Ferruh Yigit
On 1/25/2021 1:20 AM, Li Zhang wrote: Currently the flow Meter algorithms in rte_flow only supports bytes per second(BPS). Such as Single Rate Three Color Marker (srTCM rfc2697) This RFC adds the packet per second definition in Meter algorithms structure, to support the rte_mtr APIs with type srT

Re: [dpdk-dev] [PATCH] net/mlx5: fix 32-bit arch compilation issue

2021-01-28 Thread Ferruh Yigit
On 1/28/2021 5:10 PM, Alexander Kozyrev wrote: There is a "cast to pointer from integer of different size" compilation failure on 32-bit machines introduced by the RTE_FLOW_ACTION_TYPE_MODIFY_FIELD implementation in mlx5 PMD. Cast the specified value to be used as RTE_FLOW_FIELD_POINTER to a poi

Re: [dpdk-dev] [PATCH 1/1] net/pcap: imissed stats support

2021-01-28 Thread Ferruh Yigit
On 1/25/2021 5:58 PM, Ido Goshen wrote: Signed-off-by: Ido Goshen <...> @@ -695,6 +708,10 @@ eth_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats) stats->q_ibytes[i] = internal->rx_queue[i].rx_stat.bytes; rx_packets_total += stats->q_ipackets[i]

Re: [dpdk-dev] [PATCH 1/1] net/pcap: imissed stats support

2021-01-28 Thread Ferruh Yigit
On 1/25/2021 5:58 PM, Ido Goshen wrote: Signed-off-by: Ido Goshen --- drivers/net/pcap/rte_eth_pcap.c | 20 1 file changed, 20 insertions(+) diff --git a/drivers/net/pcap/rte_eth_pcap.c b/drivers/net/pcap/rte_eth_pcap.c index a32b1f3f3..83e208514 100644 --- a/drivers/net

Re: [dpdk-dev] [dpdk-techboard] [PATCH v6 2/8] eal: fix error attribute use for clang

2021-01-28 Thread Bruce Richardson
On Thu, Jan 28, 2021 at 05:46:16PM +0100, Thomas Monjalon wrote: > 28/01/2021 16:16, Bruce Richardson: > > On Thu, Jan 28, 2021 at 02:16:10PM +, Bruce Richardson wrote: > > > On Thu, Jan 28, 2021 at 02:36:25PM +0100, David Marchand wrote: > > > > On Thu, Jan 28, 2021 at 12:20 PM Bruce Richardso

Re: [dpdk-dev] [PATCH v6 6/8] buildtools/chkincs: add app to verify header includes

2021-01-28 Thread Bruce Richardson
On Thu, Jan 28, 2021 at 12:31:20PM +0100, David Marchand wrote: > On Thu, Jan 28, 2021 at 12:27 PM Bruce Richardson > wrote: > > > > +# some ethdev headers depend on bus headers > > > > +includes = include_directories('../../drivers/bus/pci', > > > > + '../../drivers/bus/vdev') > > > > > > e

[dpdk-dev] [PATCH] net/mlx5: fix 32-bit arch compilation issue

2021-01-28 Thread Alexander Kozyrev
There is a "cast to pointer from integer of different size" compilation failure on 32-bit machines introduced by the RTE_FLOW_ACTION_TYPE_MODIFY_FIELD implementation in mlx5 PMD. Cast the specified value to be used as RTE_FLOW_FIELD_POINTER to a pointer with an appropriate size suited for underlyi

[dpdk-dev] [PATCH v3] bus/pci: nvme on Windows requires class id and bus

2021-01-28 Thread Nick Connolly
Attaching to an NVMe disk on Windows using SPDK requires the PCI class ID and device.bus fields. Decode the class ID from the PCI device info strings if it is present and set device.bus. Signed-off-by: Nick Connolly --- v3: * Put version history at top - v2 mistakenly had it after the diffs v2:

[dpdk-dev] [PATCH v2] bus/pci: nvme on Windows requires class id and bus

2021-01-28 Thread Nick Connolly
Attaching to an NVMe disk on Windows using SPDK requires the PCI class ID and device.bus fields. Decode the class ID from the PCI device info strings if it is present and set device.bus. Signed-off-by: Nick Connolly --- drivers/bus/pci/windows/pci.c | 15 ++- 1 file changed, 14 inser

Re: [dpdk-dev] [PATCH v5 11/11] net/octeontx_ep: transmit data path function added

2021-01-28 Thread Ferruh Yigit
On 1/28/2021 3:22 PM, Nalla Pradeep wrote: 1. Packet transmit function for both otx and otx2 are added. 2. Flushing transmit(command) queue when pending commands are more than maximum allowed value (currently 16). 3. Scatter gather support if the packet spans multiple buffers. Signed-off-by:

Re: [dpdk-dev] [PATCH v5 10/11] net/octeontx_ep: receive data path function added

2021-01-28 Thread Ferruh Yigit
On 1/28/2021 3:22 PM, Nalla Pradeep wrote: Function to deliver packets from DROQ to application is added. It also fills DROQ with receive buffers timely such that device can fill them with incoming packets. Signed-off-by: Nalla Pradeep <...> +/* Check for response arrival from OCTEON TX2 +

Re: [dpdk-dev] [PATCH v5 07/11] net/octeontx_ep: added tx queue setup and release

2021-01-28 Thread Ferruh Yigit
On 1/28/2021 3:22 PM, Nalla Pradeep wrote: Transmit queue setup involves allocating memory for the command queue considering tx descriptor count and initializing data structure representing the queue. Transmit queue release function frees the command queue. Signed-off-by: Nalla Pradeep <...>

Re: [dpdk-dev] [PATCH v5 05/11] net/octeontx_ep: add dev info get and configure

2021-01-28 Thread Ferruh Yigit
On 1/28/2021 3:22 PM, Nalla Pradeep wrote: Add device information get and device configure operations. Signed-off-by: Nalla Pradeep <...> +static int +otx_ep_dev_configure(struct rte_eth_dev *eth_dev) +{ + struct otx_ep_device *otx_epvf = OTX_EP_DEV(eth_dev); + struct rte_eth_de

Re: [dpdk-dev] [PATCH v5 03/11] net/octeontx_ep: add device init and uninit

2021-01-28 Thread Ferruh Yigit
On 1/28/2021 3:22 PM, Nalla Pradeep wrote: Add basic init and uninit function which includes initializing fields of ethdev private structure. Signed-off-by: Nalla Pradeep --- drivers/common/octeontx2/otx2_common.h | 2 +- drivers/net/octeontx_ep/otx_ep_common.h | 19 ++- drivers/net/o

Re: [dpdk-dev] [dpdk-techboard] [PATCH v6 2/8] eal: fix error attribute use for clang

2021-01-28 Thread Thomas Monjalon
28/01/2021 16:16, Bruce Richardson: > On Thu, Jan 28, 2021 at 02:16:10PM +, Bruce Richardson wrote: > > On Thu, Jan 28, 2021 at 02:36:25PM +0100, David Marchand wrote: > > > On Thu, Jan 28, 2021 at 12:20 PM Bruce Richardson > > > wrote: > > > > > If the compiler has neither error or diagnose_i

Re: [dpdk-dev] [PATCH v1 1/1] test/distributor: prevent return buffer overload

2021-01-28 Thread David Hunt
Hi Lukasz, On 19/1/2021 3:59 AM, Lukasz Wojciechowski wrote: The distributor library implementation uses a cyclic queue to store packets returned from workers. These packets can be later collected with rte_distributor_returned_pkts() call. However the queue has limited capacity. It is able to co

Re: [dpdk-dev] [PATCH v6 4/8] ethdev: make driver-only headers private

2021-01-28 Thread Webster, Steven
> -Original Message- > From: Bruce Richardson > Sent: Wednesday, January 27, 2021 12:33 PM > Subject: [PATCH v6 4/8] ethdev: make driver-only headers private > > [Please note: This e-mail is from an EXTERNAL e-mail address] > > The rte_ethdev_driver.h, rte_ethdev_vdev.h and rte_ethdev_pc

[dpdk-dev] [Bug 628] Possible deadlock in testpmd

2021-01-28 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=628 Bug ID: 628 Summary: Possible deadlock in testpmd Product: DPDK Version: 20.08 Hardware: x86 OS: All Status: UNCONFIRMED Severity: normal Priority: High

[dpdk-dev] [PATCH v5 11/11] net/octeontx_ep: transmit data path function added

2021-01-28 Thread Nalla Pradeep
1. Packet transmit function for both otx and otx2 are added. 2. Flushing transmit(command) queue when pending commands are more than maximum allowed value (currently 16). 3. Scatter gather support if the packet spans multiple buffers. Signed-off-by: Nalla Pradeep --- drivers/net/octeontx_ep/o

[dpdk-dev] [PATCH v5 08/11] net/octeontx_ep: setting up iq and oq registers

2021-01-28 Thread Nalla Pradeep
Configuring hardware registers with command queue(iq) and driver output queue(oq) parameters. List of parameters configured for IQ after making sure it is idle 1. Base address 2. Instruction size 3. Disabling interrupts for fastpath List of parameters configured for OQ after making sure it is idle

[dpdk-dev] [PATCH v5 01/11] net/octeontx_ep: add build and doc infrastructure

2021-01-28 Thread Nalla Pradeep
Adding bare minimum PMD library and doc build infrastructure and claim the maintainership for octeontx end point PMD. Signed-off-by: Nalla Pradeep --- MAINTAINERS | 9 doc/guides/nics/features/octeontx_ep.ini | 10 + doc/guides/nics/index.rst

[dpdk-dev] [PATCH v5 10/11] net/octeontx_ep: receive data path function added

2021-01-28 Thread Nalla Pradeep
Function to deliver packets from DROQ to application is added. It also fills DROQ with receive buffers timely such that device can fill them with incoming packets. Signed-off-by: Nalla Pradeep --- drivers/net/octeontx_ep/otx_ep_common.h | 2 + drivers/net/octeontx_ep/otx_ep_ethdev.c | 3 + d

[dpdk-dev] [PATCH v5 07/11] net/octeontx_ep: added tx queue setup and release

2021-01-28 Thread Nalla Pradeep
Transmit queue setup involves allocating memory for the command queue considering tx descriptor count and initializing data structure representing the queue. Transmit queue release function frees the command queue. Signed-off-by: Nalla Pradeep --- drivers/net/octeontx_ep/otx_ep_common.h | 90 ++

[dpdk-dev] [PATCH v5 09/11] net/octeontx_ep: added dev start and stop

2021-01-28 Thread Nalla Pradeep
Dev start and stop operations are added. To accomplish this internal functions to enable or disable io queues are incorporated. Signed-off-by: Nalla Pradeep --- drivers/net/octeontx_ep/otx2_ep_vf.c| 107 drivers/net/octeontx_ep/otx_ep_common.h | 8 ++ drivers/net/octeo

[dpdk-dev] [PATCH v5 06/11] net/octeontx_ep: added rxq setup and release

2021-01-28 Thread Nalla Pradeep
Receive queue setup involves allocating memory for the queue, initializing data structure representing the queue and filling queue with receive buffers of rx descriptor count. Receive queues are referred as droq. Hardware fills the receive buffers in queue with the packet. In receive queue release

[dpdk-dev] [PATCH v5 05/11] net/octeontx_ep: add dev info get and configure

2021-01-28 Thread Nalla Pradeep
Add device information get and device configure operations. Signed-off-by: Nalla Pradeep --- doc/guides/nics/features/octeontx_ep.ini | 1 + drivers/net/octeontx_ep/otx_ep_common.h | 15 + drivers/net/octeontx_ep/otx_ep_ethdev.c | 81 +++- drivers/net/octeontx_ep/otx_e

[dpdk-dev] [PATCH v5 04/11] net/octeontx_ep: added basic device setup

2021-01-28 Thread Nalla Pradeep
Functions to setup device, basic input queue and output queue registers are added. Signed-off-by: Nalla Pradeep --- drivers/net/octeontx_ep/meson.build | 2 + drivers/net/octeontx_ep/otx2_ep_vf.c| 131 + drivers/net/octeontx_ep/otx2_ep_vf.h| 11 ++ drivers/net/

[dpdk-dev] [PATCH v5 03/11] net/octeontx_ep: add device init and uninit

2021-01-28 Thread Nalla Pradeep
Add basic init and uninit function which includes initializing fields of ethdev private structure. Signed-off-by: Nalla Pradeep --- drivers/common/octeontx2/otx2_common.h | 2 +- drivers/net/octeontx_ep/otx_ep_common.h | 19 ++- drivers/net/octeontx_ep/otx_ep_ethdev.c | 72

[dpdk-dev] [PATCH v5 00/11] Octeon Tx/Tx2 Endpoint pmd

2021-01-28 Thread Nalla Pradeep
This patch set contains PMD with minimal set of operations that can drive both Octeon Tx and Tx2 in endpoint. v2: Fixed review comments from sburla at marvell v3: Fixed review comments from jerinj at marvell v4: Fixed MAITAINERS file v5: Fixed review comments from Ferruh yigit at intel Na

[dpdk-dev] [PATCH v5 02/11] net/octeontx_ep: add ethdev probe and remove

2021-01-28 Thread Nalla Pradeep
add basic PCIe ethdev probe and remove. Signed-off-by: Nalla Pradeep --- drivers/common/octeontx2/otx2_common.h| 3 ++ drivers/net/octeontx_ep/meson.build | 2 + drivers/net/octeontx_ep/otx_ep_common.h | 14 ++ drivers/net/octeontx_ep/otx_ep_ethdev.c | 56

Re: [dpdk-dev] [PATCH v6 2/8] eal: fix error attribute use for clang

2021-01-28 Thread Bruce Richardson
On Thu, Jan 28, 2021 at 02:16:10PM +, Bruce Richardson wrote: > On Thu, Jan 28, 2021 at 02:36:25PM +0100, David Marchand wrote: > > On Thu, Jan 28, 2021 at 12:20 PM Bruce Richardson > > wrote: > > > > If the compiler has neither error or diagnose_if support, an internal > > > > API can be call

[dpdk-dev] [PATCH v2] net/iavf: fix vector mapping with queue

2021-01-28 Thread Jingjing Wu
Fix the vector mapping with queue by changing the recircle when exceeds RX_VEC_START + nb_msix; Fixes: d6bde6b5eae9 ("net/avf: enable Rx interrupt") Signed-off-by: Jingjing Wu --- v2: - fix compile warning. drivers/net/iavf/iavf_ethdev.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletion

Re: [dpdk-dev] [PATCH v2 4/5] doc: update release notes for hns3

2021-01-28 Thread Ferruh Yigit
On 1/28/2021 12:43 PM, Lijun Ou wrote: Add TM(Traffic Management) feature with hns3 in release notes. It includes: 1. configure port's peak rate with PF 2. configure TC's peak rate with PF Fixes: c09c7847d892 ("net/hns3: support traffic management") Cc: sta...@dpdk.org Signed-off-by: Lijun Ou

Re: [dpdk-dev] [PATCH v1 1/2] app/test: remove unnecessary barriers for ring stress test

2021-01-28 Thread Ananyev, Konstantin
> > > > Hi Feifei, > > > > > > > > The variable "wrk_cmd" is a signal to control threads from running and > > > stopping. When worker lcores load "wrk_cmd == WRK_CMD_RUN", they > > start > > > running and when worker lcores load "wrk_cmd == WRK_CMD_STOP", > > they > > > stop. > > > > > > For the

Re: [dpdk-dev] [PATCH v5 0/9] ethdev: support SubFunction representor

2021-01-28 Thread Xueming(Steven) Li
>> The patch of device SF capability, but seems I misunderstood your suggestion. >> Let me explain process to create a SF: >> 1. SF can be created on the fly with scripts, unlike VF which is statically >> pre-created. > >Is there a maximum index and maximum total number of SF's created? How to fi

Re: [dpdk-dev] [PATCH v6 2/8] eal: fix error attribute use for clang

2021-01-28 Thread Bruce Richardson
On Thu, Jan 28, 2021 at 02:36:25PM +0100, David Marchand wrote: > On Thu, Jan 28, 2021 at 12:20 PM Bruce Richardson > wrote: > > > If the compiler has neither error or diagnose_if support, an internal > > > API can be called without ALLOW_INTERNAL_API. > > > I prefer a build error complaining on a

Re: [dpdk-dev] [PATCH v2 2/5] net/hns3: add FEC feature for hns3.ini

2021-01-28 Thread Thomas Monjalon
28/01/2021 13:43, Lijun Ou: > The hns3 PMD add FEC features implementation in 20.11. > Therefore, need to update the hns3.ini for supporting. > > Fixes: 9bf2ea8dbc65 ("net/hns3: support FEC") > Cc: sta...@dpdk.org > > Signed-off-by: Lijun Ou > --- > doc/guides/nics/features/hns3.ini | 1 + > 1

Re: [dpdk-dev] [dpdk-stable] [PATCH v1 1/1] test/distributor: prevent return buffer overload

2021-01-28 Thread David Marchand
On Tue, Jan 19, 2021 at 4:59 AM Lukasz Wojciechowski wrote: > > The distributor library implementation uses a cyclic queue to store > packets returned from workers. These packets can be later collected > with rte_distributor_returned_pkts() call. > However the queue has limited capacity. It is abl

Re: [dpdk-dev] [PATCH] net/iavf: fix vector mapping with queue

2021-01-28 Thread Zhang, Qi Z
> -Original Message- > From: dev On Behalf Of Xing, Beilei > Sent: Thursday, January 28, 2021 11:32 AM > To: Wu, Jingjing ; dev@dpdk.org > Cc: sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] net/iavf: fix vector mapping with queue > > > > > -Original Message- > > From: Wu,

Re: [dpdk-dev] [PATCH v6 7/8] devtools: remove check-includes script

2021-01-28 Thread Thomas Monjalon
28/01/2021 12:38, Bruce Richardson: > On Thu, Jan 28, 2021 at 12:10:41PM +0100, Thomas Monjalon wrote: > > 27/01/2021 18:33, Bruce Richardson: > > > +* The ``check-includes.sh`` script for checking DPDK header files has > > > been + removed, being replaced by the ``check_includes`` build option >

Re: [dpdk-dev] [PATCH v5 3/3] PCI: don't use vfio ioctl call to access PIO resource

2021-01-28 Thread 谢华伟(此时此刻)
On 2021/1/28 0:45, Ferruh Yigit wrote: On 1/27/2021 2:43 PM, 谢华伟(此时此刻) wrote: On 2021/1/27 18:32, Ferruh Yigit wrote: I was waiting for clarification if this can be solved in virtio, which seems clarified and decided to go with this patch, I am OK to proceed with patch 1 & 2. But first pa

Re: [dpdk-dev] [PATCH v6 2/8] eal: fix error attribute use for clang

2021-01-28 Thread David Marchand
On Thu, Jan 28, 2021 at 12:20 PM Bruce Richardson wrote: > > If the compiler has neither error or diagnose_if support, an internal > > API can be called without ALLOW_INTERNAL_API. > > I prefer a build error complaining on an unknown attribute rather than > > silence a check. > > > > I.e. > > > >

  1   2   >