Re: [dpdk-dev] [PATCH v5] app/testpmd: fix setting maximum packet length

2021-01-25 Thread Li, Xiaoyun
> -Original Message- > From: Lance Richardson > Sent: Tuesday, January 26, 2021 11:45 > To: Yigit, Ferruh > Cc: Lu, Wenzhuo ; Li, Xiaoyun ; > Iremonger, Bernard ; Yang, SteveX > ; dev@dpdk.org; sta...@dpdk.org; > ouli...@huawei.com; wis...@mellanox.com; lihuis...@huawei.com > Subject: R

Re: [dpdk-dev] [PATCH v5] app/testpmd: fix setting maximum packet length

2021-01-25 Thread Lance Richardson
On Mon, Jan 25, 2021 at 7:44 PM Ferruh Yigit wrote: > > >> + if (rx_offloads != port->dev_conf.rxmode.offloads) { > >> + uint16_t qid; > >> + > >> + port->dev_conf.rxmode.offloads = rx_offloads; > >> + > >> + /* Apply JUMBO_FRAME offload configuratio

Re: [dpdk-dev] [PATCH v2] app/testpmd: avoid exit without terminal restore

2021-01-25 Thread Yu, DapengX
@Xiaoyun, Add one more explanation. even if registers prompt_exit failed, when users type "quit" and then break from cmdline_interact(), the ret check will not prevent cmdline_stdin_exit() to be called to restore terminal settings in this patch. @Beilei Can you give comment on this patch v2, so

Re: [dpdk-dev] [PATCH v5] app/testpmd: fix setting maximum packet length

2021-01-25 Thread Lance Richardson
Acked-by: Lance Richardson Thanks, Lance On Mon, Jan 25, 2021 at 7:44 PM Ferruh Yigit wrote: > > On 1/25/2021 7:41 PM, Lance Richardson wrote: > > On Mon, Jan 25, 2021 at 1:15 PM Ferruh Yigit wrote: > >> > >> From: Steve Yang > >> > >> "port config all max-pkt-len" command fails because i

Re: [dpdk-dev] [PATCH v2] app/testpmd: avoid exit without terminal restore

2021-01-25 Thread Yu, DapengX
Hi Xiaoyun, For this situation: registering prompt_exit succeed, and user type "quit" command to exit testpmd. If the second call to cmdline_stdin_exit is not excluded from the code conditionally, the cmdline_stdin_exit will be called twice; 1. the first time: in prompt() #0 cmdline_stdi

[dpdk-dev] [PATCH v12 4/4] examples/ifpga: add example for ifpga opae API

2021-01-25 Thread Wei Huang
Below major OPAE APIs are added in this example. 1. opae_init_eal() set up EAL environment. 2. opae_cleanup_eal() clean up EAL environment. 3. opae_enumerate() searches PAC with specific FPGA. 4. opae_get_property() gets properties of FPGA. 5. opae_partial_reconfigure() perform partial configuratio

[dpdk-dev] [PATCH v12 3/4] raw/ifpga: add fpga helper function

2021-01-25 Thread Wei Huang
Below helper functions are used to implement OPAE application. 1. ifpga_rawdev_lock() and ifpga_rawdev_unlock() protect FPGA access in multiproces. 2. ifpga_rawdev_get_rsu_stat() and ifpga_rawdev_set_rsu_stat() record current RSU status and progress. 3. ifpga_rawdev_get_phy_info() get information o

[dpdk-dev] [PATCH v12 2/4] raw/ifpga: add fpga property get function

2021-01-25 Thread Wei Huang
There are three types of property can be got from FPGA, they are implemented in below functions: 1. ifpga_rawdev_get_fme_property() get property of FME (FPGA Management Engine). 2. ifpga_rawdev_get_port_property() get property of FPGA port. 3. ifpga_rawdev_get_bmc_property() get property of BMC

[dpdk-dev] [PATCH v12 1/4] raw/ifpga: add fpga rsu function

2021-01-25 Thread Wei Huang
RSU (Remote System Update) depends on secure manager which may be different on various implementations, so a new secure manager device is implemented for adapting such difference. There are three major functions added: 1. ifpga_rawdev_update_flash() updates flash with specific image file. 2. ifpga_

[dpdk-dev] [PATCH v12 0/4] raw/ifpga: add extra OPAE APIs

2021-01-25 Thread Wei Huang
Cyborg is part of OpenStack, it needs some OPAE APIs to manage devices with Intel FPGA. The first three patches implement extra APIs to meet Cyborg requirement. The last patch add an example to show how to use these APIs. Main changes from v11: - implement OPAE APIs in example instead of ifpga raw

Re: [dpdk-dev] [PATCH v3 44/44] net/virtio: handle Virtio-user setup failure properly

2021-01-25 Thread Xia, Chenbo
Hi Maxime, > -Original Message- > From: Maxime Coquelin > Sent: Tuesday, January 26, 2021 1:15 AM > To: dev@dpdk.org; Xia, Chenbo ; olivier.m...@6wind.com; > amore...@redhat.com; david.march...@redhat.com > Cc: Maxime Coquelin > Subject: [PATCH v3 44/44] net/virtio: handle Virtio-user se

Re: [dpdk-dev] [PATCH v2] app/testpmd: avoid exit without terminal restore

2021-01-25 Thread Li, Xiaoyun
Hi > -Original Message- > From: dapengx...@intel.com > Sent: Monday, January 25, 2021 11:30 > To: Xing, Beilei ; Li, Xiaoyun ; > Lu, > Wenzhuo ; Iremonger, Bernard > ; step...@networkplumber.org > Cc: dev@dpdk.org; Yu, DapengX ; sta...@dpdk.org > Subject: [PATCH v2] app/testpmd: avoid ex

Re: [dpdk-dev] [PATCH v3 43/44] net/virtio: improve Vhost-user error logging

2021-01-25 Thread Xia, Chenbo
> -Original Message- > From: Maxime Coquelin > Sent: Tuesday, January 26, 2021 1:15 AM > To: dev@dpdk.org; Xia, Chenbo ; olivier.m...@6wind.com; > amore...@redhat.com; david.march...@redhat.com > Cc: Maxime Coquelin > Subject: [PATCH v3 43/44] net/virtio: improve Vhost-user error logging

Re: [dpdk-dev] [PATCH v2 43/44] net/virtio: improve Vhost-user error logging

2021-01-25 Thread Xia, Chenbo
> -Original Message- > From: Maxime Coquelin > Sent: Monday, January 25, 2021 11:04 PM > To: Xia, Chenbo ; dev@dpdk.org; olivier.m...@6wind.com; > amore...@redhat.com; david.march...@redhat.com > Subject: Re: [PATCH v2 43/44] net/virtio: improve Vhost-user error logging > > > > On 1/22/

Re: [dpdk-dev] [PATCH v3 29/44] net/virtio: add Virtio-user memory tables ops

2021-01-25 Thread Xia, Chenbo
> -Original Message- > From: Maxime Coquelin > Sent: Tuesday, January 26, 2021 1:14 AM > To: dev@dpdk.org; Xia, Chenbo ; olivier.m...@6wind.com; > amore...@redhat.com; david.march...@redhat.com > Cc: Maxime Coquelin > Subject: [PATCH v3 29/44] net/virtio: add Virtio-user memory tables ops

Re: [dpdk-dev] [PATCH v3 28/44] net/virtio: add Virtio-user protocol features ops

2021-01-25 Thread Xia, Chenbo
> -Original Message- > From: Maxime Coquelin > Sent: Tuesday, January 26, 2021 1:14 AM > To: dev@dpdk.org; Xia, Chenbo ; olivier.m...@6wind.com; > amore...@redhat.com; david.march...@redhat.com > Cc: Maxime Coquelin > Subject: [PATCH v3 28/44] net/virtio: add Virtio-user protocol features

Re: [dpdk-dev] [PATCH v3 27/44] net/virtio: add Virtio-user features ops

2021-01-25 Thread Xia, Chenbo
> -Original Message- > From: Maxime Coquelin > Sent: Tuesday, January 26, 2021 1:14 AM > To: dev@dpdk.org; Xia, Chenbo ; olivier.m...@6wind.com; > amore...@redhat.com; david.march...@redhat.com > Cc: Maxime Coquelin > Subject: [PATCH v3 27/44] net/virtio: add Virtio-user features ops > >

Re: [dpdk-dev] [PATCH v3 19/44] net/virtio: move features definition to generic header

2021-01-25 Thread Xia, Chenbo
> -Original Message- > From: Maxime Coquelin > Sent: Tuesday, January 26, 2021 1:14 AM > To: dev@dpdk.org; Xia, Chenbo ; olivier.m...@6wind.com; > amore...@redhat.com; david.march...@redhat.com > Cc: Maxime Coquelin > Subject: [PATCH v3 19/44] net/virtio: move features definition to gener

Re: [dpdk-dev] [PATCH v3 09/44] net/virtio: move MSIX detection to PCI ethdev

2021-01-25 Thread Xia, Chenbo
> -Original Message- > From: Maxime Coquelin > Sent: Tuesday, January 26, 2021 1:14 AM > To: dev@dpdk.org; Xia, Chenbo ; olivier.m...@6wind.com; > amore...@redhat.com; david.march...@redhat.com > Cc: Maxime Coquelin > Subject: [PATCH v3 09/44] net/virtio: move MSIX detection to PCI ethdev

Re: [dpdk-dev] [PATCH] ethdev: add IPv6 DSCP option for modify field action

2021-01-25 Thread Stephen Hemminger
On Tue, 26 Jan 2021 05:21:23 + Alexander Kozyrev wrote: > > From: Stephen Hemminger on Monday, January 25, > > 2021 22:44 > > > > On Tue, 26 Jan 2021 03:38:24 + > > Alexander Kozyrev wrote: > > > > > IPv6 DSCP field ID is missing from the original list of Field IDs > > > for MODIFY

Re: [dpdk-dev] [PATCH] ethdev: add IPv6 DSCP option for modify field action

2021-01-25 Thread Alexander Kozyrev
> From: Stephen Hemminger on Monday, January 25, > 2021 22:44 > > On Tue, 26 Jan 2021 03:38:24 + > Alexander Kozyrev wrote: > > > IPv6 DSCP field ID is missing from the original list of Field IDs > > for MODIFY_FIELD action. Add it to support IPv6 header fully. > > > > Fixes: 73b68f4c54a (

Re: [dpdk-dev] [PATCH] ethdev: add IPv6 DSCP option for modify field action

2021-01-25 Thread Stephen Hemminger
On Tue, 26 Jan 2021 03:38:24 + Alexander Kozyrev wrote: > IPv6 DSCP field ID is missing from the original list of Field IDs > for MODIFY_FIELD action. Add it to support IPv6 header fully. > > Fixes: 73b68f4c54a ("ethdev: introduce generic modify flow action") > > Signed-off-by: Alexander Ko

[dpdk-dev] [PATCH] app/testpmd: add IPv6 DSCP option for modify_field action

2021-01-25 Thread Alexander Kozyrev
Support IPv6 DSCP modification via the modify_field action. Add the ipv6_dscp option for the corresponding header field. Fixes: 24e1a5e39df ("app/testpmd: support modify field flow action") Signed-off-by: Alexander Kozyrev --- app/test-pmd/cmdline_flow.c | 2 +- 1 file changed, 1 insertion(+),

Re: [dpdk-dev] [PATCH v3] net/ixgbe: disable NFS filtering

2021-01-25 Thread Zhang, Qi Z
> -Original Message- > From: dev On Behalf Of Guo, Jia > Sent: Tuesday, January 26, 2021 11:36 AM > To: Yu, DapengX ; Wang, Haiyue > ; Yang, Qiming > Cc: dev@dpdk.org; Yu, DapengX ; sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3] net/ixgbe: disable NFS filtering > > Acked-by: Jef

[dpdk-dev] [PATCH] app/testpmd: fix the sample RSS issue

2021-01-25 Thread Jiawei Wang
When the RSS with null key was set in sample actions list, it caused the segmentation fault since the RSS key pointer was NULL while did the memory copy. This patch adds the RSS key NULL pointer checking before copying to fix the segmentation fault issue. Fixes: 11b1b0eddade ("app/testpmd: suppor

[dpdk-dev] 回复: [PATCH v1 3/3] ring: rename and refactor ring library

2021-01-25 Thread Feifei Wang
Hi, Konstantin > -邮件原件- > 发件人: Ananyev, Konstantin > 发送时间: 2021年1月25日 18:29 > 收件人: Ananyev, Konstantin ; Feifei Wang > ; Honnappa Nagarahalli > > 抄送: dev@dpdk.org; nd ; nd > 主题: RE: [PATCH v1 3/3] ring: rename and refactor ring library > > > > > > > Hi Feifei, > > > > > > > For legac

[dpdk-dev] [PATCH] ethdev: add IPv6 DSCP option for modify field action

2021-01-25 Thread Alexander Kozyrev
IPv6 DSCP field ID is missing from the original list of Field IDs for MODIFY_FIELD action. Add it to support IPv6 header fully. Fixes: 73b68f4c54a ("ethdev: introduce generic modify flow action") Signed-off-by: Alexander Kozyrev --- lib/librte_ethdev/rte_flow.h | 1 + 1 file changed, 1 insertio

Re: [dpdk-dev] [PATCH v3] net/ixgbe: disable NFS filtering

2021-01-25 Thread Guo, Jia
Acked-by: Jeff Guo > -Original Message- > From: dapengx...@intel.com > Sent: Tuesday, January 26, 2021 11:03 AM > To: Guo, Jia ; Wang, Haiyue ; > Yang, Qiming > Cc: dev@dpdk.org; Yu, DapengX ; sta...@dpdk.org > Subject: [PATCH v3] net/ixgbe: disable NFS filtering > > From: Dapeng Yu >

Re: [dpdk-dev] [PATCH v1] net/iavf: adjust the VLAN failure handling

2021-01-25 Thread Zhang, Qi Z
> -Original Message- > From: Wang, Haiyue > Sent: Monday, January 25, 2021 7:44 PM > To: dev@dpdk.org > Cc: Yang, Qiming ; Zhang, Qi Z > ; Wang, Haiyue ; Wu, > Jingjing ; Xing, Beilei > Subject: [PATCH v1] net/iavf: adjust the VLAN failure handling > > Change the fatal returning to pr

Re: [dpdk-dev] [PATCH v1] net/iavf: fix unsupported VLAN offload requested

2021-01-25 Thread Zhang, Qi Z
> -Original Message- > From: Wang, Haiyue > Sent: Monday, January 25, 2021 12:31 PM > To: dev@dpdk.org > Cc: Yang, Qiming ; Zhang, Qi Z > ; Wang, Haiyue ; Wu, > Jingjing ; Xing, Beilei > Subject: [PATCH v1] net/iavf: fix unsupported VLAN offload requested > > If the underlying PF does

[dpdk-dev] [PATCH v3] net/ixgbe: disable NFS filtering

2021-01-25 Thread dapengx . yu
From: Dapeng Yu Disable NFS header filtering whether NFS packets coalescing are required or not, in order to make RSS can work on NFS packets. The code without the patch does follow datasheet, but not consistent with the ixgbe kernel driver. It causes NFS packets to be filtered and make them flo

Re: [dpdk-dev] [PATCH v2] net/ixgbe: disable NFS filtering

2021-01-25 Thread Yu, DapengX
Hi Jia, Thanks for the remind, I will submit patch v3 to include the reason to fix. -Original Message- From: Guo, Jia Sent: Tuesday, January 26, 2021 10:11 AM To: Yu, DapengX ; Wang, Haiyue ; Yang, Qiming Cc: dev@dpdk.org; Yu, DapengX ; sta...@dpdk.org Subject: RE: [PATCH v2] net/ixgbe:

Re: [dpdk-dev] [PATCH v2] net/ixgbe: disable NFS filtering

2021-01-25 Thread Guo, Jia
Hi, dapeng > -Original Message- > From: dapengx...@intel.com > Sent: Monday, January 25, 2021 11:11 AM > To: Guo, Jia ; Wang, Haiyue ; > Yang, Qiming > Cc: dev@dpdk.org; Yu, DapengX ; sta...@dpdk.org > Subject: [PATCH v2] net/ixgbe: disable NFS filtering > > From: Dapeng Yu > > Disabl

Re: [dpdk-dev] [dpdk-stable] [PATCH v11 1/4] raw/ifpga: add fpga rsu function

2021-01-25 Thread Huang, Wei
Hi, -Original Message- From: Xu, Rosen Sent: Monday, January 25, 2021 18:33 To: Yigit, Ferruh ; Huang, Wei ; dev@dpdk.org; Zhang, Qi Z Cc: sta...@dpdk.org; Zhang, Tianfei ; Ray Kinsella Subject: RE: [dpdk-stable] [PATCH v11 1/4] raw/ifpga: add fpga rsu function Hi, > -Original

Re: [dpdk-dev] [PATCH v5] app/testpmd: fix setting maximum packet length

2021-01-25 Thread Ferruh Yigit
On 1/25/2021 7:41 PM, Lance Richardson wrote: On Mon, Jan 25, 2021 at 1:15 PM Ferruh Yigit wrote: From: Steve Yang "port config all max-pkt-len" command fails because it doesn't set the 'DEV_RX_OFFLOAD_JUMBO_FRAME' offload flag properly. Commit in the fixes line moved the 'DEV_RX_OFFLOAD_JU

Re: [dpdk-dev] [dpdk-stable] [PATCH] build: force pkg-config for dependency detection

2021-01-25 Thread Thomas Monjalon
18/01/2021 15:29, Bruce Richardson: > Meson can use cmake as a fallback for detecting packages, and this can > lead to picking up 64-libs for 32-bit builds. To work around this, force > the use of pkg-config only for detecting libcrypto, zlib, jansson and > other package dependencies. > > CC: sta.

Re: [dpdk-dev] [PATCH 0/3] pmdinfogen fixes

2021-01-25 Thread Thomas Monjalon
25/01/2021 23:12, Dmitry Kozlyuk: > Recent pmdinfogen patches introduced regressions with older systems. > This is a follow-up cleaning the mess. > > [1]: http://patchwork.dpdk.org/project/dpdk/list/?series=13153 > [2]: http://patchwork.dpdk.org/project/dpdk/list/?series=14274 > > Dmitry Kozlyuk

Re: [dpdk-dev] [PATCH v5] app/testpmd: fix setting maximum packet length

2021-01-25 Thread Lance Richardson
On Mon, Jan 25, 2021 at 1:15 PM Ferruh Yigit wrote: > > From: Steve Yang > > "port config all max-pkt-len" command fails because it doesn't set the > 'DEV_RX_OFFLOAD_JUMBO_FRAME' offload flag properly. > > Commit in the fixes line moved the 'DEV_RX_OFFLOAD_JUMBO_FRAME' offload > flag update from

Re: [dpdk-dev] [PATCH v10 0/3] pmdinfogen: rewrite in Python

2021-01-25 Thread Dmitry Kozlyuk
Hi Ali, > Please see the following build errors: > https://github.com/DPDK/dpdk/actions/runs/509771118 > """ > FAILED: drivers/rte_common_cpt.pmd.c > /usr/bin/python3 ../buildtools/gen-pmdinfo-cfile.py ar > /home/runner/work/dpdk/dpdk/build/drivers/libtmp_rte_common_cpt.a > drivers/rte_common_c

[dpdk-dev] [PATCH 3/3] buildtools: use build subdirectory for temporary files

2021-01-25 Thread Dmitry Kozlyuk
Use current build directory as base for temporary directories, so that all build files are isolated there. Fixes: caaca1ec6a8e ("buildtools: support object file extraction for Windows") Signed-off-by: Dmitry Kozlyuk --- Thomas asked to send this as a follow-up before regression has been noticed,

[dpdk-dev] [PATCH 2/3] buildtools: fix archive extraction for Python 3.5

2021-01-25 Thread Dmitry Kozlyuk
Python 3.5 subprocess.run() has no capture_output parameter. Use subprocess.PIPE available in all versions. Signed-off-by: Dmitry Kozlyuk --- To be squashed with caaca1ec6 ("buildtools: support object file extraction for Windows"). buildtools/gen-pmdinfo-cfile.py | 2 +- 1 file changed, 1 inser

[dpdk-dev] [PATCH 1/3] pmdinfogen: fix build with pyelftools < 0.24

2021-01-25 Thread Dmitry Kozlyuk
pyelftools had some breaking changes [1] and API enhancements [2] between 0.23 (used in Ubuntu 16.04) and 0.24. Ensure compatibility with both legacy and modern versions. [1]: https://github.com/eliben/pyelftools/pull/76 [2]: https://github.com/eliben/pyelftools/pull/56 Signed-off-by: Dmitry Kozl

[dpdk-dev] [PATCH 0/3] pmdinfogen fixes

2021-01-25 Thread Dmitry Kozlyuk
Recent pmdinfogen patches introduced regressions with older systems. This is a follow-up cleaning the mess. [1]: http://patchwork.dpdk.org/project/dpdk/list/?series=13153 [2]: http://patchwork.dpdk.org/project/dpdk/list/?series=14274 Dmitry Kozlyuk (3): pmdinfogen: fix build with pyelftools < 0

Re: [dpdk-dev] [PATCH v4 2/2] app/testpmd: fix max-pkt-len option invalid

2021-01-25 Thread Lance Richardson
On Mon, Jan 25, 2021 at 3:35 AM Steve Yang wrote: > > Moved the setting of 'DEV_RX_OFFLOAD_JUMBO_FRAME' from > 'cmd_config_max_pkt_len_parsed()' to 'init_config()' caused fail the case > where 'max_rx_pkt_len' is changed from the command line via > "port config all max-pkt-len". > > The 'init_conf

Re: [dpdk-dev] [PATCH v10 0/3] pmdinfogen: rewrite in Python

2021-01-25 Thread Ali Alnubani
Hi, > -Original Message- > From: dev On Behalf Of Dmitry Kozlyuk > Sent: Sunday, January 24, 2021 10:52 PM > To: dev@dpdk.org > Cc: Maxime Coquelin ; Bruce Richardson > ; NBU-Contact-Thomas Monjalon > ; Dmitry Kozlyuk ; Neil > Horman ; Jie Zhou > Subject: [dpdk-dev] [PATCH v10 0/3] pmdin

Re: [dpdk-dev] [dpdklab] RE: [dpdk-stable] [PATCH v4] mbuf: fix reset on mbuf free

2021-01-25 Thread Ferruh Yigit
On 1/21/2021 4:35 PM, Lincoln Lavoie wrote: Hi All, Trying to follow the specific conversation.  It is correct, the lab does not list the specific throughput values achieved by the hardware, as that data can be sensitive to the hardware vendors, etc. The purpose of the lab is to check for deg

Re: [dpdk-dev] [PATCH v3 0/4] add crypto perf test graphing script

2021-01-25 Thread Akhil Goyal
> This patchset introduces a python script to run various crypto performance > test cases, and graph the results in a consumable manner. The test suites > are configured via JSON file. Some config files are provided, > or the user may create one. Currently throughput and latency ptests for > device

Re: [dpdk-dev] [PATCH] net/octeontx2: move PF-func location for egress

2021-01-25 Thread Jerin Jacob
On Mon, Jan 18, 2021 at 4:20 PM wrote: > > From: Liron Himi > > pf-func is 16bit but the current reserved location > used in tx action is 8bits. moved it to bits 63-48. > > Fixes: 32e6aaa97 ("net/octeontx2: support flow parse actions") > Cc: sta...@dpdk.org > > Signed-off-by: Liron Himi > Review

Re: [dpdk-dev] [PATCH v3 0/4] add checking of header includes

2021-01-25 Thread Bruce Richardson
On Mon, Jan 25, 2021 at 04:51:19PM +0100, David Marchand wrote: > On Mon, Jan 25, 2021 at 3:11 PM Bruce Richardson > wrote: > > > > As a general principle, each header file should include any other > > headers it needs to provide data type definitions or macros. For > > example, any header using t

[dpdk-dev] [PATCH v5] app/testpmd: fix setting maximum packet length

2021-01-25 Thread Ferruh Yigit
From: Steve Yang "port config all max-pkt-len" command fails because it doesn't set the 'DEV_RX_OFFLOAD_JUMBO_FRAME' offload flag properly. Commit in the fixes line moved the 'DEV_RX_OFFLOAD_JUMBO_FRAME' offload flag update from 'cmd_config_max_pkt_len_parsed()' to 'init_config()'. 'init_config(

Re: [dpdk-dev] [PATCH v2 00/37] net/mvpp2: misc updates

2021-01-25 Thread Jerin Jacob
On Sat, Jan 23, 2021 at 12:49 AM wrote: > > From: Liron Himi > > This patch series align the mainline driver with all changes since 19.11 > some of the patches are fixes which should be pushed to stable > > v2: > - fix commit msg styling > - Addressed various review comments Series applied to d

[dpdk-dev] [PATCH 1/1] net/pcap: imissed stats support

2021-01-25 Thread Ido Goshen
Signed-off-by: Ido Goshen --- drivers/net/pcap/rte_eth_pcap.c | 20 1 file changed, 20 insertions(+) diff --git a/drivers/net/pcap/rte_eth_pcap.c b/drivers/net/pcap/rte_eth_pcap.c index a32b1f3f3..83e208514 100644 --- a/drivers/net/pcap/rte_eth_pcap.c +++ b/drivers/net/pcap/

Re: [dpdk-dev] [PATCH v4 2/2] app/testpmd: fix max-pkt-len option invalid

2021-01-25 Thread Ferruh Yigit
On 1/25/2021 3:46 PM, Lance Richardson wrote: On Mon, Jan 25, 2021 at 3:35 AM Steve Yang wrote: Moved the setting of 'DEV_RX_OFFLOAD_JUMBO_FRAME' from 'cmd_config_max_pkt_len_parsed()' to 'init_config()' caused fail the case where 'max_rx_pkt_len' is changed from the command line via "port con

Re: [dpdk-dev] [EXT] [PATCH v4 3/3] examples/eventdev: move eth stop to the end

2021-01-25 Thread Pavan Nikhilesh Bhagavatula
>Move eth stop code from "signal_handler" function to the end of >"main" >function. There are two reasons for this: > >First, this improves code maintenance and makes code look simple and >clear. Based on this change, after receiving the interrupt signal, >"fdata->done" is set as 1. Then the main t

Re: [dpdk-dev] [EXT] [PATCH v1 1/5] app/eventdev: fix SMP barrier bugs for perf test

2021-01-25 Thread Pavan Nikhilesh Bhagavatula
>This patch fixes RTE SMP barrier bugs for the perf test of eventdev. > >For the "perf_process_last_stage" function, wmb after storing >processed_pkts should be moved before it. This is because the worker >lcore should ensure it has really finished data processing, e.g. event >stored into buffers,

Re: [dpdk-dev] [EXT] [PATCH v1 4/5] app/eventdev: remove unnecessary barriers for pipeline test

2021-01-25 Thread Pavan Nikhilesh Bhagavatula
>For "processed_pkts" function, no operations should keep the order >that >being executed before loading "worker[i].processed_pkts". > >Signed-off-by: Feifei Wang >Reviewed-by: Ruifeng Wang Acked-by: Pavan Nikhilesh >--- > app/test-eventdev/test_pipeline_common.c | 1 - > 1 file changed, 1 deleti

Re: [dpdk-dev] [EXT] [PATCH v1 3/5] app/eventdev: replace wmb with thread fence for perf test

2021-01-25 Thread Pavan Nikhilesh Bhagavatula
>Simply replace rte_smp barrier with atomic threand fence. > >Signed-off-by: Phil Yang >Signed-off-by: Feifei Wang >Reviewed-by: Ruifeng Wang Acked-by: Pavan Nikhilesh >--- > app/test-eventdev/test_perf_common.h | 16 > 1 file changed, 8 insertions(+), 8 deletions(-) > >diff --g

Re: [dpdk-dev] [EXT] [PATCH v1 5/5] app/eventdev: remove unnecessary barriers for order test

2021-01-25 Thread Pavan Nikhilesh Bhagavatula
>For the wmb in order_process_stage_1 and >order_process_stage_invalid in >the order test, they can be removed. This is because when the test >results >are wrong, the worker core writes 'true' to t->err. Then other worker >cores, producer cores and the main core will load the 'error' index and >sto

Re: [dpdk-dev] [EXT] [PATCH v1 2/5] app/eventdev: remove unnecessary barriers for perf test

2021-01-25 Thread Pavan Nikhilesh Bhagavatula
>For "processed_pkts" and "total_latency" functions, no operations >should >keep the order that being executed before loading >"worker[i].processed_pkts". Thus rmb is unnecessary before loading. > >For "perf_launch_lcores" function, wmb after that the main lcore >updates the variable "t->done", whi

[dpdk-dev] [PATCH] dpdk-kmods: nvme support for netuio on Windows

2021-01-25 Thread Nick Connolly
Enable the netuio driver for an NVMe storage controller on Windows. Add the class ID 010802 and identify the device as 'netuio NVM Express Controller'. Signed-off-by: Nick Connolly --- windows/netuio/netuio.inf | 2 ++ 1 file changed, 2 insertions(+) diff --git a/windows/netuio/netuio.inf b/wi

Re: [dpdk-dev] [PATCH 0/3] vhost: make virtqueue cache-friendly

2021-01-25 Thread Maxime Coquelin
On 12/22/20 2:56 PM, Maxime Coquelin wrote: > As done for Virtio PMD, this series improves cache utilization > of the vhost_virtqueue struct by removing unused field, > make the live-migration cache dynamically allocated at > live-migration setup time and by moving fields > around so that hot fi

Re: [dpdk-dev] [PATCH 0/3] net/virtio: make virtqueue struct cache-friendly

2021-01-25 Thread Maxime Coquelin
On 12/21/20 5:14 PM, Maxime Coquelin wrote: > This series optimizes the cache usage of virtqueue struct, > by make a "fake" mbuf being dynamically allocated in Rx > virtnet struct, by removing a useless virtuque pointer > into the virtnet structs and by moving a few fields > to pack holes. > >

[dpdk-dev] [PATCH v3 44/44] net/virtio: handle Virtio-user setup failure properly

2021-01-25 Thread Maxime Coquelin
This patch fixes virtio_user_dev_setup() error path, by cleaning all resources it allocates. It introduces virtio_user_dev_uninit_notify() that cleans all open FDs. It implies assigning all FDs to -1 at init time. With these changes done, virtio_user_dev_init_notify() can be simplified. Suggested

[dpdk-dev] [PATCH v3 42/44] net/virtio: move Vhost-vDPA data to its backend

2021-01-25 Thread Maxime Coquelin
As done earlier for Vhost-user and Vhost-kernel, this patch moves the Vhost-vDPA specific data to its backend file. Signed-off-by: Maxime Coquelin Reviewed-by: Chenbo Xia --- drivers/net/virtio/virtio_user/vhost_vdpa.c | 120 +- .../net/virtio/virtio_user/virtio_user_dev.h |

[dpdk-dev] [PATCH v3 43/44] net/virtio: improve Vhost-user error logging

2021-01-25 Thread Maxime Coquelin
This patch improves error logging in vhost_user_read, especially printing errno when recv() fails. Suggested-by: Adrian Moreno Signed-off-by: Maxime Coquelin --- drivers/net/virtio/virtio_user/vhost_user.c | 31 - 1 file changed, 18 insertions(+), 13 deletions(-) diff --git

[dpdk-dev] [PATCH v3 40/44] net/virtio: move Vhost-user specifics to its backend

2021-01-25 Thread Maxime Coquelin
This patch moves all the Vhost-user backend specific logic like Vhost FD, listen FD and interrupt handling to the vhost-user backend implementation. In order to achieve that, new ops are created to update the link status, disconnect and reconnect the server, and fetch the link state interrupt FD.

[dpdk-dev] [PATCH v3 41/44] net/virtio: move Vhost-kernel data to its backend

2021-01-25 Thread Maxime Coquelin
As done earlier for Vhost-user, this patch moves the Vhost-Kernel specific data to its backend file. Signed-off-by: Maxime Coquelin Reviewed-by: Chenbo Xia --- drivers/net/virtio/virtio_user/vhost_kernel.c | 106 +++--- .../net/virtio/virtio_user/virtio_user_dev.c | 43 ++- ..

[dpdk-dev] [PATCH v3 39/44] net/virtio: introduce backend data

2021-01-25 Thread Maxime Coquelin
The goal of this patch is to introduce backend-specific data in order to better isolate what is backend-specific from what is generic to Virtio-user. For now, only Vhost-user protocol features are moved to Vhost-user backend data. Signed-off-by: Maxime Coquelin Reviewed-by: Chenbo Xia --- driv

[dpdk-dev] [PATCH v3 38/44] net/virtio: move protocol features to Vhost-user

2021-01-25 Thread Maxime Coquelin
Since only protocol features are specific to Vhost-user backend, this patch moves all related code to Vhost-user file. Signed-off-by: Maxime Coquelin Reviewed-by: Chenbo Xia --- drivers/net/virtio/virtio_user/vhost.h| 20 + drivers/net/virtio/virtio_user/vhost_kernel.c | 9 ++ driv

[dpdk-dev] [PATCH v3 37/44] net/virtio: make server mode blocking

2021-01-25 Thread Maxime Coquelin
This patch makes the Vhost-user backend server mode blocking at init, waiting for the client connection. The goal is to make the driver more reliable, as without waiting for client connection, the Virtio driver has to assume the Vhost-user backend will support all the features it has advertized, w

[dpdk-dev] [PATCH v3 36/44] net/virtio: move Vhost-user requests to Vhost-user backend

2021-01-25 Thread Maxime Coquelin
Now that we have a proper isolation of the backends, we can move Vhost-user requests declaration to the Vhost-user backend file. Signed-off-by: Maxime Coquelin Reviewed-by: Chenbo Xia --- drivers/net/virtio/virtio_user/vhost.h | 25 - drivers/net/virtio/virtio_user/vhos

[dpdk-dev] [PATCH v3 35/44] net/virtio: improve Virtio-user errors handling

2021-01-25 Thread Maxime Coquelin
This patch adds error logs and propagates errors reported by the backend. It also adds the device path in error logs to make it easier to distinguish which device is facing the issue. Signed-off-by: Maxime Coquelin Reviewed-by: Chenbo Xia --- .../net/virtio/virtio_user/virtio_user_dev.c | 154

[dpdk-dev] [PATCH v3 34/44] net/virtio: remove useless request ops

2021-01-25 Thread Maxime Coquelin
Now that all the ops have been implemented, we can remove the send_request ops for all backends. Signed-off-by: Maxime Coquelin Reviewed-by: Chenbo Xia --- drivers/net/virtio/virtio_user/vhost.h| 15 +-- drivers/net/virtio/virtio_user/vhost_kernel.c | 43 drivers/net/virtio/v

[dpdk-dev] [PATCH v3 33/44] net/virtio: add Virtio-user status ops

2021-01-25 Thread Maxime Coquelin
This patch introduces new callbacks to get and set the device status. Signed-off-by: Maxime Coquelin Reviewed-by: Chenbo Xia --- drivers/net/virtio/virtio_user/vhost.h| 2 + drivers/net/virtio/virtio_user/vhost_kernel.c | 14 ++ drivers/net/virtio/virtio_user/vhost_user.c | 121 +++

[dpdk-dev] [PATCH v3 32/44] net/virtio: add Virtio-user vring address ops

2021-01-25 Thread Maxime Coquelin
This patch introduces a new callback for setting vrings addresses. Signed-off-by: Maxime Coquelin Reviewed-by: Chenbo Xia --- drivers/net/virtio/virtio_user/vhost.h| 1 + drivers/net/virtio/virtio_user/vhost_kernel.c | 32 +-- drivers/net/virtio/virtio_user/vhost_user.c

[dpdk-dev] [PATCH v3 31/44] net/virtio: add Virtio-user vring file ops

2021-01-25 Thread Maxime Coquelin
This patch introduces new callbacks for setting vring files (kick and call). Signed-off-by: Maxime Coquelin Reviewed-by: Chenbo Xia --- drivers/net/virtio/virtio_user/vhost.h| 2 + drivers/net/virtio/virtio_user/vhost_kernel.c | 41 +++-- drivers/net/virtio/virtio_user/vhos

[dpdk-dev] [PATCH v3 29/44] net/virtio: add Virtio-user memory tables ops

2021-01-25 Thread Maxime Coquelin
This patch implements a dedicated callback for preparing and sending memory table to the backends. Signed-off-by: Maxime Coquelin --- drivers/net/virtio/virtio_user/vhost.h| 1 + drivers/net/virtio/virtio_user/vhost_kernel.c | 60 ++--- drivers/net/virtio/virtio_user/vhost_user.

[dpdk-dev] [PATCH v3 30/44] net/virtio: add Virtio-user vring setting ops

2021-01-25 Thread Maxime Coquelin
This patch introduces new callbacks for setting and getting vring state. Signed-off-by: Maxime Coquelin Reviewed-by: Chenbo Xia --- drivers/net/virtio/virtio_user/vhost.h| 3 + drivers/net/virtio/virtio_user/vhost_kernel.c | 49 +++- drivers/net/virtio/virtio_user/vhost_user.c

[dpdk-dev] [PATCH v3 28/44] net/virtio: add Virtio-user protocol features ops

2021-01-25 Thread Maxime Coquelin
This patch introduces new callbacks for getting and setting Vhost-user protocol features. Signed-off-by: Maxime Coquelin --- drivers/net/virtio/virtio_user/vhost.h| 2 + drivers/net/virtio/virtio_user/vhost_user.c | 64 +-- drivers/net/virtio/virtio_user/vhost_vdpa.c

[dpdk-dev] [PATCH v3 27/44] net/virtio: add Virtio-user features ops

2021-01-25 Thread Maxime Coquelin
This patch introduces new callbacks for getting and setting Virtio features, and implements them for the different backend types. Signed-off-by: Maxime Coquelin --- drivers/net/virtio/virtio_user/vhost.h| 2 + drivers/net/virtio/virtio_user/vhost_kernel.c | 150 +- .../

[dpdk-dev] [PATCH v3 26/44] net/virtio: add Virtio-user ops to set owner

2021-01-25 Thread Maxime Coquelin
This patch implements a dedicated callback for sending owner request. All the requests will be converted that way so that backends other than Vhost-user don't have to work around being it. Signed-off-by: Maxime Coquelin Reviewed-by: Chenbo Xia --- drivers/net/virtio/virtio_user/vhost.h|

[dpdk-dev] [PATCH v3 25/44] net/virtio: make Vhost-user request sender consistent

2021-01-25 Thread Maxime Coquelin
This patch makes vhost_user_write() consistent with vhost_user_read(), by passing a Vhost-user message pointer instead of a buffer pointer and its length, which is now calculated in the function. Signed-off-by: Maxime Coquelin Reviewed-by: Chenbo Xia --- drivers/net/virtio/virtio_user/vhost_use

[dpdk-dev] [PATCH v3 23/44] net/virtio: move vring alignment to generic header

2021-01-25 Thread Maxime Coquelin
This patch moves vring alignment define to the generic Virtio header. Signed-off-by: Maxime Coquelin Reviewed-by: Chenbo Xia Reviewed-by: David Marchand --- drivers/net/virtio/virtio.h | 3 +++ drivers/net/virtio/virtio_ethdev.c | 10 +- drivers/net/virtio/virtio_pci.

[dpdk-dev] [PATCH v3 24/44] net/virtio: remove last PCI refs in non-PCI code

2021-01-25 Thread Maxime Coquelin
This patch finalizes the bus isolation part of this refactoring. Signed-off-by: Maxime Coquelin Reviewed-by: Chenbo Xia Reviewed-by: David Marchand --- drivers/net/virtio/virtio_ethdev.c | 21 +--- drivers/net/virtio/virtio_rxtx.c | 18 - d

[dpdk-dev] [PATCH v3 21/44] net/virtio: move config definitions to generic header

2021-01-25 Thread Maxime Coquelin
This patch moves config and status definitions from the PCI header to the generic one. Signed-off-by: Maxime Coquelin Reviewed-by: Chenbo Xia --- drivers/net/virtio/virtio.c | 43 +++ drivers/net/virtio/virtio.h | 50 ++ drivers/net/vi

[dpdk-dev] [PATCH v3 22/44] net/virtio: make interrupt handling more generic

2021-01-25 Thread Maxime Coquelin
This patch aims at isolating MSIX notion into PCI layer. Signed-off-by: Maxime Coquelin Reviewed-by: David Marchand --- drivers/net/virtio/virtio.c | 6 drivers/net/virtio/virtio.h | 11 +-- drivers/net/virtio/virtio_ethdev.c | 7 ++--- drivers/net/virtio

[dpdk-dev] [PATCH v3 20/44] net/virtio: move virtqueue defines in generic header

2021-01-25 Thread Maxime Coquelin
This patch moves the virtqueues defines from PCI header to the generic one. Signed-off-by: Maxime Coquelin Reviewed-by: Chenbo Xia --- drivers/net/virtio/virtio.h| 18 ++ drivers/net/virtio/virtio_ethdev.h | 4 +++- drivers/net/virtio/virtio_pci.

[dpdk-dev] [PATCH v3 19/44] net/virtio: move features definition to generic header

2021-01-25 Thread Maxime Coquelin
This patch moves all the Virtio definition to the generic header. It also renames some helpers to no more reference PCI. Signed-off-by: Maxime Coquelin --- drivers/net/virtio/meson.build| 3 +- drivers/net/virtio/virtio.c | 22 drivers/net/virtio/virtio.

[dpdk-dev] [PATCH v3 18/44] net/virtio: introduce generic virtio header

2021-01-25 Thread Maxime Coquelin
This patch moves virtio_hw and virtio callbacks into a generic virtio header, now that they have been curated from PCI references. Signed-off-by: Maxime Coquelin Reviewed-by: Chenbo Xia --- drivers/net/virtio/virtio.h | 74 ++ drivers/net/virtio/virtio_ethdev.c

[dpdk-dev] [PATCH v3 17/44] net/virtio: move legacy IO to Virtio PCI

2021-01-25 Thread Maxime Coquelin
This patch moves Virtio PCI legacy IO handling to virtio_pci.c. Two functions are created so that virtio_pci_ethdev does not have to care about it. Signed-off-by: Maxime Coquelin Reviewed-by: Chenbo Xia Reviewed-by: David Marchand --- drivers/net/virtio/virtio_pci.c| 28 +++

[dpdk-dev] [PATCH v3 16/44] net/virtio: pack virtio HW struct

2021-01-25 Thread Maxime Coquelin
This patch improves the virtio_hw struct packing, going from 88 down to 80 bytes with a 6 bytes hole in the end of the first cacheline. Fields only used in the slow path are placed in the end, so that hot path only uses the first cacheline. The patch also changes booleans fields to uint8_t type, a

[dpdk-dev] [PATCH v3 15/44] net/virtio: move PCI-specific fields to PCI device

2021-01-25 Thread Maxime Coquelin
This patch moves the fields from virtio_hw structure that are PCI-specific to virtio_pci_dev_struct. Signed-off-by: Maxime Coquelin Reviewed-by: Chenbo Xia Reviewed-by: David Marchand --- drivers/net/virtio/virtio_pci.c | 139 ++-- drivers/net/virtio/virtio_pci.h |

[dpdk-dev] [PATCH v3 14/44] net/virtio: remove bus type enum

2021-01-25 Thread Maxime Coquelin
Bus type awareness at the generic ethdev level is no more needed as previous patches have made it bus-agnostic. This patch removes it from struct virtio_hw. Signed-off-by: Maxime Coquelin Reviewed-by: Chenbo Xia Reviewed-by: David Marchand --- drivers/net/virtio/virtio_ethdev.c | 18

[dpdk-dev] [PATCH v3 13/44] net/virtio: validate features at bus level

2021-01-25 Thread Maxime Coquelin
This patch provides a new callback for the bus type to validate negotiated features are compatible with it. Only user for now is PCI modern bus type, which implies that the device supports Virtio 1.0+. Signed-off-by: Maxime Coquelin Reviewed-by: Chenbo Xia --- drivers/net/virtio/virtio_ethdev.

[dpdk-dev] [PATCH v3 12/44] net/virtio: add callback for device closing

2021-01-25 Thread Maxime Coquelin
This patch introduces a new callback for device closing, making virtio_dev_close() bus-agnostic. Signed-off-by: Maxime Coquelin Reviewed-by: Chenbo Xia Reviewed-by: David Marchand --- drivers/net/virtio/meson.build | 2 -- drivers/net/virtio/virtio_ethdev.c | 13 + d

[dpdk-dev] [PATCH v3 11/44] net/virtio: store PCI type in Virtio device metadata

2021-01-25 Thread Maxime Coquelin
Going further in making the Virtio ethdev layer bus agnostic, this patch adds a boolean in the Virtio PCI device metadata. Signed-off-by: Maxime Coquelin Reviewed-by: Chenbo Xia Reviewed-by: David Marchand --- drivers/net/virtio/virtio_pci.c| 18 +++--- drivers/net/virtio/v

[dpdk-dev] [PATCH v3 10/44] net/virtio: force IOVA as VA mode for Virtio-user

2021-01-25 Thread Maxime Coquelin
At least Vhost-user backend of Virtio-user PMD requires IOVA as VA mode. Until now, it was implemented as a hack by forcing to use mbuf's buf_addr field instead of buf_iova. This patch removes all this logic and just fails probing if IOVA as VA mode is not selected. It simplifies the code overall,

[dpdk-dev] [PATCH v3 08/44] net/virtio: move PCI specific dev init to PCI ethdev init

2021-01-25 Thread Maxime Coquelin
This patch moves the PCI specific initialization from eth_virtio_dev_init() to eth_virtio_pci_init(). Signed-off-by: Maxime Coquelin Reviewed-by: Chenbo Xia Reviewed-by: David Marchand --- drivers/net/virtio/virtio_ethdev.c | 63 +-- drivers/net/virtio/virtio_pci_ethdev

[dpdk-dev] [PATCH v3 09/44] net/virtio: move MSIX detection to PCI ethdev

2021-01-25 Thread Maxime Coquelin
This patch introduces a new callback to notify the bus driver some interrupt related operation was done. This is used by Virtio PCI driver to check msix status. Signed-off-by: Maxime Coquelin --- drivers/net/virtio/virtio_ethdev.c | 12 +-- drivers/net/virtio/virtio_pci.c| 120

[dpdk-dev] [PATCH v3 07/44] net/virtio: move PCI device init in dedicated file

2021-01-25 Thread Maxime Coquelin
This patch moves the PCI Ethernet device registration bits in a dedicated patch. In following patches, more code will be moved there, with the goal of making virtio_ethdev.c truly bus-agnostic. Signed-off-by: Maxime Coquelin Reviewed-by: Chenbo Xia --- drivers/net/virtio/meson.build |

  1   2   >