[dpdk-dev] [PATCH] net/bnxt: fix null termination of receive mbuf chain

2021-01-22 Thread Lance Richardson
The last mbuf in a multi-segment packet needs to be NULL-terminated. Fixes: 0958d8b6435d ("net/bnxt: support LRO") Cc: sta...@dpdk.org Signed-off-by: Lance Richardson Reviewed-by: Somnath Kotur Reviewed-by: Ajit Kumar Khaparde --- drivers/net/bnxt/bnxt_rxr.c | 1 + 1 file changed, 1 insertion(

[dpdk-dev] [PATCH v9 3/3] pmdinfogen: remove C implementation

2021-01-22 Thread Dmitry Kozlyuk
Delete the files no longer used in build process. Add myself as maintainer of new implementation. Signed-off-by: Dmitry Kozlyuk --- MAINTAINERS| 3 +- buildtools/pmdinfogen/meson.build | 14 - buildtools/pmdinfogen/pmdinfogen.c | 456 - bui

[dpdk-dev] [PATCH v9 2/3] build: use Python pmdinfogen

2021-01-22 Thread Dmitry Kozlyuk
Use the same interpreter to run pmdinfogen as for other build scripts. Adjust wrapper script accordingly and also don't suppress stderr from ar and pmdinfogen. Add configure-time check for elftools Python module for Unix hosts. Add pyelftools to CI configuration and build requirements for Linux a

[dpdk-dev] [PATCH v9 1/3] pmdinfogen: add Python implementation

2021-01-22 Thread Dmitry Kozlyuk
Using a high-level, interpreted language simplifies maintenance and build process. Furthermore, ELF handling is delegated to pyelftools package. Original logic is kept, the copyright recognizes that. Signed-off-by: Dmitry Kozlyuk --- buildtools/pmdinfogen.py | 189 +++

[dpdk-dev] [PATCH v9 0/3] pmdinfogen: rewrite in Python

2021-01-22 Thread Dmitry Kozlyuk
This patchset implements existing pmdinfogen logic in Python, replaces and removes the old code. The goals of rewriting are: * easier maintenance by using a more high-level language, * simpler build process without host application and libelf, * foundation for adding Windows support. Canonical JS

Re: [dpdk-dev] [PATCH v8 2/3] build: use Python pmdinfogen

2021-01-22 Thread Dmitry Kozlyuk
On Fri, 22 Jan 2021 21:57:15 +0100, Thomas Monjalon wrote: > 22/01/2021 21:31, Dmitry Kozlyuk: > > On Wed, 20 Jan 2021 11:24:21 +0100, Thomas Monjalon wrote: > > > 20/01/2021 08:23, Dmitry Kozlyuk: > > > > On Wed, 20 Jan 2021 01:05:59 +0100, Thomas Monjalon wrote: > > > > > This is now the

Re: [dpdk-dev] [PATCH v8 2/3] build: use Python pmdinfogen

2021-01-22 Thread Thomas Monjalon
22/01/2021 21:31, Dmitry Kozlyuk: > On Wed, 20 Jan 2021 11:24:21 +0100, Thomas Monjalon wrote: > > 20/01/2021 08:23, Dmitry Kozlyuk: > > > On Wed, 20 Jan 2021 01:05:59 +0100, Thomas Monjalon wrote: > > > > This is now the right timeframe to introduce this change > > > > with the new Python module

Re: [dpdk-dev] [PATCH v8 2/3] build: use Python pmdinfogen

2021-01-22 Thread Dmitry Kozlyuk
On Wed, 20 Jan 2021 11:24:21 +0100, Thomas Monjalon wrote: > 20/01/2021 08:23, Dmitry Kozlyuk: > > On Wed, 20 Jan 2021 01:05:59 +0100, Thomas Monjalon wrote: > > > This is now the right timeframe to introduce this change > > > with the new Python module dependency. > > > Unfortunately, the ABI ch

[dpdk-dev] [PATCH v2 37/37] net/mvpp2: add fill buffs to configuration file

2021-01-22 Thread lironh
From: Dana Vardi Extend config file with 'fill_bpool_buffs' which control the amount of refill buffers Signed-off-by: Dana Vardi Reviewed-by: Liron Himi --- drivers/net/mvpp2/mrvl_ethdev.c | 7 --- drivers/net/mvpp2/mrvl_ethdev.h | 3 +++ drivers/net/mvpp2/mrvl_qos.c| 21 +++

[dpdk-dev] [PATCH v2 36/37] net/mvpp2: update qos defaults parameter name

2021-01-22 Thread lironh
From: Dana Vardi 'global_default' is only being used for 'qos' so adding 'qos' into its name Signed-off-by: Dana Vardi Reviewed-by: Liron Himi --- drivers/net/mvpp2/mrvl_ethdev.c | 2 +- drivers/net/mvpp2/mrvl_qos.c| 12 ++-- drivers/net/mvpp2/mrvl_qos.h| 2 +- 3 files chang

[dpdk-dev] [PATCH v2 34/37] net/mvpp2: support custom header before ethernet

2021-01-22 Thread lironh
From: Dana Vardi Extend 'start_hdr' options with custom header. Signed-off-by: Dana Vardi Reviewed-by: Liron Himi --- drivers/net/mvpp2/mrvl_qos.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/net/mvpp2/mrvl_qos.c b/drivers/net/mvpp2/mrvl_qos.c index e420c0cbc..9fec3c156 10

[dpdk-dev] [PATCH v2 35/37] net/mvpp2: forward bad packets support

2021-01-22 Thread lironh
From: Dana Vardi Extend the config file with option to forward packets that were marked as "l2 bad pkts". by default the driver drop those packets Signed-off-by: Dana Vardi Reviewed-by: Liron Himi --- drivers/net/mvpp2/mrvl_ethdev.c | 10 -- drivers/net/mvpp2/mrvl_ethdev.h | 2 ++ dr

[dpdk-dev] [PATCH v2 33/37] net/mvpp2: consider ptype in cksum info

2021-01-22 Thread lironh
From: Liron Himi Provide checksum information based on the ptype. Signed-off-by: Liron Himi --- drivers/net/mvpp2/mrvl_ethdev.c | 34 +++-- 1 file changed, 20 insertions(+), 14 deletions(-) diff --git a/drivers/net/mvpp2/mrvl_ethdev.c b/drivers/net/mvpp2/mrvl_ethde

[dpdk-dev] [PATCH v2 32/37] net/mvpp2: update start hdr name

2021-01-22 Thread lironh
From: Dana Vardi Change 'dsa_mode' to 'start_hdr' in config file Signed-off-by: Dana Vardi Reviewed-by: Liron Himi --- drivers/net/mvpp2/mrvl_qos.c | 29 +++-- 1 file changed, 19 insertions(+), 10 deletions(-) diff --git a/drivers/net/mvpp2/mrvl_qos.c b/drivers/net/mv

[dpdk-dev] [PATCH v2 31/37] net/mvpp2: apply flow-ctrl after port init

2021-01-22 Thread lironh
From: Liron Himi In case ppio was not initialized yet (only at 'start' function) the flow-ctrl setting should be saved for later stage. Signed-off-by: Liron Himi --- drivers/net/mvpp2/mrvl_ethdev.c | 26 +- drivers/net/mvpp2/mrvl_ethdev.h | 2 ++ 2 files changed, 23 in

[dpdk-dev] [PATCH v2 30/37] net/mvpp2: add 2.5G LINK info

2021-01-22 Thread lironh
From: Meir Levi Update capability with 2.5G support Signed-off-by: Meir Levi Reviewed-by: Liron Himi --- drivers/net/mvpp2/mrvl_ethdev.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/net/mvpp2/mrvl_ethdev.c b/drivers/net/mvpp2/mrvl_ethdev.c index 41971394d..2cc8320df 100644

[dpdk-dev] [PATCH v2 29/37] net/mvpp2: expose max MTU size

2021-01-22 Thread lironh
From: Liron Himi Expose max-MTU based on the max frame size that l4 checksum generation can be done by HW. Signed-off-by: Liron Himi Reviewed-by: Yuri Chipchev --- drivers/net/mvpp2/mrvl_ethdev.c | 24 ++-- drivers/net/mvpp2/mrvl_ethdev.h | 1 + 2 files changed, 23 insert

[dpdk-dev] [PATCH v2 28/37] net/mvpp2: autoneg disable handling

2021-01-22 Thread lironh
From: Yuri Chipchev Flow control autoneg disable is not supported Signed-off-by: Yuri Chipchev Reviewed-by: Liron Himi --- drivers/net/mvpp2/mrvl_ethdev.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/net/mvpp2/mrvl_ethdev.c b/drivers/net/mvpp2/mrvl_ethd

[dpdk-dev] [PATCH v2 27/37] net/mvpp2: propagate port-id in udata64

2021-01-22 Thread lironh
From: Liron Himi mbuf->port can be override and used for eventdev so saving the port-id information in another field that can be queried by application Signed-off-by: Liron Himi --- drivers/net/mvpp2/mrvl_ethdev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/mvpp2/mrvl_ethde

[dpdk-dev] [PATCH v2 26/37] net/mvpp2: introduce fixup for fifo overrun

2021-01-22 Thread lironh
From: Liron Himi Currently the HW is configured with only one pool which its buffer size may be larger than the rx-fifo-size. In that situation, frame size larger than the fifo-size is gets dropped due to fifo overrun. this is cause because the HW works in cut-through mode which waits to have in

[dpdk-dev] [PATCH v2 25/37] net/mvpp2: rearrange functions order

2021-01-22 Thread lironh
From: Liron Himi Rearrange functions order Signed-off-by: Liron Himi --- drivers/net/mvpp2/mrvl_ethdev.c | 98 - 1 file changed, 49 insertions(+), 49 deletions(-) diff --git a/drivers/net/mvpp2/mrvl_ethdev.c b/drivers/net/mvpp2/mrvl_ethdev.c index 47f9e9443..12

[dpdk-dev] [PATCH v2 24/37] net/mvpp2: support udf configuration

2021-01-22 Thread lironh
From: Liron Himi Extend the config file with 'udf' (user-defined) settings Signed-off-by: Liron Himi --- drivers/net/mvpp2/mrvl_ethdev.c | 4 +- drivers/net/mvpp2/mrvl_qos.c| 212 drivers/net/mvpp2/mrvl_qos.h| 3 + 3 files changed, 218 insertions(+)

[dpdk-dev] [PATCH v2 23/37] net/mvpp2: skip qos init if not requested

2021-01-22 Thread lironh
From: Liron Himi Skip qos init if not requested Signed-off-by: Liron Himi --- drivers/net/mvpp2/mrvl_qos.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/mvpp2/mrvl_qos.c b/drivers/net/mvpp2/mrvl_qos.c index d3ad7cc5a..1c65b5276 100644 --- a/drivers/net/mvp

[dpdk-dev] [PATCH v2 22/37] net/mvpp2: flow: add support for RAW type

2021-01-22 Thread lironh
From: Liron Himi Add support for RAW type and connect it to MUSDK UDF Signed-off-by: Liron Himi --- drivers/net/mvpp2/mrvl_ethdev.h | 1 + drivers/net/mvpp2/mrvl_flow.c | 141 2 files changed, 142 insertions(+) diff --git a/drivers/net/mvpp2/mrvl_ethdev.h

[dpdk-dev] [PATCH v2 21/37] net/mvpp2: move common functions to common location

2021-01-22 Thread lironh
From: Liron Himi Move common functions to common location Signed-off-by: Liron Himi --- drivers/net/mvpp2/mrvl_ethdev.h | 41 + drivers/net/mvpp2/mrvl_qos.c| 24 --- 2 files changed, 41 insertions(+), 24 deletions(-) diff --git a/drivers/net

[dpdk-dev] [PATCH v2 20/37] net/mvpp2: flow: build table key along with rule

2021-01-22 Thread lironh
From: Liron Himi Currently the key is always built in network order regardless of user input. Besides the fact that it is not in user order, it prevent future support for udf header between standard headers. this patch builds the key while parsing the given rule. Signed-off-by: Liron Himi ---

[dpdk-dev] [PATCH v2 19/37] net/mvpp2: flow: support generic pattern combinations

2021-01-22 Thread lironh
From: Liron Himi Currently only specific pattern combinations are supported. this makes it hard to support additional pattern. in addition there is no a real limitation that prevent any combination. This patch iterate the input patterns and convert them to a mvpp2 API. The doc doesn't describes

[dpdk-dev] [PATCH v2 18/37] net/mvpp2: use generic name for the 'cfg'

2021-01-22 Thread lironh
From: Liron Himi As the config file is not just for 'qos' it is more accurate to replace the name from 'qos_cfg' to 'cfg' Signed-off-by: Liron Himi --- drivers/net/mvpp2/mrvl_ethdev.c | 12 ++-- drivers/net/mvpp2/mrvl_qos.c| 31 +++ drivers/net/mvpp2/mrv

[dpdk-dev] [PATCH v2 17/37] net/mvpp2: adjust the number of unicast address

2021-01-22 Thread lironh
From: Liron Himi HW support 25 mac address for filtering plus one for the primary mac address. Signed-off-by: Liron Himi --- drivers/net/mvpp2/mrvl_ethdev.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/mvpp2/mrvl_ethdev.c b/drivers/net/mvpp2/mrvl_ethdev

[dpdk-dev] [PATCH v2 14/37] net/mvpp2: update Tx checksum

2021-01-22 Thread lironh
From: Liron Himi According to the dpdk spec, only 'ol_flags' should be used for tx checksum generation Signed-off-by: Liron Himi --- drivers/net/mvpp2/mrvl_ethdev.c | 60 ++--- 1 file changed, 26 insertions(+), 34 deletions(-) diff --git a/drivers/net/mvpp2/mrvl_et

[dpdk-dev] [PATCH v2 16/37] net/mvpp2: add Tx flow control

2021-01-22 Thread lironh
From: Yuri Chipchev Add tx flow control operations. Signed-off-by: Yuri Chipchev Reviewed-by: Liron Himi --- drivers/net/mvpp2/mrvl_ethdev.c | 59 - 1 file changed, 51 insertions(+), 8 deletions(-) diff --git a/drivers/net/mvpp2/mrvl_ethdev.c b/drivers/net/mvp

[dpdk-dev] [PATCH v2 13/37] net/mvpp2: add VLAN offload support

2021-01-22 Thread lironh
From: Yuri Chipchev Enable VLAN filter configuration Signed-off-by: Yuri Chipchev Reviewed-by: Liron Himi --- drivers/net/mvpp2/mrvl_ethdev.c | 110 +--- 1 file changed, 86 insertions(+), 24 deletions(-) diff --git a/drivers/net/mvpp2/mrvl_ethdev.c b/drivers/net/m

[dpdk-dev] [PATCH v2 15/37] net/mvpp2: add dsa mode support

2021-01-22 Thread lironh
From: Liron Himi Extend the config file with 'start-hdr' field. currently 'eth' (default) and 'dsa' headers are supported. Signed-off-by: Liron Himi --- drivers/net/mvpp2/mrvl_ethdev.c | 4 ++ drivers/net/mvpp2/mrvl_qos.c| 65 ++--- drivers/net/mvpp2/mrvl_qos.h

[dpdk-dev] [PATCH v2 12/37] net/mvpp2: add loopback support

2021-01-22 Thread lironh
From: Yuri Chipchev Add support for loopback mode Signed-off-by: Yuri Chipchev Reviewed-by: Liron Himi --- drivers/net/mvpp2/mrvl_ethdev.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/mvpp2/mrvl_ethdev.c b/drivers/net/mvpp2/mrvl_ethdev.c index 3891313cf..fc04e1abb 100

[dpdk-dev] [PATCH v2 11/37] net/mvpp2: save initial configuration

2021-01-22 Thread lironh
From: Yuri Chipchev Save configuration that was done prior 'start' as only then the ppio is being configured. Signed-off-by: Yuri Chipchev Reviewed-by: Liron Himi --- drivers/net/mvpp2/mrvl_ethdev.c | 107 +++- 1 file changed, 92 insertions(+), 15 deletions(-) dif

[dpdk-dev] [PATCH v2 10/37] net/mvpp2: align checking order

2021-01-22 Thread lironh
From: Yuri Chipchev First check for 'isolated' and then for '!ppio' Signed-off-by: Yuri Chipchev Reviewed-by: Liron Himi --- drivers/net/mvpp2/mrvl_ethdev.c | 40 +++-- 1 file changed, 23 insertions(+), 17 deletions(-) diff --git a/drivers/net/mvpp2/mrvl_ethdev.c

[dpdk-dev] [PATCH v2 09/37] net/mvpp2: cosmetic changes to cookie usage

2021-01-22 Thread lironh
From: Yuri Chipchev No need to add high address to cookie on transmit side, as it has already 64bit value Signed-off-by: Yuri Chipchev Reviewed-by: Liron Himi --- drivers/net/mvpp2/mrvl_ethdev.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/net/mvpp

[dpdk-dev] [PATCH v2 08/37] net/mvpp2: extend xstats support

2021-01-22 Thread lironh
From: Yuri Chipchev Add xstats_by_id callbacks Signed-off-by: Yuri Chipchev Reviewed-by: Liron Himi --- drivers/net/mvpp2/mrvl_ethdev.c | 98 - 1 file changed, 95 insertions(+), 3 deletions(-) diff --git a/drivers/net/mvpp2/mrvl_ethdev.c b/drivers/net/mvpp2/mr

[dpdk-dev] [PATCH v2 07/37] net/mvpp2: update RSS tables reservation

2021-01-22 Thread lironh
From: Yuri Chipchev In kernel-4.14 the pp2 kernel occupied 4 RSS tables as opposed to 1 RSS table in older version. Signed-off-by: Yuri Chipchev Reviewed-by: Liron Himi --- drivers/net/mvpp2/mrvl_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/mvpp2/mr

[dpdk-dev] [PATCH v2 06/37] net/mvpp2: fix frame size checking

2021-01-22 Thread lironh
From: Liron Himi Need to add CRC len to the frame-size to compare against max_rx_pkt_len which includes it. Fixes: 79ec62028 ("net/mvpp2: update MTU and MRU related calculations") Cc: sta...@dpdk.org Signed-off-by: Liron Himi Reviewed-by: Yuri Chipchev --- drivers/net/mvpp2/mrvl_ethdev.c | 3

[dpdk-dev] [PATCH v2 05/37] net/mvpp2: remove CRC len from MRU validation

2021-01-22 Thread lironh
From: Liron Himi CRC is being removed by HW before packet get write to the buffer, so CRC len should not be included in MRU validation Fixes: 79ec62028 ("net/mvpp2: update MTU and MRU related calculations") Cc: sta...@dpdk.org Signed-off-by: Liron Himi Reviewed-by: Yuri Chipchev --- drivers/

[dpdk-dev] [PATCH v2 04/37] net/mvpp2: remove VLAN flush

2021-01-22 Thread lironh
From: Liron Himi VLAN-flush in MUSDK is not supported yet. until it does, the code should be removed as currently an redundant error message is displayed. Fixes: a8f3d6783 ("net/mrvl: support VLAN filtering") Cc: sta...@dpdk.org Signed-off-by: Liron Himi --- drivers/net/mvpp2/mrvl_ethdev.c |

[dpdk-dev] [PATCH v2 03/37] net/mvpp2: fix Rx/Tx bytes statistics

2021-01-22 Thread lironh
From: Yuri Chipchev 4B of CRC was not included in the bytes statistics Fixes: bdffe0c70 ("net/mrvl: support basic stats") Cc: sta...@dpdk.org Signed-off-by: Yuri Chipchev Reviewed-by: Liron Himi --- drivers/net/mvpp2/mrvl_ethdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) di

[dpdk-dev] [PATCH v2 02/37] net/mvpp2: remove debug log on fast-path

2021-01-22 Thread lironh
From: Liron Himi In case of non-ip frame the current code reached the 'default' case which result with function call to log a msg. those kind of calls should not be performed on fast-path. The performance for this kind of frames increased by 50% Fixes: acab7d58c ("net/mvpp2: convert to dynamic

[dpdk-dev] [PATCH v2 01/37] net/mvpp2: fix stack corruption

2021-01-22 Thread lironh
From: Yuri Chipchev Fixes stack corruption in mrvl_fill_bpool function in case num > MRVL_PP2_RXD_MAX Fixes: c3637258d894 ("net/mrvl: fix Rx descriptors number") Cc: sta...@dpdk.org Signed-off-by: Yuri Chipchev Reviewed-by: Liron Himi --- drivers/net/mvpp2/mrvl_ethdev.c | 4 ++-- 1 file chan

[dpdk-dev] [PATCH v2 00/37] net/mvpp2: misc updates

2021-01-22 Thread lironh
From: Liron Himi This patch series align the mainline driver with all changes since 19.11 some of the patches are fixes which should be pushed to stable v2: - fix commit msg styling - Addressed various review comments Dana Vardi (5): net/mvpp2: update start hdr name net/mvpp2: support custo

Re: [dpdk-dev] [PATCH v4 02/22] app/testpmd: fix max rx packet length for VLAN packets

2021-01-22 Thread Lance Richardson
On Thu, Jan 21, 2021 at 10:27 AM Lance Richardson wrote: > > On Mon, Jan 18, 2021 at 2:08 AM Steve Yang wrote: > > > > When the max rx packet length is smaller than the sum of mtu size and > > ether overhead size, it should be enlarged, otherwise the VLAN packets > > will be dropped. > > > > Remo

[dpdk-dev] [PATCH 1/1] ethdev: fix handling of close failure

2021-01-22 Thread Thomas Monjalon
If a failure happens when closing a port, it was unnecessarily failing again in the function eth_err(), because of a check against HW removal cause. Indeed there is a big chance the port is released at this point. Given the port is in the middle (or at the end) of a close process, checking the erro

Re: [dpdk-dev] [PATCH 21.02 v2] mem: don't warn about base addr if not requested

2021-01-22 Thread Burakov, Anatoly
On 09-Nov-20 3:47 PM, Anatoly Burakov wrote: Any EAL memory allocation often goes through eal_get_virtual_area() function, which will print a warning whenever the resulting allocation didn't match the specified address requirements. This is useful for when we have requested a specific base virtua

[dpdk-dev] [PATCH v3] mem: improve parameter checking on memory hotplug

2021-01-22 Thread Anatoly Burakov
Currently, we don't check anything that comes in through memory hotplug subsystem using the IPC, because we always assume the data is correct. This is okay as anyone having access to the IPC socket would also have rights to crash the DPDK process through other means, but it's still a good practice

Re: [dpdk-dev] [PATCH v3 3/3] app/testpmd: fix dynamic config error

2021-01-22 Thread Ferruh Yigit
On 1/22/2021 5:04 PM, Ferruh Yigit wrote: On 1/22/2021 9:01 AM, Steve Yang wrote: The offloads of 'tx/rx_conf' didn't keep up with the corresponding offloads of 'dev_conf' if rx queue capability was 0, it would cause the configuration invalid. For example: Configuring 'max-pkt-len' would change

[dpdk-dev] [PATCH v20 4/4] examples/l3fwd-power: enable PMD power mgmt

2021-01-22 Thread Anatoly Burakov
From: Liang Ma Add PMD power management feature support to l3fwd-power sample app. Signed-off-by: Liang Ma Signed-off-by: Anatoly Burakov Acked-by: David Hunt --- Notes: v20: - Moved Rx callback removal to before port close v12: - Allow selecting PMD power management sch

[dpdk-dev] [PATCH v20 3/4] power: add PMD power management API and callback

2021-01-22 Thread Anatoly Burakov
From: Liang Ma Add a simple on/off switch that will enable saving power when no packets are arriving. It is based on counting the number of empty polls and, when the number reaches a certain threshold, entering an architecture-defined optimized power state that will either wait until a TSC timest

[dpdk-dev] [PATCH v20 2/4] eal: improve comments around power monitoring API

2021-01-22 Thread Anatoly Burakov
Currently, the API documentation is ambiguous as to what happens when certain conditions are met. Document the behavior explicitly, as well as fix some typos and outdated comments. Fixes: 6a17919b0e2a ("eal: change power intrinsics API") Signed-off-by: Anatoly Burakov --- .../include/generic/rt

[dpdk-dev] [PATCH v20 1/4] eal: rename power monitor condition member

2021-01-22 Thread Anatoly Burakov
The `data_sz` name is fine, but it looks out of place because nothing else has "data" prefix in that structure. Rename it to "size", as well as add more clarity to the comments around each struct member. Fixes: 6a17919b0e2a ("eal: change power intrinsics API") Signed-off-by: Anatoly Burakov ---

[dpdk-dev] [PATCH v20 0/4] Add PMD power management

2021-01-22 Thread Anatoly Burakov
This patchset proposes a simple API for Ethernet drivers to cause the CPU to enter a power-optimized state while waiting for packets to arrive. There are multiple proposed mechanisms to achieve said power savings: simple frequency scaling, idle loop, and monitoring the Rx queue for incoming pac

[dpdk-dev] [PATCH v3 2/2] net/mlx5: add mbuf fast free offload support

2021-01-22 Thread Viacheslav Ovsiienko
This patch adds support of the mbuf fast free offload to the transmit datapath. This offload allows freeing the mbufs on transmit completion in the most efficient way. It requires the all mbufs were allocated from the same pool, have the reference counter value as 1, and have no any externally atta

[dpdk-dev] [PATCH v3 1/2] net/mlx5: optimize inline mbuf freeing

2021-01-22 Thread Viacheslav Ovsiienko
The mlx5 PMD supports packet data inlining by pushing data to the transmit descriptor. If packet is short enough and all data are inline, the mbuf is not needed for data send anymore and can be freed. The mbuf free was performed in the most inner loop building the transmit descriptors. This patch

[dpdk-dev] [PATCH v3 0/2] add mbuf fast free offload support

2021-01-22 Thread Viacheslav Ovsiienko
This patch adds support of the mbuf fast free offload to the transmit datapath. This offload allows to free the mbufs on transmit completion in the most efficient way. It requires the all mbufs were allocated from the same pool, have the reference counter value as 1, and have no any externally atta

Re: [dpdk-dev] [PATCH v3 3/3] app/testpmd: fix dynamic config error

2021-01-22 Thread Ferruh Yigit
On 1/22/2021 9:01 AM, Steve Yang wrote: The offloads of 'tx/rx_conf' didn't keep up with the corresponding offloads of 'dev_conf' if rx queue capability was 0, it would cause the configuration invalid. For example: Configuring 'max-pkt-len' would change 'rx_offloads' in dev_conf while rx_conf.of

[dpdk-dev] [Bug 624] Port close results in "invalid port_id" log message

2021-01-22 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=624 Bug ID: 624 Summary: Port close results in "invalid port_id" log message Product: DPDK Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: nor

[dpdk-dev] [PATCH 4/4] net/ena: fix Tx sq free space assessment

2021-01-22 Thread Michal Krawczyk
From: Igor Chauskin Before starting transmission of Tx burst, the driver checked the available space in the sq and limited the number of packets for transmission accordingly. The calculation was incorrect for fragmented packets and potentially had significantly limited the length of Tx bursts. T

[dpdk-dev] [PATCH 3/4] net/ena: validate Rx req id upon acquiring the desc

2021-01-22 Thread Michal Krawczyk
Instead of veryfing the Rx descriptor each time it's being used in the driver code, now the verification happens on the HAL side. This simplifies code a lot as instead of doing 2 validations, only single one is needed. The driver have to check the rc value returned by the ena_com upon reading the

[dpdk-dev] [PATCH 2/4] net/ena: Tx doorbell statistics fix

2021-01-22 Thread Michal Krawczyk
From: Amit Bernstein Increment Tx doorbell statistics on tx_pkt_burst after writing to doorbell and in case max burst size achieved Fixes: c7519ea5eb8d ("net/ena: call additional doorbells if needed") Cc: sta...@dpdk.org Signed-off-by: Amit Bernstein Reviewed-by: Michal Krawczyk Reviewed-by:

[dpdk-dev] [PATCH 1/4] net/ena: flush Rx buffers memory pool cache

2021-01-22 Thread Michal Krawczyk
From: Ido Segev As the refill called as part of ena_start(), we end up the refill progress with stuck buffers at the caller core cache. Calling to flush the cache results with invalidate this cache and free those stuck buffers. Fixes: 1173fca25af9 ("ena: add polling-mode driver") Cc: sta...@dpd

[dpdk-dev] [PATCH 0/4] net/ena: minor bug fixes and improvements

2021-01-22 Thread Michal Krawczyk
Hi, this patchset contains few bug fixes for the ENA PMD and the version upgrade to v2.2.1. Besides that, the validation of the Rx req ID was optimized. Best regards, Michal Amit Bernstein (1): net/ena: Tx doorbell statistics fix Ido Segev (1): net/ena: flush Rx buffers memory pool cache I

Re: [dpdk-dev] [PATCH v2] app/testpmd: fix RSS key

2021-01-22 Thread Ferruh Yigit
On 1/22/2021 5:43 AM, Zhou, JunX W wrote: <...> -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Zhang,Alvin Sent: Thursday, January 21, 2021 5:42 PM To: Yigit, Ferruh Cc: dev@dpdk.org; Zhang, AlvinX ; sta...@dpdk.org Subject: [dpdk-dev] [PATCH v2] app/testpmd: fix

Re: [dpdk-dev] [PATCH] doc: update i40e PMD to support on windows

2021-01-22 Thread Kadam, Pallavi
On 1/22/2021 3:16 AM, Thomas Monjalon wrote: 21/01/2021 20:09, Pallavi Kadam: Add documentation to support i40e PMD on Windows. Update the release notes for the same. Signed-off-by: Pallavi Kadam Reviewed-by: Ranjit Menon --- doc/guides/nics/i40e.rst | 16 ++--

Re: [dpdk-dev] [PATCH v4 6/6] power: clean up includes

2021-01-22 Thread Burakov, Anatoly
On 21-Jan-21 5:22 PM, David Hunt wrote: From: Bruce Richardson re-organise the including of the new public header file and remove un-needed includes Fixes: 210c383e247b ("power: packet format for vm power management") Fixes: cd0d5547e873 ("power: vm communication channels in guest") Cc: sta...

Re: [dpdk-dev] [PATCH v4 5/6] power: add new header file to export list

2021-01-22 Thread Burakov, Anatoly
On 21-Jan-21 5:22 PM, David Hunt wrote: From: Bruce Richardson Adjust meson.build so that 'ninja install' copies the new header file into the installation directory. Fixes: 210c383e247b ("power: packet format for vm power management") Fixes: cd0d5547e873 ("power: vm communication channels in g

Re: [dpdk-dev] [PATCH v4 4/6] power: rename defines

2021-01-22 Thread Burakov, Anatoly
On 21-Jan-21 5:21 PM, David Hunt wrote: From: Bruce Richardson Rename the #defines to have an RTE_POWER_ prefix Fixes: 210c383e247b ("power: packet format for vm power management") Fixes: cd0d5547e873 ("power: vm communication channels in guest") Cc: sta...@dpdk.org Signed-off-by: Bruce Richa

[dpdk-dev] [PATCH] crypto/octeontx2: fix null pointer dereferences

2021-01-22 Thread Ankur Dwivedi
Coverity reports that pointers ip and ip6 may be dereferenced with null value. This patch fixes this. Coverity issue: 365549 Coverity issue: 365551 Fixes: 1c119d38876d ("crypto/octeontx2: support lookaside AES-CBC SHA1-HMAC") Signed-off-by: Ankur Dwivedi --- drivers/crypto/octeontx2/otx2_crypt

Re: [dpdk-dev] [PATCH v1 1/3] test/ring: reduce iteration numbers to make test duration shorter

2021-01-22 Thread Ananyev, Konstantin
> When testing ring performance in the case that multiple lcores are mapped to > the same physical core, e.g. --lcores '(0-3)@10', it takes a very long time > to wait for the "enqueue_dequeue_bulk_helper" to finish. This is because > too much iteration numbers and extremely low efficiency for enq

Re: [dpdk-dev] [PATCH v1 3/3] ring: rename and refactor ring library

2021-01-22 Thread Ananyev, Konstantin
> For legacy modes, rename ring_generic/c11 to ring_generic/c11_pvt. > Furthermore, add new file ring_elem_pvt.h which includes ring_do_eq/deq > and ring element copy/delete APIs. > > For other modes, rename xx_c11_mem to xx_elem_pvt. Move all private APIs > into these new header files. > > Sug

Re: [dpdk-dev] [PATCH v1] devtools: update abi ignore for cryptodev

2021-01-22 Thread Kinsella, Ray
On 22/01/2021 13:09, Dodji Seketeli wrote: > Thomas Monjalon writes: > > [...] > Then I've added (quickly) a libabigail exception rule: [suppress_type] name = rte_cryptodev has_data_member_inserted_between = {0, 1023} Now we want to improve this rule t

Re: [dpdk-dev] [PATCH v1] devtools: update abi ignore for cryptodev

2021-01-22 Thread Dodji Seketeli
Thomas Monjalon writes: [...] >> > Then I've added (quickly) a libabigail exception rule: >> > >> > [suppress_type] >> >name = rte_cryptodev >> >has_data_member_inserted_between = {0, 1023} >> > >> > Now we want to improve this rule to restrict the offsets >> > to the padding at the end

Re: [dpdk-dev] [PATCH v1 2/3] ring: add rte prefix before update tail API

2021-01-22 Thread Ananyev, Konstantin
> Add __rte prefix before update_tail API because it is a internal > function. > > Signed-off-by: Feifei Wang > Reviewed-by: Honnappa Nagarahalli > Reviewed-by: Ruifeng Wang > --- > lib/librte_ring/rte_ring_c11_mem.h | 4 ++-- > lib/librte_ring/rte_ring_elem.h| 4 ++-- > lib/librte_ring/

Re: [dpdk-dev] [PATCH] build: force pkg-config for dependency detection

2021-01-22 Thread Hemant Agrawal
Tested-by: Hemant Agrawal

Re: [dpdk-dev] meson: wrong dependency in cross compilation on ARM

2021-01-22 Thread Hemant Agrawal
On 1/18/2021 5:46 PM, Ferruh Yigit wrote: On 1/18/2021 12:05 PM, Ferruh Yigit wrote: On 1/18/2021 11:58 AM, Ferruh Yigit wrote: On 1/18/2021 10:51 AM, Bruce Richardson wrote: On Fri, Jan 15, 2021 at 06:40:56PM +, Ferruh Yigit wrote: On 12/21/2020 2:04 PM, Bruce Richardson wrote: On Mon

Re: [dpdk-dev] [PATCH v2 5/5] doc: update the advanced E-switch mirroring supports

2021-01-22 Thread Ferruh Yigit
On 1/12/2021 10:29 AM, Jiawei Wang wrote: Updates the description in MLX5 PMD and release note. Adds the new supports for E-switch mirroring and jump action in the same flow, and handle modify action in correct order regarding the mirroring action on E-Switch. Signed-off-by: Jiawei Wang Acked-

Re: [dpdk-dev] [PATCH] examples/pipeline: fix VXLAN script permission

2021-01-22 Thread Dumitrescu, Cristian
> -Original Message- > From: David Marchand > Sent: Friday, January 22, 2021 9:31 AM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Timothy Redaelli ; Dumitrescu, > Cristian > Subject: [PATCH] examples/pipeline: fix VXLAN script permission > > This python script provides a shebang that onl

Re: [dpdk-dev] [PATCH v4 3/6] power: rename public structs

2021-01-22 Thread Burakov, Anatoly
On 21-Jan-21 5:21 PM, David Hunt wrote: From: Bruce Richardson rename the public structs to have an rte_power_ prefix and add them to version.map in experimental section. Fixes: 210c383e247b ("power: packet format for vm power management") Fixes: cd0d5547e873 ("power: vm communication channels

Re: [dpdk-dev] [PATCH v4 3/6] power: rename public structs

2021-01-22 Thread Burakov, Anatoly
On 22-Jan-21 12:15 PM, Burakov, Anatoly wrote: On 21-Jan-21 5:21 PM, David Hunt wrote: From: Bruce Richardson rename the public structs to have an rte_power_ prefix and add them to version.map in experimental section. Fixes: 210c383e247b ("power: packet format for vm power management") Fixes:

Re: [dpdk-dev] [PATCH v4 3/6] power: rename public structs

2021-01-22 Thread Burakov, Anatoly
On 21-Jan-21 5:21 PM, David Hunt wrote: From: Bruce Richardson rename the public structs to have an rte_power_ prefix and add them to version.map in experimental section. Fixes: 210c383e247b ("power: packet format for vm power management") Fixes: cd0d5547e873 ("power: vm communication channels

Re: [dpdk-dev] [PATCH v4 2/6] power: make channel msg functions public

2021-01-22 Thread Burakov, Anatoly
On 21-Jan-21 5:21 PM, David Hunt wrote: From: Bruce Richardson Move the 2 public functions into rte_power_guest_channel.h Fixes: 210c383e247b ("power: packet format for vm power management") Fixes: cd0d5547e873 ("power: vm communication channels in guest") Cc: sta...@dpdk.org Signed-off-by: B

Re: [dpdk-dev] [PATCH v1] devtools: update abi ignore for cryptodev

2021-01-22 Thread Kinsella, Ray
On 21/01/2021 15:58, Thomas Monjalon wrote: > 21/01/2021 16:15, Dodji Seketeli: >> Hello Thomas and others, >> >> Thomas Monjalon writes: >> >>> Question to an expert, Dodji, >> >> Thanks for the kind words, but I am not an expert in anything, sadly. I >> am just trying to keep learning about

Re: [dpdk-dev] DPDK Release Status Meeting 21/01/2021

2021-01-22 Thread Ananyev, Konstantin
> >* Is ring library refactoring work stalled? Arm will check. > > * https://patches.dpdk.org/project/dpdk/list/?series=14405 > > IMO, this series is in good shape. > There is no comments from community on this series. > But this work is based on discussion between ring library maintaine

Re: [dpdk-dev] [PATCH v2 00/19] ensure headers have correct includes

2021-01-22 Thread Bruce Richardson
On Fri, Jan 22, 2021 at 12:20:55AM +0100, Thomas Monjalon wrote: > 21/01/2021 16:15, Bruce Richardson: > > On Thu, Jan 21, 2021 at 10:36:18AM +0100, Thomas Monjalon wrote: > > > 21/01/2021 10:33, Bruce Richardson: > > > > On Thu, Jan 21, 2021 at 10:25:07AM +0100, David Marchand wrote: > > > > > Is

Re: [dpdk-dev] [dpdk-announce] release candidate 21.02-rc1

2021-01-22 Thread Yu, PingX
All, Update the test status for Intel part. Till now 60% is executed and no critical issue blocked the test. # Basic Intel(R) NIC testing * PF/VF(i40e,ixgbe and igb): 60% is tested. 3 issues are found but not are big issue. * PF/VF(ICE): 50% is tested. 7 issues are found regarding DCF switch

Re: [dpdk-dev] meson: wrong dependency in cross compilation on ARM

2021-01-22 Thread Juraj Linkeš
> -Original Message- > From: dev On Behalf Of Hemant Agrawal > Sent: Monday, December 21, 2020 3:29 PM > To: Bruce Richardson > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] meson: wrong dependency in cross compilation on ARM > > > > -Original Message- > > From: dev On Behalf O

Re: [dpdk-dev] [PATCH v15 09/12] build: disable drivers in Arm builds

2021-01-22 Thread Thomas Monjalon
22/01/2021 10:07, Jerin Jacob: > On Fri, Jan 22, 2021 at 2:28 PM Thomas Monjalon wrote: > > 22/01/2021 09:39, Juraj Linkeš: > > > > > > > disabled drivers, similarly how the command line option works and > > > > > > > remove unneeded driver options ported from the old makefile > > > > > > > system

[dpdk-dev] [PATCH 01/14] net/hns3: encapsulate dfx stats in Rx/Tx datapatch

2021-01-22 Thread Lijun Ou
From: Huisong Li pkt_len_errors and l2_errors in Rx datapath indicate that driver needs to discard received packets. And driver does not discard packets for l3/l4/ol3/ol4_csum_errors in Rx datapath and others stats in Tx datapatch. Therefore, it is necessary for improving code readability and mai

[dpdk-dev] [PATCH 02/14] net/hns3: move queue stats to xstats

2021-01-22 Thread Lijun Ou
From: Huisong Li One of the hot discussions in community recently was moving queue stats to xstats. In this solution, a temporary 'RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS' device flag is created to implement the smooth switch. And the first half of this work has been completed in the ethdev framework.

[dpdk-dev] [PATCH 14/14] net/hns3: support LSC event report

2021-01-22 Thread Lijun Ou
From: Chengwen Feng This patch support LSC(Link Status Change) event report. Signed-off-by: Chengwen Feng Signed-off-by: Lijun Ou --- drivers/net/hns3/hns3_ethdev.c| 52 +++ drivers/net/hns3/hns3_ethdev.h| 4 ++- drivers/net/hns3/hns3_ethdev_vf.c |

[dpdk-dev] [PATCH 03/14] net/hns3: use array instead of switch-case

2021-01-22 Thread Lijun Ou
Heres uses errno array instead of switch-case for refactor the hns3_cmd_convert_err_code function. Besides, we add a type for ROH(RDMA Over HCCS) check cmdq return error in Kunpeng930 NIC hardware. Signed-off-by: Lijun Ou --- drivers/net/hns3/hns3_cmd.c | 54 ++---

[dpdk-dev] [PATCH 05/14] net/hns3: reconstruct the Rx interrupt map

2021-01-22 Thread Lijun Ou
From: Chengchang Tang This patch reconstruct the Rx interrupt map to reduce the cyclic complexity and improve readability and maintainability. Signed-off-by: Chengchang Tang Signed-off-by: Lijun Ou --- drivers/net/hns3/hns3_ethdev.c| 59 +++ drivers/net

[dpdk-dev] [PATCH 04/14] net/hns3: move judgment conditions to separated functions

2021-01-22 Thread Lijun Ou
Here moves some judgement conditions to a separated function for parsing IPv4 hdr and TCP hdr in hns3_parse_normal function. Also, move the check of the selected input tuple of RSS to a separated functions named hns3_rss_input_tuple_supported in order to enhance scalability and complexity. Signed-

[dpdk-dev] [PATCH 11/14] net/hns3: adjust some comments

2021-01-22 Thread Lijun Ou
Fixe some error comments and remove some meaningless comments. Signed-off-by: Lijun Ou --- drivers/net/hns3/hns3_flow.c | 19 --- 1 file changed, 8 insertions(+), 11 deletions(-) diff --git a/drivers/net/hns3/hns3_flow.c b/drivers/net/hns3/hns3_flow.c index 8a5179d..f2bff1e 1006

[dpdk-dev] [PATCH 08/14] net/hns3: fix memory leak with secondary process exit

2021-01-22 Thread Lijun Ou
the secondary process is applied a memory for the process_private during initialization. Therefore, the memory needs to be released when exiting. Fixes: c203571b3602 ("net/hns3: register and add log interface") Cc: sta...@dpdk.org Signed-off-by: Lijun Ou --- drivers/net/hns3/hns3_ethdev.c|

[dpdk-dev] [PATCH 12/14] net/hns3: remove unnecessary parentheses

2021-01-22 Thread Lijun Ou
Remove unnecessary parentheses as well as keep a reasonable blank line. Signed-off-by: Lijun Ou --- drivers/net/hns3/hns3_flow.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/hns3/hns3_flow.c b/drivers/net/hns3/hns3_flow.c index f2bff1e..e9d0a0b 100644 --- a/

  1   2   >