Re: [dpdk-dev] [PATCH] app/testpmd: increase array for fetching supported FEC caps

2020-12-23 Thread Min Hu (Connor)
在 2020/12/21 6:47, Rahul Lakkireddy 写道: From: Karra Satwik Request the driver for number of entries in the FEC caps array and then dynamically allocate the array. Signed-off-by: Karra Satwik Signed-off-by: Rahul Lakkireddy --- app/test-pmd/cmdline.c | 29 -

[dpdk-dev] [dpdk-dev v2 6/6] net/ice: enable ecpri tunnel port configure in dcf

2020-12-23 Thread Jeff Guo
Add ecpri tunnel port add and rm ops to configure ecpri udp tunnel port in dcf. Signed-off-by: Jeff Guo --- drivers/net/ice/ice_dcf_ethdev.c | 67 1 file changed, 67 insertions(+) diff --git a/drivers/net/ice/ice_dcf_ethdev.c b/drivers/net/ice/ice_dcf_ethdev.c i

[dpdk-dev] [dpdk-dev v2 5/6] net/iavf: add PTYPE mapping for ecpri

2020-12-23 Thread Jeff Guo
Until the new ecpri PTYPE be added into the RTE lib, just mapping ecpri to the PTYPE of RTE_PTYPE_L4_UDP in iavf pmd. Signed-off-by: Jeff Guo --- drivers/net/iavf/iavf_rxtx.c | 44 1 file changed, 44 insertions(+) diff --git a/drivers/net/iavf/iavf_rxtx.c b/

[dpdk-dev] [dpdk-dev v2 4/6] net/ice: add PTYPE mapping for ecpri

2020-12-23 Thread Jeff Guo
Until the new ecpri PTYPE be added into the RTE lib, just mapping ecpri to the PTYPE of RTE_PTYPE_L4_UDP in ice pmd. Signed-off-by: Jeff Guo --- drivers/net/ice/ice_rxtx.c | 44 ++ 1 file changed, 44 insertions(+) diff --git a/drivers/net/ice/ice_rxtx.c b/dri

[dpdk-dev] [dpdk-dev v2 3/6] net/ice/base: add new UDP tunnel type for ecpri

2020-12-23 Thread Jeff Guo
Add new UDP tunnel type for ecpri. Signed-off-by: Jeff Guo --- drivers/net/ice/base/ice_flex_pipe.c | 1 + drivers/net/ice/base/ice_flex_type.h | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/net/ice/base/ice_flex_pipe.c b/drivers/net/ice/base/ice_flex_pipe.c index 987bea5623..31a

[dpdk-dev] [dpdk-dev v2 1/6] net/ice/base: add package PTYPE enable information

2020-12-23 Thread Jeff Guo
Scan the 'Marker PType TCAM' session to retrieve the Rx parser PTYPE enable information from the current package. Signed-off-by: Haiyue Wang Signed-off-by: Jeff Guo --- drivers/net/ice/base/ice_flex_pipe.c | 79 drivers/net/ice/base/ice_flex_pipe.h | 3 ++ drivers/

[dpdk-dev] [dpdk-dev v2 0/6] enable UDP ecpri configure in dcf

2020-12-23 Thread Jeff Guo
Enabling ecpri UDP tunnel port configure in dcf. v2: refactor PTYPE parsing and add related sharecode patch separate patch set Jeff Guo (6): net/ice/base: add package PTYPE enable information net/ice: refactor package type parsing net/ice/base: add new UDP tunnel type for ecpri net/ice: a

[dpdk-dev] [dpdk-dev v2 2/6] net/ice: refactor package type parsing

2020-12-23 Thread Jeff Guo
If the PTYPE support of the package could be checked, no need to parse different PTYPE list for each type of the package. So, refactor the package type parsing mechanism in each flow engins. Signed-off-by: Jeff Guo --- drivers/net/ice/ice_acl_filter.c| 3 +- drivers/net/ice/ice_fdir_filter

[dpdk-dev] [dpdk-dev v2 2/2] app/testpmd: add new UDP tunnel port for ecpri

2020-12-23 Thread Jeff Guo
Add new UDP tunnel port params for ecpri configuration, the command as below: testpmd> port config 0 udp_tunnel_port add ecpri 6789 testpmd> port config 0 udp_tunnel_port rm ecpri 6789 Signed-off-by: Jeff Guo --- app/test-pmd/cmdline.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-

[dpdk-dev] [dpdk-dev v2 1/2] ethdev: add new tunnel type for ecpri

2020-12-23 Thread Jeff Guo
Add type of RTE_TUNNEL_TYPE_ECPRI into the enum of ethdev tunnel type. Signed-off-by: Jeff Guo Reviewed-by: Qi Zhang --- lib/librte_ethdev/rte_ethdev.h | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h index f5f8919186..2cbce958c

[dpdk-dev] [dpdk-dev v2 0/2] add new UDP tunnel port for ecpri

2020-12-23 Thread Jeff Guo
Add new UDP tunnel type and port params for ecpri configuration. v2: separate patch set Jeff Guo (2): ethdev: add new tunnel type for ecpri app/testpmd: add new UDP tunnel port for ecpri app/test-pmd/cmdline.c | 7 +-- lib/librte_ethdev/rte_ethdev.h | 1 + 2 files changed, 6 ins

Re: [dpdk-dev] [PATCH 0/5] add apistats function

2020-12-23 Thread Hideyuki Yamashita
Hello Thanks for your comments. I know you kindly provided many valuable comments though I reply the following first because I think it is important that my idea/proposal is acceptable or not first. > Sharing an alternate approach, if RX-TX callbacks are enabled in DPDK (which > is by default)

Re: [dpdk-dev] [PATCH 1/5] maintainers: update maintainers file for apistats

2020-12-23 Thread Hideyuki Yamashita
Hello, Sorry about the following. I typo in email address in "signed-off-by". I will revise it in the upcoming revised patchset. Sorry! BR, Hideyuki Yamashita NTT TechnoCross > Look like I am facing `mail delivery` issues to `ntt-tx.co.jp`. > > ``` > The following message to was undeliverabl

Re: [dpdk-dev] [PATCH 5/5] librte_ethdev: add to use apistats

2020-12-23 Thread Hideyuki Yamashita
Hello, Thanks for your feedback. > On Fri, 04 Dec 2020 16:51:09 +0900 > Hideyuki Yamashita wrote: > > > + > > +/* Macros for printing using RTE_LOG */ > > +#define RTE_LOGTYPE_APISTATS RTE_LOGTYPE_USER1 > > + > > Please don't use static logtypes. > Better to allocate a dynamic logtype value and

[dpdk-dev] [PATCH] app/testpmd: avoid exit without resource release

2020-12-23 Thread dapengx . yu
From: YU DAPENG In interactive mode, if testpmd exit by calling rte_exit without cmdline resource release, terminal will not echo keyboard input. So add code to just show error message, but not exit testpmd when unexpected happens on starting packet forwarding in interactive mode. User can type "

Re: [dpdk-dev] [PATCH 00/27] ice base code update

2020-12-23 Thread Yang, Qiming
> -Original Message- > From: Zhang, Qi Z > Sent: Tuesday, December 15, 2020 14:05 > To: Yang, Qiming > Cc: dev@dpdk.org; Zhang, Qi Z > Subject: [PATCH 00/27] ice base code update > > Change Summary: > > 1. Support double vlan mode. > 2. Support eCPRI msg type 0 filter on fdir. > 3. S

[dpdk-dev] [PATCH v5] net/iavf: fix invalid RSS combinations rule can be created

2020-12-23 Thread Murphy Yang
Currently, when use 'flow' command to create a rule that combine with several RSS types, even the RSS type combination is invalid, it also be created successfully. Here list some invalid RSS combinations: - ETH_RSS_IPV4 | ETH_RSS_NONFRAG_IPV4_TCP - ETH_RSS_IPV6 | ETH_RSS_NONFRAG_IPV6_TCP - ETH_

Re: [dpdk-dev] [PATCH v4] net/i40e: fix argument in RSS action

2020-12-23 Thread Zhang, Qi Z
> -Original Message- > From: dev On Behalf Of Kumar Amber > Sent: Thursday, November 12, 2020 6:43 PM > To: dev@dpdk.org > Cc: Zhao1, Wei > Subject: [dpdk-dev] [PATCH v4] net/i40e: fix argument in RSS action > > The driver must check for the queue number in the RSS action list and if

[dpdk-dev] [Bug 605] HPE 100G 841QSFP28 fails on jumbo frames when not configured for it - Unexpected CQE error syndrome

2020-12-23 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=605 Bug ID: 605 Summary: HPE 100G 841QSFP28 fails on jumbo frames when not configured for it - Unexpected CQE error syndrome Product: DPDK Version: 19.11 Hardware: x86 O

[dpdk-dev] [PATCH v2] net/qede: fix regression introduced by b10231aed1ed

2020-12-23 Thread Balazs Nemeth
When calling rte_eth_promiscuous_enable(port_id) followed by rte_eth_allmulticast_enable(port_id), the port is not in promisc mode anymore. This patch ensures that promisc mode takes precedence over allmulticast mode fixing the regression introduced by b10231aed1ed. Signed-off-by: Balazs Nemeth -

[dpdk-dev] [PATCH] net/qede: fix regression introduced by b10231aed1ed

2020-12-23 Thread Balazs Nemeth
When calling rte_eth_promiscuous_enable(port_id) followed by rte_eth_allmulticast_enable(port_id), the port is not in promisc mode anymore. This patch ensures that promisc mode takes precedence over allmulticast mode fixing the regression introduced by b10231aed1ed. --- drivers/net/qede/qede_ethde

Re: [dpdk-dev] [PATCH] net/ice: check Rx queue number on RSS init

2020-12-23 Thread Zhang, Qi Z
> -Original Message- > From: dapengx...@intel.com > Sent: Wednesday, December 23, 2020 1:30 PM > To: Yang, Qiming ; Zhang, Qi Z > Cc: dev@dpdk.org; Yu, DapengX ; sta...@dpdk.org > Subject: [PATCH] net/ice: check Rx queue number on RSS init > > From: YU DAPENG > > When RSS is initial

Re: [dpdk-dev] [PATCH v3] net/iavf: improve default RSS

2020-12-23 Thread Zhang, Qi Z
> -Original Message- > From: Ding, Xuan > Sent: Wednesday, December 23, 2020 8:52 PM > To: Zhang, Qi Z ; Wu, Jingjing ; > Xing, Beilei > Cc: dev@dpdk.org; Ding, Xuan > Subject: [PATCH v3] net/iavf: improve default RSS > > This patch adds support to actively configure RSS through port

Re: [dpdk-dev] [PATCH v2] net/iavf: improve default RSS

2020-12-23 Thread Zhang, Qi Z
> -Original Message- > From: Ding, Xuan > Sent: Wednesday, December 23, 2020 8:31 PM > To: Zhang, Qi Z ; Wu, Jingjing ; > Xing, Beilei > Cc: dev@dpdk.org; Ding, Xuan > Subject: [PATCH v2] net/iavf: improve default RSS > > This patch adds support to actively configure RSS through port

[dpdk-dev] [PATCH v3] net/iavf: improve default RSS

2020-12-23 Thread Xuan Ding
This patch adds support to actively configure RSS through port config. Any kernel PF enabled default RSS will be disabled during initialization. Besides, default RSS will be configured based on rte_eth_rss_conf->rss_hf. Currently supported default rss_type: ipv4[6], ipv4[6]_udp, ipv4[6]_tcp, ipv4[6

Re: [dpdk-dev] [PATCH] app/testpmd: fix start index for showing FEC array

2020-12-23 Thread Rahul Lakkireddy
On Monday, December 12/21/20, 2020 at 17:07:21 +0800, Min Hu (Connor) wrote: > > > 在 2020/12/21 6:47, Rahul Lakkireddy 写道: > >From: Karra Satwik > > > >Start from index 0 when going through the FEC array. This will allow > >"off" to get printed for RTE_ETH_FEC_NOFEC mode. > > > >Fixes: b19da32e3

[dpdk-dev] [PATCH v2] app/testpmd: increase array for fetching supported FEC caps

2020-12-23 Thread Rahul Lakkireddy
From: Karra Satwik Request the driver for number of entries in the FEC caps array and then dynamically allocate the array. Signed-off-by: Karra Satwik Signed-off-by: Rahul Lakkireddy Acked-by: Xiaoyun Li --- v2: - Replace if (!speed_fec_capa) with if (speed_fec_capa == NULL) app/test-pmd/cm

[dpdk-dev] [PATCH v2] net/iavf: improve default RSS

2020-12-23 Thread Xuan Ding
This patch adds support to actively configure RSS through port config. Any kernel PF enabled default RSS will be disabled during initialization. Besides, default RSS will be configured based on rte_eth_rss_conf->rss_hf. Currently supported default rss_type: ipv4[6], ipv4[6]_udp, ipv4[6]_tcp, ipv4[6

[dpdk-dev] [PATCH] maintainers: added liquidio driver maintainer

2020-12-23 Thread Ugendreshwar Kudupudi
Added Marvell LiquidIO Driver Maintainer Signed-off-by: Ugendreshwar Kudupudi --- MAINTAINERS | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index eafe9f8c4..a8d68f7ed 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -616,9 +616,8 @@ F: drivers/ne

Re: [dpdk-dev] [PATCH v4] eal: add generic thread-local-storage functions

2020-12-23 Thread Dmitry Kozlyuk
On Wed, 23 Dec 2020 11:44:31 +, Tal Shnaiderman wrote: > > > diff --git a/lib/librte_eal/windows/meson.build > > > b/lib/librte_eal/windows/meson.build > > > index 3b2faf29eb..1f1398dfe9 100644 > > > --- a/lib/librte_eal/windows/meson.build > > > +++ b/lib/librte_eal/windows/meson.build > > > @

Re: [dpdk-dev] [PATCH] net/iavf: improve default RSS

2020-12-23 Thread Ding, Xuan
Hi Qi, Thank you for your comments, replies in line. > -Original Message- > From: Zhang, Qi Z > Sent: Wednesday, December 23, 2020 6:15 PM > To: Ding, Xuan ; Wu, Jingjing > ; Xing, Beilei > Cc: dev@dpdk.org > Subject: RE: [PATCH] net/iavf: improve default RSS > > > > > -Original

[dpdk-dev] [PATCH v14 12/12] config: fix Arm implementer and its SoCs

2020-12-23 Thread Juraj Linkeš
Fix the implementer and part number of DPAA and ARMADA SoCs. The current values of 16 cores and 1 NUMA node don't cover all SoCs from the Arm implementer, e.g. Taishan 2280 has 64 cores and 4 NUMA nodes. Increase these to 64 and 4 to widen the coverage. Add configuration to SoC options where smalle

[dpdk-dev] [PATCH v14 11/12] build: add Arm SoC meson option

2020-12-23 Thread Juraj Linkeš
Add Arm SoC configuration to Arm meson.build and add a meson option to enable those options for native builds. This is preferable to specifying a cross file when doing aarch64 -> aarch64 builds, since the cross file specifies the toolchain as well. Signed-off-by: Juraj Linkeš Reviewed-by: Honnapp

[dpdk-dev] [PATCH v14 10/12] build: disable libnuma in cross builds

2020-12-23 Thread Juraj Linkeš
Some Arm SoCs are not NUMA systems. Add the capability to disable NUMA for cross build and disable NUMA in Arm cross files. Signed-off-by: Juraj Linkeš Reviewed-by: Honnappa Nagarahalli --- config/arm/arm64_armada_linux_gcc | 1 + config/arm/arm64_bluefield_linux_gcc | 1

[dpdk-dev] [PATCH v14 09/12] build: disable drivers in Arm builds

2020-12-23 Thread Juraj Linkeš
A few options that disabled drivers in the old makefiles were improperly ported to the meson build system. Fix this by adding a to the list of disabled drivers, similarly how the command line option works and remove unneeded driver options ported from the old makefile system, since they don't work

[dpdk-dev] [PATCH v14 08/12] build: add core and NUMA counts to cross files

2020-12-23 Thread Juraj Linkeš
Add support for setting core count and numa nodes in cross files. The values specified in cross files will override the default values. Also add missing default values to Arm config. Signed-off-by: Juraj Linkeš Reviewed-by: Honnappa Nagarahalli --- config/arm/arm64_armada_linux_gcc

[dpdk-dev] [PATCH v14 07/12] build: use native machine args in Arm native build

2020-12-23 Thread Juraj Linkeš
Letting the compiler decide is going to yield the best results for native builds, so use native machine args usable for both GCC and Clang. Signed-off-by: Juraj Linkeš --- config/arm/meson.build | 54 ++ 1 file changed, 28 insertions(+), 26 deletions(-) d

[dpdk-dev] [PATCH v14 06/12] build: isolate configuration for Arm generic build

2020-12-23 Thread Juraj Linkeš
Use generic configuration for the only build where it makes sense - the generic build. For other builds, if we don't know either of implementer ID or part number, the build is not supported. Add part numbers to cross files where fallback to generic configuration is assumed. Signed-off-by: Juraj Li

[dpdk-dev] [PATCH v14 05/12] build: organize Arm config into dict

2020-12-23 Thread Juraj Linkeš
Use dictionary lookup instead of checking for existing variables, iterating over all elements in the list or checking lists for optional configuration. Move variable contents into the dictionary for variables that would be referenced only once. Fallback to generic part number if the discovered part

[dpdk-dev] [PATCH v14 04/12] build: simplify how Arm flags are processed

2020-12-23 Thread Juraj Linkeš
Set flags in one loop. Append flags to a list and use the list in the loop. Signed-off-by: Juraj Linkeš Reviewed-by: Honnappa Nagarahalli --- config/arm/meson.build | 37 + 1 file changed, 17 insertions(+), 20 deletions(-) diff --git a/config/arm/meson.build

[dpdk-dev] [PATCH v14 03/12] build: reformat and move Arm config and comments

2020-12-23 Thread Juraj Linkeš
Change formatting so that it's more consistent and readable, add/modify comments/stdout messages, move configuration options to more appropriate places and make the order consistent according to these rules: 1. First list generic configuration options, then list options that may be overwritten.

[dpdk-dev] [PATCH v14 02/12] build: remove unused or superfluous variables

2020-12-23 Thread Juraj Linkeš
Remove variables that were either not used, referenced just once or not needed. Signed-off-by: Juraj Linkeš Reviewed-by: Ruifeng Wang Reviewed-by: Honnappa Nagarahalli --- config/arm/meson.build | 28 +++- 1 file changed, 7 insertions(+), 21 deletions(-) diff --git a/c

[dpdk-dev] [PATCH v14 01/12] build: rename Arm build variables

2020-12-23 Thread Juraj Linkeš
Rename Arm build variables and values so that they better conform to Arm specifications. Also rename generically sounding variable to names that better capture what the variables hold. Rename machine_args_generic to part_number_config_arm since the variable contains more than just the generic mach

[dpdk-dev] [PATCH v14 00/12] Arm build options rework

2020-12-23 Thread Juraj Linkeš
The current way of specifying Arm configuration options is insufficient since we can't identify the SoC we're building for from the MIDR information. For example, we can't distinguish between N1SDP, Graviton2 or Ampere Altra. Add a way to specify the cpu count and numa node count for cross builds

Re: [dpdk-dev] [PATCH v4] eal: add generic thread-local-storage functions

2020-12-23 Thread Tal Shnaiderman
> Subject: Re: [PATCH v4] eal: add generic thread-local-storage functions > > External email: Use caution opening links or attachments > > > > [...] > > +int > > +rte_thread_tls_set_value(rte_tls_key key, const void *value) { > > + int err; > > + > > + if (!key) { > > + RTE_L

Re: [dpdk-dev] [PATCH v1 1/1] build: optional NUMA and cpu counts detection

2020-12-23 Thread Juraj Linkeš
Hi Thomas and others, Do you have any comments? I believe Bruce is okay with this patch. Thanks, Juraj > -Original Message- > From: Juraj Linkeš > Sent: Friday, November 20, 2020 1:55 PM > To: tho...@monjalon.net; bruce.richard...@intel.com; > honnappa.nagaraha...@arm.com > Cc: dev@dpdk

Re: [dpdk-dev] [RFC PATCH v1] build: add platform meson option

2020-12-23 Thread Juraj Linkeš
> -Original Message- > From: Bruce Richardson > Sent: Friday, November 27, 2020 3:07 PM > To: Juraj Linkeš > Cc: tho...@monjalon.net; honnappa.nagaraha...@arm.com; dev@dpdk.org > Subject: Re: [RFC PATCH v1] build: add platform meson option > > On Fri, Nov 27, 2020 at 08:31:47AM +,

Re: [dpdk-dev] [PATCH 0/5] support eCPRI MSG TYPE 0 for AVF FDIR and RSS

2020-12-23 Thread Zhang, Qi Z
> -Original Message- > From: Guo, Junfeng > Sent: Monday, December 14, 2020 2:49 PM > To: Zhang, Qi Z ; Wu, Jingjing ; > Xing, Beilei > Cc: dev@dpdk.org; Guo, Junfeng ; Su, Simei > ; Cao, Yahui > Subject: [PATCH 0/5] support eCPRI MSG TYPE 0 for AVF FDIR and RSS > > This patch set en

Re: [dpdk-dev] [PATCH] net/i40e: fix Rx-bytes statistics

2020-12-23 Thread Zhang, Qi Z
> -Original Message- > From: dev On Behalf Of Zhang,Alvin > Sent: Tuesday, December 15, 2020 5:51 PM > To: Guo, Jia ; Xing, Beilei > Cc: dev@dpdk.org; Zhang, AlvinX ; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH] net/i40e: fix Rx-bytes statistics > > From: Alvin Zhang > > Update the

Re: [dpdk-dev] [PATCH v3] net/i40e: issue with ADD VLAN from Guest

2020-12-23 Thread Zhang, Qi Z
From: Guo, Jia Sent: Wednesday, December 16, 2020 10:10 AM To: Souvik Dey ; Xing, Beilei ; Zhang, Qi Z Cc: dev@dpdk.org Subject: RE: [PATCH v3] net/i40e: issue with ADD VLAN from Guest Acked-by: Jeff Guo mailto:jia@intel.com>> From: Souvik Dey mailto:so...@rbbn.com>> Sent: Tuesday, Decem

Re: [dpdk-dev] [PATCH v2] build: alias default build as generic

2020-12-23 Thread Juraj Linkeš
Hello folks, What's the status of this patch? Can we merge this or do we need more acks/reviews? Thanks, Juraj > -Original Message- > From: Bruce Richardson > Sent: Tuesday, November 24, 2020 10:31 AM > To: Juraj Linkeš > Cc: tho...@monjalon.net; honnappa.nagaraha...@arm.com; dev@dpdk

Re: [dpdk-dev] [PATCH] net/ixgbe: clear registers of all queues on VF reset

2020-12-23 Thread Zhang, Qi Z
> -Original Message- > From: dev On Behalf Of Wang, Haiyue > Sent: Friday, December 18, 2020 10:35 AM > To: Simon Ellmann ; Guo, Jia > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: clear registers of all queues on VF > reset > > > -Original Message- > > From: S

Re: [dpdk-dev] [PATCH] net/iavf: improve default RSS

2020-12-23 Thread Zhang, Qi Z
> -Original Message- > From: Ding, Xuan > Sent: Thursday, December 3, 2020 11:26 AM > To: Zhang, Qi Z ; Wu, Jingjing ; > Xing, Beilei > Cc: dev@dpdk.org; Ding, Xuan > Subject: [PATCH] net/iavf: improve default RSS > > This patch adds support to actively configure RSS. Any kernel PF e

Re: [dpdk-dev] [PATCH v2] doc: fix some statements for ice vector PMD

2020-12-23 Thread Zhang, Qi Z
> -Original Message- > From: Rong, Leyi > Sent: Thursday, December 17, 2020 10:13 AM > To: Zhang, Qi Z > Cc: Yigit, Ferruh ; dev@dpdk.org; sta...@dpdk.org > Subject: RE: [PATCH v2] doc: fix some statements for ice vector PMD > > > > -Original Message- > > From: Zhang, Qi Z >

Re: [dpdk-dev] [PATCH v1 02/38] net/mvpp2: remove debug log on fast-path

2020-12-23 Thread Michael Shamis
Reviewed-by: Michael Shamis -Original Message- From: dev On Behalf Of lir...@marvell.com Sent: Wednesday, December 2, 2020 12:12 PM To: Jerin Jacob Kollanukkaran Cc: dev@dpdk.org; Liron Himi ; sta...@dpdk.org Subject: [dpdk-dev] [PATCH v1 02/38] net/mvpp2: remove debug log on fast-path

Re: [dpdk-dev] [PATCH v1 01/38] net/mvpp2: fix stack corruption

2020-12-23 Thread Michael Shamis
Reviewed-by: Michael Shamis -Original Message- From: dev On Behalf Of lir...@marvell.com Sent: Wednesday, December 2, 2020 12:12 PM To: Jerin Jacob Kollanukkaran Cc: dev@dpdk.org; Yuri Chipchev ; sta...@dpdk.org; Liron Himi Subject: [dpdk-dev] [PATCH v1 01/38] net/mvpp2: fix stack cor

Re: [dpdk-dev] [PATCH v1 03/38] net/mvpp2: fix rx/tx bytes statistics

2020-12-23 Thread Michael Shamis
Reviewed-by: Michael Shamis -Original Message- From: dev On Behalf Of lir...@marvell.com Sent: Wednesday, December 2, 2020 12:12 PM To: Jerin Jacob Kollanukkaran Cc: dev@dpdk.org; Yuri Chipchev ; sta...@dpdk.org; Liron Himi Subject: [dpdk-dev] [PATCH v1 03/38] net/mvpp2: fix rx/tx byt

Re: [dpdk-dev] [PATCH v1 04/38] net/mvpp2: skip vlan flush

2020-12-23 Thread Michael Shamis
Reviewed-by: Michael Shamis -Original Message- From: dev On Behalf Of lir...@marvell.com Sent: Wednesday, December 2, 2020 12:12 PM To: Jerin Jacob Kollanukkaran Cc: dev@dpdk.org; Liron Himi ; sta...@dpdk.org Subject: [dpdk-dev] [PATCH v1 04/38] net/mvpp2: skip vlan flush From: Liron H

Re: [dpdk-dev] [PATCH v1 07/38] net/mvpp2: reduce prints on rx path

2020-12-23 Thread Michael Shamis
Reviewed-by: Michael Shamis -Original Message- From: dev On Behalf Of lir...@marvell.com Sent: Wednesday, December 2, 2020 12:12 PM To: Jerin Jacob Kollanukkaran Cc: dev@dpdk.org; Liron Himi ; sta...@dpdk.org; Dana Vardi Subject: [dpdk-dev] [PATCH v1 07/38] net/mvpp2: reduce prints on

Re: [dpdk-dev] [PATCH v1 06/38] net/mvpp2: fix frame size checking

2020-12-23 Thread Michael Shamis
Reviewed-by: Michael Shamis -Original Message- From: dev On Behalf Of lir...@marvell.com Sent: Wednesday, December 2, 2020 12:12 PM To: Jerin Jacob Kollanukkaran Cc: dev@dpdk.org; Liron Himi ; sta...@dpdk.org; Yuri Chipchev Subject: [dpdk-dev] [PATCH v1 06/38] net/mvpp2: fix frame siz

Re: [dpdk-dev] [PATCH v1 05/38] net/mvpp2: remove CRC len from MRU validation

2020-12-23 Thread Michael Shamis
Reviewed-by: Michael Shamis -Original Message- From: dev On Behalf Of lir...@marvell.com Sent: Wednesday, December 2, 2020 12:12 PM To: Jerin Jacob Kollanukkaran Cc: dev@dpdk.org; Liron Himi ; sta...@dpdk.org; Yuri Chipchev Subject: [dpdk-dev] [PATCH v1 05/38] net/mvpp2: remove CRC le

Re: [dpdk-dev] [PATCH v1 08/38] net/mvpp2: rss reservation

2020-12-23 Thread Michael Shamis
Reviewed-by: Michael Shamis -Original Message- From: dev On Behalf Of lir...@marvell.com Sent: Wednesday, December 2, 2020 12:12 PM To: Jerin Jacob Kollanukkaran Cc: dev@dpdk.org; Yuri Chipchev ; Liron Himi Subject: [dpdk-dev] [PATCH v1 08/38] net/mvpp2: rss reservation From: Yuri Ch

Re: [dpdk-dev] [PATCH v1 09/38] net/mvpp2: extend xstats support

2020-12-23 Thread Michael Shamis
Reviewed-by: Michael Shamis -Original Message- From: dev On Behalf Of lir...@marvell.com Sent: Wednesday, December 2, 2020 12:12 PM To: Jerin Jacob Kollanukkaran Cc: dev@dpdk.org; Yuri Chipchev ; Liron Himi Subject: [dpdk-dev] [PATCH v1 09/38] net/mvpp2: extend xstats support From: Y

Re: [dpdk-dev] [PATCH v1 10/38] net/mvpp2: cosmetic changes to cookie usage

2020-12-23 Thread Michael Shamis
Reviewed-by: Michael Shamis -Original Message- From: dev On Behalf Of lir...@marvell.com Sent: Wednesday, December 2, 2020 12:12 PM To: Jerin Jacob Kollanukkaran Cc: dev@dpdk.org; Yuri Chipchev ; Liron Himi Subject: [dpdk-dev] [PATCH v1 10/38] net/mvpp2: cosmetic changes to cookie usa

Re: [dpdk-dev] [PATCH v1 11/38] net/mvpp2: align checking order

2020-12-23 Thread Michael Shamis
Reviewed-by: Michael Shamis -Original Message- From: dev On Behalf Of lir...@marvell.com Sent: Wednesday, December 2, 2020 12:12 PM To: Jerin Jacob Kollanukkaran Cc: dev@dpdk.org; Yuri Chipchev ; Liron Himi Subject: [dpdk-dev] [PATCH v1 11/38] net/mvpp2: align checking order From: Yu

Re: [dpdk-dev] 18.11.11 (LTS) patches review and test

2020-12-23 Thread Pei Zhang
Hello Kevin, The testing with dpdk 18.11.11-rc1 from Red Hat looks good. We tested below 16 scenarios and and all got PASS on RHEL8: (1)Guest with device assignment(PF) throughput testing(1G hugepage size): PASS (2)Guest with device assignment(PF) throughput testing(2M hugepage size) : PASS (3)G

Re: [dpdk-dev] [PATCH v1 12/38] net/mvpp2: save initial configuration

2020-12-23 Thread Michael Shamis
Reviewed-by: Michael Shamis -Original Message- From: dev On Behalf Of lir...@marvell.com Sent: Wednesday, December 2, 2020 12:12 PM To: Jerin Jacob Kollanukkaran Cc: dev@dpdk.org; Yuri Chipchev ; Liron Himi Subject: [dpdk-dev] [PATCH v1 12/38] net/mvpp2: save initial configuration Fr

Re: [dpdk-dev] [PATCH v1 13/38] net/mvpp2: add loopback support

2020-12-23 Thread Michael Shamis
Reviewed-by: Michael Shamis -Original Message- From: dev On Behalf Of lir...@marvell.com Sent: Wednesday, December 2, 2020 12:12 PM To: Jerin Jacob Kollanukkaran Cc: dev@dpdk.org; Yuri Chipchev ; Liron Himi Subject: [dpdk-dev] [PATCH v1 13/38] net/mvpp2: add loopback support From: Yu

Re: [dpdk-dev] [PATCH v1 17/38] net/mvpp2: add TX flow control

2020-12-23 Thread Michael Shamis
Reviewed-by: Michael Shamis -Original Message- From: dev On Behalf Of lir...@marvell.com Sent: Wednesday, December 2, 2020 12:12 PM To: Jerin Jacob Kollanukkaran Cc: dev@dpdk.org; Yuri Chipchev ; Liron Himi Subject: [dpdk-dev] [PATCH v1 17/38] net/mvpp2: add TX flow control From: Yur

Re: [dpdk-dev] [PATCH v1 15/38] net/mvpp2: only use ol_flags for checksum generation offload

2020-12-23 Thread Michael Shamis
Reviewed-by: Michael Shamis -Original Message- From: dev On Behalf Of lir...@marvell.com Sent: Wednesday, December 2, 2020 12:12 PM To: Jerin Jacob Kollanukkaran Cc: dev@dpdk.org; Liron Himi Subject: [dpdk-dev] [PATCH v1 15/38] net/mvpp2: only use ol_flags for checksum generation offl

Re: [dpdk-dev] [PATCH v1 17/38] net/mvpp2: add TX flow control

2020-12-23 Thread Michael Shamis
Reviewed-by: Michael Shamis -Original Message- From: dev On Behalf Of lir...@marvell.com Sent: Wednesday, December 2, 2020 12:12 PM To: Jerin Jacob Kollanukkaran Cc: dev@dpdk.org; Yuri Chipchev ; Liron Himi Subject: [dpdk-dev] [PATCH v1 17/38] net/mvpp2: add TX flow control From: Yur

Re: [dpdk-dev] [PATCH v1 16/38] net/mvpp2: add dsa mode support

2020-12-23 Thread Michael Shamis
Reviewed-by: Michael Shamis -Original Message- From: dev On Behalf Of lir...@marvell.com Sent: Wednesday, December 2, 2020 12:12 PM To: Jerin Jacob Kollanukkaran Cc: dev@dpdk.org; Liron Himi Subject: [dpdk-dev] [PATCH v1 16/38] net/mvpp2: add dsa mode support From: Liron Himi extend

Re: [dpdk-dev] [PATCH v1 18/38] net/mvpp2: adjust the number of unicast address

2020-12-23 Thread Michael Shamis
Reviewed-by: Michael Shamis -Original Message- From: dev On Behalf Of lir...@marvell.com Sent: Wednesday, December 2, 2020 12:12 PM To: Jerin Jacob Kollanukkaran Cc: dev@dpdk.org; Liron Himi Subject: [dpdk-dev] [PATCH v1 18/38] net/mvpp2: adjust the number of unicast address From: Li

Re: [dpdk-dev] [PATCH v1 19/38] net/mvpp2: replace 'qos_cfg' with 'cfg'

2020-12-23 Thread Michael Shamis
Reviewed-by: Michael Shamis -Original Message- From: dev On Behalf Of lir...@marvell.com Sent: Wednesday, December 2, 2020 12:12 PM To: Jerin Jacob Kollanukkaran Cc: dev@dpdk.org; Liron Himi Subject: [dpdk-dev] [PATCH v1 19/38] net/mvpp2: replace 'qos_cfg' with 'cfg' From: Liron Himi

Re: [dpdk-dev] [PATCH v1 14/38] net/mvpp2: add vlan offload support

2020-12-23 Thread Michael Shamis
Reviewed-by: Michael Shamis -Original Message- From: dev On Behalf Of lir...@marvell.com Sent: Wednesday, December 2, 2020 12:12 PM To: Jerin Jacob Kollanukkaran Cc: dev@dpdk.org; Yuri Chipchev ; Liron Himi Subject: [dpdk-dev] [PATCH v1 14/38] net/mvpp2: add vlan offload support From

Re: [dpdk-dev] [PATCH v1 21/38] net/mvpp2: flow: build table key along with rule

2020-12-23 Thread Michael Shamis
Reviewed-by: Michael Shamis -Original Message- From: dev On Behalf Of lir...@marvell.com Sent: Wednesday, December 2, 2020 12:12 PM To: Jerin Jacob Kollanukkaran Cc: dev@dpdk.org; Liron Himi Subject: [dpdk-dev] [PATCH v1 21/38] net/mvpp2: flow: build table key along with rule From: L

Re: [dpdk-dev] [PATCH v1 20/38] net/mvpp2: flow: support generic pattern combinations

2020-12-23 Thread Michael Shamis
Reviewed-by: Michael Shamis -Original Message- From: dev On Behalf Of lir...@marvell.com Sent: Wednesday, December 2, 2020 12:12 PM To: Jerin Jacob Kollanukkaran Cc: dev@dpdk.org; Liron Himi Subject: [dpdk-dev] [PATCH v1 20/38] net/mvpp2: flow: support generic pattern combinations Fr

Re: [dpdk-dev] [PATCH v1 23/38] net/mvpp2: skip qos init if not requested

2020-12-23 Thread Michael Shamis
Reviewed-by: Michael Shamis -Original Message- From: dev On Behalf Of lir...@marvell.com Sent: Wednesday, December 2, 2020 12:12 PM To: Jerin Jacob Kollanukkaran Cc: dev@dpdk.org; Liron Himi Subject: [dpdk-dev] [PATCH v1 23/38] net/mvpp2: skip qos init if not requested From: Liron Him

Re: [dpdk-dev] [PATCH v1 24/38] net/mvpp2: move common functions to common location

2020-12-23 Thread Michael Shamis
Reviewed-by: Michael Shamis -Original Message- From: dev On Behalf Of lir...@marvell.com Sent: Wednesday, December 2, 2020 12:12 PM To: Jerin Jacob Kollanukkaran Cc: dev@dpdk.org; Liron Himi Subject: [dpdk-dev] [PATCH v1 24/38] net/mvpp2: move common functions to common location From

Re: [dpdk-dev] [PATCH v1 25/38] net/mvpp2: support udf configuration

2020-12-23 Thread Michael Shamis
Reviewed-by: Michael Shamis -Original Message- From: dev On Behalf Of lir...@marvell.com Sent: Wednesday, December 2, 2020 12:12 PM To: Jerin Jacob Kollanukkaran Cc: dev@dpdk.org; Liron Himi Subject: [dpdk-dev] [PATCH v1 25/38] net/mvpp2: support udf configuration From: Liron Himi e

Re: [dpdk-dev] [PATCH v1 26/38] net/mvpp2: rearrange functions order

2020-12-23 Thread Michael Shamis
Reviewed-by: Michael Shamis -Original Message- From: dev On Behalf Of lir...@marvell.com Sent: Wednesday, December 2, 2020 12:12 PM To: Jerin Jacob Kollanukkaran Cc: dev@dpdk.org; Liron Himi Subject: [dpdk-dev] [PATCH v1 26/38] net/mvpp2: rearrange functions order From: Liron Himi r

Re: [dpdk-dev] [PATCH v1 27/38] net/mvpp2: dummy pool creation

2020-12-23 Thread Michael Shamis
Reviewed-by: Michael Shamis -Original Message- From: dev On Behalf Of lir...@marvell.com Sent: Wednesday, December 2, 2020 12:12 PM To: Jerin Jacob Kollanukkaran Cc: dev@dpdk.org; Liron Himi Subject: [dpdk-dev] [PATCH v1 27/38] net/mvpp2: dummy pool creation From: Liron Himi Current

Re: [dpdk-dev] [PATCH v1 28/38] net/mvpp2: propagate port-id in udata64

2020-12-23 Thread Michael Shamis
Reviewed-by: Michael Shamis -Original Message- From: dev On Behalf Of lir...@marvell.com Sent: Wednesday, December 2, 2020 12:12 PM To: Jerin Jacob Kollanukkaran Cc: dev@dpdk.org; Liron Himi Subject: [dpdk-dev] [PATCH v1 28/38] net/mvpp2: propagate port-id in udata64 From: Liron Himi

Re: [dpdk-dev] [PATCH v1 29/38] net/mvpp2: autoneg disable handling

2020-12-23 Thread Michael Shamis
Reviewed-by: Michael Shamis -Original Message- From: dev On Behalf Of lir...@marvell.com Sent: Wednesday, December 2, 2020 12:12 PM To: Jerin Jacob Kollanukkaran Cc: dev@dpdk.org; Yuri Chipchev ; Liron Himi Subject: [dpdk-dev] [PATCH v1 29/38] net/mvpp2: autoneg disable handling From

Re: [dpdk-dev] [PATCH v1 31/38] net/mvpp2: add support of LINK_SPEED_2_5G

2020-12-23 Thread Michael Shamis
Reviewed-by: Michael Shamis -Original Message- From: dev On Behalf Of lir...@marvell.com Sent: Wednesday, December 2, 2020 12:12 PM To: Jerin Jacob Kollanukkaran Cc: dev@dpdk.org; Meir Levi ; Liron Himi Subject: [dpdk-dev] [PATCH v1 31/38] net/mvpp2: add support of LINK_SPEED_2_5G Fr

Re: [dpdk-dev] [PATCH v1 30/38] net/mvpp2: expose max mtu size

2020-12-23 Thread Michael Shamis
Reviewed-by: Michael Shamis -Original Message- From: dev On Behalf Of lir...@marvell.com Sent: Wednesday, December 2, 2020 12:12 PM To: Jerin Jacob Kollanukkaran Cc: dev@dpdk.org; Liron Himi ; Yuri Chipchev Subject: [dpdk-dev] [PATCH v1 30/38] net/mvpp2: expose max mtu size From: Lir

Re: [dpdk-dev] [PATCH v1 33/38] net/mvpp2: change dsa_mode naming

2020-12-23 Thread Michael Shamis
Reviewed-by: Michael Shamis -Original Message- From: dev On Behalf Of lir...@marvell.com Sent: Wednesday, December 2, 2020 12:12 PM To: Jerin Jacob Kollanukkaran Cc: dev@dpdk.org; Dana Vardi ; Liron Himi Subject: [dpdk-dev] [PATCH v1 33/38] net/mvpp2: change dsa_mode naming From: Dan

Re: [dpdk-dev] [PATCH v1 32/38] net/mvpp2: apply flow-ctrl after port init

2020-12-23 Thread Michael Shamis
Reviewed-by: Michael Shamis -Original Message- From: dev On Behalf Of lir...@marvell.com Sent: Wednesday, December 2, 2020 12:12 PM To: Jerin Jacob Kollanukkaran Cc: dev@dpdk.org; Liron Himi Subject: [dpdk-dev] [PATCH v1 32/38] net/mvpp2: apply flow-ctrl after port init From: Liron Hi

Re: [dpdk-dev] [PATCH v1 34/38] net/mvpp2: consider ptype in cksum info

2020-12-23 Thread Michael Shamis
Reviewed-by: Michael Shamis -Original Message- From: dev On Behalf Of lir...@marvell.com Sent: Wednesday, December 2, 2020 12:12 PM To: Jerin Jacob Kollanukkaran Cc: dev@dpdk.org; Liron Himi Subject: [dpdk-dev] [PATCH v1 34/38] net/mvpp2: consider ptype in cksum info From: Liron Himi

Re: [dpdk-dev] [PATCH v1 35/38] net/mvpp2: support custom header before ethernet

2020-12-23 Thread Michael Shamis
Reviewed-by: Michael Shamis -Original Message- From: dev On Behalf Of lir...@marvell.com Sent: Wednesday, December 2, 2020 12:12 PM To: Jerin Jacob Kollanukkaran Cc: dev@dpdk.org; Dana Vardi ; Liron Himi Subject: [dpdk-dev] [PATCH v1 35/38] net/mvpp2: support custom header before eth

Re: [dpdk-dev] [PATCH v1 36/38] net/mvpp2: forward bad packets support

2020-12-23 Thread Michael Shamis
Reviewed-by: Michael Shamis -Original Message- From: dev On Behalf Of lir...@marvell.com Sent: Wednesday, December 2, 2020 12:12 PM To: Jerin Jacob Kollanukkaran Cc: dev@dpdk.org; Dana Vardi ; Liron Himi Subject: [dpdk-dev] [PATCH v1 36/38] net/mvpp2: forward bad packets support From

Re: [dpdk-dev] [dpdk-dev 21.02 1/5] ethdev: add new tunnel type for ecpri

2020-12-23 Thread Zhang, Qi Z
> -Original Message- > From: Guo, Jia > Sent: Wednesday, December 16, 2020 4:59 PM > To: Zhang, Qi Z ; Wu, Jingjing ; > Yang, Qiming ; Wang, Haiyue > > Cc: dev@dpdk.org; Guo, Jia > Subject: [dpdk-dev 21.02 1/5] ethdev: add new tunnel type for ecpri > > Add type of RTE_TUNNEL_TYPE_ECP

Re: [dpdk-dev] [PATCH v1 37/38] net/mvpp2: update qos defaults parameter name

2020-12-23 Thread Michael Shamis
Reviewed-by: Michael Shamis -Original Message- From: dev On Behalf Of lir...@marvell.com Sent: Wednesday, December 2, 2020 12:12 PM To: Jerin Jacob Kollanukkaran Cc: dev@dpdk.org; Dana Vardi ; Liron Himi Subject: [dpdk-dev] [PATCH v1 37/38] net/mvpp2: update qos defaults parameter na

Re: [dpdk-dev] [PATCH v1 38/38] net/mvpp2: add fill_bpool_buffs to cfg file

2020-12-23 Thread Michael Shamis
Reviewed-by: Michael Shamis -Original Message- From: dev On Behalf Of lir...@marvell.com Sent: Wednesday, December 2, 2020 12:12 PM To: Jerin Jacob Kollanukkaran Cc: dev@dpdk.org; Dana Vardi ; Liron Himi Subject: [dpdk-dev] [PATCH v1 38/38] net/mvpp2: add fill_bpool_buffs to cfg file

Re: [dpdk-dev] [PATCH v1 22/38] net/mvpp2: flow: add support for RAW type

2020-12-23 Thread Michael Shamis
Reviewed-by: Michael Shamis -Original Message- From: dev On Behalf Of lir...@marvell.com Sent: Wednesday, December 2, 2020 12:12 PM To: Jerin Jacob Kollanukkaran Cc: dev@dpdk.org; Liron Himi Subject: [dpdk-dev] [PATCH v1 22/38] net/mvpp2: flow: add support for RAW type From: Liron Him

Re: [dpdk-dev] [PATCH v2] app/testpmd: fix dynamic config error

2020-12-23 Thread Li, Xiaoyun
Acked-by: Xiaoyun Li > -Original Message- > From: Steve Yang > Sent: Wednesday, December 23, 2020 16:52 > To: dev@dpdk.org > Cc: Lu, Wenzhuo ; Xing, Beilei ; > Iremonger, Bernard ; Li, Xiaoyun > ; Yang, Qiming ; Yang, SteveX > > Subject: [PATCH v2] app/testpmd: fix dynamic config error

[dpdk-dev] [PATCH v2] app/testpmd: fix dynamic config error

2020-12-23 Thread Steve Yang
The offloads of 'tx/rx_conf' didn't keep up with the corresponding offloads of 'dev_conf', it would cause the configuration invalid. For example: Configuring 'max-pkt-len' would change 'rx_offloads' in dev_conf while rx_conf.offloads of each queue still kept the old value. It would cause the failu

Re: [dpdk-dev] [PATCH v4] net/iavf: fix invalid RSS combinations rule can be created

2020-12-23 Thread Guo, Jia
Acked-by: Jeff Guo > -Original Message- > From: Murphy Yang > Sent: Wednesday, December 23, 2020 4:04 PM > To: dev@dpdk.org > Cc: Yang, Qiming ; Guo, Jia ; > Zhang, Qi Z ; Yang, SteveX ; > Wu, Jingjing ; Xing, Beilei ; > Yang, MurphyX > Subject: [PATCH v4] net/iavf: fix invalid RSS comb

Re: [dpdk-dev] [PATCH v1] net/iavf: support FDIR TCP/UDP pattern without input set

2020-12-23 Thread Zhang, Qi Z
> -Original Message- > From: Zhang, Yuying > Sent: Tuesday, December 1, 2020 4:32 PM > To: dev@dpdk.org; Zhang, Qi Z ; Wu, Jingjing > > Cc: Zhang, Yuying > Subject: [PATCH v1] net/iavf: support FDIR TCP/UDP pattern without input set > > This patch adds an input set refinement functio

[dpdk-dev] [PATCH v4] net/iavf: fix invalid RSS combinations rule can be created

2020-12-23 Thread Murphy Yang
Currently, when use 'flow' command to create a rule that combine with several RSS types, even the RSS type combination is invalid, it also be created successfully. Here list some invalid RSS combinations: - ETH_RSS_IPV4 | ETH_RSS_NONFRAG_IPV4_TCP - ETH_RSS_IPV6 | ETH_RSS_NONFRAG_IPV6_TCP - ETH_

  1   2   >