Re: [dpdk-dev] [PATCH] Remove printf from signal handler.

Hi I don't have a good solution here. Removing doesn't seem a good idea because there are many important alerts or reminders in all of those function calls and they may be called in other places too. I think replacing with "write" can't solve the problem too. Because behavior like stopping port

[dpdk-dev] [PATCH v5 9/9] net/ionic: minor logging fixups

Expose ionic_opcode_to_str() so it can be used for dev cmds, too. Store the device name in struct adapter. Switch to memcpy() to work around gcc false positives. Signed-off-by: Andrew Boyer --- drivers/net/ionic/ionic.h| 1 + drivers/net/ionic/ionic_dev.c| 5 drivers/net/ioni

[dpdk-dev] [PATCH v5 8/9] net/ionic: minor refactorings and helper variables

This makes the code clearer and conserves resources. Signed-off-by: Andrew Boyer --- drivers/net/ionic/ionic_lif.c | 15 ++- drivers/net/ionic/ionic_main.c | 18 +++--- 2 files changed, 17 insertions(+), 16 deletions(-) diff --git a/drivers/net/ionic/ionic_lif.c b/drive

[dpdk-dev] [PATCH v5 7/9] net/ionic: warn if loopback mode is requested

The ionic FW does not support loopback mode at this time. Signed-off-by: Andrew Boyer --- drivers/net/ionic/ionic_ethdev.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/ionic/ionic_ethdev.c b/drivers/net/ionic/ionic_ethdev.c index cd79f250e..ce6ca9671 100644 --- a/drivers/ne

[dpdk-dev] [PATCH v5 6/9] net/ionic: convert 'deferred' boolean to a flag bit

This conserves resources. Signed-off-by: Andrew Boyer --- drivers/net/ionic/ionic_lif.c | 4 ++-- drivers/net/ionic/ionic_lif.h | 2 +- drivers/net/ionic/ionic_rxtx.c | 10 ++ 3 files changed, 9 insertions(+), 7 deletions(-) diff --git a/drivers/net/ionic/ionic_lif.c b/drivers/net/i

[dpdk-dev] [PATCH v5 5/9] net/ionic: remove some unused fields

This conserves resources. Signed-off-by: Andrew Boyer --- drivers/net/ionic/ionic.h| 1 - drivers/net/ionic/ionic_dev.c| 5 + drivers/net/ionic/ionic_dev.h| 7 +-- drivers/net/ionic/ionic_ethdev.c | 2 -- drivers/net/ionic/ionic_lif.c| 22 ++ d

[dpdk-dev] [PATCH v5 4/9] net/ionic: check for cmd completion more frequently

This reduces the startup time a bit. Signed-off-by: Neel Patel Signed-off-by: Andrew Boyer --- drivers/net/ionic/ionic_dev.h | 4 +++- drivers/net/ionic/ionic_main.c | 36 - drivers/net/ionic/ionic_osdep.h | 10 - 3 files changed, 21 insertions(+), 29

[dpdk-dev] [PATCH v5 3/9] net/ionic: update documentation and MAINTAINERS

The UNMAINTAINED flag will be removed in a future patch. Signed-off-by: Andrew Boyer --- MAINTAINERS| 2 +- doc/guides/nics/features/ionic.ini | 1 + doc/guides/nics/ionic.rst | 13 +++-- 3 files changed, 9 insertions(+), 7 deletions(-) diff --git a/MA

[dpdk-dev] [PATCH v5 2/9] net/ionic: update interface file to the latest version

The ionic_if.h file contains the firmware interface definitions. Signed-off-by: Andrew Boyer --- drivers/net/ionic/ionic_if.h | 1343 ++-- drivers/net/ionic/ionic_regs.h |3 - 2 files changed, 930 insertions(+), 416 deletions(-) diff --git a/drivers/net/ionic/i

[dpdk-dev] [PATCH v5 1/9] net/ionic: connect ionic to the build system

Otherwise the ionic PMD is never built. Signed-off-by: Andrew Boyer --- drivers/net/meson.build | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/meson.build b/drivers/net/meson.build index 29f477750..6e4aa6bf3 100644 --- a/drivers/net/meson.build +++ b/drivers/net/meson.build @@ -

[dpdk-dev] [PATCH v5 0/9] net/ionic: minor updates and documentation

These patches make some minor changes to the ionic PMD. Signed-off-by: Andrew Boyer --- v5: * Fix syntax error in .rst file v4: * Address additional reviewer comments v3: * Fixed up false-positives from codespell and gcc 8.3/9.3 v2: * Address Ferruh's comments (thank you!) * Switch to net/ion

[dpdk-dev] [RFC] net/ionic: update MTU calculations

This RFC is in response to the threads about testpmd mtu settings and the deprecation of max-rx-pkt-len. It took us a while to figure out what we were supposed to be doing in this part of the API. It is not clear if max_rx_pkt_len should be an input to or an output from the PMD. The code below re

[dpdk-dev] [PATCH v4 9/9] net/ionic: minor logging fixups

Expose ionic_opcode_to_str() so it can be used for dev cmds, too. Store the device name in struct adapter. Switch to memcpy() to work around gcc false positives. Signed-off-by: Andrew Boyer --- drivers/net/ionic/ionic.h| 1 + drivers/net/ionic/ionic_dev.c| 5 drivers/net/ioni

[dpdk-dev] [PATCH v4 8/9] net/ionic: minor refactorings and helper variables

This makes the code clearer and conserves resources. Signed-off-by: Andrew Boyer --- drivers/net/ionic/ionic_lif.c | 15 ++- drivers/net/ionic/ionic_main.c | 18 +++--- 2 files changed, 17 insertions(+), 16 deletions(-) diff --git a/drivers/net/ionic/ionic_lif.c b/drive

[dpdk-dev] [PATCH v4 7/9] net/ionic: warn if loopback mode is requested

The ionic FW does not support loopback mode at this time. Signed-off-by: Andrew Boyer --- drivers/net/ionic/ionic_ethdev.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/ionic/ionic_ethdev.c b/drivers/net/ionic/ionic_ethdev.c index cd79f250e..ce6ca9671 100644 --- a/drivers/ne

[dpdk-dev] [PATCH v4 6/9] net/ionic: convert 'deferred' boolean to a flag bit

This conserves resources. Signed-off-by: Andrew Boyer --- drivers/net/ionic/ionic_lif.c | 4 ++-- drivers/net/ionic/ionic_lif.h | 2 +- drivers/net/ionic/ionic_rxtx.c | 10 ++ 3 files changed, 9 insertions(+), 7 deletions(-) diff --git a/drivers/net/ionic/ionic_lif.c b/drivers/net/i

[dpdk-dev] [PATCH v4 5/9] net/ionic: remove some unused fields

This conserves resources. Signed-off-by: Andrew Boyer --- drivers/net/ionic/ionic.h| 1 - drivers/net/ionic/ionic_dev.c| 5 + drivers/net/ionic/ionic_dev.h| 7 +-- drivers/net/ionic/ionic_ethdev.c | 2 -- drivers/net/ionic/ionic_lif.c| 22 ++ d

[dpdk-dev] [PATCH v4 4/9] net/ionic: check for cmd completion more frequently

This reduces the startup time a bit. Signed-off-by: Neel Patel Signed-off-by: Andrew Boyer --- drivers/net/ionic/ionic_dev.h | 4 +++- drivers/net/ionic/ionic_main.c | 36 - drivers/net/ionic/ionic_osdep.h | 10 - 3 files changed, 21 insertions(+), 29

[dpdk-dev] [PATCH v4 2/9] net/ionic: update interface file to the latest version

The ionic_if.h file contains the firmware interface definitions. Signed-off-by: Andrew Boyer --- drivers/net/ionic/ionic_if.h | 1343 ++-- drivers/net/ionic/ionic_regs.h |3 - 2 files changed, 930 insertions(+), 416 deletions(-) diff --git a/drivers/net/ionic/i

[dpdk-dev] [PATCH v4 3/9] net/ionic: update documentation and MAINTAINERS

The UNMAINTAINED flag will be removed in a future patch. Signed-off-by: Andrew Boyer --- MAINTAINERS| 2 +- doc/guides/nics/features/ionic.ini | 1 + doc/guides/nics/ionic.rst | 13 +++-- 3 files changed, 9 insertions(+), 7 deletions(-) diff --git a/MA

[dpdk-dev] [PATCH v4 1/9] net/ionic: connect ionic to the build system

Otherwise the ionic PMD is never built. Signed-off-by: Andrew Boyer --- drivers/net/meson.build | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/meson.build b/drivers/net/meson.build index 29f477750..6e4aa6bf3 100644 --- a/drivers/net/meson.build +++ b/drivers/net/meson.build @@ -

[dpdk-dev] [PATCH v4 0/9] net/ionic: minor updates and documentation

These patches make some minor changes to the ionic PMD. Signed-off-by: Andrew Boyer --- v4: * Address additional reviewer comments v3: * Fixed up false-positives from codespell and gcc 8.3/9.3 v2: * Address Ferruh's comments (thank you!) * Switch to net/ionic: prefix * Leave UNMAINTAINED flag

Re: [dpdk-dev] [PATCH 3/3] config/build: ignore enum forward reference warning

On Fri, Dec 04, 2020 at 05:10:20PM -0800, Pallavi Kadam wrote: > Warning generated using Clang compiler: > ..\drivers\net\i40e\base/i40e_osdep.h:34:14: warning: forward references > to 'enum' types are a Microsoft extension > [-Wmicrosoft-enum-forward-reference] > typedef enum i40e_status_code i40e

[dpdk-dev] [PATCH v3 17/17] net/bnxt: modify ring index logic

Change the ring logic so that the index increments unbounded and mask it only when needed. Modify the existing macros so that the index is not masked. Add a new macro RING_IDX() to mask it only when needed. - v2->v3: Updated the index calculation in Tx completion processing. Signed-off-by: Ajit K

[dpdk-dev] [PATCH v3 16/17] net/bnxt: add missing comments

Add and update some missing comments in the code. Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt.h | 6 ++ drivers/net/bnxt/tf_ulp/ulp_template_db_act.c | 5 + drivers/net/bnxt/tf_ulp/ulp_template_db_class.c | 6 ++ 3 files changed, 17 insertions(+)

[dpdk-dev] [PATCH v3 15/17] net/bnxt: changes to indentation and coding style

Indentation and coding style fixes. Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt.h| 4 ++-- drivers/net/bnxt/bnxt_ethdev.c | 9 - drivers/net/bnxt/bnxt_reps.c | 2 +- drivers/net/bnxt/bnxt_ring.c | 3 +-- 4 files changed, 8 insertions(+), 10 deletions(-) diff --git

[dpdk-dev] [PATCH v3 14/17] net/bnxt: fix PF resource query

From: Somnath Kotur This cmd should be called by every driver after 'hwrm_func_cfg' to get the actual number of resources allocated by the HWRM. The values returned in the cmd are the max values for that PF. Also, now that the max values for the PF are computed in probe itself, no need to invoke

[dpdk-dev] [PATCH v3 13/17] net/bnxt: fix vnic RSS configure function

From: Kalesh AP 1. moved invalid VNIC id check to the beginning of the function. 2. removed a duplicate check which avoids unnecessary code indentation. Fixes: 49d0709b257fc ("net/bnxt: delete and flush L2 filters cleanly") Cc: sta...@dpdk.org Signed-off-by: Kalesh AP Reviewed-by: Somnath Kotu

[dpdk-dev] [PATCH v3 12/17] net/bnxt: remove function declaration

Remove an orphan function declaration. It has not been defined yet and hence not used anywhere. Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_hwrm.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/bnxt/bnxt_hwrm.h b/drivers/net/bnxt/bnxt_hwrm.h index 23ca6ab51..4b329077

[dpdk-dev] [PATCH v3 11/17] net/bnxt: use the right function to free mbuf

mbufs are being allocated using rte_mbuf_raw_alloc(). Use corresponding rte_mbuf_raw_free() to free mbuf. Signed-off-by: Somnath Kotur Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_reps.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/bnxt/bnxt_reps.c

[dpdk-dev] [PATCH v3 10/17] net/bnxt: support for 236 queues in NS3

From: Rahul Gupta For NS3, increased CONFIG_RTE_ETHDEV_QUEUE_STAT_CNTRS to support 236 counters and increased MAX_STINGRAY_RINGS in driver to support more rings. Signed-off-by: Rahul Gupta Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/bnxt.h | 3 +-- 1 file changed, 1 insertion(+), 2 deleti

[dpdk-dev] [PATCH v3 09/17] net/bnxt: fix max rings computation

From: Sriharsha Basavapatna The current max_rings computation does not take into account the case when max_nq_rings is <= num_async_cpr. This results in a wrong value like 0, when max_nq_rings is 1. Fix this by subtracting num_async_cpr only when max_cp_rings > num_async_cpr. Apart from this, th

[dpdk-dev] [PATCH v3 08/17] net/bnxt: fix format specifier for unsigned int

&device requires the %u format specifer not the %d specifier, as &device is unsigned. Fixes: a46bbb57605b ("net/bnxt: update multi device design") Cc: sta...@dpdk.org Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/tf_core/tf_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[dpdk-dev] [PATCH v3 07/17] net/bnxt: fix cleanup on mutex init failure

In case mutex init fails during initialization, start cleanup and fail the initialization process. Fixes: a73b8e939f10 ("net/bnxt: fix race between start and interrupt handler") Cc: sta...@dpdk.org Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_ethdev.c | 4 +++- 1 file changed, 3 inser

[dpdk-dev] [PATCH v3 06/17] net/bnxt: fix to return error when fw command fails

From: Kalesh AP In bnxt_reta_update_op() and bnxt_rss_hash_update_op(), driver does not propagate the error back to the application when the fw command fails. Fixes: 378ab645bb0b ("net/bnxt: fix RSS RETA indirection table ops") Fixes: fcc0aa1edc10 ("net/bnxt: add RSS hash configuration") Cc: sta

[dpdk-dev] [PATCH v3 05/17] net/bnxt: remove references to Thor

Refactor code to remove references to Thor. Instead use P5 as in phase 5 of development cycle since it is applicable to boards other than Thor as well. Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt.h| 20 +++--- drivers/net/bnxt/bnxt_ethdev.c | 43 +++

[dpdk-dev] [PATCH v3 04/17] net/bnxt: release hwrm lock in the error case

From: Kalesh AP In __bnxt_hwrm_func_qcaps, when memory allocations fails driver is not releasing the hwrm lock. This patch fixes it by calling hwrm_unlock in that error case. Fixes: b7778e8a1c00 ("net/bnxt: refactor to properly allocate resources for PF/VF") Cc: sta...@dpdk.org Signed-off-by:

[dpdk-dev] [PATCH v3 03/17] net/bnxt: remove unused field

Remove flow_xstat from bnxt structure. Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/bnxt/bnxt.h b/drivers/net/bnxt/bnxt.h index 9bd4f1da9..f13d586d4 100644 --- a/drivers/net/bnxt/bnxt.h +++ b/drivers/net/bnxt/bnxt.h @@ -8

[dpdk-dev] [PATCH v3 02/17] net/bnxt: fix VNIC config on Rx queue stop

From: Samik Gupta This commit reconfigures a vnic's default ring if the current default ring is stopped by the application. It picks the lowest numbered ring that is currently active to be the new default, and issues the hwrm_vnic_cfg command to update the configuration. Applies to adapters that

[dpdk-dev] [PATCH v3 01/17] net/bnxt: fix RX rings in RSS redirection table

From: Samik Gupta This commit introduces a limit on the number of RX rings included in the RSS redirection table to a value no larger than the size supported by Thor as defined by BNXT_RSS_TBL_SIZE_THOR. Fixes: d819382543f3 ("net/bnxt: add RSS redirection table operations") Cc: sta...@dpdk.org

[dpdk-dev] [PATCH v3 00/17] fixes and refactoring changes for bnxt

Some fixes and refactoring changes for bnxt PMD. v1->v2: Resend without the legal signature/footer. v2->v3: Fix index calculation in patch 17/17. Ajit Khaparde (9): net/bnxt: remove unused field net/bnxt: remove references to Thor net/bnxt: fix cleanup on mutex init failure net/bnxt: fix

Re: [dpdk-dev] [PATCH v2 17/17] net/bnxt: modify ring index logic

On Wed, Dec 9, 2020 at 2:28 PM Ajit Khaparde wrote: > > Change the ring logic so that the index increments > unbounded and mask it only when needed. > > Modify the existing macros so that the index is not masked. > Add a new macro RING_IDX() to mask it only when needed. > > Signed-off-by: Ajit Kha

Re: [dpdk-dev] Q about testpmd and link speed settings

Any replies to this? Am I understanding the API correctly? -Andrew > On Nov 25, 2020, at 3:55 PM, Andrew Boyer wrote: > > Almost every PMD seems to do something like this (igb in this example): > > autoneg = (*speeds & ETH_LINK_SPEED_FIXED) == 0; > > But testpmd’s parse_and_check_speed_

Re: [dpdk-dev] [PATCH v3 9/9] net/ionic: minor logging fixups

> On Dec 9, 2020, at 10:42 AM, Ferruh Yigit wrote: > > On 12/9/2020 2:45 PM, Andrew Boyer wrote: >>> On Dec 9, 2020, at 8:47 AM, Ferruh Yigit >> > wrote: >>> >>> On 12/4/2020 8:16 PM, Andrew Boyer wrote: Expose ionic_opcode_to_str() so it can be used for de

[dpdk-dev] [PATCH v2 17/17] net/bnxt: modify ring index logic

Change the ring logic so that the index increments unbounded and mask it only when needed. Modify the existing macros so that the index is not masked. Add a new macro RING_IDX() to mask it only when needed. Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_cpr.h | 10 ++- driv

[dpdk-dev] [PATCH v2 16/17] net/bnxt: add missing comments

Add and update some missing comments in the code. Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt.h | 6 ++ drivers/net/bnxt/tf_ulp/ulp_template_db_act.c | 5 + drivers/net/bnxt/tf_ulp/ulp_template_db_class.c | 6 ++ 3 files changed, 17 insertions(+)

[dpdk-dev] [PATCH v2 15/17] net/bnxt: changes to indentation and coding style

Indentation and coding style fixes. Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt.h| 4 ++-- drivers/net/bnxt/bnxt_ethdev.c | 9 - drivers/net/bnxt/bnxt_reps.c | 2 +- drivers/net/bnxt/bnxt_ring.c | 3 +-- 4 files changed, 8 insertions(+), 10 deletions(-) diff --git

[dpdk-dev] [PATCH v2 14/17] net/bnxt: fix PF resource query

From: Somnath Kotur This cmd should be called by every driver after 'hwrm_func_cfg' to get the actual number of resources allocated by the HWRM. The values returned in the cmd are the max values for that PF. Also, now that the max values for the PF are computed in probe itself, no need to invoke

[dpdk-dev] [PATCH v2 13/17] net/bnxt: fix vnic RSS configure function

From: Kalesh AP 1. moved invalid VNIC id check to the beginning of the function. 2. removed a duplicate check which avoids unnecessary code indentation. Fixes: 49d0709b257fc ("net/bnxt: delete and flush L2 filters cleanly") Cc: sta...@dpdk.org Signed-off-by: Kalesh AP Reviewed-by: Somnath Kotu

[dpdk-dev] [PATCH v2 12/17] net/bnxt: remove function declaration

Remove an orphan function declaration. It has not been defined yet and hence not used anywhere. Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_hwrm.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/bnxt/bnxt_hwrm.h b/drivers/net/bnxt/bnxt_hwrm.h index 23ca6ab51..4b329077

[dpdk-dev] [PATCH v2 11/17] net/bnxt: use the right function to free mbuf

mbufs are being allocated using rte_mbuf_raw_alloc(). Use corresponding rte_mbuf_raw_free() to free mbuf. Signed-off-by: Somnath Kotur Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_reps.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/bnxt/bnxt_reps.c

[dpdk-dev] [PATCH v2 10/17] net/bnxt: support for 236 queues in NS3

From: Rahul Gupta For NS3, increased CONFIG_RTE_ETHDEV_QUEUE_STAT_CNTRS to support 236 counters and increased MAX_STINGRAY_RINGS in driver to support more rings. Signed-off-by: Rahul Gupta Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/bnxt.h | 3 +-- 1 file changed, 1 insertion(+), 2 deleti

[dpdk-dev] [PATCH v2 09/17] net/bnxt: fix max rings computation

From: Sriharsha Basavapatna The current max_rings computation does not take into account the case when max_nq_rings is <= num_async_cpr. This results in a wrong value like 0, when max_nq_rings is 1. Fix this by subtracting num_async_cpr only when max_cp_rings > num_async_cpr. Apart from this, th

[dpdk-dev] [PATCH v2 08/17] net/bnxt: fix format specifier for unsigned int

&device requires the %u format specifer not the %d specifier, as &device is unsigned. Fixes: a46bbb57605b ("net/bnxt: update multi device design") Cc: sta...@dpdk.org Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/tf_core/tf_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[dpdk-dev] [PATCH v2 06/17] net/bnxt: fix to return error when fw command fails

From: Kalesh AP In bnxt_reta_update_op() and bnxt_rss_hash_update_op(), driver does not propagate the error back to the application when the fw command fails. Fixes: 378ab645bb0b ("net/bnxt: fix RSS RETA indirection table ops") Fixes: fcc0aa1edc10 ("net/bnxt: add RSS hash configuration") Cc: sta

[dpdk-dev] [PATCH v2 07/17] net/bnxt: fix cleanup on mutex init failure

In case mutex init fails during initialization, start cleanup and fail the initialization process. Fixes: a73b8e939f10 ("net/bnxt: fix race between start and interrupt handler") Cc: sta...@dpdk.org Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_ethdev.c | 4 +++- 1 file changed, 3 inser

[dpdk-dev] [PATCH v2 05/17] net/bnxt: remove references to Thor

Refactor code to remove references to Thor. Instead use P5 as in phase 5 of development cycle since it is applicable to boards other than Thor as well. Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt.h| 20 +++--- drivers/net/bnxt/bnxt_ethdev.c | 43 +++

[dpdk-dev] [PATCH v2 04/17] net/bnxt: release hwrm lock in the error case

From: Kalesh AP In __bnxt_hwrm_func_qcaps, when memory allocations fails driver is not releasing the hwrm lock. This patch fixes it by calling hwrm_unlock in that error case. Fixes: b7778e8a1c00 ("net/bnxt: refactor to properly allocate resources for PF/VF") Cc: sta...@dpdk.org Signed-off-by:

[dpdk-dev] [PATCH v2 03/17] net/bnxt: remove unused field

Remove flow_xstat from bnxt structure. Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/bnxt/bnxt.h b/drivers/net/bnxt/bnxt.h index 9bd4f1da9..f13d586d4 100644 --- a/drivers/net/bnxt/bnxt.h +++ b/drivers/net/bnxt/bnxt.h @@ -8

[dpdk-dev] [PATCH v2 02/17] net/bnxt: fix VNIC config on Rx queue stop

From: Samik Gupta This commit reconfigures a vnic's default ring if the current default ring is stopped by the application. It picks the lowest numbered ring that is currently active to be the new default, and issues the hwrm_vnic_cfg command to update the configuration. Applies to adapters that

[dpdk-dev] [PATCH v2 01/17] net/bnxt: fix RX rings in RSS redirection table

From: Samik Gupta This commit introduces a limit on the number of RX rings included in the RSS redirection table to a value no larger than the size supported by Thor as defined by BNXT_RSS_TBL_SIZE_THOR. Fixes: d819382543f3 ("net/bnxt: add RSS redirection table operations") Cc: sta...@dpdk.org

[dpdk-dev] [PATCH v2 00/17] fixes and refactoring changes for bnxt

Some fixes and refactoring changes for bnxt PMD. v1->v2: Resend without the legal signature/footer. Ajit Khaparde (9): net/bnxt: remove unused field net/bnxt: remove references to Thor net/bnxt: fix cleanup on mutex init failure net/bnxt: fix format specifier for unsigned int net/bnxt:

Re: [dpdk-dev] [PATCH v3 3/9] net/ionic: update documentation and MAINTAINERS

> On Dec 9, 2020, at 12:15 PM, Ferruh Yigit wrote: > > On 12/9/2020 4:24 PM, Andrew Boyer wrote: >>> On Dec 9, 2020, at 10:24 AM, Ferruh Yigit >> > wrote: >>> >>> On 12/9/2020 2:36 PM, Andrew Boyer wrote: Please respond to my questions this time. I have ~70

Re: [dpdk-dev] [PATCH v11 2/7] net/bnxt: fix aarch32 build

On Wed, Dec 9, 2020 at 7:59 AM Juraj Linkeš wrote: > > From: Ruifeng Wang > > NEON vector path of the PMD needs aarch64 support. But it was > enabled for aarch32 build as well because aarch32 build had > cpu_family set to aarch64. So build for aarch32 will fail due > to unsupported intrinsics. >

Re: [dpdk-dev] [PATCH v11 3/7] net/bnxt: add support for aarch32

On Wed, Dec 9, 2020 at 8:00 AM Juraj Linkeš wrote: > > From: Ruifeng Wang > > Expand vector PMD support to aarch32. > > Signed-off-by: Ruifeng Wang > Acked-by: Ajit Khaparde > --- > drivers/net/bnxt/bnxt_rxq.h | 2 +- > drivers/net/bnxt/bnxt_rxr.h | 2 +- > drivers/net/bnxt/bnxt_txr.h | 2 +- >

[dpdk-dev] [PATCH] net/i40e: issue with ADD VLAN from Guest

In case of i40evf pmd, when ADD_VLAN is sent down the linux i40e driver, along with add the vlan the kernel driver also enables the vlan stripping by default. This might have issues if the app configured DEV_RX_OFFLOAD_VLAN_STRIP as off at the port configuration. The app after adding the VLAN will

[dpdk-dev] [PATCH 1/2] net/i40e: issue with ADD VLAN from Guest

In case of i40evf pmd, when ADD_VLAN is sent down the linux i40e driver, along with add the vlan the kernel driver also enables the vlan stripping by default. This might have issues if the app configured DEV_RX_OFFLOAD_VLAN_STRIP as off at the port configuration. The app after adding the VLAN will

Re: [dpdk-dev] [PATCH v3 3/9] net/ionic: update documentation and MAINTAINERS

On 12/9/2020 4:24 PM, Andrew Boyer wrote: On Dec 9, 2020, at 10:24 AM, Ferruh Yigit > wrote: On 12/9/2020 2:36 PM, Andrew Boyer wrote: Please respond to my questions this time. I have ~70 more patches to post by December 20. On Dec 9, 2020, at 7:03 AM, Ferruh Yi

[dpdk-dev] [PATCH] build: remove compatibility build defines

As announced in the deprecation note, remove all compatibility build defines from previous make/meson versions and use only the standardized ones - RTE_LIB_ for libraries, and RTE__ for drivers. Signed-off-by: Bruce Richardson --- config/meson.build| 2 +- config/rte_compat

Re: [dpdk-dev] [PATCH v3 3/9] net/ionic: update documentation and MAINTAINERS

> On Dec 9, 2020, at 10:24 AM, Ferruh Yigit wrote: > > On 12/9/2020 2:36 PM, Andrew Boyer wrote: >> Please respond to my questions this time. I have ~70 more patches to post by >> December 20. >>> On Dec 9, 2020, at 7:03 AM, Ferruh Yigit >> > wrote: >>> >>> On 1

[dpdk-dev] [PATCH] net/i40e: issue with ADD VLAN from Guest

In case of i40evf pmd, when ADD_VLAN is sent down the linux i40e driver, along with add the vlan the kernel driver also enables the vlan stripping by default. This might have issues if the app configured DEV_RX_OFFLOAD_VLAN_STRIP as off at the port configuration. The app after adding the VLAN will

Re: [dpdk-dev] Windows DPDK real-time priority threads causing thread starvation

On Wed, 9 Dec 2020 14:15:30 + Tal Shnaiderman wrote: > Hi, > > During our verification tests on Windows DPDK we've noticed that DPDK polling > threads, which run in REALTIME_PRIORITY_CLASS are causing starvation to other > threads from the OS which need to change affinity and run in lower

Re: [dpdk-dev] Windows DPDK real-time priority threads causing thread starvation

Hi, I tend to run with a winbdg kernel debugger (KDNET) connected to my debug target machines. It quite often reports deadlock detection when we have such "real-time" threads never yielding on a core. If we hog core-0 in particular dwm.exe never gets a look in so the desktop stops being drawn

[dpdk-dev] [Bug 599] netvsc PMD in multi-queue mode failed with 'invalid NVS resp len' error

https://bugs.dpdk.org/show_bug.cgi?id=599 Bug ID: 599 Summary: netvsc PMD in multi-queue mode failed with 'invalid NVS resp len' error Product: DPDK Version: 19.11 Hardware: x86 OS: Linux Status:

Re: [dpdk-dev] [PATCH v3 9/9] net/ionic: minor logging fixups

On 12/9/2020 2:45 PM, Andrew Boyer wrote: On Dec 9, 2020, at 8:47 AM, Ferruh Yigit > wrote: On 12/4/2020 8:16 PM, Andrew Boyer wrote: Expose ionic_opcode_to_str() so it can be used for dev cmds, too. Store the device name in struct adapter. Switch to memcpy() t

Re: [dpdk-dev] [PATCH v11 6/7] ci: add aarch64 -> aarch32 cross compiling jobs

Juraj Linkeš writes: > Add two jobs (static and shared libs), both building on aarch64 and > producing 32-bit arm binaries executable on armv8-a, but not armv7. > Do not run tests in these jobs. > > Signed-off-by: Juraj Linkeš > Reviewed-by: Ruifeng Wang > --- Acked-by: Aaron Conole FYI, tra

Re: [dpdk-dev] [PATCH v3 8/9] net/ionic: minor refactorings and helper variables

On 12/9/2020 2:39 PM, Andrew Boyer wrote: On Dec 9, 2020, at 8:04 AM, Ferruh Yigit > wrote: On 12/4/2020 8:16 PM, Andrew Boyer wrote: This makes the code clearer and conserves resources. Signed-off-by: Andrew Boyer mailto:abo...@pensando.io>> ---  drivers/net/i

Re: [dpdk-dev] [PATCH v3 3/9] net/ionic: update documentation and MAINTAINERS

On 12/9/2020 2:36 PM, Andrew Boyer wrote: Please respond to my questions this time. I have ~70 more patches to post by December 20. On Dec 9, 2020, at 7:03 AM, Ferruh Yigit > wrote: On 12/4/2020 8:16 PM, Andrew Boyer wrote: The UNMAINTAINED flag will be removed

[dpdk-dev] [PATCH] net/mlx5:fix storing the synced MAC to internal table

As the internal MAC table is divided into Unicast and Multicast address section, we should check the type of synced MAC address before storing it to the internal table. Currently the check is not done, and the synced MAC of 33:33:00:00:00:01 gets stored in the unicast section (mostly index 1) which

[dpdk-dev] [PATCH] net/mlx5:fix storing the synced MAC to internal table

During the mlx5_dev_spawn(), it tries to sync the MAC address of the Device to the internal MAC table. In case of SR-IOV VF , the mlx5_nl_mac_addr_sync() gets, 2 MAC address in the fresh start. One the unicast MAC assigned to the VF on the host and the second the multicast mac of 33:33:00:00:00:0

Re: [dpdk-dev] [PATCH v3 9/9] net/ionic: minor logging fixups

> On Dec 9, 2020, at 8:47 AM, Ferruh Yigit wrote: > > On 12/4/2020 8:16 PM, Andrew Boyer wrote: >> Expose ionic_opcode_to_str() so it can be used for dev cmds, too. >> Store the device name in struct adapter. >> Switch to memcpy() to work around gcc false positives. >> Signed-off-by: Andrew Bo

Re: [dpdk-dev] [PATCH v3 8/9] net/ionic: minor refactorings and helper variables

> On Dec 9, 2020, at 8:04 AM, Ferruh Yigit wrote: > > On 12/4/2020 8:16 PM, Andrew Boyer wrote: >> This makes the code clearer and conserves resources. >> Signed-off-by: Andrew Boyer >> --- >> drivers/net/ionic/ionic_ethdev.c | 5 ++--- >> drivers/net/ionic/ionic_lif.c| 15 ++---

Re: [dpdk-dev] [PATCH v3 3/9] net/ionic: update documentation and MAINTAINERS

Please respond to my questions this time. I have ~70 more patches to post by December 20. > On Dec 9, 2020, at 7:03 AM, Ferruh Yigit wrote: > > On 12/4/2020 8:16 PM, Andrew Boyer wrote: >> The UNMAINTAINED flag will be removed in a future patch. >> Signed-off-by: Andrew Boyer >> --- >> MAINTA

Re: [dpdk-dev] [PATCH v1] net/axgbe: add support for reading FW version

On 11/19/2020 7:26 AM, selwin.sebast...@amd.com wrote: From: Selwin Sebastian Added support for fw_version_get API Signed-off-by: Selwin Sebastian --- doc/guides/nics/features/axgbe.ini | 1 + drivers/net/axgbe/axgbe_ethdev.c | 1 + drivers/net/axgbe/axgbe_rxtx.c | 21

Re: [dpdk-dev] [PATCH v11 2/7] net/bnxt: fix aarch32 build

> -Original Message- > From: Lance Richardson > Sent: Wednesday, December 9, 2020 10:10 PM > To: Juraj Linkeš > Cc: tho...@monjalon.net; Bruce Richardson ; > acon...@redhat.com; maicolgabr...@hotmail.com; dev@dpdk.org; Ruifeng > Wang ; sta...@dpdk.org > Subject: Re: [PATCH v11 2/7] net/bn

Re: [dpdk-dev] [PATCH 21.02 2/3] vhost: refactor postcopy registration

> -Original Message- > From: Maxime Coquelin > Sent: Monday, November 16, 2020 7:36 PM > To: dev@dpdk.org; Xia, Chenbo ; Ding, Xuan > > Cc: Maxime Coquelin > Subject: [PATCH 21.02 2/3] vhost: refactor postcopy registration > > This patch moves the registration of postcopy to a > dedicat

Re: [dpdk-dev] [PATCH 21.02 3/3] vhost: refactor memory regions mapping

> -Original Message- > From: Maxime Coquelin > Sent: Monday, November 16, 2020 7:36 PM > To: dev@dpdk.org; Xia, Chenbo ; Ding, Xuan > > Cc: Maxime Coquelin > Subject: [PATCH 21.02 3/3] vhost: refactor memory regions mapping > > This patch moves memory region mmaping and related > prepar

Re: [dpdk-dev] [PATCH 21.02 1/3] vhost: refactor postcopy region registration

Hi Maxime, > -Original Message- > From: Maxime Coquelin > Sent: Monday, November 16, 2020 7:36 PM > To: dev@dpdk.org; Xia, Chenbo ; Ding, Xuan > > Cc: Maxime Coquelin > Subject: [PATCH 21.02 1/3] vhost: refactor postcopy region registration > > This patch moves the registration of memo

[dpdk-dev] Windows DPDK real-time priority threads causing thread starvation

Hi, During our verification tests on Windows DPDK we've noticed that DPDK polling threads, which run in REALTIME_PRIORITY_CLASS are causing starvation to other threads from the OS which need to change affinity and run in lower priority. While running an application for a while we see the OS thr

Re: [dpdk-dev] [PATCH v11 3/7] net/bnxt: add support for aarch32

> -Original Message- > From: Lance Richardson > Sent: Wednesday, December 9, 2020 10:00 PM > To: Juraj Linkeš > Cc: tho...@monjalon.net; Bruce Richardson ; > acon...@redhat.com; maicolgabr...@hotmail.com; dev@dpdk.org; Ruifeng > Wang > Subject: Re: [dpdk-dev] [PATCH v11 3/7] net/bnxt: ad

Re: [dpdk-dev] [PATCH] common/sfc_efx/base: support alternative MAE match fields

On 12/1/2020 7:30 AM, Ivan Malov wrote: If MAE slice is configured without conntrack support, outer rules must match on IP SRC/DST. This isn't reported clearly by the FW because IPv4 and IPv6 have separate SRC/DST pairs. The FW reports status ALWAYS for all these four fields, and having an all-ze

Re: [dpdk-dev] [PATCH v3 9/9] net/ionic: minor logging fixups

On 12/4/2020 8:16 PM, Andrew Boyer wrote: Expose ionic_opcode_to_str() so it can be used for dev cmds, too. Store the device name in struct adapter. Switch to memcpy() to work around gcc false positives. Signed-off-by: Andrew Boyer --- drivers/net/ionic/ionic.h | 1 + drivers/net/i

[dpdk-dev] [PATCH] net/mlx5:fix storing the synced MAC to internal table

As the internal MAC table is divided into Unicast and Multicast address section, we should check the type of synced MAC address before storing it to the internal table. Currently the check is not done, and the synced MAC of 33:33:00:00:00:01 gets stored in the unicast section (mostly index 1) which

[dpdk-dev] [PATCH] net/mlx5:fix storing the synced MAC to internal table

During the mlx5_dev_spawn(), it tries to sync the MAC address of the Device to the internal MAC table. In case of SR-IOV VF , the mlx5_nl_mac_addr_sync() gets, 2 MAC address in the fresh start. One the unicast MAC assigned to the VF on the host and the second the multicast mac of 33:33:00:00:00:0

Re: [dpdk-dev] ***Spam*** [PATCH v11 1/7] net/sfc: fix aarch32 build

On 12/9/20 3:59 PM, Juraj Linkeš wrote: > From: Ruifeng Wang > > The sfc PMD was enabled for aarch32 which is 32-bit mode but has > cpu_family set to aarch64. > As sfc support only 64-bit system, it should be disabled for aarch32. > > Updated meson file to disable sfc for aarch32 build. > > Fix

Re: [dpdk-dev] [PATCH v3 8/9] net/ionic: minor refactorings and helper variables

On 12/4/2020 8:16 PM, Andrew Boyer wrote: This makes the code clearer and conserves resources. Signed-off-by: Andrew Boyer --- drivers/net/ionic/ionic_ethdev.c | 5 ++--- drivers/net/ionic/ionic_lif.c| 15 ++- drivers/net/ionic/ionic_main.c | 18 +++--- 3 fil

[dpdk-dev] [PATCH v11 7/7] doc: add aarch32 build guidance

From: Phil Yang Add cross-compiling guidance for 32-bit aarch32 DPDK on aarch64 host. Signed-off-by: Phil Yang Acked-by: Ruifeng Wang --- .../linux_gsg/cross_build_dpdk_for_arm64.rst | 34 +-- 1 file changed, 24 insertions(+), 10 deletions(-) diff --git a/doc/guides/linux_gs

[dpdk-dev] [PATCH v11 6/7] ci: add aarch64 -> aarch32 cross compiling jobs

Add two jobs (static and shared libs), both building on aarch64 and producing 32-bit arm binaries executable on armv8-a, but not armv7. Do not run tests in these jobs. Signed-off-by: Juraj Linkeš Reviewed-by: Ruifeng Wang --- .ci/linux-build.sh | 7 ++- .travis.yml| 19

[dpdk-dev] [PATCH v11 4/7] build: add aarch32 meson build flags

Add aarch32 extra build flags and aarch32 machine flags to generic machine args. Also modify how arm flags are updated in meson build - for 32-bit build, update only if cross-compiling. Signed-off-by: Juraj Linkeš Acked-by: Ruifeng Wang --- config/arm/meson.build | 22 +++--- 1

[dpdk-dev] [PATCH v11 2/7] net/bnxt: fix aarch32 build

From: Ruifeng Wang NEON vector path of the PMD needs aarch64 support. But it was enabled for aarch32 build as well because aarch32 build had cpu_family set to aarch64. So build for aarch32 will fail due to unsupported intrinsics. Fixed aarch32 build by updating meson file to execule NEON vector

  1   2   >