> Subject: [PATCH v2] eal/windows: fix link error with MinGW
>
> Linking with the 'pci' driver when building with MinGW on Windows fails with
> undefined symbol 'GUID_DEVCLASS_NET'.
> This occurs because devguid.h is included in rte_windows.h before INITGUID
> is defined.
>
> Move the include of
Linking with the 'pci' driver when building with MinGW on
Windows fails with undefined symbol 'GUID_DEVCLASS_NET'.
This occurs because devguid.h is included in rte_windows.h
before INITGUID is defined.
Move the include of devguid.h after the definition of INITGUID.
Fixes: b762221ac24f ("bus/pci:
On Fri, 20 Nov 2020 21:12:55 +, Nick Connolly wrote:
> Linking with the 'pci' driver when building with MinGW on
> Windows fails with undefined symbol 'GUID_DEVCLASS_NET'.
> This occurs because devguid.h is included in rte_windows.h
> before INITGUID is defined.
>
> Resolved by moving the incl
Hi Dmitry,
On 21/11/2020 20:47, Dmitry Kozlyuk wrote:
I disagree. Just because we have rte_windows.h to properly plug Windows SDK
in, other DPDK code doesn't need to care about these details. Unused GUIDs do
take some space in static libraries, but IMO it's a fair trade for ease of
development.
Hi Nick,
Thanks for detailed explanation. It can be reproduced even without DPDK:
#include
#include
int
main(int argc, char **argv) {
return (int)&GUID_DEVCLASS_NET;
}
This links with clang, but not with MinGW-w64. AFAIK, it should not link,
because INITGUID is not defined. @DmitryM, @Nat
20/11/2020 13:30, Jerin Jacob Kollanukkaran:
> http://dpdk.org/git/next/dpdk-next-eventdev
Pulled, thanks
> > Fix assertion check warnings.
> >
> > Fixes: 8bb81f2649b1 ("net/mlx5: use thread specific flow workspace")
> >
> > Cc: sta...@dpdk.org
> > Signed-off-by: Xueming Li
> > Reviewed-by: Slava Ovsiienko
>
> Patch applied to next-net-mlx,
I know this patch is minor, but we should not write, rev
7 matches
Mail list logo
