Hi Aidan,
Some general comments first as I see that this is a first DPDK contribution.
I suggest to add cover-later to provide more context for the serie
and incremental changes between patch versions (see
https://doc.dpdk.org/guides/contributing/patches.html).
When do you plan on of providing a
13/11/2020 20:18, Radha Mohan:
> On Tue, Nov 10, 2020 at 11:57 PM Mahipal Challa wrote:
> From: Radha Mohan
> Sent: Tuesday, November 10, 2020 11:44 PM
> > On Mon, Nov 9, 2020 at 4:20 PM Radha Mohan Chintakuntla
> > wrote:
> > >
> > > Replace the maintainers for OcteonTx2 DMA and EP drivers.
>
11/11/2020 08:36, Michael Baum:
> The RSS flow expansion get a memory buffer to fill the new patterns of
> the expanded flows.
> This memory management saves the next address to write into the buffer
> in a dedicated variable.
>
> The calculation for the next address was wrongly also done when all
On Fri, Nov 13, 2020 at 02:02:38PM +, Ferruh Yigit wrote:
> On 11/13/2020 1:13 PM, Olivier Matz wrote:
> > On Fri, Nov 13, 2020 at 11:39:57AM +0100, Olivier Matz wrote:
> > > In pcap pmd, the timestamp mbuf dynamic field is mandatory. When the
> > > pcap pmd is created in a secondary process (t
Simplify some doorbell functions now that rte_cio_wmb() has been
eliminated and rte_io_wmb() is equivalent for Arm.
Fix a performance degradation on x86 platforms caused by a
previous Arm performance fix by moving the compiler barrier
closer to the I/O write.
Fixes: f0f5d844d138 ("eal: remove dep
> > If xmedata mode 1 enabled and create a flow with RSS and mark action, there
> > was an error that rdma-core failed to create RQT due to wrong queue
> > definition. This was due to mixed flow creation in thread specific flow
> > workspace.
> >
> > This patch introduces nested flow workspace(con
On Tue, Nov 10, 2020 at 11:57 PM Mahipal Challa wrote:
>
>
>
> -Original Message-
> From: Radha Mohan
> Sent: Tuesday, November 10, 2020 11:44 PM
> To: Radha Chintakuntla ; Satha Koteswara Rao Kottidi
> ; Mahipal Challa
> Cc: dev@dpdk.org; Thomas Monjalon ; Veerasenareddy Burru
> ; Sat
> > mlx_steering_dump_parser.py tool failed to dump flow due to socket file name
> > changed.
> >
> > Change socket file name back to make it consistent.
> >
> > Fixes: b1e15224849b ("common/mlx5: fix PCI driver name")
> > Cc: bi...@nvidia.com
> > Cc: sta...@dpdk.org
> >
> > Signed-off-by: Xuemi
12/11/2020 09:51, Suanming Mou:
> Currently, the counter offset support is discovered by creating the
> rule with invalid offset counter and jump action in root table. If
> the rule creation fails with EINVAL errno, that mean counter offset
> is not supported in root table.
>
> However, jump actio
13/11/2020 08:05, Bing Zhao:
> In the implementation of mlx5_hairpin_unbind, a copy-paste error was
> inside. If a single peer Rx port needed to be unbound, it would be
> bound again by mistake.
>
> All the hardware resources were released when stopping the device and
> no mess of the configuratio
10/11/2020 12:59, Xiaoyu Min:
> From: Xiaoyu Min
>
> Currently PMD only accept flow which item_mpls directly follow item_gre,
> means to match the GRE header without GRE optional field key in MPLSoGRE
> encapsulation.
>
> However, for the MPLSoGRE, the GRE header could have the optional field
>
13/11/2020 15:52, Gregory Etelson:
> post merge fixes that restore tunnel offload functionality in mlx5.
>
> v2: resolve compilation error in ubuntu inbox.
Please use --in-reply-to to keep all versions threaded.
13/11/2020 15:52, Gregory Etelson:
> The original patch allocated tunnel offload objects with invalid
> indexes. As the result, PMD tunnel object allocation failed.
>
> In this patch indexed pool provides both an index and memory for a new
> tunnel offload object.
> Also tunnel offload ipool moved
On 11/4/2020 6:04 AM, Bill Zhou wrote:
From: Bill Zhou
In the bonding configurations the port switch id for representors
was composed of pf index in bonding as the 1 msb and the representor's
index as the remaining 15 lsbs. The special corner case for the host
PF representor on BF setups with r
11/11/2020 10:28, Bing Zhao:
> Based on the specification, eCPRI can only follow ETH (VLAN) layer
> or UDP layer. When creating a flow with eCPRI item, this should be
> checked and invalid layout of the layers should be rejected.
>
> Fixes: c7eca23657b7 ("net/mlx5: add flow validation of eCPRI hea
> > The number of descriptors configured is returned to a user via the
> > rxq_info_get
> > API. This number is incorrect for MPRQ.
> > For SPRQ this number matches the number of mbufs allocated.
> > For MPRQ we have fewer external MPRQ buffers that can hold multiple
> > packets in strides of this
> > There is a performance penalty for the replenish scheme used in vectorized
> > Rx
> > burst for both MPRQ and SPRQ.
> > Mbuf elements are being filled at the end of the mbufs array and being
> > replenished at the beginning. That leads to an increase in cache misses and
> > the
> > performanc
On 10/14/2020 1:15 PM, Li,Rongqing wrote:
-Original Message-
From: Loftus, Ciara [mailto:ciara.lof...@intel.com]
Sent: Friday, October 02, 2020 12:24 AM
To: Li,Rongqing
Cc: dev@dpdk.org
Subject: RE: [PATCH][v2] net/af_xdp: avoid to unnecessary allocation and free
mbuf in rx path
wh
On 11/13/2020 4:04 PM, Lance Richardson wrote:
Simplify some doorbell functions now that rte_cio_wmb() has been
eliminated and rte_io_wmb() is equivalent for Arm.
Fix a performance degradation on x86 platforms caused by a
previous Arm performance fix by moving the compiler barrier
closer to the
On 11/13/2020 2:02 PM, Ferruh Yigit wrote:
On 11/13/2020 1:13 PM, Olivier Matz wrote:
On Fri, Nov 13, 2020 at 11:39:57AM +0100, Olivier Matz wrote:
In pcap pmd, the timestamp mbuf dynamic field is mandatory. When the
pcap pmd is created in a secondary process (this is the case for pdump),
it ca
Hi Ferruh,
Thanks for your comments.
> -Original Message-
> From: Ferruh Yigit
> Sent: Friday, November 13, 2020 12:45 AM
> To: Jiawei(Jonny) Wang ; wenzhuo...@intel.com;
> beilei.x...@intel.com; bernard.iremon...@intel.com; Ori Kam
> ; NBU-Contact-Thomas Monjalon
> ; Raslan Darawsheh
DPDK has been using meson 0.47 for some time now, so we can safely
remove the note calling out this fact.
Signed-off-by: Bruce Richardson
---
doc/guides/rel_notes/deprecation.rst | 6 --
1 file changed, 6 deletions(-)
diff --git a/doc/guides/rel_notes/deprecation.rst
b/doc/guides/rel_notes
On Fri, Nov 13, 2020 at 04:41:52PM +0100, David Marchand wrote:
> On Fri, Nov 13, 2020 at 3:15 PM David Marchand
> wrote:
> >
> > On Fri, Nov 13, 2020 at 2:53 PM Bruce Richardson
> > wrote:
> > > > +NEED_CRYPTO_SCHEDULER = $(shell echo RTE_CRYPTO_SCHEDULER | $(CPP)
> > > > $(CFLAGS) -P - | tail
On 11/13/2020 2:53 PM, Andrew Rybchenko wrote:
On 11/13/20 2:44 PM, Ferruh Yigit wrote:
In 'rte_eth_dev_configure()', if 'DEV_RX_OFFLOAD_JUMBO_FRAME' is not set
the max frame size is limited to 'RTE_ETHER_MAX_LEN' (1518).
This is mistake because for the PMDs that has frame size bigger than
"RTE_
On Fri, Nov 13, 2020 at 3:15 PM David Marchand
wrote:
>
> On Fri, Nov 13, 2020 at 2:53 PM Bruce Richardson
> wrote:
> > > +NEED_CRYPTO_SCHEDULER = $(shell echo RTE_CRYPTO_SCHEDULER | $(CPP)
> > > $(CFLAGS) -P - | tail -1)
> > > +ifeq ($(NEED_CRYPTO_SCHEDULER), 1)
> >
> > Sorry for the last-minut
On Fri, Nov 13, 2020 at 4:16 PM Gregory Etelson wrote:
> The patch notifies about invalid pkg-config. Application that uses such
> pkg-config will receive wrong linker parameters. These parameters will not
> fail link procedure, but may produce invalid output and as the result,
> application will
The kernel can use two approaches to distinguish the E-Switch
source vport in the packet metadata - either with dedicated
source_port field or register C0. To eliminate the extra source
vport matching in the hardware the source_port field can be
set to specific values (0x) for the wire source p
Hi, Elena
We have the similar issue: https://bugs.dpdk.org/show_bug.cgi?id=563
I'll reply with results there.
With best regards, Slava
> -Original Message-
> From: dev On Behalf Of Carasec Elena
> Sent: Friday, October 2, 2020 13:53
> To: dev@dpdk.org
> Subject: [dpdk-dev] mlx5: match b
> -Original Message-
> From: David Marchand
> Sent: Friday, November 13, 2020 1:04 PM
> To: Dumitrescu, Cristian
> Cc: dev
> Subject: Re: [PATCH V2] doc: add the SWX pipeline type to the prog_guide
>
> On Tue, Nov 10, 2020 at 9:03 PM Cristian Dumitrescu
> wrote:
> >
> > Add the new S
Hello David
> -Original Message-
> > DPDK relies on pkg-config(1) to provide correct parameters for
> > compiler and linker used in application build.
> > Inaccurate build parameters, produced by pkg-config from DPDK .pc
> > files could fail application build or cause unpredicted results d
13/11/2020 10:50, luca.bocca...@gmail.com:
> From: Luca Boccassi
>
> MSBuild XML files have to use CRLF line-endings, otherwise any change
> results in the whole file being rewritten with CRLF line-endings by
> Visual Studio. However, it's inconvenient to have such files checked-out
> with CLRF i
On Fri, Nov 13, 2020 at 03:52:12PM +0100, Maxime Coquelin wrote:
> With Make build system, RTE_PMD_PACKET_PREFETCH was enabled
> by default. It got lost when transitioning to Meson build
> system.
>
> In order to avoid performance changes, this patch enables
> packet prefetching in rte_config.h.
>
> -Original Message-
> From: Xueming Li
> Sent: Tuesday, November 3, 2020 10:29
> To: Matan Azrad ; Slava Ovsiienko
>
> Cc: dev@dpdk.org; Xueming(Steven) Li ; Asaf Penso
> ; Bing Zhao ; sta...@dpdk.org
> Subject: [PATCH] net/mlx5: fix unix socket server file name
>
> mlx_steering_dump_pa
On 11/13/20 2:44 PM, Ferruh Yigit wrote:
> In 'rte_eth_dev_configure()', if 'DEV_RX_OFFLOAD_JUMBO_FRAME' is not set
> the max frame size is limited to 'RTE_ETHER_MAX_LEN' (1518).
> This is mistake because for the PMDs that has frame size bigger than
> "RTE_ETHER_HDR_LEN + RTE_ETHER_CRC_LEN" (18 byt
ipools used for tunnel offload are restricted to dv enabled code only
since 1d1248d452ff, while the rest of the tunnel offload API did not
have compilation limitations. As the results, PMD compilation failed
on non-dv setups.
Current patch groups tunnel offload code in dv enabled code area and
pro
Fix mlx5_flow_tunnel_action_release and mlx5_flow_tunnel_item_release
callback names to match tunnel offload names pattern.
Fixes: 4ec6360de37d ("net/mlx5: implement tunnel offload")
Signed-off-by: Gregory Etelson
Acked-by: Viacheslav Ovsiienko
---
drivers/net/mlx5/mlx5_flow.c | 17 +--
The new flow table resource management API triggered a PMD crash in
tunnel offload mode, when tunnel match flow rule was inserted before
tunnel set rule.
Reason for the crash was double flow table registration. The table was
registered by the tunnel offload code for the first time and once
more by
The original patch allocated tunnel offload objects with invalid
indexes. As the result, PMD tunnel object allocation failed.
In this patch indexed pool provides both an index and memory for a new
tunnel offload object.
Also tunnel offload ipool moved to dv enabled code only.
Fixes: f2e8093 ("net
The original patch was removing active tunnel offload objects from a
tunnels db list without checking its reference counter value.
That action was leading to a PMD crash.
Current patch isolates tunnels db list into a separate API. That API
manages MT protection of the tunnel offload db.
Fixes: e4
post merge fixes that restore tunnel offload functionality in mlx5.
v2: resolve compilation error in ubuntu inbox.
Gregory Etelson (5):
net/mlx5: fix tunnel offload object allocation
net/mlx5: fix tunnel offload hub multi-thread protection
net/mlx5: fix double table referencing
net/mlx5:
With Make build system, RTE_PMD_PACKET_PREFETCH was enabled
by default. It got lost when transitioning to Meson build
system.
In order to avoid performance changes, this patch enables
packet prefetching in rte_config.h.
Reported-by: Marvin Liu
Suggested-by: David Marchand
Signed-off-by: Maxime
On 11/13/2020 2:03 PM, Michael Pfeiffer wrote:
Unlike TCP, UDP checksums are optional and may be zero to indicate "not
set" [RFC 768] (except for IPv6, where this prohibited [RFC 8200]). Add
this special case to the checksum offload emulation in net/tap.
Signed-off-by: Michael Pfeiffer
Review
On 11/13/2020 8:42 AM, Andrew Rybchenko wrote:
Fixes: eda1cc20c3bc ("common/sfc_efx/base: add 256-bit type")
Signed-off-by: Andrew Rybchenko
Reviewed-by: Andy Moreton
Applied to dpdk-next-net/main, thanks.
06/11/2020 13:40, Ciara Power:
> The pycodestyle tool flagged the following issues, which are now fixed.
>
> $ pycodestyle cpu_layout.py
> cpu_layout.py:18:5: E722 do not use bare 'except'
> cpu_layout.py:62:14: E231 missing whitespace after ','
>
> Fixes: deb87e6777c0 ("usertools: use sysfs
> -Original Message-
> From: Juraj Linkeš
> Sent: Friday, November 13, 2020 10:31 PM
> To: bruce.richard...@intel.com; Ruifeng Wang ;
> Honnappa Nagarahalli ; Phil Yang
> ; vcchu...@amazon.com; Dharmik Thakkar
> ; jerinjac...@gmail.com;
> hemant.agra...@nxp.com; Ajit Khaparde (ajit.khapa..
13/11/2020 15:22, Juraj Linkeš:
> From: Thomas Monjalon
> > 13/11/2020 15:03, Juraj Linkeš:
> > > From: Thomas Monjalon
> > > > 11/11/2020 14:18, Juraj Linkeš:
> > > > > Use generic configuration for the only build where it makes sense
> > > > > - the generic build. For other builds, if we don't
05/11/2020 11:41, Bruce Richardson:
> Coverity flags a possible problem where the 8-bit wq_idx value may have
> errors when shifted and sign-extended to pointer size. Since this can
> only occur if the shift index is larger than any expected value from
> hardware, it's unlikely to cause any real pr
Fix the implementer and part number of DPAA and ARMADA SoCs.
The current values of 16 cores and 1 NUMA node don't cover all SoCs from
the Arm implementer, e.g. Taishan 2280 has 64 cores and 4 NUMA nodes.
Increase these to 64 and 4 to widen the coverage.
Add configuration to SoC options where smalle
Add Arm SoC configuration to Arm meson.build and add a meson option to
enable those options for native builds. This is preferable to
specifying a cross file when doing aarch64 -> aarch64 builds, since the
cross file specifies the toolchain as well.
Signed-off-by: Juraj Linkeš
Reviewed-by: Honnapp
Some Arm SoCs are not NUMA systems. Add the capability to disable NUMA
for cross build and disable NUMA in Arm cross files.
Signed-off-by: Juraj Linkeš
Reviewed-by: Honnappa Nagarahalli
---
config/arm/arm64_armada_linux_gcc | 1 +
config/arm/arm64_bluefield_linux_gcc | 1
A few options that disabled drivers in the old makefiles were improperly
ported to the meson build system. Fix this by adding a to the list of
disabled drivers, similarly how the command line option works. Remove
unneeded driver options ported from the old makefile system.
Add support for removing
Letting the compiler decide is going to yield the best results for
native builds, so use native machine args usable for both GCC and Clang.
Signed-off-by: Juraj Linkeš
---
config/arm/meson.build | 54 ++
1 file changed, 28 insertions(+), 26 deletions(-)
d
Add support for setting core count and numa nodes in cross files. The
values specified in cross files will override the default values.
Also add missing default values to Arm config.
Signed-off-by: Juraj Linkeš
Reviewed-by: Honnappa Nagarahalli
---
config/arm/arm64_armada_linux_gcc
Add an option to automatically discover the host's numa and cpu counts
and use those values for a non cross-build.
Give users the option to override the per-arch default values or values
from cross files by specifying them on the command line with -Dmax_lcores
and -Dmax_numa_nodes.
Signed-off-by:
Use dictionary lookup instead of checking for existing variables,
iterating over all elements in the list or checking lists for optional
configuration. Move variable contents into the dictionary for variables
that would be referenced only once.
Fallback to generic part number if the discovered part
Use generic configuration for the only build where it makes sense - the
generic build. For other builds, if we don't know either of implementer
ID or part number, the build is not supported.
Add part numbers to cross files where fallback to generic configuration
is assumed.
Signed-off-by: Juraj Li
Change formatting so that it's more consistent and readable, add/modify
comments/stdout messages, move configuration options to more appropriate
places and make the order consistent according to these rules:
1. First list generic configuration options, then list options that may
be overwritten.
Rename Arm build variables and values so that they better conform to Arm
specifications. Also rename generically sounding variable to names that
better capture what the variables hold.
Rename machine_args_generic to part_number_config_arm since the
variable contains more than just the generic mach
Set flags in one loop. Append flags to a list and use the list in the
loop.
Signed-off-by: Juraj Linkeš
Reviewed-by: Honnappa Nagarahalli
---
config/arm/meson.build | 37 +
1 file changed, 17 insertions(+), 20 deletions(-)
diff --git a/config/arm/meson.build
Remove variables that were either not used, referenced just once or not
needed.
Signed-off-by: Juraj Linkeš
Reviewed-by: Ruifeng Wang
Reviewed-by: Honnappa Nagarahalli
---
config/arm/meson.build | 28 +++-
1 file changed, 7 insertions(+), 21 deletions(-)
diff --git a/c
The current machine='default' build name is not descriptive. The actual
default build is machine='native'. Add an alternative string which does
the same build and better describes what we're building:
machine='generic'. Leave machine='default' for backwards compatibility.
Signed-off-by: Juraj Link
The current way of specifying Arm configuration options is insufficient
since we can't identify the SoC we're building for from the MIDR
information. For example, we can't distinguish between N1SDP, Graviton2
or Ampere Altra.
Add a way to specify the cpu count and numa node count for cross builds
05/11/2020 14:58, Olivier Matz:
> On Thu, Nov 05, 2020 at 01:51:14PM +, David Hunt wrote:
> > Coverity flags that rte_mempool_ops_dequeue_bulk() is called without
> > checking the return value.
> >
> > This ignoring is intentional, so this patch gets the return code, then
> > uses RTE_SET_USED
On Fri, Nov 13, 2020 at 03:14:14PM +0100, David Marchand wrote:
> On Fri, Nov 13, 2020 at 3:06 PM Bruce Richardson
> wrote:
> >
> > On Fri, Nov 13, 2020 at 01:24:30PM +0100, David Marchand wrote:
> > > Rather than just installing all examples, we can use the build checks to
> > > filter out any ex
> -Original Message-
> From: Thomas Monjalon
> Sent: Friday, November 13, 2020 3:18 PM
> To: Juraj Linkeš
> Cc: bruce.richard...@intel.com; ruifeng.w...@arm.com;
> honnappa.nagaraha...@arm.com; phil.y...@arm.com;
> vcchu...@amazon.com; dharmik.thak...@arm.com; jerinjac...@gmail.com;
> h
13/11/2020 15:03, Juraj Linkeš:
> From: Thomas Monjalon
> > 11/11/2020 14:18, Juraj Linkeš:
> > > Use generic configuration for the only build where it makes sense -
> > > the generic build. For other builds, if we don't know either of
> > > implementer ID or part number, the build is not supporte
> > Meson versions >= 0.54.0 include support for handling /implib
> > with msvc link. Specifying it explicitly causes failures when
> > linking against the dll. Tested using Link 14.27.29112.0 and
> > Clang 11.0.0.
> >
> > There were a number of changes to the way that import libraries
> > are han
On Fri, Nov 13, 2020 at 2:53 PM Bruce Richardson
wrote:
> > +NEED_CRYPTO_SCHEDULER = $(shell echo RTE_CRYPTO_SCHEDULER | $(CPP)
> > $(CFLAGS) -P - | tail -1)
> > +ifeq ($(NEED_CRYPTO_SCHEDULER), 1)
>
> Sorry for the last-minute comment, but I wonder for this check if we can do
> better by adding
On Fri, Nov 13, 2020 at 3:06 PM Bruce Richardson
wrote:
>
> On Fri, Nov 13, 2020 at 01:24:30PM +0100, David Marchand wrote:
> > Rather than just installing all examples, we can use the build checks to
> > filter out any examples that are missing dependencies or are otherwise
> > unbuildable on the
On Fri, Nov 13, 2020 at 01:24:30PM +0100, David Marchand wrote:
> Rather than just installing all examples, we can use the build checks to
> filter out any examples that are missing dependencies or are otherwise
> unbuildable on the current system.
> Introduce a new "buildable" special value for th
Hi, Maxime
> -Original Message-
> From: Maxime Leroy
> Sent: Thursday, November 12, 2020 17:39
> To: Matan Azrad ; Shahaf Shuler ;
> Slava Ovsiienko ; Olivier Matz
>
> Cc: dev@dpdk.org; Didier Pallard
> Subject: [PATCH v2 2/2] net/mlx5: fix Rx descriptor status returned value
>
> From:
> -Original Message-
> From: Thomas Monjalon
> Sent: Friday, November 13, 2020 2:11 PM
> To: Juraj Linkeš
> Cc: bruce.richard...@intel.com; ruifeng.w...@arm.com;
> honnappa.nagaraha...@arm.com; phil.y...@arm.com;
> vcchu...@amazon.com; dharmik.thak...@arm.com; jerinjac...@gmail.com;
> he
12/11/2020 22:35, Tal Shnaiderman:
> > Subject: Re: [dpdk-dev] [PATCH v2] windows: minor build fixes
> >
> > Missing / incorrect '--in-reply-to'. Please ignore - still learning the
> > process!
> >
> > On 31/10/2020 06:43, Nick Connolly wrote:
> > > Meson versions >= 0.54.0 include support for h
Unlike TCP, UDP checksums are optional and may be zero to indicate "not
set" [RFC 768] (except for IPv6, where this prohibited [RFC 8200]). Add
this special case to the checksum offload emulation in net/tap.
Signed-off-by: Michael Pfeiffer
---
v2:
* Added comment.
drivers/net/tap/rte_eth_tap.c
On 11/13/2020 1:13 PM, Olivier Matz wrote:
On Fri, Nov 13, 2020 at 11:39:57AM +0100, Olivier Matz wrote:
In pcap pmd, the timestamp mbuf dynamic field is mandatory. When the
pcap pmd is created in a secondary process (this is the case for pdump),
it cannot be registered because this is not allow
On Thu, Nov 5, 2020 at 10:39 AM Dharmappa, Savinay
wrote:
> Hi Thomas,
> >> I see that this patch is not applied on rc2. When can this will be applied
> >> ? will it be part of rc3 ?. Please let me know
Please, pay attention when editing replies, this mail of yours added
Cristian token again in
> -Original Message-
> From: Ruifeng Wang
> Sent: Friday, November 13, 2020 2:52 PM
> To: Juraj Linkeš ; bruce.richard...@intel.com;
> Honnappa Nagarahalli ; Phil Yang
> ; vcchu...@amazon.com; Dharmik Thakkar
> ; jerinjac...@gmail.com;
> hemant.agra...@nxp.com; Ajit Khaparde (ajit.khapa.
Thanks for your reply Thomas, that's no problem.
I will expand the explanation for this patch when I push a v2,
v2 will hopefully also address the issues it caused with the icc build.
/Conor
> -Original Message-
> From: Thomas Monjalon
> Sent: Thursday 12 November 2020 18:47
> To: Walsh,
On Fri, Nov 13, 2020 at 01:24:23PM +0100, David Marchand wrote:
> Two issues fixed here.
>
> First add the experimental flag.
> Then fix a link issue with the crypto scheduler driver:
> /usr/bin/ld: /tmp/cchr7aHA.o: in function `main':
> main.c:(.text.startup+0x1673): undefined reference to
> `rte
> -Original Message-
> From: Juraj Linkeš
> Sent: Friday, November 13, 2020 7:38 PM
> To: bruce.richard...@intel.com; Ruifeng Wang ;
> Honnappa Nagarahalli ; Phil Yang
> ; vcchu...@amazon.com; Dharmik Thakkar
> ; jerinjac...@gmail.com;
> hemant.agra...@nxp.com; Ajit Khaparde (ajit.khapa...
31/10/2020 07:56, Nick Connolly:
> Don't run symlink-drivers-solibs.sh as part of 'install' because
> Windows doesn't support shell scripts.
>
> Signed-off-by: Nick Connolly
> Tested-by: Ranjit Menon
> Acked-by: Ranjit Menon
Applied with title "build: fix install on Windows", thanks.
On Thu, Nov 5, 2020 at 1:37 PM Gregory Etelson wrote:
>
> DPDK relies on pkg-config(1) to provide correct parameters for
> compiler and linker used in application build.
> Inaccurate build parameters, produced by pkg-config from DPDK .pc
> files could fail application build or cause unpredicted re
On Thu, Nov 5, 2020 at 9:57 AM David Marchand wrote:
>
> On Mon, Nov 2, 2020 at 12:59 PM Ibtisam Tariq
> wrote:
> >
> > The short option written for interactive mode is --i in usage of
> > this qos_sched example. Actually, it is -i.
> >
> > Fixes: cfd5c971e5e ("examples/qos_sched: add stats")
Cc
...
> diff --git a/lib/librte_gso/rte_gso.c b/lib/librte_gso/rte_gso.c
> index 896350e..fb76a21 100644
> --- a/lib/librte_gso/rte_gso.c
> +++ b/lib/librte_gso/rte_gso.c
> @@ -11,6 +11,7 @@
> #include "gso_common.h"
> #include "gso_tcp4.h"
> #include "gso_tunnel_tcp4.h"
> +#include "gso_tunnel_ud
On Fri, Nov 13, 2020 at 11:39:57AM +0100, Olivier Matz wrote:
> In pcap pmd, the timestamp mbuf dynamic field is mandatory. When the
> pcap pmd is created in a secondary process (this is the case for pdump),
> it cannot be registered because this is not allowed from a secondary
> process.
>
> To e
11/11/2020 14:18, Juraj Linkeš:
> Use generic configuration for the only build where it makes sense - the
> generic build. For other builds, if we don't know either of implementer
> ID or part number, the build is not supported.
> Add part numbers to cross files where fallback to generic configurat
On Tue, Nov 10, 2020 at 9:03 PM Cristian Dumitrescu
wrote:
>
> Add the new SWX pipeline type to the Programmer's Guide.
Thanks for this high level description.
Could you work on documenting how to start and use the new pipeline example too?
>
> V2 changes: fixed 2 typos.
Patch changelog should
On Thu, Nov 5, 2020 at 4:27 PM Cristian Dumitrescu
wrote:
>
> Fix for the exact match lookup function.
>
> Fixes: d0a00966618b ("table: add exact match SWX table")
>
> Signed-off-by: Cristian Dumitrescu
> Signed-off-by: Churchill Khangar
Applied, thanks.
--
David Marchand
On 11/11/2020 9:31 AM, Ferruh Yigit wrote:
On 11/11/2020 7:23 AM, Michael Pfeiffer wrote:
Hi,
On Tue, 2020-11-10 at 15:59 +, Ferruh Yigit wrote:
On 11/9/2020 2:22 PM, Michael Pfeiffer wrote:
Unlike TCP, UDP checksums are optional and may be zero to indicate "not
set" [RFC 768] (except for
On 11/13/20 1:24 PM, David Marchand wrote:
> vhost_blk.c: In function ‘ctrlr_worker’:
> vhost_blk.c:543:2: warning: implicit declaration of function ‘CPU_ZERO’
> [-Wimplicit-function-declaration]
> 543 | CPU_ZERO(&cpuset);
> | ^~~~
> vhost_blk.c:544:2: warning: implicit declaration
On 11/12/2020 4:35 PM, Ciara Loftus wrote:
'uint64_t' is used to hold pointers in multiple locations in the
copy-mode code (used for kernels before 5.4). For a 32-bit build
this assumption is wrong and results in build errors. This commit
replaces such instances of 'uint64_t' with 'uintptr_t'.
W
Thomas,
On Fri, Nov 13, 2020 at 1:28 PM David Marchand
wrote:
> - a fix for the vhost is waiting in next-virtio, I assume it will get
> pulled before this series,
If next-virtio is not pulled yet, we can add a temp:
dpdk_examples_exclude += ['vhost']
--
David Marchand
Hi,
>
> Instead of using getopt_long return value, strcmp was used to
> compare the input parameters with the struct option array. This
> patch get rid of all those strcmp by directly binding each longopt
> with an int enum. This is to improve readability and consistency in
> all examples.
>
>
Rather than just installing all examples, we can use the build checks to
filter out any examples that are missing dependencies or are otherwise
unbuildable on the current system.
Introduce a new "buildable" special value for the -Dexamples= meson
option, this way existing behavior on installing all
Before make removal, those examples were built with experimental flag
for tracepoints to be compiled in but the pkg-config part of those
makefiles were missed.
Fixes: 78d44153de8f ("ethdev: add tracepoints")
Signed-off-by: David Marchand
Acked-by: Bruce Richardson
---
examples/cmdline/Makefile
vhost_blk.c: In function ‘ctrlr_worker’:
vhost_blk.c:543:2: warning: implicit declaration of function ‘CPU_ZERO’
[-Wimplicit-function-declaration]
543 | CPU_ZERO(&cpuset);
| ^~~~
vhost_blk.c:544:2: warning: implicit declaration of function ‘CPU_SET’
[-Wimplicit-function-declaration]
This example is missing the experimental flag since it uses an
experimental API.
Fixes: cd1dadeb9b2a ("examples/rxtx_callbacks: support HW timestamp")
Cc: sta...@dpdk.org
Signed-off-by: David Marchand
Acked-by: Bruce Richardson
---
examples/rxtx_callbacks/Makefile | 2 ++
1 file changed, 2 ins
main.c: In function ‘lthread_tx’:
main.c:2091:25: error: implicit declaration of function ‘sched_getcpu’;
did you mean ‘sched_getparam’? [-Werror=implicit-function-declaration]
2091 | tx_conf->conf.cpu_id = sched_getcpu();
| ^~~~
|
This example missed the rework from commit 8549295db07b
("build/pkg-config: improve static linking flags").
Fixes: 08bd1a174461 ("examples/l3fwd-graph: add graph-based l3fwd skeleton")
Signed-off-by: David Marchand
Acked-by: Bruce Richardson
---
examples/l3fwd-graph/Makefile | 2 +-
1 file cha
When introducing this example, the cleanup from commit 7e9562a107f1
("examples: fix make clean when using pkg-config") was missed.
Fixes: c5eebf85badc ("examples/ntb: add example for NTB")
Cc: sta...@dpdk.org
Signed-off-by: David Marchand
Acked-by: Bruce Richardson
Acked-by: Xiaoyun Li
---
ex
1 - 100 of 159 matches
Mail list logo
