Re: [dpdk-dev] [PATCH v3 16/16] ethdev: include mbuf registration in Tx timestamp API

2020-11-02 Thread Slava Ovsiienko
> -Original Message- > From: Thomas Monjalon > Sent: Tuesday, November 3, 2020 2:14 > To: dev@dpdk.org > Cc: ferruh.yi...@intel.com; david.march...@redhat.com; > bruce.richard...@intel.com; olivier.m...@6wind.com; > andrew.rybche...@oktetlabs.ru; jer...@marvell.com; Slava Ovsiienko > ; Wen

Re: [dpdk-dev] [v6 1/2] cryptodev: support enqueue & dequeue callback functions

2020-11-02 Thread Gujjar, Abhinandan S
Hi Akhil, > -Original Message- > From: Akhil Goyal > Sent: Tuesday, November 3, 2020 11:58 AM > To: Gujjar, Abhinandan S ; dev@dpdk.org; > Doherty, Declan ; > honnappa.nagaraha...@arm.com; Ananyev, Konstantin > ; Hemant Agrawal > > Cc: Vangati, Narender ; jer...@marvell.com > Subject: RE

[dpdk-dev] [PATCH v2] net/iavf: fix PROT filed for rss hash

2020-11-02 Thread Jeff Guo
Add PROT field into IPv4 and IPv6 protocol headers for rss hash. Fixes: 91f27b2e39ab ("net/iavf: refactor RSS") Signed-off-by: Jeff Guo --- v2: add prot into the new hdr replace of function modify --- drivers/net/iavf/iavf_hash.c | 32 1 file changed, 24 insertio

Re: [dpdk-dev] [kmods PATCH] windows: normalize line-endings

2020-11-02 Thread Dmitry Kozlyuk
Hi Naty, > Doesn't the 'input' option gets you original (unmodified) line endings on > checkout? > If a file in the repo has CRLF endings, Unix devs will get it as-is (with > CRLF), right? The "input" option is for Unix devs only. > Regardless, this is the best option for Unix and since we're

Re: [dpdk-dev] [PATCH] app/testpmd: support age shared action context

2020-11-02 Thread Matan Azrad
Hi Ferruh Thank you for the fast review. Please see inline From: Ferruh Yigit > On 11/1/2020 5:48 PM, Matan Azrad wrote: > > When an age action becomes aged-out the rte_flow_get_aged_flows should > > return the action context supplied by the configuration structure. > > > > In case the age action

Re: [dpdk-dev] mbuf->packet_type

2020-11-02 Thread Levend Sayar
Hi all. Nobody cared about my mail. Am I in the wrong place? If so, can you forward me to the right place please? Best, Levend On Mon, Nov 2, 2020 at 1:45 PM Levend Sayar wrote: > Hi all. > > Recently I encountered a dont-know-why issue about mbuf->packet_type. > > Two different setups behave

Re: [dpdk-dev] [PATCH] net/mlx5: fix atomic API update

2020-11-02 Thread Slava Ovsiienko
> -Original Message- > From: Matan Azrad > Sent: Tuesday, November 3, 2020 8:48 > To: Slava Ovsiienko > Cc: dev@dpdk.org > Subject: [PATCH] net/mlx5: fix atomic API update > > The Txq refcnt 1 value means that there is not real reference to the queue and > only the control configuratio

Re: [dpdk-dev] [PATCH] net/mlx5: fix Tx queue stop state

2020-11-02 Thread Slava Ovsiienko
> -Original Message- > From: Matan Azrad > Sent: Tuesday, November 3, 2020 8:49 > To: Slava Ovsiienko > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: [PATCH] net/mlx5: fix Tx queue stop state > > The Tx queue stop API doesn't call the PMD callback when the state of the > queue is stopped.

[dpdk-dev] [PATCH] net/mlx5: fix Tx queue stop state

2020-11-02 Thread Matan Azrad
The Tx queue stop API doesn't call the PMD callback when the state of the queue is stopped. The drivers should update the state to be stopped when the queue stop callback is done successfully or when the port is stopped. The drivers should update the state to be started when the queue start callbac

Re: [dpdk-dev] [PATCH 5/8] doc: fix driver names in NIC devices guide

2020-11-02 Thread Ajit Khaparde
On Mon, Nov 2, 2020 at 6:31 PM Xu, Rosen wrote: > > > > > Subject: [PATCH 5/8] doc: fix driver names in NIC devices guide > > > > Since the built driver filenames have changed in DPDK 20.11, we need to > > update the driver doc to match. > > > > Most drivers start their section with the driver fil

[dpdk-dev] [PATCH] net/mlx5: fix atomic API update

2020-11-02 Thread Matan Azrad
The Txq refcnt 1 value means that there is not real reference to the queue and only the control configuration are saved in the struct. The patch below wrongly didn't consider it and caused a leak in the Txq object resource. Revert the specific update in the refcnt. Fixes: a02d6dd9e61f ("net/mlx5

[dpdk-dev] [PATCH v4] net/ice: fix outher chksum on cvl unknown

2020-11-02 Thread Murphy Yang
Currently, driver does not supports parse UDP outer checksum flag of tunneled packets. When execute 'csum set outer-udp hw 0' and 'csum parse-tunnel on 0' commands to enable hardware UDP outer checksum. This patch supports parse UDP outer checksum flag of tunneled packets. Fixes: dbf3c0e77a22 ("n

[dpdk-dev] [PATCH] net/ice: fix outher chksum on cvl unknown

2020-11-02 Thread Murphy Yang
Currently, driver does not supports parse UDP outer checksum flag of tunneled packets. When execute 'csum set outer-udp hw 0' and 'csum parse-tunnel on 0' commands to enable hardware UDP outer checksum. This patch supports parse UDP outer checksum flag of tunneled packets. Fixes: dbf3c0e77a22 ("n

Re: [dpdk-dev] [RFC V2 1/2] app/testpmd: fix queue stats mapping configuration

2020-11-02 Thread Min Hu (Connor)
Hi Ferruh, I agree with your proposal. But if we remove record structures, we will not be able to query the current queue stats mapping configuration. Or we can provide a query API for the PMD driver that uses the set_queue_stats_mapping API, and driver records these mapping information from user

Re: [dpdk-dev] [v6 1/2] cryptodev: support enqueue & dequeue callback functions

2020-11-02 Thread Akhil Goyal
Hi Abhinandan, > Subject: RE: [v6 1/2] cryptodev: support enqueue & dequeue callback functions > > Hi Akhil, > > Can you please go through the patch again and check if any more comments? As I suggested 2 times that there are documentation issues. Haven't seen a version To fix that. Please check

Re: [dpdk-dev] [v6 1/2] cryptodev: support enqueue & dequeue callback functions

2020-11-02 Thread Gujjar, Abhinandan S
Hi Akhil, Can you please go through the patch again and check if any more comments? I understand that we work in same time zone, getting feedback from you in the mid night will not help me/you to pull this patch in. A quick response will enable me to prepare patch set quickly and send it across.

[dpdk-dev] [PATCH v1] vhost: fix async inflight packet counter

2020-11-02 Thread Patrick Fu
Async inflight packet counter should take failed packets into account. Failed packets will be deducted in the error handling logic. Fixes: 6b3c81db8bb7 ("vhost: simplify async copy completion") Fixes: cd6760da1076 ("vhost: introduce async enqueue for split ring") Signed-off-by: Patrick Fu --- l

[dpdk-dev] [PATCH] net/mlx5: fix eCPRI previous layer checking

2020-11-02 Thread Bing Zhao
Based on the specification, eCPRI can only follow ETH (VLAN) layer or UDP layer. When creating a flow with eCPRI item, this should be checked and invalid layout of the layers should be rejected. Fixes: c7eca23657b7 ("net/mlx5: add flow validation of eCPRI header") Cc: sta...@dpdk.org Signed-off-

[dpdk-dev] [PATCH] net/mlx5: fix the eCPRI common header endianness

2020-11-02 Thread Bing Zhao
The input header of a RTE flow item is with network byte order. In the host with little endian, the bit field order are the same as the byte order. When checking the an eCPRI message type, the wrong field will be selected. Right now, since the whole u32 is being checked and for all types, the follo

Re: [dpdk-dev] [PATCH v2 4/4] test/lpm: avoid code duplication in rcu qsbr perf

2020-11-02 Thread Honnappa Nagarahalli
> >> > >> Avoid code duplication by combining single and multi threaded tests > >> > >> Signed-off-by: Dharmik Thakkar > >> Reviewed-by: Ruifeng Wang > >> --- > >> app/test/test_lpm_perf.c | 362 > >> ++- > >> 1 file changed, 91 insertions(+), 271 deletions(-)

Re: [dpdk-dev] [PATCH v3 3/4] test/lpm: remove error checking in rcu qsbr perf

2020-11-02 Thread Honnappa Nagarahalli
> -Original Message- > From: Dharmik Thakkar > Sent: Monday, November 2, 2020 11:12 PM > To: Bruce Richardson ; Vladimir Medvedkin > ; Gavin Hu ; > Honnappa Nagarahalli ; Ruifeng Wang > > Cc: dev@dpdk.org; nd ; Dharmik Thakkar > ; sta...@dpdk.org > Subject: [PATCH v3 3/4] test/lpm: rem

Re: [dpdk-dev] [PATCH v3 2/4] test/lpm: return error on failure in rcu qsbr perf

2020-11-02 Thread Honnappa Nagarahalli
> > Return error if Add/Delete fail in multiwriter perf test > > Fixes: eff30b59cc2e ("test/lpm: add RCU performance tests") > Cc: honnappa.nagaraha...@arm.com > Cc: sta...@dpdk.org > > Signed-off-by: Dharmik Thakkar > Reviewed-by: Ruifeng Wang Looks good Reviewed-by: Honnappa Nagarahalli >

[dpdk-dev] [PATCH v3 3/4] test/lpm: remove error checking in rcu qsbr perf

2020-11-02 Thread Dharmik Thakkar
Remove redundant error checking for reader threads since they never return error. Fixes: eff30b59cc2e ("test/lpm: add RCU performance tests") Cc: honnappa.nagaraha...@arm.com Cc: sta...@dpdk.org Signed-off-by: Dharmik Thakkar Reviewed-by: Ruifeng Wang --- app/test/test_lpm_perf.c | 21

[dpdk-dev] [PATCH v3 1/4] test/lpm: fix cycle calculation in rcu qsbr perf

2020-11-02 Thread Dharmik Thakkar
Fix incorrect calculations for LPM adds, LPM deletes, and average cycles in RCU QSBR perf tests Since, rcu qsbr tests run for 'RCU_ITERATIONS' and not 'ITERATIONS', replace 'ITERATIONS' with 'RCU_ITERATIONS' for calculating adds, deletes, and cycles. Also, for multi-writer perf test, each writer

[dpdk-dev] [PATCH v3 0/4] test/lpm: fix rcu qsbr perf test

2020-11-02 Thread Dharmik Thakkar
Fix LPM adds, LPM deletes, and cycle calculation. Return error if LPM add/delete fails in multi-writer test. Remove redundant error checking for readers. Combine single and multi threaded test cases to avoid code duplication. --- v3: - Add 'goto error' - Remove unnecessary if statement v2: - Ad

[dpdk-dev] [PATCH v3 2/4] test/lpm: return error on failure in rcu qsbr perf

2020-11-02 Thread Dharmik Thakkar
Return error if Add/Delete fail in multiwriter perf test Fixes: eff30b59cc2e ("test/lpm: add RCU performance tests") Cc: honnappa.nagaraha...@arm.com Cc: sta...@dpdk.org Signed-off-by: Dharmik Thakkar Reviewed-by: Ruifeng Wang --- app/test/test_lpm_perf.c | 6 ++ 1 file changed, 6 insertio

[dpdk-dev] [PATCH v3 4/4] test/lpm: avoid code duplication in rcu qsbr perf

2020-11-02 Thread Dharmik Thakkar
Avoid code duplication by combining single and multi threaded tests Signed-off-by: Dharmik Thakkar Reviewed-by: Ruifeng Wang --- app/test/test_lpm_perf.c | 359 ++- 1 file changed, 89 insertions(+), 270 deletions(-) diff --git a/app/test/test_lpm_perf.c b/ap

Re: [dpdk-dev] [PATCH v2 3/4] test/lpm: remove error checking in rcu qsbr perf

2020-11-02 Thread Dharmik Thakkar
> On Nov 2, 2020, at 7:21 PM, Honnappa Nagarahalli > wrote: > > > >> >> Remove redundant error checking for reader threads since they never return >> error. >> >> Fixes: eff30b59cc2e ("test/lpm: add RCU performance tests") >> Cc: honnappa.nagaraha...@arm.com >> Cc: sta...@dpdk.org >> >>

Re: [dpdk-dev] [PATCH v2 2/4] test/lpm: return error on failure in rcu qsbr perf

2020-11-02 Thread Dharmik Thakkar
> On Nov 2, 2020, at 7:28 PM, Honnappa Nagarahalli > wrote: > > > >> >> Return error if Add/Delete fail in multiwriter perf test >> >> Fixes: eff30b59cc2e ("test/lpm: add RCU performance tests") >> Cc: honnappa.nagaraha...@arm.com >> Cc: sta...@dpdk.org >> >> Signed-off-by: Dharmik Thakk

Re: [dpdk-dev] [PATCH v2 4/4] test/lpm: avoid code duplication in rcu qsbr perf

2020-11-02 Thread Dharmik Thakkar
> On Nov 2, 2020, at 10:21 PM, Honnappa Nagarahalli > wrote: > > >> >> Avoid code duplication by combining single and multi threaded tests >> >> Signed-off-by: Dharmik Thakkar >> Reviewed-by: Ruifeng Wang >> --- >> app/test/test_lpm_perf.c | 362 ++- >>

Re: [dpdk-dev] [PATCH] net/bnxt: fix PAM4 link negotiation

2020-11-02 Thread Ajit Khaparde
On Sun, Nov 1, 2020 at 6:43 PM Ajit Khaparde wrote: > In some instances link was not coming up if PAM4 signaling is enabled. > Added check to disable autoneg if FW indicates auto speeds are zero. > Use default auto speeds if PAM4 auto speeds is not set. > Added a fix for forced link setting. > >

Re: [dpdk-dev] [PATCH] net/bnxt: fixes for vxlan decap full offload

2020-11-02 Thread Ajit Khaparde
On Sun, Nov 1, 2020 at 8:52 AM Venkat Duvvuru < venkatkumar.duvv...@broadcom.com> wrote: > 1. When a PMD application queries for flow counters, it could ask PMD >to reset the counters when the application is doing the counters >accumulation. In this case, PMD should not accumulate rather r

Re: [dpdk-dev] [PATCH v2 4/4] test/lpm: avoid code duplication in rcu qsbr perf

2020-11-02 Thread Honnappa Nagarahalli
> > Avoid code duplication by combining single and multi threaded tests > > Signed-off-by: Dharmik Thakkar > Reviewed-by: Ruifeng Wang > --- > app/test/test_lpm_perf.c | 362 ++- > 1 file changed, 91 insertions(+), 271 deletions(-) > > diff --git a/app/tes

Re: [dpdk-dev] [kmods PATCH] windows: normalize line-endings

2020-11-02 Thread Narcisa Ana Maria Vasile
On Fri, Oct 30, 2020 at 01:55:05AM +0300, Dmitry Kozlyuk wrote: > MSBuild XML files have to use CRLF line-endings, otherwise any change > results in the whole file being rewritten with CRLF line-endings by > Visual Studio. However, it's inconvenient to have such files checked-out > with CLRF in Uni

Re: [dpdk-dev] [PATCH 5/8] doc: fix driver names in NIC devices guide

2020-11-02 Thread Xu, Rosen
> Subject: [PATCH 5/8] doc: fix driver names in NIC devices guide > > Since the built driver filenames have changed in DPDK 20.11, we need to > update the driver doc to match. > > Most drivers start their section with the driver filename highlighted in bold, > while a number were missing the hi

[dpdk-dev] [PATCH v3] drivers/net: enable packet data prefetch on x86

2020-11-02 Thread Marvin Liu
Data prefetch instruction can preload data into cpu’s hierarchical cache before data access. Data paths like e1000 and virtio utilized this feature for packet data access acceleration. Enabled packet data prefetch on x86 architecture, as prefetch instruction has been supported from very early gener

Re: [dpdk-dev] [PATCH v3 1/2] ethdev: introduce transfer attribute to shared action conf

2020-11-02 Thread Ajit Khaparde
On Mon, Nov 2, 2020 at 5:15 AM Andrew Rybchenko < andrew.rybche...@oktetlabs.ru> wrote: > On 11/2/20 2:43 PM, Ivan Malov wrote: > > In a flow rule, attribute "transfer" means operation level > > at which both traffic is matched and actions are conducted. > > > > Add the very same attribute to shar

Re: [dpdk-dev] [PATCH v2 1/4] test/lpm: fix cycle calculation in rcu qsbr perf

2020-11-02 Thread Honnappa Nagarahalli
> > Fix incorrect calculations for LPM adds, LPM deletes, and average cycles in > RCU QSBR perf tests > > Since, rcu qsbr tests run for 'RCU_ITERATIONS' and not 'ITERATIONS', replace > 'ITERATIONS' with 'RCU_ITERATIONS' > for calculating adds, deletes, and cycles. > > Also, for multi-writer pe

Re: [dpdk-dev] [PATCH v2 2/4] test/lpm: return error on failure in rcu qsbr perf

2020-11-02 Thread Honnappa Nagarahalli
> > Return error if Add/Delete fail in multiwriter perf test > > Fixes: eff30b59cc2e ("test/lpm: add RCU performance tests") > Cc: honnappa.nagaraha...@arm.com > Cc: sta...@dpdk.org > > Signed-off-by: Dharmik Thakkar > Reviewed-by: Ruifeng Wang > --- > app/test/test_lpm_perf.c | 4 > 1

Re: [dpdk-dev] [PATCH v2 3/4] test/lpm: remove error checking in rcu qsbr perf

2020-11-02 Thread Honnappa Nagarahalli
> > Remove redundant error checking for reader threads since they never return > error. > > Fixes: eff30b59cc2e ("test/lpm: add RCU performance tests") > Cc: honnappa.nagaraha...@arm.com > Cc: sta...@dpdk.org > > Signed-off-by: Dharmik Thakkar > Reviewed-by: Ruifeng Wang > --- > app/test/te

Re: [dpdk-dev] [PATCH v1] app/regex: add job context

2020-11-02 Thread Thomas Monjalon
> > > From: Guy Kaneti > > > > > > Store mbuf pointer associated with that job. > > > > > > Signed-off-by: Guy Kaneti > > > > Kind reminder to all maintainers, please review and ack/comment. > > Acked-by: Ori Kam Applied, thanks

Re: [dpdk-dev] [PATCH v1] app/regex: configure qp according to device capabilities

2020-11-02 Thread Thomas Monjalon
> > From: Guy Kaneti > > > > configure qp with OOS according to device capabilities > > returned from rte_regexdev_info_get. > > > > Signed-off-by: Guy Kaneti > > Acked-by: Ori Kam Applied, thanks

Re: [dpdk-dev] [PATCH v1] regex/mlx5: add out of order scan capability

2020-11-02 Thread Thomas Monjalon
28/10/2020 14:18, Ophir Munk: > Add missing out of order scan capability > RTE_REGEXDEV_CAPA_QUEUE_PAIR_OOS_F to mlx5 regex PMD. > > Signed-off-by: Ophir Munk > Acked-by: Ori Kam Applied, thanks

Re: [dpdk-dev] [PATCH v2] regexdev: add OOS capability definition

2020-11-02 Thread Thomas Monjalon
> > From: Guy Kaneti > > > > Add out of order scan capability to check PMD > > support for OOS. > > > > Signed-off-by: Guy Kaneti > > Acked-by: Ori Kam Applied, thanks

Re: [dpdk-dev] [PATCH 1/8] regex/octeontx2: fix unnecessary name override

2020-11-02 Thread Thomas Monjalon
02/11/2020 20:48, David Marchand: > On Mon, Nov 2, 2020 at 6:45 PM Bruce Richardson > wrote: > > > > Since the device class is now part of the standard filenames, it's no > > longer needed in name overrides in specific drivers. > > > > Fixes: a20b2c01a7a1 ("build: standardize component names and d

[dpdk-dev] [PATCH v3 16/16] ethdev: include mbuf registration in Tx timestamp API

2020-11-02 Thread Thomas Monjalon
Previously, the Tx timestamp field and flag were registered in testpmd, as described in mlx5 guide. For consistency between Rx and Tx timestamps, managing mbuf registrations inside the driver, as properly documented, is a simpler expectation. The only driver to support this feature (mlx5) is updat

[dpdk-dev] [PATCH v3 15/16] mbuf: add Tx timestamp registration helper

2020-11-02 Thread Thomas Monjalon
The function rte_mbuf_dyn_tx_timestamp_register() can be used to register the required field and flag. Signed-off-by: Thomas Monjalon --- lib/librte_mbuf/rte_mbuf_dyn.c | 7 +++ lib/librte_mbuf/rte_mbuf_dyn.h | 22 ++ lib/librte_mbuf/version.map| 1 + 3 files change

[dpdk-dev] [PATCH v3 13/16] ethdev: add doxygen comment for Rx timestamp API

2020-11-02 Thread Thomas Monjalon
The offload flag DEV_RX_OFFLOAD_TIMESTAMP had no documentation. After switching to dynamic mbuf flag and field, it becomes even more important to explicit the feature behaviour. A doxyegn comment for the timesync API was mentioning the deprecated timestamp field, so it is also updated. Signed-off

[dpdk-dev] [PATCH v3 14/16] mbuf: remove deprecated timestamp field

2020-11-02 Thread Thomas Monjalon
As announced in the deprecation note, the field timestamp is removed to give more space to the dynamic fields. The related offload flag PKT_RX_TIMESTAMP is also removed. This is how the mbuf layout looks like (pahole-style): word type namebyte size

[dpdk-dev] [PATCH v3 12/16] examples/rxtx_callbacks: switch timestamp to dynamic field

2020-11-02 Thread Thomas Monjalon
The mbuf timestamp is moved to a dynamic field in order to allow removal of the deprecated static field. Signed-off-by: Thomas Monjalon --- examples/rxtx_callbacks/main.c | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/examples/rxtx_callbacks/main.c b/example

[dpdk-dev] [PATCH v3 10/16] net/pcap: switch Rx timestamp to dynamic mbuf field

2020-11-02 Thread Thomas Monjalon
The mbuf timestamp is moved to a dynamic field in order to allow removal of the deprecated static field. The related mbuf flag is also replaced. Signed-off-by: Thomas Monjalon --- drivers/net/pcap/rte_eth_pcap.c | 20 +--- 1 file changed, 17 insertions(+), 3 deletions(-) diff --

[dpdk-dev] [PATCH v3 11/16] app/testpmd: switch Rx timestamp to dynamic mbuf field

2020-11-02 Thread Thomas Monjalon
The mbuf timestamp is moved to a dynamic field in order to allow removal of the deprecated static field. The related mbuf flag is also replaced. Signed-off-by: Thomas Monjalon --- app/test-pmd/util.c | 39 +-- 1 file changed, 37 insertions(+), 2 deletions(-)

[dpdk-dev] [PATCH v3 08/16] net/nfb: switch Rx timestamp to dynamic mbuf field

2020-11-02 Thread Thomas Monjalon
The mbuf timestamp is moved to a dynamic field in order to allow removal of the deprecated static field. The related mbuf flag is also replaced. Signed-off-by: Thomas Monjalon --- drivers/net/nfb/nfb_rx.c | 15 ++- drivers/net/nfb/nfb_rx.h | 18 ++ 2 files changed, 28

[dpdk-dev] [PATCH v3 09/16] net/octeontx2: switch Rx timestamp to dynamic mbuf field

2020-11-02 Thread Thomas Monjalon
The mbuf timestamp is moved to a dynamic field in order to allow removal of the deprecated static field. The related mbuf flag is also replaced. The dynamic offset and flag are stored in struct otx2_timesync_info to favor cache locality. Signed-off-by: Thomas Monjalon --- drivers/net/octeontx2/

[dpdk-dev] [PATCH v3 07/16] net/mlx5: switch Rx timestamp to dynamic mbuf field

2020-11-02 Thread Thomas Monjalon
The mbuf timestamp is moved to a dynamic field in order to allow removal of the deprecated static field. The related mbuf flag is also replaced. The dynamic offset and flag are stored in struct mlx5_rxq_data to favor cache locality. Signed-off-by: Thomas Monjalon Reviewed-by: Ruifeng Wang Revie

[dpdk-dev] [PATCH v3 04/16] net/ark: switch Rx timestamp to dynamic mbuf field

2020-11-02 Thread Thomas Monjalon
The mbuf timestamp is moved to a dynamic field in order to allow removal of the deprecated static field. The related dynamic mbuf flag is set, although was missing previously. The timestamp is set if configured for at least one device. Signed-off-by: Thomas Monjalon --- drivers/net/ark/ark_ethd

[dpdk-dev] [PATCH v3 05/16] net/dpaa2: switch Rx timestamp to dynamic mbuf field

2020-11-02 Thread Thomas Monjalon
The mbuf timestamp is moved to a dynamic field in order to allow removal of the deprecated static field. The related mbuf flag is also replaced. Signed-off-by: Thomas Monjalon --- drivers/net/dpaa2/dpaa2_ethdev.c | 11 +++ drivers/net/dpaa2/dpaa2_ethdev.h | 2 ++ drivers/net/dpaa2/dpaa2

[dpdk-dev] [PATCH v3 06/16] net/mlx5: fix dynamic mbuf offset lookup check

2020-11-02 Thread Thomas Monjalon
The functions rte_mbuf_dynfield_lookup() and rte_mbuf_dynflag_lookup() can return an offset starting with 0 or a negative error code. In reality the first offsets are probably reserved forever, but for the sake of strict API compliance, the checks which considered 0 as an error are fixed. Fixes:

[dpdk-dev] [PATCH v3 01/16] eventdev: remove software Rx timestamp

2020-11-02 Thread Thomas Monjalon
This a revert of the commit 569758758dcd ("eventdev: add Rx timestamp"). If the Rx timestamp is not configured on the ethdev port, there is no reason to set one. Also the accuracy of the timestamp was bad because set at a late stage. Anyway there is no trace of the usage of this timestamp. Signed

[dpdk-dev] [PATCH v3 03/16] latency: switch Rx timestamp to dynamic mbuf field

2020-11-02 Thread Thomas Monjalon
The mbuf timestamp is moved to a dynamic field in order to allow removal of the deprecated static field. The related mbuf flag is also replaced with the dynamic one. Signed-off-by: Thomas Monjalon --- lib/librte_latencystats/rte_latencystats.c | 30 ++ 1 file changed, 25 inse

[dpdk-dev] [PATCH v3 02/16] mbuf: add Rx timestamp flag and helpers

2020-11-02 Thread Thomas Monjalon
There is already a dynamic field for timestamp, used only for Tx scheduling with the dedicated Tx offload flag. The same field can be used for Rx timestamp filled by drivers. A new dynamic flag is defined for Rx usage. A new function wraps the registration of both field and Rx flag. The type rte_m

[dpdk-dev] [PATCH v3 00/16] remove mbuf timestamp

2020-11-02 Thread Thomas Monjalon
The mbuf field timestamp was announced to be removed for three reasons: - a dynamic field already exist, used for Tx only - this field always used 8 bytes even if unneeded - this field is in the first half (cacheline) of mbuf After this series, the dynamic field timestamp is used for both Rx

[dpdk-dev] [PATCH v2 1/4] test/lpm: fix cycle calculation in rcu qsbr perf

2020-11-02 Thread Dharmik Thakkar
Fix incorrect calculations for LPM adds, LPM deletes, and average cycles in RCU QSBR perf tests Since, rcu qsbr tests run for 'RCU_ITERATIONS' and not 'ITERATIONS', replace 'ITERATIONS' with 'RCU_ITERATIONS' for calculating adds, deletes, and cycles. Also, for multi-writer perf test, each writer

[dpdk-dev] [PATCH v2 3/4] test/lpm: remove error checking in rcu qsbr perf

2020-11-02 Thread Dharmik Thakkar
Remove redundant error checking for reader threads since they never return error. Fixes: eff30b59cc2e ("test/lpm: add RCU performance tests") Cc: honnappa.nagaraha...@arm.com Cc: sta...@dpdk.org Signed-off-by: Dharmik Thakkar Reviewed-by: Ruifeng Wang --- app/test/test_lpm_perf.c | 21

[dpdk-dev] [PATCH v2 2/4] test/lpm: return error on failure in rcu qsbr perf

2020-11-02 Thread Dharmik Thakkar
Return error if Add/Delete fail in multiwriter perf test Fixes: eff30b59cc2e ("test/lpm: add RCU performance tests") Cc: honnappa.nagaraha...@arm.com Cc: sta...@dpdk.org Signed-off-by: Dharmik Thakkar Reviewed-by: Ruifeng Wang --- app/test/test_lpm_perf.c | 4 1 file changed, 4 insertions

[dpdk-dev] [PATCH v2 0/4] test/lpm: fix rcu qsbr perf test

2020-11-02 Thread Dharmik Thakkar
Fix LPM adds, LPM deletes, and cycle calculation. Return error if LPM add/delete fails in multi-writer test. Remove redundant error checking for readers. Combine single and multi threaded test cases to avoid code duplication. --- v2: - Add more details about the fix to the commit message - Replac

[dpdk-dev] [PATCH v2 4/4] test/lpm: avoid code duplication in rcu qsbr perf

2020-11-02 Thread Dharmik Thakkar
Avoid code duplication by combining single and multi threaded tests Signed-off-by: Dharmik Thakkar Reviewed-by: Ruifeng Wang --- app/test/test_lpm_perf.c | 362 ++- 1 file changed, 91 insertions(+), 271 deletions(-) diff --git a/app/test/test_lpm_perf.c b/ap

Re: [dpdk-dev] [PATCH v2 08/14] net/mlx5: switch timestamp to dynamic mbuf field

2020-11-02 Thread David Christensen
On 11/1/20 10:06 AM, Thomas Monjalon wrote: The mbuf timestamp is moved to a dynamic field in order to allow removal of the deprecated static field. The related mbuf flag is also replaced. Signed-off-by: Thomas Monjalon --- drivers/net/mlx5/mlx5_rxq.c | 36

Re: [dpdk-dev] [PATCH 4/4] test/lpm: avoid code duplication in rcu qsbr perf

2020-11-02 Thread Dharmik Thakkar
> On Nov 2, 2020, at 11:17 AM, Medvedkin, Vladimir > wrote: > > Hi Dharmik, > > Thanks for the patches, see comments inlined > > > On 29/10/2020 15:36, Dharmik Thakkar wrote: >> Avoid code duplication by combining single and multi threaded tests >> Signed-off-by: Dharmik Thakkar >> Reviewed

[dpdk-dev] [PATCH v2] doc: add reference to bbdev companion configuration tool

2020-11-02 Thread Nicolas Chautru
v2: typo corrections Adding reference to companion tool to perform PF device configuration of HW bbdev devices : pf_bb_config This topic was previously discussed in https://patches.dpdk.org/patch/74270/ and it was preferred for the tool to be be upstreamed outside of DPDK in github. This dependen

[dpdk-dev] [PATCH v2] doc: add reference to companion configuration tool

2020-11-02 Thread Nicolas Chautru
Adding reference to pf_bb_config in github to do device configuration of the fpga_5gnr, fpga_lte and acc100 devices and pmds. Signed-off-by: Nicolas Chautru --- doc/guides/bbdevs/acc100.rst| 19 +++ doc/guides/bbdevs/fpga_5gnr_fec.rst | 19 +++ doc/guides/

Re: [dpdk-dev] [PATCH 5/8] doc: fix driver names in NIC devices guide

2020-11-02 Thread David Marchand
On Mon, Nov 2, 2020 at 9:17 PM David Marchand wrote: > > On Mon, Nov 2, 2020 at 6:47 PM Bruce Richardson > wrote: > > > > Since the built driver filenames have changed in DPDK 20.11, we need to > > update the driver doc to match. > > > > Most drivers start their section with the driver filename h

Re: [dpdk-dev] [PATCH] pipeline: increase immediate operand size

2020-11-02 Thread David Marchand
On Thu, Oct 29, 2020 at 7:08 PM Cristian Dumitrescu wrote: > > From: Venkata Suresh Kumar P > > This patch increases the immediate operand size from 32 to 64 bits. > > Signed-off-by: Venkata Suresh Kumar P > Acked-by: Cristian Dumitrescu Applied, thanks. -- David Marchand

Re: [dpdk-dev] [PATCH 0/8] fix driver filenames in the docs

2020-11-02 Thread David Marchand
On Mon, Nov 2, 2020 at 6:45 PM Bruce Richardson wrote: > > Since the driver filenames are now following a new standard naming convention > some doc updates are necessary. This patch makes those changes, and also > includes a few other fixes, such as the first patch, where we remove an > unncessary

Re: [dpdk-dev] [PATCH 5/8] doc: fix driver names in NIC devices guide

2020-11-02 Thread David Marchand
On Mon, Nov 2, 2020 at 6:47 PM Bruce Richardson wrote: > > Since the built driver filenames have changed in DPDK 20.11, we need to > update the driver doc to match. > > Most drivers start their section with the driver filename highlighted in > bold, while a number were missing the highlight. When

Re: [dpdk-dev] [PATCH 8/8] doc: fix driver names in programmers guide

2020-11-02 Thread David Marchand
On Mon, Nov 2, 2020 at 6:48 PM Bruce Richardson wrote: > > Since the built driver filenames have changed in DPDK 20.11, we need to > update the programmers guide doc to match. > > Fixes: a20b2c01a7a1 ("build: standardize component names and defines") > > Signed-off-by: Bruce Richardson Reviewed-b

Re: [dpdk-dev] [PATCH 7/8] doc: fix driver names in vDPA devices guide

2020-11-02 Thread David Marchand
On Mon, Nov 2, 2020 at 6:47 PM Bruce Richardson wrote: > > Since the built driver filenames have changed in DPDK 20.11, we need to > update the driver doc to match. > > Fixes: a20b2c01a7a1 ("build: standardize component names and defines") > > Signed-off-by: Bruce Richardson Reviewed-by: David Ma

Re: [dpdk-dev] [PATCH 6/8] doc: fix driver names in regex devices guide

2020-11-02 Thread David Marchand
On Mon, Nov 2, 2020 at 6:47 PM Bruce Richardson wrote: > > Since the built driver filenames have changed in DPDK 20.11, we need to > update the driver doc to match. > > Fixes: a20b2c01a7a1 ("build: standardize component names and defines") > > Signed-off-by: Bruce Richardson Reviewed-by: David Ma

Re: [dpdk-dev] [PATCH 4/8] doc: fix driver names in event devices guide

2020-11-02 Thread David Marchand
On Mon, Nov 2, 2020 at 6:46 PM Bruce Richardson wrote: > > Since the built driver filenames have changed in DPDK 20.11, we need to > update the driver doc to match. > > Fixes: a20b2c01a7a1 ("build: standardize component names and defines") > > Signed-off-by: Bruce Richardson Reviewed-by: David Ma

Re: [dpdk-dev] [PATCH 3/8] doc: fix driver names in crypto devices guide

2020-11-02 Thread David Marchand
On Mon, Nov 2, 2020 at 9:00 PM David Marchand wrote: > We still have: > doc/guides/cryptodevs/mvsam.rst:The MVSAM CRYPTO PMD > (**librte_crypto_mvsam_pmd**) provides poll mode crypto driver Ah.. and: doc/guides/cryptodevs/snow3g.rst:The SNOW3G PMD (**librte_snow3g_zuc**) provides poll mode crypto

[dpdk-dev] [PATCH] doc: add reference to companion configuration tool

2020-11-02 Thread Nicolas Chautru
Adding reference to pf_bb_config in github to do device configuration of the fpga_5gnr, fpga_lte and acc100 devices and pmds. Signed-off-by: Nicolas Chautru --- doc/guides/bbdevs/acc100.rst| 19 +++ doc/guides/bbdevs/fpga_5gnr_fec.rst | 19 +++ doc/guides/

[dpdk-dev] [PATCH] doc: add reference to bbdev companion configuration tool

2020-11-02 Thread Nicolas Chautru
Adding reference to companion tool to perform PF device configuration of HW bbdev devices : pf_bb_config This topic was previously discussed in https://patches.dpdk.org/patch/74270/ and it was preferred for the tool to be be upstreamed outside of DPDK in github. This dependency notably allows to ru

Re: [dpdk-dev] [PATCH 3/8] doc: fix driver names in crypto devices guide

2020-11-02 Thread David Marchand
On Mon, Nov 2, 2020 at 6:46 PM Bruce Richardson wrote: > > Since the built driver filenames have changed in DPDK 20.11, we need to > update the driver doc to match. > > Fixes: a20b2c01a7a1 ("build: standardize component names and defines") > > Signed-off-by: Bruce Richardson > --- > doc/guides/c

[dpdk-dev] [PATCH] test/ring: remove unused code

2020-11-02 Thread Honnappa Nagarahalli
Remove unused assignment statement as the assigned variable is not used in the code further. Coverity issue: 363690 Fixes: 6c583103a2d1 ("test/ring: factorize object checks") Cc: feifei.wa...@arm.com Signed-off-by: Honnappa Nagarahalli Reviewed-by: Feifei Wang Reviewed-by: Ruifeng Wang --- ap

Re: [dpdk-dev] [PATCH] crypto/aesni_mb: fix cpu crypto cipher auth

2020-11-02 Thread Akhil Goyal
Hi Fan, > Subject: [PATCH] crypto/aesni_mb: fix cpu crypto cipher auth > > This patch fixes the AESNI-MB PMD CPU crypto process function. Orignally > the function tried to access crypto vector's aad buffer even it is not > needed. > > Fixes: 8d928d47a29a ("cryptodev: change crypto symmetric vecto

Re: [dpdk-dev] [PATCH] test/crypto: fix null dereference for crypto op

2020-11-02 Thread Akhil Goyal
> Subject: [dpdk-dev] [PATCH] test/crypto: fix null dereference for crypto op > > In two test cases, the op value is set by the return of the > process_crypto_request function, which may be NULL. The op->status > value was checked afterwards, which was causing a dereference issue. > > To fix this

Re: [dpdk-dev] [PATCH 2/8] doc: fix driver names in compression devices guide

2020-11-02 Thread David Marchand
On Mon, Nov 2, 2020 at 6:46 PM Bruce Richardson wrote: > > Since the built driver filenames have changed in DPDK 20.11, we need to > update the driver doc to match. > > Fixes: a20b2c01a7a1 ("build: standardize component names and defines") > > Signed-off-by: Bruce Richardson Reviewed-by: David Ma

Re: [dpdk-dev] [PATCH 1/8] regex/octeontx2: fix unnecessary name override

2020-11-02 Thread David Marchand
On Mon, Nov 2, 2020 at 6:45 PM Bruce Richardson wrote: > > Since the device class is now part of the standard filenames, it's no > longer needed in name overrides in specific drivers. > > Fixes: a20b2c01a7a1 ("build: standardize component names and defines") > > Signed-off-by: Bruce Richardson E

Re: [dpdk-dev] [PATCH v2] build: add pkg-config validation

2020-11-02 Thread Gregory Etelson
Hello Bruce, > -Original Message- [snip] > > +put it # next to --whole-archive. > > +test1_static_libs_order () { > > + PKG_CONFIG_PATH="${PKG_CONFIG_PATH}:$pc_dir" \ > > Should the $pc_dir not be put first, in case there are older .pc files > around for DPDK? I posted a v3 update

[dpdk-dev] [PATCH v3] build: add pkg-config validation

2020-11-02 Thread Gregory Etelson
DPDK relies on pkg-config(1) to provide correct parameters for compiler and linker used in application build. Inaccurate build parameters, produced by pkg-config from DPDK .pc files could fail application build or cause unpredicted results during application runtime. This patch validates host pkg-

Re: [dpdk-dev] [PATCH v4 2/6] build: refactor Arm build

2020-11-02 Thread Honnappa Nagarahalli
> > > > > > > > > diff --git a/config/arm/meson.build b/config/arm/meson.build > > > > > index > > > > > 491842cad..6c31ab167 100644 > > > > > --- a/config/arm/meson.build > > > > > +++ b/config/arm/meson.build > > > > > @@ -3,12 +3,12 @@ > > > > > # Copyright(c) 2017 Cavium, Inc # Copyright(c)

Re: [dpdk-dev] [RFC PATCH v3 3/6] build: automatic NUMA and cpu counts detection

2020-11-02 Thread Honnappa Nagarahalli
> > > > > > > > > > > > On Wed, Oct 21, 2020 at 01:37:38PM +0200, Juraj Linkeš wrote: > > > > > > The build machine's number of cpus and numa nodes vary, > > > > > > resulting in mismatched counts of RTE_MAX_LCORE and > > > RTE_MAX_NUMA_NODES for > > > > > many > > > > > > builds. Automatically d

Re: [dpdk-dev] [v6 1/2] cryptodev: support enqueue & dequeue callback functions

2020-11-02 Thread Akhil Goyal
Hi Abhinandan, > Hi Akhil, > > What is the status of this patch? Is it pulled into RC2? > > As I suggested below, please fix your date and let the CI pick your patches for build. In my local build for documentation, the newly added APIs are not added in the Documentation. Please fix doxygen is

Re: [dpdk-dev] [PATCH v3 1/2] ethdev: introduce transfer attribute to shared action conf

2020-11-02 Thread Ferruh Yigit
On 11/2/2020 11:43 AM, Ivan Malov wrote: In a flow rule, attribute "transfer" means operation level at which both traffic is matched and actions are conducted. Add the very same attribute to shared action configuration. If a driver needs to prepare HW resources in two different ways, depending o

Re: [dpdk-dev] [PATCH] app/testpmd: support age shared action context

2020-11-02 Thread Ferruh Yigit
On 11/1/2020 5:48 PM, Matan Azrad wrote: When an age action becomes aged-out the rte_flow_get_aged_flows should return the action context supplied by the configuration structure. In case the age action created by the shared action API, the shared action context of the Testpmd application was not

[dpdk-dev] [PATCH 8/8] ionic: nits - whitespace, logging, helper variables

2020-11-02 Thread Andrew Boyer
These are minor cleanups which did not deserve their own patches. Signed-off-by: Andrew Boyer --- drivers/net/ionic/ionic_ethdev.c | 10 -- drivers/net/ionic/ionic_lif.c| 22 ++--- drivers/net/ionic/ionic_main.c | 4 +--- drivers/net/ionic/ionic_rxtx.c | 33 +

[dpdk-dev] [PATCH 7/8] ionic: warn if RTE tries to enable loopback mode

2020-11-02 Thread Andrew Boyer
The ionic FW does not support loopback mode at this time. Signed-off-by: Andrew Boyer --- drivers/net/ionic/ionic_ethdev.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/ionic/ionic_ethdev.c b/drivers/net/ionic/ionic_ethdev.c index 600333e20..ff5c2e51a 100644 --- a/drivers/ne

[dpdk-dev] [PATCH 6/8] ionic: convert 'deferred' boolean to a flag bit

2020-11-02 Thread Andrew Boyer
This saves space in the structure. Signed-off-by: Andrew Boyer --- drivers/net/ionic/ionic_lif.c | 4 ++-- drivers/net/ionic/ionic_lif.h | 2 +- drivers/net/ionic/ionic_rxtx.c | 10 ++ 3 files changed, 9 insertions(+), 7 deletions(-) diff --git a/drivers/net/ionic/ionic_lif.c b/driv

[dpdk-dev] [PATCH 5/8] ionic: remove some unused fields

2020-11-02 Thread Andrew Boyer
These fields were constant or unused. Signed-off-by: Andrew Boyer --- drivers/net/ionic/ionic_dev.c | 5 + drivers/net/ionic/ionic_dev.h | 7 +-- drivers/net/ionic/ionic_lif.c | 22 ++ drivers/net/ionic/ionic_lif.h | 2 -- 4 files changed, 8 insertions(+), 28 delet

[dpdk-dev] [PATCH 2/8] ionic: connect to the meson build system

2020-11-02 Thread Andrew Boyer
Otherwise the ionic PMD is never built. Signed-off-by: Andrew Boyer --- drivers/net/meson.build | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/meson.build b/drivers/net/meson.build index 4e4c2c976..5fdcab3cc 100644 --- a/drivers/net/meson.build +++ b/drivers/net/meson.build @@ -

  1   2   3   >