[dpdk-dev] [RFC] net/i40e: refactor of hash flow

2020-10-22 Thread Zhang,Alvin
From: Alvin Zhang 1. Delete original code. 2. Add 2 tables(pattern RSS type matched PCTYPE, RSS type to input set). 3. Parse RSS pattern and RSS type to get PCTYPE. 4. Parse RSS action to get queues, RSS function and hash field. 5. Create and destroy RSS filters. 6. Create new files for hash flow

Re: [dpdk-dev] [PATCH 4/5] drivers: remove config prefix used with make

2020-10-22 Thread Andrew Rybchenko
On 10/23/20 1:05 AM, Thomas Monjalon wrote: > The config options CONFIG_RTE_* are simple RTE_* defines with meson. > Now that make support is dropped, update the names in log and comments. > > Signed-off-by: Thomas Monjalon Acked-by: Andrew Rybchenko

Re: [dpdk-dev] [PATCH v2 12/14] ethdev: remove legacy FDIR filter type support

2020-10-22 Thread Andrew Rybchenko
On 10/23/20 6:32 AM, Hyong Youb Kim (hyonkim) wrote: >> -Original Message- >> From: Andrew Rybchenko >> Sent: Thursday, October 22, 2020 6:43 PM >> To: Wenzhuo Lu ; Beilei Xing >> ; Bernard Iremonger >> ; Jeff Guo ; Ray Kinsella >> ; Neil Horman ; Ajit Khaparde >> ; Somnath Kotur >> ; John

Re: [dpdk-dev] [PATCH 3/5] lib: remove config prefix used with make

2020-10-22 Thread Ruifeng Wang
> -Original Message- > From: Thomas Monjalon > Sent: Friday, October 23, 2020 6:05 AM > To: dev@dpdk.org > Cc: ferruh.yi...@intel.com; david.march...@redhat.com; > bruce.richard...@intel.com; anatoly.bura...@intel.com; > olivier.m...@6wind.com; ciara.po...@intel.com; akhil.go...@nxp.com;

Re: [dpdk-dev] [PATCH v2 2/2] lpm: hide internal data

2020-10-22 Thread Ruifeng Wang
> -Original Message- > From: David Marchand > Sent: Thursday, October 22, 2020 11:14 PM > To: Ruifeng Wang > Cc: Bruce Richardson ; Vladimir Medvedkin > ; dev ; Honnappa > Nagarahalli ; nd ; Kevin > Traynor ; tho...@monjalon.net > Subject: Re: [PATCH v2 2/2] lpm: hide internal data > >

[dpdk-dev] [Bug 564] [dpdk-20.11]flow_classify_softnic: dpdk do not transport packet.

2020-10-22 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=564 Bug ID: 564 Summary: [dpdk-20.11]flow_classify_softnic: dpdk do not transport packet. Product: DPDK Version: 20.11 Hardware: All OS: Linux Status: UNCONF

Re: [dpdk-dev] [PATCH v2 3/3] virtio-user: set status on virtio-user reconnect

2020-10-22 Thread Jiang, YuX
Tested-by: JiangYuX Best Regards Jiang yu > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Maxime Coquelin > Sent: Thursday, October 22, 2020 4:32 PM > To: Adrian Moreno ; Xia, Chenbo > ; Wang, Yinan ; > dev@dpdk.org > Cc: Fu, Patrick ; sta...@dpdk.org

Re: [dpdk-dev] [PATCH v5 5/5] net/iavf: fix vector rx burst for iavf

2020-10-22 Thread Ling, WeiX
Tested-by: Ling, Wei Regards, Ling Wei > -Original Message- > From: dev On Behalf Of Jeff Guo > Sent: Friday, October 16, 2020 05:45 PM > To: Wu, Jingjing ; Zhang, Qi Z > ; Xing, Beilei ; Wang, Haiyue > ; Yang, Qiming > Cc: dev@dpdk.org; Yigit, Ferruh ; > m...@smartsharesystems.com; st

[dpdk-dev] [PATCH v3 4/5] test/ring: add functional tests for zero copy APIs

2020-10-22 Thread Honnappa Nagarahalli
Add functional tests for zero copy APIs. Test enqueue/dequeue functions are created using the zero copy APIs to fit into the existing testing method. Signed-off-by: Honnappa Nagarahalli Reviewed-by: Dharmik Thakkar --- app/test/test_ring.c | 196 +++ app/

[dpdk-dev] [PATCH v3 5/5] test/ring: add stress tests for zero copy APIs

2020-10-22 Thread Honnappa Nagarahalli
Add stress tests for zero copy API. Signed-off-by: Honnappa Nagarahalli Reviewed-by: Dharmik Thakkar --- app/test/meson.build | 2 + app/test/test_ring_mt_peek_stress_zc.c | 56 ++ app/test/test_ring_st_peek_stress_zc.c | 65 ++ app

[dpdk-dev] [PATCH v3 2/5] lib/ring: add zero copy APIs

2020-10-22 Thread Honnappa Nagarahalli
Add zero-copy APIs. These APIs provide the capability to copy the data to/from the ring memory directly, without having a temporary copy (for ex: an array of mbufs on the stack). Use cases that involve copying large amount of data to/from the ring can benefit from these APIs. Signed-off-by: Honnap

[dpdk-dev] [PATCH v3 3/5] test/ring: move common function to header file

2020-10-22 Thread Honnappa Nagarahalli
Move test_ring_inc_ptr to header file so that it can be used by functions in other files. Signed-off-by: Honnappa Nagarahalli Reviewed-by: Dharmik Thakkar --- app/test/test_ring.c | 11 --- app/test/test_ring.h | 11 +++ 2 files changed, 11 insertions(+), 11 deletions(-) diff -

[dpdk-dev] [PATCH v3 1/5] test/ring: fix the memory dump size

2020-10-22 Thread Honnappa Nagarahalli
Pass the correct number of bytes to dump the memory. Fixes: bf28df24e915 ("test/ring: add contention stress test" Cc: konstantin.anan...@intel.com Cc: sta...@dpdk.org Signed-off-by: Honnappa Nagarahalli Reviewed-by: Dharmik Thakkar --- app/test/test_ring_stress_impl.h | 2 +- 1 file changed, 1

[dpdk-dev] [PATCH v3 0/5] lib/ring: add zero copy APIs

2020-10-22 Thread Honnappa Nagarahalli
It is pretty common for the DPDK applications to be deployed in semi-pipeline model. In these models, a small number of cores (typically 1) are designated as I/O cores. The I/O cores work on receiving and transmitting packets from the NIC and several packet processing cores. The IO core and the pac

[dpdk-dev] [PATCH v4 3/3] net/ice: optimize Tx path on AVX512 vPMD

2020-10-22 Thread Leyi Rong
Optimize Tx path by using AVX512 instructions and vectorize the tx free bufs process. Signed-off-by: Leyi Rong Signed-off-by: Bruce Richardson --- drivers/net/ice/ice_rxtx.h| 4 + drivers/net/ice/ice_rxtx_vec_avx512.c | 147 ++ drivers/net/ice/ice_rxtx_vec_

[dpdk-dev] [PATCH v4 1/3] net/ice: add AVX512 vector path

2020-10-22 Thread Leyi Rong
Add AVX512 support for ice PMD. This patch adds ice_rxtx_vec_avx512.c to support ice AVX512 vPMD. This patch aims to enable AVX512 on ice vPMD. Main changes are focus on Rx path compared with AVX2 vPMD. Signed-off-by: Leyi Rong Signed-off-by: Bruce Richardson --- drivers/net/ice/ice_rxtx.c

[dpdk-dev] [PATCH v4 2/3] net/ice: add RSS hash parsing in AVX512 path

2020-10-22 Thread Leyi Rong
Support RSS hash parsing in AVX512 data path as the default RXDID is set to #22, that means the RSS hash field locates in the 2nd 16B of each Flex Rx descriptor. Signed-off-by: Leyi Rong --- drivers/net/ice/ice_rxtx_vec_avx512.c | 105 -- 1 file changed, 98 insertions(+),

[dpdk-dev] [PATCH v4 0/3] AVX512 vPMD on ice

2020-10-22 Thread Leyi Rong
This patchset aims to support AVX512 vPMD on ice. --- v4: - Replace buf_physaddr by buf_iova in the 1st patch to eliminate build error. v3: - Code rebased. v2: - No internal judgement when RTE_MACHINE_CPUFLAG_AVX512F is set in meson.build. - Add RSS hash parsing as default RXDID is set to #2

Re: [dpdk-dev] [PATCH v2 12/14] ethdev: remove legacy FDIR filter type support

2020-10-22 Thread Hyong Youb Kim (hyonkim)
> -Original Message- > From: Andrew Rybchenko > Sent: Thursday, October 22, 2020 6:43 PM > To: Wenzhuo Lu ; Beilei Xing > ; Bernard Iremonger > ; Jeff Guo ; Ray Kinsella > ; Neil Horman ; Ajit Khaparde > ; Somnath Kotur > ; John Daley (johndale) > ; Hyong Youb Kim (hyonkim) ; > Haiyue Wang

Re: [dpdk-dev] [PATCH 3/3] ethdev: move L2 tunnel config structure to ixgbe driver

2020-10-22 Thread Guo, Jia
> -Original Message- > From: Wang, Haiyue > Sent: Friday, October 23, 2020 10:13 AM > To: Andrew Rybchenko ; Guo, Jia > ; Thomas Monjalon ; Yigit, > Ferruh ; Andrew Rybchenko > > Cc: dev@dpdk.org > Subject: RE: [PATCH 3/3] ethdev: move L2 tunnel config structure to ixgbe > driver > > >

Re: [dpdk-dev] [PATCH 2/3] ethdev: remove L2 tunnel offload control API

2020-10-22 Thread Guo, Jia
> -Original Message- > From: Wang, Haiyue > Sent: Friday, October 23, 2020 10:12 AM > To: Andrew Rybchenko ; Lu, Wenzhuo > ; Xing, Beilei ; Iremonger, > Bernard ; Ray Kinsella ; > Neil Horman ; Guo, Jia ; > Thomas Monjalon ; Yigit, Ferruh > ; Andrew Rybchenko > > Cc: dev@dpdk.org > Subj

Re: [dpdk-dev] [PATCH 1/3] ethdev: remove API to config L2 tunnel EtherType

2020-10-22 Thread Guo, Jia
> -Original Message- > From: Wang, Haiyue > Sent: Friday, October 23, 2020 10:10 AM > To: Andrew Rybchenko ; Lu, Wenzhuo > ; Xing, Beilei ; Iremonger, > Bernard ; Ray Kinsella ; > Neil Horman ; Guo, Jia ; > Thomas Monjalon ; Yigit, Ferruh > ; Andrew Rybchenko > > Cc: dev@dpdk.org > Subj

[dpdk-dev] [PATCH] net/ice: fix Rx offload flags in SSE path

2020-10-22 Thread Zhang,Alvin
From: Alvin Zhang Update reading offload flags of last two of four packets. Fixes: ece1f8a8f1c8 ("net/ice: switch to flexible descriptor in SSE path") Cc: sta...@dpdk.org Signed-off-by: Alvin Zhang --- drivers/net/ice/ice_rxtx_vec_sse.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) d

Re: [dpdk-dev] [PATCH 3/3] ethdev: move L2 tunnel config structure to ixgbe driver

2020-10-22 Thread Wang, Haiyue
> -Original Message- > From: Andrew Rybchenko > Sent: Thursday, October 22, 2020 18:06 > To: Guo, Jia ; Wang, Haiyue ; > Thomas Monjalon > ; Yigit, Ferruh ; Andrew > Rybchenko > > Cc: dev@dpdk.org > Subject: [PATCH 3/3] ethdev: move L2 tunnel config structure to ixgbe driver > > net/ix

Re: [dpdk-dev] [PATCH 4/5] drivers: remove config prefix used with make

2020-10-22 Thread Ajit Khaparde
On Thu, Oct 22, 2020 at 3:05 PM Thomas Monjalon wrote: > > The config options CONFIG_RTE_* are simple RTE_* defines with meson. > Now that make support is dropped, update the names in log and comments. > > Signed-off-by: Thomas Monjalon For bnxt PMD, Acked-by: Ajit Khaparde > --- > drivers/net

Re: [dpdk-dev] [PATCH 2/3] ethdev: remove L2 tunnel offload control API

2020-10-22 Thread Wang, Haiyue
> -Original Message- > From: Andrew Rybchenko > Sent: Thursday, October 22, 2020 18:06 > To: Lu, Wenzhuo ; Xing, Beilei ; > Iremonger, Bernard > ; Ray Kinsella ; Neil Horman > ; Guo, > Jia ; Wang, Haiyue ; Thomas > Monjalon ; > Yigit, Ferruh ; Andrew Rybchenko > > Cc: dev@dpdk.org > S

[dpdk-dev] [PATCH v3 11/11] net/bnxt: add VXLAN decap offload support

2020-10-22 Thread Ajit Khaparde
From: Venkat Duvvuru VXLAN decap offload can happen in stages. The offload request may not come as a single flow request rather may come as two flow offload requests F1 & F2. This patch is adding support for this two stage offload design. The match criteria for F1 is O_DMAC, O_SMAC, O_DST_IP, O_U

[dpdk-dev] [PATCH v3 09/11] net/bnxt: refactor flow id allocation

2020-10-22 Thread Ajit Khaparde
From: Venkat Duvvuru Currently, the flow id is allocated inside ulp_mapper_flow_create. However with vxlan decap feature if F2 flow comes before F1 flow then F2 is cached and not really installed in the hardware which means the code will return without calling ulp_mapper_flow_create. But, ULP has

[dpdk-dev] [PATCH v3 07/11] net/bnxt: change HWRM command to create reps

2020-10-22 Thread Ajit Khaparde
From: Somnath Kotur Use cfa pair alloc for configuring reps. Instead of cfa_vfr_alloc for Wh+ and cfa_pair_alloc for Stingray, converge to cfa_pair_alloc/free for both devices. Set the command request structure bits accordingly. As part of this, remove the old cfa_vfr_alloc cmd definitions as FW

[dpdk-dev] [PATCH v3 06/11] net/bnxt: add support for flow counter accumulation

2020-10-22 Thread Ajit Khaparde
From: Kishore Padmanabha Add support for flow counter accumulation. In case of hierarchical flows, involving parent and child flows, the child flow counters are aggregated to get the parent flow counter information. Signed-off-by: Kishore Padmanabha Reviewed-by: Shahaji Bhosle Reviewed-by: Aji

[dpdk-dev] [PATCH v3 08/11] net/bnxt: add mapper support for wildcard TCAM

2020-10-22 Thread Ajit Khaparde
From: Kishore Padmanabha Added support for the key and mask fields encoding for the wildcard tcam entry. Signed-off-by: Kishore Padmanabha Reviewed-by: Mike Baucom Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/tf_ulp/ulp_mapper.c | 47 -- drivers/net/bnxt/tf_ulp/ulp_utils.c | 125

Re: [dpdk-dev] [PATCH 1/3] ethdev: remove API to config L2 tunnel EtherType

2020-10-22 Thread Wang, Haiyue
> -Original Message- > From: Andrew Rybchenko > Sent: Thursday, October 22, 2020 18:06 > To: Lu, Wenzhuo ; Xing, Beilei ; > Iremonger, Bernard > ; Ray Kinsella ; Neil Horman > ; Guo, > Jia ; Wang, Haiyue ; Thomas > Monjalon ; > Yigit, Ferruh ; Andrew Rybchenko > > Cc: dev@dpdk.org > S

[dpdk-dev] [PATCH v3 04/11] net/bnxt: update ULP resource counts

2020-10-22 Thread Ajit Khaparde
From: Peter Spreadborough - Update the SR ULP requested resource counts to reflect those available after AFM resources are accounted for. - Add build option to select either 2 or 4 slot EM entries. The default is 4 slot entries. Signed-off-by: Peter Spreadborough Signed-off-by: Farah Smith Rev

[dpdk-dev] [PATCH v3 05/11] net/bnxt: fix infinite loop in flow query count

2020-10-22 Thread Ajit Khaparde
From: Somnath Kotur `nxt_resource_idx` could be zero in some cases which is invalid and should be part of the while loop condition. Also synchronize access to the flow db using the fdb_lock Fixes: 306c2d28e247 ("net/bnxt: support count action in flow query") Signed-off-by: Somnath Kotur Review

[dpdk-dev] [PATCH v3 03/11] net/bnxt: add table scope to PF Mapping

2020-10-22 Thread Ajit Khaparde
From: Farah Smith Add table scope to PF Mapping for SR and Wh+ devices. Legacy devices require PF set of base addresses for EEM operation. A table scope id is a logical construct and is mapped to the PF associated with the communications channel used. In the case of a VF, the parent PF is used.

[dpdk-dev] [PATCH v3 00/11] bnxt fixes and enhancements to TRUFLOW support

2020-10-22 Thread Ajit Khaparde
This patchset has support for VXLAN decap full offload, SR device support in tf_core and a few bug fixes. v1->v2: - Squashed some patches. - Updated commit logs. - Fixed a compilation issue reported during clang builds. v2->v3: - Added the SPDX header for cfa_resource_types.h in patch [01/11]

[dpdk-dev] [PATCH v3 01/11] net/bnxt: add stingray support to core layer

2020-10-22 Thread Ajit Khaparde
From: Peter Spreadborough - Moved P4 specific code under the P4 directory - Added P45 skeleton code for SR to build on - Add SR support in TRUFLOW core layer. The TRUFLOW core or the tf-core is a shim layer which communicates with the CFA block in the hardware. Signed-off-by: Peter Spreadborough

[dpdk-dev] [PATCH v3 02/11] net/bnxt: changes to support two table scopes

2020-10-22 Thread Ajit Khaparde
From: Jay Ding New API to map a PARIF to an EEM table scope (set of Rx and Tx EEM base addresses). It uses HWRM_TF_GLOBAL_CFG_SET HWRM to configure. PARIF is handler to a partition of the physical port. Adjustments to tf_global_cfg_set() to reduce overhead and nominal name clarification. Signed-

Re: [dpdk-dev] [PATCH 4/5] drivers: remove config prefix used with make

2020-10-22 Thread Wang, Haiyue
> -Original Message- > From: Thomas Monjalon > Sent: Friday, October 23, 2020 06:05 > To: dev@dpdk.org > Cc: Yigit, Ferruh ; david.march...@redhat.com; > Richardson, Bruce > ; Burakov, Anatoly ; > olivier.m...@6wind.com; > Power, Ciara ; akhil.go...@nxp.com; Trahe, Fiona > ; > Griffin,

Re: [dpdk-dev] [PATCH v2 2/2] net/ixgbe: remove rte_panic

2020-10-22 Thread Zhang, Qi Z
> -Original Message- > From: dev On Behalf Of Wang, Haiyue > Sent: Wednesday, October 21, 2020 1:06 AM > To: Walsh, Conor ; Guo, Jia ; > Yigit, Ferruh ; Awal, Mohammad Abdul > ; Doherty, Declan > ; sta...@dpdk.org > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2 2/2] net/ixgbe: re

Re: [dpdk-dev] [PATCH v2 1/2] net/ixgbe: fix unchecked return value

2020-10-22 Thread Zhang, Qi Z
> -Original Message- > From: dev On Behalf Of Wang, Haiyue > Sent: Wednesday, October 21, 2020 1:06 AM > To: Walsh, Conor ; Guo, Jia ; > Yigit, Ferruh ; Awal, Mohammad Abdul > ; Doherty, Declan > ; sta...@dpdk.org > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2 1/2] net/ixgbe: fi

Re: [dpdk-dev] [PATCH v2] gso: fix free issue of mbuf gso segments attach to

2020-10-22 Thread Hu, Jiayu
> -Original Message- > From: Ananyev, Konstantin > Sent: Thursday, October 22, 2020 11:34 PM > To: yang_y...@163.com; dev@dpdk.org > Cc: Hu, Jiayu ; techbo...@dpdk.org; > tho...@monjalon.net; yangy...@inspur.com > Subject: RE: [PATCH v2] gso: fix free issue of mbuf gso segments attach t

[dpdk-dev] [PATCH] net/bnxt: update PMD supported features

2020-10-22 Thread Lance Richardson
Mark "BSD nic_uio", "Usage doc", and "Perf doc" as supported for the bnxt PMD. Signed-off-by: Lance Richardson Reviewed-by: Ajit Kumar Khaparde --- doc/guides/nics/features/bnxt.ini | 3 +++ 1 file changed, 3 insertions(+) diff --git a/doc/guides/nics/features/bnxt.ini b/doc/guides/nics/featu

[dpdk-dev] [PATCH] net/bnxt: use shorter SIMD initializers

2020-10-22 Thread Lance Richardson
Make SIMD initialization code less verbose by using appropriate intrinsics when all lanes of a vector are initialized to the same value. Signed-off-by: Lance Richardson Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_rxtx_vec_neon.c | 58 +++ drivers/net/bnxt/bnxt_r

[dpdk-dev] [PATCH] net/bnxt: fix incorrect boolean operator usage

2020-10-22 Thread Lance Richardson
Use boolean AND operator instead of bitwise operator. Coverity issue: 323488 Fixes: b42c15c83e88 ("net/bnxt: support trusted VF") Signed-off-by: Lance Richardson Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dri

[dpdk-dev] [PATCH 5/5] doc: remove references to make from known issues

2020-10-22 Thread Thomas Monjalon
The config options CONFIG_RTE_* are simple RTE_* defines with meson. Now that make support is dropped, update the HPET config reference. The comment about the AVX512 config option is not relevant anymore. Signed-off-by: Thomas Monjalon --- doc/guides/rel_notes/known_issues.rst | 8 ++-- 1 f

[dpdk-dev] [PATCH 3/5] lib: remove config prefix used with make

2020-10-22 Thread Thomas Monjalon
The config options CONFIG_RTE_* are simple RTE_* defines with meson. Now that make support is dropped, update the names in logs and comments. Signed-off-by: Thomas Monjalon --- lib/librte_eal/arm/include/rte_atomic_32.h | 2 +- lib/librte_eal/arm/include/rte_atomic_64.h | 2 +- lib/librte_ea

[dpdk-dev] [PATCH 4/5] drivers: remove config prefix used with make

2020-10-22 Thread Thomas Monjalon
The config options CONFIG_RTE_* are simple RTE_* defines with meson. Now that make support is dropped, update the names in log and comments. Signed-off-by: Thomas Monjalon --- drivers/net/bnxt/bnxt_ethdev.c | 2 +- drivers/net/ixgbe/ixgbe_rxtx.c | 2 +- drivers/net/sfc/sfc_ef10_essb_rx.c

[dpdk-dev] [PATCH 1/5] eal: remove comment about old partition option

2020-10-22 Thread Thomas Monjalon
The main initialization function (rte_eal_init) has documentation about a feature from another era: memory partition. Curiously, this lost treasure is found only now, suggesting there may be other interesting things to discover in the doc. To all aspiring Indiana Jones: the hunt is open! Signed-o

[dpdk-dev] [PATCH 2/5] mem: fix config name in error logs

2020-10-22 Thread Thomas Monjalon
When introducing the new option CONFIG_RTE_MAX_MEM_MB_PER_TYPE, some logs were referencing a wrong name: CONFIG_RTE_MAX_MEM_PER_TYPE. Fixes: 66cc45e293ed ("mem: replace memseg with memseg lists") Cc: sta...@dpdk.org Signed-off-by: Thomas Monjalon --- lib/librte_eal/freebsd/eal_memory.c | 2 +-

[dpdk-dev] [PATCH 0/5] cleanup comments and logs about config options

2020-10-22 Thread Thomas Monjalon
Below patches are cleaning traces of CONFIG_RTE_ after make removal, except one occurence in app/test/test_cryptodev.c (left as exercise). PS: In reality I don't know what must be done for this case about QAT. Thomas Monjalon (5): eal: remove comment about old partition option mem: fix config

Re: [dpdk-dev] [PATCH] doc: update build guide for armv8 crypto PMD

2020-10-22 Thread Honnappa Nagarahalli
+ Dharmik > -Original Message- > From: Thomas Monjalon > Sent: Thursday, October 22, 2020 4:18 PM > To: Ruifeng Wang > Cc: dev@dpdk.org; akhil.go...@nxp.com; Honnappa Nagarahalli > ; nd > Subject: Re: [dpdk-dev] [PATCH] doc: update build guide for armv8 crypto > PMD > > 14/10/2020 11:2

Re: [dpdk-dev] [PATCH] doc: update build guide for armv8 crypto PMD

2020-10-22 Thread Thomas Monjalon
14/10/2020 11:24, Ruifeng Wang: > +* Build DPDK with meson option > ``-Darmv8_crypto_dir=``: > + > + meson -Darmv8_crypto_dir= build Please, could you add pkg-config support to this lib? I would like to remove with option from DPDK, and use the standard variable PKG_CONFIG_PATH instead. Than

Re: [dpdk-dev] [PATCH] doc: update build guide for armv8 crypto PMD

2020-10-22 Thread Thomas Monjalon
14/10/2020 11:24, Ruifeng Wang: > Removed references to Makefile and added guide about > building by using meson. > > Also added the command to create virtual device. > > Suggested-by: Akhil Goyal > Signed-off-by: Ruifeng Wang Applied, thanks

Re: [dpdk-dev] [PATCH v7 00/14] remove make support in DPDK

2020-10-22 Thread Thomas Monjalon
21/10/2020 10:17, Ciara Power: > 147 files changed, 729 insertions(+), 2065 deletions(-) Huge patchset! After few adjustments (including new driver and remaining CONFIG_RTE), Applied, thanks for the great effort.

[dpdk-dev] [PATCH v4 5/5] doc: change references to blacklist and whitelist

2020-10-22 Thread Stephen Hemminger
There are two areas where documentation needed update. The first was use of whitelist when describing address filtering. The other is the legacy -w whitelist option for PCI which is used in many examples Signed-off-by: Stephen Hemminger Acked-by: Luca Boccassi --- doc/guides/cryptodevs/dpaa2_s

[dpdk-dev] [PATCH v4 2/5] drivers: replace references to blacklist

2020-10-22 Thread Stephen Hemminger
Use the new terminology blocked to describe when devices are excluded from being used. Signed-off-by: Stephen Hemminger Acked-by: Luca Boccassi Acked-by: Hemant Agrawal --- drivers/bus/dpaa/dpaa_bus.c| 7 +++ drivers/bus/fslmc/fslmc_bus.c | 9 - drivers/bus/fslmc/fsl

[dpdk-dev] [PATCH v4 3/5] eal: replace pci-whitelist/pci-blacklist options

2020-10-22 Thread Stephen Hemminger
Replace -w / --pci-whitelist with -a / --allow options and --pci-blacklist with --block. The -b short option remains unchanged. Allow the old options for now, but print a nag warning since old options are deprecated. Signed-off-by: Stephen Hemminger Acked-by: Luca Boccassi --- lib/librte_eal/c

[dpdk-dev] [PATCH v4 4/5] app/test: use new allowlist and blocklist

2020-10-22 Thread Stephen Hemminger
Test the renamed blocklist and allowlist arguments. Use new terms in test variable names as well. Signed-off-by: Stephen Hemminger Acked-by: Luca Boccassi --- app/test/autotest.py| 16 ++-- app/test/autotest_runner.py | 18 ++--- app/test/test.c | 2 +- app/

[dpdk-dev] [PATCH v4 0/5] replace blacklist/whitelist with block/allow

2020-10-22 Thread Stephen Hemminger
This is a revised version of the earlier RFC patch set for changing the blacklist/whitelist terms in DPDK. The first patch is a duplicate from the other patch set about use of master/slave in API. Note: This may cause some warnings in existing programs in the CI tests using the -w flag. It also

Re: [dpdk-dev] [PATCH v7 12/14] doc: remove references to make from contributing guide

2020-10-22 Thread Thomas Monjalon
21/10/2020 10:17, Ciara Power: > -* ``CONFIG_RTE_ARCH`` is a string that contains the name of the architecture. > -* ``CONFIG_RTE_ARCH_I686``, ``CONFIG_RTE_ARCH_X86_64``, > ``CONFIG_RTE_ARCH_X86_64_32`` or ``CONFIG_RTE_ARCH_PPC_64`` are defined only > if we are building for those architectures. >

[dpdk-dev] [PATCH v4 1/5] eal: replace usage of blacklist/whitelist in enum

2020-10-22 Thread Stephen Hemminger
This patch renames the enum values in the EAL include files. As a backward compatible temporary migration tool, define a replacement mapping for old values. The old names relating to blacklist and whitelist are replaced by block list and allow list, but applications may be using the older compatib

[dpdk-dev] [Bug 563] mlx5 silently fails to create an ethernet rte_flow rule

2020-10-22 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=563 Bug ID: 563 Summary: mlx5 silently fails to create an ethernet rte_flow rule Product: DPDK Version: 20.11 Hardware: x86 OS: Linux Status: UNCONFIRMED

Re: [dpdk-dev] [PATCH] hash: use x86 common flag for jhash

2020-10-22 Thread David Marchand
On Thu, Oct 22, 2020 at 10:23 AM Bruce Richardson wrote: > On Thu, Oct 22, 2020 at 09:59:59AM +0200, David Marchand wrote: > > jhash has been forgotten when factorising the x86 arch check. > > > > Fixes: dbf17d44f375 ("hash: use common x86 flag") > > > > Signed-off-by: David Marchand > Acked-by:

Re: [dpdk-dev] [PATCH] efd: fix tailq entry leak in error path

2020-10-22 Thread David Marchand
On Tue, Sep 29, 2020 at 5:32 AM wangyunjian wrote: > > From: Yunjian Wang > > In rte_efd_create() allocated memory for tailq entry, we should > free it when error happens, otherwise it will lead to memory leak. > > Fixes: 56b6ef874f80 ("efd: new Elastic Flow Distributor library") > Cc: sta...@dpd

Re: [dpdk-dev] [PATCH v2] eal: fix dereference after null check

2020-10-22 Thread David Marchand
On Thu, Oct 15, 2020 at 10:43 AM wangyunjian wrote: > > From: Yunjian Wang > > This patch fixes (dereference after null check) coverity issue. > For this reason, we should add null check at the beginning of the > function and return error directly if the 'intr_handle' is null. > > Coverity issue:

[dpdk-dev] [PATCH 1/2] net/netvsc: allow setting rx and tx copy break

2020-10-22 Thread Long Li
From: Stephen Hemminger The values for Rx and Tx copy break should be tunable rather than hard coded constants. The rx_copybreak sets the threshold where the driver uses an external mbuf to avoid having to copy data. Setting 0 for copybreak will cause driver to always create an external mbuf. Se

[dpdk-dev] [PATCH 2/2] net/netvsc: introduce driver parameter to control the use of external mbuf on receiving data

2020-10-22 Thread Long Li
From: Long Li When receiving packets, netvsp puts data in a buffer mapped through UIO. Depending on packet size, netvsc may attach the buffer as an external mbuf. This is not a problem if this mbuf is consumed in the application, and the application can correctly read data out of an external mbuf

Re: [dpdk-dev] [PATCH] eal: create a runtime directory on windows

2020-10-22 Thread Dmitry Kozlyuk
> /* Detect if we are a primary or a secondary process */ > enum rte_proc_type_t > eal_proc_type_detect(void) > @@ -181,6 +231,13 @@ eal_parse_args(int argc, char **argv) > } > } > > + /* create runtime data directory */ > + if (internal_conf->no_shconf == 0 && > +

Re: [dpdk-dev] [PATCH v6 1/4] rcu: build on Windows

2020-10-22 Thread Kadam, Pallavi
On 10/21/2020 3:50 PM, Dharmik Thakkar wrote: Build the lib for Windows. Signed-off-by: Dharmik Thakkar Tested-by: Dmitry Kozlyuk --- Builds successfully on Windows. Tested-by: Pallavi Kadam

Re: [dpdk-dev] [PATCH] eal: create a runtime directory on windows

2020-10-22 Thread Ranjit Menon
On 10/21/2020 1:26 PM, Pallavi Kadam wrote: Added eal_create_runtime_dir() function in order to run any application as a user that does not have administrator access. Currently, since there is no runtime directory set, the code tries to create a file in C:\ which is only writable with administr

Re: [dpdk-dev] [PATCH v6 2/2] librte_ethdev: fix MTU size exceeds max rx packet length

2020-10-22 Thread Ananyev, Konstantin
> > Update the MTU size according to the max rx packet and Ether overhead. > > Fixes: 59d0ecdbf0e1 ("ethdev: MTU accessors") > > Signed-off-by: SteveX Yang > --- > lib/librte_ethdev/rte_ethdev.c | 14 ++ > 1 file changed, 14 insertions(+) > > diff --git a/lib/librte_ethdev/rte_e

Re: [dpdk-dev] [PATCH V3 1/1] net/mlx5: fix IPv6 next proto validation

2020-10-22 Thread Ferruh Yigit
On 10/22/2020 11:01 AM, Raslan Darawsheh wrote: Hi, -Original Message- From: Eli Britstein Sent: Thursday, October 22, 2020 11:26 AM To: dev@dpdk.org Cc: Dekel Peled ; Ori Kam ; Matan Azrad ; Raslan Darawsheh ; Slava Ovsiienko ; Shahaf Shuler ; Asaf Penso ; Eli Britstein Subject: [PAT

Re: [dpdk-dev] [PATCH v6 2/2] librte_ethdev: fix MTU size exceeds max rx packet length

2020-10-22 Thread Ferruh Yigit
On 10/22/2020 9:48 AM, SteveX Yang wrote: If max rx packet length is smaller then MTU + Ether overhead, that will drop all MTU size packets. Update the MTU size according to the max rx packet and Ether overhead. Fixes: 59d0ecdbf0e1 ("ethdev: MTU accessors") Signed-off-by: SteveX Yang --- li

Re: [dpdk-dev] [PATCH v6 1/2] app/testpmd: fix max rx packet length for VLAN packets

2020-10-22 Thread Ferruh Yigit
On 10/22/2020 9:48 AM, SteveX Yang wrote: When the max rx packet length is smaller than the sum of mtu size and ether overhead size, it should be enlarged, otherwise the VLAN packets will be dropped. Fixes: 35b2d13fd6fd ("net: add rte prefix to ether defines") Signed-off-by: SteveX Yang ---

[dpdk-dev] [PATCH 1/2] crypto/aesni_mb: support Chacha-Poly in symmetric API

2020-10-22 Thread Pablo de Lara
Add support for Chacha20-Poly1305 in the crypto symmetric API. Signed-off-by: Pablo de Lara --- drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c | 21 +++-- 1 file changed, 15 insertions(+), 6 deletions(-) diff --git a/drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c b/drivers/crypto/aesni

[dpdk-dev] [PATCH 2/2] test/crypto: disable wireless tests for symmetric API

2020-10-22 Thread Pablo de Lara
SNOW3G, KASUMI and ZUC algorithms have been added to aesni_mb PMD in this release. These algorithms are not supported for the crypto symmetric API, so the crypto tests for these algorithms are disabled. Fixes: ae8e085c608d ("crypto/aesni_mb: support KASUMI F8/F9") Fixes: 6c42e0cf4d12 ("crypto/aesn

[dpdk-dev] [PATCH v2] net/mlx5: implement tunnel offload API

2020-10-22 Thread Gregory Etelson
Tunnel Offload API provides hardware independent, unified model to offload tunneled traffic. Key model elements are: - apply matches to both outer and inner packet headers during entire offload procedure; - restore outer header of partially offloaded packet; - model is implemented as a set of

[dpdk-dev] [PATCH v5 3/3] PCI: don't use vfio ioctl call to access PIO resource

2020-10-22 Thread 谢华伟(此时此刻)
From: "huawei.xhw" VFIO should use the same way to map/read/write PORT IO as UIO, for virtio PMD. Signed-off-by: huawei.xhw --- drivers/bus/pci/linux/pci.c | 8 drivers/bus/pci/linux/pci_uio.c | 4 +++- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/bus/pci

[dpdk-dev] [PATCH v5 2/3] PCI: support MMIO in rte_pci_ioport_map/unap/read/write

2020-10-22 Thread 谢华伟(此时此刻)
From: "huawei.xhw" If IO BAR, we get PIO address. If MMIO BAR, we get mapped virtual address. We distinguish PIO and MMIO by their address like how kernel does. ioread/write8/16/32 is provided to access PIO/MMIO. BTW, for virtio on arch other than x86, BAR flag indicates PIO but is mapped. Signe

[dpdk-dev] [PATCH v5 1/3] PCI: use PCI standard sysfs entry to get PIO address

2020-10-22 Thread 谢华伟(此时此刻)
From: "huawei.xhw" Previously with igb_uio we get PIO address from igb_uio sysfs entry, with uio_pci_generic, we get PIO address from /proc/ioports. Signed-off-by: huawei.xhw --- drivers/bus/pci/linux/pci.c | 77 - drivers/bus/pci/linux/pci_uio.c | 6

[dpdk-dev] [PATCH v5 0/3] support both PIO and MMIO BAR for virtio PMD

2020-10-22 Thread 谢华伟(此时此刻)
From: "huawei.xhw" Legacy virtio-pci only supports PIO BAR resource. As we need to create lots of virtio devices and PIO resource on x86 is very limited, we expose MMIO BAR. Kernel supports both PIO and MMIO BAR for legacy virtio-pci device. We handles different type of BAR in the similar way.

[dpdk-dev] [PATCH 5/5] net/mlx5: report Rx segmentation capabilies

2020-10-22 Thread Viacheslav Ovsiienko
Add rte_eth_dev_info->rx_seg_capa parameters: - receiving to multiple pools is supported - buffer offsets are supported - no offset alignment requirement - reports the maximal aamount of segments Signed-off-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5_ethdev.c | 4 drivers/net

[dpdk-dev] [PATCH 3/5] net/mlx5: register multiple pool for Rx queue

2020-10-22 Thread Viacheslav Ovsiienko
The split feature for receiving packets was added to the mlx5 PMD, now Rx queue can receive the data to the buffers belonging to the different pools and the memory of all the involved pool must be registered for DMA operations in order to allow hardware to store the data. Signed-off-by: Viacheslav

[dpdk-dev] [PATCH 4/5] net/mlx5: update Rx datapath to support split

2020-10-22 Thread Viacheslav Ovsiienko
Only the regular rx_burst routine is updated to support split, because the vectorized ones does not support scatter and MPRQ does not support split at all. Signed-off-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5_rxq.c | 11 +-- drivers/net/mlx5/mlx5_rxtx.c | 3 ++- 2 files change

[dpdk-dev] [PATCH 2/5] net/mlx5: configure Rx queue to support split

2020-10-22 Thread Viacheslav Ovsiienko
The scatter-gather elements should be configured accordingly to support the buffer split feature. The application provides the desired settings for the segments at the beginning of the packets and PMD pads the buffer chain (if needed) with attributes of last specified segment to accommodate the pac

[dpdk-dev] [PATCH 1/5] net/mlx5: add extended Rx queue setup routine

2020-10-22 Thread Viacheslav Ovsiienko
The routine to provide Rx queue setup with specifying extended receiving buffer description is added. It allows application to specify desired segment lengths, data position offsets in the buffer and dedicated memory pool for each segment. Signed-off-by: Viacheslav Ovsiienko --- drivers/net/mlx5

[dpdk-dev] [PATCH 0/5] net/mlx5: add Rx buffer split support

2020-10-22 Thread Viacheslav Ovsiienko
This patch adds to PMD the functionality for the receiving buffer split feasture [1] [1] http://patches.dpdk.org/patch/81154/ Signed-off-by: Viacheslav Ovsiienko --- Viacheslav Ovsiienko (5): net/mlx5: add extended Rx queue setup routine net/mlx5: configure Rx queue to support split net/

Re: [dpdk-dev] [PATCH v2] gso: fix free issue of mbuf gso segments attach to

2020-10-22 Thread Ananyev, Konstantin
> > > > rte_gso_segment decreased refcnt of pkt by one, but > > it is wrong if pkt is external mbuf, pkt won't be > > freed because of incorrect refcnt, the result is > > application can't allocate mbuf from mempool because > > mbufs in mempool are run out of. > > > > One correct way is applicati

Re: [dpdk-dev] [PATCH v3 5/5] doc: change references to blacklist and whitelist

2020-10-22 Thread Wang, Haiyue
> -Original Message- > From: Stephen Hemminger > Sent: Thursday, October 22, 2020 22:39 > To: dev@dpdk.org > Cc: Stephen Hemminger ; Luca Boccassi > ; Akhil Goyal > ; Hemant Agrawal ; Griffin, John > ; > Trahe, Fiona ; Jain, Deepak K > ; Pavan Nikhilesh > ; Jerin Jacob ; Richardson, >

Re: [dpdk-dev] [PATCH v2 2/2] lpm: hide internal data

2020-10-22 Thread David Marchand
On Wed, Oct 21, 2020 at 5:02 AM Ruifeng Wang wrote: > diff --git a/lib/librte_lpm/rte_lpm.c b/lib/librte_lpm/rte_lpm.c > index 51a0ae578..88d31df6d 100644 > --- a/lib/librte_lpm/rte_lpm.c > +++ b/lib/librte_lpm/rte_lpm.c > @@ -42,9 +42,17 @@ enum valid_flag { > > /** @internal LPM structure. */ >

Re: [dpdk-dev] [PATCH v13 1/7] fib: make lookup function type configurable

2020-10-22 Thread Medvedkin, Vladimir
Hi David, On 22/10/2020 12:52, David Marchand wrote: On Mon, Oct 19, 2020 at 5:05 PM Vladimir Medvedkin wrote: Add type argument to dir24_8_get_lookup_fn() Now it supports 3 different lookup implementations: RTE_FIB_DIR24_8_SCALAR_MACRO RTE_FIB_DIR24_8_SCALAR_INLINE RTE_FIB_DIR24_8_SCAL

Re: [dpdk-dev] [PATCH v2 0/2] net/mlx5: add vectorized mprq

2020-10-22 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Alexander Kozyrev > Sent: Wednesday, October 21, 2020 11:30 PM > To: dev@dpdk.org > Cc: Raslan Darawsheh ; Matan Azrad > ; Slava Ovsiienko > Subject: [PATCH v2 0/2] net/mlx5: add vectorized mprq > > The vectorized Rx burst function helps to accelerate th

[dpdk-dev] [RFC PATCH 3/3] build: write messages to dpdk build log file

2020-10-22 Thread Bruce Richardson
Add additional info into the DPDK-specific logs by copying or replacing all "message()" calls with writes to the log file, making the build configuration, including lists of enabled/disabled drivers etc. available after the meson run has completed. Signed-off-by: Bruce Richardson --- app/test/me

[dpdk-dev] [RFC PATCH 2/3] build: shorten top-level build file

2020-10-22 Thread Bruce Richardson
Move some basic configuration settings out of the top-level meson.build file to the "config/meson.build" file, so as to keep the top-level file as clear and as short as possible. Signed-off-by: Bruce Richardson --- config/meson.build | 18 ++ meson.build| 17 -

[dpdk-dev] [RFC PATCH 0/3] add custom logging to DPDK meson runs

2020-10-22 Thread Bruce Richardson
While the meson.log file in each build directory contains lots of information, much of it is not of interest to developers, and it can be hard to see the explicitly messages from the dpdk build files among all the rest of the content. Futhermore, while at the end of the a configuration run we print

[dpdk-dev] [RFC PATCH 1/3] build: add a dpdk-specific meson log file

2020-10-22 Thread Bruce Richardson
While meson itself writes a log file of all the tests it runs and the output of those, to help debug any build problems and provide more developer information it can be helpful to have a logfile created and controlled by the dpdk meson.build files themselves. Since meson doesn't directly support t

[dpdk-dev] DPDK Release Status Meeting 22/10/2020

2020-10-22 Thread Ferruh Yigit
Meeting minutes of 22 October 2020 -- Agenda: * Release Dates * -rc1 status * Subtrees * LTS * OvS * Opens Participants: * Arm * Broadcom * Debian/Microsoft * Intel * Marvell * Nvidia * NXP * Red Hat Release Dates - * v20.11 dates * -rc1 is releas

[dpdk-dev] [PATCH v3 5/5] doc: change references to blacklist and whitelist

2020-10-22 Thread Stephen Hemminger
There are two areas where documentation needed update. The first was use of whitelist when describing address filtering. The other is the legacy -w whitelist option for PCI which is used in many examples Signed-off-by: Stephen Hemminger Acked-by: Luca Boccassi --- doc/guides/cryptodevs/dpaa2_s

[dpdk-dev] [PATCH v3 4/5] app/test: use new allowlist and blocklist

2020-10-22 Thread Stephen Hemminger
Test the renamed blocklist and allowlist arguments. Use new terms in test variable names as well. Signed-off-by: Stephen Hemminger Acked-by: Luca Boccassi --- app/test/autotest.py| 16 ++-- app/test/autotest_runner.py | 18 ++--- app/test/test.c | 2 +- app/

  1   2   3   >