[dpdk-dev] [PATCH V1 1/1] net/mlx5: support item type error message in flow Verbs

2020-09-27 Thread Li Zhang
Update the flow verbs error message to "item type X not supported", when it is not supported, instead of a generic error message "item not supported". Signed-off-by: Li Zhang --- drivers/net/mlx5/mlx5_flow_verbs.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/dr

[dpdk-dev] [PATCH] bus/pci: fix mapping of PCI resources

2020-09-27 Thread alvinx . zhang
From: Alvin Zhang When mapping PCI bar resources around the MSI-X table, if the size of the first part is 0, the second part should also be mapped if its size is not 0. Fixes: e200535c1ca3 ("mem: drop mapping API workaround") Cc: sta...@dpdk.org Signed-off-by: Alvin Zhang --- drivers/bus/pci/

[dpdk-dev] [PATCH v1 1/2] net/ice/base: add tunnel support for FDIR

2020-09-27 Thread Zhirun Yan
Add struct to store outer part for tunnel rule. Add vxlan ptype in ipv4 mac bitmap. So when create a vxlan rule, the ptype group will be valid. Signed-off-by: Zhirun Yan --- drivers/net/ice/base/ice_fdir.c | 7 +++ drivers/net/ice/base/ice_fdir.h | 9 + drivers/net/ice/base/ice_flow.

[dpdk-dev] [PATCH v1 2/2] net/ice: support inner/outer L2/L3 field for FDIR

2020-09-27 Thread Zhirun Yan
Distinguish inner/outer fields for parse pattern. So FDIR for tunnel can be more flexible. Enable VXLAN inner/outer L3/L4 different fields for FDIR. Signed-off-by: Zhirun Yan --- drivers/net/ice/ice_fdir_filter.c | 59 +-- 1 file changed, 56 insertions(+), 3 deletions

[dpdk-dev] [PATCH v1 0/2] support FDIR inner/outer field for tunnel packet

2020-09-27 Thread Zhirun Yan
support FDIR inner/outer field for tunnel packet Enable VXLAN inner/outer L2/L3 fields. Zhirun Yan (2): net/ice/base: add tunnel support for FDIR net/ice: support inner/outer L2/L3 field for FDIR drivers/net/ice/base/ice_fdir.c | 7 drivers/net/ice/base/ice_fdir.h | 9 + driv

Re: [dpdk-dev] [PATCH v1 1/4] example/vhost: add async vhost driver args parsing function

2020-09-27 Thread Jiang, Cheng1
Hi Maxime, Thanks for your comments. The replies are inline. > -Original Message- > From: Maxime Coquelin > Sent: Wednesday, September 23, 2020 4:25 PM > To: Jiang, Cheng1 ; Xia, Chenbo > ; Wang, Zhihong ; > Mcnamara, John ; Kovacevic, Marko > > Cc: dev@dpdk.org; Fu, Patrick > Subject:

Re: [dpdk-dev] [PATCH v2] common/octeontx2: fix memory mapping API's usage

2020-09-27 Thread Jerin Jacob
On Thu, Sep 24, 2020 at 4:10 PM Sarosh Arif wrote: > > replace mmap() with rte_mem_map() > and replace munmap() with rte_mem_unmap() > > Fixes: e1d9a02ad8f0 ("common/octeontx2: introduce common device class") > Signed-off-by: Sarosh Arif Updated the commit message to: < common/octeontx2: fix

Re: [dpdk-dev] [PATCH 2/2] eventdev: update app and examples for new eventdev ABI

2020-09-27 Thread Jerin Jacob
On Fri, Sep 11, 2020 at 10:32 PM Timothy McDaniel wrote: > > Several data structures and constants changed, or were added, > in the previous patch. This commit updates the dependent > apps and examples to use the new ABI. > > Signed-off-by: Timothy McDaniel > --- > app/test-eventdev/evt_common.

Re: [dpdk-dev] [PATCH 1/2] eventdev: implement ABI change

2020-09-27 Thread Jerin Jacob
On Thu, Sep 24, 2020 at 3:25 PM Sunil Kumar Kori wrote: > > >-Original Message- > >From: dev On Behalf Of Timothy McDaniel > >Sent: Friday, September 11, 2020 10:28 PM > >Cc: Jerin Jacob Kollanukkaran ; > >mattias.ronnb...@ericsson.com; liang.j...@intel.com; > >peter.mccar...@intel.com; n

Re: [dpdk-dev] [PATCH 2/2] doc: update octeontx platform guide

2020-09-27 Thread Jerin Jacob
On Fri, Jun 26, 2020 at 9:26 PM Harman Kalra wrote: > > Removing make build instructions from the platform guide > as building DPDK sources using 'make' will be deprecated > in future releases. Please change the commit message as the fact that 'make' is removed now. And please add the Fix tag to

Re: [dpdk-dev] [PATCH 1/2] doc: update octeontx2 platform guide

2020-09-27 Thread Jerin Jacob
On Fri, Jun 26, 2020 at 9:26 PM Harman Kalra wrote: > > Removing make build instructions from the platform guide > as building DPDK sources using 'make' will be deprecated > in future releases. Please change the commit message as the fact that 'make' is removed now. And please add the Fix tag to

Re: [dpdk-dev] [PATCH] net/octeontx2: fix multi seg mode for jumbo packets

2020-09-27 Thread Jerin Jacob
On Mon, Aug 10, 2020 at 4:26 PM Harman Kalra wrote: > > Scatter gather mode should get enabled: > - If mbuf size is less than max received packet length. > - MTU is reconfigured greater than mbuf size. > > Fixes: 0e2efd02db58 ("net/octeontx2: add MTU set operation") > Cc: sta...@dpdk.org > > Sig

[dpdk-dev] [PATCH v2 1/1] net/mlx5: support match ICMP identifier fields

2020-09-27 Thread Li Zhang
PRM expose fields "Icmp_header_data" in ICMP. Update ICMP mask parameter with ICMP identifier and sequence number fields. ICMP sequence number spec with mask, Icmp_header_data low 16 bits are set. ICMP identifier spec with mask, Icmp_header_data high 16 bits are set. Signed-off-by: Li Zhang ---

Re: [dpdk-dev] [PATCH] crypto/scheduler: rename slave to worker

2020-09-27 Thread Ruifeng Wang
> -Original Message- > From: dev On Behalf Of Adam Dybkowski > Sent: Wednesday, August 26, 2020 11:34 PM > To: dev@dpdk.org; fiona.tr...@intel.com; akhil.go...@nxp.com; > roy.fan.zh...@intel.com > Cc: Adam Dybkowski > Subject: [dpdk-dev] [PATCH] crypto/scheduler: rename slave to worker >

[dpdk-dev] [PATCH v2 3/4] raw/ifpga/base: cleanup ifpga raw devices when process quit

2020-09-27 Thread Tianfei zhang
From: Wei Huang Add function ifpga_rawdev_cleanup() to cleanup all ifpga raw devices and register it as RTE_FINI function to make it called after main(). Signed-off-by: Wei Huang Signed-off-by: Tianfei zhang --- drivers/raw/ifpga/ifpga_rawdev.c | 20 1 file changed, 20 in

[dpdk-dev] [PATCH v2 4/4] raw/ifpga/base: enhance driver reliability in multi-process

2020-09-27 Thread Tianfei zhang
From: Wei Huang Current hardware protection is based on pthread mutex which work just for situation of multi-thread in one process. In multi-process environment, hardware state machine would be corrupted by concurrent access, that means original pthread mutex mechanism need be enhanced. The majo

[dpdk-dev] [PATCH v2 2/4] raw/ifpga/base: free resources when destroying ifpga device

2020-09-27 Thread Tianfei zhang
From: Wei Huang Add two functions to complete the resources free work, one is ifpga_adapter_destroy(), the other is ifpga_bus_uinit(). Then call opae_adapter_destroy() in ifpga_rawdev_destroy(). Additional modifiction is removing opae_adapter_free() from ifpga_rawdev_destroy() because opae adapt

[dpdk-dev] [PATCH v2 0/4] raw/ifpga/base: An improvement for multi-process

2020-09-27 Thread Tianfei zhang
This patches set will improve the ifpga base driver reliability in multi-process environment. Main changes from v2: - Fix typo in some commit log. Patch #1: Fix a bug for register and unregister interrupt functions. Patch #2: Add two functions to free the resource when we destroy the opae adapter

[dpdk-dev] [PATCH v2 1/4] raw/ifpga/base: fix bug in IRQ functions

2020-09-27 Thread Tianfei zhang
From: Wei Huang Using a pointer instead of using a structure and point to ifpga_irq_handle[] in register and unregister interrupt functions. Treat positive return value of ifpga_unregister_msix_irq() as successful. Fixes: e0a1aafe ("raw/ifpga: introduce IRQ functions") Cc: sta...@dpdk.org Signe

[dpdk-dev] [PATCH] net/ice: support drop action for DCF switch

2020-09-27 Thread Simei Su
This patch adds drop action in DCF switch filter. Signed-off-by: Simei Su --- drivers/net/ice/ice_switch_filter.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/net/ice/ice_switch_filter.c b/drivers/net/ice/ice_switch_filter.c index 4dfeeef..8cba6eb 100644 --- a/drivers/net/ic

Re: [dpdk-dev] [PATCH 1/2] eal/windows: add pthread mutex lock

2020-09-27 Thread Suanming Mou
Hi Dmitry, > -Original Message- > From: Dmitry Kozlyuk > Sent: Sunday, September 27, 2020 11:57 PM > To: Suanming Mou > Cc: Narcisa Ana Maria Vasile ; Dmitry Malloy > ; Pallavi Kadam ; > dev@dpdk.org > Subject: Re: [PATCH 1/2] eal/windows: add pthread mutex lock > > Hi Suanming, > > Th

Re: [dpdk-dev] [PATCH v2 19/25] drivers/net: check process type in close operation

2020-09-27 Thread Xu, Rosen
Hi, > -Original Message- > From: Thomas Monjalon > Sent: Monday, September 28, 2020 7:43 > To: dev@dpdk.org > Cc: Yigit, Ferruh ; arybche...@solarflare.com; > Loftus, Ciara ; Zhang, Qi Z ; > Shepard Siegel ; Ed Czeck > ; John Miller ; > Steven Webster ; Matt Peters > ; Ajit Khaparde > ; S

Re: [dpdk-dev] [PATCH v6 0/2] update CPU flags for arm64 platform

2020-09-27 Thread Wei Hu (Xavier)
Friendly ping. On 2020/8/19 18:56, Wei Hu (Xavier) wrote: This series updates CPU flags for arm64 platform. Wei Hu (Xavier) (2): eal/arm64: update CPU flags test/cpuflag: add new flags for ARM64 platform app/test/test_cpuflags.c | 39 lib/librt

Re: [dpdk-dev] [PATCH v2 02/25] ethdev: allow drivers to return error on close

2020-09-27 Thread Xu, Rosen
Hi, > -Original Message- > From: Thomas Monjalon > Sent: Monday, September 28, 2020 7:42 > To: dev@dpdk.org > Cc: Yigit, Ferruh ; arybche...@solarflare.com; John > W. Linville ; Loftus, Ciara ; > Zhang, Qi Z ; Shepard Siegel > ; Ed Czeck ; > John Miller ; Igor Russkikh > ; Pavel Belous ;

Re: [dpdk-dev] [PATCH v2 18/25] drivers/net: accept removing device without any port

2020-09-27 Thread Xu, Rosen
Hi, > -Original Message- > From: Thomas Monjalon > Sent: Monday, September 28, 2020 7:43 > To: dev@dpdk.org > Cc: Yigit, Ferruh ; arybche...@solarflare.com; Xu, > Rosen ; Stephen Hemminger > ; K. Y. Srinivasan ; > Haiyang Zhang ; Long Li ; > Heinrich Kuhn ; Gagandeep Singh > ; Akhil Goyal

[dpdk-dev] [PATCH v2] eal: simplify exit functions

2020-09-27 Thread Thomas Monjalon
The option RTE_EAL_ALWAYS_PANIC_ON_ERROR was off by default, and not customizable with meson. It is completely removed. The function rte_dump_registers is a trace of the bare metal support era, and was not supported in userland. It is completely removed. Signed-off-by: Thomas Monjalon Acked-by:

Re: [dpdk-dev] [PATCH v2 19/25] drivers/net: check process type in close operation

2020-09-27 Thread Thomas Monjalon
> The secondary processes are not allowed to release shared resources. > Only process-private ressources should be freed in a secondary process. > Most of the time, there is no process-private ressource, > so the close operation is just forbidden in a secondary process. Missed a (double) typo in t

[dpdk-dev] [PATCH v2 22/25] app/testpmd: align behaviour of multi-port detach

2020-09-27 Thread Thomas Monjalon
A port can be closed in multiple situations: - close command calling close_port() -> rte_eth_dev_close() - exit calling close_port() -> rte_eth_dev_close() - hotplug calling close_port() -> rte_eth_dev_close() - hotplug calling detach_device() -> rte_dev_remove()

[dpdk-dev] [PATCH v2 25/25] ethdev: allow close function to return an error

2020-09-27 Thread Thomas Monjalon
The API function rte_eth_dev_close() was returning void. The return type is changed to int for notifying of errors. If an error happens during a close operation, the status of the port is undefined, a maximum of resources having been freed. Signed-off-by: Thomas Monjalon --- doc/guides/rel_note

[dpdk-dev] [PATCH v2 23/25] ethdev: remove forcing stopped state upon close

2020-09-27 Thread Thomas Monjalon
When closing a port, it is supposed to be already stopped, and marked as such with "dev_started" state zeroed. Resetting "dev_started" before calling the driver close operation was hiding the case of not properly stopped port being closed. The flag "dev_started" is not changed anymore in "rte_eth_

[dpdk-dev] [PATCH v2 24/25] ethdev: reset all when releasing a port

2020-09-27 Thread Thomas Monjalon
The function rte_eth_dev_release_port() was resetting partially the struct rte_eth_dev. The drivers were completing it with more pointers set to NULL in the close or remove operations. A full memset is done so most of those assignments become useless. Signed-off-by: Thomas Monjalon --- drivers/

[dpdk-dev] [PATCH v2 21/25] app/testpmd: reset port status on close notification

2020-09-27 Thread Thomas Monjalon
Since rte_eth_dev_release_port() is called on all port close operations, the event RTE_ETH_EVENT_DESTROY can be reliably used for resetting the port status on the application side. The intermediate state RTE_PORT_HANDLING is removed in close_port() because a port can also be closed by a PMD in a d

[dpdk-dev] [PATCH v2 20/25] drivers/net: remove redundant MAC addresses freeing

2020-09-27 Thread Thomas Monjalon
The MAC addresses array is already freed by rte_eth_dev_release_port(). The redundant freeing can be removed from the PMD port closing functions. Signed-off-by: Thomas Monjalon Reviewed-by: Ferruh Yigit --- drivers/net/ark/ark_ethdev.c| 3 --- drivers/net/hinic/hinic_pmd_ethdev.c

[dpdk-dev] [PATCH v2 19/25] drivers/net: check process type in close operation

2020-09-27 Thread Thomas Monjalon
The secondary processes are not allowed to release shared resources. Only process-private ressources should be freed in a secondary process. Most of the time, there is no process-private ressource, so the close operation is just forbidden in a secondary process. After adding proper check in the po

[dpdk-dev] [PATCH v2 18/25] drivers/net: accept removing device without any port

2020-09-27 Thread Thomas Monjalon
The ports can be closed (i.e. completely released) before removing the whole device. Such case was wrongly considered an error by some drivers. If the device supports only one port, there is nothing much to free after the port is closed. Signed-off-by: Thomas Monjalon Reviewed-by: Ferruh Yigit

[dpdk-dev] [PATCH v2 17/25] ethdev: remove old close behaviour

2020-09-27 Thread Thomas Monjalon
The temporary flag RTE_ETH_DEV_CLOSE_REMOVE is removed. It was introduced in DPDK 18.11 in order to give time for PMDs to migrate. The old behaviour was to free only queues when closing a port. The new behaviour is calling rte_eth_dev_release_port() which does three more tasks: - trigger e

[dpdk-dev] [PATCH v2 16/25] net/tap: release port upon close

2020-09-27 Thread Thomas Monjalon
From: Yunjian Wang The flag RTE_ETH_DEV_CLOSE_REMOVE is set so all port resources can be freed by rte_eth_dev_close(). Freeing of private port resources is moved from the ".remove(device)" to the ".dev_close(port)" operation. Signed-off-by: Yunjian Wang Signed-off-by: Thomas Monjalon --- dri

[dpdk-dev] [PATCH v2 15/25] net/softnic: release port upon close

2020-09-27 Thread Thomas Monjalon
The flag RTE_ETH_DEV_CLOSE_REMOVE is set so all port resources can be freed by rte_eth_dev_close(). Freeing of private port resources is moved from the ".remove(device)" to the ".dev_close(port)" operation. Nothing is closed in a secondary process. Signed-off-by: Thomas Monjalon Acked-by: Crist

[dpdk-dev] [PATCH v2 14/25] net/ring: release port upon close

2020-09-27 Thread Thomas Monjalon
The flag RTE_ETH_DEV_CLOSE_REMOVE is set so all port resources can be freed by rte_eth_dev_close(). Freeing of private port resources is moved from the ".remove(device)" to the ".dev_close(port)" operation. Nothing is closed in a secondary process. Signed-off-by: Thomas Monjalon Acked-by: Bruce

[dpdk-dev] [PATCH v2 12/25] net/pcap: release port upon close

2020-09-27 Thread Thomas Monjalon
The flag RTE_ETH_DEV_CLOSE_REMOVE is set so all port resources can be freed by rte_eth_dev_close(). Freeing of private port resources is moved from the ".remove(device)" to the ".dev_close(port)" operation. Signed-off-by: Thomas Monjalon --- drivers/net/pcap/rte_eth_pcap.c | 29 ++--

[dpdk-dev] [PATCH v2 13/25] net/qede: release port upon close

2020-09-27 Thread Thomas Monjalon
From: Rasesh Mody Set RTE_ETH_DEV_CLOSE_REMOVE upon probe so all the private resources for the port can be freed by rte_eth_dev_close(). With this change the private port resources are released in the .dev_close callback. Signed-off-by: Rasesh Mody --- drivers/net/qede/qede_ethdev.c | 25 +

[dpdk-dev] [PATCH v2 10/25] net/null: release port upon close

2020-09-27 Thread Thomas Monjalon
The flag RTE_ETH_DEV_CLOSE_REMOVE is set so all port resources can be freed by rte_eth_dev_close(). Signed-off-by: Thomas Monjalon --- drivers/net/null/rte_eth_null.c | 27 +++ 1 file changed, 19 insertions(+), 8 deletions(-) diff --git a/drivers/net/null/rte_eth_null.c

[dpdk-dev] [PATCH v2 11/25] net/octeontx: release port upon close

2020-09-27 Thread Thomas Monjalon
The flag RTE_ETH_DEV_CLOSE_REMOVE is set so all port resources can be freed by rte_eth_dev_close(). The callback ".dev_close(port)" is called also from the ".remove(device)" operation. Signed-off-by: Thomas Monjalon --- drivers/net/octeontx/octeontx_ethdev.c | 11 +++ 1 file changed, 3

[dpdk-dev] [PATCH v2 09/25] net/mlx4: release port upon close

2020-09-27 Thread Thomas Monjalon
The flag RTE_ETH_DEV_CLOSE_REMOVE is set so all port resources can be freed by rte_eth_dev_close(). Signed-off-by: Thomas Monjalon --- drivers/net/mlx4/mlx4.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/mlx4/mlx4.c b/drivers/net/mlx4/mlx4.c index df59314b66..ad7c805d67 100

[dpdk-dev] [PATCH v2 08/25] net/failsafe: release port upon close

2020-09-27 Thread Thomas Monjalon
The flag RTE_ETH_DEV_CLOSE_REMOVE is set so all port resources can be freed by rte_eth_dev_close(). Freeing of private port resources is moved from the ".remove(device)" to the ".dev_close(port)" operation. Signed-off-by: Thomas Monjalon --- drivers/net/failsafe/failsafe.c | 25 ++--

[dpdk-dev] [PATCH v2 07/25] net/bonding: release port upon close

2020-09-27 Thread Thomas Monjalon
The flag RTE_ETH_DEV_CLOSE_REMOVE is set so all port resources can be freed by rte_eth_dev_close(). Freeing of private port resources is moved from the ".remove(device)" to the ".dev_close(port)" operation. Signed-off-by: Thomas Monjalon --- drivers/net/bonding/rte_eth_bond_pmd.c | 34 +

[dpdk-dev] [PATCH v2 06/25] net/bnx2x: release port upon close

2020-09-27 Thread Thomas Monjalon
From: Rasesh Mody Set RTE_ETH_DEV_CLOSE_REMOVE upon probe so all the private resources for the port can be freed by rte_eth_dev_close(). With this change the private port resources are released in the .dev_close callback. Signed-off-by: Rasesh Mody --- drivers/net/bnx2x/bnx2x_ethdev.c | 17 +++

[dpdk-dev] [PATCH v2 05/25] net/axgbe: release port upon close

2020-09-27 Thread Thomas Monjalon
The flag RTE_ETH_DEV_CLOSE_REMOVE is set so all port resources can be freed by rte_eth_dev_close(). Freeing of private port resources is moved from the ".remove(device)" to the ".dev_close(port)" operation. The ".dev_close" callback is also called as part of the ".remove" one. Signed-off-by: Thom

[dpdk-dev] [PATCH v2 04/25] net/atlantic: release port upon close

2020-09-27 Thread Thomas Monjalon
The flag RTE_ETH_DEV_CLOSE_REMOVE is set so all port resources can be freed by rte_eth_dev_close(). Freeing of private port resources is moved from the ".remove(device)" to the ".dev_close(port)" operation. Signed-off-by: Thomas Monjalon Acked-by: Igor Russkikh --- drivers/net/atlantic/atl_eth

[dpdk-dev] [PATCH v2 02/25] ethdev: allow drivers to return error on close

2020-09-27 Thread Thomas Monjalon
The device operation .dev_close was returning void. This driver interface is changed to return an int. Note that the API rte_eth_dev_close() is still returning void, although a deprecation notice is pending to change it as well. Signed-off-by: Thomas Monjalon --- app/test/virtual_pmd.c

[dpdk-dev] [PATCH v2 03/25] net/af_packet: release port upon close

2020-09-27 Thread Thomas Monjalon
The flag RTE_ETH_DEV_CLOSE_REMOVE is set so all port resources can be freed by rte_eth_dev_close(). Freeing of private port resources is moved from the ".remove(device)" to the ".dev_close(port)" operation. Signed-off-by: Thomas Monjalon Reviewed-by: Ferruh Yigit --- drivers/net/af_packet/rte_

[dpdk-dev] [PATCH v2 00/25] cleanup ethdev close operation

2020-09-27 Thread Thomas Monjalon
This is the end of a process started two years ago, to have a close which reliably releases an ethdev port without the need of removing the device (which can have more ports). Unfortunately, some drivers might be broken because did not follow the migration recommendations. We cannot wait more, thi

[dpdk-dev] [PATCH v2 01/25] ethdev: reset device and interrupt pointers on release

2020-09-27 Thread Thomas Monjalon
The pointers .device and .intr_handle were already reset by the helper rte_eth_dev_pci_generic_remove(). It is now made part of rte_eth_dev_release_port(). It makes rte_eth_dev_pci_release() meaningless, so it is replaced with a call to rte_eth_dev_release_port(). Signed-off-by: Thomas Monjalon

Re: [dpdk-dev] [PATCH v4 1/8] test/distributor: fix deadlock with freezed worker

2020-09-27 Thread Honnappa Nagarahalli
Hi Lukasz, Few comments inline > > The sanity test with worker shutdown delegates all bufs to be processed by a > single lcore worker, then it freezes one of the lcore workers and continues to > send more bufs. The designated core to freeze (core with id == 0 in the existing code) gets

Re: [dpdk-dev] [PATCH v5 3/3] pmdinfogen: remove C implementation

2020-09-27 Thread Thomas Monjalon
> Delete the files no longer used in build process. Keep Neil Horman > maintainer of the entire "Driver information" section, only adjust > paths. Dmitry, don't you think you should be co-maintainer?

[dpdk-dev] [PATCH] net/bnx2x: release port upon close

2020-09-27 Thread Rasesh Mody
Set RTE_ETH_DEV_CLOSE_REMOVE upon probe so all the private resources for the port can be freed by rte_eth_dev_close(). With this change the private port resources are released in the .dev_close callback. Signed-off-by: Rasesh Mody --- drivers/net/bnx2x/bnx2x_ethdev.c | 17 +++-- 1 fi

[dpdk-dev] [PATCH] net/qede: release port upon close

2020-09-27 Thread Rasesh Mody
Set RTE_ETH_DEV_CLOSE_REMOVE upon probe so all the private resources for the port can be freed by rte_eth_dev_close(). With this change the private port resources are released in the .dev_close callback. Signed-off-by: Rasesh Mody --- drivers/net/qede/qede_ethdev.c | 25 +

Re: [dpdk-dev] [PATCH v5 1/3] pmdinfogen: add Python implementation

2020-09-27 Thread Stephen Hemminger
On Mon, 28 Sep 2020 00:47:30 +0300 Dmitry Kozlyuk wrote: > Using a high-level, interpreted language simplifies maintenance and > build process. Furthermore, ELF handling is delegated to pyelftools > package. Original logic is kept, the copyright recognizes that. > > Signed-off-by: Dmitry Kozlyuk

[dpdk-dev] [PATCH v5 2/3] build: use Python pmdinfogen

2020-09-27 Thread Dmitry Kozlyuk
Like for other build scripts, use Python interpreter to run pmdinfogen. Adjust wrapper script accordingly and also don't suppress stderr from ar and pmdinfogen. Add python3-pyelftools to CI configuration. The package is available on all major distributions. FreeBSD has no system requirements secti

[dpdk-dev] [PATCH v5 3/3] pmdinfogen: remove C implementation

2020-09-27 Thread Dmitry Kozlyuk
Delete the files no longer used in build process. Keep Neil Horman maintainer of the entire "Driver information" section, only adjust paths. Signed-off-by: Dmitry Kozlyuk --- MAINTAINERS| 2 +- buildtools/pmdinfogen/meson.build | 14 - buildtools/pmdinfogen/pmdinfoge

[dpdk-dev] [PATCH v5 1/3] pmdinfogen: add Python implementation

2020-09-27 Thread Dmitry Kozlyuk
Using a high-level, interpreted language simplifies maintenance and build process. Furthermore, ELF handling is delegated to pyelftools package. Original logic is kept, the copyright recognizes that. Signed-off-by: Dmitry Kozlyuk --- buildtools/pmdinfogen.py | 188 +++

[dpdk-dev] [PATCH v5 0/3] pmdinfogen: rewrite in Python

2020-09-27 Thread Dmitry Kozlyuk
This patchset implements existing pmdinfogen logic in Python, replaces and removes the old code. The goals of rewriting are: * easier maintenance by using a more high-level language, * simpler build process without host application and libelf. Travis CI script is adjusted to install python3-pyelf

Re: [dpdk-dev] [PATCH 1/2] eal/windows: add pthread mutex lock

2020-09-27 Thread Dmitry Kozlyuk
Hi Suanming, There's a remark in patch 2/2 and cover letter: > If no lock contention > with the added rte flow level mutex, the mutex only does the atomic > increasing in pthread_mutex_lock() and decreasing in > pthread_mutex_unlock(). No futex() syscall will be involved. Is this property import

Re: [dpdk-dev] [PATCH 2/2] net/octeontx: fix Tx xmit command preparation

2020-09-27 Thread Jerin Jacob
On Wed, Jul 29, 2020 at 12:14 AM wrote: > > From: Pavan Nikhilesh > > When building send command for a given descriptor it expects > it to contain the AURA identifier of the pool that it belongs > to rather than the pool identifier itself. > > Fixes: 7f4116bdbb1c ("net/octeontx: add framework for

[dpdk-dev] [PATCH v3 2/2] net/iavf: enable large VF configuration

2020-09-27 Thread Ting Xu
Add support to negotiate large VF capability, configure VSI queues, enable/disable queues and IRQ mapping for large VF. Use new virtchnl opcodes and structures to support max 256 queue pairs. Request additional queues from PF first if current allocated queues are not enough. Query max RSS queue reg

[dpdk-dev] [PATCH v3 0/2] enable large VF configuration

2020-09-27 Thread Ting Xu
This patchset supports to configure up to 256 queue pairs per VF. If large VF is supported after capability negotiation, VF will request queues from PF as needed. New virtual channel opcodes and structures are used to indicate 256 queues, so VF is designed to handle the new function of configure VS

[dpdk-dev] [PATCH v3 1/2] net/iavf: add IAVF request queues function

2020-09-27 Thread Ting Xu
Add new virtchnl function to request additional queues from PF. Current default queue pairs number when creating a VF is 16. In order to support up to 256 queue pairs, enable this request queues function. Since request queues command may return event message, modify function iavf_read_msg_from_pf t

Re: [dpdk-dev] [PATCH 0/2] add anti replay support in OCTEON TX2 security

2020-09-27 Thread Jerin Jacob
On Fri, Sep 18, 2020 at 10:01 AM Anoob Joseph wrote: > > > > > Support for anti replay is added in OCTEON TX2 security PMD. > > The functionality has been tested with ipsec-secgw application running in > > inline protocol offload mode. > > > > Ankur Dwivedi (2): > > net/octeontx2: add anti repla

Re: [dpdk-dev] [PATCH v2 3/3] event/octeontx2: add crypto adapter datapath

2020-09-27 Thread Jerin Jacob
On Thu, Sep 17, 2020 at 10:47 AM Ankur Dwivedi wrote: > > In the op new mode of crypto adapter, the completed crypto operation > is submitted to the event device by the OCTEON TX2 crypto PMD. > During event device dequeue the result of crypto operation is checked. > > Signed-off-by: Ankur Dwivedi

Re: [dpdk-dev] [PATCH v6 1/6] drivers: add generic API to find PCI extended cap

2020-09-27 Thread Jerin Jacob
On Fri, Sep 25, 2020 at 5:26 PM Manish Chopra wrote: > > By adding generic API, this patch removes individual > functions/defines implemented by drivers to find extended > PCI capabilities. > > Signed-off-by: Manish Chopra > Signed-off-by: Igor Russkikh > Reviewed-by: Gaetan Rivet Reviewed-by:

Re: [dpdk-dev] [PATCH] pci: support both PIO and MMIO BAR for legacy virtio on x86

2020-09-27 Thread 谢华伟(此时此刻)
On 2020/9/25 2:02, Ferruh Yigit wrote: On 9/15/2020 4:21 PM, 谢华伟(此时此刻) wrote: Hi Ferruh: Legacy virtio only supports PIO BAR resource. As we need to create lots of virtio devices and PIO resource on x86 is very limited, we expose MMIO BAR. Kernel support both PIO and MMIO BAR for legacy virt

[dpdk-dev] [PATCH 1/2] eal/windows: add pthread mutex lock

2020-09-27 Thread Suanming Mou
Add pthread mutex lock as it is needed for the thread safe rte flow functions. Signed-off-by: Suanming Mou --- lib/librte_eal/windows/include/pthread.h | 46 1 file changed, 46 insertions(+) diff --git a/lib/librte_eal/windows/include/pthread.h b/lib/librte_eal

[dpdk-dev] [PATCH 2/2] ethdev: make rte flow API thread safe

2020-09-27 Thread Suanming Mou
Currently, the rte flow functions are not defined as thread safety. DPDK applications either call the functions in single thread or add locks around the functions for the critical section. For PMDs support the flow operations thread safe natively, the redundant protection in application hurts the

[dpdk-dev] [PATCH 0/2] ethdev: make rte flow API thread safe

2020-09-27 Thread Suanming Mou
Currently, the rte flow functions are not defined as thread safety. DPDK applications either call the functions in single thread or add locks around the functions for the critical section. For PMDs support the flow operations thread safe natively, the redundant protection in application hurts the

[dpdk-dev] [PATCH 8/8] net/iavf: support check DD bit of a RX descriptor

2020-09-27 Thread Robin Zhang
Add implementation of inline API rx_descriptor_done in iavf PMD. Signed-off-by: Robin Zhang --- drivers/net/iavf/iavf_ethdev.c | 1 + drivers/net/iavf/iavf_rxtx.c | 26 ++ drivers/net/iavf/iavf_rxtx.h | 1 + 3 files changed, 28 insertions(+) diff --git a/drivers/ne

[dpdk-dev] [PATCH 5/8] net/iavf: add workaround promiscuous disable

2020-09-27 Thread Robin Zhang
In scenario of Kernel Driver runs on PF and PMD runs on VF, PMD exit doesn't disable promiscuous mode, this will cause vlan filter set by Kernel Driver will not take effect. This patch will fix it, add promiscuous disable at device disable. Signed-off-by: Robin Zhang --- drivers/net/iavf/iavf_e

[dpdk-dev] [PATCH 7/8] net/iavf: add extended stats

2020-09-27 Thread Robin Zhang
Add implementation of xstats() functions in iavf PMD. Signed-off-by: Robin Zhang --- drivers/net/iavf/iavf_ethdev.c | 81 ++ 1 file changed, 81 insertions(+) diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c index 5b3c68f2e..836c09f58 1

[dpdk-dev] [PATCH 4/8] net/iavf: optimize promiscuous ops

2020-09-27 Thread Robin Zhang
This patch is to improve efficiency and eliminate code redundancy of promiscuous ops. Signed-off-by: Robin Zhang --- drivers/net/iavf/iavf_ethdev.c | 49 ++ drivers/net/iavf/iavf_vchnl.c | 13 +++-- 2 files changed, 19 insertions(+), 43 deletions(-) diff --g

[dpdk-dev] [PATCH 6/8] net/iavf: cleanup Tx buffers

2020-09-27 Thread Robin Zhang
Add support to the iavf driver for the API rte_eth_tx_done_cleanup to force free consumed buffers on Tx ring. Signed-off-by: Robin Zhang --- drivers/net/iavf/iavf_ethdev.c | 1 + drivers/net/iavf/iavf_rxtx.c | 68 +- drivers/net/iavf/iavf_rxtx.h | 1 + 3 fil

[dpdk-dev] [PATCH 3/8] net/iavf: re-program promiscuous mode on VF interface

2020-09-27 Thread Robin Zhang
During a kernel PF reset, this event is propagated to the VF. The DPDK VF PMD will execute the reset task before the PF is done with his. This results in the admin queue message not being responded to leaving the port in "promiscuous" mode. This patch makes sure the promiscuous mode is configured

[dpdk-dev] [PATCH 2/8] net/iavf: set min and max MTU for VF

2020-09-27 Thread Robin Zhang
This commit sets the min and max supported MTU values for iavf VF devices via the iavf_dev_info_get() function. Min MTU supported is set to RTE_ETHER_MIN_MTU and max MTU is calculated as the max packet length supported minus the transport overhead. Signed-off-by: Robin Zhang --- drivers/net/iavf

[dpdk-dev] [PATCH 1/8] net/iavf: use link status helper functions

2020-09-27 Thread Robin Zhang
Use new rte_eth_linkstatus_get/set helper functions to handle link status update. Signed-off-by: Robin Zhang --- drivers/net/iavf/iavf_ethdev.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c index 440da7d7

[dpdk-dev] [PATCH 0/8] feature porting from i40evf to iavf

2020-09-27 Thread Robin Zhang
This patch set port some features of i40evf to iavf. Robin Zhang (8): net/iavf: use link status helper functions net/iavf: set min and max MTU for VF net/iavf: re-program promiscuous mode on VF interface net/iavf: optimize promiscuous ops net/iavf: add workaround promiscuous disable ne

Re: [dpdk-dev] [PATCH V13 0/3] add FEC support

2020-09-27 Thread Min Hu (Connor)
Hello, Are there any suggustions for this set patches ? 在 2020/9/25 16:39, Min Hu (Connor) 写道: This series add FEC support for ethdev. Min Hu (Connor) (3): ethdev: introduce FEC API net/hns3: support FEC app/testpmd: add FEC command app/test-pmd/cmdline.c