[dpdk-dev] unable to bind to vfio-pci

I have been trying to bind to vfio-pci using usertools/dpdk-devbind.py but am unable to do so. The reason behind this is that I am unable to write in /sys/bus/pci/drivers/vfio-pci/bind. Upon searching solutions I tried a couple of things such as setting iommu=pt and intel_iommu=on and ensured vt-d

Re: [dpdk-dev] [PATCH v2 1/4] ethdev: allow negative values in flow rule types

On 9/16/20 8:21 PM, Gregory Etelson wrote: > From: Gregory Etelson > Sent: Tuesday, September 15, 2020 13:27 > To: Andrew Rybchenko ; Ajit Khaparde > > Cc: dpdk-dev ; Matan Azrad ; Raslan Darawsheh > ; Ori Kam ; Gregory Etelson > ; Ori Kam ; NBU-Contact-Thomas > Monjalon ; Ferruh Yigit > Sub

[dpdk-dev] [PATCH v2 03/17] net/sfc/base: decorate libefx internal extern functions

The decorator may be used in the future to instruct linker to put it into dedicated sections or hide. Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton Reviewed-by: Mark Spender Reviewed-by: Richard Houldsworth --- drivers/net/sfc/base/ef10_impl.h | 194 +++

[dpdk-dev] [PATCH v2 05/17] net/sfc: introduce common driver library

Move libefx (base driver) into common driver. Prepare to add vDPA driver which will use the common driver as well. Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- MAINTAINERS | 1 + drivers/common/meson.build| 2 +- .../{n

[dpdk-dev] [PATCH v2 15/17] net/sfc: add MCDI callback to poll management event queue

Management event queue polling is required in the case of MCDI proxy authentication (client driver code). Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- drivers/net/sfc/sfc_mcdi.c | 14 -- drivers/net/sfc/sfc_mcdi.h | 3 +++ 2 files changed, 15 insertions(+), 2 delet

[dpdk-dev] [PATCH v2 10/17] net/sfc: use own logging helper macros

Network driver logging macros depends on sfc_adapter which is specific to the driver and cannot be used in common code. Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- drivers/net/sfc/sfc.h| 2 + drivers/net/sfc/sfc_ethdev.c | 13 ++ drivers/net/sfc/sfc_log.h| 12

[dpdk-dev] [PATCH v2 17/17] net/sfc: move MCDI helpers to common driver

These helper will be reused by other libefx consumers, e.g. vDPA driver. Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- drivers/common/sfc_efx/meson.build| 1 + .../sfc_efx/rte_common_sfc_efx_version.map| 3 + drivers/common/sfc_efx/sfc_efx_mcdi.c | 34

[dpdk-dev] [PATCH v2 13/17] net/sfc: add MCDI callbacks to allocate/free DMA memory

Net driver should use rte_eth_dma_zone_reserve(), but it is ethdev specific API which is not available for vDPA. Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- drivers/net/sfc/sfc_mcdi.c | 46 +++--- drivers/net/sfc/sfc_mcdi.h | 12 ++ 2 fi

[dpdk-dev] [PATCH v2 01/17] net/sfc/base: add missing extern storage-class specifiers

libefx coding standard requires it and the specifier is used for almost all functions in the header file. Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton Reviewed-by: Richard Houldsworth --- drivers/net/sfc/base/ef10_impl.h | 56 drivers/net/sfc/base/

[dpdk-dev] [PATCH v2 16/17] net/sfc: use MCDI control structure as libefx ops context

Now MCDI helpers interface is independent from network driver and may be moved into common driver. Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- drivers/net/sfc/sfc_mcdi.c | 47 +++--- 1 file changed, 19 insertions(+), 28 deletions(-) diff --git

[dpdk-dev] [PATCH v2 14/17] net/sfc: add MCDI callback to schedule restart

MC reboot handling is driver specific. Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- drivers/net/sfc/sfc_mcdi.c | 15 +-- drivers/net/sfc/sfc_mcdi.h | 3 +++ 2 files changed, 16 insertions(+), 2 deletions(-) diff --git a/drivers/net/sfc/sfc_mcdi.c b/drivers/net/sfc

[dpdk-dev] [PATCH v2 11/17] net/sfc: avoid usage of NIC pointer from adapter context

Prepare to avoid usage of the adapter context in common MCDI helpers. Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- drivers/net/sfc/sfc_mcdi.c | 19 +++ drivers/net/sfc/sfc_mcdi.h | 1 + 2 files changed, 12 insertions(+), 8 deletions(-) diff --git a/drivers/net

[dpdk-dev] [PATCH v2 08/17] net/sfc: make MCDI logging helper macros local

Prepare to move MCDI helpers to drivers/common. Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- drivers/net/sfc/sfc_log.h | 11 --- drivers/net/sfc/sfc_mcdi.c | 21 - 2 files changed, 16 insertions(+), 16 deletions(-) diff --git a/drivers/net/sfc/sfc_

[dpdk-dev] [PATCH v2 06/17] net/sfc: add dedicated header file with MCDI interface

MCDI helpers will be shared by net and vDPA drivers. Prepare to move it to common/sfc_efx. Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- drivers/net/sfc/sfc.h | 23 +--- drivers/net/sfc/sfc_mcdi.c | 1 + drivers/net/sfc/sfc_mcdi.h | 54 +

[dpdk-dev] [PATCH v2 02/17] net/sfc/base: decorate libefx API functions

The decorators will be used in the future to mark libefx API functions as __rte_internal. Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton Reviewed-by: Richard Houldsworth --- drivers/net/sfc/base/efx.h | 251 +++ drivers/net/sfc/base/efx_check.h |

[dpdk-dev] [PATCH v2 07/17] net/sfc: move MCDI helper interface to dedicated namespace

MCDI helpers will be moved to common/sfc_efx and it is better to do dummy renamings first before non-trivial changes. Existing functionality should be split into common and network driver specific parts. Prepare to do it. Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- drivers/ne

[dpdk-dev] [PATCH v2 12/17] net/sfc: avoid panic in the case of MCDI timeout

Implement dummy MCDI timeout handling which simply rejects further MCDI requests. Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- drivers/net/sfc/sfc_mcdi.c | 15 +-- drivers/net/sfc/sfc_mcdi.h | 1 + 2 files changed, 14 insertions(+), 2 deletions(-) diff --git a/dri

[dpdk-dev] [PATCH v2 09/17] net/sfc: start to make MCDI helpers interface shareable

sfc_adapter is network driver specific structure which finally should not be used in shared MCDI helpers interface. Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- drivers/net/sfc/sfc_mcdi.c | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/drivers/

[dpdk-dev] [PATCH v2 04/17] net/sfc: include header with debug helpers directly

Avoid build failures on further restructuring. Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- drivers/net/sfc/sfc.c | 1 + drivers/net/sfc/sfc.h | 1 + drivers/net/sfc/sfc_dp_tx.h| 1 + drivers/net/sfc/sfc_ef10.h | 2 ++ drivers/net/sfc/s

[dpdk-dev] [PATCH v2 00/17] net/sfc: factor out common driver library

Network and vDPA drivers share libefx. So, libefx should be moved to common drivers. DPDK adaptation of the MCDI interface may be shared as well. The new common driver name is sfc_efx since it a new home of libefx base driver. sfc_ prefix is used to make it clear that it is related to net/sfc (an

Re: [dpdk-dev] [PATCH 00/14] net/sfc: factor out common driver library

On 9/9/20 5:32 PM, Ferruh Yigit wrote: > On 9/8/2020 10:14 AM, Andrew Rybchenko wrote: >> Network and vDPA drivers share libefx. So, libefx should be moved >> to common drivers. >> >> DPDK adaptation of the MCDI interface may be shared as well. >> >> The new common driver name is sfc_efx since it a

Re: [dpdk-dev] [PATCH] net/ice: add support for new device type

> -Original Message- > From: Yang, Qiming > Sent: Thursday, September 17, 2020 1:28 PM > To: Zhang, Qi Z > Cc: Zhang, Helin ; dev@dpdk.org > Subject: RE: [PATCH] net/ice: add support for new device type > > Acked-by: Qiming Yang > > > -Original Message- > > From: Zhang, Qi Z

[dpdk-dev] [PATCH 20/20] net/ena: expose ENI stats as additional xstats

New HAL allows driver to read extra ENI stats. Exact meaning of each of them can be found in base/ena_defs/ena_admin_defs.h file and structure ena_admin_eni_stats. The ena_eni_stats structure is exactly the same as ena_admin_eni_stats, but it was required to be added for compatibility with xstats

[dpdk-dev] [PATCH 16/20] net/ena/base: convert values to u32 before shifting

When filling out meta descriptor, all values should be converted to the desired type (u32 in case of the meta descriptor) to prevent losing the data. For example, io_sq->phase is of type u8. If ENA_ETH_IO_TX_META_DESC_PHASE_SHIFT would be greater then 8, all data would be lost. Signed-off-by: Mic

[dpdk-dev] [PATCH 17/20] net/ena/base: simplify loop copying Rx descs

Checking for the cdesc not being NULL doesn't have any sense if the idx argument is not 0, so it can be skipped, as the error won't be detected anyway. To simplify that, only the 'i' value is being verified and the code is breaking from the infinite loop in case when all descriptors were copied in

[dpdk-dev] [PATCH 19/20] net/ena: lock dynamic usages of the admin queue

There are some cases, where the admin queue commands after the configuration phase finished - for example, the application could ask for the driver statitics from multiple cores at once. As by the design, the admin queue is not multithread safe, the spinlock was added to protect all usages of the

[dpdk-dev] [PATCH 18/20] net/ena/base: update generation date and commit

The current ena_com version was generated on 26.04.2020. Signed-off-by: Michal Krawczyk Reviewed-by: Igor Chauskin Reviewed-by: Guy Tzalik --- drivers/net/ena/base/ena_defs/ena_gen_info.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ena/base/ena_defs/ena_

[dpdk-dev] [PATCH 14/20] net/ena/base: store admin stats as u64

To minimize chance of integer overflow, the type of admin statistics was changed from u32 to u64. Signed-off-by: Michal Krawczyk Reviewed-by: Igor Chauskin Reviewed-by: Guy Tzalik --- drivers/net/ena/base/ena_com.h | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/

[dpdk-dev] [PATCH 15/20] net/ena/base: add check for meta desc being NULL

Static code analysis showed up, that it's possible for meta_desc being NULL. To avoid dereference of the NULL pointer, extra check was added if the pointer is in fact valid. Signed-off-by: Michal Krawczyk Reviewed-by: Igor Chauskin Reviewed-by: Guy Tzalik --- drivers/net/ena/base/ena_eth_com.c

[dpdk-dev] [PATCH 11/20] net/ena/base: check for RSS key configuration support

Setting RSS hash function could not be supported by the device. In that situation there is no need to fill in default hash key or even allocate hash key. Signed-off-by: Michal Krawczyk Reviewed-by: Igor Chauskin Reviewed-by: Guy Tzalik --- drivers/net/ena/base/ena_com.c | 13 ++

[dpdk-dev] [PATCH 13/20] net/ena/base: add missing unlikely

To align the error checking code with other parts of the ena_com, the conditional check is being tested for the error was wrapped inside unlikely(). Signed-off-by: Michal Krawczyk Reviewed-by: Igor Chauskin Reviewed-by: Guy Tzalik --- drivers/net/ena/base/ena_com.c | 2 +- 1 file changed, 1 in

[dpdk-dev] [PATCH 10/20] net/ena/base: do not use hardcoded RSS key buffer size

It's well defined how the RSS key buffer looks from the device perspective, so the constant calue should be used instead of magic number. Also it doesn't has to be calculated dynamically. Signed-off-by: Michal Krawczyk Reviewed-by: Igor Chauskin Reviewed-by: Guy Tzalik --- drivers/net/ena/base

[dpdk-dev] [PATCH 12/20] net/ena/base: minor style adjustments

* Function argument style improvement (space after *) * Align indentation of the define * Typo fix in the documentation * Remove extra empty line after license (aligned with other files) * Extra alignment of one line was fixed Signed-off-by: Michal Krawczyk Reviewed-by: Igor Chauskin Reviewed-by

[dpdk-dev] [PATCH 08/20] net/ena/base: add ENI stats

The Elastic Netfwork Interface (ENI) stats can be acquired from the HW. They can provide advanced values which can be further used by the application for better flow management. It isn't available to the DPDK application, yet. The PMD must expose them directly. Signed-off-by: Michal Krawczyk Re

[dpdk-dev] [PATCH 09/20] net/ena/base: split RSS function and hash getters

There is no need to keep single function for both hash function and the key. If the caller want's to get only single value, then it had to pass NULL as one of the values, making the API harder to use. Except reading functions from the device, one can also use function ena_com_get_current_hash_func

[dpdk-dev] [PATCH 06/20] net/ena/base: remove MMIOWB_NOT_DEFINED ifdef

As there is no replacment for mmiowb() and there is no need to use both versions in the DPDK, this ifdef was simply removed. Signed-off-by: Michal Krawczyk Reviewed-by: Igor Chauskin Reviewed-by: Guy Tzalik --- drivers/net/ena/base/ena_com.c | 2 -- 1 file changed, 2 deletions(-) diff --git a

[dpdk-dev] [PATCH 07/20] net/ena/base: rework setup of accelerated LLQ mode

The purpose of this change is general code simplification and type safety improvement for the logical values. Signed-off-by: Michal Krawczyk Reviewed-by: Igor Chauskin Reviewed-by: Guy Tzalik --- drivers/net/ena/base/ena_com.c | 21 ++--- drivers/net/ena/base/ena_eth_com.h

[dpdk-dev] [PATCH 01/20] net/ena/base: use min/max macros with type conversion

Usage of RTE_MIN(MAX) in ENA_MIN32, ENA_MIN16, ENA_MIN8 (and same for the MAX), was not enough, as the HAL code is assuming that those macros will conver both arguments to the specified uintX_t type. As RTE_MIN(MAX) is using 'typeof' operator, the behavior won't be the same, especially if argument

[dpdk-dev] [PATCH 04/20] net/ena/base: exponential delay in polling functions

Instead of the fixes, 5 ms delay in the polling functions, use values into given range (by default from 100 us 5000 us) and increase them exponentially each time, the operation isn't finished. This change can improve responsiveness of the driver for the fast operations. Signed-off-by: Michal Kraw

[dpdk-dev] [PATCH 05/20] net/ena/base: fix release of wait event

The wait event is being accessed without making sure it the completion context exists. The check for that is just below, so it could be used for releasing wait even safely. Fixes: 3adcba9a8987 ("net/ena: update HAL to the newer version") Cc: sta...@dpdk.org Signed-off-by: Michal Krawczyk Reviewe

[dpdk-dev] [PATCH 03/20] net/ena/base: support 'resource busy' admin status

The admin command could return ENA_ADMIN_RESOURCE_BUSY status, which is meaning that currently the given resource cannot be used. However, the request can be repeted, so it's being converted to the ENA_COM_TRY_AGAIN error code. Signed-off-by: Michal Krawczyk Reviewed-by: Igor Chauskin Reviewed-

[dpdk-dev] [PATCH 02/20] net/ena/base: specify operations of rte_delay

ENA_MSLEEP() and ENA_UDELAY() were expecting different behavior - the first one is expecting driver to sleep, while the other, to busy wait. For both cases, the rte_delay_(u|m)s() function was used, which could be either sleep or block, depending on the configuration. To make the macros valid, th

[dpdk-dev] [PATCH 00/20] Upgrade HAL and add ENI metrics support

Hi, this patchset contains upgrade of the of the HAL, which, beside some fixes, also adds possibility for reading ENI metrics from the device. Those are further exposed to the DPDK applicaiton using xstats. As it's an extra call to the admin queue during a PMD runtime, for multithread safet the

Re: [dpdk-dev] [PATCH] net/ice: add support for new device type

Acked-by: Qiming Yang > -Original Message- > From: Zhang, Qi Z > Sent: Thursday, September 17, 2020 13:18 > To: Yang, Qiming > Cc: Zhang, Helin ; dev@dpdk.org; Zhang, Qi Z > > Subject: [PATCH] net/ice: add support for new device type > > Added support for below new devices: > > ICE_D

Re: [dpdk-dev] [PATCH v4] net/iavf: reject floating RSS attribute

> -Original Message- > From: Guo, Junfeng > Sent: Thursday, September 17, 2020 12:35 PM > To: Zhang, Qi Z ; Xing, Beilei > Cc: dev@dpdk.org; Guo, Jia > Subject: RE: [PATCH v4] net/iavf: reject floating RSS attribute > > > -Original Message- > > From: Zhang, Qi Z > > Sent: We

[dpdk-dev] [PATCH v2 0/3] event/octeontx2: add support for event crypto adapter

This patch series adds support for event crypto adapter in op new mode in the OCTEON TX2 event PMD. The functionality has been verified with event crypto adapter test application. Build with meson and ninja is supported. v2: * In the "event/octeontx2: add crypto adapter datapath" patch, right sh

[dpdk-dev] [PATCH v2 2/3] event/octeontx2: add crypto adapter framework

The crypto adapter callback functions and associated data structures are added. Signed-off-by: Ankur Dwivedi --- drivers/crypto/octeontx2/meson.build | 4 +- .../crypto/octeontx2/otx2_crypto_adapter.c| 77 +++ .../crypto/octeontx2/otx2_crypto_adapter.h| 21 +

[dpdk-dev] [PATCH v2 3/3] event/octeontx2: add crypto adapter datapath

In the op new mode of crypto adapter, the completed crypto operation is submitted to the event device by the OCTEON TX2 crypto PMD. During event device dequeue the result of crypto operation is checked. Signed-off-by: Ankur Dwivedi --- drivers/common/cpt/cpt_common.h | 1 + driver

[dpdk-dev] [PATCH v2 1/3] crypto/octeontx2: move functions to helper file

Some functions are common across cryptodev pmd and the event crypto adapter. This patch moves them into a helper file. Signed-off-by: Ankur Dwivedi --- drivers/crypto/octeontx2/otx2_cryptodev_ops.c | 65 +--- .../octeontx2/otx2_cryptodev_ops_helper.h | 74 +++ 2 f

[dpdk-dev] [PATCH] net/ice: add support for new device type

Added support for below new devices: ICE_DEV_ID_E822L_BACKPLANE 0x1897 ICE_DEV_ID_E822L_SFP0x1898 ICE_DEV_ID_E822L_10G_BASE_T 0x1899 ICE_DEV_ID_E822L_SGMII 0x189A The patch also reordered items in pci_id_ice_map to align with ice_devids.h Signed-off-by: Qi Zhang --

[dpdk-dev] [PATCH 1/2] af_xdp: not return a negative value in af_xdp_rx_zc

af_xdp_rx_zc should always return the number of received packets, and negative value will be as number of received packets, and confuse the caller Fixes: d8a210774e1d ("net/af_xdp: support unaligned umem chunks") Cc: sta...@dpdk.org Signed-off-by: Li RongQing --- drivers/net/af_xdp/rte_eth_af_xd

[dpdk-dev] [PATCH 2/2] af_xdp: avoid to unnecessary allocation and free mbuf

optimize rx performance, by allocating mbuf based on result of xsk_ring_cons__peek, to avoid to redundancy allocation, and free mbuf when receive packets Signed-off-by: Li RongQing Signed-off-by: Dongsheng Rong --- drivers/net/af_xdp/rte_eth_af_xdp.c | 64 -

[dpdk-dev] [PATCH 1/2] af_xdp: not return a negative value in af_xdp_rx_zc

af_xdp_rx_zc should always return the number of received packets, and negative value will be as number of received packets, and confuse the caller Fixes: d8a210774e1d ("net/af_xdp: support unaligned umem chunks") Cc: sta...@dpdk.org Signed-off-by: Li RongQing --- drivers/net/af_xdp/rte_eth_af_xd

Re: [dpdk-dev] [PATCH v4] net/iavf: reject floating RSS attribute

> -Original Message- > From: Zhang, Qi Z > Sent: Wednesday, September 16, 2020 14:27 > To: Xing, Beilei > Cc: dev@dpdk.org; Guo, Junfeng ; Guo, Jia > ; Zhang, Qi Z > Subject: [PATCH v4] net/iavf: reject floating RSS attribute > > For RSS attribute don't have an associated RSS type, we n

[dpdk-dev] [PATCH v6 2/3] gro: add VXLAN UDP/IPv4 GRO support

From: Yi Yang VXLAN UDP/IPv4 GRO can help improve VM-to-VM UDP performance when UFO or GSO is enabled in VM, GRO must be supported if UFO or GSO is enabled, otherwise, performance can't get big improvement if only GSO is there. With this enabled in DPDK, OVS DPDK can leverage it to improve VM-to

[dpdk-dev] [PATCH v6 3/3] doc: update prog_guide and rel_notes for GRO

From: Yi Yang Release 20.11 added UDP/IPv4 and VXLAN UDP/IPv4 support for GRO, so update prog_guide and rel_notes to reflect these changes. Signed-off-by: Yi Yang --- doc/guides/prog_guide/generic_receive_offload_lib.rst | 6 +++--- doc/guides/rel_notes/release_20_11.rst| 6 +++

[dpdk-dev] [PATCH v6 1/3] gro: add UDP/IPv4 GRO support

From: Yi Yang UDP/IPv4 GRO can help improve VM-to-VM UDP performance when UFO or GSO is enabled in VM, GRO must be supported if UFO or GSO is enabled, otherwise, performance can't get big improvement if only GSO is there. With this enabled in DPDK, OVS DPDK can leverage it to improve VM-to-VM UD

[dpdk-dev] [PATCH v6 0/3] gro: add UDP/IPv4 GRO and VXLAN UDP/IPv4 GRO support

From: Yi Yang In case that UFO or GSO is enabled, GRO is very necessary, especially for UDP, it is more so. Many NICs can't support VXLAN UDP UFO/USO and VLAN UFO/USO, so UDP performance improvement depends on GSO and GRO to a great extent. This patch series added VLAN UDP/IPv4 GRO and VXLAN UDP

Re: [dpdk-dev] [PATCH v1] net/iavf: support flex desc metadata extraction

Hi Jeff, > -Original Message- > From: dev On Behalf Of Jeff Guo > Sent: Wednesday, September 9, 2020 10:54 > To: Wu, Jingjing ; Zhang, Qi Z ; > Xing, Beilei > > Cc: dev@dpdk.org; Guo, Jia > Subject: [dpdk-dev] [PATCH v1] net/iavf: support flex desc metadata extraction > > Enable metad

Re: [dpdk-dev] [PATCH 18.11] vfio: map contiguous areas in one go

Tested-by: Mei,JianweiX < jianweix@intel.com> -Original Message- From: dev On Behalf Of Anatoly Burakov Sent: Wednesday, September 16, 2020 7:26 PM To: dev@dpdk.org Cc: sta...@dpdk.org Subject: [dpdk-dev] [PATCH 18.11] vfio: map contiguous areas in one go Currently, when we are crea

Re: [dpdk-dev] [PATCH v2 0/2] remove RTE CIO barriers

Ferruh Yigit wrote: > >> > >> Since rte_cio_*mb APIs have been deprecated[1], remove them and use > >> rte_io_*mb APIs instead. > >> > >> [1] > http://code.dpdk.org/dpdk/latest/source/doc/guides/rel_notes/deprecatio > n.rst#L100 > >> > >> v2: > >> Update 20.11 release note by adding these API cha

Re: [dpdk-dev] [PATCH v5 2/2] gro: add VXLAN UDP GRO support

Thanks Jiayu, will add comments to explain it in v5. At 2020-09-17 10:06:37, "Hu, Jiayu" wrote: OK, I agree to ignore processing outer IP ID. But I think the comment need to change, as it is not accurate. VxLAN/UDP GRO doesn’t process outer IP ID is because it is meaningles

Re: [dpdk-dev] [PATCH v2] gso: fix pyld_unit_size issue for udp gso

Acked-by: Jiayu Hu > -Original Message- > From: yang_y...@163.com > Sent: Thursday, September 17, 2020 10:13 AM > To: dev@dpdk.org > Cc: Hu, Jiayu ; tho...@monjalon.net; > yangy...@inspur.com; yang_y...@163.com > Subject: [PATCH v2] gso: fix pyld_unit_size issue for udp gso > > From: Yi

[dpdk-dev] [PATCH v2] gso: fix pyld_unit_size issue for udp gso

From: Yi Yang Fragment offset of IPv4 header is measured in units of 8 bytes. Fragment offset of UDP fragments will be wrong after GSO if pyld_unit_size isn't multiple of 8. Say pyld_unit_size is 1500, fragment offset of the second UDP fragment will be 187 (i.e. 1500 / 8), which means 1496, and i

[dpdk-dev] [PATCH v8 3/3] net/octeontx2: add rss hash level support

From: Kiran Kumar K Add support to choose rss hash level from ethdev rss config. Signed-off-by: Kiran Kumar K --- drivers/net/octeontx2/otx2_ethdev.h | 2 +- drivers/net/octeontx2/otx2_rss.c| 13 +++-- 2 files changed, 12 insertions(+), 3 deletions(-) diff --git a/drivers/net/oct

[dpdk-dev] [PATCH v8 2/3] app/testpmd: support ethdev rss level config

From: Kiran Kumar K Adding support to set RSS level from ethdev config. level-default will requests the default behavior. level-outer will requests RSS to be performed on the outermost packet encapsulation level. level-inner will request RSS to be performed on the specified inner packet encapsula

[dpdk-dev] [PATCH v8 1/3] ethdev: add level support for RSS offload types

From: Kiran Kumar K This patch reserves 2 bits as input selection to select Inner and outer encapsulation level for RSS computation. It is combined with existing ETH_RSS_* to choose Inner or outer layers. This functionality already exists in rte_flow through level parameter in RSS action configur

Re: [dpdk-dev] [PATCH v5 2/2] gro: add VXLAN UDP GRO support

OK, I agree to ignore processing outer IP ID. But I think the comment need to change, as it is not accurate. VxLAN/UDP GRO doesn't process outer IP ID is because it is meaningless for reassembly in the ovs case you mentioned, rather than it's out-of-order. You can give the ovs example in the com

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/dpaa2: fix build error about timesync functions

Hi, > -Original Message- > From: Ferruh Yigit > Sent: Wednesday, September 16, 2020 11:29 PM > To: Di, ChenxuX ; hemant.agra...@nxp.com > Cc: sachin.sax...@nxp.com; sta...@dpdk.org; dev@dpdk.org; Richardson, > Bruce > Subject: Re: [dpdk-stable] [PATCH] net/dpaa2: fix build error about ti

[dpdk-dev] [PATCH v2 3/3] net/iavf: enable AVX512 for TX

To enhance the per-core performance, this patch adds some AVX512 instructions to the data path to handle the TX descriptors. Signed-off-by: Wenzhuo Lu Signed-off-by: Bruce Richardson Signed-off-by: Leyi Rong --- doc/guides/rel_notes/release_20_11.rst | 3 + drivers/net/iavf/iavf_ethdev.c

[dpdk-dev] [PATCH v2 0/3] enable AVX512 for iavf

AVX512 instructions is supported by more and more platforms. These instructions can be used in the data path to enhance the per-core performance of packet processing. Comparing with the existing implementation, this path set introduces some AVX512 instructions into the iavf data path, and we get a

[dpdk-dev] [PATCH v2 2/3] net/iavf: enable AVX512 for flexible RX

To enhance the per-core performance, this patch adds some AVX512 instructions to the data path to handle the flexible RX descriptors. Signed-off-by: Wenzhuo Lu Signed-off-by: Bruce Richardson Signed-off-by: Leyi Rong --- drivers/net/iavf/iavf_rxtx.c| 10 + drivers/net/iavf/iavf_rx

[dpdk-dev] [PATCH v2 1/3] net/iavf: enable AVX512 for legacy RX

To enhance the per-core performance, this patch adds some AVX512 instructions to the data path to handle the legacy RX descriptors. Signed-off-by: Wenzhuo Lu Signed-off-by: Bruce Richardson Signed-off-by: Leyi Rong --- drivers/net/iavf/iavf_rxtx.c| 27 +- drivers/net/iavf/iavf_rxt

Re: [dpdk-dev] [PATCH 3/3] net/iavf: enable AVX512 for TX

Hi Haiyue, > -Original Message- > From: Wang, Haiyue > Sent: Tuesday, September 15, 2020 9:17 AM > To: Lu, Wenzhuo ; dev@dpdk.org > Cc: Lu, Wenzhuo ; Richardson, Bruce > ; Rong, Leyi > Subject: RE: [dpdk-dev] [PATCH 3/3] net/iavf: enable AVX512 for TX > > > -Original Message- >

Re: [dpdk-dev] [PATCH v2] bus/pci: netuio interface for windows

On 9/16/2020 5:48 PM, Ranjit Menon wrote: Hi, Stephen On 9/15/2020 6:54 PM, Stephen Hemminger wrote: On Tue, 15 Sep 2020 16:28:03 -0700 Pallavi Kadam wrote: +    if (IsEqualGUID((const void *)&(device_info_data->ClassGuid), +    (const void *)&GUID_DEVCLASS_NETUIO)) Is there anyway to g

Re: [dpdk-dev] [PATCH v2] bus/pci: netuio interface for windows

Hi, Stephen On 9/15/2020 6:54 PM, Stephen Hemminger wrote: On Tue, 15 Sep 2020 16:28:03 -0700 Pallavi Kadam wrote: + if (IsEqualGUID((const void *)&(device_info_data->ClassGuid), + (const void *)&GUID_DEVCLASS_NETUIO)) Is there anyway to get rid of casts and have the righ

Re: [dpdk-dev] [PATCH v2 00/25] patchset for bnxt

On Wed, Sep 16, 2020 at 4:58 PM Ferruh Yigit wrote: > > On 9/16/2020 5:21 PM, Ajit Khaparde wrote: > > On Tue, Sep 15, 2020 at 9:28 PM Ajit Khaparde > > wrote: > >> > >> Some fixes and enhancements in the PMD and TruFlow layers. > >> > >> v1->v2: > >> - rebased to latest > >> - updated commit

Re: [dpdk-dev] [PATCH v2 00/25] patchset for bnxt

On 9/16/2020 5:21 PM, Ajit Khaparde wrote: On Tue, Sep 15, 2020 at 9:28 PM Ajit Khaparde wrote: Some fixes and enhancements in the PMD and TruFlow layers. v1->v2: - rebased to latest - updated commit messages Applied to dpdk-next-net-brcm. Kishore Padmanabha (14): net/bnxt: fix por

Re: [dpdk-dev] [PATCH v2 0/2] remove RTE CIO barriers

On 9/16/2020 5:13 PM, David Marchand wrote: On Fri, Sep 11, 2020 at 7:26 AM Phil Yang wrote: Since rte_cio_*mb APIs have been deprecated[1], remove them and use rte_io_*mb APIs instead. [1] http://code.dpdk.org/dpdk/latest/source/doc/guides/rel_notes/deprecation.rst#L100 v2: Update 20.11 re

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] bus/dpaa: fix fd check before close

On 9/15/2020 12:57 PM, wangyunjian wrote: From: Yunjian Wang The fd is possibly a negative value while it is passed as an argument to function "close". Fix the check to the fd. Fixes: b9c94167904f ("bus/dpaa: decouple FQ portal alloc and init") Cc: sta...@dpdk.org Signed-off-by: Yunjian Wang

Re: [dpdk-dev] Issue with net/netvsc pmd in 18.11.9

Looks like the below patch has changes a lot in the tx path which came in 18.11.9. Verified till 18.11.8 everything is working as expected. https://patches.dpdk.org/patch/67511/ Can you confirm if this change or the recv change patch proposed below will require any specific device config change

Re: [dpdk-dev] Issue with net/netvsc pmd in 18.11.9

Hi Souvik, Please also pick up this patch: https://patchwork.dpdk.org/patch/75341/ This patch didn’t make it to 18.11. Let me know if you are still seeing failures. If you can reproduce the failure with testpmd or other tools in DPDK, please also share the command you used. Thanks, Long From:

[dpdk-dev] [dpdk-announce] REMINDER: DPDK Userspace Summit* Sept. 22-23 (1 pm UTC)

DPDK Community, If you have not already, please register for DPDK Userspace Summit, happening virtually next week: *September 22-23, beginning at 1 pm / 13:00 UTC time. * REGISTER HERE Access the full agenda here to see who's

Re: [dpdk-dev] [PATCH v4 01/22] event/dlb: add documentation and meson infrastructure

> -Original Message- > From: Eads, Gage > Sent: Monday, September 14, 2020 3:56 PM > To: McDaniel, Timothy ; Richardson, Bruce > ; Mcnamara, John ; > Kovacevic, Marko ; Ray Kinsella > ; Neil Horman > Cc: dev@dpdk.org; Carrillo, Erik G ; Van Haaren, > Harry ; jer...@marvell.com > Subject

Re: [dpdk-dev] Issue with net/netvsc pmd in 18.11.9

If it helps the tx_conf->tx_free_thresh is set to 0 from app side and nb_desc is set to 4096 from the app. The same was set in 18.11.6 too. From: Dey, Souvik Sent: Wednesday, September 16, 2020 3:44 PM To: 'Long Li' ; Kevin Traynor ; dev@dpdk.org Cc: Stephen Hemminger ; Yigit, Ferruh ; Stephen

Re: [dpdk-dev] [PATCH v2 00/25] patchset for bnxt

On Tue, Sep 15, 2020 at 9:28 PM Ajit Khaparde wrote: > > Some fixes and enhancements in the PMD and TruFlow layers. > > v1->v2: > - rebased to latest > - updated commit messages Applied to dpdk-next-net-brcm. > > Kishore Padmanabha (14): > net/bnxt: fix port stop process and cleanup resources

Re: [dpdk-dev] Issue with net/netvsc pmd in 18.11.9

Hi Long, I did take this patch on top of 18.11.10rc1 , but with this patch and also with 18.11.10rc1 files, the rx itself is not working and dhcp fails. With 18.11.9 the rx is working fine and changes present in 18.11.10rc1(hn_rxtx.c ) does not look to work. 18.11.6 was all proper but 18.11.9

Re: [dpdk-dev] [PATCH v2 1/6] ethdev: add flow shared action API

On Wed, Sep 16, 2020 at 8:52 AM Andrey Vesnovaty wrote: > > Hi Ajit > > For shared action configuration I have following suggestion: > > struct rte_flow_shared_action_conf { > uint32_t no_ingress: 1; > uint32_t no_egress: 1; > }; > /*...*/ > rte_flow_shared_action_create(..., const

Re: [dpdk-dev] [v3 PATCH] test_distributor: prevent memory leakages from the pool

W dniu 08.09.2020 o 12:22, Sarosh Arif pisze: > rte_mempool_get_bulk is used to get bufs/many_bufs from the pool, > but at some locations when test fails the bufs/many_bufs are > not returned back to the pool. > Due to this, multiple executions of distributor_autotest gives the > following error me

Re: [dpdk-dev] [PATCH] eventdev: add PCI probe named convenience function

> -Original Message- > From: Eads, Gage > Sent: Monday, September 14, 2020 3:23 PM > To: McDaniel, Timothy ; Jerin Jacob > > Cc: dev@dpdk.org; Carrillo, Erik G ; Van Haaren, > Harry > Subject: RE: [PATCH] eventdev: add PCI probe named convenience function > > > > > /** > > * @in

Re: [dpdk-dev] [RFC 3/3] sft: introduce API

Hi Andery, PSB > -Original Message- > From: Andrey Vesnovaty > Sent: Wednesday, September 9, 2020 11:30 PM > To: dev@dpdk.org > Subject: [RFC 3/3] sft: introduce API > > Defines RTE SFT APIs for Statefull Flow Table library. > > SFT General description: > SFT library provides a framewor

Re: [dpdk-dev] [PATCH] bus/pci: support segment value as address domain on Windows

On 8/25/2020 4:43 AM, Tal Shnaiderman wrote: Set the domain value for rte_pci_addr probing on Windows to the value of the PCI segment returned by SPDRP_BUSNUMBER. Signed-off-by: Tal Shnaiderman --- drivers/bus/pci/windows/pci.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[dpdk-dev] [PATCH] common/octeontx2: upgrade mbox definition to version 9

Update mail box data structures to sync with af driver mbox changes done to retrieve VF's base steering rule. Signed-off-by: Nithin Dabilpuram Signed-off-by: Harman Kalra --- drivers/common/octeontx2/otx2_mbox.h | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drive

Re: [dpdk-dev] [PATCH v2 1/4] ethdev: allow negative values in flow rule types

From: Gregory Etelson Sent: Tuesday, September 15, 2020 13:27 To: Andrew Rybchenko ; Ajit Khaparde Cc: dpdk-dev ; Matan Azrad ; Raslan Darawsheh ; Ori Kam ; Gregory Etelson ; Ori Kam ; NBU-Contact-Thomas Monjalon ; Ferruh Yigit Subject: RE: [dpdk-dev] [PATCH v2 1/4] ethdev: allow negative va

Re: [dpdk-dev] [PATCH 0/4] remove experimental tags from APIs

On Fri, Sep 11, 2020 at 7:46 AM Joyce Kong wrote: > > Experimental tags can be removed from APIs in module: ticket lock, > MCS lock, pause (wait until equal APIs), and RCU (except for defer > queue APIs) as they have been aroud four releases. > > Joyce Kong (4): > eal/ticketlock: remove experime

Re: [dpdk-dev] [PATCH v3] bpf: remove experimental tag

On Mon, Sep 14, 2020 at 4:11 PM Conor Walsh wrote: > > The BPF lib was introduced in 18.05. > There were no changes in it's public API since 19.11. > It should be mature enough to remove it's 'experimental' tag. > RTE_BPF_XTYPE_NUM is also being dropped from rte_bpf_xtype to > avoid possible ABI p

Re: [dpdk-dev] [PATCH v2] app/test-pmd: fix meson build failed when enabled pmd_bonded

> -Original Message- > From: David Marchand > Sent: Friday, September 11, 2020 12:32 PM > To: Yang, SteveX ; Richardson, Bruce > > Cc: dev ; Lu, Wenzhuo ; Xing, Beilei > ; Yang, Qiming ; Kevin > Traynor ; Luca Boccassi ; Thomas > Monjalon ; Power, Ciara > Subject: Re: [dpdk-dev] [PATCH

[dpdk-dev] [PATCH v3 9/9] sched: remove the redundant code

Remove redundant data structure fields references from functions and subport level data structures. It also update the release and deprecation note. Signed-off-by: Savinay Dharmappa --- doc/guides/rel_notes/deprecation.rst | 6 -- doc/guides/rel_notes/release_20_11.rst | 4 ++ lib/librte_s

[dpdk-dev] [PATCH v3 7/9] drivers/softnic: add dynamic config of subport

Modify the softnic drivers to build the hierarchical scheduler with default subport bandwidth profile. It also allows to configure a subport with different subport bandwidth profile dynamically. Signed-off-by: Savinay Dharmappa --- drivers/net/softnic/rte_eth_softnic_internals.h | 9 + drivers

[dpdk-dev] [PATCH v3 8/9] app/test_sched: add dynamic config of subport

Modify the test_sched application to build the hierarchical scheduler with default subport bandwidth profile. It also allows to configure a subport with different subport bandwidth profile dynamically Signed-off-by: Savinay Dharmappa --- app/test/test_sched.c | 18 -- 1 file chan

  1   2   3   >