Re: [dpdk-dev] [PATCH v2 1/6] ethdev: add flow shared action API

2020-09-11 Thread Ajit Khaparde
On Wed, Jul 8, 2020 at 2:40 PM Andrey Vesnovaty wrote: > From: Andrey Vesnovaty > > This commit introduces extension of DPDK flow action API enabling > sharing of single rte_flow_action in multiple flows. The API intended for > PMDs where multiple HW offloaded flows can reuse the same HW > essen

Re: [dpdk-dev] [PATCH 1/2] config: add Graviton2(arm64) meson configuration

2020-09-11 Thread Honnappa Nagarahalli
+Jerin, Hemant, Dharmik Hi Vimal, Few comments inline. > > Add meson build configuration for Graviton2 platform with 64-bit ARM > Neoverse N1 cores. This patch makes the following changes to generic > Neoverse N1 config: > > 1. increase lcore limit to 64 > 2. increase memory support to

[dpdk-dev] [PATCH v2 6/7] net/i40e/base: fix PHY config param when enabling EEE

2020-09-11 Thread Guinan Sun
The i40e_enable_eee function did not copy phy_type_ext field from current PHY configuration retrieved with Get PHY Abilities AQ. It caused a misconfiguration of the PHY on devices supporting 2.5 and 5G speeds and prevented establishing link when only those speeds were selected for advertisement. F

[dpdk-dev] [PATCH v2 7/7] net/i40e/base: update version

2020-09-11 Thread Guinan Sun
Update base code version in readme. Signed-off-by: Guinan Sun --- drivers/net/i40e/base/README | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/i40e/base/README b/drivers/net/i40e/base/README index 58174d472..6af299311 100644 --- a/drivers/net/i40e/base/README +++

[dpdk-dev] [PATCH v2 5/7] net/i40e/base: add EEE LPI status check for X722 adapters

2020-09-11 Thread Guinan Sun
Add reading LPI (low power idle) status for supported X722 devices. If adapter's PHY supports EEE in current mode (device ID + link speed), LPI status is read from PHY Clause 45 PCS status register. Signed-off-by: Dawid Lukwinski Signed-off-by: Guinan Sun --- drivers/net/i40e/base/i40e_common.c

[dpdk-dev] [PATCH v2 4/7] net/i40e/base: fix Rx only for unicast promisc on VLAN

2020-09-11 Thread Guinan Sun
Set promiscuous mode to rx traffic only if VSI has VLANs configured. Rename misleading PROMISC_TX bit to proper name. Added I40E_AQC_SET_VSI_PROMISC_RX_ONLY during VSI unicast promiscuous mode configuration with port VLAN. Aligned unicast promiscuous with VLAN to the one without VLAN. Previously ot

[dpdk-dev] [PATCH v2 3/7] net/i40e/base: add support for minimum rollback revision

2020-09-11 Thread Guinan Sun
Add support for minimum rollback revision. Signed-off-by: Przemyslaw Ciesielski Signed-off-by: Guinan Sun --- drivers/net/i40e/base/i40e_adminq_cmd.h | 18 +++ drivers/net/i40e/base/i40e_common.c | 29 + drivers/net/i40e/base/i40e_prototype.h | 4

[dpdk-dev] [PATCH v2 1/7] net/i40e/base: update FW API version

2020-09-11 Thread Guinan Sun
Update FW increment API version for: -NVM FW Lockdown Feature for legacy devices -Security Version Opt-In Signed-off-by: Jacek Naczyk Signed-off-by: Guinan Sun --- drivers/net/i40e/base/i40e_adminq_cmd.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/i40e/ba

[dpdk-dev] [PATCH v2 2/7] net/i40e/base: fix missing function header arguments

2020-09-11 Thread Guinan Sun
Fix them by adding the argument descriptions. Fixes: 0d9d27bb8684 ("i40e/base: prepare local LLDP MIB in TLV") Cc: sta...@dpdk.org Signed-off-by: Jesse Brandeburg Signed-off-by: Guinan Sun --- drivers/net/i40e/base/i40e_dcb.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[dpdk-dev] [PATCH v2 0/7] update i40e base code

2020-09-11 Thread Guinan Sun
update i40e base code. source code of i40e driver: cid-i40e.2020.08.27.tar.gz dropped by the team which develop basic drivers for any i40e NIC. changelog in ND share repo: >From c0bfc1c07bb3 ("i40e-shared: Add VLAN field for input set") To 1a82d59f0797 ("i40e-shared: Fix PHY configuration paramet

[dpdk-dev] [PATCH 2/3] net/cxgbe: improve Rx congestion control

2020-09-11 Thread Rahul Lakkireddy
Chelsio T6 NIC can support up to 8 priority channels to manage congestion. So, increase to 8 congestion channels for T6. Also, add Rxq state to avoid unnecessarily ringing doorbell and polling the hardware for more traffic when the Rxq is stopped. Signed-off-by: Rahul Lakkireddy --- drivers/net/

[dpdk-dev] [PATCH 0/3] net/cxgbe: rework queue allocation and add RSS reta update

2020-09-11 Thread Rahul Lakkireddy
Patch 1 removes the equal distribution queue allocation across all ports under the same PF. Instead, the queues are allocated based on whichever port requests for the queues first. This will allow unused queue resources on other ports to be redistributed to ports that need more queues. Patch 2 inc

[dpdk-dev] [PATCH 3/3] net/cxgbe: add support to update RSS redirection table

2020-09-11 Thread Rahul Lakkireddy
Implement eth_dev_ops to manipulate RSS redirection table. Signed-off-by: Rahul Lakkireddy --- doc/guides/nics/features/cxgbe.ini | 1 + drivers/net/cxgbe/cxgbe_ethdev.c | 65 ++ 2 files changed, 66 insertions(+) diff --git a/doc/guides/nics/features/cxgbe.ini b/

[dpdk-dev] [PATCH 1/3] net/cxgbe: rework queue allocation between ports

2020-09-11 Thread Rahul Lakkireddy
Firmware returns the max queues that can be allocated on the entire PF. The driver evenly distributes them across all the ports belonging to the PF. However, some ports may need more queues than others and this equal distribution scheme prevents accessing these other ports unused queues. So, remove

[dpdk-dev] [PATCH v2] net/cxgbe: fix duplicate MAC addresses in MPS TCAM

2020-09-11 Thread Rahul Lakkireddy
From: Karra Satwik During MAC address insertion to MPS TCAM, add a default mask when the mask is not explicitly specified. Otherwise, driver misses the mask comparison and ends up inserting duplicate entries in the MPS TCAM. Fixes: 6fda3f0ddda9 ("net/cxgbe: add API to program hardware MPS table"

[dpdk-dev] [PATCH v3] EAL: An addition of cache line demote (CLDEMOTE) in rte_prefetch.h

2020-09-11 Thread Omkar Maslekar
rte_cldemote is similar to a prefetch hint - in reverse. cldemote(addr) enables software to hint to hardware that line is likely to be shared. Useful in core-to-core communications where cache-line is likely to be shared. ARM and PPC implementation is provided with NOP and can be added if any equiv

[dpdk-dev] [PATCH v3] EAL: An addition of cache line demote (CLDEMOTE) in rte_prefetch.h

2020-09-11 Thread Omkar Maslekar
We are including this in rte_prefetch.h since it is the most closely related code location.rte_cldemte is similar to a prefetch hint -in reverse Omkar Maslekar (1): EAL: An addition of cache line demote (CLDEMOTE) in rte_prefetch.h doc/guides/rel_notes/release_20_11.rst| 6 ++ lib

Re: [dpdk-dev] [PATCH v3] trace: fix compilation with C++

2020-09-11 Thread Chautru, Nicolas
Hi, > -Original Message- > From: sk...@marvell.com > > trace_mem is declared as 'void *' which triggers following error: > '...invalid conversion from ‘void*’ to ‘__rte_trace_header*’ > [-fpermissive]...' > > Fix this by adding proper typecast to 'struct __rte_trace_header *'. > > Fixe

[dpdk-dev] [PATCH 19/22] event/dlb2: add PMD self-tests

2020-09-11 Thread Timothy McDaniel
Add a variety of self-tests for both ldb and directed ports/queues, as well as configure, start, stop, link, etc... Signed-off-by: Timothy McDaniel --- app/test/test_eventdev.c |9 + drivers/event/dlb2/dlb2.c |1 + drivers/event/dlb2/dlb2_selftest.c | 1570

[dpdk-dev] [PATCH 21/22] event/dlb2: add timeout ticks entry point

2020-09-11 Thread Timothy McDaniel
Adds the timeout ticks conversion function. Signed-off-by: Timothy McDaniel --- drivers/event/dlb2/dlb2.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/drivers/event/dlb2/dlb2.c b/drivers/event/dlb2/dlb2.c index daf9b9f..50fb4b9 100644 --- a/drivers/event/dlb2/dlb2.c +++ b/

[dpdk-dev] [PATCH 22/22] doc: add new DLB2 eventdev driver to relnotes

2020-09-11 Thread Timothy McDaniel
Added announcement of availabililty for the new driver for Intel Dynamic Load Balancer V2.0 hardware. Signed-off-by: Timothy McDaniel --- doc/guides/rel_notes/release_20_11.rst | 5 + 1 file changed, 5 insertions(+) diff --git a/doc/guides/rel_notes/release_20_11.rst b/doc/guides/rel_notes

[dpdk-dev] [PATCH 20/22] event/dlb2: add queue and port release

2020-09-11 Thread Timothy McDaniel
These entry points are NO-OPS. DLB does not support reconfiguring individual queues or ports. The entire device must be reconfigured. Signed-off-by: Timothy McDaniel --- drivers/event/dlb2/dlb2.c | 25 + 1 file changed, 25 insertions(+) diff --git a/drivers/event/dlb2/dl

[dpdk-dev] [PATCH 18/22] event/dlb2: add PMD's token pop public interface

2020-09-11 Thread Timothy McDaniel
The PMD uses a public interface to allow applications to control the token pop mode. Supported token pop modes are as follows, and they impact core scheduling affinity for ldb ports. AUTO_POP: Pop the CQ tokens immediately after dequeueing. DELAYED_POP: Pop CQ tokens after (dequeue_depth - 1) even

[dpdk-dev] [PATCH 16/22] event/dlb2: add dequeue and its burst variants

2020-09-11 Thread Timothy McDaniel
Add support for dequeue, dequeue_burst, ... Signed-off-by: Timothy McDaniel --- drivers/event/dlb2/dlb2.c | 786 ++ 1 file changed, 786 insertions(+) diff --git a/drivers/event/dlb2/dlb2.c b/drivers/event/dlb2/dlb2.c index ac4cf19..8911c55 100644 ---

[dpdk-dev] [PATCH 15/22] event/dlb2: add enqueue and its burst variants

2020-09-11 Thread Timothy McDaniel
Add support for enqueue and its variants. Signed-off-by: Timothy McDaniel --- drivers/event/dlb2/dlb2.c | 592 ++ 1 file changed, 592 insertions(+) diff --git a/drivers/event/dlb2/dlb2.c b/drivers/event/dlb2/dlb2.c index ef23def..ac4cf19 100644 --- a/

[dpdk-dev] [PATCH 17/22] event/dlb2: add eventdev stop and close

2020-09-11 Thread Timothy McDaniel
Add support for eventdev stop and close entry points. Signed-off-by: Timothy McDaniel --- drivers/event/dlb2/dlb2.c | 261 +++-- drivers/event/dlb2/dlb2_iface.c| 6 + drivers/event/dlb2/dlb2_iface.h| 6 + drivers/event/dlb2/pf/

[dpdk-dev] [PATCH 13/22] event/dlb2: add port unlink and port unlinks in progress

2020-09-11 Thread Timothy McDaniel
Add supports for the port unlink(s) eventdev entry points. The unlink operation is an asynchronous operation executed by a control thread, and the unlinks-in-progress function reads a counter shared with the control thread. Signed-off-by: Timothy McDaniel --- drivers/event/dlb2/dlb2.c

[dpdk-dev] [PATCH 11/22] event/dlb2: add port setup

2020-09-11 Thread Timothy McDaniel
Configure the load balanded (ldb) or directed (dir) port. The consumer queue (CQ) and producer port (PP) are also set up here. Signed-off-by: Timothy McDaniel --- drivers/event/dlb2/dlb2.c | 527 + drivers/event/dlb2/dlb2_iface.c| 9 + drivers/event

[dpdk-dev] [PATCH 14/22] event/dlb2: add eventdev start

2020-09-11 Thread Timothy McDaniel
Add support for the eventdev start entry point. Signed-off-by: Timothy McDaniel --- drivers/event/dlb2/dlb2.c | 133 + drivers/event/dlb2/dlb2_iface.c| 3 + drivers/event/dlb2/dlb2_iface.h| 3 + drivers/event/dlb2/pf/base/d

[dpdk-dev] [PATCH 08/22] event/dlb2: add infos get and configure

2020-09-11 Thread Timothy McDaniel
Add support for configuring the DLB hardware. Signed-off-by: Timothy McDaniel --- drivers/event/dlb2/dlb2.c | 334 +++ drivers/event/dlb2/dlb2_iface.c|7 +- drivers/event/dlb2/dlb2_iface.h|5 + drivers/event/dlb2/pf/base/dlb2_resource.c | 3234 ++

[dpdk-dev] [PATCH 09/22] event/dlb2: add queue and port default conf

2020-09-11 Thread Timothy McDaniel
Add support for getting the queue and port default configuration. Signed-off-by: Timothy McDaniel --- drivers/event/dlb2/dlb2.c | 33 + 1 file changed, 33 insertions(+) diff --git a/drivers/event/dlb2/dlb2.c b/drivers/event/dlb2/dlb2.c index 58e953b..9ff371a 1006

[dpdk-dev] [PATCH 12/22] event/dlb2: add port link

2020-09-11 Thread Timothy McDaniel
Add port link entry point. Directed queues are identified and created at this stage. Their setup deferred until link-time, at which point we know the directed port ID. Directed queue setup will only fail if this queue is already setup or there are no directed queues left to configure. Signed-off-b

[dpdk-dev] [PATCH 10/22] event/dlb2: add queue setup

2020-09-11 Thread Timothy McDaniel
Load balanced (ldb) queues are setup here. Directed queues are not set up until link time, at which point we know the directed port ID. Directed queue setup will only fail if this queue is already setup or there are no directed queues left to configure. Signed-off-by: Timothy McDaniel --- driver

[dpdk-dev] [PATCH 04/22] event/dlb2: add definitions shared with LKM or shared code

2020-09-11 Thread Timothy McDaniel
Add headers containing structs and constants shared between the PMD and the shared code. The term shared code refers to the code that implements the hardware interface. The shared code is introduced in the probe patch, and then is extended as additional eventdev PMD entry points are added to the p

[dpdk-dev] [PATCH 01/22] event/dlb2: add meson build infrastructure

2020-09-11 Thread Timothy McDaniel
Adds the meson build infrastructure, which includes compile-time constants in rte_config.h. DLB2 is only supported on Linux X86 platforms at this time. Signed-off-by: Timothy McDaniel --- config/rte_config.h | 7 +++ drivers/event/dlb2/meson.build

[dpdk-dev] [PATCH 02/22] event/dlb2: add dynamic logging

2020-09-11 Thread Timothy McDaniel
This commit adds base support for dynamic logging. The default log level is NOTICE. Dynamic logging is used exclusively throughout this patchset. Signed-off-by: Timothy McDaniel --- drivers/event/dlb2/dlb2_log.h | 25 + 1 file changed, 25 insertions(+) create mode 100644

[dpdk-dev] [PATCH 03/22] event/dlb2: add private data structures and constants

2020-09-11 Thread Timothy McDaniel
The header file dlb2_priv.h is used internally by the PMD. It include constants, macros for device resources, structure definitions for hardware interfaces and software state, and various forward-declarations. The header file rte_pmd_dlb2.h will be exported in a subsequent patch, but is included he

[dpdk-dev] [PATCH 07/22] event/dlb2: add xstats

2020-09-11 Thread Timothy McDaniel
Add support for DLB2 xstats. Perform initialization and add standard xstats entry points. Signed-off-by: Timothy McDaniel --- drivers/event/dlb2/dlb2.c| 35 +- drivers/event/dlb2/dlb2_xstats.c | 1269 ++ drivers/event/dlb2/meson.build |1 + 3

[dpdk-dev] [PATCH 05/22] event/dlb2: add inline functions

2020-09-11 Thread Timothy McDaniel
Add miscellaneous inline functions that may be called from multiple files. These functions include inline assembly of new x86 instructions, such as movdir64b, since they are not available as builtin functions in the minimum supported GCC version. Signed-off-by: Timothy McDaniel --- drivers/even

[dpdk-dev] [PATCH 00/22] Add DLB2 PMD

2020-09-11 Thread Timothy McDaniel
The following patch series adds support for a new eventdev PMD. The DLB2 PMD adds support for the Intel Dynamic Load Balancer 2.0 (DLB2) hardware. The DLB2 is a PCIe device that provides load-balanced, prioritized scheduling of core-to-core communication. The device consists of queues and arbiters

[dpdk-dev] [PATCH v4 20/22] event/dlb: add queue and port release

2020-09-11 Thread Timothy McDaniel
These entry points are NO-OPS. DLB does not support reconfiguring individual queues or ports. The entire device must be reconfigured. Signed-off-by: Timothy McDaniel --- drivers/event/dlb/dlb.c | 25 + 1 file changed, 25 insertions(+) diff --git a/drivers/event/dlb/dlb.c

[dpdk-dev] [PATCH v4 22/22] doc: Add new DLB eventdev driver to relnotes

2020-09-11 Thread Timothy McDaniel
Added announcement of availabililty for the new driver for Intel Dynamic Load Balancer V1.0 hardware. Signed-off-by: Timothy McDaniel --- doc/guides/rel_notes/release_20_11.rst | 5 + 1 file changed, 5 insertions(+) diff --git a/doc/guides/rel_notes/release_20_11.rst b/doc/guides/rel_notes

[dpdk-dev] [PATCH v4 21/22] event/dlb: add timeout ticks entry point

2020-09-11 Thread Timothy McDaniel
Adds the timeout ticks conversion function. Signed-off-by: Timothy McDaniel --- drivers/event/dlb/dlb.c | 13 + 1 file changed, 13 insertions(+) diff --git a/drivers/event/dlb/dlb.c b/drivers/event/dlb/dlb.c index d9613ce..b7fa0ca 100644 --- a/drivers/event/dlb/dlb.c +++ b/drivers/e

[dpdk-dev] [PATCH v4 19/22] event/dlb: add PMD self-tests

2020-09-11 Thread Timothy McDaniel
Add a variety of self-tests for both ldb and directed ports/queues, as well as configure, start, stop, link, etc... Signed-off-by: Timothy McDaniel --- app/test/test_eventdev.c |8 + drivers/event/dlb/dlb.c |1 + drivers/event/dlb/dlb_selftest.c | 1563 ++

[dpdk-dev] [PATCH v4 15/22] event/dlb: add enqueue and its burst variants

2020-09-11 Thread Timothy McDaniel
Add support for enqueue and its variants. Signed-off-by: Timothy McDaniel --- drivers/event/dlb/dlb.c | 725 1 file changed, 725 insertions(+) diff --git a/drivers/event/dlb/dlb.c b/drivers/event/dlb/dlb.c index 5f2a7fa..8fbd25a 100644 --- a/driv

[dpdk-dev] [PATCH v4 16/22] event/dlb: add dequeue and its burst variants

2020-09-11 Thread Timothy McDaniel
Add support for dequeue, dequeue_burst, ... Signed-off-by: Timothy McDaniel --- drivers/event/dlb/dlb.c | 763 1 file changed, 763 insertions(+) diff --git a/drivers/event/dlb/dlb.c b/drivers/event/dlb/dlb.c index 8fbd25a..ba2323b 100644 --- a/dr

[dpdk-dev] [PATCH v4 18/22] event/dlb: add PMD's token pop public interface

2020-09-11 Thread Timothy McDaniel
The PMD uses a public interface to allow applications to control the token pop mode. Supported token pop modes are as follows, and they impact core scheduling affinity for ldb ports. AUTO_POP: Pop the CQ tokens immediately after dequeueing. DELAYED_POP: Pop CQ tokens after (dequeue_depth - 1) even

[dpdk-dev] [PATCH v4 14/22] event/dlb: add eventdev start

2020-09-11 Thread Timothy McDaniel
Add support for the eventdev start entry point. Signed-off-by: Timothy McDaniel --- drivers/event/dlb/dlb.c | 225 +-- drivers/event/dlb/dlb_iface.c| 3 + drivers/event/dlb/dlb_iface.h| 3 + drivers/event/dlb/pf/base/dlb_re

[dpdk-dev] [PATCH v4 17/22] event/dlb: add eventdev stop and close

2020-09-11 Thread Timothy McDaniel
Add support for eventdev stop and close entry points. Signed-off-by: Timothy McDaniel --- drivers/event/dlb/dlb.c | 256 +-- drivers/event/dlb/dlb_iface.c| 6 + drivers/event/dlb/dlb_iface.h| 6 + drivers/event/dlb/pf/base/

[dpdk-dev] [PATCH v4 13/22] event/dlb: add port unlink and port unlinks in progress

2020-09-11 Thread Timothy McDaniel
Add supports for the port unlink(s) eventdev entry points. The unlink operation is an asynchronous operation executed by a control thread, and the unlinks-in-progress function reads a counter shared with the control thread. Signed-off-by: Timothy McDaniel --- drivers/event/dlb/dlb.c | 167 ++

[dpdk-dev] [PATCH v4 12/22] event/dlb: add port link

2020-09-11 Thread Timothy McDaniel
Add port link entry point. Directed queues are identified and created at this stage. Their setup defered until link-time, at which point we know the directed port ID. Directed queue setup will only fail if this queue is already setup or there are no directed queues left to configure. Signed-off-by

[dpdk-dev] [PATCH v4 11/22] event/dlb: add port setup

2020-09-11 Thread Timothy McDaniel
Configure the load balanded (ldb) or directed (dir) port. The consumer queue (CQ) and producer port (PP) are also set up here. Signed-off-by: Timothy McDaniel --- drivers/event/dlb/dlb.c | 539 +++ drivers/event/dlb/dlb_iface.c| 11 + drivers/event/dlb/dlb

[dpdk-dev] [PATCH v4 10/22] event/dlb: add queue setup

2020-09-11 Thread Timothy McDaniel
Load balanced (ldb) queues are setup here. Directed queues are not set up until link time, at which point we know the directed port ID. Directed queue setup will only fail if this queue is already setup or there are no directed queues left to configure. Signed-off-by: Timothy McDaniel --- driver

[dpdk-dev] [PATCH v4 08/22] event/dlb: add infos get and configure

2020-09-11 Thread Timothy McDaniel
Add support for configuring the DLB hardware. Signed-off-by: Timothy McDaniel --- drivers/event/dlb/dlb.c | 402 +++ drivers/event/dlb/dlb_iface.c| 11 + drivers/event/dlb/dlb_iface.h| 11 + drivers/event/dlb/pf/base/dlb_resource.c | 4098 +++

[dpdk-dev] [PATCH v4 09/22] event/dlb: add queue and port default conf

2020-09-11 Thread Timothy McDaniel
Add support for getting the queue and port default configuration. Signed-off-by: Timothy McDaniel --- drivers/event/dlb/dlb.c | 29 + 1 file changed, 29 insertions(+) diff --git a/drivers/event/dlb/dlb.c b/drivers/event/dlb/dlb.c index 2dba396..fa9213c 100644 --- a/d

[dpdk-dev] [PATCH v4 05/22] event/dlb: add inline functions

2020-09-11 Thread Timothy McDaniel
Add miscellaneous inline functions that may be called from multiple files. These functions include inline assembly of new x86 instructions, such as movdir64b, since they are not available as builtin functions in the minimum supported GCC version. Signed-off-by: Timothy McDaniel --- drivers/even

[dpdk-dev] [PATCH v4 02/22] event/dlb: add dynamic logging

2020-09-11 Thread Timothy McDaniel
This commit adds base support for dynamic logging. The default log level is NOTICE. Dynamic logging is used exclusively throughout this patchset. Signed-off-by: Timothy McDaniel --- drivers/event/dlb/dlb_log.h | 25 + 1 file changed, 25 insertions(+) create mode 100644 d

[dpdk-dev] [PATCH v4 07/22] event/dlb: add xstats

2020-09-11 Thread Timothy McDaniel
Add support for DLB xstats. Perform initialization and add standard xstats entry points Signed-off-by: Timothy McDaniel --- drivers/event/dlb/dlb.c| 23 + drivers/event/dlb/dlb_xstats.c | 1252 drivers/event/dlb/meson.build |1 + 3 files c

[dpdk-dev] [PATCH v4 04/22] event/dlb: add definitions shared with LKM or shared code

2020-09-11 Thread Timothy McDaniel
Add headers containing structs and constants shared between the PMD and the shared code. The term shared code refers to the code that implements the hardware interface. The shared code is introduced in the probe patch, and then is extended as additional eventdev PMD entry points are added to the p

[dpdk-dev] [PATCH v4 03/22] event/dlb: add private data structures and constants

2020-09-11 Thread Timothy McDaniel
Add headers used internally by the PMD. These headers are used internally by the PMD. They include constants, macros for device resources, structure definitions for hardware interfaces and software state, and various forward-declarations. Signed-off-by: Timothy McDaniel --- drivers/event/dlb/dlb

[dpdk-dev] [PATCH v4 01/22] event/dlb: add documentation and meson infrastructure

2020-09-11 Thread Timothy McDaniel
Increased RTE_EVENT_MAX_QUEUES_PER_DEV config option from 64 to 255. Note that config/rte_config.h contains several configuration switches, providing for fine control of the PMD's runtime behaviour. The meson infrastructure is expanded as additional files are added to this patchset. Signed-off-b

[dpdk-dev] [PATCH v4 00/22] Add DLB PMD

2020-09-11 Thread Timothy McDaniel
The following patch series adds support for a new eventdev PMD. The DLB PMD adds support for the Intel Dynamic Load Balancer (DLB) hardware. The DLB is a PCIe device that provides load-balanced, prioritized scheduling of core-to-core communication. The device consists of queues and arbiters that co

[dpdk-dev] [PATCH 14/15] examples/ipsec-secgw: replace master lcore with main lcore

2020-09-11 Thread Stephen Hemminger
Simple replacement. Signed-off-by: Stephen Hemminger --- examples/ipsec-secgw/event_helper.c | 6 +++--- examples/ipsec-secgw/ipsec-secgw.c | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/examples/ipsec-secgw/event_helper.c b/examples/ipsec-secgw/event_helper.c index 865

[dpdk-dev] [PATCH 15/15] examples: replace master lcore with main lcore

2020-09-11 Thread Stephen Hemminger
Replace use of the term master lcore with main lcore in the example programs. Signed-off-by: Stephen Hemminger --- examples/bbdev_app/main.c | 10 examples/bond/main.c | 32 +- examples/ethtool/ethtool-app/main.c| 6 ++--- exam

[dpdk-dev] [PATCH 13/15] examples/qos: replace references to master

2020-09-11 Thread Stephen Hemminger
Use main instead of master in the QoS examples. Replace the "mst" command line argument with "mnc" Signed-off-by: Stephen Hemminger --- examples/qos_meter/main.c| 2 +- examples/qos_sched/args.c| 24 examples/qos_sched/cmdline.c | 2 +- examples/qos_sched/main.

[dpdk-dev] [PATCH 12/15] examples/performance-thread: replace reference to master lcore

2020-09-11 Thread Stephen Hemminger
Replace term master with main here. Signed-off-by: Stephen Hemminger --- examples/performance-thread/l3fwd-thread/main.c | 14 +++--- examples/performance-thread/pthread_shim/main.c | 2 +- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/examples/performance-thread/l3fwd-

[dpdk-dev] [PATCH 11/15] examples/multi_process: replace references to master/slave

2020-09-11 Thread Stephen Hemminger
Replace master with main and slave with worker. Fix the wording in comments. Signed-off-by: Stephen Hemminger --- .../multi_process/client_server_mp/mp_server/main.c| 10 +- examples/multi_process/simple_mp/main.c| 4 ++-- examples/multi_process/symmetric_mp/main.c

[dpdk-dev] [PATCH 09/15] app: replace references to master/slave

2020-09-11 Thread Stephen Hemminger
For the miscellaneous tests. Replace references to master lcore with main lcore and slave lcore with worker lcore. Signed-off-by: Stephen Hemminger --- app/test-acl/main.c | 2 +- app/test-bbdev/test_bbdev_perf.c | 8 app/test-compress-perf/main.c| 8 app/t

[dpdk-dev] [PATCH 07/15] app/test-pmd: replace master lcore with main lcore

2020-09-11 Thread Stephen Hemminger
Replace wording around main lcore. Signed-off-by: Stephen Hemminger --- app/test-pmd/config.c | 4 ++-- app/test-pmd/parameters.c | 2 +- app/test-pmd/testpmd.c| 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index 30bee

[dpdk-dev] [PATCH 10/15] examples: replace use of master with main

2020-09-11 Thread Stephen Hemminger
Change references to master/slave lcore to main/worker. For l2fwd, l3fwd and link_status examples. Signed-off-by: Stephen Hemminger --- examples/l2fwd-cat/l2fwd-cat.c| 2 +- examples/l2fwd-crypto/main.c | 6 +++--- examples/l2fwd-event/l2fwd_poll.c | 2 +- examples/l2fwd-

[dpdk-dev] [PATCH 08/15] app/test-eventdev: replace use of master lcore with main lcore

2020-09-11 Thread Stephen Hemminger
Replace master with main lcore. Signed-off-by: Stephen Hemminger --- app/test-eventdev/evt_options.c | 2 +- app/test-eventdev/test_order_common.c| 10 +- app/test-eventdev/test_perf_common.c | 12 ++-- app/test-eventdev/test_pipeline_common.c | 6 +++--- 4 fil

[dpdk-dev] [PATCH 06/15] app/test: replace uses of master/slave

2020-09-11 Thread Stephen Hemminger
Replace master lcore with main lcore and slave lcore with worker lcore. Mostly automatic replacement. Signed-off-by: Stephen Hemminger --- app/test/autotest_test_funcs.py | 2 +- app/test/meson.build| 2 +- app/test/test.c | 2 +- app/tes

[dpdk-dev] [PATCH 05/15] doc: replace master lcore with main lcore

2020-09-11 Thread Stephen Hemminger
Make sure that master lcore is not used in documentation. Signed-off-by: Stephen Hemminger --- doc/guides/faq/faq.rst | 2 +- doc/guides/linux_gsg/eal_args.include.rst| 2 +- doc/guides/nics/bnxt.rst | 2 +- doc/guides/prog

[dpdk-dev] [PATCH 02/15] eal: rename lcore word choices

2020-09-11 Thread Stephen Hemminger
Replace master lcore with main lcore and replace slave lcore with worker lcore. Keep the old functions and macros but mark them as deprecated for this release. The "--master-lcore" command line option is also deprecated and any usage will print a warning and use "--main-lcore" as replacement. Si

[dpdk-dev] [PATCH 00/15] Replace terms master/slave lcore with main/worker lcore

2020-09-11 Thread Stephen Hemminger
As announced in 20.08 release notes, the terms for lcore role will change in 20.11 release. This is a project wide patchset to terminolgy used for DPDK lcore. The term "master" referring to lcore is replaced with "main" and "slave" lcore is replaced with "worker" lcore. This is most visible in AP

[dpdk-dev] [PATCH 03/15] rte_power: replace rte_master_lcore with rte_main_lcore

2020-09-11 Thread Stephen Hemminger
Don't use old function. Signed-off-by: Stephen Hemminger --- lib/librte_power/rte_power_empty_poll.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_power/rte_power_empty_poll.c b/lib/librte_power/rte_power_empty_poll.c index 70c07b1533f3..975aa9299799 100644 ---

[dpdk-dev] [PATCH 01/15] eal: add macro to mark macros as deprecated

2020-09-11 Thread Stephen Hemminger
Add a macro that causes GCC and CLANG to emit a warning when a deprecated macro is used. Signed-off-by: Stephen Hemminger --- lib/librte_eal/include/rte_common.h | 11 +++ 1 file changed, 11 insertions(+) diff --git a/lib/librte_eal/include/rte_common.h b/lib/librte_eal/include/rte_com

[dpdk-dev] [PATCH 04/15] drivers: replace master lcore with main lcore

2020-09-11 Thread Stephen Hemminger
Replace use of deprecated rte_master_lcore with rte_main_lcore. Signed-off-by: Stephen Hemminger --- drivers/bus/dpaa/dpaa_bus.c | 2 +- drivers/net/bnxt/bnxt_ring.c | 4 ++-- drivers/net/mvpp2/mrvl_ethdev.c | 6 +++--- drivers/net/qede/base/bcm_osal

Re: [dpdk-dev] 18.11.10 (LTS) patches review and test

2020-09-11 Thread Kevin Traynor
On 11/09/2020 13:41, Stokes, Ian wrote: >> Hi all, >> >> Here is a list of patches targeted for LTS release 18.11.10. >> >> The planned date for the final release is 21 September. >> >> Please help with testing and validation of your use cases and report any >> issues/results with reply-all to this

[dpdk-dev] [PATCH] eventdev: add PCI probe named convenience function

2020-09-11 Thread Timothy McDaniel
Add new internal wrapper function for use by pci drivers as a .probe function to attach to an event interface. Same as rte_event_pmd_pci_probe, except the caller can specify the name. Updated rte_event_pmd_pci_probe so as to not duplicate code. Signed-off-by: Timothy McDaniel --- lib/librte_ev

[dpdk-dev] [PATCH 1/2] eventdev: implement ABI change

2020-09-11 Thread Timothy McDaniel
This commit implements the eventdev ABI changes required by the DLB PMD. The DLB hardware does not conform exactly to the eventdev interface. 1) It has a limit on the number of queues that may be linked to a port. 2) Some ports are further restricted to a maximum of 1 linked queue. 3) It does not

[dpdk-dev] [PATCH 2/2] eventdev: update app and examples for new eventdev ABI

2020-09-11 Thread Timothy McDaniel
Several data structures and constants changed, or were added, in the previous patch. This commit updates the dependent apps and examples to use the new ABI. Signed-off-by: Timothy McDaniel --- app/test-eventdev/evt_common.h | 11 app/test-eventdev/test_order_atq.c

[dpdk-dev] [PATCH 0/2] Eventdev ABI changes

2020-09-11 Thread Timothy McDaniel
This series implements the eventdev ABI changes required by the DLB and DLB2 PMDs. This ABI change was announced in the 20.08 release notes [1]. This patch was initially part of the V1 DLB PMD patchset. The DLB hardware does not conform exactly to the eventdev interface. 1) It has a limit on the n

[dpdk-dev] [PATCH v2] EAL: An addition of cache line demote (CLDEMOTE) in rte_prefetch.h

2020-09-11 Thread Omkar Maslekar
rte_cldemote is similar to a prefetch hint - in reverse. cldemote(addr) enables software to hint to hardware that line is likely to be shared. Useful in core-to-core communications where cache-line is likely to be shared. ARM and PPC implementation is provided with NOP and can be added if any equiv

[dpdk-dev] [PATCH v2] EAL: An addition of cache line demote (CLDEMOTE) in rte_prefetch.h

2020-09-11 Thread Omkar Maslekar
We are including this in rte_prefetch.h since it is the most closely related code location.rte_cldemte is similar to a prefetch hint -in reverse Omkar Maslekar (1): EAL: An addition of cache line demote (CLDEMOTE) in rte_prefetch.h doc/guides/rel_notes/release_20_11.rst| 8 +++- l

Re: [dpdk-dev] [PATCH] eal: add umonitor umwait to x86 cpuflags

2020-09-11 Thread Ananyev, Konstantin
> > umonitor/umwait are user-level versions of the monitor/mwait > instructions. These allow the core to wait in a low-power state > until a specified cache line is accessed, a timeout occurs, > or the core is interrupted. Isn't it a duplicate to: https://patches.dpdk.org/patch/76554/ ? > > S

[dpdk-dev] [PATCH] vhost: remove experimental tag on vDPA API

2020-09-11 Thread Maxime Coquelin
As announced in v20.08, this patch makes the vDPA and related Vhost API stable. Signed-off-by: Maxime Coquelin --- lib/librte_vhost/rte_vdpa.h| 36 -- lib/librte_vhost/rte_vdpa_dev.h| 16 lib/librte_vhost/rte_vhost.h | 6 -

[dpdk-dev] [PATCH] eal: add umonitor umwait to x86 cpuflags

2020-09-11 Thread Timothy McDaniel
umonitor/umwait are user-level versions of the monitor/mwait instructions. These allow the core to wait in a low-power state until a specified cache line is accessed, a timeout occurs, or the core is interrupted. Signed-off-by: Timothy McDaniel --- lib/librte_eal/x86/include/rte_cpuflags.h | 1 +

Re: [dpdk-dev] [PATCH v2] kernel: remove igb_uio

2020-09-11 Thread Ferruh Yigit
On 9/11/2020 4:54 PM, Thomas Monjalon wrote: > As decided in the Technical Board in November 2019, > the kernel module igb_uio is moved to the dpdk-kmods repository > in the /linux/igb_uio/ directory. > > Minutes of Technical Board meeting: > https://mails.dpdk.org/archives/dev/2019-November/15176

Re: [dpdk-dev] [PATCH] crypto/aesni-mb: support AES-ECB

2020-09-11 Thread Cornu, Marcel D
> -Original Message- > From: Cornu, Marcel D > Sent: Friday, September 11, 2020 4:49 PM > To: Doherty, Declan ; De Lara Guarch, Pablo > > Cc: dev@dpdk.org; "tomasz.kante...@intel.com"; Cornu, Marcel D > > Subject: [PATCH] crypto/aesni-mb: support AES-ECB > > This patch adds AES-ECB 128,

[dpdk-dev] [PATCH v3 6/6] test/ring: improve the application of macro

2020-09-11 Thread Feifei Wang
Add more parameters into the macro TEST_RING_VERIFY and expand the scope of application for it. Furthermore, replace all ring APIs check with TEST_RING_VERIFY to facilitate debugging. Suggested-by: Honnappa Nagarahalli Signed-off-by: Feifei Wang Reviewed-by: Phil Yang Reviewed-by: Dharmik Thakk

[dpdk-dev] [PATCH v3 5/6] test/ring: fix wrong size used in memcmp

2020-09-11 Thread Feifei Wang
When using memcmp function to check data, the third param should be the size of all elements, rather than the number of the elements. Furthermore, do code clean up by moving repeated code inside 'test_ring_mem_cmp' function to validate data and print information of enqueue/dequeue elements if vali

[dpdk-dev] [PATCH v3 4/6] test/ring: fix wrong number of enq/deq elements

2020-09-11 Thread Feifei Wang
The ring capacity is (RING_SIZE - 1), thus only (RING_SIZE - 1) number of elements can be enqueued into the ring. Fixes: af75078fece3 ("first public release") Cc: sta...@dpdk.org Signed-off-by: Feifei Wang Reviewed-by: Ruifeng Wang Reviewed-by: Phil Yang --- app/test/test_ring.c | 4 ++-- 1 f

[dpdk-dev] [PATCH v3 0/6] fix wrong passed pointer and add check

2020-09-11 Thread Feifei Wang
Several bugs in ring unit tests were identified and fixed. Added data validation on objects after enqueue/dequeue operations for data integration check. Unit tests were enhanced by checking return value of enqueue/dequeue operations and validating data integrity of objects. v2: 1. add check to v

[dpdk-dev] [PATCH v3 3/6] test/ring: validate the return value of enq/deq elements

2020-09-11 Thread Feifei Wang
Validate the return value of single element enqueue/dequeue operation in the test. Suggested-by: Honnappa Nagarahalli Signed-off-by: Feifei Wang Reviewed-by: Phil Yang --- app/test/test_ring.c | 26 ++ 1 file changed, 22 insertions(+), 4 deletions(-) diff --git a/app/t

[dpdk-dev] [PATCH v3 2/6] test/ring: fix wrong parameter passed to the enqueue APIs

2020-09-11 Thread Feifei Wang
When enqueue one element to ring in the performance test, a pointer should be passed to rte_ring_[sp|mp]enqueue APIs, not the pointer to a table of void *pointers. Fixes: a9fe152363e2 ("test/ring: add custom element size functional tests") Cc: honnappa.nagaraha...@arm.com Cc: sta...@dpdk.org Sign

[dpdk-dev] [PATCH v3 1/6] test/ring: add check to validate dequeued objects

2020-09-11 Thread Feifei Wang
Add check in test_ring_basic_ex and test_ring_with_exact_size for single element enqueue and dequeue operations to validate the dequeued objects. Signed-off-by: Feifei Wang Reviewed-by: Ruifeng Wang Reviewed-by: Phil Yang Reviewed-by: Dharmik Thakkar --- app/test/test_ring.c | 135 +++

[dpdk-dev] [PATCH v3 4/4] build: add abi breakage checks to meson

2020-09-11 Thread Conor Walsh
This patch adds the ability to run ABI breakage checks to meson. To do this the developer needs to set the meson build type to debug and set the version of DPDK that they want to check the ABI against. The option "abi_checks" has been added to meson for this, the option accepts DPDK tags e.g. "late

[dpdk-dev] [PATCH v3 3/4] buildtools: add script to setup abi checks for meson

2020-09-11 Thread Conor Walsh
This patch adds a script that is intended to be invoked by meson to do the required setup for performing ABI breakage checks at build time. The required ABI dump archives can come from several sources including being generated at build time or prebuilt archives can be pulled from a remote http loca

[dpdk-dev] [PATCH v3 0/4] abi breakage checks for meson

2020-09-11 Thread Conor Walsh
This patchset allows developers to check ABI breakages during build time. Currently checking that the DPDK ABI has not changed before up-streaming code is not intuitive. The current method, requires the contributor to use either the test-build.sh and test-meson-build.sh tools, along side some envir

  1   2   3   >