Re: [dpdk-dev] [PATCH v2 5/8] net/i40e/base: fix possible uninitialized variable

2020-07-26 Thread Jeff Guo
Acked-by: Jeff Guo On 7/27/2020 1:34 PM, Guinan Sun wrote: Fix possible uninitialized variable in i40e in the i40e_get_lpi_counters function. Fixes: 429bdc0cd967 ("net/i40e/base: add function to read LPI counters") Cc: sta...@dpdk.org Signed-off-by: Adam Ludkiewicz Signed-off-by: Guinan Sun

Re: [dpdk-dev] [PATCH v2 4/8] net/i40e/base: update FW API version to 1.11

2020-07-26 Thread Jeff Guo
Acked-by: Jeff Guo On 7/27/2020 1:34 PM, Guinan Sun wrote: Upcoming FW increment API version to 1.11 due to new bit and new fields in the Replace Cloud Filters AQ command. Signed-off-by: Jacek Naczyk Signed-off-by: Guinan Sun --- V2: * Modify commit message. --- drivers/net/i40e/base/i40e_a

Re: [dpdk-dev] [PATCH v2 3/8] net/i40e/base: add new custom cloud filter types

2020-07-26 Thread Jeff Guo
Acked-by: Jeff Guo On 7/27/2020 1:34 PM, Guinan Sun wrote: This patch adds the new filter types needed for custom cloud filters. These custom cloud filters will route traffic to VFs based on the dst IP for both tunneled and non-tunneled packets. Signed-off-by: Harshitha Ramamurthy Signed-off-b

[dpdk-dev] [PATCH v3] vhost: fix async copy fail on multi-page buffers

2020-07-26 Thread patrick . fu
From: Patrick Fu Async copy fails when single ring buffer vector is splited on multiple physical pages. This happens because current hpa address translation function doesn't handle multi-page buffers. A new gpa to hpa address conversion function, which returns the hpa on the first hitting host pa

[dpdk-dev] [PATCH v2 6/8] net/i40e/base: support unused ports disabling

2020-07-26 Thread Guinan Sun
This patch adds support for disabling unused ports. Signed-off-by: Damian Milosek Signed-off-by: Guinan Sun --- V2: * Modifiy title and message --- drivers/net/i40e/base/i40e_adminq_cmd.h | 1 + drivers/net/i40e/base/i40e_common.c | 6 ++ drivers/net/i40e/base/i40e_type.h | 1 + 3

[dpdk-dev] [PATCH v2 7/8] net/i40e/base: replace AQ command for NVM update

2020-07-26 Thread Guinan Sun
Add AQ command "NVM update in process" to replace the original AQ command "NVM progress". Signed-off-by: Jaroslaw Ilgiewicz Signed-off-by: Guinan Sun Acked-by: Jeff Guo --- V2: * Add Acked-by --- drivers/net/i40e/base/i40e_adminq_cmd.h | 12 +- drivers/net/i40e/base/i40e_common.c | 53

[dpdk-dev] [PATCH v2 8/8] net/i40e/base: update version

2020-07-26 Thread Guinan Sun
Update base code version in readme. Signed-off-by: Guinan Sun Acked-by: Jeff Guo --- V2: * Add Acked-by --- drivers/net/i40e/base/README | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/i40e/base/README b/drivers/net/i40e/base/README index 6baca4360..58174d472 100

[dpdk-dev] [PATCH v2 1/8] net/i40e/base: enable FEC on/off flag setting for X722

2020-07-26 Thread Guinan Sun
Starting with API version 1.10 firmware for X722 devices has ability to change FEC settings in PHY. Code added in this patch checks API version and sets appropriate capability flag. Signed-off-by: Dawid Lukwinski Signed-off-by: Guinan Sun Acked-by: Jeff Guo --- V2: * Add Acked-by --- drivers/n

[dpdk-dev] [PATCH v2 3/8] net/i40e/base: add new custom cloud filter types

2020-07-26 Thread Guinan Sun
This patch adds the new filter types needed for custom cloud filters. These custom cloud filters will route traffic to VFs based on the dst IP for both tunneled and non-tunneled packets. Signed-off-by: Harshitha Ramamurthy Signed-off-by: Guinan Sun --- V2: * Modify the title. --- drivers/net/i4

[dpdk-dev] [PATCH v2 4/8] net/i40e/base: update FW API version to 1.11

2020-07-26 Thread Guinan Sun
Upcoming FW increment API version to 1.11 due to new bit and new fields in the Replace Cloud Filters AQ command. Signed-off-by: Jacek Naczyk Signed-off-by: Guinan Sun --- V2: * Modify commit message. --- drivers/net/i40e/base/i40e_adminq_cmd.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(

[dpdk-dev] [PATCH v2 2/8] net/i40e/base: add PTYPE definition

2020-07-26 Thread Guinan Sun
Add I40E_RX_PTYPE_PARSER_ABORTED definition, so i40e driver will know opcode for parser aborted packets. Without this definition driver would have to rely on magic numbers. Signed-off-by: Przemyslaw Patynowski Signed-off-by: Guinan Sun Acked-by: Jeff Guo --- V2: * Add Acked-by --- drivers/net/

[dpdk-dev] [PATCH v2 5/8] net/i40e/base: fix possible uninitialized variable

2020-07-26 Thread Guinan Sun
Fix possible uninitialized variable in i40e in the i40e_get_lpi_counters function. Fixes: 429bdc0cd967 ("net/i40e/base: add function to read LPI counters") Cc: sta...@dpdk.org Signed-off-by: Adam Ludkiewicz Signed-off-by: Guinan Sun --- V2: * Modify commit message. --- drivers/net/i40e/base/i4

[dpdk-dev] [PATCH v2 0/8] update i40e base code

2020-07-26 Thread Guinan Sun
update i40e base code. source code of i40e driver: cid-i40e.2020.07.16.tar.gz dropped by the team which develop basic drivers for any i40e NIC. changelog in ND share repo: >From fc99a1143d3f ("i40e-shared: FEC on/off support flag for X722") To 673ff35c1c73 ("i40e-shared: Add support for firmware

Re: [dpdk-dev] [PATCH v2] net/ice: remove RSS for SCTP in PPPoE

2020-07-26 Thread Zhang, Qi Z
> -Original Message- > From: Guo, Jia > Sent: Monday, July 27, 2020 1:20 PM > To: Zhang, Qi Z ; Yang, Qiming > Cc: Su, Simei ; dev@dpdk.org > Subject: Re: [PATCH v2] net/ice: remove RSS for SCTP in PPPoE > > Acked-by: Jeff Guo > > On 7/27/2020 1:16 PM, Qi Zhang wrote: > > We don't su

Re: [dpdk-dev] [PATCH v2] net/ice: remove RSS for SCTP in PPPoE

2020-07-26 Thread Jeff Guo
Acked-by: Jeff Guo On 7/27/2020 1:16 PM, Qi Zhang wrote: We don't support SCTP in PPPoE RSS, remove it. Fixes: d117de460035 ("net/ice: fix GTPU/PPPoE packets with no hash value") Fixes: 0b952714e9c1 ("net/ice: refactor PF hash flow") Signed-off-by: Qi Zhang Tested-by: Nannan Lu --- driver

Re: [dpdk-dev] [PATCH 5/8] net/i40e/base: check return value of DNL admin command

2020-07-26 Thread Sun, GuinanX
Hi, Jeff > -Original Message- > From: Sun, GuinanX > Sent: Monday, July 27, 2020 12:54 PM > To: Guo, Jia ; dev@dpdk.org > Cc: Xing, Beilei ; Ludkiewicz, Adam > > Subject: RE: [PATCH 5/8] net/i40e/base: check return value of DNL admin > command > > Hi Jeff > > > -Original Message

[dpdk-dev] [PATCH v2] net/ice: remove RSS for SCTP in PPPoE

2020-07-26 Thread Qi Zhang
We don't support SCTP in PPPoE RSS, remove it. Fixes: d117de460035 ("net/ice: fix GTPU/PPPoE packets with no hash value") Fixes: 0b952714e9c1 ("net/ice: refactor PF hash flow") Signed-off-by: Qi Zhang Tested-by: Nannan Lu --- drivers/net/ice/ice_ethdev.c | 12 drivers/net/ice/ice_

Re: [dpdk-dev] [PATCH v1] app/test-regex: add RegEx test application

2020-07-26 Thread Ori Kam
Hi Jerin, > -Original Message- > From: Jerin Jacob > > On Mon, Jul 27, 2020 at 1:28 AM Ori Kam wrote: > > > > > diff --git a/app/test-regex/hello_world.rof2 b/app/test- > regex/hello_world.rof2 > > new file mode 100644 > > index 000..fb7db75 > > --- /dev/null > > +++ b/app/test-reg

Re: [dpdk-dev] [EXT] Re: [PATCH v3 1/6] drivers: add generic API to find PCI extended cap

2020-07-26 Thread Manish Chopra
> -Original Message- > From: Gaëtan Rivet > Sent: Monday, July 27, 2020 4:18 AM > To: Manish Chopra > Cc: jerinjac...@gmail.com; Jerin Jacob Kollanukkaran ; > ferruh.yi...@intel.com; dev@dpdk.org; Igor Russkikh > ; Rasesh Mody ; GR-Everest- > DPDK-Dev ; rosen...@intel.com; > tianfei.zh...

Re: [dpdk-dev] [PATCH] net/ice/base: fix symmetric asymmetric RSS interference

2020-07-26 Thread Zhang, Qi Z
> -Original Message- > From: Guo, Jia > Sent: Monday, July 27, 2020 11:32 AM > To: Lu, Nannan ; Zhang, Qi Z ; > Yang, Qiming > Cc: Su, Simei ; dev@dpdk.org; sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] net/ice/base: fix symmetric asymmetric RSS > interference > > > On 7/27/2020 9

Re: [dpdk-dev] [PATCH 6/8] net/i40e/base: add disable unused ports capability

2020-07-26 Thread Sun, GuinanX
Hi Jeff > -Original Message- > From: Guo, Jia > Sent: Monday, July 27, 2020 12:25 PM > To: Sun, GuinanX ; dev@dpdk.org > Cc: Xing, Beilei ; Milosek, Damian > > Subject: Re: [PATCH 6/8] net/i40e/base: add disable unused ports capability > > hi, guinan > > On 7/21/2020 3:39 PM, Guinan Sun

Re: [dpdk-dev] [PATCH 3/8] net/i40e/base: enable new custom cloud filters

2020-07-26 Thread Sun, GuinanX
Hi Jeff > -Original Message- > From: Guo, Jia > Sent: Monday, July 27, 2020 11:53 AM > To: Sun, GuinanX ; dev@dpdk.org > Cc: Xing, Beilei ; Ramamurthy, Harshitha > > Subject: Re: [PATCH 3/8] net/i40e/base: enable new custom cloud filters > > hi, guinan > > This patch is just define some

Re: [dpdk-dev] [PATCH 5/8] net/i40e/base: check return value of DNL admin command

2020-07-26 Thread Sun, GuinanX
Hi Jeff > -Original Message- > From: Guo, Jia > Sent: Monday, July 27, 2020 12:08 PM > To: Sun, GuinanX ; dev@dpdk.org > Cc: Xing, Beilei ; Ludkiewicz, Adam > > Subject: Re: [PATCH 5/8] net/i40e/base: check return value of DNL admin > command > > hi, guinan > > On 7/21/2020 3:39 PM, Gui

Re: [dpdk-dev] [PATCH v1] app/test-regex: add RegEx test application

2020-07-26 Thread Jerin Jacob
On Mon, Jul 27, 2020 at 1:28 AM Ori Kam wrote: > > diff --git a/app/test-regex/hello_world.rof2 b/app/test-regex/hello_world.rof2 > new file mode 100644 > index 000..fb7db75 > --- /dev/null > +++ b/app/test-regex/hello_world.rof2 > @@ -0,0 +1,45 @@ > +# > +# rof_version: 2 > +# > +# date:2020

Re: [dpdk-dev] [PATCH 8/8] net/i40e/base: update version

2020-07-26 Thread Jeff Guo
Acked-by: Jeff Guo On 7/21/2020 3:40 PM, Guinan Sun wrote: Update base code version in readme. Signed-off-by: Guinan Sun --- drivers/net/i40e/base/README | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/i40e/base/README b/drivers/net/i40e/base/README index 6b

Re: [dpdk-dev] [PATCH 7/8] net/i40e/base: replace AQ command for NVM update

2020-07-26 Thread Jeff Guo
Acked-by: Jeff Guo On 7/21/2020 3:39 PM, Guinan Sun wrote: Add AQ command "NVM update in process" to replace the original AQ command "NVM progress". Signed-off-by: Jaroslaw Ilgiewicz Signed-off-by: Guinan Sun --- drivers/net/i40e/base/i40e_adminq_cmd.h | 12 +- drivers/net/i40e/base/i

Re: [dpdk-dev] [PATCH 6/8] net/i40e/base: add disable unused ports capability

2020-07-26 Thread Jeff Guo
hi, guinan On 7/21/2020 3:39 PM, Guinan Sun wrote: This patch adds support for "Disable Unused Ports" functionality. "This patch adds support for disabling unused ports" is enough for reader i think. And use 2 verb is not good in title, "Support unused ports disabling" or other you want.

Re: [dpdk-dev] [PATCH 5/8] net/i40e/base: check return value of DNL admin command

2020-07-26 Thread Jeff Guo
hi, guinan On 7/21/2020 3:39 PM, Guinan Sun wrote: Check return value of running DNL admin command. What is "DNL", I am not sure i know the reason it appear here, could you double check it? Signed-off-by: Adam Ludkiewicz Signed-off-by: Guinan Sun --- drivers/net/i40e/base/i40e_commo

Re: [dpdk-dev] [PATCH 3/8] net/i40e/base: enable new custom cloud filters

2020-07-26 Thread Jeff Guo
hi, guinan This patch is just define some new types but not enable a feature, could the title to be "add new custom cloud filters types", is it better and could eliminate some confuse? On 7/21/2020 3:39 PM, Guinan Sun wrote: This patch adds the new filter types needed for custom cloud filter

Re: [dpdk-dev] [PATCH] net/ice: remove RSS for SCTP in PPPoE

2020-07-26 Thread Zhang, Qi Z
> -Original Message- > From: Guo, Jia > Sent: Monday, July 27, 2020 10:39 AM > To: Zhang, Qi Z ; Yang, Qiming > Cc: Su, Simei ; dev@dpdk.org > Subject: Re: [PATCH] net/ice: remove RSS for SCTP in PPPoE > > hi, qi > > On 7/25/2020 8:58 PM, Qi Zhang wrote: > > We don't support SCTP in P

Re: [dpdk-dev] [PATCH 2/8] net/i40e/base: add PTYPE definition

2020-07-26 Thread Jeff Guo
Acked-by: Jeff Guo On 7/21/2020 3:39 PM, Guinan Sun wrote: Add I40E_RX_PTYPE_PARSER_ABORTED definition, so i40e driver will know opcode for parser aborted packets. Without this definition driver would have to rely on magic numbers. Signed-off-by: Przemyslaw Patynowski Signed-off-by: Guinan Su

Re: [dpdk-dev] [PATCH 1/8] net/i40e/base: enable FEC on/off flag setting for X722

2020-07-26 Thread Jeff Guo
Acked-by: Jeff Guo On 7/21/2020 3:39 PM, Guinan Sun wrote: Starting with API version 1.10 firmware for X722 devices has ability to change FEC settings in PHY. Code added in this patch checks API version and sets appropriate capability flag. Signed-off-by: Dawid Lukwinski Signed-off-by: Guinan

Re: [dpdk-dev] [PATCH] net/ice/base: fix symmetric asymmetric RSS interference

2020-07-26 Thread Jeff Guo
On 7/27/2020 9:28 AM, Lu, Nannan wrote: -Original Message- From: dev On Behalf Of Qi Zhang Sent: Saturday, July 25, 2020 8:14 PM To: Yang, Qiming Cc: Su, Simei ; dev@dpdk.org; Zhang, Qi Z ; sta...@dpdk.org Subject: [dpdk-dev] [PATCH] net/ice/base: fix symmetric asymmetric RSS interfer

Re: [dpdk-dev] [PATCH] net/ice: remove RSS for SCTP in PPPoE

2020-07-26 Thread Jeff Guo
hi, qi On 7/25/2020 8:58 PM, Qi Zhang wrote: We don't support SCTP in PPPoE RSS, remove it. Fixes: d117de460035 ("net/ice: fix GTPU/PPPoE packets with no hash value") Fixes: 0b952714e9c1 ("net/ice: refactor PF hash flow") Signed-off-by: Qi Zhang --- drivers/net/ice/ice_ethdev.c | 12 ---

Re: [dpdk-dev] [PATCH] net/ice: remove RSS for SCTP in PPPoE

2020-07-26 Thread Lu, Nannan
> -Original Message- > From: dev On Behalf Of Qi Zhang > Sent: Saturday, July 25, 2020 8:59 PM > To: Yang, Qiming > Cc: Su, Simei ; Guo, Jia ; > dev@dpdk.org; Zhang, Qi Z > Subject: [dpdk-dev] [PATCH] net/ice: remove RSS for SCTP in PPPoE > > We don't support SCTP in PPPoE RSS, remove i

Re: [dpdk-dev] [PATCH] net/ice/base: fix symmetric asymmetric RSS interference

2020-07-26 Thread Lu, Nannan
> -Original Message- > From: dev On Behalf Of Qi Zhang > Sent: Saturday, July 25, 2020 8:14 PM > To: Yang, Qiming > Cc: Su, Simei ; dev@dpdk.org; Zhang, Qi Z > ; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH] net/ice/base: fix symmetric asymmetric RSS > interference > > A new symmetric RS

Re: [dpdk-dev] [EXT] Re: [PATCH v3 1/6] drivers: add generic API to find PCI extended cap

2020-07-26 Thread Gaëtan Rivet
On 26/07/20 19:47 +, Manish Chopra wrote: [...] > > > diff --git a/lib/librte_pci/rte_pci.h b/lib/librte_pci/rte_pci.h index > > > a03235da1..fec51e15a 100644 > > > --- a/lib/librte_pci/rte_pci.h > > > +++ b/lib/librte_pci/rte_pci.h > > > @@ -22,6 +22,22 @@ extern "C" { > > > #include > > >

Re: [dpdk-dev] [[PATCH v3 4/4] net/pcap: support hardware Tx timestamps

2020-07-26 Thread Stephen Hemminger
On Fri, 24 Jul 2020 16:23:15 -0400 Patrick Keroulas wrote: > From: Vivien Didelot > > When hardware timestamping is enabled on Rx path, system time should > no longer be used to calculate the timestamps when dumping packets. > > Instead, use the value stored by the driver in mbuf->timestamp >

[dpdk-dev] [PATCH v1] app/test-regex: add RegEx test application

2020-07-26 Thread Ori Kam
From: Yuval Avnery Following the new RegEx class. There is a need to create a dedicated test application in order to validate this class and PMD. Unlike net device this application loads data from a file. This commit introduce the new RegEx test app. The basic app flow: 1. Configure the RegEx

Re: [dpdk-dev] [EXT] Re: [PATCH v3 1/6] drivers: add generic API to find PCI extended cap

2020-07-26 Thread Manish Chopra
> -Original Message- > From: Gaëtan Rivet > Sent: Saturday, July 25, 2020 11:02 PM > To: Manish Chopra > Cc: jerinjac...@gmail.com; Jerin Jacob Kollanukkaran ; > ferruh.yi...@intel.com; dev@dpdk.org; Igor Russkikh > ; Rasesh Mody ; GR-Everest- > DPDK-Dev ; rosen...@intel.com; > tianfei.zh

Re: [dpdk-dev] [PATCH] common/qat: fix uninitialized variable bug

2020-07-26 Thread Akhil Goyal
> > > > [Adam] The ret variable value (signed) is not returned directly, please > > check the > rest of this function in src > > code. This is just checked to calculate how many ops were enqueued. And if > > all > checks skip (meaning the > > op was not processed by sym crypto, asym crypto nor co

Re: [dpdk-dev] [PATCH v2] crypto/qat: add DOCSIS performance optimization

2020-07-26 Thread Akhil Goyal
> > > > DOCSIS protocol performance in the downlink direction can be improved > > significantly in the QAT SYM PMD, especially for larger packets, by > > pre-processing all CRC generations in a batch before building and > > enqueuing any requests to the HW. This patch adds this optimization. > > >

Re: [dpdk-dev] [PATCH] common/qat: remove unused fields

2020-07-26 Thread Akhil Goyal
> > > > This patch removes unused fields from structs qat_qp and > > qat_qp_config, together with their initializations. > > > > Signed-off-by: Adam Dybkowski > Acked-by: Fiona Trahe Applied to dpdk-next-crypto Thanks.

Re: [dpdk-dev] [PATCH] crypto/octeontx2: fix structure alignment

2020-07-26 Thread Akhil Goyal
> > > > The structure cpt_request_info needs only 8 byte alignment. > > This patch replaces __rte_cache_aligned of cpt_request_info with > > __rte_aligned(8) and removes __rte_aligned(8) in cpt_meta_info structure. > > > > Fixes: fab634eb87ca ("crypto/octeontx2: support security session data path")

Re: [dpdk-dev] [PATCH v2 0/2] improve security instance setup

2020-07-26 Thread Akhil Goyal
> > These patches make some improvements to the security instance setup for > the QAT SYM and AESNI-MB PMDs. > Series Applied to dpdk-next-crypto Thanks.

Re: [dpdk-dev] [PATCH 0/3] Add AES-GCM and cipher only offload support

2020-07-26 Thread Akhil Goyal
> Subject: [PATCH 0/3] Add AES-GCM and cipher only offload support > > This patch set replaces the NITROX PMD specific test suite with generic > test suite and adds support for AES-GCM and cipher only offload. > I hope this series is for next release cycle. >From next time, please mention 20.11 i

Re: [dpdk-dev] [PATCH] crypto/scheduler: replace usage of master/slave

2020-07-26 Thread Akhil Goyal
Hi Adam, > > This patch replaces the usage of master/slave in QAT PMD and > Scheduler PMD as well as in their docs. Also the test app was > modified to use the new wording. > > Signed-off-by: Adam Dybkowski > --- This patch should be part of next release, as it is changing the user experience a

Re: [dpdk-dev] [PATCH v4 1/1] common/qat: support GEN2 QAT device 200xx

2020-07-26 Thread Akhil Goyal
Hi Adam, > diff --git a/doc/guides/rel_notes/release_20_08.rst > b/doc/guides/rel_notes/release_20_08.rst > index 2c8ac3647..48620e823 100644 > --- a/doc/guides/rel_notes/release_20_08.rst > +++ b/doc/guides/rel_notes/release_20_08.rst > @@ -187,10 +187,12 @@ New Features > > * **Updated the Qui

[dpdk-dev] [PATCH v11 08/10] common/mlx5: introduce layer to support multiple class drivers

2020-07-26 Thread Parav Pandit
Add generic mlx5 PCI PMD layer as part of existing common_mlx5 module. This enables multiple classes (net, regex, vdpa) PMDs to be supported at same time. Signed-off-by: Parav Pandit Acked-by: Matan Azrad --- Changelog: v10->v11: - Moved class combination hunk from next patch to this one v9->v1

[dpdk-dev] [PATCH v11 09/10] common/mlx5: register class drivers through common layer

2020-07-26 Thread Parav Pandit
Migrate mlx5 net, vdpa and regex PMD to start using mlx5 common class driver. Signed-off-by: Parav Pandit Acked-by: Matan Azrad --- Changelog: v10->v11: - Moved new class combinations to previous patch v8->v9: - Removed leftover inclusion of mlx5_pci bus include directory --- drivers/net/mlx5

[dpdk-dev] [PATCH v11 10/10] common/mlx5: remove class check from class drivers

2020-07-26 Thread Parav Pandit
Now that mlx5_pci PMD checks for enabled classes and performs probe(), remove() of associated classes, individual class driver does not need to check if other driver is enabled. Signed-off-by: Parav Pandit Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_common.c | 37

[dpdk-dev] [PATCH v11 07/10] common/mlx5: change class values as bits

2020-07-26 Thread Parav Pandit
mlx5 PCI Device supports multiple classes of devices such as net, vdpa, and/or regex. To support these multiple classes, change mlx5_class to a bitmap values so that if users asks to enable multiple of them, all supported classes can be parsed. Signed-off-by: Parav Pandit Acked-by: Matan Azrad -

[dpdk-dev] [PATCH v11 04/10] common/mlx5: fix void parameters in glue wrappers

2020-07-26 Thread Parav Pandit
Following two errors are reported when compiled with gcc (GCC) 8.3.1 20191121 (Red Hat 8.3.1-5). drivers/common/mlx5/linux/mlx5_glue.h:188:2: error: function declaration isn't a prototype [-Werror=strict-prototypes] drivers/common/mlx5/linux/mlx5_glue.h:188:2: error: function declaration isn't a

[dpdk-dev] [PATCH v11 06/10] common/mlx5: avoid using class constructor priority

2020-07-26 Thread Parav Pandit
mlx5_common is shared library between mlx5 net, VDPA and regex PMD. It is better to use common initialization helper instead of using RTE_PRIORITY_CLASS priority. Reviewed-by: David Marchand Suggested-by: David Marchand Signed-off-by: Parav Pandit --- Changelog: v7->v8: - new patch --- driver

[dpdk-dev] [PATCH v11 05/10] regex/mlx5: fix segmentation fault during error unwinding

2020-07-26 Thread Parav Pandit
When fail to initialize the device, avoid segmentation fault while accessing uninitialized priv. Fixes: cfc672a90b74 ("regex/mlx5: support probing") Signed-off-by: Parav Pandit --- Changelog: v9->v10: - Corrected type in commit log v7->v8: - Rebased - new patch --- drivers/regex/mlx5/mlx5_re

[dpdk-dev] [PATCH v11 01/10] eal: introduce macro for bit definition

2020-07-26 Thread Parav Pandit
There are several drivers which duplicate bit generation macro. Introduce a generic bit macros so that such drivers avoid redefining same in multiple drivers. Signed-off-by: Parav Pandit Acked-by: Matan Azrad Acked-by: Morten Brørup --- Changelog: v4->v5: - Addressed comments from Morten Brøru

[dpdk-dev] [PATCH v11 00/10] Improve mlx5 PMD driver framework for multiple classes

2020-07-26 Thread Parav Pandit
This series introduces mlx5 common driver layer to support multiple class of devices for a single PCI device. Motivation and example -- mlx5 PCI device supports multiple class of devices such as net, vdpa and regex devices. Currently only one pmd (either net or vdpa) can bind

[dpdk-dev] [PATCH v11 03/10] drivers: relax dependency order

2020-07-26 Thread Parav Pandit
From: Thomas Monjalon Drivers dependencies are evaluated in the order defined per their parent directory (also called class). This strict ordering prevents from having pairs of drivers from two classes with different dependency ordering. For example, if the mlx5 common code depends on the pci bus

[dpdk-dev] [PATCH v11 02/10] drivers: fix indent of directory list

2020-07-26 Thread Parav Pandit
From: Thomas Monjalon Define each sub-directory on its own line ended with a comma, and use a simple indent. Acked-by: Bruce Richardson Reviewed-by: David Marchand Signed-off-by: Thomas Monjalon --- Changelog: v7->8: - new patch --- drivers/meson.build | 24 +--- 1 file

Re: [dpdk-dev] [PATCH v1] vdpa/ifc: fix vring update after device config

2020-07-26 Thread Xu, Rosen
Hi, > -Original Message- > From: Xia, Chenbo > Sent: Saturday, July 25, 2020 1:09 > To: dev@dpdk.org > Cc: maxime.coque...@redhat.com; Yigit, Ferruh ; > Wang, Xiao W ; Xu, Rosen > Subject: [PATCH v1] vdpa/ifc: fix vring update after device config > > The device ready state in vhost lib

Re: [dpdk-dev] [PATCH v2 0/5] compiling ethdev lib under windows

2020-07-26 Thread Fady Bader
Hi Narcisa, I saw that the net patch was acked, can you also review this patch too to see if more work should be done. Thanks, Fady > -Original Message- > From: Fady Bader > Sent: Sunday, June 28, 2020 1:59 PM > To: dev@dpdk.org > Cc: Fady Bader ; Thomas Monjalon > ; Tasnim Bashar ; Ta