[dpdk-dev] 回复: [PATCH] lib/ring: fix the bug of HTS/RTS bulk enqueue

2020-06-09 Thread Feifei Wang
> -邮件原件- > 发件人: Honnappa Nagarahalli > 发送时间: 2020年6月10日 11:57 > 收件人: Feifei Wang ; Konstantin Ananyev > > 抄送: dev@dpdk.org; nd ; Feifei Wang > ; sta...@dpdk.org; Honnappa Nagarahalli > ; nd > 主题: RE: [PATCH] lib/ring: fix the bug of HTS/RTS bulk enqueue > > Hi Feifei, > Thanks for the p

[dpdk-dev] [PATCH] net/ice: support based RSS configure

2020-06-09 Thread Junyu Jiang
Enable/disable RSS for corresponding flow base on the user's requirement. Signed-off-by: Junyu Jiang --- drivers/net/ice/ice_ethdev.c | 181 ++- 1 file changed, 115 insertions(+), 66 deletions(-) diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_eth

[dpdk-dev] [RFC] mbuf: accurate packet Tx scheduling

2020-06-09 Thread Viacheslav Ovsiienko
There is the requirement on some networks for precise traffic timing management. The ability to send (and, generally speaking, receive) the packets at the very precisely specified moment of time provides the opportunity to support the connections with Time Division Multiplexing using the contempora

[dpdk-dev] [PATCH v2] lib/ring: fix bulk enqueue API to allow HTS/RTS modes

2020-06-09 Thread Feifei Wang
Remove the unwanted call to "_rte_ring_do_enqueue_elem" to allow for correct handling of RTS/HTS modes. Fixes: e6ba4731c0f3 ("ring: introduce RTS ring mode") Cc: sta...@dpdk.org Signed-off-by: Feifei Wang Reviewed-by: Ruifeng Wang Acked-by: Honnappa Nagarahalli --- V2: update commit message a

Re: [dpdk-dev] [PATCH v2 00/52] net/ice: base code update

2020-06-09 Thread Yang, Qiming
Hi, > -Original Message- > From: Zhang, Qi Z > Sent: Tuesday, June 9, 2020 19:59 > To: Yang, Qiming > Cc: Ye, Xiaolong ; dev@dpdk.org; Zhang, Qi Z > > Subject: [PATCH v2 00/52] net/ice: base code update > > Upgrade base with below main changes > > 1. add more protocol support - L2TPv3/

Re: [dpdk-dev] [PATCH RFC] devtools: increase default line length to 100

2020-06-09 Thread Jerin Jacob
On Tue, Jun 9, 2020 at 7:27 PM Bruce Richardson wrote: > > On Tue, Jun 09, 2020 at 04:40:28PM +0300, Andrew Rybchenko wrote: > > On 6/9/20 1:00 PM, Ananyev, Konstantin wrote: > > > > > >> > > >> On Mon, Jun 08, 2020 at 12:17:23PM -0700, Stephen Hemminger wrote: > > >>> On Mon, 8 Jun 2020 17:46:40

Re: [dpdk-dev] [PATCH v1 09/12] net/ice: add queue start and stop for DCF

2020-06-09 Thread Yang, Qiming
> -Original Message- > From: Xu, Ting > Sent: Tuesday, June 9, 2020 15:35 > To: Yang, Qiming ; dev@dpdk.org > Cc: Zhang, Qi Z ; Mcnamara, John > ; Kovacevic, Marko > ; Ye, Xiaolong > Subject: RE: [PATCH v1 09/12] net/ice: add queue start and stop for DCF > > Hi, Qiming, > > > -Or

Re: [dpdk-dev] [PATCH] lib/ring: fix the bug of HTS/RTS bulk enqueue

2020-06-09 Thread Honnappa Nagarahalli
Hi Feifei, Thanks for the patch. Few nits inline. > -Original Message- > From: Feifei Wang > Sent: Tuesday, June 9, 2020 10:39 PM > To: Honnappa Nagarahalli ; Konstantin > Ananyev > Cc: dev@dpdk.org; nd ; Feifei Wang > ; sta...@dpdk.org > Subject: [PATCH] lib/ring: fix the bug of

[dpdk-dev] [PATCH] lib/ring: fix the bug of HTS/RTS bulk enqueue

2020-06-09 Thread Feifei Wang
Directly call "_rte_ring_do_enqueue_elem" function can result in the process skips the "switch" order and cannot call the APIs of RTS and HTS mode in "rte_ring_enqueue_bulk_elem" function. To fix it, remove the unnecessary function and make "_rte_ring_do_enqueue_elem" consistent with "_rte_ring_do

Re: [dpdk-dev] [PATCH] mbuf: remove unused next member

2020-06-09 Thread Ye Xiaolong
On 06/09, Stephen Hemminger wrote: >On Tue, 9 Jun 2020 15:15:33 +0800 >Ye Xiaolong wrote: > >> On 06/09, Olivier Matz wrote: >> >Hi Xialong, >> > >> >On Tue, Jun 09, 2020 at 01:29:55PM +0800, Xiaolong Ye wrote: >> >> TAILQ_ENTRY next is not needed in struct mbuf_dynfield_elt and >> >> mbuf_dynfl

Re: [dpdk-dev] [PATCH] net/mlx5: fix typos in meter error messages

2020-06-09 Thread Raslan Darawsheh
Hi, > -Original Message- > From: dev On Behalf Of Ali Alnubani > Sent: Monday, June 8, 2020 5:03 PM > To: dev@dpdk.org > Cc: Suanming Mou ; Matan Azrad > > Subject: [dpdk-dev] [PATCH] net/mlx5: fix typos in meter error messages > > Fixes: 3bd26b23cefc ("net/mlx5: support meter profile o

Re: [dpdk-dev] [PATCH 0/4] Extend --lcores to run on cores > RTE_MAX_LCORE

2020-06-09 Thread Kevin Traynor
On 09/06/2020 18:48, Luca Boccassi wrote: > On Tue, 2020-06-09 at 16:30 +, Song, Keesang wrote: >> [AMD Public Use] >> >> Hi Kevin and Luca, >> Hi Keesang >> We are still waiting for the response. >> Can you help on this for the backports in 18.11 and 19.11? >> It would work for our customers

[dpdk-dev] [PATCH 6/6] doc/guides: update qede features list

2020-06-09 Thread Manish Chopra
Add SR-IOV PF entry in supported features Signed-off-by: Manish Chopra Signed-off-by: Igor Russkikh Signed-off-by: Rasesh Mody --- doc/guides/nics/features/qede.ini | 1 + doc/guides/nics/qede.rst | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/doc/guides/nics/fe

[dpdk-dev] [PATCH 4/6] net/qede: initialize VF MAC and link

2020-06-09 Thread Manish Chopra
This patch configures VFs with random mac if no MAC is provided by the PF/bulletin. This also adds required bulletin APIs by PF-PMD driver to communicate LINK properties/changes to the VFs through bulletin update mechanism. With these changes, VF-PMD instance is able to run fastpath over PF-PMD dr

[dpdk-dev] [PATCH 3/6] net/qede: add infrastructure support for VF load

2020-06-09 Thread Manish Chopra
This patch adds necessary infrastructure support (required to handle messages from VF and sending ramrod on behalf of VF's configuration request from alarm handler context) to start/load the VF-PMD driver instance on top of PF-PMD driver instance. Signed-off-by: Manish Chopra Signed-off-by: Igor

Re: [dpdk-dev] [PATCH v2] net/pcap: support software Tx nanosecond timestamps

2020-06-09 Thread Stephen Hemminger
On Tue, 9 Jun 2020 15:07:19 -0400 Vivien Didelot wrote: > > +#define NSEC_PER_SEC 10L > + > static inline void > calculate_timestamp(struct timeval *ts) { > uint64_t cycles; > @@ -294,8 +296,14 @@ calculate_timestamp(struct timeval *ts) { > > cycles = rte_get_timer_cycl

[dpdk-dev] [PATCH 5/6] net/qede: add VF FLR support

2020-06-09 Thread Manish Chopra
This patch adds required bit to handle VF FLR indication from Management FW (MFW) of the device With that VFs were able to load in VM (VF attached as PCI passthrough to the guest VM) followed by FLR successfully. Signed-off-by: Manish Chopra Signed-off-by: Igor Russkikh Signed-off-by: Rasesh Mo

[dpdk-dev] [PATCH 1/6] net/qede: define PCI config space specific osals

2020-06-09 Thread Manish Chopra
This patch defines various PCI config space access APIs in order to read and find IOV specific PCI capabilities. With these definitions implemented, it enables the base driver to do SR-IOV specific initialization and HW specific configuration required from PF-PMD driver instance. Signed-off-by: M

[dpdk-dev] [PATCH 2/6] net/qede: configure VFs on hardware

2020-06-09 Thread Manish Chopra
Based on number of VFs enabled at PCI, PF-PMD driver instance enables/configures those VFs from hardware perspective, such that in later patches they could get required HW access to communicate with PFs for slowpath configuration and run the fastpath themsleves. This patch also add two new qede IO

[dpdk-dev] [PATCH 0/6] qede: SR-IOV PF driver support

2020-06-09 Thread Manish Chopra
Hi, This series adds SR-IOV PF pmd driver support to have VF pmd driver work over PF pmd driver instances in order to run the adapter completely under DPDK environment for one of the use cases like ovs-dpdk. This is very initial bring-up with following testing covered - * Enable/Disable SR-IOV V

Re: [dpdk-dev] very high VIRT memory usage

2020-06-09 Thread Francesco
Hi Anatoly, Thanks a lot for the detailed response! Good to know anyway there's a "fix" already done in 20.05... also because I'm not interested in supporting secondary processes or having shared memory... Looking forward for the backports in stable branches then! Thanks! Francesco Il mar 9 gi

[dpdk-dev] [PATCH] eal: fix macros to align value

2020-06-09 Thread Harman Kalra
Found an issue while using RTE_ALIGN_MUL_NEAR with an expression, like as passed in estimate_tsc_freq(). RTE_ALIGN_MUL_FLOOR resulted in unexpected value in the above function as division has more precedence over substraction. Fixes: 5120203d753f ("eal: add macros to align value to multiple") Cc:

[dpdk-dev] DPDK techboard minutes of June 3rd

2020-06-09 Thread Ananyev, Konstantin
Meeting notes for the DPDK technical board meeting held on 2020-05-20 TB Attendees: - Bruce Richardson - Ferruh Yigit - Hemant Agrawal - Honnappa Nagarahalli - Jerin Jacob - Kevin Traynor - Konstantin Ananyev - Maxime Coquelin

Re: [dpdk-dev] [PATCH 0/4] Extend --lcores to run on cores > RTE_MAX_LCORE

2020-06-09 Thread Luca Boccassi
On Tue, 2020-06-09 at 16:30 +, Song, Keesang wrote: > [AMD Public Use] > > Hi Kevin and Luca, > > We are still waiting for the response. > Can you help on this for the backports in 18.11 and 19.11? > It would work for our customers even with changing the default value of ' > CONFIG_RTE_MAX_L

Re: [dpdk-dev] [PATCH 9/9] vhost: only use vDPA config workaround if needed

2020-06-09 Thread Maxime Coquelin
On 6/9/20 1:09 PM, Matan Azrad wrote: > Hi Maxime > > From: Maxime Coquelin >> Hi Matan, >> >> On 6/8/20 11:19 AM, Matan Azrad wrote: >>> Hi Maxime >>> >>> From: Maxime Coquelin: Hi Matan, On 6/7/20 12:38 PM, Matan Azrad wrote: > Hi Maxime > > Thanks for the huge work

Re: [dpdk-dev] [PATCH v1] net/axgbe: enable IEEE 1588 PTP support for axgbe

2020-06-09 Thread Ferruh Yigit
On 6/9/2020 4:42 PM, Sebastian, Selwin wrote: > [AMD Official Use Only - Internal Distribution Only] > > Hi Ferruh, > Added recommended modifications and resubmitted the patch. Removed > offloads handling part and "DEV_TX_OFFLOAD_MULTI_SEGS" Flag also as it is not > yet supported by drive

Re: [dpdk-dev] [RFC] add flow action context API

2020-06-09 Thread Jerin Jacob
On Thu, Jun 4, 2020 at 9:27 PM Andrey Vesnovaty wrote: > > On Thu, Jun 4, 2020 at 3:37 PM Jerin Jacob wrote: >> >> I would suggest adding rte_flow driver implementers if there is a >> change in rte_flow_ops in RFC so that >> your patch will get enough. I added the maintainers of rte_flow PMD[1] >

Re: [dpdk-dev] [PATCH v1] net/axgbe: enable IEEE 1588 PTP support for axgbe

2020-06-09 Thread Sebastian, Selwin
[AMD Official Use Only - Internal Distribution Only] Hi Ferruh, Added recommended modifications and resubmitted the patch. Removed offloads handling part and "DEV_TX_OFFLOAD_MULTI_SEGS" Flag also as it is not yet supported by driver. Commit 0625a29f42c62998318ee3e05b2420e436318678 for

[dpdk-dev] [RFC PATCH] rte_flow: introduce eCPRI item for rte_flow

2020-06-09 Thread Bing Zhao
eCPRI - enhanced CPRI - is packet based fronthaul interface developed by CPRI (Common Public Radio Interface) forum to connect the eREC and eRE. It supports 5G and enables increased efficiency. More details could be found in the specification via the link below: https://www.gigalight.com/downloads

Re: [dpdk-dev] [PATCH 2/2] eal: resolve getentropy at run time for random seed

2020-06-09 Thread Dan Gora
On Tue, Jun 2, 2020 at 2:10 AM Dan Gora wrote: > > Can these patches be considered again for 20.08? > > I thought that I addressed all of the issues or at least provided > reasonable responses to all of the concerns. So I guess I'll take that as a "no"... I have to admit that I just laughed when

Re: [dpdk-dev] very high VIRT memory usage

2020-06-09 Thread Stephen Hemminger
On Tue, 9 Jun 2020 14:39:54 +0100 "Burakov, Anatoly" wrote: > On 09-Jun-20 2:13 PM, Ferruh Yigit wrote: > > On 6/9/2020 1:46 PM, Burakov, Anatoly wrote: > >> On 08-Jun-20 12:03 PM, Francesco wrote: > >>> Hi all, > >>> I upgraded an old DPDK-based app which was using DPDK 17.11 to latest DPDK

Re: [dpdk-dev] [PATCH] mbuf: remove unused next member

2020-06-09 Thread Stephen Hemminger
On Tue, 9 Jun 2020 15:15:33 +0800 Ye Xiaolong wrote: > On 06/09, Olivier Matz wrote: > >Hi Xialong, > > > >On Tue, Jun 09, 2020 at 01:29:55PM +0800, Xiaolong Ye wrote: > >> TAILQ_ENTRY next is not needed in struct mbuf_dynfield_elt and > >> mbuf_dynflag_elt, since they are actually chained by r

[dpdk-dev] [PATCH v2] net/axgbe: enable IEEE 1588 PTP support

2020-06-09 Thread selwin . sebastian
From: Selwin Sebastian Add ethdev APIs to support PTP timestamping Signed-off-by: Selwin Sebastian --- drivers/net/axgbe/axgbe_common.h | 8 + drivers/net/axgbe/axgbe_ethdev.c | 336 + drivers/net/axgbe/axgbe_ethdev.h | 14 ++ drivers/net/axgbe/axgb

[dpdk-dev] [RFC] - Offloading tunnel ports

2020-06-09 Thread Oz Shlomo
Rte_flow API provides the building blocks for vendor agnostic flow classification offloads. The rte_flow match and action primitives are fine grained, thus enabling DPDK applications the flexibility to offload network stacks and complex pipelines. Applications wishing to offload complex data str

Re: [dpdk-dev] [PATCH v2] app/testpmd: fix error detection in MTU command

2020-06-09 Thread Ferruh Yigit
On 6/9/2020 3:44 PM, Phil Yang wrote: >> -Original Message- >> From: dev On Behalf Of Shy Shyman >> Sent: Monday, June 8, 2020 10:18 PM >> To: dev@dpdk.org >> Cc: wenzhuo...@intel.com; beilei.x...@intel.com; >> bernard.iremon...@intel.com; xavier.hu...@huawei.com >> Subject: [dpdk-dev] [PA

Re: [dpdk-dev] [PATCH v1 7/8] net/mlx5: add mlx5 header file specific to Linux

2020-06-09 Thread Ophir Munk
> -Original Message- > From: Ferruh Yigit > Sent: Tuesday, June 9, 2020 2:49 PM > To: Ophir Munk ; dev@dpdk.org; Matan Azrad > ; Raslan Darawsheh > Subject: Re: [dpdk-dev] [PATCH v1 7/8] net/mlx5: add mlx5 header file > specific to Linux > <...> > >> On 6/3/2020 4:06 PM, Ophir Munk wrot

Re: [dpdk-dev] [PATCH v2] app/testpmd: fix error detection in MTU command

2020-06-09 Thread Phil Yang
> -Original Message- > From: dev On Behalf Of Shy Shyman > Sent: Monday, June 8, 2020 10:18 PM > To: dev@dpdk.org > Cc: wenzhuo...@intel.com; beilei.x...@intel.com; > bernard.iremon...@intel.com; xavier.hu...@huawei.com > Subject: [dpdk-dev] [PATCH v2] app/testpmd: fix error detection in M

Re: [dpdk-dev] [RFC] [PATCH v1 3/3] net/pcap: dump hardware timestamps

2020-06-09 Thread Ferruh Yigit
On 6/9/2020 3:17 PM, Patrick Keroulas wrote: > When hardware timestamping is activated, system time should no longer be > used to timestamp dumped the packets. Instead, use value held by > forwarded and assume they were converted to nanoseconds. > > Signed-off-by: Patrick Keroulas > Signed-off-by

[dpdk-dev] [RFC] [PATCH v1 3/3] net/pcap: dump hardware timestamps

2020-06-09 Thread Patrick Keroulas
When hardware timestamping is activated, system time should no longer be used to timestamp dumped the packets. Instead, use value held by forwarded and assume they were converted to nanoseconds. Signed-off-by: Patrick Keroulas Signed-off-by: Vivien Didelot --- drivers/net/pcap/rte_eth_pcap.c |

[dpdk-dev] [RFC] [PATCH v1 1/3] net/mlx5: add timestamp-to-ns converter from libibverbs

2020-06-09 Thread Patrick Keroulas
While some devices update their own clock info to provide current time, mlx5dv part of libibverbs already handles this and also converts any raw counter cycle to nanoseconds. Signed-off-by: Patrick Keroulas --- drivers/common/mlx5/mlx5_glue.c | 16 drivers/common/mlx5/mlx5_glue.

[dpdk-dev] [RFC] [PATCH v1 2/3] ethdev: add API to convert raw timestamps to nsec

2020-06-09 Thread Patrick Keroulas
Existing ethdev functions can read/write time from/to device but they're all related to timesync and none of them can translate a raw counter in real time unit which is usefull in a pdump application. A new API is required because the conversion is derived from dev clock info. Signed-off-by: Pat

Re: [dpdk-dev] [PATCH v6 04/11] eal/mem: extract common code for memseg list initialization

2020-06-09 Thread Dmitry Kozlyuk
On Tue, 9 Jun 2020 14:36:10 +0100 "Burakov, Anatoly" wrote: > On 03-Jun-20 12:03 AM, Dmitry Kozlyuk wrote: > > All supported OS create memory segment lists (MSL) and reserve VA space > > for them in a nearly identical way. Move common code into EAL private > > functions to reduce duplication. > >

[dpdk-dev] [RFC] [PATCH v1 0/3] pdump HW timestamps for mlx5

2020-06-09 Thread Patrick Keroulas
The intention is to produce a pcap with nanosecond precision when timestamp offloading is activated on mlx5 NIC. The packets forwarded by testpmd hold the raw counter but a pcap requires a time unit. Assuming that the NIC clock is already synced with external master clock, this patchset simply int

Re: [dpdk-dev] [PATCH RFC] devtools: increase default line length to 100

2020-06-09 Thread Bruce Richardson
On Tue, Jun 09, 2020 at 04:40:28PM +0300, Andrew Rybchenko wrote: > On 6/9/20 1:00 PM, Ananyev, Konstantin wrote: > > > >> > >> On Mon, Jun 08, 2020 at 12:17:23PM -0700, Stephen Hemminger wrote: > >>> On Mon, 8 Jun 2020 17:46:40 +0100 Bruce Richardson > >>> wrote: > >>> > Rather than contin

Re: [dpdk-dev] [PATCH 2/3] cryptodev: add security operation to crypto operation

2020-06-09 Thread Coyle, David
Hi Konstantin, see below > -Original Message- > From: Ananyev, Konstantin > Sent: Tuesday, June 9, 2020 2:23 PM > > > > > > /** Status of crypto operation */ > > @@ -121,6 +123,13 @@ struct rte_crypto_op { > > struct rte_crypto_asym_op asym[0]; > > /**< Asymmetr

Re: [dpdk-dev] [PATCH v7 04/11] eal/mem: extract common code for memseg list initialization

2020-06-09 Thread Burakov, Anatoly
On 09-Jun-20 12:14 PM, Tal Shnaiderman wrote: Subject: [PATCH v7 04/11] eal/mem: extract common code for memseg list initialization All supported OS create memory segment lists (MSL) and reserve VA space for them in a nearly identical way. Move common code into EAL private functions to reduce du

Re: [dpdk-dev] [PATCH RFC] devtools: increase default line length to 100

2020-06-09 Thread Andrew Rybchenko
On 6/9/20 1:00 PM, Ananyev, Konstantin wrote: > >> >> On Mon, Jun 08, 2020 at 12:17:23PM -0700, Stephen Hemminger wrote: >>> On Mon, 8 Jun 2020 17:46:40 +0100 >>> Bruce Richardson wrote: >>> Rather than continuing to recommend an 80-char line limit, let's take a hint from the Lin

Re: [dpdk-dev] very high VIRT memory usage

2020-06-09 Thread Burakov, Anatoly
On 09-Jun-20 2:13 PM, Ferruh Yigit wrote: On 6/9/2020 1:46 PM, Burakov, Anatoly wrote: On 08-Jun-20 12:03 PM, Francesco wrote: Hi all, I upgraded an old DPDK-based app which was using DPDK 17.11 to latest DPDK 20.05 and I noticed that if I look at "top" I see that the VIRT memory taken by my a

Re: [dpdk-dev] [PATCH v6 04/11] eal/mem: extract common code for memseg list initialization

2020-06-09 Thread Burakov, Anatoly
On 03-Jun-20 12:03 AM, Dmitry Kozlyuk wrote: All supported OS create memory segment lists (MSL) and reserve VA space for them in a nearly identical way. Move common code into EAL private functions to reduce duplication. Signed-off-by: Dmitry Kozlyuk --- +int +eal_memseg_list_alloc(struct r

Re: [dpdk-dev] [PATCH 2/3] cryptodev: add security operation to crypto operation

2020-06-09 Thread Ananyev, Konstantin
> > Add a new security operation structure to the crypto operation to allow > protocol specific parameters defined in rte_security be defined for a > crypto operation. > > Please note this is API changes only. Implementation will follow in > next version. > > Signed-off-by: David Coyle > Sign

Re: [dpdk-dev] very high VIRT memory usage

2020-06-09 Thread Ferruh Yigit
On 6/9/2020 1:46 PM, Burakov, Anatoly wrote: > On 08-Jun-20 12:03 PM, Francesco wrote: >> Hi all, >> I upgraded an old DPDK-based app which was using DPDK 17.11 to latest DPDK >> 20.05 and I noticed that if I look at "top" I see that the VIRT memory >> taken by my application is now 256.1GB while

Re: [dpdk-dev] very high VIRT memory usage

2020-06-09 Thread Burakov, Anatoly
On 08-Jun-20 12:03 PM, Francesco wrote: Hi all, I upgraded an old DPDK-based app which was using DPDK 17.11 to latest DPDK 20.05 and I noticed that if I look at "top" I see that the VIRT memory taken by my application is now 256.1GB while before it was <1GB. I've seen this same behavior with al

[dpdk-dev] [PATCH] common/qat: support GEN2 device C34xx

2020-06-09 Thread Adam Dybkowski
This adds pci detection and documentation for Intel GEN2 QuickAssist device C34xx (PF Did 0x18ee, VF Did 0x18ef). Signed-off-by: Adam Dybkowski --- doc/guides/compressdevs/qat_comp.rst | 3 ++- doc/guides/cryptodevs/qat.rst | 8 ++-- doc/guides/rel_notes/release_20_08.rst | 5

[dpdk-dev] [PATCH v2 52/52] net/ice/base: update IPV4 and IPV6 flow ptype masks

2020-06-09 Thread Qi Zhang
In the flow API, add ability to add IPV4/IPV6 rules that match on packets with or without inner L4 protocols. Also, remove PPPOD packet from PPPOE bitmap. Signed-off-by: Dan Nowlin Signed-off-by: Paul M. Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_flow.c | 168

[dpdk-dev] [PATCH v2 51/52] net/ice/base: add 1G SGMII PHY type

2020-06-09 Thread Qi Zhang
There isn't a case for 1G SGMII in ice_get_media_type() so add the handling for it. Also handle the special case where some direct attach cables may report that they support 1G SGMII, but that is erroneous since SGMII is supposed to be a backplane media type (between a MAC and a PHY). If the drive

[dpdk-dev] [PATCH v2 50/52] net/ice/base: add more device ID support

2020-06-09 Thread Qi Zhang
Add support for E823L devices. Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_common.c | 5 + drivers/net/ice/base/ice_devids.h | 10 ++ drivers/net/ice/base/ice_nvm.c| 5 + drivers/net/ice/ice_ethdev.c | 5 + 4 files changed, 25 insertions(+) diff --git a/

[dpdk-dev] [PATCH v2 49/52] net/ice/base: fix uninitialized flag

2020-06-09 Thread Qi Zhang
This patch add initialization for prof_res_bm_init flag to zero in order that the possible resource for field vector in the files can be initialized. Fixes: 453d087ccaff ("net/ice/base: add common functions") Cc: sta...@dpdk.org Signed-off-by: Wei Zhao Signed-off-by: Paul M. Stillwell Jr Signed

[dpdk-dev] [PATCH v2 48/52] net/ice/base: add more tunnel type for IPv4 and IPv6

2020-06-09 Thread Qi Zhang
This patch add more tunnel type defination ipv4/ipv6 packet, it enable tcp/udp layer of ipv4/ipv6 as L4 payload but without L4 dst/src port number as input set for switch filter rule. For example: we can download a switch rule to direct ipv4 packet with specific source and destination ip address t

[dpdk-dev] [PATCH v2 46/52] net/ice/base: remove unused code for VSI list free

2020-06-09 Thread Qi Zhang
When free vsi list resource after vsi list update to empty, some useless code in function ice_remove_vsi_list_rule() should be deleted. Signed-off-by: Wei Zhao Signed-off-by: Paul M. Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_switch.c | 17 + 1 file chang

[dpdk-dev] [PATCH v2 47/52] net/ice/base: fix reference count when update VSI list

2020-06-09 Thread Qi Zhang
The parameter ref_cnt is used for tracking how many rules are reusing this VSI list, so it can only be updated when a rule which using this list be deleted. Fixes: f89aa3affa9e ("net/ice/base: support removing advanced rule") Cc: sta...@dpdk.org Signed-off-by: Wei Zhao Signed-off-by: Paul M. Sti

[dpdk-dev] [PATCH v2 45/52] net/ice/base: add a new command to LLDP commands

2020-06-09 Thread Qi Zhang
Add support for LLDP forwarding to SW programming in FW LLDP Filter Control is 0x0A0A. Signed-off-by: Sharon Haroni Signed-off-by: Paul M. Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_adminq_cmd.h | 14 ++ 1 file changed, 14 insertions(+) diff --git a/drivers/

[dpdk-dev] [PATCH v2 40/52] net/ice/base: add new API to check all autoneg enable bits

2020-06-09 Thread Qi Zhang
struct ice_aqc_get_phy_caps_data has multiple autoneg enable bits. ice_is_phy_caps_an_enabled checks all bits and returns true if any autoneg enable bits are set. Signed-off-by: Paul Greenwalt Signed-off-by: Paul M. Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_common.c | 1

[dpdk-dev] [PATCH v2 44/52] net/ice/base: distribute Tx queues evenly

2020-06-09 Thread Qi Zhang
Distribute the tx queues evenly across all queue groups. This will help the queues to get more equal sharing among the queues when all are in use. In the previous algorithm, the next queue group node will be picked up only after the previous one filled with max children. For example: if VSI is con

[dpdk-dev] [PATCH v2 41/52] net/ice/base: avoid PPPoE ipv4 overlap

2020-06-09 Thread Qi Zhang
When PPPOE header is not selected, pppoe should not be included in ipv4 ptype bitmaps. Signed-off-by: Yahui Cao Signed-off-by: Paul M. Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_flow.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/ne

[dpdk-dev] [PATCH v2 43/52] net/ice/base: adjust scheduler default BW weight

2020-06-09 Thread Qi Zhang
By default the queues are configured in legacy mode. The default BW settings for legacy/advanced modes are different. The existing code was using the advanced mode default value of 1 which was incorrect. This caused the unbalanced BW sharing among siblings. The recommneded default value is applied.

[dpdk-dev] [PATCH v2 42/52] net/ice/base: initialize AQ failure variable when set fc

2020-06-09 Thread Qi Zhang
ice_set_fc takes a u8 pointer 'aq_failures' as an input parameter. If this function encounters an error, in addition to returning an appropriate ice_status enum code, it also populates aq_failures with a link specific error value. If the caller does not initialize this variable to 0 before calling

[dpdk-dev] [PATCH v2 39/52] net/ice/base: remove unimplemented function prototypes

2020-06-09 Thread Qi Zhang
There are no implementations for these two functions so remove the prototypes. Signed-off-by: Tony Nguyen Signed-off-by: Paul M. Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_fdir.h | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/net/ice/base/ice_fdir.h b/dr

[dpdk-dev] [PATCH v2 38/52] net/ice/base: add entries in Profile TCAM with priority

2020-06-09 Thread Qi Zhang
The profile TCAM tables are implemented such that entries with a smaller index in the table have a higher priority. When records to be added to the table have flags to differentiate between standard PTG and VSIG records, then these entries need to have higher priority in order to be found and proce

[dpdk-dev] [PATCH v2 35/52] net/ice/base: correct return value

2020-06-09 Thread Qi Zhang
Function ice_rem_adv_rule_id return incorrect error code (ICE_ERR_PARAM) whereas it should have returned ICE_ERR_DOES_NOT_EXIST return code if filter list is empty or unable to find "rule" in list Signed-off-by: Kiran Patil Signed-off-by: Paul M. Stillwell Jr Signed-off-by: Qi Zhang --- driver

[dpdk-dev] [PATCH v2 37/52] net/ice/base: fix for memory leak

2020-06-09 Thread Qi Zhang
Handles memory leaks during control queue initialization and buffer allocation failures. The MACRO - ICE_FREE_CQ_BUFS is modified to re-use for this fix. Fixes: 6c1f26be50a2 ("net/ice/base: add control queue information") Cc: sta...@dpdk.org Signed-off-by: Surabhi Boob Signed-off-by: Paul M. Sti

[dpdk-dev] [PATCH v2 36/52] net/ice/base: remove unneeded variable

2020-06-09 Thread Qi Zhang
The variable 'adj' is initialized to 0 and later used in an addition, but the value is never changed from 0. Remove the variable since it's doing nothing. Signed-off-by: Tony Nguyen Signed-off-by: Paul M. Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_flow.c | 3 +-- 1 file

[dpdk-dev] [PATCH v2 32/52] net/ice/base: reset capabilities before parsing

2020-06-09 Thread Qi Zhang
The capability flags used to report whether an NVM component has a pending update are stored as simple booleans. If ice_parse_caps finds the relevant capability then the boolean is set to true. If the capability is not provided by firmware, then the boolean value will be left alone. This works dur

[dpdk-dev] [PATCH v2 34/52] net/ice/base: update the vsi handle to remaining VSI

2020-06-09 Thread Qi Zhang
Needs to update the VSI handle to the last remaining VSI using the rule for ICE_FWD_TO_VSI. Otherwise it may have error for deleting the rule. Signed-off-by: Haiyue Wang Signed-off-by: Paul M. Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_switch.c | 1 + 1 file changed, 1 i

[dpdk-dev] [PATCH v2 33/52] net/ice/base: add RL profile bit mask check

2020-06-09 Thread Qi Zhang
Mask bits before accessing the profile type field. Signed-off-by: Tarun Singh Signed-off-by: Paul M. Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_sched.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/net/ice/base/ice_sched.c b/driv

[dpdk-dev] [PATCH v2 30/52] net/ice/base: add support for more PPPoE packet type

2020-06-09 Thread Qi Zhang
This patch add more dummy packet type for pppoe packet, it enable tcp/udp layer of ipv4/ipv6 for pppoe payload, so we can use L4 dst/src port as input set for switch filter. Signed-off-by: Wei Zhao Signed-off-by: Paul M. Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_protoco

[dpdk-dev] [PATCH v2 31/52] net/ice/base: reset flags when all rules are deleted

2020-06-09 Thread Qi Zhang
To avoid having stale information about "adv_rule" per recipe, when all rules associated to a given recipe are deleted, reset the "adv_rule" flag otherwise it causes problem later on when decisions about filter rules being present or not are made based on "adv_rule" flag. Removed setting "adv_rule

[dpdk-dev] [PATCH v2 25/52] net/ice/base: add RSS support for IPv6 prefix

2020-06-09 Thread Qi Zhang
Some IPv6 prefix related fields are defined in this patch, so that we can use prefixes instead of full IPv6 address for RSS. These prefixes include the first 32, 48, 64 bits of both SRC and DST IPV6 address. Signed-off-by: Junfeng Guo Signed-off-by: Paul M. Stillwell Jr Signed-off-by: Qi Zhang

[dpdk-dev] [PATCH v2 29/52] net/ice/base: remove unnecessary code

2020-06-09 Thread Qi Zhang
Remove unncessary case branch. Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_flow.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/ice/base/ice_flow.c b/drivers/net/ice/base/ice_flow.c index 030a55ba7..53ff5f4be 100644 --- a/drivers/net/ice/base/ice_flow.c +++ b/drivers

[dpdk-dev] [PATCH v2 26/52] net/ice/base: use macro for sizeof

2020-06-09 Thread Qi Zhang
The definition of ICE_SW_RULE_RX_TX_ETH_HDR_SIZE open codes the size of a structure field. Replace this with the use of FIELD_SIZEOF. Signed-off-by: Jacob Keller Signed-off-by: Paul M. Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_switch.h | 17 - 1 file cha

[dpdk-dev] [PATCH v2 28/52] net/ice/base: return correct error code

2020-06-09 Thread Qi Zhang
Return ICE_ERR_DOES_NOT_EXIST return code if admin command error code is ICE_AQ_RC_ENOENT (not exist). ice_aq_sw_rules is used when switch rule is getting added/deleted/updated. In case of delete/update switch rule, admin command can return ICE_AQ_RC_ENOENT error code if such rule does not exist, h

[dpdk-dev] [PATCH v2 27/52] net/ice/base: add debug logs

2020-06-09 Thread Qi Zhang
Add debug logs for ice_aq_get_phy_caps(), and format ice_aq_set_phy_cfg() and ice_aq_get_link_info() debug logs to make them more readable. Signed-off-by: Paul Greenwalt Signed-off-by: Paul M. Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_common.c | 69 +

[dpdk-dev] [PATCH v2 24/52] net/ice/base: adjust function signature style format

2020-06-09 Thread Qi Zhang
Where possible, cuddle multiple lines of function signatures to be consistent throughout the code. Signed-off-by: Bruce Allan Signed-off-by: Paul M. Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_common.c | 3 +-- drivers/net/ice/base/ice_controlq.c | 9 +++-- driver

[dpdk-dev] [PATCH v2 20/52] net/ice/baes: add NVM help functions

2020-06-09 Thread Qi Zhang
Add couple functions that DPDK would like to use for accessing the NVM. Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_common.h | 1 - drivers/net/ice/base/ice_nvm.c| 67 +-- drivers/net/ice/base/ice_nvm.h| 10

[dpdk-dev] [PATCH v2 23/52] net/ice/base: remove unnecessary braces

2020-06-09 Thread Qi Zhang
This patch mainly does cleanups related to unnecessary braces. A few other minor fixes are included which include fixing a typo, pulling up some lines, and fixing RCT. Signed-off-by: Tony Nguyen Signed-off-by: Paul M. Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_flex_pipe

[dpdk-dev] [PATCH v2 21/52] net/ice/base: allow GENEVE and VXLAN rules with VLAN

2020-06-09 Thread Qi Zhang
When programming GENEVE and VXLAN switch rules, there are some instances where both VLAN tagged packets plus non-VLAN tagged packets are needed to match the rule. In order to perform this action in one rule, the switch code needs to setup the packet flag mask to ignore the VLAN packet flag. This w

[dpdk-dev] [PATCH v2 22/52] net/ice/base: increase timeout after PFR

2020-06-09 Thread Qi Zhang
To allow for resets during package download, increase the timeout period after performing a PFR. The time waited is the global config lock timeout plus the normal PFSWR timeout. Signed-off-by: Dan Nowlin Signed-off-by: Paul M. Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_c

[dpdk-dev] [PATCH v2 17/52] net/ice/base: add FDIR support for L2TPV3 ESP AH and PFCP

2020-06-09 Thread Qi Zhang
FDIR can forward: - L2TPV3 packets with session id. - IPSEC ESP packets with security parameter index. - IPSEC AH packets with security parameter index. - NAT_T ESP packets with security parameter index. - PFCP packets with s field value. Signed-off-by: Yahui Cao Signed-off-by: Paul M. Stillwell

[dpdk-dev] [PATCH v2 13/52] net/ice/base: refactor flow director filter swap

2020-06-09 Thread Qi Zhang
Move the swap of flow director addresses and ports into training packet generation. This reduces the code written for ACL. Signed-off-by: Henry Tieman Signed-off-by: Paul M. Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_fdir.c | 59 ---

[dpdk-dev] [PATCH v2 19/52] net/ice/base: initialize Set PHY Configuration FEC fields

2020-06-09 Thread Qi Zhang
Currently the caller needs to initialize the ice_cfg_phy_fec() parameter ice_aqc_set_phy_cfg_data FEC fields before calling. However, this is not necessary since ice_cfg_phy_fec() calls Get PHY Capabilities. Initialize ice_aqc_set_phy_cfg_data FEC capabilities and FEC option fields from Get PHY Ca

[dpdk-dev] [PATCH v2 18/52] net/ice/base: add FD completion report option

2020-06-09 Thread Qi Zhang
This patch introduces comp_report variable so that the called can determine whether to report completion on error or on all cases. Signed-off-by: Yahui Cao Signed-off-by: Paul M. Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_fdir.c | 2 +- drivers/net/ice/base/ice_fdir.h

[dpdk-dev] [PATCH v2 16/52] net/ice/base: cleanup comment formatting

2020-06-09 Thread Qi Zhang
Add missing space between end of comment text and comment terminator, and remove unnecessary punctuation. Signed-off-by: Bruce Allan Signed-off-by: Paul M. Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_acl.c| 25 +- drivers/net/ice/base/ice_acl_ctrl.

[dpdk-dev] [PATCH v2 15/52] net/ice/base: group function protoypes together

2020-06-09 Thread Qi Zhang
There are some function prototypes at the beginning of the file and some at the end, group them all together so that they are in one consistent location. Signed-off-by: Tony Nguyen Signed-off-by: Paul M. Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_fdir.h | 83

[dpdk-dev] [PATCH v2 14/52] net/ice/base: change IPV6 training packet

2020-06-09 Thread Qi Zhang
Add additional UDP payload to allow for additional headers such as ESP. Signed-off-by: Dan Nowlin Signed-off-by: Paul M. Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_switch.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/net/ice/base/ic

[dpdk-dev] [PATCH v2 09/52] net/ice/base: add AUI media type

2020-06-09 Thread Qi Zhang
Add and report AUI PHY types as an AUI media type Signed-off-by: Doug Dziggel Signed-off-by: Paul M. Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_common.c | 5 +++-- drivers/net/ice/base/ice_type.h | 1 + 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/dri

[dpdk-dev] [PATCH v2 07/52] net/ice/base: gate devices from FW link override

2020-06-09 Thread Qi Zhang
Currently, the FW link override feature is only permitted for E810 devices. However, the ice_fw_supports_link_override() guards against FW versions irrespective of the device. This assumes FW versions between the families are aligned, which is not the case. Signed-off-by: Jeb Cramer Signed-off-b

[dpdk-dev] [PATCH v2 11/52] net/ice/base: update PHY type high max index value

2020-06-09 Thread Qi Zhang
As currently, we are supporting only 5 PHY_SPEEDs for phy_type_high. Thus, we should adjust the value of ICE_PHY_TYPE_HIGH_MAX_INDEX to 5. Signed-off-by: Chinh T Cao Signed-off-by: Paul M. Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_adminq_cmd.h | 2 +- 1 file changed, 1

[dpdk-dev] [PATCH v2 12/52] net/ice/base: consolidate VF Promiscuous mode

2020-06-09 Thread Qi Zhang
Consolidate the Promiscuous rule for SMBM on the chosen logical port. Signed-off-by: Shibin Koikkara Reeny Signed-off-by: Paul M. Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_switch.c | 145 ++ 1 file changed, 115 insertions(+), 30 delet

[dpdk-dev] [PATCH v2 10/52] net/ice/base: fix variable type for ACL

2020-06-09 Thread Qi Zhang
The commit ef92cee94cdb ("ice-shared: Fix remaining minor casting issues") changed the idx variable within ice_acl_add_entry() from a u16 to a u8. This causes the code to truncate the values greater than 255 to 255 or less when calling ice_aq_program_acl_entry() resulting in the wrong TCAM index be

[dpdk-dev] [PATCH v2 08/52] net/ice/base: improve VSI filters rebuild

2020-06-09 Thread Qi Zhang
This change improve VSI filter configuration rebuild for multiport configuration, ie. where 1 PF includes more than one logical port. For some functions, association between port and corresponding switch_info or port_info structure has been lost because by default the pointer to the first element o

[dpdk-dev] [PATCH v2 05/52] net/ice/base: consolidate implementation of MAC config set

2020-06-09 Thread Qi Zhang
Consolidate implementation of ice_aq_set_mac_cfg for switch mode and NIC mode. As per the specification, the driver needs to call set_mac_cfg (opcode 0x0603) to be able to exercise jumbo frames. Signed-off-by: Anirudh Venkataramanan Signed-off-by: Jeb Cramer Signed-off-by: Paul M. Stillwell Jr

  1   2   >