Re: [dpdk-dev] [RFC 1/6] eal: add power management intrinsics

2020-05-28 Thread Jerin Jacob
On Thu, May 28, 2020 at 9:08 PM Ananyev, Konstantin wrote: > > > > > Hi Anatoly, > > > > > >> > > >> Add two new power management intrinsics, and provide an implementation > > >> in eal/x86 based on UMONITOR/UMWAIT instructions. The instructions > > >> are implemented as raw byte opcodes because t

Re: [dpdk-dev] [PATCH] rte_sched: correctly free allocated subport memory

2020-05-28 Thread Stephen Hemminger
On Tue, 26 May 2020 19:24:55 +0200 Hrvoje Habjanic wrote: > In function rte_sched_subport_free (lib/librte_sched/rte_sched.c, > line 865), there is code to free all allocated stuff related to > scheduler subport. First there are some checks, and in the end, > rte_bitmap_free is called. > > Now,

Re: [dpdk-dev] [PATCH] ether: check the first segment length on SW VLAN insertion

2020-05-28 Thread Stephen Hemminger
On Wed, 27 May 2020 15:31:41 +0100 Andrew Rybchenko wrote: > SW VLAN insertion relies on Ethernet addresses location in contigous > memory (do not split across mbuf segments). There is no any formal > requirements on data location and mbuf structure which guarantee it. > So, check it explicitly t

[dpdk-dev] [PATCH v15 1/2] eal: add uuid dependent header files explicitly

2020-05-28 Thread Haiyue Wang
Add the dependent header files explicitly, so that the user just needs to include the 'rte_uuid.h' header file directly to avoid compile error: (1). rte_uuid.h:97:55: error: unknown type name ‘size_t’ (2). rte_uuid.h:58:2: error: implicit declaration of function ‘memcpy’ Fixes: 6bc67c497a51 ("ea

[dpdk-dev] [PATCH v15 0/2] support for VFIO-PCI VF token interface

2020-05-28 Thread Haiyue Wang
v15: Add the missed EXPERIMENTAL warning for API doxgen. v14: Rebase the patch for 20.08 release note. v13: Rename the EAL get VF token function, and leave the freebsd type as empty. v12: support to vfio devices with VF token and no token. v11: Use the eal parameter to pass the VF token, then n

[dpdk-dev] [PATCH v15 2/2] eal: support for VFIO-PCI VF token

2020-05-28 Thread Haiyue Wang
The kernel module vfio-pci introduces the VF token to enable SR-IOV support since 5.7. The VF token can be set by a vfio-pci based PF driver and must be known by the vfio-pci based VF driver in order to gain access to the device. Signed-off-by: Haiyue Wang Acked-by: Anatoly Burakov Acked-by: An

Re: [dpdk-dev] [PATCH v14 2/2] eal: support for VFIO-PCI VF token

2020-05-28 Thread Wang, Haiyue
> -Original Message- > From: Ye, Xiaolong > Sent: Friday, May 29, 2020 09:26 > To: Wang, Haiyue > Cc: dev@dpdk.org; Burakov, Anatoly ; > tho...@monjalon.net; > jer...@marvell.com; david.march...@redhat.com; arybche...@solarflare.com > Subject: Re: [dpdk-dev] [PATCH v14 2/2] eal: support

Re: [dpdk-dev] [PATCH v14 2/2] eal: support for VFIO-PCI VF token

2020-05-28 Thread Ye Xiaolong
On 05/28, Haiyue Wang wrote: >The kernel module vfio-pci introduces the VF token to enable SR-IOV >support since 5.7. > >The VF token can be set by a vfio-pci based PF driver and must be known >by the vfio-pci based VF driver in order to gain access to the device. > >Signed-off-by: Haiyue Wang >Ac

Re: [dpdk-dev] [PATCH v1] net/ice: fix PCI DSN to be lowercase values

2020-05-28 Thread Ye Xiaolong
On 05/28, Haiyue Wang wrote: >The PCI DSN (device serial number) to format package file name should be >lowercase values. > >Fixes: d1c91179e952 ("net/ice: check DSN package file firstly") > >Signed-off-by: Haiyue Wang >--- > drivers/net/ice/ice_dcf_parent.c | 4 ++-- > 1 file changed, 2 insertions

[dpdk-dev] [PATCH v3 2/2] build: treat warning as an error on Windows

2020-05-28 Thread Pallavi Kadam
Added -Werror in meson file to consider all the warnings as errors on Windows. Signed-off-by: Pallavi Kadam Reviewed-by: Ranjit Menon --- config/meson.build | 4 1 file changed, 4 insertions(+) diff --git a/config/meson.build b/config/meson.build index 43ab11310..c3c1c0c4e 100644 --- a/co

[dpdk-dev] [PATCH v3 0/2] Fix Windows compiler warnings

2020-05-28 Thread Pallavi Kadam
This patchset fixes all the Windows compiler warnings generated using Clang and MinGW compiler. Henceforth, all the warnings will be treated as errors on Windows. v3 changes: Fixed pthread warning Added -Werror on Windows Fixed MinGW warnings v2 changes: Excluded d

[dpdk-dev] [PATCH v3 1/2] eal: fix warnings on Windows

2020-05-28 Thread Pallavi Kadam
Fixed bunch of warnings when compiling using clang on Windows such as the use of an unsafe string function (strerror), [-Wunused-variable], [-Wunused-function] in eal_common_options.c [-Wunused-const-variable] in getopt.c and [-Wunused-parameter] in eal_common_thread.c. Also fixed warnings generate

Re: [dpdk-dev] [PATCH 3/3] lib: remind experimental status in library headers

2020-05-28 Thread Honnappa Nagarahalli
> > Hello Honnappa, > > On Fri, May 22, 2020 at 4:16 PM Honnappa Nagarahalli > wrote: > > > @@ -11,7 +11,8 @@ > > > * Wireless base band device abstraction APIs. > > > * > > > * @warning > > > - * @b EXPERIMENTAL: this API may change without prior notice > > > + * @b EXPERIMENTAL: > > >

Re: [dpdk-dev] DPDK Release Status Meeting 28/05/2020

2020-05-28 Thread Akhil Goyal
> > Zoom vs Skype > > - > > > > * Linux foundation is providing zoom accounts and should we switch the > meetings > > to the Zoom, as done in the regular CI meetings? > > > > * It seems Skype is not performing well on Linux > > > > * There can be some limitations using Zoom for some

Re: [dpdk-dev] DPDK Release Status Meeting 28/05/2020

2020-05-28 Thread Stephen Hemminger
On Thu, 28 May 2020 16:55:55 +0100 Ferruh Yigit wrote: > Minutes 28 May 2020 > --- > > Agenda: > * Release Dates > * Zoom vs Skype > * 20.05 retrospective > * LTS > > Participants: > * Arm > * Debian/Microsoft > * Intel > * Mellanox > * NXP > * Red Hat > > > Release Dates > --

Re: [dpdk-dev] [PATCH] bus/vmbus: fix wrong allocation for device.name

2020-05-28 Thread Stephen Hemminger
On Thu, 28 May 2020 20:03:07 +0800 wangyunjian wrote: > From: Yunjian Wang > > We do not need and should not allocate memory for device.name. > The device.name should be set point to the devargs->name. > > Fixes: 831dba47bd36 ("bus/vmbus: add Hyper-V virtual bus support") > Cc: sta...@dpdk.org

[dpdk-dev] DPDK Release Status Meeting 28/05/2020

2020-05-28 Thread Ferruh Yigit
Minutes 28 May 2020 --- Agenda: * Release Dates * Zoom vs Skype * 20.05 retrospective * LTS Participants: * Arm * Debian/Microsoft * Intel * Mellanox * NXP * Red Hat Release Dates - * v20.05 is released on Tuesday 26 May * https://mails.dpdk.org/archives/dev/2020-

Re: [dpdk-dev] [EXT] Re: [PATCH 1/3] mbuf: add Tx offloads for packet marking

2020-05-28 Thread Nithin Dabilpuram
Hi Olivier, On Fri, May 15, 2020 at 07:27:46PM +0530, Nithin Dabilpuram wrote: > On Fri, May 15, 2020 at 10:30:30AM +, Ananyev, Konstantin wrote: > > > > > On Thu, May 14, 2020 at 10:29:31PM +0200, Olivier Matz wrote: > > > > Hi Nithin, > > > > > > > > On Tue, May 05, 2020 at 11:49:20AM +0530

Re: [dpdk-dev] [RFC 1/6] eal: add power management intrinsics

2020-05-28 Thread Ananyev, Konstantin
> > Hi Anatoly, > > > >> > >> Add two new power management intrinsics, and provide an implementation > >> in eal/x86 based on UMONITOR/UMWAIT instructions. The instructions > >> are implemented as raw byte opcodes because there is not yet widespread > >> compiler support for these instructions. >

Re: [dpdk-dev] [20.11] [PATCH v2] stack: remove experimental tag from API

2020-05-28 Thread Thomas Monjalon
28/05/2020 17:04, Gage Eads: > The stack library was first released in 19.05, and its interfaces have been > stable since their initial introduction. This commit promotes the full > interface to stable, starting with the 20.11 major version. > > Signed-off-by: Gage Eads > --- > doc/guides/rel_no

[dpdk-dev] [20.11] [PATCH v2] stack: remove experimental tag from API

2020-05-28 Thread Gage Eads
The stack library was first released in 19.05, and its interfaces have been stable since their initial introduction. This commit promotes the full interface to stable, starting with the 20.11 major version. Signed-off-by: Gage Eads --- doc/guides/rel_notes/release_20_11.rst | 3 +++ lib/librte_

Re: [dpdk-dev] [PATCH v2 1/2] devtools: standardize script arguments

2020-05-28 Thread Thomas Monjalon
28/05/2020 16:37, Power, Ciara: > From: Thomas Monjalon > >06/05/2020 11:55, Ciara Power: > >> This patch modifies the arguments expected by the check-git-log > >> script, to match the format of arguments for the checkpatches script. > >> Both scripts now take certain argument options in the same

Re: [dpdk-dev] [RFC 1/6] eal: add power management intrinsics

2020-05-28 Thread Bruce Richardson
On Thu, May 28, 2020 at 03:40:18PM +0100, Burakov, Anatoly wrote: > On 28-May-20 12:39 PM, Ananyev, Konstantin wrote: > > Hi Anatoly, > > > > > > > > Add two new power management intrinsics, and provide an implementation > > > in eal/x86 based on UMONITOR/UMWAIT instructions. The instructions > >

Re: [dpdk-dev] [PATCH v5 04/11] eal/mem: extract common code for memseg list initialization

2020-05-28 Thread Dmitry Kozlyuk
On Thu, 28 May 2020 12:46:49 +0100 "Burakov, Anatoly" wrote: > On 25-May-20 1:37 AM, Dmitry Kozlyuk wrote: > > All supported OS create memory segment lists (MSL) and reserve VA space > > for them in a nearly identical way. Move common code into EAL private > > functions to reduce duplication. > >

Re: [dpdk-dev] [RFC 1/6] eal: add power management intrinsics

2020-05-28 Thread Burakov, Anatoly
On 28-May-20 12:39 PM, Ananyev, Konstantin wrote: Hi Anatoly, Add two new power management intrinsics, and provide an implementation in eal/x86 based on UMONITOR/UMWAIT instructions. The instructions are implemented as raw byte opcodes because there is not yet widespread compiler support for t

Re: [dpdk-dev] [PATCH v2 1/2] devtools: standardize script arguments

2020-05-28 Thread Power, Ciara
Hi Thomas, >-Original Message- >From: Thomas Monjalon >Sent: Sunday 24 May 2020 21:58 >To: Power, Ciara >Cc: dev@dpdk.org >Subject: Re: [dpdk-dev] [PATCH v2 1/2] devtools: standardize script >arguments > >06/05/2020 11:55, Ciara Power: >> This patch modifies the arguments expected by th

Re: [dpdk-dev] [PATCH] stack: remove experimental tag from API

2020-05-28 Thread Bruce Richardson
On Thu, May 28, 2020 at 02:18:32PM +, Eads, Gage wrote: > > > > -Original Message- > > From: Thomas Monjalon > > Sent: Thursday, May 28, 2020 3:11 AM > > To: Eads, Gage ; Ray Kinsella > > Cc: dev@dpdk.org; david.march...@redhat.com; nhor...@tuxdriver.com; > > phil.y...@arm.com; honn

Re: [dpdk-dev] [PATCH] stack: remove experimental tag from API

2020-05-28 Thread Eads, Gage
> -Original Message- > From: Thomas Monjalon > Sent: Thursday, May 28, 2020 3:11 AM > To: Eads, Gage ; Ray Kinsella > Cc: dev@dpdk.org; david.march...@redhat.com; nhor...@tuxdriver.com; > phil.y...@arm.com; honnappa.nagaraha...@arm.com; > olivier.m...@6wind.com > Subject: Re: [PATCH] s

Re: [dpdk-dev] [PATCH v5 05/11] eal/mem: extract common code for dynamic memory allocation

2020-05-28 Thread Dmitry Kozlyuk
On Thu, 28 May 2020 13:21:06 +0100 "Burakov, Anatoly" wrote: > On 25-May-20 1:37 AM, Dmitry Kozlyuk wrote: > > Code in Linux EAL that supports dynamic memory allocation (as opposed to > > static allocation used by FreeBSD) is not OS-dependent and can be reused > > by Windows EAL. Move such code t

Re: [dpdk-dev] [PATCH v2] devtools: remove useless files from ABI reference

2020-05-28 Thread David Marchand
On Sun, May 24, 2020 at 7:43 PM Thomas Monjalon wrote: > > When building an ABI reference with meson, some static libraries > are built and linked in apps. They are useless and take a lot of space. > Those binaries, and other useless files (examples and doc files) > in the share/ directory, are re

Re: [dpdk-dev] [PATCH 20.08 2/9] usertools/dpdk-devbind: support python3 only

2020-05-28 Thread Burakov, Anatoly
On 28-May-20 1:39 PM, Burakov, Anatoly wrote: On 22-May-20 2:23 PM, Louise Kilheeney wrote: Changed script to explicitly use python3 only. Signed-off-by: Louise Kilheeney --- There is a bunch of old cruft in a few scripts, such as python compatibility checks and reimplementation of check_ou

Re: [dpdk-dev] [PATCH 20.08 2/9] usertools/dpdk-devbind: support python3 only

2020-05-28 Thread Burakov, Anatoly
On 22-May-20 2:23 PM, Louise Kilheeney wrote: Changed script to explicitly use python3 only. Signed-off-by: Louise Kilheeney --- There is a bunch of old cruft in a few scripts, such as python compatibility checks and reimplementation of check_output. it would be nice if those were fixed as

Re: [dpdk-dev] [PATCH v2] devtools: forbid variable declaration inside for

2020-05-28 Thread David Marchand
On Sun, May 24, 2020 at 7:30 PM Thomas Monjalon wrote: > > Some compilers raise an error when declaring a variable > in the middle of a function. This is a C99 allowance. > Even if DPDK switches globally to C99 or C11 standard, > the coding rules are for declarations at the beginning > of a block:

Re: [dpdk-dev] [PATCH v5 05/11] eal/mem: extract common code for dynamic memory allocation

2020-05-28 Thread Burakov, Anatoly
On 25-May-20 1:37 AM, Dmitry Kozlyuk wrote: Code in Linux EAL that supports dynamic memory allocation (as opposed to static allocation used by FreeBSD) is not OS-dependent and can be reused by Windows EAL. Move such code to a file compiled only for the OS that require it. Signed-off-by: Dmitry K

Re: [dpdk-dev] [PATCH v5 04/11] eal/mem: extract common code for memseg list initialization

2020-05-28 Thread Burakov, Anatoly
On 25-May-20 1:37 AM, Dmitry Kozlyuk wrote: All supported OS create memory segment lists (MSL) and reserve VA space for them in a nearly identical way. Move common code into EAL private functions to reduce duplication. Signed-off-by: Dmitry Kozlyuk --- +void +eal_memseg_list_populate(struc

Re: [dpdk-dev] [RFC 2/6] ethdev: add simple power management API

2020-05-28 Thread Ananyev, Konstantin
> > Add a simple on/off switch that will enable saving power when no > packets are arriving. It is based on counting the number of empty > polls and, when the number reaches a certain threshold, entering an > architecture-defined optimized power state that will either wait > until a TSC timestamp

[dpdk-dev] [PATCH] bus/vmbus: fix wrong allocation for device.name

2020-05-28 Thread wangyunjian
From: Yunjian Wang We do not need and should not allocate memory for device.name. The device.name should be set point to the devargs->name. Fixes: 831dba47bd36 ("bus/vmbus: add Hyper-V virtual bus support") Cc: sta...@dpdk.org Signed-off-by: Yunjian Wang --- drivers/bus/vmbus/linux/vmbus_bus.

[dpdk-dev] [Bug 486] i40e driver has very bad performance when VXLAN TSO is enabled

2020-05-28 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=486 Bug ID: 486 Summary: i40e driver has very bad performance when VXLAN TSO is enabled Product: DPDK Version: 19.11 Hardware: x86 OS: Linux Status: UNCONFIR

Re: [dpdk-dev] [PATCH v5 03/11] eal: introduce memory management wrappers

2020-05-28 Thread Burakov, Anatoly
On 25-May-20 1:37 AM, Dmitry Kozlyuk wrote: Introduce OS-independent wrappers for memory management operations used across DPDK and specifically in common code of EAL: * rte_mem_map() * rte_mem_unmap() * rte_get_page_size() * rte_mem_lock() Windows uses different APIs for memory mapping and res

Re: [dpdk-dev] [PATCH v5 04/11] eal/mem: extract common code for memseg list initialization

2020-05-28 Thread Burakov, Anatoly
On 25-May-20 1:37 AM, Dmitry Kozlyuk wrote: All supported OS create memory segment lists (MSL) and reserve VA space for them in a nearly identical way. Move common code into EAL private functions to reduce duplication. Signed-off-by: Dmitry Kozlyuk --- +eal_memseg_list_alloc(struct rte_mem

Re: [dpdk-dev] [RFC 1/6] eal: add power management intrinsics

2020-05-28 Thread Ananyev, Konstantin
Hi Anatoly, > > Add two new power management intrinsics, and provide an implementation > in eal/x86 based on UMONITOR/UMWAIT instructions. The instructions > are implemented as raw byte opcodes because there is not yet widespread > compiler support for these instructions. > > The power managemen

Re: [dpdk-dev] [PATCH v5 02/11] eal: introduce internal wrappers for file operations

2020-05-28 Thread Thomas Monjalon
28/05/2020 12:09, Dmitry Kozlyuk: > On Thu, 28 May 2020 09:59:13 +0200 > Thomas Monjalon wrote: > > > 25/05/2020 02:37, Dmitry Kozlyuk: > > > * eal_file_lock: lock or unlock an open file. > > > * eal_file_truncate: enforce a given size for an open file. > > [...] > > > Implementation for Linux

Re: [dpdk-dev] [PATCH v5 03/11] eal: introduce memory management wrappers

2020-05-28 Thread Burakov, Anatoly
On 25-May-20 1:37 AM, Dmitry Kozlyuk wrote: Introduce OS-independent wrappers for memory management operations used across DPDK and specifically in common code of EAL: * rte_mem_map() * rte_mem_unmap() * rte_get_page_size() * rte_mem_lock() Windows uses different APIs for memory mapping and res

Re: [dpdk-dev] [PATCH v5 02/11] eal: introduce internal wrappers for file operations

2020-05-28 Thread Dmitry Kozlyuk
On Thu, 28 May 2020 09:59:13 +0200 Thomas Monjalon wrote: > 25/05/2020 02:37, Dmitry Kozlyuk: > > * eal_file_lock: lock or unlock an open file. > > * eal_file_truncate: enforce a given size for an open file. > [...] > > Implementation for Linux and FreeBSD is placed in "unix" subdirectory, > >

Re: [dpdk-dev] [dpdk-stable] [PATCH] doc: fix API index

2020-05-28 Thread Luca Boccassi
On Thu, 2020-05-28 at 11:14 +0200, David Marchand wrote: > On Wed, May 27, 2020 at 2:17 PM David Marchand > wrote: > > > With Doxygen 1.8.18, a warning appears when tagging > > > the main markdown header with {#index}. > > > That's why the tag has been removed from the API index in DPDK 20.05. > >

Re: [dpdk-dev] [PATCH v5 04/11] eal/mem: extract common code for memseg list initialization

2020-05-28 Thread Dmitry Kozlyuk
On Thu, 28 May 2020 09:31:54 +0200 Thomas Monjalon wrote: > 25/05/2020 02:37, Dmitry Kozlyuk: > > All supported OS create memory segment lists (MSL) and reserve VA space > > for them in a nearly identical way. Move common code into EAL private > > functions to reduce duplication. > > > > Signed-

Re: [dpdk-dev] [PATCH v3] net/ixgbe: include QPRDC in imissed stat

2020-05-28 Thread Zhao1, Wei
Hi, Harris, Cody I have reply in other mail for " why imissed doesn't include it ", thanks. > -Original Message- > From: Harris, Cody > Sent: Thursday, May 28, 2020 4:17 PM > To: Zhao1, Wei ; dev@dpdk.org > Cc: Ye, Xiaolong ; Guo, Jia > Subject: Re: [dpdk-dev] [PATCH v3] net/ixgbe: in

[dpdk-dev] [PATCH v2] net/mlx5: fix interrupt installation timing

2020-05-28 Thread Suanming Mou
Currently, the DevX counter query works asynchronously with Devx interrupt handler return the query result. When port closes, the interrupt handler will be uninstalled and the Devx comp obj will also be destroyed. Meanwhile the query is still not cancelled. In this case, counter query may use the

Re: [dpdk-dev] [PATCH] doc: fix API index

2020-05-28 Thread David Marchand
On Wed, May 27, 2020 at 2:17 PM David Marchand wrote: > > With Doxygen 1.8.18, a warning appears when tagging > > the main markdown header with {#index}. > > That's why the tag has been removed from the API index in DPDK 20.05. > > Unfortunately it makes the index page classified as a standard > >

[dpdk-dev] [PATCH 3/3] l3fwd-power: add interrupt-only mode

2020-05-28 Thread Anatoly Burakov
In addition to existing modes, add a mode which is very similar to legacy mode, but does not do frequency scaling, and thus does not depend on the power library. Signed-off-by: Anatoly Burakov --- examples/l3fwd-power/main.c | 215 +--- 1 file changed, 202 inserti

[dpdk-dev] [PATCH 2/3] l3fwd-power: only allow supported power library envs

2020-05-28 Thread Anatoly Burakov
Currently, l3fwd-power will attempt to run even if the power env is set to KVM, which is not supported. Fix this by preventing the app from initializing unless the env is set to one of the supported modes. Signed-off-by: Anatoly Burakov --- examples/l3fwd-power/main.c | 9 + 1 file chang

[dpdk-dev] [PATCH 0/3] Add interrupt-only mode to l3fwd-power

2020-05-28 Thread Anatoly Burakov
Since 20.05, l3fwd-power has become much more stringent about whether it allows initialization without initializing the librte_power library with it. This means that while previously the app could have been used to test RX interrupts functionality even if the app itself was in a half-working state,

[dpdk-dev] [PATCH 1/3] l3fwd-power: disable interrupts by default

2020-05-28 Thread Anatoly Burakov
Currently, interrupts are enabled in telemetry and empty poll modes, but they are not used. Switch to disabling interrupts by default, and only enable interrupts for modes that require them. Signed-off-by: Anatoly Burakov --- examples/l3fwd-power/main.c | 12 +++- 1 file changed, 7 inser

[dpdk-dev] [PATCH v2] vhost: enable reply-ack systematically

2020-05-28 Thread Maxime Coquelin
As announced during v20.05 release cycle, this patch makes reply-ack protocol feature to be enabled unconditionally. This protocol feature makes the communication between the master and the slave more robust, avoiding for example possible undefined behaviour with VHOST_USER_SET_MEM_TABLE. Also, r

Re: [dpdk-dev] [PATCH v2 5/5] bpf: x86 JIT support for packet data load instructions

2020-05-28 Thread Morten Brørup
> From: Konstantin Ananyev [mailto:konstantin.anan...@intel.com] > Sent: Wednesday, May 27, 2020 4:17 PM > > Make x86 JIT to generate native code for > (BPF_ABS | | BPF_LD) and (BPF_IND | | BPF_LD) > instructions. > > Signed-off-by: Konstantin Ananyev > --- [...] > +/* > + * helper function,

Re: [dpdk-dev] [PATCH v5 05/11] eal/mem: extract common code for dynamic memory allocation

2020-05-28 Thread Thomas Monjalon
25/05/2020 02:37, Dmitry Kozlyuk: > Code in Linux EAL that supports dynamic memory allocation (as opposed to > static allocation used by FreeBSD) is not OS-dependent and can be reused > by Windows EAL. Move such code to a file compiled only for the OS that > require it. > > Signed-off-by: Dmitry K

[dpdk-dev] [PATCH] vhost: enable reply-ack systematically

2020-05-28 Thread Maxime Coquelin
As announced dunring v20.05 release cycle, this patch makes reply-ack protocol feature to be enabled unconditionally. This protocol feature makes the communication between the master and the slave more robust, avoiding for example possible undefined behaviour with VHOST_USER_SET_MEM_TABLE. Also,

Re: [dpdk-dev] [PATCH] stack: remove experimental tag from API

2020-05-28 Thread Ray Kinsella
On 28/05/2020 09:10, Thomas Monjalon wrote: > Anyway I think it deserves a comment in the release notes (API section). agreed

Re: [dpdk-dev] [PATCH v3] net/ixgbe: include QPRDC in imissed stat

2020-05-28 Thread Harris, Cody
Hi Zhao Wei, I understand that the QPRDC drop count is available by stats->q_errors. I'm interested to know why imissed doesn't include it. The name imissed makes it sound like the counter counts incoming missed (valid) packets regardless of where the drop occurs during reception. I think the

Re: [dpdk-dev] [PATCH] stack: remove experimental tag from API

2020-05-28 Thread Thomas Monjalon
28/05/2020 07:46, Ray Kinsella: > Hi Gage, > > Do you have any idea. > If the change from experimental to stable symbol is likely to break anyone's > application? > (are folks actively using the api with shared libraries) > > If so, you _may_ consider offering a temporary alias to experimental u

Re: [dpdk-dev] [PATCH v3] net/ixgbe: include QPRDC in imissed stat

2020-05-28 Thread Zhao1, Wei
Hi, Cody Harris More info, you can get the number of dropped packet per queue by stats->q_errors, No need to add this into imissed. > -Original Message- > From: Zhao1, Wei > Sent: Thursday, May 28, 2020 11:54 AM > To: Cody Harris ; dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH v3] net

Re: [dpdk-dev] [PATCH v5 02/11] eal: introduce internal wrappers for file operations

2020-05-28 Thread Thomas Monjalon
25/05/2020 02:37, Dmitry Kozlyuk: > * eal_file_lock: lock or unlock an open file. > * eal_file_truncate: enforce a given size for an open file. [...] > Implementation for Linux and FreeBSD is placed in "unix" subdirectory, > which is intended for common code between the two. Files should be named >

[dpdk-dev] [PATCH 2/3] net/virtio: add reply-ack support to Virtio-user

2020-05-28 Thread Maxime Coquelin
This patch adds support reply-ack vhost-user protocol feature, which is for now only used to ensure VHOST_USER_SET_MEM_TABLE requests are handled by the slave, but later will be used for VHOST_USER_SET_STATUS. Signed-off-by: Maxime Coquelin --- drivers/net/virtio/virtio_user/vhost.h| 6

[dpdk-dev] [PATCH 3/3] net/virtio: add Virtio status support to Virtio-user

2020-05-28 Thread Maxime Coquelin
This patch adds support for VHOST_USER_SET_STATUS request. It is used to make the backend aware of Virtio devices status update. It is useful for the backend to know when the Virtio driver is done with the Virtio device configuration. Signed-off-by: Maxime Coquelin --- drivers/net/virtio/virtio

[dpdk-dev] [PATCH 0/3] net/virtio: add Vhost-user protocol features

2020-05-28 Thread Maxime Coquelin
This series adds Vhost-user protocol features support to Virtio-user PMD's Vhost-user backend. The first patch introduces protocol features negotiation, and the second one reply-ack feature. The third patch adds support to the SET_STATUS request, which is not merged upstream yet. Neither in DPDK

[dpdk-dev] [PATCH 1/3] net/virtio: add vhost-user protocol features support

2020-05-28 Thread Maxime Coquelin
This patch adds support for Vhost-user protocol features. It is required to support protocol features that were not in initial Vhost-user specification, such as reply-ack, MTU... Also, this patch prevents Virtio multiqueue feature negotiation if the slave does not support MQ protocol feature as st

Re: [dpdk-dev] [PATCH v5 04/11] eal/mem: extract common code for memseg list initialization

2020-05-28 Thread Thomas Monjalon
25/05/2020 02:37, Dmitry Kozlyuk: > All supported OS create memory segment lists (MSL) and reserve VA space > for them in a nearly identical way. Move common code into EAL private > functions to reduce duplication. > > Signed-off-by: Dmitry Kozlyuk > --- > +void > +eal_memseg_list_populate(struct

[dpdk-dev] [PATCH v2] net/mlx5: fix secondary process resources release

2020-05-28 Thread Suanming Mou
When secondary process starts, it will allocate its own process private data, and also does remap to UAR register of the Tx queue. Once the secondary process exits, these resources should be released accordingly. And the shared resources owned by primary should not be touched. Currently, once one