Re: [dpdk-dev] [PATCH v8 01/13] common/dpaax: move internal symbols into INTERNAL section

2020-05-18 Thread Ray Kinsella
Working on it at the moment Hemant. Ray K On 19/05/2020 07:43, Hemant Agrawal wrote: > Hi Ray, > Will you please review and ack this series?. > > Regards, > Hemant > >> -Original Message- >> From: Hemant Agrawal >> Sent: Friday, May 15, 2020 3:18 PM >> To: dev@dpdk.org; david.mar

Re: [dpdk-dev] [PATCH v8 01/13] common/dpaax: move internal symbols into INTERNAL section

2020-05-18 Thread Hemant Agrawal
Hi Ray, Will you please review and ack this series?. Regards, Hemant > -Original Message- > From: Hemant Agrawal > Sent: Friday, May 15, 2020 3:18 PM > To: dev@dpdk.org; david.march...@redhat.com; m...@ashroe.eu > Cc: Hemant Agrawal > Subject: [PATCH v8 01/13] common/dpaax: move

Re: [dpdk-dev] [PATCH v2] vhost: fix zero-copy cannot be enabled

2020-05-18 Thread Ye Xiaolong
On 05/13, Xuan Ding wrote: >This patch fixes the situation where vhost-user cannot start as server with >dequeue_zero_copy enabled. > >Using flag instead of vsocket->is_server to determine whether vhost-user is >in client mode. Because vsocket->is_server is not ready at this time. > >Cc: sta...@dpd

Re: [dpdk-dev] [PATCH] cryptodev: fix SHA-1 digest enum comment

2020-05-18 Thread Anoob Joseph
Hi Adam, Akhil, Please see inline. Thanks, Anoob > -Original Message- > From: dev On Behalf Of Adam Dybkowski > Sent: Monday, May 18, 2020 7:54 PM > To: dev@dpdk.org; fiona.tr...@intel.com; akhil.go...@nxp.com > Cc: Adam Dybkowski ; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH] cryptode

[dpdk-dev] [PATCH 2/2] bus/fslmc: fix check for vfio_group_fd

2020-05-18 Thread wangyunjian
From: Yunjian Wang The issue is that a file descriptor at 0 is a valid one. Currently the file not found, the return value will be set to 0. As a result, it is impossible to distinguish between a correct descriptor and a failed return value. Fix it to return -ENOENT instead of 0. Fixes: a69f7930

[dpdk-dev] [PATCH 1/2] vfio: fix check for vfio_group_fd

2020-05-18 Thread wangyunjian
From: Yunjian Wang The issue is that a file descriptor at 0 is a valid one. Currently the file not found, the return value will be set to 0. As a result, it is impossible to distinguish between a correct descriptor and a failed return value. Fix it to return -ENOENT instead of 0. Fixes: b758423b

[dpdk-dev] [PATCH 0/2] fixes for vfio

2020-05-18 Thread wangyunjian
From: Yunjian Wang This series include two fixes patches for vfio. Yunjian Wang (2): vfio: fix check for vfio_group_fd bus/fslmc: fix check for vfio_group_fd drivers/bus/fslmc/fslmc_vfio.c | 9 ++--- lib/librte_eal/linux/eal_vfio.c | 23 +-- lib/li

Re: [dpdk-dev] [dpdk-dev v2] net/iavf: fix VF reset issue for hash

2020-05-18 Thread Ye Xiaolong
On 05/19, Jeff Guo wrote: >Since there are some default rss configure in kernel PF/VF but not DPDK >IAVF, if these configurations be modified by VF and then VF reset, this >default rss configurations can not be reset to default by IAVF. So need >to add default rss set in IAVF hash initial process.

[dpdk-dev] [dpdk-dev v2] net/iavf: fix VF reset issue for hash

2020-05-18 Thread Jeff Guo
Since there are some default rss configure in kernel PF/VF but not DPDK IAVF, if these configurations be modified by VF and then VF reset, this default rss configurations can not be reset to default by IAVF. So need to add default rss set in IAVF hash initial process. Signed-off-by: Jeff Guo Fixe

[dpdk-dev] [dpdk-dev v2] net/iavf: fix VF reset issue for hash

2020-05-18 Thread Jeff Guo
Since there are some default rss configure in kernel PF/VF but not DPDK IAVF, if these configurations be modified by VF and then VF reset, this default rss configurations can not be reset to default by IAVF. So need to add default rss set in IAVF hash initial process. Signed-off-by: Jeff Guo Fixe

[dpdk-dev] [PATCH] doc: add release notes for Hisilicon hns3 PMD driver

2020-05-18 Thread Wei Hu (Xavier)
Add release notes for Hisilicon hns3 PMD driver. Signed-off-by: Wei Hu (Xavier) --- doc/guides/rel_notes/release_20_05.rst | 7 +++ 1 file changed, 7 insertions(+) diff --git a/doc/guides/rel_notes/release_20_05.rst b/doc/guides/rel_notes/release_20_05.rst index 2e94566..1496e52 100644 ---

Re: [dpdk-dev] [PATCH v2] net/i40e: fix queue related exception handling

2020-05-18 Thread Ye Xiaolong
On 05/18, Qiming Yang wrote: >There should have different behavior in queue start fail and stop fail case. >When queue start fail, all the next actions should be terminated and then >started queues should be cleared. But for queue stop stage, one queue stop >fail should not end other queues stop. T

Re: [dpdk-dev] [PATCH v4] doc: update bnxt guide

2020-05-18 Thread Ajit Khaparde
On Mon, May 18, 2020 at 10:58 AM Ajit Khaparde wrote: > - Update list of supported adapters. > - Update list of supported features. > - Add some details to describe the features. > - Remove obsolete limitations. > - Fix and update links. > > Signed-off-by: JP Lee > Signed-off

Re: [dpdk-dev] net/iavf: fix VF reset issue for hash

2020-05-18 Thread Jeff Guo
hi, xiaolong On 5/19/2020 7:54 AM, Ye Xiaolong wrote: On 05/18, Jeff Guo wrote: Since there are some default rss configure in kernel PF/VF but not DPDK IAVF, if these configurations be modified by VF and then VF reset, this default rss configurations can not be reset to default by IAVF. So need

Re: [dpdk-dev] [PATCH] net/ice: fix RSS for GTPU

2020-05-18 Thread Ye Xiaolong
On 05/13, Qi Zhang wrote: >All supported pattern for GTPU include extend header: >pattern_eth_ipv4_gtpu_eh_ipv4 >pattern_eth_ipv4_gtpu_eh_ipv4_udp >pattern_eth_ipv4_gtpu_eh_ipv4_tcp > >So the RSS rule should only take effect on GTPU packet that contains >extend header. The patch fix above issue and

Re: [dpdk-dev] [PATCH v5] net/i40e: fix the core dump risk of wild pointer operation

2020-05-18 Thread Ye Xiaolong
On 05/18, Wei Zhao wrote: >In i40e PMD code of function i40e_res_pool_free(), if valid_entry >is freed by "rte_free(valid_entry);" in the code, then the following >code for pool update may still use the wild pointer "valid_entry" >for pool info update. It seems has the risk of core dump for >using

Re: [dpdk-dev] [PATCH] net/ixgbe/base: update copyright

2020-05-18 Thread Zhao1, Wei
Reviewed-by: Wei Zhao > -Original Message- > From: Li, Xiaoyun > Sent: Monday, May 18, 2020 4:42 PM > To: Yigit, Ferruh ; Ye, Xiaolong > ; Zhang, Qi Z > Cc: Zhao1, Wei ; Guo, Jia ; > dev@dpdk.org; Li, Xiaoyun ; sta...@dpdk.org > Subject: [PATCH] net/ixgbe/base: update copyright > > Cl

Re: [dpdk-dev] [dpdk-stable] [PATCH v2 2/2] net/e1000: fix defects of macro in VF

2020-05-18 Thread Zhao1, Wei
> -Original Message- > From: Ye, Xiaolong > Sent: Tuesday, May 19, 2020 7:39 AM > To: Zhao1, Wei > Cc: Sun, GuinanX ; dev@dpdk.org; sta...@dpdk.org; > Min, JiaqiX ; Yigit, Ferruh > Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2 2/2] net/e1000: fix defects of > macro in VF > > Hi, we

Re: [dpdk-dev] [PATCH 20.08] telemetry: add upper limit on connections

2020-05-18 Thread Stephen Hemminger
On Mon, 18 May 2020 17:12:32 +0100 Ciara Power wrote: > This patch limits the number of client connections to the new telemetry > socket. The limit is set at 10. > > Signed-off-by: Ciara Power The upper limit is fine, but using System V semaphores is not a good way to do this. Please consider

Re: [dpdk-dev] net/iavf: fix VF reset issue for hash

2020-05-18 Thread Ye Xiaolong
On 05/18, Jeff Guo wrote: >Since there are some default rss configure in kernel PF/VF but not DPDK >IAVF, if these configurations be modified by VF and then VF reset, this >default rss configurations can not be reset to default by IAVF. So need >to add default rss set in IAVF hash initial process.

Re: [dpdk-dev] [dpdk-stable] [PATCH v2 2/2] net/e1000: fix defects of macro in VF

2020-05-18 Thread Ye Xiaolong
Hi, wei On 05/18, Zhao1, Wei wrote: >Hi, xiaolong > >> -Original Message- >> From: dev On Behalf Of Ye Xiaolong >> Sent: Monday, May 18, 2020 9:25 AM >> To: Sun, GuinanX >> Cc: dev@dpdk.org; sta...@dpdk.org >> Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2 2/2] net/e1000: fix defects >

[dpdk-dev] [PATCH v7 1/3] timer: move from common to Unix directory

2020-05-18 Thread Fady Bader
Eal common timer doesn't compile under Windows. Compilation log: error LNK2019: unresolved external symbol nanosleep referenced in function rte_delay_us_sleep error LNK2019: unresolved external symbol get_tsc_freq referenced in function set_tsc_freq error LNK2019: unresolved external symbol sleep

[dpdk-dev] [PATCH v7 3/3] timer: support EAL functions on Windows

2020-05-18 Thread Fady Bader
Implemented the needed Windows eal timer functions. Signed-off-by: Fady Bader --- lib/librte_eal/common/meson.build | 1 + lib/librte_eal/windows/eal.c| 6 +++ lib/librte_eal/windows/eal_timer.c | 86 + lib/librte_eal/windows/include/rte_o

[dpdk-dev] [PATCH v7 2/3] eal: proc type function for Windows

2020-05-18 Thread Fady Bader
Implementation of rte_proc_type_t for Windows as it is needed for Windows eal timer. Signed-off-by: Fady Bader --- lib/librte_eal/windows/eal.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/lib/librte_eal/windows/eal.c b/lib/librte_eal/windows/eal.c index d084606a6..feee91244 100644

[dpdk-dev] [PATCH v7 0/3] eal timer split and implementation for Windows

2020-05-18 Thread Fady Bader
This patchset splits OS dependent EAL timer functions and implements them for windows. v2: * fixing styles and correctness errors. v3: * fixing correctness, get_tsc_freq was reimplemented. v4: * rebasing to the new version of "Windows basic memory management" series. * fixing styl

Re: [dpdk-dev] [PATCH v4 8/8] eal/windows: implement basic memory management

2020-05-18 Thread Dmitry Kozlyuk
On Mon, 18 May 2020 03:17:04 +0300 Dmitry Kozlyuk wrote: > On Wed, 13 May 2020 12:25:10 + > Fady Bader wrote: > [snip] > > > > > > I meant the code of the application that calls > > > rte_mempool_create(). Or is it one of the DPDK test applications? > > > > > > > I got it from dpdk\app

Re: [dpdk-dev] [PATCH v2] eal: fix warnings on Windows

2020-05-18 Thread Narcisa Ana Maria Vasile
On Thu, May 14, 2020 at 01:39:45PM -0700, Pallavi Kadam wrote: > This patch fixes bunch of warnings when compiling on Windows > such as the use of an unsafe string function (strerror), > [-Wunused-const-variable] in getopt.c and > [-Wunused-variable], [-Wunused-function] in eal_common_options.c >

[dpdk-dev] [PATCH v4] doc: update bnxt guide

2020-05-18 Thread Ajit Khaparde
- Update list of supported adapters. - Update list of supported features. - Add some details to describe the features. - Remove obsolete limitations. - Fix and update links. Signed-off-by: JP Lee Signed-off-by: Ajit Khaparde Acked-by: Kovacevic Marko --- v1->v2: Some lines w

Re: [dpdk-dev] [PATCH v2 3/5] doc: add cycles per packet in testpmd user guide

2020-05-18 Thread Dharmik Thakkar
> On May 18, 2020, at 4:47 AM, Ferruh Yigit wrote: > > On 5/15/2020 9:33 PM, Dharmik Thakkar wrote: >> Hi Ferruh, >> >>> On May 15, 2020, at 7:15 AM, Ferruh Yigit wrote: >>> >>> On 5/8/2020 11:38 PM, Dharmik Thakkar wrote: Update documentation for 'show fwd' testpmd runtime function to

[dpdk-dev] [PATCH v3] doc: update bnxt guide

2020-05-18 Thread Ajit Khaparde
- Update list of supported adapters. - Update list of supported features. - Add some details to describe the features. - Remove obsolete limitations. - Fix and update links. Signed-off-by: JP Lee Signed-off-by: Ajit Khaparde Acked-by: Kovacevic Marko --- v1->v2: Some lines w

Re: [dpdk-dev] [PATCH] eal: fix lcore state bug

2020-05-18 Thread Lukasz Wojciechowski
W dniu 18.05.2020 o 20:39, David Marchand pisze: > On Mon, May 18, 2020 at 8:25 PM Lukasz Wojciechowski > wrote: >> Hi David, >> >> The patch is here for quite a while and I believe it's assign to you. >> Today there were some questions about it on >> https://protect2.fireeye.com/url?k=a0a7498c-

Re: [dpdk-dev] [PATCH] eal: fix lcore state bug

2020-05-18 Thread David Marchand
On Mon, May 18, 2020 at 8:25 PM Lukasz Wojciechowski wrote: > > Hi David, > > The patch is here for quite a while and I believe it's assign to you. > Today there were some questions about it on > https://bugs.dpdk.org/show_bug.cgi?id=464 > > Is there anything else to be done, so it can be accepted

Re: [dpdk-dev] [PATCH v6] abi: provide experimental alias of API for old apps

2020-05-18 Thread Ferruh Yigit
On 5/18/2020 6:51 PM, Thomas Monjalon wrote: > 18/05/2020 19:34, Ferruh Yigit: >> On 5/18/2020 6:18 PM, Thomas Monjalon wrote: >>> 16/05/2020 13:53, Neil Horman: On Fri, May 15, 2020 at 04:01:53PM +0100, Ray Kinsella wrote: > From: Ferruh Yigit > > On v20.02 some APIs matured and

[dpdk-dev] [PATCH v5] meter: provide experimental alias of API for old apps

2020-05-18 Thread Ferruh Yigit
On v20.02 some meter APIs have been matured and symbols moved from EXPERIMENTAL to DPDK_20.0.1 block. This can break the applications that were using these mentioned APIs on v19.11. Although there is no modification on the APIs and the action is positive and matures the APIs, the affect can be neg

Re: [dpdk-dev] [PATCH] eal: fix lcore state bug

2020-05-18 Thread Lukasz Wojciechowski
Hi David, The patch is here for quite a while and I believe it's assign to you. Today there were some questions about it on https://bugs.dpdk.org/show_bug.cgi?id=464 Is there anything else to be done, so it can be accepted? Best regards Lukasz W dniu 28.04.2020 o 03:21, Lukasz Wojciechowski pi

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/igc: update copyright

2020-05-18 Thread Ferruh Yigit
On 5/18/2020 11:44 AM, Ferruh Yigit wrote: > On 5/18/2020 10:13 AM, Xiaoyun Li wrote: >> Clarify Intel copyright and update the date to 2020. >> >> Fixes: 8cb7c57d9b3c ("net/igc: support device initialization") >> Cc: sta...@dpdk.org >> >> Signed-off-by: Xiaoyun Li > > Reviewed-by: Ferruh Yigit

Re: [dpdk-dev] [dpdk-stable] [PATCH] common/iavf: update copyright

2020-05-18 Thread Ferruh Yigit
On 5/18/2020 11:43 AM, Ferruh Yigit wrote: > On 5/18/2020 9:45 AM, Xiaoyun Li wrote: >> Clarify Intel copyright and update the date to 2020. >> >> Fixes: 317862a4e44f ("net/iavf: replace license text with SPDX tag") >> Cc: sta...@dpdk.org >> >> Signed-off-by: Xiaoyun Li > > Reviewed-by: Ferruh Yi

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/ice: update copyright

2020-05-18 Thread Ferruh Yigit
On 5/18/2020 11:44 AM, Ferruh Yigit wrote: > On 5/18/2020 10:07 AM, Xiaoyun Li wrote: >> Clarify Intel copyright and update the date to 2020. >> >> Fixes: f3202a097f12 ("net/ice/base: add ACL module") >> Fixes: a90fae1d0755 ("net/ice/base: add admin queue structures and commands") >> Fixes: 2d2bdc0

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/i40e/base: update copyright

2020-05-18 Thread Ferruh Yigit
On 5/18/2020 11:42 AM, Ferruh Yigit wrote: > On 5/18/2020 9:44 AM, Xiaoyun Li wrote: >> Clarify Intel copyright and update the date to 2020. >> >> Fixes: 547be3f01f55 ("net/i40e/base: replace license text with SPDX tag") >> Cc: sta...@dpdk.org >> >> Signed-off-by: Xiaoyun Li > > Reviewed-by: Ferr

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/ixgbe/base: update copyright

2020-05-18 Thread Ferruh Yigit
On 5/18/2020 11:42 AM, Ferruh Yigit wrote: > On 5/18/2020 9:41 AM, Xiaoyun Li wrote: >> Clarify Intel copyright and update the date to 2020. >> >> Fixes: 9db3087f4f77 ("net/ixgbe/base: update the license") >> Cc: sta...@dpdk.org >> >> Signed-off-by: Xiaoyun Li > > Reviewed-by: Ferruh Yigit > A

Re: [dpdk-dev] [PATCH v6] abi: provide experimental alias of API for old apps

2020-05-18 Thread Thomas Monjalon
18/05/2020 19:34, Ferruh Yigit: > On 5/18/2020 6:18 PM, Thomas Monjalon wrote: > > 16/05/2020 13:53, Neil Horman: > >> On Fri, May 15, 2020 at 04:01:53PM +0100, Ray Kinsella wrote: > >>> From: Ferruh Yigit > >>> > >>> On v20.02 some APIs matured and symbols moved from EXPERIMENTAL to > >>> DPDK_20

Re: [dpdk-dev] [PATCH] eal/windows: support thread ID query

2020-05-18 Thread Dmitry Kozlyuk
On Mon, 18 May 2020 17:26:34 +0300 Tasnim Bashar wrote: > Add rte_sys_gettid function to use rte_gettid() on Windows. > rte_gettid() is required for recursive spin lock and recursive ticket > lock. > > Signed-off-by: Tasnim Bashar > --- > lib/librte_eal/windows/eal_thread.c | 6 ++ > 1 fil

Re: [dpdk-dev] [PATCH v6] abi: provide experimental alias of API for old apps

2020-05-18 Thread Ferruh Yigit
On 5/18/2020 6:18 PM, Thomas Monjalon wrote: > 16/05/2020 13:53, Neil Horman: >> On Fri, May 15, 2020 at 04:01:53PM +0100, Ray Kinsella wrote: >>> From: Ferruh Yigit >>> >>> On v20.02 some APIs matured and symbols moved from EXPERIMENTAL to >>> DPDK_20.0.1 block. >>> >>> This had the affect of bre

Re: [dpdk-dev] [PATCH v6] abi: provide experimental alias of API for old apps

2020-05-18 Thread Thomas Monjalon
16/05/2020 13:53, Neil Horman: > On Fri, May 15, 2020 at 04:01:53PM +0100, Ray Kinsella wrote: > > From: Ferruh Yigit > > > > On v20.02 some APIs matured and symbols moved from EXPERIMENTAL to > > DPDK_20.0.1 block. > > > > This had the affect of breaking the applications that were using these >

Re: [dpdk-dev] [PATCH v2] app/testpmd: fix DCB set failure

2020-05-18 Thread Ferruh Yigit
On 5/12/2020 11:13 AM, Ting Xu wrote: > When set DCB in testpmd, there is a segmentation fault. It is > because the local variable rss_conf in get_eth_dcb_conf() > is not cleared, so that the pointer member variable rss_key has > a random address, which leads to an error in the following > processi

Re: [dpdk-dev] [pull-request] next-eventdev 20.05-rc3

2020-05-18 Thread Thomas Monjalon
14/05/2020 15:24, Jerin Jacob Kollanukkaran: > http://dpdk.org/git/next/dpdk-next-eventdev Pulled, thanks

Re: [dpdk-dev] [pull-request] next-crypto 20.05 rc3

2020-05-18 Thread Thomas Monjalon
17/05/2020 16:12, Akhil Goyal: > http://dpdk.org/git/next/dpdk-next-crypto Pulled, thanks

Re: [dpdk-dev] [PATCH v3] doc: fix references to bind_default_symbol

2020-05-18 Thread Thomas Monjalon
06/05/2020 17:41, Ray Kinsella: > The document abi_versioning.rst incorrectly instructs the developer to > add BIND_DEFAULT_SYMBOL to the public header, not the source file. This > commit fixes the issue and adds some clarifications. > > The commit also clarifies the use of use_function_versioning

Re: [dpdk-dev] [PATCH] eal: remove register from function parameter in headers

2020-05-18 Thread David Marchand
On Mon, May 11, 2020 at 11:05 AM Bruce Richardson wrote: > > On Mon, May 11, 2020 at 09:56:10AM +0100, Burakov, Anatoly wrote: > > On 09-May-20 12:25 AM, Stephen Hemminger wrote: > > > Compiling a C++ application that includes directly or indirectly > > > rte_common.h will cause a warning: > > > >

Re: [dpdk-dev] [dpdk-stable] [PATCH v5] ethdev: fix DCB set failure

2020-05-18 Thread Ferruh Yigit
On 5/13/2020 2:28 PM, Ferruh Yigit wrote: > On 5/13/2020 6:16 PM, Ting Xu wrote: >> When rte_eth_dev_rss_hash_conf_get() is called, if the variable >> rss_conf is not initialized, the pointer member variable rss_key >> may have a random address, which leads to an error in the following >> processin

Re: [dpdk-dev] [PATCH v5] ethdev: fix DCB set failure

2020-05-18 Thread Ferruh Yigit
On 5/18/2020 3:57 PM, Matan Azrad wrote: > > Hi > > From: Andrew Rybchenko >> CC net/nfp maintainer >> >> On 5/13/20 8:16 PM, Ting Xu wrote: >>> When rte_eth_dev_rss_hash_conf_get() is called, if the variable >>> rss_conf is not initialized, the pointer member variable rss_key may >>> have a ran

Re: [dpdk-dev] [PATCH v5] ethdev: fix DCB set failure

2020-05-18 Thread Ferruh Yigit
On 5/18/2020 2:32 PM, Andrew Rybchenko wrote: > CC net/nfp maintainer > > On 5/13/20 8:16 PM, Ting Xu wrote: >> When rte_eth_dev_rss_hash_conf_get() is called, if the variable >> rss_conf is not initialized, the pointer member variable rss_key >> may have a random address, which leads to an error

Re: [dpdk-dev] [PATCH v2] abi: document reasons behind the three part versioning

2020-05-18 Thread Thomas Monjalon
05/05/2020 10:56, Ray Kinsella: > Clarify the reasons behind the three part version numbering scheme. > Documents the fixes made in f26c2b3. > > Fixes: f26c2b39b271 ("build: fix soname info for 19.11 compatibility") > > Signed-off-by: Ray Kinsella > Signed-off-by: Bruce Richardson > --- > v2: >

[dpdk-dev] [PATCH 20.08] telemetry: add upper limit on connections

2020-05-18 Thread Ciara Power
This patch limits the number of client connections to the new telemetry socket. The limit is set at 10. Signed-off-by: Ciara Power --- lib/librte_telemetry/telemetry.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/lib/librte_telemetry/telemetry.c b/lib/librte_telemetry/telemetr

[dpdk-dev] [PATCH 5/5] bpf: x86 JIT support for packet data load instructions

2020-05-18 Thread Konstantin Ananyev
Make x86 JIT to generate native code for (BPF_ABS | | BPF_LD) and (BPF_IND | | BPF_LD) instructions. Signed-off-by: Konstantin Ananyev --- lib/librte_bpf/bpf_jit_x86.c | 181 ++ lib/librte_bpf/bpf_validate.c | 17 +++- 2 files changed, 197 insertions(+), 1 del

Re: [dpdk-dev] [PATCH] doc: add rcu defer queue API info

2020-05-18 Thread David Marchand
On Wed, May 6, 2020 at 5:54 AM Honnappa Nagarahalli wrote: > > Added notes about RCU defer queue APIs. > > Signed-off-by: Honnappa Nagarahalli > --- > doc/guides/rel_notes/release_20_05.rst | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/doc/guides/rel_notes/release_20_05.rst >

[dpdk-dev] [PATCH 1/5] test/bpf: fix few small issues

2020-05-18 Thread Konstantin Ananyev
Address for few small issues: - unreachable return statement - failed test-case can finish with 'success' status Also use unified cmp_res() function to check return value. Fixes: a9de470cc7c0 ("test: move to app directory") Cc: sta...@dpdk.org Signed-off-by: Konstantin Ananyev --- app/test/t

[dpdk-dev] [PATCH 4/5] test/bpf: add new test cases for mbuf load instructions

2020-05-18 Thread Konstantin Ananyev
Add new test-cases for BPF_ABS/BPF_IND load instructions. Signed-off-by: Konstantin Ananyev --- app/test/test_bpf.c | 463 1 file changed, 463 insertions(+) diff --git a/app/test/test_bpf.c b/app/test/test_bpf.c index 4a61a7d7c..7c3de96c6 100644 ---

[dpdk-dev] [PATCH 2/5] bpf: fix add/sub min/max estimations

2020-05-18 Thread Konstantin Ananyev
eval_add()/eval_sub() not always correctly estimate minimum and maximum possible values of add/sub operations. Fixes: 8021917293d0 ("bpf: add extra validation for input BPF program") Cc: sta...@dpdk.org Signed-off-by: Konstantin Ananyev --- lib/librte_bpf/bpf_validate.c | 10 +- 1 file

[dpdk-dev] [PATCH 3/5] bpf: add support for packet data load instructions

2020-05-18 Thread Konstantin Ananyev
To fill the gap with linux kernel eBPF implementation, add support for two non-generic instructions: (BPF_ABS | | BPF_LD) and (BPF_IND | | BPF_LD) which are used to access packet data. These instructions can only be used when BPF context is a pointer to 'struct rte_mbuf' (i.e: RTE_BPF_ARG_PTR_MBU

[dpdk-dev] [PATCH 0/5] bpf: add support for BPF_ABS/BPF_IND instructions

2020-05-18 Thread Konstantin Ananyev
To fill the gap with linux kernel eBPF implementation, add support for two non-generic instructions: (BPF_ABS | | BPF_LD) and (BPF_IND | | BPF_LD) which are used to access packet data. Make necessary changes in BPF verifier, interpreter and x86 JIT code. Konstantin Ananyev (5): test/bpf: fix f

Re: [dpdk-dev] [PATCH] doc: fix wrong config option

2020-05-18 Thread David Marchand
On Tue, May 12, 2020 at 9:49 PM Matteo Croce wrote: > > The documentation says that CONFIG_ENABLE_LTO enables LTO during the > build, but the correct value actually is CONFIG_RTE_ENABLE_LTO > > Fixes: 098cc0fea3be ("build: add option to enable LTO") Cc: sta...@dpdk.org > Signed-off-by: Matteo Cro

Re: [dpdk-dev] [PATCH v2 1/2] common/octeontx2: move internal symbols to INTERNAL section

2020-05-18 Thread David Marchand
On Thu, May 14, 2020 at 2:50 PM David Marchand wrote: > > On Thu, May 14, 2020 at 9:02 AM Ray Kinsella wrote: > > > diff --git a/devtools/libabigail.abignore b/devtools/libabigail.abignore > > > index c9ee73cb3..dfe346db4 100644 > > > --- a/devtools/libabigail.abignore > > > +++ b/devtools/libabi

[dpdk-dev] [dpdk-announce] DPDK 18.11.8 (LTS) released

2020-05-18 Thread Kevin Traynor
Hi all, Here is a new LTS release: https://fast.dpdk.org/rel/dpdk-18.11.8.tar.xz The git tree is at: https://dpdk.org/browse/dpdk-stable/?h=18.11 DPDK 18.11.8 has fixes for CVE-2020-10722, CVE-2020-10723 and CVE-2020-10724. Thanks to the issue reporters, to the developers for fi

Re: [dpdk-dev] [PATCH v5] ethdev: fix DCB set failure

2020-05-18 Thread Matan Azrad
Hi From: Andrew Rybchenko > CC net/nfp maintainer > > On 5/13/20 8:16 PM, Ting Xu wrote: > > When rte_eth_dev_rss_hash_conf_get() is called, if the variable > > rss_conf is not initialized, the pointer member variable rss_key may > > have a random address, which leads to an error in the followi

Re: [dpdk-dev] [PATCH 3/5] telemetry: fix closing socket fd on error

2020-05-18 Thread Laatz, Kevin
On 12/05/2020 16:29, Ciara Power wrote: The socket fd is now being closed when the connection fails. Coverity issue: 358444 Fixes: b80fe1805eee ("telemetry: introduce backward compatibility") Cc: ciara.po...@intel.com Signed-off-by: Ciara Power --- lib/librte_telemetry/telemetry_legacy.c | 1

Re: [dpdk-dev] [PATCH 5/5] telemetry: fix buffer overrun if max bytes read

2020-05-18 Thread Laatz, Kevin
On 12/05/2020 16:29, Ciara Power wrote: If 1024 bytes were received over the socket, this caused buffer_recvf[bytes] to overrun the array. The size of the buffer - 1 is now passed to the read function. Coverity issue: 358442 Fixes: b80fe1805eee ("telemetry: introduce backward compatibility") Cc:

Re: [dpdk-dev] [PATCH 1/5] telemetry: keep telemetry threads separate from data plane

2020-05-18 Thread Laatz, Kevin
On 12/05/2020 16:28, Ciara Power wrote: The threads for listening on the telemetry sockets are control threads and should be separated from those on the data plane. Since telemetry cannot use the rte_ctrl_thread_create() API, as it does not depend on EAL, we pass the ctrl thread cpu_set to teleme

Re: [dpdk-dev] [PATCH 2/5] telemetry: fix error checking for strchr function

2020-05-18 Thread Laatz, Kevin
On 12/05/2020 16:28, Ciara Power wrote: The strchr function return was not being checked which could lead to NULL deferencing later in the function. Coverity issue: 358438 Coverity issue: 358445 Fixes: b80fe1805eee ("telemetry: introduce backward compatibility") Cc: ciara.po...@intel.com Signed

Re: [dpdk-dev] [PATCH 4/5] telemetry: fix checking error return for socket creation

2020-05-18 Thread Laatz, Kevin
On 12/05/2020 16:29, Ciara Power wrote: The return value from the socket function is now checked, as it can return a negative value on error. Coverity issue: 358443 Fixes: b80fe1805eee ("telemetry: introduce backward compatibility") Cc: ciara.po...@intel.com Signed-off-by: Ciara Power --- li

[dpdk-dev] [dpdk-announce] DPDK 19.11.2 released

2020-05-18 Thread Luca Boccassi
Hi all, Here is a new stable release: https://fast.dpdk.org/rel/dpdk-19.11.2.tar.xz The git tree is at: https://dpdk.org/browse/dpdk-stable/?h=19.11 This release fixes the following security issues: CVE-2020-10722 CVE-2020-10723 CVE-2020-10724 CVE-2020-10725 CVE-2020-10726 A ma

[dpdk-dev] [dpdk-announce] DPDK 20.02.1 released

2020-05-18 Thread Luca Boccassi
Hi all, Here is a new stable release: https://fast.dpdk.org/rel/dpdk-20.02.1.tar.xz The git tree is at: https://dpdk.org/browse/dpdk-stable/?h=20.02 This release fixes the following security issues: CVE-2020-10722 CVE-2020-10723 CVE-2020-10724 CVE-2020-10725 CVE-2020-10726 A ma

Re: [dpdk-dev] incorrect vlan_tci in rte mbuf

2020-05-18 Thread Yan, Xiaoping (NSB - CN/Hangzhou)
Hi Beilei & Jia, I got your name from the MAINTAINERS for Intel i40e. Could you help to have a look at the issue, described in my previous mail? Thank you. Best regards Yan Xiaoping -Original Message- From: Olivier Matz Sent: 2020年5月18日 15:24 To: Yan, Xiaoping (NSB - CN/Hangzhou) Cc

[dpdk-dev] [PATCH] eal/windows: support thread ID query

2020-05-18 Thread Tasnim Bashar
Add rte_sys_gettid function to use rte_gettid() on Windows. rte_gettid() is required for recursive spin lock and recursive ticket lock. Signed-off-by: Tasnim Bashar --- lib/librte_eal/windows/eal_thread.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/lib/librte_eal/windows/eal_thread

[dpdk-dev] [PATCH] cryptodev: fix SHA-1 digest enum comment

2020-05-18 Thread Adam Dybkowski
This patch fixes improper SHA-1 digest size in the enum comment. Fixes: 1bd407fac80b ("cryptodev: extract symmetric operations") Cc: sta...@dpdk.org Signed-off-by: Adam Dybkowski --- lib/librte_cryptodev/rte_crypto_sym.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/li

Re: [dpdk-dev] [PATCH 0/6] Fix vhost security issues

2020-05-18 Thread David Marchand
On Mon, May 18, 2020 at 3:17 PM Ferruh Yigit wrote: > > From: Maxime Coquelin > > Marvin Liu (1): > vhost: fix translated address not checked > > Maxime Coquelin (3): > vhost: check log mmap offset and size overflow > vhost: fix vring index check > vhost/crypto: validate keys lengths > >

Re: [dpdk-dev] net/iavf: fix VF reset issue for hash

2020-05-18 Thread Zhang, Qi Z
> -Original Message- > From: He, Zhiwei > Sent: Monday, May 18, 2020 9:15 PM > To: Guo, Jia ; Xing, Beilei ; Ye, > Xiaolong ; Zhang, Qi Z ; Wu, > Jingjing > Cc: dev@dpdk.org; Guo, Jia > Subject: RE: [dpdk-dev] net/iavf: fix VF reset issue for hash > > Test-by Zhiwei.He > > -Ori

Re: [dpdk-dev] [PATCH v5] ethdev: fix DCB set failure

2020-05-18 Thread Andrew Rybchenko
CC net/nfp maintainer On 5/13/20 8:16 PM, Ting Xu wrote: > When rte_eth_dev_rss_hash_conf_get() is called, if the variable > rss_conf is not initialized, the pointer member variable rss_key > may have a random address, which leads to an error in the following > processing. This patch initialized t

[dpdk-dev] [PATCH 6/6] vhost: fix potential fd leak

2020-05-18 Thread Ferruh Yigit
From: Xuan Ding Vhost will create temporary file when receiving VHOST_USER_GET_INFLIGHT_FD message. Malicious guest can send endless this message to drain out the resource of host. When receiving VHOST_USER_GET_INFLIGHT_FD message repeatedly, closing the file created during the last handling of

[dpdk-dev] [PATCH 4/6] vhost: fix translated address not checked

2020-05-18 Thread Ferruh Yigit
From: Marvin Liu Malicious guest can construct desc with invalid address and zero buffer length. That will request vhost to check both translated address and translated data length. This patch will add missed address check. CVE-2020-10725 Fixes: 75ed51697820 ("vhost: add packed ring batch dequeu

[dpdk-dev] [PATCH 1/6] vhost: check log mmap offset and size overflow

2020-05-18 Thread Ferruh Yigit
From: Maxime Coquelin vhost_user_set_log_base() is a message handler that is called to handle the VHOST_USER_SET_LOG_BASE message. Its payload contains a 64 bit size and offset. Both are added up and used as a size when calling mmap(). There is no integer overflow check. If an integer overflow o

[dpdk-dev] [PATCH 5/6] vhost: fix potential memory space leak

2020-05-18 Thread Ferruh Yigit
From: Xiaolong Ye A malicious container which has direct access to the vhost-user socket can keep sending VHOST_USER_GET_INFLIGHT_FD messages which may cause leaking resources until resulting a DOS. Fix it by unmapping the dev->inflight_info->addr before assigning new mapped addr to it. CVE-2020

[dpdk-dev] [PATCH 3/6] vhost/crypto: validate keys lengths

2020-05-18 Thread Ferruh Yigit
From: Maxime Coquelin transform_cipher_param() and transform_chain_param() handle the payload data for the VHOST_USER_CRYPTO_CREATE_SESS message. These payloads have to be validated, since it could come from untrusted sources. Two buffers and their lenghts are defined in this payload, one the th

[dpdk-dev] [PATCH 0/6] Fix vhost security issues

2020-05-18 Thread Ferruh Yigit
From: Maxime Coquelin Marvin Liu (1): vhost: fix translated address not checked Maxime Coquelin (3): vhost: check log mmap offset and size overflow vhost: fix vring index check vhost/crypto: validate keys lengths Xiaolong Ye (1): vhost: fix potential memory space leak Xuan Ding (1):

[dpdk-dev] [PATCH 2/6] vhost: fix vring index check

2020-05-18 Thread Ferruh Yigit
From: Maxime Coquelin vhost_user_check_and_alloc_queue_pair() is used to extract a vring index from a payload. This function validates the index and is called early on in when performing message handling. Most message handlers depend on it correctly validating the vring index. Depending on the m

Re: [dpdk-dev] net/iavf: fix VF reset issue for hash

2020-05-18 Thread He, Zhiwei
Test-by Zhiwei.He -Original Message- From: dev On Behalf Of Jeff Guo Sent: Tuesday, May 19, 2020 8:20 AM To: Xing, Beilei ; Ye, Xiaolong ; Zhang, Qi Z ; Wu, Jingjing Cc: dev@dpdk.org; Guo, Jia Subject: [dpdk-dev] net/iavf: fix VF reset issue for hash Since there are some default rss

Re: [dpdk-dev] [PATCH v4] meter: provide experimental alias of API for old apps

2020-05-18 Thread Ray Kinsella
On 18/05/2020 13:13, Thomas Monjalon wrote: > And I think, because of this goal, you will try to maintain ABI compat > of *ALL* experimental symbols maturing as stable symbol. I think that is a fair point, what we will ultimately need is a way to filter TCs that touch experimental from the Uni

Re: [dpdk-dev] [PATCH] maintainers: add Xavier for bonding

2020-05-18 Thread Ferruh Yigit
On 5/18/2020 12:20 PM, Wei Hu (Xavier) wrote: > Adding Xavier as additional maintainer to bonding. > > Signed-off-by: Wei Hu (Xavier) > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 6a14622..46b6535 100644 > --- a/MAINTAINERS > +++

[dpdk-dev] net/iavf: fix VF reset issue for hash

2020-05-18 Thread Jeff Guo
Since there are some default rss configure in kernel PF/VF but not DPDK IAVF, if these configurations be modified by VF and then VF reset, this default rss configurations can not be reset to default by IAVF. So need to add default rss set in IAVF hash initial process. Signed-off-by: Jeff Guo Fixe

Re: [dpdk-dev] [PATCH v4] meter: provide experimental alias of API for old apps

2020-05-18 Thread Thomas Monjalon
18/05/2020 13:48, Ray Kinsella: > On 18/05/2020 11:46, Thomas Monjalon wrote: > > 18/05/2020 11:30, Ray Kinsella: > >> On 18/05/2020 10:22, Thomas Monjalon wrote: > >>> 18/05/2020 08:29, Ray Kinsella: > On 17/05/2020 20:52, Dumitrescu, Cristian wrote: > > From: Yigit, Ferruh > >> > >>

Re: [dpdk-dev] [PATCH v4] meter: provide experimental alias of API for old apps

2020-05-18 Thread Ray Kinsella
On 18/05/2020 12:18, Dumitrescu, Cristian wrote: > > >> -Original Message- >> From: Thomas Monjalon >> Sent: Monday, May 18, 2020 11:46 AM >> To: Yigit, Ferruh ; Ray Kinsella ; >> Dumitrescu, Cristian >> Cc: Neil Horman ; Eelco Chaudron >> ; dev@dpdk.org; David Marchand >> ; sta...@d

Re: [dpdk-dev] [PATCH] build: disable gcc 10 zero-length-bounds warning

2020-05-18 Thread David Marchand
On Fri, May 15, 2020 at 10:28 AM David Marchand wrote: > On Thu, May 14, 2020 at 3:19 PM Kevin Traynor wrote: > > > > gcc 10 issues warnings about the use of rearm_data marker > > from struct rte_mbuf. > > > > e.g. > > ../drivers/net/enic/enic_rxtx_vec_avx2.c: In function ‘rx_one’: > > ../drivers

Re: [dpdk-dev] [PATCH] hash: fix gcc 10 maybe-uninitialized warning

2020-05-18 Thread David Marchand
On Fri, May 15, 2020 at 4:28 PM Kevin Traynor wrote: > > gcc 10.1.1 reports a warning for the ext_bkt_id variable: > > ../lib/librte_hash/rte_cuckoo_hash.c: > In function ‘__rte_hash_add_key_with_hash’: > ../lib/librte_hash/rte_cuckoo_hash.c:1104:29: > warning: ‘ext_bkt_id’ may be used uninitializ

Re: [dpdk-dev] [PATCH v4] meter: provide experimental alias of API for old apps

2020-05-18 Thread Ray Kinsella
On 18/05/2020 11:46, Thomas Monjalon wrote: > 18/05/2020 11:30, Ray Kinsella: >> On 18/05/2020 10:22, Thomas Monjalon wrote: >>> 18/05/2020 08:29, Ray Kinsella: On 17/05/2020 20:52, Dumitrescu, Cristian wrote: > From: Yigit, Ferruh >> >> On v20.02 some meter APIs have been matu

[dpdk-dev] [PATCH] maintainers: add Xavier for bonding

2020-05-18 Thread Wei Hu (Xavier)
Adding Xavier as additional maintainer to bonding. Signed-off-by: Wei Hu (Xavier) --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 6a14622..46b6535 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -529,6 +529,7 @@ F: doc/guides/nics/features/defaul

Re: [dpdk-dev] [PATCH v4] meter: provide experimental alias of API for old apps

2020-05-18 Thread Dumitrescu, Cristian
> -Original Message- > From: Thomas Monjalon > Sent: Monday, May 18, 2020 11:46 AM > To: Yigit, Ferruh ; Ray Kinsella ; > Dumitrescu, Cristian > Cc: Neil Horman ; Eelco Chaudron > ; dev@dpdk.org; David Marchand > ; sta...@dpdk.org; Luca Boccassi > ; Richardson, Bruce ; > Stokes, Ian ;

Re: [dpdk-dev] Fwd: Re: [PATCH v2 2/2] net/bonding: fix MAC address when one port resets

2020-05-18 Thread Wei Hu (Xavier)
On 2020/5/18 17:55, Ferruh Yigit wrote: On 5/16/2020 10:51 AM, Wei Hu (Xavier) wrote: On 2020/5/16 16:59, Wei Hu (Xavier) wrote: Forwarded Message Subject: Re: [dpdk-dev] [PATCH v2 2/2] net/bonding: fix MAC address when one port resets Date: Fri, 15 May 2020 11:46:30 +01

Re: [dpdk-dev] [PATCH v7 31/32] mempool: add tracepoints

2020-05-18 Thread Jerin Jacob
On Mon, May 18, 2020 at 3:15 PM Fady Bader wrote: > > Hi, > I'm trying to build this patch on Windows and I'm getting a compilation error > because the sizes of long and size_t vary on Windows (see comments down > below). > > > -Original Message- > > From: dev On Behalf Of jer...@marvel

[dpdk-dev] [PATCH v2 3/3] doc: update vm_power_manager cmdline options in doc

2020-05-18 Thread Sexton, Rory
Signed-off-by: Rory Sexton --- doc/guides/sample_app_ug/vm_power_management.rst | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/doc/guides/sample_app_ug/vm_power_management.rst b/doc/guides/sample_app_ug/vm_power_management.rst index e98277ccb..dd0f46158 100644

[dpdk-dev] [PATCH v2 2/3] examples/vm_power_manager: Allowing power managing of idle cores

2020-05-18 Thread Sexton, Rory
This change is required to allow the branch ratio algorithm to power manage cores with no workload running on them. This is useful both when idle cores don't use C-states and for a number of hyperthreading scenarios. Signed-off-by: Rory Sexton --- examples/vm_power_manager/oob_monitor_x86.c | 8

  1   2   >