Re: [dpdk-dev] [PATCH] net/ice/base: fix FDIR rule passthrough mode

2020-05-14 Thread Ye Xiaolong
Hi, simei On 05/08, Simei Su wrote: >This patch adds support for FDIR passthrough mode. When FDIR rule >hits, FDIR just forward this packet to the next stage filter. > >Fixes: 55daca4e45fc ("net/ice/base: change function to static") This commit doesn't make sense to me, it just change the functio

Re: [dpdk-dev] [PATCH v3 0/2] fixes for caam_jr

2020-05-14 Thread Gagandeep Singh
> -Original Message- > From: wangyunjian > Sent: Thursday, May 14, 2020 4:30 PM > To: dev@dpdk.org > Cc: Gagandeep Singh ; Hemant Agrawal > ; jerry.lili...@huawei.com; > xudin...@huawei.com; Yunjian Wang > Subject: [dpdk-dev] [PATCH v3 0/2] fixes for caam_jr > > From: Yunjian Wang >

Re: [dpdk-dev] [PATCH] net/ice/base: fix FDIR rule passthrough mode

2020-05-14 Thread Zhang, Qi Z
> -Original Message- > From: Su, Simei > Sent: Friday, May 8, 2020 9:22 AM > To: Zhang, Qi Z ; Ye, Xiaolong > Cc: dev@dpdk.org; Cao, Yahui ; Su, Simei > > Subject: [PATCH] net/ice/base: fix FDIR rule passthrough mode > > This patch adds support for FDIR passthrough mode. When FDIR ru

[dpdk-dev] [PATCH v3 2/2] net/qede: fix port reconfiguration

2020-05-14 Thread Rasesh Mody
This patch fixes deallocation of all fastpath resources unconditionally, when re-configuring the device. When re-allocating resources PMD depends on application to explicitly setup the Rx/Tx queue. Deallocation of all the resources is only required if the Rx/Tx queue configuration changes. For oth

[dpdk-dev] [PATCH v3 1/2] net/qede: fix assignment of Rx/Tx handlers

2020-05-14 Thread Rasesh Mody
Fix to assign dummy Rx/Tx handlers in dev_stop. For MTU set, assignment of the appropriate Rx/Tx handlers will be handled by dev_start/dev_stop. Fixes: 81f8804992c9 ("net/qede: enhance Rx CPU utilization") Fixes: 8de0c4201926 ("net/qede: fix odd number of queues usage in 100G mode") Cc: sta...@dpd

Re: [dpdk-dev] [PATCH] net/i40e: fix the security risk of wild pointer operation

2020-05-14 Thread Jeff Guo
hi, zhaowei On 5/12/2020 11:19 PM, Wei Zhao wrote: In i40e PMD code of function i40e_res_pool_free(), if valid_entry is freed by "rte_free(valid_entry);" in the following code: if (prev != NULL) { if (insert == 1) { LIST_REMOVE(valid_entry, next); rte

Re: [dpdk-dev] [PATCH v3] net/i40e: fix queue region issue in RSS flow

2020-05-14 Thread Xu, HailinX
Tested-by: Xu, Hailin Regards, Xu, Hailin -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Wang, ShougangX Sent: Thursday, May 14, 2020 3:04 PM To: Iremonger, Bernard ; dev@dpdk.org Cc: Xing, Beilei ; Guo, Jia ; sta...@dpdk.org Subject: Re: [dpdk-dev] [PATCH v3]

Re: [dpdk-dev] [PATCH] test/graph_perf: fix memory leaks

2020-05-14 Thread Jerin Jacob
On Thu, May 14, 2020 at 2:26 AM wrote: > > From: Pavan Nikhilesh > > Fix memory leaks reported by coverity. > > Coverity issue: 358440, 358441, 358446. The last dot can be removed when merging. > Fixes: 61d77071ab99 ("test/graph: add performance tests") > > Signed-off-by: Pavan Nikhilesh Ac

[dpdk-dev] [PATCH v3] net/axgbe: support sfp module EEPROM

2020-05-14 Thread asomalap
From: Amaranath Somalapuram Adding API for get_module_eeprom and get_module_info. Signed-off-by: Amaranath Somalapuram --- doc/guides/nics/features/axgbe.ini | 1 + drivers/net/axgbe/axgbe_ethdev.c | 2 + drivers/net/axgbe/axgbe_phy.h | 4 ++ drivers/net/axgbe/axgbe_phy_impl.c | 1

[dpdk-dev] [PATCH v7 11/13] bus/dpaa: change netcfg access as function

2020-05-14 Thread Hemant Agrawal
This patch changes the export of fman port config as function call instead of direct variable access. This is in control path, so it will not impact perf. Signed-off-by: Hemant Agrawal --- drivers/bus/dpaa/dpaa_bus.c | 6 ++ drivers/bus/dpaa/rte_bus_dpaa_version.map | 1 + driv

[dpdk-dev] [PATCH v7 10/13] bus/dpaa: move log into to respective dpaa drivers

2020-05-14 Thread Hemant Agrawal
This is to reduce the number of variables getting exposed from the dpaa bus. They are not required to be in bus. Signed-off-by: Hemant Agrawal --- drivers/bus/dpaa/dpaa_bus.c | 19 +--- drivers/bus/dpaa/rte_bus_dpaa_version.map | 4 -- drivers/bus/dpaa/rte_dpaa_logs.h

[dpdk-dev] [PATCH v7 12/13] bus/fslmc: share mcp ptr as function across libs

2020-05-14 Thread Hemant Agrawal
Currently rte_mcp_ptr_list is being shared as a variable across libs. This is only used in control path. This patch change it to a exported function based access. Signed-off-by: Hemant Agrawal --- drivers/bus/fslmc/fslmc_vfio.c | 15 --- drivers/bus/fslmc/portal/dpaa2_hw

[dpdk-dev] [PATCH v7 08/13] mempool/dpaa2: fix to add the include file

2020-05-14 Thread Hemant Agrawal
rte_dpaa2_mempool.h header was missed to be added in meson.build for header installation. Fixes: 7ed359909556 ("mempool/dpaa2: add functions for CMDIF") Cc: sta...@dpdk.org Signed-off-by: Hemant Agrawal --- drivers/mempool/dpaa2/meson.build | 2 ++ 1 file changed, 2 insertions(+) diff --git a/

[dpdk-dev] [PATCH v7 09/13] bus/dpaa: share qman portal ids as function calls

2020-05-14 Thread Hemant Agrawal
qman caam and pool portal ids are only used in control path. This patch changes their inter library access to function call instead of direct shared variable. Signed-off-by: Hemant Agrawal --- drivers/bus/dpaa/base/qbman/qman_driver.c | 10 ++ drivers/bus/dpaa/include/fsl_qman.h |

[dpdk-dev] [PATCH v7 13/13] bus/fslmc: remove unused symbols

2020-05-14 Thread Hemant Agrawal
rte_dpaa2_memsegs is not being used by any other library or even within bus. Signed-off-by: Hemant Agrawal --- drivers/bus/fslmc/portal/dpaa2_hw_dpbp.c| 6 -- drivers/bus/fslmc/portal/dpaa2_hw_pvt.h | 3 --- drivers/bus/fslmc/rte_bus_fslmc_version.map | 1 - 3 files changed, 10 delet

[dpdk-dev] [PATCH v7 07/13] crypto: move internal symbols into INTERNAL section

2020-05-14 Thread Hemant Agrawal
This patch moves the internal symbols to INTERNAL sections so that any change in them is not reported as ABI breakage. Signed-off-by: Hemant Agrawal --- drivers/crypto/dpaa2_sec/dpaa2_sec_event.h | 5 +++-- drivers/crypto/dpaa2_sec/rte_pmd_dpaa2_sec_version.map | 6 -- drivers/cr

[dpdk-dev] [PATCH v7 04/13] mempool/dpaa2: move internal symbols into INTERNAL section

2020-05-14 Thread Hemant Agrawal
This patch moves the internal symbols to INTERNAL sections so that any change in them is not reported as ABI breakage. Signed-off-by: Hemant Agrawal --- devtools/libabigail.abignore| 8 drivers/mempool/dpaa/rte_mempool_dpaa_version.map | 6 -- drivers/mempo

[dpdk-dev] [PATCH v7 03/13] bus/dpaa: move internal symbols into INTERNAL section

2020-05-14 Thread Hemant Agrawal
This patch moves the internal symbols to INTERNAL sections so that any change in them is not reported as ABI breakage. This patch also removes two symbols, which are not to be exported. rte_dpaa_mem_ptov - static inline in the headerfile fman_ccsr_map_fd - local shared variable. Signed-off-by: H

[dpdk-dev] [PATCH v7 05/13] net/dpaa: move internal symbols into INTERNAL section

2020-05-14 Thread Hemant Agrawal
This patch moves the internal symbols to INTERNAL sections so that any change in them is not reported as ABI breakage. Signed-off-by: Hemant Agrawal --- devtools/libabigail.abignore | 2 ++ drivers/net/dpaa/dpaa_ethdev.h| 2 ++ drivers/net/dpaa/rte_pmd_dpaa_version.map |

[dpdk-dev] [PATCH v7 06/13] net/dpaa2: move internal symbols into INTERNAL section

2020-05-14 Thread Hemant Agrawal
This patch moves the internal symbols to INTERNAL sections so that any change in them is not reported as ABI breakage. Signed-off-by: Hemant Agrawal --- drivers/net/dpaa2/dpaa2_ethdev.h| 2 ++ drivers/net/dpaa2/rte_pmd_dpaa2_version.map | 12 +++- 2 files changed, 9 insertio

[dpdk-dev] [PATCH v7 02/13] bus/fslmc: move internal symbols into INTERNAL section

2020-05-14 Thread Hemant Agrawal
This patch moves the internal symbols to INTERNAL sections so that any change in them is not reported as ABI breakage. This patch also removes two symbols, which were not used anywhere else i.e. rte_fslmc_vfio_dmamap & dpaa2_get_qbman_swp Signed-off-by: Hemant Agrawal --- devtools/libabigail.ab

[dpdk-dev] [PATCH v7 01/13] common/dpaax: move internal symbols into INTERNAL section

2020-05-14 Thread Hemant Agrawal
This patch moves the internal symbols to INTERNAL sections so that any change in them is not reported as ABI breakage. Signed-off-by: Hemant Agrawal --- devtools/libabigail.abignore | 3 +++ drivers/common/dpaax/dpaa_of.h| 15 +++ drivers/com

[dpdk-dev] [PATCH v7 00/13] NXP DPAAx: move internal symbols to INTERNAL

2020-05-14 Thread Hemant Agrawal
v7: using empty DPDK_20.0 to preserve the so name v6: v5 was dirty v5: use empty DPDK_20.0 to avoid so name erriin pmd_dpaa2 v4: pmd_dpaa, mempool_dpaa2 also has external symbols. So, changing the libabigail.abignore exception to only for selected func calls pmd_dpaa2 also has experimental exte

[dpdk-dev] [PATCH] net/mlx5: fix wrong port action assert position

2020-05-14 Thread Bing Zhao
In the current implementation, only one port action is supported in switchdev mode. So only one port action will exist in a single device flow. In debug mode, an assertion will be used to check the if the port action is none, and it should locate before the port action resource registration. In the

Re: [dpdk-dev] [PATCH v4] net/i40e: fix out of bounds read issue

2020-05-14 Thread Ye Xiaolong
Minor nit: 'issue' doesn't need to be mentioned in the commit title, since the 'fix' implies something is broken. On 05/14, Chenxu Di wrote: >This patch fixes (out-of-bounds read) coverity issue. > >Coverity issue: 357699 >Coverity issue: 357694 >Fixes: feaae285b342 ("net/i40e: support hash config

Re: [dpdk-dev] [PATCH v1] net/iavf: fix setting wrong RXDID value for Rx queue

2020-05-14 Thread Zeng, XiaoxiaoX
Tested-by: Zeng,XiaoxiaoX Best regards, Zeng,xiaoxiao > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ting Xu > Sent: Monday, May 11, 2020 11:28 PM > To: dev@dpdk.org > Cc: Xing, Beilei ; Wu, Jingjing > ; Ye, Xiaolong ; > sta...@dpdk.org > Subject: [dpdk-de

Re: [dpdk-dev] [PATCH v2 2/2] net/bonding: fix MAC address when one port resets

2020-05-14 Thread Wei Hu (Xavier)
Hi, Ferruh Yigit & Chas Williams Could you please give any suggestion? Thanks. Best Regards Xavier On 2020/4/17 16:58, Wei Hu (Xavier) wrote: Hi, Chas Williams    Thanks for your comments on Patch V1. now we have sent Patch V2.    Could you please give some suggestion on them?    Thank

Re: [dpdk-dev] [PATCH v2] net/virtio: fix unexpected event after reconnect

2020-05-14 Thread Wang, Xiao W
Hi, Best Regards, Xiao > -Original Message- > From: Liu, Yong > Sent: Friday, May 15, 2020 10:35 AM > To: maxime.coque...@redhat.com; Ye, Xiaolong ; > Wang, Zhihong ; Wang, Xiao W > > Cc: dev@dpdk.org; Liu, Yong ; sta...@dpdk.org > Subject: [PATCH v2] net/virtio: fix unexpected event af

Re: [dpdk-dev] [PATCH] net/virtio: disable event suppression when reconnect

2020-05-14 Thread Liu, Yong
Thanks for reminder, xiao. v2 will cc stable branch. As spec mentioned, notification is more precise in semantic. Will do /event suppression/event notification/s. Regards, Marvin > -Original Message- > From: Wang, Xiao W > Sent: Friday, May 15, 2020 9:53 AM > To: Liu, Yong ; maxime.c

[dpdk-dev] [PATCH v2] net/virtio: fix unexpected event after reconnect

2020-05-14 Thread Marvin Liu
Event notification should be disabled after virtqueue initialization and enabled by calling rte_eth_dev_rx_intr_enable later. When virtio user device reconnecting to vhost, virtqueue_disable_intr should be called to disable event notification. Fixes: 6ebbf4109f35 ("net/virtio-user: fix packed ring

Re: [dpdk-dev] [PATCH] net/i40e: fix the security risk of wild pointer operation

2020-05-14 Thread Zhao1, Wei
Can any one view for this patch? Thanks! > -Original Message- > From: Zhao1, Wei > Sent: Tuesday, May 12, 2020 11:19 PM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Xing, Beilei ; Zhao1, Wei > > Subject: [PATCH] net/i40e: fix the security risk of wild pointer operation > > In i40e PMD cod

Re: [dpdk-dev] [PATCH] net/virtio: disable event suppression when reconnect

2020-05-14 Thread Wang, Xiao W
Hi Marvin, Comments inline. Thanks for the fix. Best Regards, Xiao > -Original Message- > From: dev On Behalf Of Marvin Liu > Sent: Friday, May 15, 2020 9:41 AM > To: maxime.coque...@redhat.com; Ye, Xiaolong ; > Wang, Zhihong > Cc: dev@dpdk.org; Liu, Yong > Subject: [dpdk-dev] [PATCH]

[dpdk-dev] [PATCH] net/virtio: disable event suppression when reconnect

2020-05-14 Thread Marvin Liu
Event suppression should be disabled after virtqueue initialization. It can be enabled by calling rte_eth_dev_rx_intr_enable later. Signed-off-by: Marvin Liu diff --git a/drivers/net/virtio/virtqueue.c b/drivers/net/virtio/virtqueue.c index 408bba236a..2702e120ee 100644 --- a/drivers/net/virtio/

Re: [dpdk-dev] [PATCH] lib/librte_net: fix bug for ipv4 checksumcalculating

2020-05-14 Thread guohongzhi (A)
Ok, later I will write a patch to solve the problem of tcpdump checksum -Original Message- From: Morten Brørup [mailto:m...@smartsharesystems.com] Sent: Thursday,May 14,2020 20:57 To: guohongzhi (A) ; dev@dpdk.org Cc: olivier.m...@6wind.com; konstantin.anan...@intel.com; jiayu...@intel.co

[dpdk-dev] [PATCH] net/mlx5: fix Verbs counter pool allocation

2020-05-14 Thread Suanming Mou
When create the Verbs flows with counter, randomly SEGSEV will also comes. The reason is that the counter pool memory is not allocated sufficiently and initialized correctly in Verbs case. As the mlx5_flow_counter array member is moved out of the counter pool struct, the counter pool memory layout

[dpdk-dev] [Bug 478] Unable to build igb_uio kernel module on Ubuntu 18.04

2020-05-14 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=478 Bug ID: 478 Summary: Unable to build igb_uio kernel module on Ubuntu 18.04 Product: DPDK Version: 17.11 Hardware: x86 OS: Linux Status: UNCONFIRMED Severity: norma

Re: [dpdk-dev] [PATCH v4 4/4] eal/atomic: add wrapper for c11 atomics

2020-05-14 Thread Mattias Rönnblom
On 2020-05-14 10:34, Morten Brørup wrote: > + Added people from the related discussion regarding the ARM roadmap > [https://protect2.fireeye.com/v1/url?k=10efdd7b-4e4f1ed2-10ef9de0-86959e472243-b772fef31e4ae6af&q=1&e=e3b0051e-bb23-4a30-84c7-7e5e80f83325&u=https%3A%2F%2Fmails.dpdk.org%2Farchives%2F

Re: [dpdk-dev] [EXT] Re: [PATCH 2/2] net/qede: restore Tx queue setup

2020-05-14 Thread Rasesh Mody
>From: Ferruh Yigit >Sent: Thursday, May 14, 2020 7:33 AM > >On 5/6/2020 3:43 AM, Rasesh Mody wrote: >> Hi, >> >>> From: Thomas Monjalon >>> Sent: Tuesday, May 05, 2020 2:15 AM >>> >>> 05/05/2020 10:59, Ferruh Yigit: On 5/5/2020 7:44 AM, Jerin Jacob wrote: > On Tue, May 5, 2020 at 8:39 A

Re: [dpdk-dev] [PATCH v4 4/4] eal/atomic: add wrapper for c11 atomics

2020-05-14 Thread Honnappa Nagarahalli
> Subject: Re: [PATCH v4 4/4] eal/atomic: add wrapper for c11 atomics > > On 2020-05-14 10:34, Morten Brørup wrote: > > + Added people from the related discussion regarding the ARM roadmap > [https://protect2.fireeye.com/v1/url?k=10efdd7b-4e4f1ed2-10ef9de0- > 86959e472243-b772fef31e4ae6af&q=1&e=

[dpdk-dev] [PATCH v2] eal: fix warnings on Windows

2020-05-14 Thread Pallavi Kadam
This patch fixes bunch of warnings when compiling on Windows such as the use of an unsafe string function (strerror), [-Wunused-const-variable] in getopt.c and [-Wunused-variable], [-Wunused-function] in eal_common_options.c v2 changes: Excluded dirent.h file on Windows temporarily.

Re: [dpdk-dev] [PATCH v2] common/mlx5: fix bogus assert

2020-05-14 Thread Slava Ovsiienko
> -Original Message- > From: Alexander Kozyrev > Sent: Thursday, May 14, 2020 18:11 > To: Slava Ovsiienko ; dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > ; step...@networkplumber.org; sta...@dpdk.org > Subject: RE: [PATCH v2] common/mlx5: fix bogus assert > > These asserts seem redu

Re: [dpdk-dev] [EXT] Re: [PATCH 1/3] mbuf: add Tx offloads for packet marking

2020-05-14 Thread Olivier Matz
Hi Nithin, On Tue, May 05, 2020 at 11:49:20AM +0530, Nithin Dabilpuram wrote: > On Mon, May 04, 2020 at 02:27:35PM +0200, Olivier Matz wrote: > > On Mon, May 04, 2020 at 03:34:57PM +0530, Nithin Dabilpuram wrote: > > > On Mon, May 04, 2020 at 11:16:40AM +0200, Olivier Matz wrote: > > > > On Mon, M

Re: [dpdk-dev] [PATCH] ring: empty and count optimizations

2020-05-14 Thread Morten Brørup
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ananyev, > Konstantin > Sent: Thursday, May 14, 2020 6:47 PM > > > > > > -static inline unsigned > > > > +static inline unsigned int > > > > rte_ring_count(const struct rte_ring *r) > > > > { > > > > uint32_t prod_tail = r->prod.tail;

Re: [dpdk-dev] [PATCH] eal: fix warnings on Windows

2020-05-14 Thread Ranjit Menon
On 5/14/2020 1:02 AM, Thomas Monjalon wrote: 14/05/2020 00:53, Pallavi Kadam: This patch fixes bunch of warnings when compiling on Windows such as the use of an unsafe string function (strerror), [-Wunused-const-variable] in getopt.c and [-Wunused-variable], [-Wunused-function] in eal_common_opt

Re: [dpdk-dev] [PATCH] lib/librte_hash: add rte_hash_del_key_fixed without compact

2020-05-14 Thread Wang, Yipeng1
> -Original Message- > From: Lilijun (Jerry) > Sent: Tuesday, May 12, 2020 6:28 PM > To: Wang, Yipeng1 ; Honnappa Nagarahalli > ; 'dev@dpdk.org' > Cc: wangyunjian ; xudingke > ; 'sta...@dpdk.org' ; nd > ; nd > Subject: 答复: [dpdk-dev] [PATCH] lib/librte_hash: add > rte_hash_del_key_fixed

Re: [dpdk-dev] [PATCH v3 01/12] common/dpaax: move internal symbols into INTERNAL section

2020-05-14 Thread Hemant Agrawal (OSS)
> > On Thu, May 14, 2020 at 3:31 PM David Marchand > wrote: > > > > On Thu, May 14, 2020 at 2:39 PM Hemant Agrawal (OSS) > > wrote: > > > > > > [Hemant] this is working fine for pmd_dpaa but not for pmd_dpaa2 > > > > > > I removed the filename_exp and introduced function based name= Now > > > th

Re: [dpdk-dev] [PATCH] ring: empty and count optimizations

2020-05-14 Thread Ananyev, Konstantin
> > > > -static inline unsigned > > > +static inline unsigned int > > > rte_ring_count(const struct rte_ring *r) > > > { > > > uint32_t prod_tail = r->prod.tail; > > > uint32_t cons_tail = r->cons.tail; > > > uint32_t count = (prod_tail - cons_tail) & r->mask; > > > - return (count > r->c

Re: [dpdk-dev] [PATCH v1 0/4] fixes for queue resource free and code style

2020-05-14 Thread Ferruh Yigit
On 5/14/2020 10:29 AM, Xiaoyun wang wrote: > This patch adds tx_queues and rx_queues non-null judgment before > free tx or rx resources, because some app may set tx_queues or > rx_queues to be null before call free resource interfaces, which > may cause a segfault, adds pkt_len member update for

Re: [dpdk-dev] [PATCH v1] net/axgbe: support sfp module EEPROM

2020-05-14 Thread Ferruh Yigit
On 5/14/2020 2:43 PM, asoma...@amd.com wrote: > From: Amaranath Somalapuram > > Adding API for get_module_eeprom and get_module_info. > > Signed-off-by: Amaranath Somalapuram Hi Amaranath, I guess this is v3 of the patch, can you please use the version info and keep the all versions in same th

Re: [dpdk-dev] [PATCH v5] doc: alias to experimental tag for stable apis

2020-05-14 Thread David Marchand
On Thu, May 14, 2020 at 3:39 PM Ray Kinsella wrote: > +In the map file, experimental symbols are listed as part of the > ``experimental`` > +version node. > + > +.. code-block:: none > + > + DPDK_20 { > +global: > +... > + > +local: *; > + }; > + > + EXPERIMENTAL { >

Re: [dpdk-dev] [PATCH v3] meter: provide experimental alias of API for old apps

2020-05-14 Thread David Marchand
On Thu, May 14, 2020 at 6:08 PM Ferruh Yigit wrote: > > On 5/14/2020 4:32 PM, David Marchand wrote: > > On Thu, May 14, 2020 at 1:52 PM Ferruh Yigit wrote: > >> > >> On v20.02 some meter APIs have been matured and symbols moved from > >> EXPERIMENTAL to DPDK_20.0.1 block. > >> > >> This can break

Re: [dpdk-dev] [PATCH v3 01/12] common/dpaax: move internal symbols into INTERNAL section

2020-05-14 Thread David Marchand
On Thu, May 14, 2020 at 3:31 PM David Marchand wrote: > > On Thu, May 14, 2020 at 2:39 PM Hemant Agrawal (OSS) > wrote: > > > > [Hemant] this is working fine for pmd_dpaa but not for pmd_dpaa2 > > > > I removed the filename_exp and introduced function based name= > > Now the issue is the followi

Re: [dpdk-dev] [PATCH] net/vmxnet3: handle bad host framing

2020-05-14 Thread Ferruh Yigit
On 5/13/2020 11:24 PM, Yong Wang wrote: > -Original Message- > From: Stephen Hemminger > Date: Tuesday, May 12, 2020 at 1:40 PM > To: Yong Wang > Cc: "dev@dpdk.org" , Stephen Hemminger > > Subject: [PATCH] net/vmxnet3: handle bad host framing > > The VMXNet3 protocol has a start-of

[dpdk-dev] [PATCH v4] meter: provide experimental alias of API for old apps

2020-05-14 Thread Ferruh Yigit
On v20.02 some meter APIs have been matured and symbols moved from EXPERIMENTAL to DPDK_20.0.1 block. This can break the applications that were using these mentioned APIs on v19.11. Although there is no modification on the APIs and the action is positive and matures the APIs, the affect can be neg

Re: [dpdk-dev] [PATCH v3] meter: provide experimental alias of API for old apps

2020-05-14 Thread Ferruh Yigit
On 5/14/2020 4:32 PM, David Marchand wrote: > On Thu, May 14, 2020 at 1:52 PM Ferruh Yigit wrote: >> >> On v20.02 some meter APIs have been matured and symbols moved from >> EXPERIMENTAL to DPDK_20.0.1 block. >> >> This can break the applications that were using these mentioned APIs on >> v19.11.

Re: [dpdk-dev] [PATCH v3] meter: provide experimental alias of API for old apps

2020-05-14 Thread Ray Kinsella
On 14/05/2020 16:32, David Marchand wrote: > On Thu, May 14, 2020 at 1:52 PM Ferruh Yigit wrote: >> >> On v20.02 some meter APIs have been matured and symbols moved from >> EXPERIMENTAL to DPDK_20.0.1 block. >> >> This can break the applications that were using these mentioned APIs on >> v19.11

Re: [dpdk-dev] [PATCH v2 2/2] examples/kni: fix MTU change to setup Tx queue

2020-05-14 Thread Ferruh Yigit
On 5/14/2020 5:09 AM, Rasesh Mody wrote: > This patch adds a fix to setup Tx queue when changing KNI interface MTU. > It ensures device can safely start txq post MTU change operation. > > Fixes: fc9ee41b7016 ("examples/kni: convert to new ethdev offloads API") > Cc: sta...@dpdk.org > > Signed-off

Re: [dpdk-dev] [PATCH v3] meter: provide experimental alias of API for old apps

2020-05-14 Thread David Marchand
On Thu, May 14, 2020 at 1:52 PM Ferruh Yigit wrote: > > On v20.02 some meter APIs have been matured and symbols moved from > EXPERIMENTAL to DPDK_20.0.1 block. > > This can break the applications that were using these mentioned APIs on > v19.11. Although there is no modification on the APIs and th

Re: [dpdk-dev] [PATCH] doc/guides/eventdevs: removing typing error in documentation of eventdevs

2020-05-14 Thread Jerin Jacob
On Thu, May 14, 2020 at 8:58 PM Muhammad Bilal wrote: > > Bugzilla ID: 477 > Cc: dev@dpdk.org > Cc: sta...@dpdk.org > Cc: jer...@marvell.com > Signed-off-by: Muhammad Bilal The same typo repeated for other places as well. Please send a single patch for fixing all in one shot. [master][dpdk.org]

[dpdk-dev] [PATCH] doc/guides/eventdevs: removing typing error in documentation of eventdevs

2020-05-14 Thread Muhammad Bilal
Bugzilla ID: 477 Cc: dev@dpdk.org Cc: sta...@dpdk.org Cc: jer...@marvell.com Signed-off-by: Muhammad Bilal --- doc/guides/eventdevs/index.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/guides/eventdevs/index.rst b/doc/guides/eventdevs/index.rst index 570905b81..bb66a5

[dpdk-dev] [Bug 477] Typing error in index.rst of doc/guides/eventdevs at line 8

2020-05-14 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=477 Bug ID: 477 Summary: Typing error in index.rst of doc/guides/eventdevs at line 8 Product: DPDK Version: 20.05 Hardware: All OS: All Status: UNCONFIRMED

Re: [dpdk-dev] [PATCH v2] common/mlx5: fix bogus assert

2020-05-14 Thread Alexander Kozyrev
These asserts seem redundant for me. Don't you think? EINVAL is returned, why bother to assert the same condition? Regards, Alex > -Original Message- > From: Viacheslav Ovsiienko > Sent: Thursday, May 14, 2020 3:09 > To: dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > ; step...@net

Re: [dpdk-dev] [PATCH v3] meter: provide experimental alias of API for old apps

2020-05-14 Thread Ray Kinsella
On 14/05/2020 12:52, Ferruh Yigit wrote: > On v20.02 some meter APIs have been matured and symbols moved from > EXPERIMENTAL to DPDK_20.0.1 block. > > This can break the applications that were using these mentioned APIs on > v19.11. Although there is no modification on the APIs and the action i

Re: [dpdk-dev] [EXT] Re: [PATCH 2/2] net/qede: restore Tx queue setup

2020-05-14 Thread Ferruh Yigit
On 5/6/2020 3:43 AM, Rasesh Mody wrote: > Hi, > >> From: Thomas Monjalon >> Sent: Tuesday, May 05, 2020 2:15 AM >> >> 05/05/2020 10:59, Ferruh Yigit: >>> On 5/5/2020 7:44 AM, Jerin Jacob wrote: On Tue, May 5, 2020 at 8:39 AM Rasesh Mody >> wrote: > > Some applications do not explici

[dpdk-dev] [PATCH v6 12/13] bus/fslmc: share mcp ptr as function across libs

2020-05-14 Thread Hemant Agrawal
Currently rte_mcp_ptr_list is being shared as a variable across libs. This is only used in control path. This patch change it to a exported function based access. Signed-off-by: Hemant Agrawal --- drivers/bus/fslmc/fslmc_vfio.c | 15 --- drivers/bus/fslmc/portal/dpaa2_hw

[dpdk-dev] [PATCH v6 13/13] bus/fslmc: remove unused symbols

2020-05-14 Thread Hemant Agrawal
rte_dpaa2_memsegs is not being used by any other library or even within bus. Signed-off-by: Hemant Agrawal --- drivers/bus/fslmc/portal/dpaa2_hw_dpbp.c| 6 -- drivers/bus/fslmc/portal/dpaa2_hw_pvt.h | 3 --- drivers/bus/fslmc/rte_bus_fslmc_version.map | 1 - 3 files changed, 10 delet

[dpdk-dev] [PATCH v6 11/13] bus/dpaa: change netcfg access as function

2020-05-14 Thread Hemant Agrawal
This patch changes the export of fman port config as function call instead of direct variable access. This is in control path, so it will not impact perf. Signed-off-by: Hemant Agrawal --- drivers/bus/dpaa/dpaa_bus.c | 6 ++ drivers/bus/dpaa/rte_bus_dpaa_version.map | 1 + driv

[dpdk-dev] [PATCH v6 10/13] bus/dpaa: move log into to respective dpaa drivers

2020-05-14 Thread Hemant Agrawal
This is to reduce the number of variables getting exposed from the dpaa bus. They are not required to be in bus. Signed-off-by: Hemant Agrawal --- drivers/bus/dpaa/dpaa_bus.c | 19 +--- drivers/bus/dpaa/rte_bus_dpaa_version.map | 4 -- drivers/bus/dpaa/rte_dpaa_logs.h

[dpdk-dev] [PATCH v6 09/13] bus/dpaa: share qman portal ids as function calls

2020-05-14 Thread Hemant Agrawal
qman caam and pool portal ids are only used in control path. This patch changes their inter library access to function call instead of direct shared variable. Signed-off-by: Hemant Agrawal --- drivers/bus/dpaa/base/qbman/qman_driver.c | 10 ++ drivers/bus/dpaa/include/fsl_qman.h |

[dpdk-dev] [PATCH v6 07/13] net/dpaa2: move internal symbols into INTERNAL section

2020-05-14 Thread Hemant Agrawal
This patch moves the internal symbols to INTERNAL sections so that any change in them is not reported as ABI breakage. Signed-off-by: Hemant Agrawal --- drivers/net/dpaa2/dpaa2_ethdev.h| 2 ++ drivers/net/dpaa2/rte_pmd_dpaa2_version.map | 12 +++- 2 files changed, 9 insertio

[dpdk-dev] [PATCH v6 06/13] net/dpaa: move internal symbols into INTERNAL section

2020-05-14 Thread Hemant Agrawal
This patch moves the internal symbols to INTERNAL sections so that any change in them is not reported as ABI breakage. Signed-off-by: Hemant Agrawal --- devtools/libabigail.abignore | 4 +++- drivers/net/dpaa/dpaa_ethdev.h| 2 ++ drivers/net/dpaa/rte_pmd_dpaa_version.map

[dpdk-dev] [PATCH v6 05/13] mempool/dpaa2: move internal symbols into INTERNAL section

2020-05-14 Thread Hemant Agrawal
This patch moves the internal symbols to INTERNAL sections so that any change in them is not reported as ABI breakage. Signed-off-by: Hemant Agrawal --- devtools/libabigail.abignore| 6 ++ drivers/mempool/dpaa/rte_mempool_dpaa_version.map | 2 +- drivers/mempool/dpa

[dpdk-dev] [PATCH v6 04/13] crypto: move internal symbols into INTERNAL section

2020-05-14 Thread Hemant Agrawal
This patch moves the internal symbols to INTERNAL sections so that any change in them is not reported as ABI breakage. Signed-off-by: Hemant Agrawal --- devtools/libabigail.abignore | 4 drivers/crypto/dpaa2_sec/dpaa2_sec_event.h | 5 +++-- drivers/cryp

[dpdk-dev] [PATCH v6 08/13] mempool/dpaa2: fix to add the include file

2020-05-14 Thread Hemant Agrawal
rte_dpaa2_mempool.h header was missed to be added in meson.build for header installation. Fixes: 7ed359909556 ("mempool/dpaa2: add functions for CMDIF") Cc: sta...@dpdk.org Signed-off-by: Hemant Agrawal --- drivers/mempool/dpaa2/meson.build | 2 ++ 1 file changed, 2 insertions(+) diff --git a/

[dpdk-dev] [PATCH v6 03/13] bus/dpaa: move internal symbols into INTERNAL section

2020-05-14 Thread Hemant Agrawal
This patch moves the internal symbols to INTERNAL sections so that any change in them is not reported as ABI breakage. Signed-off-by: Hemant Agrawal --- devtools/libabigail.abignore | 2 ++ drivers/bus/dpaa/include/fsl_bman.h | 6 + drivers/bus/dpaa/include/fsl_fman.h

[dpdk-dev] [PATCH v6 01/13] common/dpaax: move internal symbols into INTERNAL section

2020-05-14 Thread Hemant Agrawal
This patch moves the internal symbols to INTERNAL sections so that any change in them is not reported as ABI breakage. Signed-off-by: Hemant Agrawal --- devtools/libabigail.abignore | 3 +++ drivers/common/dpaax/dpaa_of.h| 15 +++ drivers/com

[dpdk-dev] [PATCH v6 00/13] NXP DPAAx: move internal symbols to INTERNAL

2020-05-14 Thread Hemant Agrawal
v6: v5 was dirty v5: use empty DPDK_20.0 to avoid so name erriin pmd_dpaa2 v4: pmd_dpaa, mempool_dpaa2 also has external symbols. So, changing the libabigail.abignore exception to only for selected func calls pmd_dpaa2 also has experimental external func call remaining. However, it causes the so

[dpdk-dev] [PATCH v6 02/13] bus/fslmc: move internal symbols into INTERNAL section

2020-05-14 Thread Hemant Agrawal
This patch moves the internal symbols to INTERNAL sections so that any change in them is not reported as ABI breakage. This patch also removes two symbols, which were not used anywhere else i.e. rte_fslmc_vfio_dmamap & dpaa2_get_qbman_swp Signed-off-by: Hemant Agrawal --- devtools/libabigail.ab

[dpdk-dev] [PATCH v5 01/13] common/dpaax: move internal symbols into INTERNAL section

2020-05-14 Thread Hemant Agrawal
This patch moves the internal symbols to INTERNAL sections so that any change in them is not reported as ABI breakage. Signed-off-by: Hemant Agrawal --- devtools/libabigail.abignore | 3 +++ drivers/common/dpaax/dpaa_of.h| 15 +++ drivers/com

[dpdk-dev] [PATCH v5 03/13] bus/dpaa: move internal symbols into INTERNAL section

2020-05-14 Thread Hemant Agrawal
This patch moves the internal symbols to INTERNAL sections so that any change in them is not reported as ABI breakage. Signed-off-by: Hemant Agrawal --- devtools/libabigail.abignore | 2 ++ drivers/bus/dpaa/include/fsl_bman.h | 6 + drivers/bus/dpaa/include/fsl_fman.h

[dpdk-dev] [PATCH v5 02/13] bus/fslmc: move internal symbols into INTERNAL section

2020-05-14 Thread Hemant Agrawal
This patch moves the internal symbols to INTERNAL sections so that any change in them is not reported as ABI breakage. This patch also removes two symbols, which were not used anywhere else i.e. rte_fslmc_vfio_dmamap & dpaa2_get_qbman_swp Signed-off-by: Hemant Agrawal --- devtools/libabigail.ab

[dpdk-dev] [PATCH v5 04/13] crypto: move internal symbols into INTERNAL section

2020-05-14 Thread Hemant Agrawal
This patch moves the internal symbols to INTERNAL sections so that any change in them is not reported as ABI breakage. Signed-off-by: Hemant Agrawal --- devtools/libabigail.abignore | 4 drivers/crypto/dpaa2_sec/dpaa2_sec_event.h | 5 +++-- drivers/cryp

[dpdk-dev] [PATCH] temp

2020-05-14 Thread Hemant Agrawal
Signed-off-by: Hemant Agrawal --- devtools/libabigail.abignore| 2 -- drivers/net/dpaa2/rte_pmd_dpaa2_version.map | 14 -- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/devtools/libabigail.abignore b/devtools/libabigail.abignore index d54b9675e..87c0a

[dpdk-dev] [PATCH v5 00/13] NXP DPAAx: move internal symbols to INTERNAL

2020-05-14 Thread Hemant Agrawal
v5: use empty DPDK_20.0 to avoid so name err in pmd_dpaa2 v4: pmd_dpaa, mempool_dpaa2 also has external symbols. So, changing the libabigail.abignore exception to only for selected func calls pmd_dpaa2 also has experimental external func call remaining. However, it causes the so name to be changed

Re: [dpdk-dev] [PATCH] lib/librte_net: fix bug for ipv4 checksumcalculating

2020-05-14 Thread Olivier Matz
Hi, On Thu, May 14, 2020 at 02:56:41PM +0200, Morten Brørup wrote: > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of guohongzhi > > Sent: Thursday, May 14, 2020 3:27 AM > > > > The function of rte_ipv4_cksum for calculating the > > checksum of IPv4 header is incorrect. > > This function wi

Re: [dpdk-dev] [PATCH v3 01/12] common/dpaax: move internal symbols into INTERNAL section

2020-05-14 Thread Hemant Agrawal (OSS)
> > [Hemant] this is working fine for pmd_dpaa but not for pmd_dpaa2 > > > > I removed the filename_exp and introduced function based name= Now the > > issue is the following warning SONAME changed from > > 'librte_pmd_dpaa2.so.20.0' to 'librte_pmd_dpaa2.so.0.200.2' > > > > The primary reason is

Re: [dpdk-dev] [PATCH v4] examples/ipsec-secgw: add per core packet stats

2020-05-14 Thread Ananyev, Konstantin
> Adding per core packet handling stats to analyze traffic distribution > when multiple cores are engaged. > > Since aggregating the packet stats across cores would affect > performance, keeping the feature disabled using compile time flags. > > Signed-off-by: Anoob Joseph > --- > v4: > * Move

Re: [dpdk-dev] [PATCH] ring: empty and count optimizations

2020-05-14 Thread Morten Brørup
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ananyev, > Konstantin > Sent: Thursday, May 14, 2020 2:24 PM > > > Hi Morten, > > > Testing if the ring is empty is as simple as comparing the producer > and > > consumer pointers. > > In theory, this optimization reduces the number of poten

[dpdk-dev] [PATCH v1] net/axgbe: support sfp module EEPROM

2020-05-14 Thread asomalap
From: Amaranath Somalapuram Adding API for get_module_eeprom and get_module_info. Signed-off-by: Amaranath Somalapuram --- doc/guides/nics/features/axgbe.ini | 1 + drivers/net/axgbe/axgbe_ethdev.c | 2 + drivers/net/axgbe/axgbe_phy.h | 4 ++ drivers/net/axgbe/axgbe_phy_impl.c | 1

Re: [dpdk-dev] DPDK Release Status Meeting 14/05/2020

2020-05-14 Thread Ferruh Yigit
On 5/14/2020 12:13 PM, Ferruh Yigit wrote: > Minutes 14 May 2020 > --- > > Agenda: > * Release Dates > * -rc2 status > * Subtrees > * Opens > > Participants: > * Arm > * Debian/Microsoft > * Intel > * Mellanox > * Red Hat > > > Release Dates > - > > * v20.05 dates:

[dpdk-dev] [PATCH v5] doc: alias to experimental tag for stable apis

2020-05-14 Thread Ray Kinsella
When a maintainer is promoting an API to become part of the next major ABI version by removing the experimental tag, possibly a few releases in advance of the declaration of the next ABI version. The maintainer may choose to offer an alias to the experimental tag, as removing the tag before the dec

Re: [dpdk-dev] [PATCH v3 01/12] common/dpaax: move internal symbols into INTERNAL section

2020-05-14 Thread David Marchand
On Thu, May 14, 2020 at 2:39 PM Hemant Agrawal (OSS) wrote: > > [Hemant] this is working fine for pmd_dpaa but not for pmd_dpaa2 > > I removed the filename_exp and introduced function based name= > Now the issue is the following warning > SONAME changed from 'librte_pmd_dpaa2.so.20.0' to > 'libr

[dpdk-dev] [PATCH v4 13/13] bus/fslmc: remove unused symbols

2020-05-14 Thread Hemant Agrawal
rte_dpaa2_memsegs is not being used by any other library or even within bus. Signed-off-by: Hemant Agrawal --- drivers/bus/fslmc/portal/dpaa2_hw_dpbp.c| 6 -- drivers/bus/fslmc/portal/dpaa2_hw_pvt.h | 3 --- drivers/bus/fslmc/rte_bus_fslmc_version.map | 1 - 3 files changed, 10 delet

[dpdk-dev] [PATCH v4 12/13] bus/fslmc: share mcp ptr as function across libs

2020-05-14 Thread Hemant Agrawal
Currently rte_mcp_ptr_list is being shared as a variable across libs. This is only used in control path. This patch change it to a exported function based access. Signed-off-by: Hemant Agrawal --- drivers/bus/fslmc/fslmc_vfio.c | 15 --- drivers/bus/fslmc/portal/dpaa2_hw

[dpdk-dev] [PATCH v4 11/13] bus/dpaa: change netcfg access as function

2020-05-14 Thread Hemant Agrawal
This patch changes the export of fman port config as function call instead of direct variable access. This is in control path, so it will not impact perf. Signed-off-by: Hemant Agrawal --- drivers/bus/dpaa/dpaa_bus.c | 6 ++ drivers/bus/dpaa/rte_bus_dpaa_version.map | 1 + driv

[dpdk-dev] [PATCH v4 10/13] bus/dpaa: move log into to respective dpaa drivers

2020-05-14 Thread Hemant Agrawal
This is to reduce the number of variables getting exposed from the dpaa bus. They are not required to be in bus. Signed-off-by: Hemant Agrawal --- drivers/bus/dpaa/dpaa_bus.c | 19 +--- drivers/bus/dpaa/rte_bus_dpaa_version.map | 4 -- drivers/bus/dpaa/rte_dpaa_logs.h

[dpdk-dev] [PATCH v4 09/13] bus/dpaa: share qman portal ids as function calls

2020-05-14 Thread Hemant Agrawal
qman caam and pool portal ids are only used in control path. This patch changes their inter library access to function call instead of direct shared variable. Signed-off-by: Hemant Agrawal --- drivers/bus/dpaa/base/qbman/qman_driver.c | 10 ++ drivers/bus/dpaa/include/fsl_qman.h |

[dpdk-dev] [PATCH v4 07/13] net/dpaa2: move internal symbols into INTERNAL section

2020-05-14 Thread Hemant Agrawal
This patch moves the internal symbols to INTERNAL sections so that any change in them is not reported as ABI breakage. Signed-off-by: Hemant Agrawal --- devtools/libabigail.abignore| 4 +++- drivers/net/dpaa2/dpaa2_ethdev.h| 2 ++ drivers/net/dpaa2/rte_pmd_dpaa2_versi

[dpdk-dev] [PATCH v4 08/13] mempool/dpaa2: fix to add the include file

2020-05-14 Thread Hemant Agrawal
rte_dpaa2_mempool.h header was missed to be added in meson.build for header installation. Fixes: 7ed359909556 ("mempool/dpaa2: add functions for CMDIF") Cc: sta...@dpdk.org Signed-off-by: Hemant Agrawal --- drivers/mempool/dpaa2/meson.build | 2 ++ 1 file changed, 2 insertions(+) diff --git a/

[dpdk-dev] [PATCH v4 02/13] bus/fslmc: move internal symbols into INTERNAL section

2020-05-14 Thread Hemant Agrawal
This patch moves the internal symbols to INTERNAL sections so that any change in them is not reported as ABI breakage. This patch also removes two symbols, which were not used anywhere else i.e. rte_fslmc_vfio_dmamap & dpaa2_get_qbman_swp Signed-off-by: Hemant Agrawal --- devtools/libabigail.ab

  1   2   >