The flow_verbs_translate() function accumulates hash fields while
iterating through the flow items (SRC_IPV4, DST_IPV4, SRC_IPV6,
DST_IPV6, SRC_PORT_TCP, DST_PORT_TCP, SRC_PORT_UDP, DST_PORT_UDP).
Before this commit the dev_flow handle structure was reused in each new
flow_verbs_translate() call, h
On Mon, May 4, 2020 at 2:02 AM David Marchand wrote:
>
> Invert the current trace point headers logic by making
> rte_trace_point_register.h include rte_trace_point.h.
>
> There is no more need for a RTE_TRACE_POINT_REGISTER_SELECT special macro
> since including rte_trace_point_register.h itself
On Mon, May 4, 2020 at 2:02 AM David Marchand wrote:
>
> RTE_TRACE_POINT_DEFINE and RTE_TRACE_POINT_REGISTER must come in pairs.
> Merge them and let RTE_TRACE_POINT_REGISTER handle the constructor part.
Initially, I thought of doing the same. But, later I realized that
this largely grows the nu
On Wed, Apr 8, 2020 at 6:19 PM Harman Kalra wrote:
>
> On Tue, Apr 07, 2020 at 07:35:43PM +0800, wangyunjian wrote:
> > External Email
> >
> > --
> > From: Yunjian Wang
> >
> > When octeontx_create() is cleaning up, it does not c
Hi,
Sharing an observation especially with Fortville (X710), if the port is not
started the advertised speed is not max speed (`1` or `4`). Hence would
cross check on `link_state` be useful before display?
> -Original Message-
> From: dev On Behalf Of Andrew Rybchenko
> Sent:
> Subject: Re: [PATCH v2 0/2] Use WFE for spinlock and ring
>
> On Sun, Apr 26, 2020 at 10:39 AM Gavin Hu wrote:
> >
> > The rte_wait_until_equal_xxx APIs abstract the functionality of
> > 'polling for a memory location to become equal to a given value'[1].
> >
> > Use the API for the rte spinl
There is nothing performance sensitive in this list, use dynamic
allocations and remove the arbitrary limit on the number of trace
patterns a user can pass.
Signed-off-by: David Marchand
---
lib/librte_eal/common/eal_common_trace.c | 10 +++---
.../common/eal_common_trace_utils.c
From: Phil Yang
Prevent from writing beyond the allocated memory.
GCC 10 compiling output:
eal_common_trace_utils.c: In function 'eal_trace_dir_args_save':
eal_common_trace_utils.c:290:24: error: '__builtin___sprintf_chk' \
may write a terminating nul past the end of the destination \
No need to duplicate an untouched string.
Signed-off-by: David Marchand
---
lib/librte_eal/common/eal_common_trace_utils.c | 12 ++--
1 file changed, 2 insertions(+), 10 deletions(-)
diff --git a/lib/librte_eal/common/eal_common_trace_utils.c
b/lib/librte_eal/common/eal_common_trace_ut
The trace framework can be configured via 4 EAL options:
- --trace which calls eal_trace_args_save,
- --trace-dir which calls eal_trace_dir_args_save,
- --trace-bufsz which calls eal_trace_bufsz_args_save,
- --trace-mode which calls eal_trace_mode_args_save.
Those 4 internal callbacks are getting
Prefer a local name to optarg which is a global symbol from the C library.
Fixes: 8c8066ea6a7b ("trace: add trace mode configuration parameter")
Signed-off-by: David Marchand
---
.../common/eal_common_trace_utils.c | 32 +--
lib/librte_eal/common/eal_trace.h
Invert the current trace point headers logic by making
rte_trace_point_register.h include rte_trace_point.h.
There is no more need for a RTE_TRACE_POINT_REGISTER_SELECT special macro
since including rte_trace_point_register.h itself means we want to
register trace points.
The unexplained "provide
Those trace points are defined but not registered.
Fixes: 4cf30e3f3c35 ("cryptodev: add tracepoints")
Signed-off-by: David Marchand
---
lib/librte_cryptodev/cryptodev_trace_points.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/lib/librte_cryptodev/cryptodev_trace_points.c
b/lib/li
Couple of fixes and cleanup (missed during initial review) on the newly
introduced traces framework.
Phil patch [1] has been rebased as part of this series.
1: http://patchwork.dpdk.org/patch/69467/
--
David Marchand
David Marchand (7):
cryptodev: fix trace points registration
trace: simpli
RTE_TRACE_POINT_DEFINE and RTE_TRACE_POINT_REGISTER must come in pairs.
Merge them and let RTE_TRACE_POINT_REGISTER handle the constructor part.
Signed-off-by: David Marchand
---
app/test/test_trace_register.c| 12 +-
doc/guides/prog_guide/trace_lib.rst | 12 +-
lib/l
On Wed, Apr 29, 2020 at 1:58 AM Stephen Hemminger
wrote:
>
> Started using valgrind with DPDK, and there are lots of leftover
> memory and file descriptors. This makes it hard to find application
> leaks versus DPDK leaks.
>
> The DPDK has a function that applications can use to tell it
> to clean
On Sat, Apr 25, 2020 at 11:44 AM Rasesh Mody wrote:
>
> Add support for get firmware version operation.
>
> Get and dump multi boot image (MBI) version as part of get
> firmware version string along with Management fimrware (MFW) version.
> Use qede_fw_version_get() for PMD info logs.
>
> Signed-o
> -Original Message-
> From: Bill Zhou
> Subject: [PATCH v4] app/testpmd: support flow aging
>
> Currently, there is no way to check the aging event or to get the current
> aged flows in testpmd, this patch include those implements, it's included:
>
> - Add new item "flow_aged" to the
> -Original Message-
> From: Andrew Rybchenko
>
> On 5/3/20 10:17 AM, Dekel Peled wrote:
> > Specified pattern may be translated in different manner.
> > For example the pattern "eth / ipv4" can be translated to match
> > untagged packets only, since the pattern doesn't specify a VLAN i
On Sun, Apr 26, 2020 at 10:39 AM Gavin Hu wrote:
>
> The rte_wait_until_equal_xxx APIs abstract the functionality of 'polling
> for a memory location to become equal to a given value'[1].
>
> Use the API for the rte spinlock and ring implementations.
>
> [1] http://patches.dpdk.org/cover/62703/
>
On Tue, Apr 28, 2020 at 6:11 PM Harman Kalra wrote:
>
> Since event-octeontx PMD and net-octeontx PMD works very
> tightly, so this patchset implements the event-octeontx
> side changes to support new features added to net-octeontx
> PMD.
Acked-by: Jerin Jacob
Series applied to dpdk-next-eventd
On 5/2/20 10:35 PM, Ivan Dyukov wrote:
> 01.05.2020 16:28, Andrew Rybchenko пишет:
>> On 4/27/20 12:57 PM, Ivan Dyukov wrote:
>>> Signed-off-by: Ivan Dyukov
>>> ---
>>> doc/guides/sample_app_ug/link_status_intr.rst | 3 ++-
>>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>>
>>> diff --git a
Thanks Jerin, agree with you on graceful shutdown in rc2.
> -Original Message-
> From: Jerin Jacob
> Sent: Sunday, May 3, 2020 3:28 PM
> To: Varghese, Vipin
> Cc: Pavan Nikhilesh Bhagavatula ; Jerin Jacob
> Kollanukkaran ; Burakov, Anatoly
> ; dpdk-dev
> Subject: Re: [dpdk-dev] [PATCH]
> Subject: Re: [PATCH v2 7/7] bus/pci: support Windows with bifurcated
> drivers
>
> On 2020-04-28 12:11 GMT+0300 tal...@mellanox.com wrote:
> [snip]
> > + switch (dev->kdrv) {
> > + case RTE_KDRV_NONE:
> > + /* Get NUMA node using DEVPKEY_Device_Numa_Node */
> > + bResult
Hi,
> -Original Message-
> From: dev On Behalf Of Matan Azrad
> Sent: Sunday, May 3, 2020 10:42 AM
> To: Bill Zhou ; Ori Kam ;
> Shahaf Shuler ; Slava Ovsiienko
> ; marko.kovace...@intel.com;
> john.mcnam...@intel.com
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v3 0/2] net/mlx5: s
From: Eli Britstein
> The HW is optimized for IPv4/IPv6. For such cases avoid matching on
> ethertype, and use ip_version field instead.
>
> Eli Britstein (2):
> net/mlx5: introduce a helper to set IP version match
> net/mlx5: optimize performance for IPv4/IPv6 ethertype
Series-acked-by:
Hi,
> -Original Message-
> From: dev On Behalf Of Ferruh Yigit
> Sent: Monday, April 27, 2020 7:56 PM
> To: Gaëtan Rivet ; wangyunjian
>
> Cc: dev@dpdk.org; jerry.lili...@huawei.com; xudin...@huawei.com;
> sta...@dpdk.org
> Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] net/failsafe: fix
https://bugs.dpdk.org/show_bug.cgi?id=468
Bug ID: 468
Summary: bnxt: build fail with gcc10 default fno-common
Product: DPDK
Version: 20.05
Hardware: All
OS: Linux
Status: UNCONFIRMED
Severity: normal
Introduce a heler function to set the ip_version match.
Signed-off-by: Eli Britstein
Acked-by: Viacheslav Ovsiienko
---
drivers/net/mlx5/mlx5_flow_dv.c | 38 --
1 file changed, 28 insertions(+), 10 deletions(-)
diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/
The HW is optimized for IPv4/IPv6. For such cases avoid matching on
ethertype, and use ip_version field instead.
Signed-off-by: Eli Britstein
Acked-by: Viacheslav Ovsiienko
---
drivers/net/mlx5/mlx5_flow_dv.c | 53 +++--
1 file changed, 41 insertions(+), 12 d
The HW is optimized for IPv4/IPv6. For such cases avoid matching on
ethertype, and use ip_version field instead.
Eli Britstein (2):
net/mlx5: introduce a helper to set IP version match
net/mlx5: optimize performance for IPv4/IPv6 ethertype
drivers/net/mlx5/mlx5_flow_dv.c | 91 +++
Hi Eli
Good optimization.
Thanks.
Please see comment below...
From: Eli Britstein
> The HW is optimized for IPv4/IPv6. For such cases avoid matching on
> ethertype, and use ip_version field instead.
>
> Signed-off-by: Eli Britstein
> Acked-by: Viacheslav Ovsiienko
> ---
> drivers/net/mlx5/
Introduce a heler function to set the ip_version match.
Signed-off-by: Eli Britstein
Acked-by: Viacheslav Ovsiienko
---
drivers/net/mlx5/mlx5_flow_dv.c | 38 --
1 file changed, 28 insertions(+), 10 deletions(-)
diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/
The HW is optimized for IPv4/IPv6. For such cases avoid matching on
ethertype, and use ip_version field instead.
Signed-off-by: Eli Britstein
Acked-by: Viacheslav Ovsiienko
---
drivers/net/mlx5/mlx5_flow_dv.c | 51 +++--
1 file changed, 39 insertions(+), 12 d
The HW is optimized for IPv4/IPv6. For such cases avoid matching on
ethertype, and use ip_version field instead.
Eli Britstein (2):
net/mlx5: introduce a helper to set IP version match
net/mlx5: optimize performance for IPv4/IPv6 ethertype
drivers/net/mlx5/mlx5_flow_dv.c | 89 +++
On Sun, May 3, 2020 at 6:45 AM Varghese, Vipin wrote:
>
> Hi Pavan,
>
> Snipped
>
> > >> > >
> > >> > > When probing event device in secondary process skip
> > >> > > reinitializing the device data structure as it is already done in
> > >> > > primary
> > process.
> > >> > >
> > >> > > When remov
On 5/3/20 10:17 AM, Dekel Peled wrote:
> Specified pattern may be translated in different manner.
> For example the pattern "eth / ipv4" can be translated to match
> untagged packets only, since the pattern doesn't specify a VLAN item.
> It can also be translated to match both tagged and untagged p
From: Bill Zhou:
> Currently, there is no way to check the aging event or to get the current aged
> flows in testpmd, this patch include those implements, it's included:
>
> - Add new item "flow_aged" to the current print event command arguments.
> - Add new command to list all aged flows, mean
Currently, there is no way to check the aging event or to get the current
aged flows in testpmd, this patch include those implements, it's included:
- Add new item "flow_aged" to the current print event command arguments.
- Add new command to list all aged flows, meanwhile, we can set parameter
Hi,
> -Original Message-
> From: dev On Behalf Of Xiaoyu Min
> Sent: Wednesday, April 29, 2020 4:01 PM
> To: Matan Azrad ; Shahaf Shuler
> ; Slava Ovsiienko
> Cc: dev@dpdk.org; sta...@dpdk.org
> Subject: [dpdk-dev] [PATCH] net/mlx5: fix default rule do RSS regardless
> rxmode
>
> PMD cr
Implemented the needed Windows eal timer functions.
Signed-off-by: Fady Bader
---
lib/librte_eal/common/meson.build | 1 +
lib/librte_eal/windows/eal.c| 6 ++
lib/librte_eal/windows/eal_timer.c | 96 +
lib/librte_eal/windows/include/rte_os.h | 2
Eal common timer doesn't compile under Windows.
Compilation log:
error LNK2019:
unresolved external symbol nanosleep referenced in function
rte_delay_us_sleep
error LNK2019:
unresolved external symbol get_tsc_freq referenced in function set_tsc_freq
error LNK2019:
unresolved external symbol sleep
From: Fady Bader
This patchset splits OS dependent EAL timer functions and implements them for
windows.
v2:
* fixing styles and correctness errors.
v3:
* fixing correctness, get_tsc_freq was reimplemented.
Depends-on: series-9374 ("Windows basic memory management")
Fady Bader (2):
From: Bill Zhou:
> Those patches implement flow aging for mlx5 driver. First patch is to modify
> the current additional memory allocation for counter, so that it's easy to get
> every counter additional memory location by using offsetting. Second patch
> implements aging check and age-out event
From: Raslan Darawsheh
> Hi,
>
> > -Original Message-
> > From: David Christensen
> > Sent: Thursday, April 30, 2020 10:41 PM
> > To: Ori Kam ; Thomas Monjalon
> > ; Matan Azrad ; Shahaf
> Shuler
> > ; Slava Ovsiienko ;
> > Beilei Xing ; Qi Zhang ;
> > Maxime Coquelin ; Zhihong Wang
> >
Specified pattern may be translated in different manner.
For example the pattern "eth / ipv4" can be translated to match
untagged packets only, since the pattern doesn't specify a VLAN item.
It can also be translated to match both tagged and untagged packets,
for the same reason.
This patch updates
46 matches
Mail list logo
