Hi Akhil,
Please see inline.
Thanks,
Anoob
> -Original Message-
> From: Akhil Goyal
> Sent: Monday, April 6, 2020 12:12 PM
> To: Anoob Joseph ; Radu Nicolau
>
> Cc: Narayana Prasad Raju Athreya ; Tejasree Kondoj
> ; dev@dpdk.org
> Subject: [EXT] RE: [PATCH v3] examples/ipsec-secgw: sup
From: Satheesh Paul A
This patch adds SDP packet parsing support with custom L2 header,
adds support to include a field from custom header for flow tag
generation.
Signed-off-by: Satheesh Paul A
---
v2: No change. Resending after subscribing to dev@dpdk.org mailing list
doc/guides/nics/octeon
> > Hi Anoob,
> >
> > >
> > > Adding support for the following,
> > > 1. AES-192-GCM
> > > 2. AES-256-GCM
> > > 3. AES-192-CBC
> > >
> > > Signed-off-by: Anoob Joseph
> > > Signed-off-by: Tejasree Kondoj
> > > ---
> > > v3:
> > > * Fixed incorrect AES-GCM key length being printed during app start
On Sat, Apr 4, 2020 at 8:50 PM wrote:
>
> From: Pavan Nikhilesh
>
> When an application invokes rte_eth_dev_configure consecutively without
> setting up Rx/Tx queues, it will incorrectly return error while trying
> to restore Rx/Tx queue configuration.
>
> Fix configuration sequence by checking i
Minutes of Technical Board Meeting, 25-Mar-2020
Members Attending
-
-Bruce
-Hemant (Chair)
-Honnappa
-Jerin
-Kevin
-Konstantin
-Maxime
-Olivier
-Stephen
-Thomas
NOTE: The technical board meetings every second Wednesday on IRC channel
#dpdk-board, at 3pm UTC. Meetings are public
On Fri, Apr 3, 2020 at 2:24 PM Nithin Dabilpuram wrote:
>
> From: Krzysztof Kanas
>
> Add Traffic Management capability callbacks to provide
> global, level and node capabilities. This patch also
> adds documentation on Traffic Management Support.
>
> Signed-off-by: Nithin Dabilpuram
> Signed-of
> > Subject: [PATCH v3 11/12] service: optimize with c11 one-way barrier
> >
> > The num_mapped_cores and execute_lock are synchronized with
> > rte_atomic_XX APIs which is a full barrier, DMB, on aarch64. This
> > patch optimized it with
> > c11 atomic one-way barrier.
> >
> > Signed-off-by: Phi
https://bugs.dpdk.org/show_bug.cgi?id=440
Bug ID: 440
Summary: net/mlx5: Read of "out_of_buffer" using
fopen/fread/fclose causing TLB shootdowns due to
mmap/munmap
Product: DPDK
Version: 19.11
Hardware:
On Fri, 28 Feb 2020 15:04:51 -0500
"Dey, Souvik" wrote:
> + /* Configure the previously stored Multicast address list */
> + if (IS_VF(sc)) {
> +bnx2x_vfpf_set_mcast(sc, sc->mc_addrs, sc->mc_addrs_num);
> +}
Did you run checkpatch on this, the indentation does not match DPDK
> Subject: [PATCH v3 07/12] service: remove rte prefix from static functions
>
> Fixes: 3cf5eb1546ed ("service: fix and refactor atomic service accesses")
> Fixes: 21698354c832 ("service: introduce service cores concept")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Phil Yang
> Reviewed-by: Honnap
On Tue, Mar 31, 2020 at 9:54 PM Harman Kalra wrote:
>
> Adding support to configure link attributes like speed,
> duplex, negotiation.
>
> Signed-off-by: Harman Kalra
> ---
> Depends on https://patchwork.dpdk.org/patch/66344/
Acked-by: Jerin Jacob
Applied to dpdk-next-net-mrvl/master. Thanks
On Fri, Apr 3, 2020 at 7:05 PM Andrzej Ostruszka [C]
wrote:
>
> On 4/3/20 4:20 AM, vattun...@marvell.com wrote:
> > From: Vamsi Attunuru
> >
> > Patch adds routines to set/clear nix lf error & ras interrupt enable
> > registers. These nix lf error interrupts get triggered if there are
> > any fai
Hi Pavan,
> -Original Message-
> From: dev On Behalf Of Pavan Nikhilesh Bhagavatula
> Sent: Sunday, April 5, 2020 8:11 PM
> To: Ori Kam ; Jerin Jacob Kollanukkaran
> ; xiang.w.w...@intel.com
> Cc: dev@dpdk.org; Shahaf Shuler ;
> hemant.agra...@nxp.com; Opher Reviv ; Alex
> Rosenbaum ; Dov
Hi Pavan,
> -Original Message-
> From: dev On Behalf Of Pavan Nikhilesh Bhagavatula
>
> >> >+
> >> >+int
> >> >+rte_regexdev_configure(uint8_t dev_id, const struct
> >> >rte_regexdev_config *cfg)
> >> >+{
> >> >+ if (dev_id >= RTE_MAX_REGEXDEV_DEVS)
> >> >+ return -EINVAL;
> >> >
> >
> > The service id validation is verified in the calling function, remove
> > the redundant code inside the service_update function.
> >
> > Fixes: 21698354c832 ("service: introduce service cores concept")
> > Cc: sta...@dpdk.org
> >
> > Signed-off-by: Phil Yang
> > Reviewed-by: Honnappa Nag
Hi Ori,
>> From: dev On Behalf Of Pavan Nikhilesh
>Bhagavatula
>>
>> Looks like this implementation is incomplete?
>> I don't see any pmd specific helper functions for @see
>rte_cryptodev_pmd.c,
>> rte_eventdev_pmd*
>>
>I think the current implementation includes all needed functions,
>at least f
Hi Akhil,
Please see inline.
Thanks,
Anoob
> -Original Message-
> From: Akhil Goyal
> Sent: Sunday, April 5, 2020 8:54 PM
> To: Anoob Joseph ; Radu Nicolau
>
> Cc: Narayana Prasad Raju Athreya ; Tejasree Kondoj
> ; dev@dpdk.org
> Subject: [EXT] RE: [PATCH v3] examples/ipsec-secgw: supp
> > > > --
> > > > >
> > > > > This patch adds 3DES CBC mode cipher algorithm.
> > > > >
> > > > > Signed-off-by: Nagadheeraj Rottela
> > > > > ---
> > > > Is it worth mentioning in release notes?
> > >
> > > I added that description to avoid below checkpatch warning:
> > >
> > > ### crypto/nitrox
+dev@dpdk.org
-Original Message-
From: Sardar, Shamsher singh
Sent: Friday, April 3, 2020 10:12 PM
To: Ferruh Yigit
Cc: Kumar, Ravi1
Subject: RE: [dpdk-dev] [PATCH v2] net/axgbe: vlan support enabling in axgbe
Hi Yigit,
1. The Rx vlan filter set calls vlan_offload_set as shown below:
>
> >
> > Added cpu-crypto fallback option parsing as well as tests for it
> >
> > Signed-off-by: Mariusz Drost
> > ---
>
> Tested-by: Konstantin Ananyev
> Acked-by: Konstantin Ananyev
>
Applied to dpdk-next-crypto
Thanks.
>
> If the NPS_PKT ring/port is greater than 8191 the NPS_PKT*() macros will
> evaluate to incorrect values due to unintended sign extension from int
> to unsigned long. To fix this, add UL suffix to the constants in these
> macros. The same problem is with AQMQ_QSZX() macro also.
>
> Coverity
> -Original Message-
> From: Nagadheeraj Rottela
> Sent: Friday, March 27, 2020 7:13 PM
> To: Akhil Goyal
> Cc: dev@dpdk.org; tho...@monjalon.net; jsrika...@marvell.com;
> Nagadheeraj Rottela
> Subject: [PATCH v3 2/2] crypto/nitrox: fix array out of bounds access
>
> In nitrox_sym_pm
>
> > -Original Message-
> > From: Dybkowski, AdamX
> > Sent: Thursday, March 26, 2020 4:22 PM
> > To: dev@dpdk.org; Trahe, Fiona ;
> akhil.go...@nxp.com
> > Cc: Dybkowski, AdamX
> > Subject: [PATCH v4 1/2] common/qat: get version of QAT firmware
> >
> > This patch adds the function fo
>> >+
>> >+int
>> >+rte_regexdev_configure(uint8_t dev_id, const struct
>> >rte_regexdev_config *cfg)
>> >+{
>> >+ if (dev_id >= RTE_MAX_REGEXDEV_DEVS)
>> >+ return -EINVAL;
>> >+ if (regex_devices[dev_id] == NULL)
>> >+ return -EINVAL;
>> >+ if (cfg == NULL)
>> >+
> >
> > Acked-by: Anoob Joseph
>
> Applied to dpdk-next-crypto
>
> Thanks.
Squashed to the original patch which introduced the issue as it is not
submitted to master branch yet.
> >
> > If core 0 is not included in coremask in event mode then ipsec-secgw seg
> > faults.
> > This fix uses first core from coremask in rx queue configuration instead of
> > core
> 0
> > which was always previously used.
> >
> > Signed-off-by: Lukasz Bartosik
> > ---
> > examples/ipsec-sec
>
> v5: cosmetic change
> v4: Changes based on review comments from Akhil. Also taking the new PMD
> out of this serie
> to be pushed in separate serie.
> v3: squash the release notes updates into the related commits
> v2: including release note update + fix for typo in commit message reported by
Hi Jeff,
> -Original Message-
> From: Jeff Guo
> Sent: Tuesday, March 31, 2020 11:50 AM
> To: Ori Kam ; xiaolong...@intel.com;
> qi.z.zh...@intel.com
> Cc: dev@dpdk.org; jingjing...@intel.com; yahui@intel.com;
> simei...@intel.com
> Subject: Re: [dpdk-dev] [dpdk-dev v2 3/4] app/testpm
On Mon, Mar 16, 2020 at 3:04 PM Harman Kalra wrote:
>
> This patchset adds following new features to octeontx PMD:
> * Multi segment support
> * MTU support
> * Setting link up and down
> * VLAN filter offload
> * flow control - pause frames
> * Rx Tx checksum offload
>
> Harman Kalra (6):
> net
Hi Anoob,
>
> Adding support for the following,
> 1. AES-192-GCM
> 2. AES-256-GCM
> 3. AES-192-CBC
>
> Signed-off-by: Anoob Joseph
> Signed-off-by: Tejasree Kondoj
> ---
> v3:
> * Fixed incorrect AES-GCM key length being printed during app startup
> * Introduced new macro 'SALT_SIZE' to make t
Hi Xiao,
> -Original Message-
> From: Xiao Zhang
> Sent: Tuesday, March 31, 2020 4:30 PM
> To: dev@dpdk.org
> Cc: Ori Kam ; qi.z.zh...@intel.com;
> wei.zh...@intel.com; Xiao Zhang ; sta...@dpdk.org
> Subject: [v2] app/testpmd: fix PPPOES flow API
>
> The command line to create RTE flow
Hi Pavan,
Thanks for the review, PSB
Thanks,
Ori
> -Original Message-
> From: dev On Behalf Of Pavan Nikhilesh Bhagavatula
>
> >This commit implements all the RegEx public API.
> >
> >Signed-off-by: Ori Kam
> >---
> > lib/librte_regexdev/rte_regexdev.c | 298
> >+++
Hi Pavan,
Thanks for your review, PSB.
Best,
Ori
> -Original Message-
> From: dev On Behalf Of Pavan Nikhilesh Bhagavatula
>
> Looks like this implementation is incomplete?
> I don't see any pmd specific helper functions for @see rte_cryptodev_pmd.c,
> rte_eventdev_pmd*
>
I think the c
Hi Pavan,
Thanks for your comments, PSB.
Best,
Ori
> -Original Message-
> From: dev On Behalf Of Pavan Nikhilesh Bhagavatula
> Subject: Re: [dpdk-dev] [EXT] [PATCH v1 0/4] add RegEx class
>
> Hi Ori,
>
> Looks like the series is missing support for virtual devices i.e. vdev
> @see rte
Hi Pavan,
Thanks for your review, PSB.
Best,
Ori
> -Original Message-
> From: dev On Behalf Of Pavan Nikhilesh Bhagavatula
>
>
>
> > #
> >+# Compile regex device support
> >+#
> >+CONFIG_RTE_LIBRTE_REGEXDEV=y
> >+CONFIG_RTE_LIBRTE_REGEXDEV_DEBUG=n
>
> The above flag is never used in
On Sat, Mar 7, 2020 at 3:27 PM wrote:
>
> From: Kiran Kumar K
>
> Octeontx2 HW has support for detecting the bad L2/L3/L4 UDP lengths.
> Since DPDK does not have specific error flag for this, exposing it
> as bad checksum failure in mbuff:ol_flags to leverage this feature.
>
> These errors will b
On Wed, Mar 4, 2020 at 4:58 AM Rasesh Mody wrote:
>
> Hi Souvik,
>
>
>
> Could you resend this patch in text format?
>
>
>
> When we are doing open source work, the contents of the footer are not
> compatible with what we are doing. Please remove the footer in patches and
> mailing list interact
On Thu, Mar 5, 2020 at 7:21 PM Dey, Souvik wrote:
>
> Thanks will do that. And will also try to remove the trailer in the patches.
> Thanks for pointing it out.
>
> From: dev On Behalf Of Rasesh Mody
> Sent: Tuesday, March 3, 2020 6:01 PM
> To: Dey, Souvik ; Shahed Shaikh ; Jerin
> Jacob Kollan
Hi Lukasz,
Please see inline.
Thanks,
Anoob
> -Original Message-
> From: Lukasz Wojciechowski
> Sent: Saturday, April 4, 2020 12:06 AM
> To: Anoob Joseph ; dev@dpdk.org
> Cc: Narayana Prasad Raju Athreya ; Lukas Bartosik [C]
>
> Subject: [EXT] Re: [dpdk-dev] [PATCH 01/13] librte_securi
On Wed, Mar 4, 2020 at 7:19 PM Bruce Richardson
wrote:
>
> On Wed, Mar 04, 2020 at 11:17:04AM +0530, agup...@marvell.com wrote:
> > From: Amit Gupta
> >
> > Add a condition to check if octeontx drivers are disabled.
> > octeontx drivers are built only if dependent drivers i.e.
> > ethdev, mempool
On Fri, Mar 6, 2020 at 7:14 PM Nithin Dabilpuram
wrote:
>
> Sync mail box data structures to version 0x0005 to
> that of kernel AF driver.
>
> Signed-off-by: Nithin Dabilpuram
Acked-by: Jerin Jacob
Applied to dpdk-next-net-mrvl/master. Thanks
This patch is dependent on another net/octeontx2:
The following changes since commit 10c69730a4b4910b4d57c365329a6c26479d25cd:
lpm6: make IPv6 address immutable (2020-03-31 21:45:43 +0200)
are available in the Git repository at:
http://dpdk.org/git/next/dpdk-next-eventdev
for you to fetch changes up to f2c9b773f95dfe2386d68814ac2788d26e20a
From: Nithin Dabilpuram
Adding the user guide for l3fwd graph application.
Signed-off-by: Nithin Dabilpuram
---
MAINTAINERS | 1 +
doc/guides/rel_notes/release_20_05.rst| 8 +
doc/guides/sample_app_ug/index.rst| 1 +
doc/guides/sample
From: Nithin Dabilpuram
Add graph creation, configuration logic and graph main loop.
This graph main loop is run on every slave lcore and calls
rte_graph_walk() to walk over lcore specific rte_graph.
Master core accumulates and prints graph walk stats of all the
lcore's graph's.
Signed-off-by: N
From: Nithin Dabilpuram
Add packet drop node process function for pkt_drop
rte_node. This node simply free's every object received as
an rte_mbuf to its rte_pktmbuf pool.
Signed-off-by: Nithin Dabilpuram
Signed-off-by: Pavan Nikhilesh
Signed-off-by: Kiran Kumar K
---
lib/librte_node/Makefile
From: Nithin Dabilpuram
Add graph based l3fwd application skeleton with cmdline
parsing support inline with normal l3fwd.
Signed-off-by: Nithin Dabilpuram
---
MAINTAINERS | 3 +
examples/Makefile| 3 +
examples/l3fwd-graph/Makefile| 58
exampl
From: Nithin Dabilpuram
Add changes to ethdev port and queue configuration based
on command line parameters for l3fwd graph application.
Signed-off-by: Nithin Dabilpuram
---
examples/l3fwd-graph/main.c | 350 +++-
1 file changed, 349 insertions(+), 1 deletion(-)
From: Kiran Kumar K
Add ip4 rewrite process function for ip4_rewrite
rte_node. On every packet received by this node,
header is overwritten with new data before forwarding
it to next node. Header data to overwrite with is
identified by next hop id passed in mbuf priv data
by previous node.
Signe
From: Pavan Nikhilesh
Add IPv4 lookup process function for ip4_lookup
rte_node. This node performs LPM lookup using x86_64
vector supported RTE_LPM API on every packet received
and forwards it to a next node that is identified by
lookup result.
Signed-off-by: Pavan Nikhilesh
Signed-off-by: Nith
From: Nithin Dabilpuram
Add arm64 specific IPv4 lookup process function
for ip4_lookup node. This node performs LPM lookup
on every packet received and forwards it to a next
node that is identified by lookup result.
Signed-off-by: Nithin Dabilpuram
Signed-off-by: Kiran Kumar K
Signed-off-by: P
From: Nithin Dabilpuram
Add ip4_rewrite and ip4_lookup ctrl API. ip4_lookup ctrl
API is used to add route entries for LPM lookup with
result data containing next hop id and next proto.
ip4_rewrite ctrl API is used to add rewrite data for
every next hop.
Signed-off-by: Nithin Dabilpuram
Signed-o
From: Pavan Nikhilesh
Add IPv4 lookup process function for ip4_lookup node.
This node performs LPM lookup using simple RTE_LPM API on every packet
received and forwards it to a next node that is identified by lookup
result.
Signed-off-by: Pavan Nikhilesh
Signed-off-by: Nithin Dabilpuram
---
d
From: Nithin Dabilpuram
Add ctrl api to setup ethdev_rx and ethdev_tx node.
This ctrl api clones 'N' number of ethdev_rx and ethdev_tx
nodes with specific (port, queue) pairs updated in their context.
All the ethdev ports and queues are setup before this api
is called.
Signed-off-by: Nithin Dabi
From: Nithin Dabilpuram
Add log infra for node specific logging.
Also, add null rte_node that just ignores all the objects
directed to it.
Signed-off-by: Nithin Dabilpuram
Signed-off-by: Pavan Nikhilesh
Signed-off-by: Kiran Kumar K
---
MAINTAINERS | 5 +
app/tes
From: Nithin Dabilpuram
Add source rte_node ethdev_rx process function and register
it. This node is a source node that will be called periodically
and when called, performs rte_eth_rx_burst() on a specific
(port, queue) pair and enqueue them as stream of objects to
next node.
Signed-off-by: Nit
From: Nithin Dabilpuram
Add rte_node ethdev_tx process function and register it to
graph infra. This node has a specific (port, tx-queue) as context
and it enqueue's all the packets received to that specific queue pair.
When rte_eth_tx_burst() i.e enqueue to queue pair fails, packets
are forwarde
From: Jerin Jacob
Adding implementation for graph specific API to dump the
Graph information to a file. This API will dump detailed internal
info about node objects and graph objects.
Signed-off-by: Jerin Jacob
Signed-off-by: Kiran Kumar K
Signed-off-by: Pavan Nikhilesh
Signed-off-by: Nithin
From: Pavan Nikhilesh
Add unit test framework to create and test performance of various graph
models.
example command to test:
echo "graph_perf_autotest" | sudo ./build/app/test/dpdk-test -c 0x30
Signed-off-by: Pavan Nikhilesh
Signed-off-by: Nithin Dabilpuram
---
app/test/Makefile
From: Jerin Jacob
Adding implementation for graph stats collection API. This API will
create a cluster for a specified node pattern and aggregate the node
runtime stats.
Signed-off-by: Jerin Jacob
Signed-off-by: Kiran Kumar K
Signed-off-by: Pavan Nikhilesh
Signed-off-by: Nithin Dabilpuram
--
From: Jerin Jacob
Adding implementation for rte_graph_walk() API. This will perform a walk
on the circular buffer and call the process function of each node
and collect the stats if stats collection is enabled.
Signed-off-by: Jerin Jacob
Signed-off-by: Kiran Kumar K
Signed-off-by: Pavan Nikhil
From: Kiran Kumar K
Adding the unit test to test the functionality of node and graph APIs.
Testing includes registering a node, cloning a node, creating a graph,
perform graph walk, collecting stats and all node and graph debug APIs.
example command to test:
echo "graph_autotest" | sudo ./build/
From: Jerin Jacob
Adding API implementation support exporting the graph object to file.
This will export the graph to a file in Graphviz format.
It can be viewed in many viewers such as
https://dreampuf.github.io/GraphvizOnline/
Signed-off-by: Jerin Jacob
Signed-off-by: Kiran Kumar K
Signed-of
From: Jerin Jacob
Adding support for graph specific API implementation like
Graph lookup to get graph object, retrieving graph ID
>From name and graph name from ID.
Signed-off-by: Jerin Jacob
Signed-off-by: Kiran Kumar K
Signed-off-by: Pavan Nikhilesh
Signed-off-by: Nithin Dabilpuram
---
li
From: Jerin Jacob
Adding graph specific API implementations like graph create
and graph destroy. This detect loops in the graph,
check for isolated nodes and operation to verify the validity of
graph.
Signed-off-by: Jerin Jacob
Signed-off-by: Kiran Kumar K
Signed-off-by: Pavan Nikhilesh
Signe
From: Jerin Jacob
Adding support to create and populate the memory for graph reel.
This includes reserving the memory in the memzone, populating the nodes,
Allocating memory for node-specific streams to hold objects.
Once it is populated the reel memory contains the following sections.
+---
From: Jerin Jacob
Adding internal graph API helpers support to check whether a graph has
isolated nodes and any node have a loop to itself and BFS
algorithm implementation etc.
Signed-off-by: Jerin Jacob
Signed-off-by: Nithin Dabilpuram
---
lib/librte_graph/Makefile| 1 +
lib/librte
From: Jerin Jacob
Graph architecture abstracts the data processing functions as
"node" and "link" them together to create a complex "graph" to enable
reusable/modular data processing functions.
These APIs enables graph framework operations such as create, lookup,
dump and destroy on graph and no
From: Jerin Jacob
Adding node-specific API implementation like cloning node, updating
edges for the node, shrinking edges of a node, retrieving edges of a
node.
Signed-off-by: Jerin Jacob
Signed-off-by: Kiran Kumar K
Signed-off-by: Pavan Nikhilesh
Signed-off-by: Nithin Dabilpuram
---
lib/li
From: Jerin Jacob
Adding rte_node_register() API implementation includes allocating
memory for node object, check for duplicate node name and
add the allocated node to STAILQ node_list for future use.
Signed-off-by: Jerin Jacob
Signed-off-by: Kiran Kumar K
Signed-off-by: Pavan Nikhilesh
Signe
From: Jerin Jacob
Adding node debug API implementation support to dump
single or all the node objects to the given file.
Signed-off-by: Jerin Jacob
Signed-off-by: Kiran Kumar K
Signed-off-by: Pavan Nikhilesh
Signed-off-by: Nithin Dabilpuram
---
lib/librte_graph/Makefile | 1 +
From: Jerin Jacob
Using graph traversal for packet processing is a proven architecture
that has been implemented in various open source libraries.
Graph architecture for packet processing enables abstracting the data
processing functions as “nodes” and “links” them together to create a
complex “
71 matches
Mail list logo
