Re: [dpdk-dev] [PATCH v4 00/13] add switch filter support for intel DCF

2020-04-03 Thread Ye Xiaolong
On 04/03, Zhang, Qi Z wrote: > > >> -Original Message- >> From: Zhao1, Wei >> Sent: Friday, April 3, 2020 12:46 PM >> To: dev@dpdk.org >> Cc: Zhang, Qi Z ; Lu, Nannan ; >> Fu, Qi ; Peng, Yuan >> Subject: [PATCH v4 00/13] add switch filter support for intel DCF >> >> A DCF (Device Config

[dpdk-dev] Memory requirement calculation to create mempools with external memory

2020-04-03 Thread Bao-Long Tran
Hi, My goal is to create mbuf pools using external memory with rte_malloc_heap_*(). The initial implementation goes like this: - Create an empty heap rte_malloc_heap_create() - Calculate memory required - Provision and add the calculated single memory chunk to the heap rte_malloc_heap_memory_ad

[dpdk-dev] [Bug 438] memif sock does not honor file-prefix

2020-04-03 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=438 Bug ID: 438 Summary: memif sock does not honor file-prefix Product: DPDK Version: 20.02 Hardware: x86 OS: Linux Status: UNCONFIRMED Severity: normal Prio

[dpdk-dev] [Bug 437] memif pmd, does not cleanup on primary application restart

2020-04-03 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=437 Bug ID: 437 Summary: memif pmd, does not cleanup on primary application restart Product: DPDK Version: 20.02 Hardware: x86 OS: Linux Status: UNCONFIRMED

[dpdk-dev] [Bug 436] rte_eth_promiscuous_enable fails for memif on l2fwd

2020-04-03 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=436 Bug ID: 436 Summary: rte_eth_promiscuous_enable fails for memif on l2fwd Product: DPDK Version: 20.02 Hardware: All OS: All Status: UNCONFIRMED Severity: normal

Re: [dpdk-dev] [PATCH] i40evf: use non spinning delay when issuing AQ request to PF

2020-04-03 Thread Zhang, Qi Z
> -Original Message- > From: Laurent Hardy > Sent: Monday, March 30, 2020 10:34 PM > To: dev@dpdk.org; Ye, Xiaolong ; Zhang, Qi Z > > Cc: olivier.m...@6wind.com; david.march...@redhat.com > Subject: [PATCH] i40evf: use non spinning delay when issuing AQ request to > PF > > When a port

[dpdk-dev] [Bug 435] Proposed improvement to non-interactive loop timing

2020-04-03 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=435 Bug ID: 435 Summary: Proposed improvement to non-interactive loop timing Product: DPDK Version: 20.02 Hardware: All OS: Linux Status: UNCONFIRMED Severity: enhance

[dpdk-dev] [Bug 434] bps calculation does not fit in 64 bit

2020-04-03 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=434 Bug ID: 434 Summary: bps calculation does not fit in 64 bit Product: DPDK Version: 20.02 Hardware: x86 OS: Linux Status: UNCONFIRMED Severity: normal Pri

Re: [dpdk-dev] [PATCH v2 0/4] Introduce IF proxy library

2020-04-03 Thread Thomas Monjalon
03/04/2020 23:18, Morten Brørup: > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Jerin Jacob > > Thomas Monjalon wrote: > > > 02/04/2020 15:48, Andrzej Ostruszka [C]: > > > > On 3/26/20 6:42 PM, Andrzej Ostruszka wrote: > > > > > On 3/25/20 12:11 PM, Morten Brørup wrote: > > > > [...] > > >

Re: [dpdk-dev] [PATCH v2 0/4] Introduce IF proxy library

2020-04-03 Thread Thomas Monjalon
Hi Andrzej, Thanks for the very good explanations in the cover letter. I have several comments and questions about the design. I think IF proxy is a good idea which should be part of a bigger plan. 10/03/2020 12:10, Andrzej Ostruszka: > What is this useful for > === > > Usua

Re: [dpdk-dev] [PATCH v2 0/4] Introduce IF proxy library

2020-04-03 Thread Morten Brørup
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Jerin Jacob > Sent: Friday, April 3, 2020 9:09 PM > > On Fri, Apr 3, 2020 at 10:49 PM Thomas Monjalon > wrote: > > > > 02/04/2020 15:48, Andrzej Ostruszka [C]: > > > On 3/26/20 6:42 PM, Andrzej Ostruszka wrote: > > > > On 3/25/20 12:11 PM, Mo

Re: [dpdk-dev] [PATCH 05/13] app/test: introduce librte_security tests

2020-04-03 Thread Lukasz Wojciechowski
Dear Akhil, W dniu 01.04.2020 o 19:09, Akhil Goyal pisze: > Hi Lukasz, > > >> This patch introduces set of unit tests of librte_security API functions. >> Tests are added to dpdk-test application and can be run with >> "security_autotest" runtime command. >> >> This is the first patch in the serie

Re: [dpdk-dev] [PATCH v2 0/4] Introduce IF proxy library

2020-04-03 Thread Jerin Jacob
On Fri, Apr 3, 2020 at 10:49 PM Thomas Monjalon wrote: > > 02/04/2020 15:48, Andrzej Ostruszka [C]: > > On 3/26/20 6:42 PM, Andrzej Ostruszka wrote: > > > On 3/25/20 12:11 PM, Morten Brørup wrote: > > [...] > > >> And I am still strongly opposed to the callback method: > > > > > > Noted - however

[dpdk-dev] [PATCH v4 3/4] doc/rcu: add RCU integration design details

2020-04-03 Thread Honnappa Nagarahalli
From: Ruifeng Wang Add a section to describe a design to integrate QSBR RCU library with other libraries in DPDK. Signed-off-by: Honnappa Nagarahalli --- doc/guides/prog_guide/rcu_lib.rst | 59 +++ 1 file changed, 59 insertions(+) diff --git a/doc/guides/prog_guide

[dpdk-dev] [PATCH v4 1/4] lib/rcu: add resource reclamation APIs

2020-04-03 Thread Honnappa Nagarahalli
Add resource reclamation APIs to make it simple for applications and libraries to integrate rte_rcu library. Signed-off-by: Honnappa Nagarahalli Reviewed-by: Ola Liljedhal Reviewed-by: Ruifeng Wang --- lib/librte_rcu/Makefile| 2 +- lib/librte_rcu/meson.build | 2 + lib

[dpdk-dev] [PATCH v4 2/4] test/rcu: test cases for RCU defer queue APIs

2020-04-03 Thread Honnappa Nagarahalli
Add test cases for RCU defer queue APIs. Signed-off-by: Honnappa Nagarahalli --- app/test/test_rcu_qsbr.c | 365 ++- 1 file changed, 363 insertions(+), 2 deletions(-) diff --git a/app/test/test_rcu_qsbr.c b/app/test/test_rcu_qsbr.c index b60dc5099..94869b7b9

[dpdk-dev] [PATCH v4 4/4] lib/rcu: add additional debug logs

2020-04-03 Thread Honnappa Nagarahalli
Added additional debug logs. These helped in debugging RCU defer APIs. Signed-off-by: Honnappa Nagarahalli --- lib/librte_rcu/rte_rcu_qsbr.h | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/lib/librte_rcu/rte_rcu_qsbr.h b/lib/librte_rcu/rte_rcu_qsbr.h index 213f9b029..

[dpdk-dev] [PATCH v4 0/4] Add RCU reclamation APIs

2020-04-03 Thread Honnappa Nagarahalli
v4 1) RCU reclamation APIs changed to provide lot more flexibility a) The rte_rcu_qsbr_dq_enqueue and rte_rcu_qsbr_dq_reclaim APIs can be configured to be MT safe b) The auto reclamation limit and how much to reclaim can be configured c) rte_rcu_qsbr_dq_reclaim API returns the

Re: [dpdk-dev] [PATCH 01/13] librte_security: fix verification of parameters

2020-04-03 Thread Lukasz Wojciechowski
Hi Anoob, Thank you very much for your review. Please see my answers inline. Best regards, Lukasz W dniu 17.03.2020 o 13:59, Anoob Joseph pisze: > Hi Lukasz, > > Please see inline. > > Thanks, > Anoob > >> -Original Message- >> From: dev On Behalf Of Lukasz Wojciechowski >> Sent: Thurs

[dpdk-dev] [PATCH v3 9/9] ring: add C11 memory model for new sync modes

2020-04-03 Thread Konstantin Ananyev
Add C11 atomics based implementation for RTS and HTS head/tail update primitivies. Signed-off-by: Konstantin Ananyev --- lib/librte_ring/Makefile | 4 +- lib/librte_ring/meson.build| 2 + lib/librte_ring/rte_ring_hts.h | 4 + lib/librte_ring/rte_ring_hts_c

[dpdk-dev] [PATCH v3 8/9] test/ring: add stress test for MT peek API

2020-04-03 Thread Konstantin Ananyev
Introduce new test case to test MT peek API. Signed-off-by: Konstantin Ananyev --- app/test/Makefile| 1 + app/test/meson.build | 1 + app/test/test_ring_peek_stress.c | 43 app/test/test_ring_stress.c | 3 +++ app/test/test_ri

[dpdk-dev] [PATCH v3 6/9] test/ring: add contention stress test for HTS ring

2020-04-03 Thread Konstantin Ananyev
Introduce new test case to test HTS ring mode under contention. Signed-off-by: Konstantin Ananyev --- app/test/Makefile | 1 + app/test/meson.build| 1 + app/test/test_ring_hts_stress.c | 32 app/test/test_ring_stress.c | 3 +++ a

[dpdk-dev] [PATCH v3 7/9] ring: introduce peek style API

2020-04-03 Thread Konstantin Ananyev
For rings with producer/consumer in RTE_RING_SYNC_ST, RTE_RING_SYNC_MT_HTS mode, provide an ability to split enqueue/dequeue operation into two phases: - enqueue/dequeue start - enqueue/dequeue finish That allows user to inspect objects in the ring without removing them from it (aka MT

[dpdk-dev] [PATCH v3 4/9] test/ring: add contention stress test for RTS ring

2020-04-03 Thread Konstantin Ananyev
Introduce new test case to test RTS ring mode under contention. Signed-off-by: Konstantin Ananyev --- app/test/Makefile | 1 + app/test/meson.build| 1 + app/test/test_ring_rts_stress.c | 32 app/test/test_ring_stress.c | 3 +++ a

[dpdk-dev] [PATCH v3 5/9] ring: introduce HTS ring mode

2020-04-03 Thread Konstantin Ananyev
Introduce head/tail sync mode for MT ring synchronization. In that mode enqueue/dequeue operation is fully serialized: only one thread at a time is allowed to perform given op. Suppose to reduce stall times in case when ring is used on overcommitted cpus (multiple active threads on the same cpu).

[dpdk-dev] [PATCH v3 3/9] ring: introduce RTS ring mode

2020-04-03 Thread Konstantin Ananyev
Introduce relaxed tail sync (RTS) mode for MT ring synchronization. Aim to reduce stall times in case when ring is used on overcommited cpus (multiple active threads on the same cpu). The main difference from original MP/MC algorithm is that tail value is increased not by every thread that finished

[dpdk-dev] [PATCH v3 1/9] test/ring: add contention stress test

2020-04-03 Thread Konstantin Ananyev
Introduce new test-case to measure ring perfomance under contention (miltiple producers/consumers). Starts dequeue/enqueue loop on all available slave lcores. Signed-off-by: Konstantin Ananyev --- app/test/Makefile| 2 + app/test/meson.build | 2 + app/test/test_r

[dpdk-dev] [PATCH v3 2/9] ring: prepare ring to allow new sync schemes

2020-04-03 Thread Konstantin Ananyev
Change from *single* to *sync_type* to allow different synchronisation schemes to be applied. Mark *single* as deprecated in comments. Add new functions to allow user to query ring sync types. Replace direct access to *single* with appopriate function call. Signed-off-by: Konstantin Ananyev ---

[dpdk-dev] [PATCH v3 0/9] New sync modes for ring

2020-04-03 Thread Konstantin Ananyev
V2 - V3 1. Few more compilation fixes (for gcc 4.8.X) 2. Extra update devtools/libabigail.abignore (workaround) V1 - v2 changes: 1. Fix compilation issues 2. Add C11 atomics support 3. Updates devtools/libabigail.abignore (workaround) RFC - V1 changes: 1. remove ABI brekage (at least I hope I di

Re: [dpdk-dev] [PATCH v3 1/2] net/hinic/base: fix FW hotactive problem

2020-04-03 Thread Ferruh Yigit
On 4/1/2020 10:30 AM, Xiaoyun wang wrote: > When PF detects FW is hotactive, up returns HINIC_DEV_BUSY_ACTIVE_FW for Hi Xiaoyun, What is 'hotactive'? "hot active"? Does it mean FW busy? > pf driver, when cmdq reinit at txrx flush, cmdq will fail, driver should > reinit the cmdq when port start.

Re: [dpdk-dev] [PATCH v2 0/4] Introduce IF proxy library

2020-04-03 Thread Thomas Monjalon
02/04/2020 15:48, Andrzej Ostruszka [C]: > On 3/26/20 6:42 PM, Andrzej Ostruszka wrote: > > On 3/25/20 12:11 PM, Morten Brørup wrote: > [...] > >> And I am still strongly opposed to the callback method: > > > > Noted - however for now I would like to keep them. I don't have much > > experience wi

Re: [dpdk-dev] [PATCH v4] ethdev: fix for compiler warning when vtune profiling is on

2020-04-03 Thread Ferruh Yigit
On 4/2/2020 7:45 PM, eugeny.parshu...@linux.intel.com wrote: > From: Eugeny Parshutin > > Add the previous prototype for the 'profile_hook_rx_burst_cb' function > to fix the compiler warning when the DPDK is built with > 'RTE_ETHDEV_PROFILE_WITH_VTUNE' config option enabled: > /home/dpdk/lib/libr

Re: [dpdk-dev] [EXT] Re: [PATCH] test: add reassembly perf test

2020-04-03 Thread Pavan Nikhilesh Bhagavatula
>> From: Pavan Nikhilesh >> >> Add reassembly perf autotest for both ipv4 and ipv6 reassembly. >> Each test is performed with vairable number of fragments per flow, >> either ordered or unorderd fragments and interleaved flows. >> >> Signed-off-by: Pavan Nikhilesh >> --- >> app/test/meson.build

[dpdk-dev] [PATCH v2 4/4] app/crypto-perf: add support for multi-function processing

2020-04-03 Thread David Coyle
Support for multi-function operations, via a raw device, has been added to the test-crypto-perf app. A new optype has been added: multi-fn A new parameter has been added for multi-fn mode: --multi-fn-params The field specify what type of multi-function processing is required and the options ass

[dpdk-dev] [PATCH v2 3/4] test/rawdev: add aesni_mb raw device tests

2020-04-03 Thread David Coyle
Adding unit tests for the AESNI-MB raw device. Signed-off-by: David Coyle Signed-off-by: Mairtin o Loingsigh --- app/test/test_rawdev.c | 16 1 file changed, 16 insertions(+) diff --git a/app/test/test_rawdev.c b/app/test/test_rawdev.c index 524a9d5f3..badb6a756 100644 --- a/a

[dpdk-dev] [PATCH v2 2/4] raw/aesni_mb: add aesni_mb raw device

2020-04-03 Thread David Coyle
Adding an AESNI-MB raw device, thereby exposing AESNI-MB to the rawdev API. The AESNI-MB raw device will use the multi-function interface to allow combined operations be sent to the AESNI-MB software library. Signed-off-by: David Coyle Signed-off-by: Mairtin o Loingsigh --- config/common_base

[dpdk-dev] [PATCH v2 1/4] raw/common: add multi-function interface

2020-04-03 Thread David Coyle
The multi-function interface provides a flexible and extensible way of combining one or more packet processing functions into a single operation. The interface can be used by applications to send the combined operations to a optimized software or hardware accelerator via a raw device. Signed-off-b

[dpdk-dev] [PATCH v2 0/4] introduce multi-function processing support

2020-04-03 Thread David Coyle
PLEASE NOTE: This patchset supercedes the following v1 patches which were mistakenly added as stand-alone patches (apologies for any confusion this may cause) https://patchwork.dpdk.org/patch/66733/ https://patchwork.dpdk.org/patch/66735/ https://patchwork.dpdk.org/patch/66736/ PLEASE NOTE ALSO:

Re: [dpdk-dev] [PATCH v1] app/testpmd: add memory dump command

2020-04-03 Thread Morten Brørup
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Stephen Hemminger > Sent: Friday, April 3, 2020 6:09 PM > > On Fri, 3 Apr 2020 14:29:06 +0100 > Ferruh Yigit wrote: > > > > + socket_stats.heap_totalsz_bytes / 1.0e6, > > > + socket_stats.heap_allocsz_bytes /

Re: [dpdk-dev] [PATCH v2 0/2] support CPU crypto for AESNI MB PMD

2020-04-03 Thread Akhil Goyal
Hi Pablo, Could you please ack this patchset if no issues? > > v2 - v1 > Fix gcc 4.8 compilation issue > > Add support for CPU crypto API into aesni_mb PMD > and extend cryptodev UT to cover this new functionality. > > Konstantin Ananyev (2): > crypto/aesni_mb: support CPU crypto > test/c

Re: [dpdk-dev] [PATCH v1] app/testpmd: add memory dump command

2020-04-03 Thread Stephen Hemminger
On Fri, 3 Apr 2020 14:29:06 +0100 Ferruh Yigit wrote: > > + socket_stats.heap_totalsz_bytes / 1.0e6, > > + socket_stats.heap_allocsz_bytes / 1.0e6, > > + (double)socket_stats.heap_allocsz_bytes * 100 / > > + (double)socket_st

Re: [dpdk-dev] [PATCH] test: add reassembly perf test

2020-04-03 Thread Aaron Conole
writes: > From: Pavan Nikhilesh > > Add reassembly perf autotest for both ipv4 and ipv6 reassembly. > Each test is performed with vairable number of fragments per flow, > either ordered or unorderd fragments and interleaved flows. > > Signed-off-by: Pavan Nikhilesh > --- > app/test/meson.build

Re: [dpdk-dev] [PATCH v1] app/testpmd: add memory dump command

2020-04-03 Thread Stephen Hemminger
On Fri, 3 Apr 2020 14:29:06 +0100 Ferruh Yigit wrote: > > + int64_t total = 0; > > + int64_t alloc = 0; > > + int64_t free = 0; Should be unsigned (ie uint64_t)

[dpdk-dev] [PATCH v2 1/2] crypto/aesni_mb: support CPU crypto

2020-04-03 Thread Konstantin Ananyev
Add support for CPU crypto mode by introducing required handler. Signed-off-by: Konstantin Ananyev --- doc/guides/cryptodevs/aesni_mb.rst| 3 + doc/guides/cryptodevs/features/aesni_mb.ini | 1 + .../crypto/aesni_mb/aesni_mb_pmd_private.h| 5 +- drivers/crypto/aesni_mb/rte

[dpdk-dev] [PATCH v2 2/2] test/crypto: add CPU crypto mode for AESNI MB

2020-04-03 Thread Konstantin Ananyev
This patch adds ability to run unit tests in cpu crypto mode for AESNI MB cryptodev. Signed-off-by: Konstantin Ananyev --- app/test/test_cryptodev.c | 146 ++ 1 file changed, 115 insertions(+), 31 deletions(-) diff --git a/app/test/test_cryptodev.c b/app/test

[dpdk-dev] [PATCH v2 0/2] support CPU crypto for AESNI MB PMD

2020-04-03 Thread Konstantin Ananyev
v2 - v1 Fix gcc 4.8 compilation issue Add support for CPU crypto API into aesni_mb PMD and extend cryptodev UT to cover this new functionality. Konstantin Ananyev (2): crypto/aesni_mb: support CPU crypto test/crypto: add CPU crypto mode for AESNI MB app/test/test_cryptodev.c

[dpdk-dev] [PATCH v4 32/33] mempool: add tracepoints

2020-04-03 Thread jerinj
From: Sunil Kumar Kori Add tracepoints at important and mandatory APIs for tracing support. Signed-off-by: Sunil Kumar Kori --- lib/librte_mempool/Makefile| 3 + lib/librte_mempool/mempool_trace_points.c | 108 +++ lib/librte_mempool/meson.build | 5

[dpdk-dev] [PATCH v4 33/33] doc: add trace library guide

2020-04-03 Thread jerinj
From: Jerin Jacob Add programmar's guide for trace library support. Signed-off-by: Jerin Jacob Signed-off-by: Sunil Kumar Kori --- MAINTAINERS| 1 + doc/guides/prog_guide/index.rst| 1 + doc/guides/prog_guide/trace_lib.rst| 339 +

[dpdk-dev] [PATCH v4 29/33] ethdev: add tracepoints

2020-04-03 Thread jerinj
From: Sunil Kumar Kori Add tracepoints at important and mandatory APIs for tracing support. Signed-off-by: Sunil Kumar Kori --- examples/cmdline/Makefile | 1 + examples/cmdline/meson.build | 1 + examples/distributor/Makefile | 1 + exam

[dpdk-dev] [PATCH v4 28/33] eal/trace: add trace performance test cases

2020-04-03 Thread jerinj
From: Jerin Jacob This test case shall be used to measure the trace overhead. Example command to run the performance test case. echo "trace_perf" | ./build/app/test/dpdk-test -c 0x3 --trace-level=8 Signed-off-by: Jerin Jacob --- app/test/Makefile | 1 + app/test/meson.build

[dpdk-dev] [PATCH v4 31/33] cryptodev: add tracepoints

2020-04-03 Thread jerinj
From: Sunil Kumar Kori Add tracepoints at important and mandatory APIs for tracing support. Signed-off-by: Sunil Kumar Kori --- lib/librte_cryptodev/Makefile | 4 +- lib/librte_cryptodev/cryptodev_trace_points.c | 70 + lib/librte_cryptodev/meson.build |

[dpdk-dev] [PATCH v4 30/33] eventdev: add tracepoints

2020-04-03 Thread jerinj
From: Sunil Kumar Kori Add tracepoints at important and mandatory APIs for tracing support. Signed-off-by: Sunil Kumar Kori --- lib/librte_eventdev/Makefile | 3 + lib/librte_eventdev/eventdev_trace_points.c | 173 +++ lib/librte_eventdev/meson.build

[dpdk-dev] [PATCH v4 25/33] eal/trace: add trace bufsize configuration parameter

2020-04-03 Thread jerinj
From: Sunil Kumar Kori Trace library exposes --trace-bufsz EAL parameter to configure maximum size of ring buffer where events are to be stored. Signed-off-by: Sunil Kumar Kori --- doc/guides/linux_gsg/eal_args.include.rst | 13 lib/librte_eal/common/eal_common_options.c| 17 +

[dpdk-dev] [PATCH v4 27/33] eal/trace: add unit test cases

2020-04-03 Thread jerinj
From: Sunil Kumar Kori Example commands to run UT and check the traces with babeltrace viewer. - Delete the existing /root/dpdk-traces/ directory if needed. > sudo rm -rf /root/dpdk-traces/ - Start the dpdk-test > sudo ./build/app/test/dpdk-test -c 0x3 - --trace-level=8 - Run trace_autotest >

[dpdk-dev] [PATCH v4 26/33] eal/trace: add trace mode configuration parameter

2020-04-03 Thread jerinj
From: Sunil Kumar Kori Trace library exposes --trace-mode eal parameter to configure event record mode when ring buffers are full. Signed-off-by: Sunil Kumar Kori --- doc/guides/linux_gsg/eal_args.include.rst | 12 ++ lib/librte_eal/common/eal_common_options.c| 17 .../com

[dpdk-dev] [PATCH v4 24/33] eal/trace: add trace dir configuration parameter

2020-04-03 Thread jerinj
From: Sunil Kumar Kori Trace library exposes --trace-dir EAL parameter to configure directory where traces will be generated. Signed-off-by: Sunil Kumar Kori --- doc/guides/linux_gsg/eal_args.include.rst | 11 lib/librte_eal/common/eal_common_options.c| 15 ++ .../common/eal_c

[dpdk-dev] [PATCH v4 19/33] eal/trace: add memory tracepoints

2020-04-03 Thread jerinj
From: Jerin Jacob Add the following memory-related tracepoints. rte_trace_lib_eal_mem_zmalloc; rte_trace_lib_eal_mem_malloc; rte_trace_lib_eal_mem_realloc; rte_trace_lib_eal_mem_free; rte_malloc() and rte_free() has been used in the trace implementation, in order to avoid tracing implementation

[dpdk-dev] [PATCH v4 22/33] eal/trace: add interrupt tracepoints

2020-04-03 Thread jerinj
From: Jerin Jacob Add the following interrupt related tracepoints. rte_trace_lib_eal_intr_callback_register; rte_trace_lib_eal_intr_callback_unregister; rte_trace_lib_eal_intr_enable; rte_trace_lib_eal_intr_disable; Signed-off-by: Jerin Jacob --- .../common/eal_common_trace_points.c

[dpdk-dev] [PATCH v4 23/33] eal/trace: add trace level configuration parameter

2020-04-03 Thread jerinj
From: Sunil Kumar Kori Trace library exposes --trace-level EAL parameter to configure global and trace point specific level. Signed-off-by: Sunil Kumar Kori --- doc/guides/linux_gsg/eal_args.include.rst | 19 lib/librte_eal/common/eal_common_options.c| 19 +++- lib/librte_eal/co

[dpdk-dev] [PATCH v4 20/33] eal/trace: add memzone tracepoints

2020-04-03 Thread jerinj
From: Jerin Jacob Add the following memzone related tracepoints. rte_trace_lib_eal_memzone_reserve rte_trace_lib_eal_memzone_lookup rte_trace_lib_eal_memzone_free Signed-off-by: Jerin Jacob --- lib/librte_eal/common/eal_common_memzone.c| 9 +++ .../common/eal_common_trace_points.c

[dpdk-dev] [PATCH v4 21/33] eal/trace: add thread tracepoints

2020-04-03 Thread jerinj
From: Jerin Jacob Add the following thread related tracepoints. rte_trace_lib_eal_thread_remote_launch; rte_trace_lib_eal_thread_lcore_ready; Signed-off-by: Jerin Jacob --- lib/librte_eal/common/eal_common_trace_points.c | 9 + lib/librte_eal/freebsd/eal_interrupts.c | 2 +-

[dpdk-dev] [PATCH v4 16/33] eal/trace: hook internal trace APIs to FreeBSD

2020-04-03 Thread jerinj
From: Jerin Jacob Connect the internal trace interface API to FreeBSD EAL. Signed-off-by: Jerin Jacob --- lib/librte_eal/freebsd/eal.c| 10 ++ lib/librte_eal/freebsd/eal_thread.c | 3 +++ 2 files changed, 13 insertions(+) diff --git a/lib/librte_eal/freebsd/eal.c b/lib/librte

[dpdk-dev] [PATCH v4 14/33] eal/trace: implement provider payload

2020-04-03 Thread jerinj
From: Jerin Jacob The trace function payloads such as rte_trace_ctf_* have dual functions. The first to emit the payload for the registration function and the second one to act as trace mem emitters aka provider payload. When it used as provider payload, those function copy the trace field to tr

[dpdk-dev] [PATCH v4 17/33] eal/trace: add generic tracepoints

2020-04-03 Thread jerinj
From: Jerin Jacob This patch creates the following generic tracepoint for generic tracing when there is no dedicated tracepoint is available. rte_trace_lib_eal_generic_void() rte_trace_lib_eal_generic_u64() rte_trace_lib_eal_generic_u32() rte_trace_lib_eal_generic_u16() rte_trace_lib_eal_generic

[dpdk-dev] [PATCH v4 15/33] eal/trace: hook internal trace APIs to Linux

2020-04-03 Thread jerinj
From: Jerin Jacob Connect the internal trace interface API to Linux EAL. Signed-off-by: Jerin Jacob --- lib/librte_eal/common/eal_common_thread.c | 3 ++- lib/librte_eal/linux/eal.c| 9 + lib/librte_eal/linux/eal_thread.c | 3 +++ 3 files changed, 14 insertions(

[dpdk-dev] [PATCH v4 18/33] eal/trace: add alarm tracepoints

2020-04-03 Thread jerinj
From: Jerin Jacob Add following alarm related trace points. rte_trace_lib_eal_alarm_set() rte_trace_lib_eal_alarm_cancel() Signed-off-by: Jerin Jacob --- .../common/eal_common_trace_points.c | 9 + lib/librte_eal/freebsd/eal_alarm.c | 3 +++ lib/librte_eal/incl

[dpdk-dev] [PATCH v4 13/33] eal/trace: implement registration payload

2020-04-03 Thread jerinj
From: Jerin Jacob The trace function payloads such as rte_trace_ctf_* have dual functions. The first to emit the payload for the registration function and the second one to act as trace memory emitters. When it used as registration payload, it will do the following to fulfill the registration jo

[dpdk-dev] [PATCH v4 12/33] eal/trace: implement trace save

2020-04-03 Thread jerinj
From: Jerin Jacob Implement rte_trace_save(), which will save the metadata file and trace memory snapshot to the trace directory. Signed-off-by: Jerin Jacob --- .../common/eal_common_trace_utils.c | 80 +++ lib/librte_eal/rte_eal_version.map| 1 + 2 files

[dpdk-dev] [PATCH v4 11/33] eal/trace: implement debug dump function

2020-04-03 Thread jerinj
From: Jerin Jacob Implement rte_trace_metadata_dump() and rte_trace_dump() functions. Former one used to dump the CTF metadata file and the latter one to dump all the registered events and its status. Signed-off-by: Jerin Jacob Signed-off-by: Sunil Kumar Kori --- lib/librte_eal/common/eal_com

[dpdk-dev] [PATCH v4 09/33] eal/trace: handle CTF keyword collision

2020-04-03 Thread jerinj
From: Sunil Kumar Kori Some of the keyword like align, event, "." and "->" etc will be used in CTF metadata syntax. This patch support for handling those keywords with DPDK events name. Signed-off-by: Sunil Kumar Kori --- lib/librte_eal/common/eal_common_trace_ctf.c | 119 +++

[dpdk-dev] [PATCH v4 10/33] eal/trace: implement trace memory allocation

2020-04-03 Thread jerinj
From: Jerin Jacob Trace memory will be allocated per thread to enable lockless trace events updates to the memory. The allocator will first attempt to allocate from hugepage, if not available from hugepage then fallback to malloc memory. Later in the patches series, This API will be hooked to DP

[dpdk-dev] [PATCH v4 08/33] eal/trace: create CTF TDSL metadata in memory

2020-04-03 Thread jerinj
From: Jerin Jacob Common trace format(CTF) defines the metadata[1][2] for trace events, This patch creates the metadata for the DPDK events in memory and latter this will be saved to trace directory on rte_trace_save() invocation. [1] https://diamon.org/ctf/#specification [2] https://diamon.org/

[dpdk-dev] [PATCH v4 07/33] eal/trace: get bootup timestamp for trace

2020-04-03 Thread jerinj
From: Jerin Jacob Find epoch_sec, epoch_nsec and uptime_ticks time information on eal_trace_init()/bootup to derive the time in the trace. Signed-off-by: Jerin Jacob --- lib/librte_eal/common/eal_common_trace.c | 3 +++ .../common/eal_common_trace_utils.c | 22 +

[dpdk-dev] [PATCH v4 06/33] eal/trace: add internal trace init and fini interface

2020-04-03 Thread jerinj
From: Jerin Jacob Define eal_trace_init() and eal_trace_fini() EAL interface functions that rte_eal_init() and rte_eal_cleanup() function can be use to initialize and finalize the trace subsystem. eal_trace_init() function will add the following functionality if trace is enabled through EAL comma

[dpdk-dev] [PATCH v4 05/33] eal/trace: implement trace operation APIs

2020-04-03 Thread jerinj
From: Jerin Jacob This patch implements the following public trace APIs. - rte_trace_global_is_enabled() - rte_trace_global_is_disabled() - rte_trace_is_id_invalid() - rte_trace_global_level_set() - rte_trace_global_level_get() - rte_trace_global_mode_set() - rte_trace_global_mode_get() - rte_tr

[dpdk-dev] [PATCH v4 01/33] meson: add libatomic as a global dependency for i686 clang

2020-04-03 Thread jerinj
From: Pavan Nikhilesh Add libatomic as a global dependency when compiling for 32-bit using clang. As we need libatomic for 64-bit atomic ops. Cc: bruce.richard...@intel.com Signed-off-by: Pavan Nikhilesh Acked-by: Bruce Richardson --- config/meson.build | 8 drivers

[dpdk-dev] [PATCH v4 03/33] eal/trace: define the public API for trace support

2020-04-03 Thread jerinj
From: Jerin Jacob Define the public API for trace support. This patch also adds support for the build infrastructure and update the MAINTAINERS file for the trace subsystem. Signed-off-by: Jerin Jacob Signed-off-by: Sunil Kumar Kori --- MAINTAINERS | 6 + confi

[dpdk-dev] [PATCH v4 02/33] eal: introduce API for getting thread name

2020-04-03 Thread jerinj
From: Jerin Jacob Introduce rte_thread_getname() API to get the thread name and implement it for Linux and FreeBSD. FreeBSD does not support getting the thread name. One of the consumers of this API will be the trace subsystem where it used as an informative purpose. Signed-off-by: Jerin Jacob

[dpdk-dev] [PATCH v4 04/33] eal/trace: implement trace register API

2020-04-03 Thread jerinj
From: Jerin Jacob The consumers of trace API defines the tracepoint and registers to eal. Internally these tracepoints will be stored in STAILQ for future use. This patch implements the tracepoint registration function. Signed-off-by: Jerin Jacob --- MAINTAINERS

[dpdk-dev] [PATCH v4 00/33] DPDK Trace support

2020-04-03 Thread jerinj
From: Jerin Jacob v4: ~~ This patch depends on http://patches.dpdk.org/patch/67758/ Depends-on:series-9191 1) Rebased to master. 2) Adapted to latest EAL directory structure change. 3) Fix possible build issue with out of tree application wherein it does not define -DALLOW_EXPERIMENTAL_API.

Re: [dpdk-dev] [PATCH] ci: fix telemetry dependency in Travis

2020-04-03 Thread Ruifeng Wang
> -Original Message- > From: dev On Behalf Of > juraj.lin...@pantheon.tech > Sent: Friday, April 3, 2020 8:46 PM > To: acon...@redhat.com; maicolgabr...@hotmail.com > Cc: dev@dpdk.org; juraj.linkes > Subject: [dpdk-dev] [PATCH] ci: fix telemetry dependency in Travis > > From: "juraj.lin

Re: [dpdk-dev] [PATCH 1/2] bitmap: add create bitmap with all bits set

2020-04-03 Thread Andrzej Ostruszka
Hello Suanming Please find my comments below. However please note that so far I have never used DPDK bitmaps so I might not be the best person to comment - this patch needs some attention so I spent some time on it. Overall I'm fine with the changes however since this is a performance enhancemen

Re: [dpdk-dev] [PATCH] ci: fix telemetry dependency in Travis

2020-04-03 Thread Aaron Conole
juraj.lin...@pantheon.tech writes: > From: "juraj.linkes" > > libjansson4 is not enough to build telemetry. Replace it with > libjansson-dev. > > Signed-off-by: Juraj Linkeš > --- I see that earlier builds would print: = Content Skipped = libs:

[dpdk-dev] [PATCH v3] build: enable allow experimental API flag globally

2020-04-03 Thread pbhagavatula
From: Pavan Nikhilesh Remove setting ALLOW_EXPERIMENTAL_API individually for each Makefile and meson.build in app, lib and drivers instead enable ALLOW_EXPERIMENTAL_API flag globally. This changes reduces the clutter across the project while still maintaining the functionality of ALLOW_EXPERIMENT

Re: [dpdk-dev] [PATCH] [v1 1/1] net/octeontx2: add routines to set/clear interrupt enable registers

2020-04-03 Thread Andrzej Ostruszka [C]
On 4/3/20 4:20 AM, vattun...@marvell.com wrote: > From: Vamsi Attunuru > > Patch adds routines to set/clear nix lf error & ras interrupt enable > registers. These nix lf error interrupts get triggered if there are > any failures during nix lf configuration. This interrupts are enabled > before an

Re: [dpdk-dev] [PATCH v1] app/testpmd: add memory dump command

2020-04-03 Thread Ferruh Yigit
On 4/3/2020 7:53 AM, Xueming Li wrote: > Introduce new command to dump memory statistics of each socket, > summary, also show changes since last call. > > Usage: > dump_socket > > Signed-off-by: Xueming Li > --- > app/test-pmd/cmdline.c | 52 > +

Re: [dpdk-dev] [PATCH v2] net/axgbe: vlan support enabling in axgbe

2020-04-03 Thread Ferruh Yigit
On 4/3/2020 7:20 AM, ssar...@amd.com wrote: > From: Sardar Shamsher Singh > > adding below APIs for axgbe > - axgbe_enable_rx_vlan_stripping: to enable vlan header stipping > - axgbe_disable_rx_vlan_stripping: to disable vlan header stipping > - axgbe_enable_rx_vlan_filtering: to enable vlan filt

Re: [dpdk-dev] [PATCH] [v1 1/1] examples/l2fwd: add cmdline option for forwarding port info

2020-04-03 Thread Andrzej Ostruszka [C]
On 4/3/20 5:30 AM, vattun...@marvell.com wrote: > From: Vamsi Attunuru > > Current l2fwd application configures adjacent ports as destination > ports for forwarding the traffic which is a kind of static mapping > that can not be altered by the command line options. > > Patch adds a config option

[dpdk-dev] [PATCH] ci: fix telemetry dependency in Travis

2020-04-03 Thread juraj . linkes
From: "juraj.linkes" libjansson4 is not enough to build telemetry. Replace it with libjansson-dev. Signed-off-by: Juraj Linkeš --- .travis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index fd4f79cfc..2d2292ff6 100644 --- a/.travis.yml +++ b

Re: [dpdk-dev] [PATCH v2 29/29] net/ena: update version of the driver to v2.1.0

2020-04-03 Thread Michał Krawczyk
czw., 2 kwi 2020 o 17:53 Ferruh Yigit napisał(a): > > On 4/1/2020 3:21 PM, Michal Krawczyk wrote: > > The v2.1.0 is refactoring Tx and Rx paths, including few bug fixes and > > is also adding a new features which are going to be available with the > > newest hardware: > > * Accelerated LLQ mode >

Re: [dpdk-dev] [PATCH v2 28/29] net/ena: update copyright date

2020-04-03 Thread Michał Krawczyk
czw., 2 kwi 2020 o 17:51 Ferruh Yigit napisał(a): > > On 4/1/2020 3:21 PM, Michal Krawczyk wrote: > > The v2.1.0 making changes in the ena_ethdev files were done this year, > > so the copyright notice should be updated. > > > > Signed-off-by: Michal Krawczyk > > Reviewed-by: Igor Chauskin > > Re

Re: [dpdk-dev] [PATCH v2 19/29] net/ena: add Tx drops statistic

2020-04-03 Thread Michał Krawczyk
czw., 2 kwi 2020 o 15:05 Ferruh Yigit napisał(a): > > On 4/1/2020 3:21 PM, Michal Krawczyk wrote: > > ENA device can report in the AENQ handler amount of Tx packets that were > > dropped and not sent. > > > > This statistic is showing global value for the device and because > > rte_eth_stats is mi

Re: [dpdk-dev] [PATCH v2 04/14] net/igc: support reception and transmission of packets

2020-04-03 Thread Ferruh Yigit
On 3/20/2020 2:46 AM, alvinx.zh...@intel.com wrote: > From: Alvin Zhang > > Below ops are added too: > mac_addr_add > mac_addr_remove > mac_addr_set > set_mc_addr_list > mtu_set > promiscuous_enable > promiscuous_disable > allmulticast_enable > allmulticast_disable > rx_queue_setup > rx_queue_rel

Re: [dpdk-dev] [PATCH v2 14/14] net/igc: implement flow API

2020-04-03 Thread Ferruh Yigit
On 3/20/2020 2:46 AM, alvinx.zh...@intel.com wrote: > From: Alvin Zhang > > Below type of flows are supported: > ether-type filter, > 2-tuple filter, > SYN filter, > RSS > > Signed-off-by: Alvin Zhang <...> > @@ -852,6 +854,11 @@ > case RTE_ETH_FILTER_HASH: > ret = igc_has

Re: [dpdk-dev] [PATCH v2 10/14] net/igc: implement ether-type filter

2020-04-03 Thread Ferruh Yigit
On 3/20/2020 2:46 AM, alvinx.zh...@intel.com wrote: > From: Alvin Zhang > > Update feature list too. > > Signed-off-by: Alvin Zhang > --- > doc/guides/nics/features/igc.ini | 1 + > drivers/net/igc/Makefile | 1 + > drivers/net/igc/igc_ethdev.c | 5 + > drivers/net/igc/igc_et

Re: [dpdk-dev] [PATCH v2 05/14] net/igc: implement status API

2020-04-03 Thread Ferruh Yigit
On 3/20/2020 2:46 AM, alvinx.zh...@intel.com wrote: > From: Alvin Zhang > > Implement base status, extend status and per queue status API. Status API? This patch enables statistics, right? > > Below ops are added: > stats_get > xstats_get > xstats_get_by_id > xstats_get_names_by_id > xstats_ge

Re: [dpdk-dev] [PATCH v2 03/14] net/igc: implement device base ops

2020-04-03 Thread Ferruh Yigit
On 3/20/2020 2:46 AM, alvinx.zh...@intel.com wrote: > From: Alvin Zhang > > Bellow ops are implemented: > dev_configure > dev_start > dev_stop > dev_close > dev_reset > dev_set_link_up > dev_set_link_down > link_update > fw_version_get > dev_led_on > dev_led_off > > Signed-off-by: Alvin Zhang >

Re: [dpdk-dev] [PATCH v2 02/14] net/igc: support device initialization

2020-04-03 Thread Ferruh Yigit
On 3/20/2020 2:46 AM, alvinx.zh...@intel.com wrote: > From: Alvin Zhang > > Update base share codes, add readme. > Add OS specific functions and definitions. > Add device initialization codes. > > Signed-off-by: Alvin Zhang <...> > # > +# Add extra flags for base driver files (also known as

Re: [dpdk-dev] [PATCH v2 01/14] net/igc: add igc PMD

2020-04-03 Thread Ferruh Yigit
On 3/20/2020 2:46 AM, alvinx.zh...@intel.com wrote: > From: Alvin Zhang > > Implement device detection and loading. > Add igc driver guid docs. > > Signed-off-by: Alvin Zhang > > v2: Update release note. Modify codes according to comments <...> > @@ -0,0 +1,39 @@ > +.. SPDX-License-Identifi

Re: [dpdk-dev] [PATCH v2 17/29] net/ena: add support for large LLQ headers

2020-04-03 Thread Michał Krawczyk
czw., 2 kwi 2020 o 15:02 Ferruh Yigit napisał(a): > > On 4/1/2020 3:21 PM, Michal Krawczyk wrote: > > If the device supports larger LLQ (Low Latency Queue) headers, the user > > can activate them by enabling CONFIG_RTE_LIBRTE_ENA_LARGE_LLQ_HEADERS > > flag in the configuration file. > > > > If the

  1   2   >