[dpdk-dev] [PATCH] net/ice: support mark only action for FDIR

2020-04-01 Thread Simei Su
This patch fixes issue that doesn't support mark only case. Mark only action is equal to mark + passthru action. Fixes: f5cafa961fae ("net/ice: add flow director create and destroy") Cc: sta...@dpdk.org Signed-off-by: Simei Su --- drivers/net/ice/ice_fdir_filter.c | 13 - 1 file cha

[dpdk-dev] [PATCH v6] net/i40e: enable MAC address as FDIR input set

2020-04-01 Thread Lunyuan Cui
FVL enable source MAC address and destination MAC address as FDIR's input set for ipv4-other, ipv4-udp and ipv4-tcp. When OVS-DPDK is working as a pure L2 switch, enable MAC address as FDIR input set with Mark+RSS action would help the performance speed up. And FVL FDIR supports to change input set

Re: [dpdk-dev] [PATCH v2 2/2] vhost: cache gpa to hpa translation

2020-04-01 Thread Liu, Yong
> -Original Message- > From: Gavin Hu > Sent: Thursday, April 2, 2020 11:05 AM > To: Liu, Yong ; maxime.coque...@redhat.com; Ye, > Xiaolong ; Wang, Zhihong > > Cc: dev@dpdk.org; nd ; nd > Subject: RE: [dpdk-dev] [PATCH v2 2/2] vhost: cache gpa to hpa translation > > Hi Marvin, > > >

Re: [dpdk-dev] [PATCH v2 2/2] vhost: cache gpa to hpa translation

2020-04-01 Thread Gavin Hu
Hi Marvin, > -Original Message- > From: Liu, Yong > Sent: Wednesday, April 1, 2020 9:01 PM > To: Gavin Hu ; maxime.coque...@redhat.com; Ye, > Xiaolong ; Wang, Zhihong > > Cc: dev@dpdk.org; nd > Subject: RE: [dpdk-dev] [PATCH v2 2/2] vhost: cache gpa to hpa translation > > > > > -

Re: [dpdk-dev] [PATCH v2 2/2] vhost: cache gpa to hpa translation

2020-04-01 Thread Ye Xiaolong
On 04/01, Marvin Liu wrote: >If Tx zero copy enabled, gpa to hpa mapping table is updated one by >one. This will harm performance when guest memory backend using 2M >hugepages. Now add cached mapping table which will sorted by using >sequence. Address translation will first check cached mapping tab

Re: [dpdk-dev] [PATCH v2 1/2] vhost: utilize dpdk dynamic memory allocator

2020-04-01 Thread Ye Xiaolong
On 04/01, Marvin Liu wrote: >Replace dynamic memory allocator with dpdk memory allocator. > >Signed-off-by: Marvin Liu > >diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c >index bd1be0104..79fcb9d19 100644 >--- a/lib/librte_vhost/vhost_user.c >+++ b/lib/librte_vhost/vhost

[dpdk-dev] [PATCH v5] net/i40e: enable MAC address as FDIR input set

2020-04-01 Thread Lunyuan Cui
FVL enable src MAC address and dst MAC address as FDIR's input set for ipv4-other, ipv4-udp and ipv4-tcp. When OVS-DPDK is working as a pure L2 switch, enable MAC address as FDIR input set with Mark+RSS action would help the performance speed up. And FVL FDIR supports to change input set with MAC a

[dpdk-dev] [PATCH v2 1/2] virtio: one way barrier for split vring used idx

2020-04-01 Thread Joyce Kong
In case VIRTIO_F_ORDER_PLATFORM(36) is not negotiated, then the frontend and backend are assumed to be implemented in software, that is they can run on identical CPUs in an SMP configuration. Thus a weak form of memory barriers like rte_smp_r/wmb, other than rte_cio_r/wmb, is sufficient for this ca

[dpdk-dev] [PATCH v2 2/2] virtio: one way barrier for split vring avail idx

2020-04-01 Thread Joyce Kong
In case VIRTIO_F_ORDER_PLATFORM(36) is not negotiated, then the frontend and backend are assumed to be implemented in software, that is they can run on identical CPUs in an SMP configuration. Thus a weak form of memory barriers like rte_smp_r/wmb, other than rte_cio_r/wmb, is sufficient for this ca

[dpdk-dev] [PATCH v2 0/2] one way barrier for split vring idx

2020-04-01 Thread Joyce Kong
This patch set replaces the two-way barriers with C11 one-way barriers for split vring idx, when the frontend and backend are implemented in software. By doing PVP benchmarking, the test result showed the throughput increased 20% with the 0.001% of acceptable loss rate on Thunderx2 platform.[1] B

Re: [dpdk-dev] [PATCH v4] net/ice: fix RSS advanced rule invalid issue

2020-04-01 Thread He, Zhiwei
The [PATCH v4] net/ice: fix RSS advanced rule invalid issue patch test -by Zhiwei.he -Original Message- From: dev On Behalf Of Junyu Jiang Sent: Wednesday, April 1, 2020 4:27 PM To: dev@dpdk.org Cc: Zhang, Qi Z ; Yang, Qiming ; Jiang, JunyuX ; sta...@dpdk.org Subject: [dpdk-dev] [PATCH

Re: [dpdk-dev] [PATCH 2/2] test/malloc: add bad parameter tests for realloc

2020-04-01 Thread David Christensen
On 4/1/20 6:11 AM, Anatoly Burakov wrote: Realloc did not have bad parameter autotest. Add them. Signed-off-by: Anatoly Burakov --- Reviewed-by: David Christensen

Re: [dpdk-dev] [PATCH 1/2] test/malloc: run realloc tests on external heap

2020-04-01 Thread David Christensen
On 4/1/20 6:11 AM, Anatoly Burakov wrote: Due to the fact that the rte_realloc() test depends on the layout of underlying memory, it can sometimes fail due to fragmentation of the memory. To address this, make it so that the realloc autotests are run using a newly created external memory heap

Re: [dpdk-dev] [PATCH v4] net/i40e: enable MAC address as FDIR input set

2020-04-01 Thread Xing, Beilei
> -Original Message- > From: Cui, LunyuanX > Sent: Wednesday, April 1, 2020 3:51 PM > To: dev@dpdk.org > Cc: Xing, Beilei ; Yang, Qiming > ; Wu, Jingjing ; Cui, > LunyuanX > Subject: [PATCH v4] net/i40e: enable MAC address as FDIR input set > > FVL enable src MAC address and dst MAC a

Re: [dpdk-dev] Garbage value is returned while reading moudle eeprom for i40e (PF) with DPDK 18.11

2020-04-01 Thread Xing, Beilei
Hi Anubhav, Thanks for the fix. Could you please submit the fix patch? thanks. BR, Beilei From: Anubhav Choudhary Sent: Wednesday, April 1, 2020 3:13 PM To: Xing, Beilei ; dev@dpdk.org; us...@dpdk.org Subject: RE: Garbage value is returned while reading moudle eeprom for i40e (PF) with DPDK 18

Re: [dpdk-dev] [PATCH] net/dpdkoin: add new driver

2020-04-01 Thread Stephen Hemminger
On Wed, 1 Apr 2020 21:51:53 +0100 Kevin Traynor wrote: > On 01/04/2020 14:10, Matteo Croce wrote: > > DPDK polls the packet in a busy loop. This means that CPU constantly spins > > looking for packets, regardless of the network traffic. > > DPDK does this to reduce latency and avoid using interru

Re: [dpdk-dev] [PATCH v2 1/6] rte_ethdev: add function to check if device is owned

2020-04-01 Thread Stephen Hemminger
On Wed, 01 Apr 2020 23:42:44 +0200 Thomas Monjalon wrote: > 16/03/2020 17:09, Stephen Hemminger: > > This is a simple helper function to check if device is owned > > (being used as a sub-device). > > I would suggest not restricting ownership to sub-device case. > > > It is more convienent tha

Re: [dpdk-dev] [PATCH v2 1/6] rte_ethdev: add function to check if device is owned

2020-04-01 Thread Thomas Monjalon
16/03/2020 17:09, Stephen Hemminger: > This is a simple helper function to check if device is owned > (being used as a sub-device). I would suggest not restricting ownership to sub-device case. > It is more convienent than having > applications call rte_eth_dev_owner_get and check the result. Ye

Re: [dpdk-dev] [PATCH] raw/common: introduce the Multi-function API

2020-04-01 Thread Thomas Monjalon
Hi, 16/03/2020 20:21, Mairtin o Loingsigh: > Multi-function API allows user to chain xforms of various > types together in a single operation Please could you elaborate a bit more? Which problem are you trying to address? What is the design? How it can be used? For such feature proposal, I recom

Re: [dpdk-dev] [PATCH] net/dpdkoin: add new driver

2020-04-01 Thread Kevin Traynor
On 01/04/2020 14:10, Matteo Croce wrote: > DPDK polls the packet in a busy loop. This means that CPU constantly spins > looking for packets, regardless of the network traffic. > DPDK does this to reduce latency and avoid using interrupts, at expense of > efficiency: this might consume more processi

Re: [dpdk-dev] [PATCH 1/4] lib: introduce IF Proxy library

2020-04-01 Thread Andrzej Ostruszka [C]
First of all thank you Vipin for taking a look at this. On 4/1/20 7:29 AM, Varghese, Vipin wrote: > snipped >> diff --git a/lib/librte_if_proxy/Makefile b/lib/librte_if_proxy/Makefile >> new file mode 100644 >> index 0..43cb702a2 >> --- /dev/null >> +++ b/lib/librte_if_proxy/Makefile >> @@

Re: [dpdk-dev] [PATCH v3 00/33] DPDK Trace support

2020-04-01 Thread Jerin Jacob
On Thu, Apr 2, 2020 at 1:13 AM Thomas Monjalon wrote: > > 01/04/2020 21:14, Jerin Jacob: > > On Wed, Apr 1, 2020 at 11:22 PM Jerin Jacob wrote: > > > > > > On Wed, Apr 1, 2020 at 11:02 PM David Marchand > > > wrote: > > > > > > > > On Wed, Apr 1, 2020 at 6:25 PM Jerin Jacob > > > > wrote: > >

Re: [dpdk-dev] [PATCH v2] ethdev: fix for compiler warning when vtune profiling option is enabled

2020-04-01 Thread Alexander Kozyrev
Hi Eugeny, > -Original Message- > From: dev On Behalf Of > eugeny.parshu...@linux.intel.com > Sent: Wednesday, April 1, 2020 8:26 > To: Thomas Monjalon ; ferruh.yi...@intel.com; > john.mcnam...@intel.com > Cc: dev@dpdk.org; eugeny.parshu...@linux.intel.com; > roman.p.kha...@intel.com > S

Re: [dpdk-dev] [PATCH v3 00/33] DPDK Trace support

2020-04-01 Thread Thomas Monjalon
01/04/2020 21:14, Jerin Jacob: > On Wed, Apr 1, 2020 at 11:22 PM Jerin Jacob wrote: > > > > On Wed, Apr 1, 2020 at 11:02 PM David Marchand > > wrote: > > > > > > On Wed, Apr 1, 2020 at 6:25 PM Jerin Jacob wrote: > > > > On Wed, Apr 1, 2020 at 7:42 PM David Marchand > > > > wrote: > > > > > On

Re: [dpdk-dev] [PATCH v3 00/33] DPDK Trace support

2020-04-01 Thread Jerin Jacob
On Wed, Apr 1, 2020 at 11:22 PM Jerin Jacob wrote: > > On Wed, Apr 1, 2020 at 11:02 PM David Marchand > wrote: > > > > On Wed, Apr 1, 2020 at 6:25 PM Jerin Jacob wrote: > > > On Wed, Apr 1, 2020 at 7:42 PM David Marchand > > > wrote: > > > > On Wed, Apr 1, 2020 at 12:05 PM Jerin Jacob > > >

Re: [dpdk-dev] [PATCH 2/6] fib: make lookup function type configurable

2020-04-01 Thread Medvedkin, Vladimir
Hi Ray, -Original Message- From: Ray Kinsella Sent: Wednesday, April 1, 2020 6:48 AM To: Medvedkin, Vladimir ; dev@dpdk.org Cc: Ananyev, Konstantin ; Richardson, Bruce Subject: Re: [dpdk-dev] [PATCH 2/6] fib: make lookup function type configurable Hi Vladimir, On 09/03/2020 12:43, V

Re: [dpdk-dev] [PATCH] net/dpdkoin: add new driver

2020-04-01 Thread Aaron Conole
Matteo Croce writes: > DPDK polls the packet in a busy loop. This means that CPU constantly spins > looking for packets, regardless of the network traffic. > DPDK does this to reduce latency and avoid using interrupts, at expense of > efficiency: this might consume more processing power and gener

[dpdk-dev] [PATCH v3 3/4] ip_frag: ipv6 fragments must not be resubmitted to fragmentation

2020-04-01 Thread Aaron Conole
IPv6 only allows traffic source nodes to fragment, so submitting a packet with next header of IPPROTO_FRAGMENT would be invalid. Signed-off-by: Aaron Conole --- lib/librte_ip_frag/rte_ipv6_fragmentation.c | 4 1 file changed, 4 insertions(+) diff --git a/lib/librte_ip_frag/rte_ipv6_fragmen

[dpdk-dev] [PATCH v3 0/4] ip_frag: add a unit test for fragmentation

2020-04-01 Thread Aaron Conole
This adds a simple unit test for the ip fragmentation library and covers fragmenting ipv4 and ipv6. Additionally, some fixes are introduced, which are really just sanity rather than real issues in the field. v2->v3: - Remove c99-ism from 4/4 v1->v2: - Fix patch 4/4 which had a missing assignment

[dpdk-dev] [PATCH v3 4/4] ipfrag: add unit test case

2020-04-01 Thread Aaron Conole
Initial IP fragmentation unit test. Signed-off-by: Aaron Conole --- MAINTAINERS| 1 + app/test/meson.build | 2 + app/test/test_ipfrag.c | 277 + 3 files changed, 280 insertions(+) create mode 100644 app/test/test_ipfrag.c diff --git a/

[dpdk-dev] [PATCH v3 1/4] ip_frag: ensure minimum v4 fragmentation length

2020-04-01 Thread Aaron Conole
The IPv4 specification says that each fragment must at least the size of an IP header plus 8 octets. When attempting to run ipfrag using a smaller size, the fragment library will return successful completion, even though it is a violation of RFC791 (and updates). Signed-off-by: Aaron Conole ---

[dpdk-dev] [PATCH v3 2/4] ip_frag: ensure minimum v6 fragmentation length

2020-04-01 Thread Aaron Conole
Similar to v4, we should ensure that at least a minimum fragmentation length can be achieved. Signed-off-by: Aaron Conole --- lib/librte_ip_frag/rte_ipv6_fragmentation.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/lib/librte_ip_frag/rte_ipv6_fragmentation.c b/lib/librte_ip_

[dpdk-dev] [Bug 432] Entering Non-numeric value for Setup hugepage mappings, dpdk-setup.sh still goes to create_mnt_huge function and prints misleading info

2020-04-01 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=432 Bug ID: 432 Summary: Entering Non-numeric value for Setup hugepage mappings, dpdk-setup.sh still goes to create_mnt_huge function and prints misleading info Product: DPDK

Re: [dpdk-dev] [PATCH 0/3] add new Double Word Key hash table

2020-04-01 Thread Medvedkin, Vladimir
Hi Honnappa, -Original Message- From: Honnappa Nagarahalli Sent: Tuesday, March 31, 2020 10:17 PM To: tho...@monjalon.net; Medvedkin, Vladimir Cc: Wang, Yipeng1 ; Stephen Hemminger ; dev@dpdk.org; Morten Brørup ; dev@dpdk.org; Ananyev, Konstantin ; Gobriel, Sameh ; Richardson, Bruce

Re: [dpdk-dev] [PATCH 0/3] add new Double Word Key hash table

2020-04-01 Thread Medvedkin, Vladimir
Hi Thomas, -Original Message- From: Thomas Monjalon Sent: Tuesday, March 31, 2020 8:56 PM To: Medvedkin, Vladimir Cc: Wang, Yipeng1 ; Stephen Hemminger ; dev@dpdk.org; Morten Brørup ; dev@dpdk.org; Ananyev, Konstantin ; Gobriel, Sameh ; Richardson, Bruce ; Suanming Mou ; Olivier Ma

Re: [dpdk-dev] [PATCH v3 00/33] DPDK Trace support

2020-04-01 Thread Jerin Jacob
On Wed, Apr 1, 2020 at 11:02 PM David Marchand wrote: > > On Wed, Apr 1, 2020 at 6:25 PM Jerin Jacob wrote: > > On Wed, Apr 1, 2020 at 7:42 PM David Marchand > > wrote: > > > On Wed, Apr 1, 2020 at 12:05 PM Jerin Jacob wrote: > > > > I assume the patch content will be: > > > > 1) Removing expe

Re: [dpdk-dev] [PATCH 05/13] app/test: introduce librte_security tests

2020-04-01 Thread Thomas Monjalon
01/04/2020 19:09, Akhil Goyal: > Hi Lukasz, > > > This patch introduces set of unit tests of librte_security API functions. > > Tests are added to dpdk-test application and can be run with > > "security_autotest" runtime command. > > > > This is the first patch in the series of patches as adding

Re: [dpdk-dev] net/nfb: check rxmac array size

2020-04-01 Thread Ferruh Yigit
On 4/1/2020 7:38 AM, Jakub Neruda wrote: > From: Martin Spinler > > The driver wrongly assumed the presence of at least one rxmac in every > firmware and accessed to non-existing unit > > Signed-off-by: Martin Spinler > Acked-by: Jakub Neruda Applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH v3 00/33] DPDK Trace support

2020-04-01 Thread David Marchand
On Wed, Apr 1, 2020 at 6:25 PM Jerin Jacob wrote: > On Wed, Apr 1, 2020 at 7:42 PM David Marchand > wrote: > > On Wed, Apr 1, 2020 at 12:05 PM Jerin Jacob wrote: > > > I assume the patch content will be: > > > 1) Removing experimental API from app, lib, drivers, examples with > > > make and mes

Re: [dpdk-dev] [PATCH 05/13] app/test: introduce librte_security tests

2020-04-01 Thread Akhil Goyal
Hi Lukasz, > > This patch introduces set of unit tests of librte_security API functions. > Tests are added to dpdk-test application and can be run with > "security_autotest" runtime command. > > This is the first patch in the series of patches as adding all test cases > for all API functions in

Re: [dpdk-dev] [PATCH v3 00/33] DPDK Trace support

2020-04-01 Thread Jerin Jacob
On Wed, Apr 1, 2020 at 10:16 PM Bruce Richardson wrote: > > > > > > > > Since the trace changes in the "inline" functions of the specific > > > > library already > > > > disabled under _compile time_ RTE_ENABLE_TRACE_DP flag and > > > > it is using RTE_TRACE_POINT_DP() to define the trace unlike

Re: [dpdk-dev] [PATCH v3 33/33] doc: add trace library guide

2020-04-01 Thread Jerin Jacob
On Wed, Apr 1, 2020 at 8:27 PM Thomas Monjalon wrote: > > Hi, > > I did not review the code. > I want to understand the design first, I don't intend to write this as a low-level design document. I would suggest please look into API documentation in the first trace patch. http://patches.dpdk.org/p

Re: [dpdk-dev] [PATCH 00/12] update and simplify telemetry library.

2020-04-01 Thread Wiles, Keith
> On Mar 19, 2020, at 12:18 PM, Ciara Power wrote: > > This patchset extensively reworks the telemetry library adding new > functionality and simplifying much of the existing code, while > maintaining backward compatibility. > > This work is based on the previously sent RFC for a "process info

Re: [dpdk-dev] [PATCH v3 00/33] DPDK Trace support

2020-04-01 Thread Bruce Richardson
On Wed, Apr 01, 2020 at 09:55:20PM +0530, Jerin Jacob wrote: > On Wed, Apr 1, 2020 at 7:42 PM David Marchand > wrote: > > > > On Wed, Apr 1, 2020 at 12:05 PM Jerin Jacob wrote: > > > On Wed, Apr 1, 2020 at 1:49 PM David Marchand > > > wrote: > > > > - Regardless of the trace framework, the ALL

Re: [dpdk-dev] [PATCH v3 00/33] DPDK Trace support

2020-04-01 Thread Jerin Jacob
On Wed, Apr 1, 2020 at 7:42 PM David Marchand wrote: > > On Wed, Apr 1, 2020 at 12:05 PM Jerin Jacob wrote: > > On Wed, Apr 1, 2020 at 1:49 PM David Marchand > > wrote: > > > - Regardless of the trace framework, the ALLOW_EXPERIMENTAL_API flag > > > gates access to APIs so that external users a

Re: [dpdk-dev] [PATCH 00/12] update and simplify telemetry library.

2020-04-01 Thread Bruce Richardson
On Wed, Apr 01, 2020 at 05:42:21PM +0200, David Marchand wrote: > Hello, > > > On Thu, Mar 19, 2020 at 6:35 PM Ciara Power wrote: > > > > This patchset extensively reworks the telemetry library adding new > > functionality and simplifying much of the existing code, while > > maintaining backward

Re: [dpdk-dev] [PATCH v6] net/vmxnet3: Added mtu_set() function to allow setting MTU.

2020-04-01 Thread Ferruh Yigit
On 3/31/2020 6:31 PM, Yong Wang wrote: > > -Original Message- > From: Eduard Serra Miralles > Date: Wednesday, March 25, 2020 at 12:19 PM > To: "dev@dpdk.org" > Cc: Yong Wang > Subject: [PATCH v6] net/vmxnet3: Added mtu_set() function to allow setting > MTU. > > (Picked up from @C

Re: [dpdk-dev] [PATCH 00/12] update and simplify telemetry library.

2020-04-01 Thread David Marchand
Hello, On Thu, Mar 19, 2020 at 6:35 PM Ciara Power wrote: > > This patchset extensively reworks the telemetry library adding new > functionality and simplifying much of the existing code, while > maintaining backward compatibility. > > This work is based on the previously sent RFC for a "process

Re: [dpdk-dev] [PATCH 0/2] support CPU crypto for AESNI MB PMD

2020-04-01 Thread Ananyev, Konstantin
Hi Akhil, > > Hi Konstantin, > > It looks there are some failures in meson build. > Could you please fix them and send a v2? Will do. > > Thanks, > Akhil > > > -Original Message- > > From: Konstantin Ananyev > > Sent: Monday, March 16, 2020 6:51 PM > > To: dev@dpdk.org > > Cc: Akhil

Re: [dpdk-dev] [PATCH v3 33/33] doc: add trace library guide

2020-04-01 Thread Thomas Monjalon
Hi, I did not review the code. I want to understand the design first, and I start with the user documentation. John, Marko, who is going to review this new documentation? I think we need some help for syntax and phrasing here. Thanks > +Trace Library > += > + > +DPDK provides a trac

[dpdk-dev] [PATCH v2 27/29] doc: add notes on ENA usage on metal instances

2020-04-01 Thread Michal Krawczyk
As AWS metal instances are supporting IOMMU, the usage of igb_uio or vfio-pci can lead to a problems (when to use which module), especially that the vfio-pci isn't supporting SMMU on arm64. To clear up the problem of using those modules in various setup conditions (with or without IOMMU) on metal

[dpdk-dev] [PATCH v2 26/29] net/ena: reuse 0 length Rx descriptor

2020-04-01 Thread Michal Krawczyk
Some ENA devices can pass to the driver descriptor with length 0. To avoid extra allocation, the descriptor can be reused by simply putting it back to the device. Signed-off-by: Michal Krawczyk Reviewed-by: Igor Chauskin Reviewed-by: Guy Tzalik --- v2: * Compare rc (error code) to 0 value exp

[dpdk-dev] [PATCH v2 28/29] net/ena: update copyright date

2020-04-01 Thread Michal Krawczyk
The v2.1.0 making changes in the ena_ethdev files were done this year, so the copyright notice should be updated. Signed-off-by: Michal Krawczyk Reviewed-by: Igor Chauskin Reviewed-by: Guy Tzalik --- drivers/net/ena/base/ena_plat_dpdk.h | 2 +- drivers/net/ena/ena_ethdev.c | 2 +- driv

[dpdk-dev] [PATCH v2 29/29] net/ena: update version of the driver to v2.1.0

2020-04-01 Thread Michal Krawczyk
The v2.1.0 is refactoring Tx and Rx paths, including few bug fixes and is also adding a new features which are going to be available with the newest hardware: * Accelerated LLQ mode * Disabling meta descriptor caching is required for that * Handling Rx descriptor which length is 0 * Tx drops are

[dpdk-dev] [PATCH v2 20/29] net/ena: disable meta caching

2020-04-01 Thread Michal Krawczyk
In the LLQ mode, the device can indicate that meta data descriptor caching is disabled. In that case the driver should send valid meta descriptor on every Tx packet. Signed-off-by: Michal Krawczyk Reviewed-by: Igor Chauskin Reviewed-by: Guy Tzalik --- drivers/net/ena/ena_ethdev.c | 28

[dpdk-dev] [PATCH v2 17/29] net/ena: add support for large LLQ headers

2020-04-01 Thread Michal Krawczyk
If the device supports larger LLQ (Low Latency Queue) headers, the user can activate them by enabling CONFIG_RTE_LIBRTE_ENA_LARGE_LLQ_HEADERS flag in the configuration file. If the device isn't supporting this feature, the default value will be used. Signed-off-by: Michal Krawczyk Reviewed-by: I

[dpdk-dev] [PATCH v2 18/29] net/ena: remove memory barriers before doorbells

2020-04-01 Thread Michal Krawczyk
The doorbell code is already issuing the doorbell by using rte_write. Because of that, there is no need to do that before calling the function. Signed-off-by: Michal Krawczyk Reviewed-by: Igor Chauskin Reviewed-by: Guy Tzalik --- drivers/net/ena/ena_ethdev.c | 9 + 1 file changed, 1 in

[dpdk-dev] [PATCH v2 19/29] net/ena: add Tx drops statistic

2020-04-01 Thread Michal Krawczyk
ENA device can report in the AENQ handler amount of Tx packets that were dropped and not sent. This statistic is showing global value for the device and because rte_eth_stats is missing field that could indicate this value (it isn't the Tx error), it is being presented as a extended statistic. As

[dpdk-dev] [PATCH v2 16/29] net/ena: refactor getting IO queues capabilities

2020-04-01 Thread Michal Krawczyk
Reading values from the device is about the maximum capabilities of the device. Because of that, the names of the fields storing those values, functions and temporary variables, should be more descriptive in order to improve self documentation fo the code. In connection with this, the way of getti

[dpdk-dev] [PATCH v2 13/29] net/ena/base: fix indentation of multiple defines

2020-04-01 Thread Michal Krawczyk
As the alignemnt of the defines wasn't valid, it was removed at all, so instead of using multiple spaces or tabs, the single space after define name is being used. Signed-off-by: Michal Krawczyk Reviewed-by: Igor Chauskin Reviewed-by: Guy Tzalik --- drivers/net/ena/base/ena_com.h | 8

[dpdk-dev] [PATCH v2 11/29] net/ena/base: use 48-bit memory addresses in ena_com

2020-04-01 Thread Michal Krawczyk
ENA device is using 48-bit memory for IO. because of that, the upper limit had to be updated. Signed-off-by: Michal Krawczyk Reviewed-by: Igor Chauskin Reviewed-by: Guy Tzalik --- drivers/net/ena/base/ena_com.c | 2 +- drivers/net/ena/base/ena_defs/ena_common_defs.h | 6 +-

[dpdk-dev] [PATCH v2 14/29] net/ena/base: update gen date and commit

2020-04-01 Thread Michal Krawczyk
The current ena_com version was generated on 25.09.2019. Signed-off-by: Michal Krawczyk Reviewed-by: Igor Chauskin Reviewed-by: Guy Tzalik --- drivers/net/ena/base/ena_defs/ena_gen_info.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/ena/base/ena_defs/en

[dpdk-dev] [PATCH v2 12/29] net/ena/base: fix types for printing timestamps

2020-04-01 Thread Michal Krawczyk
Because ena_com is being used by multiple platforms which are using different C versions, PRIu64 cannot be used directly and must be defined in the platform file. Signed-off-by: Michal Krawczyk Reviewed-by: Igor Chauskin Reviewed-by: Guy Tzalik --- drivers/net/ena/base/ena_com.c | 2 +-

[dpdk-dev] [PATCH v2 15/29] net/ena: set IO ring size to the valid value

2020-04-01 Thread Michal Krawczyk
IO rings were configured with the maximum allowed size for the Tx/Rx rings. However, the application could decide to create smaller rings. This patch is using value stored in the ring instead of the value from the adapter which is indicating the maximum allowed value. Fixes: df238f84c0a2 ("net/en

[dpdk-dev] [PATCH v2 10/29] net/ena/base: add error logs when preparing Tx

2020-04-01 Thread Michal Krawczyk
To make the debugging easier, the error logs were added in the Tx path. Signed-off-by: Michal Krawczyk Reviewed-by: Igor Chauskin Reviewed-by: Guy Tzalik --- drivers/net/ena/base/ena_eth_com.c | 24 +++- 1 file changed, 19 insertions(+), 5 deletions(-) diff --git a/drivers

[dpdk-dev] [PATCH v2 09/29] net/ena/base: fix indentation in cq polling

2020-04-01 Thread Michal Krawczyk
The spaces instead of tabs were used for the indent. Signed-off-by: Michal Krawczyk Reviewed-by: Igor Chauskin Reviewed-by: Guy Tzalik --- drivers/net/ena/base/ena_com.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/ena/base/ena_com.c b/drivers/net/ena

[dpdk-dev] [PATCH v2 05/29] net/ena/base: rework interrupt moderation

2020-04-01 Thread Michal Krawczyk
This feature allows for adaptive interrupt moderation. It's not used by the DPDK PMD, but is a part of the newest HAL version. Signed-off-by: Michal Krawczyk Reviewed-by: Igor Chauskin Reviewed-by: Guy Tzalik --- drivers/net/ena/base/ena_com.c | 171 +-- drivers/n

[dpdk-dev] [PATCH v2 08/29] net/ena/base: fix documentation of the functions

2020-04-01 Thread Michal Krawczyk
The documentation format was aligned and few typos were fixed. Signed-off-by: Michal Krawczyk Reviewed-by: Igor Chauskin Reviewed-by: Guy Tzalik --- drivers/net/ena/base/ena_com.h | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/net/ena/bas

[dpdk-dev] [PATCH v2 07/29] net/ena/base: add accelerated LLQ mode

2020-04-01 Thread Michal Krawczyk
In order to use the accelerated LLQ, the driver must limit the Tx burst and be aware that the device has the meta caching disabled. In that situation, the meta descriptor must be valid on each Tx packet. Signed-off-by: Michal Krawczyk Reviewed-by: Igor Chauskin Reviewed-by: Guy Tzalik --- driv

[dpdk-dev] [PATCH v2 06/29] net/ena/base: remove extra properties strings

2020-04-01 Thread Michal Krawczyk
This buffer was never used by the ENA PMD. It could be used for debugging, but it's presence is redundant now. Signed-off-by: Michal Krawczyk Reviewed-by: Igor Chauskin Reviewed-by: Guy Tzalik --- drivers/net/ena/base/ena_com.c | 56 -- drivers/net/ena/base/ena_

[dpdk-dev] [PATCH v2 01/29] net/ena: check if size of buffer is at least 1400B

2020-04-01 Thread Michal Krawczyk
Some of the ENA devices can't handle buffers which are smaller than a 1400B. Because of this limitation, size of the buffer is being checked and limited during the Rx queue setup. If it's below the allowed value, PMD won't finish it's configuration successfully.. Signed-off-by: Michal Krawczyk R

[dpdk-dev] [PATCH v2 03/29] net/ena/base: prevent allocation of 0-sized memory

2020-04-01 Thread Michal Krawczyk
From: Igor Chauskin rte_memzone_reserve() will reserve the biggest contiguous memzone available if received 0 as size param. Fixes: 9ba7981ec992 ("ena: add communication layer for DPDK") Cc: sta...@dpdk.org Signed-off-by: Igor Chauskin Reviewed-by: Michal Krawczyk Reviewed-by: Guy Tzalik ---

[dpdk-dev] [PATCH v2 00/29] Update ENA driver to v2.1.0

2020-04-01 Thread Michal Krawczyk
Hi, This patchset is including severeal changes, including: * ena_com (HAL) update * Support for upcoming device features * Refactor of the IO path * Documentation update about ENA usage on metal instances v2: * Fix comments from review Igor Chauskin (2): net/ena/base: make allocation macros t

[dpdk-dev] [PATCH v2 04/29] net/ena/base: set default hash key

2020-04-01 Thread Michal Krawczyk
The RSS hash key was present in the device, but it wasn't exposed to the user. The other key still cannot be set, but now it can be accessed if one needs to do that. By default, the random hash key is used and it is generated only once when requested for the first time. Signed-off-by: Michal Kraw

[dpdk-dev] [PATCH v2 02/29] net/ena/base: make allocation macros thread-safe

2020-04-01 Thread Michal Krawczyk
From: Igor Chauskin Memory allocation region id could possibly be non-unique due to non-atomic increment, causing allocation failure. Fixes: 9ba7981ec992 ("ena: add communication layer for DPDK") Cc: sta...@dpdk.org Signed-off-by: Igor Chauskin Reviewed-by: Michal Krawczyk Reviewed-by: Guy Tz

Re: [dpdk-dev] [PATCH 1/2] drivers/qat: im buffer too small - split op

2020-04-01 Thread Akhil Goyal
Hi Fiona, Could you please review this patchset. > > This patch implements a special way of buffer handling when internal > QAT IM buffer is too small for Huffman dynamic compression operation. > Instead of falling back to fixed compression, the operation is now > split into multiple smaller dyna

Re: [dpdk-dev] [PATCH 0/2] support CPU crypto for AESNI MB PMD

2020-04-01 Thread Akhil Goyal
Hi Konstantin, It looks there are some failures in meson build. Could you please fix them and send a v2? Thanks, Akhil > -Original Message- > From: Konstantin Ananyev > Sent: Monday, March 16, 2020 6:51 PM > To: dev@dpdk.org > Cc: Akhil Goyal ; pablo.de.lara.gua...@intel.com; > declan.d

Re: [dpdk-dev] [PATCH v3 00/33] DPDK Trace support

2020-04-01 Thread Thomas Monjalon
01/04/2020 16:12, David Marchand: > On Wed, Apr 1, 2020 at 12:05 PM Jerin Jacob wrote: > > On Wed, Apr 1, 2020 at 1:49 PM David Marchand > > wrote: > > > - Regardless of the trace framework, the ALLOW_EXPERIMENTAL_API flag > > > gates access to APIs so that external users are aware of their stat

Re: [dpdk-dev] [PATCH] test/crypto: replace wireless algos test vectors

2020-04-01 Thread Akhil Goyal
Hi Fiona, > Hi Akhil, Thomas, > Can you please hold off on applying this patch for the moment - it seems we > may get approval on licensing for the original vectors. > Fiona > Do we still need this patch?

Re: [dpdk-dev] [PATCH v3 00/33] DPDK Trace support

2020-04-01 Thread David Marchand
On Wed, Apr 1, 2020 at 12:05 PM Jerin Jacob wrote: > On Wed, Apr 1, 2020 at 1:49 PM David Marchand > wrote: > > - Regardless of the trace framework, the ALLOW_EXPERIMENTAL_API flag > > gates access to APIs so that external users are aware of their status. > > I have been considering setting this

Re: [dpdk-dev] [PATCH] crypto/nitrox: add 3DES-CBC support

2020-04-01 Thread Akhil Goyal
> > -- > > > > > > This patch adds 3DES CBC mode cipher algorithm. > > > > > > Signed-off-by: Nagadheeraj Rottela > > > --- > > Is it worth mentioning in release notes? > > I added that description to avoid below checkpatch warni

[dpdk-dev] [PATCH] vhost: remove deferred shadow update

2020-04-01 Thread Marvin Liu
Defer shadow ring update will help overall throughput when frontend much slower than backend. But that is not all the cases we faced now. In case like ovs-dpdk + dpdk virtio user, frontend will much faster than backend. Frontend may not be able to collect available descs when shadow update is defer

Re: [dpdk-dev] [PATCH v3] examples/ipsec-secgw: support flow director feature

2020-04-01 Thread Akhil Goyal
> -Original Message- > From: Anoob Joseph > Sent: Wednesday, April 1, 2020 6:57 PM > To: Akhil Goyal ; Praveen Shetty > ; dev@dpdk.org; declan.dohe...@intel.com > Cc: bernard.iremon...@intel.com; konstantin.anan...@intel.com > Subject: RE: [dpdk-dev] [PATCH v3] examples/ipsec-secgw: sup

Re: [dpdk-dev] [PATCH] net/dpdkoin: add new driver

2020-04-01 Thread Ferruh Yigit
On 4/1/2020 2:10 PM, Matteo Croce wrote: > DPDK polls the packet in a busy loop. This means that CPU constantly spins > looking for packets, regardless of the network traffic. > DPDK does this to reduce latency and avoid using interrupts, at expense of > efficiency: this might consume more processi

Re: [dpdk-dev] [PATCH v3] examples/ipsec-secgw: support flow director feature

2020-04-01 Thread Anoob Joseph
Hi Akhil, Praveen, Can't rte_flow and RSS co-exist? In rte_flow there is an ACTION type RSS in addition to QUEUE. With this patch, if rte_flow is enabled on any SA, then RSS would be disabled for the entire port. Is that the right behavior? And if we have to address this later, what would be th

Re: [dpdk-dev] [PATCH v3] examples/ipsec-secgw: support flow director feature

2020-04-01 Thread Akhil Goyal
Hi Praveen, Sorry for being late to reply on this, Please delegate the patches properly from next time in patchworks. This patch was neither delegated to me, nor I was in to/cc. So it got missed. > > Support load distribution in security gateway application using > NIC load distribution feature

[dpdk-dev] [PATCH v2 4/4] ipfrag: add unit test case

2020-04-01 Thread Aaron Conole
Initial IP fragmentation unit test. Signed-off-by: Aaron Conole --- MAINTAINERS| 1 + app/test/meson.build | 2 + app/test/test_ipfrag.c | 276 + 3 files changed, 279 insertions(+) create mode 100644 app/test/test_ipfrag.c diff --git a/

[dpdk-dev] [PATCH v2 0/4] ip_frag: add a unit test for fragmentation

2020-04-01 Thread Aaron Conole
This adds a simple unit test for the ip fragmentation library and covers fragmenting ipv4 and ipv6. Additionally, some fixes are introduced, which are really just sanity rather than real issues in the field. v1->v2: - Fix patch 4/4 which had a missing assignment for pktid. Aaron Conole (4): ip

[dpdk-dev] [PATCH v2 1/4] ip_frag: ensure minimum v4 fragmentation length

2020-04-01 Thread Aaron Conole
The IPv4 specification says that each fragment must at least the size of an IP header plus 8 octets. When attempting to run ipfrag using a smaller size, the fragment library will return successful completion, even though it is a violation of RFC791 (and updates). Signed-off-by: Aaron Conole ---

[dpdk-dev] [PATCH v2 2/4] ip_frag: ensure minimum v6 fragmentation length

2020-04-01 Thread Aaron Conole
Similar to v4, we should ensure that at least a minimum fragmentation length can be achieved. Signed-off-by: Aaron Conole --- lib/librte_ip_frag/rte_ipv6_fragmentation.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/lib/librte_ip_frag/rte_ipv6_fragmentation.c b/lib/librte_ip_

[dpdk-dev] [PATCH v2 3/4] ip_frag: ipv6 fragments must not be resubmitted to fragmentation

2020-04-01 Thread Aaron Conole
IPv6 only allows traffic source nodes to fragment, so submitting a packet with next header of IPPROTO_FRAGMENT would be invalid. Signed-off-by: Aaron Conole --- lib/librte_ip_frag/rte_ipv6_fragmentation.c | 4 1 file changed, 4 insertions(+) diff --git a/lib/librte_ip_frag/rte_ipv6_fragmen

[dpdk-dev] [PATCH 2/2] test/malloc: add bad parameter tests for realloc

2020-04-01 Thread Anatoly Burakov
Realloc did not have bad parameter autotest. Add them. Signed-off-by: Anatoly Burakov --- app/test/test_malloc.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/app/test/test_malloc.c b/app/test/test_malloc.c index 3a45a00406..788595ead7 100644 --- a/app/test/test_malloc.c +++ b/

[dpdk-dev] [PATCH 1/2] test/malloc: run realloc tests on external heap

2020-04-01 Thread Anatoly Burakov
Due to the fact that the rte_realloc() test depends on the layout of underlying memory, it can sometimes fail due to fragmentation of the memory. To address this, make it so that the realloc autotests are run using a newly created external memory heap instead of main memory. Bugzilla ID: 424 Sign

[dpdk-dev] [PATCH] net/dpdkoin: add new driver

2020-04-01 Thread Matteo Croce
DPDK polls the packet in a busy loop. This means that CPU constantly spins looking for packets, regardless of the network traffic. DPDK does this to reduce latency and avoid using interrupts, at expense of efficiency: this might consume more processing power and generate more heat than needed, pote

Re: [dpdk-dev] [PATCH v2 2/2] vhost: cache gpa to hpa translation

2020-04-01 Thread Liu, Yong
> -Original Message- > From: Gavin Hu > Sent: Wednesday, April 1, 2020 6:07 PM > To: Liu, Yong ; maxime.coque...@redhat.com; Ye, > Xiaolong ; Wang, Zhihong > > Cc: dev@dpdk.org; nd > Subject: RE: [dpdk-dev] [PATCH v2 2/2] vhost: cache gpa to hpa translation > > Hi Marvin, > > >

Re: [dpdk-dev] /validate-abi.sh complains [PATCH v1 3/8] ring: introduce RTS ring mode

2020-04-01 Thread Neil Horman
On Tue, Mar 31, 2020 at 09:24:41PM +0200, Thomas Monjalon wrote: > 31/03/2020 21:22, Thomas Monjalon: > > 31/03/2020 19:05, Ananyev, Konstantin: > > > Hi everyone, > > > > > > Have a question regarding validate-abi.sh. > > > > devtools/validate-abi.sh should be removed. > > Please use the new dev

Re: [dpdk-dev] Napatech pmd

2020-04-01 Thread Neil Horman
On Tue, Mar 31, 2020 at 10:07:12PM +0200, Thomas Monjalon wrote: > 31/03/2020 21:56, Neil Horman: > > On Tue, Mar 31, 2020 at 02:29:08PM +0200, Thomas Monjalon wrote: > > > 31/03/2020 14:17, Neil Horman: > > > > On Tue, Mar 31, 2020 at 01:25:25PM +0200, Thomas Monjalon wrote: > > > > > Hi, > > > >

Re: [dpdk-dev] [PATCH] net/mlx5: fix link state update

2020-04-01 Thread Matan Azrad
Hi From: Benoit Ganne > Hi Matan, > > >> Seems to be a bug in kernel mlx5 driver: > > 1. To check with our driver team what is the issue to report a VF link Yes, driver team said the 3 kernel patches should solve the issue. > Note that even with the kernel patch, there still seem to be a valid

Re: [dpdk-dev] Napatech pmd

2020-04-01 Thread Neil Horman
On Tue, Mar 31, 2020 at 09:59:27PM +0200, Thomas Monjalon wrote: > 31/03/2020 21:51, Neil Horman: > > On Tue, Mar 31, 2020 at 07:58:45AM -0700, Stephen Hemminger wrote: > > > On Tue, 31 Mar 2020 12:39:17 + > > > Michael Lilja wrote: > > > > > > > Hi, > > > > > > > > I appreciate the discussi

[dpdk-dev] [PATCH v2] ethdev: fix for compiler warning when vtune profiling option is enabled

2020-04-01 Thread eugeny . parshutin
From: Eugeny Parshutin Add the previous prototype for the 'profile_hook_rx_burst_cb' function to fix the compiler warning when the DPDK is built with 'RTE_ETHDEV_PROFILE_WITH_VTUNE' config option enabled: /home/dpdk/lib/librte_ethdev/ethdev_profile.c:17:1: warning: no previous prototype for profi

  1   2   >