[dpdk-dev] [PATCH v2] usertools/dpdk-setup.sh: fix dpdk-setup's behaviour on non-alphanumeric inputs

2020-03-19 Thread Sarosh Arif
Bugzilla ID: 419 Cc: sta...@dpdk.org Signed-off-by: Sarosh Arif --- usertools/dpdk-setup.sh | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/usertools/dpdk-setup.sh b/usertools/dpdk-setup.sh index e5bbe9fee..c27f89c5f 100755 --- a/usertools/dpdk-setup.sh +++ b/u

Re: [dpdk-dev] [RFC] app/test-flow-perf: add rte_flow perf app

2020-03-19 Thread Jerin Jacob
On Tue, Mar 17, 2020 at 7:16 PM Wisam Jaddo wrote: Thanks for this application. Useful stuff. > > Introducing new application for rte_flow performance > testing. The application provide the ability to test > insertion rate of specific rte_flow rule, by stressing > it to the NIC, and calculate th

[dpdk-dev] [PATCH v4] app/testpmd: add fw version in port info

2020-03-19 Thread Muhammad Ahmad
rte_eth_dev_fw_version_get() was not called in test pmd. ??Added rte_eth_dev_fw_version_get() in testpmd under show port info Bugzilla ID: 225 Cc: dev@dpdk.org Reported-by: Thomas Monjalon Signed-off-by: Muhammad Ahmad --- app/test-pmd/config.c | 10 ++ 1 file changed, 10 insertions(

Re: [dpdk-dev] [PATCH v2 3/3] app/testpmd: qualify profiling statistics on burst size

2020-03-19 Thread Jerin Jacob
On Thu, Mar 19, 2020 at 7:21 PM Viacheslav Ovsiienko wrote: > > The execution time of rx/tx burst routine depends on the burst size. > It would be meaningful to research this dependency, the patch > provides an extra profiling data per rx/tx burst size. > > Signed-off-by: Viacheslav Ovsiienko >

Re: [dpdk-dev] [PATCH 0/3] refresh NIC features matrix

2020-03-19 Thread Zhang, Qi Z
Hi Thomas: > -Original Message- > From: Thomas Monjalon > Sent: Thursday, March 12, 2020 7:02 AM > To: dev@dpdk.org > Cc: rahul.lakkire...@chelsio.com; Zhang, Qi Z ; Wang, > Xiao W ; xavier.hu...@huawei.com; Xing, Beilei > ; Lu, Wenzhuo ; Yang, Qiming > ; Ananyev, Konstantin > ; Yigit, Fe

Re: [dpdk-dev] [PATCH v3 00/12] generic rte atomic APIs deprecate proposal

2020-03-19 Thread Honnappa Nagarahalli
> Subject: Re: [PATCH v3 00/12] generic rte atomic APIs deprecate proposal > > 18/03/2020 15:01, Van Haaren, Harry: > > Hi Phil & Honnappa, > > > > From: Phil Yang > > > > > > DPDK provides generic rte_atomic APIs to do several atomic operations. > > > These APIs are using the deprecated __sync

Re: [dpdk-dev] [PATCH v3 00/12] generic rte atomic APIs deprecate proposal

2020-03-19 Thread Honnappa Nagarahalli
> > Subject: [PATCH v3 00/12] generic rte atomic APIs deprecate proposal > > > > DPDK provides generic rte_atomic APIs to do several atomic operations. > > These APIs are using the deprecated __sync built-ins and enforce full > > memory barriers on aarch64. However, full barriers are not necessar

Re: [dpdk-dev] [PATCH v3] testpmd: added rte_eth_dev_fw_version_get in testpmd

2020-03-19 Thread Kalesh Anakkur Purayil
Hi Muhammad, Could you update the commit title as: "app/testpmd: add fw version in port info" Regards, Kalesh On Thu, Mar 19, 2020 at 1:16 PM Muhammad Ahmad wrote: > rte_eth_dev_fw_version_get() was not called in test pmd. > Added rte_eth_dev_fw_version_get() in testpmd under > show port inf

Re: [dpdk-dev] [PATCH v2] eal: fix to set the rte_device ptr's device args before hotplug

2020-03-19 Thread Somnath Kotur
On Mon, Feb 17, 2020 at 3:36 PM Thomas Monjalon wrote: > > 17/02/2020 11:02, Ferruh Yigit: > > On 2/17/2020 3:18 AM, Somnath Kotur wrote: > > > On Fri, Feb 14, 2020 at 1:54 PM Gaetan Rivet wrote: > > >> > > >> On 14/02/2020 07:43, Somnath Kotur wrote: > > >>> As per the comments in this code sect

[dpdk-dev] [PATCH v2 14/14] net/igc: implement flow API

2020-03-19 Thread alvinx . zhang
From: Alvin Zhang Below type of flows are supported: ether-type filter, 2-tuple filter, SYN filter, RSS Signed-off-by: Alvin Zhang --- drivers/net/igc/Makefile | 1 + drivers/net/igc/igc_ethdev.c | 3 + drivers/net/igc/igc_ethdev.h | 27 ++ drivers/net/igc/igc_filter.c | 7 + driver

[dpdk-dev] [PATCH v2 09/14] net/igc: implement feature of VLAN

2020-03-19 Thread alvinx . zhang
From: Alvin Zhang Below ops ware added: vlan_filter_set vlan_offload_set vlan_tpid_set vlan_strip_queue_set Signed-off-by: Alvin Zhang v2: fix max packet length fault when extend vlan is enabled or disabled --- doc/guides/nics/features/igc.ini | 2 + drivers/net/igc/igc_ethdev.c | 209 +

[dpdk-dev] [PATCH v2 13/14] net/igc: implement hash filter configure

2020-03-19 Thread alvinx . zhang
From: Alvin Zhang Support configure of hash filter. Signed-off-by: Alvin Zhang --- drivers/net/igc/igc_filter.c | 155 +++ drivers/net/igc/igc_txrx.c | 77 - drivers/net/igc/igc_txrx.h | 4 ++ 3 files changed, 235 insertions(+)

[dpdk-dev] [PATCH v2 10/14] net/igc: implement ether-type filter

2020-03-19 Thread alvinx . zhang
From: Alvin Zhang Update feature list too. Signed-off-by: Alvin Zhang --- doc/guides/nics/features/igc.ini | 1 + drivers/net/igc/Makefile | 1 + drivers/net/igc/igc_ethdev.c | 5 + drivers/net/igc/igc_ethdev.h | 15 +++ drivers/net/igc/igc_filter.c | 237 +++

[dpdk-dev] [PATCH v2 11/14] net/igc: implement 2-tuple filter

2020-03-19 Thread alvinx . zhang
From: Alvin Zhang Add L3 protocol type and L4 destination port filter. Signed-off-by: Alvin Zhang --- drivers/net/igc/igc_ethdev.h | 38 + drivers/net/igc/igc_filter.c | 341 +++ drivers/net/igc/igc_filter.h | 3 + 3 files changed, 382 insertions(

[dpdk-dev] [PATCH v2 12/14] net/igc: implement TCP SYN filter

2020-03-19 Thread alvinx . zhang
From: Alvin Zhang Support putting all TCP SYN packets into a specified queue. Signed-off-by: Alvin Zhang --- drivers/net/igc/igc_ethdev.h | 18 ++ drivers/net/igc/igc_filter.c | 129 +++ drivers/net/igc/igc_filter.h | 3 + 3 files changed, 150 ins

[dpdk-dev] [PATCH v2 08/14] net/igc: implement RSS API

2020-03-19 Thread alvinx . zhang
From: Alvin Zhang Below ops are added: reta_update reta_query rss_hash_update rss_hash_conf_get Signed-off-by: Alvin Zhang --- doc/guides/nics/features/igc.ini | 2 + drivers/net/igc/igc_ethdev.c | 171 +++ drivers/net/igc/igc_ethdev.h | 9 +++ d

[dpdk-dev] [PATCH v2 05/14] net/igc: implement status API

2020-03-19 Thread alvinx . zhang
From: Alvin Zhang Implement base status, extend status and per queue status API. Below ops are added: stats_get xstats_get xstats_get_by_id xstats_get_names_by_id xstats_get_names stats_reset xstats_reset queue_stats_mapping_set Signed-off-by: Alvin Zhang v2: fix xstats_get_names_by_id issue

[dpdk-dev] [PATCH v2 07/14] net/igc: implement flow control ops

2020-03-19 Thread alvinx . zhang
From: Alvin Zhang Update feature list too. Signed-off-by: Alvin Zhang --- doc/guides/nics/features/igc.ini | 1 + drivers/net/igc/igc_ethdev.c | 121 +++ 2 files changed, 122 insertions(+) diff --git a/doc/guides/nics/features/igc.ini b/doc/guides/nic

[dpdk-dev] [PATCH v2 06/14] net/igc: enable Rx queue interrupts

2020-03-19 Thread alvinx . zhang
From: Alvin Zhang Setup NIC to generate MSI-X interrupts. Set the IVAR register to map interrupt causes to vectors. Implement interrupt enable/disable functions. Signed-off-by: Alvin Zhang --- doc/guides/nics/features/igc.ini | 1 + drivers/net/igc/igc_ethdev.c | 170

[dpdk-dev] [PATCH v2 04/14] net/igc: support reception and transmission of packets

2020-03-19 Thread alvinx . zhang
From: Alvin Zhang Below ops are added too: mac_addr_add mac_addr_remove mac_addr_set set_mc_addr_list mtu_set promiscuous_enable promiscuous_disable allmulticast_enable allmulticast_disable rx_queue_setup rx_queue_release rx_queue_count rx_descriptor_done rx_descriptor_status tx_descriptor_status

[dpdk-dev] [PATCH v2 03/14] net/igc: implement device base ops

2020-03-19 Thread alvinx . zhang
From: Alvin Zhang Bellow ops are implemented: dev_configure dev_start dev_stop dev_close dev_reset dev_set_link_up dev_set_link_down link_update fw_version_get dev_led_on dev_led_off Signed-off-by: Alvin Zhang v2: Modify codes according to comments. --- doc/guides/nics/features/igc.ini | 4

[dpdk-dev] [PATCH v2 01/14] net/igc: add igc PMD

2020-03-19 Thread alvinx . zhang
From: Alvin Zhang Implement device detection and loading. Add igc driver guid docs. Signed-off-by: Alvin Zhang v2: Update release note. Modify codes according to comments --- MAINTAINERS | 7 + config/common_base | 7 + doc/guides/nics/feat

[dpdk-dev] [PATCH v2 00/14] igc PMD

2020-03-19 Thread alvinx . zhang
From: Alvin Zhang The IGC PMD (librte_pmd_igc) provides poll mode driver support for Foxville I225 Series Network Adapters. Alvin Zhang (14): net/igc: add igc PMD net/igc: support device initialization net/igc: implement device base ops net/igc: support reception and transmission of pack

[dpdk-dev] [PATCH v1] doc: Update ICE PMD driver/firmware/package version for DPDK 20.02

2020-03-19 Thread Chen, Zhaoyan
Update driver/firmware/package version for DPDK20.02 Signed-off-by: Chen, Zhaoyan --- doc/guides/nics/ice.rst | 2 ++ 1 file changed, 2 insertions(+) diff --git a/doc/guides/nics/ice.rst b/doc/guides/nics/ice.rst index 8af32dabf..c80953822 100644 --- a/doc/guides/nics/ice.rst +++ b/doc/guides/

[dpdk-dev] [PATCH v3] net/i40e: implement hash function in rte flow API

2020-03-19 Thread Chenxu Di
implement set hash global configurations, set symmetric hash enable and set hash input set in rte flow API. Signed-off-by: Chenxu Di --- v3: -modified the doc i40e.rst v2: -canceled remove legacy filter functions. --- doc/guides/nics/i40e.rst | 14 + doc/guides/rel_notes/release_

Re: [dpdk-dev] [PATCH 1/2] net/iavf: support generic flow

2020-03-19 Thread Yang, Qiming
Thanks, I'll fix them in v2 > -Original Message- > From: Zhang, Qi Z > Sent: 2020年3月19日 10:01 > To: Yang, Qiming ; dev@dpdk.org > Cc: Yang, Qiming > Subject: RE: [dpdk-dev] [PATCH 1/2] net/iavf: support generic flow > > > > > -Original Message- > > From: dev On Behalf Of Qimi

Re: [dpdk-dev] dpdk-dev] [PATCH] cryptodev: fix missing device id range checking

2020-03-19 Thread Zhao, XinfengX
Tested-by: Zhao, Xinfengmailto:xinfengx.z...@intel.com>> > -Original Message- > From: Dybkowski, AdamX intel.com> > Sent: Thursday, February 20, 2020 3:04 PM > To: dev at dpdk.org; Trahe, Fiona > https://mail

[dpdk-dev] [PATCH] eal: reorganize directories layout

2020-03-19 Thread Thomas Monjalon
Some clean-up is done in EAL sub-directories. The goal is to make organization easier to understand, and to prepare moving some files from common to Unix-only place. Since the kernel modules are moved to kernel/ directory, there is no need anymore for the sub-directory eal/ in linux/, freebsd/ and

Re: [dpdk-dev] [PATCH v1 13/32] eal/trace: implement provider payload

2020-03-19 Thread Mattias Rönnblom
On 2020-03-18 20:02, jer...@marvell.com wrote: > From: Jerin Jacob > > The trace function payloads such as rte_trace_ctf_* have > dual functions. The first to emit the payload for the registration > function and the second one to act as trace mem emitters aka > provider payload. > > When it used a

Re: [dpdk-dev] [PATCH v1 12/32] eal/trace: implement registration payload

2020-03-19 Thread Mattias Rönnblom
On 2020-03-18 20:02, jer...@marvell.com wrote: > From: Jerin Jacob > > The trace function payloads such as rte_trace_ctf_* have > dual functions. The first to emit the payload for the registration > function and the second one to act as trace memory emitters. > > When it used as registration paylo

Re: [dpdk-dev] [PATCH v1 11/32] eal/trace: implement trace save

2020-03-19 Thread Mattias Rönnblom
On 2020-03-18 20:02, jer...@marvell.com wrote: > From: Jerin Jacob > > Implement rte_trace_save(), which will save the metadata > file and trace memory snapshot to the trace directory. > > Signed-off-by: Jerin Jacob > --- > .../common/eal_common_trace_utils.c | 75 +++

Re: [dpdk-dev] [EXT] Re: [PATCH] devtools: fix check symbol change script

2020-03-19 Thread Neil Horman
On Thu, Mar 19, 2020 at 09:15:50PM +0530, Nithin Dabilpuram wrote: > On Thu, Mar 19, 2020 at 11:40:39AM -0400, Neil Horman wrote: > > External Email > > > > -- > > On Thu, Mar 19, 2020 at 03:56:03PM +0100, David Marchand wrote: >

Re: [dpdk-dev] [PATCH] doc: prefer https when pointing to dpdk.org

2020-03-19 Thread Luca Boccassi
On Thu, 2020-03-19 at 16:40 +0100, David Marchand wrote: > On Thu, Mar 19, 2020 at 10:01 AM Thomas Monjalon > wrote: > > 19/03/2020 09:28, David Marchand: > > > for file in $(git grep -l http://.*dpdk.org doc/); do > > > sed -i -e 's#http://\(.*dpdk.org\)#https://\1#g' $file; > > > done > > > >

Re: [dpdk-dev] [PATCH v1] usertools/dpdk-setup.sh: fix dpdk-setup's behaviour on non-alphanumeric inputs

2020-03-19 Thread Stephen Hemminger
On Thu, 19 Mar 2020 22:44:23 +0500 Sarosh Arif wrote: > Bugzilla ID: 419 > Cc: sta...@dpdk.org > Signed-off-by: Sarosh Arif > --- > usertools/dpdk-setup.sh | 10 -- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/usertools/dpdk-setup.sh b/usertools/dpdk-setup.sh > in

Re: [dpdk-dev] [PATCH v3 7/7] vfio/pci: Cleanup .probe() exit paths

2020-03-19 Thread Cornelia Huck
On Wed, 11 Mar 2020 15:59:27 -0600 Alex Williamson wrote: > The cleanup is getting a tad long. > > Signed-off-by: Alex Williamson > --- > drivers/vfio/pci/vfio_pci.c | 54 > --- > 1 file changed, 25 insertions(+), 29 deletions(-) Reviewed-by: Corneli

[dpdk-dev] [PATCH v1] usertools/dpdk-setup.sh: fix dpdk-setup's behaviour on non-alphanumeric inputs

2020-03-19 Thread Sarosh Arif
Bugzilla ID: 419 Cc: sta...@dpdk.org Signed-off-by: Sarosh Arif --- usertools/dpdk-setup.sh | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/usertools/dpdk-setup.sh b/usertools/dpdk-setup.sh index e5bbe9fee..bdacf5256 100755 --- a/usertools/dpdk-setup.sh +++ b/userto

Re: [dpdk-dev] [PATCH v3 5/7] vfio/pci: Add sriov_configure support

2020-03-19 Thread Cornelia Huck
On Wed, 11 Mar 2020 15:59:12 -0600 Alex Williamson wrote: > With the VF Token interface we can now expect that a vfio userspace > driver must be in collaboration with the PF driver, an unwitting > userspace driver will not be able to get past the GET_DEVICE_FD step > in accessing the device. We

[dpdk-dev] [PATCH 10/12] telemetry: remove existing telemetry files

2020-03-19 Thread Ciara Power
This patch removes the existing telemetry files, which are now redundant as the new version of telemetry has backward compatibility for their functionality. Signed-off-by: Ciara Power --- lib/librte_metrics/rte_metrics_telemetry.c|9 - lib/librte_telemetry/Makefile |5

[dpdk-dev] [PATCH 11/12] lib: add telemetry as eal dependency

2020-03-19 Thread Ciara Power
This patch moves telemetry further down the build, and adds it as a dependency for EAL. Telemetry is now configured to build by default, and has EAL flags, shown below: "--telemetry" = Enables telemetry (this is default if no flags given) "--no-telemetry" = Disables telemetry When telemetry is ena

[dpdk-dev] [PATCH 12/12] eal: add eal telemetry callbacks

2020-03-19 Thread Ciara Power
From: Bruce Richardson EAL now registers commands to provide some basic info from EAL. Example: Connecting to /var/run/dpdk/rte/dpdk_telemetry.66307 --> / {"/": ["/", "/eal/app_params", "/eal/params", "/eal/version", "/ethdev/list", "/ethdev/stats", "/rawdev/list", "/rawdev/stats"]} --> /eal/ap

[dpdk-dev] [PATCH 09/12] telemetry: introduce telemetry backward compatibility

2020-03-19 Thread Ciara Power
The new telemetry will now open a socket using the old telemetry path, to ensure backward compatibility. This is not yet initialised, as it would clash with the existing telemetry, to be removed in a later patch. This means that both old and new telemetry socket interfaces are handled in a common w

[dpdk-dev] [PATCH 06/12] usertools: add new telemetry python script

2020-03-19 Thread Ciara Power
From: Bruce Richardson This patch adds a python script that can be used with the new telemetry socket. It connects as a client to the socket, and allows the user send a command and see the JSON response. The example usage below shows the script connecting to the new telemetry socket, and sending

[dpdk-dev] [PATCH 08/12] examples/l3fwd-power: enable use of new telemetry

2020-03-19 Thread Ciara Power
The l3fwd-power example app now registers a stats command with telemetry, and provides a callback function to handle formatting the power stats. An example usage is shown below: Connecting to /var/run/dpdk/rte/dpdk_telemetry.23863 --> / {"/": ["/", "/ethdev/list", "/ethdev/stats", "/l3fwd-power/s

[dpdk-dev] [PATCH 07/12] rawdev: add callback support for telemetry

2020-03-19 Thread Ciara Power
The rawdev library now registers commands with telemetry, and implements the corresponding callback functions. These allow a list of rawdev devices and stats for a rawdev port to be queried. An example usage, with ioat rawdev driver instances, is shown below: Connecting to /var/run/dpdk/rte/dpdk_

[dpdk-dev] [PATCH 03/12] telemetry: invert dependency on metrics

2020-03-19 Thread Ciara Power
From: Bruce Richardson Rather than having the telemetry library depend on the metrics lib we invert the dependency so that metrics instead depends on telemetry lib, and registers the needed functions with it at init time. This prepares the way for a cleaner telemetry architecture to be applied in

[dpdk-dev] [PATCH 02/12] metrics: reduce code taken from telemetry

2020-03-19 Thread Ciara Power
The telemetry code that was moved into the metrics library can be shortened, while still maintaining the same functionality. Signed-off-by: Ciara Power Signed-off-by: Bruce Richardson --- lib/librte_metrics/rte_metrics_telemetry.c | 476 lib/librte_metrics/rte_metrics_tele

[dpdk-dev] [PATCH 05/12] ethdev: add callback support for telemetry

2020-03-19 Thread Ciara Power
From: Bruce Richardson The ethdev library now registers commands with telemetry, and implements the callback functions. These commands allow the list of ethdev ports and the stats for a port to be queried. Signed-off-by: Bruce Richardson Signed-off-by: Ciara Power --- lib/librte_ethdev/Makefi

[dpdk-dev] [PATCH 04/12] telemetry: introduce new telemetry functionality

2020-03-19 Thread Ciara Power
From: Bruce Richardson This patch introduces a new telemetry connection socket and handling functionality. Like the existing telemetry implementation (which is unaffected by this change) it uses a unix socket, but unlike the existing one it does not have a fixed list of commands - instead librari

[dpdk-dev] [PATCH 01/12] telemetry: move code to metrics for later reuse

2020-03-19 Thread Ciara Power
This commit moves some of the telemetry library code to a new file in the metrics library. No modifications are made to the moved code, except what is needed to allow it to compile and run. The additional code in metrics is built only when the Jansson library is present. Telemetry functions as nor

[dpdk-dev] [PATCH 00/12] update and simplify telemetry library.

2020-03-19 Thread Ciara Power
This patchset extensively reworks the telemetry library adding new functionality and simplifying much of the existing code, while maintaining backward compatibility. This work is based on the previously sent RFC for a "process info" library: https://patchwork.dpdk.org/project/dpdk/list/?series=774

Re: [dpdk-dev] [PATCH v3 4/7] vfio: Introduce VFIO_DEVICE_FEATURE ioctl and first user

2020-03-19 Thread Cornelia Huck
On Wed, 11 Mar 2020 15:59:01 -0600 Alex Williamson wrote: > The VFIO_DEVICE_FEATURE ioctl is meant to be a general purpose, device > agnostic ioctl for setting, retrieving, and probing device features. > This implementation provides a 16-bit field for specifying a feature > index, where the data

Re: [dpdk-dev] [PATCH v3 3/7] vfio/pci: Introduce VF token

2020-03-19 Thread Cornelia Huck
On Wed, 11 Mar 2020 15:58:52 -0600 Alex Williamson wrote: > If we enable SR-IOV on a vfio-pci owned PF, the resulting VFs are not > fully isolated from the PF. The PF can always cause a denial of service > to the VF, even if by simply resetting itself. The degree to which a PF > can access the

Re: [dpdk-dev] [PATCH v3] net/vhost: fix potential memory leak

2020-03-19 Thread Kevin Traynor
Hi Itsuro, On 05/03/2020 02:54, Itsuro Oda wrote: > If a vhost device is closed before eth_dev_configure is done > to the device, internal resources allocated to the device > would not be freed. This patch fixes it. > > Fixes: 3d01b759d267 ("net/vhost: delay driver setup") > Cc: sta...@dpdk.org >

Re: [dpdk-dev] [PATCH] maintainers: update for ring library

2020-03-19 Thread David Marchand
On Thu, Mar 5, 2020 at 6:01 PM Olivier Matz wrote: > > Honnappa and Konstantin contributed actively to the ring library > and volunteered to replace myself as maintainers. > > Signed-off-by: Olivier Matz Acked-by: Honnappa Nagarahalli Acked-by: Konstantin Ananyev Applied, thanks. -- David

[dpdk-dev] [PATCH v2] examples/ipsec-secgw: support flow director feature

2020-03-19 Thread Praveen Shetty
Support load distribution in security gateway application using NIC load distribution feature(Flow Director). Flow Director is used to redirect the specified inbound ipsec flow to a specified queue.This is achieved by extending the SA rule syntax to support specification by adding new action_type o

Re: [dpdk-dev] [EXT] Re: [PATCH v1 20/26] node: ipv4 lookup for x86

2020-03-19 Thread Pavan Nikhilesh Bhagavatula
>-Original Message- >From: Ray Kinsella >Sent: Thursday, March 19, 2020 9:21 PM >To: Pavan Nikhilesh Bhagavatula ; Jerin >Jacob Kollanukkaran ; Nithin Kumar Dabilpuram > >Cc: dev@dpdk.org; tho...@monjalon.net; >david.march...@redhat.com; mattias.ronnb...@ericsson.com; Kiran >Kumar Kokkil

Re: [dpdk-dev] [PATCH] ring: fix unaligned memory access on aarch32

2020-03-19 Thread David Marchand
On Mon, Mar 9, 2020 at 6:20 PM Phil Yang wrote: > > The 32-bit arm machine doesn't support unaligned memory access. It > will cause a bus error on aarch32 with the custom element size ring. > > Thread 1 "test" received signal SIGBUS, Bus error. > __rte_ring_enqueue_elems_64 (n=1, obj_table=0xf5edf

Re: [dpdk-dev] [EXT] Re: [PATCH v1 20/26] node: ipv4 lookup for x86

2020-03-19 Thread Ray Kinsella
On 19/03/2020 14:22, Pavan Nikhilesh Bhagavatula wrote: >> On 18/03/2020 21:35, jer...@marvell.com wrote: >>> From: Pavan Nikhilesh >>> >>> Add IPv4 lookup process function for ip4_lookup >>> rte_node. This node performs LPM lookup using x86_64 >>> vector supported RTE_LPM API on every packet r

Re: [dpdk-dev] [PATCH] devtools: fix check symbol change script

2020-03-19 Thread Bing Zhao
> -Original Message- > From: Neil Horman > Sent: Thursday, March 19, 2020 11:41 PM > To: David Marchand > Cc: Thomas Monjalon ; dev ; > Jerin Jacob Kollanukkaran ; Nithin Dabilpuram > ; dpdk stable ; Bing > Zhao > Subject: Re: [PATCH] devtools: fix check symbol change script > > On Thu,

Re: [dpdk-dev] [EXT] Re: [PATCH] devtools: fix check symbol change script

2020-03-19 Thread Nithin Dabilpuram
On Thu, Mar 19, 2020 at 11:40:39AM -0400, Neil Horman wrote: > External Email > > -- > On Thu, Mar 19, 2020 at 03:56:03PM +0100, David Marchand wrote: > > On Thu, Mar 19, 2020 at 3:44 PM Nithin Dabilpuram > > wrote: > > > > > > F

Re: [dpdk-dev] [PATCH] devtools: fix check symbol change script

2020-03-19 Thread Neil Horman
On Thu, Mar 19, 2020 at 03:56:03PM +0100, David Marchand wrote: > On Thu, Mar 19, 2020 at 3:44 PM Nithin Dabilpuram > wrote: > > > > Fix check symbol change script to detect new diff file when > > it is in between "--- /dev/null" to "b/lib/...". > > Current awk line expects line to start with "a/

Re: [dpdk-dev] [PATCH] doc: prefer https when pointing to dpdk.org

2020-03-19 Thread David Marchand
On Thu, Mar 19, 2020 at 10:01 AM Thomas Monjalon wrote: > > 19/03/2020 09:28, David Marchand: > > for file in $(git grep -l http://.*dpdk.org doc/); do > > sed -i -e 's#http://\(.*dpdk.org\)#https://\1#g' $file; > > done > > > > Cc: sta...@dpdk.org > > > > Signed-off-by: David Marchand > > ---

Re: [dpdk-dev] [PATCH] usertools/dpdk-setup.sh: fix dpdk-setup's behaviour on non-alphanumeric inputs

2020-03-19 Thread Stephen Hemminger
On Thu, 19 Mar 2020 18:31:47 +0500 Sarosh Arif wrote: > - ${OPTIONS[our_entry]} ${our_entry} > > + re='^[0-9]+$' > + if [[ $our_entry =~ $re ]] ; then > + ${OPTIONS[our_entry]} ${our_entry} > + fi > + Some comments: 1. Use same indentation style as the rest of the script

Re: [dpdk-dev] [PATCH] devtools: fix check symbol change script

2020-03-19 Thread David Marchand
On Thu, Mar 19, 2020 at 3:44 PM Nithin Dabilpuram wrote: > > Fix check symbol change script to detect new diff file when > it is in between "--- /dev/null" to "b/lib/...". > Current awk line expects line to start with "a/..." > which is not always true for all diffs. > As a result if in_map was '

Re: [dpdk-dev] [PATCH] pmdinfo: check for pci.ids in /usr/share/misc

2020-03-19 Thread David Marchand
On Thu, Mar 12, 2020 at 5:30 PM wrote: > > From: Luca Boccassi > > Debian and Ubuntu switched years ago from /usr/share/hwdata to > /usr/share/misc, > and the former is just a compat symlink now. > We are starting to get bug reports to nudge us into changing. > So check the new path first, and t

[dpdk-dev] [PATCH] devtools: fix check symbol change script

2020-03-19 Thread Nithin Dabilpuram
Fix check symbol change script to detect new diff file when it is in between "--- /dev/null" to "b/lib/...". Current awk line expects line to start with "a/..." which is not always true for all diffs. As a result if in_map was '1' earlier, it will not be changed to '0' and we get check patch error

Re: [dpdk-dev] [PATCH] contigmem: cleanup properly when load fails

2020-03-19 Thread David Marchand
On Tue, Mar 10, 2020 at 10:32 AM Bruce Richardson wrote: > > On Mon, Mar 09, 2020 at 03:00:25AM -0700, Jim Harris wrote: > > If contigmem is not able to allocate all of the > > requested buffers, it frees whatever buffers were > > able to be allocated up until that point. > > > > But the pointers

Re: [dpdk-dev] [RFC PATCH 0/5] Support Intel IPSec MB v0.53 in DPDK 18.11

2020-03-19 Thread Kevin Traynor
+sta...@dpdk.org Hi Pablo, Sorry, but I'm not comfortable with these patches for 18.11. On 05/03/2020 15:34, Pablo de Lara wrote: > This patchset adds support to the following crypto PMDs to use > Intel IPSec MB v0.53, in DPDK v18.11: > - AESNI MB PMD: had support up to v0.52, extending to v0.53

Re: [dpdk-dev] [EXT] Re: [PATCH v1 20/26] node: ipv4 lookup for x86

2020-03-19 Thread Pavan Nikhilesh Bhagavatula
>On 18/03/2020 21:35, jer...@marvell.com wrote: >> From: Pavan Nikhilesh >> >> Add IPv4 lookup process function for ip4_lookup >> rte_node. This node performs LPM lookup using x86_64 >> vector supported RTE_LPM API on every packet received >> and forwards it to a next node that is identified by >>

Re: [dpdk-dev] [PATCH] net/ipn3ke: use ctrl thread to check link status

2020-03-19 Thread Xu, Rosen
Thanks. > -Original Message- > From: Ye, Xiaolong > Sent: Thursday, March 19, 2020 21:43 > To: Pei, Andy > Cc: dev@dpdk.org; Xu, Rosen ; sta...@dpdk.org; > david.march...@redhat.com; Yigit, Ferruh > Subject: Re: [PATCH] net/ipn3ke: use ctrl thread to check link status > > On 03/16, And

Re: [dpdk-dev] [PATCH 2/2] net/octeontx2: add devargs to lock Rx/Tx ctx

2020-03-19 Thread Pavan Nikhilesh Bhagavatula
>-Original Message- >From: dev On Behalf Of Andrzej Ostruszka >Sent: Thursday, March 19, 2020 3:07 PM >To: dev@dpdk.org >Subject: Re: [dpdk-dev] [PATCH 2/2] net/octeontx2: add devargs to lock >Rx/Tx ctx > >On 3/6/20 5:35 PM, pbhagavat...@marvell.com wrote: >> From: Pavan Nikhilesh >> >>

Re: [dpdk-dev] [PATCH] contigmem: cleanup properly when load fails

2020-03-19 Thread Harris, James R
On 3/19/20, 5:54 AM, "David Marchand" wrote: On Tue, Mar 10, 2020 at 10:32 AM Bruce Richardson wrote: > > On Mon, Mar 09, 2020 at 03:00:25AM -0700, Jim Harris wrote: > > If contigmem is not able to allocate all of the > > requested buffers, it frees whatever buffers we

[dpdk-dev] [PATCH v2 2/3] app/testpmd: gather Rx and Tx routines profiling

2020-03-19 Thread Viacheslav Ovsiienko
This patch counts the tick spent in rx-tx_burst routines in dedicated counters and displays the gathered profiling statistics. The feature is engaged only if CONFIG_RTE_TEST_PMD_RECORD_CORE_CYCLES configured as 'Y'. The "set fwdprof (flags)" command can be used to select what counters should be in

[dpdk-dev] [PATCH v2 3/3] app/testpmd: qualify profiling statistics on burst size

2020-03-19 Thread Viacheslav Ovsiienko
The execution time of rx/tx burst routine depends on the burst size. It would be meaningful to research this dependency, the patch provides an extra profiling data per rx/tx burst size. Signed-off-by: Viacheslav Ovsiienko --- app/test-pmd/csumonly.c | 11 +++ app/test-pmd/flowgen.c

[dpdk-dev] [PATCH v2 0/3] app/testpmd: qualify Rx/Tx profiling data on burst size

2020-03-19 Thread Viacheslav Ovsiienko
There is the CONFIG_RTE_TEST_PMD_RECORD_CORE_CYCLES configuration parameter enabling the lightweight profiler for the forwarding routines that provides the time spent in the routines and estimates the CPU cycles required to process one packet. It would be good to have separated data for the Rx and

[dpdk-dev] [PATCH v2 1/3] app/testpmd: add profiling flags set command

2020-03-19 Thread Viacheslav Ovsiienko
This commit is preparation step before adding the separated profiling of Rx and Tx burst routines. The new testpmd command is introduced: set fwdprof (flags) This command controls which profiling statistics is being gathered in runtime: - bit 0 - enables profiling the entire forward routine, c

Re: [dpdk-dev] [PATCH] net/ipn3ke: use ctrl thread to check link status

2020-03-19 Thread Ye Xiaolong
On 03/16, Andy Pei wrote: >ipn3ke driver creates a thread to check link status. > >before this patch, pthread_create() is used to create >thread, leaving the new thread unrestrained wrt cpu >affinity. > >After this patch, rte_ctrl_thread_create() is used to >create thread. The affinity of the new t

Re: [dpdk-dev] [PATCH 1/2] mempool/octeontx2: add devargs to lock ctx in cache

2020-03-19 Thread Pavan Nikhilesh Bhagavatula
>-Original Message- >From: dev On Behalf Of Andrzej Ostruszka >Sent: Thursday, March 19, 2020 3:07 PM >To: dev@dpdk.org >Subject: Re: [dpdk-dev] [PATCH 1/2] mempool/octeontx2: add devargs >to lock ctx in cache > >On 3/6/20 5:35 PM, pbhagavat...@marvell.com wrote: >> From: Pavan Nikhilesh

[dpdk-dev] [PATCH] usertools/dpdk-setup.sh: fix dpdk-setup's behaviour on non-alphanumeric inputs

2020-03-19 Thread Sarosh Arif
Used regular expression to see if the input is numeric, otherwise prompts the user to re-enter. Bugzilla ID: 419 Cc: sta...@dpdk.org Signed-off-by: Sarosh Arif --- usertools/dpdk-setup.sh | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) mode change 100755 => 100644 usertools/dpdk-se

[dpdk-dev] [PATCH 2/3] net/tap: fix mbuf and mem leak during queue release

2020-03-19 Thread wangyunjian
From: Yunjian Wang For the tap PMD, we should release mbufs and iovecs from the Rx queue when close or remove device. Fixes: 0781f5762cfe ("net/tap: support segmented mbufs") CC: sta...@dpdk.org Signed-off-by: Yunjian Wang --- drivers/net/tap/rte_eth_tap.c | 12 1 file changed, 1

[dpdk-dev] [PATCH 0/3] fixes for tap

2020-03-19 Thread wangyunjian
From: Yunjian Wang This series include three fixes patches for tap PMD driver. Yunjian Wang (3): net/tap: fix mbuf double free when writev fails net/tap: fix mbuf and mem leak during queue release net/tap: fix check for mbuf's nb_segs failure drivers/net/tap/rte_eth_tap.c | 53 ++

[dpdk-dev] [PATCH 1/3] net/tap: fix mbuf double free when write fails

2020-03-19 Thread wangyunjian
From: Yunjian Wang When the tap_write_mbufs() function return with break, mbuf was freed without incrementing num_packets. This may lead applications also free the mbuf. And the pmd_tx_burst() function should returns the number of original packets it actually sent excluding tso mbufs. Fixes: 939

[dpdk-dev] [PATCH 3/3] net/tap: fix check for mbuf's nb_segs failure

2020-03-19 Thread wangyunjian
From: Yunjian Wang Now the rxq->pool is mbuf concatenation, But its nb_segs is 1. When do some sanity checks on the mbuf, it fails. Fixes: 0781f5762cfe ("net/tap: support segmented mbufs") CC: sta...@dpdk.org Signed-off-by: Yunjian Wang --- drivers/net/tap/rte_eth_tap.c | 24 +

Re: [dpdk-dev] [PATCH v3 0/7] vfio/pci: SR-IOV support

2020-03-19 Thread Alex Williamson
On Thu, 19 Mar 2020 06:32:25 + "Tian, Kevin" wrote: > > From: Alex Williamson > > Sent: Thursday, March 12, 2020 5:58 AM > > > > Only minor tweaks since v2, GET and SET on VFIO_DEVICE_FEATURE are > > enforced mutually exclusive except with the PROBE option as suggested > > by Connie, the mo

[dpdk-dev] DPDK Release Status Meeting 19/03/2020

2020-03-19 Thread Ferruh Yigit
Minutes 19 March 2020 - Agenda: * Release Dates * Subtrees * OvS Participants: * Debian/Microsoft * Intel * Marvell * Mellanox * NXP * Red Hat Release Dates - * v20.05 dates: * Proposal/V1 deadline passed, it was on Wednesday 18 March 2020 * Integration/Merg

Re: [dpdk-dev] [PATCH] contigmem: cleanup properly when load fails

2020-03-19 Thread David Marchand
On Tue, Mar 10, 2020 at 10:32 AM Bruce Richardson wrote: > > On Mon, Mar 09, 2020 at 03:00:25AM -0700, Jim Harris wrote: > > If contigmem is not able to allocate all of the > > requested buffers, it frees whatever buffers were > > able to be allocated up until that point. > > > > But the pointers

Re: [dpdk-dev] [PATCH] crypto: add cryptodev trace and new API rte_cryptodev_is_qp_setup()

2020-03-19 Thread Trahe, Fiona
> -Original Message- > From: Danilewicz, MarcinX > Sent: Thursday, March 19, 2020 12:21 PM > To: dev@dpdk.org > Cc: akhil.go...@nxp.com; Trahe, Fiona > Subject: [PATCH] crypto: add cryptodev trace and new API > rte_cryptodev_is_qp_setup() > > From: Fiona Trahe > > Signed-off-by: Fi

Re: [dpdk-dev] [PATCH v1 20/26] node: ipv4 lookup for x86

2020-03-19 Thread Ray Kinsella
On 18/03/2020 21:35, jer...@marvell.com wrote: > From: Pavan Nikhilesh > > Add IPv4 lookup process function for ip4_lookup > rte_node. This node performs LPM lookup using x86_64 > vector supported RTE_LPM API on every packet received > and forwards it to a next node that is identified by > loo

Re: [dpdk-dev] [PATCH 0/4] Support DMA-accelerated Tx operations for vhost-user PMD

2020-03-19 Thread Hu, Jiayu
Hi Maxime, > -Original Message- > From: Maxime Coquelin > Sent: Thursday, March 19, 2020 5:10 PM > To: Hu, Jiayu ; dev@dpdk.org > Cc: Ye, Xiaolong ; Wang, Zhihong > > Subject: Re: [PATCH 0/4] Support DMA-accelerated Tx operations for vhost- > user PMD > > Hi Jiayu, > > On 3/19/20 8:33

Re: [dpdk-dev] [dpdk-stable] [PATCH] doc: prefer https when pointing to dpdk.org

2020-03-19 Thread Kevin Traynor
On 19/03/2020 08:28, David Marchand wrote: > for file in $(git grep -l http://.*dpdk.org doc/); do > sed -i -e 's#http://\(.*dpdk.org\)#https://\1#g' $file; > done > > Cc: sta...@dpdk.org > > Signed-off-by: David Marchand Acked-by: Kevin Traynor > --- > devtools/checkpatches.sh

Re: [dpdk-dev] [PATCH v1 06/32] eal/trace: get bootup timestamp for trace

2020-03-19 Thread Mattias Rönnblom
On 2020-03-18 20:02, jer...@marvell.com wrote: > From: Jerin Jacob > > Find epoch_sec, epoch_nsec and uptime_ticks time information > on eal_trace_init()/bootup to derive the time in the trace. > > Signed-off-by: Jerin Jacob > --- > lib/librte_eal/common/eal_common_trace.c | 3 +++ > ...

Re: [dpdk-dev] [PATCH v1 05/32] eal/trace: add internal trace init and fini interface

2020-03-19 Thread Mattias Rönnblom
On 2020-03-18 20:02, jer...@marvell.com wrote: > From: Jerin Jacob > > Define eal_trace_init() and eal_trace_fini() EAL interface > functions that rte_eal_init() and rte_eal_cleanup() function can be > use to initialize and finalize the trace subsystem. > eal_trace_init() function will add the fol

[dpdk-dev] mbuf: why rte_pktmbuf_pool_create doesn't have the flags parameter ?

2020-03-19 Thread Sylvain R
Hi ! It is my understanding that when we want a mempool to give to the queue setup functions, we should use rte_pktmbuf_pool_create() instead of rte_mempool_create(). However, the former does not allow to create single producer / single consumer mempools, as it doesn't have the 'flags' parameter r

[dpdk-dev] [PATCH] net/ixgbe: fix link state timing issue on fiber ports

2020-03-19 Thread Phil Yang
With some models of fiber ports (e.g. X520-2 device ID 0x10fb), it is possible when a port is started to experience a timing issue which prevents the link from ever being fully set up. In ixgbe_dev_link_update_share(), if the media type is fiber and the link is down, a flag (IXGBE_FLAG_NEED_LINK_C

Re: [dpdk-dev] [PATCH v1 04/32] eal/trace: implement trace operation APIs

2020-03-19 Thread Mattias Rönnblom
On 2020-03-18 20:02, jer...@marvell.com wrote: > From: Jerin Jacob > > This patch implements the following public trace APIs. > > - rte_trace_global_is_enabled() > - rte_trace_global_is_disabled() > - rte_trace_is_id_invalid() > - rte_trace_global_level_set() > - rte_trace_global_level_get() > - r

Re: [dpdk-dev] [PATCH v1 03/32] eal/trace: implement trace register API

2020-03-19 Thread Mattias Rönnblom
On 2020-03-18 20:02, jer...@marvell.com wrote: > From: Jerin Jacob > > The consumers of trace API defines the tracepoint and registers > to eal. Internally these tracepoints will be stored in STAILQ > for future use. This patch implements the tracepoint > registration function. > > Signed-off-by:

Re: [dpdk-dev] [PATCH 1/2] mempool/octeontx2: add devargs to lock ctx in cache

2020-03-19 Thread Andrzej Ostruszka
On 3/6/20 5:35 PM, pbhagavat...@marvell.com wrote: > From: Pavan Nikhilesh > > Add device arguments to lock NPA aura and pool contexts in NDC cache. > The device args take hexadecimal bitmask where each bit represent the > corresponding aura/pool id. > Example: > -w 0002:02:00.0,npa_lock_ma

Re: [dpdk-dev] [PATCH 2/2] net/octeontx2: add devargs to lock Rx/Tx ctx

2020-03-19 Thread Andrzej Ostruszka
On 3/6/20 5:35 PM, pbhagavat...@marvell.com wrote: > From: Pavan Nikhilesh > > Add device arguments to lock Rx/Tx contexts. > Application can either choose to lock Rx or Tx contexts by using > 'lock_rx_ctx' or 'lock_tx_ctx' respectively per each port. > > Example: > -w 0002:02:00.0,lock_rx

Re: [dpdk-dev] [PATCH] mbuf: optimize memory loads during mbuf freeing

2020-03-19 Thread Olivier Matz
Hi, On Mon, Mar 16, 2020 at 06:31:40PM +, Alexander Kozyrev wrote: > Introduction of pinned external buffers doubled memory loads in the > rte_pktmbuf_prefree_seg() function. Analysis of the generated assembly > code shows unnecessary load of the pool field of the rte_mbuf structure. > Here is

Re: [dpdk-dev] [PATCH] ethdev: add DBDF action to RTE Flow

2020-03-19 Thread Thomas Monjalon
19/03/2020 10:17, Kiran Kumar Kokkilagadda: > From: Ori Kam > > From: Kiran Kumar Kokkilagadda > > > From: Ori Kam > > > > From: kirankum...@marvell.com > > > > > From: Kiran Kumar K > > > > > > > > > > Adding suuport to DBDF action in the RTE Flow. > > > > > Application can specify the dbdf va

  1   2   >