[dpdk-dev] [PATCH v2 5/7] net/ice: export the DDP definition symbols

2020-03-09 Thread Haiyue Wang
A new DCF PMD will be introduced, which runs on Intel VF hardware, and it is a pure software design to control the advance functionality (such as switch, ACL) for rest of the VFs. The DCF (Device Config Function) feature shares the core functions of the ICE PMD, like it needs to export the DDP def

[dpdk-dev] [PATCH v2 1/7] net/iavf: stop the PCI probe in DCF mode

2020-03-09 Thread Haiyue Wang
A new DCF PMD will be introduced, which runs on Intel VF hardware, and it is a pure software design to control the advance functionality (such as switch, ACL) for rest of the VFs. So if the DCF (Device Config Function) mode is specified by the devarg 'cap=dcf', then it will stop the PCI probe in t

[dpdk-dev] [PATCH v2 4/7] net/ice: handle the AdminQ command by DCF

2020-03-09 Thread Haiyue Wang
The DCF (Device Config Function) splits the AdminQ command into two parts: one is the descriptor of AdminQ command, the other is the buffer of AdminQ command (the descriptor has BUF flag set). When both of them are received by the PF, the PF will handle them as one command. And also, the filled de

[dpdk-dev] [PATCH v2 3/7] net/ice: initiate to acquire the DCF capability

2020-03-09 Thread Haiyue Wang
Since the DCF (Device Config Function) controls the flow setting of other VFs by the mailbox with PF, for security, it needs to acquire the DCF capability from PF when starts, and exits to disable it. Signed-off-by: Haiyue Wang --- drivers/net/ice/ice_dcf.c | 28 +++- 1 f

[dpdk-dev] [PATCH v2 0/7] add Intel DCF PMD support

2020-03-09 Thread Haiyue Wang
A DCF (Device Config Function) based approach is proposed where a device bound to the device's VF0 can act as a sole controlling entity to exercise advance functionality (such as switch, ACL) for rest of the VFs. The DCF works as a standalone PMD to support this function, which shares the ice PMD

[dpdk-dev] [PATCH v2 2/7] net/ice: add the DCF hardware initialization

2020-03-09 Thread Haiyue Wang
Introduce the DCF (Device Config Function) feature in the ice PMD, it works as a standalone PMD which doesn't handle the packet Rx/Tx related things. Its hardware entity is the VF. Add the basic DCF hardware initialization, this is specified by devarg 'cap=dcf'. Signed-off-by: Haiyue Wang --- d

[dpdk-dev] [PATCH] lib/librte_net/rte_ether.h:changed RTE_ETHER_MAX_LEN

2020-03-09 Thread Muhammad Ahmad
Change the RTE_ETHER_MAX_LEN from 1518 to 1526 Bugzilla ID: 296 Fixes: c5b2d13 (net: add rte prefix to ether defines) Cc: sta...@dpdk.org Cc: Oliver Matz Reported-by: LAVA Suggested-by: LAVA Signed-off-by: Muhammad Ahmad --- lib/librte_net/rte_ether.h | 2 +- 1 file changed, 1 insertion(+)

Re: [dpdk-dev] [PATCH v1 3/4] net/ice: add the DCF framework

2020-03-09 Thread Ye Xiaolong
On 03/10, Wang, Haiyue wrote: >> >+static int >> >+ice_dcf_dev_filter_ctrl(struct rte_eth_dev *dev, >> >+ enum rte_filter_type filter_type, >> >+ __rte_unused enum rte_filter_op filter_op, >> >+ __rte_unused void *arg) >> >+{ >> >> legacy filte

Re: [dpdk-dev] [PATCH v1 3/4] net/ice: add the DCF framework

2020-03-09 Thread Wang, Haiyue
> -Original Message- > From: Ye, Xiaolong > Sent: Tuesday, March 10, 2020 12:17 > To: Wang, Haiyue > Cc: dev@dpdk.org; Zhang, Qi Z ; Yang, Qiming > ; Xing, > Beilei ; Zhao1, Wei > Subject: Re: [PATCH v1 3/4] net/ice: add the DCF framework > > On 03/09, Haiyue Wang wrote: > >The DCF (De

[dpdk-dev] [PATCH] vhost: make iotlb cache name unique among multi processes

2020-03-09 Thread Itsuro Oda
Currently, iotlb cache name is comprised of vid and virtqueue index. For example, "iotlb_cache_0_0". Because vid is assigned per process, iotlb cache name is not unique among multi processes. For example a secondary process uses a vhost (ex. eth_vhost0,iface=/tmp/sock0) and another secondary proces

Re: [dpdk-dev] [PATCH v1 1/4] net/iavf: stop the PCI probe in DCF mode

2020-03-09 Thread Wang, Haiyue
> -Original Message- > From: Ye, Xiaolong > Sent: Tuesday, March 10, 2020 11:38 > To: Wang, Haiyue > Cc: dev@dpdk.org; Zhang, Qi Z ; Yang, Qiming > ; Xing, > Beilei ; Zhao1, Wei > Subject: Re: [PATCH v1 1/4] net/iavf: stop the PCI probe in DCF mode > > On 03/10, Wang, Haiyue wrote: > >

Re: [dpdk-dev] [PATCH v1 3/4] net/ice: add the DCF framework

2020-03-09 Thread Ye Xiaolong
On 03/09, Haiyue Wang wrote: >The DCF (Device Config Function) feature works as a standalone PMD, its >hardware entity is the trusted VF with ID 0, and the software function >is to control the flow setting of other VFs by the mailbox with PF. > >It doesn't handle packet Rx/Tx related things. This P

Re: [dpdk-dev] [PATCH v1 1/4] net/iavf: stop the PCI probe in DCF mode

2020-03-09 Thread Ye Xiaolong
On 03/10, Wang, Haiyue wrote: >> -Original Message- >> From: Ye, Xiaolong >> Sent: Monday, March 9, 2020 23:38 >> To: Wang, Haiyue >> Cc: dev@dpdk.org; Zhang, Qi Z ; Yang, Qiming >> ; Xing, >> Beilei ; Zhao1, Wei >> Subject: Re: [PATCH v1 1/4] net/iavf: stop the PCI probe in DCF mode >>

[dpdk-dev] [PATCH] net/ixgbe: fix setting VF MAC address

2020-03-09 Thread Guinan Sun
This problem occurs because clear_rar is executed at the wrong time, so PF cannot receive data normally. This patch is used to modify the calling logic of clear_rar. Fixes: 3c4270187518 ("net/ixgbe: support VF MAC address add/remove") Cc: sta...@dpdk.org Signed-off-by: Guinan Sun --- drivers/n

Re: [dpdk-dev] dev Digest, Vol 288, Issue 27

2020-03-09 Thread Zhang, XiX
[PATCH] vfio: map contiguous areas in one go Test-by : xix.zh...@intel.com Thanks > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of dev- > requ...@dpdk.org > Sent: February 25, 2020 21:50 > To: dev@dpdk.org > Subject: dev Digest, Vol 288, Issue 27 > > Send dev m

[dpdk-dev] 答复: [PATCH] cycles: add isb before read cntvct_el0

2020-03-09 Thread Linhaifeng
-邮件原件- 发件人: David Marchand [mailto:david.march...@redhat.com] 发送时间: 2020年3月9日 17:19 收件人: Linhaifeng 抄送: dev@dpdk.org; tho...@monjalon.net; Lilijun (Jerry) ; chenchanghu ; xudingke 主题: Re: [dpdk-dev] [PATCH] cycles: add isb before read cntvct_el0 On Mon, Mar 9, 2020 at 10:14 AM Linha

[dpdk-dev] 答复: [PATCH] cycles: add isb before read cntvct_el0

2020-03-09 Thread Linhaifeng
-邮件原件- 发件人: Jerin Jacob [mailto:jerinjac...@gmail.com] 发送时间: 2020年3月9日 23:43 收件人: Linhaifeng 抄送: dev@dpdk.org; tho...@monjalon.net; Lilijun (Jerry) ; chenchanghu ; xudingke 主题: Re: [dpdk-dev] [PATCH] cycles: add isb before read cntvct_el0 On Mon, Mar 9, 2020 at 2:43 PM Linhaifeng w

Re: [dpdk-dev] [PATCH v1 1/4] net/iavf: stop the PCI probe in DCF mode

2020-03-09 Thread Wang, Haiyue
> -Original Message- > From: Ye, Xiaolong > Sent: Monday, March 9, 2020 23:38 > To: Wang, Haiyue > Cc: dev@dpdk.org; Zhang, Qi Z ; Yang, Qiming > ; Xing, > Beilei ; Zhao1, Wei > Subject: Re: [PATCH v1 1/4] net/iavf: stop the PCI probe in DCF mode > > On 03/09, Haiyue Wang wrote: > >A n

Re: [dpdk-dev] [PATCH v1 4/4] doc: add release notes for Intel ice PMD

2020-03-09 Thread Wang, Haiyue
Got it. BR, Haiyue > -Original Message- > From: Ye, Xiaolong > Sent: Monday, March 9, 2020 23:22 > To: Wang, Haiyue > Cc: dev@dpdk.org; Zhang, Qi Z ; Yang, Qiming > ; Xing, > Beilei ; Zhao1, Wei > Subject: Re: [PATCH v1 4/4] doc: add release notes for Intel ice PMD > > Release note d

Re: [dpdk-dev] [PATCH v1 0/4] add Intel DCF PMD support

2020-03-09 Thread Wang, Haiyue
> -Original Message- > From: Kevin Traynor > Sent: Tuesday, March 10, 2020 03:34 > To: Thomas Monjalon ; David Marchand > ; Ye, Xiaolong > > Cc: Wang, Haiyue ; dev ; Zhang, Qi Z > ; Yang, > Qiming ; Xing, Beilei ; Zhao1, > Wei ; > Aaron Conole ; c...@dpdk.org; Yigit, Ferruh > > Subje

[dpdk-dev] [PATCH 2/4] common/iavf: add two opcodes to send the AdminQ command

2020-03-09 Thread Qi Zhang
Add two virtchnl opcodes to send the AdminQ command, one is used to send the descriptor, the other is used to send the buffer payload if the AdminQ command has BUF flag set. Signed-off-by: Haiyue Wang Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/common/iavf/virtchnl.h

[dpdk-dev] [PATCH 0/4] iavf share code update

2020-03-09 Thread Qi Zhang
Main change: update virtual channel to support DCF Qi Zhang (4): common/iavf: update copyright date common/iavf: add two opcodes to send the AdminQ command common/iavf: add support for DCF capability negotiation common/iavf: add support for VSI mapping table drivers/common/iavf/iavf_adm

[dpdk-dev] [PATCH 3/4] common/iavf: add support for DCF capability negotiation

2020-03-09 Thread Qi Zhang
Add DCF capability flag for VF. Add an opcode for disabling DCF capability. Add an virtchnl event code for AVF resetting completion. Signed-off-by: Xiaoyun Li Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/common/iavf/virtchnl.h | 4 1 file changed, 4 insertions(+)

[dpdk-dev] [PATCH 4/4] common/iavf: add support for VSI mapping table

2020-03-09 Thread Qi Zhang
Add an opcode for getting VSI mapping table. Add an virtchnl event code for VF reset done. Signed-off-by: Beilei Xing Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/common/iavf/virtchnl.h | 29 + 1 file changed, 29 insertions(+) diff --git a

[dpdk-dev] [PATCH 1/4] common/iavf: update copyright date

2020-03-09 Thread Qi Zhang
Update copyright date to 2020. Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/common/iavf/iavf_adminq.c | 2 +- drivers/common/iavf/iavf_adminq.h | 2 +- drivers/common/iavf/iavf_adminq_cmd.h | 2 +- drivers/common/iavf/iavf_alloc.h | 2 +- drivers/common/ia

Re: [dpdk-dev] [PATCH v1 0/4] add Intel DCF PMD support

2020-03-09 Thread Kevin Traynor
On 09/03/2020 17:57, Thomas Monjalon wrote: > 09/03/2020 17:20, Ye Xiaolong: >> Hi, David >> >> On 03/09, David Marchand wrote: >>> On Mon, Mar 9, 2020 at 3:22 PM Haiyue Wang wrote: A DCF (Device Config Function) based approach is proposed where a device bound to the device's VF0 ca

Re: [dpdk-dev] [PATCH] lpm6: make IPv6 addresses immutable

2020-03-09 Thread Stephen Hemminger
On Mon, 9 Mar 2020 18:02:21 + "Medvedkin, Vladimir" wrote: > On 09/03/2020 15:52, Stephen Hemminger wrote: > > On Mon, 9 Mar 2020 13:38:53 + > > "Medvedkin, Vladimir" wrote: > > > >> Hi Andrze, > >> > >> Adding const qualifier for bulk lookup leads to compilation problems > >> (see htt

Re: [dpdk-dev] [PATCH] lpm6: make IPv6 addresses immutable

2020-03-09 Thread Stephen Hemminger
On Mon, 9 Mar 2020 18:02:21 + "Medvedkin, Vladimir" wrote: > On 09/03/2020 15:52, Stephen Hemminger wrote: > > On Mon, 9 Mar 2020 13:38:53 + > > "Medvedkin, Vladimir" wrote: > > > >> Hi Andrze, > >> > >> Adding const qualifier for bulk lookup leads to compilation problems > >> (see htt

Re: [dpdk-dev] [PATCH] lpm6: make IPv6 addresses immutable

2020-03-09 Thread Medvedkin, Vladimir
On 09/03/2020 15:52, Stephen Hemminger wrote: On Mon, 9 Mar 2020 13:38:53 + "Medvedkin, Vladimir" wrote: Hi Andrze, Adding const qualifier for bulk lookup leads to compilation problems (see http://c-faq.com/ansi/constmismatch.html) Also I don't think it would be good for usability to ma

Re: [dpdk-dev] [PATCH v1 0/4] add Intel DCF PMD support

2020-03-09 Thread Thomas Monjalon
09/03/2020 17:20, Ye Xiaolong: > Hi, David > > On 03/09, David Marchand wrote: > >On Mon, Mar 9, 2020 at 3:22 PM Haiyue Wang wrote: > >> > >> A DCF (Device Config Function) based approach is proposed where a device > >> bound to the device's VF0 can act as a sole controlling entity to exercise >

Re: [dpdk-dev] Issue with X550 link status

2020-03-09 Thread Kevin Traynor
On 04/03/2020 21:22, Dey, Souvik wrote: Hi Souvik, > Little more information. It looks like the below X550 nic is broken as the > change related to http://patches.dpdk.org/patch/63951/ is not been backported. > The below patch broken the link status for ixgbevf and the fix was done in > the abo

[dpdk-dev] [PATCH] ring: fix unaligned memory access on aarch32

2020-03-09 Thread Phil Yang
The 32-bit arm machine doesn't support unaligned memory access. It will cause a bus error on aarch32 with the custom element size ring. Thread 1 "test" received signal SIGBUS, Bus error. __rte_ring_enqueue_elems_64 (n=1, obj_table=0xf5edfe41, prod_head=0, \ r=0xf5edfb80) at /build/dpdk/build/inclu

[dpdk-dev] [PATCH] contigmem: cleanup properly when load fails

2020-03-09 Thread Jim Harris
If contigmem is not able to allocate all of the requested buffers, it frees whatever buffers were able to be allocated up until that point. But the pointers are not set to NULL in that case. After the load fails, the FreeBSD kernel will immediately call the contigmem unload handler, which tries to

Re: [dpdk-dev] [PATCH 05/16] bus/fslmc: support handle portal alloc failure

2020-03-09 Thread Ferruh Yigit
On 3/9/2020 5:00 PM, Ferruh Yigit wrote: > On 3/2/2020 2:58 PM, Hemant Agrawal wrote: >> Add the error handling on failure. >> >> Signed-off-by: Nipun Gupta >> Signed-off-by: Hemant Agrawal > > > Hi, > > This commit seems doing, > - Fix 'dpaa2_put_qbman_swp()' which previously may reference th

Re: [dpdk-dev] [PATCH 05/16] bus/fslmc: support handle portal alloc failure

2020-03-09 Thread Ferruh Yigit
On 3/2/2020 2:58 PM, Hemant Agrawal wrote: > Add the error handling on failure. > > Signed-off-by: Nipun Gupta > Signed-off-by: Hemant Agrawal Hi, This commit seems doing, - Fix 'dpaa2_put_qbman_swp()' which previously may reference the 'dpio_dev' when it is null, but the function introduced

Re: [dpdk-dev] [dpdk-stable] [PATCH] examples/vmdq: fix RSS configuration

2020-03-09 Thread Ferruh Yigit
On 3/3/2020 9:16 AM, Junyu Jiang wrote: > In order that all queues of pools can receive packets, > add enable-rss argument to change rss configuration. > > Fixes: 6bb97df521aa ("examples/vmdq: new app") > Cc: sta...@dpdk.org > > Signed-off-by: Junyu Jiang Hi Junyu, I was about to ask to docume

Re: [dpdk-dev] [PATCH 1/6] eal: introduce zmm type for AVX 512-bit

2020-03-09 Thread Jerin Jacob
On Mon, Mar 9, 2020 at 6:14 PM Vladimir Medvedkin wrote: > > New data type to manipulate 512 bit AVX values. > > Signed-off-by: Vladimir Medvedkin > --- > lib/librte_eal/common/include/arch/x86/rte_vect.h | 20 > 1 file changed, 20 insertions(+) > > diff --git a/lib/librte_e

Re: [dpdk-dev] [v2] ethdev: add PFCP header to flow API

2020-03-09 Thread Ori Kam
> -Original Message- > From: Xiao Zhang > Sent: Friday, March 6, 2020 8:39 AM > To: dev@dpdk.org > Cc: Ori Kam ; ferruh.yi...@intel.com; Xiao Zhang > > Subject: [v2] ethdev: add PFCP header to flow API > > This patch adds the new flow item RTE_FLOW_ITEM_TYPE_PFCP to flow API to > matc

Re: [dpdk-dev] [PATCH v1 2/4] net/ice: export the DDP definition symbols

2020-03-09 Thread Ye Xiaolong
On 03/09, Haiyue Wang wrote: >A new DCF PMD will be introduced, which runs on Intel VF hardware, and >it is a pure software design to control the advance functionality (such >as switch, ACL) for rest of the VFs. > >The DCF (Device Config Function) feature shares the core functions of >the ICE PMD,

Re: [dpdk-dev] [PATCH v1 0/4] add Intel DCF PMD support

2020-03-09 Thread Ye Xiaolong
Hi, David On 03/09, David Marchand wrote: >On Mon, Mar 9, 2020 at 3:22 PM Haiyue Wang wrote: >> >> A DCF (Device Config Function) based approach is proposed where a device >> bound to the device's VF0 can act as a sole controlling entity to exercise >> advance functionality (such as switch, ACL)

Re: [dpdk-dev] [PATCH] eal/arm64: remove internal macros

2020-03-09 Thread Jerin Jacob
On Mon, Mar 9, 2020 at 3:09 PM David Marchand wrote: > > No need to export dsb and dmb. > EAL memory barriers are the public API. > > %s/\<\(d.b\)\>(\([^()]*\))$/asm volatile("\1 \2" : : : "memory")/ > > Signed-off-by: David Marchand Acked-by: Jerin Jacob > --- > .../common/include/arch/arm/

Re: [dpdk-dev] [dpdk-stable] [PATCH v2 1/2] net/hinic: fix snprintf length

2020-03-09 Thread Ferruh Yigit
On 3/6/2020 12:06 PM, Kevin Traynor wrote: > Correct length and remove unnecessary brackets. > > Fixes: d9ce1917941c ("net/hinic/base: add hardware operation") > Cc: sta...@dpdk.org > > Signed-off-by: Kevin Traynor > > --- > v2: fix typo in commit msg > For series, Reviewed-by: Ferruh Yigit

[dpdk-dev] Coverity scan

2020-03-09 Thread Thomas Monjalon
We have a public Coverity scan triggered by John for the community: https://scan.coverity.com/projects/dpdk-data-plane-development-kit Note there is a tool to help with this task: http://thyrsus.com/gitweb/?p=coverity-submit.git;a=shortlog;h=refs/tags/1.13 I see two issues with th

Re: [dpdk-dev] [PATCH] lpm6: make IPv6 addresses immutable

2020-03-09 Thread Stephen Hemminger
On Mon, 9 Mar 2020 13:38:53 + "Medvedkin, Vladimir" wrote: > Hi Andrze, > > Adding const qualifier for bulk lookup leads to compilation problems > (see http://c-faq.com/ansi/constmismatch.html) > Also I don't think it would be good for usability to make users > explicitly cast to (const ui

Re: [dpdk-dev] [PATCH v7 1/6] lib/eal: implement the family of PMD bit operation APIs

2020-03-09 Thread Stephen Hemminger
On Mon, 9 Mar 2020 17:54:05 +0800 Joyce Kong wrote: > /** > + * @warning > + * @b EXPERIMENTAL: this API may change, or be removed, without prior notice > + * > + * Return the original bit from a 64-bit value, then clear it to 0 without > + * memory ordering. > + * > + * @param nr > + * The ta

Re: [dpdk-dev] [PATCH v2] mbuf: replace zero-length marker with unnamed union

2020-03-09 Thread Stephen Hemminger
On Mon, 9 Mar 2020 08:55:05 + Ferruh Yigit wrote: > On 3/7/2020 3:56 PM, Gavin Hu wrote: > > Declaring zero-length arrays in other contexts, including as interior > > members of structure objects or as non-member objects, is discouraged. > > Accessing elements of zero-length arrays declared i

Re: [dpdk-dev] [PATCH 04/28] net/ice/base: read PSM clock frequency from register

2020-03-09 Thread Kevin Traynor
On 09/03/2020 11:43, Qi Zhang wrote: > Read the GLGEN_CLKSTAT_SRC register to determine which PSM clock > frequency is selected. This ensures that the rate limiter profile > calculations will be correct. > This seems to be a fix whereby a default and possibly incorrect frequency was used previou

Re: [dpdk-dev] [PATCH] cycles: add isb before read cntvct_el0

2020-03-09 Thread Jerin Jacob
On Mon, Mar 9, 2020 at 2:43 PM Linhaifeng wrote: > > We nead isb rather than dsb to sync system counter to cntvct_el0. # Currently rte_rdtsc() does not have dsb. Right? or any barriers. # Why do you need it? If it regarding, getting accurate value then use rte_rdtsc_precise(). > > Signed-off-by:

Re: [dpdk-dev] [PATCH v1 1/4] net/iavf: stop the PCI probe in DCF mode

2020-03-09 Thread Ye Xiaolong
On 03/09, Haiyue Wang wrote: >A new DCF PMD will be introduced, which runs on Intel VF hardware, and >it is a pure software design to control the advance functionality (such >as switch, ACL) for rest of the VFs. > >So if the DCF (Device Config Function) mode is specified by the devarg >'cap=dcf', t

Re: [dpdk-dev] [PATCH v1 0/4] add Intel DCF PMD support

2020-03-09 Thread David Marchand
On Mon, Mar 9, 2020 at 3:22 PM Haiyue Wang wrote: > > A DCF (Device Config Function) based approach is proposed where a device > bound to the device's VF0 can act as a sole controlling entity to exercise > advance functionality (such as switch, ACL) for rest of the VFs. > > The DCF works as a stan

Re: [dpdk-dev] [PATCH v2 3/7] vfio/pci: Introduce VF token

2020-03-09 Thread Alex Williamson
On Mon, 9 Mar 2020 01:33:48 + "Tian, Kevin" wrote: > > From: Tian, Kevin > > Sent: Monday, March 9, 2020 9:22 AM > > > > > From: Alex Williamson > > > Sent: Monday, March 9, 2020 8:46 AM > > > > > > On Sat, 7 Mar 2020 01:04:41 + > > > "Tian, Kevin" wrote: > > > > > > > > From: Alex

Re: [dpdk-dev] [PATCH] mem: mark pages as not accessed when reserving VA

2020-03-09 Thread Maxime Coquelin
On 3/9/20 3:54 PM, David Marchand wrote: > When the memory allocator reserves virtual addresses, it still does not > know what they will be used for. > Besides, huge areas are reserved for memory hotplug in multiprocess > setups. But most of the pages are unused in the whole life of the > proces

Re: [dpdk-dev] [PATCH v1 4/4] doc: add release notes for Intel ice PMD

2020-03-09 Thread Ye Xiaolong
Release note doesn't have to be a separate patch, can go with the feature patch. Thanks, Xiaolong On 03/09, Haiyue Wang wrote: >Add release notes for the new Intel ice feature DCF (Device Config >Function). > >Signed-off-by: Haiyue Wang >--- > doc/guides/rel_notes/release_20_05.rst | 5 + >

Re: [dpdk-dev] [PATCH v2 5/7] vfio/pci: Add sriov_configure support

2020-03-09 Thread Alex Williamson
On Mon, 9 Mar 2020 01:48:11 + "Tian, Kevin" wrote: > > From: Alex Williamson > > Sent: Monday, March 9, 2020 8:46 AM > > > > On Sat, 7 Mar 2020 01:35:23 + > > "Tian, Kevin" wrote: > > > > > > From: Alex Williamson > > > > Sent: Saturday, March 7, 2020 6:18 AM > > > > > > > > On Fri,

[dpdk-dev] [PATCH] mem: mark pages as not accessed when reserving VA

2020-03-09 Thread David Marchand
When the memory allocator reserves virtual addresses, it still does not know what they will be used for. Besides, huge areas are reserved for memory hotplug in multiprocess setups. But most of the pages are unused in the whole life of the processes. Change protection mode to PROT_NONE when only re

Re: [dpdk-dev] [PATCH v2] mbuf: replace zero-length markerwith unnamed union

2020-03-09 Thread Morten Brørup
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Richardson, Bruce > Sent: Monday, March 9, 2020 3:16 PM > > From: dev On Behalf Of Morten Brørup > > Sent: Monday, March 9, 2020 1:31 PM > > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ferruh Yigit > > > Sent: Monday, March 9, 2020

Re: [dpdk-dev] [PATCH v2 0/7] vfio/pci: SR-IOV support

2020-03-09 Thread Alex Williamson
On Mon, 9 Mar 2020 11:36:46 +0800 Jason Wang wrote: > On 2020/3/7 上午12:24, Alex Williamson wrote: > > On Fri, 6 Mar 2020 11:35:21 +0800 > > Jason Wang wrote: > > > >> On 2020/3/6 上午1:14, Alex Williamson wrote: > >>> On Tue, 25 Feb 2020 14:09:07 +0800 > >>> Jason Wang wrote: > >>> > >>>

Re: [dpdk-dev] [PATCH 2/2] net/memif: fix init handling when already connected

2020-03-09 Thread Ferruh Yigit
On 2/19/2020 1:06 PM, Jakub Grajciar -X (jgrajcia - PANTHEON TECH SRO at Cisco) wrote: >> -Original Message- >> From: Július Milan >> Sent: Wednesday, February 19, 2020 9:19 AM >> To: dev@dpdk.org; Jakub Grajciar -X (jgrajcia - PANTHEON TECH SRO at Cisco) >> >> Subject: [dpdk-dev][PATCH 2

Re: [dpdk-dev] [PATCH] doc: document memif loopback feature

2020-03-09 Thread Ferruh Yigit
On 3/9/2020 12:12 PM, Július Milan wrote: > Shows the example of how to connect 2 memif ports into loopback and test > the communication. > > Signed-off-by: Július Milan Squashed into relevant commit [1] in next-net, thanks. [1] [v3,1/2] net/memif: enable loopback https://patches.dpdk.org/patch

Re: [dpdk-dev] [PATCH v3 1/2] net/memif: enable loopback

2020-03-09 Thread Ferruh Yigit
On 3/9/2020 2:22 PM, Július Milan wrote: > With this patch it is possible to connect 2 DPDK memifs into loopback, > i.e. when they have the same id and different roles, as for example: > "--vdev=net_memif0,role=master,id=0" > "--vdev=net_memif1,role=slave,id=0" > > Signed-off-by: Július Milan

[dpdk-dev] [PATCH v1 4/4] doc: add release notes for Intel ice PMD

2020-03-09 Thread Haiyue Wang
Add release notes for the new Intel ice feature DCF (Device Config Function). Signed-off-by: Haiyue Wang --- doc/guides/rel_notes/release_20_05.rst | 5 + 1 file changed, 5 insertions(+) diff --git a/doc/guides/rel_notes/release_20_05.rst b/doc/guides/rel_notes/release_20_05.rst index 000b

[dpdk-dev] [PATCH v1 3/4] net/ice: add the DCF framework

2020-03-09 Thread Haiyue Wang
The DCF (Device Config Function) feature works as a standalone PMD, its hardware entity is the trusted VF with ID 0, and the software function is to control the flow setting of other VFs by the mailbox with PF. It doesn't handle packet Rx/Tx related things. This PMD needs the iAVF virtchnl to send

[dpdk-dev] [PATCH v1 2/4] net/ice: export the DDP definition symbols

2020-03-09 Thread Haiyue Wang
A new DCF PMD will be introduced, which runs on Intel VF hardware, and it is a pure software design to control the advance functionality (such as switch, ACL) for rest of the VFs. The DCF (Device Config Function) feature shares the core functions of the ICE PMD, like it needs to export the DDP def

[dpdk-dev] [PATCH v1 1/4] net/iavf: stop the PCI probe in DCF mode

2020-03-09 Thread Haiyue Wang
A new DCF PMD will be introduced, which runs on Intel VF hardware, and it is a pure software design to control the advance functionality (such as switch, ACL) for rest of the VFs. So if the DCF (Device Config Function) mode is specified by the devarg 'cap=dcf', then it will stop the PCI probe in t

[dpdk-dev] [PATCH v1 0/4] add Intel DCF PMD support

2020-03-09 Thread Haiyue Wang
A DCF (Device Config Function) based approach is proposed where a device bound to the device's VF0 can act as a sole controlling entity to exercise advance functionality (such as switch, ACL) for rest of the VFs. The DCF works as a standalone PMD to support this function, which shares the ice PMD

Re: [dpdk-dev] [PATCH v2] mbuf: replace zero-length marker with unnamed union

2020-03-09 Thread Richardson, Bruce
> -Original Message- > From: dev On Behalf Of Morten Brørup > Sent: Monday, March 9, 2020 1:31 PM > To: Yigit, Ferruh ; Gavin Hu ; > dev@dpdk.org > Cc: nd ; david.march...@redhat.com; tho...@monjalon.net; > ktray...@redhat.com; jer...@marvell.com; Honnappa Nagarahalli > ; Ruifeng Wang ;

Re: [dpdk-dev] [PATCH] lpm6: make IPv6 addresses immutable

2020-03-09 Thread Medvedkin, Vladimir
Hi Andrze, Adding const qualifier for bulk lookup leads to compilation problems (see http://c-faq.com/ansi/constmismatch.html) Also I don't think it would be good for usability to make users explicitly cast to (const uint8_t **) when passing 'ips' argument. I'd suggest leaving lookup_bulk as i

Re: [dpdk-dev] [PATCH v2] mbuf: replace zero-length marker with unnamed union

2020-03-09 Thread Morten Brørup
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ferruh Yigit > Sent: Monday, March 9, 2020 12:30 PM > > On 3/9/2020 9:45 AM, Gavin Hu wrote: > > Hi Ferruh, > > > >> -Original Message- > >> From: Ferruh Yigit > >> Sent: Monday, March 9, 2020 4:55 PM > >> > >> On 3/7/2020 3:56 PM, Ga

Re: [dpdk-dev] [PATCH] eal/arm64: remove internal macros

2020-03-09 Thread Gavin Hu
Reviewed-by: Gavin Hu

Re: [dpdk-dev] [PATCH dpdk-dev v3] mempool: sort the rte_mempool_ops by name

2020-03-09 Thread David Marchand
On Mon, Mar 9, 2020 at 9:56 AM Tonghao Zhang wrote: > On Mon, Mar 9, 2020 at 4:27 PM Olivier Matz wrote: > > The fact that the ops index changes during mempool driver lifetime is > > indeed frightening, especially knowning that this is a dynamic > > registration that could happen at any moment in

[dpdk-dev] [PATCH] net/mlx5: fix zero value check for set tag action

2020-03-09 Thread Wisam Jaddo
If we allow to have data and mask <0x0> we might hit a zero data value that will not do any effect Fixes: e554b672aa05 ("net/mlx5: support flow tag") Cc: viachesl...@mellanox.com Cc: sta...@dpdk.org Signed-off-by: Wisam Jaddo --- drivers/net/mlx5/mlx5_flow_dv.c | 4 1 file changed, 4 inse

[dpdk-dev] [PATCH] ipsec: use hash lookup with hash sigs in sad lookup

2020-03-09 Thread Vladimir Medvedkin
Change hash function from jhash to crc. Precalculate hash signatures for a bulk of keys and then use rte_hash_lookup_with_hash_bulk_data() to speed up sad lookup Signed-off-by: Vladimir Medvedkin --- This patch depends on https://patches.dpdk.org/patch/66460/ lib/librte_ipsec/ipsec_sad.c | 38 +

[dpdk-dev] [PATCH 1/2] hash: add hash bulk lookup with hash signatures array

2020-03-09 Thread Vladimir Medvedkin
Implement rte_hash_lookup_with_hash_bulk_data() - lookup function with precomputed hash signatures. Signed-off-by: Vladimir Medvedkin --- lib/librte_hash/rte_cuckoo_hash.c| 402 +++ lib/librte_hash/rte_hash.h | 27 +++ lib/librte_hash/rte_hash_versi

[dpdk-dev] [PATCH 6/6] app/testfib: add support for different lookup functions

2020-03-09 Thread Vladimir Medvedkin
Added -v option to switch between different lookup implementations to measure their performance and correctness. Signed-off-by: Vladimir Medvedkin --- app/test-fib/main.c | 58 ++--- 1 file changed, 55 insertions(+), 3 deletions(-) diff --git a/ap

[dpdk-dev] [PATCH 2/2] test: update hash performance tests

2020-03-09 Thread Vladimir Medvedkin
Add preformance test for rte_hash_lookup_with_hash_bulk_data() Signed-off-by: Vladimir Medvedkin --- app/test/test_hash_perf.c | 45 - 1 file changed, 40 insertions(+), 5 deletions(-) diff --git a/app/test/test_hash_perf.c b/app/test/test_hash_perf.c

[dpdk-dev] [PATCH 5/6] fib6: introduce AVX512 lookup

2020-03-09 Thread Vladimir Medvedkin
Add new lookup implementation for FIB6 trie algorithm using AVX512 instruction set Signed-off-by: Vladimir Medvedkin --- lib/librte_fib/rte_fib6.h| 3 +- lib/librte_fib/trie.c| 58 +++ lib/librte_fib/trie_avx512.h | 231 +++ 3 files

[dpdk-dev] [PATCH 3/6] fib: introduce AVX512 lookup

2020-03-09 Thread Vladimir Medvedkin
Add new lookup implementation for DIR24_8 algorithm using AVX512 instruction set Signed-off-by: Vladimir Medvedkin --- lib/librte_fib/dir24_8.c| 71 lib/librte_fib/dir24_8_avx512.h | 116 lib/librte_fib/rte_fib.h|

[dpdk-dev] [PATCH 0/6] fib: implement AVX512 vector lookup

2020-03-09 Thread Vladimir Medvedkin
This patch series implements vectorized lookup using AVX512 for ipv4 dir24_8 and ipv6 trie algorithms. Also introduced rte_fib_set_lookup_fn() to change lookup function type. Added option to select lookup function type in testfib application. Vladimir Medvedkin (6): eal: introduce zmm type for A

[dpdk-dev] [PATCH 2/6] fib: make lookup function type configurable

2020-03-09 Thread Vladimir Medvedkin
Add type argument to dir24_8_get_lookup_fn() Now it supports 3 different lookup implementations: RTE_FIB_DIR24_8_SCALAR_MACRO RTE_FIB_DIR24_8_SCALAR_INLINE RTE_FIB_DIR24_8_SCALAR_UNI Add new rte_fib_set_lookup_fn() - user can change lookup function type runtime. Signed-off-by: Vladimir Medvedk

[dpdk-dev] [PATCH 4/6] fib6: make lookup function type configurable

2020-03-09 Thread Vladimir Medvedkin
Add type argument to trie_get_lookup_fn() Now it only supports RTE_FIB6_TRIE_SCALAR Add new rte_fib6_set_lookup_fn() - user can change lookup function type runtime. Signed-off-by: Vladimir Medvedkin --- lib/librte_fib/rte_fib6.c | 19 ++- lib/librte_fib/rte_fib6.h

[dpdk-dev] [PATCH 1/6] eal: introduce zmm type for AVX 512-bit

2020-03-09 Thread Vladimir Medvedkin
New data type to manipulate 512 bit AVX values. Signed-off-by: Vladimir Medvedkin --- lib/librte_eal/common/include/arch/x86/rte_vect.h | 20 1 file changed, 20 insertions(+) diff --git a/lib/librte_eal/common/include/arch/x86/rte_vect.h b/lib/librte_eal/common/include/arc

[dpdk-dev] [PATCH 3/4] app/testfib: get rid of libresolv dependency

2020-03-09 Thread Vladimir Medvedkin
Get rid of using inet_net_pton(). Implement it internally in the app. Signed-off-by: Vladimir Medvedkin --- app/test-fib/Makefile | 2 -- app/test-fib/main.c | 85 +-- 2 files changed, 41 insertions(+), 46 deletions(-) diff --git a/app/test-fib

[dpdk-dev] [PATCH 4/4] app: enable test-fib application

2020-03-09 Thread Vladimir Medvedkin
Build test-fib application Signed-off-by: Vladimir Medvedkin --- app/Makefile| 1 + app/meson.build | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/app/Makefile b/app/Makefile index db9d2d5..9fd62fb 100644 --- a/app/Makefile +++ b/app/Makefile @@ -11,6 +11,7 @@ DIRS-$(

[dpdk-dev] [PATCH 2/4] app/testfib: fix format string

2020-03-09 Thread Vladimir Medvedkin
Change format for uint64_t to to %"PRIu64" to make compiller happy Fixes: 103809d032cd ("app/test-fib: add test application for FIB") Cc: vladimir.medved...@intel.com Signed-off-by: Vladimir Medvedkin --- app/test-fib/main.c | 22 -- 1 file changed, 12 insertions(+), 10 dele

[dpdk-dev] [PATCH 1/4] app/testfib: fix possible uninitialized warning

2020-03-09 Thread Vladimir Medvedkin
Compiller can throw warning message for routes and lookup files. Fixes: 103809d032cd ("app/test-fib: add test application for FIB") Cc: vladimir.medved...@intel.com Signed-off-by: Vladimir Medvedkin --- app/test-fib/main.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff

[dpdk-dev] [PATCH 0/4] app/testfib: testfib app various fixes

2020-03-09 Thread Vladimir Medvedkin
This patch series fixes compillation problems for some platforms. Also it enables testfib app build with other applications. Vladimir Medvedkin (4): app/testfib: fix possible uninitialized warning app/testfib: fix format string app/testfib: get rid of libresolv dependency app: enable test-

[dpdk-dev] [PATCH v3 1/2] net/memif: enable loopback

2020-03-09 Thread Július Milan
With this patch it is possible to connect 2 DPDK memifs into loopback, i.e. when they have the same id and different roles, as for example: "--vdev=net_memif0,role=master,id=0" "--vdev=net_memif1,role=slave,id=0" Signed-off-by: Július Milan --- v2: changed log format string of size (type size

[dpdk-dev] [PATCH v2] net/ice: remove redundant code

2020-03-09 Thread Qi Zhang
Remove function ice_clear_queues, since all equivalent code has already be executed durring ice_rx|tx_queue_stop. Also function ice_rx|tx_queue_release_mbufs simpley wrapped a function pointer call which is not necessary, remove them. Signed-off-by: Qi Zhang --- v2: - function declare in ice_rxt

[dpdk-dev] [PATCH 26/28] net/ice/base: update copyright date

2020-03-09 Thread Qi Zhang
Update copyright date to 2020. Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_adminq_cmd.h| 2 +- drivers/net/ice/base/ice_alloc.h | 2 +- drivers/net/ice/base/ice_bitops.h| 2 +- drivers/net/ice/base/ice_common.c| 2 +- drive

[dpdk-dev] [PATCH 27/28] net/ice/base: add the hook to send AdminQ command

2020-03-09 Thread Qi Zhang
Add the hook to send the PF's AdminQ command in another path, like not directly to the firmware. If the AdminQ command is sent through the hook path, it needs to save the AQ error codes from firmware as the last status for admin control queue, so that the AdminQ command function can use it to do e

[dpdk-dev] [PATCH 28/28] net/ice/base: don't access some hardware registers in DCF

2020-03-09 Thread Qi Zhang
DCF runs as a VF so it can't access PF registers. And export the filter management list static functions as public for make DCF initialization. Signed-off-by: Haiyue Wang Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_common.c| 7 +-- drivers/ne

[dpdk-dev] [PATCH 25/28] net/ice/base: add ACL module

2020-03-09 Thread Qi Zhang
Add all ACL related code. Signed-off-by: Real Valiquette Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/Makefile |2 + drivers/net/ice/base/ice_acl.c| 629 + drivers/net/ice/base/ice_acl.h| 206 ++ drivers/n

[dpdk-dev] [PATCH 22/28] net/ice/base: couple casting issue fixes

2020-03-09 Thread Qi Zhang
Adjust variable size between u8 and u16 to fix casting issues Also fix couple coding style issues Karol Kolacinski Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_adminq_cmd.h | 9 drivers/net/ice/base/ice_common.c | 4 ++-- drivers/net/ic

[dpdk-dev] [PATCH 20/28] net/ice/base: add macro specifying max NVM offset

2020-03-09 Thread Qi Zhang
The ice_aq_read_nvm function uses a somewhat weird construction for verifying that the incoming offset is valid. Replace this construction with a simple greater-than expression, and define the maximum value (24bits) in the ice_adminq_cmd.h By providing a macro, the check becomes more clear. Additi

[dpdk-dev] [PATCH 21/28] net/ice/base: implement new sr read functions

2020-03-09 Thread Qi Zhang
Remove the ice_read_sr_aq function and implement ice_read_sr_word_aq directly in terms of the new ice_read_flat_nvm function. This simplifies the code by reducing a now unnecessary reading function. Signed-off-by: Jacob Keller Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- driv

[dpdk-dev] [PATCH 24/28] net/ice/base: store NVM version info in extracted format

2020-03-09 Thread Qi Zhang
Currently the NVM and Option ROM version information is stored in a minimal format. The ice_get_nvm_version function exists to extract this information for display. This needlessly complicates using these fields as the extraction function must be called to parse the NVM and Option ROM data. Furthe

[dpdk-dev] [PATCH 23/28] net/ice/base: support PHY persistent feature

2020-03-09 Thread Qi Zhang
In this patch, we will modify the ice_copy_phy_caps_to_cfg(...) function to conditionally fill up the ice_aqc_set_phy_cfg_data.module_compliance_enforcement with correct value, based on the PHY persistent feature. Apply the ice_copy_phy_caps_to_cfg() function inside ice_set_fc() Signed-off-by: Ch

[dpdk-dev] [PATCH 19/28] net/ice/base: xtract logic of flat NVM read to function

2020-03-09 Thread Qi Zhang
The ice_read_sr_buf_aq function implements logic to correctly break apart NVM reads into 4Kb chunks. Additionally, it ensures that each read never crosses a Shadow RAM sector boundary. This logic is useful when reading the flat NVM as a byte-addressable stream. Extract that logic in terms of bytes

[dpdk-dev] [PATCH 15/28] net/ice/base: capitalize abbreviations

2020-03-09 Thread Qi Zhang
Fix abbreviations as found by abbrevcheck Signed-off-by: Tony Nguyen Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_dcb.c | 8 +++--- drivers/net/ice/base/ice_fdir.c | 6 ++--- drivers/net/ice/base/ice_flex_pipe.c | 52 ++---

[dpdk-dev] [PATCH 17/28] net/ice/base: add shared driver parameter command

2020-03-09 Thread Qi Zhang
Adds the Driver Shared Parameters (0x0C90) AQ command. Signed-off-by: Lev Faerman Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_adminq_cmd.h | 17 + 1 file changed, 17 insertions(+) diff --git a/drivers/net/ice/base/ice_adminq_cmd.h b

  1   2   >