Re: [dpdk-dev] [PATCH] net/virtio-user: do not reset virtqueues for split ring

2020-02-04 Thread Maxime Coquelin
On 2/5/20 3:11 AM, Tiwei Bie wrote: > Add missing braces to avoid resetting virtqueues unconditionally > during reconnection. > > Fixes: 6ebbf4109f35 ("net/virtio-user: fix packed ring server mode") > > Signed-off-by: Tiwei Bie > --- > Cc: Xuan Ding > > drivers/net/virtio/virtio_user_ethde

Re: [dpdk-dev] [PATCH] net/mlx5: fix use of uninitialized array

2020-02-04 Thread Slava Ovsiienko
Very nice, Dekel, we found the root cause of the failure. Acked-by: Viacheslav Ovsiienko > -Original Message- > From: Dekel Peled > Sent: Wednesday, February 5, 2020 8:42 > To: Matan Azrad ; Slava Ovsiienko > ; Raslan Darawsheh > Cc: dev@dpdk.org; Bing Zhao > Subject: [PATCH] net/mlx5

[dpdk-dev] [PATCH] net/mlx5: fix use of uninitialized array

2020-02-04 Thread Dekel Peled
Previous patch changed the format of struct mlx5_flow_dv_modify_hdr_resource, to use a flexible array for modification actions. In __flow_dv_translate() a union was defined with item of this struct, and an array of maximal possible size. Aray elements are filled in several functions. In function fl

Re: [dpdk-dev] [EXT] Re: [PATCH v2 4/4] add ABI checks

2020-02-04 Thread Anoob Joseph
Hi Akhil, Neil, Fiona Sorry for the late response. I want to propose a new change in line with what you folks had proposed. May be we can treat the new features EXPERIMENTAL until a new stable release. enum rte_crypto_aead_algorithm { RTE_CRYPTO_AEAD_AES_CCM = 1, /**< AES algo

Re: [dpdk-dev] [EXTERNAL] [PATCH 0/6] MinGW-w64 support

2020-02-04 Thread Dmitry Kozlyuk
Hi Narcisa, > I'm having some trouble with cross-compilation: > > python3 meson.py -Dexamples=helloworld ../../dpdk/build ../../dpdk > --cross-file ../../dpdk/meson_mingw.txt > The Meson build system > Version: 0.53.1 > Source dir: /mnt/d/dpdk > Build dir: /mnt/d/dpdk/build > Build type: cross b

Re: [dpdk-dev] [PATCH] rte_vhost: do not treat empty socket message as error

2020-02-04 Thread Tiwei Bie
[PATCH] rte_vhost: do not treat empty socket message as error s/rte_vhost:/vhost:/ On Thu, Jan 30, 2020 at 09:05:39AM +0100, Vitaliy Mysak wrote: > According to recvmsg() specification, 0 is a valid > return code when client is disconnecting. > Therefore, it should not be reported as error, unl

Re: [dpdk-dev] [PATCH] vhost: add event areas to vq_is_ready()

2020-02-04 Thread Tiwei Bie
On Sat, Jan 25, 2020 at 09:52:16AM +0100, Adrian Moreno wrote: > Consider a virtqueue ready when, apart from the the descriptor area, s/the the/the/ > both event supression areas have been mapped. s/supression/suppression/ > > Fixes: 2d1541e2b6b3 ("vhost: add vring address setup for packed que

Re: [dpdk-dev] [PATCH] net/virtio-user: do not reset virtqueues for split ring

2020-02-04 Thread Ding, Xuan
Hi Tiwei, Corrected on my local, thank you for your fix in advance. Regards, Xuan Ding > -Original Message- > From: Bie, Tiwei > Sent: Wednesday, February 5, 2020 10:11 AM > To: dev@dpdk.org; maxime.coque...@redhat.com; Wang, Zhihong > > Cc: Ding, Xuan > Subject: [PATCH] net/virtio-us

Re: [dpdk-dev] [PATCH 6/6] doc: guide for Windows build using MinGW-w64

2020-02-04 Thread Thomas Monjalon
05/02/2020 00:57, Dmitry Kozlyuk: > > I think having the choice between GCC and Clang for Windows is very cool. > > > > When starting the Windows port, I asked the fundamental question of the > > supported compilers. The answer was MinGW adds "non-standard" DLLs: > > https://mails.dpdk.org/arc

[dpdk-dev] [PATCH] net/virtio-user: do not reset virtqueues for split ring

2020-02-04 Thread Tiwei Bie
Add missing braces to avoid resetting virtqueues unconditionally during reconnection. Fixes: 6ebbf4109f35 ("net/virtio-user: fix packed ring server mode") Signed-off-by: Tiwei Bie --- Cc: Xuan Ding drivers/net/virtio/virtio_user_ethdev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

Re: [dpdk-dev] Windows Support Plan

2020-02-04 Thread Thomas Monjalon
02/02/2020 21:37, Dmitry Kozliuk: > Where do I find a high-level plan of comprehensive Windows support: design > decisions, implementation order, etc? Please help documenting design decisions in the DPDK doc. For implementation order, we'll discuss it soon together. > Information on the subject i

Re: [dpdk-dev] [PATCH 4/6] build: MinGW-w64 support for Meson

2020-02-04 Thread Thomas Monjalon
05/02/2020 00:21, Dmitry Kozlyuk: > > I really like this patch. > > So both GCC (with MinGW) and native clang are supported? > > Thanks. Yes, I tested both toolchains. > > > [...] > > > +# MS linker requires special treatment. > > > +# FIXME: use cc.get_linker_id() after upgrading to Meson >=0.53

Re: [dpdk-dev] [PATCH 6/6] doc: guide for Windows build using MinGW-w64

2020-02-04 Thread Dmitry Kozlyuk
> I think having the choice between GCC and Clang for Windows is very cool. > > When starting the Windows port, I asked the fundamental question of the > supported compilers. The answer was MinGW adds "non-standard" DLLs: > https://mails.dpdk.org/archives/dev/2019-January/124236.html Indeed

Re: [dpdk-dev] [PATCH 5/6] build: add cross-file for MinGW-w64

2020-02-04 Thread Dmitry Kozlyuk
> > --- /dev/null > > +++ b/meson_mingw.txt > > I think this file should be in config/x86/ OK, will fix in v2. -- Dmitry Kozlyuk

Re: [dpdk-dev] [PATCH 4/6] build: MinGW-w64 support for Meson

2020-02-04 Thread Dmitry Kozlyuk
> I really like this patch. > So both GCC (with MinGW) and native clang are supported? Thanks. Yes, I tested both toolchains. > [...] > > +# MS linker requires special treatment. > > +# FIXME: use cc.get_linker_id() after upgrading to Meson >=0.53. > > What does it mean? It won't work with mes

Re: [dpdk-dev] [RFC PATCH 0/7] vfio/pci: SR-IOV support

2020-02-04 Thread Alex Williamson
Promised example QEMU test case... commit 3557c63bcb286c71f3f7242cad632edd9e297d26 Author: Alex Williamson Date: Tue Feb 4 13:47:41 2020 -0700 vfio-pci: QEMU support for vfio-pci VF tokens Example support for using a vf_token to gain access to a device as well as using the V

Re: [dpdk-dev] How to compile and run l2fwd/l3fwd on DPDK windows?

2020-02-04 Thread William Tu
On Tue, Feb 4, 2020 at 1:46 PM Pallavi Kadam wrote: > > Hi William, > > On 2/4/2020 1:25 PM, William Tu wrote: > > Hi, > > I'm able to follow the doc to run helloworld example > https://doc.dpdk.org/guides/windows_gsg/build_dpdk.html#build-the-code > > I'm thinking about running l2fwd on my x710 c

Re: [dpdk-dev] How to compile and run l2fwd/l3fwd on DPDK windows?

2020-02-04 Thread William Tu
On Tue, Feb 4, 2020 at 1:47 PM Thomas Monjalon wrote: > > 04/02/2020 22:25, William Tu: > > Hi, > > > > I'm able to follow the doc to run helloworld example > > https://doc.dpdk.org/guides/windows_gsg/build_dpdk.html#build-the-code > > > > I'm thinking about running l2fwd on my x710 card. > > Is t

Re: [dpdk-dev] [PATCH] eal/windows: refine public interface

2020-02-04 Thread Dmitry Kozlyuk
> I agree bloating rte_os.h is a concern. > If you can achieve the initial goal (no specific include in apps, libs > and drivers) while reducing rte_os.h, I think it is good. would be such a specific include, like in Linux EAL. This file would include Windows platform SDK files in the right orde

[dpdk-dev] [RFC PATCH 6/7] vfio/pci: Remove dev_fmt definition

2020-02-04 Thread Alex Williamson
It currently results in messages like: "vfio-pci :03:00.0: vfio_pci: ..." Which is quite a bit redundant. Signed-off-by: Alex Williamson --- drivers/vfio/pci/vfio_pci.c |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/vfio/pci/vfio_pci.c b/drivers/vfio/pci/vfio_pci.c index 02

[dpdk-dev] [RFC PATCH 4/7] vfio: Introduce VFIO_DEVICE_FEATURE ioctl and first user

2020-02-04 Thread Alex Williamson
The VFIO_DEVICE_FEATURE ioctl is meant to be a general purpose, device agnostic ioctl for setting, retrieving, and probing device features. This implementation provides a 16-bit field for specifying a feature index, where the data porition of the ioctl is determined by the semantics for the given f

[dpdk-dev] [RFC PATCH 5/7] vfio/pci: Add sriov_configure support

2020-02-04 Thread Alex Williamson
With the VF Token interface we can now expect that a vfio userspace driver must be in collaboration with the PF driver, an unwitting userspace driver will not be able to get past the GET_DEVICE_FD step in accessing the device. We can now move on to actually allowing SR-IOV to be enabled by vfio-pc

[dpdk-dev] [RFC PATCH 7/7] vfio/pci: Cleanup .probe() exit paths

2020-02-04 Thread Alex Williamson
The cleanup is getting a tad long. Signed-off-by: Alex Williamson --- drivers/vfio/pci/vfio_pci.c | 54 --- 1 file changed, 25 insertions(+), 29 deletions(-) diff --git a/drivers/vfio/pci/vfio_pci.c b/drivers/vfio/pci/vfio_pci.c index 343fe38ed06b..7274

[dpdk-dev] [RFC PATCH 3/7] vfio/pci: Introduce VF token

2020-02-04 Thread Alex Williamson
If we enable SR-IOV on a vfio-pci owned PF, the resulting VFs are not fully isolated from the PF. The PF can always cause a denial of service to the VF, if not access data passed through the VF directly. This is why vfio-pci currently does not bind to PFs with SR-IOV enabled and does not provide a

[dpdk-dev] [RFC PATCH 0/7] vfio/pci: SR-IOV support

2020-02-04 Thread Alex Williamson
There seems to be an ongoing desire to use userspace, vfio-based drivers for both SR-IOV PF and VF devices. The fundamental issue with this concept is that the VF is not fully independent of the PF driver. Minimally the PF driver might be able to deny service to the VF, VF data paths might be dep

[dpdk-dev] [RFC PATCH 2/7] vfio/pci: Implement match ops

2020-02-04 Thread Alex Williamson
This currently serves the same purpose as the default implementation but will be expanded for additional functionality. Signed-off-by: Alex Williamson --- drivers/vfio/pci/vfio_pci.c |8 1 file changed, 8 insertions(+) diff --git a/drivers/vfio/pci/vfio_pci.c b/drivers/vfio/pci/vfi

[dpdk-dev] [RFC PATCH 1/7] vfio: Include optional device match in vfio_device_ops callbacks

2020-02-04 Thread Alex Williamson
Allow bus drivers to provide their own callback to match a device to the user provided string. Signed-off-by: Alex Williamson --- drivers/vfio/vfio.c | 19 +++ include/linux/vfio.h |3 +++ 2 files changed, 18 insertions(+), 4 deletions(-) diff --git a/drivers/vfio/vfio.c

Re: [dpdk-dev] [PATCH 6/6] doc: guide for Windows build using MinGW-w64

2020-02-04 Thread Thomas Monjalon
31/01/2020 04:07, Dmitry Kozlyuk: > Instructions for different toolchains presented as options on the > corresponging steps of the guide, so that common parts may be reused. > > Signed-off-by: Dmitry Kozlyuk [...] > --- a/doc/guides/windows_gsg/build_dpdk.rst > +++ b/doc/guides/windows_gsg/build_

Re: [dpdk-dev] [PATCH 0/4] make vhost PMD available for secondary processes

2020-02-04 Thread Itsuro ODA
Hi Maxime, Thank you for your reply and review. I will make fixes of the patches according to your indication and post them. Thanks. Itsuro Oda On Tue, 4 Feb 2020 18:54:23 +0100 Maxime Coquelin wrote: > Hi Itsuro, > > On 1/20/20 3:17 AM, Itsuro ODA wrote: > > Hi vhost PMD maitainers, > > > >

Re: [dpdk-dev] [PATCH 5/6] build: add cross-file for MinGW-w64

2020-02-04 Thread Thomas Monjalon
31/01/2020 04:07, Dmitry Kozlyuk: > Add Meson configuration to cross-compile for Windows using MinGW-w64. > It may require adjustments in some cases, but at least it provides > the foundation. > > Signed-off-by: Dmitry Kozlyuk > > create mode 100644 meson_mingw.txt > > --- /dev/null > +++ b/me

Re: [dpdk-dev] [PATCH v2 4/4] add ABI checks

2020-02-04 Thread Neil Horman
On Tue, Feb 04, 2020 at 10:32:01AM +, Akhil Goyal wrote: > > > > > 04/02/2020 11:16, Akhil Goyal: > > > Hi, > > > > On 2/3/2020 5:09 PM, Thomas Monjalon wrote: > > > > > 03/02/2020 10:30, Ferruh Yigit: > > > > >> On 2/2/2020 2:41 PM, Ananyev, Konstantin wrote: > > > > >>> 02/02/2020 14:05, Th

Re: [dpdk-dev] [PATCH 4/6] build: MinGW-w64 support for Meson

2020-02-04 Thread Thomas Monjalon
31/01/2020 04:07, Dmitry Kozlyuk: > MinGW-w64 linker does not mimic MS linker options, so the build system > must differentiate between linkers on Windows. Use GNU linker options > with GCC and MS linker options with Clang. > > MinGW-w64 by default uses MSVCRT stdio, which does not comply to ANSI,

Re: [dpdk-dev] [PATCH] eal/windows: refine public interface

2020-02-04 Thread Thomas Monjalon
31/01/2020 06:24, Dmitry Kozlyuk: > The goal of rte_os.h is to mitigate OS differences for EAL users. > In Windows EAL, rte_os.h did excessive things: That's an interesting point of view. The idea of rte_os.h was to hide OS-specifics, so the DPDK applications have no Windows-specific header to inc

Re: [dpdk-dev] [PATCH v2 4/4] add ABI checks

2020-02-04 Thread Neil Horman
On Tue, Feb 04, 2020 at 10:16:56AM +, Akhil Goyal wrote: > Hi, > > On 2/3/2020 5:09 PM, Thomas Monjalon wrote: > > > 03/02/2020 10:30, Ferruh Yigit: > > >> On 2/2/2020 2:41 PM, Ananyev, Konstantin wrote: > > >>> 02/02/2020 14:05, Thomas Monjalon: > > 31/01/2020 15:16, Trahe, Fiona: > > >>>

Re: [dpdk-dev] DPDK Windows Build

2020-02-04 Thread Thomas Monjalon
29/01/2020 19:05, Jeremy Plsek: > Hi Dmitry, > > > There is a bug in Meson: '/OPT:REF' must be prefixed with '-Wl,' when using > > Clang with link.exe, because Clang does not recognize '/OPT:REF' as an > > argument to pass to linker, but treats it as a filename instead. > > A patch is not under re

Re: [dpdk-dev] How to compile and run l2fwd/l3fwd on DPDK windows?

2020-02-04 Thread Thomas Monjalon
04/02/2020 22:25, William Tu: > Hi, > > I'm able to follow the doc to run helloworld example > https://doc.dpdk.org/guides/windows_gsg/build_dpdk.html#build-the-code > > I'm thinking about running l2fwd on my x710 card. > Is there any step-by-step document to follow? > > So far I'm not able to c

Re: [dpdk-dev] How to compile and run l2fwd/l3fwd on DPDK windows?

2020-02-04 Thread Pallavi Kadam
Hi William, On 2/4/2020 1:25 PM, William Tu wrote: Hi, I'm able to follow the doc to run helloworld example https://doc.dpdk.org/guides/windows_gsg/build_dpdk.html#build-the-code I'm thinking about running l2fwd on my x710 card. Is there any step-by-step document to follow? Currently, L2fwd/

[dpdk-dev] How to compile and run l2fwd/l3fwd on DPDK windows?

2020-02-04 Thread William Tu
Hi, I'm able to follow the doc to run helloworld example https://doc.dpdk.org/guides/windows_gsg/build_dpdk.html#build-the-code I'm thinking about running l2fwd on my x710 card. Is there any step-by-step document to follow? So far I'm not able to compile the l3fwd and l2fwd. meson fails for l3fw

Re: [dpdk-dev] DPDK Windows Build

2020-02-04 Thread William Tu
On Mon, Feb 3, 2020 at 10:16 PM Dmitry Kozlyuk wrote: > > Hi William, > > > examples\meson.build:11:0: ERROR: Program or command 'sh' not found or > > not executable > > > > A full log can be found at > > C:\dpdk-draft-windows\build11\meson-logs\meson-log.txt > > > > Do I need to install "sh"? > >

Re: [dpdk-dev] [RFC] Accelerator API to chain packet processing functions

2020-02-04 Thread Jerin Jacob
On Tue, Feb 4, 2020 at 8:15 PM David Coyle wrote: > > Introduction > > > This RFC introduces a new DPDK library, rte_accelerator. > > The main aim of this library is to provide a flexible and extensible way of > combining one or more packet-processing functions into a single operatio

Re: [dpdk-dev] [PATCH v2 4/4] add ABI checks

2020-02-04 Thread Neil Horman
On Tue, Feb 04, 2020 at 09:44:53AM -0500, Aaron Conole wrote: > Thomas Monjalon writes: > > > RED FLAG > > > > I don't see a lot of reactions, so I summarize the issue. > > We need action TODAY! > > > > API makes think that rte_cryptodev_info_get() cannot return > > a value >= 3 (RTE_CRYPTO_AEAD_

Re: [dpdk-dev] [pull-request] next-eventdev 20.02 RC2

2020-02-04 Thread Thomas Monjalon
28/01/2020 10:13, Jerin Jacob Kollanukkaran: > http://dpdk.org/git/next/dpdk-next-eventdev Pulled, thanks

Re: [dpdk-dev] [PATCH 3/3] app/testpmd: fix uninitialized members when setting PFC

2020-02-04 Thread Ferruh Yigit
On 1/28/2020 11:21 AM, Ferruh Yigit wrote: > On 1/21/2020 11:44 AM, Wei Hu (Xavier) wrote: >> From: "Wei Hu (Xavier)" >> >> Only a part of members in the local structure variable named pfc_conf are >> initialized in the function named cmd_priority_flow_ctrl_set_parsed when >> typing "set pfc_ctrl.

Re: [dpdk-dev] [PATCH 2/3] app/testpmd: fix the initial value when setting PFC

2020-02-04 Thread Ferruh Yigit
On 1/28/2020 11:21 AM, Ferruh Yigit wrote: > On 1/21/2020 11:44 AM, Wei Hu (Xavier) wrote: >> From: "Wei Hu (Xavier)" >> >> Currently, the initial values of the local structure variable named >> rx_tx_onoff_2_lfc_mode and rx_tx_onoff_2_pfc_mode are different in the >> similar part of these two fol

Re: [dpdk-dev] [PATCH 0/3] app/testpmd: fixes for testpmd application

2020-02-04 Thread Ferruh Yigit
On 1/21/2020 11:44 AM, Wei Hu (Xavier) wrote: > These patchset are fixes for testpmd application. > > Wei Hu (Xavier) (3): > app/testpmd: update Rx offload after setting MTU sccessfully > app/testpmd: fix the initial value when setting PFC > app/testpmd: fix uninitialized members when settin

Re: [dpdk-dev] [PATCH] vhost:fix crash on port deletion and VM shutdown at same time

2020-02-04 Thread Maxime Coquelin
On 1/16/20 3:07 AM, Zhike Wang wrote: > The vhost_user_read_cb() and rte_vhost_driver_unregister() can be > called at the same time by 2 threads. Eg thread1 calls vhost_user_read_cb() > and removes the vsocket from conn_list, then thread2 calls > rte_vhost_driver_unregister() and frees the vsock

Re: [dpdk-dev] [PATCH 4/4] net/vhost: make secondary probe complete

2020-02-04 Thread Maxime Coquelin
On 1/9/20 12:22 AM, Itsuro Oda wrote: > add lacking member setting and make secondary probe complete. Add > Signed-off-by: Itsuro Oda > --- > drivers/net/vhost/rte_eth_vhost.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/vhost/rte_eth_vhost.c > b

Re: [dpdk-dev] [PATCH 3/4] net/vhost: delay vhost driver setup

2020-02-04 Thread Maxime Coquelin
On 1/9/20 12:22 AM, Itsuro Oda wrote: > setting vhost driver is delayed at eth_dev configuration Sentences starts with an upper-case. Vhost driver setup is delayed... > in order to be able to set it from a secondary process. Add Fixes tag and cc stable. > Signed-off-by: Itsuro Oda > --- >

Re: [dpdk-dev] [PATCH v2] eal/ppc64: improve rte_rdtsc with ppc_get_timebase

2020-02-04 Thread David Christensen
__ppc_get_timebase() is GNU extension and is more efficient v2: Advoid breaking other ppc_64 flatforms. The __ppc_get_timebase() seems to be specific to powerpc platform and with GLIBC. Signed-off-by: Thinh Tran Reviewed-by: David Christensen

Re: [dpdk-dev] [PATCH 2/4] net/vhost: allocate iface_name from heap

2020-02-04 Thread Maxime Coquelin
No variable or function names in the title, as per the contribution guidelines: net/vhost: allocate interface name from heap On 1/9/20 12:22 AM, Itsuro Oda wrote: > allocate iface_name of pmd_internal from heap in order to > be able to refer from secondary processes. As for patch, better to have

Re: [dpdk-dev] [PATCH v4] app/testpmd: fix copying the name of the dynflag

2020-02-04 Thread Ferruh Yigit
On 2/4/2020 2:39 PM, Iremonger, Bernard wrote: >> -Original Message- >> From: Ori Kam >> Sent: Tuesday, February 4, 2020 1:40 PM >> To: Lu, Wenzhuo ; Wu, Jingjing >> ; Iremonger, Bernard >> >> Cc: dev@dpdk.org; or...@mellanox.com; Yigit, Ferruh >> ; viachesl...@mellanox.com >> Subject: [P

Re: [dpdk-dev] [RFC PATCH v2] kni: properly translate pa2va for cloned mbuf

2020-02-04 Thread Ferruh Yigit
On 2/4/2020 4:49 PM, yoursunny wrote: > Hi Ferruh > > Thanks for your review. > > On Tue, Feb 4, 2020 at 11:17 AM Ferruh Yigit wrote: >> >> On 1/28/2020 4:16 PM, Junxiao Shi wrote: >>> Previously, KNI kernel module uses the difference between m->buf_addr >>> and m->buf_iova to calculate userspac

Re: [dpdk-dev] [PATCH 1/4] net/vhost: remove an unused member

2020-02-04 Thread Maxime Coquelin
On 1/9/20 12:22 AM, Itsuro Oda wrote: > remove an unused member from pmd_internal. Please try to do a complete sentence: This patch removes an unused... > Signed-off-by: Itsuro Oda > --- > drivers/net/vhost/rte_eth_vhost.c | 9 + > 1 file changed, 1 insertion(+), 8 deletions(-) > >

Re: [dpdk-dev] [PATCH 0/4] make vhost PMD available for secondary processes

2020-02-04 Thread Maxime Coquelin
Hi Itsuro, On 1/20/20 3:17 AM, Itsuro ODA wrote: > Hi vhost PMD maitainers, > > I have not got any feedback yet. > Since this is the first time I submit a patch, something > may be wrong, would you tell me what should I do ? Sorry for the delay, and thanks for the contribution. You series does

Re: [dpdk-dev] [PATCH v2 4/4] add ABI checks

2020-02-04 Thread Trahe, Fiona
> -Original Message- > From: Thomas Monjalon > Sent: Tuesday, February 4, 2020 4:00 PM > To: Trahe, Fiona > Cc: David Marchand ; nhor...@tuxdriver.com; > bl...@debian.org; > ktray...@redhat.com; Ray Kinsella ; dev@dpdk.org; Akhil Goyal > ; Yigit, Ferruh ; Ananyev, > Konstantin > ; de

Re: [dpdk-dev] [RFC PATCH v2] kni: properly translate pa2va for cloned mbuf

2020-02-04 Thread yoursunny
Hi Ferruh Thanks for your review. On Tue, Feb 4, 2020 at 11:17 AM Ferruh Yigit wrote: > > On 1/28/2020 4:16 PM, Junxiao Shi wrote: > > Previously, KNI kernel module uses the difference between m->buf_addr > > and m->buf_iova to calculate userspace virtual address from physical > > address. This

[dpdk-dev] [PATCH v5] app/testpmd: add portlist option to the testpmd

2020-02-04 Thread Hariprasad Govindharajan
In current version, we are setting the ports using portmask. With portmask, we can use only upto 64 ports. This portlist option enables the user to use more than 64 ports. Now we can specify the ports in 2 different ways - Using portmask (-p [0x]nnn): mask must be in hex for

Re: [dpdk-dev] Big spike in DPDK VSZ

2020-02-04 Thread Burakov, Anatoly
On 04-Feb-20 12:07 PM, siddarth rai wrote: Hi Anatoly, You mentioned that the maximum size of mempool is limited. Can you tell what is the limit and where is it specified? Regards, Siddarth The mempool size itself isn't limited. However, due to the nature of how memory subsystem works, ther

Re: [dpdk-dev] [RFC PATCH v2] kni: properly translate pa2va for cloned mbuf

2020-02-04 Thread Ferruh Yigit
On 1/28/2020 4:16 PM, Junxiao Shi wrote: > Previously, KNI kernel module uses the difference between m->buf_addr > and m->buf_iova to calculate userspace virtual address from physical > address. This works for direct mbufs, but does not work for indirect > (cloned) mbufs that come from another memp

[dpdk-dev] [PATCH] examples/ioat: fix unchecked return value

2020-02-04 Thread Ciara Power
The function call to get the device info can return negative values on failure, which was previously unchecked. This return value is now checked and the function exits on failure. Coverity issue: 350361 Fixes: c8e6ceecebc1 ("examples/ioat: add new sample app for ioat driver") Cc: pawelx.mod...@int

[dpdk-dev] [PATCH] examples/ioat: fix unchecked return value

2020-02-04 Thread Ciara Power
The return value of the get link function call was not checked, and could return a negative value indicating a failure. If the return value is not 0 for success, the loop continues with the next port. To avoid a slight name clash with the new ret variable, the existing retval variable is renamed t

[dpdk-dev] [PATCH] examples/ioat: fix failure check for ioat dequeue

2020-02-04 Thread Ciara Power
The nb_dq return value from the ioat dequeue is negative in failure cases, however the variable was an unsigned int, causing the condition where nb_dq <= 0 to never be true. This is now cast to a signed int, which will successfully reflect the -1 value to be used in this conditional check. Coverit

Re: [dpdk-dev] [PATCH v4 00/15] add OCTEON TX2 inline IPsec support

2020-02-04 Thread Akhil Goyal
> > This series adds inline IPsec support in OCTEON TX2 PMD. > > In the inbound path, rte_flow framework need to be used to configure > the NPC block, which does the h/w lookup. The packets would get > processed by the crypto block and would submit to the scheduling block, > SSO. So inline IPse

Re: [dpdk-dev] [PATCH v7] eal: add manual probing option

2020-02-04 Thread Gaetan Rivet
On 04/02/2020 16:06, Thomas Monjalon wrote: 04/02/2020 13:43, Gaetan Rivet: On 04/02/2020 12:07, Thomas Monjalon wrote: 04/02/2020 11:03, Gaetan Rivet: On 03/02/2020 23:21, Thomas Monjalon wrote: 03/02/2020 06:16, Pavan Nikhilesh Bhagavatula: @David Marchand @tho...@monjalon.net Ping? Are

Re: [dpdk-dev] [PATCH v2 4/4] add ABI checks

2020-02-04 Thread Thomas Monjalon
04/02/2020 16:52, Trahe, Fiona: > > > We are working on a patch, when it is ready we will send it. > > If it's not ready by end of your today, of course, go ahead with (b) and > > we will work towards 20.05. > > We will not be sending a patch today. > The patch we're working on will provide two v

Re: [dpdk-dev] [PATCH v2 4/4] add ABI checks

2020-02-04 Thread Trahe, Fiona
> We are working on a patch, when it is ready we will send it. > If it's not ready by end of your today, of course, go ahead with (b) and > we will work towards 20.05. We will not be sending a patch today. The patch we're working on will provide two versions of rte_cryptodev_info_get(), both ca

Re: [dpdk-dev] [PATCH v6 0/8] integrate librte_ipsec SAD into ipsec-secgw

2020-02-04 Thread Akhil Goyal
> This series integrates SA database (SAD) capabilities from ipsec library. > The goal is to make ipsec-secgw RFC compliant regarding inbound SAD. > Also patch series removes hardcoded limitation for maximum number of SA's > and SP's. > According to our measurements, after this series of patches,

Re: [dpdk-dev] [PATCH v5 0/6] integrate librte_ipsec SAD into ipsec-secgw

2020-02-04 Thread Akhil Goyal
> > Hi Akhil, > > > > > > > This series integrates SA database (SAD) capabilities from ipsec library. > > > The goal is to make ipsec-secgw RFC compliant regarding inbound SAD. > > > Also patch series removes hardcoded limitation for maximum number of > > > SA's and SP's. > > > According to our m

Re: [dpdk-dev] [PATCH v2 0/4] add static ibverbs in meson

2020-02-04 Thread Bruce Richardson
On Tue, Feb 04, 2020 at 04:14:46PM +0100, Thomas Monjalon wrote: > 04/02/2020 15:33, Bruce Richardson: > > On Tue, Feb 04, 2020 at 03:27:50PM +0100, Thomas Monjalon wrote: > > > 04/02/2020 12:48, Bruce Richardson: > > > > as we discussed offline, I really don't like the necessity of the > > > > hid

Re: [dpdk-dev] [PATCH v2 0/4] add static ibverbs in meson

2020-02-04 Thread Thomas Monjalon
04/02/2020 15:33, Bruce Richardson: > On Tue, Feb 04, 2020 at 03:27:50PM +0100, Thomas Monjalon wrote: > > 04/02/2020 12:48, Bruce Richardson: > > > as we discussed offline, I really don't like the necessity of the > > > hidden_deps part of this, so I've tried coming up with some other > > > soluti

Re: [dpdk-dev] [PATCH] vhost: flush shadow tx if there is no more packets

2020-02-04 Thread Maxime Coquelin
On 2/4/20 4:05 PM, Eugenio Perez Martin wrote: > Ouch, my bad again, sorry :). > > I've forwarded the patch to stable@, please let me know if I need to do > something else. > > Maxime, please let me know if I need to send a new version with the "Fixed: > " tag :). Not needed, I will handle it

[dpdk-dev] [PATCH] net/failsafe: fix reported hash key size in device info

2020-02-04 Thread Raslan Darawsheh
Hash key size is missing from reported device info. This fills the hash key size in device info. Fixes: 4586be37 ("net/failsafe: fix reported device info") Cc: sta...@dpdk.org Signed-off-by: Raslan Darawsheh --- drivers/net/failsafe/failsafe_ops.c | 3 +++ 1 file changed, 3 insertions(+) diff

Re: [dpdk-dev] [PATCH] vhost: flush shadow tx if there is no more packets

2020-02-04 Thread Eugenio Perez Martin
Ouch, my bad again, sorry :). I've forwarded the patch to stable@, please let me know if I need to do something else. Maxime, please let me know if I need to send a new version with the "Fixed: " tag :). Thanks! On Tue, Feb 4, 2020 at 2:49 PM Kevin Traynor wrote: > On 04/02/2020 09:23, Eugeni

Re: [dpdk-dev] [PATCH v7] eal: add manual probing option

2020-02-04 Thread Thomas Monjalon
04/02/2020 13:43, Gaetan Rivet: > On 04/02/2020 12:07, Thomas Monjalon wrote: > > 04/02/2020 11:03, Gaetan Rivet: > >> On 03/02/2020 23:21, Thomas Monjalon wrote: > >>> 03/02/2020 06:16, Pavan Nikhilesh Bhagavatula: > @David Marchand @tho...@monjalon.net > > Ping? > > Are t

[dpdk-dev] BUG: eBPF missing BPF_ABS

2020-02-04 Thread Stephen Hemminger
As I mentioned in my FOSDEM talk the current DPDK eBPF handling is not usable for packet filters. I have ported the classic BPF to eBPF code and the generated code is not usable by DPDK. The problem is that DPDK eBPF does not implement all the opcodes. BPF_ABS is not implemented and must be. It is

Re: [dpdk-dev] [RFC] service: stop lcore threads before 'finalize'

2020-02-04 Thread Aaron Conole
David Marchand writes: > On Fri, Jan 17, 2020 at 9:17 AM David Marchand > wrote: >> >> On Thu, Jan 16, 2020 at 8:50 PM Aaron Conole wrote: >> > >> > I've noticed an occasional segfault from the build system in the >> > service_autotest and after talking with David (CC'd), it seems like it's >>

Re: [dpdk-dev] [PATCH 04/14] eal: cleanup threads

2020-02-04 Thread Aaron Conole
Stephen Hemminger writes: > When rte_eal_cleanup is called it should stop all the child threads > and close the pipes between threads. > > Signed-off-by: Stephen Hemminger > --- Acked-by: Aaron Conole

Re: [dpdk-dev] [PATCH v2 4/4] add ABI checks

2020-02-04 Thread Aaron Conole
Thomas Monjalon writes: > RED FLAG > > I don't see a lot of reactions, so I summarize the issue. > We need action TODAY! > > API makes think that rte_cryptodev_info_get() cannot return > a value >= 3 (RTE_CRYPTO_AEAD_LIST_END in 19.11). > Current 20.02 returns 3 (RTE_CRYPTO_AEAD_CHACHA20_POLY1305

[dpdk-dev] [RFC] Accelerator API to chain packet processing functions

2020-02-04 Thread David Coyle
Introduction This RFC introduces a new DPDK library, rte_accelerator. The main aim of this library is to provide a flexible and extensible way of combining one or more packet-processing functions into a single operation, thereby allowing these to be performed in parallel in optimiz

Re: [dpdk-dev] [PATCH v4] app/testpmd: fix copying the name of the dynflag

2020-02-04 Thread Iremonger, Bernard
> -Original Message- > From: Ori Kam > Sent: Tuesday, February 4, 2020 1:40 PM > To: Lu, Wenzhuo ; Wu, Jingjing > ; Iremonger, Bernard > > Cc: dev@dpdk.org; or...@mellanox.com; Yigit, Ferruh > ; viachesl...@mellanox.com > Subject: [PATCH v4] app/testpmd: fix copying the name of the dynfla

Re: [dpdk-dev] [EXT] Re: [PATCH] doc: add inline protocol in feature list

2020-02-04 Thread Ferruh Yigit
On 1/22/2020 9:47 AM, Anoob Joseph wrote: > Hi Ferruh, > > Please see inline. > > Thanks, > Anoob > >> -Original Message- >> From: Ferruh Yigit >> Sent: Tuesday, January 21, 2020 9:42 PM >> To: Anoob Joseph ; John McNamara >> ; Marko Kovacevic >> >> Cc: Jerin Jacob Kollanukkaran ; Nara

Re: [dpdk-dev] [PATCH v2 0/4] add static ibverbs in meson

2020-02-04 Thread Bruce Richardson
On Tue, Feb 04, 2020 at 03:27:50PM +0100, Thomas Monjalon wrote: > 04/02/2020 12:48, Bruce Richardson: > > as we discussed offline, I really don't like the necessity of the > > hidden_deps part of this, so I've tried coming up with some other > > solutions. > > Thanks for looking closely at these

Re: [dpdk-dev] [PATCH v2 0/4] add static ibverbs in meson

2020-02-04 Thread Thomas Monjalon
04/02/2020 12:48, Bruce Richardson: > as we discussed offline, I really don't like the necessity of the > hidden_deps part of this, so I've tried coming up with some other > solutions. Thanks for looking closely at these patches. > For example, in my testing I get the same result with the > follo

[dpdk-dev] [PATCH v3 10/13] examples/ipsec-secgw: add eventmode to ipsec-secgw

2020-02-04 Thread Lukasz Bartosik
Add eventmode support to ipsec-secgw. With the aid of event helper configure and use the eventmode capabilities. Signed-off-by: Anoob Joseph Signed-off-by: Lukasz Bartosik --- examples/ipsec-secgw/event_helper.c | 3 + examples/ipsec-secgw/event_helper.h | 14 ++ examples/ipsec-secgw/ipsec-s

[dpdk-dev] [PATCH v3 11/13] examples/ipsec-secgw: add driver mode worker

2020-02-04 Thread Lukasz Bartosik
Add driver inbound and outbound worker thread for ipsec-secgw. In driver mode application does as little as possible. It simply forwards packets back to port from which traffic was received instructing HW to apply inline security processing using first outbound SA configured for a given port. If a

[dpdk-dev] [PATCH v3 13/13] examples/ipsec-secgw: make number of buffers dynamic

2020-02-04 Thread Lukasz Bartosik
Make number of buffers in a pool nb_mbuf_in_pool dependent on number of ports, cores and crypto queues. Add command line option -s which when used overrides dynamic calculation of number of buffers in a pool. Signed-off-by: Anoob Joseph Signed-off-by: Lukasz Bartosik --- examples/ipsec-secgw/ip

[dpdk-dev] [PATCH v3 12/13] examples/ipsec-secgw: add app mode worker

2020-02-04 Thread Lukasz Bartosik
Add application inbound/outbound worker thread and IPsec application processing code for event mode. Exampple ipsec-secgw command in app mode: ipsec-secgw -w 0002:02:00.0,ipsec_in_max_spi=128 -w 0002:03:00.0,ipsec_in_max_spi=128 -w 0002:0e:00.0 -w 0002:10:00.1 --log-level=8 -c 0x1 -- -P -p 0x3 -u

[dpdk-dev] [PATCH v3 09/13] examples/ipsec-secgw: add event helper config init/uninit

2020-02-04 Thread Lukasz Bartosik
Add eventmode helper eh_conf_init and eh_conf_uninit functions which purpose is to initialize and unitialize eventmode helper configuration. Signed-off-by: Anoob Joseph Signed-off-by: Lukasz Bartosik --- examples/ipsec-secgw/event_helper.c | 103 examples/ip

[dpdk-dev] [PATCH v3 08/13] examples/ipsec-secgw: add support for internal ports

2020-02-04 Thread Lukasz Bartosik
Add support for Rx and Tx internal ports. When internal ports are available then a packet can be received from eth port and forwarded to event queue by HW without any software intervention. The same applies to Tx side where a packet sent to an event queue can by forwarded by HW to eth port without

[dpdk-dev] [PATCH v3 01/13] examples/ipsec-secgw: add default rte flow for inline Rx

2020-02-04 Thread Lukasz Bartosik
From: Ankur Dwivedi The default flow created would enable security processing on all ESP packets. If the default flow is created, SA based rte_flow creation would be skipped. Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph --- examples/ipsec-secgw/ipsec-secgw.c | 61 +

[dpdk-dev] [PATCH v3 07/13] examples/ipsec-secgw: add routines to launch workers

2020-02-04 Thread Lukasz Bartosik
In eventmode workers can be drafted differently according to the capabilities of the underlying event device. The added functions will receive an array of such workers and probe the eventmode properties to choose the worker. Signed-off-by: Anoob Joseph Signed-off-by: Lukasz Bartosik --- example

[dpdk-dev] [PATCH v3 05/13] examples/ipsec-secgw: add Tx adapter support

2020-02-04 Thread Lukasz Bartosik
From: Anoob Joseph Add Tx adapter support. The event helper init routine will initialize the Tx adapter according to the configuration. If Tx adapter config is not present it will generate a default config. Signed-off-by: Anoob Joseph Signed-off-by: Lukasz Bartosik --- examples/ipsec-secgw/ev

[dpdk-dev] [PATCH v3 06/13] examples/ipsec-secgw: add routines to display config

2020-02-04 Thread Lukasz Bartosik
From: Anoob Joseph Add routines to display the eventmode configuration and provide an overview of the devices used. Signed-off-by: Anoob Joseph Signed-off-by: Lukasz Bartosik --- examples/ipsec-secgw/event_helper.c | 207 examples/ipsec-secgw/event_helper.

[dpdk-dev] [PATCH v3 02/13] examples/ipsec-secgw: add framework for eventmode helper

2020-02-04 Thread Lukasz Bartosik
From: Anoob Joseph Add framework for eventmode helper. Event mode involves initialization of multiple devices like eventdev, ethdev and etc. Add routines to initialize and uninitialize event device. Generate a default config for event device if it is not specified in the configuration. Currently

[dpdk-dev] [PATCH v3 03/13] examples/ipsec-secgw: add eventdev port-lcore link

2020-02-04 Thread Lukasz Bartosik
From: Anoob Joseph Add event device port-lcore link and specify which event queues should be connected to the event port. Generate a default config for event port-lcore links if it is not specified in the configuration. This routine will check the number of available ports and then create links a

[dpdk-dev] [PATCH v3 04/13] examples/ipsec-secgw: add Rx adapter support

2020-02-04 Thread Lukasz Bartosik
From: Anoob Joseph Add Rx adapter support. The event helper init routine will initialize the Rx adapter according to the configuration. If Rx adapter config is not present it will generate a default config. If there are enough event queues available it will map eth ports and event queues 1:1 (one

[dpdk-dev] [PATCH v3 00/13] add eventmode to ipsec-secgw

2020-02-04 Thread Lukasz Bartosik
This series introduces event-mode additions to ipsec-secgw. With this series, ipsec-secgw would be able to run in eventmode. The worker thread (executing loop) would be receiving events and would be submitting it back to the eventdev after the processing. This way, multicore scaling and h/w assist

Re: [dpdk-dev] [PATCH] vhost: flush shadow tx if there is no more packets

2020-02-04 Thread Kevin Traynor
On 04/02/2020 09:23, Eugenio Perez Martin wrote: > Hi Kevin! > > Sorry, thanks for noticing it! It fixes commit ("31d6c6a5b vhost: optimize > packed ring dequeue"), what was not present on 18.11 version (I've checked > that v19.08 does not contain the failure). > Right, in that case the issue is

[dpdk-dev] [PATCH v4] app/testpmd: fix copying the name of the dynflag

2020-02-04 Thread Ori Kam
When working with testpmd and setting the dynflag name, we copy the name given by the cmd to the dynflag name. The issue is that the size of the dynflag name is smaller then the string used by testpmd. This commit solves this issue by checking that the length of the requested flag name is not too

Re: [dpdk-dev] [PATCH] examples/l2fwd-crypto:skip dev configure for masked devices

2020-02-04 Thread Akhil Goyal
> > > > > > The devices which are masked by cryptodev mask should not be initialized > > and skipped while traversing the device list. > > > > Fixes: 61a7018ba0 ("examples/l2fwd-crypto:skip dev configure for masked > > devices") > > Cc: sta...@dpdk.org > > > > Signed-off-by: Apeksha Gupta > >

  1   2   >