From: Maxime Coquelin
> On 1/29/20 11:09 AM, Matan Azrad wrote:
> > The HW virtq object represents an emulated context for a VIRTIO_NET
> > virtqueue which was created and managed by a VIRTIO_NET driver as
> > defined in VIRTIO Specification.
> >
> > Add support to prepare and release all the ba
This patch fixes not included in original patch release note
Fixes: 6cde900bd59d ("common/qat: remove tail write coalescing")
Signed-off-by: Arek Kusztal
---
doc/guides/rel_notes/release_20_02.rst | 9 +
1 file changed, 9 insertions(+)
diff --git a/doc/guides/rel_notes/release_20_02.rs
This commit fixes missing release notes for dual thread feature.
Fixes: 026f21c0b951 ("common/qat: support dual threads for enqueue/dequeue")
Signed-off-by: Arek Kusztal
---
doc/guides/rel_notes/release_20_02.rst | 7 +++
1 file changed, 7 insertions(+)
diff --git a/doc/guides/rel_notes/re
Hi
From: Maxime Coquelin
> On 1/29/20 11:09 AM, Matan Azrad wrote:
> > As an arrangement to the vitrio queues creation, a 2 QPs and CQ may be
> > created for the virtio queue.
> >
> > The design is to trigger an event for the guest and for the vdpa
> > driver when a new CQE is posted by the HW a
On Thu, Jan 30, 2020 at 10:18 PM Somnath Kotur
wrote:
> HW seems to populate the cfa code in the Rx descriptor even
> if an explicit flow rule is not configured via application as
> there might be a default rule configured in HW even for promisc
> mode.
>
> Fixes: 94eb699bc82e ("net/bnxt: support
HW seems to populate the cfa code in the Rx descriptor even
if an explicit flow rule is not configured via application as
there might be a default rule configured in HW even for promisc
mode.
Fixes: 94eb699bc82e ("net/bnxt: support flow mark action")
Reviewed-by: Ajit Khaparde
Signed-off-by: Som
Hello Pallavi,
> +#include "eal_internal_cfg.h"
> +
> +/* sets up platform-specific runtime data dir */
> +int
> +eal_create_runtime_dir(void);
> +
> +/* returns runtime dir */
> +const char *
> +eal_get_runtime_dir(void);
Any reason not to #include "eal_filesystem.h"?
> +
> +static inline const
The goal of rte_os.h is to mitigate OS differences for EAL users.
In Windows EAL, rte_os.h did excessive things:
1. It included platform SDK headers (windows.h, etc). Those files are
huge, require specific inclusion order, and are generally unused by
the code including rte_os.h. Declarations
HW seems to populate the cfa code in the Rx descriptor even
if an explicit flow rule is not configured via application as
there might be a default rule configured in HW even for promisc
mode.
Fixes: 6d9be25b9771 ("net/bnxt: fix to support zero mark id along with RSS
action")
Reviewed-by: Ajit Kh
Please ignore this patch
Thanks
On Fri, Jan 31, 2020 at 10:37 AM Somnath Kotur
wrote:
> HW seems to populate the cfa code in the Rx descriptor even
> if an explicit flow rule is not configured via application as
> there might be a default rule configured in HW even for promisc
> mode.
>
> Fixes
HW seems to populate the cfa code in the Rx descriptor even
if an explicit flow rule is not configured via application as
there might be a default rule configured in HW even for promisc
mode.
Fixes: ff88f133be45 ("net/bnxt: fix to support zero mark id along with RSS
action")
Bug: CTRL-45914
Chan
Changed the rte_ring chapter in programmer's guide to reflect
the addition of rte_ring_xxx_elem APIs. References to pointers
as ring elements is changed to generic term 'objects'.
Signed-off-by: Honnappa Nagarahalli
Reviewed-by: Gavin Hu
---
doc/guides/prog_guide/ring_lib.rst | 16 +
Correct the documentation for obj_table in rte_ring_xxx_elem APIs.
Fixes: cc4b218790f6 ("ring: support configurable element size")
Signed-off-by: Honnappa Nagarahalli
Reviewed-by: Gavin Hu
---
lib/librte_ring/rte_ring_elem.h | 34 -
1 file changed, 17 insertions
Add Meson configuration to cross-compile for Windows using MinGW-w64.
It may require adjustments in some cases, but at least it provides
the foundation.
Signed-off-by: Dmitry Kozlyuk
create mode 100644 meson_mingw.txt
diff --git a/meson_mingw.txt b/meson_mingw.txt
new file mode 100644
index 00
Instructions for different toolchains presented as options on the
corresponging steps of the guide, so that common parts may be reused.
Signed-off-by: Dmitry Kozlyuk
diff --git a/doc/guides/windows_gsg/build_dpdk.rst
b/doc/guides/windows_gsg/build_dpdk.rst
index 6711e07e2..eabc459fb 100644
---
Use portable format attribute for output strings.
Signed-off-by: Dmitry Kozlyuk
diff --git a/lib/librte_cmdline/cmdline.h b/lib/librte_cmdline/cmdline.h
index 27d2effdf..952a50829 100644
--- a/lib/librte_cmdline/cmdline.h
+++ b/lib/librte_cmdline/cmdline.h
@@ -7,6 +7,8 @@
#ifndef _CMDLINE_H_
#
Use portable format attribute for logging and panic messages.
Signed-off-by: Dmitry Kozlyuk
diff --git a/lib/librte_eal/common/include/rte_common.h
b/lib/librte_eal/common/include/rte_common.h
index 2f086bb9c..dc406ce27 100644
--- a/lib/librte_eal/common/include/rte_common.h
+++ b/lib/librte_ea
MinGW-w64 linker does not mimic MS linker options, so the build system
must differentiate between linkers on Windows. Use GNU linker options
with GCC and MS linker options with Clang.
MinGW-w64 by default uses MSVCRT stdio, which does not comply to ANSI,
most notably its formatting and string hand
This patch series add support for building DPDK using MinGW-w64.
MinGW-w64 provides GNU toolchain and independent platform SDK on
Windows. It also supports cross-compilation to Windows from POSIX
systems by providing cross tollchains and libraries [0]. It does NOT
emulate a full POSIX environment,
When using __attribute__((format(...)) on functions, GCC on Windows
assumes MS-specific format string by default, even if the underlying
stdio implementation is ANSI-compliant (either MS Unicersal CRT
or MinGW implementation). Wrap attribute into a macro that forces
GNU-specific format string when
Hi.
I have a fail in SR-IOV
I use a HPE Eth 631SFP28 2port NIC
Setting up SR-IOV will cause problems on the second port (port 1).
The configuration of SR-IOV is assigned one VF on each port.
I added this information to the last table.
l Error Log
testpmd> port stop 0
Stopping
Hi Konstantin,
On 30.01.2020 23:21, Ananyev, Konstantin wrote:
>
>
>> -Original Message-
>> From: Ananyev, Konstantin
>> Sent: Thursday, January 30, 2020 11:13 AM
>> To: Lukas Bartosik ; Anoob Joseph
>> ; Akhil Goyal ; Nicolau, Radu
>> ; Thomas Monjalon
>> Cc: Jerin Jacob Kollanukkaran
__ppc_get_timebase() is GNU extention and is more efficient
Signed-off-by: Thinh Tran
Reviewed-by: David Christensen
Excluding syslog/ dlfcn definitions and parameters
from Windows by adding #ifndef RTE_EXEC_ENV_WINDOWS.
Note: This is a temporary change. In future, separate
'unix' directory will be created for unix specific functions.
Signed-off-by: Pallavi Kadam
Reviewed-by: Ranjit Menon
---
lib/librte_eal/
Added support for additional common files in meson build
to expand Windows EAL and to support the lcore parsing
feature on Windows.
Signed-off-by: Pallavi Kadam
Signed-off-by: Antara Ganesh Kolar
Reviewed-by: Ranjit Menon
Reviewed-by: Keith Wiles
---
lib/librte_eal/windows/eal/meson.build | 8
Adding specific logic for eal.c to support parsing on
Windows.
Signed-off-by: Pallavi Kadam
Signed-off-by: Antara Ganesh Kolar
Reviewed-by: Ranjit Menon
Reviewed-by: Keith Wiles
---
lib/librte_eal/windows/eal/eal.c | 133 ++-
1 file changed, 130 insertions(+), 3 de
Adding a function to detect process type, also included
header files to contain suitable function declarations
and to support extra warning flags.
Signed-off-by: Pallavi Kadam
Signed-off-by: Antara Ganesh Kolar
Reviewed-by: Ranjit Menon
Reviewed-by: Keith Wiles
---
lib/librte_eal/windows/eal/
Adding dirent.h on Windows to support common code.
eal_common_options.c includes this file.
The original contribution is under MIT license.
https://github.com/tronkko/dirent
Signed-off-by: Antara Ganesh Kolar
Signed-off-by: Pallavi Kadam
Reviewed-by: Ranjit Menon
Reviewed-by: Keith Wiles
---
Adding additional function definitions for pthread, cpuset
implementation, asprintf implementation, in order to support
common code.
Signed-off-by: Bruce Richardson
Signed-off-by: Pallavi Kadam
Reviewed-by: Ranjit Menon
Reviewed-by: Keith Wiles
---
lib/librte_eal/windows/eal/include/pthread.h
Adding getopt files to support parsing option on
Windows.
The original contribution is under BSD-2 license.
https://raw.githubusercontent.com/greenplum-db/libusual/master/usual/getopt.c
https://raw.githubusercontent.com/greenplum-db/libusual/master/usual/getopt.h
Signed-off-by: Antara Ganesh Kola
Modified \common\include\arch\x86\rte_vect.h
to include SSE4 header for Windows.
Signed-off-by: Antara Ganesh Kolar
Signed-off-by: Pallavi Kadam
Reviewed-by: Ranjit Menon
Reviewed-by: Keith Wiles
---
lib/librte_eal/common/include/arch/x86/rte_vect.h | 4 +++-
1 file changed, 3 insertions(+),
Adding eal_filesystem.h to support functions and
path defines for files and directories on Windows.
Signed-off-by: Antara Ganesh Kolar
Signed-off-by: Pallavi Kadam
Reviewed-by: Ranjit Menon
Reviewed-by: Keith Wiles
---
.../windows/eal/include/eal_filesystem.h | 94 +++
1
The Governing Board and Tech Board have provided exceptions for
MIT and BSD-2-Clause license files for DPDK support on Windows.
Signed-off-by: Pallavi Kadam
Reviewed-by: Ranjit Menon
---
license/exceptions.txt | 12 +++-
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/lice
This patchset includes additional functionalities for Windows EAL
to support command-line parsing feature and some EAL common code
on Windows.
This patchset can be applied to windpdk-next-dev branch in the draft repo.
v6 changes:
Removed sysfs function as it was not required on Windows.
> -Original Message-
> From: dev On Behalf Of Thomas Monjalon
> Sent: Thursday, January 30, 2020 4:00 PM
> To: Anoob Joseph ; akhil.go...@nxp.com; Trahe, Fiona
>
> Cc: dev@dpdk.org; David Marchand ; Richardson,
> Bruce ;
> nhor...@tuxdriver.com; Mcnamara, John ; Trahe, Fiona
> ; Kus
30/01/2020 17:00, David Marchand:
> --- a/devtools/test-meson-builds.sh
> +++ b/devtools/test-meson-builds.sh
> +refsrcdir=$(mktemp -d -t dpdk-${DPDK_ABI_REF_VERSION:-}.XXX)
Instead of a temporary source directory,
could it be inside $DPDK_ABI_REF_DIR/$DPDK_ABI_REF_VERSION ?
I feel it would more "
30/01/2020 17:00, David Marchand:
> Enabling them requires a configuration that will trigger the ABI dumps
> generation as part of the existing devtools/test-build.sh and
> devtools/test-meson-builds.sh scripts.
[...]
> --- a/devtools/test-meson-builds.sh
> +++ b/devtools/test-meson-builds.sh
>
> -Original Message-
> From: Ananyev, Konstantin
> Sent: Thursday, January 30, 2020 11:13 AM
> To: Lukas Bartosik ; Anoob Joseph
> ; Akhil Goyal ; Nicolau, Radu
> ; Thomas Monjalon
> Cc: Jerin Jacob Kollanukkaran ; Narayana Prasad Raju
> Athreya ; Ankur Dwivedi
> ; Archana Muniganti ;
30/01/2020 17:00, David Marchand:
> Let's test installing with meson as part of Travis and the
> devtools/test-meson-builds.sh script.
For test-meson-builds.sh, I would prefer avoiding install if not needed.
Can we install only if compiling examples or checking ABI?
> -compile () #
> +compile (
When working with testpmd and setting the dynflag name, we copy the
name given by the cmd to the dynflag name.
The issue is that the size of the dynflag name is smaller then the
string used by testpmd.
This commit solves this issue by checking that the length of the requested
flag name is not too
When working with testpmd and setting the dynflag name, we copy the
name given by the cmd to the dynflag name.
The issue is that the size of the dynflag name is smaller then the
string used by testpmd.
This commit solves this issue by checking if the requested name
is too long.
Coverity issue: 3
30/01/2020 17:15, Eelco Chaudron:
> On 30 Jan 2020, at 17:04, Luca Boccassi wrote:
> > On Thu, 2020-01-30 at 16:55 +0100, Thomas Monjalon wrote:
> >> 30/01/2020 15:21, Luca Boccassi:
> >>> On Thu, 2020-01-30 at 15:17 +0100, Thomas Monjalon wrote:
> 30/01/2020 13:57, Luca Boccassi:
> > On T
Hi,
We’re seeing an issue since upgrading to 19.08, the kni FIFO’s apparently
aren’t contiguous. From user-space’s perspective, the kni’s tx_q straddles the
2MB pageboundary at 0x17a60. The mbuf pointers in the ring prior to this
address are valid. The tx_q’s write pointer is indicating
30/01/2020 17:09, Ferruh Yigit:
> On 1/29/2020 8:13 PM, Akhil Goyal wrote:
> >
> >
> >>
> >> On Wed, Jan 29, 2020 at 7:10 PM Anoob Joseph wrote:
> >>> The asymmetric crypto library is experimental. Changes to experimental
> >>> code
> >> paths is allowed, right?
> >>
> >> The asymmetric crypto
On 1/29/20 11:09 AM, Matan Azrad wrote:
> Add support for the next features in virtq configuration:
> VIRTIO_F_RING_PACKED,
> VIRTIO_NET_F_HOST_TSO4,
> VIRTIO_NET_F_HOST_TSO6,
> VIRTIO_NET_F_CSUM,
> VIRTIO_NET_F_GUEST_CSUM,
> VIRTIO_F_VERSION_1,
>
> These fea
On 1/29/20 11:09 AM, Matan Azrad wrote:
> The HW virtq object represents an emulated context for a VIRTIO_NET
> virtqueue which was created and managed by a VIRTIO_NET driver as
> defined in VIRTIO Specification.
>
> Add support to prepare and release all the basic HW resources needed
> the use
Hi Bernard,
> -Original Message-
> From: Ori Kam
> Sent: Thursday, January 30, 2020 8:56 PM
> To: Iremonger, Bernard ; Lu, Wenzhuo
> ; Wu, Jingjing
> Cc: dev@dpdk.org; Yigit, Ferruh ; Slava Ovsiienko
>
> Subject: RE: [PATCH] app/testpmd: fix copying the name of the dynflag
>
> Hi Bernar
Hi Bernard,
Thanks for review, PSB
Ori
> -Original Message-
> From: Iremonger, Bernard
> Sent: Thursday, January 30, 2020 6:54 PM
> To: Ori Kam ; Lu, Wenzhuo ;
> Wu, Jingjing
> Cc: dev@dpdk.org; Yigit, Ferruh ; Slava Ovsiienko
>
> Subject: RE: [PATCH] app/testpmd: fix copying the name
> >Subject: [PATCH v3 1/4] hash: fix meson headers packaging
> >
> >Those headers are internal and should not be distributed.
> >
> >Fixes: 5b9656b157d3 ("lib: build with meson")
> >Cc: sta...@dpdk.org
> >
> >Signed-off-by: David Marchand
> >Acked-by: Luca Boccassi
>
> [Wang, Yipeng]
> Thanks
On 1/29/20 11:09 AM, Matan Azrad wrote:
> As an arrangement to the vitrio queues creation, a 2 QPs and CQ may be
> created for the virtio queue.
>
> The design is to trigger an event for the guest and for the vdpa driver
> when a new CQE is posted by the HW after the packet transition.
>
> Thi
>-Original Message-
>From: David Marchand [mailto:david.march...@redhat.com]
>Sent: Thursday, January 30, 2020 8:00 AM
>To: dev@dpdk.org
>Cc: tho...@monjalon.net; Richardson, Bruce ;
>Laatz, Kevin ;
>acon...@redhat.com; nhor...@tuxdriver.com; akhil.go...@nxp.com;
>ano...@marvell.com; bl..
On 20 Jan 22:06, Xiao Wang wrote:
> Since all related queues' interrupts are turned on before epoll, we need
> to turn off all the interrupts after wakeup. This patch fixes the issue
> of only turning off the interrupted queues.
>
> Fixes: b736d64787fc ("examples/l3fwd-power: disable Rx interrupt
On 1/29/20 11:09 AM, Matan Azrad wrote:
> In order to map the guest physical addresses used by the virtio device
> guest side to the host physical addresses used by the HW as the host
> side, memory regions are created.
>
> By this way, for example, the HW can translate the addresses of the
> p
On 1/30/2020 4:58 PM, jer...@marvell.com wrote:
> From: Jerin Jacob
>
> Based on the tech board meeting held on 2019-11-06,
> It's been decided to move igb_uio kernel module to a new repository
> hosted by dpdk.org in v20.11 release.
>
> http://mails.dpdk.org/archives/dev/2019-November/151763.ht
Fix the IONIC_RXQ_COMP_PKT_TYPE_MASK define. This fixes
the coverity defect #353608
Signed-off-by: Alfredo Cardigliano
---
drivers/net/ionic/ionic_if.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ionic/ionic_if.h b/drivers/net/ionic/ionic_if.h
index ab300be6e.
Some of the memebers of the mpls struct are not initialized.
this commit init the uninitialized members.
Coverity issue: 325735
Fixes: 3e77031be855 ("app/testpmd: add MPLSoGRE encapsulation")
Cc: sta...@dpdk.org
Signed-off-by: Ori Kam
---
app/test-pmd/cmdline_flow.c | 4 +++-
1 file changed, 3
From: Jerin Jacob
Based on the tech board meeting held on 2019-11-06,
It's been decided to move igb_uio kernel module to a new repository
hosted by dpdk.org in v20.11 release.
http://mails.dpdk.org/archives/dev/2019-November/151763.html
Adding the deprecation notice for the same in advance.
Si
Hi Ori,
> -Original Message-
> From: Ori Kam
> Sent: Thursday, January 30, 2020 1:23 PM
> To: Lu, Wenzhuo ; Wu, Jingjing
> ; Iremonger, Bernard
>
> Cc: dev@dpdk.org; or...@mellanox.com; Yigit, Ferruh
> ; viachesl...@mellanox.com
> Subject: [PATCH] app/testpmd: fix copying the name of the
https://bugs.dpdk.org/show_bug.cgi?id=387
Bug ID: 387
Summary: Disabling octeontx in meson leads to meson configure
failure
Product: DPDK
Version: 20.02
Hardware: All
OS: All
Status: UNCONFIRMED
On 1/30/2020 3:59 PM, Thomas Monjalon wrote:
> 30/01/2020 14:06, Trahe, Fiona:
>> We were unaware the LIST_END change could constitute an ABI breakage, but
>> can see how it affects the array size when picked up.
>> We're exploring options.
>>
>> I agree with Anoob's point that if we don't allow t
Currently only one qp will be used for one core. The number of qps can
be increased to match the number of lcore params.
Signed-off-by: Anoob Joseph
Signed-off-by: Lukasz Bartosik
---
examples/ipsec-secgw/ipsec-secgw.c | 32 ++--
examples/ipsec-secgw/ipsec.c |
On 16/01/2020 12:42, Ferruh Yigit wrote:
> On 1/16/2020 11:54 AM, Neil Horman wrote:
>> On Thu, Jan 16, 2020 at 12:25:06PM +0100, David Marchand wrote:
>>> On Tue, Dec 17, 2019 at 2:08 PM Eelco Chaudron wrote:
Moved RFC4115 APIs to none experimental as they have been there
since
Get a burst mode information for Rx/Tx queues in mlx5.
Provide callback functions to show this information in
a "show rxq info" and "show txq info" output.
Signed-off-by: Alexander Kozyrev
---
doc/guides/nics/features/mlx5.ini | 1 +
drivers/net/mlx5/mlx5.c | 12 +++
drivers/net/mlx
Hi Konstantin,
Please see inline.
Thanks,
Anoob
> -Original Message-
> From: Ananyev, Konstantin
> Sent: Thursday, January 30, 2020 3:43 AM
> To: Anoob Joseph ; Akhil Goyal ;
> Nicolau, Radu
> Cc: Jerin Jacob Kollanukkaran ; Lukas Bartosik
> ; Narayana Prasad Raju Athreya
> ; dev@dpdk.
From: Kiran Kumar K
When HIGIG flow control enabled with CGX, We are disabling Tx flow control.
Added check to enable the full flow control in HIGIG mode.
Signed-off-by: Kiran Kumar K
---
V2 changes:
* Updated commit log
drivers/net/octeontx2/otx2_flow_ctrl.c | 1 +
1 file changed, 1 insertio
When adding mpls item we copy the structure, in some cases
the item is not initialized.
This commit solves this by initializing the struct.
Coverity issue: 325734
Fixes: a1191d39cb57 ("app/testpmd: add MPLSoUDP encapsulation")
Cc: sta...@dpdk.org
Signed-off-by: Ori Kam
---
app/test-pmd/cmdline
On 30 Jan 2020, at 17:04, Luca Boccassi wrote:
On Thu, 2020-01-30 at 16:55 +0100, Thomas Monjalon wrote:
30/01/2020 15:21, Luca Boccassi:
On Thu, 2020-01-30 at 15:17 +0100, Thomas Monjalon wrote:
30/01/2020 13:57, Luca Boccassi:
On Thu, 2020-01-30 at 13:33 +0100, Thomas Monjalon wrote:
H
Use the MLX5_ASSERT macros instead of the standard assert clause.
Depends on the RTE_LIBRTE_MLX5_DEBUG configuration option to define it.
If RTE_LIBRTE_MLX5_DEBUG is enabled MLX5_ASSERT is equal to RTE_VERIFY
to bypass the global CONFIG_RTE_ENABLE_ASSERT option.
If RTE_LIBRTE_MLX5_DEBUG is disabled
net/mlx: assert cleanup in mlx drivers
The Mellanox PMD uses the NDEBUG definition to control built-in debug
features including the asserting one. The DPDK uses a bit different
approach and provides RTE_ASSERT macro and appropriate global
configuration option: CONFIG_RTE_ENABLE_ASSERT.
The patch s
Use the RTE_LIBRTE_MLX4_DEBUG compilation flag to get rid of dependency
on the NDEBUG definition. This is a preparation step to switch
from standard assert clauses to DPDK RTE_ASSERT ones in MLX4 driver.
Signed-off-by: Alexander Kozyrev
Acked-by: Viacheslav Ovsiienko
---
drivers/net/mlx4/Makefi
Use the RTE_LIBRTE_MLX5_DEBUG configuration flag to get rid of dependency
on the NDEBUG definition. This is a preparation step to switch
from standard assert clauses to DPDK RTE_ASSERT ones in MLX5 driver.
Signed-off-by: Alexander Kozyrev
Acked-by: Viacheslav Ovsiienko
---
drivers/common/mlx5/M
Use the MLX4_ASSERT macros instead of the standard assert clause.
Depends on the RTE_LIBRTE_MLX4_DEBUG configuration option to define it.
If RTE_LIBRTE_MLX4_DEBUG is enabled MLX4_ASSERT is equal to RTE_VERIFY
to bypass the global CONFIG_RTE_ENABLE_ASSERT option.
If RTE_LIBRTE_MLX4_DEBUG is disabled
Remove -Werror-all flag in ICC configuration file to stop treating ICC
warnings as errors in DPDK due to many false positives. We are using
GCC and Clang as a benchmark for warnings anyway for simplification.
Suggested-by: Thomas Monjalon
Signed-off-by: Alexander Kozyrev
Acked-by: Viacheslav Ovs
On Thu, Jan 30, 2020 at 10:25 AM Andrzej Ostruszka
wrote:
>
> Timer, LPM and Distributor libraries no longer use function versioning
> and therefore do not need separate build for static and shared version
> of libraries.
>
> This patch removes use_function_versioning from their meson build files
On 1/29/2020 8:13 PM, Akhil Goyal wrote:
>
>
>>
>> On Wed, Jan 29, 2020 at 7:10 PM Anoob Joseph wrote:
>>> The asymmetric crypto library is experimental. Changes to experimental code
>> paths is allowed, right?
>>
>> The asymmetric crypto enum is referenced by a function part of the stable
>> A
On Thu, 2020-01-30 at 16:55 +0100, Thomas Monjalon wrote:
> 30/01/2020 15:21, Luca Boccassi:
> > On Thu, 2020-01-30 at 15:17 +0100, Thomas Monjalon wrote:
> > > 30/01/2020 13:57, Luca Boccassi:
> > > > On Thu, 2020-01-30 at 13:33 +0100, Thomas Monjalon wrote:
> > > > > Hi,
> > > > >
> > > > > I di
From: Kiran Kumar K
Due to following errata (NIX-35687) 2019-03-20 A0 CatA Link
credit deadlock, We disabled Tx flow control. Add check to enable
the full flow control in HIGIG mode.
Signed-off-by: Kiran Kumar K
---
drivers/net/octeontx2/otx2_flow_ctrl.c | 1 +
1 file changed, 1 insertion(+)
For normal developers, those checks are disabled.
Enabling them requires a configuration that will trigger the ABI dumps
generation as part of the existing devtools/test-build.sh and
devtools/test-meson-builds.sh scripts.
Those checks are enabled in the CI for the default meson options on x86
and
No functional change intended, prepare for reusing this code.
The config and compilation parts are separated in helpers.
Unsetting CC is moved to the caller of the helper.
Signed-off-by: David Marchand
Acked-by: Luca Boccassi
---
Changelog since v2:
- changed indent in config(),
- removed useles
Let's test installing with meson as part of Travis and the
devtools/test-meson-builds.sh script.
The resulting headers and binaries make more sense to run checks
against, since they should be the same as what the final users get.
test-null.sh is now called on an installed testpmd.
The (future) AB
Here is the current state of the ABI checks.
libabigail has some issues when mixing dump and so files compiled with
clang [1], so for now, all checks are done on dumps only.
libabigail 1.0-rc3 in Xenial reported issues that disappear with the
version 1.2 in Bionic.
To avoid getting warnings on in
Those headers are internal and should not be distributed.
Fixes: 5b9656b157d3 ("lib: build with meson")
Cc: sta...@dpdk.org
Signed-off-by: David Marchand
Acked-by: Luca Boccassi
---
lib/librte_hash/meson.build | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/lib/librte_h
30/01/2020 14:06, Trahe, Fiona:
> We were unaware the LIST_END change could constitute an ABI breakage, but can
> see how it affects the array size when picked up.
> We're exploring options.
>
> I agree with Anoob's point that if we don't allow the LIST_END to be
> modified, then it means no fea
30/01/2020 15:21, Luca Boccassi:
> On Thu, 2020-01-30 at 15:17 +0100, Thomas Monjalon wrote:
> > 30/01/2020 13:57, Luca Boccassi:
> > > On Thu, 2020-01-30 at 13:33 +0100, Thomas Monjalon wrote:
> > > > Hi,
> > > >
> > > > I disagree with the need of this patch.
> > > > The symbol was experimental,
> -Original Message-
> From: Thomas Monjalon
> Sent: Thursday, January 30, 2020 5:03 AM
> To: Ferruh Yigit ; Aaron Conole
> ; Amit Gupta
> Cc: dev@dpdk.org; Michael Santana ;
> dev@dpdk.org; Aaron Conole ;
> david.march...@redhat.com; yipeng1.w...@intel.com; Honnappa
> Nagarahalli
> S
On Thu, 2020-01-30 at 15:01 +, Stokes, Ian wrote:
>
> On 1/30/2020 10:08 AM, Luca Boccassi wrote:
> > On Mon, 2020-01-13 at 12:47 +, Luca Boccassi wrote:
> > > Hi all,
> > >
> > > Here is a list of patches targeted for LTS release 17.11.10.
> > > This will be the last 17.11 release.
> > >
On 1/30/2020 10:08 AM, Luca Boccassi wrote:
On Mon, 2020-01-13 at 12:47 +, Luca Boccassi wrote:
Hi all,
Here is a list of patches targeted for LTS release 17.11.10.
This will be the last 17.11 release.
The planned date for the final release is the 30th of January.
Please help with test
On 1/14/2020 2:40 PM, Kevin Traynor wrote:
Hi all,
Here is a list of patches targeted for LTS release 18.11.6.
The planned date for the final release is 31st January.
Please help with testing and validation of your use cases and report
any issues/results with reply-all to this mail. For the
On 1/29/20 11:08 AM, Matan Azrad wrote:
> Add support for get_features and get_protocol_features operations.
>
> Part of the features are reported by the DevX capabilities.
>
> Signed-off-by: Matan Azrad
> Acked-by: Viacheslav Ovsiienko
> ---
> doc/guides/vdpadevs/features/mlx5.ini | 7 +++
On 1/29/20 11:08 AM, Matan Azrad wrote:
> Support get_queue_num operation to get the maximum number of queues
> supported by the device.
>
> This number comes from the DevX capabilities.
>
> Signed-off-by: Matan Azrad
> Acked-by: Viacheslav Ovsiienko
> ---
> drivers/vdpa/mlx5/mlx5_vdpa.c |
On 1/29/20 11:08 AM, Matan Azrad wrote:
> Add a new driver to support vDPA operations by Mellanox devices.
>
> The first Mellanox devices which support vDPA operations are
> ConnectX6DX and Bluefield1 HCA for their PF ports and VF ports.
>
> This driver is depending on rdma-core like the mlx5
Use the MLX5_ASSERT macros instead of the standard assert clause.
Depends on the RTE_LIBRTE_MLX5_DEBUG configuration option to define it.
If RTE_LIBRTE_MLX5_DEBUG is enabled MLX5_ASSERT is equal to RTE_VERIFY
to bypass the global CONFIG_RTE_ENABLE_ASSERT option.
If RTE_LIBRTE_MLX5_DEBUG is disabled
On Thu, 2020-01-30 at 15:17 +0100, Thomas Monjalon wrote:
> 30/01/2020 13:57, Luca Boccassi:
> > On Thu, 2020-01-30 at 13:33 +0100, Thomas Monjalon wrote:
> > > Hi,
> > >
> > > I disagree with the need of this patch.
> > > The symbol was experimental, meaning we can change it.
> > > Removing exper
Use the RTE_LIBRTE_MLX5_DEBUG configuration flag to get rid of dependency
on the NDEBUG definition. This is a preparation step to switch
from standard assert clauses to DPDK RTE_ASSERT ones in MLX5 driver.
Signed-off-by: Alexander Kozyrev
Acked-by: Viacheslav Ovsiienko
---
drivers/common/mlx5/M
Use the MLX4_ASSERT macros instead of the standard assert clause.
Depends on the RTE_LIBRTE_MLX4_DEBUG configuration option to define it.
If RTE_LIBRTE_MLX4_DEBUG is enabled MLX4_ASSERT is equal to RTE_VERIFY
to bypass the global CONFIG_RTE_ENABLE_ASSERT option.
If RTE_LIBRTE_MLX4_DEBUG is disabled
The Mellanox PMD uses the NDEBUG definition to control built-in debug
features including the asserting one. The DPDK uses a bit different
approach and provides RTE_ASSERT macro and appropriate global
configuration option: CONFIG_RTE_ENABLE_ASSERT.
The patch set introduces the MLX_ASSERT macros that
Remove -Werror-all flag in ICC configuration file to stop treating ICC
warnings as errors in DPDK due to many false positives. We are using
GCC and Clang as a benchmark for warnings anyway for simplification.
Suggested-by: Thomas Monjalon
Signed-off-by: Alexander Kozyrev
Acked-by: Viacheslav Ovs
Use the RTE_LIBRTE_MLX4_DEBUG compilation flag to get rid of dependency
on the NDEBUG definition. This is a preparation step to switch
from standard assert clauses to DPDK RTE_ASSERT ones in MLX4 driver.
Signed-off-by: Alexander Kozyrev
Acked-by: Viacheslav Ovsiienko
---
drivers/net/mlx4/Makefi
Adding the deprecation notice as reminder for next ABI breakage release
(20.11).
This one time breakage is required to be able to extend enum/define
without breaking ABI.
Signed-off-by: Ferruh Yigit
---
doc/guides/rel_notes/deprecation.rst | 14 ++
1 file changed, 14 insertions(+)
d
30/01/2020 13:57, Luca Boccassi:
> On Thu, 2020-01-30 at 13:33 +0100, Thomas Monjalon wrote:
> > Hi,
> >
> > I disagree with the need of this patch.
> > The symbol was experimental, meaning we can change it.
> > Removing experimental tag is not an ABI break.
>
> Hi,
>
> This symbol change was re
1 - 100 of 131 matches
Mail list logo
