Re: [dpdk-dev] Kni interface unable to receive ipv6 solicited node multicast addressed frames

2020-01-24 Thread Srinivasan J
Calling rte_eth_allmulticast_enable() in the DPDK KNI sample app solved the issue. Sharing the fix so that it will be helpful for others facing similar issue. Regards, Srini /dpdk-stable-18.08.1/examples/kni/main.c @@ -618,8 +619,10 @@ rte_exit(EXIT_FAILURE, "Could not start port

Re: [dpdk-dev] coding style question - c99 comments

2020-01-24 Thread Lance Richardson
Thanks, a patch adding C99_COMMENT_TOLERANCE has been posted. Lance On Fri, Jan 24, 2020 at 12:10 PM Ferruh Yigit wrote: > On 1/23/2020 4:43 PM, Lance Richardson wrote: > > On Thu, Jan 23, 2020 at 11:15 AM Stephen Hemminger > > wrote: > >> > >> On Thu, 23 Jan 2020 11:05:58 -0500 > >> Lance

[dpdk-dev] [PATCH] devtools: check c99 comment use in checkpatches.sh

2020-01-24 Thread Lance Richardson
C99-style comments are not permitted according to DPDk coding style guidelines, enable checking for these by checkpatch.pl. Signed-off-by: Lance Richardson --- devtools/checkpatches.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/devtools/checkpatches.sh b/devtools/checkpa

[dpdk-dev] [PATCH] app/test: add test for mbuf with pinned external buffer

2020-01-24 Thread Viacheslav Ovsiienko
This patch adds unit test for the mbufs allocated from the special pool with pinned external data buffers. The pinned buffer mbufs are tested in the same way as regular ones with taking into account some specifics of cloning/attaching. Signed-off-by: Viacheslav Ovsiienko --- app/test/test_mbuf.

Re: [dpdk-dev] [PATCH v2 1/5] mk/icc: disable treatment of warnings as errors

2020-01-24 Thread Thomas Monjalon
24/01/2020 17:36, Ferruh Yigit: > On 1/23/2020 6:20 PM, Alexander Kozyrev wrote: > > Remove -Werror-all flag in ICC configuration file to stop treating ICC > > warnings as errors in DPDK due to many false positives. We are using > > GCC and Clang as a benchmark for warnings anyway for simplificatio

Re: [dpdk-dev] coding style question - c99 comments

2020-01-24 Thread Ferruh Yigit
On 1/23/2020 4:43 PM, Lance Richardson wrote: > On Thu, Jan 23, 2020 at 11:15 AM Stephen Hemminger > wrote: >> >> On Thu, 23 Jan 2020 11:05:58 -0500 >> Lance Richardson wrote: >> >>> The DPDK Coding Style document doesn't mention the use of c99 comments >>> using '//' as a comment delimiter, but

[dpdk-dev] [PATCH v2] eal/mem: preallocate VA space in no-huge mode

2020-01-24 Thread Anatoly Burakov
When --no-huge mode is used, the memory is currently allocated with mmap(NULL, ...). This is fine in most cases, but can fail in cases where DPDK is run on a machine with an IOMMU that is of more limited address width than that of a VA, because we're not specifying the address hint for mmap() call.

Re: [dpdk-dev] [PATCH v2 2/5] net/mlx4: use mlx4 debug flag instead of NDEBUG

2020-01-24 Thread Bruce Richardson
On Fri, Jan 24, 2020 at 04:50:51PM +, Slava Ovsiienko wrote: > > -Original Message- > > From: Ferruh Yigit > > Sent: Friday, January 24, 2020 18:43 > > To: Alexander Kozyrev ; dev@dpdk.org > > Cc: Raslan Darawsheh ; Matan Azrad > > ; Slava Ovsiienko ; > > Thomas Monjalon ; Bruce Richar

[dpdk-dev] [PATCH] eal/mem: preallocate VA space in no-huge mode

2020-01-24 Thread Anatoly Burakov
When --no-huge mode is used, the memory is currently allocated with mmap(NULL, ...). This is fine in most cases, but can fail in cases where DPDK is run on a machine with an IOMMU that is of more limited address width than that of a VA, because we're not specifying the address hint for mmap() call.

Re: [dpdk-dev] [PATCH v2 2/5] net/mlx4: use mlx4 debug flag instead of NDEBUG

2020-01-24 Thread Slava Ovsiienko
> -Original Message- > From: Ferruh Yigit > Sent: Friday, January 24, 2020 18:43 > To: Alexander Kozyrev ; dev@dpdk.org > Cc: Raslan Darawsheh ; Matan Azrad > ; Slava Ovsiienko ; > Thomas Monjalon ; Bruce Richardson > > Subject: Re: [PATCH v2 2/5] net/mlx4: use mlx4 debug flag instead of

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] net/tap: fix memory leak when unregister intr handler

2020-01-24 Thread Ferruh Yigit
On 1/21/2020 4:14 PM, Ferruh Yigit wrote: > On 1/21/2020 2:12 AM, Yunjian Wang wrote: >> The return check of function tap_lsc_intr_handle_set() is wrong, it should >> be 0 or a positive number if success. So the intr_handle->intr_vec was not >> been freed when tap_lsc_intr_handle_set() returned a p

Re: [dpdk-dev] [PATCH v2 2/5] net/mlx4: use mlx4 debug flag instead of NDEBUG

2020-01-24 Thread Ferruh Yigit
On 1/23/2020 6:20 PM, Alexander Kozyrev wrote: > Define a new MLX4_DEBUG compilation flag to get rid of dependency > on the NDEBUG definition. This is a preparation step to switch > from standard assert clauses to DPDK RTE_ASSERT ones in MLX4 driver. > > Signed-off-by: Alexander Kozyrev > Acked-b

Re: [dpdk-dev] [PATCH v2 1/5] mk/icc: disable treatment of warnings as errors

2020-01-24 Thread Ferruh Yigit
On 1/23/2020 6:20 PM, Alexander Kozyrev wrote: > Remove -Werror-all flag in ICC configuration file to stop treating ICC > warnings as errors in DPDK due to many false positives. We are using > GCC and Clang as a benchmark for warnings anyway for simplification. > > Suggested-by: Thomas Monjalon >

Re: [dpdk-dev] [PATCH 2/2] build: remove warnings for builds with icc

2020-01-24 Thread Bruce Richardson
On Fri, Jan 24, 2020 at 03:51:16PM +, Burakov, Anatoly wrote: > On 24-Jan-20 3:37 PM, Bruce Richardson wrote: > > While icc builds without the "werror" setting build successfully, there are > > a lot of warnings. To make the output cleaner, and to allow building with > > warnings enabled, we ca

Re: [dpdk-dev] [dpdk-stable] [PATCH 2/2] app/testpmd: fix invalid port detaching

2020-01-24 Thread Ferruh Yigit
On 1/23/2020 7:25 PM, Matan Azrad wrote: > Hi > > From: Ferruh Yigit >> On 1/23/2020 3:29 PM, Matan Azrad wrote: >>> >>> Hi >>> >>> From: Ferruh Yigit On 1/23/2020 2:05 PM, Matan Azrad wrote: > Hi > > From: Yigit, Ferruh >> On 11/12/2019 8:47 AM, Matan Azrad wrote: >>> The

Re: [dpdk-dev] [PATCH 2/2] build: remove warnings for builds with icc

2020-01-24 Thread Burakov, Anatoly
On 24-Jan-20 3:37 PM, Bruce Richardson wrote: While icc builds without the "werror" setting build successfully, there are a lot of warnings. To make the output cleaner, and to allow building with warnings enabled, we can add a list of warning ids to ignore. Signed-off-by: Bruce Richardson ---

[dpdk-dev] [PATCH 2/2] build: remove warnings for builds with icc

2020-01-24 Thread Bruce Richardson
While icc builds without the "werror" setting build successfully, there are a lot of warnings. To make the output cleaner, and to allow building with warnings enabled, we can add a list of warning ids to ignore. Signed-off-by: Bruce Richardson --- config/meson.build | 6 ++ 1 file changed, 6

[dpdk-dev] [PATCH 0/2] remove compiler warnings with icc using meson

2020-01-24 Thread Bruce Richardson
While icc can compile DPDK successfully using a meson/ninja build, there are a lot of warnings issued in the process, which means that any use of werror flag will break the build, and the output just looks messy and possibly worrying to the user. To improve this situation, we can fix the warnings

[dpdk-dev] [PATCH 1/2] net/octeontx2: check compiler flag before use

2020-01-24 Thread Bruce Richardson
Rather than assuming all compilers support the -flax-vector-extensions flag, we should test this before using it, thereby potentially avoiding warnings. Cc: jer...@marvell.com Signed-off-by: Bruce Richardson --- drivers/net/octeontx2/meson.build | 4 +--- 1 file changed, 1 insertion(+), 3 delet

Re: [dpdk-dev] [PATCH v4] build: allow using wildcards to disable drivers

2020-01-24 Thread Robin Jarry
2020-01-24, Bruce Richardson: > Rather than having to explicitly list each and every driver to disable in a > build, we can use a small python script and the python glob library to > expand out the wildcards. This means that we can configure meson using e.g. > > meson -Ddisable_drivers=crypto/

[dpdk-dev] [PATCH v4] build: allow using wildcards to disable drivers

2020-01-24 Thread Bruce Richardson
Rather than having to explicitly list each and every driver to disable in a build, we can use a small python script and the python glob library to expand out the wildcards. This means that we can configure meson using e.g. meson -Ddisable_drivers=crypto/*,event/* build to do a build omitting

Re: [dpdk-dev] [PATCH v3] build: allow using wildcards to disable drivers

2020-01-24 Thread Richardson, Bruce
> -Original Message- > From: Robin Jarry > Sent: Friday, January 24, 2020 12:28 PM > To: Richardson, Bruce > Cc: dev@dpdk.org; tho...@monjalon.net > Subject: Re: [PATCH v3] build: allow using wildcards to disable drivers > > 2020-01-24, Bruce Richardson: > > Rather than having to expl

[dpdk-dev] [PATCH] net/octeontx2: disable HIGIG on port stop

2020-01-24 Thread kirankumark
From: Kiran Kumar K If HIGIG mode is enabled on configure, This needs to be disabled on port stop. Adding support to send mbox message on port stop to configure the port to default. Signed-off-by: Kiran Kumar K --- drivers/net/octeontx2/otx2_ethdev.c | 9 +++-- 1 file changed, 7 insertions

Re: [dpdk-dev] [PATCH v2] net/enic: use RTE min and max macros

2020-01-24 Thread Ferruh Yigit
On 1/21/2020 8:35 PM, John Daley wrote: > Use the RTE_MIN and RTE_MAX macros instead of private macros. > > Signed-off-by: John Daley > Reviewed-by: Hyong Youb Kim Applied to dpdk-next-net/master, thanks. (Applied as incremental patch, instead of v2, since v1 is already in main repo)

Re: [dpdk-dev] [PATCH v3] build: allow using wildcards to disable drivers

2020-01-24 Thread Robin Jarry
2020-01-24, Bruce Richardson: > Rather than having to explicitly list each and every driver to disable in a > build, we can use a small python script and the python glob library to > expand out the wildcards. This means that we can configure meson using e.g. > > meson -Ddisable_drivers=crypto/

Re: [dpdk-dev] [PATCH v3 3/3] lib: use RTE_DIM to calculate array size

2020-01-24 Thread Laatz, Kevin
> From: Pavan Nikhilesh > > use RTE_DIM to calculate array size. > > Suggested-by: David Marchand > Signed-off-by: Pavan Nikhilesh > Acked-by: Cristian Dumitrescu > --- > lib/librte_ethdev/rte_ethdev.c | 8 +++- > lib/librte_ip_frag/ip_frag_internal.c| 5 ++-

[dpdk-dev] [PATCH v3] build: allow using wildcards to disable drivers

2020-01-24 Thread Bruce Richardson
Rather than having to explicitly list each and every driver to disable in a build, we can use a small python script and the python glob library to expand out the wildcards. This means that we can configure meson using e.g. meson -Ddisable_drivers=crypto/*,event/* build to do a build omitting

Re: [dpdk-dev] [PATCH v2] usertools: fix telemetry python3 compatibility

2020-01-24 Thread Laatz, Kevin
> The client script for use with the telemetry library did not support > Python3, as the data being sent over the socket was in string format. > Python3 requires the data be explicitly converted to bytes before being > sent. Similarily, the received bytes need to be decoded into string > format. >