[dpdk-dev] [PATCH] doc: update qede PMD guide

2019-11-21 Thread Rasesh Mody
- Add note for Co-existence of DPDK and Linux drivers. - Update the firmware version in example. - Add Config note for potential error due to lack of memzone desciptor count. Signed-off-by: Rasesh Mody --- doc/guides/nics/qede.rst | 25 - 1 file changed, 20 insertio

Re: [dpdk-dev] [PATCH v7 09/10] build: change ABI version to 20.0

2019-11-21 Thread Sachin Saxena
> -Original Message- > From: David Marchand > Sent: Wednesday, November 20, 2019 3:20 AM > To: Anatoly Burakov ; Thomas Monjalon > > Cc: dev ; Hemant Agrawal ; > Sachin Saxena ; Stephen Hemminger > ; Mcnamara, John > ; Kinsella, Ray ; Bruce > Richardson > Subject: Re: [PATCH v7 09/10] bu

[dpdk-dev] [PATCH v2 5/5] crypto/ccp: fix capabilities for digest size

2019-11-21 Thread asomalap
From: Amaranath Somalapuram CCP can support varied digest sizes ranging from 1 to some max value But the current code support only fixed max values. This patch updates the minimum digest sizes to 1 Fixes: e0d88a394e ("crypto/ccp: support run-time CPU based auth") Cc: sta...@dpdk.org Signed-off-

[dpdk-dev] [PATCH v2 4/5] crypto/ccp: fix support scheduling CCP's on burst

2019-11-21 Thread asomalap
From: Amaranath Somalapuram CCP driver was scheduling only one CCP in a single burst(enqueue). Effective throughput was limited to 1 CCP performance. Scheduling multiple ccp within one burst will increase the ccp performance. this changes will divide the enqueue packets equally among the multiple

[dpdk-dev] [PATCH v2 3/5] crypto/ccp: fix CCP CPU authentication crash

2019-11-21 Thread asomalap
From: Amaranath Somalapuram when ccp_auth_opt=1 is set and if authentication error occurred ccp driver crash. The enqueue referance count nb_ops miss match with dequeue nb_ops on authentication error Fixes: e0d88a394e ("crypto/ccp: support run-time CPU based auth") Cc: sta...@dpdk.org Signed-of

[dpdk-dev] [PATCH v2 2/5] crypto/ccp: fix update max qp and burst size

2019-11-21 Thread asomalap
From: Amaranath Somalapuram CCP driver crash when running l2fwd issue happen when changing MAX_PKT_BURST 32 to 256 increacing the CCP qp to 8 and CCP_MAX_BURST to 256 Fixes: ef4b04f87f ("crypto/ccp: support device init") Cc: sta...@dpdk.org Signed-off-by: Amaranath Somalapuram --- drivers/cry

[dpdk-dev] [PATCH v2 1/5] doc: fix app usage in CCP guide

2019-11-21 Thread asomalap
From: Amaranath Somalapuram Updateing the CCP doc, fixing description of some parameter. Changing AES_CBC to aes-cbc, SHA1_HMAC to sha1-hmac Fixes: 4433ced9aa ("doc: add AMD CCP guide") Cc: sta...@dpdk.org Signed-off-by: Amaranath Somalapuram --- doc/guides/cryptodevs/ccp.rst | 32 +++

[dpdk-dev] [PATCH v1] hash: added a new API to hash to query key id

2019-11-21 Thread Kumar Amber
Adding new API function to query the maximum key ID that could possibly returned by add_key_functions. When multi_key_add flag set, the maximum key id is larger than the entry count specified by the user. Signed-off-by: Kumar Amber --- lib/librte_hash/rte_cuckoo_hash.c| 15 +++ l

[dpdk-dev] [Bug 368] missing character in document l2_forward_event.rst

2019-11-21 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=368 Pavan Nikhilesh Bhagavatula (pbhagavat...@marvell.com) changed: What|Removed |Added CC||pbhagavat.

[dpdk-dev] [PATCH V1] doc: add tested Intel platforms with Intel NICs

2019-11-21 Thread Chen, Zhaoyan
From: Wenjie Li Add tested Intel platforms with Intel NICs to v19.11 release note. Signed-off-by: Wenjie Li --- doc/guides/rel_notes/release_19_11.rst | 89 ++ 1 file changed, 89 insertions(+) diff --git a/doc/guides/rel_notes/release_19_11.rst b/doc/guides/rel_notes/

Re: [dpdk-dev] [PATCH v2] net/mlx5: fix incorrect L3/L4 layer chosen with tunnel

2019-11-21 Thread Suanming Mou
On 11/21/2019 8:09 PM, Suanming Mou wrote: > For tunnel mode, there maybe two L3/L4 layer match pattern items, > the inner layer follows the outer layer as the latter layer item, > the TTL and port modify actions should handle the outermost layer. > > Current the outer and inner L3/L4 layers are bo

Re: [dpdk-dev] [PATCH v2 3/3] net/bnxt: fix to free all the vnics during port stop

2019-11-21 Thread Ajit Khaparde
On Thu, Nov 21, 2019 at 3:35 PM Ajit Khaparde wrote: > From: Somnath Kotur > > Now that vnics are created only as part of the flow creation cmds > and not during init, we cannot rely on iterating only through > 'nr_vnics'. We need to sweep all the vnics by using 'max_vnics' > otherwise a vnic wi

[dpdk-dev] [PATCH v2 1/3] doc: update bnxt feature list

2019-11-21 Thread Ajit Khaparde
Updating bnxt.ini file. These features were added earlier under the following commits. 1) 94d4afd2d167 ("net/bnxt: advertise scatter Rx offload capability") 2) 57d5e5bc86e4 ("net/bnxt: add statistics") 3) 88920136688c ("net/bnxt: support xstats get by id") Signed-off-by: Ajit Khaparde --- doc/gu

[dpdk-dev] [PATCH v2 3/3] net/bnxt: fix to free all the vnics during port stop

2019-11-21 Thread Ajit Khaparde
From: Somnath Kotur Now that vnics are created only as part of the flow creation cmds and not during init, we cannot rely on iterating only through 'nr_vnics'. We need to sweep all the vnics by using 'max_vnics' otherwise a vnic with a stale 'rx_queue_cnt' might be left lingering post a port stop

[dpdk-dev] [PATCH v2 2/3] doc: update release notes for Broadcom PMD

2019-11-21 Thread Ajit Khaparde
Update release doc briefly describing updates to bnxt PMD for 19.11 release. The support for these was added in the following commits: 1) b150a7e7ee66 ("net/bnxt: support LRO on Thor adapters") 2) be14720def9c ("net/bnxt: support FW reset") 3) df6cd7c1f73a ("net/bnxt: handle reset notify async eve

Re: [dpdk-dev] [PATCH v2 3/3] ethdev: improve flow mark Rx offload deprecation notice

2019-11-21 Thread Thomas Monjalon
19/11/2019 13:12, Andrew Rybchenko: > The deprecation notice is required since it adds more requirements > when RTE flow mark and flag actions may be used and require > changes in applications. I am still not sure what is the best solution here. I continued to think about it in this thread:

Re: [dpdk-dev] [PATCH] app/testpmd: reduce memory consumption

2019-11-21 Thread Thomas Monjalon
21/11/2019 22:25, Thomas Monjalon: > 21/11/2019 16:12, David Marchand: > > Following [1], testpmd memory consumption has skyrocketted. > > The rte_port structure has gotten quite fat. > > > > struct rte_port { > > [...] > > struct rte_eth_rxconf rx_conf[65536];/* 266280 3145728 */ >

Re: [dpdk-dev] [PATCH] app/testpmd: reduce memory consumption

2019-11-21 Thread Thomas Monjalon
21/11/2019 16:12, David Marchand: > Following [1], testpmd memory consumption has skyrocketted. > The rte_port structure has gotten quite fat. > > struct rte_port { > [...] > struct rte_eth_rxconf rx_conf[65536];/* 266280 3145728 */ > /* --- cacheline 53312 boundary (3411968 bytes)

Re: [dpdk-dev] [PATCH] app/testpmd: reduce memory consumption

2019-11-21 Thread Thomas Monjalon
21/11/2019 17:23, David Marchand: > On Thu, Nov 21, 2019 at 5:17 PM David Marchand > wrote: > > > > On Thu, Nov 21, 2019 at 4:36 PM Ferruh Yigit wrote: > > > > diff --git a/app/test-pmd/testpmd.h b/app/test-pmd/testpmd.h > > > > index 90694a3309..217d577018 100644 > > > > --- a/app/test-pmd/testp

Re: [dpdk-dev] [dpdk-stable] [PATCH] mk: remove library search path from binary

2019-11-21 Thread Thomas Monjalon
21/11/2019 18:12, Ferruh Yigit: > On 11/18/2019 3:14 PM, Thomas Monjalon wrote: > > 12/11/2019 14:15, Ferruh Yigit: > >> This patch functionally reverts the patch in fixes line to not have any > >> hardcoded library path in the final binary for the security reasons, in > >> case this binary distrib

Re: [dpdk-dev] [PATCH v4] net/ice: add flow mark hint support

2019-11-21 Thread Thomas Monjalon
21/11/2019 13:40, Zhang, Qi Z: > From: Thomas Monjalon > > 21/11/2019 02:19, Zhang, Qi Z: > > > From: Thomas Monjalon > > > > 19/11/2019 07:14, Qi Zhang: > > > > > Since not all data paths support flow mark, the driver needs a > > > > > hint from application to select the correct data path if flo

Re: [dpdk-dev] [PATCH] app/testpmd: reduce memory consumption

2019-11-21 Thread David Marchand
On Thu, Nov 21, 2019 at 5:45 PM Stephen Hemminger wrote: > > On Thu, 21 Nov 2019 16:12:55 +0100 > David Marchand wrote: > > > - uint16_tnb_rx_desc[MAX_QUEUE_ID+1]; /**< per queue rx > > desc number */ > > - uint16_tnb_tx_desc[MAX_QUEUE_ID+1]; /**< per queu

[dpdk-dev] [PATCH] app/testpmd: use rte_rand() instead of random()

2019-11-21 Thread pbhagavatula
From: Pavan Nikhilesh Use rte_rand() instead of random() for better randomness. Coverity Issue: 337666 Signed-off-by: Pavan Nikhilesh --- app/test-pmd/txonly.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test-pmd/txonly.c b/app/test-pmd/txonly.c index 539043c34..3c

[dpdk-dev] [PATCH 1/2] app/test-eventdev: fix possible divide by zero

2019-11-21 Thread pbhagavatula
From: Pavan Nikhilesh Fix possible divide by zero condition when calculating percentages. Coverity Issue: 277205 Coverity Issue: 277234 Fixes: d008f20bce23 ("app/eventdev: add event timer adapter as a producer") Cc: sta...@dpdk.org Signed-off-by: Pavan Nikhilesh --- app/test-eventdev/test_per

[dpdk-dev] [PATCH 2/2] app/test-evnetdev: fix unchecked return value

2019-11-21 Thread pbhagavatula
From: Pavan Nikhilesh Fix unchecked return values reported by coverity. Coverity Issue: 336861 Coverity Issue: 349906 Fixes: 032a965a8f1d ("app/eventdev: support Tx adapter") Cc: sta...@dpdk.org Signed-off-by: Pavan Nikhilesh --- app/test-eventdev/test_pipeline_common.c | 17 ++---

[dpdk-dev] memif: extra link_get in secondary

2019-11-21 Thread Stephen Hemminger
What is this code doing (why query link status)? static uint16_t eth_memif_rx_zc(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts) { ... struct rte_eth_link link; if (unlikely((pmd->flags & ETH_MEMIF_FLAG_CONNECTED) == 0)) return 0; if (unlikely(ring

[dpdk-dev] [PATCH v2] mbuf: display more fields in dump

2019-11-21 Thread Stephen Hemminger
The rte_pktmbuf_dump should display offset, refcount, and vlan info since these are often useful during debugging. Signed-off-by: Stephen Hemminger --- v2 - remove casts, change in_port to port the refcount and offset are property of per-segment lib/librte_mbuf/rte_mbuf.c | 17 ++--

[dpdk-dev] [PATCH 1/2] examples/l2fwd-event: validate function return values

2019-11-21 Thread pbhagavatula
From: Pavan Nikhilesh Validate `rte_eth_link_get_nowait`, `rte_service_map_lcore_set` and `rte_eth_dev_info_get` return values. Coverity issue: 350600 Coverity issue: 350601 Coverity issue: 350602 Signed-off-by: Pavan Nikhilesh --- examples/l2fwd-event/l2fwd_common.c | 6 +- examples/l2f

[dpdk-dev] [PATCH 2/2] doc: fix incorrect command line arguments in l2fwd-event

2019-11-21 Thread pbhagavatula
From: Pavan Nikhilesh Fix incorrect command line argument documented for l2fwd-event. Bugzilla ID: 367 Bugzilla ID: 368 Fixes: 14d7ea259aeb ("doc: add application usage guide for l2fwd-event") Reported-by: Vipin Varghese Signed-off-by: Pavan Nikhilesh --- doc/guides/sample_app_ug/l2_forward_

[dpdk-dev] [PATCH] lib/hash: remove unnecessary locks in lock-free

2019-11-21 Thread Dharmik Thakkar
Remove __hash_rw_reader_unlock() calls from lock free hash lookup Signed-off-by: Dharmik Thakkar Reviewed-by: Gavin Hu Reviewed-by: Honnappa Nagarahalli --- lib/librte_hash/rte_cuckoo_hash.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/lib/librte_hash/rte_cuckoo_

[dpdk-dev] [PATCH] net/mlx5: fix get metadata register for E-Switch domain

2019-11-21 Thread Viacheslav Ovsiienko
The metadata register used for META item/action within E-Switch steering domain should be altered depending on dv_xmeta_en devarg value. Fixes: 3e8edd0ef848 ("net/mlx5: update metadata register ID query") Signed-off-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5_flow.c | 10 +- 1 fi

Re: [dpdk-dev] [dpdk-stable] [PATCH] mk: remove library search path from binary

2019-11-21 Thread Ferruh Yigit
On 11/18/2019 3:14 PM, Thomas Monjalon wrote: > 12/11/2019 14:15, Ferruh Yigit: >> This patch functionally reverts the patch in fixes line to not have any >> hardcoded library path in the final binary for the security reasons, in >> case this binary distributed to production environment. > > What

Re: [dpdk-dev] [PATCH] mbuf: display more fields in dump

2019-11-21 Thread Morten Brørup
I think the name also changed from in_port.Sent from a smartphone. Please pardon brevity and spelling. Oprindelig besked Fra: Stephen Hemminger Dato: 21/11/2019 17.43 (GMT+01:00) Til: Morten Brørup Cc: dev@dpdk.org Emne: Re: [dpdk-dev] [PATCH] mbuf: display more fields in d

Re: [dpdk-dev] [PATCH] doc: minor fixes in tap guide

2019-11-21 Thread Stephen Hemminger
On Thu, 21 Nov 2019 14:27:01 +0100 Andrzej Ostruszka wrote: > Corrected one typo and ip address. > > Signed-off-by: Andrzej Ostruszka > > Fixes: de96fe68ae95 ("net/tap: add basic flow API patterns and actions") > Cc: sta...@dpdk.org > --- > doc/guides/nics/tap.rst | 4 ++-- > 1 file changed,

Re: [dpdk-dev] [PATCH] app/testpmd: reduce memory consumption

2019-11-21 Thread Stephen Hemminger
On Thu, 21 Nov 2019 16:12:55 +0100 David Marchand wrote: > - uint16_tnb_rx_desc[MAX_QUEUE_ID+1]; /**< per queue rx > desc number */ > - uint16_tnb_tx_desc[MAX_QUEUE_ID+1]; /**< per queue tx > desc number */ > - struct rte_eth_rxconf rx_conf[MAX_QUEU

Re: [dpdk-dev] [PATCH] mbuf: display more fields in dump

2019-11-21 Thread Stephen Hemminger
On Thu, 21 Nov 2019 17:16:42 +0100 Morten Brørup wrote: > Are all these explicit type casts really needed? buf_iova is already > uint64_t, buflen is uint16_t, data_off is uint16_t, rte_mbuf_refcnt_read() > returns uint16_t, pkt_len is uint32_t, nb_segs is uint16_t, port is uint16_t, > vlan_tci

Re: [dpdk-dev] [dpdk-stable] [PATCH] doc: minor fixes in tap guide

2019-11-21 Thread Ferruh Yigit
On 11/21/2019 1:27 PM, Andrzej Ostruszka wrote: > Corrected one typo and ip address. > > Signed-off-by: Andrzej Ostruszka > > Fixes: de96fe68ae95 ("net/tap: add basic flow API patterns and actions") > Cc: sta...@dpdk.org Reviewed-by: Ferruh Yigit Applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH] app/testpmd: reduce memory consumption

2019-11-21 Thread David Marchand
On Thu, Nov 21, 2019 at 5:17 PM David Marchand wrote: > > On Thu, Nov 21, 2019 at 4:36 PM Ferruh Yigit wrote: > > > diff --git a/app/test-pmd/testpmd.h b/app/test-pmd/testpmd.h > > > index 90694a3309..217d577018 100644 > > > --- a/app/test-pmd/testpmd.h > > > +++ b/app/test-pmd/testpmd.h > > > @@

Re: [dpdk-dev] [PATCH] app/testpmd: reduce memory consumption

2019-11-21 Thread David Marchand
On Thu, Nov 21, 2019 at 4:36 PM Ferruh Yigit wrote: > > diff --git a/app/test-pmd/testpmd.h b/app/test-pmd/testpmd.h > > index 90694a3309..217d577018 100644 > > --- a/app/test-pmd/testpmd.h > > +++ b/app/test-pmd/testpmd.h > > @@ -58,8 +58,6 @@ typedef uint16_t portid_t; > > typedef uint16_t queu

Re: [dpdk-dev] [PATCH] mbuf: display more fields in dump

2019-11-21 Thread Morten Brørup
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Stephen Hemminger > Sent: Wednesday, November 20, 2019 6:41 PM > > The rte_pktmbuf_dump should display offset, refcount, and vlan > info since these are often useful during debugging. > > Signed-off-by: Stephen He

Re: [dpdk-dev] [PATCH] app/testpmd: reduce memory consumption

2019-11-21 Thread Ferruh Yigit
On 11/21/2019 3:12 PM, David Marchand wrote: > Following [1], testpmd memory consumption has skyrocketted. > The rte_port structure has gotten quite fat. > > struct rte_port { > [...] > struct rte_eth_rxconf rx_conf[65536];/* 266280 3145728 */ > /* --- cacheline 53312 boundary (341

Re: [dpdk-dev] [PATCH] malloc: fix memory element size in case of padding

2019-11-21 Thread Burakov, Anatoly
On 21-Nov-19 2:25 PM, Xueming Li wrote: This patch fixes wrong inner memory element size when joining two elements. Fixes: af75078fece3 ("first public release") Cc: sta...@dpdk.org Signed-off-by: Xueming Li --- lib/librte_eal/common/malloc_elem.c | 4 1 file changed, 4 insertions(+) d

[dpdk-dev] [PATCH] app/testpmd: reduce memory consumption

2019-11-21 Thread David Marchand
Following [1], testpmd memory consumption has skyrocketted. The rte_port structure has gotten quite fat. struct rte_port { [...] struct rte_eth_rxconf rx_conf[65536];/* 266280 3145728 */ /* --- cacheline 53312 boundary (3411968 bytes) was 40 bytes ago --- */ struct rte_eth_txconf

Re: [dpdk-dev] [PATCH] net/mlx5: fix selection between encap and decap

2019-11-21 Thread Raslan Darawsheh
Hi, > -Original Message- > From: dev On Behalf Of Ori Kam > Sent: Thursday, November 21, 2019 3:19 PM > To: Matan Azrad ; Shahaf Shuler > ; Slava Ovsiienko > Cc: dev@dpdk.org; Ori Kam ; Dekel Peled > ; Bing Zhao > Subject: [dpdk-dev] [PATCH] net/mlx5: fix selection between encap and > de

Re: [dpdk-dev] [PATCH v2] net/ixgbe: fix QoS performance drop issue

2019-11-21 Thread Ye Xiaolong
On 11/21, Shougang Wang wrote: >Currently macsec offload will be enabled all the time >when device start. It will cause QoS sample application >performance drop issue. This patch add check before this >feature enabled. > >Fixes: 50556c88104c ("net/ixgbe: fix MACsec setting") > >Signed-off-by: Shoug

Re: [dpdk-dev] [PATCH v2] mbuf: extend pktmbuf pool private structure

2019-11-21 Thread Olivier Matz
On Thu, Nov 21, 2019 at 12:28:18PM +, Shahaf Shuler wrote: > With the API and ABI freeze ahead, it will be good to reserve > some bits on the private structure for future use. > > Otherwise we will potentially need to maintain two different > private structure during 2020 period. > > There is

Re: [dpdk-dev] [PATCH] net/virtio-user: drop attribute "unused" for memory callback

2019-11-21 Thread Ferruh Yigit
On 11/21/2019 12:55 AM, Maxime Coquelin wrote: > > > On 11/19/19 8:12 AM, Tiwei Bie wrote: >> The "addr" param has been used since the event callbacks are enabled >> for external memory. So the "__rte_unused" should be dropped. >> >> Besides, slightly refine the coding style by consistently assum

[dpdk-dev] [PATCH] malloc: fix memory element size in case of padding

2019-11-21 Thread Xueming Li
This patch fixes wrong inner memory element size when joining two elements. Fixes: af75078fece3 ("first public release") Cc: sta...@dpdk.org Signed-off-by: Xueming Li --- lib/librte_eal/common/malloc_elem.c | 4 1 file changed, 4 insertions(+) diff --git a/lib/librte_eal/common/malloc_ele

Re: [dpdk-dev] [PATCH] mbuf: extend pktmbuf pool private structure

2019-11-21 Thread Olivier Matz
Hi, On Wed, Nov 20, 2019 at 07:56:14AM -0800, Stephen Hemminger wrote: > On Wed, 20 Nov 2019 07:01:26 + > Shahaf Shuler wrote: > > > Wednesday, November 20, 2019 1:51 AM, Stephen Hemminger: > > > Subject: Re: [dpdk-dev] [PATCH] mbuf: extend pktmbuf pool private > > > structure > > > > > > O

Re: [dpdk-dev] [dpdk-stable] [PATCH 2/2] malloc: fix realloc padded element size

2019-11-21 Thread Xueming(Steven) Li
> -Original Message- > From: Burakov, Anatoly > Sent: Thursday, November 21, 2019 9:17 PM > To: Xueming(Steven) Li ; David Marchand > > Cc: Asaf Penso ; dev ; dpdk stable > > Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH 2/2] malloc: fix realloc padded > element size > > On 21-Nov-19 1

Re: [dpdk-dev] [dpdk-stable] [PATCH] testpmd: fix memory leak in iterator

2019-11-21 Thread Ferruh Yigit
On 11/21/2019 11:43 AM, Iremonger, Bernard wrote: >> -Original Message- >> From: dev On Behalf Of Stephen Hemminger >> Sent: Wednesday, November 20, 2019 11:26 PM >> To: dev@dpdk.org >> Cc: Stephen Hemminger ; >> ndabilpu...@marvell.com; sta...@dpdk.org >> Subject: [dpdk-dev] [PATCH] testp

Re: [dpdk-dev] [PATCH] net/mlx5: fix flow tag hash list conversion

2019-11-21 Thread Raslan Darawsheh
Hi, > -Original Message- > From: dev On Behalf Of Matan Azrad > Sent: Thursday, November 21, 2019 1:28 PM > To: dev@dpdk.org > Cc: Slava Ovsiienko > Subject: [dpdk-dev] [PATCH] net/mlx5: fix flow tag hash list conversion > > When DR is not supported and DV is supported, tag action still

[dpdk-dev] [PATCH] doc: minor fixes in tap guide

2019-11-21 Thread Andrzej Ostruszka
Corrected one typo and ip address. Signed-off-by: Andrzej Ostruszka Fixes: de96fe68ae95 ("net/tap: add basic flow API patterns and actions") Cc: sta...@dpdk.org --- doc/guides/nics/tap.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/guides/nics/tap.rst b/doc/guid

[dpdk-dev] [PATCH] net/mlx5: fix selection between encap and decap

2019-11-21 Thread Ori Kam
The current raw_encap function selects if to decap or encap based on the egress/ingress attribute. This concepts doesn't work in case of FDB since all flows are considered ingress. To solve this issue we moved to check the encap size. if the encap size is larger then eth + ipv4 it means we are try

Re: [dpdk-dev] [dpdk-stable] [PATCH 2/2] malloc: fix realloc padded element size

2019-11-21 Thread Burakov, Anatoly
On 21-Nov-19 1:15 PM, Burakov, Anatoly wrote: On 21-Nov-19 12:55 PM, Xueming(Steven) Li wrote: Hi Anatoly, -Original Message- From: Burakov, Anatoly Sent: Thursday, November 21, 2019 8:30 PM To: David Marchand ; Xueming(Steven) Li Cc: Asaf Penso ; dev ; dpdk stable Subject: Re: [dpd

Re: [dpdk-dev] [dpdk-stable] [PATCH 2/2] malloc: fix realloc padded element size

2019-11-21 Thread Burakov, Anatoly
On 21-Nov-19 12:55 PM, Xueming(Steven) Li wrote: Hi Anatoly, -Original Message- From: Burakov, Anatoly Sent: Thursday, November 21, 2019 8:30 PM To: David Marchand ; Xueming(Steven) Li Cc: Asaf Penso ; dev ; dpdk stable Subject: Re: [dpdk-stable] [PATCH 2/2] malloc: fix realloc padde

Re: [dpdk-dev] [PATCH] net/virtio-user: drop attribute "unused" for memory callback

2019-11-21 Thread Ferruh Yigit
On 11/21/2019 12:09 PM, Burakov, Anatoly wrote: > On 21-Nov-19 8:58 AM, Ferruh Yigit wrote: >> On 11/21/2019 12:55 AM, Maxime Coquelin wrote: >>> >>> >>> On 11/19/19 8:12 AM, Tiwei Bie wrote: The "addr" param has been used since the event callbacks are enabled for external memory. So the

Re: [dpdk-dev] [dpdk-stable] [PATCH 2/2] malloc: fix realloc padded element size

2019-11-21 Thread Xueming(Steven) Li
Hi Anatoly, > -Original Message- > From: Burakov, Anatoly > Sent: Thursday, November 21, 2019 8:30 PM > To: David Marchand ; Xueming(Steven) Li > > Cc: Asaf Penso ; dev ; dpdk stable > > Subject: Re: [dpdk-stable] [PATCH 2/2] malloc: fix realloc padded element size > > On 20-Nov-19 1:2

Re: [dpdk-dev] [PATCH v8 11/12] build: change ABI version to 20.0

2019-11-21 Thread David Marchand
On Wed, Nov 20, 2019 at 6:25 PM Anatoly Burakov wrote: > > From: Pawel Modrak > > Merge all vesions in linker version script files to DPDK_20.0. > > This commit was generated by running the following command: > > :~/DPDK$ buildtools/update-abi.sh 20.0 Updated map files for i40e and ipn3ke, follo

[dpdk-dev] [PATCH] app/crypto-perf: fix incorrect input data for AEAD decrypt

2019-11-21 Thread Archana Muniganti
In AEAD decrypt(verify mode), test data should point to cipher text instead of plain text Fixes: 5b2b0a740fba ("app/crypto-perf: overwrite mbuf when verifying") Signed-off-by: Archana Muniganti --- app/test-crypto-perf/cperf_test_verify.c | 14 +++--- 1 file changed, 11 insertions(+), 3

Re: [dpdk-dev] [PATCH] app/crypto-perf: fix incorrect input data for AEAD decrypt

2019-11-21 Thread Anoob Joseph
> -Original Message- > From: Archana Muniganti > Sent: Thursday, November 21, 2019 4:44 PM > To: akhil.go...@nxp.com; pablo.de.lara.gua...@intel.com > Cc: Archana Muniganti ; Anoob Joseph > ; Jerin Jacob Kollanukkaran ; > dev@dpdk.org; sta...@dpdk.org > Subject: [PATCH] app/crypto-perf: fi

Re: [dpdk-dev] [PATCH v4] net/ice: add flow mark hint support

2019-11-21 Thread Zhang, Qi Z
> -Original Message- > From: Thomas Monjalon > Sent: Thursday, November 21, 2019 3:37 PM > To: Zhang, Qi Z > Cc: dev@dpdk.org; Ye, Xiaolong ; Yigit, Ferruh > ; arybche...@solarflare.com; or...@mellanox.com > Subject: Re: [dpdk-dev] [PATCH v4] net/ice: add flow mark hint support > > 21

[dpdk-dev] [PATCH] doc: fix typo in EAL programmer's guide

2019-11-21 Thread Anatoly Burakov
The correct name for virt2memseg API is `rte_mem_virt2memseg`, not `rte_virt2memseg`. Fixes: 950e8fb4e194 ("mem: allow registering external memory areas") Cc: sta...@dpdk.org Signed-off-by: Anatoly Burakov --- doc/guides/prog_guide/env_abstraction_layer.rst | 2 +- 1 file changed, 1 insertion(+

Re: [dpdk-dev] [dpdk-stable] [PATCH 2/2] malloc: fix realloc padded element size

2019-11-21 Thread Burakov, Anatoly
On 20-Nov-19 1:25 PM, David Marchand wrote: On Wed, Nov 20, 2019 at 3:12 AM Xueming(Steven) Li wrote: -Original Message- From: David Marchand Sent: Wednesday, November 20, 2019 4:47 AM To: Xueming(Steven) Li ; Anatoly Burakov Cc: Asaf Penso ; dev ; dpdk stable Subject: Re: [dpdk-st

[dpdk-dev] [PATCH v2] mbuf: extend pktmbuf pool private structure

2019-11-21 Thread Shahaf Shuler
With the API and ABI freeze ahead, it will be good to reserve some bits on the private structure for future use. Otherwise we will potentially need to maintain two different private structure during 2020 period. There is already one use case for those reserved bits[1] The reserved field should b

[dpdk-dev] mbuf autotest fails with 19.11-rc3

2019-11-21 Thread Jerin Jacob Kollanukkaran
mbuf autotest fails with 19.11-rc3 $ echo "mbuf_autotest" | sudo ./build/app/test/dpdk-test -c 0x3 EAL: Detected 56 lcore(s) EAL: Detected 2 NUMA nodes EAL: Multi-process socket /var/run/dpdk/rte/mp_socket EAL: Selected IOVA mode 'PA' EAL: No available hugepages reported in hugepages-1048576kB EA

[dpdk-dev] [PATCH v2] net/mlx5: fix incorrect L3/L4 layer chosen with tunnel

2019-11-21 Thread Suanming Mou
For tunnel mode, there maybe two L3/L4 layer match pattern items, the inner layer follows the outer layer as the latter layer item, the TTL and port modify actions should handle the outermost layer. Current the outer and inner L3/L4 layers are both regared as the outer layer in flow_dv_attr_init()

Re: [dpdk-dev] [PATCH] net/virtio-user: drop attribute "unused" for memory callback

2019-11-21 Thread Burakov, Anatoly
On 21-Nov-19 8:58 AM, Ferruh Yigit wrote: On 11/21/2019 12:55 AM, Maxime Coquelin wrote: On 11/19/19 8:12 AM, Tiwei Bie wrote: The "addr" param has been used since the event callbacks are enabled for external memory. So the "__rte_unused" should be dropped. Besides, slightly refine the codin

Re: [dpdk-dev] [PATCH] testpmd: fix memory leak in iterator

2019-11-21 Thread Iremonger, Bernard
> -Original Message- > From: dev On Behalf Of Stephen Hemminger > Sent: Wednesday, November 20, 2019 11:26 PM > To: dev@dpdk.org > Cc: Stephen Hemminger ; > ndabilpu...@marvell.com; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH] testpmd: fix memory leak in iterator > > The RTE_FOREACH_MATC

[dpdk-dev] [PATCH] net/mlx5: fix flow tag hash list conversion

2019-11-21 Thread Matan Azrad
When DR is not supported and DV is supported, tag action still can be used by the metadata feature. Wrongly, the tag hash list was not created what caused failure in metadata action creation. Create the tag hash list for each DV case. Fixes: 860897d2895a ("net/mlx5: reorganize flow tables with h

Re: [dpdk-dev] [dpdk-stable] [PATCH v3 1/3] test/rcu: fix the compiling error for armv8.2

2019-11-21 Thread Gavin Hu (Arm Technology China)
> -Original Message- > From: Thomas Monjalon > Sent: Thursday, November 21, 2019 6:19 AM > To: Gavin Hu (Arm Technology China) ; Honnappa > Nagarahalli ; Steve Capper > > Cc: sta...@dpdk.org; dev@dpdk.org; nd ; > david.march...@redhat.com > Subject: Re: [dpdk-stable] [PATCH v3 1/3] test

[dpdk-dev] DPDK Release Status Meeting 21/11/2019

2019-11-21 Thread Ferruh Yigit
Minutes 21 November 2019 Agenda: * Release Dates * RC3 Status * Subtrees * OvS * Opens Participants: * Arm * Debian/Microsoft * Intel * Marvell * Mellanox * NXP * Red Hat Release Dates - * v19.11 dates: * RC3 is released on Wednesday 20 November * htt

Re: [dpdk-dev] [PATCH v8 00/12] Implement the new ABI policy and add helper scripts

2019-11-21 Thread Burakov, Anatoly
On 20-Nov-19 10:13 PM, David Marchand wrote: On Wed, Nov 20, 2019 at 9:17 PM Thomas Monjalon wrote: 20/11/2019 18:23, Anatoly Burakov: This patchset prepares the codebase for the new ABI policy and adds a few helper scripts. 379 files changed, 1172 insertions(+), 3409 deletions(-) Thanks

Re: [dpdk-dev] [PATCH] net/mlx5: fix incorrect L3 layer chosen in TTL action

2019-11-21 Thread Suanming Mou
> -Original Message- > From: Matan Azrad > Sent: Thursday, November 21, 2019 3:40 PM > To: Suanming Mou ; Slava Ovsiienko > > Cc: dev@dpdk.org; sta...@dpdk.org; Dekel Peled > Subject: RE: [PATCH] net/mlx5: fix incorrect L3 layer chosen in TTL action > > > Hi Mou > > From: Suanming

Re: [dpdk-dev] [PATCH] net/virtio-user: drop attribute "unused" for memory callback

2019-11-21 Thread Ferruh Yigit
On 11/21/2019 12:55 AM, Maxime Coquelin wrote: > > > On 11/19/19 8:12 AM, Tiwei Bie wrote: >> The "addr" param has been used since the event callbacks are enabled >> for external memory. So the "__rte_unused" should be dropped. >> >> Besides, slightly refine the coding style by consistently assum

Re: [dpdk-dev] [PATCH v2] net/ixgbe: fix QoS performance drop issue

2019-11-21 Thread Ye Xiaolong
On 11/21, Shougang Wang wrote: >Currently macsec offload will be enabled all the time >when device start. It will cause QoS sample application >performance drop issue. This patch add check before this >feature enabled. > >Fixes: 50556c88104c ("net/ixgbe: fix MACsec setting") > >Signed-off-by: Shoug

[dpdk-dev] [PATCH v2] net/ixgbe: fix QoS performance drop issue

2019-11-21 Thread Shougang Wang
Currently macsec offload will be enabled all the time when device start. It will cause QoS sample application performance drop issue. This patch add check before this feature enabled. Fixes: 50556c88104c ("net/ixgbe: fix MACsec setting") Signed-off-by: Shougang Wang --- drivers/net/ixgbe/ixgbe_

[dpdk-dev] [PATCH] pktgen: fix stats clear

2019-11-21 Thread Tran Bao Long
Reset the total RX/TX pkts/bytes statistics as well when user issues a clear command. Signed-off-by: Tran Bao Long --- app/pktgen-cmds.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/app/pktgen-cmds.c b/app/pktgen-cmds.c index 0e9af7c..1e8e456 100644 --- a/app/pktgen-cm