Re: [dpdk-dev] [PATCH] eal/linux: fix muti-secondary msl create issue

On Wed, Nov 20, 2019 at 3:48 AM Li Han wrote: > > when we run dpdk in docker, process pid may the same. > add rte_rdtsc() to ensure all the names used in rte_fbarray_init > are different. There is already a fix being prepared by Yasufumi Ogawa. https://patchwork.dpdk.org/patch/62972/ -- David

[dpdk-dev] [PATCH v2 2/2] net/ice: fix FDIR support for GTPU without extension header

Add FDIR support for normal GTP-U packet, which doesn't contain GTP_PSC extension header. Fixes: efc16c621415 ("net/ice: support flow director GTPU tunnel") Cc: yahui@intel.com Signed-off-by: Yahui Cao --- drivers/net/ice/ice_fdir_filter.c | 9 +++-- drivers/net/ice/ice_generic_flow.c

[dpdk-dev] [PATCH v2 1/2] net/ice: fix GTPU extension header renaming

GTP-U packet with extension header is GTP-U packet with GTP_PSC header inserted between GTP-U header and inner payload. Fixes: 3e4eab9c2192 ("net/ice: add pattern manifest") Cc: ying.a.w...@intel.com Signed-off-by: Yahui Cao --- drivers/net/ice/ice_fdir_filter.c | 5 +++-- drivers/net/ice/ice

[dpdk-dev] [PATCH v2 0/2] fix FDIR support for GTPU

This patch series enables FDIR support for both GTP-U and GTP-U with extension header. - Patch 1 renames GTPU with extension header related variables - Patch 2 adds FDIR support for non-extension-header GTPU -- Yahui Cao (2): net/ice: fix GTPU extension header renaming net/ice: fix FDIR sup

Re: [dpdk-dev] [PATCH] mbuf: extend pktmbuf pool private structure

Wednesday, November 20, 2019 1:51 AM, Stephen Hemminger: > Subject: Re: [dpdk-dev] [PATCH] mbuf: extend pktmbuf pool private > structure > > On Tue, 19 Nov 2019 23:30:15 +0100 > Thomas Monjalon wrote: > > > 19/11/2019 17:25, Stephen Hemminger: > > > On Tue, 19 Nov 2019 15:23:50 + > > > Shaha

Re: [dpdk-dev] [PATCH v3] crypto/openssl: support SG for inplace buffers

> -Original Message- > From: dev On Behalf Of Akhil Goyal > Sent: Wednesday, November 20, 2019 11:29 AM > To: dev@dpdk.org > Cc: declan.dohe...@intel.com; Anoob Joseph ; > konstantin.anan...@intel.com; Jerin Jacob Kollanukkaran > ; Akhil Goyal > Subject: [dpdk-dev] [PATCH v3] crypto/opens

[dpdk-dev] [PATCH v3] crypto/openssl: support SG for inplace buffers

As per current support, Scatter Gather is only supported for out of place input and output buffers. This patch add support for Scatter Gather for inplace buffers. Signed-off-by: Akhil Goyal --- changes in v3: - fixed hardcode in decryption path changes in v2: - fixed typo - enabled corresponding

Re: [dpdk-dev] [EXT] [PATCH v2] crypto/openssl: support SG for inplace buffers

> > static inline int > > process_openssl_decryption_update(struct rte_mbuf *mbuf_src, int offset, > > - uint8_t **dst, int srclen, EVP_CIPHER_CTX *ctx) > > + uint8_t **dst, int srclen, EVP_CIPHER_CTX *ctx, uint8_t inplace) > > { > > struct rte_mbuf *m; > > int dstlen

[dpdk-dev] [PATCH 2/2] net/ice: fix FDIR support for GTPU without extension header

Add FDIR support for normal GTP-U packet, which doesn't contain GTP_PSC extension header. Fixes: efc16c621415 ("net/ice: support flow director GTPU tunnel") Cc: yahui@intel.com Signed-off-by: Yahui Cao --- drivers/net/ice/ice_fdir_filter.c | 10 -- 1 file changed, 8 insertions(+), 2

[dpdk-dev] [PATCH 1/2] net/ice: fix GTPU and GTPU extension header mix

GTP-U packet with extension header is GTP-U packet with GTP_PSC header inserted between GTP-U header and inner payload. Fixes: 3e4eab9c2192 ("net/ice: add pattern manifest") Cc: ying.a.w...@intel.com Signed-off-by: Yahui Cao --- drivers/net/ice/ice_generic_flow.c | 14 ++--- drivers/net

[dpdk-dev] [PATCH 0/2] fix FDIR support for non-extension-header GTPU

This patch series fixes FDIR support only for GTP-U with extension header by adding support for GTP-U without extension header. - Patch 1 fixes ice flow GTPU with extension header definition - Patch 2 adds FDIR support for non-extension-header GTPU -- Yahui Cao (2): net/ice: fix GTPU and GTPU

[dpdk-dev] Minutes of Technical Board Meeting, 2019-11-06

Minutes of Technical Board Meeting, 2019-11-06 Members Attending - -Bruce -Ferruh -Hemant -Honnappa -Jerin (Chair) -Kevin -Konstantin -Maxime -Olivier -Thomas NOTE: The technical board meetings every second Wednesday on IRC channel #dpdk-board, at 3pm UTC. Meetings are public a

Re: [dpdk-dev] [PATCH 1/2] doc: update bnxt feature list

On Tue, Nov 19, 2019 at 8:29 PM Ajit Khaparde wrote: > Updating bnxt.ini file. > > Signed-off-by: Ajit Khaparde > Patch applied to dpdk-next-net-brcm. > --- > doc/guides/nics/features/bnxt.ini | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/doc/guides/nics/features/bnxt.ini > b/do

Re: [dpdk-dev] [PATCH 2/2] net/bnxt: fix check for null spec and mask

On Tue, Nov 19, 2019 at 8:29 PM Ajit Khaparde wrote: > bnxt_validate_and_parse_flow_type already has protocol specific NULL > checks for rte_flow_item spec and mask and take actions accordingly. > A check at the top of the loop is redundant and is preventing the > protocol specific checks from be

[dpdk-dev] [PATCH 5/5] event/octeontx2: update start timestamp periodically

From: Pavan Nikhilesh Update start timestamp periodically to prevent drift. Signed-off-by: Pavan Nikhilesh --- drivers/event/octeontx2/otx2_tim_evdev.c | 28 +++ drivers/event/octeontx2/otx2_tim_evdev.h | 7 -- drivers/event/octeontx2/otx2_tim_worker.c | 19 +

[dpdk-dev] [PATCH 4/5] event/octeontx2: update SSO buffers based on timer count

From: Pavan Nikhilesh Update SSO internal XAQ buffers based on number of timers in event timer adapter. Signed-off-by: Pavan Nikhilesh --- drivers/event/octeontx2/otx2_evdev.h | 6 +- drivers/event/octeontx2/otx2_evdev_adptr.c | 84 +- drivers/event/octeontx2/otx2_ti

[dpdk-dev] [PATCH 3/5] event/octeontx2: improve chunk pool performance

From: Pavan Nikhilesh Enable mempool cache for internal mempool to improve alloc performance. Signed-off-by: Pavan Nikhilesh --- drivers/event/octeontx2/otx2_tim_evdev.c | 4 ++-- drivers/event/octeontx2/otx2_tim_worker.h | 15 ++- 2 files changed, 16 insertions(+), 3 deletions(-

[dpdk-dev] [PATCH 1/5] event/octeontx2: fix TIM HW race condition

From: Pavan Nikhilesh Fix HW race condition observed when timeout resolution is low (<5us). When HW traverses a given TIM bucket it will clear chunk_remainder, but since SW always decreases the chunk_remainder at the start of the arm routine it might cause a race where SW updates chunk_remainder

[dpdk-dev] [PATCH 2/5] event/octeontx2: use opposite bucket to store current chunk

From: Pavan Nikhilesh Since TIM buckets are always aligned to 32B and our cache line size being 128B, we will always have a cache miss when reading current_chunk pointer. Avoid the cache miss by storing the current_chunk pointer in the bucket opposite to the current bucket. Signed-off-by: Pavan

Re: [dpdk-dev] [PATCH] crypto/armv8: enable meson build

> > Hi Dharmik, > > As per the recent communication with Honnappa on a separate mail chain, > ARM has agreed to Host the armv8_crypto library. If it is happening in 19.11 To the wider audience, yes Arm will host a crypto library which is an existing repo on Arm github. We will pull the Marvell

Re: [dpdk-dev] [EXT] [PATCH v2] crypto/openssl: support SG for inplace buffers

Hi Akhil, A minor question. Otherwise, looks good. Thanks, Anoob > -Original Message- > From: Akhil Goyal > Sent: Monday, November 18, 2019 7:06 PM > To: dev@dpdk.org > Cc: declan.dohe...@intel.com; Anoob Joseph ; > konstantin.anan...@intel.com; Jerin Jacob Kollanukkaran > ; Akhil Goyal

[dpdk-dev] [PATCH 1/2] doc: update bnxt feature list

Updating bnxt.ini file. Signed-off-by: Ajit Khaparde --- doc/guides/nics/features/bnxt.ini | 3 +++ 1 file changed, 3 insertions(+) diff --git a/doc/guides/nics/features/bnxt.ini b/doc/guides/nics/features/bnxt.ini index 9721dd61d..37a99e336 100644 --- a/doc/guides/nics/features/bnxt.ini +++ b

[dpdk-dev] [PATCH 2/2] net/bnxt: fix check for null spec and mask

bnxt_validate_and_parse_flow_type already has protocol specific NULL checks for rte_flow_item spec and mask and take actions accordingly. A check at the top of the loop is redundant and is preventing the protocol specific checks from being executed. Fixes: b7e01f386059 ("net/bnxt: handle cleanup i

[dpdk-dev] [PATCH v2 2/6] net/octeontx: add application domain validation

From: Pavan Nikhilesh Add domain validation for PKI and PKO vfs Signed-off-by: Pavan Nikhilesh --- drivers/common/octeontx/octeontx_mbox.c | 15 - drivers/common/octeontx/octeontx_mbox.h | 6 +- .../octeontx/rte_common_octeontx_version.map | 1 + drivers/event/octeontx/ssovf

[dpdk-dev] [PATCH v2 5/6] event/octeontx: add appication domain validation

From: Pavan Nikhilesh Add applicaton domain validation for OCTEON TX TIM vfs aka Event timer. Signed-off-by: Pavan Nikhilesh --- drivers/event/octeontx/timvf_evdev.c | 12 ++--- drivers/event/octeontx/timvf_evdev.h | 8 +--- drivers/event/octeontx/timvf_probe.c | 65 ++

[dpdk-dev] [PATCH v2 4/6] mempool/octeontx: add application domain validation

From: Pavan Nikhilesh Add application domain validation for OCTEON TX FPA vfs. Signed-off-by: Pavan Nikhilesh --- drivers/mempool/octeontx/octeontx_fpavf.c | 86 +++ 1 file changed, 58 insertions(+), 28 deletions(-) diff --git a/drivers/mempool/octeontx/octeontx_fpavf.c b

[dpdk-dev] [PATCH v2 6/6] net/octeontx: make Rx queue offloads same as dev offloads

From: Pavan Nikhilesh Make Rx queue specific offloads same as device Rx offloads. Signed-off-by: Pavan Nikhilesh --- drivers/net/octeontx/octeontx_ethdev.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/octeontx/octeontx_ethdev.c b/drivers/net/octeontx/octeontx_ethdev.c ind

[dpdk-dev] [PATCH v2 3/6] net/octeontx: cleanup redudant mbox structs

From: Pavan Nikhilesh Cleanup redudant mail box structures. Signed-off-by: Pavan Nikhilesh --- drivers/net/octeontx/base/octeontx_pkivf.c | 25 +-- drivers/net/octeontx/base/octeontx_pkivf.h | 242 +++-- 2 files changed, 43 insertions(+), 224 deletions(-) diff --git a/drivers

[dpdk-dev] [PATCH v2 0/6] octeontx: sync with latest SDK

From: Pavan Nikhilesh Sync octeontx mailbox with the latest version (10.1.2.x) of SDK available. Pavan Nikhilesh (6): octeontx: update mbox definition to version 1.1.3 net/octeontx: add application domain validation net/octeontx: cleanup redudant mbox structs mempool/octeontx: add applic

[dpdk-dev] [PATCH v2 1/6] octeontx: update mbox definition to version 1.1.3

From: Pavan Nikhilesh Sync mail box data structures to version 1.1.3. Add mail box version verification and defer initializing octeontx devices if mail box version mismatches. Update OCTEON TX limitaion with max mempool size used. Signed-off-by: Pavan Nikhilesh Reviewed-by: Jerin Jacob Kollanuk

[dpdk-dev] [PATCH] eal/linux: fix muti-secondary msl create issue

when we run dpdk in docker, process pid may the same. add rte_rdtsc() to ensure all the names used in rte_fbarray_init are different. Signed-off-by: Li Han --- lib/librte_eal/linux/eal/eal_memalloc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/librte_eal/linux/eal

Re: [dpdk-dev] [PATCH 20.02] net/virtio-user: do not close tap when disabling queue pairs

On Tue, Nov 19, 2019 at 08:36:38AM -0800, Stephen Hemminger wrote: > On Tue, 19 Nov 2019 14:29:48 +0800 > Tiwei Bie wrote: > > > -static int > > +int > > +vhost_kernel_tap_attach_queue(int fd) > > +{ > > + struct ifreq ifr; > > + > > + memset(&ifr, 0, sizeof(ifr)); > > + ifr.ifr_flags = IFF

Re: [dpdk-dev] [dpdk-stable] [PATCH 2/2] malloc: fix realloc padded element size

> -Original Message- > From: David Marchand > Sent: Wednesday, November 20, 2019 4:47 AM > To: Xueming(Steven) Li ; Anatoly Burakov > > Cc: Asaf Penso ; dev ; dpdk stable > > Subject: Re: [dpdk-stable] [PATCH 2/2] malloc: fix realloc padded element > size > > On Tue, Nov 12, 2019 at 3:5

[dpdk-dev] [PATCH v4] net/e1000: fix link status update

There is no need to judge the original link state, only update the data according to the current link state. It can maintain better robustness. In addition, this patch change the variable from link_check to link_up. Fixes: 80ba61115e77 ("net/e1000: use link status helper functions") Cc: sta...@dp

[dpdk-dev] [PATCH v2] [pktgen] Fix IPv6 addressing for set/sequence/save commands, packet headers, UI printing

Current IPv6 functionality in pktgen is broken. This fix makes it so that IPv6 addresses are properly set when using the set, sequence, and save commands and that the IP header and UDP/TCP psuedo-header IPV6 addresses are properly set. To preserve the runtime commands, the `_atoip` function no lon

Re: [dpdk-dev] [PATCH] mbuf: extend pktmbuf pool private structure

On Tue, 19 Nov 2019 23:30:15 +0100 Thomas Monjalon wrote: > 19/11/2019 17:25, Stephen Hemminger: > > On Tue, 19 Nov 2019 15:23:50 + > > Shahaf Shuler wrote: > > > > > Tuesday, November 19, 2019 11:33 AM, Thomas Monjalon: > > > > Subject: Re: [PATCH] mbuf: extend pktmbuf pool private str

[dpdk-dev] [PATCH] [pktgen] Fix IPv6 addressing for set/sequence/save commands, packet headers, UI printing

Current IPv6 functionality in pktgen is broken. This fix makes it so that IPv6 addresses are properly set when using the set, sequence, and save commands and that the IP header and UDP/TCP psuedo-header IPV6 addresses are properly set. To preserve the runtime commands, the `_atoip` function no l

Re: [dpdk-dev] [PATCH] net/bnxt: fix vector receive check

On Tue, Nov 19, 2019 at 2:12 PM Lance Richardson < lance.richard...@broadcom.com> wrote: > Take DEV_RX_OFFLOAD_RSS_HASH into account when deciding whether vector > mode receive can be enabled. > > Fixes: 8b945a7f7dcb ("drivers/net: update Rx RSS hash offload > capabilities") > Signed-off-by: Lance

Re: [dpdk-dev] [dpdk-stable] [PATCH 1/2] bus/pci: fix driver detach clear

12/11/2019 09:47, Matan Azrad: > When a rte_device is unplugged, the driver should be detached from the > device. Yes > The PCI detach driver operation wrongly didn't clear the driver from the > device structure what remain the device in probe state from the EAL > point of view. Are you aware of

Re: [dpdk-dev] [PATCH] mbuf: extend pktmbuf pool private structure

19/11/2019 17:25, Stephen Hemminger: > On Tue, 19 Nov 2019 15:23:50 + > Shahaf Shuler wrote: > > > Tuesday, November 19, 2019 11:33 AM, Thomas Monjalon: > > > Subject: Re: [PATCH] mbuf: extend pktmbuf pool private structure > > > > > > 18/11/2019 11:02, Shahaf Shuler: > > > > struct rte_p

Re: [dpdk-dev] [PATCH v7 09/10] build: change ABI version to 20.0

08/11/2019 17:25, Anatoly Burakov: > From: Pawel Modrak > > Merge all vesions in linker version script files to DPDK_20.0. > > This commit was generated by running the following command: > > :~/DPDK$ buildtools/update-abi.sh 20.0 > > Signed-off-by: Pawel Modrak > Signed-off-by: Anatoly Burako

[dpdk-dev] [PATCH] net/bnxt: fix vector receive check

Take DEV_RX_OFFLOAD_RSS_HASH into account when deciding whether vector mode receive can be enabled. Fixes: 8b945a7f7dcb ("drivers/net: update Rx RSS hash offload capabilities") Signed-off-by: Lance Richardson Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_ethdev.c | 1 + 1 file changed, 1

Re: [dpdk-dev] [PATCH v2 1/2] lib: fix log typos

On 19/11/2019 21:18, David Marchand wrote: > On Wed, Nov 13, 2019 at 5:11 PM Kevin Traynor wrote: >> >> Fix these as they are user visible. Found with codespell. >> >> Fixes: bacaa2754017 ("eal: add channel for multi-process communication") >> Fixes: f05e26051c15 ("eal: add IPC asynchronous reques

Re: [dpdk-dev] [PATCH v7 09/10] build: change ABI version to 20.0

Reduced the Cc: list. On Fri, Nov 8, 2019 at 5:26 PM Anatoly Burakov wrote: > > From: Pawel Modrak > > Merge all vesions in linker version script files to DPDK_20.0. > > This commit was generated by running the following command: > > :~/DPDK$ buildtools/update-abi.sh 20.0 > I inspected the chan

Re: [dpdk-dev] [PATCH v7 04/10] timer: remove deprecated code

On Fri, Nov 8, 2019 at 5:25 PM Anatoly Burakov wrote: > > From: Marcin Baran > > Remove code for old ABI versions ahead of ABI version bump. > > Signed-off-by: Marcin Baran > Signed-off-by: Anatoly Burakov > Acked-by: Bruce Richardson > Acked-by: Erik Gabriel Carrillo > --- > > Notes: > v

Re: [dpdk-dev] [PATCH v7 05/10] lpm: remove deprecated code

On Fri, Nov 8, 2019 at 5:25 PM Anatoly Burakov wrote: > > From: Marcin Baran > > Remove code for old ABI versions ahead of ABI version bump. > > Signed-off-by: Marcin Baran > Signed-off-by: Anatoly Burakov > Acked-by: Bruce Richardson > --- > > Notes: > v2: > - Moved this to before ABI

Re: [dpdk-dev] [PATCH] ci: add 32-bit travis builds

On Tue, Nov 19, 2019 at 5:06 PM Aaron Conole wrote: > > Bruce Richardson writes: > > > Add a travis job to build for 32-bit on 64-bit systems to catch additional > > build errors, for example, incorrect use of printf specifiers with uint64_t > > types. > > > > Signed-off-by: Bruce Richardson > A

Re: [dpdk-dev] [PATCH v2 1/2] lib: fix log typos

On Wed, Nov 13, 2019 at 5:11 PM Kevin Traynor wrote: > > Fix these as they are user visible. Found with codespell. > > Fixes: bacaa2754017 ("eal: add channel for multi-process communication") > Fixes: f05e26051c15 ("eal: add IPC asynchronous request") > Fixes: 0cbce3a167f1 ("vfio: skip DMA map fai

Re: [dpdk-dev] [PATCH] build: remove unneeded meson option

On Tue, Nov 19, 2019 at 3:06 PM Bruce Richardson wrote: > > On Tue, Nov 19, 2019 at 01:59:23PM +0100, David Marchand wrote: > > The meson option has been missed when removing this code. > > > > Fixes: 8e35792c5325 ("eal: remove dead code on NUMA node detection") > > Cc: sta...@dpdk.org > > > > Sig

Re: [dpdk-dev] [PATCH v2] kni: reduce interface name size

On Fri, Nov 15, 2019 at 2:30 PM Ferruh Yigit wrote: > On 11/15/2019 1:03 PM, Michael Pfeiffer wrote: > > The name in rte_kni_device_info is passed to the kernel, which allows > > interface names with at most 16 bytes (IFNAMSIZ). rte_kni_alloc with a > > longer name currently trigger a kernel BUG i

Re: [dpdk-dev] [PATCH] kni: reduce interface name size

On Tue, Nov 19, 2019 at 1:13 PM Ferruh Yigit wrote: > > On 11/15/2019 4:23 PM, Stephen Hemminger wrote: > > On Fri, 15 Nov 2019 12:41:07 +0100 > > Michael Pfeiffer wrote: > > > >> The name in rte_kni_device_info is passed to the kernel, which allows > >> interface names with at most 16 bytes (IFN

Re: [dpdk-dev] [PATCH 1/2] mempool: use actual IOVA addresses when populating

On Thu, Nov 14, 2019 at 2:58 PM Anatoly Burakov wrote: > > Currently, when mempool is being populated, we get IOVA address > of every segment using rte_mem_virt2iova(). This works for internal > memory, but does not really work for external memory, and does not > work on platforms which return RTE

Re: [dpdk-dev] [dpdk-stable] [PATCH 2/2] malloc: fix realloc padded element size

On Tue, Nov 12, 2019 at 3:50 PM Xueming Li wrote: > > When resize a memory with next element, the original element size grows. > If the orginal element has padding, the real inner element size didn't > grow as well and this causes trailer verification failure when malloc > debug enabled. I did no

Re: [dpdk-dev] Jumbo Frame in pktgen & dpdk-pktgen

John, Marko, It seems we are missing documentation about enabling Jumbo frames in an application, and possibly an example of using the rte_eth_dev_info->max_mtu. Med venlig hilsen / kind regards - Morten Brørup > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of

Re: [dpdk-dev] [PATCH v2] app/testpmd: report invalid command line parameter

On 11/18/2019 8:18 AM, Ferruh Yigit wrote: On 11/18/2019 3:37 PM, David Marchand wrote: We currently do not check that a non option string has been passed to testpmd. Example: $ ./master/app/testpmd --no-huge -m 512 --vdev net_null0 \ --vdev net_null1 -- -i nb-cores=2 --total-num-mbuf

Re: [dpdk-dev] [PATCH 0/3] bnxt patches

On Tue, Nov 19, 2019 at 10:57 AM Ajit Khaparde wrote: > Couple of bug fixes and an update to the release notes. > Please apply. > > Ajit Khaparde (2): > net/bnxt: fix to ignore resource qcaps error with older FW > doc: update release notes for Broadcom PMD > > Rahul Gupta (1): > net/bnxt: f

[dpdk-dev] [PATCH 0/3] bnxt patches

Couple of bug fixes and an update to the release notes. Please apply. Ajit Khaparde (2): net/bnxt: fix to ignore resource qcaps error with older FW doc: update release notes for Broadcom PMD Rahul Gupta (1): net/bnxt: fix jumbo frame configuration in firmware doc/guides/rel_notes/release_

[dpdk-dev] [PATCH 1/3] net/bnxt: fix to ignore resource qcaps error with older FW

On some old versions of FW, bnxt_hwrm_func_resc_qcaps can return an error. This is because the command was not implemented completely in FW till the subsequent version. Ignore the error and continue with the driver initialization. Fixes: edafb57ba4a1 ("net/bnxt: fix VF resource allocation") Cc: st

[dpdk-dev] [PATCH 3/3] doc: update release notes for Broadcom PMD

Update release doc briefly describing updates to bnxt PMD for 19.11 release. Signed-off-by: Ajit Khaparde --- doc/guides/rel_notes/release_19_11.rst | 10 ++ 1 file changed, 10 insertions(+) diff --git a/doc/guides/rel_notes/release_19_11.rst b/doc/guides/rel_notes/release_19_11.rst in

[dpdk-dev] [PATCH 2/3] net/bnxt: fix jumbo frame configuration in firmware

From: Rahul Gupta In order to prevent reconfiguration of firmware resources for every MTU change, configure FW with max MTU value using hwrm_func_cfg to support all frame sizes. There is no need to overwrite the driver level MTU variable data->mtu with the FW MTU. Fixes: 905cd45ce30e ("net/bnxt:

Re: [dpdk-dev] [PATCH v7 10/10] buildtools: add ABI versioning check script

08/11/2019 17:25, Anatoly Burakov: > From: Marcin Baran > +echo "correct version (ABI_VER/ABI_VER+1/EXPERIMENTAL)" I don't get why a symbol could be versioned for the next ABI? Assuming we upgrade the ABI version at the beginning of the cycle, every symbols should have the same version, right

Re: [dpdk-dev] Jumbo Frame in pktgen & dpdk-pktgen

Nirmal, Here are the changes that I've been using to allow jumbo frames with dpdk-19.08 and pktgen-19.10.0: diff -r default/dpdk-19.08/lib/librte_mbuf/rte_mbuf.h jumbo/dpdk-19.08/lib/librte_mbuf/rte_mbuf.h 462c462 < #define RTE_MBUF_DEFAULT_DATAROOM 2048 --- > #define RTE_MBUF

Re: [dpdk-dev] [PATCH v7 03/10] buildtools: add ABI update shell script

08/11/2019 17:25, Anatoly Burakov: > In order to facilitate mass updating of version files, add a shell > script that recurses into lib/ and drivers/ directories and calls > the ABI version update script. > > Signed-off-by: Anatoly Burakov > Acked-by: Bruce Richardson > --- /dev/null > +++ b/bui

Re: [dpdk-dev] [PATCH 20.02] net/virtio-user: do not close tap when disabling queue pairs

On Tue, 19 Nov 2019 14:29:48 +0800 Tiwei Bie wrote: > -static int > +int > +vhost_kernel_tap_attach_queue(int fd) > +{ > + struct ifreq ifr; > + > + memset(&ifr, 0, sizeof(ifr)); > + ifr.ifr_flags = IFF_ATTACH_QUEUE; > + return ioctl(fd, TUNSETQUEUE, (void *)&ifr); > +} > + > +int

Re: [dpdk-dev] [PATCH] mbuf: extend pktmbuf pool private structure

On Tue, 19 Nov 2019 15:23:50 + Shahaf Shuler wrote: > Tuesday, November 19, 2019 11:33 AM, Thomas Monjalon: > > Subject: Re: [PATCH] mbuf: extend pktmbuf pool private structure > > > > 18/11/2019 11:02, Shahaf Shuler: > > > struct rte_pktmbuf_pool_private { > > > uint16_t mbuf_data_room

Re: [dpdk-dev] [PATCH] ci: add 32-bit travis builds

Bruce Richardson writes: > Add a travis job to build for 32-bit on 64-bit systems to catch additional > build errors, for example, incorrect use of printf specifiers with uint64_t > types. > > Signed-off-by: Bruce Richardson > --- Nice! Acked-by: Aaron Conole

Re: [dpdk-dev] [PATCH v7 02/10] buildtools: add script for updating symbols abi version

19/11/2019 16:38, Burakov, Anatoly: > On 19-Nov-19 2:01 PM, Thomas Monjalon wrote: > > 08/11/2019 17:25, Anatoly Burakov: > >> From: Pawel Modrak > >> > >> Add a script that automatically merges all stable ABI's under one > >> ABI section with the new version, while leaving experimental > >> secti

Re: [dpdk-dev] [PATCH] net/mlx5: fix hairpin split detection

Hi, > -Original Message- > From: dev On Behalf Of Ori Kam > Sent: Tuesday, November 19, 2019 2:39 PM > To: Matan Azrad ; Shahaf Shuler > ; Slava Ovsiienko > Cc: dev@dpdk.org; Ori Kam > Subject: [dpdk-dev] [PATCH] net/mlx5: fix hairpin split detection > > When creating a flow, the flow

Re: [dpdk-dev] [PATCH] net/mlx5: fix port action create routine

Hi, > -Original Message- > From: Viacheslav Ovsiienko > Sent: Tuesday, November 19, 2019 11:16 AM > To: dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > ; Ori Kam > Subject: [PATCH] net/mlx5: fix port action create routine > > To support LAG configurations the mlx5dv_dr_action_create

Re: [dpdk-dev] [PATCH] net/mlx5: fix assert in tx inline settings ajustment

Hi, > -Original Message- > From: Viacheslav Ovsiienko > Sent: Tuesday, November 19, 2019 3:13 PM > To: dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > ; Ori Kam > Subject: [PATCH] net/mlx5: fix assert in tx inline settings ajustment > > Assert condition is fixed to not alert for the

Re: [dpdk-dev] [PATCH v7 01/10] config: change ABI versioning to global

On 19-Nov-19 1:53 PM, Thomas Monjalon wrote: 08/11/2019 17:25, Anatoly Burakov: From: Marcin Baran As per new ABI policy, all of the libraries are now versioned using one global ABI version. Changes in this patch implement the necessary steps to enable that. For the history, would be nice to

Re: [dpdk-dev] [dpdk-stable] [PATCH] ethdev: avoid undefined behaviour on configuration copying

On 11/19/2019 2:57 PM, Ferruh Yigit wrote: > On 11/19/2019 8:22 AM, Andrew Rybchenko wrote: >> memcpy() source and destination areas must not overlap and equal >> pointers is the case which is really met, so handle it. >> >> Fixes: 68b931bff287 ("ethdev: eliminate interim variable") >> Cc: sta...@d

Re: [dpdk-dev] [PATCH v7 02/10] buildtools: add script for updating symbols abi version

On 19-Nov-19 2:01 PM, Thomas Monjalon wrote: 08/11/2019 17:25, Anatoly Burakov: From: Pawel Modrak Add a script that automatically merges all stable ABI's under one ABI section with the new version, while leaving experimental section exactly as it is. Signed-off-by: Pawel Modrak Signed-off-b

[dpdk-dev] [PATCH] net/mlx5: fix L3 encapsulation flow validation

In order to configure L3 encapsulation\decapsulation flow to mlx5 devices, 2 actions should be added to the flow actions list: RTE_FLOW_ACTION_TYPE_RAW_DECAP and RTE_FLOW_ACTION_TYPE_RAW_ENCAP. One of the validations for this scenario is to check that modify actions is not done before the L3 decap

Re: [dpdk-dev] [PATCH] mbuf: extend pktmbuf pool private structure

Tuesday, November 19, 2019 11:33 AM, Thomas Monjalon: > Subject: Re: [PATCH] mbuf: extend pktmbuf pool private structure > > 18/11/2019 11:02, Shahaf Shuler: > > struct rte_pktmbuf_pool_private { > > uint16_t mbuf_data_room_size; /**< Size of data space in each > mbuf. */ > > uint16_t mbu

Re: [dpdk-dev] [PATCH v6 1/1] net/hinic: fix secondary process issue

On 11/19/2019 12:31 PM, Xiaoyun wang wrote: > The secondary process does not need to register interrupt handle, > remove rte_intr_callback_register from secondary process branch. > > Fixes: 06b6a81bbabf ("net/hinic: document missing features") I can see above patch documents the "Multiprocess awa

[dpdk-dev] [PATCH] ci: add 32-bit travis builds

Add a travis job to build for 32-bit on 64-bit systems to catch additional build errors, for example, incorrect use of printf specifiers with uint64_t types. Signed-off-by: Bruce Richardson --- .ci/linux-build.sh | 5 + .travis.yml| 10 ++ 2 files changed, 15 insertions(+)

Re: [dpdk-dev] [PATCH v2 2/3] ethdev: remove deprecation notice about RSS hash offload

On 11/19/2019 12:12 PM, Andrew Rybchenko wrote: > The offload was added, but the deprecation notice was not removed. > > Fixes: 5d308972954c ("ethdev: add mbuf RSS update as an offload") > > Signed-off-by: Andrew Rybchenko Acked-by: Ferruh Yigit

Re: [dpdk-dev] [PATCH v2 1/3] ethdev: remove deprecation notice for packet type set

On 11/19/2019 12:12 PM, Andrew Rybchenko wrote: > The functionality is added, but the deprecation notice is not > removed. > > Fixes: 5d4813acda2c ("ethdev: add packet type range function") > > Signed-off-by: Andrew Rybchenko Acked-by: Ferruh Yigit

Re: [dpdk-dev] [PATCH] ethdev: avoid undefined behaviour on configuration copying

On 11/19/2019 8:22 AM, Andrew Rybchenko wrote: > memcpy() source and destination areas must not overlap and equal > pointers is the case which is really met, so handle it. > > Fixes: 68b931bff287 ("ethdev: eliminate interim variable") > Cc: sta...@dpdk.org > > Signed-off-by: Andrew Rybchenko Re

Re: [dpdk-dev] [PATCH] doc: update git fixline alias with cc to stable

On 19/11/2019 11:22, Bruce Richardson wrote: > On Tue, Nov 19, 2019 at 11:03:57AM +, Reshma Pattan wrote: >> Update git fixline alias to add sta...@dpdk.org to Cc >> >> Signed-off-by: Reshma Pattan >> --- >> doc/guides/contributing/patches.rst | 2 +- >> 1 file changed, 1 insertion(+), 1 dele

Re: [dpdk-dev] [PATCH v2] crypto/openssl: support SG for inplace buffers

Hi Anoob, Any more comments on this patch? If not please Ack. Thanks, Akhil > > As per current support, Scatter Gather is only supported > for out of place input and output buffers. > This patch add support for Scatter Gather for inplace buffers. > > Signed-off-by: Akhil Goyal > ---

Re: [dpdk-dev] [PATCH] build: remove unneeded meson option

On Tue, Nov 19, 2019 at 01:59:23PM +0100, David Marchand wrote: > The meson option has been missed when removing this code. > > Fixes: 8e35792c5325 ("eal: remove dead code on NUMA node detection") > Cc: sta...@dpdk.org > > Signed-off-by: David Marchand > --- Acked-by: Bruce Richardson

Re: [dpdk-dev] [PATCH v7 02/10] buildtools: add script for updating symbols abi version

08/11/2019 17:25, Anatoly Burakov: > From: Pawel Modrak > > Add a script that automatically merges all stable ABI's under one > ABI section with the new version, while leaving experimental > section exactly as it is. > > Signed-off-by: Pawel Modrak > Signed-off-by: Anatoly Burakov > Acked-by:

Re: [dpdk-dev] [dpdk-stable] [PATCH] ethdev: avoid undefined behaviour on configuration copying

On 11/19/19 4:37 PM, Ferruh Yigit wrote: > On 11/19/2019 1:19 PM, Ferruh Yigit wrote: >> On 11/19/2019 12:36 PM, Andrew Rybchenko wrote: >>> On 11/19/19 3:24 PM, Ferruh Yigit wrote: On 11/19/2019 8:22 AM, Andrew Rybchenko wrote: > memcpy() source and destination areas must not overlap and

Re: [dpdk-dev] [PATCH] net/i40e: force promiscuous state after VF reset

On 13 Nov 2019, at 2:14, Zhang, Xiao wrote: -Original Message- From: Eelco Chaudron [mailto:echau...@redhat.com] Sent: Tuesday, November 12, 2019 7:09 PM To: Zhang, Xiao Cc: Zhang, Qi Z ; dev@dpdk.org; Xing, Beilei Subject: Re: [dpdk-dev] [PATCH] net/i40e: force promiscuous state a

Re: [dpdk-dev] [PATCH v7 01/10] config: change ABI versioning to global

08/11/2019 17:25, Anatoly Burakov: > From: Marcin Baran > > As per new ABI policy, all of the libraries are now versioned using > one global ABI version. Changes in this patch implement the > necessary steps to enable that. For the history, would be nice to describe the "why" of each change here

[dpdk-dev] [PATCH v2] net/i40e: always re-program promiscuous mode on VF interface

During a kernel PF reset, this event is propagated to the VF. The DPDK VF PMD will execute the reset task before the PF is done with his. This results in the admin queue message not being responded to leaving the port in "promiscuous" mode. This patch makes sure the promiscuous mode is configured

[dpdk-dev] rte_eth_dev_stop and rte_eth_dev_close are still void

Thomas, Ferruh, the following deprecation notice is still in place: * ethdev: Update API functions returning ``void`` to return ``int`` with   negative errno values to indicate various error conditions (e.g.   invalid port ID, unsupported operation, failed operation):   - ``rte_eth_dev_stop``  

Re: [dpdk-dev] [dpdk-stable] [PATCH] ethdev: avoid undefined behaviour on configuration copying

On 11/19/2019 1:19 PM, Ferruh Yigit wrote: > On 11/19/2019 12:36 PM, Andrew Rybchenko wrote: >> On 11/19/19 3:24 PM, Ferruh Yigit wrote: >>> On 11/19/2019 8:22 AM, Andrew Rybchenko wrote: memcpy() source and destination areas must not overlap and equal pointers is the case which is really

Re: [dpdk-dev] [PATCH] ethdev: avoid undefined behaviour on configuration copying

On 11/19/19 4:19 PM, Ferruh Yigit wrote: > On 11/19/2019 12:36 PM, Andrew Rybchenko wrote: >> On 11/19/19 3:24 PM, Ferruh Yigit wrote: >>> On 11/19/2019 8:22 AM, Andrew Rybchenko wrote: memcpy() source and destination areas must not overlap and equal pointers is the case which is really m

Re: [dpdk-dev] [PATCH] ethdev: avoid undefined behaviour on configuration copying

On 11/19/2019 12:36 PM, Andrew Rybchenko wrote: > On 11/19/19 3:24 PM, Ferruh Yigit wrote: >> On 11/19/2019 8:22 AM, Andrew Rybchenko wrote: >>> memcpy() source and destination areas must not overlap and equal >>> pointers is the case which is really met, so handle it. >> Agree providing same confi

[dpdk-dev] [PATCH] net/mlx5: fix assert in tx inline settings ajustment

Assert condition is fixed to not alert for the case when multi-packet write is not supported/engaged at all. Fixes: b53cd86965a1 ("net/mlx5: adjust inline setting for large Tx queue sizes") Signed-off-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5_txq.c | 3 ++- 1 file changed, 2 insertions

Re: [dpdk-dev] [PATCH] net/bnxt: fix Rx queue pool calculation

On 11/18/2019 8:41 PM, Ajit Khaparde wrote: > > > On Mon, Nov 18, 2019 at 12:32 PM Ajit Khaparde > wrote: > > When the number of Rx queues requested by the application is less than > the number of pools calculated, we end up calling HWRM_VNIC_ALLOC wit

[dpdk-dev] [PATCH] build: remove unneeded meson option

The meson option has been missed when removing this code. Fixes: 8e35792c5325 ("eal: remove dead code on NUMA node detection") Cc: sta...@dpdk.org Signed-off-by: David Marchand --- meson_options.txt | 2 -- 1 file changed, 2 deletions(-) diff --git a/meson_options.txt b/meson_options.txt index

Re: [dpdk-dev] minimum supported meson version

On 11/19/19 3:40 PM, Luca Boccassi wrote: > On Tue, 2019-11-19 at 15:27 +0300, Andrew Rybchenko wrote: >> Bruce, >> >> root meson.build declares 0.47.1, but I see the following during >> build: >> >> WARNING: Project specifies a minimum meson_version '>= 0.47.1' but >> uses >> features which were a

Re: [dpdk-dev] minimum supported meson version

On Tue, 2019-11-19 at 15:27 +0300, Andrew Rybchenko wrote: > Bruce, > > root meson.build declares 0.47.1, but I see the following during > build: > > WARNING: Project specifies a minimum meson_version '>= 0.47.1' but > uses > features which were added in newer versions: > * 0.48.0: {'console arg

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/bonding: do not inherit slave device configuration

On 11/19/19 3:18 PM, Ferruh Yigit wrote: > On 11/19/2019 9:03 AM, Andrew Rybchenko wrote: >> Bonding device should control bonded devices configuration. >> >> Also avoid usage of slave's data->dev_conf. >> >> Fixes: 2efb58cbab6e ("bond: new link bonding library") >> Cc: sta...@dpdk.org >> >> Signed

[dpdk-dev] [PATCH] net/mlx5: fix hairpin split detection

When creating a flow, the flow is checked if it should be split into 2 flows based on the queue/rss acton. If the RSS action with given without any queues, it will result in crash due to the fact that the function checks the queue type. This commit fixes this issue by checking if the rss action i

Re: [dpdk-dev] [PATCH] ethdev: avoid undefined behaviour on configuration copying

On 11/19/19 3:24 PM, Ferruh Yigit wrote: > On 11/19/2019 8:22 AM, Andrew Rybchenko wrote: >> memcpy() source and destination areas must not overlap and equal >> pointers is the case which is really met, so handle it. > Agree providing same config as input can cause problem with current > implementa

  1   2   >