Re: [dpdk-dev] [PATCH v3 2/3] config: add arm neoverse N1 SDP configuration

2019-11-13 Thread Gavin Hu (Arm Technology China)
Hi Jerin, > -Original Message- > From: Jerin Jacob > Sent: Tuesday, November 12, 2019 12:24 PM > To: Gavin Hu (Arm Technology China) > Cc: dpdk-dev ; nd ; tho...@monjalon.net; > Honnappa Nagarahalli > Subject: Re: [dpdk-dev] [PATCH v3 2/3] config: add arm neoverse N1 SDP > configuration

Re: [dpdk-dev] [PATCH] net/ice: fix FDIR programming status check issue

2019-11-13 Thread Ye Xiaolong
On 11/14, Yahui Cao wrote: >To make sure if FDIR programming succeed or fail, legacy programming >status descriptor WB format is enabled and FDIR queue irq is opened. > >Fixes: 84dc7a95a2d3 ("net/ice: enable flow director engine") >Cc: beilei.x...@intel.com > >Signed-off-by: Yahui Cao >Signed-off-

[dpdk-dev] [PATCH v17 19/19] raw/ifpga: introducing new irq API

2019-11-13 Thread Rosen Xu
From: Tianfei zhang Introducing new register and unregister API for ifpga interrupt. 1. register FME and AFU interrupt ifpga_register_msix_irq() 2. unregister FME and AFU interrupt ifpga_unregister_msix_irq() On PAC N3000 card, there is one PCIe MSIX interrupt for FME managerment, like th

[dpdk-dev] [PATCH v17 17/19] raw/ifpga: add lightweight fpga image support

2019-11-13 Thread Rosen Xu
From: Andy Pei if fpga image support lightweight feature, set afu uuid to all 0, ipn3ke representor will not be probed. Signed-off-by: Andy Pei --- drivers/raw/ifpga/ifpga_rawdev.c | 44 +--- 1 file changed, 32 insertions(+), 12 deletions(-) diff --git a/dr

[dpdk-dev] [PATCH v17 16/19] raw/ifpga/base: add new API get board info

2019-11-13 Thread Rosen Xu
From: Tianfei zhang Add new API to get the board info. opae_mgr_get_board_info() Signed-off-by: Tianfei zhang Signed-off-by: Andy Pei --- drivers/raw/ifpga/base/ifpga_api.c | 11 +++ drivers/raw/ifpga/base/ifpga_defines.h | 55 ++ drivers/raw/ifpga/base

[dpdk-dev] [PATCH v17 15/19] raw/ifpga/base: clean fme errors

2019-11-13 Thread Rosen Xu
From: Tianfei zhang Clean fme errors register when some fme errors occurred. Signed-off-by: Tianfei zhang Signed-off-by: Andy Pei --- drivers/raw/ifpga/base/ifpga_fme_error.c | 24 ++-- drivers/raw/ifpga/ifpga_rawdev.c | 22 ++ 2 files changed,

[dpdk-dev] [PATCH v17 18/19] raw/ifpga/base: add multiple cards support

2019-11-13 Thread Rosen Xu
From: Tianfei zhang In PAC N3000 card, there is one MAX10 chip in each card, and all of the sensors are connected to MAX10 chip. To support multiple cards in one server, we introducing a sensor device list under intel_max10_device instead of a global list. On the other hand, we using separate int

[dpdk-dev] [PATCH v17 13/19] raw/ifpga/base: add secure support

2019-11-13 Thread Rosen Xu
From: Tianfei zhang Add secure max10 device support. Signed-off-by: Tianfei zhang Signed-off-by: Andy Pei --- drivers/raw/ifpga/base/ifpga_defines.h| 2 + drivers/raw/ifpga/base/ifpga_fme.c| 26 -- drivers/raw/ifpga/base/opae_intel_max10.c | 137 +---

[dpdk-dev] [PATCH v17 14/19] raw/ifpga/base: configure FEC mode

2019-11-13 Thread Rosen Xu
From: Tianfei zhang We can change the PKVL FEC mode when the A10 NIOS FW initialization. The end-user can use this feature the change the FEC mode, the default mode is RS FEC mode. Signed-off-by: Tianfei zhang Signed-off-by: Andy Pei --- drivers/raw/ifpga/base/ifpga_fme.c | 42 +++

[dpdk-dev] [PATCH v17 12/19] net/ipn3ke: remove configuration for i40e port bonding

2019-11-13 Thread Rosen Xu
The ipn3ke board FPGA and i40e BDF scan has added in ifpga_rawdev, so it doesn't need to provide configuration for i40e port bonding. Signed-off-by: Rosen Xu Signed-off-by: Andy Pei --- drivers/net/ipn3ke/Makefile | 1 + drivers/net/ipn3ke/ipn3ke_ethdev.c| 292 ++

[dpdk-dev] [PATCH v17 10/19] raw/ifpga: add SEU error handler

2019-11-13 Thread Rosen Xu
Add SEU interrupt support for FPGA. Signed-off-by: Tianfei zhang Signed-off-by: Rosen Xu Signed-off-by: Andy Pei --- drivers/raw/ifpga/ifpga_rawdev.c | 241 +++ 1 file changed, 241 insertions(+) diff --git a/drivers/raw/ifpga/ifpga_rawdev.c b/drivers/raw/if

[dpdk-dev] [PATCH v17 07/19] raw/ifpga/base: add sensor support

2019-11-13 Thread Rosen Xu
From: Tianfei zhang The sensor devices are connected in MAX10 FPGA. we used the device tree to describe those sensor devices. Parse the device tree to get the sensor devices and add them into a list. Signed-off-by: Tianfei zhang Signed-off-by: Andy Pei --- drivers/raw/ifpga/base/opae_intel_ma

[dpdk-dev] [PATCH v17 09/19] raw/ifpga/base: update SEU register definition

2019-11-13 Thread Rosen Xu
From: Tianfei zhang Update the SEU registser definition. Signed-off-by: Tianfei zhang Signed-off-by: Andy Pei --- drivers/raw/ifpga/base/ifpga_defines.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/raw/ifpga/base/ifpga_defines.h b/drivers/raw/ifpga/base/ifpg

[dpdk-dev] [PATCH v17 11/19] raw/ifpga: add PCIe BDF devices tree scan

2019-11-13 Thread Rosen Xu
Add PCIe BDF devices tree scan for ipn3ke. Signed-off-by: Rosen Xu Signed-off-by: Andy Pei --- drivers/raw/ifpga/ifpga_rawdev.c | 551 ++- drivers/raw/ifpga/ifpga_rawdev.h | 16 ++ 2 files changed, 562 insertions(+), 5 deletions(-) diff --git a/drivers/raw/

[dpdk-dev] [PATCH v17 08/19] raw/ifpga/base: introducing sensor APIs

2019-11-13 Thread Rosen Xu
From: Tianfei zhang Introducing sensor APIs to PMD driver for PAC N3000 card. Those sensor APIs: 1. opae_mgr_for_each_sensor() 2. opae_mgr_get_sensor_by_name() 3. opae_mgr_get_sensor_by_id() 4. opae_mgr_get_sensor_value_by_name() 5. opae_mgr_get_sensor_value_by_id() 6. opae_mgr_get_sensor_value(

[dpdk-dev] [PATCH v17 05/19] raw/ifpga/base: add device tree support

2019-11-13 Thread Rosen Xu
From: Tianfei zhang In PAC N3000 card, this is a BMC chip which using MAX10 FPGA to manage the board configuration, like sensors, flash controller, QSFP, powers. And this is a SPI bus connected between A10 FPGA and MAX10, we can access the MAX10 registers over this SPI bus. In BMC, there are abo

[dpdk-dev] [PATCH v17 03/19] raw/ifpga/base: clear pending bit

2019-11-13 Thread Rosen Xu
From: Tianfei zhang Every defined bit in FME_ERROR0 is RW1C. Other reserved bits are always 0 when readout and it will plan to be RW1C if needed in future. So it is safe just write the read back value to clear all the errors. Signed-off-by: Tianfei zhang Signed-off-by: Andy Pei --- drivers/ra

[dpdk-dev] [PATCH v17 01/19] net/i40e: i40e support ipn3ke FPGA port bonding

2019-11-13 Thread Rosen Xu
From: Andy Pei In ipn3ke, each FPGA network side port bonding to an i40e pf, each i40e pf link status should get data from FPGA network, side port. This patch provide bonding relationship. Signed-off-by: Rosen Xu Signed-off-by: Andy Pei --- drivers/net/i40e/base/i40e_type.h | 3 +++

[dpdk-dev] [PATCH v17 02/19] raw/ifpga/base: add irq support

2019-11-13 Thread Rosen Xu
From: Tianfei zhang Add irq support for ifpga FME global error, port error and uint unit. We implmented this feature by vfio interrupt mechanism. To build this feature, CONFIG_RTE_EAL_VFIO should be enabled. Signed-off-by: Tianfei zhang Signed-off-by: Andy Pei --- config/common_base

[dpdk-dev] [PATCH v17 04/19] raw/ifpga/base: add SEU error support

2019-11-13 Thread Rosen Xu
From: Tianfei zhang This patch exposes SEU error information to application then application could compare this information (128bit) with its own SMH file to know if this SEU is a fatal error or not. Signed-off-by: Tianfei zhang Signed-off-by: Andy Pei --- drivers/raw/ifpga/base/ifpga_defines

[dpdk-dev] [PATCH v17 06/19] raw/ifpga/base: align the send buffer for SPI

2019-11-13 Thread Rosen Xu
From: Tianfei zhang The length of send buffer of SPI bus should be 4bytes align. Signed-off-by: Tianfei Zhang Signed-off-by: Andy Pei --- drivers/raw/ifpga/base/opae_spi_transaction.c | 40 --- 1 file changed, 36 insertions(+), 4 deletions(-) diff --git a/drivers/raw/

[dpdk-dev] [PATCH v17 00/19] add PCIe AER disable and IRQ support for ipn3ke

2019-11-13 Thread Rosen Xu
This patch set adds PCIe AER disable and FPGA interrupt support for ipn3ke. It also provides a small rework for port bonding between FPGA line side port and I40e PF port. What is the PCI Express AER(Advanced Error Reporting)? Advanced Error Reporting capability is implemented with a PCI Express ad

Re: [dpdk-dev] [PATCH v16 01/19] net/i40e: i40e support ipn3ke FPGA port bonding

2019-11-13 Thread Xu, Rosen
> -Original Message- > From: Yigit, Ferruh > Sent: Wednesday, November 13, 2019 22:38 > To: Xu, Rosen ; dev@dpdk.org > Cc: Zhang, Tianfei ; Pei, Andy > ; Ye, Xiaolong > Subject: Re: [PATCH v16 01/19] net/i40e: i40e support ipn3ke FPGA port > bonding > > On 11/13/2019 7:08 AM, Rosen Xu w

Re: [dpdk-dev] [PATCH v16 10/19] raw/ifpga: add SEU error handler

2019-11-13 Thread Xu, Rosen
> -Original Message- > From: Yigit, Ferruh > Sent: Wednesday, November 13, 2019 22:50 > To: Xu, Rosen ; dev@dpdk.org > Cc: Zhang, Tianfei ; Pei, Andy > ; Ye, Xiaolong > Subject: Re: [PATCH v16 10/19] raw/ifpga: add SEU error handler > > On 11/13/2019 7:08 AM, Rosen Xu wrote: > > Add SEU

Re: [dpdk-dev] [PATCH] net/ice: fix missing spdx license identifier

2019-11-13 Thread Ye Xiaolong
On 11/14, Yahui Cao wrote: >Fixes: 84dc7a95a2d3 ("net/ice: enable flow director engine") >Cc: beilei.x...@intel.com > >Signed-off-by: Yahui Cao >--- > drivers/net/ice/ice_fdir_filter.c | 4 > 1 file changed, 4 insertions(+) > >diff --git a/drivers/net/ice/ice_fdir_filter.c >b/drivers/net/ice/

Re: [dpdk-dev] [PATCH] net/e1000: fix link status update

2019-11-13 Thread Ye Xiaolong
Hi, On 11/13, Cui LunyuanX wrote: >Unassigned variable should not be used as judgment, and there The issue here is link structure variable has been memset first, which makes it meaningless to compare the value of link.link_status in the conditions. >is no need to update link status according to

[dpdk-dev] [PATCH] net/ice: fix missing spdx license identifier

2019-11-13 Thread Yahui Cao
Fixes: 84dc7a95a2d3 ("net/ice: enable flow director engine") Cc: beilei.x...@intel.com Signed-off-by: Yahui Cao --- drivers/net/ice/ice_fdir_filter.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/net/ice/ice_fdir_filter.c b/drivers/net/ice/ice_fdir_filter.c index dd0e1b0c9..78

Re: [dpdk-dev] [PATCH v3] port: fix library build order dependency

2019-11-13 Thread David Marchand
On Thu, Nov 14, 2019 at 1:43 AM Rahul Shah wrote: > > The port library should be built after eventdev library. > > Fixes: 5d92c4e5 ("port: add eventdev port type") > > Signed-off-by: Rahul Shah This patch has been accepted and applied in its v2 form: https://patchwork.dpdk.org/patch/62661/ --

Re: [dpdk-dev] [PATCH v2] net/ice: ignore error when remove RSS rule

2019-11-13 Thread Ye Xiaolong
On 11/14, Qi Zhang wrote: >Currently, multiple rte_flow RSS rules may map to the same >hardware rule if a later rule is just for input set change or >symm turn on/off. So after one of the rules be destroyed, we will >get error ICE_ERR_DOES_NOT_EXIST when destroying any other rules. >The patch simpl

Re: [dpdk-dev] [PATCH v2] net/ice: fix flow destroy issue for RSS

2019-11-13 Thread Ye Xiaolong
On 11/13, Simei Su wrote: >In ice_hash_create(), whatever the hash_function is, the filter_ptr->symm >is always 0 and when we destroy the flow, the ice_rem_rss_cfg() is never >carried out. So the destroy function never works well. The patch fixes >this issue and at the same time distinguishes seman

Re: [dpdk-dev] [RFC 0/4] cpu-crypto API choices

2019-11-13 Thread Jerin Jacob
On Wed, Nov 6, 2019 at 12:11 AM Konstantin Ananyev wrote: > > Originally both SW and HW crypto PMDs use rte_crypot_op based API to > process the crypto workload asynchronously. This way provides uniformity > to both PMD types, but also introduce unnecessary performance penalty to > SW PMDs that ha

Re: [dpdk-dev] [PATCH 0/7] net/mlx5: support for flow action on VLAN header

2019-11-13 Thread Hideyuki Yamashita
Hello Slava, Note that I am using the following dpdk rc. DPDK 19.11 rc-1 BR, HIdeyuki Yamashita NTT TechnoCross > Hello Slava, > > As I reported to you, creating flow was successful with Connect-X5. > However when I sent packets to the NIC from outer side of > the host, I have problem. > > >

Re: [dpdk-dev] [PATCH 0/7] net/mlx5: support for flow action on VLAN header

2019-11-13 Thread Hideyuki Yamashita
Hello Slava, As I reported to you, creating flow was successful with Connect-X5. However when I sent packets to the NIC from outer side of the host, I have problem. [Case 1] Packet distribution on multi-queue based on dst MAC address. NIC config: 04:00.0 Mellanox Connect-X5 0.5.00.0 Intel XXV71

[dpdk-dev] [PATCH v2] net/ice: ignore error when remove RSS rule

2019-11-13 Thread Qi Zhang
Currently, multiple rte_flow RSS rules may map to the same hardware rule if a later rule is just for input set change or symm turn on/off. So after one of the rules be destroyed, we will get error ICE_ERR_DOES_NOT_EXIST when destroying any other rules. The patch simply fixes this by ignoring this e

Re: [dpdk-dev] [PATCH v2] net/ice: fix flow destroy issue for RSS

2019-11-13 Thread Zhang, Qi Z
> -Original Message- > From: Su, Simei > Sent: Wednesday, November 13, 2019 10:03 AM > To: Zhang, Qi Z ; Yang, Qiming > > Cc: dev@dpdk.org; Ye, Xiaolong ; Su, Simei > > Subject: [PATCH v2] net/ice: fix flow destroy issue for RSS > > In ice_hash_create(), whatever the hash_function is

Re: [dpdk-dev] [PATCH] net/ice: ignore error when remove RSS rule

2019-11-13 Thread Zhang, Qi Z
> -Original Message- > From: Ye, Xiaolong > Sent: Thursday, November 14, 2019 11:31 AM > To: Zhang, Qi Z > Cc: Yang, Qiming ; Su, Simei ; > dev@dpdk.org > Subject: Re: [PATCH] net/ice: ignore error when remove RSS rule > > On 11/12, Qi Zhang wrote: > >Currently, multiple rte_flow RSS

[dpdk-dev] [Bug 369] l2fwd-event fails for service core mask

2019-11-13 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=369 Bug ID: 369 Summary: l2fwd-event fails for service core mask Product: DPDK Version: unspecified Hardware: x86 OS: Linux Status: UNCONFIRMED Severity: major

[dpdk-dev] [Bug 368] missing character in document l2_forward_event.rst

2019-11-13 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=368 Bug ID: 368 Summary: missing character in document l2_forward_event.rst Product: DPDK Version: unspecified Hardware: x86 OS: Linux Status: UNCONFIRMED Severity: no

[dpdk-dev] [Bug 367] extra character in document l2_forward_event.rst

2019-11-13 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=367 Bug ID: 367 Summary: extra character in document l2_forward_event.rst Product: DPDK Version: unspecified Hardware: x86 OS: Linux Status: UNCONFIRMED Severity: norm

Re: [dpdk-dev] [PATCH v2] net/ixgbe: fix link status

2019-11-13 Thread Cui, LunyuanX
Hi, Ilya Maximets Before my patch, original treatment is as follows: esdp_reg = IXGBE_READ_REG(hw, IXGBE_ESDP); if ((esdp_reg & IXGBE_ESDP_SDP3)) link_up = 0; if (link_up == 0) { if (ixgbe_get_media_type(hw) == ixgbe_media_type_fiber) {

Re: [dpdk-dev] [PATCH] net/ice: ignore error when remove RSS rule

2019-11-13 Thread Ye Xiaolong
On 11/12, Qi Zhang wrote: >Currently, multiple rte_flow RSS rules may mapping to the same s/mapping/map >hardware rule if a later rule is just for inputset change or symm >turn on/off. so after one of the rules be destroyed, we will >get error ICE_ERR_DOES_NOT_EXIST when destroying any other rule

[dpdk-dev] [PATCH v3] port: fix library build order dependency

2019-11-13 Thread Rahul Shah
The port library should be built after eventdev library. Fixes: 5d92c4e5 ("port: add eventdev port type") Signed-off-by: Rahul Shah --- lib/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/Makefile b/lib/Makefile index 5d04ab915..1ff00ba8c 100644 --- a/lib/Makef

Re: [dpdk-dev] Mbuf memory alignment constraints for (micro)architectures

2019-11-13 Thread David Christensen
# Is PPC and other ARM SoC has formula (B) to compute DRAM channel distribution ? or Is it specific to x86? That would define where the hooks needs to added to have proper fix. The Power 9 chip has eight memory channels, each with a dedicated memory controller unit (MCU). The MCUs can be conf

[dpdk-dev] [PATCH v7 1/1] fbarray: fix duplicated fbarray file in secondary

2019-11-13 Thread yasufum . o
From: Yasufumi Ogawa In secondary_msl_create_walk(), it creates a file for fbarrays with its PID for reserving unique name among secondary processes. However, it does not work if several secondaries run as app containers because each of containerized secondary has PID 1, and failed to reserve uni

[dpdk-dev] [PATCH v7 0/1] fbarray: fix duplicated fbarray file in secondary

2019-11-13 Thread yasufum . o
From: Yasufumi Ogawa In secondary_msl_create_walk(), it creates a file for fbarrays with its PID for reserving unique name among secondary processes. However, it does not work if several secondaries run as app containers because each of containerized secondary has PID 1, and failed to reserve uni

Re: [dpdk-dev] time taken for allocation of mempool.

2019-11-13 Thread Venumadhav Josyula
Hi Anatoly, By default w/o specifying --iova-mode option is iova-mode=pa by default ? Thanks Venu On Wed, 13 Nov, 2019, 10:56 pm Burakov, Anatoly, wrote: > On 13-Nov-19 9:19 AM, Bruce Richardson wrote: > > On Wed, Nov 13, 2019 at 10:37:57AM +0530, Venumadhav Josyula wrote: > >> Hi , > >> We ar

Re: [dpdk-dev] [PATCH v2] build: add dockerfile for building docker image

2019-11-13 Thread Yasufumi Ogawa
On 2019/10/15 1:39, Ray Kinsella wrote: On 04/10/2019 11:08, Abdul Halim wrote: Adding a Dockerfile with Ubuntu bionic base image to build dpdk as shared library. This docker image could be used as base image to build and run dpdk applications in containers. Hi Abdul, I have tested your Dock

Re: [dpdk-dev] [PATCH v7 1/2] examples/multi_process/client_server_mp: check port validity

2019-11-13 Thread Stephen Hemminger
On Tue, 6 Aug 2019 12:07:25 + Matan Azrad wrote: > Hi > > > > -Original Message- > > From: dev On Behalf Of Stephen Hemminger > > Sent: Monday, August 5, 2019 7:38 PM > > To: dev@dpdk.org > > Cc: Stephen Hemminger > > Subject: [dpdk-dev] [PATCH v7 1/2] > > examples/multi_process/c

Re: [dpdk-dev] [PATCH v17 03/10] ethdev: add validation to offloads set by PMD

2019-11-13 Thread Ferruh Yigit
On 11/11/2019 1:19 PM, pbhagavat...@marvell.com wrote: > +static int > +validate_offloads(uint16_t port_id, uint64_t req_offloads, > + uint64_t set_offloads, const char *offload_type, > + const char *(*offload_name)(uint64_t)) > +{ > + uint64_t offloads_diff = req_of

Re: [dpdk-dev] [PATCH v17 02/10] ethdev: add mbuf RSS update as an offload

2019-11-13 Thread Ferruh Yigit
On 11/11/2019 1:19 PM, pbhagavat...@marvell.com wrote: > @@ -1305,6 +1306,17 @@ rte_eth_dev_configure(uint16_t port_id, uint16_t > nb_rx_q, uint16_t nb_tx_q, > goto rollback; > } > > + /* Check if Rx RSS distribution is disabled but RSS hash is enabled. */ > + if (((d

Re: [dpdk-dev] [PATCH v17 04/10] drivers/net: update Rx RSS hash offload capabilities

2019-11-13 Thread Ferruh Yigit
On 11/11/2019 1:19 PM, pbhagavat...@marvell.com wrote: > diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c > b/drivers/net/ixgbe/ixgbe_ethdev.c > index 30c0379d4..8c1caac18 100644 > --- a/drivers/net/ixgbe/ixgbe_ethdev.c > +++ b/drivers/net/ixgbe/ixgbe_ethdev.c > @@ -2402,6 +2402,9 @@ ixgbe_dev_config

[dpdk-dev] RFC - remove Transactional Memory support?

2019-11-13 Thread Stephen Hemminger
In response to the new TSX Async Abort vulnerability (TAA); perhaps it would be best to remove the limited Transactional Memory support in rte_hash. The feature is not widely used, a potential security soft spot and only supported on Intel (and broken by design there). https://git.kernel.org/p

Re: [dpdk-dev] time taken for allocation of mempool.

2019-11-13 Thread Burakov, Anatoly
On 13-Nov-19 9:19 AM, Bruce Richardson wrote: On Wed, Nov 13, 2019 at 10:37:57AM +0530, Venumadhav Josyula wrote: Hi , We are using 'rte_mempool_create' for allocation of flow memory. This has been there for a while. We just migrated to dpdk-18.11 from dpdk-17.05. Now here is problem statement

Re: [dpdk-dev] [PATCH] devtools: add SPDX license tag check script

2019-11-13 Thread Stephen Hemminger
On Wed, 13 Nov 2019 06:59:48 + Hemant Agrawal wrote: > HI Stephen, > Will you please enhance it to also provide number of files in each > category? The number of files is shrinking to zero, so may not be necessary soon. > > We also need to think about how to handle the scripts "*.s

[dpdk-dev] [PATCH] net/mlx5: fix environment variable recovery

2019-11-13 Thread Viacheslav Ovsiienko
The state of environment variable MLX5_BF_SHUT_UP was not recovered correctly if there was no tx_db_nc devarg specified. Fixes: 8409a28573d3 ("net/mlx5: control transmit doorbell register mapping") Signed-off-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5.c | 12 1 file changed

[dpdk-dev] [PATCH v2 2/2] lib: fix Doxygen typos

2019-11-13 Thread Kevin Traynor
Fix these as they are user visible. Found with codespell. Fixes: af75078fece3 ("first public release") Fixes: c2361bab70c5 ("eal: compute IOVA mode based on PA availability") Fixes: 0880c40113ef ("drivers: advertise kmod dependencies in pmdinfo") Fixes: 56b6ef874f80 ("efd: new Elastic Flow Distrib

[dpdk-dev] [PATCH v2 1/2] lib: fix log typos

2019-11-13 Thread Kevin Traynor
Fix these as they are user visible. Found with codespell. Fixes: bacaa2754017 ("eal: add channel for multi-process communication") Fixes: f05e26051c15 ("eal: add IPC asynchronous request") Fixes: 0cbce3a167f1 ("vfio: skip DMA map failure if already mapped") Fixes: 445c6528b55f ("power: common inte

[dpdk-dev] [PATCH 1/2] lib: fix log typos

2019-11-13 Thread Kevin Traynor
Found with codespell. Fixes: bacaa2754017 ("eal: add channel for multi-process communication") Fixes: f05e26051c15 ("eal: add IPC asynchronous request") Fixes: 0cbce3a167f1 ("vfio: skip DMA map failure if already mapped") Fixes: 445c6528b55f ("power: common interface for guest and host") Fixes: e6

[dpdk-dev] [PATCH 2/2] lib: fix Doxygen typos

2019-11-13 Thread Kevin Traynor
Found with codespell. Fixes: af75078fece3 ("first public release") Fixes: c2361bab70c5 ("eal: compute IOVA mode based on PA availability") Fixes: 0880c40113ef ("drivers: advertise kmod dependencies in pmdinfo") Fixes: 56b6ef874f80 ("efd: new Elastic Flow Distributor library") Fixes: 5a5f3178d4a8 (

[dpdk-dev] [Bug 366] i40e PMD returns 0 for secondary invoking rx_burst on queue 0, when Primary dies

2019-11-13 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=366 Bug ID: 366 Summary: i40e PMD returns 0 for secondary invoking rx_burst on queue 0, when Primary dies Product: DPDK Version: unspecified Hardware: x86 OS: Linux

Re: [dpdk-dev] [PATCH] net/i40e: fix clang build error with 16B descriptors

2019-11-13 Thread Ferruh Yigit
On 11/13/2019 2:31 AM, Ye Xiaolong wrote: > On 11/12, Bruce Richardson wrote: >> When compiling with 16B descriptor support enabled, clang compiles gave an >> error, complaining that the final parameter of _mm256_blend_epi32() had to >> be an immediate value (i.e. compile-time constant). While it a

Re: [dpdk-dev] [PATCH v2 0/6] bnxt patchset with bug fixes

2019-11-13 Thread Ajit Khaparde
On Wed, Nov 13, 2019 at 7:07 AM Ajit Khaparde wrote: > Patchset against dpdk-next-net. Please apply. > > v1->v2: Updated commit ids in fixes tag. > > Ajit Khaparde (2): > net/bnxt: fix a potential segfault in xstats get > net/bnxt: fix potential NULL pointer dereference > > Kalesh AP (1): >

[dpdk-dev] [PATCH v2 6/6] net/bnxt: fix potential NULL pointer dereference

2019-11-13 Thread Ajit Khaparde
Null-checking "rxq" suggests that it may be null, but it has already been dereferenced on all paths leading to the check. Refactored the code to address this issue. Coverity issue: 350594 Fixes: fc4bfea59696 ("net/bnxt: fix Rx queue start/stop for Thor based NICs") Signed-off-by: Ajit Khaparde R

[dpdk-dev] [PATCH v2 2/6] net/bnxt: cap queue count for NS3/Stingray devices

2019-11-13 Thread Ajit Khaparde
From: Somnath Kotur Cap max queue count to 128 for NS3 devices and ensure that same count is reported as part of dev_info_get_op as well Signed-off-by: Somnath Kotur Reviewed-by: Rahul Gupta --- drivers/net/bnxt/bnxt.h| 7 +++ drivers/net/bnxt/bnxt_ethdev.c | 2 +- drivers/net/bnx

[dpdk-dev] [PATCH v2 5/6] net/bnxt: change print message type from ERR to DEBUG

2019-11-13 Thread Ajit Khaparde
From: Venkat Duvvuru When an existing mac_addr is tried to get programmed again, a message is displayed that the mac_addr already exists. However the message is of type ERR. This patch changes the message to type DEBUG Fixes: 938a87db4324 ("net/bnxt: fix redundant MAC address check") Signed-off

[dpdk-dev] [PATCH v2 1/6] net/bnxt: add missing checks for firmware reset

2019-11-13 Thread Ajit Khaparde
From: Kalesh AP Driver should fail the eth_dev_ops callbacks and accessing Tx and Rx queues when device is in reset or in error state. Added missing checks for fw reset in few routines. Fixes: be14720def9c ("net/bnxt: support FW reset") Reviewed-by: Santoshkumar Karanappa Rastapur Signed-off-b

[dpdk-dev] [PATCH v2 4/6] net/bnxt: fix a potential segfault in xstats get

2019-11-13 Thread Ajit Khaparde
We would hit a segfault in bnxt_dev_xstats_get_op() if xstats argument is NULL, Check if the argument is NULL and return appropriately. Fixes: bfb9c2260be2 ("net/bnxt: support xstats get/reset") Cc: sta...@dpdk.org Signed-off-by: Ajit Khaparde Reviewed-by: Andy Gospodarek --- drivers/net/bnxt/

Re: [dpdk-dev] [PATCH v2] net/ixgbe: fix link status

2019-11-13 Thread Ilya Maximets
On 13.11.2019 17:34, Cui LunyuanX wrote: > After ports reset, tx laser register will be reset. The link > status for 82599eb got from link status register was not correct. > Set tx laser disabled after ports reset. > > ixgbe_dev_setup_link_alarm_handler() will set tx laser enabled > when show port

[dpdk-dev] [PATCH v2 3/6] net/bnxt: fix flow creation with non-consecutive group ids

2019-11-13 Thread Ajit Khaparde
From: Rahul Gupta In non-RSS mode, vnics map 1:1 with Rx queues during init. This can create problems if non-consecutive group IDs are given as part of subsequent flow create cmds as they can end up pointing to Rx queues (mapped during init) that are different than the intended destination queue

[dpdk-dev] [PATCH v2 0/6] bnxt patchset with bug fixes

2019-11-13 Thread Ajit Khaparde
Patchset against dpdk-next-net. Please apply. v1->v2: Updated commit ids in fixes tag. Ajit Khaparde (2): net/bnxt: fix a potential segfault in xstats get net/bnxt: fix potential NULL pointer dereference Kalesh AP (1): net/bnxt: add missing checks for firmware reset Rahul Gupta (1): net

Re: [dpdk-dev] [PATCH v16 01/19] net/i40e: i40e support ipn3ke FPGA port bonding

2019-11-13 Thread Ferruh Yigit
On 11/13/2019 2:38 PM, Ferruh Yigit wrote: > On 11/13/2019 7:08 AM, Rosen Xu wrote: >> From: Andy Pei >> >> In ipn3ke, each FPGA network side port bonding to an i40e pf, >> each i40e pf link status should get data from FPGA network, >> side port. This patch provide bonding relationship. >> >> Sign

Re: [dpdk-dev] [PATCH v16 10/19] raw/ifpga: add SEU error handler

2019-11-13 Thread Ferruh Yigit
On 11/13/2019 7:08 AM, Rosen Xu wrote: > Add SEU interrupt support for FPGA. > > Signed-off-by: Tianfei zhang > Signed-off-by: Rosen Xu > Signed-off-by: Andy Pei <...> > +static int > +fme_err_handle_error0(struct opae_manager *mgr) > +{ > + struct feature_fme_error0 fme_error0; > + u

Re: [dpdk-dev] [PATCH v16 01/19] net/i40e: i40e support ipn3ke FPGA port bonding

2019-11-13 Thread Ferruh Yigit
On 11/13/2019 7:08 AM, Rosen Xu wrote: > From: Andy Pei > > In ipn3ke, each FPGA network side port bonding to an i40e pf, > each i40e pf link status should get data from FPGA network, > side port. This patch provide bonding relationship. > > Signed-off-by: Rosen Xu > Signed-off-by: Andy Pei <

Re: [dpdk-dev] [EXT] Re: [PATCH v3 0/3] test: fix timeout in flags autotest

2019-11-13 Thread Krzysztof Kanas
On 12/11/2019 21:34, David Marchand wrote: > On Tue, Nov 12, 2019 at 9:29 AM Krzysztof Kanas wrote: >> On 19-11-08 14:45, David Marchand wrote: >>> External Email >>> >>> -- >>> On Fri, Nov 8, 2019 at 12:05 PM David Marchand >>>

Re: [dpdk-dev] [PATCH] MAINTAINERS: resign from NFP PMD maintainer

2019-11-13 Thread Alejandro Lucero
On Wed, Nov 13, 2019 at 12:55 PM Ferruh Yigit wrote: > On 11/13/2019 12:47 PM, Alejandro Lucero wrote: > > I'm leaving Netronome and will not work with the NFP anymore. > > Thanks Alejandro for all your contributions, and new best of luck in your > new > journey. > > Thanks Jan. It has been a ple

Re: [dpdk-dev] [PATCH] MAINTAINERS: resign from NFP PMD maintainer

2019-11-13 Thread Ferruh Yigit
On 11/13/2019 12:47 PM, Alejandro Lucero wrote: > I'm leaving Netronome and will not work with the NFP anymore. Thanks Alejandro for all your contributions, and new best of luck in your new journey. > > Signed-off-by: Alejandro Lucero > --- > MAINTAINERS | 2 +- > 1 file changed, 1 insertion(+

[dpdk-dev] [PATCH] MAINTAINERS: resign from NFP PMD maintainer

2019-11-13 Thread Alejandro Lucero
I'm leaving Netronome and will not work with the NFP anymore. Signed-off-by: Alejandro Lucero --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index f2fdb9387..9e805387d 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -771,7 +771,7 @@ F:

Re: [dpdk-dev] [PATCH] net/mlx5: fix layer bits not unique

2019-11-13 Thread Raslan Darawsheh
Hi, > -Original Message- > From: dev On Behalf Of Xiaoyu Min > Sent: Wednesday, November 13, 2019 11:30 AM > To: Matan Azrad ; Shahaf Shuler > ; Slava Ovsiienko > Cc: dev@dpdk.org; Ori Kam > Subject: [dpdk-dev] [PATCH] net/mlx5: fix layer bits not unique > > The layer bits should be un

Re: [dpdk-dev] [EXT] Re: [PATCH v12 0/2] add IOVA=VA mode support

2019-11-13 Thread Ferruh Yigit
On 11/13/2019 6:33 AM, Vamsi Krishna Attunuru wrote: > >> -Original Message- >> From: Jerin Jacob >> Sent: Friday, November 8, 2019 8:24 PM >> To: Ferruh Yigit >> Cc: Vamsi Krishna Attunuru ; dev@dpdk.org; >> tho...@monjalon.net; Jerin Jacob Kollanukkaran ; Kiran >> Kumar Kokkilagadda ;

[dpdk-dev] [PATCH] af_packet: advertise offload capabilities that code already supports

2019-11-13 Thread Paul Atkins
The af_packet pmd already supports MULTI_SEG tx packets, and tx VLAN_INSERT so advertise these capabilities. Signed-off-by: Paul Atkins --- drivers/net/af_packet/rte_eth_af_packet.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/af_packet/rte_eth_af_packet.c b/drivers/net/af_

Re: [dpdk-dev] [PATCH] net/mlx5: fix verbs flow counter query

2019-11-13 Thread Raslan Darawsheh
Hi, > -Original Message- > From: dev On Behalf Of Dekel Peled > Sent: Tuesday, November 12, 2019 4:19 PM > To: Matan Azrad ; Shahaf Shuler > ; Slava Ovsiienko > Cc: Ori Kam ; dev@dpdk.org > Subject: [dpdk-dev] [PATCH] net/mlx5: fix verbs flow counter query > > Function flow_verbs_counte

Re: [dpdk-dev] [PATCH] net/mlx5: fix the get function of Rx queue type

2019-11-13 Thread Raslan Darawsheh
Hi, > -Original Message- > From: dev On Behalf Of Dekel Peled > Sent: Monday, November 11, 2019 4:33 PM > To: Matan Azrad ; Shahaf Shuler > ; Slava Ovsiienko > Cc: Ori Kam ; dev@dpdk.org > Subject: [dpdk-dev] [PATCH] net/mlx5: fix the get function of Rx queue type > > Function mlx5_rxq_

Re: [dpdk-dev] [PATCH 0/2] small improvements for FreeBSD build

2019-11-13 Thread Luca Boccassi
On Tue, 2019-11-12 at 16:41 +, Bruce Richardson wrote: > Two small changes to improve FreeBSD build and install with meson > > Bruce Richardson (2): > freebsd: allow installing kernel modules > freebsd: always use clang for kmod compilation > > kernel/freebsd/meson.build | 7 +-- > 1

Re: [dpdk-dev] [PATCH] vhost: fix validate_msg_fds if VHOST_USER_VRING_NOFD_MASK set.

2019-11-13 Thread 王志克
Thanks for comment. Just send out v2. Br, Zhike Wang JDCloud, Product Development, IaaS   Mobile/+86 13466719566 E- mail/wangzh...@jd.com Address/5F Building A,North-Star Century Center,8 Beichen Wes

[dpdk-dev] [PATCH v2] vhost: fix vring message handling broken in some case

2019-11-13 Thread Zhike Wang
When VHOST_USER_VRING_NOFD_MASK is set, the fd_num is 0, so validate_msg_fds() will return error. In this case, the negotiation of vring message between vhost user front end and back end would fail, and as a result, vhost user link could NOT be up. How to reproduce: 1.Run dpdk testpmd insides VM,

Re: [dpdk-dev] [PATCH] doc/guides: clean repeated words

2019-11-13 Thread Kevin Traynor
On 12/11/2019 19:33, David Marchand wrote: > Shoot repeated words in all our guides. > > Signed-off-by: David Marchand Can add 'Cc: sta...@dpdk.org' and whatever applies applies. Acked-by: Kevin Traynor > --- > doc/guides/contributing/coding_style.rst | 8 > doc/gu

Re: [dpdk-dev] [PATCH] vhost: fix validate_msg_fds if VHOST_USER_VRING_NOFD_MASK set.

2019-11-13 Thread David Marchand
On Wed, Nov 13, 2019 at 10:53 AM Maxime Coquelin wrote: > > Hi Zhike, > > On 11/13/19 6:03 AM, Zhike Wang wrote: > > When VHOST_USER_VRING_NOFD_MASK is set, the fd_num is 0. > > > > Fixes: bf47225 ("vhost: fix possible denial of service by leaking FDs") > > Signed-off-by: Zhike Wang > > --- > >

Re: [dpdk-dev] [PATCH] net/mlx5: fix layer bits not unique

2019-11-13 Thread Slava Ovsiienko
> -Original Message- > From: Xiaoyu Min > Sent: Wednesday, November 13, 2019 11:30 > To: Matan Azrad ; Shahaf Shuler > ; Slava Ovsiienko > Cc: dev@dpdk.org; Ori Kam > Subject: [PATCH] net/mlx5: fix layer bits not unique > > The layer bits should be unique otherwise layer info will be in

Re: [dpdk-dev] [PATCH] vhost: fix validate_msg_fds if VHOST_USER_VRING_NOFD_MASK set.

2019-11-13 Thread Maxime Coquelin
Hi Zhike, On 11/13/19 6:03 AM, Zhike Wang wrote: > When VHOST_USER_VRING_NOFD_MASK is set, the fd_num is 0. > > Fixes: bf47225 ("vhost: fix possible denial of service by leaking FDs") > Signed-off-by: Zhike Wang > --- > lib/librte_vhost/vhost_user.c | 13 ++--- > 1 file changed, 10 inse

Re: [dpdk-dev] [PATCH] net/mlx5: fix suffix flow creation in metadata split

2019-11-13 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Viacheslav Ovsiienko > Sent: Wednesday, November 13, 2019 10:28 AM > To: dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > ; Ori Kam > Subject: [PATCH] net/mlx5: fix suffix flow creation in metadata split > > The variable cleanup was erroneously done b

Re: [dpdk-dev] [PATCH v2] net/mlx5: revert default rules amount optimization

2019-11-13 Thread Raslan Darawsheh
Hi, > -Original Message- > From: dev On Behalf Of Matan Azrad > Sent: Wednesday, November 13, 2019 12:00 AM > To: dev@dpdk.org > Cc: Slava Ovsiienko ; Dekel Peled > > Subject: [dpdk-dev] [PATCH v2] net/mlx5: revert default rules amount > optimization > > This reverts commit 304ffe576f23

[dpdk-dev] [PATCH] net/e1000: fix link status update

2019-11-13 Thread Cui LunyuanX
Unassigned variable should not be used as judgment, and there is no need to update link status according to old link status. This patch fix the issue. Fixes: 80ba61115e77 ("net/e1000: use link status helper functions") Cc: sta...@dpdk.org Signed-off-by: Lunyuan Cui --- drivers/net/e1000/em_ethd

Re: [dpdk-dev] time taken for allocation of mempool.

2019-11-13 Thread Olivier Matz
Hi Venu, On Wed, Nov 13, 2019 at 02:41:04PM +0530, Venumadhav Josyula wrote: > Hi Oliver, > > > > *> Could you give some more details about you use case? (hugepage size, > number of objects, object size, additional mempool flags, ...)* > > Ours in telecom product, we support multiple rats. Let

[dpdk-dev] [PATCH] net/mlx5: fix layer bits not unique

2019-11-13 Thread Xiaoyu Min
The layer bits should be unique otherwise layer info will be interpreted wrongly. Fixes: 70d84dc797b7 ("net/mlx5: add internal tag item and action") Cc: or...@mellanox.com Fixes: 55deee1715f0 ("net/mlx5: extend flow mark support") Cc: viachesl...@mellanox.com Signed-off-by: Xiaoyu Min --- driv

Re: [dpdk-dev] time taken for allocation of mempool.

2019-11-13 Thread Bruce Richardson
On Wed, Nov 13, 2019 at 10:37:57AM +0530, Venumadhav Josyula wrote: > Hi , > We are using 'rte_mempool_create' for allocation of flow memory. This has > been there for a while. We just migrated to dpdk-18.11 from dpdk-17.05. Now > here is problem statement > > Problem statement : > In new dpdk ( 1

Re: [dpdk-dev] [PATCH] doc/guides: clean repeated words

2019-11-13 Thread David Marchand
On 12/11/2019 20:33, David Marchand wrote: > Shoot repeated words in all our guides. > > Signed-off-by: David Marchand For anyone interested, I caught this with a patch I added to my checks: awk ' { if (prev_file != FILENAME) { prev="" prev_line=""

Re: [dpdk-dev] time taken for allocation of mempool.

2019-11-13 Thread Venumadhav Josyula
Hi Oliver, *> Could you give some more details about you use case? (hugepage size, number of objects, object size, additional mempool flags, ...)* Ours in telecom product, we support multiple rats. Let us take example of 4G case where we act as an gtpu proxy. ·Hugepage size :- 2 Mb ·

Re: [dpdk-dev] [PATCH v5 0/4] net/ice: fix memory release in FDIR

2019-11-13 Thread Ye Xiaolong
On 11/13, Wang ShougangX wrote: >These patches include FDIR memory resource fixes related to ICE driver. >Patch 1: fix memzone reserve and release in FDIR >Patch 2: fix removal of FDIR profile >Patch 3: fix FDIR counter resource release >Patch 4: fix wild pointer > >--- >v5 changes: > Changed loop

Re: [dpdk-dev] [PATCH] net/mlx5: fix suffix flow creation in metadata split

2019-11-13 Thread Matan Azrad
From: Viacheslav Ovsiienko > The variable cleanup was erroneously done before pointer usage. > The cleanup is moved to appropriate place, comment is clarified. > > Fixes: 8d72fa668964 ("net/mlx5: share tag between meter and metadata") > > Reported-by: Eli Britstein > Signed-off-by: Viacheslav

Re: [dpdk-dev] [PATCH v5 4/4] net/ice: fix wild pointer

2019-11-13 Thread Yang, Qiming
Hi, > -Original Message- > From: Wang, ShougangX > Sent: Wednesday, November 13, 2019 9:38 AM > To: dev@dpdk.org > Cc: Yang, Qiming ; Zhang, Qi Z > ; Wang, ShougangX > Subject: [PATCH v5 4/4] net/ice: fix wild pointer > > To avoid wild pointer, pointers should be set to NULL after free t

  1   2   >