Re: [dpdk-dev] [PATCH v4 1/4] ethdev: add the API for getting burst mode information

On Sat, Oct 26, 2019 at 3:57 AM Thomas Monjalon wrote: > > 25/10/2019 18:02, Jerin Jacob: > > On Fri, Oct 25, 2019 at 9:15 PM Thomas Monjalon wrote: > > > 25/10/2019 16:08, Ferruh Yigit: > > > > On 10/25/2019 10:36 AM, Thomas Monjalon wrote: > > > > > 15/10/2019 09:51, Haiyue Wang: > > > > >> Som

Re: [dpdk-dev] [PATCH v4 1/4] ethdev: add the API for getting burst mode information

> -Original Message- > From: Thomas Monjalon > Sent: Saturday, October 26, 2019 1:27 > To: Jerin Jacob > Cc: Ferruh Yigit ; Haiyue Wang > ; dpdk-dev ; > xiaolong...@intel.com; ray.kinse...@intel.com; Bernard Iremonger > ; chenmin@intel.com; Andrew > Rybchenko ; Slava Ovsiienko > ;

Re: [dpdk-dev] [PATCH v4 1/4] ethdev: add the API for getting burst mode information

26/10/2019 06:40, Wang, Haiyue: > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > 25/10/2019 18:02, Jerin Jacob: > > > On Fri, Oct 25, 2019 at 9:15 PM Thomas Monjalon > > > wrote: > > > > 25/10/2019 16:08, Ferruh Yigit: > > > > > On 10/25/2019 10:36 AM, Thomas Monjalon wrote: > > > > > > 1

Re: [dpdk-dev] [PATCH v4 1/4] ethdev: add the API for getting burst mode information

> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Saturday, October 26, 2019 06:27 > To: Jerin Jacob > Cc: Yigit, Ferruh ; Wang, Haiyue > ; dpdk-dev > ; Ye, Xiaolong ; Kinsella, Ray > ; > Iremonger, Bernard ; Sun, Chenmin > ; Andrew > Rybchenko ; Slava Ov

Re: [dpdk-dev] [PATCH v2 0/4] some fixes for hns3 PMD driver

Hi, Ferruh Yigit Can this series of fixes be added to dpdk version 19.11? Thanks. Regards Xavier On 2019/10/26 9:03, Wei Hu (Xavier) wrote: > > On 2019/10/25 23:07, Ferruh Yigit wrote: >> On 10/25/2019 1:37 PM, Wei Hu (Xavier) wrote: >>> This series adds some fixes for hns3 ethernet

Re: [dpdk-dev] [PATCH v2 0/4] some fixes for hns3 PMD driver

On 2019/10/25 23:07, Ferruh Yigit wrote: > On 10/25/2019 1:37 PM, Wei Hu (Xavier) wrote: >> This series adds some fixes for hns3 ethernet pmd driver. >> >> v1 -> v2: >> 1. Address some comments from Ferruh Yigit as belows: >> >> https://inbox.dpdk.org/dev/31868759-1900-2aad-4e38-0a

Re: [dpdk-dev] Please stop using iopl() in DPDK

> On Oct 25, 2019, at 9:13 AM, Stephen Hemminger > wrote: > > On Thu, 24 Oct 2019 21:45:56 -0700 > Andy Lutomirski wrote: > >> Hi all- >> >> Supporting iopl() in the Linux kernel is becoming a maintainability >> problem. As far as I know, DPDK is the only major modern user of >> iopl(). >> >>

Re: [dpdk-dev] [PATCH v11 0/9] vhost: support inflight share memory protocol feature

25/10/2019 12:12, Maxime Coquelin: > On 10/25/19 12:08 PM, Thomas Monjalon wrote: > > 16/10/2019 13:12, Maxime Coquelin: > >> On 10/9/19 10:48 PM, Jin Yu wrote: > >>> Jin Yu (9): > >>> vhost: add the inflight description > >>> vhost: add packed ring > >>> vhost: add the inflight structure > >

Re: [dpdk-dev] [PATCH v6] app/testpmd: enable GTP header parse and Tx checksum offload

22/10/2019 18:26, Ting Xu: > This patch enables testpmd to forward GTP packet in csum fwd mode. > A GTP header structure (without optional fields and extension header) > is defined in new rte_gtp.h. A parser function in testpmd is added. > GTPU and GTPC packets are both supported, with respective U

Re: [dpdk-dev] [PATCH v6] app/testpmd: enable GTP header parse and Tx checksum offload

23/10/2019 19:23, Ferruh Yigit: > On 10/22/2019 4:45 PM, Ferruh Yigit wrote: > > On 10/22/2019 5:26 PM, Ting Xu wrote: > >> This patch enables testpmd to forward GTP packet in csum fwd mode. > >> A GTP header structure (without optional fields and extension header) > >> is defined in new rte_gtp.h.

Re: [dpdk-dev] [PATCH v4 1/4] ethdev: add the API for getting burst mode information

25/10/2019 18:02, Jerin Jacob: > On Fri, Oct 25, 2019 at 9:15 PM Thomas Monjalon wrote: > > 25/10/2019 16:08, Ferruh Yigit: > > > On 10/25/2019 10:36 AM, Thomas Monjalon wrote: > > > > 15/10/2019 09:51, Haiyue Wang: > > > >> Some PMDs have more than one RX/TX burst paths, add the ethdev API > > >

Re: [dpdk-dev] [PATCH v5 02/15] ethdev: add support for hairpin queue

25/10/2019 21:01, Ori Kam: > From: Thomas Monjalon > > 24/10/2019 17:30, Andrew Rybchenko: > > > On 10/24/19 6:17 PM, Thomas Monjalon wrote: > > > > 24/10/2019 16:47, Andrew Rybchenko: > > > >> On 10/24/19 11:29 AM, Ori Kam wrote: > > > >>> Hi Andrew, > > > >>> > > > >>> When writing the new funct

Re: [dpdk-dev] [PATCH v2 0/3] move mbuf definition into a separate file

27/09/2019 15:50, Konstantin Ananyev: > Konstantin Ananyev (3): > eal: move CACHE and IOVA related definitions > mbuf: move mbuf definition into a separate file > examples/bpf: remove duplicate mbuf definition Applied, thanks

Re: [dpdk-dev] [PATCH v4 1/1] fbarray: get fbarrays from containerized secondary

Hi David, Thank you for your comments. On 2019/10/26 0:36, David Marchand wrote: On Fri, Oct 11, 2019 at 11:36 AM David Marchand wrote: Some comments. ping. The title does not reflect the observed issue. I would like to consider to revise it. I understand that secondary processeses

Re: [dpdk-dev] [PATCH v3 07/12] log: add log stream accessor

On 25/10/2019 14:56, David Marchand wrote: > Define an accessor so that users can write their debug message to the > same stream than the rte_log infrastructure. > Use it in the qat infrastructure. > > Signed-off-by: David Marchand > Acked-by: Thomas Monjalon > --- > Changelog since v1: > - use

Re: [dpdk-dev] [RFC v2 6/7] app/testpmd: macsec on/off commands using rte_security interface

On Fri, 25 Oct 2019 17:54:08 + Pavel Belous wrote: > +static struct rte_mempool *get_security_pool(struct rte_security_ctx *ctx) > +{ > + struct rte_mempool *mp = rte_mempool_lookup(TESTPMD_MEMPOOL_NAME); > + > + if (!mp) { > + unsigned int ssize = rte_security_session_get

Re: [dpdk-dev] [RFC v2 6/7] app/testpmd: macsec on/off commands using rte_security interface

On Fri, 25 Oct 2019 17:54:08 + Pavel Belous wrote: > +int set_macsec_on_off(portid_t port_id, int on, int en, int rp) > +{ > + struct rte_security_session_conf macsec_conf; > + struct rte_security_ctx *ctx; > + struct rte_mempool *mp; > + int err = 0; > + > + ctx = rte_eth

Re: [dpdk-dev] [PATCH v5 02/15] ethdev: add support for hairpin queue

Hi Andrew, Thomas > -Original Message- > From: Thomas Monjalon > Sent: Thursday, October 24, 2019 6:35 PM > To: Andrew Rybchenko > Cc: dev@dpdk.org; Ori Kam ; Ferruh Yigit > ; jingjing...@intel.com; > step...@networkplumber.org > Subject: Re: [dpdk-dev] [PATCH v5 02/15] ethdev: add suppo

Re: [dpdk-dev] [PATCH 1/2] config: fix RHEL7.6 build errors on Power 9 systems

gcc 4.8.5 used on RHEL 7.6 can identify a Power 9 CPU but cannot generate Power 9 code when the "-mcpu=native" command line argument is used. Test whether the compiler can generate Power 9 code and adjust the machine setting appropriately. Signed-off-by: David Christensen --- Ping

Re: [dpdk-dev] [PATCH v5 00/15] add hairpin feature

On 10/23/2019 2:37 PM, Ori Kam wrote: > This patch set implements the hairpin feature. > The hairpin feature was introduced in RFC[1] > > The hairpin feature (different name can be forward) acts as "bump on the > wire", > meaning that a packet that is received from the wire can be modified using

Re: [dpdk-dev] [PATCH v2] kni: add ability to set min/max MTU

On 10/25/2019 7:30 PM, Ferruh Yigit wrote: > From: Igor Ryzhov > > Starting with kernel version 4.10, there are new min/max MTU values in > net_device structure, which are set to ETH_MIN_MTU and ETH_DATA_LEN by > default. We should be able to change these values to allow MTU more than > 1500 to b

[dpdk-dev] [PATCH v2] kni: add ability to set min/max MTU

From: Igor Ryzhov Starting with kernel version 4.10, there are new min/max MTU values in net_device structure, which are set to ETH_MIN_MTU and ETH_DATA_LEN by default. We should be able to change these values to allow MTU more than 1500 to be set on KNI. Signed-off-by: Igor Ryzhov Acked-by: Fe

[dpdk-dev] [RFC v2 7/7] app/testpmd: macsec adding RX/TX SC using rte_security interface

From: Pavel Belous Signed-off-by: Pavel Belous Signed-off-by: Igor Russkikh --- app/test-pmd/cmdline.c | 11 +- app/test-pmd/macsec.c | 56 ++ app/test-pmd/macsec.h | 2 ++ 3 files changed, 63 insertions(+), 6 deletions(-) diff --git

[dpdk-dev] [RFC v2 4/7] net/atlantic: add MACSEC internal HW data declaration and functions

From: Pavel Belous MACSEC configuration is done by configuring multiple tables of MACSEC block: - Ingress Pre-Security Classification table - Ingress SC/SA/SAK lookup tables - Ingress Post-Security Classification table - Egress Packet Classifier table - Egress Control Filter table - Egress SC/SA

[dpdk-dev] [RFC v2 5/7] net/atlantic: implementation of the MACSEC using rte_security interface

From: Pavel Belous Signed-off-by: Pavel Belous --- drivers/net/atlantic/Makefile | 2 +- drivers/net/atlantic/atl_ethdev.c | 316 ++- drivers/net/atlantic/atl_sec.c| 615 ++ drivers/net/atlantic/atl_sec.h

[dpdk-dev] [RFC v2 6/7] app/testpmd: macsec on/off commands using rte_security interface

From: Pavel Belous Here we create/get security mempool, get sec_ctx, and then request session creation with macsec specific session configuration. encrypt and replay_protection parameters are really not a global macsec attributes, they are related to tx and rx security connection properties. Bu

[dpdk-dev] [RFC v2 3/7] net/atlantic: Add helper functions for PHY access

From: Pavel Belous Aquantia AQC107/AQC108 ethernet controllers includes MAC and PHY part. Some network features, like MACSec, are configured directly in the PHY part. This patch adds helper functions for accessing PHY part via internal MDIO interface. Signed-off-by: Pavel Belous --- drivers/

[dpdk-dev] [RFC v2 1/7] security: MACSEC infrastructure data declarations

From: Pavel Belous This patch extends rte_security framework to support MACSEC operations. Signed-off-by: Igor Russkikh Signed-off-by: Pavel Belous --- lib/librte_security/rte_security.h | 143 +++-- 1 file changed, 138 insertions(+), 5 deletions(-) diff --git

[dpdk-dev] [RFC v2 2/7] security: Update rte_security documentation

From: Pavel Belous Signed-off-by: Pavel Belous --- doc/guides/prog_guide/rte_security.rst | 4 1 file changed, 4 deletions(-) diff --git a/doc/guides/prog_guide/rte_security.rst b/doc/guides/prog_guide/rte_security.rst index 7d0734a..4b9b186 100644 --- a/doc/guides/prog_guide/rte_securit

[dpdk-dev] [RFC v2 0/7] RFC: Support MACSEC offload in the RTE_SECURITY infrastructure.

From: Pavel Belous This RFC suggest possible API to implement generic MACSEC HW offload in DPDK infrastructure. Right now two PMDs implementing MACSEC hw offload via private API: ixgbe (Intel) and atlantic (Aquantia). During that private API discussion it was decided to go further with well def

Re: [dpdk-dev] Performance impact of "declaring" more CPU cores

The only useful observation we made is that when we are in a "bad case", the LLC has more cache misses. Have you looked closely at the CPU topology on your platform, can you provide some examples here of what you're seeing? The hwloc package is very useful in visualizing how your logical core

Re: [dpdk-dev] [PATCH v10 2/5] eal: add the APIs to wait until equal

Hi Gavin, > The rte_wait_until_equal_xx APIs abstract the functionality of > 'polling for a memory location to become equal to a given value'. > > Add the RTE_ARM_USE_WFE configuration entry for aarch64, disabled > by default. When it is enabled, the above APIs will call WFE instruction > to save

Re: [dpdk-dev] [PATCH] event/octeontx2: use wfe while waiting for head

Hi Gavin, >Hi Pavan, > >> -Original Message- >> From: Pavan Nikhilesh Bhagavatula >> Sent: Friday, October 25, 2019 12:26 PM >> To: Gavin Hu (Arm Technology China) ; >> jer...@marvell.com >> Cc: dev@dpdk.org; nd >> Subject: RE: [dpdk-dev] [PATCH] event/octeontx2: use wfe while >waiting fo

Re: [dpdk-dev] [PATCH v5] net/memif: zero-copy slave

On 8/22/2019 9:18 AM, Jakub Grajciar wrote: > Zero-copy slave support for memif PMD. > Slave interface exposes DPDK memory to > master interface. Only single file segments > are supported (EAL option --single-file-segments). > > Signed-off-by: Jakub Grajciar Reviewed-by: Ferruh Yigit Since bin

Re: [dpdk-dev] [PATCH] event/octeontx2: use wfe while waiting for head

Hi Pavan, > -Original Message- > From: Pavan Nikhilesh Bhagavatula > Sent: Friday, October 25, 2019 12:26 PM > To: Gavin Hu (Arm Technology China) ; > jer...@marvell.com > Cc: dev@dpdk.org; nd > Subject: RE: [dpdk-dev] [PATCH] event/octeontx2: use wfe while waiting for > head > > Hi Gav

Re: [dpdk-dev] [PATCH v3] port: Eventdev port support added in the rte_port library

25/10/2019 17:39, Dumitrescu, Cristian: > From: Shah, Rahul R > > > > Adding a new port type called eventdev to the > > rte_port library. > > > > Signed-off-by: Rahul Shah > > Acked-by: Cristian Dumitrescu > > The only cosmetic change I would suggest is for the name of the patch, which > can

[dpdk-dev] [PATCH v7 4/4] doc: add maintainer for abi policy

Add an entry to the maintainer file for the abi policy. Signed-off-by: Ray Kinsella --- MAINTAINERS | 4 1 file changed, 4 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index f0f555b..6ae7fb3 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -80,6 +80,10 @@ M: Marko Kovacevic F: READM

[dpdk-dev] [PATCH v7 2/4] doc: changes to abi policy introducing major abi versions

This policy change introduces major ABI versions, these are declared every year, typically aligned with the LTS release and are supported by subsequent releases in the following year. This change is intended to improve ABI stabilty for those projects consuming DPDK. Signed-off-by: Ray Kinsella --

[dpdk-dev] [PATCH v7 3/4] doc: updates to versioning guide for abi versions

Updates to the ABI versioning guide, to account for the changes to the DPDK ABI/API policy. Fixes for references to abi versioning and policy guides. Signed-off-by: Ray Kinsella --- doc/guides/contributing/abi_versioning.rst | 248 +++-- doc/guides/contributing/patches.rs

[dpdk-dev] [PATCH v7 1/4] doc: separate versioning.rst into version and policy

Separate versioning.rst into abi versioning and abi policy guidance, in preparation for adding more detail to the abi policy. Signed-off-by: Ray Kinsella --- doc/guides/contributing/abi_policy.rst | 167 doc/guides/contributing/abi_versioning.rst | 427 + doc/gui

[dpdk-dev] [PATCH v7 0/4] doc: changes to abi policy introducing major abi versions

TL;DR abbreviation: A major ABI version that all DPDK releases during an agreed period support. ABI versioning is managed at a project-level, in place of library-level management. ABI changes to add new features are permitted, as long as ABI compatibility with the major ABI version is maintained.

Re: [dpdk-dev] [RFC] mempool: introduce indexed memory pool

On Fri, Oct 25, 2019 at 8:59 PM Xueming(Steven) Li wrote: > > > >From: Jerin Jacob > >Sent: Saturday, October 19, 2019 8:28 PM > > > >On Fri, 18 Oct, 2019, 3:40 pm Xueming(Steven) Li, > > wrote: > >> -Original Message- > >> From: Jerin Jacob

Re: [dpdk-dev] [PATCH] cmdline: prefix cmdline numeric enum

On Fri, 25 Oct 2019 11:55:41 +0100 Bruce Richardson wrote: > On Thu, Oct 24, 2019 at 11:09:26AM -0700, Stephen Hemminger wrote: > > The values in an enum are really global names and not specific > > to the enum in question. This can lead to namespace conflicts > > in applications if a common valu

Re: [dpdk-dev] Please stop using iopl() in DPDK

On Thu, 24 Oct 2019 21:45:56 -0700 Andy Lutomirski wrote: > Hi all- > > Supporting iopl() in the Linux kernel is becoming a maintainability > problem. As far as I know, DPDK is the only major modern user of > iopl(). > > After doing some research, DPDK uses direct io port access for only a > s

Re: [dpdk-dev] [PATCH v13 3/6] drivers/net: update Rx RSS hash offload capabilities

>On 10/25/19 5:33 PM, pbhagavat...@marvell.com wrote: >> From: Pavan Nikhilesh >> >> Add DEV_RX_OFFLOAD_RSS_HASH flag for all PMDs that support RSS >hash >> delivery. >> >> Signed-off-by: Pavan Nikhilesh >> Reviewed-by: Andrew Rybchenko >> Reviewed-by: Hemant Agrawal >> Acked-by: Jerin Jacob >

Re: [dpdk-dev] [PATCH v2 2/2] sched: modify internal structs and functions for 64 bit values

16/10/2019 17:14, Dumitrescu, Cristian: > From: Singh, Jasvinder > > > > Modify internal structure and functions to support 64-bit > > values for rates and stats parameters. > > > > Signed-off-by: Jasvinder Singh > > Signed-off-by: Lukasz Krakowiak > > --- > > v2: > > - remove rte_sched_min_val

Re: [dpdk-dev] [PATCH v4 1/4] ethdev: add the API for getting burst mode information

On Fri, Oct 25, 2019 at 9:15 PM Thomas Monjalon wrote: > > 25/10/2019 16:08, Ferruh Yigit: > > On 10/25/2019 10:36 AM, Thomas Monjalon wrote: > > > 15/10/2019 09:51, Haiyue Wang: > > >> Some PMDs have more than one RX/TX burst paths, add the ethdev API > > >> that allows an application to retrieve

Re: [dpdk-dev] [PATCH 1/2] security: add anti replay window size

Hi Konstantin, > -Original Message- > From: Ananyev, Konstantin > Sent: Friday, October 25, 2019 3:30 PM > To: Hemant Agrawal ; dev@dpdk.org; Akhil > Goyal ; Doherty, Declan > Subject: RE: [dpdk-dev] [PATCH 1/2] security: add anti replay window size > Importance: High > > Hi Hemant, >

Re: [dpdk-dev] [PATCH v7 00/15] sched: subport level configuration of pipe nodes

25/10/2019 12:51, Jasvinder Singh: > This patchset refactors the dpdk qos sched library to allow subport > level configuration flexibility of the pipe nodes. > > Currently, all parameters for the pipe nodes (subscribers) > configuration are part of the port level structure which forces > all group

Re: [dpdk-dev] [PATCH v5] eal: add manual probing option

On Fri, Oct 25, 2019 at 9:16 PM Gaetan Rivet wrote: > > Add a new EAL option enabling manual probing in the EAL. > This command line option will configure the EAL so that buses > will not trigger their probe step on their own. > > Applications are then expected to hotplug devices as they see fit.

[dpdk-dev] [PATCH v5] eal: add manual probing option

Add a new EAL option enabling manual probing in the EAL. This command line option will configure the EAL so that buses will not trigger their probe step on their own. Applications are then expected to hotplug devices as they see fit. Devices declared on the command line by the user (using -w and

Re: [dpdk-dev] [PATCH v4 1/4] ethdev: add the API for getting burst mode information

25/10/2019 16:08, Ferruh Yigit: > On 10/25/2019 10:36 AM, Thomas Monjalon wrote: > > 15/10/2019 09:51, Haiyue Wang: > >> Some PMDs have more than one RX/TX burst paths, add the ethdev API > >> that allows an application to retrieve the mode information about > >> Rx/Tx packet burst such as Scalar o

Re: [dpdk-dev] [PATCH v3] port: Eventdev port support added in the rte_port library

Hi Rahul, Thank you for your work! > -Original Message- > From: Shah, Rahul R > Sent: Tuesday, October 1, 2019 7:05 PM > To: Dumitrescu, Cristian > Cc: dev@dpdk.org > Subject: [PATCH v3] port: Eventdev port support added in the rte_port > library > > Adding a new port type called eventd

Re: [dpdk-dev] [PATCH v2] app/test: fix build when ring PMD is disabled

> -Original Message- > From: David Marchand > On Thu, Oct 17, 2019 at 1:16 PM Reshma Pattan > wrote: > > diff --git a/app/test/meson.build b/app/test/meson.build index > > 2c23c6347..e221e44f7 100644 > > --- a/app/test/meson.build > > +++ b/app/test/meson.build > > [snip] > > > @@

Re: [dpdk-dev] [PATCH v3] port: Eventdev port support added in the rte_port library

> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Friday, October 25, 2019 4:35 PM > To: Dumitrescu, Cristian ; Singh, Jasvinder > > Cc: dev@dpdk.org; Shah, Rahul R > Subject: Re: [dpdk-dev] [PATCH v3] port: Eventdev port support added in the > rte_port

Re: [dpdk-dev] [PATCH] vfio: fix BAR offset type for 32-bit app

On 24-Oct-19 1:10 PM, Michal Krawczyk wrote: When 32-bit application is built on 64-bit system it is possible that the offset of the resource is outside of the 32-bit value. The problem with the unsigned long is, that it is 32-bit and not 64-bit when using armhf compiler. Although the system is

[dpdk-dev] [PATCH v10 1/5] bus/fslmc: fix the conflicting dmb function

There are two definitions conflicting each other, for more details, refer to [1]. include/rte_atomic_64.h:19: error: "dmb" redefined [-Werror] drivers/bus/fslmc/mc/fsl_mc_sys.h:36: note: this is the location of the previous definition #define dmb() {__asm__ __volatile__("" : : : "memory"); } The

[dpdk-dev] [PATCH v10 4/5] net/thunderx: use new API to save cycles on aarch64

Use the new API to wait in low power state instead of continuous polling to save CPU cycles and power. Signed-off-by: Gavin Hu Reviewed-by: Ruifeng Wang Acked-by: Jerin Jacob --- drivers/net/thunderx/Makefile | 1 + drivers/net/thunderx/meson.build | 1 + drivers/net/thunderx/nicvf_rxtx.c

[dpdk-dev] [PATCH v10 3/5] ticketlock: use new API to reduce contention on aarch64

While using ticket lock, cores repeatedly poll the lock variable. This is replaced by rte_wait_until_equal API. Running ticketlock_autotest on ThunderX2, Ampere eMAG80, and Arm N1SDP[1], there were variances between runs, but no notable performance gain or degradation were seen with and without th

[dpdk-dev] [PATCH v10 2/5] eal: add the APIs to wait until equal

The rte_wait_until_equal_xx APIs abstract the functionality of 'polling for a memory location to become equal to a given value'. Add the RTE_ARM_USE_WFE configuration entry for aarch64, disabled by default. When it is enabled, the above APIs will call WFE instruction to save CPU cycles and power.

[dpdk-dev] [PATCH v10 5/5] event/opdl: use new API to save cycles on aarch64

Use the new API to wait in low power state instead of continuous polling to save CPU cycles and power. Signed-off-by: Gavin Hu Reviewed-by: Ruifeng Wang Reviewed-by: Jerin Jacob --- drivers/event/opdl/Makefile| 1 + drivers/event/opdl/meson.build | 1 + drivers/event/opdl/opdl_ring.c | 5 +

[dpdk-dev] [PATCH v10 0/5] use WFE for aarch64

V10: - move arm specific stuff to arch/arm/rte_pause_64.h V9: - fix a weblink broken (David Marchand) - define rte_wfe and rte_sev() (Ananyev Konstantin) - explicitly define three function APIs instead of marcos (Ananyev Konstantin) - incorporate common rte_wfe and rte_sev into the generic rte_spin

[dpdk-dev] [PATCH v3] app/test: fix build when ring PMD is disabled

1)pdump, latency, bitrate, ring PMD and test_event_eth_tx_adapter unit tests are dependent on ring PMD, so compile those tests only when ring PMD is enabled else ignore. 2)get rid of make file error which was added by bond unit test for ring PMD disabled case which is not necessary. Fixes: 086eb6

Re: [dpdk-dev] [PATCH v4 1/1] fbarray: get fbarrays from containerized secondary

On Fri, Oct 11, 2019 at 11:36 AM David Marchand wrote: > > Some comments. ping. > > The title does not reflect the observed issue. > I understand that secondary processeses can't be started from a docker > container. > The patch title should reflect this. > > On Wed, Jul 24, 2019 at 10:20 AM w

Re: [dpdk-dev] [PATCH v3] port: Eventdev port support added in the rte_port library

01/10/2019 20:05, Rahul Shah: > Adding a new port type called eventdev to the > rte_port library. > > Signed-off-by: Rahul Shah > --- > lib/librte_port/Makefile | 4 +- > lib/librte_port/meson.build | 8 +- > lib/librte_port/rte_port_eventdev.c | 585 +++

Re: [dpdk-dev] [PATCH v3 12/12] doc: announce global logs struct removal from ABI

25/10/2019 15:56, David Marchand: > New accessor has been introduced to provide the hidden information. > This symbol can now be kept internal. [..] > +* eal: The ``rte_logs`` struct and global symbol will be made private to > + remove it from the externally visible ABI and allow it to be updated

Re: [dpdk-dev] [PATCH v3 12/12] doc: announce global logs struct removal from ABI

On 25-Oct-19 2:56 PM, David Marchand wrote: New accessor has been introduced to provide the hidden information. This symbol can now be kept internal. Signed-off-by: David Marchand --- doc/guides/rel_notes/deprecation.rst | 4 1 file changed, 4 insertions(+) diff --git a/doc/guides/rel_

Re: [dpdk-dev] [RFC] mempool: introduce indexed memory pool

>From: Jerin Jacob >Sent: Saturday, October 19, 2019 8:28 PM > >On Fri, 18 Oct, 2019, 3:40 pm Xueming(Steven) Li, > wrote: >> -Original Message- >> From: Jerin Jacob >> Sent: Friday, October 18, 2019 12:41 AM >> To: Xueming(St

Re: [dpdk-dev] [PATCH v3 11/12] eal: make the global configuration private

On 25-Oct-19 2:56 PM, David Marchand wrote: Now that all elements of the rte_config structure have (deinlined) accessors, we can hide it. Signed-off-by: David Marchand Acked-by: Thomas Monjalon --- Can't think of any uses covered by this struct that aren't already covered by our API's, so..

Re: [dpdk-dev] [PATCH v3 08/12] test/mem: remove dependency on EAL internals

On 25-Oct-19 2:56 PM, David Marchand wrote: Rather than dereference the mem_config internal structure, we can rely on the rte_memzone_walk API and count memzones. Signed-off-by: David Marchand Acked-by: Thomas Monjalon --- Acked-by: Anatoly Burakov -- Thanks, Anatoly

Re: [dpdk-dev] [PATCH v3 04/12] mem: hide internal heap header

On 25-Oct-19 2:56 PM, David Marchand wrote: Let's avoid exporting structures without an identified usecase. Signed-off-by: David Marchand Acked-by: Thomas Monjalon --- Acked-by: Anatoly Burakov -- Thanks, Anatoly

[dpdk-dev] [PATCH 1/2] ethdev: add flow action type update as an offload

From: Pavan Nikhilesh Add new Rx offload flag `DEV_RX_OFFLOAD_FLOW_MARK` that can be used to enable/disable PMDs write to `rte_mbuf::hash::fdir::hi` and `rte_mbuf::ol_flags` when flow actions `RTE_FLOW_ACTION_MARK` and `RTE_FLOW_ACTION_FLAG` are enabled. PMDs notify the validity of `rte_mbuf::ha

Re: [dpdk-dev] [PATCH v3 03/12] eal: remove deprecated malloc virt2phys function

On 25-Oct-19 2:56 PM, David Marchand wrote: Remove rte_malloc_virt2phy as announced previously. Signed-off-by: David Marchand Acked-by: Thomas Monjalon --- Acked-by: Anatoly Burakov -- Thanks, Anatoly

[dpdk-dev] [PATCH 2/2] drivers/net: update Rx flow flag and mark capabilities

From: Pavan Nikhilesh Add DEV_RX_OFFLOAD_FLOW_MARK flag for all PMDs that support flow action flag and mark. Signed-off-by: Pavan Nikhilesh Reviewed-by: Andrew Rybchenko Acked-by: Jerin Jacob --- drivers/net/bnxt/bnxt_ethdev.c | 3 ++- drivers/net/enic/enic_res.c | 3 +

Re: [dpdk-dev] [PATCH v3 02/12] eal: remove deprecated CPU flags check function

On 25-Oct-19 2:56 PM, David Marchand wrote: Remove rte_cpu_check_supported as announced previously. Signed-off-by: David Marchand Acked-by: Thomas Monjalon --- Acked-by: Anatoly Burakov -- Thanks, Anatoly

Re: [dpdk-dev] [PATCH v3 01/12] eal: make lcore config private

On 25-Oct-19 2:56 PM, David Marchand wrote: From: Stephen Hemminger The internal structure of lcore_config does not need to be part of visible API/ABI. Make it private to EAL. Rearrange the structure so it takes less memory (and cache footprint). Signed-off-by: Stephen Hemminger Signed-off-b

Re: [dpdk-dev] [PATCH v2 0/4] some fixes for hns3 PMD driver

On 10/25/2019 1:37 PM, Wei Hu (Xavier) wrote: > This series adds some fixes for hns3 ethernet pmd driver. > > v1 -> v2: > 1. Address some comments from Ferruh Yigit as belows: > > https://inbox.dpdk.org/dev/31868759-1900-2aad-4e38-0ae8fe526...@intel.com > > https://inbox.

Re: [dpdk-dev] [PATCH] eal: add option --iso-cmem for external custom memory

On 25-Oct-19 1:53 PM, Rajesh Ravi wrote: Thanks Anatoly. I think now we 're close to sync. You understood it right: the problem is dma/iommu mappings are not getting created. 1)vfio_mem_event_callback() is getting called later when memory is allocated from heap but not when external memory is

Re: [dpdk-dev] [PATCH v4] eal: add manual probing option

On Fri, Oct 25, 2019 at 8:11 PM Gaetan Rivet wrote: > > Add a new EAL option enabling manual probing in the EAL. > This command line option will configure the EAL so that buses > will not trigger their probe step on their own. > > Applications are then expected to hotplug devices as they see fit.

Re: [dpdk-dev] [PATCH v13 3/6] drivers/net: update Rx RSS hash offload capabilities

On 10/25/19 5:33 PM, pbhagavat...@marvell.com wrote: From: Pavan Nikhilesh Add DEV_RX_OFFLOAD_RSS_HASH flag for all PMDs that support RSS hash delivery. Signed-off-by: Pavan Nikhilesh Reviewed-by: Andrew Rybchenko Reviewed-by: Hemant Agrawal Acked-by: Jerin Jacob Acked-by: Ajit Khaparde

Re: [dpdk-dev] Please stop using iopl() in DPDK

On Thu, Oct 24, 2019 at 11:42 PM Willy Tarreau wrote: > > Hi Andy, > > On Thu, Oct 24, 2019 at 09:45:56PM -0700, Andy Lutomirski wrote: > > Hi all- > > > > Supporting iopl() in the Linux kernel is becoming a maintainability > > problem. As far as I know, DPDK is the only major modern user of > >

[dpdk-dev] [PATCH v4] eal: add manual probing option

Add a new EAL option enabling manual probing in the EAL. This command line option will configure the EAL so that buses will not trigger their probe step on their own. Applications are then expected to hotplug devices as they see fit. Devices declared on the command line by the user (using -w and

Re: [dpdk-dev] [PATCH] net/virtio: fix broken Tx checksum offloads

On 10/25/2019 9:30 AM, Maxime Coquelin wrote: > > > On 10/24/19 7:46 PM, Andrew Rybchenko wrote: >> Missing parenthesis around expression before type cast to struct >> virtio_net_hdr pointer makes the arithmetic to be in >> sizeof(struct virtio_net_hdr) units. >> >> Use rte_pktmbuf_mtod_offset()

[dpdk-dev] [PATCH v13 6/6] app/testpmd: add command to set supported ptype mask

From: Pavan Nikhilesh Add command to set supported ptype mask. Usage: set port ptype_mask Disable ptype parsing by default. Signed-off-by: Pavan Nikhilesh --- app/test-pmd/cmdline.c | 80 + app/test-pmd/testpmd.c | 6 ++

[dpdk-dev] [PATCH v13 5/6] examples/l2fwd: disable ptype parsing

From: Pavan Nikhilesh Disable packet type parsing as l2fwd doesn't rely on packet types. Signed-off-by: Pavan Nikhilesh --- examples/l2fwd/Makefile| 1 + examples/l2fwd/main.c | 2 ++ examples/l2fwd/meson.build | 1 + 3 files changed, 4 insertions(+) diff --git a/examples/l2fwd/Makef

[dpdk-dev] [PATCH v13 4/6] examples/eventdev_pipeline: add new Rx RSS hash offload

From: Pavan Nikhilesh Since pipeline_generic uses `rte_mbuf::hash::rss` add the new Rx offload flag `DEV_RX_OFFLOAD_RSS_HASH` to inform PMD to copy the RSS hash result into the mbuf. Signed-off-by: Pavan Nikhilesh --- examples/eventdev_pipeline/main.c | 128 - .../p

[dpdk-dev] [PATCH v13 3/6] drivers/net: update Rx RSS hash offload capabilities

From: Pavan Nikhilesh Add DEV_RX_OFFLOAD_RSS_HASH flag for all PMDs that support RSS hash delivery. Signed-off-by: Pavan Nikhilesh Reviewed-by: Andrew Rybchenko Reviewed-by: Hemant Agrawal Acked-by: Jerin Jacob Acked-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_ethdev.c | 9 -

[dpdk-dev] [PATCH v13 2/6] ethdev: add mbuf RSS update as an offload

From: Pavan Nikhilesh Add new Rx offload flag `DEV_RX_OFFLOAD_RSS_HASH` which can be used to enable/disable PMDs write to `rte_mbuf::hash::rss`. PMDs notify the validity of `rte_mbuf::hash:rss` to the applcation by enabling `PKT_RX_RSS_HASH ` flag in `rte_mbuf::ol_flags`. Signed-off-by: Pavan Ni

[dpdk-dev] [PATCH v13 0/6] ethdev: add new Rx offload flags

From: Pavan Nikhilesh Add new Rx offload flags `DEV_RX_OFFLOAD_RSS_HASH` These flags can be used to enable/disable PMD writes to rte_mbuf fields `hash.rss` and also `ol_flags:PKT_RX_RSS` and `ol_flags:PKT_RX_FDIR`. Add new packet type set function `rte_eth_dev_set_supported_ptypes`, allows appli

[dpdk-dev] [PATCH v13 1/6] ethdev: add set ptype function

From: Pavan Nikhilesh Add `rte_eth_dev_set_supported_ptypes` function that will allow the application to inform the PMD the packet types it is interested in. Based on the ptypes set PMDs can optimize their Rx path. -If application doesn’t want any ptype information it can call `rte_eth_dev_set_s

Re: [dpdk-dev] [PATCH v4 1/4] ethdev: add the API for getting burst mode information

On 10/25/2019 10:36 AM, Thomas Monjalon wrote: > 15/10/2019 09:51, Haiyue Wang: >> Some PMDs have more than one RX/TX burst paths, add the ethdev API >> that allows an application to retrieve the mode information about >> Rx/Tx packet burst such as Scalar or Vector, and Vector technology >> like AV

[dpdk-dev] [PATCH v2] devtools: add EditorConfig file

EditorConfig is a file format and collection of text editor plugins for maintaining consistent coding styles between different editors and IDEs. Initialize the file following the coding rules in doc/guides/contributing/coding_style.rst, doc/guides/contributing/documentation.rst and doc/guides/cont

Re: [dpdk-dev] [PATCH v4 1/4] ethdev: add the API for getting burst mode information

Hi Thomas & Andrew, > -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Friday, October 25, 2019 17:37 > To: Wang, Haiyue ; Yigit, Ferruh > > Cc: dev@dpdk.org; Ye, Xiaolong ; Kinsella, Ray > ; > Iremonger, Bernard ; Sun, Chenmin > ; > arybche...@solarflare

[dpdk-dev] [PATCH v3 12/12] doc: announce global logs struct removal from ABI

New accessor has been introduced to provide the hidden information. This symbol can now be kept internal. Signed-off-by: David Marchand --- doc/guides/rel_notes/deprecation.rst | 4 1 file changed, 4 insertions(+) diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/de

[dpdk-dev] [PATCH v3 10/12] eal: factorize lcore role code

This code belongs to the lcore API, move the prototype to the right header, then factorize the code into the common code. Signed-off-by: David Marchand Acked-by: Thomas Monjalon --- lib/librte_eal/common/eal_common_lcore.c | 10 ++ lib/librte_eal/common/include/rte_eal.h | 11 ---

[dpdk-dev] [PATCH v3 11/12] eal: make the global configuration private

Now that all elements of the rte_config structure have (deinlined) accessors, we can hide it. Signed-off-by: David Marchand Acked-by: Thomas Monjalon --- doc/guides/rel_notes/release_19_11.rst | 3 +++ lib/librte_eal/common/eal_common_mcfg.c | 1 + lib/librte_eal/common/eal_private.h | 3

[dpdk-dev] [PATCH v3 07/12] log: add log stream accessor

Define an accessor so that users can write their debug message to the same stream than the rte_log infrastructure. Use it in the qat infrastructure. Signed-off-by: David Marchand Acked-by: Thomas Monjalon --- Changelog since v1: - use ternary operator, --- drivers/common/qat/qat_logs.c

[dpdk-dev] [PATCH v3 08/12] test/mem: remove dependency on EAL internals

Rather than dereference the mem_config internal structure, we can rely on the rte_memzone_walk API and count memzones. Signed-off-by: David Marchand Acked-by: Thomas Monjalon --- app/test/test_memzone.c | 50 ++--- 1 file changed, 31 insertions(+), 19

[dpdk-dev] [PATCH v3 04/12] mem: hide internal heap header

Let's avoid exporting structures without an identified usecase. Signed-off-by: David Marchand Acked-by: Thomas Monjalon --- app/test-pmd/testpmd.c | 1 - lib/librte_eal/common/Makefile | 2 +- lib/librte_eal/common/eal_memcfg.h | 3 ++-

[dpdk-dev] [PATCH v3 03/12] eal: remove deprecated malloc virt2phys function

Remove rte_malloc_virt2phy as announced previously. Signed-off-by: David Marchand Acked-by: Thomas Monjalon --- doc/guides/rel_notes/deprecation.rst | 3 --- doc/guides/rel_notes/release_19_11.rst | 3 +++ lib/librte_eal/common/include/rte_malloc.h | 7 --- 3 files changed, 3 inse

  1   2   3   >