[dpdk-dev] [RFC] mempool: introduce indexed memory pool

2019-10-16 Thread Xueming Li
Indexed memory pool manages memory entries by index, allocation from pool returns both memory pointer and index(ID). users save ID as u32 or less(u16) instead of traditional 8 bytes pointer. Memory could be retrieved from pool or returned to pool later by index. Pool allocates backend memory in ch

Re: [dpdk-dev] [PATCH] net/i40e: force promiscuous state after VF reset

2019-10-16 Thread Xing, Beilei
> -Original Message- > From: Eelco Chaudron [mailto:echau...@redhat.com] > Sent: Tuesday, October 15, 2019 6:32 PM > To: Xing, Beilei ; Zhang, Qi Z > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] net/i40e: force promiscuous state after VF > reset > > Any update on this patch? > >

Re: [dpdk-dev] [PATCH] net/ice/base: fix for FDIR QFI offset in GTP protocol

2019-10-16 Thread Ye Xiaolong
On 10/17, Qi Zhang wrote: >For the GTP protocol, the QFI offset used by to create the field vector >was off by one byte. This patch corrects that offset. > >Fixes: febb0f877f6e ("net/ice/base: add QFI for flow director") > >Signed-off-by: Dan Nowlin >Signed-off-by: Paul M Stillwell Jr >Signed-off

Re: [dpdk-dev] [PATCH 0/2] drivers/net: fix address of first segment

2019-10-16 Thread Ye Xiaolong
On 09/24, Joyce Kong wrote: >The series fix (dereference after null check) coverity issue on NEON vPMD. >Which for x86 sse/avx2 (commit 4916f63985ddb56af43980252d1134d051523685, >commit 739c35f08bc0296ffda47f006f1903a67527063f) have been merged. > >Joyce Kong (2): > net/i40e: fix address of first

[dpdk-dev] [PATCH] net/ice/base: fix for FDIR QFI offset in GTP protocol

2019-10-16 Thread Qi Zhang
For the GTP protocol, the QFI offset used by to create the field vector was off by one byte. This patch corrects that offset. Fixes: febb0f877f6e ("net/ice/base: add QFI for flow director") Signed-off-by: Dan Nowlin Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ic

Re: [dpdk-dev] [PATCH 1/2] test/meson: hash test split into shorter subtests

2019-10-16 Thread Amit Gupta
> -Original Message- > From: Wang, Yipeng1 > Sent: Wednesday, September 11, 2019 10:35 PM > To: Amit Gupta ; Gobriel, Sameh > ; Richardson, Bruce > ; De Lara Guarch, Pablo > > Cc: dev@dpdk.org > Subject: [EXT] RE: [PATCH 1/2] test/meson: hash test split into shorter > subtests > > Ext

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] eal/ppc: fix 64 bit atomic exchange operation

2019-10-16 Thread David Marchand
On Wed, Oct 16, 2019 at 5:10 PM David Marchand wrote: > > On Tue, Oct 15, 2019 at 11:16 PM David Christensen > wrote: > > > > The rte_atomic64_exchange operation for ppc_64 incorrectly linked > > back to a 32 bit generic operation (__atomic_exchange_4) rather than > > the 64 bit generic operation

Re: [dpdk-dev] [PATCH] eal/ppc_64: add SPDX license tag

2019-10-16 Thread David Marchand
On Sat, Sep 28, 2019 at 1:45 AM David Christensen wrote: > > > Cc: Gowrishankar Muthukrishnan > > > > Signed-off-by: Hemant Agrawal > > --- > > lib/librte_eal/common/arch/ppc_64/rte_cycles.c | 4 > > 1 file changed, 4 insertions(+) > > Reviewed-by: David Christensen As discussed offlis

Re: [dpdk-dev] [PATCH v6 4/5] mbuf: add a pktmbuf copy routine

2019-10-16 Thread David Marchand
On Wed, Oct 16, 2019 at 8:58 AM Olivier Matz wrote: > > On Tue, Oct 08, 2019 at 09:33:49AM -0700, Stephen Hemminger wrote: > > This is a commonly used operation that surprisingly the > > DPDK has not supported. The new rte_pktmbuf_copy does a > > deep copy of packet. This is a complete copy includ

Re: [dpdk-dev] [PATCH v6 3/5] mbuf: deinline rte_pktmbuf_clone

2019-10-16 Thread David Marchand
On Tue, Oct 8, 2019 at 6:34 PM Stephen Hemminger wrote: > > Cloning mbufs requires allocations and iteration > and therefore should not be an inline. > > Signed-off-by: Stephen Hemminger > Acked-by: Andrew Rybchenko > Acked-by: Olivier Matz Applied, thanks. -- David Marchand

Re: [dpdk-dev] [PATCH] mempool: clarify default populate function

2019-10-16 Thread David Marchand
On Tue, Oct 8, 2019 at 11:35 AM Olivier Matz wrote: > > No functional change. Clarify the populate function to make > the next commit easier to understand. After discussion offlist, changed this: Clarify the populate function to make future changes easier to understand. > > Rename the va

Re: [dpdk-dev] [PATCH v6 2/5] mbuf: delinline rte_pktmbuf_linearize

2019-10-16 Thread David Marchand
On Tue, Oct 8, 2019 at 6:34 PM Stephen Hemminger wrote: > > This copy part of this function is too big to be put inline. > The places it is used are only in special exception paths > where a highly fragmented mbuf arrives at a device that can't handle it. > > Signed-off-by: Stephen Hemminger > Ac

Re: [dpdk-dev] [PATCH] kni: support allmulticast mode set

2019-10-16 Thread David Marchand
On Tue, Oct 8, 2019 at 7:46 PM Yigit, Ferruh wrote: > > On 8/12/2019 4:06 AM, Xiaolong Ye wrote: > > This patch adds support to allow users enable/disable allmulticast mode for > > kni interface. > > > > This requirement comes from bugzilla 312, more details can refer to: > > https://bugs.dpdk.org

Re: [dpdk-dev] [PATCH v6 1/5] mbuf: don't generate invalid mbuf in clone test

2019-10-16 Thread David Marchand
On Tue, Oct 8, 2019 at 6:34 PM Stephen Hemminger wrote: > > The test for cloning changed mbuf would generate an mbuf > whose length and segments were invalid. This would cause a crash > if test was run with mbuf debugging enabled. It could be interesting to add calls to rte_mbuf_check() (not depe

Re: [dpdk-dev] [PATCH v2 1/1] test/meson: hash lf test moved to dpdk perf testsuite

2019-10-16 Thread Amit Gupta
> -Original Message- > From: Honnappa Nagarahalli > Sent: Friday, September 13, 2019 9:17 PM > To: Wang, Yipeng1 ; Aaron Conole > ; Amit Gupta > Cc: Gobriel, Sameh ; Richardson, Bruce > ; De Lara Guarch, Pablo > ; dev@dpdk.org; Honnappa Nagarahalli > ; nd ; nd > Subject: [EXT] RE: [dp

Re: [dpdk-dev] [PATCH v4 1/2] lib/ring: apis to support configurable element size

2019-10-16 Thread Honnappa Nagarahalli
> Hi Honnappa, > > > > > > > > > > > Current APIs assume ring elements to be pointers. However, in > > > > > many use cases, the size can be different. Add new APIs to > > > > > support configurable ring element sizes. > > > > > > > > > > Signed-off-by: Honnappa Nagarahalli > > > > > > > > > >

Re: [dpdk-dev] [PATCH] vhost: return error message for mbuf allocation failure

2019-10-16 Thread Tiwei Bie
On Wed, Oct 16, 2019 at 04:31:07PM +0200, Ilya Maximets wrote: > mbuf allocation failure is a hard failure that highlights some > significant issues with memory pool size or a mbuf leak. > > We still have the message for subsequent chained mbufs, but not > for the first one. It was removed while

[dpdk-dev] [PATCH v4] ethdev: add HIGIG2 key field to flow API

2019-10-16 Thread kirankumark
From: Kiran Kumar K Add new rte_flow_item_higig2_hdr in order to match higig2 header. It is a layer 2.5 protocol and used in broadcom switches. Header format is based on the following document. http://read.pudn.com/downloads558/doc/comm/2301468/HiGig_protocol.pdf Signed-off-by: Kiran Kumar K --

Re: [dpdk-dev] [PATCH v6 01/10] examples/l2fwd-event: add default poll mode routines

2019-10-16 Thread Pavan Nikhilesh Bhagavatula
>On Mon, 14 Oct 2019 23:52:38 +0530 > wrote: > >> From: Pavan Nikhilesh >> >> Add the default l2fwd poll mode routines similar to examples/l2fwd. >> >> Signed-off-by: Sunil Kumar Kori >> Signed-off-by: Pavan Nikhilesh > >Patchwork CI reports build failures on this. >Every patch must build, even

Re: [dpdk-dev] [PATCH v2] net/ice: invoke callback func when link status change

2019-10-16 Thread Ye Xiaolong
On 10/16, Leyi Rong wrote: >Needs to call _rte_eth_dev_callback_process to run registered >callbacks when link status change. > >Fixes: cf911d90e366 ("net/ice: support link update") > >Signed-off-by: Leyi Rong > >--- >v2: >- adds fixline in commit log. >--- > drivers/net/ice/ice_ethdev.c | 6 +

Re: [dpdk-dev] [PATCH v5 0/5] rework for ice generic flow framework and switch filter

2019-10-16 Thread Ye Xiaolong
On 10/17, Ying Wang wrote: >patch 1/5 minor code clean >patch 2/5 adds devargs to control pipeline mode >patch 3/5 rework for ice generic flow framework >patch 4/5 add rte_flow pattern list >patch 5/5 rework switch filter on new framework > >Qiming Yang (1): > net/ice: add devargs to control pipel

[dpdk-dev] [PATCH v5 4/5] net/ice: add pattern manifest

2019-10-16 Thread Ying Wang
The patch adds a manifest for all patterns which can be selected by low level filter engine to compose their supported list. Signed-off-by: Ying Wang Acked-by: Qi Zhang --- drivers/net/ice/ice_generic_flow.c | 1287 drivers/net/ice/ice_generic_flow.h | 201

[dpdk-dev] [PATCH v5 3/5] net/ice: rework for generic flow enabling

2019-10-16 Thread Ying Wang
The patch reworks the generic flow API (rte_flow) implementation. It introduces an abstract layer which provides a unified interface for low-level filter engine (switch, fdir, hash) to register supported patterns and actions and implement flow validate/create/destroy/flush/ query activities. The p

[dpdk-dev] [PATCH v5 2/5] net/ice: add devargs to control pipeline mode

2019-10-16 Thread Ying Wang
From: Qiming Yang Added a devarg to control the mode in generic flow API. We use none-pipeline mode by default. Signed-off-by: Qiming Yang Acked-by: Qi Zhang --- doc/guides/nics/ice.rst| 19 +++ doc/guides/rel_notes/release_19_11.rst | 2 ++ drivers/net/ice/ic

[dpdk-dev] [PATCH v5 5/5] net/ice: rework switch filter

2019-10-16 Thread Ying Wang
From: wei zhao The patch reworks packet process engine's binary classifier (switch) for the new framework. It also adds support for new packet type like PPPoE for switch filter. Signed-off-by: Wei Zhao Acked-by: Qi Zhang --- doc/guides/rel_notes/release_19_11.rst |1 + drivers/net/ice/ice

[dpdk-dev] [PATCH v5 1/5] net/ice: minor code clean

2019-10-16 Thread Ying Wang
The patch removes redundant code and cleans up some wrong indentations. Signed-off-by: Ying Wang Acked-by: Qi Zhang --- drivers/net/ice/ice_generic_flow.c | 39 +++--- 1 file changed, 19 insertions(+), 20 deletions(-) diff --git a/drivers/net/ice/ice_generic_flo

[dpdk-dev] [PATCH v5 0/5] rework for ice generic flow framework and switch filter

2019-10-16 Thread Ying Wang
patch 1/5 minor code clean patch 2/5 adds devargs to control pipeline mode patch 3/5 rework for ice generic flow framework patch 4/5 add rte_flow pattern list patch 5/5 rework switch filter on new framework Qiming Yang (1): net/ice: add devargs to control pipeline mode Ying Wang (3): net/ice:

Re: [dpdk-dev] [PATCH v4 0/5] rework for ice generic flow framework and switch filter

2019-10-16 Thread Ye Xiaolong
On 10/14, Ying Wang wrote: >patch 1/5 minor code clean >patch 2/5 adds devargs to control pipeline mode >patch 3/5 rework for ice generic flow framework >patch 4/5 add rte_flow pattern list >patch 5/5 rework switch filter on new framework > >Qiming Yang (1): > net/ice: add devargs to control pipel

Re: [dpdk-dev] [PATCH v1 0/2] net/ice: enable GTP checksum offload

2019-10-16 Thread Zhang, Qi Z
> -Original Message- > From: Xu, Ting > Sent: Friday, September 20, 2019 4:36 PM > To: dev@dpdk.org > Cc: Lu, Wenzhuo ; Wu, Jingjing > ; Ye, Xiaolong ; Yang, Qiming > ; Mcnamara, John ; > Kovacevic, Marko ; olivier.m...@6wind.com; > Zhang, Qi Z > Subject: [PATCH v1 0/2] net/ice: enable

Re: [dpdk-dev] [PATCH v6 06/13] vhost: add packed ring batch dequeue

2019-10-16 Thread Liu, Yong
> -Original Message- > From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] > Sent: Wednesday, October 16, 2019 6:36 PM > To: Liu, Yong ; Bie, Tiwei ; Wang, > Zhihong ; step...@networkplumber.org; > gavin...@arm.com > Cc: dev@dpdk.org > Subject: Re: [PATCH v6 06/13] vhost: add packed

Re: [dpdk-dev] [RFC PATCH 1/9] security: introduce CPU Crypto action type and API

2019-10-16 Thread Ananyev, Konstantin
Hi Akhil, > > > User can use the same session, that is what I am also insisting, but it > > > may have > > separate > > > Session private data. Cryptodev session create API provide that > > > functionality > > and we can > > > Leverage that. > > > > rte_cryptodev_sym_session. sess_data[] is in

[dpdk-dev] [PATCH v3 8/9] build: change ABI version to 20.0

2019-10-16 Thread Anatoly Burakov
From: Pawel Modrak Merge all vesions in linker version script files to DPDK_20.0. This commit was generated by running the following command: :~/DPDK$ buildtools/update-abi.sh 20.0 Signed-off-by: Pawel Modrak Signed-off-by: Anatoly Burakov --- Notes: v2: - Regenerate the commit usin

[dpdk-dev] [PATCH v2 09/10] build: change ABI version to 20.0

2019-10-16 Thread Anatoly Burakov
From: Pawel Modrak Merge all vesions in linker version script files to DPDK_20.0. This commit was generated by running the following command: :~/DPDK$ buildtools/update-abi.sh 20.0 Signed-off-by: Pawel Modrak Signed-off-by: Anatoly Burakov --- Notes: v2: - Regenerated this patch usi

Re: [dpdk-dev] [PATCH v4] vhost: add support for large buffers

2019-10-16 Thread Ilya Maximets
Hi. Not a full review. Few comments inline. Best regards, Ilya Maximets. On 15.10.2019 18:17, Flavio Leitner wrote: The rte_vhost_dequeue_burst supports two ways of dequeuing data. If the data fits into a buffer, then all data is copied and a single linear buffer is returned. Otherwise it allo

Re: [dpdk-dev] [dpdk-stable] 18.11.3 (LTS) patches review and test

2019-10-16 Thread Abhishek Marathe
Hi Kevin, We tried reverting all netvsc and failsafe patches, still we got the same results. We are still looking into it. "PERF-DPDK-MULTICORE-PPS-F32" testcase failed because of performance is lower than threshold. Following performance is observed in distros other than Ubuntu and RHEL 7 (bec

Re: [dpdk-dev] [PATCH] eal:ppc: fix incorrect ifdef for ppc_64

2019-10-16 Thread David Christensen
An ifdef present in eal_memory.c references "RTE_ARCH_PPC64" when it should actually use "RTE_ARCH_PPC_64". Simple testing revealed that both the PPC_64 and non-PPC_64 versions of the code involved work, but the PPC_64 version of the code is retained to be consistent with other instances in the s

Re: [dpdk-dev] [PATCH v3 01/14] ethdev: add support for hairpin queue

2019-10-16 Thread Ori Kam
Hi Andrew, Thanks again for your time. PSB, Ori > -Original Message- > From: Andrew Rybchenko > Sent: Tuesday, October 15, 2019 1:12 PM > To: Ori Kam ; Thomas Monjalon > ; Ferruh Yigit > Cc: dev@dpdk.org; jingjing...@intel.com; step...@networkplumber.org > Subject: Re: [PATCH v3 01/1

Re: [dpdk-dev] [PATCH v6 01/10] examples/l2fwd-event: add default poll mode routines

2019-10-16 Thread Stephen Hemminger
On Mon, 14 Oct 2019 23:52:38 +0530 wrote: > From: Pavan Nikhilesh > > Add the default l2fwd poll mode routines similar to examples/l2fwd. > > Signed-off-by: Sunil Kumar Kori > Signed-off-by: Pavan Nikhilesh Patchwork CI reports build failures on this. Every patch must build, even if part of

Re: [dpdk-dev] [PATCH v1 1/5] lib/eal: implement the family of rte bit operation APIs

2019-10-16 Thread Stephen Hemminger
On Tue, 15 Oct 2019 15:49:57 +0800 Joyce Kong wrote: > There are a lot functions of bit operations scattered and > duplicated in PMDs, consolidating them into a common API > family is necessary. Furthermore, the bit operation is > mostly applied to the IO devices, so use __ATOMIC_ACQ_REL > to ens

Re: [dpdk-dev] [PATCH v1 1/1] bus/vdev: add get iommu class callback

2019-10-16 Thread Ferruh Yigit
On 10/16/2019 3:29 PM, vattun...@marvell.com wrote: > From: Vamsi Attunuru > > When DPDK application is run with vdevs, EAL decides > the iommu mode and accordingly application runs in > either of the modes. > > For KNI kind of functionality with vdevs, since there > is no backed device structur

Re: [dpdk-dev] [RFC] net/null: add empty promiscuous mode functions

2019-10-16 Thread Ferruh Yigit
On 10/16/2019 4:46 PM, Ciara Power wrote: > Adding promiscuous functions prevents sample applications failing when run > on this virtual PMD. The sample applications call promiscuous functions, > and fail if this function call returns an error, which occurs when the > virtual PMD does not support t

Re: [dpdk-dev] [PATCH v2 1/3] lib/ethdev: add ethdev op to get hash index

2019-10-16 Thread Ferruh Yigit
On 10/15/2019 10:52 AM, vattun...@marvell.com wrote: > From: Vamsi Attunuru > > Some networking devices may use custom algos for computing > hash indices and spread the packets accordingly. > > Patch adds an eth_dev op to get the hash index correspond > to the given hash value received in the in

Re: [dpdk-dev] [PATCH v2 1/3] lib/ethdev: add ethdev op to get hash index

2019-10-16 Thread Ferruh Yigit
On 10/15/2019 6:28 PM, Vamsi Krishna Attunuru wrote: > > >> -Original Message- >> From: dev On Behalf Of Ferruh Yigit >> Sent: Tuesday, October 15, 2019 10:17 PM >> To: Vamsi Krishna Attunuru ; dev@dpdk.org >> Cc: arybche...@solarflare.com; Jerin Jacob Kollanukkaran >> ; tho...@monjalon.

[dpdk-dev] [PATCH v3 7/9] drivers/octeontx: add missing public symbol

2019-10-16 Thread Anatoly Burakov
The logtype symbol was missing from the .map file. Add it. Fixes: d8dd31652cf4 ("common/octeontx: move mbox to common folder") Cc: pbhagavat...@caviumnetworks.com Cc: sta...@dpdk.org Signed-off-by: Anatoly Burakov --- Notes: v2: - add this patch to avoid compile breakage when bumping AB

[dpdk-dev] [PATCH v3 9/9] buildtools: add ABI versioning check script

2019-10-16 Thread Anatoly Burakov
From: Marcin Baran Add a shell script that checks whether built libraries are versioned with expected ABI (current ABI, current ABI + 1, or EXPERIMENTAL). The following command was used to verify current source tree (assuming build directory is in ./build): find ./build/lib ./build/drivers -nam

[dpdk-dev] [PATCH v3 6/9] distributor: remove deprecated code

2019-10-16 Thread Anatoly Burakov
From: Marcin Baran Remove code for old ABI versions ahead of ABI version bump. Signed-off-by: Marcin Baran Signed-off-by: Anatoly Burakov --- Notes: v3: - Removed single mode from distributor as per Dave's comments v2: - Moved this to before ABI version bump to avoid comp

[dpdk-dev] [PATCH v3 4/9] timer: remove deprecated code

2019-10-16 Thread Anatoly Burakov
From: Marcin Baran Remove code for old ABI versions ahead of ABI version bump. Signed-off-by: Marcin Baran Signed-off-by: Anatoly Burakov --- Notes: v2: - Moved this to before ABI version bump to avoid compile breakage lib/librte_timer/rte_timer.c | 90 ++

[dpdk-dev] [PATCH v3 5/9] lpm: remove deprecated code

2019-10-16 Thread Anatoly Burakov
From: Marcin Baran Remove code for old ABI versions ahead of ABI version bump. Signed-off-by: Marcin Baran Signed-off-by: Anatoly Burakov --- Notes: v2: - Moved this to before ABI version bump to avoid compile breakage lib/librte_lpm/rte_lpm.c | 996 ++--

[dpdk-dev] [PATCH v3 3/9] buildtools: add ABI update shell script

2019-10-16 Thread Anatoly Burakov
In order to facilitate mass updating of version files, add a shell script that recurses into lib/ and drivers/ directories and calls the ABI version update script. Signed-off-by: Anatoly Burakov --- Notes: v3: - Switch to sh rather than bash, and remove bash-isms - Address review com

[dpdk-dev] [PATCH v3 2/9] buildtools: add script for updating symbols abi version

2019-10-16 Thread Anatoly Burakov
From: Pawel Modrak Add a script that automatically merges all stable ABI's under one ABI section with the new version, while leaving experimental section exactly as it is. Signed-off-by: Pawel Modrak Signed-off-by: Anatoly Burakov --- Notes: v3: - Add comments to regex patterns

[dpdk-dev] [PATCH v3 0/9] Implement the new ABI policy and add helper scripts

2019-10-16 Thread Anatoly Burakov
This patchset prepares the codebase for the new ABI policy and adds a few helper scripts. There are two new scripts for managing ABI versions added. The first one is a Python script that will read in a .map file, flatten it and update the ABI version to the ABI version specified on the command-lin

[dpdk-dev] [PATCH v3 1/9] config: change ABI versioning to global

2019-10-16 Thread Anatoly Burakov
From: Marcin Baran As per new ABI policy, all of the libraries are now versioned using one global ABI version. Changes in this patch implement the necessary steps to enable that. Signed-off-by: Marcin Baran Signed-off-by: Pawel Modrak Signed-off-by: Anatoly Burakov --- Notes: v3: - R

Re: [dpdk-dev] [PATCH] net/ixgbe: avoid multpile definitions of 'bool'

2019-10-16 Thread Dharmik Thakkar
Hi Ye, Thank you for the comments! > On Oct 16, 2019, at 1:23 AM, Ye Xiaolong wrote: > > Hi, > > On 10/03, Dharmik Thakkar wrote: >> Compilation issue arises due to multiple definitions of 'bool' >> in 'ixgbe_ethdev.h'. > > Which compiler would trigger this compilation issue? gcc version 7.4.0

Re: [dpdk-dev] [PATCH v10 0/5] kni: add IOVA=VA support

2019-10-16 Thread Ferruh Yigit
On 10/16/2019 1:17 PM, Vamsi Krishna Attunuru wrote: > > >> -Original Message- >> From: dev On Behalf Of Yigit, Ferruh >> Sent: Tuesday, October 15, 2019 9:05 PM >> To: Vamsi Krishna Attunuru ; dev@dpdk.org >> Cc: tho...@monjalon.net; Jerin Jacob Kollanukkaran ; >> olivier.m...@6wind.com

Re: [dpdk-dev] [EXT] Re: [PATCH v10 4/5] kni: add IOVA=VA support in KNI module

2019-10-16 Thread Ferruh Yigit
On 10/16/2019 12:26 PM, Vamsi Krishna Attunuru wrote: > > >> -Original Message- >> From: Stephen Hemminger >> Sent: Tuesday, October 15, 2019 9:16 PM >> To: Yigit, Ferruh >> Cc: Vamsi Krishna Attunuru ; dev@dpdk.org; >> tho...@monjalon.net; Jerin Jacob Kollanukkaran ; >> olivier.m...@6w

[dpdk-dev] [RFC] net/null: add empty promiscuous mode functions

2019-10-16 Thread Ciara Power
Adding promiscuous functions prevents sample applications failing when run on this virtual PMD. The sample applications call promiscuous functions, and fail if this function call returns an error, which occurs when the virtual PMD does not support the promiscuous function being called. This chang

[dpdk-dev] [PATCH v3 10/11] crypto/octeontx2: add asymmetric in enqueue/dequeue ops

2019-10-16 Thread Anoob Joseph
From: Sunila Sahu This patch adds asymmetric support in enqueue/dequeue ops. Signed-off-by: Anoob Joseph Signed-off-by: Kanaka Durga Kotamarthy Signed-off-by: Sunila Sahu --- drivers/crypto/octeontx2/otx2_cryptodev_ops.c | 177 ++ drivers/crypto/octeontx2/otx2_cryptod

[dpdk-dev] [PATCH v3 11/11] app/test: register octeontx2 PMD to asym testsuite

2019-10-16 Thread Anoob Joseph
From: Sunila Sahu This patch updates asymmetric crypto unit-test application to validate asymmetric crypto operation supported by octeontx2 PMD. Signed-off-by: Anoob Joseph Signed-off-by: Kanaka Durga Kotamarthy Signed-off-by: Sunila Sahu --- app/test/test_cryptodev_asym.c | 20

[dpdk-dev] [PATCH v3 09/11] crypto/octeontx2: add asymmetric session operations

2019-10-16 Thread Anoob Joseph
From: Kanaka Durga Kotamarthy This patch adds asymmetric session setup and free routines. RSA and modexp operations are supported. Signed-off-by: Anoob Joseph Signed-off-by: Kanaka Durga Kotamarthy Signed-off-by: Sunila Sahu --- doc/guides/cryptodevs/features/octeontx2.ini | 4 + doc

[dpdk-dev] [PATCH v3 08/11] test: add OCTEON TX2 tests

2019-10-16 Thread Anoob Joseph
This patch adds the OCTEON TX2 crypto validation tests. Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph Signed-off-by: Tejasree Kondoj --- app/test/meson.build| 1 + app/test/test_cryptodev.c | 323 app/test/test

[dpdk-dev] [PATCH v3 05/11] crypto/octeontx2: add symmetric capabilities

2019-10-16 Thread Anoob Joseph
This patch adds the symmetric capabilities for OCTEON TX2 crypto PMD. Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph Signed-off-by: Tejasree Kondoj --- doc/guides/cryptodevs/features/octeontx2.ini | 59 ++ doc/guides/cryptodevs/octeontx2.rst| 41 ++ drivers/cr

[dpdk-dev] [PATCH v3 06/11] crypto/octeontx2: add session related functions

2019-10-16 Thread Anoob Joseph
From: Ankur Dwivedi This patch adds the symmetric session related callbacks. Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph Signed-off-by: Tejasree Kondoj --- drivers/common/cpt/cpt_mcode_defines.h| 2 + drivers/crypto/octeontx2/otx2_cryptodev_ops.c | 117

[dpdk-dev] [PATCH v3 04/11] crypto/octeontx2: add queue pair functions

2019-10-16 Thread Anoob Joseph
From: Ankur Dwivedi This patch adds the queue pair setup and queue pair release functions for OCTEON TX2 crypto pmd. Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph Signed-off-by: Tejasree Kondoj --- .../crypto/octeontx2/otx2_cryptodev_hw_access.c| 99 +++ .../crypto/octeon

[dpdk-dev] [PATCH v3 07/11] crypto/octeontx2: add enqueue/dequeue ops

2019-10-16 Thread Anoob Joseph
This patch adds the enqueue burst and dequeue burst callbacks for the OCTEON TX2 crypto driver. Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph Signed-off-by: Tejasree Kondoj --- drivers/common/cpt/cpt_hw_types.h | 52 drivers/crypto/octeontx2/Makefile

[dpdk-dev] [PATCH v3 03/11] crypto/octeontx2: add device control ops

2019-10-16 Thread Anoob Joseph
From: Ankur Dwivedi This patch adds the device control functions. Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph Signed-off-by: Tejasree Kondoj --- drivers/crypto/octeontx2/Makefile | 1 + drivers/crypto/octeontx2/meson.build | 1 + drivers/crypto

[dpdk-dev] [PATCH v3 02/11] crypto/octeontx2: add device init sequence in probe

2019-10-16 Thread Anoob Joseph
This patch adds the device init sequence for OCTEON TX2 crypto device. Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph Signed-off-by: Tejasree Kondoj --- drivers/crypto/octeontx2/Makefile | 10 +++ drivers/crypto/octeontx2/meson.build | 2 ++ drivers/crypto

[dpdk-dev] [PATCH v3 01/11] crypto/octeontx2: add PMD skeleton

2019-10-16 Thread Anoob Joseph
Adding OCTEON TX2 crypto PMD skeleton. Enabling the driver by default in common_base. Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph Signed-off-by: Tejasree Kondoj --- MAINTAINERS| 7 ++ config/common_base |

[dpdk-dev] [PATCH v3 00/11] add OCTEON TX2 crypto PMD

2019-10-16 Thread Anoob Joseph
The series introduces poll mode driver to enable crypto offload engine on Marvell OCTEON TX2 SoC. Changes in v3: * Rebased on tip of dpdk-next-crypto("36112de91a44") * Updated version map to use right DPDK version * Added sanity checks in dev_close() routine. Changes in v2: * Merged series adding

Re: [dpdk-dev] [PATCH] eal:ppc: fix incorrect ifdef for ppc_64

2019-10-16 Thread David Marchand
On Wed, Sep 25, 2019 at 11:42 PM David Christensen wrote: > > An ifdef present in eal_memory.c references "RTE_ARCH_PPC64" when > it should actually use "RTE_ARCH_PPC_64". Simple testing revealed > that both the PPC_64 and non-PPC_64 versions of the code involved > work, but the PPC_64 version of

Re: [dpdk-dev] [PATCH v2 2/2] sched: modify internal structs and functions for 64 bit values

2019-10-16 Thread Dumitrescu, Cristian
> -Original Message- > From: Singh, Jasvinder > Sent: Wednesday, October 16, 2019 3:17 PM > To: dev@dpdk.org > Cc: Dumitrescu, Cristian ; Krakowiak, > LukaszX > Subject: [PATCH v2 2/2] sched: modify internal structs and functions for 64 > bit > values > > Modify internal structure and

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] eal/ppc: fix 64 bit atomic exchange operation

2019-10-16 Thread David Marchand
On Tue, Oct 15, 2019 at 11:16 PM David Christensen wrote: > > The rte_atomic64_exchange operation for ppc_64 incorrectly linked > back to a 32 bit generic operation (__atomic_exchange_4) rather than > the 64 bit generic operation (__atomic_exchange_8). As a result, > applications that used rte_et

Re: [dpdk-dev] [PATCH] vhost: return error message for mbuf allocation failure

2019-10-16 Thread Flavio Leitner
On Wed, 16 Oct 2019 16:31:07 +0200 Ilya Maximets wrote: > mbuf allocation failure is a hard failure that highlights some > significant issues with memory pool size or a mbuf leak. > > We still have the message for subsequent chained mbufs, but not > for the first one. It was removed while intro

Re: [dpdk-dev] [PATCH] kni: add ability to set min/max MTU

2019-10-16 Thread Ferruh Yigit
On 10/16/2019 3:47 PM, David Marchand wrote: > On Wed, Oct 16, 2019 at 12:55 PM David Marchand > wrote: >> >> On Wed, Oct 16, 2019 at 12:43 PM Ferruh Yigit wrote: >>> >>> On 10/16/2019 7:40 AM, David Marchand wrote: On Fri, Oct 11, 2019 at 6:16 PM Ferruh Yigit wrote: > > On 9/

Re: [dpdk-dev] [PATCH] kni: add ability to set min/max MTU

2019-10-16 Thread David Marchand
On Wed, Oct 16, 2019 at 12:55 PM David Marchand wrote: > > On Wed, Oct 16, 2019 at 12:43 PM Ferruh Yigit wrote: > > > > On 10/16/2019 7:40 AM, David Marchand wrote: > > > On Fri, Oct 11, 2019 at 6:16 PM Ferruh Yigit > > > wrote: > > >> > > >> On 9/19/2019 12:22 PM, Igor Ryzhov wrote: > > >>> St

Re: [dpdk-dev] [PATCH v1 1/1] bus/vdev: add get iommu class callback

2019-10-16 Thread Jerin Jacob
On Wed, Oct 16, 2019 at 7:59 PM wrote: > > From: Vamsi Attunuru > > When DPDK application is run with vdevs, EAL decides > the iommu mode and accordingly application runs in > either of the modes. > > For KNI kind of functionality with vdevs, since there > is no backed device structure in kernel,

Re: [dpdk-dev] [EXT] Re: [PATCH v10 4/5] kni: add IOVA=VA support in KNI module

2019-10-16 Thread Vamsi Krishna Attunuru
> -Original Message- > From: Vamsi Krishna Attunuru > Sent: Wednesday, October 16, 2019 4:56 PM > To: Stephen Hemminger ; Yigit, Ferruh > > Cc: dev@dpdk.org; tho...@monjalon.net; Jerin Jacob Kollanukkaran > ; olivier.m...@6wind.com; ferruh.yi...@intel.com; > anatoly.bura...@intel.com; a

[dpdk-dev] [PATCH] vhost: return error message for mbuf allocation failure

2019-10-16 Thread Ilya Maximets
mbuf allocation failure is a hard failure that highlights some significant issues with memory pool size or a mbuf leak. We still have the message for subsequent chained mbufs, but not for the first one. It was removed while introducing extbuf support for large buffers. But it was useful for catc

[dpdk-dev] [PATCH v1 1/1] bus/vdev: add get iommu class callback

2019-10-16 Thread vattunuru
From: Vamsi Attunuru When DPDK application is run with vdevs, EAL decides the iommu mode and accordingly application runs in either of the modes. For KNI kind of functionality with vdevs, since there is no backed device structure in kernel, iommu_mode = PA needs to be enforced during eal init.

Re: [dpdk-dev] [PATCH v5] vhost: add support for large buffers

2019-10-16 Thread Flavio Leitner
On Wed, 16 Oct 2019 16:08:54 +0200 Ilya Maximets wrote: > On 16.10.2019 16:02, Flavio Leitner wrote: > > On Wed, 16 Oct 2019 15:46:15 +0200 > > Maxime Coquelin wrote: > > > >> On 10/16/19 3:32 PM, Ilya Maximets wrote: > >>> On 16.10.2019 13:13, Maxime Coquelin wrote: > > >

Re: [dpdk-dev] [PATCH v5] vhost: add support for large buffers

2019-10-16 Thread Ilya Maximets
On 16.10.2019 16:02, Flavio Leitner wrote: On Wed, 16 Oct 2019 15:46:15 +0200 Maxime Coquelin wrote: On 10/16/19 3:32 PM, Ilya Maximets wrote: On 16.10.2019 13:13, Maxime Coquelin wrote: On 10/15/19 8:59 PM, Flavio Leitner wrote: The rte_vhost_dequeue_burst supports two ways of dequeuing

Re: [dpdk-dev] [PATCH v5] vhost: add support for large buffers

2019-10-16 Thread Ilya Maximets
On 16.10.2019 15:46, Maxime Coquelin wrote: On 10/16/19 3:32 PM, Ilya Maximets wrote: On 16.10.2019 13:13, Maxime Coquelin wrote: On 10/15/19 8:59 PM, Flavio Leitner wrote: The rte_vhost_dequeue_burst supports two ways of dequeuing data. If the data fits into a buffer, then all data is cop

Re: [dpdk-dev] [PATCH v5] vhost: add support for large buffers

2019-10-16 Thread Flavio Leitner
On Wed, 16 Oct 2019 15:46:15 +0200 Maxime Coquelin wrote: > On 10/16/19 3:32 PM, Ilya Maximets wrote: > > On 16.10.2019 13:13, Maxime Coquelin wrote: > >> > >> > >> On 10/15/19 8:59 PM, Flavio Leitner wrote: > >>> The rte_vhost_dequeue_burst supports two ways of dequeuing data. > >>> If the d

Re: [dpdk-dev] [PATCH v5] vhost: add support for large buffers

2019-10-16 Thread Maxime Coquelin
On 10/16/19 3:32 PM, Ilya Maximets wrote: > On 16.10.2019 13:13, Maxime Coquelin wrote: >> >> >> On 10/15/19 8:59 PM, Flavio Leitner wrote: >>> The rte_vhost_dequeue_burst supports two ways of dequeuing data. >>> If the data fits into a buffer, then all data is copied and a >>> single linear buf

Re: [dpdk-dev] [PATCH v2 00/12] add OCTEON TX2 crypto PMD

2019-10-16 Thread Anoob Joseph
Hi Akhil, I'll rebase the series and send in a short while. Thanks, Anoob > -Original Message- > From: Akhil Goyal > Sent: Wednesday, October 16, 2019 7:02 PM > To: Anoob Joseph ; Pablo de Lara > > Cc: Fiona Trahe ; Jerin Jacob Kollanukkaran > ; Narayana Prasad Raju Athreya > ; Shally

Re: [dpdk-dev] [PATCH v3 0/3] add fallback session

2019-10-16 Thread Ananyev, Konstantin
> > Hi Konstantin, > > Thanks for clarifying your stand on review comments. > > From the comments we(Marvell/Cavium) have received on multiple features, my > impression is that the feature need to be correct/fully > done/acceptable to the overall community. Features are usually agreed upon if

Re: [dpdk-dev] [PATCH] raw/ioat: enable xstats reset for ioat device

2019-10-16 Thread Bruce Richardson
On Wed, Oct 16, 2019 at 02:16:26PM +0100, Ciara Power wrote: > The rawdev xstats_reset function is now enabled. It is called when the > ioat autotest completes, to reset all xstat values after they have been > modified during testing. > > Signed-off-by: Ciara Power Reviewed-by: Bruce Richardson

Re: [dpdk-dev] [PATCH v2 03/10] buildtools: add ABI update shell script

2019-10-16 Thread Bruce Richardson
On Wed, Oct 16, 2019 at 01:43:18PM +0100, Anatoly Burakov wrote: > In order to facilitate mass updating of version files, add a shell > script that recurses into lib/ and drivers/ directories and calls > the ABI version update script. > > Signed-off-by: Anatoly Burakov > --- > > Notes: > v2:

Re: [dpdk-dev] [PATCH v5] vhost: add support for large buffers

2019-10-16 Thread Ilya Maximets
On 16.10.2019 13:13, Maxime Coquelin wrote: On 10/15/19 8:59 PM, Flavio Leitner wrote: The rte_vhost_dequeue_burst supports two ways of dequeuing data. If the data fits into a buffer, then all data is copied and a single linear buffer is returned. Otherwise it allocates additional mbufs and ch

Re: [dpdk-dev] [PATCH v2 00/12] add OCTEON TX2 crypto PMD

2019-10-16 Thread Akhil Goyal
Please rebase this series. Build cannot be verified by CI. There are apply issues. > > The series introduces poll mode driver to enable crypto offload engine > on Marvell OCTEON TX2 SoC. > > Changes in v2: > * Merged series adding sym features and asym features into one. > * Squashed patches as

Re: [dpdk-dev] [PATCH v2 02/10] buildtools: add script for updating symbols abi version

2019-10-16 Thread Bruce Richardson
On Wed, Oct 16, 2019 at 01:43:17PM +0100, Anatoly Burakov wrote: > From: Pawel Modrak > > Add a script that automatically merges all stable ABI's under one > ABI section with the new version, while leaving experimental > section exactly as it is. > > Signed-off-by: Pawel Modrak > Signed-off-by:

Re: [dpdk-dev] [PATCH v2 01/10] config: change ABI versioning for global

2019-10-16 Thread Bruce Richardson
On Wed, Oct 16, 2019 at 01:43:16PM +0100, Anatoly Burakov wrote: > From: Marcin Baran > > The libraries should be maintained using global > ABI versioning. The changes includes adding global > ABI version support for both makefile and meson > build system. Experimental libraries should be > marke

[dpdk-dev] [PATCH] net/memif: add multiple memif data transmission support

2019-10-16 Thread Anand Sunkad
When Multiple slave/master Memif interfaces are created in single process data transmission over second connection is not successful. Issue is because of "mq->in_port" is not initialized with "dev->data->port_id" in memif_msg_enq_add_ring() and memif_msg_receive_add_ring() functions, and while tra

Re: [dpdk-dev] [PATCH v2 07/10] lib: change function suffix in distributor

2019-10-16 Thread Hunt, David
On 16/10/2019 13:43, Anatoly Burakov wrote: From: Marcin Baran The functions and structures version 2.0 is still in use in librte_distributor for single packet mode but the version suffix "_v20" needs to be changed to "_single" in order to avoid confusion. Signed-off-by: Marcin Baran Signed

[dpdk-dev] [PATCH v2 2/2] sched: modify internal structs and functions for 64 bit values

2019-10-16 Thread Jasvinder Singh
Modify internal structure and functions to support 64-bit values for rates and stats parameters. Signed-off-by: Jasvinder Singh Signed-off-by: Lukasz Krakowiak --- v2: - remove rte_sched_min_val_2_u32() from rte_sched_common.h - replace rte_sched_min_val_2_u32() by RTE_MIN in rte_sched.c - repla

[dpdk-dev] [PATCH v2 1/2] sched: add support for 64 bit values

2019-10-16 Thread Jasvinder Singh
To support high bandwidth network interfaces, all rates (port, subport level token bucket and traffic class rates, pipe level token bucket and traffic class rates) and stats counters defined in public data structures (rte_sched.h) are modified to support 64 bit counters. Signed-off-by: Jasvinder S

[dpdk-dev] [PATCH] raw/ioat: enable xstats reset for ioat device

2019-10-16 Thread Ciara Power
The rawdev xstats_reset function is now enabled. It is called when the ioat autotest completes, to reset all xstat values after they have been modified during testing. Signed-off-by: Ciara Power --- drivers/raw/ioat/ioat_rawdev.c | 38 + drivers/raw/ioat/ioat_ra

Re: [dpdk-dev] [PATCH v4 0/2] Add overflow recovery for stateless compression

2019-10-16 Thread Akhil Goyal
> > > -Original Message- > > From: Trybula, ArturX > > Sent: Wednesday, October 16, 2019 10:41 AM > > To: dev@dpdk.org; Trahe, Fiona ; > shal...@marvell.com; Dybkowski, AdamX > > ; Trybula, ArturX ; > akhil.go...@nxp.com > > Subject: [PATCH v4 0/2] Add overflow recovery for stateless com

Re: [dpdk-dev] [RFC PATCH 1/9] security: introduce CPU Crypto action type and API

2019-10-16 Thread Ananyev, Konstantin
> -Original Message- > From: Akhil Goyal [mailto:akhil.go...@nxp.com] > Sent: Tuesday, October 15, 2019 4:02 PM > To: Ananyev, Konstantin ; Zhang, Roy Fan > ; 'dev@dpdk.org' ; > De Lara Guarch, Pablo ; 'Thomas Monjalon' > ; Doherty, Declan > > Cc: 'Anoob Joseph' ; Jerin Jacob ; > Hem

Re: [dpdk-dev] [RFC PATCH 00/13] add eventmode to ipsec-secgw

2019-10-16 Thread Ananyev, Konstantin
> This series introduces event-mode additions to ipsec-secgw. This effort > is based on the proposed changes for l2fwd-event and the additions in > l3fwd for event support. > > With this series, ipsec-secgw would be able to run in eventmode. The > worker thread (executing loop) would be receivin

Re: [dpdk-dev] [PATCH] doc: fix unmatched double quotation mark

2019-10-16 Thread Akhil Goyal
> > Fixes: ba7b86b1419b ("doc: add l2fwd-crypto sample app guide") > Cc: sta...@dpdk.org > > Signed-off-by: Xiao Wang > --- > doc/guides/sample_app_ug/l2_forward_crypto.rst | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Acked-by: Akhil Goyal Applied to dpdk-next-crypto Thanks.

  1   2   >