[dpdk-dev] [PATCH v4 14/14] doc: add NXP PFE PMD in release notes

2019-10-09 Thread Gagandeep Singh
Update release notes for NXP PFE driver supported for 19.11. Signed-off-by: Gagandeep Singh --- doc/guides/rel_notes/release_19_11.rst | 5 + 1 file changed, 5 insertions(+) diff --git a/doc/guides/rel_notes/release_19_11.rst b/doc/guides/rel_notes/release_19_11.rst index 7a1223249..883108

[dpdk-dev] [PATCH v4 13/14] net/pfe: add link status update

2019-10-09 Thread Gagandeep Singh
This patch add link related operations like link update, up and down. Signed-off-by: Gagandeep Singh Acked-by: Nipun Gupta Acked-by: Akhil Goyal --- doc/guides/nics/features/pfe.ini | 1 + doc/guides/nics/pfe.rst | 1 + drivers/net/pfe/pfe_ethdev.c | 105 ++

[dpdk-dev] [PATCH v4 12/14] net/pfe: add allmulticast and promiscuous

2019-10-09 Thread Gagandeep Singh
This patch adds support to enable multicast and promiscuous mode. Signed-off-by: Gagandeep Singh Acked-by: Nipun Gupta Acked-by: Akhil Goyal --- doc/guides/nics/features/pfe.ini | 2 ++ doc/guides/nics/pfe.rst | 2 ++ drivers/net/pfe/pfe_ethdev.c | 42 +++

[dpdk-dev] [PATCH v4 11/14] net/pfe: add MTU and MAC address set operations

2019-10-09 Thread Gagandeep Singh
To update MAC address or MTU, operations are added to the driver. Signed-off-by: Gagandeep Singh Acked-by: Nipun Gupta Acked-by: Akhil Goyal --- doc/guides/nics/features/pfe.ini | 1 + doc/guides/nics/pfe.rst | 1 + drivers/net/pfe/pfe_ethdev.c | 71 +

[dpdk-dev] [PATCH v4 10/14] net/pfe: add supported packet types and basic statistics

2019-10-09 Thread Gagandeep Singh
This patch add support for supported packet types by the platform andbasic statistics like numbers of packets/bytes receive and transmit. Signed-off-by: Gagandeep Singh Acked-by: Nipun Gupta Acked-by: Akhil Goyal --- doc/guides/nics/features/pfe.ini | 2 ++ doc/guides/nics/pfe.rst |

[dpdk-dev] [PATCH v4 09/14] net/pfe: add burst enqueue and dequeue operations

2019-10-09 Thread Gagandeep Singh
This patch add burst enqueue and dequeue operations to the pfe PMD. Signed-off-by: Gagandeep Singh Acked-by: Nipun Gupta Acked-by: Akhil Goyal --- drivers/net/pfe/pfe_ethdev.c | 140 + drivers/net/pfe/pfe_hif.c | 360 +- drivers/net/pfe/pfe_hif.

[dpdk-dev] [PATCH v4 08/14] net/pfe: add queue setup and release operations

2019-10-09 Thread Gagandeep Singh
This patch add RX/TX queue setup operations and supported checksum offloads. Signed-off-by: Gagandeep Singh Acked-by: Nipun Gupta Acked-by: Akhil Goyal --- doc/guides/nics/features/pfe.ini | 2 + doc/guides/nics/pfe.rst | 1 + drivers/net/pfe/pfe_ethdev.c | 93 +++

[dpdk-dev] [PATCH v4 06/14] net/pfe: add MAC and host interface initialisation

2019-10-09 Thread Gagandeep Singh
HIF or host interface is responsible for transmit and receive packets between physical ethernet interfaces and HIF library defined logical interfaces. This patch initialise that host interface and MAC. Signed-off-by: Gagandeep Singh Signed-off-by: Akhil Goyal Acked-by: Nipun Gupta --- drivers

[dpdk-dev] [PATCH v4 07/14] net/pfe: add device start stop operations

2019-10-09 Thread Gagandeep Singh
This patch adds device start, stop and close operations. Signed-off-by: Gagandeep Singh Signed-off-by: Akhil Goyal Acked-by: Nipun Gupta --- drivers/net/pfe/Makefile | 2 +- drivers/net/pfe/pfe_eth.h | 1 + drivers/net/pfe/pfe_ethdev.c | 184 + drivers/net/pfe/pfe

[dpdk-dev] [PATCH v4 02/14] net/pfe: introduce pfe net poll mode driver

2019-10-09 Thread Gagandeep Singh
pfe (packet forwarding engine) is a network poll mode driver for NXP SoC ls1012a. This patch introduces the framework of pfe driver with basic functions of initialisation and teardown. Signed-off-by: Gagandeep Singh Signed-off-by: Akhil Goyal Acked-by: Nipun Gupta --- MAINTAINERS

[dpdk-dev] [PATCH v4 04/14] net/pfe: support dynamic logging

2019-10-09 Thread Gagandeep Singh
This patch introduces logging for the pfe PMD. Signed-off-by: Gagandeep Singh Acked-by: Nipun Gupta Acked-by: Akhil Goyal --- drivers/net/pfe/pfe_ethdev.c | 69 +--- drivers/net/pfe/pfe_logs.h | 31 2 files changed, 88 insertions(+), 12 deleti

[dpdk-dev] [PATCH v4 05/14] net/pfe: add HW specific macros and operations

2019-10-09 Thread Gagandeep Singh
This patch add some hardware specific macros and functions that will be used by the driver. Signed-off-by: Gagandeep Singh Signed-off-by: Akhil Goyal Acked-by: Nipun Gupta --- drivers/net/pfe/base/cbus.h | 66 + drivers/net/pfe/base/cbus/bmu.h | 41 drivers/net/pfe/b

[dpdk-dev] [PATCH v4 03/14] doc: add guide for pfe net PMD

2019-10-09 Thread Gagandeep Singh
This patch add documentation for pfe network poll mode driver. PFE is a hardware programmable packet forwarding engine to provide high performance ethernet interfaces. Signed-off-by: Gagandeep Singh Acked-by: Nipun Gupta Acked-by: Akhil Goyal --- MAINTAINERS | 1 + doc/

[dpdk-dev] [PATCH v4 00/14] introduces pfe network PMD

2019-10-09 Thread Gagandeep Singh
This series introduces pfe (packet forwarding engine) network poll mode driver for NXP SoC ls1012a. First patch of this series move OF library code from dpaa bus to a common folder as PFE also uses the same library for getting information from the device tree. This patch is included in this series

[dpdk-dev] [PATCH v4 01/14] common/dpaax: moving OF lib code from dpaa bus

2019-10-09 Thread Gagandeep Singh
From: Hemant Agrawal This code is being shared by more than 1 type of driver. Common is most appropriate place for it. Signed-off-by: Hemant Agrawal --- drivers/bus/dpaa/Makefile | 2 +- drivers/bus/dpaa/base/fman/fman.c | 2 +- drivers/bus/dpaa/base/fman/netc

Re: [dpdk-dev] [PATCH v5 1/1] mbuf: add bulk free function

2019-10-09 Thread Andrew Rybchenko
On 10/10/19 1:54 AM, Stephen Hemminger wrote: On Wed, 9 Oct 2019 13:55:11 + Morten Brørup wrote: +/** + * @internal helper function for freeing a bulk of packet mbuf segments + * via an array holding the packet mbuf segments from the same mempool + * pending to be freed. + * + * @param

Re: [dpdk-dev] [PATCH v1 1/1] kernel/linux: introduce vfio_pf kernel module

2019-10-09 Thread Jerin Jacob
On Thu, 10 Oct, 2019, 4:58 AM Stephen Hemminger, wrote: > On Tue, 8 Oct 2019 20:58:27 +0530 > Jerin Jacob wrote: > > > On Tue, 8 Oct, 2019, 8:42 PM Stephen Hemminger, < > step...@networkplumber.org> > > wrote: > > > > > On Fri, 6 Sep 2019 14:42:30 +0530 > > > wrote: > > > > > > > From: Vamsi At

Re: [dpdk-dev] [PATCH] crypto/armv8: enable meson build

2019-10-09 Thread Jerin Jacob
On Thu, 10 Oct, 2019, 10:17 AM Honnappa Nagarahalli, < honnappa.nagaraha...@arm.com> wrote: > > > > > On Mon, 7 Oct, 2019, 3:49 PM Jerin Jacob, wrote: > > > > On Sun, 6 Oct, 2019, 11:36 PM Thomas Monjalon, > wrote: > > 05/10/2019 17:28, Jerin Jacob: > > On Fri, Oct 4, 2019 at 4:27 AM Dharmik Th

Re: [dpdk-dev] [PATCH v2] vhost: add support for large buffers.

2019-10-09 Thread Tiwei Bie
[PATCH v2] vhost: add support for large buffers. There is a warning reported by devtools/check-git-log.sh The '.' at the end of the title should be dropped. On Fri, Oct 04, 2019 at 05:10:08PM -0300, Flavio Leitner wrote: > The rte_vhost_dequeue_burst supports two ways of dequeuing data. > If th

Re: [dpdk-dev] [PATCH] crypto/armv8: enable meson build

2019-10-09 Thread Honnappa Nagarahalli
On Mon, 7 Oct, 2019, 3:49 PM Jerin Jacob, mailto:jerinjac...@gmail.com>> wrote: On Sun, 6 Oct, 2019, 11:36 PM Thomas Monjalon, mailto:tho...@monjalon.net>> wrote: 05/10/2019 17:28, Jerin Jacob: > On Fri, Oct 4, 2019 at 4:27 AM Dharmik Thakkar > mailto:dharmik.thak...@arm.com>> wrote: > > > >

[dpdk-dev] [PATCH] app/testpmd: introduce Rx offloads argument

2019-10-09 Thread viveksharma
From: Vivek Sharma Introduce boot time argument for configuring all rx offloads. Signed-off-by: Vivek Sharma --- app/test-pmd/parameters.c | 16 +++- doc/guides/testpmd_app_ug/run_app.rst | 5 + 2 files changed, 20 insertions(+), 1 deletion(-) diff --git a/app/tes

[dpdk-dev] [PATCH] app/testpmd: introduce QinQ offload argument

2019-10-09 Thread viveksharma
From: Vivek Sharma Introduce boot time argument for configuring QinQ strip offload. Fix port info display to distinguish between qinq strip and extend offloads. Signed-off-by: Vivek Sharma --- app/test-pmd/config.c | 9 +++-- app/test-pmd/parameters.c | 6 ++

Re: [dpdk-dev] [PATCH v4] cryptodev: extend api of asymmetric crypto by sessionless

2019-10-09 Thread Anoob Joseph
Hi Arek, Shouldn't we update release notes also? Also a minor observation, what is the usage that we should stick to? "session-less" or "sessionless". I see that we use it interchangeably. Thanks, Anoob > -Original Message- > From: dev On Behalf Of Arek Kusztal > Sent: Wednesday, Octo

Re: [dpdk-dev] [PATCH 0/4] updates for hns3 ethernet pmd driver

2019-10-09 Thread Wei Hu (Xavier)
Hi, Ferruh Yigit The page in patches.dpdk.org indicates that CI checking against this series failed, the page as follows: http://mails.dpdk.org/archives/test-report/2019-October/101655.html Just like the previous failure of patch CI checking, this series based on dpdk-next-net repo but CI ch

Re: [dpdk-dev] [PATCH v3 12/12] net/ice/base: improve misc code style

2019-10-09 Thread Yang, Qiming
-Original Message- From: Zhang, Qi Z Sent: Tuesday, October 8, 2019 09:50 To: Lu, Wenzhuo ; Yang, Qiming Cc: dev@dpdk.org; Ye, Xiaolong ; Zhang, Qi Z ; Nguyen, Anthony L ; Stillwell Jr, Paul M Subject: [PATCH v3 12/12] net/ice/base: improve misc code style Combine a couple of functi

Re: [dpdk-dev] [PATCH v3 10/12] net/ice/base: fix switch rule programming for all profiles

2019-10-09 Thread Yang, Qiming
-Original Message- From: Zhang, Qi Z Sent: Tuesday, October 8, 2019 09:50 To: Lu, Wenzhuo ; Yang, Qiming Cc: dev@dpdk.org; Ye, Xiaolong ; Zhang, Qi Z ; Nowlin, Dan ; Stillwell Jr, Paul M Subject: [PATCH v3 10/12] net/ice/base: fix switch rule programming for all profiles In switch

Re: [dpdk-dev] [PATCH v3 11/12] net/ice/base: add QFI for Flow Director

2019-10-09 Thread Yang, Qiming
-Original Message- From: Zhang, Qi Z Sent: Tuesday, October 8, 2019 09:50 To: Lu, Wenzhuo ; Yang, Qiming Cc: dev@dpdk.org; Ye, Xiaolong ; Zhang, Qi Z ; Nowlin, Dan ; Stillwell Jr, Paul M Subject: [PATCH v3 11/12] net/ice/base: add QFI for Flow Director Added the GTP QFI field to th

Re: [dpdk-dev] [PATCH v3 09/12] net/ice/base: fix flow raw field vector extraction

2019-10-09 Thread Yang, Qiming
-Original Message- From: Zhang, Qi Z Sent: Tuesday, October 8, 2019 09:50 To: Lu, Wenzhuo ; Yang, Qiming Cc: dev@dpdk.org; Ye, Xiaolong ; Zhang, Qi Z ; Nowlin, Dan ; Stillwell Jr, Paul M Subject: [PATCH v3 09/12] net/ice/base: fix flow raw field vector extraction Correct the ordering

[dpdk-dev] [PATCH v2 12/12] net/bnxt: remove unnecessary variable assignment

2019-10-09 Thread Ajit Khaparde
From: Kalesh AP There is no need to assign return value to a temporary variable. Instead return error directly in case of failure. Fixes: 1fe427fd08ee ("net/bnxt: support enable/disable interrupt") Cc: sta...@dpdk.org Signed-off-by: Kalesh AP Reviewed-by: Santoshkumar Karanappa Rastapur Review

[dpdk-dev] [PATCH v2 11/12] net/bnxt: fix coding style issues

2019-10-09 Thread Ajit Khaparde
From: Kalesh AP - Remove unnecessary new line - Remove unnecessary blank lines - Align rte_* header file inclusion at one place Fixes: 37d6161a68ba ("net/bnxt: add ring group alloc/free") Fixes: ec77c6298301 ("net/bnxt: add stats context allocation") Cc: sta...@dpdk.org Signed-off-by: Kalesh AP

[dpdk-dev] [PATCH v2 08/12] net/bnxt: change msix vector to queue mapping

2019-10-09 Thread Ajit Khaparde
From: Rahul Gupta DPDK PCIe-VFIO framework configures base MSIX vector for interrupts which is supported by other h/w. In case of bnxt, base MSIX vector starts with the RX completion queue 0. To comply with the DPDK framework We need to increase the map index by 1 so that RXTX completion queues e

[dpdk-dev] [PATCH v2 10/12] net/bnxt: fix to handle interface change status in port start only

2019-10-09 Thread Ajit Khaparde
From: Kalesh AP Driver issues hwrm_if_change when the port is started and stopped. This command returns whether the fw has undergone a reset while port was down. Fix to handle hwrm_if_change status during port start only. Fixes: 92d6617b6e33 ("net/bnxt: inform firmware about IF state changes") C

[dpdk-dev] [PATCH v2 06/12] net/bnxt: get the default HWRM command timeout from firmware

2019-10-09 Thread Ajit Khaparde
The HWRM command timeout is set to a very high value. VER_GET command response returns the default request timeout value. Use this value for waiting for HWRM commands to complete. Poll for the valid bit every 1us instead of 600us. Fixes: cbcd375d37d2 ("net/bnxt: fix HWRM macros and locking") Cc: s

[dpdk-dev] [PATCH v2 07/12] net/bnxt: reduce cleanup time during reset recovery

2019-10-09 Thread Ajit Khaparde
From: Rahul Gupta In stop_op(), don't wait for link down event's ASYNC response from FW. Fixes: 7c9b9cebadfc ("net/bnxt: fix async link handling and update") Cc: sta...@dpdk.org Signed-off-by: Rahul Gupta Reviewed-by: Kalesh Anakkur Purayil Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/bnx

[dpdk-dev] [PATCH v2 05/12] net/bnxt: update trusted VF status only when it changes

2019-10-09 Thread Ajit Khaparde
We are currently logging trusted VF information everytime a VF config change is indicated by the async message. Update it only when new setting is different from the current setting. Fixes: b42c15c83e88 ("net/bnxt: support trusted VF") Cc: sta...@dpdk.org Signed-off-by: Ajit Khaparde Reviewed-by

[dpdk-dev] [PATCH v2 03/12] net/bnxt: return error if setting link up fail

2019-10-09 Thread Ajit Khaparde
From: Kalesh AP Currently bnxt driver does not return error in case setting link up fails. Fixes: 5c206086feaa ("net/bnxt: add link state operations") Cc: sta...@dpdk.org Signed-off-by: Kalesh AP Reviewed-by: Somnath Kotur --- drivers/net/bnxt/bnxt_ethdev.c | 2 +- 1 file changed, 1 insertion

[dpdk-dev] [PATCH v2 00/12] bnxt patchset with bug fixes

2019-10-09 Thread Ajit Khaparde
This patch against dpdk-next-net mostly contains bug fixes for issues found during testing. v1->v2: -Split patch 09/10 into two and reworded the commit messages. -Rebased against latest dpdk-next-net -Some of the patches were missing the Fixes tag. Added it to them. Ajit

[dpdk-dev] [PATCH v2 04/12] net/bnxt: remove redundant header file inclusion

2019-10-09 Thread Ajit Khaparde
From: Kalesh AP bnxt.h header includes bnxt_cpr.h and bnxt_util.h. There is no need to include these headers file explicitly. This commit does not cause any functional change. Cc: sta...@dpdk.org Signed-off-by: Kalesh AP Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_cpr.c| 1 - dr

[dpdk-dev] [PATCH v2 02/12] net/bnxt: free default completion ring before VF configuration

2019-10-09 Thread Ajit Khaparde
From: Santoshkumar Karanappa Rastapur If the VF resources need to be reconfigured using the bnxt_hwrm_func_reserve_vf_resc, make sure that the default completion ring is freed first before the resources are reserved. Reallocate the ring once the VF resources are configured. Fixes: 7bc8e9a227cc

[dpdk-dev] [PATCH v2 09/12] net/bnxt: enable interrupts after checking interface status from FW

2019-10-09 Thread Ajit Khaparde
From: Kalesh AP Driver issues hwrm_if_change when the port is started. This command returns whether the fw has undergone a reset while port was down and driver does re-init of resources if fw has undergone a reset. Fix to enable interrupts only after this check. Fixes: 7c9b9cebadfc ("net/bnxt: f

[dpdk-dev] [PATCH v2 01/12] net/bnxt: fix return checks and return values

2019-10-09 Thread Ajit Khaparde
From: Kalesh AP This patch fixes few checks and few return values while getting and clearing device statistics. 1. Fixed to return standard error code. 2. Clubbed few error checks 3. Removed an unnecessary return check Fixes: bfb9c2260be2 ("net/bnxt: support xstats get/reset") Fixes: 8892013668

Re: [dpdk-dev] [PATCH v2 0/3] net/i40e: add FDIR ID to vector rx

2019-10-09 Thread Zhang, Qi Z
> -Original Message- > From: Van Haaren, Harry > Sent: Wednesday, October 9, 2019 11:20 PM > To: dev@dpdk.org > Cc: Zhang, Qi Z ; Ergin, Mesut A > ; Van Haaren, Harry > > Subject: [PATCH v2 0/3] net/i40e: add FDIR ID to vector rx > > v2: > - Improve RSS clearning in SSE 16B descriptor

Re: [dpdk-dev] [PATCH v5 1/1] mbuf: add bulk free function

2019-10-09 Thread Ananyev, Konstantin
> Add function for freeing a bulk of mbufs. > > v5: > * Rename variables from "free" to "pending" for improved readability. > * Add prefix __ to rte_pktmbuf_free_seg_via_array(). > * Add array size parameter to __rte_pktmbuf_free_seg_via_array(). > The compiler will optimize the parameter away

Re: [dpdk-dev] [PATCH v1 1/1] kernel/linux: introduce vfio_pf kernel module

2019-10-09 Thread Stephen Hemminger
On Tue, 8 Oct 2019 20:58:27 +0530 Jerin Jacob wrote: > On Tue, 8 Oct, 2019, 8:42 PM Stephen Hemminger, > wrote: > > > On Fri, 6 Sep 2019 14:42:30 +0530 > > wrote: > > > > > From: Vamsi Attunuru > > > > > > The DPDK use case such as VF representer or OVS offload etc > > > would call for PF a

Re: [dpdk-dev] [PATCH 0/2] Improve function versioning meson support

2019-10-09 Thread Stephen Hemminger
On Fri, 27 Sep 2019 20:49:30 +0100 Bruce Richardson wrote: > Adding support for LTO has exposed some issues with how the functions > versioning was supported by meson, which was always set to build both > shared and static libraries. > > For plain C code, so long as the -fPIC compiler flag was p

Re: [dpdk-dev] [PATCH] doc: fix internal links for older releases

2019-10-09 Thread Stephen Hemminger
On Tue, 8 Oct 2019 11:47:36 +0200 David Marchand wrote: > Using external explicit references to http://doc.dpdk.org makes older > releases documentation point to the current master documentation pages. > Switch to internal references. > > Fixes: 59ad25fe2184 ("doc: add overview of qat guide") >

Re: [dpdk-dev] [PATCH v5 1/1] mbuf: add bulk free function

2019-10-09 Thread Stephen Hemminger
On Wed, 9 Oct 2019 13:55:11 + Morten Brørup wrote: > > +/** > + * @internal helper function for freeing a bulk of packet mbuf segments > + * via an array holding the packet mbuf segments from the same mempool > + * pending to be freed. > + * > + * @param m > + * The packet mbuf segment to

Re: [dpdk-dev] [PATCH] net/af_packet: improve Tx statistics accuracy

2019-10-09 Thread Stephen Hemminger
On Wed, 9 Oct 2019 16:29:09 +0100 Flavia Musatescu wrote: > + if (sendto(pkt_q->sockfd, NULL, 0, MSG_DONTWAIT, NULL, 0) == -1 && > + errno != ENOBUFS) { > + /* Error sending. > + * When sendto call fails and ENOBUFS error is being set > +

Re: [dpdk-dev] packet data access bug in bpf and pdump libs

2019-10-09 Thread Stephen Hemminger
On Wed, 9 Oct 2019 17:20:58 +0200 Morten Brørup wrote: > > -Original Message- > > From: Stephen Hemminger [mailto:step...@networkplumber.org] > > Sent: Wednesday, October 9, 2019 5:15 PM > > > > On Wed, 9 Oct 2019 17:06:24 +0200 > > Morten Brørup wrote: > > > > > > -Original Mess

Re: [dpdk-dev] [dpdk-stable] [PATCH 1/3] net/enic: restrict several handlers to primary process

2019-10-09 Thread Ferruh Yigit
On 10/9/2019 10:38 AM, Hyong Youb Kim (hyonkim) wrote: >> -Original Message- >> From: Ferruh Yigit >> Sent: Wednesday, October 9, 2019 6:28 PM >> To: Hyong Youb Kim (hyonkim) >> Cc: dev@dpdk.org; John Daley (johndale) ; Dirk- >> Holger Lenz ; sta...@dpdk.org >> Subject: Re: [dpdk-stable]

Re: [dpdk-dev] [PATCH v3 1/1] app/testpmd: add console cmd to show port supported ptypes

2019-10-09 Thread Ferruh Yigit
On 9/19/2019 10:16 AM, Iremonger, Bernard wrote: >> -Original Message- >> From: vattun...@marvell.com [mailto:vattun...@marvell.com] >> Sent: Thursday, September 19, 2019 4:50 AM >> To: dev@dpdk.org >> Cc: Lu, Wenzhuo ; Wu, Jingjing >> ; Iremonger, Bernard >> ; tho...@monjalon.net; Vamsi At

[dpdk-dev] [PATCH v4] cryptodev: extend api of asymmetric crypto by sessionless

2019-10-09 Thread Arek Kusztal
This commit adds asymmetric session-less option to rte_crypto_asym_op. Feature flag for sessionless is added to rte_cryptodev. Signed-off-by: Arek Kusztal --- v2: - added union v3: - added entry into feature matrix - added information to prog_guide v4: - fixed formatting - fixed grammar doc/gui

Re: [dpdk-dev] [RFC] Chacha20 Poly1305 Support

2019-10-09 Thread Trahe, Fiona
Hi Arek, -- From: Kusztal, ArkadiuszX Sent: Wednesday, October 9, 2019 9:30 AM To: dev@dpdk.org Cc: akhil.go...@nxp.com; Zhang, Roy Fan ; Shally Verma ; Trahe, Fiona ; Anoob Joseph ; De Lara Guarch, Pablo ; Doherty, Declan ; t...@semihalf.com Subject: [RFC] Chacha20 Poly1305 Support Hi,

Re: [dpdk-dev] [PATCH v3 0/3] add fallback session

2019-10-09 Thread Anoob Joseph
Hi Konstantin, Following are the main issues I had identified, 1. Doesn't work for inline protocol offload (the plan itself won't scale for that case) 2. Ignores the data from the h/w lookup 3. The fallback support is actually supported in ipsec-secgw (application) instead of librte_ipsec. 4. R

[dpdk-dev] [PATCH v10 7/7] examples: disable Rx packet type parsing

2019-10-09 Thread pbhagavatula
From: Pavan Nikhilesh Disable packet type parsing in examples that don't use `rte_mbuf::packet_type` by setting ptype_mask as 0 in `rte_eth_dev_set_supported_ptypes` Signed-off-by: Pavan Nikhilesh --- examples/bbdev_app/main.c | 1 + examples/bond/main.c

[dpdk-dev] [PATCH v10 4/7] drivers/net: update Rx RSS hash offload capabilities

2019-10-09 Thread pbhagavatula
From: Pavan Nikhilesh Add DEV_RX_OFFLOAD_RSS_HASH flag for all PMDs that support RSS hash delivery. Signed-off-by: Pavan Nikhilesh Reviewed-by: Andrew Rybchenko Reviewed-by: Hemant Agrawal Acked-by: Jerin Jacob Acked-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_ethdev.c | 3 ++- driv

[dpdk-dev] [PATCH v10 6/7] examples/eventdev_pipeline: add new Rx RSS hash offload

2019-10-09 Thread pbhagavatula
From: Pavan Nikhilesh Since pipeline_generic uses `rte_mbuf::hash::rss` add the new Rx offload flag `DEV_RX_OFFLOAD_RSS_HASH` to inform PMD to copy the RSS hash result into the mbuf. Signed-off-by: Pavan Nikhilesh --- examples/eventdev_pipeline/main.c | 113 - .../p

[dpdk-dev] [PATCH v10 5/7] drivers/net: update Rx flow flag and mark capabilities

2019-10-09 Thread pbhagavatula
From: Pavan Nikhilesh Add DEV_RX_OFFLOAD_FLOW_MARK flag for all PMDs that support flow action flag and mark. Signed-off-by: Pavan Nikhilesh Reviewed-by: Andrew Rybchenko Acked-by: Jerin Jacob --- drivers/net/bnxt/bnxt_ethdev.c | 3 ++- drivers/net/enic/enic_res.c | 3 ++-

[dpdk-dev] [PATCH v10 3/7] ethdev: add flow action type update as an offload

2019-10-09 Thread pbhagavatula
From: Pavan Nikhilesh Add new Rx offload flag `DEV_RX_OFFLOAD_FLOW_MARK` that can be used to enable/disable PMDs write to `rte_mbuf::hash::fdir::hi` and `rte_mbuf::ol_flags` when flow actions `RTE_FLOW_ACTION_MARK` and `RTE_FLOW_ACTION_FLAG` are enabled. PMDs notify the validity of `rte_mbuf::ha

[dpdk-dev] [PATCH v10 2/7] ethdev: add mbuf RSS update as an offload

2019-10-09 Thread pbhagavatula
From: Pavan Nikhilesh Add new Rx offload flag `DEV_RX_OFFLOAD_RSS_HASH` which can be used to enable/disable PMDs write to `rte_mbuf::hash::rss`. PMDs notify the validity of `rte_mbuf::hash:rss` to the applcation by enabling `PKT_RX_RSS_HASH ` flag in `rte_mbuf::ol_flags`. Signed-off-by: Pavan Ni

[dpdk-dev] [PATCH v10 0/7] ethdev: add new Rx offload flags

2019-10-09 Thread pbhagavatula
From: Pavan Nikhilesh Add new Rx offload flags `DEV_RX_OFFLOAD_RSS_HASH` and `DEV_RX_OFFLOAD_FLOW_MARK`. These flags can be used to enable/disable PMD writes to rte_mbuf fields `hash.rss` and `hash.fdir.hi` and also `ol_flags:PKT_RX_RSS` and `ol_flags:PKT_RX_FDIR`. Add new packet type set functi

[dpdk-dev] [PATCH v10 1/7] ethdev: add set ptype function

2019-10-09 Thread pbhagavatula
From: Pavan Nikhilesh Add `rte_eth_dev_set_supported_ptypes` function that will allow the application to inform the PMD the packet types it is interested in. Based on the ptypes set PMDs can optimize their Rx path. -If application doesn’t want any ptype information it can call `rte_eth_dev_set_s

[dpdk-dev] [PATCH] net/af_packet: improve Tx statistics accuracy

2019-10-09 Thread Flavia Musatescu
When sendto call fails and ENOBUFS error is being set some of the packets are actually successfully transmitted. There is no available count of those packets, so in order to make the statistics more accurate, all the previously enqueued packets will be considered successful, even though this is not

Re: [dpdk-dev] packet data access bug in bpf and pdump libs

2019-10-09 Thread Morten Brørup
> -Original Message- > From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Wednesday, October 9, 2019 5:15 PM > > On Wed, 9 Oct 2019 17:06:24 +0200 > Morten Brørup wrote: > > > > -Original Message- > > > From: Stephen Hemminger [mailto:step...@networkplumber.org]

[dpdk-dev] [PATCH v2 3/3] net/i40e: add flow director support to avx rx path

2019-10-09 Thread Harry van Haaren
This commit adds FDIR ID support to the AVX2 based recieve path routine. Support for both 16B and 32B descriptors is implemented. Signed-off-by: Harry van Haaren --- v2: - Fixup AVX2 RSS clearing to not pollute register --- drivers/net/i40e/i40e_rxtx_vec_avx2.c | 193 +-

[dpdk-dev] [PATCH v2 2/3] net/i40e: add flow mark capability to SSE vector routine

2019-10-09 Thread Harry van Haaren
This commit adds an implementation to the SSE vector implementation of RX routine and moves some common defines from a c file to the header file. I40e can have 16 and 32 byte descriptors, and the Flow Director ID data and indication-bit are in different locations for each size descriptor. The supp

[dpdk-dev] [PATCH v2 1/3] net/i40e: cache fdir enable value in rx queue

2019-10-09 Thread Harry van Haaren
This commit adds a fdir_enable flag in a uint8_t sized hole the rx queue structure The flag enables the rx code path to easily identify if fdir is active. This can be used to skip fdir id processing when it is not required. The flag is zero by default (as rxq is zmalloc-ed at startup), and the fla

[dpdk-dev] [PATCH v2 0/3] net/i40e: add FDIR ID to vector rx

2019-10-09 Thread Harry van Haaren
v2: - Improve RSS clearning in SSE 16B descriptor - Fix AVX 16B descriptor data handling --- Hey All, This series adds FDIR ID support to the vector Rx routines. Support for both the SSE and AVX drivers is added, and both the 16 byte and 32 byte descriptors are implemented. A v1/RFC for this fu

Re: [dpdk-dev] packet data access bug in bpf and pdump libs

2019-10-09 Thread Stephen Hemminger
On Wed, 9 Oct 2019 17:06:24 +0200 Morten Brørup wrote: > > -Original Message- > > From: Stephen Hemminger [mailto:step...@networkplumber.org] > > Sent: Wednesday, October 9, 2019 5:02 PM > > > > On Wed, 9 Oct 2019 11:11:46 + > > "Ananyev, Konstantin" wrote: > > > > > Hi Morten, >

[dpdk-dev] [RFC PATCH 13/13] examples/ipsec-secgw: add cmd line option for bufs

2019-10-09 Thread Anoob Joseph
Add command line option -s which can be used to configure number of buffers in a pool. Default number of buffers is 4000. Signed-off-by: Anoob Joseph Signed-off-by: Lukasz Bartosik --- examples/ipsec-secgw/ipsec-secgw.c | 23 +++ 1 file changed, 19 insertions(+), 4 deletions

[dpdk-dev] [RFC PATCH 12/13] examples/ipsec-secgw: add app outbound worker

2019-10-09 Thread Anoob Joseph
This patch adds the app outbound worker thread. Signed-off-by: Anoob Joseph Signed-off-by: Lukasz Bartosik --- examples/ipsec-secgw/ipsec_worker.c | 190 +++- 1 file changed, 189 insertions(+), 1 deletion(-) diff --git a/examples/ipsec-secgw/ipsec_worker.c b/ex

[dpdk-dev] [RFC PATCH 11/13] examples/ipsec-secgw: add driver outbound worker

2019-10-09 Thread Anoob Joseph
This patch adds the driver outbound worker thread for ipsec-secgw. In this mode the security session is a fixed one and sa update is not done. Signed-off-by: Anoob Joseph Signed-off-by: Lukasz Bartosik --- examples/ipsec-secgw/ipsec-secgw.c | 6 +++ examples/ipsec-secgw/ipsec.c| 4 ++

[dpdk-dev] [RFC PATCH 10/13] examples/ipsec-secgw: add app processing code

2019-10-09 Thread Anoob Joseph
Add IPsec application processing code for event mode. Signed-off-by: Anoob Joseph Signed-off-by: Lukasz Bartosik --- examples/ipsec-secgw/ipsec-secgw.c | 108 ++-- examples/ipsec-secgw/ipsec-secgw.h | 81 examples/ipsec-secgw/ipsec.h| 37 +++--- examples/ips

[dpdk-dev] [RFC PATCH 09/13] examples/ipsec-secgw: add app inbound worker

2019-10-09 Thread Anoob Joseph
Add application inbound worker thread. Signed-off-by: Anoob Joseph Signed-off-by: Lukasz Bartosik --- examples/ipsec-secgw/ipsec_worker.c | 86 - 1 file changed, 85 insertions(+), 1 deletion(-) diff --git a/examples/ipsec-secgw/ipsec_worker.c b/examples/ips

[dpdk-dev] [RFC PATCH 08/13] examples/ipsec-secgw: add eventmode to ipsec-secgw

2019-10-09 Thread Anoob Joseph
Add eventmode support to ipsec-secgw. This uses event helper to setup and use the eventmode capabilities. Add driver inbound worker. Example command: ./ipsec-secgw -c 0x1 -w 0002:02:00.0,nb_ipsec_in_sa=100 -w 0002:07:00.0 -w 0002:0e:00.0 -w 0002:10:00.1 -- -P -p 0x3 -u 0x1 --config "(0,0,0),(1,0

[dpdk-dev] [RFC PATCH 07/13] examples/ipsec-secgw: add support for internal ports

2019-10-09 Thread Anoob Joseph
Add support for Rx and Tx internal ports. When internal ports are available then a packet can be received from eth port and forwarded to event queue by HW without any software intervention. The same applies to Tx side where a packet sent to an event queue can by forwarded by HW to eth port without

[dpdk-dev] [RFC PATCH 06/13] examples/ipsec-secgw: add routines to launch workers

2019-10-09 Thread Anoob Joseph
With eventmode, workers can be drafted differently according to the capabilities of the underlying event device. The added functions will receive an array of such workers and probe the eventmode properties to choose the worker. Signed-off-by: Anoob Joseph Signed-off-by: Lukasz Bartosik --- exam

[dpdk-dev] [RFC PATCH 05/13] examples/ipsec-secgw: add routines to display config

2019-10-09 Thread Anoob Joseph
Add routines to display the eventmode configuration. This gives an overview of the devices used. Signed-off-by: Anoob Joseph Signed-off-by: Lukasz Bartosik --- examples/ipsec-secgw/event_helper.c | 207 examples/ipsec-secgw/event_helper.h | 14 +++ 2 files

[dpdk-dev] [RFC PATCH 04/13] examples/ipsec-secgw: add Tx adapter support

2019-10-09 Thread Anoob Joseph
Add Tx adapter support. The event helper init routine will initialize the Tx adapter according to the configuration. If Tx adapter config is not present it will generate a default config. Signed-off-by: Anoob Joseph Signed-off-by: Lukasz Bartosik --- examples/ipsec-secgw/event_helper.c | 375 ++

[dpdk-dev] [RFC PATCH 00/13] add eventmode to ipsec-secgw

2019-10-09 Thread Anoob Joseph
This series introduces event-mode additions to ipsec-secgw. This effort is based on the proposed changes for l2fwd-event and the additions in l3fwd for event support. With this series, ipsec-secgw would be able to run in eventmode. The worker thread (executing loop) would be receiving events and w

[dpdk-dev] [RFC PATCH 03/13] examples/ipsec-secgw: add Rx adapter support

2019-10-09 Thread Anoob Joseph
Add Rx adapter support. The event helper init routine will initialize the Rx adapter according to the configuration. If Rx adapter config is not present it will generate a default config. It will check the available eth ports and event queues and map them 1:1. So one eth port will be connected to o

[dpdk-dev] [RFC PATCH 02/13] examples/ipsec-secgw: add eventdev port-lcore link

2019-10-09 Thread Anoob Joseph
Add event device port-lcore link and specify which event queues should be connected to the event port. Generate a default config for event port-lcore links if it is not specified in the configuration. This routine will check the number of available ports and then create links according to the numbe

[dpdk-dev] [RFC PATCH 01/13] examples/ipsec-secgw: add framework for eventmode helper

2019-10-09 Thread Anoob Joseph
Add framework for eventmode helper. Event mode would involve initialization of multiple devices, like eventdev, ethdev etc. Add routines to initialize and uninitialize event devices. Generate a default config for event devices if it is not specified in the configuration. The routine will iterate ov

Re: [dpdk-dev] packet data access bug in bpf and pdump libs

2019-10-09 Thread Morten Brørup
> -Original Message- > From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Wednesday, October 9, 2019 5:02 PM > > On Wed, 9 Oct 2019 11:11:46 + > "Ananyev, Konstantin" wrote: > > > Hi Morten, > > > > > > > > Hi Konstantin and Stephen, > > > > > > I just noticed the sa

Re: [dpdk-dev] packet data access bug in bpf and pdump libs

2019-10-09 Thread Stephen Hemminger
On Wed, 9 Oct 2019 11:11:46 + "Ananyev, Konstantin" wrote: > Hi Morten, > > > > > Hi Konstantin and Stephen, > > > > I just noticed the same bug in your bpf and pcap libraries: > > > > You are using rte_pktmbuf_mtod(), but should be using rte_pktmbuf_read(). > > Otherwise you cannot read

Re: [dpdk-dev] [RFC 5/8] pdump: add classic BPF filtering

2019-10-09 Thread Stephen Hemminger
On Wed, 9 Oct 2019 08:21:42 + "Ananyev, Konstantin" wrote: > Hi everyone, > > > > > > > > > > > > Simple classic BPF interpreter based off of libpcap. > > > > > > > > > > > > > > > > > > > > > > This is a copy of the BPF interpreter from libpcap which > > > > > > > > > > > is > > > > > > >

Re: [dpdk-dev] [PATCH] doc: fix release notes for removed testpmd commands

2019-10-09 Thread David Marchand
On Wed, Oct 9, 2019 at 3:47 PM Thomas Monjalon wrote: > > The notes were not visible in the generated doc output because > of an indentation mistake. > While fixing the indentation, the formatting is improved. > > Fixes: e5db17a1e54e ("app/testpmd: remove duplicated Rx offload commands") > Cc: fla

Re: [dpdk-dev] [PATCH] mk: add support for UBSAN

2019-10-09 Thread Harman Kalra
Ping.. On Fri, Sep 13, 2019 at 11:40:40AM +, Harman Kalra wrote: > Ping.. > Kindly review this patch. > > On Mon, Aug 19, 2019 at 07:18:21PM +0530, Harman Kalra wrote: > > UndefinedBehaviorSanitizer (UBSan) is a fast undefined behavior > > detector. UBSan modifies the program at compile-time

[dpdk-dev] [PATCH 4/4] net/hns3: restores bus_master_en and msix_enable during PF FLR reset

2019-10-09 Thread Wei Hu (Xavier)
From: Chunsong Feng PF FLR resets the PCIe ECAM space of all VFs under the PF and does not automatically recover. Therefore, the VF driver needs to restore the ECAM configuration, including bus_master_en, msix_enable. Signed-off-by: Chunsong Feng Signed-off-by: Wei Hu (Xavier) --- drivers/net

[dpdk-dev] [PATCH 3/4] net/hns3: Renew command and desc structure

2019-10-09 Thread Wei Hu (Xavier)
From: humin This patch adds commands and modifies descriptor structures for accessing manage table and mac table. Signed-off-by: humin Signed-off-by: Wei Hu (Xavier) --- drivers/net/hns3/hns3_cmd.h | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/net/hns3/h

[dpdk-dev] [PATCH 1/4] net/hns3: modify the statistics for sending and receiving messages

2019-10-09 Thread Wei Hu (Xavier)
From: Hao Chen In receiving direction, for FCS error messages, drivers no longer record them in rte_eth_stats.ipackets statistics. In sending direction, for messages of illegal length, too long or equals 0, drivers will not notify the network card hardware to send them, will not continue to send

[dpdk-dev] [PATCH 2/4] net/hns3: change the return value of firmware processing timeout from -EBADE to -ETIME

2019-10-09 Thread Wei Hu (Xavier)
From: Hongbo Zheng Configuration commands are sent to firmware for processing. When firmware processing timeout, the corresponding error code is returned. Considering that it is more reasonable to use error code -ETIME for timeout error, the error code for processing timeout is changed from -EBAD

[dpdk-dev] [PATCH 0/4] updates for hns3 ethernet pmd driver

2019-10-09 Thread Wei Hu (Xavier)
This series adds some updates for hns3 ethernet pmd driver. The No.1 patch modifies the statistics information for sending and receiving packets. The No.2 patch changes the return value of firmware processing timeout from -EBADE to -ETIME. The No.3 patch adds commands between driver and firmware.

[dpdk-dev] [PATCH v5 1/1] mbuf: add bulk free function

2019-10-09 Thread Morten Brørup
Add function for freeing a bulk of mbufs. v5: * Rename variables from "free" to "pending" for improved readability. * Add prefix __ to rte_pktmbuf_free_seg_via_array(). * Add array size parameter to __rte_pktmbuf_free_seg_via_array(). The compiler will optimize the parameter away anyway. * Add d

[dpdk-dev] [PATCH v5 0/1] mbuf: add bulk free function

2019-10-09 Thread Morten Brørup
Add function for freeing a bulk of mbufs. v5: * Rename variables from "free" to "pending" for improved readability. * Add prefix __ to rte_pktmbuf_free_seg_via_array(). * Add array size parameter to __rte_pktmbuf_free_seg_via_array(). The compiler will optimize the parameter away anyway. * Add d

[dpdk-dev] [PATCH] doc: fix release notes for removed testpmd commands

2019-10-09 Thread Thomas Monjalon
The notes were not visible in the generated doc output because of an indentation mistake. While fixing the indentation, the formatting is improved. Fixes: e5db17a1e54e ("app/testpmd: remove duplicated Rx offload commands") Cc: flavia.musate...@intel.com Signed-off-by: Thomas Monjalon --- doc/gu

Re: [dpdk-dev] [PATCH] devtools: check coverity and bugzilla tags

2019-10-09 Thread Kevin Traynor
On 08/10/2019 16:52, David Marchand wrote: > Let's try to check for discrepancies in covery and bugzilla tags. s/covery/coverity/ - you are trying to fool your patch? :-) > The contributing guide specifies that: > - for coverity issues, the tag is 'Coverity issue:' > - for bugzilla issues, the ta

Re: [dpdk-dev] [RFC PATCH 1/9] security: introduce CPU Crypto action type and API

2019-10-09 Thread Ananyev, Konstantin
Hi Akhil, > > > > > > > > > > > > > > > > > This action type allows the burst of > > > > > > > > > > > > > > > > > symmetric crypto > > > > > > workload > > > > > > > > using > > > > > > > > > > > the > > > > > > > > > > > > > > > same > > > > > > > > > > > > > > > > > algorithm, key, and direc

[dpdk-dev] [PATCH v1] net/ice: avoid the parsed devargs value being overwritten

2019-10-09 Thread Haiyue Wang
If the default dev args 'proto_xtr' is not in the first position, it will overwrite the parsed queue map value, so use an new variable to save the default. And enhance the error message printing to show the right information. Signed-off-by: Haiyue Wang --- drivers/net/ice/ice_ethdev.c | 44

[dpdk-dev] [PATCH v11 8/9] vhost: add vring functions packed ring support

2019-10-09 Thread Jin Yu
This patch add packed ring support in two APIs so user can get the packed ring`. Signed-off-by: Lin Li Signed-off-by: Xun Ni Signed-off-by: Yu Zhang Signed-off-by: Jin Yu --- lib/librte_vhost/vhost.c | 68 +--- 1 file changed, 49 insertions(+), 19 deletions

  1   2   >