Re: [dpdk-dev] [PATCH 0/8] eBPF arm64 JIT support

2019-10-07 Thread Jerin Jacob
On Tue, 8 Oct, 2019, 1:45 AM Thomas Monjalon, wrote: > 07/10/2019 21:29, Jerin Jacob: > > On Mon, 7 Oct, 2019, 11:35 PM Thomas Monjalon, > wrote: > [...] > > let's restart from the beginning by answering simple questions: > > > - what are the use cases of BPF in DPDK? > > > > If something needs

Re: [dpdk-dev] [PATCH v3 2/3] vhost: convert buffer addresses to GPA for logging

2019-10-07 Thread Tiwei Bie
On Fri, Sep 27, 2019 at 08:37:58PM +0200, Adrian Moreno wrote: > Note that the API facing rte_vhost_log_write is not modified. > So, make explicit that it expects the address in GPA space. > > Fixes: 69c90e98f483 ("vhost: enable IOMMU support") > Cc: maxime.coque...@redhat.com > Cc: sta...@dpdk.or

Re: [dpdk-dev] [PATCH v3 3/3] vhost: prevent zero copy mode if iommu is on

2019-10-07 Thread Tiwei Bie
On Fri, Sep 27, 2019 at 08:37:59PM +0200, Adrian Moreno wrote: > The simltaneous use of dequeue_zero_copy and IOMMU is problematic. > Not only because IOVA_VA mode is not supported but also because the > potential invalidation of guest pages while the buffers are in use, > is not handled. > > Prev

Re: [dpdk-dev] [PATCH 3/3] net/virtio: reject unsupported Rx multi queue modes

2019-10-07 Thread Tiwei Bie
On Tue, Oct 01, 2019 at 04:44:31PM +0100, Andrew Rybchenko wrote: > From: Dilshod Urazov > > This driver supports none of DCB, RSS or VMDQ modes, > therefore must check and return error if configured incorrectly. > > Fixes: c1f86306a026 ("virtio: add new driver") > Cc: sta...@dpdk.org > > Signe

Re: [dpdk-dev] [PATCH 2/3] net/virtio: reject deferred start Tx queue setup

2019-10-07 Thread Tiwei Bie
On Tue, Oct 01, 2019 at 04:44:30PM +0100, Andrew Rybchenko wrote: > From: Dilshod Urazov > > Deferred start Tx queue is not supported by the driver. > > Fixes: 0748be2cf9a2 ("ethdev: queue start and stop") > Cc: sta...@dpdk.org > > Signed-off-by: Dilshod Urazov > Signed-off-by: Andrew Rybchenk

Re: [dpdk-dev] [PATCH v10 0/5] kni: add IOVA=VA support

2019-10-07 Thread Vamsi Krishna Attunuru
@All, we are expecting to merge this in 19.11 release and if any one have comments please respond. > -Original Message- > From: Vamsi Krishna Attunuru > Sent: Wednesday, September 25, 2019 9:30 AM > To: vattun...@marvell.com; dev@dpdk.org > Cc: tho...@monjalon.net; Jerin Jacob Kollanukkar

Re: [dpdk-dev] [PATCH v1 1/1] kernel/linux: introduce vfio_pf kernel module

2019-10-07 Thread Vamsi Krishna Attunuru
> -Original Message- > From: Jerin Jacob Kollanukkaran > Sent: Friday, September 6, 2019 6:58 PM > To: Thomas Monjalon ; Vamsi Krishna Attunuru > > Cc: dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH v1 1/1] kernel/linux: introduce vfio_pf kernel > module > > > -Original Message

Re: [dpdk-dev] [RFC 5/8] pdump: add classic BPF filtering

2019-10-07 Thread Stephen Hemminger
On Tue, 8 Oct 2019 09:45:45 +0530 Jerin Jacob wrote: > On Tue, 8 Oct, 2019, 9:31 AM Stephen Hemminger, > wrote: > > > On Tue, 8 Oct 2019 09:17:08 +0530 > > Jerin Jacob wrote: > > > > > On Tue, 8 Oct, 2019, 3:15 AM Stephen Hemminger, < > > step...@networkplumber.org> > > > wrote: > > > > >

Re: [dpdk-dev] [RFC 5/8] pdump: add classic BPF filtering

2019-10-07 Thread Jerin Jacob
On Tue, 8 Oct, 2019, 9:31 AM Stephen Hemminger, wrote: > On Tue, 8 Oct 2019 09:17:08 +0530 > Jerin Jacob wrote: > > > On Tue, 8 Oct, 2019, 3:15 AM Stephen Hemminger, < > step...@networkplumber.org> > > wrote: > > > > > On Tue, 8 Oct 2019 01:03:17 +0530 > > > Jerin Jacob wrote: > > > > > > > On

Re: [dpdk-dev] [RFC 5/8] pdump: add classic BPF filtering

2019-10-07 Thread Stephen Hemminger
On Tue, 8 Oct 2019 09:17:08 +0530 Jerin Jacob wrote: > On Tue, 8 Oct, 2019, 3:15 AM Stephen Hemminger, > wrote: > > > On Tue, 8 Oct 2019 01:03:17 +0530 > > Jerin Jacob wrote: > > > > > On Mon, 7 Oct, 2019, 11:03 PM Stephen Hemminger, < > > step...@networkplumber.org> > > > wrote: > > > > >

Re: [dpdk-dev] [RFC 5/8] pdump: add classic BPF filtering

2019-10-07 Thread Jerin Jacob
On Tue, 8 Oct, 2019, 3:15 AM Stephen Hemminger, wrote: > On Tue, 8 Oct 2019 01:03:17 +0530 > Jerin Jacob wrote: > > > On Mon, 7 Oct, 2019, 11:03 PM Stephen Hemminger, < > step...@networkplumber.org> > > wrote: > > > > > On Mon, 7 Oct 2019 22:37:43 +0530 > > > Jerin Jacob wrote: > > > > > > > On

[dpdk-dev] 答复: [PATCH] crypto/virtio: alloc private data by NUMA affinity

2019-10-07 Thread Zhoujian (jay)
> -Original Message- > From: Akhil Goyal [mailto:akhil.go...@nxp.com] > Sent: Friday, October 4, 2019 8:00 PM > To: Zhoujian (jay) > Cc: dev@dpdk.org; Xiao Wang > Subject: RE: [dpdk-dev] [PATCH] crypto/virtio: alloc private data by NUMA > affinity > > Hi Jay, > > Could you please revi

[dpdk-dev] [PATCH v3] net/i40e: fix exception with multi-driver

2019-10-07 Thread alvinx . zhang
From: Alvin Zhang If support-multi-driver is enabled, the global registers should not be configured. But with the current code base, if creating a flow with rte_flow API, the global register GLQF_FD_MSK may be changed. Fixes: cfdfca493cae ("net/i40e: fix multiple driver support") Cc: sta...@dpdk

Re: [dpdk-dev] [PATCH] crypto/virtio: alloc private data by NUMA affinity

2019-10-07 Thread Zhoujian (jay)
> -Original Message- > From: Xiao Wang [mailto:xiao.w.w...@intel.com] > Sent: Wednesday, September 4, 2019 9:22 PM > To: Zhoujian (jay) > Cc: dev@dpdk.org; Xiao Wang > Subject: [PATCH] crypto/virtio: alloc private data by NUMA affinity > > It's better to allocate device private data o

[dpdk-dev] [PATCH v3] net/i40e: fix exception with multi-driver

2019-10-07 Thread alvinx . zhang
From: Alvin Zhang If support-multi-driver is enabled, the global registers should not be configured. But with the current code base, if creating a flow with rte_flow API, the global register GLQF_FD_MSK may be changed. Fixes: cfdfca493cae ("net/i40e: fix multiple driver support") Cc: sta...@dpdk

[dpdk-dev] [PATCH v3 12/12] net/ice/base: improve misc code style

2019-10-07 Thread Qi Zhang
Combine a couple of function definitions that can fit on one line. RCT a variable declaration. Signed-off-by: Tony Nguyen Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_flex_pipe.c | 6 ++ drivers/net/ice/base/ice_flex_pipe.h | 3 +-- drivers/net/ic

[dpdk-dev] [PATCH v3 11/12] net/ice/base: add QFI for Flow Director

2019-10-07 Thread Qi Zhang
Added the GTP QFI field to the Flow director interface to allow matching against this field. Since this field only appears in GTP packets with extension headers, this also requires adding profile TCAM mask matching capability. This allows comprehending different PTYPE attributes by examining flags

[dpdk-dev] [PATCH v3 10/12] net/ice/base: fix switch rule programming for all profiles

2019-10-07 Thread Qi Zhang
In switch rule programming, if the caller requested tunnel type of ICE_SW_TUN_AND_NON_TUN, then the code would incorrectly attempt to add a tunneled UDP port in the training packet, this would cause the rule addition to fail. This patch does not attempt to add the UDP port so that the rule programm

[dpdk-dev] [PATCH v3 09/12] net/ice/base: fix flow raw field vector extraction

2019-10-07 Thread Qi Zhang
Correct the ordering of raw field extraction in the field vector by taking into account the ordering setting for requesting block. Fixes: aa1cd410fa64 ("net/ice/base: add flow module") Signed-off-by: Dan Nowlin Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/bas

[dpdk-dev] [PATCH v3 07/12] net/ice/base: zero initialize structures

2019-10-07 Thread Qi Zhang
Some functions create ice_pkg_enum structure, but it seems it's possible some of the members are used un-initialized. So we'll initialize all instantiations of this structure within ice_flex_pipe.c The patch also fix header comment mismatch issue for ice_init_prof_result_bm Signed-off-by: Jeb Cr

[dpdk-dev] [PATCH v3 03/12] net/ice/base: update flow ptype bitmaps

2019-10-07 Thread Qi Zhang
In the flow api, the outer first ptype bitmaps contained many references to inner ptypes. Because of PTG assignments, these were causing issues when programming rules on the inner ptypes. For example, in RSS when programming the outer IPV6 hash fields, it also programmed several inner IPV4 PTGs wit

[dpdk-dev] [PATCH v3 08/12] net/ice/base: fix unexpected switch rule overwrite

2019-10-07 Thread Qi Zhang
A switch rule with "drop" action will be overwritten by a rule with same pattern match but with a "to queue" action. While in an inversed flow creation sequence, the "to queue" can't be overwritten by the "drop" rule. The inconsistent behavior is not expected, the patch fix the issue by preventing

[dpdk-dev] [PATCH v3 05/12] net/ice/base: improvements to Flow Director masking

2019-10-07 Thread Qi Zhang
Currently, 3-tuple FD matching is implemented using masking. However, this is using up twenty-four of the thirty-two FD masks available. This patch uses the swap register more efficiently to implement the 3-tuple matches, which saves all FD masks for other uses. Added IPV6 versions of DSCP, TTL an

[dpdk-dev] [PATCH v3 06/12] net/ice/base: remove dead error condition

2019-10-07 Thread Qi Zhang
The pointer cmd is set to an address of a structure, which can never be NULL. Remove the check-for-NULL lines since it's dead code anyway. Signed-off-by: Jeb Cramer Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang Acked-by: Qiming Yang --- drivers/net/ice/base/ice_common.c | 3 ---

[dpdk-dev] [PATCH v3 04/12] net/ice/base: add GTPU TEID support for FD

2019-10-07 Thread Qi Zhang
Added the training packet for GTPU TEID field to the Flow director to allow matching against this field. Signed-off-by: Junfeng Guo Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang Acked-by: Qiming Yang --- drivers/net/ice/base/ice_fdir.c | 2 ++ drivers/net/ice/base/ice_fdir.h | 1

[dpdk-dev] [PATCH v3 02/12] net/ice/base: fix for NVGRE switch rule programming

2019-10-07 Thread Qi Zhang
Correct for GRE/NVGRE training packets to include the correct protocol IDs for TCP and UDP respectively. Fixes: b83a0c290322 ("net/ice/base: fix inner TCP and UDP support for GRE") Signed-off-by: Dan Nowlin Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang Acked-by: Qiming Yang ---

[dpdk-dev] [PATCH v3 00/12] net/ice: base code update

2019-10-07 Thread Qi Zhang
Changes in summary 1. add GTP TEID support for fdir 2. improve fdir mask support. 3. couple fixes. 4. support QFI match in fdir v2: - add QFI match support in fdir - couple fixes and code clean v3: - fix title in patch 12/12 Qi Zhang (12): net/ice/base: fix for adding PPPoE switch rule net/i

[dpdk-dev] [PATCH v3 01/12] net/ice/base: fix for adding PPPoE switch rule

2019-10-07 Thread Qi Zhang
Update VLAN protocol ID to correct value for single VXLAN scenario. Fix the missing ethertype offset for PPPoE dummy packet offset to allow matching the corresponding field. Fixes: d341bdc30290 ("net/ice/base: add support for GTP and PPPoE protocols") Signed-off-by: Dan Nowlin Signed-off-by: Jun

Re: [dpdk-dev] [PATCH v2 RESEND] timer: remove check_tsc_flags()

2019-10-07 Thread Stephen Hemminger
On Mon, 07 Oct 2019 08:40:05 -0700 Jim Harris wrote: > This code was added 7+ years ago: > > commit fb022b85bae4 ("timer: check TSC reliability") > > presumably when variant TSCs were still somewhat > common? But this code doesn't do anything except print > a warning, and the warning doesn't g

[dpdk-dev] [PATCH v2 RESEND] timer: remove check_tsc_flags()

2019-10-07 Thread Jim Harris
This code was added 7+ years ago: commit fb022b85bae4 ("timer: check TSC reliability") presumably when variant TSCs were still somewhat common? But this code doesn't do anything except print a warning, and the warning doesn't give any kind of advice to the user, so let's just remove it. While t

[dpdk-dev] [PATCH v6 RESEND] eal: add tsc_hz to rte_mem_config

2019-10-07 Thread Jim Harris
This ensures secondary processes never have to calculate the TSC rate themselves, which can be noticeable in VMs that don't have access to arch-specific detection mechanism (such as CPUID leaf 0x15 or MSR 0xCE on x86). Since rte_mem_config is now internal to the rte_eal library, we can add tsc_hz

Re: [dpdk-dev] [RFC 5/8] pdump: add classic BPF filtering

2019-10-07 Thread Stephen Hemminger
On Tue, 8 Oct 2019 01:03:17 +0530 Jerin Jacob wrote: > On Mon, 7 Oct, 2019, 11:03 PM Stephen Hemminger, > wrote: > > > On Mon, 7 Oct 2019 22:37:43 +0530 > > Jerin Jacob wrote: > > > > > On Mon, 7 Oct, 2019, 10:23 PM Stephen Hemminger, < > > step...@networkplumber.org> > > > wrote: > > > >

[dpdk-dev] [dpdk-announce] Register for DPDK Summit North America

2019-10-07 Thread Trishan de Lanerolle
If you would like to catch up on DPDK Userspace EU sessions, video playlist is available here: https://bit.ly/2IsuO9w Stay tuned for a packed agenda at the upcoming DPDK Summit North America on *November 12-13th, Mountain View, California* *https://events.linuxfoundation.org/events/dpdknorthameri

Re: [dpdk-dev] [PATCH 0/8] eBPF arm64 JIT support

2019-10-07 Thread Thomas Monjalon
07/10/2019 21:29, Jerin Jacob: > On Mon, 7 Oct, 2019, 11:35 PM Thomas Monjalon, wrote: [...] > let's restart from the beginning by answering simple questions: > > - what are the use cases of BPF in DPDK? > > If something needs to be dynamically controlled then eBPF can be used, > couple of use c

Re: [dpdk-dev] 18.11.3 (LTS) patches review and test

2019-10-07 Thread Ju-Hyoung Lee
+@Abhishek Marathe -Original Message- From: Thinh Tran Sent: Monday, October 7, 2019 1:01 PM To: Kevin Traynor ; sta...@dpdk.org Cc: dev@dpdk.org; Akhil Goyal ; Ali Alnubani ; benjamin.wal...@intel.com; David Christensen ; Hemant Agrawal ; Ian Stokes ; Jerin Jacob ; John McNamara ; J

Re: [dpdk-dev] 18.11.3 (LTS) patches review and test

2019-10-07 Thread Thinh Tran
Hi- IBM - DPDK on Power result *Basic PF on Mallanox: No new errors or regressions were seen. *Performance: no degradation compared to 18.11.2 System tested: - IBM Power9 Model 8335-101 CPU: 2.3 (pvr 004e 1203) Tested NICs: - Mellanox Technologies MT28800 Family [ConnectX-5 Ex] - firmware ve

[dpdk-dev] [PATCH] net/bnxt: fix a check in rxq start op

2019-10-07 Thread Ajit Khaparde
From: Kalesh AP This patch fixes a wrong check in rxq start operation. Driver should check for rxq start state. Fixes: 4316e043cbcb ("net/bnxt: fix RxQ stop/start handling") Signed-off-by: Kalesh AP Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_ring.c | 2 +- 1 file changed, 1 insertio

Re: [dpdk-dev] [RFC 5/8] pdump: add classic BPF filtering

2019-10-07 Thread Jerin Jacob
On Mon, 7 Oct, 2019, 11:03 PM Stephen Hemminger, wrote: > On Mon, 7 Oct 2019 22:37:43 +0530 > Jerin Jacob wrote: > > > On Mon, 7 Oct, 2019, 10:23 PM Stephen Hemminger, < > step...@networkplumber.org> > > wrote: > > > > > Simple classic BPF interpreter based off of libpcap. > > > > > > This is a

Re: [dpdk-dev] [PATCH 0/8] eBPF arm64 JIT support

2019-10-07 Thread Jerin Jacob
On Mon, 7 Oct, 2019, 11:35 PM Thomas Monjalon, wrote: > 07/10/2019 15:00, Jerin Jacob: > > On Mon, 7 Oct, 2019, 6:03 PM Thomas Monjalon wrote: > > > 04/10/2019 17:39, Jerin Jacob: > > > > On Thu, Oct 3, 2019 at 8:35 PM Ananyev, Konstantin wrote: > > > > > > On Thu, Oct 3, 2019 at 6:21 PM Thomas M

Re: [dpdk-dev] [PATCH 5/5] app/test-bbdev: enable fpga_lte_fec support in shared builds

2019-10-07 Thread Chautru, Nicolas
> -Original Message- > From: Richardson, Bruce > Sent: Friday, October 4, 2019 10:19 AM > To: dev@dpdk.org; Chautru, Nicolas > Cc: Akhil Goyal ; Andrzej Ostruszka ; > Richardson, Bruce > Subject: [PATCH 5/5] app/test-bbdev: enable fpga_lte_fec support in shared > builds > > Now that t

Re: [dpdk-dev] [PATCH 0/8] eBPF arm64 JIT support

2019-10-07 Thread Thomas Monjalon
07/10/2019 15:00, Jerin Jacob: > On Mon, 7 Oct, 2019, 6:03 PM Thomas Monjalon wrote: > > 04/10/2019 17:39, Jerin Jacob: > > > On Thu, Oct 3, 2019 at 8:35 PM Ananyev, Konstantin wrote: > > > > > On Thu, Oct 3, 2019 at 6:21 PM Thomas Monjalon wrote: > > > > > > 03/09/2019 12:59, jer...@marvell.com: >

Re: [dpdk-dev] [PATCH v2 0/9] bnxt patchset

2019-10-07 Thread Ferruh Yigit
On 10/4/2019 4:48 AM, Ajit Khaparde wrote: > Apart form fixes support for Thor and vector PMD, this patchset > adds support for LRO on Thor based adapters and CoS classification. > Patchset against dpdk-next-net, has been compiled & tested on an > x86_64 system. > > Please apply. > > > Lance Ric

Re: [dpdk-dev] [RFC 5/8] pdump: add classic BPF filtering

2019-10-07 Thread Stephen Hemminger
On Mon, 7 Oct 2019 22:37:43 +0530 Jerin Jacob wrote: > On Mon, 7 Oct, 2019, 10:23 PM Stephen Hemminger, > wrote: > > > Simple classic BPF interpreter based off of libpcap. > > > > This is a copy of the BPF interpreter from libpcap which is > > modified to handle mbuf meta data. The existing pca

Re: [dpdk-dev] [RFC 5/8] pdump: add classic BPF filtering

2019-10-07 Thread Jerin Jacob
On Mon, 7 Oct, 2019, 10:23 PM Stephen Hemminger, wrote: > Simple classic BPF interpreter based off of libpcap. > > This is a copy of the BPF interpreter from libpcap which is > modified to handle mbuf meta data. The existing pcap_offline_filter > does not expose a way to match VLAN tags. Copying

[dpdk-dev] [RFC 8/8] app/capture: add packet capture using pcapng

2019-10-07 Thread Stephen Hemminger
New application (dpdk-capture) with syntax analogous to tshark's dumpcap command. It runs as a secondary process and produces capture output in pcapng format. It does not use DPDK style EAL arguments; instead the flags are meant to be the same as dumpcap. The program depends on libpcap since it u

[dpdk-dev] [RFC 4/8] pdump: stamp packets with current timestamp

2019-10-07 Thread Stephen Hemminger
Put the current cycle count in as timestamp when they are placed in the ring for packet capture. Signed-off-by: Stephen Hemminger --- lib/librte_pdump/rte_pdump.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/librte_pdump/rte_pdump.c b/lib/librte_pdump/rte_pdump.c index 830decef91e2.

[dpdk-dev] [RFC 5/8] pdump: add classic BPF filtering

2019-10-07 Thread Stephen Hemminger
Simple classic BPF interpreter based off of libpcap. This is a copy of the BPF interpreter from libpcap which is modified to handle mbuf meta data. The existing pcap_offline_filter does not expose a way to match VLAN tags. Copying the BPF interpreter also means that rte_pdump still does not have a

[dpdk-dev] [RFC 7/8] pcapng: add new library for writing pcapng files

2019-10-07 Thread Stephen Hemminger
Simple library for formatting pcapng files used by wireshark and other programs. See PCAP next generation file format specification https://github.com/pcapng/pcapng Signed-off-by: Stephen Hemminger --- config/common_base | 6 + lib/Makefile |

[dpdk-dev] [RFC 1/8] pdump: use new pktmbuf copy function

2019-10-07 Thread Stephen Hemminger
The rte_pktmbuf_copy handles varying size mbuf pools correctly. Signed-off-by: Stephen Hemminger --- lib/librte_pdump/rte_pdump.c | 69 +--- 1 file changed, 1 insertion(+), 68 deletions(-) diff --git a/lib/librte_pdump/rte_pdump.c b/lib/librte_pdump/rte_pdump.c i

[dpdk-dev] [RFC 3/8] pdump: tag copied mbuf with port

2019-10-07 Thread Stephen Hemminger
Set the port when packets go into ring, so same ring can be used for multiple ports. Signed-off-by: Stephen Hemminger --- lib/librte_pdump/rte_pdump.c | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/lib/librte_pdump/rte_pdump.c b/lib/librte_pdump/rte_pdump

[dpdk-dev] [RFC 6/8] pdump: add packet header truncation

2019-10-07 Thread Stephen Hemminger
Add support for pcap style header truncation (called snap length). This optimizes packet capture by not copying the whole packet. Since API is already versioned (in previous patch), it is ok to add one new argument for the length. Signed-off-by: Stephen Hemminger --- app/pdump/main.c

[dpdk-dev] [RFC 0/8] Packet Capture enhancements

2019-10-07 Thread Stephen Hemminger
This is a set of patches to provide enhanced capabilities for packet capture. It adds new features to base pdump library (with API versioning); new PCAPNG output formatter and new application which works like dumpcap from Wireshark. Stephen Hemminger (8): pdump: use new pktmbuf copy function p

[dpdk-dev] [RFC 2/8] pdump: use dynamic logtype

2019-10-07 Thread Stephen Hemminger
The logtype USER1 should not be overloaded for library function. Instead use a dynamic log type. Signed-off-by: Stephen Hemminger --- lib/librte_pdump/rte_pdump.c | 68 1 file changed, 38 insertions(+), 30 deletions(-) diff --git a/lib/librte_pdump/rte_pdump

[dpdk-dev] [PATCH v2 10/10] doc: update security cpu process description

2019-10-07 Thread Fan Zhang
This patch updates programmer's guide and release note for newly added security cpu process description. Signed-off-by: Fan Zhang --- doc/guides/cryptodevs/aesni_gcm.rst| 6 ++ doc/guides/cryptodevs/aesni_mb.rst | 7 +++ doc/guides/prog_guide/rte_security.rst | 112 ++

[dpdk-dev] [PATCH v2 09/10] examples/ipsec-secgw: add security cpu_crypto action support

2019-10-07 Thread Fan Zhang
Since ipsec library is added cpu_crypto security action type support, this patch updates ipsec-secgw sample application with added action type "cpu-crypto". The patch also includes a number of test scripts to prove the correctness of the implementation. Signed-off-by: Fan Zhang --- examples/ipse

[dpdk-dev] [PATCH v2 08/10] ipsec: add rte_security cpu_crypto action support

2019-10-07 Thread Fan Zhang
This patch updates the ipsec library to handle the newly introduced RTE_SECURITY_ACTION_TYPE_CPU_CRYPTO action. Signed-off-by: Fan Zhang --- lib/librte_ipsec/crypto.h | 24 +++ lib/librte_ipsec/esp_inb.c | 200 ++-- lib/librte_ipsec/esp_outb.c | 369 ++

[dpdk-dev] [PATCH v2 07/10] app/test: add aesni_mb security cpu crypto perftest

2019-10-07 Thread Fan Zhang
Since crypto perf application does not support rte_security, this patch adds a simple AES-CBC-SHA1-HMAC CPU crypto performance test to crypto unittest application. The test includes different key and data sizes test with single buffer test items and will display the throughput as well as cycle coun

[dpdk-dev] [PATCH v2 06/10] app/test: add aesni_mb security cpu crypto autotest

2019-10-07 Thread Fan Zhang
This patch adds cpu crypto unit test for AESNI_MB PMD. Signed-off-by: Fan Zhang --- app/test/test_security_cpu_crypto.c | 371 +++- 1 file changed, 369 insertions(+), 2 deletions(-) diff --git a/app/test/test_security_cpu_crypto.c b/app/test/test_security_cpu_cr

[dpdk-dev] [PATCH v2 05/10] crypto/aesni_mb: add rte_security handler

2019-10-07 Thread Fan Zhang
This patch add rte_security support support to AESNI-MB PMD. The PMD now initialize security context instance, create/delete PMD specific security sessions, and process crypto workloads in synchronous mode. Signed-off-by: Fan Zhang --- drivers/crypto/aesni_mb/meson.build| 2 +-

[dpdk-dev] [PATCH v2 04/10] app/test: add security cpu crypto perftest

2019-10-07 Thread Fan Zhang
Since crypto perf application does not support rte_security, this patch adds a simple GCM CPU crypto performance test to crypto unittest application. The test includes different key and data sizes test with single buffer and SGL buffer test items and will display the throughput as well as cycle cou

[dpdk-dev] [PATCH v2 01/10] security: introduce CPU Crypto action type and API

2019-10-07 Thread Fan Zhang
This patch introduce new RTE_SECURITY_ACTION_TYPE_CPU_CRYPTO action type to security library. The type represents performing crypto operation with CPU cycles. The patch also includes a new API to process crypto operations in bulk and the function pointers for PMDs. Signed-off-by: Fan Zhang --- l

[dpdk-dev] [PATCH v2 02/10] crypto/aesni_gcm: add rte_security handler

2019-10-07 Thread Fan Zhang
This patch add rte_security support support to AESNI-GCM PMD. The PMD now initialize security context instance, create/delete PMD specific security sessions, and process crypto workloads in synchronous mode with scatter-gather list buffer supported. Signed-off-by: Fan Zhang --- drivers/crypto/ae

[dpdk-dev] [PATCH v2 00/10] security: add software synchronous crypto process

2019-10-07 Thread Fan Zhang
This RFC patch adds a way to rte_security to process symmetric crypto workload in bulk synchronously for SW crypto devices. Originally both SW and HW crypto PMDs works under rte_cryptodev to process the crypto workload asynchronously. This way provides uniformity to both PMD types but also introdu

[dpdk-dev] [PATCH v2 03/10] app/test: add security cpu crypto autotest

2019-10-07 Thread Fan Zhang
This patch adds cpu crypto unit test for AESNI_GCM PMD. Signed-off-by: Fan Zhang --- app/test/Makefile | 1 + app/test/meson.build| 1 + app/test/test_security_cpu_crypto.c | 564 3 files changed, 566 insertions(+) creat

Re: [dpdk-dev] [PATCH v2 2/2] build: support building ABI versioned files twice

2019-10-07 Thread Bruce Richardson
On Tue, Oct 01, 2019 at 05:53:05PM +0100, Bruce Richardson wrote: > On Tue, Oct 01, 2019 at 03:23:47PM +0200, Andrzej Ostruszka wrote: > > Thanks Bruce for the patch. I like the idea of splitting versioning out > > of rte_compat.h, but I have some comments. > > > > On 9/27/19 10:59 PM, Bruce Rich

[dpdk-dev] [PATCH v3 2/2] build: support building ABI versioned files twice

2019-10-07 Thread Bruce Richardson
Any file with ABI versioned functions needs different macros for shared and static builds, so we need to accomodate that. Rather than building everything twice, we just flag to the build system which libraries need that handling, by setting use_function_versioning in the meson.build files. To ensu

[dpdk-dev] [PATCH v3 1/2] eal: split compat header file

2019-10-07 Thread Bruce Richardson
The compat.h header file provided macros for two purposes: 1. it provided the macros for marking functions as rte_experimental 2. it provided the macros for doing function versioning Although these were in the same file, #1 is something that is for use by public header files, which #2 is for inter

[dpdk-dev] [PATCH v3 0/2] Improve function versioning meson support

2019-10-07 Thread Bruce Richardson
Adding support for LTO has exposed some issues with how the functions versioning was supported by meson, which was always set to build both shared and static libraries. For plain C code, so long as the -fPIC compiler flag was passed, the output is identical whether or not the code is to be include

[dpdk-dev] [PATCH v5 3/5] mbuf: deinline rte_pktmbuf_clone

2019-10-07 Thread Stephen Hemminger
Cloning mbufs requires allocations and iteration and therefore should not be an inline. Signed-off-by: Stephen Hemminger Acked-by: Andrew Rybchenko --- lib/librte_mbuf/rte_mbuf.c | 39 lib/librte_mbuf/rte_mbuf.h | 38 ++-

[dpdk-dev] [PATCH v5 4/5] mbuf: add a pktmbuf copy routine

2019-10-07 Thread Stephen Hemminger
This is a commonly used operation that surprisingly the DPDK has not supported. The new rte_pktmbuf_copy does a deep copy of packet. This is a complete copy including meta-data. It handles the case where the source mbuf comes from a pool with larger data area than the destination pool. The routine

[dpdk-dev] [PATCH v5 2/5] mbuf: delinline rte_pktmbuf_linearize

2019-10-07 Thread Stephen Hemminger
This copy part of this function is too big to be put inline. The places it is used are only in special exception paths where a highly fragmented mbuf arrives at a device that can't handle it. Signed-off-by: Stephen Hemminger Acked-by: Andrew Rybchenko --- lib/librte_mbuf/rte_mbuf.c |

[dpdk-dev] [PATCH v5 5/5] mbuf: add pktmbuf copy test

2019-10-07 Thread Stephen Hemminger
New test for rte_pktmbuf_copy based of the clone tests. Signed-off-by: Stephen Hemminger --- app/test/test_mbuf.c | 126 +++ 1 file changed, 126 insertions(+) diff --git a/app/test/test_mbuf.c b/app/test/test_mbuf.c index aafad0cf6206..49c3a5f7893c 100644

[dpdk-dev] [PATCH v5 1/5] mbuf: don't generate invalid mbuf in clone test

2019-10-07 Thread Stephen Hemminger
The test for cloning changed mbuf would generate an mbuf whose length and segments were invalid. This would cause a crash if test was run with mbuf debugging enabled. Fixes: f1022aba76a5 ("app/test: rename mbuf variable") Signed-off-by: Stephen Hemminger --- app/test/test_mbuf.c | 3 +++ 1 file

[dpdk-dev] [PATCH v5 0/5] mbuf copy/cloning enhancements

2019-10-07 Thread Stephen Hemminger
This patch set is all about improving the mbuf related cloning and copying. They are motivated by seeing issues with mbuf copying in rte_pdump and realized this a wider and more general problem. The pdump copy could not handle different size pools and did not handle meta data, etc. They cause no f

Re: [dpdk-dev] [PATCH] service: improve service run performance

2019-10-07 Thread Van Haaren, Harry
> -Original Message- > From: David Marchand [mailto:david.march...@redhat.com] > Sent: Monday, October 7, 2019 3:53 PM > To: Van Haaren, Harry > Cc: dev ; Rao, Nikhil > Subject: Re: [dpdk-dev] [PATCH] service: improve service run performance > > On Mon, Sep 16, 2019 at 12:01 PM Nikhil Ra

Re: [dpdk-dev] [RFC v3] net/memif: allow for full key size in socket name

2019-10-07 Thread Ferruh Yigit
On 10/7/2019 10:01 AM, Jakub Grajciar -X (jgrajcia - PANTHEON TECHNOLOGIES at Cisco) wrote: > > Hi Ferruh, > >> Hi Jakub, >> >> While testing your zero-copy patch [1], I stuck to a bind() error [2]. >> When provided a socket length bigger than "sizeof(struct sockaddr)", bind() >> fails. I am test

Re: [dpdk-dev] [PATCH] service: improve service run performance

2019-10-07 Thread David Marchand
On Mon, Sep 16, 2019 at 12:01 PM Nikhil Rao wrote: > > For a valid service, the core mask of the service > is checked against the current core and the corresponding > entry in the active_on_lcore array is set or reset. > > Upto 8 cores share the same cache line for their > service active_on_lcore

Re: [dpdk-dev] [PATCH] service: improve service run performance

2019-10-07 Thread Eads, Gage
> For a valid service, the core mask of the service > is checked against the current core and the corresponding > entry in the active_on_lcore array is set or reset. > Upto 8 cores share the same cache line for their > service active_on_lcore array entries since each entry is a uint8_t. > Some num

[dpdk-dev] [PATCH v2 0/4] synchronise meson warnings with make

2019-10-07 Thread Bruce Richardson
The warnings used when building DPDK with make were stricter than those used with meson, so this patchset aligns the two as far as is possible, while also adding in -Wextra as a general compile flag. The one difference is that with "make" we allow different flags for GCC and clang, while with meso

[dpdk-dev] [PATCH v2 3/4] build: enable extra warnings for meson build

2019-10-07 Thread Bruce Richardson
While meson always adds -Wall flag to C compiles, the make build adds extra warning flags that are not present in the meson build. This addresses that shortcoming by adding additional warning flags to our builds. The one omission is the -Wcast-align flag, which though present in make gcc builds, gi

[dpdk-dev] [PATCH v2 4/4] drivers: remove duplicated compiler flags

2019-10-07 Thread Bruce Richardson
Now that -Wextra, and other warning flags are standard in the build, remove any duplication in driver build specifications. Signed-off-by: Bruce Richardson Acked-by: Luca Boccassi --- drivers/net/fm10k/base/meson.build | 2 +- drivers/net/mlx4/meson.build| 1 - drivers/net/mlx5/meson.b

[dpdk-dev] [PATCH v2 2/4] raw/ifpga: remove unneeded compiler flags

2019-10-07 Thread Bruce Richardson
The warning disable flags for the base driver code were copy-pasted from another source, and are actually unnecessary for this driver. Therefore remove them. Signed-off-by: Bruce Richardson Acked-by: Luca Boccassi --- drivers/raw/ifpga/base/meson.build | 11 --- 1 file changed, 11 delet

[dpdk-dev] [PATCH v2 1/4] build: allow compile with stricter fallthrough warnings

2019-10-07 Thread Bruce Richardson
DPDK currently compiles with implicit-fallthrough=2 warning level. With gcc -Wextra flag, the default level is 3, so some minor changes are needed to support this in DPDK. Signed-off-by: Bruce Richardson Acked-by: Luca Boccassi --- drivers/net/bonding/rte_eth_bond_pmd.c | 3 ++- drivers/net/fm1

Re: [dpdk-dev] [PATCH 19.11 0/4] synchronise meson warnings with make

2019-10-07 Thread Luca Boccassi
On Thu, 2019-07-25 at 15:38 +0100, Bruce Richardson wrote: > The warnings used when building DPDK with make were stricter than > those > used with meson, so this patchset aligns the two as far as is > possible, > while also adding in -Wextra as a general compile flag. > > The one difference is tha

Re: [dpdk-dev] [PATCH 4/7] test/rcu: use size_t instead of int

2019-10-07 Thread David Marchand
Hello Honnappa, On Mon, Sep 9, 2019 at 5:17 PM Ruifeng Wang (Arm Technology China) wrote: > > > > -Original Message- > > From: dev On Behalf Of Honnappa Nagarahalli > > Sent: Monday, September 9, 2019 06:50 > > To: Honnappa Nagarahalli ; > > konstantin.anan...@intel.com > > Cc: dev@dpdk.

[dpdk-dev] [PATCH] net/mlx5: fix vport id translation for LAG configuration

2019-10-07 Thread Viacheslav Ovsiienko
The vport id value was taken from wrong field. Fixes: a6282bb1f8f4 ("net/mlx5: update source and destination vport translations") Signed-off-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5_flow_dv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_fl

[dpdk-dev] [PATCH] net/mlx5: fix direct call to rdma-core library

2019-10-07 Thread Viacheslav Ovsiienko
The routine mlx5dv_query_devx_port() was called directly instead of using the mlx5 glue thunk. Fixes: f8c2c1e2ac93 ("net/mlx5: query vport index match mode and parameters") Signed-off-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5.c | 2 +- drivers/net/mlx5/mlx5_glue.c | 17 ++

[dpdk-dev] [PATCH] net/mlx5: fix device scan within switch domain

2019-10-07 Thread Viacheslav Ovsiienko
In LAG configuration the devices in the same switch domain might be spawned on the base of different PCI devices, so we should check all devices backed by mlx5 PMD whether they belong to specified switch domain. When the new devices are being created it is not possible to detect whether the sibling

[dpdk-dev] [PATCH] net/mlx5: fix port id action domain check

2019-10-07 Thread Viacheslav Ovsiienko
The validating routines flow_dv_validate_action_port_id() and flow_dv_validate_item_port_id() could return the positive or ever zero value in case of domains mismatch and the validation routine missed the rules for ports belonging to different switching domains. Fixes: 812909392b52 ("net/mlx5: ela

Re: [dpdk-dev] [PATCH v2 0/6] lib/ring: templates to support custom element size

2019-10-07 Thread David Marchand
On Fri, Sep 6, 2019 at 9:05 PM Honnappa Nagarahalli wrote: > > The current rte_ring hard-codes the type of the ring element to 'void *', > hence the size of the element is hard-coded to 32b/64b. Since the ring > element type is not an input to rte_ring APIs, it results in couple > of issues: > > 1

Re: [dpdk-dev] [PATCH v3 2/3] lib/rcu: add resource reclamation APIs

2019-10-07 Thread Medvedkin, Vladimir
Hi Honnappa, On 01/10/2019 07:29, Honnappa Nagarahalli wrote: Add resource reclamation APIs to make it simple for applications and libraries to integrate rte_rcu library. Signed-off-by: Honnappa Nagarahalli Reviewed-by: Ola Liljedhal Reviewed-by: Ruifeng Wang --- app/test/test_rcu_qsbr.c

Re: [dpdk-dev] [PATCH v8 04/10] vhost: add two new messages to support a shared buffer

2019-10-07 Thread Adrian Moreno
On 9/27/19 12:56 PM, Jin Yu wrote: > This patch introduces two new messages VHOST_USER_GET_INFLIGHT_FD > and VHOST_USER_SET_INFLIGHT_FD to support transferring a shared > buffer between qemu and backend. > > Signed-off-by: Lin Li > Signed-off-by: Xun Ni > Signed-off-by: Yu Zhang > Signed-off-by

[dpdk-dev] [PATCH v6 2/4] examples/ipsec-secgw: add fallback session feature

2019-10-07 Thread Marcin Smoczynski
Inline processing is limited to a specified subset of traffic. It is often unable to handle more complicated situations, such as fragmented traffic. When using inline processing such traffic is dropped. Introduce fallback session for inline processing allowing processing packets that normally woul

[dpdk-dev] [PATCH v6 4/4] examples/ipsec-secgw: add offload fallback tests

2019-10-07 Thread Marcin Smoczynski
Add tests for offload fallback feature; add inbound config modificator SGW_CFG_XPRM_IN (offload fallback setting can be set only for inbound SAs). Tests are using cryptodev for outbound SA. To test fragmentation with QAT set: MULTI_SEG_TEST="--reassemble=4096 --cryptodev_mask=0x" Acked-by: Ko

[dpdk-dev] [PATCH v6 3/4] examples/ipsec-secgw: add frag TTL cmdline option

2019-10-07 Thread Marcin Smoczynski
Due to fragment loss on highly saturated links and long fragment lifetime, ipsec-secgw application quickly runs out of free reassembly buckets. As a result new fragments are being dropped. Introduce --frag-ttl option which allow user to lower default fragment lifitime which solves problem of satur

[dpdk-dev] [PATCH v6 1/4] examples/ipsec-secgw: sa structure cleanup

2019-10-07 Thread Marcin Smoczynski
Cleanup ipsec_sa structure by removing every field that is already in the rte_ipsec_session structure: * cryptodev/security session union * action type * offload flags * security context References to abovementioned fields are changed to direct references to matching fields of rte_ipsec_session

[dpdk-dev] [PATCH v6 0/4] add fallback session

2019-10-07 Thread Marcin Smoczynski
Add fallback session feature allowing to process packets that inline processor is unable to handle (e.g. fragmented traffic). Processing takes place in a secondary session defined for SA in a configuration file. This feature is limited to ingress IPsec traffic only. IPsec anti-replay window and ES

Re: [dpdk-dev] [PATCH 0/8] eBPF arm64 JIT support

2019-10-07 Thread Jerin Jacob
On Mon, 7 Oct, 2019, 6:03 PM Thomas Monjalon, wrote: > 04/10/2019 17:39, Jerin Jacob: > > On Thu, Oct 3, 2019 at 8:35 PM Ananyev, Konstantin > > wrote: > > > > > > Hi everyone, > > > > > > > > > > > On Thu, Oct 3, 2019 at 6:21 PM Thomas Monjalon > wrote: > > > > > > > > > > 03/09/2019 12:59, je

Re: [dpdk-dev] [RFC PATCH 1/9] security: introduce CPU Crypto action type and API

2019-10-07 Thread Ananyev, Konstantin
Hi Akhil, > > > > > > > > > > > > > > > This action type allows the burst of symmetric > > > > > > > > > > > > > > > crypto > > > > workload > > > > > > using > > > > > > > > > the > > > > > > > > > > > > > same > > > > > > > > > > > > > > > algorithm, key, and direction being processed by > >

Re: [dpdk-dev] [PATCH v2 0/3] net/atlantic: Atlantic PMD updates

2019-10-07 Thread Ferruh Yigit
On 9/20/2019 5:21 PM, Pavel Belous wrote: > From: Pavel Belous > > This patchset provides the various fixes for Atlantic Driver. > > v2 changes: > - compile errors on some environments fixed > > Pavel Belous (3): > net/atlantic: exclude MACSEC counters from xstats > net/atlantic: fix report

  1   2   >