Re: [dpdk-dev] [PATCH] net/mlx5: fix compilation issue with gcc pragma

2019-10-01 Thread Slava Ovsiienko
> -Original Message- > From: dev On Behalf Of Slava Ovsiienko > Sent: Wednesday, October 2, 2019 9:15 > To: Stephen Hemminger > Cc: dev@dpdk.org; Matan Azrad ; Raslan > Darawsheh ; ferruh.yi...@intel.com > Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix compilation issue with gcc > pragma >

Re: [dpdk-dev] [PATCH] net/mlx5: fix compilation issue with gcc pragma

2019-10-01 Thread Slava Ovsiienko
> -Original Message- > From: Stephen Hemminger > Sent: Wednesday, October 2, 2019 2:41 > To: Slava Ovsiienko > Cc: dev@dpdk.org; Matan Azrad ; Raslan > Darawsheh ; ferruh.yi...@intel.com > Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix compilation issue with gcc > pragma > > On Tue, 1 Oct

[dpdk-dev] [PATCH v2] net/mlx5: fix compilation issue with gcc pragma

2019-10-01 Thread Viacheslav Ovsiienko
The GCC compiler might generate warning or error if format parameter of fscanf is not literal. This was suppressed with GCC specific pragms. Some compilers (i.e Intel icc) do not recognize GCC diagnostic pragma. The code was refactored with stringification, pragmas are not needed anymore. Fixes: a

[dpdk-dev] [PATCH v2 17/17] net/bnxt: use macro for getting default vnic

2019-10-01 Thread Ajit Khaparde
From: Kalesh AP Minor code cleanup. BNXT_GET_DEFAULT_VNIC macro returns the default VNIC of the function and fixed code to use the macro. Signed-off-by: Kalesh AP Reviewed-by: Somnath Kotur Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_ethdev.c | 10 +- 1 file changed, 5 inser

[dpdk-dev] [PATCH v2 16/17] net/bnxt: support for QinQ insertion and stripping

2019-10-01 Thread Ajit Khaparde
From: Somnath Kotur Driver will accelerate only outer/S-VLAN insertion by turning on the appropriate bits in the Tx Buffer Descriptor when the packet arrives for transmission. The TPID to be used for this S-VLAN is conveyed by the vlan_tpid_set dev_op which will terminate in the driver. In the Rx

[dpdk-dev] [PATCH v2 14/17] net/bnxt: fix mbuf flags for PTP packets in vector mode Rx

2019-10-01 Thread Ajit Khaparde
From: Kalesh AP PKT_RX_IEEE1588_PTP and PKT_RX_IEEE1588_TMST flags need to be set in the offload flags for the received pkt in case of PTP offload. Fixes: bc4a000f2f53c ("net/bnxt: implement SSE vector mode") Cc: sta...@dpdk.org Signed-off-by: Kalesh AP Reviewed-by: Somnath Kotur Reviewed-by:

[dpdk-dev] [PATCH v2 12/17] net/bnxt: fix accessing variable before null check

2019-10-01 Thread Ajit Khaparde
From: Kalesh AP Check input argument "rxq" in bnxt_rx_queue_release_mbufs(), to be sure variable is not NULL before accessing it. Fixes: 9b63c6fd70e3 ("net/bnxt: support Rx/Tx queue start/stop") Cc: sta...@dpdk.org Signed-off-by: Kalesh AP Reviewed-by: Santoshkumar Karanappa Rastapur Reviewed-

[dpdk-dev] [PATCH v2 09/17] net/bnxt: remove unnecessary return check

2019-10-01 Thread Ajit Khaparde
From: Kalesh AP HWRM_CHECK_RESULT_SILENT() returns if the HWRM command fails. There is no need to check the return value after this call. Signed-off-by: Kalesh AP Reviewed-by: Lance Richardson Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_hwrm.c | 119 +--

[dpdk-dev] [PATCH v2 11/17] net/bnxt: remove unnecessary interrupt disable

2019-10-01 Thread Ajit Khaparde
From: Kalesh AP Since bnxt_enable_int() is called at start time, invoke bnxt_disable_int() during stop only. Remove it from device uninit function. Signed-off-by: Kalesh AP Reviewed-by: Lance Richardson Reviewed-by: Ajit Khaparde Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_ethdev

[dpdk-dev] [PATCH v2 10/17] net/bnxt: remove unused macro

2019-10-01 Thread Ajit Khaparde
From: Kalesh AP remove MAX_NUM_MAC_ADDR macro Signed-off-by: Kalesh AP Reviewed-by: Lance Richardson Reviewed-by: Ajit Khaparde Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/bnxt/bnxt.h b/drivers/net/bnxt/bnxt.h index

[dpdk-dev] [PATCH v2 13/17] net/bnxt: fix Rx queue count devop

2019-10-01 Thread Ajit Khaparde
From: Rahul Gupta Fix Computing of number of used descriptors in an Rx queue. Fixes: 1b7ceba3e375 ("net/bnxt: support Rx queue count") Cc: sta...@dpdk.org Signed-off-by: Rahul Gupta Reviewed-by: Ajit Khaparde Reviewed-by: Somnath Kotur Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_

[dpdk-dev] [PATCH v2 15/17] net/bnxt: fix a segfault in secondary process

2019-10-01 Thread Ajit Khaparde
From: Stephen Hemminger The secondary process should not modify device state when init is called. The pci device information pointed to by dev_private pointer is not correct in secondary process. Fixes: b7778e8a1c00 ("net/bnxt: refactor to properly allocate resources for PF/VF") Cc: sta...@dpdk

[dpdk-dev] [PATCH v2 08/17] net/bnxt: fix use of deferred start of transmit queues

2019-10-01 Thread Ajit Khaparde
From: Kalesh AP Driver should not change "deferred_start" state of the tx queues. It should get the state in queue_setup_op() and use that value. Since the deferred start state was being used in the packet transmit functions to determine whether the queue has been stopped already, introduced a p

[dpdk-dev] [PATCH v2 07/17] net/bnxt: fix L2 context calculation for Thor

2019-10-01 Thread Ajit Khaparde
From: Kalesh AP On Wh+, number of L2 context supported by FW is the sum of number of EM flow count and number of L2 context count returned in HWRM_FUNC_QCFG. This is not true for Thor. Restrict this only for Whitney for now. Fixes: ff9c0ca47e81176 ("net/bnxt: save the number of EM flow count")

[dpdk-dev] [PATCH v2 00/17] bnxt patchset

2019-10-01 Thread Ajit Khaparde
bnxt patchset against dpdk-next-net. This patchset has been rebased and is dependent on "bnxt patchset to support device error recovery" https://patchwork.dpdk.org/project/dpdk/list/?series=6660 Please apply. -- v1->v2: Rebased to the newer dpdk-next-net code base. Ajit Khaparde (2): net/bnxt:

[dpdk-dev] [PATCH v2 06/17] net/bnxt: fix 40G link failure for Thor

2019-10-01 Thread Ajit Khaparde
From: Santoshkumar Karanappa Rastapur Link autonegotiation for 40G is not supported by Thor. Hence speed needs to be forced and autoneg disabled to configure 40G speed. Fixes: f8168ca0e690 ("net/bnxt: support thor controller") Reviewed-by: Ajit Khaparde Signed-off-by: Santoshkumar Karanappa Ras

[dpdk-dev] [PATCH v2 02/17] net/bnxt: fix traffic failure with higher mbuf size

2019-10-01 Thread Ajit Khaparde
From: Santoshkumar Karanappa Rastapur Maximum frame length supported by hw is 9600 bytes. When user launches testpmd with --mbuf-size=9729, we are posting buffer descriptors of size 9601 to the ring. This was causing packets getting discarded. Fixes: daef48efe5e5 ("net/bnxt: support set MTU") Cc

[dpdk-dev] [PATCH v2 03/17] net/bnxt: fix rxq stop/start handling

2019-10-01 Thread Ajit Khaparde
From: Kalesh AP Driver should not change "deferred_start" state of the rx queues. It should get the state in queue_setup_op() and use that value. Since the deferred start state was being used in the packet receive functions to determine whether a stopped rx ring should be polled, introduced a pe

[dpdk-dev] [PATCH v2 05/17] net/bnxt: fix async link handling and update

2019-10-01 Thread Ajit Khaparde
When updating the link because of an async link notification there is no need to set wait_for_completion. At this point the link related information should be available without need to poll. Use rte_eth_linkstatus_set instead of memcpy to ensure atomicity while updating the link status. We force th

[dpdk-dev] [PATCH v2 04/17] net/bnxt: subscribe to link speed change notification

2019-10-01 Thread Ajit Khaparde
We are not subscribing to link speed change notification. This patch addresses that. Signed-off-by: Ajit Khaparde Reviewed-by: Rahul Gupta Reviewed-by: Santoshkumar Karanappa Rastapur Reviewed-by: Kalesh Anakkur Purayil --- drivers/net/bnxt/bnxt_hwrm.c | 1 + drivers/net/bnxt/bnxt_hwrm.h | 2

[dpdk-dev] [PATCH v2 01/17] net/bnxt: fix incorrect flow steering

2019-10-01 Thread Ajit Khaparde
From: Santoshkumar Karanappa Rastapur When user creates a flow similar to an existing flow with just the destination queue change, we delete the old filter and allocate a new one with this destination queue change. We were also allocating a new L2 filter matching the same destination mac resultin

Re: [dpdk-dev] [RFC PATCH v1] regexdev: introduce regexdev subsystem

2019-10-01 Thread Shahaf Shuler
Friday, September 27, 2019 5:46 PM, Jerin Jacob Kollanukkaran: > subsystem > > > -Original Message- > > From: Jerin Jacob Kollanukkaran > > Sent: Tuesday, September 10, 2019 4:33 PM > > To: Shahaf Shuler ; Thomas Monjalon > > ; dev@dpdk.org > > Cc: Pavan Nikhilesh Bhagavatula ; Hemant > >

Re: [dpdk-dev] [PATCH v4 6/6] doc: deprecation notice for VFIO DMA map APIs

2019-10-01 Thread Shahaf Shuler
Hi David, Tuesday, October 1, 2019 6:20 PM, David Marchand: > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v4 6/6] doc: deprecation notice for VFIO > DMA map APIs > > Hello Shahaf, > > On 10/03/2019 09:28, Shahaf Shuler wrote: > > As those should be replaced by rte_dev_dma_map and > rte_dev

Re: [dpdk-dev] [PATCH] vhost: add support to large linear mbufs

2019-10-01 Thread Shahaf Shuler
Wednesday, October 2, 2019 1:20 AM, Flavio Leitner: > Subject: [dpdk-dev] [PATCH] vhost: add support to large linear mbufs > > The rte_vhost_dequeue_burst supports two ways of dequeuing data. If the > data fits into a buffer, then all data is copied and a single linear buffer is > returned. Otherw

Re: [dpdk-dev] [PATCH 2/5] lib/ring: add template to support different element sizes

2019-10-01 Thread Honnappa Nagarahalli
> > Add templates to support creating ring APIs with different ring > > element sizes. > > > > Signed-off-by: Honnappa Nagarahalli > > Reviewed-by: Dharmik Thakkar > > Reviewed-by: Gavin Hu > > Reviewed-by: Ruifeng Wang > > --- > > lib/librte_ring/Makefile| 4 +- > > lib/librte_r

[dpdk-dev] [PATCH v7 7/7] examples: disable Rx packet type parsing

2019-10-01 Thread pbhagavatula
From: Pavan Nikhilesh Disable packet type parsing in examples that don't use `rte_mbuf::packet_type` by setting ptype_mask as 0 in `rte_eth_dev_set_supported_ptypes` Signed-off-by: Pavan Nikhilesh --- examples/bbdev_app/main.c | 1 + examples/bond/main.c

[dpdk-dev] [PATCH v7 6/7] examples/eventdev_pipeline: add new Rx RSS hash offload

2019-10-01 Thread pbhagavatula
From: Pavan Nikhilesh Since pipeline_generic uses `rte_mbuf::hash::rss` add the new Rx offload flag `DEV_RX_OFFLOAD_RSS_HASH` to inform PMD to copy the RSS hash result into the mbuf. Signed-off-by: Pavan Nikhilesh --- examples/eventdev_pipeline/main.c | 113 - .../p

[dpdk-dev] [PATCH v7 4/7] drivers/net: update Rx RSS hash offload capabilities

2019-10-01 Thread pbhagavatula
From: Pavan Nikhilesh Add DEV_RX_OFFLOAD_RSS_HASH flag for all PMDs that support RSS hash delivery. Signed-off-by: Pavan Nikhilesh Reviewed-by: Andrew Rybchenko Reviewed-by: Hemant Agrawal Acked-by: Jerin Jacob Acked-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_ethdev.c | 3 ++- driv

[dpdk-dev] [PATCH v7 5/7] drivers/net: update Rx flow flag and mark capabilities

2019-10-01 Thread pbhagavatula
From: Pavan Nikhilesh Add DEV_RX_OFFLOAD_FLOW_MARK flag for all PMDs that support flow action flag and mark. Signed-off-by: Pavan Nikhilesh Reviewed-by: Andrew Rybchenko --- drivers/net/bnxt/bnxt_ethdev.c | 3 ++- drivers/net/enic/enic_res.c | 3 ++- drivers/net/i40e/i40e

[dpdk-dev] [PATCH v7 1/7] ethdev: add set ptype function

2019-10-01 Thread pbhagavatula
From: Pavan Nikhilesh Add `rte_eth_dev_set_supported_ptypes` function that will allow the application to inform the PMD the packet types it is interested in. Based on the ptypes set PMDs can optimize their Rx path. -If application doesn’t want any ptype information it can call `rte_eth_dev_set_s

[dpdk-dev] [PATCH v5 0/7] ethdev: add new Rx offload flags

2019-10-01 Thread pbhagavatula
From: Pavan Nikhilesh Add new Rx offload flags `DEV_RX_OFFLOAD_RSS_HASH` and `DEV_RX_OFFLOAD_FLOW_MARK`. These flags can be used to enable/disable PMD writes to rte_mbuf fields `hash.rss` and `hash.fdir.hi` and also `ol_flags:PKT_RX_RSS` and `ol_flags:PKT_RX_FDIR`. Add new packet type set functi

[dpdk-dev] [PATCH v7 3/7] ethdev: add flow action type update as an offload

2019-10-01 Thread pbhagavatula
From: Pavan Nikhilesh Add new Rx offload flag `DEV_RX_OFFLOAD_FLOW_MARK` that can be used to enable/disable PMDs write to `rte_mbuf::hash::fdir::hi` and `rte_mbuf::ol_flags` when flow actions `RTE_FLOW_ACTION_MARK` and `RTE_FLOW_ACTION_FLAG` are enabled. PMDs notify the validity of `rte_mbuf::ha

[dpdk-dev] [PATCH v7 2/7] ethdev: add mbuf RSS update as an offload

2019-10-01 Thread pbhagavatula
From: Pavan Nikhilesh Add new Rx offload flag `DEV_RX_OFFLOAD_RSS_HASH` which can be used to enable/disable PMDs write to `rte_mbuf::hash::rss`. PMDs notify the validity of `rte_mbuf::hash:rss` to the applcation by enabling `PKT_RX_RSS_HASH ` flag in `rte_mbuf::ol_flags`. Signed-off-by: Pavan Ni

Re: [dpdk-dev] [PATCH] eventdev: flag to identify same destined packets enqueue

2019-10-01 Thread Hemant Agrawal
Hi Jerin, > On Tue, Oct 1, 2019 at 8:36 PM Nipun Gupta wrote: > > > > > > > > > -Original Message- > > > From: Jerin Jacob > > > Sent: Tuesday, October 1, 2019 7:50 PM > > > To: Nipun Gupta > > > Cc: Jerin Jacob ; dpdk-dev ; Pavan > > > Nikhilesh ; Sunil Kumar Kori > > > ; Hemant Agrawal

Re: [dpdk-dev] [PATCH 01/10] security: introduce CPU Crypto action type and API

2019-10-01 Thread Hemant Agrawal
Hi Konstantin, > > >>> This patch introduce new RTE_SECURITY_ACTION_TYPE_CPU_CRYPTO > > >>> action type to security library. The type represents performing > > >>> crypto operation with CPU cycles. The patch also includes a new > > >>> API to process crypto operations in bulk and the function poin

Re: [dpdk-dev] [PATCH 3/9] net/bnxt: remove logically dead code

2019-10-01 Thread Ajit Khaparde
On Tue, Oct 1, 2019 at 6:04 AM Kevin Traynor wrote: > If rc contains a non-zero return code from bnxt_hwrm_send_message(), > HWRM_CHECK_RESULT_SILENT() will return. > > Just after that code, there is an 'if (!rc) {...} else {...}'. > Coverity is complaining that this if else statement is dead cod

[dpdk-dev] [PATCH v3 15/15] net/bnxt: add PTP support for Thor

2019-10-01 Thread Ajit Khaparde
From: Kalesh AP On Thor, direct access to PTP registers (via GRC) is not supported. Driver must use HWRM to access the timestamp information. Vectorized Rx/Tx cannot be enabled if RTE_LIBRTE_IEEE1588=y. Remove the PTP flags handling code from the vector Rx path. Add support to read tx timestamp

[dpdk-dev] [PATCH v3 14/15] net/bnxt: use BIT macro instead of bit fields

2019-10-01 Thread Ajit Khaparde
From: Kalesh AP use BIT macro instead of bit fields. Signed-off-by: Kalesh AP Reviewed-by: Somnath Kotur Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt.h | 79 ++-- drivers/net/bnxt/bnxt_util.h | 4 ++ 2 files changed, 44 insertions(+), 39 deleti

[dpdk-dev] [PATCH v3 10/15] net/bnxt: add support for FW reset

2019-10-01 Thread Ajit Khaparde
From: Kalesh AP Added code to perform FW_RESET. When the driver detects error in FW, it has to initiate the recovery by resetting the cores. FW advertise the method to do a core reset, reset register offsets and values to perform reset in response of HWRM_ERROR_RECOVERY_QCFG command. There are 2

[dpdk-dev] [PATCH v3 13/15] net/bnxt: avoid null pointer dereference

2019-10-01 Thread Ajit Khaparde
From: Kalesh AP Commit "bd0a14c99f65" enables the creation of a dedicated completion ring for asynchronous event handling instead of handling these events on a receive completion ring on non Stingray Platforms. This causes a segfault due to NULL pointer defreference in bnxt_alloc_async_cp_ring()

[dpdk-dev] [PATCH v3 09/15] net/bnxt: add code for periodic FW health monitoring

2019-10-01 Thread Ajit Khaparde
From: Kalesh AP Periodically poll the FW heartbeat register and FW recovery counter registers to check the FW health. Polling frequency will be advertised by the FW in HWRM_ERROR_RECOVERY_QCFG response. Schedule the task upon receiving the async event from FW. Signed-off-by: Kalesh AP Reviewed-

[dpdk-dev] [PATCH v3 11/15] net/bnxt: add hot firmware upgrade support for Stingray

2019-10-01 Thread Ajit Khaparde
From: Kalesh AP FW sets HWRM_FUNC_QCAPS_OUTPUT_FLAGS_ERR_RECOVER_RELOAD in HWRM_FUNC_QCAPS command, if device requires to invoke fastboot FW during FW reset. Driver has to poll for shutdown bit in fw_status register: 1. in case of hot fw upgrade, this bit will be set after all function driver

[dpdk-dev] [PATCH v3 06/15] net/bnxt: query firmware error recovery capabilities

2019-10-01 Thread Ajit Khaparde
From: Kalesh AP In Driver initiated error recovery process, driver has to know about the registers offset and values to initiate FW reset. The HWRM command HWRM_ERROR_RECOVERY_QCFG is used to obtain all the registers and values required to initiate FW reset. This command response includes FW hear

[dpdk-dev] [PATCH v3 12/15] net/bnxt: reduce verbosity of logs

2019-10-01 Thread Ajit Khaparde
From: Kalesh AP When IOMMU is available, EAL picks IOVA as VA as the default IOVA mode. This causes the bnxt driver to log warning messages saying "Memzone physical address same as virtual." and "Using rte_mem_virt2iova()" during load. Reduce the verbosity of logs to DEBUG. Reduced couple of oth

[dpdk-dev] [PATCH v3 05/15] net/bnxt: handle fatal event from FW under error conditions

2019-10-01 Thread Ajit Khaparde
From: Kalesh AP When firmware hit some unrecoverable error conditions, firmware initiate the recovery by sending an async event EVENT_CMPL_EVENT_ID_RESET_NOTIFY with data1 set to RESET_NOTIFY_EVENT_DATA1_REASON_CODE_FW_EXCEPTION_FATAL to all host drivers and will reset the chip. The recovery pro

[dpdk-dev] [PATCH v3 08/15] net/bnxt: advertise error recovery capability and handle async event

2019-10-01 Thread Ajit Khaparde
From: Kalesh AP 1. Advertise HWRM_FUNC_DRV_RGTR_INPUT_FLAGS_ERROR_RECOVERY_SUPPORT flag in the FUNC_DRV_RGTR command. 2. request for the async event ASYNC_EVENT_CMPL_EVENT_ID_ERROR_RECOVERY in the FUNC_DRV_RGTR command. 3. handle the async event EVENT_ID_ERROR_RECOVERY from FW. Error recov

[dpdk-dev] [PATCH v3 02/15] net/bnxt: prevent device access when device is in reset

2019-10-01 Thread Ajit Khaparde
From: Kalesh AP Refactor init and uninit functions so that the driver can fail the eth_dev_ops callbacks and accessing Tx and Rx queues when device is in reset or in error state. Transmit and receive queues are freed during reset cleanup and reallocated during recovery. So we block all data path

[dpdk-dev] [PATCH v3 07/15] net/bnxt: map status registers for FW health monitoring

2019-10-01 Thread Ajit Khaparde
From: Kalesh AP HWRM_ERROR_RECOVERY_QCFG command returns the FW status registers offset for periodic firmware health check monitoring. Map them to GRC window 2. Signed-off-by: Kalesh AP Reviewed-by: Somnath Kotur Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt.h| 22 ++

[dpdk-dev] [PATCH v3 01/15] net/bnxt: add FW reset HWRM command

2019-10-01 Thread Ajit Khaparde
From: Kalesh AP This patch adds new FW reset HWRM command. Code using this command will be added in future patch. Signed-off-by: Kalesh AP Reviewed-by: Somnath Kotur Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/hsi_struct_def_dpdk.h | 137 + 1 file changed, 137 ins

[dpdk-dev] [PATCH v3 03/15] net/bnxt: handle reset notify async event from FW

2019-10-01 Thread Ajit Khaparde
From: Kalesh AP When the FW upgrade is initiated the current instance of FW issues a HWRM_ASYNC_EVENT_CMPL_EVENT_ID_RESET_NOTIFY async notification to the driver. On receiving this notification, the PMD shall quiesce itself and poll on the HWRM_VER_GET FW command at regular intervals. Once the V

[dpdk-dev] [PATCH v3 04/15] net/bnxt: inform firmware about IF state changes

2019-10-01 Thread Ajit Khaparde
From: Kalesh AP Use latest firmware API to inform firmware about IF state changes. Firmware has the option to clean up resources during IF down and to require the driver to reserve resources again during IF up. During port start, HWRM_FUNC_DRV_IF_CHANGE command response flags indicates that firm

[dpdk-dev] [PATCH v3 00/15] bnxt patchset to support device error recovery

2019-10-01 Thread Ajit Khaparde
This patchset adds support to monitor the health of the firmware and the underlying device and recover to an operational state in case of error. We can also detect if a FW upgrade is in progress and quiesce all access to the device and recover once FW indicates everything is ready. Patchset agains

Re: [dpdk-dev] [PATCH] net/mlx5: fix compilation issue with gcc pragma

2019-10-01 Thread Stephen Hemminger
On Tue, 1 Oct 2019 17:15:46 + Slava Ovsiienko wrote: > > -Original Message- > > From: Stephen Hemminger > > Sent: Tuesday, October 1, 2019 17:54 > > To: Slava Ovsiienko > > Cc: dev@dpdk.org; Matan Azrad ; Raslan > > Darawsheh ; ferruh.yi...@intel.com > > Subject: Re: [dpdk-dev] [PAT

Re: [dpdk-dev] Qn on vlan filtering for promiscuous ports VMXNET3 driver

2019-10-01 Thread Stephen Hemminger
On Tue, 1 Oct 2019 11:43:37 -0700 Geetha Anandakrishnan wrote: > Hi All, > > I am experimenting DPDK with VMXNET3. I see that the vmxnet3 driver code > does not set vlan filtering if port is in promiscuous mode. > I modified the vmxnet3 code to skip the check for promiscuous port, code > below.

Re: [dpdk-dev] [PATCH v3 4/6] mbuf: add a pktmbuf copy routine

2019-10-01 Thread Stephen Hemminger
On Tue, 1 Oct 2019 17:36:10 + Slava Ovsiienko wrote: > Hi, Stephen > > > -Original Message- > > From: dev On Behalf Of Stephen Hemminger > > Sent: Monday, September 30, 2019 22:21 > > To: dev@dpdk.org > > Cc: Stephen Hemminger > > Subject: [dpdk-dev] [PATCH v3 4/6] mbuf: add a pktm

Re: [dpdk-dev] [PATCH] vhost: add support to large linear mbufs

2019-10-01 Thread Flavio Leitner
On Tue, 1 Oct 2019 19:19:35 -0300 Flavio Leitner wrote: > The rte_vhost_dequeue_burst supports two ways of dequeuing data. If > the data fits into a buffer, then all data is copied and a single > linear buffer is returned. Otherwise it allocates additional mbufs > and chains them together to ret

[dpdk-dev] [PATCH] vhost: add support to large linear mbufs

2019-10-01 Thread Flavio Leitner
The rte_vhost_dequeue_burst supports two ways of dequeuing data. If the data fits into a buffer, then all data is copied and a single linear buffer is returned. Otherwise it allocates additional mbufs and chains them together to return a multiple segments mbuf. While that covers most use cases, it

[dpdk-dev] [PATCH v6 7/7] examples: disable Rx packet type parsing

2019-10-01 Thread pbhagavatula
From: Pavan Nikhilesh Disable packet type parsing in examples that don't use `rte_mbuf::packet_type` by setting ptype_mask as 0 in `rte_eth_dev_set_supported_ptypes` Signed-off-by: Pavan Nikhilesh --- examples/bbdev_app/main.c | 1 + examples/bond/main.c

[dpdk-dev] [PATCH v6 5/7] drivers/net: update Rx flow flag and mark capabilities

2019-10-01 Thread pbhagavatula
From: Pavan Nikhilesh Add DEV_RX_OFFLOAD_FLOW_MARK flag for all PMDs that support flow action flag and mark. Signed-off-by: Pavan Nikhilesh Reviewed-by: Andrew Rybchenko --- drivers/net/bnxt/bnxt_ethdev.c | 3 ++- drivers/net/enic/enic_res.c | 3 ++- drivers/net/i40e/i40e

[dpdk-dev] [PATCH v6 6/7] examples/eventdev_pipeline: add new Rx RSS hash offload

2019-10-01 Thread pbhagavatula
From: Pavan Nikhilesh Since pipeline_generic uses `rte_mbuf::hash::rss` add the new Rx offload flag `DEV_RX_OFFLOAD_RSS_HASH` to inform PMD to copy the RSS hash result into the mbuf. Signed-off-by: Pavan Nikhilesh --- examples/eventdev_pipeline/main.c | 113 - .../p

[dpdk-dev] [PATCH v6 2/7] ethdev: add mbuf RSS update as an offload

2019-10-01 Thread pbhagavatula
From: Pavan Nikhilesh Add new Rx offload flag `DEV_RX_OFFLOAD_RSS_HASH` which can be used to enable/disable PMDs write to `rte_mbuf::hash::rss`. PMDs notify the validity of `rte_mbuf::hash:rss` to the applcation by enabling `PKT_RX_RSS_HASH ` flag in `rte_mbuf::ol_flags`. Signed-off-by: Pavan Ni

[dpdk-dev] [PATCH v6 4/7] drivers/net: update Rx RSS hash offload capabilities

2019-10-01 Thread pbhagavatula
From: Pavan Nikhilesh Add DEV_RX_OFFLOAD_RSS_HASH flag for all PMDs that support RSS hash delivery. Signed-off-by: Pavan Nikhilesh Reviewed-by: Andrew Rybchenko Reviewed-by: Hemant Agrawal Acked-by: Jerin Jacob Acked-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_ethdev.c | 3 ++- driv

[dpdk-dev] [PATCH v6 3/7] ethdev: add flow action type update as an offload

2019-10-01 Thread pbhagavatula
From: Pavan Nikhilesh Add new Rx offload flag `DEV_RX_OFFLOAD_FLOW_MARK` that can be used to enable/disable PMDs write to `rte_mbuf::hash::fdir::hi` and `rte_mbuf::ol_flags` when flow actions `RTE_FLOW_ACTION_MARK` and `RTE_FLOW_ACTION_FLAG` are enabled. PMDs notify the validity of `rte_mbuf::ha

[dpdk-dev] [PATCH v6 0/7] ethdev: add new Rx offload flags

2019-10-01 Thread pbhagavatula
From: Pavan Nikhilesh Add new Rx offload flags `DEV_RX_OFFLOAD_RSS_HASH` and `DEV_RX_OFFLOAD_FLOW_MARK`. These flags can be used to enable/disable PMD writes to rte_mbuf fields `hash.rss` and `hash.fdir.hi` and also `ol_flags:PKT_RX_RSS` and `ol_flags:PKT_RX_FDIR`. Add new packet type set functi

[dpdk-dev] [PATCH v6 1/7] ethdev: add set ptype function

2019-10-01 Thread pbhagavatula
From: Pavan Nikhilesh Add `rte_eth_dev_set_supported_ptypes` function that will allow the application to inform the PMD the packet types it is interested in. Based on the ptypes set PMDs can optimize their Rx path. -If application doesn’t want any ptype information it can call `rte_eth_dev_set_s

[dpdk-dev] Qn on vlan filtering for promiscuous ports VMXNET3 driver

2019-10-01 Thread Geetha Anandakrishnan
Hi All, I am experimenting DPDK with VMXNET3. I see that the vmxnet3 driver code does not set vlan filtering if port is in promiscuous mode. I modified the vmxnet3 code to skip the check for promiscuous port, code below. But it does not seem like filtering works with this change, when port is in

[dpdk-dev] [PATCH v3 0/3] RCU integration with LPM library

2019-10-01 Thread Honnappa Nagarahalli
This patch set is dependent on https://patches.dpdk.org/cover/60270/ This patchset integrates RCU QSBR support with LPM library. Please refer to RCU documentation in the above mentioned patch series. This patch set follows the suggested design of integrating RCU library with other libraries in DP

[dpdk-dev] [PATCH v3 2/3] app/test: add test case for LPM RCU integration

2019-10-01 Thread Honnappa Nagarahalli
From: Ruifeng Wang Add positive and negative tests for API rte_lpm_rcu_qsbr_add. Also test LPM library behavior when RCU QSBR is enabled. Signed-off-by: Ruifeng Wang Reviewed-by: Gavin Hu Reviewed-by: Honnappa Nagarahalli --- app/test/test_lpm.c | 152

[dpdk-dev] [PATCH v3 3/3] test/lpm: add RCU integration performance tests

2019-10-01 Thread Honnappa Nagarahalli
Add performance tests for RCU integration. The performance difference with and without RCU integration is very small (~1% to ~2%) on both Arm and x86 platforms. Signed-off-by: Honnappa Nagarahalli Reviewed-by: Gavin Hu Reviewed-by: Ruifeng Wang --- app/test/test_lpm_perf.c | 487 ++

[dpdk-dev] [PATCH v3 1/3] lib/lpm: integrate RCU QSBR

2019-10-01 Thread Honnappa Nagarahalli
From: Ruifeng Wang Currently, the tbl8 group is freed even though the readers might be using the tbl8 group entries. The freed tbl8 group can be reallocated quickly. This results in incorrect lookup results. RCU QSBR process is integrated for safe tbl8 group reclaim. Refer to RCU documentation t

Re: [dpdk-dev] [PATCH v3 4/6] mbuf: add a pktmbuf copy routine

2019-10-01 Thread Slava Ovsiienko
Hi, Stephen > -Original Message- > From: dev On Behalf Of Stephen Hemminger > Sent: Monday, September 30, 2019 22:21 > To: dev@dpdk.org > Cc: Stephen Hemminger > Subject: [dpdk-dev] [PATCH v3 4/6] mbuf: add a pktmbuf copy routine > > This is a commonly used operation that surprisingly t

Re: [dpdk-dev] [PATCH 00/17] bnxt patchset to improve rte flow support

2019-10-01 Thread Ajit Khaparde
Ferruh. Yes. We are working on that already. Thanks On Tue, Oct 1, 2019 at 10:02 AM Ferruh Yigit wrote: > On 9/3/2019 3:18 AM, Ajit Khaparde wrote: > > Among other changes, this patchset adds support to: > > - create filters with RSS action. > > - create source MAC filters. > > - use user provid

Re: [dpdk-dev] [PATCH v2 0/3] examples/ipsec-secgw: set default

2019-10-01 Thread Ananyev, Konstantin
Hi Bernard, > > This patch set, sets the default code path in the ipsec-secgw > application to use the librte_ipsec. > The *_old test scripts have been modified to use the legacy code > path. > > Changes in v2: > - > The error messages for the -l option have been updated. > The pkt

Re: [dpdk-dev] [PATCH v2 3/3] examples/ipsec-secgw: update pktest.sh script

2019-10-01 Thread Ananyev, Konstantin
> -Original Message- > From: Iremonger, Bernard > Sent: Tuesday, October 1, 2019 4:18 PM > To: dev@dpdk.org; Ananyev, Konstantin ; > akhil.go...@nxp.com > Cc: Iremonger, Bernard > Subject: [PATCH v2 3/3] examples/ipsec-secgw: update pktest.sh script > > Drop SGW_CMD_XPRM=l, as default

Re: [dpdk-dev] [PATCH v2 2/3] examples/ipsec-secgw: add -l 0 parameter to old scripts

2019-10-01 Thread Ananyev, Konstantin
> -Original Message- > From: Iremonger, Bernard > Sent: Tuesday, October 1, 2019 4:18 PM > To: dev@dpdk.org; Ananyev, Konstantin ; > akhil.go...@nxp.com > Cc: Iremonger, Bernard > Subject: [PATCH v2 2/3] examples/ipsec-secgw: add -l 0 parameter to old > scripts > > enable legacy mode

Re: [dpdk-dev] [PATCH] doc: fix list of unsupported features for IPsec lib

2019-10-01 Thread Ananyev, Konstantin
> -Original Message- > From: Iremonger, Bernard > Sent: Tuesday, October 1, 2019 5:27 PM > To: Ananyev, Konstantin ; dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH] doc: fix list of unsupported features for > IPsec lib > > Hi Konstantin, > > > -Original Message- > > From: dev [

[dpdk-dev] [PATCH v2 5/5] app: add test-sad application

2019-10-01 Thread Vladimir Medvedkin
Usage example and performance evaluation for the ipsec SAD library Signed-off-by: Vladimir Medvedkin --- app/Makefile | 1 + app/meson.build | 3 +- app/test-sad/Makefile| 18 ++ app/test-sad/main.c | 662 +++ app/tes

[dpdk-dev] [PATCH v2 4/5] test/ipsec: add ipsec SAD autotests

2019-10-01 Thread Vladimir Medvedkin
Signed-off-by: Vladimir Medvedkin --- app/test/Makefile | 1 + app/test/autotest_data.py | 6 + app/test/meson.build | 1 + app/test/test_ipsec_sad.c | 856 ++ 4 files changed, 864 insertions(+) create mode 100644 app/test/test_ipsec

[dpdk-dev] [PATCH v2 3/5] ipsec: add SAD add/delete/lookup implementation

2019-10-01 Thread Vladimir Medvedkin
Replace rte_ipsec_sad_add(), rte_ipsec_sad_del() and rte_ipsec_sad_lookup() stubs with actual implementation. It uses three librte_hash tables each of which contains an entries for a specific SA type (either it is addressed by SPI only or SPI+DIP or SPI+DIP+SIP) Signed-off-by: Vladimir Medvedkin

[dpdk-dev] [PATCH v2 1/5] ipsec: add inbound SAD API

2019-10-01 Thread Vladimir Medvedkin
Add inbound security association database (SAD) API and stub implementation. Signed-off-by: Vladimir Medvedkin --- lib/librte_ipsec/Makefile | 2 + lib/librte_ipsec/ipsec_sad.c | 50 ++ lib/librte_ipsec/meson.build | 4 +- lib/librte_ipsec/rte_ipsec_

[dpdk-dev] [PATCH v2 2/5] ipsec: add SAD create/destroy implementation

2019-10-01 Thread Vladimir Medvedkin
Replace rte_ipsec_sad_create(), rte_ipsec_sad_destroy() and rte_ipsec_sad_find_existing() API stubs with actual implementation. Signed-off-by: Vladimir Medvedkin --- lib/librte_ipsec/Makefile| 2 +- lib/librte_ipsec/ipsec_sad.c | 233 +-- lib/librte_

[dpdk-dev] [PATCH v2 0/5] ipsec: add inbound SAD

2019-10-01 Thread Vladimir Medvedkin
According to RFC 4301 IPSec implementation needs an inbound SA database (SAD). For each incoming inbound IPSec-protected packet (ESP or AH) it has to perform a lookup within it’s SAD. Lookup should be performed by: Security Parameters Index (SPI) + destination IP (DIP) + source IP (SIP) or SPI +

Re: [dpdk-dev] [PATCH v1 3/5] ipsec: add SAD add/delete/lookup implementation

2019-10-01 Thread Medvedkin, Vladimir
Hi Konstantin, On 12/09/2019 18:58, Ananyev, Konstantin wrote: Hi Vladimir, Replace rte_ipsec_sad_add(), rte_ipsec_sad_del() and rte_ipsec_sad_lookup() stubs with actual implementation. It uses three librte_hash tables each of which contains an entries for a specific SA type (either it is add

Re: [dpdk-dev] [PATCH] net/mlx5: fix compilation issue with gcc pragma

2019-10-01 Thread Slava Ovsiienko
> -Original Message- > From: Stephen Hemminger > Sent: Tuesday, October 1, 2019 17:54 > To: Slava Ovsiienko > Cc: dev@dpdk.org; Matan Azrad ; Raslan > Darawsheh ; ferruh.yi...@intel.com > Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix compilation issue with gcc > pragma > > On Tue, 1 Oct

Re: [dpdk-dev] [PATCH v5 09/12] test/fib: add FIB library autotests

2019-10-01 Thread Medvedkin, Vladimir
Hi Aaron, On 12/09/2019 15:07, Aaron Conole wrote: Vladimir Medvedkin writes: Functional tests for the new FIB library. Signed-off-by: Vladimir Medvedkin --- app/test/Makefile | 1 + app/test/autotest_data.py | 6 + app/test/meson.build | 3 + app/test/test_fib.c

Re: [dpdk-dev] [PATCH 00/17] bnxt patchset to improve rte flow support

2019-10-01 Thread Ferruh Yigit
On 9/3/2019 3:18 AM, Ajit Khaparde wrote: > Among other changes, this patchset adds support to: > - create filters with RSS action. > - create source MAC filters. > - use user provided priority to place rule appropriately in HW. > > This series is dependent on the series "bnxt patchset" submitted

Re: [dpdk-dev] [PATCH v2 2/2] build: support building ABI versioned files twice

2019-10-01 Thread Bruce Richardson
On Tue, Oct 01, 2019 at 03:23:47PM +0200, Andrzej Ostruszka wrote: > Thanks Bruce for the patch. I like the idea of splitting versioning out > of rte_compat.h, but I have some comments. > > On 9/27/19 10:59 PM, Bruce Richardson wrote: > [...] > > --- a/config/common_base > > +++ b/config/common_b

Re: [dpdk-dev] [PATCH v8 2/3] ethdev: extend RSS offload types

2019-10-01 Thread Ferruh Yigit
On 10/1/2019 5:02 PM, Iremonger, Bernard wrote: > Hi Simei, > >> -Original Message- >> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Andrew Rybchenko >> Sent: Tuesday, October 1, 2019 3:49 PM >> To: Su, Simei ; Zhang, Qi Z ; Ye, >> Xiaolong ; Yigit, Ferruh >> Cc: dev@dpdk.org >> Su

Re: [dpdk-dev] [PATCH 1/3] net/virtio: reject deferred start Rx queue setup

2019-10-01 Thread Andrew Rybchenko
Hi Kevin, On 10/1/19 7:29 PM, Kevin Traynor wrote: Hi, On 01/10/2019 16:44, Andrew Rybchenko wrote: From: Dilshod Urazov Deferred start Rx queue is not supported by the driver. Fixes: 0748be2cf9a2 ("ethdev: queue start and stop") Cc: sta...@dpdk.org Signed-off-by: Dilshod Urazov Signed-of

Re: [dpdk-dev] [PATCH 1/3] net/virtio: reject deferred start Rx queue setup

2019-10-01 Thread Kevin Traynor
Hi, On 01/10/2019 16:44, Andrew Rybchenko wrote: > From: Dilshod Urazov > > Deferred start Rx queue is not supported by the driver. > > Fixes: 0748be2cf9a2 ("ethdev: queue start and stop") > Cc: sta...@dpdk.org > > Signed-off-by: Dilshod Urazov > Signed-off-by: Andrew Rybchenko > --- > driv

Re: [dpdk-dev] [PATCH] doc: fix list of unsupported features for IPsec lib

2019-10-01 Thread Iremonger, Bernard
Hi Konstantin, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Konstantin > Ananyev > Sent: Friday, September 27, 2019 3:21 PM > To: dev@dpdk.org > Cc: Ananyev, Konstantin > Subject: [dpdk-dev] [PATCH] doc: fix list of unsupported features for IPsec > lib > >

Re: [dpdk-dev] [PATCH] net/null: fix multi-process rx and tx

2019-10-01 Thread Ferruh Yigit
On 10/1/2019 5:00 PM, Ferruh Yigit wrote: > On 9/29/2019 3:41 AM, Yasufumi Ogawa wrote: >> Packet processing in secondary process cannot work because rx_pkt_burst >> and tx_pkt_burst in eth_dev are not initialized while probing device. >> This patch is to the initialization. >> >> Signed-off-by: Ya

Re: [dpdk-dev] [PATCH v8 2/3] ethdev: extend RSS offload types

2019-10-01 Thread Iremonger, Bernard
Hi Simei, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Andrew Rybchenko > Sent: Tuesday, October 1, 2019 3:49 PM > To: Su, Simei ; Zhang, Qi Z ; Ye, > Xiaolong ; Yigit, Ferruh > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v8 2/3] ethdev: extend RSS off

Re: [dpdk-dev] [PATCH] net/null: fix multi-process rx and tx

2019-10-01 Thread Ferruh Yigit
On 9/29/2019 3:41 AM, Yasufumi Ogawa wrote: > Packet processing in secondary process cannot work because rx_pkt_burst > and tx_pkt_burst in eth_dev are not initialized while probing device. > This patch is to the initialization. > > Signed-off-by: Yasufumi Ogawa > --- > drivers/net/null/rte_eth_

[dpdk-dev] [PATCH 2/3] net/virtio: reject deferred start Tx queue setup

2019-10-01 Thread Andrew Rybchenko
From: Dilshod Urazov Deferred start Tx queue is not supported by the driver. Fixes: 0748be2cf9a2 ("ethdev: queue start and stop") Cc: sta...@dpdk.org Signed-off-by: Dilshod Urazov Signed-off-by: Andrew Rybchenko --- drivers/net/virtio/virtio_rxtx.c | 5 + 1 file changed, 5 insertions(+)

[dpdk-dev] [PATCH 3/3] net/virtio: reject unsupported Rx multi queue modes

2019-10-01 Thread Andrew Rybchenko
From: Dilshod Urazov This driver supports none of DCB, RSS or VMDQ modes, therefore must check and return error if configured incorrectly. Fixes: c1f86306a026 ("virtio: add new driver") Cc: sta...@dpdk.org Signed-off-by: Dilshod Urazov Signed-off-by: Andrew Rybchenko --- drivers/net/virtio/v

[dpdk-dev] [PATCH 1/3] net/virtio: reject deferred start Rx queue setup

2019-10-01 Thread Andrew Rybchenko
From: Dilshod Urazov Deferred start Rx queue is not supported by the driver. Fixes: 0748be2cf9a2 ("ethdev: queue start and stop") Cc: sta...@dpdk.org Signed-off-by: Dilshod Urazov Signed-off-by: Andrew Rybchenko --- drivers/net/virtio/virtio_rxtx.c | 5 + 1 file changed, 5 insertions(+)

Re: [dpdk-dev] [PATCH 9/9] net/bnxt: remove commented out code

2019-10-01 Thread Ajit Khaparde
On Tue, Oct 1, 2019 at 6:04 AM Kevin Traynor wrote: > This commented out todo and code is old. Remove it. > > Fixes: b7435d660a8c ("net/bnxt: add ntuple filtering support") > Cc: ajit.khapa...@broadcom.com > Cc: sta...@dpdk.org > > Signed-off-by: Kevin Traynor > Acked-by: Ajit Khaparde --- >

Re: [dpdk-dev] [PATCH v2 4/7] drivers/net: update Rx RSS hash offload capabilities

2019-10-01 Thread Ajit Khaparde
On Wed, Aug 21, 2019 at 1:48 PM wrote: > From: Pavan Nikhilesh > > Add DEV_RX_OFFLOAD_RSS_HASH flag for all PMDs that support RSS hash > delivery. > > Signed-off-by: Pavan Nikhilesh > For net/bnxt: Acked-by: Ajit Khaparde > --- > drivers/net/bnxt/bnxt_ethdev.c | 3 ++- > drivers/net/

Re: [dpdk-dev] [PATCH] eventdev: flag to identify same destined packets enqueue

2019-10-01 Thread Jerin Jacob
On Tue, Oct 1, 2019 at 8:36 PM Nipun Gupta wrote: > > > > > -Original Message- > > From: Jerin Jacob > > Sent: Tuesday, October 1, 2019 7:50 PM > > To: Nipun Gupta > > Cc: Jerin Jacob ; dpdk-dev ; Pavan > > Nikhilesh ; Sunil Kumar Kori > > ; Hemant Agrawal ; > > Richardson, Bruce ; Marko

  1   2   3   >