Re: [dpdk-dev] [PATCH v2 08/16] vhost: add flush function for burst enqueue

2019-09-24 Thread Liu, Yong
> -Original Message- > From: Liu, Yong > Sent: Wednesday, September 25, 2019 1:38 PM > To: Gavin Hu (Arm Technology China) ; > maxime.coque...@redhat.com; Bie, Tiwei ; Wang, Zhihong > > Cc: dev@dpdk.org; nd > Subject: RE: [dpdk-dev] [PATCH v2 08/16] vhost: add flush function for > burst e

Re: [dpdk-dev] [PATCH v1 1/1] bus/pci: probe PCI devices in whitelisted order

2019-09-24 Thread Slava Ovsiienko
> -Original Message- > From: dev On Behalf Of vattun...@marvell.com > Sent: Monday, September 23, 2019 14:57 > To: dev@dpdk.org > Cc: gaetan.ri...@6wind.com; ferruh.yi...@intel.com; > anatoly.bura...@intel.com; Thomas Monjalon ; > jer...@marvell.com; Vamsi Attunuru > Subject: [dpdk-dev] [

Re: [dpdk-dev] [PATCH v3 1/8] net/ice: enable flow director engine

2019-09-24 Thread Cao, Yahui
Thanks for the comments. Old version patches' states are changed. -Original Message- From: Gavin Hu (Arm Technology China) [mailto:gavin...@arm.com] Sent: Wednesday, September 25, 2019 11:20 AM To: Cao, Yahui ; Yang, Qiming ; Lu, Wenzhuo Cc: dev@dpdk.org; Zhang, Qi Z ; Ye, Xiaolong ; X

[dpdk-dev] [PATCH] examples/fips_validation: fix null pointer dereferences

2019-09-24 Thread Chaitanya Babu Talluri
One issue caught by Coverity 343408 *deref_parm: Directly dereferencing parameter val->val. In writeback_tdes_hex_str(), tmp_val is initialised to null. tmp_val.val is updated only if keys are found. If keys are not found,it doesn't fails but continues to invoke writeback_hex_str(),where val->val

Re: [dpdk-dev] [PATCH] net/axgbe: fix double unlock coverity issue

2019-09-24 Thread Poornima, PallantlaX
Hi, >-Original Message- >From: Poornima, PallantlaX >Sent: Thursday, September 19, 2019 4:32 PM >To: dev@dpdk.org >Cc: Pattan, Reshma ; Parthasarathy, JananeeX M >; ravi1.ku...@amd.com; Poornima, >PallantlaX ; sta...@dpdk.org >Subject: [PATCH] net/axgbe: fix double unlock coverity issue >

Re: [dpdk-dev] [PATCH] lib/eventdev: fix null pointer dereferences coverity issue

2019-09-24 Thread Gujjar, Abhinandan S
Please find the comments inline > -Original Message- > From: Chaitanya Babu, TalluriX > Sent: Friday, September 20, 2019 12:39 PM > To: dev@dpdk.org > Cc: Pattan, Reshma ; Parthasarathy, JananeeX M > ; Gujjar, Abhinandan S > ; Chaitanya Babu, TalluriX > ; sta...@dpdk.org > Subject: [PATCH]

[dpdk-dev] Queries about the RED implementation

2019-09-24 Thread Avinash .
Hi, I was going through the implementation of RED in dpdk. I wanted to clarify some doubts about the implementation. First, In RED Paper the Pmax used, how is this related to InvMaxp in dpdk, why inverse? Secondly, the minth and maxth are constant values in RED paper, but in the dpdk implementatio

Re: [dpdk-dev] [PATCH v2 08/16] vhost: add flush function for burst enqueue

2019-09-24 Thread Liu, Yong
> -Original Message- > From: Gavin Hu (Arm Technology China) [mailto:gavin...@arm.com] > Sent: Wednesday, September 25, 2019 11:38 AM > To: Liu, Yong ; maxime.coque...@redhat.com; Bie, Tiwei > ; Wang, Zhihong > Cc: dev@dpdk.org; nd > Subject: RE: [dpdk-dev] [PATCH v2 08/16] vhost: add

Re: [dpdk-dev] [PATCH v3 1/8] net/ice: enable flow director engine

2019-09-24 Thread Xing, Beilei
> -Original Message- > From: Gavin Hu (Arm Technology China) [mailto:gavin...@arm.com] > Sent: Wednesday, September 25, 2019 11:20 AM > To: Cao, Yahui ; Yang, Qiming > ; Lu, Wenzhuo > Cc: dev@dpdk.org; Zhang, Qi Z ; Ye, Xiaolong > ; Xing, Beilei ; nd > > Subject: RE: [dpdk-dev] [PATCH v3

[dpdk-dev] [PATCH v2] net/octeontx2: add TSO offload support

2019-09-24 Thread Nithin Dabilpuram
Add support to below TCP segmentation offloads for 96XX A1 onwards and 95xx B0 onwards. - TCPv4, TCPv6 - VXLAN[v4 | v6][v4 | v6] - GENEVE[v4 | v6][v4 | v6] This patch also modifies a fastpath function to be forced inline due to performance reasons for multi-seg mode. Signed-off-by: Nithin Dabilpu

[dpdk-dev] [PATCH] net/octeontx2: add GRE TSO offload support

2019-09-24 Thread Nithin Dabilpuram
Extends existing TSO support to GRE tunnel on the same SoC revisions. Signed-off-by: Nithin Dabilpuram --- Note: This patchset depends on "net/octeontx2: add TSO offload support" i.e "http://patches.dpdk.org/patch/59691/"; drivers/net/octeontx2/otx2_ethdev.c | 111 ++

[dpdk-dev] [PATCH v2] net/octeontx2: add TSO offload support

2019-09-24 Thread Nithin Dabilpuram
Add support to below TCP segmentation offloads for 96XX A1 onwards and 95xx B0 onwards. - TCPv4, TCPv6 - VXLAN[v4 | v6][v4 | v6] - GENEVE[v4 | v6][v4 | v6] This patch also modifies a fastpath function to be forced inline due to performance reasons for multi-seg mode. Signed-off-by: Nithin Dabilpu

Re: [dpdk-dev] [PATCH v2 10/16] vhost: split enqueue and dequeue flush functions

2019-09-24 Thread Gavin Hu (Arm Technology China)
Similarly the rte_smp_wmb can be out of and right above the loop. > -Original Message- > From: dev On Behalf Of Marvin Liu > Sent: Friday, September 20, 2019 12:37 AM > To: maxime.coque...@redhat.com; tiwei@intel.com; > zhihong.w...@intel.com > Cc: dev@dpdk.org; Marvin Liu > Subject

Re: [dpdk-dev] [PATCH v1 1/1] kernel/linux: introduce vfio_pf kernel module

2019-09-24 Thread Vamsi Krishna Attunuru
Hi, We would like to have these support in 19.11. Please let us know if there are any comments or suggestions, we can discuss and address accordingly. -Original Message- From: Jerin Jacob Kollanukkaran Sent: Friday, September 6, 2019 6:58 PM To: Thomas Monjalon ; Vamsi Krishna Attunuru

Re: [dpdk-dev] [PATCH v10 0/5] kni: add IOVA=VA support

2019-09-24 Thread Vamsi Krishna Attunuru
PING. -Original Message- From: vattun...@marvell.com Sent: Friday, August 16, 2019 11:43 AM To: dev@dpdk.org Cc: tho...@monjalon.net; Jerin Jacob Kollanukkaran ; olivier.m...@6wind.com; ferruh.yi...@intel.com; anatoly.bura...@intel.com; arybche...@solarflare.com; Kiran Kumar Kokkilagad

Re: [dpdk-dev] [PATCH v2 08/16] vhost: add flush function for burst enqueue

2019-09-24 Thread Gavin Hu (Arm Technology China)
Hi Marvin, One typo and one comment about the barrier. /Gavin > -Original Message- > From: dev On Behalf Of Marvin Liu > Sent: Friday, September 20, 2019 12:37 AM > To: maxime.coque...@redhat.com; tiwei@intel.com; > zhihong.w...@intel.com > Cc: dev@dpdk.org; Marvin Liu > Subject: [

Re: [dpdk-dev] [PATCH v3 1/8] net/ice: enable flow director engine

2019-09-24 Thread Gavin Hu (Arm Technology China)
Hi Yahui, two general comments: 1.Please make old versions of patches Superseded to facilitate review. 2. the two occurrences of rte_wmb can be removed, a similar patch has been reviewed by Qi. http://patches.dpdk.org/patch/59278/ /Gavin > -Original Message- > From: dev On Behalf Of

[dpdk-dev] [RFC v4] net/i40e: enable multi-queue Rx interrupt for VF

2019-09-24 Thread lunyuan.cui
Current implementation is that only one Rx queue can support interrupt, because all queues are mapped in the same vector id in vfio_enable_msix(). So VF can not support multi-queue Rx interrupt in the interrupt mode. In this patch, if the packet I/O interrupt on datapath is enabled (rte_intr_dp_is

[dpdk-dev] net/ixgbe: fix X553 wrong speed capability

2019-09-24 Thread Zhang Xiao
The speed capability of X553 1GbE should be ETH_LINK_SPEED_1G | ETH_LINK_SPEED_100M | ETH_LINK_SPEED_10M rather than ETH_LINK_SPEED_1G | ETH_LINK_SPEED_10G. Correct it to fix the issue. Fixes: e274f5732225 ("ethdev: add speed capabilities") Cc: marcde...@gmail.com Cc: sta...@dpdk.org Signed-off-b

Re: [dpdk-dev] [PATCH v2 00/22] add hns3 ethernet PMD driver

2019-09-24 Thread Wei Hu (Xavier)
On 2019/9/25 4:34, Aaron Conole wrote: > "Wei Hu (Xavier)" writes: > >> Hi, Ferruh Yigit >> >> I sent out patch V2 yesterday. And I found that the following page >> indicates that there is a compilation error. >> >> http://mails.dpdk.org/archives/test-report/2019-September/098385.html >> >

Re: [dpdk-dev] [PATCH v6 02/17] raw/ifpga/base: add irq support

2019-09-24 Thread Zhang, Tianfei
> -Original Message- > From: Ye, Xiaolong > Sent: Wednesday, September 25, 2019 12:02 AM > To: Pei, Andy > Cc: dev@dpdk.org; Xu, Rosen ; Zhang, Tianfei > ; Zhang, Qi Z ; Lomartire, > David ; Yigit, Ferruh > Subject: Re: [PATCH v6 02/17] raw/ifpga/base: add irq support > > On 09/19, An

Re: [dpdk-dev] [PATCH v6 04/17] raw/ifpga/base: add SEU error support

2019-09-24 Thread Zhang, Tianfei
> -Original Message- > From: Ye, Xiaolong > Sent: Wednesday, September 25, 2019 12:37 AM > To: Pei, Andy > Cc: dev@dpdk.org; Xu, Rosen ; Zhang, Tianfei > ; Zhang, Qi Z ; Lomartire, > David ; Yigit, Ferruh > Subject: Re: [PATCH v6 04/17] raw/ifpga/base: add SEU error support > > On 09/

Re: [dpdk-dev] [PATCH v2] kni: rework rte_kni_update_link using ioctl

2019-09-24 Thread Aaron Conole
Igor Ryzhov writes: > Current implementation doesn't allow us to update KNI carrier if the > interface is not yet UP in kernel. It means that we can't use it in the > same thread which is processing rte_kni_ops.config_network_if, which is > very convenient, because it allows us to have correct ca

Re: [dpdk-dev] [PATCH v2 00/22] add hns3 ethernet PMD driver

2019-09-24 Thread Aaron Conole
"Wei Hu (Xavier)" writes: > Hi, Ferruh Yigit > > I sent out patch V2 yesterday. And I found that the following page > indicates that there is a compilation error. > > http://mails.dpdk.org/archives/test-report/2019-September/098385.html > > The relevant sections in the log: > > <...> > > *Me

Re: [dpdk-dev] FW: 17.11.7-rc1 (LTS) patches review and test

2019-09-24 Thread Luca Boccassi
Yu Ping, Qian, I have pushed to the 17.11 branch with the fixes for 1 and 2, and for building with kernel 5.3 (just a change in the comments, nothing functional). Do you need to re-run the test suite, or are you confident enough with a quick check? This release is already quite late, is it OK if

Re: [dpdk-dev] [PATCH v2 00/15] sched: subport level configuration of pipe nodes

2019-09-24 Thread Singh, Jasvinder
> -Original Message- > From: Dumitrescu, Cristian > Sent: Monday, September 23, 2019 2:06 PM > To: Singh, Jasvinder ; dev@dpdk.org > Subject: RE: [PATCH v2 00/15] sched: subport level configuration of pipe nodes > > Hi Jasvinder, > > > -Original Message- > > From: Singh, Jasvin

[dpdk-dev] [PATCH v2] kni: rework rte_kni_update_link using ioctl

2019-09-24 Thread Igor Ryzhov
Current implementation doesn't allow us to update KNI carrier if the interface is not yet UP in kernel. It means that we can't use it in the same thread which is processing rte_kni_ops.config_network_if, which is very convenient, because it allows us to have correct carrier status of the interface

[dpdk-dev] [PATCH] kni: rework rte_kni_update_link using ioctl

2019-09-24 Thread Igor Ryzhov
Current implementation doesn't allow us to update KNI carrier if the interface is not yet UP in kernel. It means that we can't use it in the same thread which is processing rte_kni_ops.config_network_if, which is very convenient, because it allows us to have correct carrier status of the interface

Re: [dpdk-dev] [PATCH] igb_uio: fix build on Linux 5.3 for implicit fall through

2019-09-24 Thread Luca Boccassi
On Mon, 2019-07-29 at 13:32 +0100, Ferruh Yigit wrote: > build error: > .../dpdk/build/build/kernel/linux/igb_uio/igb_uio.c: >In function ‘igbuio_pci_enable_interrupts’: >.../dpdk/build/build/kernel/linux/igb_uio/igb_uio.c:230:6: >error: this statement may fall through >[-Werror=imp

[dpdk-dev] [PATCH v6] eal: make lcore_config private

2019-09-24 Thread Stephen Hemminger
The internal structure of lcore_config is no longer be part of visible API/ABI. Make it private to EAL. Rearrange and resize the fields in the structure so it takes less memory (and cache footprint). Signed-off-by: Stephen Hemminger --- v6 - rebase for 19.11 follows my earlier efforts at hi

Re: [dpdk-dev] FW: 17.11.7-rc1 (LTS) patches review and test

2019-09-24 Thread Luca Boccassi
On Tue, 2019-09-24 at 18:15 +0100, Kevin Traynor wrote: > On 24/09/2019 17:36, Ferruh Yigit wrote: > > On 9/24/2019 12:07 PM, Luca Boccassi wrote: > > > Ping - any updates on these patches? The release of 17.11.7 is > > > currently on hold waiting for a resolution here. > > > > Hi Luca, > > > > T

Re: [dpdk-dev] FW: 17.11.7-rc1 (LTS) patches review and test

2019-09-24 Thread Kevin Traynor
On 24/09/2019 17:36, Ferruh Yigit wrote: > On 9/24/2019 12:07 PM, Luca Boccassi wrote: >> Ping - any updates on these patches? The release of 17.11.7 is >> currently on hold waiting for a resolution here. > > Hi Luca, > > Test team provided some internal details: > > 1- Build issue on f30, > A p

Re: [dpdk-dev] [PATCH] test/bpf: add new test cases

2019-09-24 Thread Ananyev, Konstantin
Hi, > > This patch implements following new test cases: > - test_call4: test case to verify if stack corruption occurs > across with multiple function calls. > - test_jump2: test case with a default packet in memory, parse > the packet and check if dest ip is part of a subnet. > - test_call5: t

Re: [dpdk-dev] [PATCH 0/8] eBPF arm64 JIT support

2019-09-24 Thread Ananyev, Konstantin
> > Added eBPF arm64 JIT support to improve the eBPF program performance > on arm64. > > dpdk.org/examples/bpf/t1.c application shows around 50% improvement > on OCTEON TX2 platform in JIT vs interpreter mode. > > Verified the implementation using existing bpf_autotest application. > > # ech

[dpdk-dev] [PATCH] ethdev: handle removed device properly on promisc replay

2019-09-24 Thread Andrew Rybchenko
Promiscuous mode callback may return error if the device is removed. Use eth_err() helper to check the condition and return appropriate error code. Fixes: dff6d544fb3c ("ethdev: do nothing if promiscuous mode is applied again") Signed-off-by: Andrew Rybchenko --- lib/librte_ethdev/rte_ethdev.c

Re: [dpdk-dev] [PATCH v2 0/4] net/bnx2x: update to latest FW

2019-09-24 Thread Rasesh Mody
>From: Jerin Jacob >Sent: Tuesday, September 24, 2019 9:30 AM > >On Tue, Sep 24, 2019 at 9:27 PM Ferruh Yigit wrote: >> >> On 9/24/2019 4:39 PM, Jerin Jacob wrote: >> > On Mon, Sep 23, 2019 at 10:03 PM Ferruh Yigit >wrote: >> >> >> >> On 9/19/2019 10:11 PM, Rasesh Mody wrote: >> >>> Hi, >> >>> >

Re: [dpdk-dev] RFC: hiding struct rte_eth_dev

2019-09-24 Thread Ananyev, Konstantin
Hi everyone, > > > > Hi folks, > > > > The ABI Stability proposals should be pretty well known at this point. > > The latest rev is here ... > > > > http://inbox.dpdk.org/dev/1565864619-17206-1-git-send-email-...@ashroe.eu/ > > > > As has been discussed public data structure's are risky for ABI >

Re: [dpdk-dev] [PATCH v2 0/2] Add external mbufs option

2019-09-24 Thread Trahe, Fiona
> -Original Message- > From: Dybkowski, AdamX > Sent: Tuesday, September 24, 2019 3:11 PM > To: dev@dpdk.org; Trahe, Fiona ; Trybula, ArturX > ; akhil.go...@nxp.com > Cc: Dybkowski, AdamX > Subject: [PATCH v2 0/2] Add external mbufs option > > This patchset adds a unit test of the exte

Re: [dpdk-dev] [PATCH 2/3] net/af_xdp: support pinning of IRQs

2019-09-24 Thread Stephen Hemminger
On Thu, 19 Sep 2019 14:15:19 + Ciara Loftus wrote: > +char driver_array[NUM_DRIVERS][NAME_MAX] = {"i40e", "ixgbe", "mlx5_core"}; This only makes sense in this file. Should be static.

Re: [dpdk-dev] RFC: hiding struct rte_eth_dev

2019-09-24 Thread Jerin Jacob
On Mon, Sep 23, 2019 at 9:49 PM Ray Kinsella wrote: > > Hi folks, > > The ABI Stability proposals should be pretty well known at this point. > The latest rev is here ... > > http://inbox.dpdk.org/dev/1565864619-17206-1-git-send-email-...@ashroe.eu/ > > As has been discussed public data structure's

Re: [dpdk-dev] [PATCH v2 0/7] ethdev: change allmulticast controls to return status

2019-09-24 Thread Ferruh Yigit
On 9/24/2019 1:56 PM, Andrew Rybchenko wrote: > m> > References: <1568031190-16510-1-git-send-email-arybche...@solarflare.co > m> > > It is the fourth patch series to get rid of void returning functions > in ethdev in accordance with deprecation notice [1]. > > It should be applied on top of [2],

Re: [dpdk-dev] [PATCH v6 04/17] raw/ifpga/base: add SEU error support

2019-09-24 Thread Ye Xiaolong
On 09/19, Andy Pei wrote: >From: Tianfei zhang > >This patch exposes SEU error information to application then application >could compare this information (128bit) with its own SMH file to know >if this SEU is a fatal error or not. > >Signed-off-by: Tianfei zhang >Signed-off-by: Andy Pei >--- >

Re: [dpdk-dev] FW: 17.11.7-rc1 (LTS) patches review and test

2019-09-24 Thread Ferruh Yigit
On 9/24/2019 12:07 PM, Luca Boccassi wrote: > Ping - any updates on these patches? The release of 17.11.7 is > currently on hold waiting for a resolution here. Hi Luca, Test team provided some internal details: 1- Build issue on f30, A patch has been sent to stable mail list to fix it, not sure

Re: [dpdk-dev] [PATCH v2 0/4] net/bnx2x: update to latest FW

2019-09-24 Thread Jerin Jacob
On Tue, Sep 24, 2019 at 9:27 PM Ferruh Yigit wrote: > > On 9/24/2019 4:39 PM, Jerin Jacob wrote: > > On Mon, Sep 23, 2019 at 10:03 PM Ferruh Yigit > > wrote: > >> > >> On 9/19/2019 10:11 PM, Rasesh Mody wrote: > >>> Hi, > >>> > >>> Currently, BNX2X PMD uses a very old firmware 7.2.51. > >>> This

[dpdk-dev] [PATCH v2] vhost: add experimental flag

2019-09-24 Thread Jim Harris
This function is listed under EXPERIMENTAL in the rte_vhost_version.map, so it needs to be marked with __rte_experimental in the header file as well. Found by check-experimental-syms.sh when trying to compile DPDK with -finstrument-functions. This script didn't catch this in the normal case, sinc

Re: [dpdk-dev] [PATCH v6 02/17] raw/ifpga/base: add irq support

2019-09-24 Thread Ye Xiaolong
On 09/25, Ye Xiaolong wrote: >>+/* only support msix for now*/ >>+static int vfio_msix_enable_block(s32 vfio_dev_fd, unsigned int vec_start, >>+ unsigned int count, s32 *fds) > >DPDK convention is put the function return type in a separate line. > Just noticed that th

Re: [dpdk-dev] [PATCH] vhost: add __rte_experimental to rte_vhost_va_from_guest_pa

2019-09-24 Thread Maxime Coquelin
On 9/24/19 6:04 PM, Ferruh Yigit wrote: > On 9/24/2019 12:26 AM, Harris, James R wrote: >> >> >> On 9/23/19, 8:41 AM, "Yigit, Ferruh" wrote: >> >> On 9/18/2019 2:12 PM, Maxime Coquelin wrote: >> > >> > >> > On 8/20/19 11:37 AM, Jim Harris wrote: >> >> This function is lis

Re: [dpdk-dev] [PATCH v6 02/17] raw/ifpga/base: add irq support

2019-09-24 Thread Ye Xiaolong
On 09/19, Andy Pei wrote: >From: Tianfei zhang > >Add irq support for ifpga FME globle error, port error and uint unit. s/globle/global >We implmented this feature by vfio interrupt mechanism. > >Signed-off-by: Tianfei zhang >Signed-off-by: Andy Pei >--- > drivers/raw/ifpga/base/ifpga_feature_

Re: [dpdk-dev] [PATCH] vhost: add __rte_experimental to rte_vhost_va_from_guest_pa

2019-09-24 Thread Ferruh Yigit
On 9/24/2019 12:26 AM, Harris, James R wrote: > > > On 9/23/19, 8:41 AM, "Yigit, Ferruh" wrote: > > On 9/18/2019 2:12 PM, Maxime Coquelin wrote: > > > > > > On 8/20/19 11:37 AM, Jim Harris wrote: > >> This function is listed under EXPERIMENTAL in the > >> rte_vhost_ve

Re: [dpdk-dev] [PATCH v2 01/10] build: add an option to enable LTO build

2019-09-24 Thread Ray Kinsella
On 24/09/2019 13:59, Neil Horman wrote: > On Tue, Sep 24, 2019 at 12:25:35PM +0200, Bruce Richardson wrote: >> On Tue, Sep 24, 2019 at 08:46:25AM +0200, Andrzej Ostruszka wrote: >>> On 9/23/19 6:13 PM, Bruce Richardson wrote: >>> [...] However, testing on my system with the meson build, I'm

Re: [dpdk-dev] [PATCH v2 0/4] net/bnx2x: update to latest FW

2019-09-24 Thread Ferruh Yigit
On 9/24/2019 4:39 PM, Jerin Jacob wrote: > On Mon, Sep 23, 2019 at 10:03 PM Ferruh Yigit wrote: >> >> On 9/19/2019 10:11 PM, Rasesh Mody wrote: >>> Hi, >>> >>> Currently, BNX2X PMD uses a very old firmware 7.2.51. >>> This patch series updated the base driver to use to latest >>> firmware 7.13.11.

Re: [dpdk-dev] [PATCH v6 00/17] add PCIe AER disable and IRQ support for ipn3ke

2019-09-24 Thread Ye Xiaolong
Some general comment, it seems lack of doc/release_note update, and meson also need to be considered, as it will be the default build system in the future. Thanks, Xiaolong On 09/19, Andy Pei wrote: >This patch set adds PCIe AER disable and IRQ support for ipn3ke. >Disable PCIe AER is very usefu

Re: [dpdk-dev] [PATCH v2 0/4] net/bnx2x: update to latest FW

2019-09-24 Thread Jerin Jacob
On Mon, Sep 23, 2019 at 10:03 PM Ferruh Yigit wrote: > > On 9/19/2019 10:11 PM, Rasesh Mody wrote: > > Hi, > > > > Currently, BNX2X PMD uses a very old firmware 7.2.51. > > This patch series updated the base driver to use to latest > > firmware 7.13.11. The latest firmware comprises of enhancement

[dpdk-dev] [PATCH] test/bpf: add new test cases

2019-09-24 Thread Harman Kalra
This patch implements following new test cases: - test_call4: test case to verify if stack corruption occurs across with multiple function calls. - test_jump2: test case with a default packet in memory, parse the packet and check if dest ip is part of a subnet. - test_call5: test case with string d

Re: [dpdk-dev] [PATCH] port: fix missing pcap support with meson

2019-09-24 Thread Bruce Richardson
On Tue, Sep 24, 2019 at 01:04:14PM +0100, Bruce Richardson wrote: > The meson build was missing the define to enable pcap port support if > libpcap (development) package was found on the build platform. Rather than > duplicating the checks for libpcap found in the pcap net PMD build file, we > can

[dpdk-dev] udp checksum

2019-09-24 Thread Khoussi, Siham (IntlAssoc)
Dear all, I have a question related to layer 4 checksum. I am creating a UDP packet by appending the layers in order (udp, ipv4, Eth). However, when I run Wireshark on the receiving end I get: [UDPchecksum = missing (nor present]. Whereas, the checksum for ipv4 works fine. Here is what I do:

Re: [dpdk-dev] [PATCH v6 01/17] net/i40e: i40e support ipn3ke FPGA port bonding

2019-09-24 Thread Ye Xiaolong
On 09/19, Andy Pei wrote: >In ipn3ke, each FPGA network side port bonding to an i40e pf, >each i40e pf link status should get data from FPGA network, >side port. This patch provide bonding relationship. > >Signed-off-by: Rosen Xu >Signed-off-by: Andy Pei >--- > drivers/net/i40e/base/i40e_type.h |

[dpdk-dev] [Bug 351] When RTE_LIBRTE_PCAP_PMD is enabled RTE_PORT_PCAP is not enabled for rte_port_source_sink.c

2019-09-24 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=351 Cristian Bidea (cristian.bi...@keysight.com) changed: What|Removed |Added Resolution|--- |FIXED S

Re: [dpdk-dev] [PATCH 2/3] net/af_xdp: support pinning of IRQs

2019-09-24 Thread Ye Xiaolong
On 09/19, Ciara Loftus wrote: [snip] >+/* drivers supported for the queue_irq option */ >+enum {I40E_DRIVER, IXGBE_DRIVER, MLX5_DRIVER, NUM_DRIVERS}; Minor nit, how about using below format for readability and align with other enum type definition in DPDK? enum supported_driver { I40E_

[dpdk-dev] [PATCH v2 2/2] app/compress-perf: add external mbufs option

2019-09-24 Thread Adam Dybkowski
This patch adds new performance measurement option --external-mbufs that allocates and uses memzones as external buffers instead of putting the data directly inside mbufs. Signed-off-by: Adam Dybkowski --- app/test-compress-perf/comp_perf_options.h| 2 + .../comp_perf_options_parse.c

[dpdk-dev] [PATCH v2 1/2] test/compress: add external buffer in mbuf API test

2019-09-24 Thread Adam Dybkowski
Adds a new test to verify external buffer in mbuf APIs. Initialize fields in test_data_params structures by name for better readability. Signed-off-by: Adam Dybkowski --- app/test/test_compressdev.c | 314 +--- 1 file changed, 221 insertions(+), 93 deletions(-) d

[dpdk-dev] [PATCH v2 0/2] Add external mbufs option

2019-09-24 Thread Adam Dybkowski
This patchset adds a unit test of the external buffers functionality and a new option to the compression performance benchmark tool to use memzones as external buffers instead of the data put directly inside mbufs. --- v2: * Rebasing over the stateful decompression patch This patch depends on http

[dpdk-dev] [PATCH v3 8/8] net/ice: add FDIR vxlan tunnel support

2019-09-24 Thread Yahui Cao
Enable FDIR vxlan tunnel matching for RTE_FLOW Signed-off-by: Yahui Cao --- drivers/net/ice/ice_ethdev.h | 6 ++ drivers/net/ice/ice_fdir_filter.c | 99 +++ 2 files changed, 95 insertions(+), 10 deletions(-) diff --git a/drivers/net/ice/ice_ethdev.h b/drivers/n

[dpdk-dev] [PATCH v3 7/8] net/ice: reject duplicate flow for FDIR

2019-09-24 Thread Yahui Cao
Enable duplication lookup for existing flow director rule entry. Signed-off-by: Yahui Cao --- drivers/net/ice/ice_ethdev.h | 17 +++ drivers/net/ice/ice_fdir_filter.c | 186 -- 2 files changed, 196 insertions(+), 7 deletions(-) diff --git a/drivers/net/ice/ice_

[dpdk-dev] [PATCH v3 6/8] net/ice: add FDIR counter support

2019-09-24 Thread Yahui Cao
This patch add FDIR statistical counter support and it includes RTE_FLOW count actions support and query support. RTE_FLOW count actions support id and shared. RTE_FLOW query record packet hits by default. Signed-off-by: Yahui Cao --- drivers/net/ice/ice_ethdev.h | 7 ++ drivers/net/ice/

[dpdk-dev] [PATCH v3 4/8] net/ice: enable FDIR queue group

2019-09-24 Thread Yahui Cao
FDIR can send packet to a group of queues and distruibte it by RSS. Signed-off-by: Yahui Cao --- drivers/net/ice/ice_fdir_filter.c | 68 +++ 1 file changed, 68 insertions(+) diff --git a/drivers/net/ice/ice_fdir_filter.c b/drivers/net/ice/ice_fdir_filter.c index f55

[dpdk-dev] [PATCH v3 5/8] net/ice: add FDIR counter resource init/release

2019-09-24 Thread Yahui Cao
The patch integrates the counter resource init/release into fdir's init/release scenario Signed-off-by: Yahui Cao --- drivers/net/ice/ice_ethdev.h | 33 +++ drivers/net/ice/ice_fdir_filter.c | 92 +++ 2 files changed, 125 insertions(+) diff --git a/drive

[dpdk-dev] [PATCH v3 3/8] net/ice: add FDIR create and destroy

2019-09-24 Thread Yahui Cao
Add ice_create_fdir_filter to create a rule. If a flow is matched by flow director filter, filter rule will be set to HW. For now common pattern and queue/passthru/drop/mark actions are supported. Signed-off-by: Yahui Cao --- doc/guides/rel_notes/release_19_11.rst | 1 + drivers/net/ice/ice_et

[dpdk-dev] [PATCH v3 2/8] net/ice: configure HW FDIR rule

2019-09-24 Thread Yahui Cao
From: Beilei Xing This patch adds a HW FDIR rule to the FDIR HW table without adding a FDIR filter. Signed-off-by: Beilei Xing --- drivers/net/ice/ice_fdir_filter.c | 239 ++ 1 file changed, 239 insertions(+) diff --git a/drivers/net/ice/ice_fdir_filter.c b/driver

[dpdk-dev] [PATCH v3 1/8] net/ice: enable flow director engine

2019-09-24 Thread Yahui Cao
From: Beilei Xing Enable flow director engine, including initialization and teardown. - Control VSI create and release. - Queue pair allocated, set up and release. - Programming packet create and release. - FDIR profile create and release. Signed-off-by: Beilei Xing --- drivers/net/ice/Mak

[dpdk-dev] [PATCH v3 0/8] net/ice: add ice Flow Director driver

2019-09-24 Thread Yahui Cao
This patch series adds Flow Director support for Intel Ethernet Controller E810 series using RTE_FLOW - Patch 01-02 are FDIR init,teardown and configuration - Remaining patches are FDIR RTE_FLOW enablement The patchset depends on: http://patchwork.dpdk.org/project/dpdk/list/?series=6420 --- v3: *

Re: [dpdk-dev] [PATCH 1/1] ethdev: change owner delete function return value to int

2019-09-24 Thread Ferruh Yigit
On 9/10/2019 10:02 AM, Andrew Rybchenko wrote: > From: Igor Romanov > > Change rte_eth_dev_owner_delete() return value from void to int > and return negative errno values in case of error conditions. > > Right now there is only one error case for rte_eth_dev_owner_delete() - > invalid owner, but

Re: [dpdk-dev] [PATCH 0/7] ethdev: change MAC addr get function return value to int

2019-09-24 Thread Ferruh Yigit
On 9/10/2019 9:52 AM, Andrew Rybchenko wrote: > It is the sixth patch series to get rid of void returning functions > in ethdev in accordance with deprecation notice [1]. > > It should be applied on top of [2], [3], [4], [5] and [6]. > > Functions which return void are bad since they do not provi

Re: [dpdk-dev] [PATCH 1/2] test/compress: add external buffer in mbuf API test

2019-09-24 Thread Trahe, Fiona
> -Original Message- > From: Dybkowski, AdamX > Sent: Tuesday, September 3, 2019 10:43 AM > To: dev@dpdk.org; Trahe, Fiona ; De Lara Guarch, Pablo > ; Trybula, ArturX > Cc: Dybkowski, AdamX > Subject: [PATCH 1/2] test/compress: add external buffer in mbuf API test > > Adds a new test

Re: [dpdk-dev] [PATCH 2/2] ethdev: make stats and xstats reset callbacks return int

2019-09-24 Thread Andrew Rybchenko
On 9/24/19 2:56 PM, Ferruh Yigit wrote: On 9/6/2019 3:34 PM, Andrew Rybchenko wrote: From: Igor Romanov Change return value of the callbacks from void to int. Make implementations across all drivers return negative errno values in case of error conditions. Both callbacks are updated together

Re: [dpdk-dev] [PATCH v2 01/10] build: add an option to enable LTO build

2019-09-24 Thread Neil Horman
On Tue, Sep 24, 2019 at 12:25:35PM +0200, Bruce Richardson wrote: > On Tue, Sep 24, 2019 at 08:46:25AM +0200, Andrzej Ostruszka wrote: > > On 9/23/19 6:13 PM, Bruce Richardson wrote: > > [...] > > > However, testing on my system with the meson build, I'm getting lots of > > > link errors [See below

[dpdk-dev] [PATCH v2 7/7] examples/ipv4_multicast: check allmulticast enable status

2019-09-24 Thread Andrew Rybchenko
m> <1569329773-10185-1-git-send-email-arybche...@solarflare.com> From: Ivan Ilchenko rte_eth_allmulticast_enable()/rte_eth_allmulticast_disable() return value was changed from void to int, so this patch modify usage of these functions across examples/ipv4_multicast according to new return type.

[dpdk-dev] [PATCH v2 4/7] ethdev: change allmulticast callbacks to return status

2019-09-24 Thread Andrew Rybchenko
m> <1569329773-10185-1-git-send-email-arybche...@solarflare.com> From: Ivan Ilchenko Enabling/disabling of allmulticast mode is not always successful and it should be taken into account to be able to handle it properly. When correct return status is unclear from driver code, -EAGAIN is used.

[dpdk-dev] [PATCH v2 1/7] ethdev: change allmulticast mode API to return errors

2019-09-24 Thread Andrew Rybchenko
m> <1569329773-10185-1-git-send-email-arybche...@solarflare.com> From: Ivan Ilchenko Change rte_eth_allmulticast_enable()/rte_eth_allmulticast_disable() return value from void to int and return negative errno values in case of error conditions. Modify usage of these functions across the ethdev

[dpdk-dev] [PATCH v2 5/7] ethdev: do nothing if all-multicast mode is applied again

2019-09-24 Thread Andrew Rybchenko
m> <1569329773-10185-1-git-send-email-arybche...@solarflare.com> Since driver callbacks return status code now, there is no necessity to enable or disable all-multicast mode once again if it is already successfully enabled or disabled. Configuration restore at startup tries to ensure that config

[dpdk-dev] [PATCH v2 6/7] app/testpmd: check code of allmulticast mode switch

2019-09-24 Thread Andrew Rybchenko
m> <1569329773-10185-1-git-send-email-arybche...@solarflare.com> From: Ivan Ilchenko rte_eth_allmulticast_enable()/rte_eth_allmulticast_disable() return value was changed from void to int, so this patch modify usage of these functions across app/test-pmd according to new return type. Signed-of

[dpdk-dev] [PATCH v2 2/7] net/failsafe: check code of allmulticast mode switch

2019-09-24 Thread Andrew Rybchenko
m> <1569329773-10185-1-git-send-email-arybche...@solarflare.com> From: Ivan Ilchenko rte_eth_allmulticast_enable()/rte_eth_allmulticast_disable() return value was changed from void to int, so this patch modify usage of these functions across net/failsafe according to new return type. Try to ke

[dpdk-dev] [PATCH v2 0/7] ethdev: change allmulticast controls to return status

2019-09-24 Thread Andrew Rybchenko
m> References: <1568031190-16510-1-git-send-email-arybche...@solarflare.co m> It is the fourth patch series to get rid of void returning functions in ethdev in accordance with deprecation notice [1]. It should be applied on top of [2], [3] and [4] which are already accepted in dpdk-next-net. Fun

[dpdk-dev] [PATCH v2 3/7] net/bonding: check code of allmulticast mode switch

2019-09-24 Thread Andrew Rybchenko
m> <1569329773-10185-1-git-send-email-arybche...@solarflare.com> From: Ivan Ilchenko rte_eth_allmulticast_enable()/rte_eth_allmulticast_disable() return value was changed from void to int, so this patch modify usage of these functions across net/bonding according to new return type. Signed-off

Re: [dpdk-dev] [PATCH 2/2] app/compress-perf: add external mbufs option

2019-09-24 Thread Trahe, Fiona
> -Original Message- > From: Dybkowski, AdamX > Sent: Tuesday, September 3, 2019 10:43 AM > To: dev@dpdk.org; Trahe, Fiona ; De Lara Guarch, Pablo > ; Trybula, ArturX > Cc: Dybkowski, AdamX > Subject: [PATCH 2/2] app/compress-perf: add external mbufs option > > This patch adds new per

Re: [dpdk-dev] [PATCH v2 2/2] examples/ipsec-secgw: tests for split SAD

2019-09-24 Thread Ananyev, Konstantin
> > Test scripts updated to reflect change of SAD (split into IPv4 SAD > and IPv6 SAD). New parameter added to run_test.sh for performing tests > with mixed IP version, eg. IPv4 ipsec tunnel with IPv6 traffic. > > Bugzilla ID: 239 > Fixes: 5a032a71c6d3 ("examples/ipsec-secgw: make app to use I

Re: [dpdk-dev] [PATCH 00/18] ethdev: change link status get functions return value to int

2019-09-24 Thread Ferruh Yigit
On 9/10/2019 9:25 AM, Andrew Rybchenko wrote: > It is the fifth patch series to get rid of void returning functions > in ethdev in accordance with deprecation notice [1]. > > It should be applied on top of [2], [3], [4] and [5]. > > Functions which return void are bad since they do not provide ex

Re: [dpdk-dev] [PATCH v2 1/2] examples/ipsec-secgw: fix SAD selection logic

2019-09-24 Thread Ananyev, Konstantin
> Ipsec-secgw example application fails to initialize when using default > configuration file (ep0.cfg) in library mode (librte_ipsec enabled). > > The reason is that two of SP rules in ep0.cfg, one for IPv4 and one > for IPv6, are using the same SPI number. When SA rules are initialized, > thei

Re: [dpdk-dev] [PATCH 4/7] ethdev: change allmulticast callbacks to return status

2019-09-24 Thread Andrew Rybchenko
On 9/24/19 11:27 AM, Ferruh Yigit wrote: On 9/9/2019 1:13 PM, Andrew Rybchenko wrote: From: Ivan Ilchenko Enabling/disabling of allmulticast mode is not always successful and it should be taken into account to be able to handle it properly. When correct return status is unclear from driver co

Re: [dpdk-dev] [PATCH v2 01/10] build: add an option to enable LTO build

2019-09-24 Thread Bruce Richardson
On Tue, Sep 24, 2019 at 01:52:23PM +0200, Andrzej Ostruszka wrote: > > On 9/24/19 12:25 PM, Bruce Richardson wrote: > > On Tue, Sep 24, 2019 at 08:46:25AM +0200, Andrzej Ostruszka wrote: > [...] > >> PS. IMHO this SHARED_LIB define should be removed from the rte_config.h > >> and meson.build shoul

[dpdk-dev] [PATCH] port: fix missing pcap support with meson

2019-09-24 Thread Bruce Richardson
The meson build was missing the define to enable pcap port support if libpcap (development) package was found on the build platform. Rather than duplicating the checks for libpcap found in the pcap net PMD build file, we can move the checks to the top-level config directory and reference the RTE_PC

Re: [dpdk-dev] [RFC] ethdev: add new fields for max LRO session size

2019-09-24 Thread Matan Azrad
Hi From: Ferruh Yigit > On 9/15/2019 8:48 AM, Matan Azrad wrote: > > Hi Ferruh > > > > From: Ferruh Yigit > >> On 8/29/2019 8:47 AM, Matan Azrad wrote: > >>> It may be needed by the user to limit the LRO session packet size. > >>> In order to allow the above limitation, add new Rx configuration f

Re: [dpdk-dev] [PATCH] vhost: fix vring memory partially mapped

2019-09-24 Thread Maxime Coquelin
On 9/6/19 2:50 PM, Adrian Moreno wrote: > Only the mapping of the vring addresses is being ensured. This causes > errors when the vring size is larger than the IOTLB page size. E.g: > queue sizes > 256 for 4K IOTLB pages > > Ensure the entire vring memory range gets mapped. Refactor duplicated

Re: [dpdk-dev] [PATCH 0/2] ethdev: change xstats reset function return value to int

2019-09-24 Thread Ferruh Yigit
On 9/6/2019 3:34 PM, Andrew Rybchenko wrote: > It is the third patch series to get rid of void returning functions > in ethdev in accordance with deprecation notice [1]. > > It should be applied on top of the first [2] and the second [3]. > It could be applied separately, but few simple conflicts

Re: [dpdk-dev] [PATCH 2/2] ethdev: make stats and xstats reset callbacks return int

2019-09-24 Thread Ferruh Yigit
On 9/6/2019 3:34 PM, Andrew Rybchenko wrote: > From: Igor Romanov > > Change return value of the callbacks from void to int. Make > implementations across all drivers return negative errno > values in case of error conditions. > > Both callbacks are updated together because a large number of > d

Re: [dpdk-dev] [PATCH v2 01/10] build: add an option to enable LTO build

2019-09-24 Thread Andrzej Ostruszka
On 9/24/19 12:25 PM, Bruce Richardson wrote: > On Tue, Sep 24, 2019 at 08:46:25AM +0200, Andrzej Ostruszka wrote: [...] >> PS. IMHO this SHARED_LIB define should be removed from the rte_config.h >> and meson.build should be updated to detect 'default_library' and add it >> as needed. Don't know

Re: [dpdk-dev] [PATCH 5/7] ethdev: do nothing if all-multicast mode is applied again

2019-09-24 Thread Andrew Rybchenko
On 9/24/19 2:03 PM, Ferruh Yigit wrote: On 9/24/2019 9:54 AM, Andrew Rybchenko wrote: On 9/24/19 11:36 AM, Ferruh Yigit wrote: On 9/9/2019 1:13 PM, Andrew Rybchenko wrote: Since driver callbacks return status code now, there is no necessity to enable or disable all-multicast mode once again if

Re: [dpdk-dev] [PATCH 03/20] security: add hfn override option in PDCP

2019-09-24 Thread Ananyev, Konstantin
> > HFN can be given as a per packet value also. > > As we do not have IV in case of PDCP, and HFN is > > used to generate IV. IV field can be used to get the > > per packet HFN while enq/deq > > If hfn_ovrd field in pdcp_xform is set, > > application is expected to set the per packet HFN > > in

Re: [dpdk-dev] [PATCH v3 2/4] doc: changes to abi policy introducing major abi versions

2019-09-24 Thread Ray Kinsella
Thanks Kevin for working through all this. Other comments are inline. On 30/08/2019 17:20, Kevin Traynor wrote: > Hi Ray, > > On 15/08/2019 11:23, Ray Kinsella wrote: >> This policy change introduces major ABI versions, these are >> declared every year, typically aligned with the LTS release >>

Re: [dpdk-dev] [PATCH] examples/ipsec-secgw: fix over MTU packet crash

2019-09-24 Thread Ananyev, Konstantin
> -Original Message- > From: Smoczynski, MarcinX > Sent: Tuesday, September 24, 2019 11:55 AM > To: Ananyev, Konstantin ; akhil.go...@nxp.com > Cc: dev@dpdk.org; Smoczynski, MarcinX ; > sta...@dpdk.org > Subject: [PATCH] examples/ipsec-secgw: fix over MTU packet crash > > When sending

  1   2   >