Re: [dpdk-dev] [PATCH 09/15] net/virtio: add virtio vDPA op to get protocol features

2019-09-01 Thread Tiwei Bie
On Thu, Aug 29, 2019 at 09:59:54AM +0200, Maxime Coquelin wrote: > This patch implements the vDPA .get_protocol_features() > callback. > > Signed-off-by: Maxime Coquelin > --- > drivers/net/virtio/virtio_vdpa.c | 13 + > 1 file changed, 13 insertions(+) > > diff --git a/drivers/net/

Re: [dpdk-dev] [PATCH 08/15] net/virtio: add virtio vDPA op to get features

2019-09-01 Thread Tiwei Bie
On Thu, Aug 29, 2019 at 09:59:53AM +0200, Maxime Coquelin wrote: > This patch implements the vDPA .get_features() callback. > > Signed-off-by: Maxime Coquelin > --- > drivers/net/virtio/virtio_vdpa.c | 32 > 1 file changed, 32 insertions(+) > > diff --git a/driv

Re: [dpdk-dev] [PATCH 1/1] net/enic: enic driver doesn't work with 2nd process

2019-09-01 Thread Hyong Youb Kim (hyonkim)
> -Original Message- > From: dev On Behalf Of dirk > Sent: Tuesday, August 27, 2019 6:03 PM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH 1/1] net/enic: enic driver doesn't work with 2nd > process > > net/enic: enic driver doesn't work with 2nd process. the problem is that the > private

Re: [dpdk-dev] [PATCH 07/15] net/virtio: add vDPA ops to get number of queue

2019-09-01 Thread Tiwei Bie
On Thu, Aug 29, 2019 at 09:59:52AM +0200, Maxime Coquelin wrote: > This patch implements the vDPA .get_queue_num() callback. > > Signed-off-by: Maxime Coquelin > --- > drivers/net/virtio/virtio_vdpa.c | 43 > 1 file changed, 43 insertions(+) Reviewed-by: Tiwei B

Re: [dpdk-dev] [PATCH 06/15] net/virtio: add skeleton for virtio vDPA driver

2019-09-01 Thread Tiwei Bie
On Thu, Aug 29, 2019 at 09:59:51AM +0200, Maxime Coquelin wrote: > + > +RTE_PMD_REGISTER_PCI(net_virtio_vdpa, rte_virtio_vdpa); > +RTE_PMD_REGISTER_PCI_TABLE(net_virtio_vdpa, pci_id_virtio_vdpa_map); > +RTE_PMD_REGISTER_KMOD_DEP(net_virtio_vdpa, "* vfio-pci"); > + > +RTE_INIT(virtio_vdpa_init_log)

Re: [dpdk-dev] [PATCH v2] common/dpaax: move shared sec HW code to common

2019-09-01 Thread Akhil Goyal
> > The SEC HW code is being shared by multiple NXP based > drivers. It is better to place it at a common place. > the current users are: > 1. DPAA2_SEC > 2. DPAA_SEC > 3. CAAM_JR > > > Signed-off-by: Hemant Agrawal > --- These are few pending patches related to pdcp which I will be sending

Re: [dpdk-dev] [PATCH 05/15] net/virtio: save notify bar ID in virtio HW struct

2019-09-01 Thread Tiwei Bie
On Thu, Aug 29, 2019 at 09:59:50AM +0200, Maxime Coquelin wrote: > SAving the notify bar ID in the virtio HW struct will be s/SAving/Saving/ > used by the virtio-vdpa driver in its .get_notify_area() > callback. > > Signed-off-by: Maxime Coquelin > --- > drivers/net/virtio/virtio_pci.c | 6 +++

Re: [dpdk-dev] [PATCH 04/15] net/virtio: add virtio PCI subsystem device ID declaration

2019-09-01 Thread Tiwei Bie
On Thu, Aug 29, 2019 at 09:59:49AM +0200, Maxime Coquelin wrote: > The Virtio PCI susbsytem IDs need to be specified to > prevent it to probe IFC vDPA VFs. > > Signed-off-by: Maxime Coquelin > --- > drivers/net/virtio/virtio_pci.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers

Re: [dpdk-dev] [PATCH 03/15] net/virtio: move control path fonctions in virtqueue file

2019-09-01 Thread Tiwei Bie
> net/virtio: move control path fonctions in virtqueue file s/fonctions/functions/ On Thu, Aug 29, 2019 at 09:59:48AM +0200, Maxime Coquelin wrote: > Virtio-vdpa driver needs to implement the control path, > so move related functions to virtqueue file so that it > can be used by both Virtio PMD a

Re: [dpdk-dev] [PATCH 01/15] vhost: remove vhost kernel header inclusion

2019-09-01 Thread Tiwei Bie
On Thu, Aug 29, 2019 at 09:59:46AM +0200, Maxime Coquelin wrote: > This is preliminary rework for virtio-vdpa driver, in > order to avoid conflicts with Virtio PMD headers. > > Generally, I think it is better not to include kernel > headers in RTE headers, especially in the case of Vhost > and Vir

[dpdk-dev] mbuf in chain buffer has packet len as 0 , will it impact TX?

2019-09-01 Thread chetan bhasin
Hello Everyone, I have a use case where one of the buffer in a chain has packet-len 0 , Can anybody suggest whether it will cause a problem while doing a TX ? Thanks, Chetan Bhasin

[dpdk-dev] Stopping DPDK Timer [RTE-Timers]

2019-09-01 Thread Suraj R Gupta
Hi all, I am working with DPDK timers. In the documentation of timers, it has been said that dpdk based rte-timers cannot stopped while running. I would like to know if there is any way to stop it in middle or any workaround is possible. For e.g.: If I have timer started for 500 ms and i want to

Re: [dpdk-dev] [PATCH 22/22] net/hns3: add hns3 build files

2019-09-01 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: Wei Hu (Xavier) > Sent: Saturday, August 31, 2019 7:41 AM > To: Jerin Jacob Kollanukkaran ; dev@dpdk.org > Cc: xavier_hu...@163.com; linux...@huawei.com; > forest.zhouch...@huawei.com > Subject: [EXT] Re: [dpdk-dev] [PATCH 22/22] net/hns3: add hns3 build files

[dpdk-dev] [PATCH 6/8] net/ice/base: propagate errors from functions

2019-09-01 Thread Qi Zhang
There could be an error returned from ice_fill_adv_dummy_packet() so we need to propagate that to the caller. Additionally, the call to ice_flow_xtract_pkt_flags() could also return an error so we need to propagate it as well. Also add in the correct offsets for GENEVE and VXLAN_GPE to the dummy p

[dpdk-dev] [PATCH 5/8] net/ice/base: correct the mask for checking protocol header

2019-09-01 Thread Qi Zhang
Before this patch, the logic of protocol header checking only support non-tunneled packet. This patch remove the inner protocol in L3/L4 RSS seg hdr mask and change the protocol header validation to reflect this. So, for ice_add_rss_cfg(), the last parameter addl_hdrs could specify the protocol hea

[dpdk-dev] [PATCH 8/8] net/ice/base: remove RSS code as iavf host

2019-09-01 Thread Qi Zhang
The DPDK PF doesn't support SRIOV so remove the related iavf host code. Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_flow.c | 128 1 file changed, 128 deletions(-) diff --git a/drivers/net/ice/base/ice_flow.c b

[dpdk-dev] [PATCH 7/8] net/ice/base: remove pointless NULL check of port info

2019-09-01 Thread Qi Zhang
The code in ice_sched_cleanup_all checks whether the port info is NULL prior to calling ice_sched_clear_port. More importantly, it also checks whether the port structure has been initialized by checking its port_state field as well. Signed-off-by: Jacob Keller Signed-off-by: Paul M Stillwell Jr

[dpdk-dev] [PATCH 2/8] net/ice/base: add support for tunnel packets

2019-09-01 Thread Qi Zhang
Add VXLAN tunnel training packets to flow director and change the interface to support tunnel packets. Signed-off-by: Henry Tieman Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_fdir.c | 266 drivers/net/ice/base

[dpdk-dev] [PATCH 3/8] net/ice/base: add non-word aligned ip field support

2019-09-01 Thread Qi Zhang
Add non-word aligned field support for ipv4 with ttl, tos and proto. All these fields are one byte within one word. In order to match bytes within the IPv4 header for flow director we need to use a mask. Signed-off-by: Junfeng Guo Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang ---

[dpdk-dev] [PATCH 0/8] net/ice/base: share code update secend batch.

2019-09-01 Thread Qi Zhang
The patchset depends on the first batch http://patchwork.dpdk.org/project/dpdk/list/?series=6158&state=* Key Features: 1) Add tunnel support for fdir 2) Add non-word aligned field support for fdir Qi Zhang (8): net/ice/base: remove redundant empty lines net/ice/base: add support for tunnel

[dpdk-dev] [PATCH 4/8] net/ice/base: add non-word aligned ipv6 field support

2019-09-01 Thread Qi Zhang
Add non-word aligned field support for IPv6 with hlim, tc and proto. All these fields are one byte within one word. In order to match bytes within the IPv6 header for flow director we need to use a mask. Signed-off-by: Junfeng Guo Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang ---

[dpdk-dev] [PATCH 1/8] net/ice/base: remove redundant empty lines

2019-09-01 Thread Qi Zhang
Remove redundant empty lines Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_adminq_cmd.h| 111 --- drivers/net/ice/base/ice_bitops.h| 2 - drivers/net/ice/base/ice_common.c| 25 --- drivers/net/ice/b

Re: [dpdk-dev] net/ixgbe:fix wrong link status

2019-09-01 Thread Zhao1, Wei
Reviewed-by: Wei Zhao > -Original Message- > From: Zhang, Xiao > Sent: Monday, September 2, 2019 7:52 PM > To: dev@dpdk.org > Cc: Zhao1, Wei ; Zhang, Xiao ; > sta...@dpdk.org > Subject: net/ixgbe:fix wrong link status > > The link status for 82599eb got from link status register was not

[dpdk-dev] [PATCH v3] net/ipn3ke: setup MTU when HW init

2019-09-01 Thread Andy Pei
set up mtu to the minimun in tx mtu, rx mtu and IPN3KE_MAC_FRAME_SIZE_MAX. Signed-off-by: Andy Pei --- Cc: qi.z.zh...@intel.com Cc: ferruh.yi...@intel.com Cc: rosen...@intel.com Cc: xiaolong...@intel.com v2: modify low bound and upper bound. v3: modify according to community comments. drivers

Re: [dpdk-dev] [PATCH v2] net/ipn3ke: setup MTU when HW init

2019-09-01 Thread Pei, Andy
HI xiaolong, Reply inline. -Original Message- From: Ye, Xiaolong Sent: Wednesday, August 21, 2019 2:16 PM To: Pei, Andy Cc: dev@dpdk.org; Xu, Rosen ; Zhang, Tianfei Subject: Re: [dpdk-dev] [PATCH v2] net/ipn3ke: setup MTU when HW init On 08/09, Andy Pei wrote: >set up mtu to the mini

[dpdk-dev] net/ixgbe:fix wrong link status

2019-09-01 Thread Zhang Xiao
The link status for 82599eb got from link status register was not correct, check the enable/disable flag of tx laser when getting the link status, set the link status down if tx laser disabled since the tx laser flag could be set correctly when up/down the link status. Fixes: dc66e5fd01b9 ("net/ix

Re: [dpdk-dev] [PATCH] net/mlx5: fix completion queue drain loop

2019-09-01 Thread Gavin Hu (Arm Technology China)
Hi Viacheslav, > -Original Message- > From: dev On Behalf Of Viacheslav Ovsiienko > Sent: Sunday, August 4, 2019 9:57 PM > To: dev@dpdk.org > Cc: ys...@mellanox.com; shah...@mellanox.com > Subject: [dpdk-dev] [PATCH] net/mlx5: fix completion queue drain loop > > The completion loop speed

[dpdk-dev] [PATCH 15/15] net/bnxt: handle reset notify async event on ns3 devices

2019-09-01 Thread Ajit Khaparde
From: Kalesh AP FW sets HWRM_FUNC_QCAPS_OUTPUT_FLAGS_ERR_RECOVER_RELOAD in HWRM_FUNC_QCAPS command, if device requires to invoke fastboot FW during FW reset. Wait for FW_STATUS to set the SHUTDOWN bit in health register before the master function calls fastboot FW. Signed-off-by: Kalesh AP Rev

[dpdk-dev] [PATCH 13/15] net/bnxt: fix Rx queue count devop

2019-09-01 Thread Ajit Khaparde
From: Rahul Gupta Fix Computing of number of used descriptors in an Rx queue. Fixes: 1b7ceba3e375 ("net/bnxt: support Rx queue count") Signed-off-by: Rahul Gupta Reviewed-by: Ajit Khaparde Reviewed-by: Somnath Kotur Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_ethdev.c | 31 +

[dpdk-dev] [PATCH 12/15] net/bnxt: fix accessing variable before null check

2019-09-01 Thread Ajit Khaparde
From: Kalesh AP Check input argument "rxq" in bnxt_rx_queue_release_mbufs(), to be sure variable is not NULL before accessing it. Fixes: 9b63c6fd70e3 ("net/bnxt: support Rx/Tx queue start/stop") Signed-off-by: Kalesh AP Reviewed-by: Santoshkumar Karanappa Rastapur Reviewed-by: Ajit Khaparde S

[dpdk-dev] [PATCH 14/15] net/bnxt: fix mbuf flags for PTP packets in vector mode Rx

2019-09-01 Thread Ajit Khaparde
From: Kalesh AP PKT_RX_IEEE1588_PTP and PKT_RX_IEEE1588_TMST flags need to be set in the offload flags for the received pkt in case of PTP offload. Fixes: bc4a000f2f53c ("net/bnxt: implement SSE vector mode") Signed-off-by: Kalesh AP Reviewed-by: Somnath Kotur Reviewed-by: Lance Richardson S

[dpdk-dev] [PATCH 11/15] net/bnxt: remove unnecessary interrupt disable

2019-09-01 Thread Ajit Khaparde
From: Kalesh AP Since bnxt_enable_int() is called at start time, invoke bnxt_disable_int() during stop only. Remove it from device uninit function. Signed-off-by: Kalesh AP Reviewed-by: Lance Richardson Reviewed-by: Ajit Khaparde Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_ethdev

[dpdk-dev] [PATCH 07/15] net/bnxt: fix L2 context calculation for Thor

2019-09-01 Thread Ajit Khaparde
From: Kalesh AP On Wh+, number of L2 context supported by FW is the sum of number of EM flow count and number of L2 context count returned in HWRM_FUNC_QCFG. This is not true for Thor. Restrict this only for Whitney for now. Fixes: ff9c0ca47e81176 ("net/bnxt: save the number of EM flow count")

[dpdk-dev] [PATCH 10/15] net/bnxt: remove unused macro

2019-09-01 Thread Ajit Khaparde
From: Kalesh AP remove MAX_NUM_MAC_ADDR macro Signed-off-by: Kalesh AP Reviewed-by: Lance Richardson Reviewed-by: Ajit Khaparde Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/bnxt/bnxt.h b/drivers/net/bnxt/bnxt.h index

[dpdk-dev] [PATCH 09/15] net/bnxt: remove unnecessary return check

2019-09-01 Thread Ajit Khaparde
From: Kalesh AP HWRM_CHECK_RESULT_SILENT() returns if the HWRM command fails. There is no need to check the return value after this call. Signed-off-by: Kalesh AP Reviewed-by: Lance Richardson Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_hwrm.c | 119 +--

[dpdk-dev] [PATCH 08/15] net/bnxt: fix use of deferred start of transmit queues

2019-09-01 Thread Ajit Khaparde
From: Kalesh AP Driver should not change "deferred_start" state of the tx queues. It should get the state in queue_setup_op() and use that value. Since the deferred start state was being used in the packet transmit functions to determine whether the queue has been stopped already, introduced a p

[dpdk-dev] [PATCH 05/15] net/bnxt: fix async link handling and update

2019-09-01 Thread Ajit Khaparde
When updating the link because of an async link notification there is no need to set wait_for_completion. At this point the link related information should be available without need to poll. Use rte_eth_linkstatus_set instead of memcpy to ensure atomicity while updating the link status. We force th

[dpdk-dev] [PATCH 06/15] net/bnxt: fix 40G link failure for Thor

2019-09-01 Thread Ajit Khaparde
From: Santoshkumar Karanappa Rastapur Link autonegotiation for 40G is not supported by Thor. Hence speed needs to be forced and autoneg disabled to configure 40G speed. Fixes: f8168ca0e690 ("net/bnxt: support thor controller") Reviewed-by: Ajit Khaparde Signed-off-by: Santoshkumar Karanappa Ras

[dpdk-dev] [PATCH 04/15] net/bnxt: subscribe to link speed change notification

2019-09-01 Thread Ajit Khaparde
We are not subscribing to link speed change notification. This patch addresses that. Signed-off-by: Ajit Khaparde Reviewed-by: Rahul Gupta Reviewed-by: Santoshkumar Karanappa Rastapur Reviewed-by: Kalesh Anakkur Purayil --- drivers/net/bnxt/bnxt_hwrm.c | 1 + drivers/net/bnxt/bnxt_hwrm.h | 2

[dpdk-dev] [PATCH 03/15] net/bnxt: fix rxq stop/start handling

2019-09-01 Thread Ajit Khaparde
From: Kalesh AP Driver should not change "deferred_start" state of the rx queues. It should get the state in queue_setup_op() and use that value. Since the deferred start state was being used in the packet receive functions to determine whether a stopped rx ring should be polled, introduced a pe

[dpdk-dev] [PATCH 01/15] net/bnxt: fix incorrect flow steering

2019-09-01 Thread Ajit Khaparde
From: Santoshkumar Karanappa Rastapur When user creates a flow similar to an existing flow with just the destination queue change, we delete the old filter and allocate a new one with this destination queue change. We were also allocating a new L2 filter matching the same destination mac resultin

[dpdk-dev] [PATCH 02/15] net/bnxt: fix traffic failure with higher mbuf size

2019-09-01 Thread Ajit Khaparde
From: Santoshkumar Karanappa Rastapur Maximum frame length supported by hw is 9600 bytes. When user launches testpmd with --mbuf-size=9729, we are posting buffer descriptors of size 9601 to the ring. This was causing packets getting discarded. Fixes: daef48efe5e5 ("net/bnxt: support set MTU") Si

[dpdk-dev] [PATCH 00/15] bnxt patchset

2019-09-01 Thread Ajit Khaparde
bnxt patchset against dpdk-next-net. This patchset is **dependent** on "bnxt patchset for thor and bnxt vector PMD" a series submitted eariler. Please apply. Ajit Khaparde (2): net/bnxt: subscribe to link speed change notification net/bnxt: fix async link handling and update Kalesh AP (9):

[dpdk-dev] [PATCH] net/atlantic: get rid of double declaration of dev info get

2019-09-01 Thread Andrew Rybchenko
From: Ivan Ilchenko atl_dev_info_get() is declared twice in atl_ethdev.c. Delete one of these declararions. Fixes: bb42aa9ffe4e ("net/atlantic: configure device start/stop") Cc: sta...@dpdk.org Signed-off-by: Ivan Ilchenko Signed-off-by: Andrew Rybchenko --- drivers/net/atlantic/atl_ethdev.c

Re: [dpdk-dev] [PATCH 1/1] net/mlx4: fix build on PPC64

2019-09-01 Thread Matan Azrad
Hi > From: dev On Behalf Of Christian Ehrhardt > The AltiVec header file breaks boolean type: > > error: incompatible types when initializing type '__vector _bool int' {aka > '_vector(4) __bool int'} using type 'int' > > If __APPLE_ALTIVEC__ is defined, then bool type is redefined and conflicts

[dpdk-dev] [PATCH v2 2/7] net/mlx5: add VLAN push/pop DR commands to glue

2019-09-01 Thread Moti Haimovsky
This commit adds the mlx5dv VLAN push and pop commands to mlx5_glue interface. Signed-off-by: Moti Haimovsky --- drivers/net/mlx5/Makefile| 5 + drivers/net/mlx5/meson.build | 2 ++ drivers/net/mlx5/mlx5_glue.c | 29 + drivers/net/mlx5/mlx5_glue.h | 6 +

[dpdk-dev] [PATCH v2 4/7] net/mlx5: support push flow action on VLAN header

2019-09-01 Thread Moti Haimovsky
This commit adds support for RTE_FLOW_ACTION_TYPE_OF_PUSH_VLAN using direct verbs flow rules. If present in the flow, The VLAN default values are taken from the VLAN item configuration. In this commit only the VLAN TPID value can be set since VLAN modification actions are not supported yet. Signed

[dpdk-dev] [PATCH v2 7/7] net/mlx5: supp modify VLAN ID on existing VLAN hdr

2019-09-01 Thread Moti Haimovsky
This commit adds support for modifying the VID of the outermost VLAN header already present in the packet. Signed-off-by: Moti Haimovsky --- drivers/net/mlx5/mlx5_flow.h| 3 +- drivers/net/mlx5/mlx5_flow_dv.c | 90 +++-- drivers/net/mlx5/mlx5_prm.h |

[dpdk-dev] [PATCH v2 5/7] net/mlx5: support modify VLAN priority on VLAN hdr

2019-09-01 Thread Moti Haimovsky
This commit adds support for modifying the VLAN priority (PCP) field in about-to-be-pushed VLAN header. This feature can only modify the PCP field of a new VLAN header yet to be pushed. It does not support modifying an existing or already pushed VLAN headers. Signed-off-by: Moti Haimovsky --- dr

[dpdk-dev] [PATCH v2 1/7] net/mlx5: support for an action search in a list

2019-09-01 Thread Moti Haimovsky
This commit adds a helper routine that supports searching for a specific action in a list of actions. Signed-off-by: Moti Haimovsky --- drivers/net/mlx5/mlx5_flow.c | 23 +++ drivers/net/mlx5/mlx5_flow.h | 3 +++ 2 files changed, 26 insertions(+) diff --git a/drivers/net/ml

[dpdk-dev] [PATCH v2 6/7] net/mlx5: supp modify VLAN ID on new VLAN header

2019-09-01 Thread Moti Haimovsky
This commit adds support for modifying the VLAN ID (VID) field in an about-to-be-pushed VLAN header. This feature can only modify the VID field of a new VLAN header yet to be pushed. It does not support modifying an existing or already pushed VLAN headers. Signed-off-by: Moti Haimovsky --- drive

[dpdk-dev] [PATCH v2 3/7] net/mlx5: support pop flow action on VLAN header

2019-09-01 Thread Moti Haimovsky
This commit adds support for RTE_FLOW_ACTION_TYPE_OF_POP_VLAN via direct verbs flow rules. Signed-off-by: Moti Haimovsky --- drivers/net/mlx5/mlx5.c | 9 + drivers/net/mlx5/mlx5.h | 1 + drivers/net/mlx5/mlx5_flow.h| 5 ++- drivers/net/mlx5/mlx5_flow_dv.c | 78

[dpdk-dev] [PATCH v2 0/7] net/mlx5: support for flow action on VLAN header

2019-09-01 Thread Moti Haimovsky
VLAN actions support is implemented in librte_ethdev, and in test-pmd application, based on [1] Generic flow API. These actions conform to the VLAN actions defined in [2] the OpenFlow Switch Specification. rte_flow defines the following VLAN actions: 1. OF_POP_VLAN Pop the outer-most VLAN hea