From: Stephen Hemminger
The mp_server incorrectly allows a port mask that included hidden
ports and which later caused either lost packets or failed initialization.
This fixes explicitly checking that each bit in portmask is a
valid port before using it.
Fixes: 5b7ba31148a8 ("ethdev: add port o
From: Stephen Hemminger
The mp_client crashes if run on Azure or any system where ethdev
ports are owned. In that case, the tx_buffer and tx_stats for the
real port were initialized correctly, but the wrong port was used.
For example if the server has Ports 3 and 5. Then calling
rte_eth_tx_buffe
v6 - just include fixes; cleanups can wait until 19.11
v5 - change logic in server_mp for evaluating port mask
v4 - fix checkpatch warning
add patches to fix style issues and use ether format addr
v3 - merge both patches in one series
use alternative algorithm to check port ownership (
02/08/2019 23:25, Aaron Conole:
> This series turns the fast unit tests on for a limited set of
> builds under the travis build system. An example run is available
> at:
>
> https://travis-ci.org/orgcandman/dpdk/builds/565991679
>
> The builds which execute the unit tests may be distinguished by
02/08/2019 23:25, Aaron Conole:
> From: Michael Santana
>
> Currently many unit tests fail when running tests under shared builds.
> This happens because of missing driver dependencies. This is fixed by
> explicitly linking in missing drivers for the test application.
>
> before and after (clang
From: Michael Santana
Currently many unit tests fail when running tests under shared builds.
This happens because of missing driver dependencies. This is fixed by
explicitly linking in missing drivers for the test application.
before and after (clang):
https://travis-ci.com/Maickii/dpdk-2/jobs/2
When building under Travis (or another linux CI service), enable
running the fast-tests when the RUN_TESTS environment variable is set.
For the Travis service, introduce two new shared builds, since the
shared builds are the ones passing. Builds that are statically
linked still show some issues i
This series turns the fast unit tests on for a limited set of
builds under the travis build system. An example run is available
at:
https://travis-ci.org/orgcandman/dpdk/builds/565991679
The builds which execute the unit tests may be distinguished by the
"RUN_TESTS" parameter.
Aaron Conole (1):
Thomas Monjalon writes:
> 02/08/2019 22:59, Aaron Conole:
>> Thomas Monjalon writes:
>> > 31/07/2019 22:54, Michael Santana Francisco:
>> >> On Wed, Jul 31, 2019 at 10:50 AM Aaron Conole wrote:
>> >> > --- a/.ci/linux-build.sh
>> >> > +++ b/.ci/linux-build.sh
>> >> > @@ -22,3 +22,11 @@ fi
>> >>
02/08/2019 22:59, Aaron Conole:
> Thomas Monjalon writes:
> > 31/07/2019 22:54, Michael Santana Francisco:
> >> On Wed, Jul 31, 2019 at 10:50 AM Aaron Conole wrote:
> >> > --- a/.ci/linux-build.sh
> >> > +++ b/.ci/linux-build.sh
> >> > @@ -22,3 +22,11 @@ fi
> >> > OPTS="$OPTS --default-library=$
01/08/2019 12:35, Phil Yang:
> Fixes: c41a04958b ("net/memif: support multi-process")
>
> Signed-off-by: Phil Yang
> Reviewed-by: Gavin Hu
> ---
> --- a/drivers/net/memif/rte_eth_memif.c
> +++ b/drivers/net/memif/rte_eth_memif.c
> @@ -1265,7 +1265,7 @@ rte_pmd_memif_probe(struct rte_vdev_device
Thomas Monjalon writes:
> 31/07/2019 22:54, Michael Santana Francisco:
>> On Wed, Jul 31, 2019 at 10:50 AM Aaron Conole wrote:
>> > --- a/.ci/linux-build.sh
>> > +++ b/.ci/linux-build.sh
>> > @@ -22,3 +22,11 @@ fi
>> > OPTS="$OPTS --default-library=$DEF_LIB"
>> > meson build --werror -Dexample
01/08/2019 14:27, David Marchand:
> The memory tests currently check that, for normal mode (not legacy mode),
> there is no memory left behind when exiting.
I think this is the real bug:
we are checking a behaviour that we cannot achieve currently.
> The problem is that if a ethdev port is alloca
> > > > Following removal of -c and -n options, the array should have been
> > > > shrunk to avoid launch_proc to access unitialised strings.
> > > >
> > > > Fixes: b4dbacdb1ad7 ("test/eal: set core mask/list config only in
> > > > dedicated test")
> > > > Fixes: 501fa9a40298 ("test/eal: set memor
31/07/2019 09:55, David Marchand:
> The tests do not depend on ixgbe or i40e drivers, just remove this
> explicit link that likely comes from a copy/paste from testpmd.
>
> Fixes: b5dc795a8a55 ("test: build app with meson as dpdk-test")
> Cc: sta...@dpdk.org
>
> Signed-off-by: David Marchand
Ap
Thomas Monjalon writes:
> 31/07/2019 16:50, Aaron Conole:
>> From: Michael Santana
>> --- a/app/test/meson.build
>> +++ b/app/test/meson.build
>> +if dpdk_conf.has('RTE_LIBRTE_RING_MEMPOOL')
>> +test_deps += 'mempool_ring'
>> +endif
>> +if dpdk_conf.has('RTE_LIBRTE_STACK_MEMPOOL')
>> +te
31/07/2019 16:50, Aaron Conole:
> From: Michael Santana
> --- a/app/test/meson.build
> +++ b/app/test/meson.build
> +if dpdk_conf.has('RTE_LIBRTE_RING_MEMPOOL')
> + test_deps += 'mempool_ring'
> +endif
> +if dpdk_conf.has('RTE_LIBRTE_STACK_MEMPOOL')
> + test_deps += 'mempool_stack'
> +endi
31/07/2019 22:54, Michael Santana Francisco:
> On Wed, Jul 31, 2019 at 10:50 AM Aaron Conole wrote:
> > --- a/.ci/linux-build.sh
> > +++ b/.ci/linux-build.sh
> > @@ -22,3 +22,11 @@ fi
> > OPTS="$OPTS --default-library=$DEF_LIB"
> > meson build --werror -Dexamples=all $OPTS
> > ninja -C build
>
01/08/2019 10:14, Ananyev, Konstantin:
> >
> > Left-shift of an integer constant is represented as 'int' type, but a left
> > shift of 1 by 31 bits in 'int' is undefined. Use the U suffix to force
> > a representation as unsigned.
> >
> > Caught while running with ubsan under gcc.
> >
> > Fixes
> > Subject: [dpdk-dev] [PATCH] doc: fix guide build warning
> Acked-by: John McNamara
Applied, thanks
Yes, thank you for the patch, acked.
The "txq_inline_min" value was not set for ConnectX-5 to 0 as default.
At the TX queue setup time the "txq_inline_min" is checked against
MLX5_ARG_UNSET and default value 0 is set:
txq_set_params()
...
inlen_mode = (config->txq_inline_min == MLX5_ARG_UNSET) ?
David, Takeshi,
Can you test your setups with (only) this patch?
This should address both of your issues.
Correctly identifies my system as requiring PA mode:
sudo LD_LIBRARY_PATH=/home/davec/src/dpdk/build/lib
/home/davec/src/dpdk/build/app/testpmd --log-level="lib.*:debug" -w
:01:00.0
IOMMU capabilities won't change and must be checked even if no PCI device
seem to be supported yet when EAL initialised.
This is to accommodate with SPDK that registers its drivers after
rte_eal_init(), especially on PPC platform where the IOMMU does not
support VA.
Fixes: 703458e19c16 ("bus/pci
On Fri, 2 Aug 2019 17:08:26 +0100
"Burakov, Anatoly" wrote:
> On 02-Aug-19 3:51 AM, Stephen Hemminger wrote:
> > rte_panic causes a backtrace (which is uniformative since all
> > these calls are in main). Instead use rte_exit and try and make the
> > messages informative.
> >
> > Signed-off-by:
> -Original Message-
> From: dev On Behalf Of Burakov, Anatoly
> Sent: Friday, August 2, 2019 9:35 PM
> To: David Marchand ; dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] doc: announce malloc virt2phys symbol
> removal
>
> On 02-Aug-19 2:29 PM, David Marchand wrote:
> > This symbol has
On 02-Aug-19 3:51 AM, Stephen Hemminger wrote:
rte_panic causes a backtrace (which is uniformative since all
these calls are in main). Instead use rte_exit and try and make the
messages informative.
Signed-off-by: Stephen Hemminger
---
Missed opportunity for a "keep calm" joke...
Reviewed-by
On 02-Aug-19 2:29 PM, David Marchand wrote:
This symbol has been deprecated for quite some time.
Let's drop it in the next release.
Signed-off-by: David Marchand
---
Acked-by: Anatoly Burakov
--
Thanks,
Anatoly
On Fri, 2 Aug 2019 05:33:20 +
Matan Azrad wrote:
> Hi Stephen
>
> One more small comment inline
>
> From: Stephen Hemminger
> > Sent: Friday, August 2, 2019 5:58 AM
> > To: dev@dpdk.org
> > Cc: Stephen Hemminger
> > Subject: [dpdk-dev] [PATCH v5 1/4]
> > examples/multi_process/client_ser
Updates to the ABI versioning guide, to account for the changes to the DPDK
ABI/API policy.
Signed-off-by: Ray Kinsella
---
doc/guides/contributing/abi_versioning.rst | 240 +++--
1 file changed, 159 insertions(+), 81 deletions(-)
diff --git a/doc/guides/contributing/abi
This policy change introduces major ABI versions, these are
declared every year, typically aligned with the LTS release
and are supported by subsequent releases in the following year.
This change is intended to improve ABI stabilty for those projects
consuming DPDK.
Signed-off-by: Ray Kinsella
--
Separate versioning.rst into abi versioning and abi policy guidance, in
preparation for adding more detail to the abi policy.
Signed-off-by: Ray Kinsella
---
doc/guides/contributing/abi_policy.rst | 169 +
doc/guides/contributing/abi_versioning.rst | 427 +
doc/gu
TL;DR Abbreviation:
A major ABI version that all DPDK releases during a one year period
support. ABI versioning is managed at a project-level, in place of library-level
management. ABI changes to add new features are permitted, as long as ABI
compatibility with the major ABI version is maintained.
On Fri, 2 Aug 2019 12:45:55 +0530
Nilesh wrote:
> Hello,
>
> We are building an application where a majority of the packets on the
> fast path are handled by DPDK, but a small subset of packets on the slow
> path need to be redirected to a legacy userspace socket program that
> runs over the
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Mcnamara, John
> Sent: Tuesday, July 30, 2019 10:33 AM
> To: Ergin, Mesut A ; Xing, Beilei
> ; Zhang, Qi Z
> Cc: dev@dpdk.org; Ergin, Mesut A
> Subject: Re: [dpdk-dev] [PATCH] doc: update release note for i40e
On Wed, Jul 31, 2019 at 4:50 PM Aaron Conole wrote:
>
> This series turns the fast unit tests on for a limited set of
> builds under the travis build system. An example run is available
> at:
>
> https://travis-ci.org/orgcandman/dpdk/builds/565991679
>
> The builds which execute the unit tests ma
> -Original Message-
> From: jer...@marvell.com [mailto:jer...@marvell.com]
> Sent: Wednesday, July 31, 2019 4:46 PM
> To: dev@dpdk.org; Mcnamara, John ; Kovacevic,
> Marko
> Cc: tho...@monjalon.net; avi...@marvell.com; Jerin Jacob
>
> Subject: [dpdk-dev] [PATCH v2] doc: add tested Mar
On Fri, Aug 2, 2019 at 3:37 PM Aaron Conole wrote:
>
> David Marchand writes:
>
> > On Thu, Aug 1, 2019 at 2:28 PM David Marchand
> > wrote:
> >>
> >> The memory tests currently check that, for normal mode (not legacy mode),
> >> there is no memory left behind when exiting.
> >>
> >> The proble
> -Original Message-
> From: jer...@marvell.com [mailto:jer...@marvell.com]
> Sent: Friday, August 2, 2019 6:53 AM
> To: dev@dpdk.org; Mcnamara, John ; Kovacevic,
> Marko
> Cc: tho...@monjalon.net; Richardson, Bruce ;
> Jerin Jacob
> Subject: [dpdk-dev] [PATCH] doc: fix guide build war
On Thu, Aug 1, 2019 at 3:25 AM David Marchand wrote:
>
> On Wed, Jul 31, 2019 at 9:57 PM Michael Santana Francisco
> wrote:
> >
> > On Wed, Jul 31, 2019 at 2:56 PM David Marchand
> > wrote:
> > >
> > > Following removal of -c and -n options, the array should have been
> > > shrunk to avoid launc
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Maxime Coquelin
> Sent: Friday, August 2, 2019 8:00 AM
> To: dev@dpdk.org; tho...@monjalon.net; hemant.agra...@nxp.com; Richardson,
> Bruce
> Cc: Maxime Coquelin
> Subject: [dpdk-dev] [PATCH] doc: replace PVP t
On Fri, Aug 2, 2019 at 9:34 AM Aaron Conole wrote:
>
> Michael Santana Francisco writes:
>
> > On Wed, Jul 31, 2019 at 10:50 AM Aaron Conole wrote:
> >>
> >> When building under Travis (or another linux CI service), enable running
> >> the
> >> fast-tests for selected builds. Only the shared b
David Marchand writes:
> On Thu, Aug 1, 2019 at 2:28 PM David Marchand
> wrote:
>>
>> The memory tests currently check that, for normal mode (not legacy mode),
>> there is no memory left behind when exiting.
>>
>> The problem is that if a ethdev port is allocated when scanning pci
>> devices (e
Michael Santana Francisco writes:
> On Wed, Jul 31, 2019 at 10:50 AM Aaron Conole wrote:
>>
>> When building under Travis (or another linux CI service), enable running the
>> fast-tests for selected builds. Only the shared builds are enabled at this
>> point, since they are the ones passing. B
This symbol has been deprecated for quite some time.
Let's drop it in the next release.
Signed-off-by: David Marchand
---
doc/guides/rel_notes/deprecation.rst | 3 +++
1 file changed, 3 insertions(+)
diff --git a/doc/guides/rel_notes/deprecation.rst
b/doc/guides/rel_notes/deprecation.rst
index
Minutes 1 August 2019
Agenda:
* Release Dates
* RC3 Status
* Subtrees
* OvS
* Opens
Participants:
* Cavium/Marvell
* Debian/Microsoft
* Intel
* Mellanox
* NXP
* Red Hat
Release Dates
-
* v19.08 dates:
* RC2 is released on Tuesday 23 July
* https://mail
> -Original Message-
> From: Zhang, Tianfei
> Sent: Friday, August 2, 2019 3:36 PM
> To: Jerin Jacob Kollanukkaran ; Xu, Rosen
> ; dev@dpdk.org
> Cc: Yigit, Ferruh ; Pei, Andy ;
> Lomartire, David ; Zhang, Qi Z
> ; Ye, Xiaolong
> Subject: [EXT] RE: [dpdk-dev] [PATCH v2 02/12] raw/ifpga_ra
On Thu, Aug 1, 2019 at 2:29 PM David Marchand wrote:
>
> On Thu, Aug 1, 2019 at 2:28 PM David Marchand
> wrote:
> >
> > The memory tests currently check that, for normal mode (not legacy mode),
> > there is no memory left behind when exiting.
> >
> > The problem is that if a ethdev port is alloc
On Fri, Aug 2, 2019 at 4:59 AM Stephen Hemminger
wrote:
>
> Lots of little style complaints from checkpatch.
>
> Signed-off-by: Stephen Hemminger
> ---
> .../client_server_mp/mp_server/args.c | 37 -
> .../client_server_mp/mp_server/init.c | 79 +++
> .../
Acked-by: Hemant Agrawal
Acked-by: Hemant Agrawal
On Fri, Aug 2, 2019 at 12:14 PM David Marchand
wrote:
>
> IOMMU capabilities won't change and must be checked even if no PCI device
> seem to be supported yet when EAL initialised.
>
> This is to accommodate with SPDK that registers its drivers after
> rte_eal_init(), especially on PPC platform wh
IOMMU capabilities won't change and must be checked even if no PCI device
seem to be supported yet when EAL initialised.
This is to accommodate with SPDK that registers its drivers after
rte_eal_init(), especially on PPC platform where the IOMMU does not
support VA.
Fixes: 703458e19c16 ("bus/pci:
> -Original Message-
> From: Jerin Jacob Kollanukkaran [mailto:jer...@marvell.com]
> Sent: Friday, August 2, 2019 11:58 AM
> To: Xu, Rosen ; dev@dpdk.org
> Cc: Yigit, Ferruh ; Zhang, Tianfei
> ; Pei, Andy ; Lomartire,
> David ; Zhang, Qi Z ; Ye,
> Xiaolong
> Subject: RE: [dpdk-dev] [PAT
> -Original Message-
> From: vattun...@marvell.com
> Sent: Friday, August 2, 2019 12:27 PM
> To: dev@dpdk.org
> Cc: tho...@monjalon.net; Jerin Jacob Kollanukkaran ;
> Vamsi Krishna Attunuru ; Nithin Kumar
> Dabilpuram
> Subject: [dpdk-dev] [PATCH v3 1/1] common/octeontx2: fix unaligned mb
This macro is unused after a previous fix.
Fixes: fe822eb8c565 ("bus/pci: use IOVA DMA mask check when setting IOVA mode")
Cc: sta...@dpdk.org
Signed-off-by: David Marchand
---
drivers/bus/pci/linux/pci.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/bus/pci/linux/pci.c b/drivers/b
The rte_flow_item_vlan has the inner_type, which is missing on
DR/DV flow engine.
By adding this support, the example testpmd commands could be:
- matching all vlan traffic with id 2:
testpmd> flow create 0 ingress pattern eth / vlan vid is 2 / end
actions queue index 2 / end
- mat
From: Sylvain Rodon
Timestamp is always set in PCAP header, whether it reads a file or
listen on an interface. This information can be important for some
applications and it cannot be obtained otherwise (especially when
reading a PCAP file, where the timestamp is not the current time).
Timestamp
From: Sylvain Rodon
Timestamp is always set in PCAP header, whether it reads a file or
listen on an interface. This information can be important for some
applications and it cannot be obtained otherwise (especially when
reading a PCAP file, where the timestamp is not the current time).
Timestamp
On 01-Aug-19 2:01 PM, David Marchand wrote:
Hello Anatoly,
On Wed, Jul 31, 2019 at 5:36 AM Takeshi Yoshimura wrote:
Commit b76fafb174d2 ("eal: fix IOVA mode selection as VA for PCI
drivers") breaks ppc apps with no IOVA configs (or RTE_IOVA_DC)
because of the inconsistency of user's request a
On Fri, Aug 2, 2019 at 10:09 AM Takeshi T Yoshimura wrote:
>
> -David Marchand wrote: -
>
> >To: Takeshi T Yoshimura
> >From: David Marchand
> >Date: 08/01/2019 06:47PM
> >Cc: dev , David Christensen
> >Subject: [EXTERNAL] Re: [dpdk-dev] [PATCH] eal: forcing IOVA as PA in
> >ppc
> >
>
-David Marchand wrote: -
>To: Takeshi T Yoshimura
>From: David Marchand
>Date: 08/01/2019 06:47PM
>Cc: dev , David Christensen
>Subject: [EXTERNAL] Re: [dpdk-dev] [PATCH] eal: forcing IOVA as PA in
>ppc
>
>On Thu, Aug 1, 2019 at 10:46 AM Takeshi T Yoshimura
>wrote:
>>
>> > - Are the (
a new mail box version of ixgbe_mbox_api_13 need to enable for pf
host, in order that it can communicate with vf for queue number.
Signed-off-by: Wei Zhao
---
drivers/net/ixgbe/ixgbe_pf.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ixgbe/ixgbe_pf.c b/drivers/net/ixgbe/ixgbe_p
Hello,
We are building an application where a majority of the packets on the
fast path are handled by DPDK, but a small subset of packets on the slow
path need to be redirected to a legacy userspace socket program that
runs over the kernel TCP/IP stack. Therefore, we are trying to inject
the
Hi,
> -Original Message-
> From: Jerin Jacob Kollanukkaran [mailto:jer...@marvell.com]
> Sent: Friday, August 02, 2019 12:15
> To: Xu, Rosen ; dev@dpdk.org
> Cc: Yigit, Ferruh ; Zhang, Tianfei
> ; Pei, Andy ; Lomartire,
> David ; Zhang, Qi Z ; Ye,
> Xiaolong
> Subject: RE: [dpdk-dev] [PAT
Signed-off-by: Maxime Coquelin
---
doc/guides/howto/pvp_reference_benchmark.rst | 32 ++--
1 file changed, 3 insertions(+), 29 deletions(-)
diff --git a/doc/guides/howto/pvp_reference_benchmark.rst
b/doc/guides/howto/pvp_reference_benchmark.rst
index b90c63457..64b1f4d8e 100644
65 matches
Mail list logo
