[dpdk-dev] [PATCH v2] mempool/octeontx2: fix possible ABI break with force inline

2019-07-17 Thread pbhagavatula
From: Pavan Nikhilesh Since direct register access is used in npa_lf_aura_op_alloc_bulk() use __rte_noinline instead of __rte_always_inline to preserve ABI. Based on the compiler npa_lf_aura_op_alloc_bulk might be inlined differently which may lead to undefined behaviour due to handcoded asm. Fi

[dpdk-dev] [PATCH v3 2/4] eal: fix IOVA mode selection as VA for pci drivers

2019-07-17 Thread jerinj
From: David Marchand The incriminated commit broke the use of RTE_PCI_DRV_IOVA_AS_VA which was intended to mean "driver only supports VA" but had been understood as "driver supports both PA and VA" by most net drivers and used to let dpdk processes to run as non root (which do not have access to

[dpdk-dev] [PATCH v3 4/4] eal: select IOVA mode as VA for default case

2019-07-17 Thread jerinj
From: Jerin Jacob When bus layer selected the preferred mode as RTE_IOVA_DC then select the IOVA mode as RTE_IOVA_VA. The RTE_IOVA_VA selected as the default because, 1) All drivers work in RTE_IOVA_VA mode, irrespective of physical address availability. 2) By default, the mempool, first asks

[dpdk-dev] [PATCH v3 1/4] Revert "bus/pci: add Mellanox kernel driver type"

2019-07-17 Thread jerinj
From: David Marchand This reverts commit 0cb86518db57d35e0abc14d6703fad561a0310e2. The pci bus now reports DC when faced with a device bound to an unknown driver and, in such a case, the IOVA mode is selected against physical address availability. As a consequence, there is no reason for this s

[dpdk-dev] [PATCH v3 3/4] eal: change RTE_PCI_DRV_IOVA_AS_VA flag name

2019-07-17 Thread jerinj
From: Jerin Jacob In order to align name with other PCI driver flag such as RTE_PCI_DRV_NEED_MAPPING and to reflect its purpose, Change RTE_PCI_DRV_IOVA_AS_VA flag name as RTE_PCI_DRV_NEED_IOVA_AS_VA. Signed-off-by: Jerin Jacob --- drivers/bus/pci/linux/pci.c | 4 ++-- drivers/

[dpdk-dev] [PATCH v3 0/4] Fixes on IOVA mode selection

2019-07-17 Thread jerinj
From: Jerin Jacob Orginal V1 cover letter from David Marchand: Following the issues reported by Jerin and the discussion that emerged from it, here are fixes to restore and document the behavior of the EAL and the pci bus driver. I pondered all the arguments and tried to have the less changes p

Re: [dpdk-dev] [PATCH] net/i40e: fix request queue fail in VF

2019-07-17 Thread Ye Xiaolong
On 07/18, taox@intel.com wrote: >From: Zhu Tao > >When the VF configuration is larger than the number of queues reserved >by PF, VF sends the request queue command through admin queue. When PF >received this command, it may reset the VF and send a notification >before resetting. If this notifi

[dpdk-dev] [PATCH v6 4/4] lib/lpm: use atomic store to avoid partial update

2019-07-17 Thread Ruifeng Wang
Compiler could generate non-atomic stores for whole table entry updating. This may cause incorrect nexthop to be returned, if the byte with valid flag is updated prior to the byte with nexthop is updated. Besides, field by field updating of table entries follow read-modify-write sequences. The oper

[dpdk-dev] [PATCH v6 2/4] lib/lpm: memory orderings to avoid race conditions for v1604

2019-07-17 Thread Ruifeng Wang
When a tbl8 group is getting attached to a tbl24 entry, lookup might fail even though the entry is configured in the table. For ex: consider a LPM table configured with 10.10.10.1/24. When a new entry 10.10.10.32/28 is being added, a new tbl8 group is allocated and tbl24 entry is changed to point

[dpdk-dev] [PATCH v6 3/4] lib/lpm: memory orderings to avoid race conditions for v20

2019-07-17 Thread Ruifeng Wang
When a tbl8 group is getting attached to a tbl24 entry, lookup might fail even though the entry is configured in the table. For ex: consider a LPM table configured with 10.10.10.1/24. When a new entry 10.10.10.32/28 is being added, a new tbl8 group is allocated and tbl24 entry is changed to point

[dpdk-dev] [PATCH v6 0/4] LPM4 memory ordering changes

2019-07-17 Thread Ruifeng Wang
LPM4 uses DIR24-8 method of routing info data organization. Routing rule with prefix longer than 24 bits will be stored in a tbl24 entry together with an associated tbl8 group. When a tbl8 group is getting attached to a tbl24 entry, lookup might fail even though the entry is configured in the tabl

[dpdk-dev] [PATCH v6 1/4] lib/lpm: not inline unnecessary functions

2019-07-17 Thread Ruifeng Wang
Tests showed that the function inlining caused performance drop on some x86 platforms with the memory ordering patches applied. By force no-inline functions, the performance was better than before on x86 and no impact to arm64 platforms. Besides inlines of other functions are removed to let compil

[dpdk-dev] [PATCH] net/i40e: fix request queue fail in VF

2019-07-17 Thread taox . zhu
From: Zhu Tao When the VF configuration is larger than the number of queues reserved by PF, VF sends the request queue command through admin queue. When PF received this command, it may reset the VF and send a notification before resetting. If this notification is read by the timed task alarm, Ta

Re: [dpdk-dev] [PATCH] mempool/octeontx2: use noinline to preserve ABI

2019-07-17 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: pbhagavat...@marvell.com > Sent: Thursday, July 18, 2019 12:10 AM > To: Jerin Jacob Kollanukkaran ; Nithin Kumar > Dabilpuram ; Vamsi Krishna Attunuru > > Cc: dev@dpdk.org; Pavan Nikhilesh Bhagavatula > > Subject: [dpdk-dev][PATCH] mempool/octeontx2: use noin

[dpdk-dev] [PATCH] examples/ipsec-secgw: add parameter --mtu parse option

2019-07-17 Thread taox . zhu
From: Zhu Tao This patch add parameter --mtu parse key and enumeration value. Signed-off-by: Zhu Tao --- examples/ipsec-secgw/ipsec-secgw.c | 1 + 1 file changed, 1 insertion(+) diff --git a/examples/ipsec-secgw/ipsec-secgw.c b/examples/ipsec-secgw/ipsec-secgw.c index b1ecbb975..05fffa967 10

Re: [dpdk-dev] [EXT] Re: [PATCH v3] app/testpmd: add device related cmds

2019-07-17 Thread Nithin Kumar Dabilpuram
Hi Ferruh, On 7/17/2019 10:21 PM, Ferruh Yigit wrote: > External Email > > -- > On 7/17/2019 1:30 PM, Nithin Dabilpuram wrote: >> With the latest published interface of >> rte_eal_hotplug_[add,remove](), and rte_eth_dev_close(), >

[dpdk-dev] [PATCH 22/22] net/bnxt: update HWRM API to version 1.10.0.91

2019-07-17 Thread Ajit Khaparde
Update HWRM API to version 1.10.0.91 Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/hsi_struct_def_dpdk.h | 1283 1 file changed, 1100 insertions(+), 183 deletions(-) diff --git a/drivers/net/bnxt/hsi_struct_def_dpdk.h b/drivers/net/bnxt/hsi_struct_def_dpdk.h index

[dpdk-dev] [PATCH 21/22] net/bnxt: fix to correctly check result of HWRM command

2019-07-17 Thread Ajit Khaparde
From: Kalesh AP HWRM_CHECK_RESULT macro is used to check the status of HWRM commands. Fixes: 18c2854b96dd149 ("net/bnxt: configure a default VF VLAN") Cc: sta...@dpdk.org Signed-off-by: Kalesh AP Reviewed-by: Somnath Kotur --- drivers/net/bnxt/bnxt_hwrm.c | 9 + 1 file changed, 1 ins

[dpdk-dev] [PATCH 18/22] net/bnxt: pass correct RSS table address for thor

2019-07-17 Thread Ajit Khaparde
From: Lance Richardson The current implementation erroneously passes the address of the beginning of RSS table for each 64-entry context instead of the address of the appropriate subtable for the context. This results in only the first 64 receive queues being used. Fix by passing the correct addr

[dpdk-dev] [PATCH 20/22] net/bnxt: fix MAC/VLAN filter allocation failure

2019-07-17 Thread Ajit Khaparde
From: Santoshkumar Karanappa Rastapur We were adding the VLAN filters to all the VNICs of the function. Also, we were adding these VLANs to all the existing MAC only filters. This was resulting in fewer VLANs getting added. By default we should allocate MAC+VLAN filter only to the default VNIC of

[dpdk-dev] [PATCH 16/22] net/bnxt: fully initialize hwrm msgs for thor RSS cfg

2019-07-17 Thread Ajit Khaparde
From: Lance Richardson Fully initialize hwrm messages for thor RSS configuration to avoid hwrm duplicate sequence numbers. Fixes: 38412304b50a ("net/bnxt: enable RSS for thor-based controllers") Reviewed-by: Kalesh Anakkur Purayil Signed-off-by: Lance Richardson --- drivers/net/bnxt/bnxt_hwrm

[dpdk-dev] [PATCH 19/22] net/bnxt: avoid overrun in get statistics

2019-07-17 Thread Ajit Khaparde
From: Lance Richardson Avoid overrun in rte_eth_stats struct when the number of tx/rx rings in use is greater than RTE_ETHDEV_QUEUE_STAT_CNTRS. Fixes: 57d5e5bc86e4 ("net/bnxt: add statistics") Cc: sta...@dpdk.org Reviewed-by: Kalesh Anakkur Purayil Reviewed-by: Ajit Khaparde Signed-off-by: Lan

[dpdk-dev] [PATCH 15/22] net/bnxt: use correct RSS table sizes

2019-07-17 Thread Ajit Khaparde
From: Lance Richardson RSS table size is variable with BCM57500-based adapters. Use correct size when allocating memory for RSS state. Fixes: 05375e6f58df ("net/bnxt: enable rss for thor-based adapters") Reviewed-by: Ajit Khaparde Reviewed-by: Somnath Kotur Signed-off-by: Lance Richardson ---

[dpdk-dev] [PATCH 17/22] net/bnxt: use correct number of RSS contexts for thor

2019-07-17 Thread Ajit Khaparde
From: Lance Richardson BCM57500-based adapters use a variable number of RSS contexts depending upon the number of receive rings in use. The current implementation is erroneously using the maximum possible number of RSS contexts instead of the actual number allocated when setting up RSS tables in

[dpdk-dev] [PATCH 10/22] net/bnxt: retry irq callback deregistration

2019-07-17 Thread Ajit Khaparde
From: Lance Richardson rte_intr_callback_unregister() can fail if the handler happens to be active at the time of the call. Add logic to retry a reasonable number of times to help ensure that the callback is unregistered on uninit. Fixes: 7bc8e9a227cc ("net/bnxt: support async link notification"

[dpdk-dev] [PATCH 13/22] net/bnxt: fix lock release on getting NVM info

2019-07-17 Thread Ajit Khaparde
From: Kalesh AP HWRM response was parsed after releasing the spinlock. Fixes: 19e6af01bb36 ("net/bnxt: support get/set EEPROM") Cc: sta...@dpdk.org Signed-off-by: Kalesh AP Reviewed-by: Somnath Kotur --- drivers/net/bnxt/bnxt_hwrm.c | 9 - 1 file changed, 4 insertions(+), 5 deletions

[dpdk-dev] [PATCH 14/22] net/bnxt: fix RSS disable issue for thor-based adapters

2019-07-17 Thread Ajit Khaparde
From: Santoshkumar Karanappa Rastapur In bnxt_hwrm_vnic_rss_cfg_thor, we were exiting if hash_type is 0. This was preventing RSS getting disabled. Fixing it by removing the check for hash_type while configuring RSS. Fixes: 38412304b50a ("net/bnxt: enable RSS for thor-based controllers") Reviewe

[dpdk-dev] [PATCH 08/22] net/bnxt: use correct vnic default completion ring

2019-07-17 Thread Ajit Khaparde
From: Lance Richardson Use the completion ring associated with the default Rx ring when configuring the default completion ring ID instead of the async completion ring ID. Fixes: f8168ca0e690 ("net/bnxt: support thor controller") Reviewed-by: Ajit Kumar Khaparde Signed-off-by: Lance Richardson

[dpdk-dev] [PATCH 11/22] net/bnxt: fix error checking of FW commands

2019-07-17 Thread Ajit Khaparde
From: Kalesh AP HWRM_CHECK_RESULT() checks the return value of HWRM command and returns in case the command fails. There is no need of return value check after HWRM_CHECK_RESULT(). Fixes: 49947a13ba9e ("net/bnxt: support Tx loopback, set VF MAC and queues drop") Cc: sta...@dpdk.org Signed-off-

[dpdk-dev] [PATCH 12/22] net/bnxt: fix to return standard error codes

2019-07-17 Thread Ajit Khaparde
From: Kalesh AP Fixed the return values of few routines to return standard error code. Also fixed few error logs to more meaningful one. Fixes: 804e746c7b7338 ("net/bnxt: add hardware resource manager init code") Fixes: e3d8f1e6a665f9 ("net/bnxt: cache address of doorbell to subsequent access")

[dpdk-dev] [PATCH 09/22] net/bnxt: use dedicated cpr for async events

2019-07-17 Thread Ajit Khaparde
From: Lance Richardson This commit enables the creation of a dedicated completion ring for asynchronous event handling instead of handling these events on a receive completion ring. For the stingray platform and other platforms needing tighter control of resource utilization, we retain the abili

[dpdk-dev] [PATCH 06/22] net/bnxt: fix failure path in dev init

2019-07-17 Thread Ajit Khaparde
From: Kalesh AP 1. bnxt_dev_init() invokes bnxt_dev_uninit() on failure. So there is no need to do individual function cleanups in failure path. 2. rearrange the check for primary process to remove an unwanted goto. 3. fix to invoke bnxt_hwrm_func_buf_unrgtr() in bnxt_dev_uninit() when it i

[dpdk-dev] [PATCH 07/22] net/bnxt: reset filters before registering interrupts

2019-07-17 Thread Ajit Khaparde
From: Kalesh AP If interrupt registration fails during device init, driver invokes uninit which in turn causes error messages while trying to free vnic filters. Fix this by moving filter initialization call before interrupt registration. Fixes: 1b533790f44e ("net/bnxt: avoid invalid vnic id in s

[dpdk-dev] [PATCH 04/22] net/bnxt: fix an unconditional wait in link update

2019-07-17 Thread Ajit Khaparde
From: Kalesh AP There is an unconditional delay in link update op. Fixed it to wait only if wait for request completion is set. Fixes: 7bc8e9a227ccbc64 ("net/bnxt: support async link notification") Cc: sta...@dpdk.org Signed-off-by: Kalesh AP Reviewed-by: Lance Richardson --- drivers/net/bnx

[dpdk-dev] [PATCH 03/22] net/bnxt: fix failure to add a MAC address

2019-07-17 Thread Ajit Khaparde
From: Kalesh AP HWRM command to add MAC address can fail. Driver should check the return value of HWRM command and do the house keeping properly. Fixes: 778b759ba10e45208 ("net/bnxt: add MAC address") Cc: sta...@dpdk.org Signed-off-by: Kalesh AP Reviewed-by: Somnath Kotur Reviewed-by: Ajit Kh

[dpdk-dev] [PATCH 00/22] bnxt patchset

2019-07-17 Thread Ajit Khaparde
This patchset based on commit a164bb7c0a5ab3b100357cf56696c945fe28ab73 contains bug fixes and an update to the HWRM API. Please apply. Ajit Khaparde (1): net/bnxt: update HWRM API to version 1.10.0.91 Kalesh AP (11): net/bnxt: fix to handle error case during port start net/bnxt: fix return

[dpdk-dev] [PATCH 01/22] net/bnxt: fix to handle error case during port start

2019-07-17 Thread Ajit Khaparde
From: Kalesh AP 1. during port start, if bnxt_init_chip() return error bnxt_dev_start_op() invokes bnxt_shutdown_nic() which in turn calls bnxt_free_all_hwrm_resources() to free up resources. Hence remove the bnxt_free_all_hwrm_resources() from bnxt_init_chip() failure path. 2. fix to ch

[dpdk-dev] [PATCH 02/22] net/bnxt: fix return value check of address mapping

2019-07-17 Thread Ajit Khaparde
From: Kalesh AP rte_mem_virt2iova() function returns RTE_BAD_IOVA on failure, not zero. Fixes: 62196f4e0941 ("mem: rename address mapping function to IOVA") Cc: sta...@dpdk.org Signed-off-by: Kalesh AP Reviewed-by: Somnath Kotur --- drivers/net/bnxt/bnxt_ethdev.c | 6 +++--- drivers/net/bnx

[dpdk-dev] [PATCH 05/22] net/bnxt: fix setting primary MAC address

2019-07-17 Thread Ajit Khaparde
From: Kalesh AP 1. Default filter is tied to VNIC 0 at index 0. After finding the filter with mac_index 0 and set the new MAC address, looping through remaining filters is unnecessary. 2. Added a check for NULL MAC address. 3. bnxt_hwrm_set_l2_filter() clears the existing filter configurati

Re: [dpdk-dev] [PATCH 2/3] net/ice: fix flow action validation

2019-07-17 Thread Yang, Qiming
-Original Message- From: Wang, Ying A Sent: Thursday, July 18, 2019 9:39 AM To: Zhang, Qi Z Cc: Yang, Qiming ; dev@dpdk.org; Wang, Ying A ; sta...@dpdk.org Subject: [PATCH 2/3] net/ice: fix flow action validation Action is a list. We should check each element of the action rather tha

Re: [dpdk-dev] [PATCH 3/3] net/ice: add flow ipv6 tc support

2019-07-17 Thread Yang, Qiming
-Original Message- From: Wang, Ying A Sent: Thursday, July 18, 2019 9:39 AM To: Zhang, Qi Z Cc: Yang, Qiming ; dev@dpdk.org; Wang, Ying A ; sta...@dpdk.org Subject: [PATCH 3/3] net/ice: add flow ipv6 tc support When set flow ipv6 tc rule, ice_get_flow_field will set error. This patch

Re: [dpdk-dev] [PATCH 1/3] net/ice: fix flow get inputset check

2019-07-17 Thread Wang, Ying A
> -Original Message- > From: Yang, Qiming > Sent: Thursday, July 18, 2019 10:47 AM > To: Wang, Ying A ; Zhang, Qi Z > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: RE: [PATCH 1/3] net/ice: fix flow get inputset check > > So I think the bug is the skipped pattern don't pass to the next f

Re: [dpdk-dev] [PATCH 1/3] net/ice: fix flow get inputset check

2019-07-17 Thread Yang, Qiming
So I think the bug is the skipped pattern don't pass to the next function. -Original Message- From: Wang, Ying A Sent: Thursday, July 18, 2019 10:40 AM To: Yang, Qiming ; Zhang, Qi Z Cc: dev@dpdk.org; sta...@dpdk.org Subject: RE: [PATCH 1/3] net/ice: fix flow get inputset check >

Re: [dpdk-dev] [PATCH 1/3] net/ice: fix flow get inputset check

2019-07-17 Thread Wang, Ying A
> -Original Message- > From: Yang, Qiming > Sent: Thursday, July 18, 2019 10:33 AM > To: Wang, Ying A ; Zhang, Qi Z > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: RE: [PATCH 1/3] net/ice: fix flow get inputset check > > It's no need to add RTE_FLOW_ITEM_TYPE_VOID because we have skippe

Re: [dpdk-dev] [PATCH 2/3] net/ice: fix flow action validation

2019-07-17 Thread Yang, Qiming
Hi, Ying For the action check reorganization, please according to Beilei's comments, use array to stand the action element list. And as we discussed before, it's better to change in the next release. Qiming -Original Message- From: Wang, Ying A Sent: Thursday, July 18, 2019 9:39 AM To:

Re: [dpdk-dev] [PATCH 1/3] net/ice: fix flow get inputset check

2019-07-17 Thread Yang, Qiming
It's no need to add RTE_FLOW_ITEM_TYPE_VOID because we have skipped all the VOID items. -Original Message- From: Wang, Ying A Sent: Thursday, July 18, 2019 9:39 AM To: Zhang, Qi Z Cc: Yang, Qiming ; dev@dpdk.org; Wang, Ying A ; sta...@dpdk.org Subject: [PATCH 1/3] net/ice: fix flow get

Re: [dpdk-dev] [PATCH 2/3] net/ice: fix flow action validation

2019-07-17 Thread Ye Xiaolong
On 07/18, Wang Ying A wrote: >Action is a list. We should check each element of the action >rather than the first one. >This patch fixes this issue. > >Fixes: d76116a4678f ("net/ice: add generic flow API") >Cc: sta...@dpdk.org > >Signed-off-by: Wang Ying A >--- > drivers/net/ice/ice_generic_flow.c

[dpdk-dev] [PATCH 0/3] ice: flow inputset/action validation fix and add ipv6 tc support

2019-07-17 Thread Wang Ying A
Patch 1/3 avoids set error for RTE_FLOW_ITEM_TYPE_VOID in inputset check. Patch 2/3 adds check for each element of action list. Patch 3/3 adds ipv6 tc support for flow rule. Wang Ying A (3): net/ice: fix flow get inputset check net/ice: fix flow action validation net/ice: add flow ipv6 tc su

[dpdk-dev] [PATCH 3/3] net/ice: add flow ipv6 tc support

2019-07-17 Thread Wang Ying A
When set flow ipv6 tc rule, ice_get_flow_field will set error. This patch fixes this issue. Fixes: d76116a4678f ("net/ice: add generic flow API") Cc: sta...@dpdk.org Signed-off-by: Wang Ying A --- drivers/net/ice/ice_generic_flow.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-

[dpdk-dev] [PATCH 1/3] net/ice: fix flow get inputset check

2019-07-17 Thread Wang Ying A
ice_get_flow_field should not set error if item->type is RTE_FLOW_ITEM_TYPE_VOID. This patch fixes this issue. Fixes: d76116a4678f ("net/ice: add generic flow API") Cc: sta...@dpdk.org Signed-off-by: Wang Ying A --- drivers/net/ice/ice_generic_flow.c | 4 +++- 1 file changed, 3 insertions(+), 1

[dpdk-dev] [PATCH 2/3] net/ice: fix flow action validation

2019-07-17 Thread Wang Ying A
Action is a list. We should check each element of the action rather than the first one. This patch fixes this issue. Fixes: d76116a4678f ("net/ice: add generic flow API") Cc: sta...@dpdk.org Signed-off-by: Wang Ying A --- drivers/net/ice/ice_generic_flow.c | 39 -

[dpdk-dev] [PATCH v2 2/3] cfgfile: use RTE_LOG for errors

2019-07-17 Thread Stephen Hemminger
In general, DPDK libraries to not print error messages to stdout because that is often redirected to /dev/null for daemons. This patch changes cfgfile library to use RTE_LOG with its own type. Signed-off-by: Stephen Hemminger --- lib/librte_cfgfile/Makefile | 1 + lib/librte_cfgfile/rte_cf

[dpdk-dev] [PATCH v2 1/3] cfgfile: remove unnecessary initialization

2019-07-17 Thread Stephen Hemminger
No need to initialize variable if it is immediately overwritten. It is better style not do unnecessary initialization with modern tools since it lets compiler and other static checkers detect uninitialized data. Signed-off-by: Stephen Hemminger --- lib/librte_cfgfile/rte_cfgfile.c | 8

[dpdk-dev] [PATCH v2 0/3] cfgfile: cleanup patches

2019-07-17 Thread Stephen Hemminger
Small cleanups to cfgfile library Stephen Hemminger (3): cfgfile: remove unnecessary initialization cfgfile: use RTE_LOG for errors cfgfile: use calloc lib/librte_cfgfile/Makefile | 1 + lib/librte_cfgfile/rte_cfgfile.c | 55 +--- 2 files changed, 37 inser

[dpdk-dev] [PATCH v2 3/3] cfgfile: use calloc

2019-07-17 Thread Stephen Hemminger
Better to use calloc when allocating arrays. Signed-off-by: Stephen Hemminger --- lib/librte_cfgfile/rte_cfgfile.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/lib/librte_cfgfile/rte_cfgfile.c b/lib/librte_cfgfile/rte_cfgfile.c index 388415147930..9049fd9c2319 100

Re: [dpdk-dev] [PATCH 2/3] cfgfile: use RTE_LOG for errors

2019-07-17 Thread Stephen Hemminger
On Wed, 17 Jul 2019 23:01:00 +0200 Thomas Monjalon wrote: > 16/07/2019 19:27, Stephen Hemminger: > > In general, DPDK libraries to not print error messages to > > stdout because that is often redirected to /dev/null for daemons. > > This patch changes cfgfile library to use RTE_LOG with its > > o

[dpdk-dev] [PATCH] doc: fix PDF build of bbdev prog guide

2019-07-17 Thread Thomas Monjalon
Some machine (like on dpdk.org) may fail to build the prog guide PDF because of the complex table inserted in the bbdev chapter. Fixes: 3f3f608142cf ("doc: update bbdev guide for 5GNR operations") Cc: nicolas.chau...@intel.com Signed-off-by: Thomas Monjalon --- Anyway all the documentation about

Re: [dpdk-dev] [PATCH 2/3] cfgfile: use RTE_LOG for errors

2019-07-17 Thread Thomas Monjalon
16/07/2019 19:27, Stephen Hemminger: > In general, DPDK libraries to not print error messages to > stdout because that is often redirected to /dev/null for daemons. > This patch changes cfgfile library to use RTE_LOG with its > own type. > > Signed-off-by: Stephen Hemminger > --- > --- a/lib/libr

Re: [dpdk-dev] [PATCH v1] examples/power: fix policy handling for fifo

2019-07-17 Thread Thomas Monjalon
16/07/2019 15:44, Burakov, Anatoly: > On 16-Jul-19 12:11 PM, David Hunt wrote: > > While the core frequency scale-up and scale down all works fine with the > > fifo-per-core functionaliry, there was a gap for policy handling. When > > creating or destroying a policy, the core associated with the fi

Re: [dpdk-dev] [PATCH v1] examples/power: fix busyness number limed to 50%

2019-07-17 Thread Thomas Monjalon
16/07/2019 15:50, Burakov, Anatoly: > On 15-Jul-19 3:07 PM, David Hunt wrote: > > Current implementation only outputs 3 numbers for busyness, 0, 50 and 100. > > Fix this so that the 50% is replaced by a curve, more meaningful. > > This can be replaced in each use case by a suitable calculation for

Re: [dpdk-dev] [PATCH] maintainers: add Andrew for next-net tree

2019-07-17 Thread Andrew Rybchenko
On 7/17/19 8:50 PM, Ferruh Yigit wrote: Adding Andrew as co-maintainer to next-net sub-tree. Signed-off-by: Ferruh Yigit --- Cc: Andrew Rybchenko --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index a984ab194..c2b575a94 100644 --- a/MAINTAINERS

Re: [dpdk-dev] [PATCH v3 2/2] distributor: fix additional check on no of workers

2019-07-17 Thread Thomas Monjalon
17/07/2019 17:32, Hunt, David: > Hi Harman, > > On 05/07/2019 11:05, Harman Kalra wrote: > > No of workers should never exceed RTE_MAX_LCORE. > > RTE_DIST_ALG_SINGLE also require no of workers check. > > > > Fixes: 775003ad2f96 ("distributor: add new burst-capable library") > > Cc: sta...@dpdk.org

[dpdk-dev] [PATCH] doc: fix ETH address example

2019-07-17 Thread Dekel Peled
Ethernet address examples contain 5 bytes only. This patch changes the examples to valid 6 bytes Ethernet addresses. Fixes: 4d73b6fb9907 ("doc: add generic flow API guide") Cc: sta...@dpdk.org Signed-off-by: Dekel Peled --- doc/guides/prog_guide/rte_flow.rst | 38 +++

[dpdk-dev] [RFC] net: be more restrictive in ether_unformat_addr

2019-07-17 Thread Stephen Hemminger
The current code acts more like BSD ether_aton and allows leading zeros which breaks the cmdline tests. Change the code to be more restrictive and only allow the fully expanded standard formats. Fixes: 596d31092d32 ("net: add function to convert string to ethernet address") Signed-off-by: Stephen

Re: [dpdk-dev] [PATCH] rte_ether: force format string for unformat_addr

2019-07-17 Thread Stephen Hemminger
On Wed, 10 Jul 2019 16:31:59 -0400 Aaron Conole wrote: > Stephen Hemminger writes: > > > On Wed, 10 Jul 2019 15:13:02 -0400 > > Aaron Conole wrote: > > > >> Stephen Hemminger writes: > >> > >> > On Wed, 10 Jul 2019 14:33:42 -0400 > >> > Aaron Conole wrote: > >> > > >> >> rte_ether_u

[dpdk-dev] [PATCH] mempool/octeontx2: use noinline to preserve ABI

2019-07-17 Thread pbhagavatula
From: Pavan Nikhilesh Since direct register access is used in npa_lf_aura_op_alloc_bulk() use __rte_noinline to preserve ABI. Signed-off-by: Pavan Nikhilesh --- drivers/mempool/octeontx2/otx2_mempool_ops.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mempool/octe

Re: [dpdk-dev] [PATCH] failsafe: skip devargs if not present in secondary

2019-07-17 Thread Ferruh Yigit
On 6/24/2019 5:27 PM, Gaëtan Rivet wrote: > On Mon, Jun 24, 2019 at 08:23:38AM -0700, Stephen Hemminger wrote: >> On Mon, 24 Jun 2019 10:15:58 +0200 >> Gaëtan Rivet wrote: >> >>> Hello Stephen, >>> >>> On Fri, Jun 21, 2019 at 03:08:24PM -0700, Stephen Hemminger wrote: When secondary process i

[dpdk-dev] [PATCH] doc: remove unused maintainer role from guide

2019-07-17 Thread Thomas Monjalon
The backup maintainer role is not explicitly used in the file MAINTAINERS. Listing names in a priority order is preferred and more flexible than explicit named roles. Signed-off-by: Thomas Monjalon --- doc/guides/contributing/patches.rst | 2 -- 1 file changed, 2 deletions(-) diff --git a/doc/g

Re: [dpdk-dev] [PATCH] net/bonding: use dynamic log type for error message

2019-07-17 Thread Ferruh Yigit
On 7/16/2019 9:39 PM, Stephen Hemminger wrote: > The generic RTE_LOGTYPE_PMD is a historical relic and should > not be used. Bonding driver was still using it in one place. > > Signed-off-by: Stephen Hemminger Reviewed-by: Ferruh Yigit Applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH] eal: update comment about --no-huge option

2019-07-17 Thread Thomas Monjalon
17/07/2019 14:35, Burakov, Anatoly: > On 17-Jul-19 9:56 AM, Thomas Monjalon wrote: > > The old comment, on top of the function rte_eal_has_hugepages(), > > is really outdated and not generic enough. > > > > Signed-off-by: Thomas Monjalon > > Acked-by: Anatoly Burakov Applied

Re: [dpdk-dev] [PATCH v10 0/2] new ring reset api and use it by hash

2019-07-17 Thread Thomas Monjalon
> Gavin Hu (2): > ring: add reset API to flush the ring when not in use > hash: flush the rings instead of dequeuing one by one Applied, thanks

[dpdk-dev] [PATCH] maintainers: add Andrew for next-net tree

2019-07-17 Thread Ferruh Yigit
Adding Andrew as co-maintainer to next-net sub-tree. Signed-off-by: Ferruh Yigit --- Cc: Andrew Rybchenko --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index a984ab194..c2b575a94 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -29,6 +29,7 @@ T: git:

Re: [dpdk-dev] [PATCH v2] testpmd: add option to not start device

2019-07-17 Thread Ferruh Yigit
On 7/16/2019 7:42 PM, Stephen Hemminger wrote: > Some configuration options can not be tested properly with testpmd > because it automatically starts all ports. This makes it harder > to test driver handling of configuration options: > (for example rx_deferred_start). > > Add new command line flag

Re: [dpdk-dev] [PATCH] bus/fslmc: fix err path in device iterator

2019-07-17 Thread Thomas Monjalon
17/07/2019 18:08, Thomas Monjalon: > 17/07/2019 17:55, Hemant Agrawal: > > Fixes: e67a61614d0b ("bus/fslmc: support device iteration") > > > > Signed-off-by: Hemant Agrawal > > Tested-by: Thomas Monjalon Applied, thanks

Re: [dpdk-dev] [PATCH 1/2] net/ark: remove queue offset based on port id

2019-07-17 Thread Ferruh Yigit
On 7/16/2019 10:34 PM, Ed Czeck wrote: > Fixes: c33d45af3633 ("net/ark: add Tx initial version") > Cc: sta...@dpdk.org > > Signed-off-by: Ed Czeck Hi Ed, Can you please add some context to commit log, what was the problem, what was its impact, how this is fixed? > --- > drivers/net/ark/ark_et

Re: [dpdk-dev] [PATCH v7 1/4] mempool: modify mempool populate() to skip objects from page boundaries

2019-07-17 Thread Vamsi Krishna Attunuru
> -Original Message- > From: Andrew Rybchenko > Sent: Wednesday, July 17, 2019 7:07 PM > To: Vamsi Krishna Attunuru ; dev@dpdk.org > Cc: tho...@monjalon.net; Jerin Jacob Kollanukkaran ; > olivier.m...@6wind.com; ferruh.yi...@intel.com; > anatoly.bura...@intel.com; Kiran Kumar Kokkilagadd

Re: [dpdk-dev] [PATCH 3/3] drivers/net: use ack API in interrupt handlers

2019-07-17 Thread Shahed Shaikh
> -Original Message- > From: Nithin Dabilpuram > Sent: Wednesday, July 17, 2019 5:29 PM > To: Hyong Youb Kim ; David Marchand > ; Thomas Monjalon ; > Ferruh Yigit ; Igor Russkikh > ; Pavel Belous ; > Allain Legacy ; Matt Peters > ; Ravi Kumar ; Rasesh > Mody ; Shahed Shaikh ; > Wenzhuo Lu

Re: [dpdk-dev] [PATCH v3 00/15] bnxt patch series

2019-07-17 Thread Ferruh Yigit
On 7/17/2019 11:41 AM, Ajit Khaparde wrote: > Patchset fixing various bugs in bnxt PMD based on recent commit: > 1e101412320061a4a1cd47db4227b4f8a163e9f6 > > Ajit Khaparde (3): > net/bnxt: fix for doorbell register offset for Tx ring > net/bnxt: save the number of EM flow count > net/bnxt: f

Re: [dpdk-dev] [PATCH v3] app/testpmd: add device related cmds

2019-07-17 Thread Ferruh Yigit
On 7/17/2019 1:30 PM, Nithin Dabilpuram wrote: > With the latest published interface of > rte_eal_hotplug_[add,remove](), and rte_eth_dev_close(), > rte_eth_dev_close() would cleanup all the data structures of > port's eth dev leaving the device common resource intact > if RTE_ETH_DEV_CLOSE_REMOVE

Re: [dpdk-dev] [PATCH v3] app/testpmd: add device related cmds

2019-07-17 Thread Ferruh Yigit
On 7/17/2019 1:30 PM, Nithin Dabilpuram wrote: > With the latest published interface of > rte_eal_hotplug_[add,remove](), and rte_eth_dev_close(), > rte_eth_dev_close() would cleanup all the data structures of > port's eth dev leaving the device common resource intact > if RTE_ETH_DEV_CLOSE_REMOVE

Re: [dpdk-dev] [PATCH v4 0/4] app/testpmd: support raw encap/decap actions

2019-07-17 Thread Ferruh Yigit
On 7/17/2019 1:27 PM, Xiaoyu Min wrote: > This series is based on RFC [1], which enable the testpmd to support > the raw_encap/raw_decap actions in a generic and convenient way. > > Some rte_flow_item's fields are also opened in testpmd cmdline > i.e. MPLS's TC & S in order to make sure the encaps

[dpdk-dev] [PATCH 2/2] crypto/dpaa2_sec: fix err handling for session init failures

2019-07-17 Thread Hemant Agrawal
The session init shall return failure if the internal session create fails for any reasons. Fixes: 13273250eec5 ("crypto/dpaa2_sec: support AES-GCM and CTR") Cc: sta...@dpdk.org Signed-off-by: Hemant Agrawal --- drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 13 +++-- 1 file changed, 7 in

[dpdk-dev] [PATCH 1/2] test/crypto: fix session init failure for wireless test

2019-07-17 Thread Hemant Agrawal
This patch add the support to handle the failure in session create for wireless related cases. Else it will cause segment fault due to I/O on un-initialized sessions. Fixes: b3bbd9e5f2659 ("cryptodev: support device independent sessions") Cc: sta...@dpdk.org Signed-off-by: Hemant Agrawal --- ap

Re: [dpdk-dev] [PATCH v3] net/pcap: create null Rx function

2019-07-17 Thread Ferruh Yigit
On 7/17/2019 9:08 AM, A.McLoughlin wrote: > Previously in the PCAP PMD it was only possibe to specify an rxq which > uses an iface or a pcap file. This patch creates a 'dummy Rx' function > which is used when no rx_pcap or rx_iface is passed but a tx queue is > passed. This function can be polled a

Re: [dpdk-dev] [PATCH] bus/fslmc: fix err path in device iterator

2019-07-17 Thread Thomas Monjalon
17/07/2019 17:55, Hemant Agrawal: > Fixes: e67a61614d0b ("bus/fslmc: support device iteration") > > Signed-off-by: Hemant Agrawal Tested-by: Thomas Monjalon

Re: [dpdk-dev] [EXT] [PATCH v3 02/11] cryptodev: add cipher field to RSA op

2019-07-17 Thread Kusztal, ArkadiuszX
Hi Shally, > > > > Signed-off-by: Arek Kusztal > > --- > > lib/librte_cryptodev/rte_crypto_asym.h | 26 > > +- > > 1 file changed, 25 insertions(+), 1 deletion(-) > > > > diff --git a/lib/librte_cryptodev/rte_crypto_asym.h > > b/lib/librte_cryptodev/rte_crypto_asym.h > > i

Re: [dpdk-dev] [PATCH v4 00/11] Rework API for RSA algorithm in asymmetric crypto

2019-07-17 Thread Trahe, Fiona
> -Original Message- > From: Kusztal, ArkadiuszX > Sent: Wednesday, July 17, 2019 1:51 PM > To: dev@dpdk.org > Cc: akhil.go...@nxp.com; Trahe, Fiona ; > shal...@marvell.com; Nowak, > DamianX ; Kusztal, ArkadiuszX > > Subject: [PATCH v4 00/11] Rework API for RSA algorithm in asymmetric

[dpdk-dev] [PATCH] bus/fslmc: fix err path in device iterator

2019-07-17 Thread Hemant Agrawal
Fixes: e67a61614d0b ("bus/fslmc: support device iteration") Signed-off-by: Hemant Agrawal --- drivers/bus/fslmc/fslmc_bus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/bus/fslmc/fslmc_bus.c b/drivers/bus/fslmc/fslmc_bus.c index a2ed3bcc9..9e4146aba 100644 --- a/dr

[dpdk-dev] [PATCH] doc: update Marvell OCTEON TX2 LBK support

2019-07-17 Thread jerinj
From: Jerin Jacob Add LBK HW block abstraction details and the application usage models. This patch also updates missing DPI HW block to DPDK subsystem mapping as well. Signed-off-by: Jerin Jacob --- doc/guides/platform/octeontx2.rst | 21 + 1 file changed, 21 insertions(+

[dpdk-dev] [PATCH] devtools: fix building kernel component tags

2019-07-17 Thread jerinj
From: Jerin Jacob Update devtools/build-tags.sh to account the kernel components under in kernel directory. Fixes: acaa9ee991b5 ("move kernel modules directories") Cc: sta...@dpdk.org Signed-off-by: Jerin Jacob --- devtools/build-tags.sh | 2 ++ 1 file changed, 2 insertions(+) diff --git a/d

[dpdk-dev] [PATCH v2 1/2] devtools: restore null test

2019-07-17 Thread Thomas Monjalon
This small testpmd test was not working for a long time because of several changes in EAL and mempool. The 3 main issues solved are: - Make --no-huge working by specifying an amount of memory to allocate in legacy mode, and disabling mlockall. - Load a mempool handle

[dpdk-dev] [PATCH v2 2/2] devtools: allow misc options in null test

2019-07-17 Thread Thomas Monjalon
In order to ease basic testing with customized options, EAL and testpmd options can be added as third and fourth arguments of the "null PMD" script. Also, the first argument becomes more flexible by accepting the testpmd path as an alternative to the build directory. Signed-off-by: Thomas Monjalo

Re: [dpdk-dev] [PATCH v3 2/2] distributor: fix additional check on no of workers

2019-07-17 Thread Hunt, David
Hi Harman, On 05/07/2019 11:05, Harman Kalra wrote: No of workers should never exceed RTE_MAX_LCORE. RTE_DIST_ALG_SINGLE also require no of workers check. Fixes: 775003ad2f96 ("distributor: add new burst-capable library") Cc: sta...@dpdk.org Signed-off-by: Harman Kalra --- lib/librte_distri

Re: [dpdk-dev] [PATCH v3 1/2] test/distributor: fix flush with worker shutdown test

2019-07-17 Thread Hunt, David
Hi Harman, On 05/07/2019 11:05, Harman Kalra wrote: On restarting worker 0 after shutdown, packets handled by worker 0 must be incremented only when a packet is received by it. Fixes: c3eabff124e6 ("distributor: add unit tests") Cc: sta...@dpdk.org Signed-off-by: Harman Kalra --- app/test/t

Re: [dpdk-dev] [EXT] Re: [PATCH v2 2/3] eal: add ack interrupt API

2019-07-17 Thread Nithin Kumar Dabilpuram
On Wed, Jul 17, 2019 at 03:05:47PM +, Hyong Youb Kim (hyonkim) wrote: > > -Original Message- > > From: Nithin Kumar Dabilpuram > > Sent: Wednesday, July 17, 2019 11:36 PM > [...] > > > > Subject: [PATCH v2 2/3] eal: add ack interrupt API > > > > > > > > Add new ack interrupt API to avo

Re: [dpdk-dev] [PATCH v2] net/ena: Fix admin cq polling for 32-bit apps

2019-07-17 Thread Ferruh Yigit
On 7/17/2019 3:29 PM, Michał Krawczyk wrote: > pt., 12 lip 2019 o 19:35 David Harton napisał(a): >> >> Recent modifications to admin command queue polling logic >> did not support 32-bit applications. Updated the driver to >> work for 32 or 64 bit applications >> >> Fixes: 3adcba9a89 ("net/ena: u

Re: [dpdk-dev] [EXT] Re: [PATCH v2 2/3] eal: add ack interrupt API

2019-07-17 Thread Hyong Youb Kim (hyonkim)
> -Original Message- > From: Nithin Kumar Dabilpuram > Sent: Wednesday, July 17, 2019 11:36 PM [...] > > > Subject: [PATCH v2 2/3] eal: add ack interrupt API > > > > > > Add new ack interrupt API to avoid using > > > VFIO_IRQ_SET_ACTION_TRIGGER(rte_intr_enable()) for > > > acking interrupt

Re: [dpdk-dev] [PATCH v4 02/11] sched: add config flexibility to tc queue sizes

2019-07-17 Thread Singh, Jasvinder
> > > > /** Number of traffic classes per pipe (as well as subport). > > - * Cannot be changed. > > */ > > -#define RTE_SCHED_TRAFFIC_CLASSES_PER_PIPE4 > > +#define RTE_SCHED_TRAFFIC_CLASSES_PER_PIPE\ > > +(RTE_SCHED_QUEUES_PER_PIPE - RTE_SCHED_BE_QUEUES_PER_PIPE + 1) > > > > /** N

Re: [dpdk-dev] [PATCH v4 06/11] sched: improve doxygen comments

2019-07-17 Thread Singh, Jasvinder
> > /** Port configuration parameters. */ struct rte_sched_port_params { > > - const char *name;/**< String to be associated */ > > - int socket; /**< CPU socket ID */ > > - uint32_t rate; /**< Output port rate > > -

Re: [dpdk-dev] [PATCH v4 06/11] sched: improve doxygen comments

2019-07-17 Thread Singh, Jasvinder
> > #ifndef RTE_SCHED_FRAME_OVERHEAD_DEFAULT > > #define RTE_SCHED_FRAME_OVERHEAD_DEFAULT 24 > > @@ -121,34 +125,39 @@ extern "C" { > > * byte. > > */ > > struct rte_sched_subport_params { > > - /* Subport token bucket */ > > - uint32_t tb_rate;/**< Rate (measur

  1   2   3   >