Re: [dpdk-dev] [PATCH v3] net/ice: fix flow validation fail

2019-07-14 Thread Zhang, Qi Z
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Xing, Beilei > Sent: Monday, July 15, 2019 11:20 AM > To: Yang, Qiming ; dev@dpdk.org > Cc: Yang, Qiming ; sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3] net/ice: fix flow validation fail > > > > > -

Re: [dpdk-dev] [PATCH] vfio: fix interrupts race condition

2019-07-14 Thread Jerin Jacob Kollanukkaran
> > > > > > This is a real bug which should be fixed in this release. > > > As the patch is quite big and needs a strong validation, I prefer > > > merging it quickly to give a lot of time before releasing 19.08-rc2. > > > The maintainers of all concerned PMDs are Cc. > > > Please make sure the int

[dpdk-dev] [PATCH] net/octeontx2: add flags based extraction support

2019-07-14 Thread kirankumark
From: Kiran Kumar K Adding support for flags based extraction in octeontx2 Flow. Patch supports extracting data greater than 32 bytes using lflags. When flags based extraction is enabled, lower 4 bits will be considered (16 flags) for indexing the flags, and will be used for extraction. Signed-o

Re: [dpdk-dev] [EXT] Re: [PATCH v6 0/4] add IOVA = VA support in KNI

2019-07-14 Thread Jerin Jacob Kollanukkaran
> > (also, i don't really like the name NO_PAGE_BOUND since in > > memzone API there's a "bounded memzone" allocation API, and this > > flag's name reads like objects would not be bounded by page size, > > not that they won't cross page > > boundary) > > >>> > > >>> No stro

Re: [dpdk-dev] [RFC PATCH v1] regexdev: introduce regexdev subsystem

2019-07-14 Thread Jerin Jacob Kollanukkaran
Ping. Is anyone interested to collaborate on this RFC[2]? Marvell would like to contribute on one SW(PCRE based) PMD and HW PMD for this API. Shahaf from Mellanox proposed a presentation on DPDK Regex device for upcoming user space summit[1] so It would be good to iron out the differences in va

Re: [dpdk-dev] [DPDK] drivers/net: fix dereference after null check coverity

2019-07-14 Thread Stephen Hemminger
On Sat, 13 Jul 2019 00:39:47 +0800 Xiao Zhang wrote: > This patch tries to fix the coverity issues of dereference after null > check. > > Coverity issue: 343452 > Coverity issue: 343447 > Coverity issue: 343422 > Coverity issue: 343416 > Coverity issue: 343407 > Coverity issue: 343403 > Coverity

Re: [dpdk-dev] [PATCH] config: fix meson build failure on ThunderX2

2019-07-14 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: Honnappa Nagarahalli > Sent: Friday, July 12, 2019 10:10 PM > To: Jerin Jacob Kollanukkaran ; Gavin Hu (Arm > Technology China) ; dev@dpdk.org > Cc: nd ; tho...@monjalon.net; Pavan Nikhilesh Bhagavatula > ; sta...@dpdk.org; Honnappa Nagarahalli > ; nd > Subjec

[dpdk-dev] [v2] drivers/net: fix dereference after null check coverity

2019-07-14 Thread Xiao Zhang
This patch tries to fix the coverity issues of dereference after null check. The addresses of receive queue start segment for ice, avf, i40e, fm10k and ixgb were not checked before use. Add check to avoid coverity issues. Coverity issue: 343452 Coverity issue: 343407 Fixes: c68a52b8 ("net/ice: su

Re: [dpdk-dev] [PATCH v3] net/ice: fix flow validation fail

2019-07-14 Thread Xing, Beilei
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Qiming Yang > Sent: Monday, July 15, 2019 10:24 AM > To: dev@dpdk.org > Cc: Yang, Qiming ; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH v3] net/ice: fix flow validation fail > > ice_flow_valid_attr will return z

Re: [dpdk-dev] [DPDK] drivers/net: fix dereference after null check coverity

2019-07-14 Thread Zhang, Xiao
Hi Qiming, I will update the commit log. Thanks, Xiao > -Original Message- > From: Yang, Qiming > Sent: Monday, July 15, 2019 10:37 AM > To: Zhang, Xiao ; dev@dpdk.org > Cc: Zhang, Qi Z ; Wang, Xiao W > ; Xing, Beilei ; Lu, Wenzhuo > > Subject: RE: [DPDK] drivers/net: fix dereference afte

Re: [dpdk-dev] [DPDK] drivers/net: fix dereference after null check coverity

2019-07-14 Thread Yang, Qiming
Hi, Xiao Please explain what's the issue you fixed in the commit log. And for the fix patch, fix line is needed, please refer to other merged patches. commit e0474b94f8a36672d66be7408e3f7cf00e302329 is a good reference. Qiming -Original Message- From: Zhang, Xiao Sent: Saturday, July 13

[dpdk-dev] [PATCH v3] net/ice: fix flow validation fail

2019-07-14 Thread Qiming Yang
ice_flow_valid_attr will return zero on success and a negative value on error. Current return value check logical is opposite to the expected behavior. This patch fixed this issue. Fixes: d76116a4678f ("net/ice: add generic flow API") Cc: sta...@dpdk.org Signed-off-by: Qiming Yang --- drivers/n

Re: [dpdk-dev] [PATCH v1] net/ice: use rx/tx DMA iova instead of phys_addr which is deprecated

2019-07-14 Thread Zhang, Qi Z
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Haiyue Wang > Sent: Friday, July 12, 2019 1:27 AM > To: dev@dpdk.org > Cc: Wang, Haiyue ; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH v1] net/ice: use rx/tx DMA iova instead of > phys_addr which is deprecated >

Re: [dpdk-dev] [PATCH 1/2] common/cpt: remove redundant bit swaps

2019-07-14 Thread Thomas Monjalon
06/07/2019 15:23, Anoob Joseph: > The bit swaps can be removed by re-arranging the structure. > > Signed-off-by: Anoob Joseph Series applied, thanks

Re: [dpdk-dev] [PATCH v2] common/octeontx2: add CNF95xx SoC support

2019-07-14 Thread Thomas Monjalon
12/07/2019 14:37, Jerin Jacob Kollanukkaran: > > -Original Message- > > From: Nithin Dabilpuram > > Sent: Friday, July 12, 2019 2:56 PM > > To: Jerin Jacob Kollanukkaran ; Nithin Kumar > > Dabilpuram ; Vamsi Krishna Attunuru > > ; John McNamara ; > > Marko Kovacevic ; Kiran Kumar Kokkilaga

Re: [dpdk-dev] [PATCH] eal/bsd: fix config creation

2019-07-14 Thread Thomas Monjalon
12/07/2019 16:56, Bruce Richardson: > On Fri, Jul 12, 2019 at 03:48:08PM +0100, Anatoly Burakov wrote: > > The config create function did not store the mem config address in > > the shared memconfig structure, so the secondary processes couldn't > > map it at the requred address. > > > > Fixes: b1

Re: [dpdk-dev] [dpdk-stable] [PATCH v1] examples/vm_power: fix strcpy buffer overrun

2019-07-14 Thread Thomas Monjalon
12/07/2019 16:47, Bruce Richardson: > On Fri, Jul 12, 2019 at 03:04:02PM +0100, David Hunt wrote: > > replace strcpy with rte_strlcpy to prevent buffer overrun > > With fix, attempting to use a VERY lonng vm name results in a nicely > > truncated 32 character name rather than a segfault: > > Settin

Re: [dpdk-dev] [Suspected-Phishing][PATCH v4] net/mlx5: support IP-in-IP tunnel

2019-07-14 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Xiaoyu Min > Sent: Wednesday, July 10, 2019 6:00 PM > To: Raslan Darawsheh ; Slava Ovsiienko > ; Shahaf Shuler ; > Yongseok Koh ; John McNamara > ; Marko Kovacevic > > Cc: dev@dpdk.org > Subject: [Suspected-Phishing][PATCH v4] net/mlx5: support IP-in-IP t

Re: [dpdk-dev] [PATCH] ethdev: extend flow metadata

2019-07-14 Thread Andrew Rybchenko
On 11.07.2019 10:44, Adrien Mazarguil wrote: On Wed, Jul 10, 2019 at 04:37:46PM +, Yongseok Koh wrote: On Jul 10, 2019, at 5:26 AM, Thomas Monjalon wrote: 10/07/2019 14:01, Bruce Richardson: On Wed, Jul 10, 2019 at 12:07:43PM +0200, Olivier Matz wrote: On Wed, Jul 10, 2019 at 10:55:34AM

Re: [dpdk-dev] [PATCH] vfio: fix interrupts race condition

2019-07-14 Thread Thomas Monjalon
14/07/2019 07:10, Hyong Youb Kim (hyonkim): > > -Original Message- > > From: Thomas Monjalon > > Sent: Thursday, July 11, 2019 6:21 AM > [...] > > Subject: Re: [dpdk-dev] [PATCH] vfio: fix interrupts race condition > > > > 10/07/2019 14:33, David Marchand: > > > Populating the eventfd in