Re: [dpdk-dev] [PATCH v6 0/4] add IOVA = VA support in KNI

2019-07-03 Thread Vamsi Krishna Attunuru
Hi All, Just to summarize, below items have arisen from the initial review. 1) Can the new mempool flag be made default to all the pools and will there be case that new flag functionality would fail for some page sizes.? 2) Adding HW device info(pci dev info) to KNI device structure, will it

Re: [dpdk-dev] [PATCH v4] net/i40e: fix core dumped when setting txq or rxq to 0 in VF

2019-07-03 Thread Pei, Andy
Thanks Qi -Original Message- From: Zhang, Qi Z Sent: Thursday, July 4, 2019 2:18 PM To: Pei, Andy ; dev@dpdk.org Cc: Zhang, Helin ; sta...@dpdk.org; Zhang, Roy Fan ; Wu, Jingjing ; Xing, Beilei ; Yigit, Ferruh ; Xu, Rosen ; Ye, Xiaolong Subject: RE: [PATCH v4] net/i40e: fix core dumpe

Re: [dpdk-dev] [PATCH v4] net/i40e: fix core dumped when setting txq or rxq to 0 in VF

2019-07-03 Thread Zhang, Qi Z
> -Original Message- > From: Pei, Andy > Sent: Thursday, July 4, 2019 9:39 AM > To: dev@dpdk.org > Cc: Pei, Andy ; Zhang, Helin ; > sta...@dpdk.org; Zhang, Roy Fan ; Zhang, Qi Z > ; Wu, Jingjing ; Xing, Beilei > ; Yigit, Ferruh ; Xu, Rosen > ; Ye, Xiaolong > Subject: [PATCH v4] net/i40e

[dpdk-dev] [PATCH v2] app/testpmd: fix to add offloads confguration for queue

2019-07-03 Thread Wei Zhao
When adding offloads from commandline, not only port related configuration bits should be set, but also queue related offloads configuration bits, or it will cause error. For example, test in this process for ixgbe: (1)./x86_64-native-linuxapp-gcc/app/testpmd -c 0x6 -n 4 -- -i --portmask=0x1 --port

[dpdk-dev] Running dpdk application inside virtual machine created on VirtualBox

2019-07-03 Thread Shailja Pandey
Hi, I am trying to run dpdk application inside a virtual machine (Ubuntu 16.04) deployed in Oracle Virtualbox. The host machine is also the same Ubuntu 16.04. I am running l2fwd application in the VM and the packets are being generated using pktgen-DPDK running on other physical machine. The

Re: [dpdk-dev] [PATCH v4 4/4] app/testpmd: match GRE's key and present bits

2019-07-03 Thread Jack Min
On Wed, 19-07-03, 17:25, Adrien Mazarguil wrote: > On Tue, Jul 02, 2019 at 05:45:55PM +0800, Xiaoyu Min wrote: > > support matching on GRE key and present bits (C,K,S) > > > > example testpmd command could be: > > testpmd>flow create 0 ingress group 1 pattern eth / ipv4 / > > gre crksv

[dpdk-dev] [RFC] ethdev: support input set change by RSS action

2019-07-03 Thread simei
From: Simei Su This RFC introduces inputset structure to rte_flow_action_rss to support input set specific configuration by rte_flow RSS action. We can give an testpmd command line example to make it more clear. For example, below flow selects the l4 port as inputset for any eth/ipv4/tcp packet

[dpdk-dev] [PATCH] doc: announce ABI change for rte flow RSS action

2019-07-03 Thread simei
From: Simei Su Add new structure inputset in rte_flow_action_rss. This can support input set configuration by rte_flow RSS action. Signed-off-by: Simei Su --- doc/guides/rel_notes/deprecation.rst | 3 +++ 1 file changed, 3 insertions(+) diff --git a/doc/guides/rel_notes/deprecation.rst b/doc

[dpdk-dev] [RFC] ethdev: support symmetric hash function

2019-07-03 Thread simei
From: Simei Su Currently, there are DEFAULT,TOEPLITZ and SIMPLE_XOR hash funtion. To support symmetric hash by rte_flow RSS action, this RFC introduces SYMMETRIC_TOEPLITZ to rte_eth_hash_function. Signed-off-by: Simei Su --- lib/librte_ethdev/rte_flow.h | 1 + 1 file changed, 1 insertion(+) d

[dpdk-dev] [PATCH] doc: announce ABI change for RSS hash funtion

2019-07-03 Thread simei
From: Simei Su Add new field SYMMETRIC_TOEPLITZ in rte_eth_hash_function. This can support symmetric hash function by rte_flow RSS action. Signed-off-by: Simei Su --- doc/guides/rel_notes/deprecation.rst | 2 ++ 1 file changed, 2 insertions(+) diff --git a/doc/guides/rel_notes/deprecation.rst

Re: [dpdk-dev] [PATCH v1 1/2] lib/ring: add enqueue-dequeue callabck

2019-07-03 Thread Varghese, Vipin
Thanks Honnappa, will work on the changes suggested. > -Original Message- > From: Honnappa Nagarahalli > Sent: Tuesday, June 11, 2019 9:48 AM > To: Varghese, Vipin ; olivier.m...@6wind.com; > Pattan, Reshma ; Wiles, Keith > ; dev@dpdk.org > Cc: Padubidri, Sanjay A ; Honnappa Nagarahalli >

Re: [dpdk-dev] [PATCH v2 2/2] examples/l2fwd-crypto: add callback handlers

2019-07-03 Thread Varghese, Vipin
Thanks Ruifeng, will work on the suggested changes. > -Original Message- > From: Ruifeng Wang (Arm Technology China) > Sent: Friday, June 21, 2019 12:37 PM > To: Varghese, Vipin ; Wiles, Keith > ; dev@dpdk.org; De Lara Guarch, Pablo > ; akhil.go...@nxp.com; Doherty, Declan > > Cc: Padubi

Re: [dpdk-dev] [PATCH v2 1/2] lib/crypto: add callback handlers for crypto

2019-07-03 Thread Varghese, Vipin
Thanks Akhil, I will work on the suggested inputs. > -Original Message- > From: Akhil Goyal > Sent: Thursday, June 27, 2019 7:55 PM > To: Varghese, Vipin ; Wiles, Keith > ; dev@dpdk.org; De Lara Guarch, Pablo > ; Doherty, Declan > > Cc: Padubidri, Sanjay A > Subject: RE: [PATCH v2 1/2]

Re: [dpdk-dev] [EXT] Re: [PATCH 00/39] adding eventmode helper library

2019-07-03 Thread Anoob Joseph
Hi Thomas, > It was discussed in the techboard today. > Please read the summary below. > > We want to keep l2fwd as simple as possible. > So we agree to have a fork of l2fwd for eventdev. > > It was proposed to integrate eventdev in l2fwd, l3fwd and ipsec-secgw. > l2fwd will get eventdev integra

Re: [dpdk-dev] [PATCH v4 1/4] ethdev: add GRE key field to flow API

2019-07-03 Thread Jack Min
On Wed, 19-07-03, 17:25, Adrien Mazarguil wrote: > On Tue, Jul 02, 2019 at 05:45:52PM +0800, Xiaoyu Min wrote: > > Add new rte_flow_item_gre_key in order to match the optional key field. > > > > Signed-off-by: Xiaoyu Min > > OK with adding this feature, however I still have a bunch of comments b

[dpdk-dev] [DPDK] net/e1000: Intel i219 reset hang issue fix.

2019-07-03 Thread Xiao Zhang
Unit hang may occur if multiple descriptors are available in the rings during reset or close. Flush them before reset or close to avoid the issue. Change-Id: Ia5e8dd06ad890d19f5093f1696faf68f7f52b491 Signed-off-by: Xiao Zhang --- drivers/net/e1000/base/e1000_ich8lan.h | 1 + drivers/net/e1000/e

[dpdk-dev] [PATCH v4 5/5] event/octeontx2: add Tx adadpter support

2019-07-03 Thread pbhagavatula
From: Pavan Nikhilesh Add event eth Tx adapter support to octeontx2 SSO. Signed-off-by: Jerin Jacob Signed-off-by: Pavan Nikhilesh Signed-off-by: Nithin Dabilpuram --- drivers/event/octeontx2/otx2_evdev.c | 79 drivers/event/octeontx2/otx2_evdev.h | 32 ++

[dpdk-dev] [PATCH v4 3/5] event/octeontx2: add event eth Rx adapter fastpath ops

2019-07-03 Thread pbhagavatula
From: Pavan Nikhilesh Add support for event eth Rx adapter fastpath operations. Signed-off-by: Jerin Jacob Signed-off-by: Pavan Nikhilesh Signed-off-by: Nithin Dabilpuram --- drivers/event/octeontx2/otx2_evdev.c | 308 - drivers/event/octeontx2/otx2_evdev.h |

[dpdk-dev] [PATCH v4 4/5] event/octeontx2: add PTP support for SSO

2019-07-03 Thread pbhagavatula
From: Harman Kalra Add PTP support for SSO based on rx_offloads of the queue connected to it. Signed-off-by: Harman Kalra Signed-off-by: Nithin Dabilpuram Signed-off-by: Pavan Nikhilesh --- drivers/event/octeontx2/otx2_evdev.c | 2 ++ drivers/event/octeontx2/otx2_evdev.h | 6 ++

[dpdk-dev] [PATCH v4 1/5] event/octeontx2: add event eth Rx adapter support

2019-07-03 Thread pbhagavatula
From: Pavan Nikhilesh Add event eth Rx adapter capabilities, queue add and delete functions. Signed-off-by: Pavan Nikhilesh Signed-off-by: Jerin Jacob --- doc/guides/eventdevs/octeontx2.rst | 6 + drivers/event/octeontx2/Makefile | 2 +- drivers/event/octeontx2/meson.bui

[dpdk-dev] [PATCH v4 2/5] event/octeontx2: resize SSO inflight event buffers

2019-07-03 Thread pbhagavatula
From: Pavan Nikhilesh Resize SSO internal in-flight buffer count based on the Rx queues mempool size connected to event queues. Signed-off-by: Pavan Nikhilesh --- drivers/event/octeontx2/otx2_evdev.h | 2 ++ drivers/event/octeontx2/otx2_evdev_adptr.c | 34 +- 2 files

[dpdk-dev] [PATCH v4 0/5] event/octeontx2: add Rx/Tx adapter support

2019-07-03 Thread pbhagavatula
From: Pavan Nikhilesh This patchset adds event eth Rx/Tx adapter support for OCTEONTX2 event device, depends on: http://patches.dpdk.org/project/dpdk/list/?series=5302 v4 Changes: - Squash documentation patch. - Remove unnessary net/octeontx2 library dependency. v3 Changes: - rebase patches to

Re: [dpdk-dev] [PATCH] net/i40e: fix unexpected skip fdir setup

2019-07-03 Thread Xing, Beilei
> -Original Message- > From: Zhang, Qi Z > Sent: Wednesday, July 3, 2019 2:35 PM > To: Xing, Beilei > Cc: dev@dpdk.org; Zhang, Qi Z ; sta...@dpdk.org > Subject: [PATCH] net/i40e: fix unexpected skip fdir setup > > In i40e_flow_flush_fdir_filter, i40e_fdir_teardown is called, so > i40e_

Re: [dpdk-dev] [PATCH v4 1/4] ethdev: add GRE key field to flow API

2019-07-03 Thread Jack Min
On Wed, 19-07-03, 16:06, Thomas Monjalon wrote: > 02/07/2019 11:45, Xiaoyu Min: > > + /** > > +* Matches a GRE optional key field. > > +* > > +* The value should a big-endian 32bit integer. > > +*/ > > + RTE_FLOW_ITEM_TYPE_GRE_KEY, > > We probably want to use the same format as

[dpdk-dev] [PATCH v4] net/i40e: fix core dumped when setting txq or rxq to 0 in VF

2019-07-03 Thread Andy Pei
Testpmd would stuck and result in core dump when user specifies an invalid VF queue number, for example when setting txq or rxq to 0. When txq or rxq is set to 0, pointer of pointer rxq or txq in function i40evf_configure_vsi_queues is NULL. The usage of txq[i] or rxq[0] is valid. This patch fixes

Re: [dpdk-dev] [PATCH 3/3] lib/hash: adjust tbl_chng_cnt position

2019-07-03 Thread Wang, Yipeng1
>-Original Message- >From: Honnappa Nagarahalli [mailto:honnappa.nagaraha...@arm.com] >Sent: Tuesday, July 2, 2019 10:23 AM >To: Wang, Yipeng1 ; Gobriel, Sameh >; Richardson, Bruce >; De Lara Guarch, Pablo > >Cc: Gavin Hu (Arm Technology China) ; Ruifeng Wang (Arm >Technology China) ; >d

Re: [dpdk-dev] [PATCH 2/3] lib/hash: load pData after full key compare

2019-07-03 Thread Wang, Yipeng1
>-Original Message- >From: Honnappa Nagarahalli [mailto:honnappa.nagaraha...@arm.com] >Sent: Monday, July 1, 2019 9:35 PM >To: Wang, Yipeng1 ; Gobriel, Sameh >; Richardson, Bruce >; De Lara Guarch, Pablo > >Cc: Gavin Hu (Arm Technology China) ; Ruifeng Wang (Arm >Technology China) ; >dev

[dpdk-dev] [PATCH 3/3] net/bnx2x: fix fastpath SB allocation for SRIOV

2019-07-03 Thread Rasesh Mody
For SRIOV, fastpath status blocks are not allocated resulting in segfault. Separate out fastpath DMA allocation/free from rest of memory allocation/free. It is now done as part of NIC load/unload. Comment indentation changes in bnx2x_alloc_hsi_mem() and bnx2x_free_hsi_mem() APIs. Fixes: f0219d98d

[dpdk-dev] [PATCH 2/3] net/bnx2x: fix link events polling for SRIOV

2019-07-03 Thread Rasesh Mody
We do not need to schedule periodic poll for slowpath link events for SRIOV. The link events are handled by the PF driver. Fixes: 6041aa619f9a ("net/bnx2x: fix poll link status") Cc: sta...@dpdk.org Signed-off-by: Rasesh Mody --- drivers/net/bnx2x/bnx2x_ethdev.c | 19 --- 1 file

[dpdk-dev] [PATCH 1/3] net/bnx2x: fix read VF id

2019-07-03 Thread Rasesh Mody
The logic, to read vf_id used by ACQUIRE/TEARDOWN_Q/RELEASE TLVs, multiplexed return value to convey vf_id value and status of read vf_id API. This lets to segfault at dev_start() as resources are not properly cleaned and re-allocated. Fix read vf_id API to differentiate between vf_id value and re

Re: [dpdk-dev] [PATCH 0/2] fix issues with Ubuntu 18.04 compilation

2019-07-03 Thread Thomas Monjalon
> > Bruce Richardson (2): > > examples: fix pkg-config detection with older make > > buildtools/test-meson-builds: workaround pkg-config issue > > Series-acked-by: Luca Boccassi Applied, thanks

Re: [dpdk-dev] [PATCH v6 0/7] bbdev: adding support in BBDEV for 5GNR FEC

2019-07-03 Thread Thomas Monjalon
03/07/2019 20:31, Chautru, Nicolas: > Thomas wrote: > >> Nicolas Chautru (7): > >> bbdev: renaming non-generic LTE specific structure > >> bbdev: extension of BBDEV API for 5G FEC > >> docs/guides: updating bbdev API for 5GNR operations > >> baseband/turbo_sw: extension of turbosw PMD for 5

Re: [dpdk-dev] [PATCH v5 7/9] raw/ioat: add configure, start and stop functions

2019-07-03 Thread Aaron Conole
Bruce Richardson writes: > On Wed, Jul 03, 2019 at 12:21:39PM -0400, Aaron Conole wrote: >> Bruce Richardson writes: >> >> > Allow initializing a driver instance. Include selftest to validate >> > these functions. >> > >> > Signed-off-by: Bruce Richardson Acked-by: >> > Anatoly Burakov Tested

Re: [dpdk-dev] [PATCH v3 00/58] OCTEON TX2 Ethdev driver

2019-07-03 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: jer...@marvell.com > Sent: Wednesday, July 3, 2019 2:12 PM > To: dev@dpdk.org > Cc: Jerin Jacob Kollanukkaran > Subject: [dpdk-dev] [PATCH v3 00/58] OCTEON TX2 Ethdev driver > > From: Jerin Jacob > > This patchset adds support for OCTEON TX2 ethdev driver.

Re: [dpdk-dev] [PATCH v4] ethdev: support QinQ strip dynamic configuration

2019-07-03 Thread Andrew Rybchenko
On 03.07.2019 20:48, Ferruh Yigit wrote: On 7/2/2019 4:37 AM, viveksha...@marvell.com wrote: From: Vivek Sharma Enable missing support for runtime configuration (setting/getting) of QinQ strip rx offload for a given ethdev. Signed-off-by: Vivek Sharma Hi Andrew, As far as I understand you

Re: [dpdk-dev] [PATCH v6 0/7] bbdev: adding support in BBDEV for 5GNR FEC

2019-07-03 Thread Chautru, Nicolas
Thomas wrote: >> Nicolas Chautru (7): >> bbdev: renaming non-generic LTE specific structure >> bbdev: extension of BBDEV API for 5G FEC >> docs/guides: updating bbdev API for 5GNR operations >> baseband/turbo_sw: extension of turbosw PMD for 5G >> docs/guides: updating building steps for

Re: [dpdk-dev] [PATCH v6 0/7] bbdev: adding support in BBDEV for 5GNR FEC

2019-07-03 Thread Thomas Monjalon
Hi, > Nicolas Chautru (7): > bbdev: renaming non-generic LTE specific structure > bbdev: extension of BBDEV API for 5G FEC > docs/guides: updating bbdev API for 5GNR operations > baseband/turbo_sw: extension of turbosw PMD for 5G > docs/guides: updating building steps for BBDEV PMD > t

Re: [dpdk-dev] [PATCH v4] ethdev: support QinQ strip dynamic configuration

2019-07-03 Thread Ferruh Yigit
On 7/2/2019 4:37 AM, viveksha...@marvell.com wrote: > From: Vivek Sharma > > Enable missing support for runtime configuration (setting/getting) > of QinQ strip rx offload for a given ethdev. > > Signed-off-by: Vivek Sharma Hi Andrew, As far as I understand you were OK with the patch after cha

Re: [dpdk-dev] [PATCH v2] ethdev: support action with any config object type

2019-07-03 Thread Ferruh Yigit
On 7/2/2019 4:15 PM, Adrien Mazarguil wrote: > On Tue, Jul 02, 2019 at 05:17:26PM +0300, Dekel Peled wrote: >> In current implementation, an action which requires parameters >> must accept them enclosed in a structure. >> Some actions require a single, trivial type parameter, but it still >> must b

[dpdk-dev] [PATCH v2 2/2] failsafe: implement xstats

2019-07-03 Thread Stephen Hemminger
Add support for extended statistics in failsafe driver. Reports basic statistics for the failsafe driver, and detailed statistics for each sub device. Signed-off-by: Stephen Hemminger --- drivers/net/failsafe/failsafe_ops.c | 135 1 file changed, 135 insertions(+) d

[dpdk-dev] [PATCH v2 1/2] ethdev: expose basic xstats for driver use

2019-07-03 Thread Stephen Hemminger
Avoid duplication by having generic basic xstats available for use by drivers. A later patch uses this for failsafe driver. Signed-off-by: Stephen Hemminger --- lib/librte_ethdev/rte_ethdev.c | 17 +++ lib/librte_ethdev/rte_ethdev_driver.h| 65 lib/libr

[dpdk-dev] [PATCH v2 0/2] *failsafe: add xstats

2019-07-03 Thread Stephen Hemminger
A useful feature of netvsc PMD is the ability to see how many packets were processed through the VF device. This patch set adds a similar (but more limited) capability to failsafe driver. Since failsafe doesn't have top level xstats, this set uses the generic xstats that exist already as a base th

Re: [dpdk-dev] [PATCH] net/af_packet: set default blocksize to pagesize

2019-07-03 Thread Ferruh Yigit
On 6/24/2019 3:32 PM, kka...@marvell.com wrote: > From: Krzysztof Kanas > > Kernel validates block size to be aligned to page size. Code works on > platforms with page size 4k, but on others e.g. Arm64 fails with default > parameters. > > Signed-off-by: Krzysztof Kanas Reviewed-by: Ferruh Yigi

Re: [dpdk-dev] [PATCH] mempool/octeontx2: fix clang build failure

2019-07-03 Thread Pavan Nikhilesh Bhagavatula
+Cc : Gavin Hu For some reason send mail didn't pick up reported-by. >-Original Message- >From: pbhagavat...@marvell.com >Sent: Wednesday, July 3, 2019 10:22 PM >To: Jerin Jacob Kollanukkaran >Cc: dev@dpdk.org; Pavan Nikhilesh Bhagavatula > >Subject: [dpdk-dev][PATCH] mempool/octeontx2

[dpdk-dev] [PATCH] mempool/octeontx2: fix clang build failure

2019-07-03 Thread pbhagavatula
From: Pavan Nikhilesh The ARMv8.1 CASP instruction works with even register pairs and since there no register constraint in older versions of GCC/Clang, use explicit register allocation to satisfy CASP requirements. Fixs build issue with arm64-armv8a-linux-clang. Fixes: ee338015e7a9 ("mempool/o

Re: [dpdk-dev] [PATCH 0/2] fix issues with Ubuntu 18.04 compilation

2019-07-03 Thread Luca Boccassi
On Wed, 2019-07-03 at 17:39 +0100, Bruce Richardson wrote: > This set has two fixes for the build issues on Ubuntu. The first > patch > adds in support for older make v4.1, and the second works around a > problem with pkg-config giving an incorrect prefix in some > circumstances. > > Bruce Richard

Re: [dpdk-dev] [PATCH v5 7/9] raw/ioat: add configure, start and stop functions

2019-07-03 Thread Bruce Richardson
On Wed, Jul 03, 2019 at 12:21:39PM -0400, Aaron Conole wrote: > Bruce Richardson writes: > > > Allow initializing a driver instance. Include selftest to validate > > these functions. > > > > Signed-off-by: Bruce Richardson Acked-by: > > Anatoly Burakov Tested-by: Harry van Haaren > > --- > > >

[dpdk-dev] [PATCH 0/2] fix issues with Ubuntu 18.04 compilation

2019-07-03 Thread Bruce Richardson
This set has two fixes for the build issues on Ubuntu. The first patch adds in support for older make v4.1, and the second works around a problem with pkg-config giving an incorrect prefix in some circumstances. Bruce Richardson (2): examples: fix pkg-config detection with older make buildtool

[dpdk-dev] [PATCH 2/2] buildtools/test-meson-builds: workaround pkg-config issue

2019-07-03 Thread Bruce Richardson
With Debian and Ubuntu, the default installation path for the 64-bit libraries is set to e.g. /usr/local/lib/x86_64-linux-gnu/, compared to /usr/local/lib64 on Fedora and Redhat distributions. This causes issues when using "pkg-config --define-prefix" since pkg-config assumes the prefix to be the g

Re: [dpdk-dev] [PATCH v2] telemetry: fix build warnings seen when using gcc 9

2019-07-03 Thread Laatz, Kevin
On 03/07/2019 10:23, Flavia Musatescu wrote: Suppress the unaligned packed member address warnings by extending the telemetry library build flags with -Wno-address-of-packed-member option, through the WERROR_FLAGS makefile variable. With this change additional warnings are turned on to be treate

[dpdk-dev] [PATCH 1/2] examples: fix pkg-config detection with older make

2019-07-03 Thread Bruce Richardson
Make versions before 4.2 did not have support for the .SHELLSTATUS variable, so use another method to detect shell success. Fixes: 22119c4591a0 ("examples: use pkg-config in makefiles") Cc: sta...@dpdk.org Signed-off-by: Bruce Richardson --- examples/bbdev_app/Makefile | 3 +-- exam

Re: [dpdk-dev] [EXT] Re: [PATCH 00/39] adding eventmode helper library

2019-07-03 Thread Thomas Monjalon
03/07/2019 11:37, Anoob Joseph: > From: Thomas Monjalon > > 03/07/2019 03:35, Anoob Joseph: > > > [Anoob] Initially the target would be only DPDK applications. > > > As I had mentioned earlier, I'm dropping the idea of making this a > > > library/common code. My proposal is to have all the code in

Re: [dpdk-dev] [PATCH v5 7/9] raw/ioat: add configure, start and stop functions

2019-07-03 Thread Aaron Conole
Bruce Richardson writes: > Allow initializing a driver instance. Include selftest to validate these > functions. > > Signed-off-by: Bruce Richardson > Acked-by: Anatoly Burakov > Tested-by: Harry van Haaren > --- > > V4: Guarantee correct SUCCESS/FAILURE return values from test function >

Re: [dpdk-dev] [PATCH v3 2/8] cryptodev: add digest encrypted feature flag

2019-07-03 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Damian Nowak > Sent: Wednesday, July 3, 2019 12:16 PM > To: dev@dpdk.org > Cc: akhil.go...@nxp.com; Trahe, Fiona ; Kusztal, > ArkadiuszX ; Nowak, DamianX > > Subject: [dpdk-dev] [PATCH v3 2/8] cryptodev: add dig

Re: [dpdk-dev] [PATCH v3 1/8] cryptodev: document usage of digest-appended operations

2019-07-03 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Damian Nowak > Sent: Wednesday, July 3, 2019 12:16 PM > To: dev@dpdk.org > Cc: akhil.go...@nxp.com; Trahe, Fiona ; Kusztal, > ArkadiuszX ; Nowak, DamianX > > Subject: [dpdk-dev] [PATCH v3 1/8] cryptodev: documen

[dpdk-dev] [PATCH] net/netvsc: fix definition of offload values

2019-07-03 Thread Stephen Hemminger
The definition of ipsec and rsc offloads was incorrect. Neither one of these is used by current driver, but the values should be fixed now for future RSC support. Signed-off-by: Stephen Hemminger --- drivers/net/netvsc/ndis.h | 26 +- 1 file changed, 13 insertions(+), 13

[dpdk-dev] [PATCH v2 3/3] test: rework rsa test implementation

2019-07-03 Thread Arek Kusztal
This commit reworks rsa test implementation to be conformant to the RSA API. Simulation of PKCS1_5 padding was added to be used with PADDING_NONE option. Signed-off-by: Arek Kusztal --- app/test/test_cryptodev_asym.c | 44 --- app/test/test_cryptodev_asym_util.h

[dpdk-dev] [PATCH v2 2/3] crypto/openssl: rework openssl rsa implementation

2019-07-03 Thread Arek Kusztal
This commit reworks implementation of RSA algorithm in OPENSSL PMD to be conformant to API changes. Signed-off-by: Arek Kusztal --- drivers/crypto/openssl/rte_openssl_pmd.c | 67 ++-- 1 file changed, 38 insertions(+), 29 deletions(-) diff --git a/drivers/crypto/opens

[dpdk-dev] [PATCH v2 0/3]Rework API for RSA algorithm in asymmetric crypto

2019-07-03 Thread Arek Kusztal
Most things from v1 were simplified according to Shally adn Fiona comments. No more rfc details in comments and some things were shortened. There is no more struct for padding too, but only union for PSS and OAEP. Added test case for padding none with encryption (pkcs padding is done in test) ps. I

[dpdk-dev] [PATCH v2 1/3] cryptodev: rework api of rsa algorithm

2019-07-03 Thread Arek Kusztal
This patch reworks API of RSA algorithm. Major changes: - Cipher field was introduced - Field for singature verification when padding none selected was added - Padding union was created - PKCS1-v1_5 Block type 0 was removed - Fixed comments about prime numbers - Added guide to use none padding Sig

Re: [dpdk-dev] [PATCH v1 1/1] net/hinic: use mutex replace spin lock

2019-07-03 Thread Stephen Hemminger
On Wed, 3 Jul 2019 23:35:42 +0800 Ziyang Xuan wrote: > > +static inline int hinic_mutex_init(pthread_mutex_t *pthreadmutex, > + const pthread_mutexattr_t *mattr) > +{ > + int err; > + > + err = pthread_mutex_init(pthreadmutex, mattr); > + if (unli

Re: [dpdk-dev] [PATCH v3 0/8] cryptodev: support encrypted-digest use-cases

2019-07-03 Thread Trahe, Fiona
> -Original Message- > From: Nowak, DamianX > Sent: Wednesday, July 3, 2019 12:16 PM > To: dev@dpdk.org > Cc: akhil.go...@nxp.com; Trahe, Fiona ; Kusztal, > ArkadiuszX > ; Nowak, DamianX > Subject: [PATCH v3 0/8] cryptodev: support encrypted-digest use-cases > > This patchset adds sup

[dpdk-dev] [PATCH v6 4/7] baseband/turbo_sw: extension of turbosw PMD for 5G

2019-07-03 Thread Nicolas Chautru
Implementation still based on Intel SDK libraries optimized for AVX512 instructions set and 5GNR. This can be also build for AVX2 for 4G capability or without SDK dependency for maintenance. Signed-off-by: Nicolas Chautru Acked-by: Amr Mokhtar --- config/common_base

[dpdk-dev] [PATCH v6 6/7] test-bbdev: update of bbdev test-app for 5GNR

2019-07-03 Thread Nicolas Chautru
Extending test framework for FEC 5GNR operations for UT verification and profiling. Signed-off-by: Nicolas Chautru Acked-by: Amr Mokhtar --- app/test-bbdev/main.c | 48 +- app/test-bbdev/main.h |6 +- app/test-bbdev/meson.build|3 + app/test

[dpdk-dev] [PATCH v6 3/7] docs/guides: updating bbdev API for 5GNR operations

2019-07-03 Thread Nicolas Chautru
The documentation captures the related change in BBDEV API to support 5GNR encode/decode operations. Signed-off-by: Nicolas Chautru Acked-by: Amr Mokhtar --- doc/guides/prog_guide/bbdev.rst | 505 1 file changed, 458 insertions(+), 47 deletions(-) diff

[dpdk-dev] [PATCH v6 2/7] bbdev: extension of BBDEV API for 5G FEC

2019-07-03 Thread Nicolas Chautru
Extension to BBDEV operations to support 5G on top of existing 4G operations. Signed-off-by: Nicolas Chautru Acked-by: Amr Mokhtar --- doc/guides/rel_notes/release_19_08.rst | 4 +- lib/librte_bbdev/rte_bbdev.c | 22 +- lib/librte_bbdev/rte_bbdev.h | 138 +++- lib/lib

[dpdk-dev] [PATCH v6 1/7] bbdev: renaming non-generic LTE specific structure

2019-07-03 Thread Nicolas Chautru
Renaming of the enums and structure which were LTE specific to allow for extension and support for 5GNR operations. Signed-off-by: Nicolas Chautru Acked-by: Amr Mokhtar --- app/test-bbdev/test_bbdev_vector.c | 4 +- app/test-bbdev/test_bbdev_vector.h | 2 +- driv

[dpdk-dev] [PATCH v6 5/7] docs/guides: updating building steps for BBDEV PMD

2019-07-03 Thread Nicolas Chautru
This now includes steps to build with either libraries for AVX2, or AVX512 or no dependency. Signed-off-by: Nicolas Chautru Acked-by: Amr Mokhtar --- doc/guides/bbdevs/turbo_sw.rst | 42 +- 1 file changed, 29 insertions(+), 13 deletions(-) diff --git a/d

[dpdk-dev] [PATCH v6 0/7] bbdev: adding support in BBDEV for 5GNR FEC

2019-07-03 Thread Nicolas Chautru
v6 update: minor fix for compilation issue reported on CI v5 update: rebase and squashing release note update with related change. v4 update: cosmetic changes reported by ci/checkpatch This set enables specifically bbdev to support 5GNR operations (previously only LTE specific) and to add the re

[dpdk-dev] [PATCH v6 6/6] app/test-compress-perf: add force process termination

2019-07-03 Thread Artur Trybula
From: Tomasz Jozwiak This patch adds a possibility to force controlled process termination as a result of two signals: SIGTERM and SIGINT Signed-off-by: Tomasz Jozwiak Acked-by: Artur Trybula --- app/test-compress-perf/comp_perf_options.h| 1 + .../comp_perf_test_benchmark.c

Re: [dpdk-dev] [PATCH v4 1/4] ethdev: add GRE key field to flow API

2019-07-03 Thread Adrien Mazarguil
On Tue, Jul 02, 2019 at 05:45:52PM +0800, Xiaoyu Min wrote: > Add new rte_flow_item_gre_key in order to match the optional key field. > > Signed-off-by: Xiaoyu Min OK with adding this feature, however I still have a bunch of comments below. > --- > doc/guides/prog_guide/rte_flow.rst | 8 ++

Re: [dpdk-dev] [PATCH v4 4/4] app/testpmd: match GRE's key and present bits

2019-07-03 Thread Adrien Mazarguil
On Tue, Jul 02, 2019 at 05:45:55PM +0800, Xiaoyu Min wrote: > support matching on GRE key and present bits (C,K,S) > > example testpmd command could be: > testpmd>flow create 0 ingress group 1 pattern eth / ipv4 / > gre crksv is 0x2000 crksv mask 0xb000 / > gre_key key is 0x123

[dpdk-dev] [PATCH v6 4/6] app/test-compress-perf: add benchmark test case

2019-07-03 Thread Artur Trybula
From: Tomasz Jozwiak This patch adds a benchmark part to compression-perf-tool as a separate test case, which can be executed multi-threaded. Signed-off-by: Tomasz Jozwiak Signed-off-by: Tomasz Jozwiak Acked-by: Artur Trybula --- app/test-compress-perf/Makefile | 1 + .../com

[dpdk-dev] [PATCH v6 5/6] doc: update dpdk-test-compress-perf description

2019-07-03 Thread Artur Trybula
From: Tomasz Jozwiak This patch updates a dpdk-test-compress-perf documentation. Signed-off-by: Tomasz Jozwiak Acked-by: Artur Trybula --- doc/guides/tools/comp_perf.rst | 34 +++--- 1 file changed, 31 insertions(+), 3 deletions(-) diff --git a/doc/guides/tools/co

[dpdk-dev] [PATCH v6 3/6] app/test-compress-perf: add verification test case

2019-07-03 Thread Artur Trybula
From: Tomasz Jozwiak This patch adds a verification part to compression-perf-tool as a separate test case, which can be executed multi-threaded. Signed-off-by: Tomasz Jozwiak Signed-off-by: Tomasz Jozwiak Acked-by: Artur Trybula --- app/test-compress-perf/Makefile | 1 + .../

[dpdk-dev] [PATCH v6 2/6] app/test-compress-perf: add ptest command line option

2019-07-03 Thread Artur Trybula
From: Tomasz Jozwiak This patch adds --ptest option to make possible a choose of test case from command line. Signed-off-by: Tomasz Jozwiak Signed-off-by: Tomasz Jozwiak Acked-by: Artur Trybula --- .../comp_perf_options_parse.c | 32 +++ 1 file changed, 32 ins

[dpdk-dev] [PATCH v6 0/6] add multiple cores feature to test-compress-perf

2019-07-03 Thread Artur Trybula
This patchset adds multiple cores feature to compression perf tool. All structures have been aligned and are consistent with crypto perf tool. All test cases have constructor, runner and destructor and can use more cores and compression devices at the same time. v2 changes: - fixed checkpatch w

[dpdk-dev] [PATCH v6 1/6] app/test-compress-perf: add weak functions for multi-cores test

2019-07-03 Thread Artur Trybula
From: Tomasz Jozwiak This patch adds a template functions for multi-cores performance version of compress-perf-tool and updates release notes for 19.08 Signed-off-by: Tomasz Jozwiak Signed-off-by: Tomasz Jozwiak Acked-by: Artur Trybula --- app/test-compress-perf/Makefile | 3

Re: [dpdk-dev] [PATCH v2] app/testpmd: fix setting RSS queue rule failure on fedora30

2019-07-03 Thread Iremonger, Bernard
> > Subject: Re: [dpdk-dev] [PATCH v2] app/testpmd: fix setting RSS queue > > rule failure on fedora30 > > > > On 06/25, Haiyue Wang wrote: > > >Declare a local variable 'arg' to hold the pointer to ARGS_ENTRY_ARB, > > >otherwise, the pop 'arg' in 'parse_int' holds wrong data like 'arg-> > > >of

[dpdk-dev] [PATCH v1 1/1] net/hinic: use mutex replace spin lock

2019-07-03 Thread Ziyang Xuan
Using spin lock to protect critical resources of sending mgmt messages. This will make high CPU usage when sending mgmt messages frequently. We can use mutex to protect the critical resources to reduce CPU usage while keep functioning properly. Signed-off-by: Ziyang Xuan --- drivers/net/hinic/Ma

Re: [dpdk-dev] [pull-request] next-eventdev 19.08 RC1

2019-07-03 Thread Thomas Monjalon
03/07/2019 05:55, Jerin Jacob Kollanukkaran: > http://dpdk.org/git/next/dpdk-next-eventdev Pulled, thanks

Re: [dpdk-dev] [PATCH v10 0/3] add actions to modify header fields

2019-07-03 Thread Ferruh Yigit
On 7/2/2019 4:15 PM, Adrien Mazarguil wrote: > On Tue, Jul 02, 2019 at 05:44:25PM +0300, Dekel Peled wrote: >> Patch [1] implemented set of header modification actions in MLX PMD, based >> on ethdev and testpmd updates included in [2]. >> This series implements support of additional header modific

Re: [dpdk-dev] [PATCH v4 1/4] ethdev: add GRE key field to flow API

2019-07-03 Thread Thomas Monjalon
02/07/2019 11:45, Xiaoyu Min: > + /** > + * Matches a GRE optional key field. > + * > + * The value should a big-endian 32bit integer. > + */ > + RTE_FLOW_ITEM_TYPE_GRE_KEY, We probably want to use the same format as in Dekel's patch for doxygen documentation of the act

Re: [dpdk-dev] [PATCH 19.08 v2] doc: announce infinite Rx PCAP PMD feature

2019-07-03 Thread Ferruh Yigit
On 7/3/2019 12:04 PM, Cian Ferriter wrote: > This feature was added in the following commit: > commit a3f5252e5cbd ("net/pcap: enable infinitely Rx a pcap file") > > Signed-off-by: Cian Ferriter <...> > @@ -116,6 +116,12 @@ New Features >* Enabled need_wakeup feature which can provide effic

Re: [dpdk-dev] [dpdk-stable] [PATCH 1/3] ethdev: avoid error on PCI unplug of already closed ethdev

2019-07-03 Thread Ferruh Yigit
On 7/2/2019 6:38 PM, Ferruh Yigit wrote: > On 6/21/2019 11:15 AM, Andrew Rybchenko wrote: >> On 6/21/19 12:52 PM, David Marchand wrote: >>> On Fri, Jun 21, 2019 at 11:41 AM Andrew Rybchenko >>> >>> wrote: If PCI Ethernet device driver removes it on close (RTE_ETH_DEV_CLOSE_REMOVE) and l

Re: [dpdk-dev] [PATCH v2 09/28] sched: update pkt read and write API

2019-07-03 Thread Dumitrescu, Cristian
> -Original Message- > From: Singh, Jasvinder > Sent: Tuesday, July 2, 2019 10:05 PM > To: Dumitrescu, Cristian ; dev@dpdk.org > Cc: Tovar, AbrahamX ; Krakowiak, LukaszX > > Subject: RE: [PATCH v2 09/28] sched: update pkt read and write API > > > > > -Original Message- > > Fr

[dpdk-dev] [PATCH 2/2] test/bpf: add test-case for function return value

2019-07-03 Thread Konstantin Ananyev
New test-case to cover situation when external function returns a pointer the data. Signed-off-by: Konstantin Ananyev --- app/test/test_bpf.c | 130 1 file changed, 130 insertions(+) diff --git a/app/test/test_bpf.c b/app/test/test_bpf.c index 1d5040

[dpdk-dev] [PATCH 0/2] bpf: fix and new test-case

2019-07-03 Thread Konstantin Ananyev
Fixes problem in validate part for function return value checking and adds new test-case to cover that. Konstantin Ananyev (2): bpf: fix validate for function return value test/bpf: add test-case for function return value app/test/test_bpf.c | 130 ++

[dpdk-dev] [PATCH 1/2] bpf: fix validate for function return value

2019-07-03 Thread Konstantin Ananyev
eval_call() blindly calls eval_max_bound() for external function return value for all return types. That causes wrong estimation for returned pointer min and max boundaries. So any attempt to dereference that pointer value causes verifier to fail with error message: "memory boundary violation at pc

Re: [dpdk-dev] [PATCH v7 08/12] app/testpmd: use new ethernet address parser

2019-07-03 Thread Iremonger, Bernard
Hi Stephen, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Stephen > Hemminger > Sent: Tuesday, July 2, 2019 11:13 PM > To: dev@dpdk.org > Cc: Stephen Hemminger > Subject: [dpdk-dev] [PATCH v7 08/12] app/testpmd: use new ethernet > address parser > > The cmdl

Re: [dpdk-dev] [EXT] [PATCH v3 1/3] eal/arm64: add 128-bit atomic compare exchange

2019-07-03 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: Jerin Jacob Kollanukkaran > Sent: Wednesday, July 3, 2019 5:56 PM > To: Phil Yang ; dev@dpdk.org > Cc: tho...@monjalon.net; hemant.agra...@nxp.com; > honnappa.nagaraha...@arm.com; gavin...@arm.com; n...@arm.com; > gage.e...@intel.com > Subject: RE: [EXT] [PATCH

[dpdk-dev] [PATCH v3] test/eal: add ut for eal options proc-type and uio

2019-07-03 Thread Lavanya Govindarajan
Added unit test cases for EAL flags --proc-type=auto and --create-uio-dev in order to cover the below functions eal_proc_type_detect() rte_eal_create_uio_dev() Signed-off-by: Lavanya Govindarajan Reviewed-by: David Marchand Acked-by: Anatoly Burakov --- v3: Corrected error log message to be con

Re: [dpdk-dev] [EXT] [PATCH v3 1/3] eal/arm64: add 128-bit atomic compare exchange

2019-07-03 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: Phil Yang > Sent: Friday, June 28, 2019 1:42 PM > To: dev@dpdk.org > Cc: tho...@monjalon.net; Jerin Jacob Kollanukkaran ; > hemant.agra...@nxp.com; honnappa.nagaraha...@arm.com; > gavin...@arm.com; n...@arm.com; gage.e...@intel.com > Subject: [EXT] [PATCH v3 1/

Re: [dpdk-dev] [PATCH v5 0/6] add multiple cores feature to test-compress-perf

2019-07-03 Thread Tomasz Jóźwiak
Hi Akhil, Was rebased on Monday. Too dynamic head :) , will do Today and add you in Cc. Thx, Tomek śr., 3.07.2019, 12:21 użytkownik Akhil Goyal napisał: > Hi Tomasz, > > This series need a rebase. > > Thanks, > Akhil > > > > > This patchset adds multiple cores feature to compression perf tool

Re: [dpdk-dev] [PATCH v2] drivers/net/nfb: add timestamp support

2019-07-03 Thread Ferruh Yigit
On 7/2/2019 11:32 AM, Rastislav Cernay wrote: > From: Rastislav Cernay > > This patch adds timestamping support to nfb driver. > > Signed-off-by: Rastislav Cernay <...> > @@ -142,3 +142,22 @@ Example output: > TX threshold registers: pthresh=0 hthresh=0 wthresh=0 > TX RS bit thres

Re: [dpdk-dev] [PATCH] app/testpmd: fix to add offloads confguration for queue

2019-07-03 Thread Iremonger, Bernard
Hi Wei, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Wei Zhao > Sent: Wednesday, July 3, 2019 6:24 AM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Zhao1, Wei > Subject: [dpdk-dev] [PATCH] app/testpmd: fix to add offloads confguration > for queue > > When add

[dpdk-dev] [PATCH] doc: update bnxt PMD guide

2019-07-03 Thread Lance Richardson
- Include list of supported adapters. - Include list of supported features. - Document requirements for vector mode PMD. - Remove obsolete limitation (scatter rx has been supported for some time). - Fixed broken links. Acked-by: Ajit Khaparde Signed-off-by: Lance Richardson --- doc/guides/nic

Re: [dpdk-dev] [PATCH 19.08 v2] doc: announce infinite Rx PCAP PMD feature

2019-07-03 Thread Ferriter, Cian
v2 changes: * added the commit ID to which the announcement is relevant > -Original Message- > From: Ferriter, Cian > Sent: 03 July 2019 12:04 > To: Mcnamara, John ; Kovacevic, Marko > > Cc: dev@dpdk.org; Ferriter, Cian > Subject: [PATCH 19.08 v2] doc: announce infinite Rx PCAP PMD featu

[dpdk-dev] [PATCH v3 8/8] test/crypto: return correct value if feature not supported

2019-07-03 Thread Damian Nowak
This patch makes unsupported tests visible in the testsuite summary. Signed-off-by: Damian Nowak --- app/test/test_cryptodev.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c index 336cfd0..05422da 100644 --- a/app

[dpdk-dev] [PATCH v3 6/8] test/crypto: add kasumi test cases for auth-cipher

2019-07-03 Thread Damian Nowak
This patch adds test cases for kasumi in-place and out-of-place auth-cipher operations. Test cases include buffer appended digest generation with encryption and buffer decryption with appended digest verification. Signed-off-by: Damian Nowak --- app/test/test_cryptodev.c | 22

  1   2   3   >