Re: [dpdk-dev] [PATCH] net/mlx5: fix condition for calling mlx5_link_update_unlocked_gset

2019-06-10 Thread Shahaf Shuler
Srinivas, Tuesday, June 11, 2019 9:29 AM, Asaf Penso: > Subject: [PATCH] net/mlx5: fix condition for calling > mlx5_link_update_unlocked_gset > > mlx5_link_update uses the newer ethtool command > ETHTOOL_GLINKSETTINGS to determine interface capabilities but falls back > to the older (deprecated)

[dpdk-dev] [PATCH] net/mlx5: fix condition for calling mlx5_link_update_unlocked_gset

2019-06-10 Thread Asaf Penso
mlx5_link_update uses the newer ethtool command ETHTOOL_GLINKSETTINGS to determine interface capabilities but falls back to the older (deprecated) ETHTOOL_GSET command if the new method fails for any reason. The older method only supports reporting of capabilities up to 40G. However, mlx5_link_upd

Re: [dpdk-dev] RFC - vdev_netvsc automatic blacklisting

2019-06-10 Thread Matan Azrad
Hi Stephen From: Stephen Hemminger > When using DPDK on Azure it is common to have one non-DPDK interface. > If that non-DPDK interface is present vdev_netvsc correctly skip it. > But if the non-DPDK has accelerated networking the Mellanox driver will still > get associated with DPDK (and break co

Re: [dpdk-dev] [PATCH v1 1/2] lib/ring: add enqueue-dequeue callabck

2019-06-10 Thread Honnappa Nagarahalli
> > Hi Honnappa, > > snipped > > > > > > Add callback event handler for enqueue dequeue operation on ring. > > > The pre-enqueue and post-dequeue operation on ring is selected to > > > invoke user callback handler. > > Can you provide a use case for this to better understand the need? > Use cases

Re: [dpdk-dev] [PATCH 14/14] test: skip tests when missing requirements

2019-06-10 Thread Honnappa Nagarahalli
(pruning a little bit of the CC: list...) On Fri, Jun 7, 2019 at 10:55 PM Honnappa Nagarahalli mailto:honnappa.nagaraha...@arm.com>> wrote: > > Let's mark as skipped the tests when they are missing some requirements like a > number of used cores or specific hardware availability, like compress,

Re: [dpdk-dev] [EXT] Re: [PATCH 24/39] eventdev: add Rx adapter init in eventmode

2019-06-10 Thread Anoob Joseph
Hi Erik, Please see inline. Thanks, Anoob > -Original Message- > From: dev On Behalf Of Carrillo, Erik G > Sent: Monday, June 10, 2019 8:26 PM > To: Anoob Joseph ; Jerin Jacob Kollanukkaran > ; Rao, Nikhil ; Gujjar, > Abhinandan S ; Richardson, Bruce > ; De Lara Guarch, Pablo > > Cc: N

Re: [dpdk-dev] [PATCH v2] crypto/octeontx: sync mbox changes done in kernel driver

2019-06-10 Thread Anoob Joseph
Hi Akhil, Pablo, This patch is ready for merge. Thanks, Anoob > -Original Message- > From: Anoob Joseph > Sent: Wednesday, May 29, 2019 4:14 PM > To: Akhil Goyal ; Pablo de Lara > > Cc: Lukas Bartosik ; Jerin Jacob Kollanukkaran > ; Narayana Prasad Raju Athreya > ; dev@dpdk.org; Anoob

Re: [dpdk-dev] [PATCH] net/i40e: i40e rework for ipn3ke

2019-06-10 Thread Xu, Rosen
Hi Andy, > -Original Message- > From: Pei, Andy > Sent: Monday, June 10, 2019 14:15 > To: Xu, Rosen ; dev@dpdk.org > Cc: Zhang, Roy Fan ; Zhang, Qi Z > ; Wu, Jingjing ; Xing, Beilei > ; Yigit, Ferruh > Subject: RE: [PATCH] net/i40e: i40e rework for ipn3ke > > Hi, Rosen > > > Your ACK i

Re: [dpdk-dev] [DPDK v2] net/ipn3ke: modifications on AFU configurations

2019-06-10 Thread Xu, Rosen
Hi Dan, Thanks your clarify, pls apply them in new patch set, not just explain them in this patch. > -Original Message- > From: Wei, Dan > Sent: Tuesday, June 04, 2019 11:19 > To: Xu, Rosen ; dev@dpdk.org > Cc: Yigit, Ferruh ; sta...@dpdk.org > Subject: RE: [DPDK v2] net/ipn3ke: modifica

Re: [dpdk-dev] [PATCH v3 4/4] raw/ifpga_rawdev/base: fix miss physical address

2019-06-10 Thread Xu, Rosen
> -Original Message- > From: Zhang, Tianfei > Sent: Monday, June 10, 2019 23:52 > To: dev@dpdk.org; Xu, Rosen ; sta...@dpdk.org > Cc: Zhang, Tianfei > Subject: [PATCH v3 4/4] raw/ifpga_rawdev/base: fix miss physical address > > Fix miss phy_addr on ifpga_acc_get_region_info() function.

Re: [dpdk-dev] [PATCH v3 3/4] raw/ifpga_rawdev/base: fix bit fields definition

2019-06-10 Thread Xu, Rosen
> -Original Message- > From: Zhang, Tianfei > Sent: Monday, June 10, 2019 23:52 > To: dev@dpdk.org; Xu, Rosen ; sta...@dpdk.org > Cc: Zhang, Tianfei > Subject: [PATCH v3 3/4] raw/ifpga_rawdev/base: fix bit fields definition > > Fix CTRL_DEV_SELECT bit fields definition about eth_group

Re: [dpdk-dev] [PATCH v3 2/4] raw/ifpga_rawdev: fix logically dead code

2019-06-10 Thread Xu, Rosen
> -Original Message- > From: Zhang, Tianfei > Sent: Monday, June 10, 2019 23:52 > To: dev@dpdk.org; Xu, Rosen ; sta...@dpdk.org > Cc: Zhang, Tianfei > Subject: [PATCH v3 2/4] raw/ifpga_rawdev: fix logically dead code > > add temporary variable in max10_reg_write(). > > Coverity issue:

Re: [dpdk-dev] [PATCH v3 1/4] raw/ifpga_rawdev: fix use of untrusted scalar value

2019-06-10 Thread Xu, Rosen
> -Original Message- > From: Zhang, Tianfei > Sent: Monday, June 10, 2019 23:52 > To: dev@dpdk.org; Xu, Rosen ; sta...@dpdk.org > Cc: Zhang, Tianfei > Subject: [PATCH v3 1/4] raw/ifpga_rawdev: fix use of untrusted scalar value > > Add checking the buffer size and use > const char * for

Re: [dpdk-dev] [PATCH] app/testpmd: fix offloads default set error

2019-06-10 Thread Zhao1, Wei
"If we take that propose, it means we do not need any patch at all." Sorry for typo. > -Original Message- > From: Zhao1, Wei > Sent: Tuesday, June 11, 2019 9:29 AM > To: 'Kevin Traynor' ; dev@dpdk.org > Cc: sta...@dpdk.org; Yigit, Ferruh > Subject: RE: [dpdk-dev] [PATCH] app/testpmd: fix

Re: [dpdk-dev] [PATCH v2] net/ixgbevf: add an option pflink_fullchk to get link status nowait

2019-06-10 Thread Zhang, Qi Z
> -Original Message- > From: Zhang, Qi Z > Sent: Monday, June 10, 2019 7:17 PM > To: Wang, Haiyue ; dev@dpdk.org; Lu, Wenzhuo > ; Wang, Liang-min ; > dani...@research.att.com; ktray...@redhat.com > Cc: sta...@dpdk.org > Subject: RE: [PATCH v2] net/ixgbevf: add an option pflink_fullchk to

Re: [dpdk-dev] [PATCH] app/testpmd: fix offloads default set error

2019-06-10 Thread Zhao1, Wei
Hi, Kevin Traynor This patch is based on Yigit Ferruh's suggestion in the following mail. https://mails.dpdk.org/archives/dev/2019-May/132178.html If we take your propose, it means we do need any patch at all. Because the code implement now is just that scheme, we will do "or" for offload

Re: [dpdk-dev] [PATCH] acl: fix build issue with some arm64 compiler

2019-06-10 Thread Honnappa Nagarahalli
> > > > -- > > > > > Subject: [dpdk-dev] [PATCH] acl: fix build issue with some arm64 > > > > > compiler > > > > > > > > > > From: Jerin Jacob > > > > > > > > > > Some compilers reporting the following error, though the > > > > > existing code doesn't have any uninitialized variable case. > > > >

Re: [dpdk-dev] [PATCH v2] net/ixgbevf: add an option pflink_fullchk to get link status nowait

2019-06-10 Thread Wang, Haiyue
> -Original Message- > From: Zhang, Qi Z > Sent: Monday, June 10, 2019 19:17 > To: Wang, Haiyue ; dev@dpdk.org; Lu, Wenzhuo > ; Wang, > Liang-min ; dani...@research.att.com; > ktray...@redhat.com > Cc: sta...@dpdk.org > Subject: RE: [PATCH v2] net/ixgbevf: add an option pflink_fullchk to

[dpdk-dev] [PATCH v2] usertools: update to usertool for baseband device

2019-06-10 Thread Nicolas Chautru
Allows binding of baseband devices Signed-off-by: Nicolas Chautru --- usertools/dpdk-devbind.py | 10 +- usertools/dpdk-setup.sh | 6 +++--- 2 files changed, 12 insertions(+), 4 deletions(-) diff --git a/usertools/dpdk-devbind.py b/usertools/dpdk-devbind.py index 9e79f0d..a6ee8f9 100

[dpdk-dev] [PATCH v2] usertools: update to usertool for baseband device

2019-06-10 Thread Nicolas Chautru
Purely minor script change to support the BBDEV devices An FPGA BBDEV PMD is being pushed in parallel but this patch can be pushed independently from CI point of view. This was pushed earlier as a v1 in previous patchset https://patches.dpdk.org/project/dpdk/list/?series=4657 Nicolas Chautru (1)

Re: [dpdk-dev] [RFC 1/3] ethdev: extend flow metadata

2019-06-10 Thread Yongseok Koh
On Mon, Jun 10, 2019 at 10:20:28AM +0300, Andrew Rybchenko wrote: > On 6/10/19 6:19 AM, Wang, Haiyue wrote: > > > -Original Message- > > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Andrew Rybchenko > > > Sent: Sunday, June 9, 2019 22:24 > > > To: Yongseok Koh ; shah...@mellanox.c

[dpdk-dev] [RFC] rte_timer: add rte_timer_next_ticks

2019-06-10 Thread Stephen Hemminger
It is useful to know when the next timer will expire when using rte_epoll_wait (or sleep when idle). This experimental API provides a hook to query the number of ticks remaining. Signed-off-by: Stephen Hemminger --- lib/librte_timer/rte_timer.c | 21 + lib/librte_ti

[dpdk-dev] [PATCH v2 7/7] doc: update KNI documentation

2019-06-10 Thread Stephen Hemminger
Make the KNI documentation reflect modern kernel networking. Ifconfig has been superseded by iproute2 for 15 years. Iproute2 is well maintained, supports current feature set. Ethtool is no longer supported by KNI. Tshark is a better replacement for tcpdump. Signed-off-by: Stephen Hemminger ---

[dpdk-dev] [PATCH v2 5/7] kni: use proper type for kni fifo's

2019-06-10 Thread Stephen Hemminger
Using void * instead of proper type is unsafe practice. Signed-off-by: Stephen Hemminger --- kernel/linux/kni/kni_dev.h | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/kernel/linux/kni/kni_dev.h b/kernel/linux/kni/kni_dev.h index f3e6c3ca4efa..ceba5f73c1d9 100644

[dpdk-dev] [PATCH v2 6/7] kni: return -EFAULT if copy_from_user fails

2019-06-10 Thread Stephen Hemminger
The correct thing to return if user gives a bad data is to return -EFAULT. Logging is also discouraged because it could be used as a DoS attack. Signed-off-by: Stephen Hemminger --- kernel/linux/kni/kni_misc.c | 16 +--- 1 file changed, 5 insertions(+), 11 deletions(-) diff --git a/

[dpdk-dev] [PATCH v2 4/7] kni: drop unused fields

2019-06-10 Thread Stephen Hemminger
The kni net structure only exists in driver no API/ABI. Several fields were either totally unused or set and never used. Signed-off-by: Stephen Hemminger --- kernel/linux/kni/kni_dev.h | 8 kernel/linux/kni/kni_misc.c | 1 - 2 files changed, 9 deletions(-) diff --git a/kernel/linux/kn

[dpdk-dev] [PATCH v2 3/7] kni: don't keep stats in kni_net

2019-06-10 Thread Stephen Hemminger
Since kernel 2.6.28 the network subsystem has provided dev->stats for devices to use statistics handling and is the default if no ndo_get_stats is provided. This allow allows for 64 bit (rather than just 32 bit) statistics with KNI. Signed-off-by: Stephen Hemminger --- kernel/linux/kni/kni_dev.

[dpdk-dev] [PATCH v2 1/7] kni: don't need stubs for rx_mode or ioctl

2019-06-10 Thread Stephen Hemminger
The netdev subsystem already handles case where network sevice does not support ioctl. If device has no rx_mode hook it is not called. Signed-off-by: Stephen Hemminger --- kernel/linux/kni/kni_net.c | 19 --- 1 file changed, 19 deletions(-) diff --git a/kernel/linux/kni/kni_net

[dpdk-dev] [PATCH v2 2/7] kni: use netdev_alloc_skb

2019-06-10 Thread Stephen Hemminger
netdev_alloc_skb is optimized to any alignment or setup of skb->dev that is required. The kernel intentionall does not pad packets on x86, because it is faster. Signed-off-by: Stephen Hemminger --- kernel/linux/kni/kni_net.c | 17 +++-- 1 file changed, 3 insertions(+), 14 deletions(-

[dpdk-dev] [PATCH v2 0/7] kni: cleanups and improvements

2019-06-10 Thread Stephen Hemminger
While testing KNI with netvsc, saw lots of places more code could be safely removed from KNI kernel driver. This is still mostly "putting lipstick on a pig" all users would be better off using virtio_user rather than KNI. v2 - get rid of unnecessary padding, combine the unused field patches Step

Re: [dpdk-dev] [dpdk-stable] [PATCH v3] net/ena: fix assigning NUMA node to IO queue

2019-06-10 Thread Ferruh Yigit
On 6/4/2019 11:59 AM, Michal Krawczyk wrote: > Previous solution was using memzones in invalid way in hope to assign > IO queue to the appropriate NUMA zone. > > The right way is to use socket_id from the rx/tx queue setup function > and then pass it to the IO queue. > > Fixes: 3d3edc265fc8 ("net

Re: [dpdk-dev] [PATCH 2/2] app/testpmd: creating mbuf pool based on maximum supported segments

2019-06-10 Thread Ferruh Yigit
On 5/27/2019 9:35 AM, Sunil Kumar Kori wrote: > Configuring buffer size based following parameters: > - max-pkt-len > - max supported segments per MTU > > Buffer size are configured as given below: > - If platform supports infinite segments per packet then default > buffer size is used. > - If p

[dpdk-dev] [PATCH v1] maintainers: claim maintainership of BBDEV

2019-06-10 Thread Nicolas Chautru
As discussed with Akhil and within Intel teams, there has been a reorg within Intel teams caused BBDEV maitainership to switch hands. Previous maintainer is on time off without access to email for next couple of weeks and cannot formally ack this, hence this change will be acked by other Intel sta

[dpdk-dev] [PATCH v1] maintainers: claim maintainership of BBDEV

2019-06-10 Thread Nicolas Chautru
Reorg within Intel teams causing transfer of maintainership --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 15d0829..d0e1b25 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -355,7 +355,7 @@ M: Cristian Dumitrescu F: lib/librte_eth

Re: [dpdk-dev] [PATCH 1/2] lib/librte_ethdev: add in default value of rte_eth_dev_info

2019-06-10 Thread Ferruh Yigit
On 6/9/2019 3:33 PM, Andrew Rybchenko wrote: > On 5/27/19 11:35 AM, Sunil Kumar Kori wrote: >> rte_eth_dev_info structure exposes, nb_seg_max & nb_mtu_seg_max >> to provide maximum number of supported segments for a given platform. >> >> Defining UINT16_MAX as default value of above mentioned varia

[dpdk-dev] [PATCH v4] baseband/fpga_lte_fec: adding driver for FEC on FPGA

2019-06-10 Thread Nicolas Chautru
Supports for FEC 4G PMD Driver on FPGA card PAC N3000 Signed-off-by: Nicolas Chautru --- config/common_base |6 + doc/guides/bbdevs/fpga_lte_fec.rst | 318 +++ doc/guides/bbdevs/index.rst|1 + drivers/baseband/Makef

[dpdk-dev] [PATCH v4] baseband/fpga_lte_fec: adding driver for FEC on FPGA

2019-06-10 Thread Nicolas Chautru
Update v4: Fix warning for the DEBUG configuration. Update v3: Squashing 3 previous patches into one as recommended. This is adding a new PMD driver for BBDEV device based on FPGA implementation on PAC N3000 HW to provide FEC 4G acceleration. v1 was shared earlier on this patchwork : https://p

Re: [dpdk-dev] [PATCH v2 0/3] add more features for AF_XDP pmd

2019-06-10 Thread Ferruh Yigit
On 5/30/2019 10:07 AM, Xiaolong Ye wrote: > This patch series mainly includes 3 new features for AF_XDP pmd. They > are separated independent features, the reason I take them in one > patchset is that they have code dependency. > > 1. zero copy > > This patch enables `zero copy` between af_xdp um

Re: [dpdk-dev] [PATCH v1 3/3] test/mcslock: add mcs queued lock unit test

2019-06-10 Thread Phil Yang (Arm Technology China)
Hi, > -Original Message- > From: Honnappa Nagarahalli > Sent: Friday, June 7, 2019 1:27 PM > To: Ananyev, Konstantin ; Phil Yang (Arm > Technology China) ; dev@dpdk.org > Cc: tho...@monjalon.net; jer...@marvell.com; hemant.agra...@nxp.com; > Gavin Hu (Arm Technology China) ; nd > ; nd >

Re: [dpdk-dev] [PATCH v1 1/2] lib/lpm: memory orderings to avoid race conditions for v1604

2019-06-10 Thread Medvedkin, Vladimir
Hi Honnappa, Wang, On 05/06/2019 20:23, Honnappa Nagarahalli wrote: Hi Wang, On 05/06/2019 06:54, Ruifeng Wang wrote: When a tbl8 group is getting attached to a tbl24 entry, lookup might fail even though the entry is configured in the table. For ex: consider a LPM table configured with 10.10.

Re: [dpdk-dev] [PATCH 24/39] eventdev: add Rx adapter init in eventmode

2019-06-10 Thread Carrillo, Erik G
> -Original Message- > From: Anoob Joseph > Sent: Monday, June 3, 2019 12:32 PM > To: Jerin Jacob ; Rao, Nikhil ; > Carrillo, Erik G ; Gujjar, Abhinandan S > ; Richardson, Bruce > ; De Lara Guarch, Pablo > > Cc: Anoob Joseph ; Narayana Prasad > ; dev@dpdk.org; Lukasz Bartosik > ; Pavan Ni

Re: [dpdk-dev] [PATCH 32/39] eventdev: add routine to launch eventmode workers

2019-06-10 Thread Carrillo, Erik G
Hi Anoob, One other observation in-line: > -Original Message- > From: Anoob Joseph > Sent: Monday, June 3, 2019 12:33 PM > To: Jerin Jacob ; Rao, Nikhil ; > Carrillo, Erik G ; Gujjar, Abhinandan S > ; Richardson, Bruce > ; De Lara Guarch, Pablo > > Cc: Anoob Joseph ; Narayana Prasad > ;

Re: [dpdk-dev] [PATCH 32/39] eventdev: add routine to launch eventmode workers

2019-06-10 Thread Carrillo, Erik G
Hi Anoob, I've listed a few notes in-line. > -Original Message- > From: Anoob Joseph > Sent: Monday, June 3, 2019 12:33 PM > To: Jerin Jacob ; Rao, Nikhil ; > Carrillo, Erik G ; Gujjar, Abhinandan S > ; Richardson, Bruce > ; De Lara Guarch, Pablo > > Cc: Anoob Joseph ; Narayana Prasad >

[dpdk-dev] [PATCH] net/iavf: move debug dump desc flag to config file

2019-06-10 Thread Lavanya Govindarajan
DEBUG_DUMP_DESC flag is commented out in IAVF Makefile and to enable it user needs to edit the Makefile. It is felt that this method is not good. Hence removing this flag from IAVF makefile and adding a flag CONFIG_RTE_LIBRTE_IAVF_DEBUG_DUMP_DESC to config/common_base. Signed-off-by: Lavanya Govin

Re: [dpdk-dev] [PATCH] acl: fix build issue with some arm64 compiler

2019-06-10 Thread Aaron Conole
writes: > From: Jerin Jacob > > Some compilers reporting the following error, though the existing > code doesn't have any uninitialized variable case. > Just to make compiler happy, initialize the int32x4_t variable > one shot in C language. > > ../lib/librte_acl/acl_run_neon.h: In function 'sea

Re: [dpdk-dev] [PATCH] kernel/linux: fix modules install path

2019-06-10 Thread Igor Ryzhov
Thanks for the clarification, I get it now. I will send v2 later today. On Mon, Jun 10, 2019 at 2:12 PM Bruce Richardson wrote: > On Mon, Jun 10, 2019 at 02:04:26PM +0300, Igor Ryzhov wrote: > >Bruce, > >From my understanding, kernel_dir is a directory with kernel headers > >needed >

Re: [dpdk-dev] [PATCH v2] net/ixgbevf: add an option pflink_fullchk to get link status nowait

2019-06-10 Thread Zhang, Qi Z
> -Original Message- > From: Wang, Haiyue > Sent: Friday, June 7, 2019 11:56 PM > To: dev@dpdk.org; Zhang, Qi Z ; Lu, Wenzhuo > ; Wang, Liang-min ; > dani...@research.att.com; ktray...@redhat.com > Cc: Wang, Haiyue ; sta...@dpdk.org > Subject: [PATCH v2] net/ixgbevf: add an option pflink

Re: [dpdk-dev] [PATCH] kernel/linux: fix modules install path

2019-06-10 Thread Bruce Richardson
On Mon, Jun 10, 2019 at 02:04:26PM +0300, Igor Ryzhov wrote: >Bruce, >From my understanding, kernel_dir is a directory with kernel headers >needed >for modules building. Right now, yes. I'd suggest that we change that to the actual kernel modules directory, and we get both the bui

Re: [dpdk-dev] [PATCH] kernel/linux: fix modules install path

2019-06-10 Thread Igor Ryzhov
Bruce, >From my understanding, kernel_dir is a directory with kernel headers needed for modules building. When it's formed automatically, yes, it will be "/lib/modules/version/build" and we can get installation directory by stripping "/build". But when it's set manually, it can be set to, for exam

Re: [dpdk-dev] [PATCH 25/39] eventdev: add routine to validate conf

2019-06-10 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: Anoob Joseph > Sent: Monday, June 3, 2019 11:02 PM > To: Jerin Jacob Kollanukkaran ; Nikhil Rao > ; Erik Gabriel Carrillo ; > Abhinandan Gujjar ; Bruce Richardson > ; Pablo de Lara > > Cc: Anoob Joseph ; Narayana Prasad Raju Athreya > ; dev@dpdk.org; Lukas Bar

Re: [dpdk-dev] [PATCH 19/39] eventdev: add common initialize routine for eventmode devs

2019-06-10 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: Anoob Joseph > Sent: Monday, June 3, 2019 11:02 PM > To: Jerin Jacob Kollanukkaran ; Nikhil Rao > ; Erik Gabriel Carrillo ; > Abhinandan Gujjar ; Bruce Richardson > ; Pablo de Lara > > Cc: Anoob Joseph ; Narayana Prasad Raju Athreya > ; dev@dpdk.org; Lukas Bar

Re: [dpdk-dev] [PATCH 16/39] eventdev: add eventmode CL options framework

2019-06-10 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: Anoob Joseph > Sent: Monday, June 3, 2019 11:02 PM > To: Jerin Jacob Kollanukkaran ; Nikhil Rao > ; Erik Gabriel Carrillo ; > Abhinandan Gujjar ; Bruce Richardson > ; Pablo de Lara > > Cc: Anoob Joseph ; Narayana Prasad Raju Athreya > ; dev@dpdk.org; Lukas Bar

Re: [dpdk-dev] [PATCH 15/39] eventdev: add routines for logging eventmode helper

2019-06-10 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: Anoob Joseph > Sent: Monday, June 3, 2019 11:02 PM > To: Jerin Jacob Kollanukkaran ; Nikhil Rao > ; Erik Gabriel Carrillo ; > Abhinandan Gujjar ; Bruce Richardson > ; Pablo de Lara > > Cc: Anoob Joseph ; Narayana Prasad Raju Athreya > ; dev@dpdk.org; Lukas Bar

Re: [dpdk-dev] [PATCH 14/39] eventdev: add files for eventmode helper

2019-06-10 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: Anoob Joseph > Sent: Monday, June 3, 2019 11:02 PM > To: Jerin Jacob Kollanukkaran ; Nikhil Rao > ; Erik Gabriel Carrillo ; > Abhinandan Gujjar ; Bruce Richardson > ; Pablo de Lara > > Cc: Anoob Joseph ; Narayana Prasad Raju Athreya > ; dev@dpdk.org; Lukas Bar

Re: [dpdk-dev] [PATCH] app/testpmd: fix offloads default set error

2019-06-10 Thread Kevin Traynor
On 10/06/2019 07:45, Wei Zhao wrote: > There is no need to use default offloads configuration > if offloads configuration has been pass down from uplayer. > It doesn't seem like the right fix to me. It means if a user enable/disable one offload in the command line they are silently changing from

Re: [dpdk-dev] [PATCH 18/39] eventdev: add framework for eventmode conf

2019-06-10 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: Anoob Joseph > Sent: Monday, June 3, 2019 11:02 PM > To: Jerin Jacob Kollanukkaran ; Nikhil Rao > ; Erik Gabriel Carrillo ; > Abhinandan Gujjar ; Bruce Richardson > ; Pablo de Lara > > Cc: Anoob Joseph ; Narayana Prasad Raju Athreya > ; dev@dpdk.org; Lukas Bar

Re: [dpdk-dev] [EXT] Re: [PATCH v1 00/58] OCTEON TX2 Ethdev driver

2019-06-10 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: Ferruh Yigit > Sent: Thursday, June 6, 2019 8:53 PM > To: Jerin Jacob Kollanukkaran ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v1 00/58] OCTEON TX2 Ethdev driver > > On 6/2/2019 4:23 PM, jer...@marvell.com wrote: > > From: Jerin Jacob > > > > This pat

Re: [dpdk-dev] [PATCH] acl: fix build issue with some arm64 compiler

2019-06-10 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: Honnappa Nagarahalli > Sent: Monday, June 10, 2019 11:00 AM > To: Jerin Jacob Kollanukkaran ; dev@dpdk.org > Cc: tho...@monjalon.net; Gavin Hu (Arm Technology China) > ; msant...@redhat.com; acon...@redhat.com; > sta...@dpdk.org; Honnappa Nagarahalli ; > nd ; n

Re: [dpdk-dev] [PATCH] kernel/linux: fix modules install path

2019-06-10 Thread Bruce Richardson
On Mon, Jun 10, 2019 at 11:25:52AM +0300, Igor Ryzhov wrote: > Currently kernel modules are installed into /usr/src/ instead of > /lib/modules when meson build system is used. This patch fixes that. > > Old build option "kernel_dir" is changed to "kernel_version". > > Signed-off-by: Igor Ryzhov

Re: [dpdk-dev] Incorrect install_dir for Linux kernel modules

2019-06-10 Thread Igor Ryzhov
Done – http://patches.dpdk.org/patch/54619/ On Fri, Jun 7, 2019 at 12:29 PM Bruce Richardson wrote: > On Thu, Jun 06, 2019 at 09:33:09PM +0300, Igor Ryzhov wrote: > > Hi everyone, > > > > I faced an issue today with install directory for rte_kni and igb_uio. > > Modules are installed to '/usr/sr

[dpdk-dev] [PATCH] kernel/linux: fix modules install path

2019-06-10 Thread Igor Ryzhov
Currently kernel modules are installed into /usr/src/ instead of /lib/modules when meson build system is used. This patch fixes that. Old build option "kernel_dir" is changed to "kernel_version". Signed-off-by: Igor Ryzhov --- kernel/linux/igb_uio/meson.build | 2 +- kernel/linux/kni/meson.bui

[dpdk-dev] [PATCH v3 4/4] raw/ifpga_rawdev/base: fix miss physical address

2019-06-10 Thread Tianfei zhang
Fix miss phy_addr on ifpga_acc_get_region_info() function. Fixes: 56bb54ea1bd ("raw/ifpga/base: add Intel FPGA OPAE share code") Cc: sta...@dpdk.org Signed-off-by: Tianfei zhang --- drivers/raw/ifpga_rawdev/base/ifpga_api.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/raw/ifpga_r

[dpdk-dev] [PATCH v3 3/4] raw/ifpga_rawdev/base: fix bit fields definition

2019-06-10 Thread Tianfei zhang
Fix CTRL_DEV_SELECT bit fields definition about eth_group devices. Fixes: 8a256bef32 ("raw/ifpga/base: add eth group driver") Cc: sta...@dpdk.org Signed-off-by: Tianfei zhang --- drivers/raw/ifpga_rawdev/base/opae_eth_group.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/d

[dpdk-dev] [PATCH v3 2/4] raw/ifpga_rawdev: fix logically dead code

2019-06-10 Thread Tianfei zhang
add temporary variable in max10_reg_write(). Coverity issue: 337927 Fixes: 96ebfcf ("raw/ifpga/base: add SPI and MAX10 device driver") Cc: sta...@dpdk.org Signed-off-by: Tianfei zhang --- drivers/raw/ifpga_rawdev/base/opae_intel_max10.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-

[dpdk-dev] [PATCH v3 1/4] raw/ifpga_rawdev: fix use of untrusted scalar value

2019-06-10 Thread Tianfei zhang
Add checking the buffer size and use const char * for buffer declaration. Coverity issue: 279449 Fixes: ef1e8ede ("raw/ifpga: add Intel FPGA bus rawdev driver") Cc: sta...@dpdk.org Signed-off-by: Tianfei zhang --- drivers/raw/ifpga_rawdev/base/ifpga_api.c | 4 +-- drivers/raw/ifpga_rawdev/

[dpdk-dev] [PATCH 13/29] net/sfc/base: transition to the extensible NVRAM info API

2019-06-10 Thread Andrew Rybchenko
From: Richard Houldsworth Old NVRAM info API required function prototype too often. Signed-off-by: Richard Houldsworth Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/base/ef10_nvram.c | 20 +--- drivers/net/sfc/base/ef10_vpd.c| 7 +-- drivers/net/sfc/base/efx_im

[dpdk-dev] [PATCH 19/29] net/sfc/base: add MCDI wrappers for vPort and vSwitch in EVB

2019-06-10 Thread Andrew Rybchenko
From: Gautam Dawar Add the functions to implement the vPort and vSwitch MCDI calls. Signed-off-by: Gautam Dawar Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/base/ef10_evb.c | 299 drivers/net/sfc/base/efx.h | 18 +++ 2 files changed, 317 i

[dpdk-dev] [PATCH 02/29] net/sfc/base: fix signed/unsigned mismatch errors

2019-06-10 Thread Andrew Rybchenko
From: Andrew Lee Use UINT32_MAX instead of assigning -1 to a uint32_t variable to resolve "conversion from 'int' to 'uint32_t', signed/unsigned mismatch" errors produced by the Visual Studio 2017 toolchain [with the default /W4 /WX C compiler options which set warning level 4 and treat warnings a

[dpdk-dev] [PATCH 16/29] net/sfc/base: add definition of OEM TLV

2019-06-10 Thread Andrew Rybchenko
From: Kevin Lampis Allows to enable additional functionality related to this OEM (e.g. vendor extensions to VPD, NC-SI etc.) Signed-off-by: Kevin Lampis Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/base/ef10_tlv_layout.h | 10 ++ 1 file changed, 10 insertions(+) diff --git a/d

[dpdk-dev] [PATCH 28/29] net/sfc/base: provide API to fetch vPort statistics

2019-06-10 Thread Andrew Rybchenko
From: Gautam Dawar Hypervisor should be able to track VF statistics. Signed-off-by: Gautam Dawar Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/base/ef10_evb.c | 13 + drivers/net/sfc/base/ef10_impl.h | 7 +++ drivers/net/sfc/base/efx.h | 8 drivers/net/

[dpdk-dev] [PATCH 27/29] net/sfc/base: provide APIs to configure and reset vPort

2019-06-10 Thread Andrew Rybchenko
From: Gautam Dawar Implement functions to set vPort VLAN and MAC address and reset the vPort. Signed-off-by: Gautam Dawar Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/base/ef10_evb.c | 83 + drivers/net/sfc/base/ef10_impl.h | 9 drivers/net/sfc/base

[dpdk-dev] [PATCH 09/29] net/sfc/base: add NVRAM info to API

2019-06-10 Thread Andrew Rybchenko
From: Richard Houldsworth Add function to query partition characteristics. Refactor efx_nvram_size to share implementation. Signed-off-by: Richard Houldsworth Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/base/ef10_impl.h | 6 + drivers/net/sfc/base/ef10_nvram.c | 36 +++

[dpdk-dev] [PATCH 24/29] net/sfc/base: support proxy auth operations for SR-IOV

2019-06-10 Thread Andrew Rybchenko
From: Gautam Dawar VMware expects that certain kind of configurations made on the VFs are authorized by the ESXi before these are applied e.g. assigning a MAC address to the VF, setting MTU etc. Firmware supports a feature called MCDI proxy which will be used to implement this authorization check

[dpdk-dev] [PATCH 23/29] net/sfc/base: support data path with EVB module

2019-06-10 Thread Andrew Rybchenko
From: Gautam Dawar ef10_nic_init() allocates a vAdaptor for the physical port in current flow. In case of SR-IOV, this vAdaptor must be created for the PF as the vSwitch is allocated on the physical port. So, the call to efx_mcdi_vadaptor_alloc() should be avoided in ef10_nic_init() in SR-IOV flo

[dpdk-dev] [PATCH 29/29] net/sfc/base: add APIs for PTP privilege configuration

2019-06-10 Thread Andrew Rybchenko
From: Gautam Dawar Implement the efx_proxy_auth_privilege_mask_get() to get a function's privilege mask and efx_proxy_auth_privilege_modify() to add/remove privileges for a function specified by PF and VF index. Signed-off-by: Gautam Dawar Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/b

[dpdk-dev] [PATCH 26/29] net/sfc/base: provide proxy APIs to client drivers

2019-06-10 Thread Andrew Rybchenko
From: Gautam Dawar Implement the APIs for PROXY_CMD, PROXY_COMPLETE and PRIVILEGE_MASK messages to allow client drivers authorize VF operations like set MAC, set MTU etc. with firmware. Signed-off-by: Gautam Dawar Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/base/ef10_impl.h | 19 +++

[dpdk-dev] [PATCH 07/29] net/sfc/base: add capabilities for bundle partition support

2019-06-10 Thread Andrew Rybchenko
From: Richard Houldsworth Signed-off-by: Richard Houldsworth Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/base/ef10_nic.c | 8 drivers/net/sfc/base/efx.h | 4 +++- 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/drivers/net/sfc/base/ef10_nic.c b/drivers/net/

[dpdk-dev] [PATCH 10/29] net/sfc/base: update MCDI headers

2019-06-10 Thread Andrew Rybchenko
Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/base/efx_regs_mcdi.h | 1667 - drivers/net/sfc/base/efx_regs_mcdi_aoe.h | 13 + drivers/net/sfc/base/efx_regs_mcdi_strs.h | 174 +-- 3 files changed, 1751 insertions(+), 103 deletions(-) diff --git a/drivers

[dpdk-dev] [PATCH 25/29] net/sfc/base: implement proxy auth MCDI event handling

2019-06-10 Thread Andrew Rybchenko
From: Gautam Dawar Add the capability to receive MCDI proxy event from firmware and invoke the client driver registered function to handle it. Signed-off-by: Gautam Dawar Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/base/ef10_ev.c | 7 +++ drivers/net/sfc/base/efx.h | 3 +

[dpdk-dev] [PATCH 22/29] net/sfc/base: factor out upstream port vAdaptor allocation

2019-06-10 Thread Andrew Rybchenko
From: Gautam Dawar Separate out vAdaptor allocation from ef10_nic_init() as it is not required for SR-IOV use case. In case of SR-IOV, vAdaptor is allocated early along with vSwitch creation and vPort configuration. Signed-off-by: Gautam Dawar Signed-off-by: Andrew Rybchenko --- drivers/net/s

[dpdk-dev] [PATCH 18/29] net/sfc/base: introduce of EVB module for SR-IOV support

2019-06-10 Thread Andrew Rybchenko
From: Gautam Dawar Implement the framework for Enterprise Virtual Briding (EVB) module. SR-IOV augments the software virtual switch with NIC capbilities supported from EVB module. Further patches will add APIs to create and destroy EVB switching hierarchy required for SR-IOV and APIs to set vPort

[dpdk-dev] [PATCH 20/29] net/sfc/base: add EVB module vSwitch/vPort/vAdaptor ops

2019-06-10 Thread Andrew Rybchenko
From: Gautam Dawar Implement functions to allocate and free vSwitch, vPort and vAdaptor. Also, implement functions to add and delete vPort MAC address and EVB port assign. Most of the efx_evb_ops_t functions take vSwitch ID as a parameter for future enhancements. Currently, firmware doesn't impl

[dpdk-dev] [PATCH 06/29] net/sfc/base: add driver version string registration

2019-06-10 Thread Andrew Rybchenko
From: Richard Houldsworth Support the registration of a version string by the libefx client. The string is passed on to the MC in efx_nic_probe only to allow the MC to advertise the OS driver version in NC-SI, and the content is considered opaque for libefx. Signed-off-by: Richard Houldsworth S

[dpdk-dev] [PATCH 03/29] net/sfc/base: fix shift by more bits than field width

2019-06-10 Thread Andrew Rybchenko
From: Mark Spender This was probably an oversight when support for multiple sensor pages was added. Despite being undefined behaviour in C, it probably worked on Intel x32/x64 as on them bit shift operations wrap round. Fixes: dfb3b1ce15f6 ("net/sfc/base: import monitors access via MCDI") Cc: s

[dpdk-dev] [PATCH 21/29] net/sfc/base: implement vSwitch create/destroy

2019-06-10 Thread Andrew Rybchenko
From: Gautam Dawar The vSwitch create API takes an array of num_vports client driver allocated vPort config entries where entry at index 0 contains the PF configuration and rest num_vports-1 entries refer to vPort configuration for VFs 0 to (num_vports-2). The required hierarchy (vswitch/vport/va

[dpdk-dev] [PATCH 08/29] net/sfc/base: add extensible NVRAM info function

2019-06-10 Thread Andrew Rybchenko
From: Richard Houldsworth Includes the partition read-only flag, to allow for checks before opening the partition. Signed-off-by: Richard Houldsworth Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/base/efx.h | 10 ++ drivers/net/sfc/base/efx_impl.h | 6 drivers/net/sfc/b

[dpdk-dev] [PATCH 17/29] net/sfc/base: export the zero-based MCDI port number

2019-06-10 Thread Andrew Rybchenko
From: Gautam Dawar Proxy authorization module for SR-IOV requires one instance of proxy data structures per card. In order to achieve this, proxy data structures will be allocated only for primary port (port id 0) and other secondary ports in the card will access those data structures through ref

[dpdk-dev] [PATCH 00/29] net/sfc/base: update base driver

2019-06-10 Thread Andrew Rybchenko
checkpatches.sh generates warnings/errors because of a bit different coding style in base driver. Andrew Lee (1): net/sfc/base: fix signed/unsigned mismatch errors Andrew Rybchenko (2): net/sfc/base: do not rely on indirect header inclusion net/sfc/base: update MCDI headers Gautam Dawar (1

[dpdk-dev] [PATCH 11/29] net/sfc/base: add firmware ID header

2019-06-10 Thread Andrew Rybchenko
From: Richard Houldsworth Add definitions header for reflash header IDs. This is required to support different handling modes for signed firmware images. Signed-off-by: Richard Houldsworth Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/base/ef10_firmware_ids.h | 184 +

[dpdk-dev] [PATCH 15/29] net/sfc/base: add definition of bundle metadata partition

2019-06-10 Thread Andrew Rybchenko
From: Paul Fox Signed-off-by: Paul Fox Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/base/ef10_nvram.c | 1 + drivers/net/sfc/base/ef10_tlv_layout.h | 25 + drivers/net/sfc/base/efx.h | 1 + 3 files changed, 27 insertions(+) diff --git a/driver

[dpdk-dev] [PATCH 14/29] net/sfc/base: add background mode firmware updating

2019-06-10 Thread Andrew Rybchenko
From: Richard Houldsworth Request firmware updates be performed in background mode. In this mode MCDI to the function processing the update remains accessible and the client polls for completion. This is supported for lengthy partition updates such as MCFW and bundles. The MC ignores the flags us

[dpdk-dev] [PATCH 12/29] net/sfc/base: support direct FW update for bundle partitions

2019-06-10 Thread Andrew Rybchenko
From: Richard Houldsworth All signed images other than for the MCFW partition should be written fully to the partition with no rearrangement. Signed-off-by: Richard Houldsworth Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/base/ef10_image.c | 74 ---

[dpdk-dev] [PATCH 01/29] net/sfc/base: enable chained multicast on all EF10 cards

2019-06-10 Thread Andrew Rybchenko
From: Gautam Dawar Set WORKAROUND_BUG26807 which does the job. Fix the misunderstanding in the Medford code: i.e. the workaround is always supported by firmware, but the driver still needs to enable it. Also, as it now applies to all EF10 controllers, the implementation is moved to EF10 common p

[dpdk-dev] [PATCH 05/29] net/sfc/base: do not rely on indirect header inclusion

2019-06-10 Thread Andrew Rybchenko
Types defined in efx_types.h are used in efx.h and it is better do not rely on the header inclusion from somewhere else (typically from efsys.h). Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/base/efx.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/sfc/base/efx.h b/driver

[dpdk-dev] [PATCH 04/29] net/sfc/base: improve code style in sensors decoding

2019-06-10 Thread Andrew Rybchenko
From: Mark Spender Add more comments to simplify code reading and understanding. Signed-off-by: Mark Spender Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/base/mcdi_mon.c | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/drivers/net/sfc/bas

Re: [dpdk-dev] [dpdk-stable] [PATCH] app/testpmd: fix offloads overwrite by default configuration

2019-06-10 Thread Zhao1, Wei
Hi, Ferruh A patch has been commit for this issue by me, so no need for bug tracker https://patches.dpdk.org/patch/54584/ > -Original Message- > From: Yigit, Ferruh > Sent: Friday, May 24, 2019 9:04 PM > To: Zhao1, Wei ; dev@dpdk.org > Cc: sta...@dpdk.org; Peng, Yuan ; Lu, Wenzhuo > >

Re: [dpdk-dev] [PATCH v2 1/2] raw/ifpga: fix use of untrusted scalar value

2019-06-10 Thread Xu, Rosen
Hi, > -Original Message- > From: Zhang, Tianfei > Sent: Tuesday, June 04, 2019 23:52 > To: dev@dpdk.org; Xu, Rosen > Cc: Zhang, Tianfei ; sta...@dpdk.org; Zhang > Subject: [PATCH v2 1/2] raw/ifpga: fix use of untrusted scalar value Pls use ./devtools/check-git-log.sh to check git log bef

Re: [dpdk-dev] [PATCH v2 2/2] raw/ifpga: fix logically dead code

2019-06-10 Thread Xu, Rosen
Hi, > -Original Message- > From: Zhang, Tianfei > Sent: Tuesday, June 04, 2019 23:52 > To: dev@dpdk.org; Xu, Rosen > Cc: Zhang, Tianfei ; sta...@dpdk.org; Zhang > Subject: [PATCH v2 2/2] raw/ifpga: fix logically dead code Pls use ./devtools/check-git-log.sh to check git log before send p

Re: [dpdk-dev] [RFC 1/3] ethdev: extend flow metadata

2019-06-10 Thread Andrew Rybchenko
On 6/10/19 6:19 AM, Wang, Haiyue wrote: -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Andrew Rybchenko Sent: Sunday, June 9, 2019 22:24 To: Yongseok Koh ; shah...@mellanox.com; tho...@monjalon.net; Yigit, Ferruh ; adrien.mazarg...@6wind.com; olivier.m...@6wind.c

[dpdk-dev] [PATCH] app/testpmd: fix offloads default set error

2019-06-10 Thread Wei Zhao
There is no need to use default offloads configuration if offloads configuration has been pass down from uplayer. Fixes: 5e91aeef218c ("app/testpmd: fix offload flags after port config") Signed-off-by: Wei Zhao --- app/test-pmd/testpmd.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(

  1   2   >