[dpdk-dev] [PATCH] net/ipn3ke: delete unnecessary code

2019-05-21 Thread Andy Pei
Whether the value of ret is true or false, the end target is always run. It is unnecessary to check the value of ret, so just delete it. Coverity issue: 337930 Fixes: c01c748e4ae6 ("net/ipn3ke: add new driver") Cc: rosen...@intel.com Cc: sta...@dpdk.org Signed-off-by: Andy Pei --- drivers/net/i

[dpdk-dev] [PATCH] net/ipn3ke: delete identical branch

2019-05-21 Thread Andy Pei
Whether the if statement is ture or not, the operation is identical. It is unnecessary to check the if statement, so just delete the if statement. Coverity issue: 337928 Fixes: c820468ac99c ("net/ipn3ke: support TM") Cc: rosen...@intel.com Cc: sta...@dpdk.org Signed-off-by: Andy Pei --- drivers

[dpdk-dev] [PATCH] raw/ifpga: fix unintentional integer overflow

2019-05-21 Thread Andy Pei
cast unsigned int ports_per_retimer, unsigned int nums_retimer, unsigned int nums_fvl and unsigned int ports_per_fvl to uint64_t before multiply operation, to avoid Unintentional integer overflow. Coverity issue: 337924, 337926 Fixes: d1cd4eb2d48e ("raw/ifpga: support ipn3ke") Cc: rosen...@intel.c

[dpdk-dev] [PATCH] net/i40e: allow VF to get pctype mapping info

2019-05-21 Thread Beilei Xing
This patch allows VF to get pctype mapping info. Signed-off-by: Beilei Xing --- drivers/net/i40e/rte_pmd_i40e.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/i40e/rte_pmd_i40e.c b/drivers/net/i40e/rte_pmd_i40e.c index 7ae78e4..8a4889e 100644 --- a/drivers/net/i40e/rte_pmd_i40

Re: [dpdk-dev] [EXT] Re: [PATCH] devtools: skip the symbol check when map file under drivers

2019-05-21 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: Neil Horman > Sent: Wednesday, May 22, 2019 1:57 AM > To: Jerin Jacob Kollanukkaran > Cc: dev@dpdk.org; tho...@monjalon.net; sta...@dpdk.org > Subject: [EXT] Re: [dpdk-dev] [PATCH] devtools: skip the symbol check when > map file under drivers > > On Wed, May

Re: [dpdk-dev] [PATCH v2 0/2] Introduces armada target

2019-05-21 Thread Gavin Hu (Arm Technology China)
> -Original Message- > From: dev On Behalf Of lir...@marvell.com > Sent: Sunday, May 19, 2019 5:11 AM > To: tho...@monjalon.net > Cc: dev@dpdk.org; Liron Himi > Subject: [dpdk-dev] [PATCH v2 0/2] Introduces armada target > > From: Liron Himi > > Introduces armada target to address dif

Re: [dpdk-dev] [PATCH v1] hash: simplify signature compare neon process

2019-05-21 Thread Wang, Yipeng1
>-Original Message- >From: Ruifeng Wang [mailto:ruifeng.w...@arm.com] >Sent: Monday, April 29, 2019 3:02 AM >To: Wang, Yipeng1 ; Gobriel, Sameh >; Richardson, Bruce >; De Lara Guarch, Pablo > >Cc: dev@dpdk.org; jer...@marvell.com; honnappa.nagaraha...@arm.com; >n...@arm.com; Ruifeng Wang

Re: [dpdk-dev] [PATCH 1/2] test/hash: use existing lcore API

2019-05-21 Thread Wang, Yipeng1
>-Original Message- >From: David Marchand [mailto:david.march...@redhat.com] >Sent: Wednesday, May 15, 2019 12:57 AM >To: dev@dpdk.org >Cc: tho...@monjalon.net; step...@networkplumber.org; sta...@dpdk.org; Wang, >Yipeng1 ; Gobriel, >Sameh ; Richardson, Bruce >; De Lara Guarch, Pablo > >Su

[dpdk-dev] [PATCH 10/11] net/bnxt: HWRM version update

2019-05-21 Thread Ajit Khaparde
Update HWRM API to version 1.10.0.74 Signed-off-by: Ajit Khaparde Reviewed-by: Lance Richardson --- drivers/net/bnxt/hsi_struct_def_dpdk.h | 1399 1 file changed, 1168 insertions(+), 231 deletions(-) diff --git a/drivers/net/bnxt/hsi_struct_def_dpdk.h b/drivers/net/bn

[dpdk-dev] [PATCH 09/11] net/bnxt: update HWRM version

2019-05-21 Thread Ajit Khaparde
Update HWRM version to 1.10.0.48 Signed-off-by: Ajit Khaparde Reviewed-by: Lance Richardson --- drivers/net/bnxt/hsi_struct_def_dpdk.h | 3156 +--- 1 file changed, 2874 insertions(+), 282 deletions(-) diff --git a/drivers/net/bnxt/hsi_struct_def_dpdk.h b/drivers/net/bnxt/h

[dpdk-dev] [PATCH 11/11] net/bnxt: update release notes for bnxt

2019-05-21 Thread Ajit Khaparde
Update release doc briefly describing updates to bnxt PMD. Signed-off-by: Ajit Khaparde --- doc/guides/rel_notes/release_19_08.rst | 6 ++ 1 file changed, 6 insertions(+) diff --git a/doc/guides/rel_notes/release_19_08.rst b/doc/guides/rel_notes/release_19_08.rst index b9510f93a..2ff9d4b1c

[dpdk-dev] [PATCH 08/11] net/bnxt: update HWRM API

2019-05-21 Thread Ajit Khaparde
Update HWRM API to version 1.10.0.19 Signed-off-by: Ajit Khaparde Reviewed-by: Lance Richardson --- drivers/net/bnxt/hsi_struct_def_dpdk.h | 3112 +++- 1 file changed, 2514 insertions(+), 598 deletions(-) diff --git a/drivers/net/bnxt/hsi_struct_def_dpdk.h b/drivers/net/bn

[dpdk-dev] [PATCH 07/11] net/bnxt: fix reta query op

2019-05-21 Thread Ajit Khaparde
From: Lance Richardson Fix reta query op to only return table entries as identfied by the provided mask. Translate firmware group IDs to queue numbers. Removed extraneous code from bnxt_reta_query_op(). Fixes: d819382543f3 ("net/bnxt: add RSS redirection table operations") Signed-off-by: Lance

[dpdk-dev] [PATCH 05/11] net/bnxt: fix RSS reta indirection table update

2019-05-21 Thread Ajit Khaparde
We are trying to update the indirection table for all the VNICs. We should update the table only for the default vnic0. This patch fixes the above issue. Fixes: d819382543f3 ("net/bnxt: add RSS redirection table operations") Signed-off-by: Ajit Khaparde Reviewed-by: Rahul Gupta Reviewed-by: Lanc

[dpdk-dev] [PATCH 06/11] net/bnxt: use reta update mask and translate qid to grp id

2019-05-21 Thread Ajit Khaparde
From: Lance Richardson Fix the reta update function to only update table entries that are selected by the update mask. Translate queue number to firmware group ID when updating an entry. Fixes: d819382543f3 ("net/bnxt: add RSS redirection table operations") Signed-off-by: Lance Richardson Revie

[dpdk-dev] [PATCH 03/11] net/bnxt: implement vector mode driver

2019-05-21 Thread Ajit Khaparde
From: Lance Richardson Introduce vector mode support for the bnxt pmd. Signed-off-by: Lance Richardson Signed-off-by: Ajit Khaparde --- config/common_base | 1 + drivers/net/bnxt/Makefile| 1 + drivers/net/bnxt/bnxt_ethdev.c | 92 - drivers/net/bnx

[dpdk-dev] [PATCH 04/11] net/bnxt: fix double counting VLAN tags

2019-05-21 Thread Ajit Khaparde
From: Lance Richardson When determining whether scattered receive mode is needed, the size of a QinQ header is being added to rxmode.max_rx_pkt_len before comparing to the receive buffer size, however max_rx_pkt_len already accounts for the QinQ header size. Fix by simply comparing rxmode.max_rx_

[dpdk-dev] [PATCH 02/11] net/bnxt: compute and store scattered RX status

2019-05-21 Thread Ajit Khaparde
From: Lance Richardson In preparation for a bnxt vector-mode driver, compute and store scattered_rx status for the device when started. Signed-off-by: Lance Richardson Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_ethdev.c | 23 +++ 1 file changed, 23 insertions(+)

[dpdk-dev] [PATCH 00/11] bnxt patchset

2019-05-21 Thread Ajit Khaparde
This patchset based on top of the previous submission adds the following: 1) support for vector mode Tx and RX 2) HWRM API update (split into multiple patches) 3) fixes for RSS reta update and query It also updates the release notes. Please apply. Ajit Khaparde (5): net/bnxt: fix RSS reta indi

[dpdk-dev] [PATCH 01/11] net/bnxt: move tx bd checking to header file

2019-05-21 Thread Ajit Khaparde
From: Lance Richardson To allow sharing of tx_bds_in_hw() and bnxt_tx_avail() between vector-mode and non-vector transmit functions, move these functions into bnxt_txr.h. Signed-off-by: Lance Richardson Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_txr.c | 15 --- drivers/n

[dpdk-dev] [PATCH] net/mlx4: use dynamic log type

2019-05-21 Thread Stephen Hemminger
This driver should use dynamic log level not RTE_LOGTYPE_PMD. Other drivers were converted back in 18.02. This is really a bug, all other drivers use dynamic log levels by now. Signed-off-by: Stephen Hemminger --- drivers/net/mlx4/mlx4.c | 8 drivers/net/mlx4/mlx4_utils.h | 6 +++

Re: [dpdk-dev] [PATCH 2/3] net/i40e: add runtime option to disable vector rx

2019-05-21 Thread Ergin, Mesut A
> -Original Message- > From: Ananyev, Konstantin > Sent: Tuesday, May 21, 2019 10:21 AM > To: Ergin, Mesut A ; Xing, Beilei > ; Zhang, Qi Z > Cc: dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH 2/3] net/i40e: add runtime option to disable > vector rx > > > > > > > > > > > > > > > > > >

[dpdk-dev] Arm's roadmap for 19.08

2019-05-21 Thread Honnappa Nagarahalli
Hello, Following are the work items planned for 19.08 release: 1) Integrate WFE/SEV instructions in spinlock and ring library 2) Introduce MCS lock library 3) Address race conditions in LPM library 4) Lock-free rte_hash single thread performance improvements 5) Add support for lock-free s

Re: [dpdk-dev] [PATCH] devtools: skip the symbol check when map file under drivers

2019-05-21 Thread Neil Horman
On Wed, May 22, 2019 at 01:26:28AM +0530, jer...@marvell.com wrote: > From: Jerin Jacob > > Drivers do not have ABI. > Skip the symbol check if map file under drivers directory. > > Fixes: 4bec48184e33 ("devtools: add checks for ABI symbol addition") > > Cc: sta...@dpdk.org > Cc: Neil Horman >

[dpdk-dev] [PATCH] devtools: skip the symbol check when map file under drivers

2019-05-21 Thread jerinj
From: Jerin Jacob Drivers do not have ABI. Skip the symbol check if map file under drivers directory. Fixes: 4bec48184e33 ("devtools: add checks for ABI symbol addition") Cc: sta...@dpdk.org Cc: Neil Horman Signed-off-by: Jerin Jacob --- devtools/check-symbol-change.sh | 8 1 file

Re: [dpdk-dev] [PATCH 3/5] vhost: do not inline unlikely fragmented buffers code

2019-05-21 Thread Mattias Rönnblom
On 2019-05-17 14:22, Maxime Coquelin wrote: Handling of fragmented virtio-net header and indirect descriptors tables was implemented to fix CVE-2018-1059. It should not never happen with healthy guests and so are already considered as unlikely code path. This patch moves these bits into non-inli

Re: [dpdk-dev] [PATCH 2/3] net/i40e: add runtime option to disable vector rx

2019-05-21 Thread Ananyev, Konstantin
> > > > > > > > > > > > > > Vector RX functions are not at feature parity with non-vector ones and > > > > > currently the vector RX path is enabled by default. Hence, the only > > > > > option to force selection of non-vector variants and be able to retain > > > > > functionality is to disable

Re: [dpdk-dev] [PATCH 2/3] net/i40e: add runtime option to disable vector rx

2019-05-21 Thread Ergin, Mesut A
> -Original Message- > From: Ananyev, Konstantin > Sent: Monday, May 20, 2019 4:11 PM > To: Ergin, Mesut A ; Xing, Beilei > ; Zhang, Qi Z > Cc: dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH 2/3] net/i40e: add runtime option to disable > vector rx > > > > > > > > > Hi > > > > > > > > > >

Re: [dpdk-dev] [PATCH] doc: fix typo in release note

2019-05-21 Thread Kevin Traynor
On 21/05/2019 15:33, Ferruh Yigit wrote: > On 5/21/2019 9:46 AM, Yong Wang wrote: >> The patch fixes some typoes in 19.02 release note. >> >> Fixes: 6f04df497962 ("doc: add release notes for mlx5") >> Fixes: bf9a90e2b562 ("doc: update release notes for 19.02") >> >> Signed-off-by: Yong Wang > > I

Re: [dpdk-dev] [PATCH 00/15] prefix network structures

2019-05-21 Thread Stephen Hemminger
On Tue, 21 May 2019 18:13:00 +0200 Olivier Matz wrote: > The rte_net headers conflict with the libc headers, because > some definitions are duplicated, sometimes with few differences. > > This patchset adds the rte_ (or RTE_) prefix to all structures, functions > and defines in rte_net library.

[dpdk-dev] [PATCH 14/15] net: add rte prefix to udp structure

2019-05-21 Thread Olivier Matz
Add 'rte_' prefix to structures: - rename struct udp_hdr as struct rte_udp_hdr. Signed-off-by: Olivier Matz --- app/test-pmd/csumonly.c| 27 ++- app/test-pmd/flowgen.c | 4 ++-- app/test-pmd/txonly.c | 8 app/tes

Re: [dpdk-dev] [RFC v2 00/14] prefix network structures

2019-05-21 Thread Olivier Matz
Hi Ferruh, On Mon, May 20, 2019 at 06:11:35PM +0100, Ferruh Yigit wrote: > On 4/10/2019 9:32 AM, Olivier Matz wrote: > > This RFC targets 19.08. > > > > The rte_net headers conflict with the libc headers, because > > some definitions are duplicated, sometimes with few differences. > > > > This R

[dpdk-dev] [PATCH 15/15] doc: announce network api change

2019-05-21 Thread Olivier Matz
Signed-off-by: Olivier Matz --- doc/guides/rel_notes/deprecation.rst | 4 doc/guides/rel_notes/release_19_08.rst | 3 +++ 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst index 098d24381..7e2dcb769 1

[dpdk-dev] [PATCH 12/15] net: add rte prefix to sctp structure

2019-05-21 Thread Olivier Matz
Add 'rte_' prefix to structures: - rename struct sctp_hdr as struct rte_sctp_hdr. Signed-off-by: Olivier Matz --- app/test-pmd/csumonly.c | 5 +++-- app/test/packet_burst_generator.c | 6 +++--- app/test/packet_burst_generator.h | 2 +- app/test/test_flow_classify.c | 2 +- dri

[dpdk-dev] [PATCH 13/15] net: add rte prefix to tcp structure

2019-05-21 Thread Olivier Matz
Add 'rte_' prefix to structures: - rename struct tcp_hdr as struct rte_tcp_hdr. Signed-off-by: Olivier Matz --- app/test-pmd/csumonly.c| 14 -- app/test/packet_burst_generator.c | 10 +- app/test/packet_burst_generator.h | 2

[dpdk-dev] [PATCH 11/15] net: add rte prefix to ip defines

2019-05-21 Thread Olivier Matz
Add 'RTE_' prefix to defines: - rename IPv4( as RTE_IPv4(. - rename IPV4_MAX_PKT_LEN as RTE_IPV4_MAX_PKT_LEN. - rename IPV4_HDR_IHL_MASK as RTE_IPV4_HDR_IHL_MASK. - rename IPV4_IHL_MULTIPLIER as RTE_IPV4_IHL_MULTIPLIER. - rename IPV4_HDR_DF_SHIFT as RTE_IPV4_HDR_DF_SHIFT. - rename IPV4_HDR_MF_SHIFT

[dpdk-dev] [PATCH 09/15] net: add rte prefix to icmp defines

2019-05-21 Thread Olivier Matz
Add 'RTE_' prefix to defines: - rename IP_ICMP_ECHO_REPLY as RTE_IP_ICMP_ECHO_REPLY. - rename IP_ICMP_ECHO_REQUEST as RTE_IP_ICMP_ECHO_REQUEST. Signed-off-by: Olivier Matz --- app/test-pmd/icmpecho.c | 10 +- lib/librte_net/rte_icmp.h | 4 ++-- 2 files changed, 7 insertions(+), 7 dele

[dpdk-dev] [PATCH 07/15] net: add rte prefix to gre structure

2019-05-21 Thread Olivier Matz
Add 'rte_' prefix to structures: - rename struct gre_hdr as struct rte_gre_hdr. Signed-off-by: Olivier Matz --- drivers/net/mlx5/mlx5_flow_dv.c | 4 ++-- lib/librte_net/rte_gre.h| 2 +- lib/librte_net/rte_net.c| 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git

[dpdk-dev] [PATCH 06/15] net: add rte prefix to esp structure

2019-05-21 Thread Olivier Matz
Add 'rte_' prefix to structures: - rename struct esp_hdr as struct rte_esp_hdr. Signed-off-by: Olivier Matz --- app/test/test_ipsec.c| 4 ++-- examples/ipsec-secgw/esp.c | 47 +++- examples/ipsec-secgw/sa.c| 6 +++--- lib/librte_ethdev/rte_

[dpdk-dev] [PATCH 08/15] net: add rte prefix to icmp structure

2019-05-21 Thread Olivier Matz
Add 'rte_' prefix to structures: - rename struct icmp_hdr as struct rte_icmp_hdr. Signed-off-by: Olivier Matz --- app/test-pmd/icmpecho.c | 4 ++-- lib/librte_ethdev/rte_flow.h | 2 +- lib/librte_net/rte_icmp.h| 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/app/te

[dpdk-dev] [PATCH 02/15] net: add rte prefix to arp defines

2019-05-21 Thread Olivier Matz
Add 'RTE_' prefix to defines: - rename ARP_HRD_ETHER as RTE_ARP_HRD_ETHER. - rename ARP_OP_REQUEST as RTE_ARP_OP_REQUEST. - rename ARP_OP_REPLY as RTE_ARP_OP_REPLY. - rename ARP_OP_REVREQUEST as RTE_ARP_OP_REVREQUEST. - rename ARP_OP_REVREPLY as RTE_ARP_OP_REVREPLY. - rename ARP_OP_INVREQUEST as RT

[dpdk-dev] [PATCH 00/15] prefix network structures

2019-05-21 Thread Olivier Matz
The rte_net headers conflict with the libc headers, because some definitions are duplicated, sometimes with few differences. This patchset adds the rte_ (or RTE_) prefix to all structures, functions and defines in rte_net library. This is a big changeset, that will break the API of many functions,

[dpdk-dev] [PATCH 01/15] net: add rte prefix to arp structures

2019-05-21 Thread Olivier Matz
Also rename arp_hrd, arp_pro, arp_hln, arp_pln and arp_op fields to avoid conflict with the #defines in gnu libc. Signed-off-by: Olivier Matz --- app/test-pmd/icmpecho.c| 24 ++--- app/test/packet_burst_generator.c | 12 +-- app/test/packet_burst_gene

[dpdk-dev] [dpdk-announce] Reminder DPDK userspace CFP

2019-05-21 Thread Trishan de Lanerolle
*New Venue for DPDK Userspace, * *LA CITE DU VIN* *Bordeaux, France* *September 19 - 20, 2019* *Call for Proposal is now open.* https://events.linuxfoundation.jp/events/dpdk-userspace-2019-bordeaux/program/call-for-proposals-cfp/ Call For Paper submissions must be received by 11:59pm PST on *Fri

[dpdk-dev] 19.08 Intel Roadmap

2019-05-21 Thread O'Driscoll, Tim
These are the features that we plan to submit for the 19.08 release: Intel(r) Ethernet 800 Series Network Adapter Enhancements: Enhancements to the ICE and IAVF PMDs to support rte_flow, ethertype and tunnel filters, and inner L3/L4 checksum strip/insertion for Intel(r) Ethernet 800 Series Netw

Re: [dpdk-dev] [dpdk-stable] [PATCH] app/testpmd: fix offloads overwrite by default configuration

2019-05-21 Thread Ferruh Yigit
On 5/21/2019 2:30 AM, Zhao1, Wei wrote: > Hi, Ferruh > >> -Original Message- >> From: Yigit, Ferruh >> Sent: Monday, May 20, 2019 11:23 PM >> To: Zhao1, Wei ; dev@dpdk.org >> Cc: sta...@dpdk.org; Peng, Yuan ; Lu, Wenzhuo >> >> Subject: Re: [dpdk-stable] [PATCH] app/testpmd: fix offloads o

Re: [dpdk-dev] [PATCH] rte_flow: mark rte_flow_error_set as cold

2019-05-21 Thread Ferruh Yigit
On 5/21/2019 3:31 PM, Stephen Hemminger wrote: > On Tue, 21 May 2019 08:01:53 + > "Van Haaren, Harry" wrote: > >>> -Original Message- >>> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Stephen Hemminger >>> Sent: Monday, May 20, 2019 11:52 PM >>> To: adrien.mazarg...@6wind.com >

[dpdk-dev] [PATCH] compress/qat: fixed overflow status return from qat pmd

2019-05-21 Thread Adam Dybkowski
This patch fixes fail status returned from compression PMD in case destination buffer size in not enough to store all data. Fixes: 3dc9ef2d23fe ("compress/qat: fix returned status on overflow") Signed-off-by: Adam Dybkowski --- drivers/compress/qat/qat_comp.c | 21 + drivers/

Re: [dpdk-dev] [PATCH] compress/isal: fix use after free

2019-05-21 Thread Daly, Lee
Hi Stephen, Thanks for the patch. > -Original Message- > From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Tuesday, May 21, 2019 3:47 PM > To: Daly, Lee > Cc: dev@dpdk.org; Stephen Hemminger > Subject: [PATCH] compress/isal: fix use after free > > The release function

Re: [dpdk-dev] [PATCH v1] examples/l3fwd-power: add telemetry mode support

2019-05-21 Thread Pattan, Reshma
> -Original Message- > From: Burakov, Anatoly > Sent: Monday, May 20, 2019 2:17 PM > To: Pattan, Reshma ; dev@dpdk.org > Cc: Hunt, David ; Ma, Liang J > Subject: Re: [PATCH v1] examples/l3fwd-power: add telemetry mode support > > > --- > > > > > + poll_count = 0;

[dpdk-dev] [PATCH] compress/isal: fix use after free

2019-05-21 Thread Stephen Hemminger
The release function was using qp->stream after already releasing it and the null pointer checking was missing. Also since rte_free(NULL) is a no-op, remove unnecessary checks for NULL. Coverity issure: 340860 Fixes: dc49e6aa4879 ("compress/isal: add ISA-L compression functionality") Signed-off-b

Re: [dpdk-dev] Generating Debug information in Windows using Clang (PDB files)

2019-05-21 Thread Adham Masarwah
On Tue, May 21, 2019 at 01:41:06PM +, Adham Masarwah wrote: > > > > >From: Bruce Richardson > > >Sent: Tuesday, May 21, 2019 11:22 AM > > > > > >On Mon, May 20, 2019 at 07:02:22PM +0100, Menon, Ranjit wrote: > > >>Adham… > > >> > > >>I don’t think we debugged using clang compiled cod

Re: [dpdk-dev] [PATCH] doc: fix typo in release note

2019-05-21 Thread Ferruh Yigit
On 5/21/2019 9:46 AM, Yong Wang wrote: > The patch fixes some typoes in 19.02 release note. > > Fixes: 6f04df497962 ("doc: add release notes for mlx5") > Fixes: bf9a90e2b562 ("doc: update release notes for 19.02") > > Signed-off-by: Yong Wang I am not in favor of updating old release notes, I b

Re: [dpdk-dev] [PATCH] rte_flow: mark rte_flow_error_set as cold

2019-05-21 Thread Stephen Hemminger
On Tue, 21 May 2019 08:01:53 + "Van Haaren, Harry" wrote: > > -Original Message- > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Stephen Hemminger > > Sent: Monday, May 20, 2019 11:52 PM > > To: adrien.mazarg...@6wind.com > > Cc: dev@dpdk.org; Stephen Hemminger > > Subject:

[dpdk-dev] 18.11.2 (LTS) patches review and test

2019-05-21 Thread Kevin Traynor
Hi all, Here is a list of patches targeted for LTS release 18.11.2. The planned date for the final release is 11th June. Please help with testing and validation of your use cases and report any issues/results. For the final release I will update the release notes with fixes and reported validati

Re: [dpdk-dev] Generating Debug information in Windows using Clang (PDB files)

2019-05-21 Thread Bruce Richardson
On Tue, May 21, 2019 at 01:41:06PM +, Adham Masarwah wrote: > > >From: Bruce Richardson > >Sent: Tuesday, May 21, 2019 11:22 AM > > > >On Mon, May 20, 2019 at 07:02:22PM +0100, Menon, Ranjit wrote: > >>Adham… > >> > >>I don’t think we debugged using clang compiled code for Hello wor

Re: [dpdk-dev] Generating Debug information in Windows using Clang (PDB files)

2019-05-21 Thread Adham Masarwah
>From: Bruce Richardson >Sent: Tuesday, May 21, 2019 11:22 AM > >On Mon, May 20, 2019 at 07:02:22PM +0100, Menon, Ranjit wrote: >>Adham… >> >>I don’t think we debugged using clang compiled code for Hello world – >>mainly because it was only a “helloworld” application and we didn’t >

[dpdk-dev] [Bug 283] BPF: array ins_chk is missing an entry

2019-05-21 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=283 Bug ID: 283 Summary: BPF: array ins_chk is missing an entry Product: DPDK Version: 19.08 Hardware: All OS: All Status: CONFIRMED Severity: normal Priorit

Re: [dpdk-dev] [PATCH] mempool: optimize copy in cache get

2019-05-21 Thread Andrew Rybchenko
On 5/21/19 12:03 PM, Xiao Wang wrote: Use rte_memcpy to improve the pointer array copy. This optimization method has already been applied to __mempool_generic_put() [1], this patch applies it to __mempool_generic_get(). Slight performance gain can be observed in testpmd txonly test. [1] 863bfb47

[dpdk-dev] [PATCH] doc: fix typo in release note

2019-05-21 Thread Yong Wang
The patch fixes some typoes in 19.02 release note. Fixes: 6f04df497962 ("doc: add release notes for mlx5") Fixes: bf9a90e2b562 ("doc: update release notes for 19.02") Signed-off-by: Yong Wang --- doc/guides/rel_notes/release_19_02.rst | 8 1 file changed, 4 insertions(+), 4 deletions(-

[dpdk-dev] [PATCH] mempool: optimize copy in cache get

2019-05-21 Thread Xiao Wang
Use rte_memcpy to improve the pointer array copy. This optimization method has already been applied to __mempool_generic_put() [1], this patch applies it to __mempool_generic_get(). Slight performance gain can be observed in testpmd txonly test. [1] 863bfb47449 ("mempool: optimize copy in cache")

Re: [dpdk-dev] [PATCH v1] net/ice: update the RSS RETA size with support values

2019-05-21 Thread Zhang, Qi Z
> -Original Message- > From: Yang, Qiming > Sent: Tuesday, May 21, 2019 2:46 PM > To: Wang, Haiyue ; dev@dpdk.org; Zhang, Qi Z > ; Wu, Jingjing ; Lu, Wenzhuo > > Subject: RE: [PATCH v1] net/ice: update the RSS RETA size with support values > > > -Original Message- > From: Wang

Re: [dpdk-dev] [PATCH] net/i40e: enable new device

2019-05-21 Thread Zhang, Qi Z
> -Original Message- > From: Xing, Beilei > Sent: Wednesday, May 15, 2019 9:59 AM > To: Zhang, Qi Z > Cc: dev@dpdk.org > Subject: [PATCH] net/i40e: enable new device > > This patch removes ifdef to enable new device. > > Signed-off-by: Beilei Xing Acked-by: Qi Zhang Applied to dpd

Re: [dpdk-dev] [PATCH v4] vhost: support inflight share memory protocol feature

2019-05-21 Thread Tiwei Bie
On Tue, May 21, 2019 at 04:29:31PM +0800, lin li wrote: > Tiwei Bie 于2019年5月20日周一上午10:14写道: > > > > On Fri, May 17, 2019 at 05:47:07PM +0200, Maxime Coquelin wrote: > > > On 5/5/19 11:02 AM, Li Lin wrote: > > [...] > > > > /** > > > >* Device structure contains all configuration information

Re: [dpdk-dev] [PATCH] app/test-compress-perf: fix reliance on integer endianness

2019-05-21 Thread Jozwiak, TomaszX
Hi Shally > -Original Message- > From: Shally Verma [mailto:shal...@marvell.com] > Sent: Tuesday, May 21, 2019 10:04 AM > To: Jozwiak, TomaszX ; Trahe, Fiona > ; dev@dpdk.org; sta...@dpdk.org > Cc: Trybula, ArturX > Subject: RE: [PATCH] app/test-compress-perf: fix reliance on integer > en

Re: [dpdk-dev] [PATCH v4] vhost: support inflight share memory protocol feature

2019-05-21 Thread lin li
Tiwei Bie 于2019年5月20日周一 上午10:14写道: > > On Fri, May 17, 2019 at 05:47:07PM +0200, Maxime Coquelin wrote: > > On 5/5/19 11:02 AM, Li Lin wrote: > [...] > > > /** > > >* Device structure contains all configuration information relating > > >* to the device. > > > @@ -303,6 +314,7 @@ struct v

Re: [dpdk-dev] Generating Debug information in Windows using Clang (PDB files)

2019-05-21 Thread Bruce Richardson
On Mon, May 20, 2019 at 07:02:22PM +0100, Menon, Ranjit wrote: >Adham… > >I don’t think we debugged using clang compiled code for Hello world – >mainly because it was only a “helloworld” application and we didn’t >quite need any debugging!:-) > > >I found this link: >[1]h

[dpdk-dev] [PATCH 11/11] net/hinic: add support for basic device operations

2019-05-21 Thread Ziyang Xuan
Add hinic PMD initialization and ethernet operatioins code. Signed-off-by: Ziyang Xuan --- drivers/net/hinic/Makefile |2 +- drivers/net/hinic/hinic_pmd_ethdev.c| 2157 +++ drivers/net/hinic/rte_pmd_hinic_version.map |4 + 3 files changed,

[dpdk-dev] [PATCH 10/11] net/hinic: add TX module

2019-05-21 Thread Ziyang Xuan
Add code for TX module Signed-off-by: Ziyang Xuan --- drivers/net/hinic/Makefile |2 +- drivers/net/hinic/hinic_pmd_tx.c | 1036 ++ 2 files changed, 1037 insertions(+), 1 deletion(-) create mode 100644 drivers/net/hinic/hinic_pmd_tx.c diff --git a/

[dpdk-dev] [PATCH 09/11] net/hinic: add RX module

2019-05-21 Thread Ziyang Xuan
Add code for RX module. Signed-off-by: Ziyang Xuan --- drivers/net/hinic/Makefile | 2 +- drivers/net/hinic/hinic_pmd_rx.c | 906 +++ 2 files changed, 907 insertions(+), 1 deletion(-) create mode 100644 drivers/net/hinic/hinic_pmd_rx.c diff --git a/d

[dpdk-dev] [PATCH 08/11] net/hinic: add hinic PMD build and doc files

2019-05-21 Thread Ziyang Xuan
Add build and doc files, and common code files. Signed-off-by: Ziyang Xuan --- MAINTAINERS | 9 + config/common_base | 5 + doc/guides/nics/features/hinic.ini | 32 ++ drivers/net/Makefile| 1 + drivers/net/hinic/Makefile

[dpdk-dev] [PATCH 07/11] net/hinic/base: add various headers

2019-05-21 Thread Ziyang Xuan
Add various headers that define mgmt commands, cmdq commands, rx data structures, tx data structures and basic defines for use in the code. Signed-off-by: Ziyang Xuan --- drivers/net/hinic/base/hinic_compat.h | 257 + drivers/net/hinic/base/hinic_port_cmd.h | 494 ++

[dpdk-dev] [PATCH 06/11] net/hinic/base: add code for nic business

2019-05-21 Thread Ziyang Xuan
Add code for nic business, including qps structures, qps configuration, wqs configuration for qps, nic business configuration functionalities. Signed-off-by: Ziyang Xuan --- drivers/net/hinic/base/hinic_pmd_nic.h| 85 ++ drivers/net/hinic/base/hinic_pmd_niccfg.c | 1408

[dpdk-dev] [PATCH 05/11] net/hinic/base: add eqs and context code

2019-05-21 Thread Ziyang Xuan
Add code for eq. Aeq is a kind queue for mgmt asynchronous message and mgmt command response message. Signed-off-by: Ziyang Xuan --- drivers/net/hinic/base/hinic_ctx_def.h | 201 + drivers/net/hinic/base/hinic_pmd_dpdev.h | 149 +++ drivers/net/hinic/base/hinic_pmd_eqs.c | 736 ++

[dpdk-dev] [PATCH 04/11] net/hinic/base: add code about hardware operation

2019-05-21 Thread Ziyang Xuan
Add code for hardware operation, including configuration, query and so on. Signed-off-by: Ziyang Xuan --- drivers/net/hinic/base/hinic_pmd_cfg.c | 269 ++ drivers/net/hinic/base/hinic_pmd_cfg.h | 264 + drivers/net/hinic/base/hinic_pmd_hw.h| 49 + drivers/net/hinic/base/hinic

[dpdk-dev] [PATCH 03/11] net/hinic/base: add mgmt module interactive code

2019-05-21 Thread Ziyang Xuan
Add the structures, functionalities for interaction with mgmt module. Signed-off-by: Ziyang Xuan --- drivers/net/hinic/base/hinic_pmd_hw_mgmt.h| 85 +++ drivers/net/hinic/base/hinic_pmd_mgmt.c | 619 ++ drivers/net/hinic/base/hinic_pmd_mgmt.h | 12

[dpdk-dev] [PATCH 02/11] net/hinic/base: add command channels code

2019-05-21 Thread Ziyang Xuan
Admin channels include api channel and command queue, Api channel is for mgmt module. And command queue is for ucode module. Signed-off-by: Ziyang Xuan --- drivers/net/hinic/base/hinic_pmd_api_cmd.c | 1040 drivers/net/hinic/base/hinic_pmd_api_cmd.h | 271

[dpdk-dev] [PATCH 01/11] net/hinic/base: add registers for Huawei Hi1822 NIC

2019-05-21 Thread Ziyang Xuan
Add the registers that comprise the Huawei Hi1822 NIC. There is no functionality in this patch. Signed-off-by: Ziyang Xuan --- drivers/net/hinic/base/hinic_csr.h | 172 + 1 file changed, 172 insertions(+) create mode 100644 drivers/net/hinic/base/hinic_csr.h

Re: [dpdk-dev] [PATCH] app/test-compress-perf: fix reliance on integer endianness

2019-05-21 Thread Shally Verma
HI Tomasz > -Original Message- > From: Jozwiak, TomaszX > Sent: Tuesday, May 21, 2019 12:18 PM > To: Trahe, Fiona ; dev@dpdk.org; Shally Verma > ; sta...@dpdk.org > Cc: Trybula, ArturX > Subject: [EXT] RE: [PATCH] app/test-compress-perf: fix reliance on integer > endianness > > External

[dpdk-dev] [PATCH 00/11] A new net PMD - hinic

2019-05-21 Thread Ziyang Xuan
This patch set adds support of a new net PMD for Huawei Intelligent nic. This patch provides supoort for basic RX/TX and the contorl path needed for it. Later on new features will be added like VLAN, VFs, etc. Basic features: 1. Basic device operations: probe, initialization, start/stop, config

Re: [dpdk-dev] [PATCH] rte_flow: mark rte_flow_error_set as cold

2019-05-21 Thread Van Haaren, Harry
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Stephen Hemminger > Sent: Monday, May 20, 2019 11:52 PM > To: adrien.mazarg...@6wind.com > Cc: dev@dpdk.org; Stephen Hemminger > Subject: [dpdk-dev] [PATCH] rte_flow: mark rte_flow_error_set as cold > > A minor op