[dpdk-dev] [RFC] eventdev: replace mbufs with events in Rx callback

Replace the mbuf pointer array in the event eth Rx adapter callback with an event array instead of an mbuf array. Using an event array allows the application to change attributes of the events enqueued by the SW adapter. Signed-off-by: Nikhil Rao --- Hi All, Please review the new interface prop

[dpdk-dev] [PATCH] net/mlx5: match on TCP flags via DV/DR engine

Add support to match all TCP control bits (flags) except "NS (ECN-nonce)" via Direct Verbs (DV) or Direct Rule (DR) engine. Signed-off-by: Xiaoyu Min --- drivers/net/mlx5/mlx5_flow_dv.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_flow_dv

Re: [dpdk-dev] [PATCH] doc: announce API change to remove exit calls in libs

On Wed, May 8, 2019 at 11:54 PM Thomas Monjalon wrote: > Two public functions from EAL and metrics libraries need to return > some new error codes instead of calling rte_panic or rte_exit. > > Signed-off-by: Thomas Monjalon > --- > > -- > 2.21.0 > > Acked-By: Arnon Warshavsky

Re: [dpdk-dev] [PATCH] net/i40e: fix error when create two RSS flow rule

Tested-by: Li WenjieX > -Original Message- > From: Zhao1, Wei > Sent: Thursday, May 9, 2019 11:00 AM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Zhang, Qi Z ; Peng, Yuan > ; Zhao1, Wei > Subject: [PATCH] net/i40e: fix error when create two RSS flow rule > > There is need to refuse to crea

[dpdk-dev] [PATCH] net/i40e: fix error when create two RSS flow rule

There is need to refuse to create the second RSS flow rule as only one RSS key and HASH register for each PF port. Users should delete the first rule before setup the second rule. Fixes: ecad87d22383 ("net/i40e: move RSS to flow API") Cc: sta...@dpdk.org Signed-off-by: Wei Zhao --- drivers/net/

[dpdk-dev] [PATCH v1] net/af_xdp: enable zero copy by extbuf

Implement zero copy of af_xdp pmd through mbuf's external memory mechanism to achieve high performance. This patch also provides a new parameter "pmd_zero_copy" for user, so they can choose to enable zero copy of af_xdp pmd or not. To be clear, "zero copy" here is different from the "zero copy mo

Re: [dpdk-dev] [PATCH] doc: add deprecation notice on timer lib cleanup

On Wed, 8 May 2019 17:48:06 -0500 Erik Gabriel Carrillo wrote: > Due to an upcoming fix to allow the timer library to safely free its > allocations during the finalize() call[1], an ABI change will be > required. A new lock will be added to the rte_mem_config structure, > which will be used by t

Re: [dpdk-dev] [RFC v3 1/2] eal: replace libc-based random number generation with LFSR

On Wed, 8 May 2019 22:30:00 +0200 Mattias Rönnblom wrote: > On 2019-05-08 22:12, Stephen Hemminger wrote: > > On Wed, 24 Apr 2019 14:33:19 +0200 > > Mattias Rönnblom wrote: > > > >> diff --git a/lib/librte_eal/linux/eal/eal.c > >> b/lib/librte_eal/linux/eal/eal.c > >> index 161399619..d6bf0e

[dpdk-dev] [PATCH v2] doc: add Mellanox BlueField platform guide

Platform specific guide for Mellanox BlueField SoC is added. Signed-off-by: Yongseok Koh --- v2: * remove release note update * cosmetic changes * make contents clearer .../linux_gsg/cross_build_dpdk_for_arm64.rst | 2 + doc/guides/platform/bluefield.rst | 147 ++

Re: [dpdk-dev] [PATCH v2] timer: fix resource leak in finalize

> -Original Message- > From: Burakov, Anatoly > Sent: Wednesday, May 8, 2019 3:50 AM > To: Carrillo, Erik G ; rsanf...@akamai.com; > tho...@monjalon.net > Cc: dev@dpdk.org > Subject: Re: [PATCH v2] timer: fix resource leak in finalize > > On 07-May-19 11:04 PM, Carrillo, Erik G wrote: >

[dpdk-dev] [PATCH v2 0/2] hash: fix bugs in 'free key with position'

This patch series solves 2 bugs reported on Bugzilla (bug-261) within the function rte_hash_free_key_with_postion(). It also adds a test case to catch similar bugs in the future. https://bugs.dpdk.org/show_bug.cgi?id=261 --- v2: * Add comments in test_hash.c (Yipeng) * Resolve checkpatch warnin

[dpdk-dev] [PATCH v2 1/2] hash: fix bugs in 'free key with position'

This patch fixes 2 bugs- 1] Incorrect position returned to the free slots. 2] Incorrect computation of total_entries Bugzilla ID: 261 Fixes: 9d033dac7d7c ("hash: support no free on delete") Cc: honnappa.nagaraha...@arm.com Cc: sta...@dpdk.org Reported-by: Linfan Suggested-by: Linfan Signed-off-

[dpdk-dev] [PATCH v2 2/2] test/hash: add test for 'free key with position'

This patch adds a unit test for rte_hash_free_key_with_position(). Suggested-by: Linfan Signed-off-by: Dharmik Thakkar --- app/test/test_hash.c | 94 1 file changed, 94 insertions(+) diff --git a/app/test/test_hash.c b/app/test/test_hash.c index 390

Re: [dpdk-dev] [PATCH 2/2] test/hash: add test for 'free key with position'

> On May 8, 2019, at 3:11 PM, Wang, Yipeng1 wrote: > > Hi, thanks for the patch! > Reply inlined: Hi Yipeng, Thank you for the review! > >> -Original Message- >> From: Dharmik Thakkar [mailto:dharmik.thak...@arm.com] >> Sent: Wednesday, May 8, 2019 9:51 AM >> To: Wang, Yipeng1 ; Gobri

Re: [dpdk-dev] [PATCH v3 1/4] test: fix typo in print statement

It seems your emails are not threaded at all. It makes really hard to review them. All patches of a patchset must be in the same thread, ideally with a cover letter. All versions of a patchset must be in the same thread, ideally with the cover letter v1 being the common ancestor. Please check h

[dpdk-dev] [PATCH] doc: add deprecation notice on timer lib cleanup

Due to an upcoming fix to allow the timer library to safely free its allocations during the finalize() call[1], an ABI change will be required. A new lock will be added to the rte_mem_config structure, which will be used by the timer library to synchronize init/finalize calls among multiple process

[dpdk-dev] [PATCH v3] timer: fix resource leak in finalize

By using a lock added to the rte_mem_config (which lives in shared memory), we can synchronize multiple processes in init/finalize and safely free allocations made during init. Signed-off-by: Erik Gabriel Carrillo --- changes in v3: - The previous version had race condition. This version fixes

[dpdk-dev] [PATCH] timer: allow first subsystem init from secondary

Since memzones can be reserved from secondary processes as well as primary processes, if the first call to the timer subsystem init function occurs in a secondary process, we should allow it to succeed. Fixes: c0749f7096c7 ("timer: allow management in shared memory") Signed-off-by: Erik Gabriel C

Re: [dpdk-dev] [PATCH v3 1/4] test: fix typo in print statement

Hi David, 08/05/2019 23:02, David Christensen: > v2: > * None > v3: > * None It seems your emails are not threaded at all. It makes really hard to review them. All patches of a patchset must be in the same thread, ideally with a cover letter. All versions of a patchset must be in the same thread,

[dpdk-dev] [PATCH v3 2/4] test: verify calloc succeeded for sum variable

Code tested calloc failures for pt & lpt variables but not for the sum variable. Add a test for calloc failure of sum. Signed-off-by: David Christensen --- v3: * No changes v2: * Removed change to ITER_MAX --- app/test/test_barrier.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --

[dpdk-dev] [PATCH v3 4/4] test: fix memory barrier test failure on power CPUs

The memory barrier test fails on IBM Power 9 systems. Add additional barriers to accommodate the weakly ordered model used on Power CPUs. Signed-off-by: David Christensen --- v2: * Removed ifdef's for PPC since the rte_smp_*mb() macros are already customized for each CPU architecture v3: * Non

[dpdk-dev] [PATCH v3 3/4] test: change memory barrier variables to uint64_t

Memory barrier failures can be intermittent. Increase the size of the sum/val/iteration variables to allow tests that can run for days so that sporadic errors can be identified. Signed-off-by: David Christensen --- v2: * Removed change to ITER_MAX v3: * None --- app/test/test_barrier.c | 23

[dpdk-dev] [PATCH v3 1/4] test: fix typo in print statement

Change "much" to "match" in a printf. Signed-off-by: David Christensen --- v2: * None v3: * None app/test/test_barrier.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test/test_barrier.c b/app/test/test_barrier.c index 82b572c..c219d56 100644 --- a/app/test/test_barrie

[dpdk-dev] [PATCH] doc: announce API change to remove exit calls in libs

Two public functions from EAL and metrics libraries need to return some new error codes instead of calling rte_panic or rte_exit. Signed-off-by: Thomas Monjalon --- doc/guides/rel_notes/deprecation.rst | 6 ++ 1 file changed, 6 insertions(+) diff --git a/doc/guides/rel_notes/deprecation.rst

Re: [dpdk-dev] [RFC v3 1/2] eal: replace libc-based random number generation with LFSR

On 2019-05-08 22:12, Stephen Hemminger wrote: On Wed, 24 Apr 2019 14:33:19 +0200 Mattias Rönnblom wrote: diff --git a/lib/librte_eal/linux/eal/eal.c b/lib/librte_eal/linux/eal/eal.c index 161399619..d6bf0e89e 100644 --- a/lib/librte_eal/linux/eal/eal.c +++ b/lib/librte_eal/linux/eal/eal.c @@ -

Re: [dpdk-dev] [PATCH] doc: announce ABI change on eal and kni

08/05/2019 22:22, Arnon Warshavsky: > > I am preparing a deprecation notice for rte_eal_remote_launch > > and rte_metrics_init. > > > hmm, I followed panic and not exit, so missed rte_metrics_init. > rte_eal_remote_launch currently returns int. what deprecation goes there? We probably need to add

Re: [dpdk-dev] [PATCH] doc: announce ABI change on eal and kni

> > > > I am preparing a deprecation notice for rte_eal_remote_launch > and rte_metrics_init. > > > hmm, I followed panic and not exit, so missed rte_metrics_init. rte_eal_remote_launch currently returns int. what deprecation goes there?

Re: [dpdk-dev] [RFC v3 1/2] eal: replace libc-based random number generation with LFSR

On Wed, 24 Apr 2019 14:33:19 +0200 Mattias Rönnblom wrote: > diff --git a/lib/librte_eal/linux/eal/eal.c b/lib/librte_eal/linux/eal/eal.c > index 161399619..d6bf0e89e 100644 > --- a/lib/librte_eal/linux/eal/eal.c > +++ b/lib/librte_eal/linux/eal/eal.c > @@ -1083,8 +1083,6 @@ rte_eal_init(int argc

Re: [dpdk-dev] [PATCH 2/2] test/hash: add test for 'free key with position'

Hi, thanks for the patch! Reply inlined: >-Original Message- >From: Dharmik Thakkar [mailto:dharmik.thak...@arm.com] >Sent: Wednesday, May 8, 2019 9:51 AM >To: Wang, Yipeng1 ; Gobriel, Sameh >; Richardson, Bruce >; De Lara Guarch, Pablo > >Cc: dev@dpdk.org; honnappa.nagaraha...@arm.com;

[dpdk-dev] [Question] PCie AER/RAS Error handling in Linux Driver for any DPDK PMD

Hello, I am very new to the DPDK and in efforts to understand the framework I have come across a question and for which I could not find a proper answer. Question: How are the error events(AER/RAS) from the Physical device handled in PMD? To the best of my understanding, These should get propag

Re: [dpdk-dev] [dpdk-stable] [PATCH] doc: fix typo in mlx5 guide

On 5/8/2019 10:24 AM, Yongseok Koh wrote: > Fixes: 43e9d9794cde ("net/mlx5: support upstream rdma-core") > Cc: sta...@dpdk.org > > Signed-off-by: Yongseok Koh Reviewed-by: Ferruh Yigit Applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH] app/testpmd: fix mbuf leak in the case of multi-segment Tx

On 5/8/2019 11:27 AM, Andrew Rybchenko wrote: > The last mbuf allocated in bulk is never used and never freed. > > Fixes: 01b645dcff7f ("app/testpmd: move txonly prepare in separate function") > Fixes: 561ddcf8d099 ("app/testpmd: allocate txonly segments per bulk") > > Signed-off-by: Andrew Rybch

[dpdk-dev] [RFC] crypto: handling of encrypted digest

Hi all crypto PMD maintainers, We're getting requests to handle the following case on symmetric crypto API, needed for 5G security: Generate digest, append to end of raw data, then encrypt the raw data plus digest. In opposite direction decryption returns raw data plus digest, authentica

[dpdk-dev] IBM Power9 testing for 19.05-rc3

Hi- The following describes the test completed for 19.05-rc3 run on IBM Power9 hardware: * Single port stability test using l3fwd (16 cpus) and TRex, tested 64 and 1500 byte packets at a 0.0% drop rate for 4 hours each. No errors or regressions were seen. System tested: - IBM Power9 Mode

[dpdk-dev] [PATCH 2/2] test/hash: add test for 'free key with position'

This patch adds a unit test for rte_hash_free_key_with_position(). Suggested-by: Linfan Signed-off-by: Dharmik Thakkar --- app/test/test_hash.c | 83 1 file changed, 83 insertions(+) diff --git a/app/test/test_hash.c b/app/test/test_hash.c index 390

[dpdk-dev] [PATCH 0/2] hash: fix bugs in 'free key with position'

This patch series solves 2 bugs reported on Bugzilla (bug-261) within the function rte_hash_free_key_with_postion(). It also adds a test case to catch similar bugs in the future. https://bugs.dpdk.org/show_bug.cgi?id=261 Dharmik Thakkar (2): hash: fix bugs in 'free key with position' test/has

[dpdk-dev] [PATCH 1/2] hash: fix bugs in 'free key with position'

This patch fixes 2 bugs- 1] Incorrect position returned to the free slots. 2] Incorrect computation of total_entries Bugzilla ID: 261 Fixes: 9d033dac7d7c ("hash: support no free on delete") Cc: honnappa.nagaraha...@arm.com Cc: sta...@dpdk.org Reported-by: Linfan Suggested-by: Linfan Signed-off-

Re: [dpdk-dev] [PATCH] net/iavf: fix stats reset

On 22/04/2019 03:18, Qiming Yang wrote: > stats_reset has been missed when support stats in iavf driver. > This patch add statistics reset function. > > Fixes: f4a41a6953af ("net/avf: support stats") > Cc: sta...@dpdk.org > > Signed-off-by: Qiming Yang Hi - This won't apply on 18.11 branch. Ple

Re: [dpdk-dev] [PATCH] net/sfc: fix MTU change to check Rx scatter consistency

On 23/04/2019 09:14, Andrew Rybchenko wrote: > From: Igor Romanov > > Rx queue setup function checks configured MTU to make sure that > no oversized packets can be received. But a following call to > set MTU function might make this check irrelevant. > > Add a function to check MTU size against

Re: [dpdk-dev] [PATCH 00/11] Aquantia atlantic bugfixes

On 29/04/2019 09:20, Igor Russkikh wrote: > This patchset contains various bugfixes found during verification > and integration testing. > > Most notable is eeprom access cleanup, fix for broadcast filter, > flow control logic tracking, some code style cleanups. > > Igor Russkikh (7): > net/atl

Re: [dpdk-dev] [EXT] Re: [PATCH] crypto/octeontx: use distinct metabuf pool for each queue

Hi Kevin, This patch need not be backported. You can ignore this. Thanks, Anoob > -Original Message- > From: Kevin Traynor > Sent: Wednesday, May 8, 2019 4:47 PM > To: Anoob Joseph ; Akhil Goyal ; > Pablo de Lara > Cc: Jerin Jacob Kollanukkaran ; Narayana Prasad Raju > Athreya ; Shally

Re: [dpdk-dev] [PATCH v6 00/11] al: replace calls to rte_panic and refrain from new instances

On Wed, May 8, 2019 at 1:16 PM Thomas Monjalon wrote: > I did a status of rte_panic/rte_exit calls in libs. > > There are a lot of cleanups to do in EAL. > We may apply the same kind of solution for Linux, FreeBSD and Windows. > > Thanks for the list. Only checked at the mbuf part for now. libr

Re: [dpdk-dev] [PATCH v2] ipc: unlock on failure

> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Aaron Conole > Sent: Monday, May 6, 2019 3:48 PM > To: dev@dpdk.org > Cc: Lipiec, Herakliusz ; sta...@dpdk.org; > Burakov, Anatoly ; David Marchand > > Subject: [dpdk-dev] [PATCH v2] ipc: unlock on failure > > Rep

Re: [dpdk-dev] [PATCH v2] doc/compress: clarify error handling on data-plane

HI Shally, > -Original Message- > From: Shally Verma [mailto:shal...@marvell.com] > Sent: Wednesday, May 8, 2019 1:41 PM > To: Trahe, Fiona ; dev@dpdk.org > Cc: akhil.go...@nxp.com; Ashish Gupta ; Daly, Lee > ; Sunila > Sahu ; sta...@dpdk.org > Subject: RE: [PATCH v2] doc/compress: clarif

Re: [dpdk-dev] [PATCH] ethdev: add size and align to compose dma zone name strings

On 4/29/19 11:03 AM, David Marchand wrote: On Sat, Apr 27, 2019 at 11:48 AM wangyunjian > wrote: From: Yunjian Wang mailto:wangyunj...@huawei.com>> The current dma zone name consists of the port_id, queue_id and ring_name. If a port_id is reused, a new

Re: [dpdk-dev] [PATCH v8] app/pdump: add pudmp exits with primary support

On 2019/5/8 18:22, Thomas Monjalon wrote: About the title, you can write: "app/pdump: exit with primary process" 08/05/2019 11:37, Suanming. Mou: On 2019/5/8 16:04, Thomas Monjalon wrote: Hi, I try to suggest some rewording below. Thanks very much. First, let me explain what is the patch

[dpdk-dev] [PATCH] examples/ipsec-secgw: fix Makefile indentation

Fix invalid indentation - extra whitespace before error directive which is causing syntax error when no pkgconfig file for the DPDK is found and RTE_SDK is not specified. Signed-off-by: Marcin Smoczynski --- examples/ipsec-secgw/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) dif

[dpdk-dev] [PATCH] net/ixgbe: fix cancel link handler when port is being removed

From: Yunjian Wang The nic's interrupt source has some active handler, which maybe call ixgbe_dev_link_update() to set link handler. We should cancel the link handler before remove dev to prevent executing the link handler. It triggers segfault. Fixes: 0408f47ba4d6 ("net/ixgbe: fix busy polling

Re: [dpdk-dev] [PATCH v2] doc/compress: clarify error handling on data-plane

Hi Fiona > -Original Message- > From: Trahe, Fiona > Sent: Tuesday, May 7, 2019 11:54 PM > To: Shally Verma ; dev@dpdk.org > Cc: akhil.go...@nxp.com; Ashish Gupta ; Daly, Lee > ; Sunila Sahu ; sta...@dpdk.org; > Trahe, Fiona > Subject: RE: [PATCH v2] doc/compress: clarify error handling

Re: [dpdk-dev] [PATCH] ipsec: fix missing ipsec headers after install

On Wed, May 08, 2019 at 02:12:12PM +0200, Marcin Smoczynski wrote: > Invalid statement is used to indicate header files to install. > > Fixed the statement and reformatted recipe file. > > Signed-off-by: Marcin Smoczynski > --- > lib/librte_ipsec/meson.build | 4 ++-- > 1 file changed, 2 insert

[dpdk-dev] [PATCH] ipsec: fix missing ipsec headers after install

Invalid statement is used to indicate header files to install. Fixed the statement and reformatted recipe file. Signed-off-by: Marcin Smoczynski --- lib/librte_ipsec/meson.build | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/librte_ipsec/meson.build b/lib/librte_ips

Re: [dpdk-dev] [PATCH] crypto/octeontx: use distinct metabuf pool for each queue

On 18/04/2019 04:30, Anoob Joseph wrote: > The metabuf pool is shared across all queue pairs belonging to the > PMD. In order to prevent one queue pair from starving another, > use a distinct mempool for each queue pair. > > Fixes: 273487f7b381 ("crypto/octeontx: add global resource init") > Hi

Re: [dpdk-dev] [PATCH v6 00/11] al: replace calls to rte_panic and refrain from new instances

24/04/2018 08:41, Arnon Warshavsky: > The purpose of this patch series is to cleanup the library code > from paths that end up aborting the process, > and move to checking error values, in order to allow the running process > perform an orderly teardown or other mitigation of the event. > > This p

Re: [dpdk-dev] [PATCH] doc: announce ABI change on eal and kni

07/05/2019 11:57, Arnon Warshavsky: > > > > > > Changing 'kni_fifo_init()' return type shouldn't be a problem at all, > > perhaps it would be a problem if the content of the fifo changed but it is > > not > > the case. > > > > Should I move this patch to deferred or reject? It can be set to "reje

[dpdk-dev] [PATCH 3/3] examples/ipsec-secgw: add support for ipv6 options

Using transport with IPv6 and header extensions requires calculating total header length including extensions up to ESP header which is achieved with iteratively parsing extensions when preparing traffic for processing. Calculated l3_len is later used to determine SPI field offset for an inbound tr

[dpdk-dev] [PATCH 2/3] ipsec: fix transport mode for ipv6 with extensions

Reconstructing IPv6 header after encryption or decryption requires updating 'next header' value in the preceding protocol header, which is determined by parsing IPv6 header and iteratively looking for next IPv6 header extension. It is required that 'l3_len' in the mbuf metadata contains a total le

[dpdk-dev] [PATCH 1/3] net: new ipv6 header extension parsing function

Introduce new function for IPv6 header extension parsing able to determine extension length and next protocol number. This function is helpful when implementing IPv6 header traversing. Signed-off-by: Marcin Smoczynski --- lib/librte_net/rte_ip.h | 49 + 1

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/iavf: fix queue interrupt for ICE

On 18/04/2019 05:58, Wei Zhao wrote: > Enable CLEARPBA bit is required by ice NIC of A0/A1 version to > enable Tx and Rx queue interrupt. > Also enable CLEARPBA bit does no impact on IAVF behaviour when be > hosted by other devices, so we can make it as default. > > Fixes: d6bde6b5eae9 ("net/avf:

[dpdk-dev] [PATCH] app/testpmd: fix mbuf leak in the case of multi-segment Tx

The last mbuf allocated in bulk is never used and never freed. Fixes: 01b645dcff7f ("app/testpmd: move txonly prepare in separate function") Fixes: 561ddcf8d099 ("app/testpmd: allocate txonly segments per bulk") Signed-off-by: Andrew Rybchenko --- app/test-pmd/txonly.c | 2 +- 1 file changed, 1

Re: [dpdk-dev] [PATCH v8] app/pdump: add pudmp exits with primary support

About the title, you can write: "app/pdump: exit with primary process" 08/05/2019 11:37, Suanming. Mou: > On 2019/5/8 16:04, Thomas Monjalon wrote: > > Hi, > > > > I try to suggest some rewording below. > > Thanks very much. > > First, let me explain what is the patch work for. > > As we all k

Re: [dpdk-dev] [PATCH v8] app/pdump: add pudmp exits with primary support

On 2019/5/8 16:04, Thomas Monjalon wrote: Hi, I try to suggest some rewording below. Thanks very much. First,  let me explain what is the patch work for. As we all know, the pdump tool works as the secondary process. When the primary process exits, if the secondary process keeps running

Re: [dpdk-dev] [PATCH] doc: add Mellanox BlueField platform guide

> On May 8, 2019, at 1:27 AM, Thomas Monjalon wrote: > > 08/05/2019 04:04, Yongseok Koh: >> --- a/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst >> +++ b/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst >> +.. _getting_the_prerequisite_library: > > The name of this anchor should specify

[dpdk-dev] [PATCH] doc: fix typo in mlx5 guide

Fixes: 43e9d9794cde ("net/mlx5: support upstream rdma-core") Cc: sta...@dpdk.org Signed-off-by: Yongseok Koh --- doc/guides/nics/mlx5.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst index af1e408ead..325e9f697a 100644 --

Re: [dpdk-dev] [PATCH v2] timer: fix resource leak in finalize

On 07-May-19 11:04 PM, Carrillo, Erik G wrote: Hi Anatoly, Thanks for the review. Comments in-line: <...snipped...> #define RTE_MAX_DATA_ELS 64 +static const struct rte_memzone *rte_timer_data_mz; static +rte_atomic16_t *rte_timer_mz_refcnt; static struct rte_timer_data *rte_timer_data

[dpdk-dev] [PATCH v4 0/4] net/mlx5: code cleanup in rx and tx files

During work on Rx feature I did some cleanup actions. This series includes those changes divided by their type. --- v2: Change 2nd patch type to "fix". v3: Apply minor code-review comment on 2nd patch. Add Acked-by in all patches. v4: Fix compilaton issue in 4th patch. --- Dekel Peled (4):

[dpdk-dev] [PATCH v4 2/4] net/mlx5: fix missing validation of null pointer

Function mlx5_rxq_ibv_release() is called in several places. Before each call except one, the input parameter is validated to make sure it is not null. This patch adds the validation where it is missing. It also changes a priv_ prefix, left in a comment, to mlx5_ prefix. Fixes: af4f09f28294 ("net

[dpdk-dev] [PATCH v4 3/4] net/mlx5: fix description of function return value

Return value of function mlx5_rxq_releasable() was not described correctly in function description. This patch updates the description to correctly describe the optional return values. Fixes: a6d83b6a9209 ("net/mlx5: standardize on negative errno values") cc: sta...@dpdk.org Signed-off-by: Dekel

[dpdk-dev] [PATCH v4 4/4] net/mlx5: move locally used functions to static

Multiple functions were declared in header file mlx5_rxtx.h, inplemented in mlx5_rxq.c, and called only in mlx5_rxq.c. This patch moves all these functions declarations into mlx5_rxq.c, as static functions. Some functions implementation was copied higher in the file to precede the functions calls.

[dpdk-dev] [PATCH v4 1/4] net/mlx5: remove unused functions

Functions implemented but never called: mlx5_rxq_ibv_releasable() mlx5_rxq_cleanup() mlx5_txq_ibv_releasable() Function declared but not implemented: rxq_alloc_mprq_buf() This patch removes these functions from code and header file. Signed-off-by: Dekel Peled Acked-by: Shahaf Shuler Acked-by:

Re: [dpdk-dev] [PATCH] doc: add Mellanox BlueField platform guide

08/05/2019 04:04, Yongseok Koh: > --- a/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst > +++ b/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst > +.. _getting_the_prerequisite_library: The name of this anchor should specify "arm". > + > Getting the prerequisite library > ---

Re: [dpdk-dev] [PATCH] doc: add cryptodev gcm iv deprecation notice

> -Original Message- > From: Kusztal, ArkadiuszX > Sent: Wednesday, April 17, 2019 8:41 AM > To: dev@dpdk.org > Cc: akhil.go...@nxp.com; Trahe, Fiona ; De Lara > Guarch, Pablo ; Kusztal, ArkadiuszX > > Subject: [PATCH] doc: add cryptodev gcm iv deprecation notice > > This patch adds de

Re: [dpdk-dev] [PATCH] doc: prepare security process for vulnerabilities

08/05/2019 00:38, Luca Boccassi: > On Tue, 2019-05-07 at 18:02 +0200, Thomas Monjalon wrote: > > create mode 100644 doc/guides/contributing/vulnerability.rst > > I think at least the fingerprint of the GPG key to encrypt to, if a > link to the whole public key given the page is served over https,

Re: [dpdk-dev] [PATCH v8] app/pdump: add pudmp exits with primary support

Hi, I try to suggest some rewording below. 03/05/2019 07:48, Suanming. Mou: > +/* Enough to set it to 500ms for exiting. */ > +#define MONITOR_INTERVAL (500 * 1000) What is "enough"? What is "it"? What is the relation between MONITOR_INTERVAL and exiting? [...] > + /* > + * Don't worry

Re: [dpdk-dev] [PATCH v4 1/3] rte_ethdev: Add API function to read dev clock

On 5/2/19 3:11 PM, Tom Barbette wrote: Add rte_eth_read_clock to read the raw clock of a device. The main use is to get the device clock conversion co-efficients to be able to translate the raw clock of the timestamp field of the pkt mbuf to a local synced time value. This function was missing

Re: [dpdk-dev] [RFC v5] /net: memory interface (memif)

-- Damjan On 7 May 2019, at 13:29, Honnappa Nagarahalli mailto:honnappa.nagaraha...@arm.com>> wrote: On 3/22/2019 11:57 AM, Jakub Grajciar wrote: Memory interface (memif), provides high performance packet transfer over shared memory. Signed-off-by: Jakub Grajciar mailto:jgraj...@cisco.com>

Re: [dpdk-dev] [PATCH v4 0/3] Add rte_eth_read_clock API

Maybe a (last) motivation point. We just did a 100G link traffic capture with time-stamping of all packets in HW using a Mellanox CX5. SW time-stamping fails to reveal queueing delays, and as multi-queue is needed for writing 100G traffic to multiple NVMe drives, does not allow to recover the