[dpdk-dev] [PATCH] net/mlx5: fix init with zero Rx queues

2019-05-01 Thread Dekel Peled
Recent patch [1] added, at the end of mlx5_dev_configure(), a call to mlx5_proc_priv_init(), initializing process_private data of eth_dev. This call is not reached if PMD is started with zero Rx queues. In this case mlx5_dev_configure() returns earlier due to the check: if (rxqs_n == priv->

Re: [dpdk-dev] [PATCH] net/mlx5: fix Direct Rules API

2019-05-01 Thread Shahaf Shuler
Wednesday, May 1, 2019 11:41 PM, Ori Kam: > Subject: [dpdk-dev] [PATCH] net/mlx5: fix Direct Rules API > > The RDMA-CORE Direct Rules API was changed in latest upstream code > > This commit update the API accordingly. > > Fixes: 4f84a19779ca ("net/mlx5: add Direct Rules API") > > Signed-off-by:

Re: [dpdk-dev] [PATCH 1/2] build: add option for armv8 crypto extension

2019-05-01 Thread Yongseok Koh
> On May 1, 2019, at 9:13 PM, Honnappa Nagarahalli > wrote: > >> Per armv8 crypto extension support, make build always enable it by default >> as long as compiler supports the feature while meson build only enables it >> for >> 'default' machine of generic armv8 architecture. For example, speci

Re: [dpdk-dev] [PATCH 2/2] mk: disable armv8 crypto extension for Mellanox BlueField

2019-05-01 Thread Yongseok Koh
> On May 1, 2019, at 9:12 PM, Honnappa Nagarahalli > wrote: > >> >> Mellanox BlueField has a variant which doesn't have armv8 crypto extension. >> If crypto enabled binary runs on such a pltform, rte_eal_init() fails. To >> have >> binary compatibility across multiple variants, it is disabled

Re: [dpdk-dev] [PATCH 1/2] build: add option for armv8 crypto extension

2019-05-01 Thread Honnappa Nagarahalli
> Per armv8 crypto extension support, make build always enable it by default > as long as compiler supports the feature while meson build only enables it for > 'default' machine of generic armv8 architecture. For example, specifying '- > mcpu=cortex-a72' doesn't enable it but '+crypto' is required

Re: [dpdk-dev] [PATCH 2/2] mk: disable armv8 crypto extension for Mellanox BlueField

2019-05-01 Thread Honnappa Nagarahalli
> > Mellanox BlueField has a variant which doesn't have armv8 crypto extension. > If crypto enabled binary runs on such a pltform, rte_eal_init() fails. To have > binary compatibility across multiple variants, it is disabled by default and > can > be enabled for crypto enabled parts. > > Signed-

[dpdk-dev] [PATCH v6] app/pdump: add pudmp exits with primary support

2019-05-01 Thread Suanming . Mou
When primary app exits, the residual running pdump will stop the primary app to restart. Add pdump exits with primary support. Signed-off-by: Suanming.Mou --- Change in V6: - remove "Suggested-by" tags and head line '.' in git log. - adjust the rte_alarm.h head file position. - add comment

Re: [dpdk-dev] [PATCH v5] app/pdump: add pudmp exits with primary support.

2019-05-01 Thread Suanming . Mou
On 2019/5/1 0:39, Burakov, Anatoly wrote: On 30-Apr-19 12:25 PM, Suanming.Mou wrote: On 2019/4/30 17:42, Burakov, Anatoly wrote: On 30-Apr-19 12:35 PM, Suanming.Mou wrote: When primary app exits, the residual running pdump will stop the primary app to restart. Add pdump exits with primary s

[dpdk-dev] [PATCH 2/2] mk: disable armv8 crypto extension for Mellanox BlueField

2019-05-01 Thread Yongseok Koh
Mellanox BlueField has a variant which doesn't have armv8 crypto extension. If crypto enabled binary runs on such a pltform, rte_eal_init() fails. To have binary compatibility across multiple variants, it is disabled by default and can be enabled for crypto enabled parts. Signed-off-by: Yongseok K

[dpdk-dev] [PATCH 1/2] build: add option for armv8 crypto extension

2019-05-01 Thread Yongseok Koh
Per armv8 crypto extension support, make build always enable it by default as long as compiler supports the feature while meson build only enables it for 'default' machine of generic armv8 architecture. For example, specifying '-mcpu=cortex-a72' doesn't enable it but '+crypto' is required in order

Re: [dpdk-dev] [EXT] [PATCH 5/6] build: add option for armv8 crypto extension

2019-05-01 Thread Yongseok Koh
> On Apr 29, 2019, at 8:33 PM, Honnappa Nagarahalli > wrote: > >> On Apr 15, 2019, at 1:13 PM, Honnappa Nagarahalli >> wrote: >> >> Subject: [EXT] [PATCH 5/6] build: add option for armv8 crypto >> extension >> >> CONFIG_RTE_MACHINE="armv8a" >> +CONFIG_RTE_ENABLE_ARMV8_CR

[dpdk-dev] [PATCH] net/mlx: support IOVA VA mode

2019-05-01 Thread Yongseok Koh
Set RTE_PCI_DRV_IOVA_AS_VA to driver's drv_flags as device's IOMMU takes virtual address. Cc: sta...@dpdk.org Cc: Davide Caratti Signed-off-by: Yongseok Koh --- drivers/net/mlx4/mlx4.c | 4 ++-- drivers/net/mlx5/mlx5.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/dr

Re: [dpdk-dev] [DPDK] devtools: change for ABI back-compatibility checking

2019-05-01 Thread Thomas Monjalon
24/04/2019 14:08, Neil Horman: > On Wed, Apr 24, 2019 at 03:11:59PM +, Peng Huang wrote: > > The new default-taget "linux" is introduced in v19.05-rc1 > > but not exist in before release such as v19.02 which have > > default-target "linuxapp", there is no compatibility report > > when run valid

Re: [dpdk-dev] [PATCH] net/ixgbe: 10GBASE-T SFP+ copper support

2019-05-01 Thread Ananyev, Konstantin
> -Original Message- > From: Ido Goshen [mailto:i...@cgstowernetworks.com] > Sent: Sunday, April 28, 2019 7:54 AM > To: Ananyev, Konstantin ; Lu, Wenzhuo > > Cc: dev@dpdk.org > Subject: RE: [PATCH] net/ixgbe: 10GBASE-T SFP+ copper support > > > > > -Original Message- > > From

Re: [dpdk-dev] [PATCH v9 0/4] lib/rcu: add RCU library supporting QSBR mechanism

2019-05-01 Thread Thomas Monjalon
01/05/2019 05:54, Honnappa Nagarahalli: > Dharmik Thakkar (1): > test/rcu_qsbr: add API and functional tests > > Honnappa Nagarahalli (3): > rcu: add RCU library supporting QSBR mechanism > doc/rcu: add lib_rcu documentation > doc: added RCU to the release notes Applied with discussed doc

Re: [dpdk-dev] [PATCH v9 3/4] doc/rcu: add lib_rcu documentation

2019-05-01 Thread Thomas Monjalon
01/05/2019 23:20, Honnappa Nagarahalli: > > > Subject: [dpdk-dev] [PATCH v9 3/4] doc/rcu: add lib_rcu documentation > > > > > > Add lib_rcu QSBR API and programmer guide documentation. > > > > > > Signed-off-by: Honnappa Nagarahalli > > > Reviewed-by: Marko Kovacevic > > > > Some minor comments

Re: [dpdk-dev] [PATCH v4] eventdev: add experimental tag back

2019-05-01 Thread Thomas Monjalon
26/04/2019 19:18, Kevin Traynor: > On 26/04/2019 17:33, Nikhil Rao wrote: > > Add the experimental tag back to the Rx event adapter callback, > > the Rx event callback register and the Rx event adapter statistics > > retrieval functions due to an API change to be proposed in a > > future patch. > >

Re: [dpdk-dev] [PATCH v9 3/4] doc/rcu: add lib_rcu documentation

2019-05-01 Thread Honnappa Nagarahalli
> > Subject: [dpdk-dev] [PATCH v9 3/4] doc/rcu: add lib_rcu documentation > > > > Add lib_rcu QSBR API and programmer guide documentation. > > > > Signed-off-by: Honnappa Nagarahalli > > Reviewed-by: Marko Kovacevic > > Some minor comments below. Nothing blocking. Thanks John for the comments.

Re: [dpdk-dev] [PATCH v9 0/4] lib/rcu: add RCU library supporting QSBR mechanism

2019-05-01 Thread Honnappa Nagarahalli
> Subject: Re: [dpdk-dev] [PATCH v9 0/4] lib/rcu: add RCU library supporting > QSBR mechanism > > On Wed, May 01, 2019 at 02:56:48PM +, Honnappa Nagarahalli wrote: > > > > > > On Tue, Apr 30, 2019 at 10:54:15PM -0500, Honnappa Nagarahalli wrote: > > > > Lock-less data structures provide scalab

Re: [dpdk-dev] [PATCH] eventdev: fix control flow issues

2019-05-01 Thread Thomas Monjalon
> > This patch fixes null pointer dereference and control flow issues reported > > in > > event crypto adapter by coverity > > > > Coverity issue: 279439 Dereference null return value Coverity issue: 279446 > > Logically dead code Coverity issue: 279450 Logically dead code Coverity > > issue: >

Re: [dpdk-dev] [pull-request] next-crypto 19.05 rc3

2019-05-01 Thread Thomas Monjalon
01/05/2019 16:26, Akhil Goyal: > http://dpdk.org/git/next/dpdk-next-crypto Pulled, thanks

[dpdk-dev] [PATCH] net/mlx5: fix Direct Rules API

2019-05-01 Thread Ori Kam
The RDMA-CORE Direct Rules API was changed in latest upstream code This commit update the API accordingly. Fixes: 4f84a19779ca ("net/mlx5: add Direct Rules API") Signed-off-by: Ori Kam --- drivers/net/mlx5/Makefile | 4 +-- drivers/net/mlx5/meson.build| 4 +-- drivers/net/mlx5/mlx5

[dpdk-dev] [PATCH 2/4] bus/fslmc: fix printf of null pointer

2019-05-01 Thread Bruce Richardson
Printing a null pointer with %s is flagged as a warning by GCC 9, and should not be done. Replace the %s with the word "null" itself. Fixes: 828d51d8fc3e ("bus/fslmc: refactor scan and probe functions") Cc: shreyansh.j...@nxp.com Signed-off-by: Bruce Richardson --- drivers/bus/fslmc/fslmc_bus.c

[dpdk-dev] [PATCH 3/4] raw/skeleton_rawdev: fix warnings with GCC 9 on Fedora 30

2019-05-01 Thread Bruce Richardson
GCC9 gives warnings if the parameter passed to printf for "%s" could be NULL, so we need to add checks in some cases to ensure that is not the case. Fixes: 61c592a8d035 ("raw/skeleton: introduce skeleton rawdev driver") Cc: shreyansh.j...@nxp.com Signed-off-by: Bruce Richardson --- drivers/raw/

[dpdk-dev] [PATCH 4/4] raw/dpaa2_cmdif: fix warnings with GCC 9 on Fedora 30

2019-05-01 Thread Bruce Richardson
GCC9 gives warnings if the parameter passed to printf for "%s" could be NULL, so we need to add checks in some cases to ensure that is not the case. Fixes: 3298fa4853b8 ("raw/dpaa2_cmdif: introduce DPAA2 command interface driver") Cc: nipun.gu...@nxp.com Signed-off-by: Bruce Richardson --- dri

[dpdk-dev] [PATCH 0/4] fix warnings with gcc 9 on Fedora 30

2019-05-01 Thread Bruce Richardson
This set of changes fixes warnings seen when compiling DPDK on Fedora 30. In most cases these warnings appear to be false positives, which means we have the option to just disable the warning. Because the changes required to the code to silence the warnings are fairly small I've chosen in all cases

[dpdk-dev] [PATCH 1/4] net/ixgbe: fix warning with GCC 9 on Fedora 30

2019-05-01 Thread Bruce Richardson
Compiling on Fedora 30, we get the following warning, causing build failure when Werror flag is set: ../drivers/net/ixgbe/ixgbe_rxtx.c:2141:14: warning: ‘nmb’ may be used uninitialized in this function [-Wmaybe-uninitialized] 2141 |rxe->mbuf = nmb; |~~^ Initializing th

[dpdk-dev] [PATCH] timer: fix resource leak in finalize

2019-05-01 Thread Erik Gabriel Carrillo
The finalize function should free the memzone created in the init function, rather than freeing the allocation the memzone references, otherwise a memzone descriptor can be leaked. Fixes: c0749f7096c7 ("timer: allow management in shared memory") Signed-off-by: Erik Gabriel Carrillo --- lib/libr

Re: [dpdk-dev] [PATCH v9 0/4] lib/rcu: add RCU library supporting QSBR mechanism

2019-05-01 Thread Neil Horman
On Wed, May 01, 2019 at 02:56:48PM +, Honnappa Nagarahalli wrote: > > > > On Tue, Apr 30, 2019 at 10:54:15PM -0500, Honnappa Nagarahalli wrote: > > > Lock-less data structures provide scalability and determinism. > > > They enable use cases where locking may not be allowed (for ex: > > > real-

Re: [dpdk-dev] [PATCH] net/vmxnet3: add VLAN filter capability

2019-05-01 Thread Yong Wang
-Original Message- From: Mark Gillott Date: Wednesday, May 1, 2019 at 8:30 AM To: Yong Wang Cc: "dev@dpdk.org" , Mark Gillott Subject: [PATCH] net/vmxnet3: add VLAN filter capability The driver supports VLAN filtering, but the option is not included in the advertised list of cap

[dpdk-dev] [PATCH 3/3] crypto/zuc: fix dependency check

2019-05-01 Thread Bruce Richardson
The check for the zuc library dependency did not check for the include file needed for compilation. It's also recommended when looking for a library to use the name without the lib prefix. Fixes: df1740a8db5f ("crypto/zuc: enable meson build") Signed-off-by: Bruce Richardson --- drivers/crypto/

[dpdk-dev] [PATCH 1/3] crypto/snow3g: add to meson build

2019-05-01 Thread Bruce Richardson
Snow3G driver is missing support for building with meson. Add a new meson.build file so it can be included in the builds. Signed-off-by: Bruce Richardson --- drivers/crypto/meson.build| 2 +- drivers/crypto/snow3g/meson.build | 13 + 2 files changed, 14 insertions(+), 1 dele

[dpdk-dev] [PATCH 2/3] crypto/kasumi: fix dependency check

2019-05-01 Thread Bruce Richardson
The check for the kasumi library dependency did not check for the include file needed for compilation. It's also recommended when looking for a library to use the name without the lib prefix. Fixes: 2ec2d46c6255 ("crypto/kasumi: enable meson build") Signed-off-by: Bruce Richardson --- drivers/c

[dpdk-dev] [PATCH 0/3] small fixes for crypto drivers

2019-05-01 Thread Bruce Richardson
Some fixes for the dependency checking of the kasumi and zuc PMDs, and an addition of meson support for snow3g which seems to have been overlooked previously. [Apologies for the late submission, but hopefully these can make it into 19.05] Bruce Richardson (3): crypto/snow3g: add to meson build

[dpdk-dev] [PATCH] net/vmxnet3: add VLAN filter capability

2019-05-01 Thread Mark Gillott
The driver supports VLAN filtering, but the option is not included in the advertised list of capabilities. Thus any attempt to enable VLAN filtering always fails. Update the list of offload capabilities to include DEV_RX_OFFLOAD_VLAN_FILTER. Signed-off-by: Mark Gillott --- drivers/net/vmxnet3/vm

Re: [dpdk-dev] [PATCH v9 0/4] lib/rcu: add RCU library supporting QSBR mechanism

2019-05-01 Thread Honnappa Nagarahalli
> > On Tue, Apr 30, 2019 at 10:54:15PM -0500, Honnappa Nagarahalli wrote: > > Lock-less data structures provide scalability and determinism. > > They enable use cases where locking may not be allowed (for ex: > > real-time applications). > > > I know this is version 9 of the patch, so I'm sorry fo

[dpdk-dev] [pull-request] next-crypto 19.05 rc3

2019-05-01 Thread Akhil Goyal
The following changes since commit 7f251bcf22c5729792f9243480af1b3c072876a5: version: 19.05-rc2 (2019-04-23 00:43:52 +0200) are available in the Git repository at: http://dpdk.org/git/next/dpdk-next-crypto for you to fetch changes up to 035c9fb61cb3d1053bdb291d45a0ca13a69230f6: doc/cryp

Re: [dpdk-dev] [PATCH v3] doc/crypto: add release notes and more detailed doc to qat

2019-05-01 Thread Akhil Goyal
> > > -Original Message- > > From: Trahe, Fiona > > Sent: Thursday, April 18, 2019 6:45 PM > > To: dev@dpdk.org > > Cc: akhil.go...@nxp.com; Kusztal, ArkadiuszX > > ; Trahe, Fiona > > Subject: [PATCH v3] doc/crypto: add release notes and more detailed doc to > > qat > > > > From: Arek K

[dpdk-dev] Compiling on Fedora 30

2019-05-01 Thread Bruce Richardson
Hi, Just an FYI for anyone updating to Fedora 30, released this week; there are issues with building latest DPDK head. F30 seems to ship with GCC 9, which is not officially released yet as far as I can see, and so has some new warnings being flagged in our code. I needed to set the following cfla

Re: [dpdk-dev] [PATCH] doc: fix broken link in programmers guide lpm library references

2019-05-01 Thread Mcnamara, John
> -Original Message- > From: Lipiec, Herakliusz > Sent: Wednesday, April 24, 2019 4:36 PM > To: Richardson, Bruce ; Medvedkin, Vladimir > ; Mcnamara, John ; > Kovacevic, Marko > Cc: dev@dpdk.org; Lipiec, Herakliusz ; > Iremonger, Bernard ; sta...@dpdk.org > Subject: [PATCH] doc: fix broken

Re: [dpdk-dev] [EXT] [PATCH v2] crypto/octeontx: use distinct metabuf pool for each queue

2019-05-01 Thread Akhil Goyal
> Hi Akhil, > > > One more thing, is this patch applicable for backport to stable release? > Yes. > > Thanks, > Anoob > Applied to dpdk-next-crypto Thanks

Re: [dpdk-dev] [PATCH v9 0/4] lib/rcu: add RCU library supporting QSBR mechanism

2019-05-01 Thread Neil Horman
On Tue, Apr 30, 2019 at 10:54:15PM -0500, Honnappa Nagarahalli wrote: > Lock-less data structures provide scalability and determinism. > They enable use cases where locking may not be allowed > (for ex: real-time applications). > I know this is version 9 of the patch, so I'm sorry for the late com

Re: [dpdk-dev] [PATCH] doc: update release notes for new armv8 targets

2019-05-01 Thread Mcnamara, John
> -Original Message- > From: jer...@marvell.com [mailto:jer...@marvell.com] > Sent: Thursday, April 25, 2019 8:42 AM > To: dev@dpdk.org; Mcnamara, John ; Kovacevic, > Marko > Cc: tho...@monjalon.net; ys...@mellanox.com; Jerin Jacob > > Subject: [dpdk-dev] [PATCH] doc: update release no

Re: [dpdk-dev] [PATCH v5] doc: add meson ut info in prog guide

2019-05-01 Thread Mcnamara, John
> > Sorry, I stop reading here. > Marko, John, did you try to review this patch? Yes. I will review offline. John

Re: [dpdk-dev] [PATCH v9 3/4] doc/rcu: add lib_rcu documentation

2019-05-01 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Honnappa Nagarahalli > Sent: Wednesday, May 1, 2019 4:54 AM > To: Ananyev, Konstantin ; > step...@networkplumber.org; paul...@linux.ibm.com; Kovacevic, Marko > ; dev@dpdk.org > Cc: honnappa.nagaraha...@arm.com; g

Re: [dpdk-dev] [PATCH v9 4/4] doc: added RCU to the release notes

2019-05-01 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Honnappa Nagarahalli > Sent: Wednesday, May 1, 2019 4:54 AM > To: Ananyev, Konstantin ; > step...@networkplumber.org; paul...@linux.ibm.com; Kovacevic, Marko > ; dev@dpdk.org > Cc: honnappa.nagaraha...@arm.com; g

Re: [dpdk-dev] [PATCH v2 6/6] examples: remove auto-generation of examples list

2019-05-01 Thread Luca Boccassi
On Fri, 2019-04-26 at 17:50 +0100, Bruce Richardson wrote: > The examples/meson.build file scanned the filesystem to find all > examples > to build (for examples=all option) and install. However, using > run_command > and scanning the filesystem prevented ninja from properly detecting > the > addit

Re: [dpdk-dev] [PATCH v2 3/6] build: fix ninja install on FreeBSD

2019-05-01 Thread Luca Boccassi
On Fri, 2019-04-26 at 17:50 +0100, Bruce Richardson wrote: > The post-install script to symlink the PMDs from their own PMD > directory to > the regular lib directory (so they would be found by ld at runtime) > was > using the "-r" flag to ln to create relative symlinks. This flag is > unsupported

Re: [dpdk-dev] [PATCH v2 1/6] examples/l3fwd: fix compile on FreeBSD

2019-05-01 Thread Luca Boccassi
On Fri, 2019-04-26 at 17:50 +0100, Bruce Richardson wrote: > On freebsd we need to include sys/socket.h to get the definition of > AF_INET in order to compile. > > Fixes: d5ceea4ab160 ("examples/l3fwd: format IP addresses for > printing") > > Signed-off-by: Bruce Richardson < > bruce.richard...@i