Re: [dpdk-dev] [PATCH v7 2/2] doc: add guide for debug and troubleshoot

2019-04-07 Thread Thomas Monjalon
08/04/2019 05:18, Varghese, Vipin: > Hi Thomas and John, > > Thanks for the comments and suggestion. > > snipped > > > > + > > > > + It is difficult to cover all possible issues; in a single attempt. > > > > + With ``feedback and suggestions from the community, more cases can > > > > + be > > > >

Re: [dpdk-dev] [PATCH] net/ixgbevf: remove MTU setting limitation

2019-04-07 Thread Zhao1, Wei
Hi, > -Original Message- > From: David Harton (dharton) [mailto:dhar...@cisco.com] > Sent: Wednesday, April 3, 2019 8:36 PM > To: Zhao1, Wei ; dev@dpdk.org > Cc: Lu, Wenzhuo ; Ananyev, Konstantin > ; Zhang, Qi Z > Subject: RE: [dpdk-dev] [PATCH] net/ixgbevf: remove MTU setting limitation

Re: [dpdk-dev] [PATCH] examples/l3fwd: support separate buffer pool per port

2019-04-07 Thread Ruifeng Wang (Arm Technology China)
Hi Shreyansh, I tried this patch on MacchiatoBin + 82599 NIC. Compared with global-pool mode, per-port-pool mode showed slightly lower performance in single core test. In dual core test, both modes had nearly same performance. My setup only has two ports which is limited. Just want to know the

[dpdk-dev] [Bug 241] QEMU (vIOMMU+virtio) crashes when DPDK exits

2019-04-07 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=241 Bug ID: 241 Summary: QEMU (vIOMMU+virtio) crashes when DPDK exits Product: DPDK Version: 18.11 Hardware: All OS: All Status: CONFIRMED Severity: major Pr

Re: [dpdk-dev] [PATCH v2 1/1] net/mlx5: fix sharing context destroy order

2019-04-07 Thread Shahaf Shuler
Friday, April 5, 2019 4:29 PM, Viacheslav Ovsiienko: > Subject: [dpdk-dev] [PATCH v2 1/1] net/mlx5: fix sharing context destroy > order > > At the mlx5 device closing the shared IB context was destroyed before > cleanup routines completion. As it was found on some setups (Netlink fails > with old

Re: [dpdk-dev] [PATCH v2 1/1] net/mlx5: fix device probing for old kernel drivers

2019-04-07 Thread Shahaf Shuler
Friday, April 5, 2019 4:26 PM, Viacheslav Ovsiienko: > Subject: [dpdk-dev] [PATCH v2 1/1] net/mlx5: fix device probing for old > kernel drivers > > Retrieving network interface index via Netlink fails in case of old ib_core > kernel driver installed - mlx5_nl_ifindex() routine fails due to > RDMA_

Re: [dpdk-dev] [PATCH v2 1/1] net/mlx5: fix typos in comments

2019-04-07 Thread Shahaf Shuler
Friday, April 5, 2019 11:56 AM, Viacheslav Ovsiienko: > Subject: [PATCH v2 1/1] net/mlx5: fix typos in comments > > Fixes: 299d7dc28c37 ("net/mlx5: add representor recognition on Linux 5.x") > > Signed-off-by: Viacheslav Ovsiienko > Applied to next-net-mlx, thanks. Pay attention the below com

Re: [dpdk-dev] [PATCH v3 3/4] net/mlx5: remove device register remap

2019-04-07 Thread Shahaf Shuler
Hi Koh, See small comments below. Same for mlx4 patch. Friday, April 5, 2019 4:34 AM, Yongseok Koh: > Subject: [dpdk-dev] [PATCH v3 3/4] net/mlx5: remove device register remap > > UAR (User Access Region) register does not need to be remapped for > primary process but it should be remapped only

Re: [dpdk-dev] [PATCH v3 2/4] net/mlx5: remove redundant queue index

2019-04-07 Thread Shahaf Shuler
Friday, April 5, 2019 4:34 AM, Yongseok Koh: > Subject: [dpdk-dev] [PATCH v3 2/4] net/mlx5: remove redundant queue > index > > Queue index is redundantly stored for both Rx and Tx structures. > E.g. txq_ctrl->idx and txq->stats.idx. Both are consolidated to single > storage - > rxq->idx and txq->

Re: [dpdk-dev] [PATCH v3 1/3] packet_ordering: add statistics for each worker thread

2019-04-07 Thread Phil Yang (Arm Technology China)
> -Original Message- > From: Thomas Monjalon > Sent: Friday, April 5, 2019 7:25 AM > To: Phil Yang (Arm Technology China) > Cc: dev@dpdk.org; david.h...@intel.com; reshma.pat...@intel.com; Gavin > Hu (Arm Technology China) ; Honnappa Nagarahalli > ; nd > Subject: Re: [dpdk-dev] [PATCH v3

Re: [dpdk-dev] [PATCH v2] vhost: fix null pointer checking

2019-04-07 Thread Tiwei Bie
On Thu, Apr 04, 2019 at 09:53:17AM +0100, Mohammad Abdul Awal wrote: > Null value for parameters will cause segfault. > > Fixes: d7280c9fff ("vhost: support selective datapath") > Fixes: 72e8543093df ("vhost: add API to get MTU value") > Fixes: a277c71598 ("vhost: refactor code structure") > Fixes

Re: [dpdk-dev] [PATCH v2 2/5] examples/vhost_scsi: fix missing NULL-check for parameter

2019-04-07 Thread Tiwei Bie
On Fri, Apr 05, 2019 at 03:37:06PM +0100, Bruce Richardson wrote: > Coverity points out that there is a check in the main thread loop for the > ctrlr->bdev being NULL, but by that stage the pointer has already been > dereferenced. Therefore, for safety, before we enter the loop do an > initial chec

Re: [dpdk-dev] [PATCH v2 1/5] examples/vhost_scsi: fix header check for meson build

2019-04-07 Thread Tiwei Bie
On Fri, Apr 05, 2019 at 03:37:05PM +0100, Bruce Richardson wrote: > The header check for the example app was looking for virtio_scsi.h without > the "linux/" prefix, which meant it was never getting found when it should > have been. > > Fixes: 8d47a753b7cb ("examples/vhost_scsi: disable build if m

Re: [dpdk-dev] [PATCH v7 2/2] doc: add guide for debug and troubleshoot

2019-04-07 Thread Varghese, Vipin
Hi Thomas and John, Thanks for the comments and suggestion. snipped > > > + > > > + It is difficult to cover all possible issues; in a single attempt. > > > + With ``feedback and suggestions from the community, more cases can > > > + be > > > covered``. > > > > Do you really mean to `` quote (i.e

Re: [dpdk-dev] [PATCH v5 2/2] app/pdump: enhance to support multi-core capture

2019-04-07 Thread Varghese, Vipin
Hi Reshma, snipped > > > > > > > + fflush(stdout); > > > > > > Why is fflush used here and in below other places? > > To ensure the stdout content is flushed out. We had used similar approach > > to ' > > examples/l2fwd/main.c' > > > > Can you elaborate more? What problem do you see if y

[dpdk-dev] [PATCH v4 3/3] test/ring_perf: replace sync builtins with atomic builtins

2019-04-07 Thread Phil Yang
'__sync' built-in functions are deprecated, should use the '__atomic' built-in instead. the sync built-in functions are full barriers, while atomic built-in functions offer less restrictive one-way barriers, which help performance. Here is the example test result on TX2: sudo ./arm64-armv8a-linuxa

[dpdk-dev] [PATCH v4 2/3] test/distributor: replace sync builtins with atomic builtins

2019-04-07 Thread Phil Yang
'__sync' built-in functions are deprecated, should use the '__atomic' built-in instead. the sync built-in functions are full barriers, while atomic built-in functions offer less restrictive one-way barriers, which help performance. Here is the example test result on TX2: sudo ./arm64-armv8a-linuxa

[dpdk-dev] [PATCH v4 0/3] example and test cases optimizations

2019-04-07 Thread Phil Yang
v4: packet_ordering: Fixed -Wmissing-braces issue for clang build. (Thomas Monjalon) v3: test_distributor: Remove the conditional compilation and just keep the __atomic_xxx calls. (Honnappa Nagarahalli) v2: 1. Add per lcore statistics for each worker thread, removed __sync builtins. 2. Reimplemen

Re: [dpdk-dev] [PATCH v6 2/2] app/pdump: enhance to support multi-core capture

2019-04-07 Thread Varghese, Vipin
Hi Reshma, snipped > Nit picks: > > > > > +The ``--multi`` command line option is optional argument. If passed, > > +capture will be running on unique cores for all ``--pdump`` options. > > +If ignored, capture will be running on single core for all ``--pdump`` > > options. > > + > > Instead of

[dpdk-dev] [PATCH v4 1/3] packet_ordering: add statistics for each worker thread

2019-04-07 Thread Phil Yang
The current implementation using the '__sync' built-ins to synchronize statistics within worker threads. The '__sync' built-ins functions are full barriers which will affect the performance, so add a per worker packets statistics to remove the synchronisation between worker threads. Since the maxi

[dpdk-dev] [PATCH v7] net/nfb: new netcope driver

2019-04-07 Thread Rastislav Cernay
From: Rastislav Cernay Added new net driver for Netcope nfb cards Signed-off-by: Rastislav Cernay --- v2: remove unnecessary cast remove unnecessary zeroing move declaration to not mix with code restore skeleton example v3: add release notes add doc to doc index add architec

Re: [dpdk-dev] [dpdk-techboard] DPDK ABI/API Stability

2019-04-07 Thread Thomas Monjalon
04/04/2019 16:07, Burakov, Anatoly: > On 04-Apr-19 1:52 PM, Ray Kinsella wrote: > > On 04/04/2019 11:54, Bruce Richardson wrote: > >> On Thu, Apr 04, 2019 at 10:29:19AM +0100, Burakov, Anatoly wrote: > >>> On 03-Apr-19 4:42 PM, Ray Kinsella wrote: > >> Actually, I think we *do* need to constrain th

Re: [dpdk-dev] [dpdk-techboard] DPDK ABI/API Stability

2019-04-07 Thread Thomas Monjalon
05/04/2019 15:25, Ray Kinsella: > On 04/04/2019 14:10, Bruce Richardson wrote: > > On Thu, Apr 04, 2019 at 02:05:27PM +0100, Ray Kinsella wrote: > >> On 04/04/2019 13:02, Luca Boccassi wrote: > >>> On Thu, 2019-04-04 at 11:54 +0100, Bruce Richardson wrote: > On Thu, Apr 04, 2019 at 10:29:19AM

Re: [dpdk-dev] [PATCH] net/vmxnet3: synchronize vmxnet definitionswith 6.7 public

2019-04-07 Thread Thomas Monjalon
07/04/2019 02:36, Eduard Serra: > Hey Thomas, > > Thanks for taking a look. > My intentions is to port some of the new features on top of this patch (flow > steering, ESP RSS – preparing the patches right now) which we are using > inhouse to DPDK, however for that I require to upgrade definition

Re: [dpdk-dev] [dpdk-announce] release candidate 19.05-rc1

2019-04-07 Thread Thomas Monjalon
06/04/2019 00:55, Thomas Monjalon: > We have one month to complete this release cycle. > 19.05-rc2 is expected on 10th of April. Sorry, this date is wrong. As stated in the release meeting minutes, the next release candidate, DPDK 19.05-rc2 is expected on 17th of April: http://mails.dpdk.o