Re: [dpdk-dev] [PATCH 3/3] vhost: fix null pointer checking

2019-04-03 Thread Ye Xiaolong
Hi, Tiwei, On 04/04, Tiwei Bie wrote: [snip] >> @@ -515,7 +515,7 @@ rte_vhost_get_ifname(int vid, char *buf, size_t len) >> { >> struct virtio_net *dev = get_device(vid); >> >> -if (dev == NULL) >> +if (dev == NULL || !buf) > >It would be better to do the check in this way: (!dev |

Re: [dpdk-dev] [PATCH 2/3] net/virtio: fix null pointer checking

2019-04-03 Thread Tiwei Bie
On Wed, Apr 03, 2019 at 05:08:11PM +0100, Mohammad Abdul Awal wrote: > Null value of device name should return error without further processing. > > Fixes: 1c8489da56 ("net/virtio-user: fix multi-process support") > > Signed-off-by: Mohammad Abdul Awal > --- > drivers/net/virtio/virtio_user_eth

Re: [dpdk-dev] [PATCH 3/3] vhost: fix null pointer checking

2019-04-03 Thread Tiwei Bie
On Wed, Apr 03, 2019 at 05:08:23PM +0100, Mohammad Abdul Awal wrote: > Null value for parameters will cause segfault. > > Fuxes: d7280c9fff ("vhost: support selective datapath") s/Fuxes/Fixes/ > Fixes: 72e8543093 ("vhost: add external message handling to the API") Should be 72e8543093df ("vhost

Re: [dpdk-dev] [PATCH v10 1/1] net/af_xdp: introduce AF XDP PMD driver

2019-04-03 Thread Ye Xiaolong
Hi, Luca On 04/03, Luca Boccassi wrote: >On Wed, 2019-04-03 at 18:44 +0100, Ferruh Yigit wrote: >> On 4/3/2019 5:59 PM, Xiaolong Ye wrote: >> > Add a new PMD driver for AF_XDP which is a proposed faster version >> > of >> > AF_PACKET interface in Linux. More info about AF_XDP, please refer >> > to

Re: [dpdk-dev] [PATCH v10 1/1] net/af_xdp: introduce AF XDP PMD driver

2019-04-03 Thread Ye Xiaolong
On 04/03, Luca Boccassi wrote: >On Wed, 2019-04-03 at 18:44 +0100, Ferruh Yigit wrote: >> On 4/3/2019 5:59 PM, Xiaolong Ye wrote: >> > Add a new PMD driver for AF_XDP which is a proposed faster version >> > of >> > AF_PACKET interface in Linux. More info about AF_XDP, please refer >> > to [1] >> >

Re: [dpdk-dev] DSW eventdev is getting "stuck"?

2019-04-03 Thread Venky Venkatesh
On 4/3/19, 12:02 PM, "Mattias Rönnblom" wrote: On 2019-04-03 20:36, Venky Venkatesh wrote: > > > On 4/3/19, 11:34 AM, "Mattias Rönnblom" wrote: > > On 2019-04-03 20:17, Venky Venkatesh wrote: > > Hi, > > I am using the DSW code from 18.11 wit

Re: [dpdk-dev] [PATCH v10 1/1] net/af_xdp: introduce AF XDP PMD driver

2019-04-03 Thread Ye Xiaolong
Hi, Ferruh On 04/03, Ferruh Yigit wrote: >On 4/3/2019 5:59 PM, Xiaolong Ye wrote: >> Add a new PMD driver for AF_XDP which is a proposed faster version of >> AF_PACKET interface in Linux. More info about AF_XDP, please refer to [1] >> [2]. >> >> This is the vanilla version PMD which just uses a r

Re: [dpdk-dev] [PATCH v3 3/3] net/mlx5: add jump action support for NIC

2019-04-03 Thread Shahaf Shuler
Hi Ori, Wednesday, April 3, 2019 4:22 PM, Ori Kam: > Subject: [PATCH v3 3/3] net/mlx5: add jump action support for NIC > > When using Direct Rules we can add actions to jump between tables. > This is extra useful since rule insertion rate is much higher on other tables > compared to table zero. >

[dpdk-dev] [PATCH v2 1/3] app/testpmd: fix mempool free on exit

2019-04-03 Thread Shahaf Shuler
Allocated mempools were never free. it is bad practice. Fixes: af75078fece3 ("first public release") Cc: sta...@dpdk.org Signed-off-by: Shahaf Shuler --- app/test-pmd/testpmd.c | 25 +++-- app/test-pmd/testpmd.h | 2 ++ 2 files changed, 21 insertions(+), 6 deletions(-) dif

[dpdk-dev] [PATCH v2 2/3] app/testpmd: support creation of no IOVA contig mempools

2019-04-03 Thread Shahaf Shuler
providing a command line parameter to set the mempool flags accordingly. This mode is relevant only when creating an empty mempool and then populating with memory. Signed-off-by: Shahaf Shuler --- app/test-pmd/parameters.c | 13 + app/test-pmd/testpmd.c|

[dpdk-dev] [PATCH v2 0/3] DMA map anonymous memory to eth devices

2019-04-03 Thread Shahaf Shuler
Small series to use the APIs introduced by commit c33a675b6276 ("bus: introduce device level DMA memory mapping") On v2: * enforcing parameter validity at option parse time. * precede unmap to be before unregister. * extended debug log verbosity to include eth device name. * precede unmap and

[dpdk-dev] [PATCH v2 3/3] app/testpmd: map anonymous memory for eth devices

2019-04-03 Thread Shahaf Shuler
Mempools can be populated with anonymous memory when using command line parameter --mp-alloc=anon. Considering the mempools are going to be used by the net devices, it is better to DMA map this memory. This patch add such mapping now that we have the APIs in place[1]. [1] commit c33a675b6276 ("b

Re: [dpdk-dev] [RFC 3/3] bus/pci: add mdev support

2019-04-03 Thread Tiwei Bie
On Wed, Apr 03, 2019 at 10:13:25PM +0800, Wiles, Keith wrote: > Some minor nits. > > > On Apr 3, 2019, at 2:18 AM, Tiwei Bie wrote: > > > > This patch adds the mdev support in PCI bus driver. A mdev > > driver is introduced to probe the mdev devices whose device > > API is "vfio-pci" on the mdev

Re: [dpdk-dev] [PATCH] net/ice: send driver version to firmware

2019-04-03 Thread Yang, Qiming
-Original Message- From: Zhang, Qi Z Sent: Friday, March 29, 2019 9:30 AM To: Lu, Wenzhuo ; Yang, Qiming Cc: dev@dpdk.org; Stillwell Jr, Paul M ; Zhang, Qi Z Subject: [PATCH] net/ice: send driver version to firmware The driver must send its version information to the firmware, so th

Re: [dpdk-dev] [pull-request] next-crypto 19.05 rc1

2019-04-03 Thread Thomas Monjalon
02/04/2019 18:08, Akhil Goyal: > http://dpdk.org/git/next/dpdk-next-crypto Pulled, thanks

Re: [dpdk-dev] [pull-request] next-eventdev 19.05 RC1

2019-04-03 Thread Thomas Monjalon
02/04/2019 03:37, Jerin Jacob Kollanukkaran: > http://dpdk.org/git/next/dpdk-next-eventdev Pulled, thanks

[dpdk-dev] [PATCH v9 6/8] stack: add C11 atomic implementation

2019-04-03 Thread Gage Eads
This commit adds an implementation of the lock-free stack push, pop, and length functions that use __atomic builtins, for systems that benefit from the finer-grained memory ordering control. Signed-off-by: Gage Eads Reviewed-by: Olivier Matz Reviewed-by: Honnappa Nagarahalli --- lib/librte_sta

[dpdk-dev] [PATCH v9 7/8] test/stack: add lock-free stack tests

2019-04-03 Thread Gage Eads
This commit adds lock-free stack variants of stack_autotest (stack_lf_autotest) and stack_perf_autotest (stack_lf_perf_autotest), which differ only in that the lock-free versions pass the RTE_STACK_F_LF flag to all rte_stack_create() calls. Signed-off-by: Gage Eads Reviewed-by: Olivier Matz ---

[dpdk-dev] [PATCH v9 8/8] mempool/stack: add lock-free stack mempool handler

2019-04-03 Thread Gage Eads
This commit adds support for lock-free (linked list based) stack mempool handler. In mempool_perf_autotest the lock-based stack outperforms the lock-free handler for certain lcore/alloc count/free count combinations*, however: - For applications with preemptible pthreads, a standard (lock-based)

[dpdk-dev] [PATCH v9 5/8] stack: add lock-free stack implementation

2019-04-03 Thread Gage Eads
This commit adds support for a lock-free (linked list based) stack to the stack API. This behavior is selected through a new rte_stack_create() flag, RTE_STACK_F_LF. The stack consists of a linked list of elements, each containing a data pointer and a next pointer, and an atomic stack depth counte

[dpdk-dev] [PATCH v9 4/8] test/stack: add stack perf test

2019-04-03 Thread Gage Eads
stack_perf_autotest tests the following with one lcore: - Cycles to attempt to pop an empty stack - Cycles to push then pop a single object - Cycles to push then pop a burst of 32 objects It also tests the cycles to push then pop a burst of 8 and 32 objects with the following lcore combinations (i

[dpdk-dev] [PATCH v9 1/8] stack: introduce rte stack library

2019-04-03 Thread Gage Eads
The rte_stack library provides an API for configuration and use of a bounded stack of pointers. Push and pop operations are MT-safe, allowing concurrent access, and the interface supports pushing and popping multiple pointers at a time. The library's interface is modeled after another DPDK data st

[dpdk-dev] [PATCH v9 2/8] mempool/stack: convert mempool to use rte stack

2019-04-03 Thread Gage Eads
The new rte_stack library is derived from the mempool handler, so this commit removes duplicated code and simplifies the handler by migrating it to this new API. Signed-off-by: Gage Eads Reviewed-by: Olivier Matz --- MAINTAINERS | 2 +- drivers/mempool/stack/Makef

[dpdk-dev] [PATCH v9 0/8] Add stack library and new mempool handler

2019-04-03 Thread Gage Eads
This patchset introduces a stack library, supporting both lock-based and lock-free stacks, and a lock-free stack mempool handler. The lock-based stack code is derived from the existing stack mempool handler, and that handler is refactored to use the stack library. The lock-free stack mempool hand

[dpdk-dev] [PATCH v9 3/8] test/stack: add stack test

2019-04-03 Thread Gage Eads
stack_autotest performs positive and negative testing of the stack API, and exercises the push and pop datapath functions with all available lcores. Signed-off-by: Gage Eads Reviewed-by: Olivier Matz --- MAINTAINERS | 1 + app/test/Makefile | 2 + app/test/meson.build | 3 +

Re: [dpdk-dev] [PATCH v8 3/8] test/stack: add stack test

2019-04-03 Thread Eads, Gage
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Wednesday, April 3, 2019 5:41 PM > To: Eads, Gage > Cc: dev@dpdk.org; olivier.m...@6wind.com; arybche...@solarflare.com; > Richardson, Bruce ; Ananyev, Konstantin > ; gavin...@arm.com; > honnappa.nagaraha.

Re: [dpdk-dev] [PATCH v8 3/8] test/stack: add stack test

2019-04-03 Thread Thomas Monjalon
03/04/2019 22:50, Gage Eads: > stack_autotest performs positive and negative testing of the stack API, and > exercises the push and pop datapath functions with all available lcores. > > Signed-off-by: Gage Eads > Reviewed-by: Olivier Matz > --- > MAINTAINERS | 1 + > app/test/Makefi

Re: [dpdk-dev] [PATCH v2] eal: change init macro as exec environment specific

2019-04-03 Thread Thomas Monjalon
03/04/2019 22:07, Thomas Monjalon: > 03/04/2019 21:28, Jerin Jacob Kollanukkaran: > > From: Jerin Jacob > > > > baremetal execution environments may have a different > > method to enable RTE_INIT instead of using compiler > > constructor and/or OS specific linker scheme. > > Allow an option to ov

[dpdk-dev] [PATCH v8 7/8] test/stack: add lock-free stack tests

2019-04-03 Thread Gage Eads
This commit adds lock-free stack variants of stack_autotest (stack_lf_autotest) and stack_perf_autotest (stack_lf_perf_autotest), which differ only in that the lock-free versions pass the RTE_STACK_F_LF flag to all rte_stack_create() calls. Signed-off-by: Gage Eads Reviewed-by: Olivier Matz ---

[dpdk-dev] [PATCH v8 6/8] stack: add C11 atomic implementation

2019-04-03 Thread Gage Eads
This commit adds an implementation of the lock-free stack push, pop, and length functions that use __atomic builtins, for systems that benefit from the finer-grained memory ordering control. Signed-off-by: Gage Eads Reviewed-by: Olivier Matz Reviewed-by: Honnappa Nagarahalli --- lib/librte_sta

[dpdk-dev] [PATCH v8 8/8] mempool/stack: add lock-free stack mempool handler

2019-04-03 Thread Gage Eads
This commit adds support for lock-free (linked list based) stack mempool handler. In mempool_perf_autotest the lock-based stack outperforms the lock-free handler for certain lcore/alloc count/free count combinations*, however: - For applications with preemptible pthreads, a standard (lock-based)

[dpdk-dev] [PATCH v8 3/8] test/stack: add stack test

2019-04-03 Thread Gage Eads
stack_autotest performs positive and negative testing of the stack API, and exercises the push and pop datapath functions with all available lcores. Signed-off-by: Gage Eads Reviewed-by: Olivier Matz --- MAINTAINERS | 1 + app/test/Makefile | 2 + app/test/meson.build | 3 +

[dpdk-dev] [PATCH v8 5/8] stack: add lock-free stack implementation

2019-04-03 Thread Gage Eads
This commit adds support for a lock-free (linked list based) stack to the stack API. This behavior is selected through a new rte_stack_create() flag, RTE_STACK_F_LF. The stack consists of a linked list of elements, each containing a data pointer and a next pointer, and an atomic stack depth counte

[dpdk-dev] [PATCH v8 4/8] test/stack: add stack perf test

2019-04-03 Thread Gage Eads
stack_perf_autotest tests the following with one lcore: - Cycles to attempt to pop an empty stack - Cycles to push then pop a single object - Cycles to push then pop a burst of 32 objects It also tests the cycles to push then pop a burst of 8 and 32 objects with the following lcore combinations (i

[dpdk-dev] [PATCH v8 2/8] mempool/stack: convert mempool to use rte stack

2019-04-03 Thread Gage Eads
The new rte_stack library is derived from the mempool handler, so this commit removes duplicated code and simplifies the handler by migrating it to this new API. Signed-off-by: Gage Eads Reviewed-by: Olivier Matz --- MAINTAINERS | 2 +- drivers/mempool/stack/Makef

[dpdk-dev] [PATCH v8 1/8] stack: introduce rte stack library

2019-04-03 Thread Gage Eads
The rte_stack library provides an API for configuration and use of a bounded stack of pointers. Push and pop operations are MT-safe, allowing concurrent access, and the interface supports pushing and popping multiple pointers at a time. The library's interface is modeled after another DPDK data st

[dpdk-dev] [PATCH v8 0/8] Add stack library and new mempool handler

2019-04-03 Thread Gage Eads
This patchset introduces a stack library, supporting both lock-based and lock-free stacks, and a lock-free stack mempool handler. The lock-based stack code is derived from the existing stack mempool handler, and that handler is refactored to use the stack library. The lock-free stack mempool hand

Re: [dpdk-dev] [PATCH v7 0/8] Add stack library and new mempool handler

2019-04-03 Thread Eads, Gage
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Wednesday, April 3, 2019 3:40 PM > To: Eads, Gage > Cc: dev@dpdk.org; olivier.m...@6wind.com; arybche...@solarflare.com; > Richardson, Bruce ; Ananyev, Konstantin > ; gavin...@arm.com; > honnappa.nagaraha.

Re: [dpdk-dev] [PATCH v7 0/8] Add stack library and new mempool handler

2019-04-03 Thread Thomas Monjalon
03/04/2019 22:09, Gage Eads: > v7: > - Add rte_branch_prediction.h include to rte_stack_std.h for unlikely() > - Add rte_compat.h include to rte_stack.h for __rte_experimental There is another error when compiling for Arm: lib/librte_stack/rte_stack.h:76:2: error: implicit declaration of

[dpdk-dev] [PATCH v7 8/8] mempool/stack: add lock-free stack mempool handler

2019-04-03 Thread Gage Eads
This commit adds support for lock-free (linked list based) stack mempool handler. In mempool_perf_autotest the lock-based stack outperforms the lock-free handler for certain lcore/alloc count/free count combinations*, however: - For applications with preemptible pthreads, a standard (lock-based)

[dpdk-dev] [PATCH v7 6/8] stack: add C11 atomic implementation

2019-04-03 Thread Gage Eads
This commit adds an implementation of the lock-free stack push, pop, and length functions that use __atomic builtins, for systems that benefit from the finer-grained memory ordering control. Signed-off-by: Gage Eads Reviewed-by: Olivier Matz Reviewed-by: Honnappa Nagarahalli --- lib/librte_sta

[dpdk-dev] [PATCH v7 4/8] test/stack: add stack perf test

2019-04-03 Thread Gage Eads
stack_perf_autotest tests the following with one lcore: - Cycles to attempt to pop an empty stack - Cycles to push then pop a single object - Cycles to push then pop a burst of 32 objects It also tests the cycles to push then pop a burst of 8 and 32 objects with the following lcore combinations (i

[dpdk-dev] [PATCH v7 7/8] test/stack: add lock-free stack tests

2019-04-03 Thread Gage Eads
This commit adds lock-free stack variants of stack_autotest (stack_lf_autotest) and stack_perf_autotest (stack_lf_perf_autotest), which differ only in that the lock-free versions pass the RTE_STACK_F_LF flag to all rte_stack_create() calls. Signed-off-by: Gage Eads Reviewed-by: Olivier Matz ---

[dpdk-dev] [PATCH v7 5/8] stack: add lock-free stack implementation

2019-04-03 Thread Gage Eads
This commit adds support for a lock-free (linked list based) stack to the stack API. This behavior is selected through a new rte_stack_create() flag, RTE_STACK_F_LF. The stack consists of a linked list of elements, each containing a data pointer and a next pointer, and an atomic stack depth counte

[dpdk-dev] [PATCH v7 2/8] mempool/stack: convert mempool to use rte stack

2019-04-03 Thread Gage Eads
The new rte_stack library is derived from the mempool handler, so this commit removes duplicated code and simplifies the handler by migrating it to this new API. Signed-off-by: Gage Eads Reviewed-by: Olivier Matz --- MAINTAINERS | 2 +- drivers/mempool/stack/Makef

[dpdk-dev] [PATCH v7 3/8] test/stack: add stack test

2019-04-03 Thread Gage Eads
stack_autotest performs positive and negative testing of the stack API, and exercises the push and pop datapath functions with all available lcores. Signed-off-by: Gage Eads Reviewed-by: Olivier Matz --- MAINTAINERS | 1 + app/test/Makefile | 2 + app/test/meson.build | 3 +

[dpdk-dev] [PATCH v7 0/8] Add stack library and new mempool handler

2019-04-03 Thread Gage Eads
This patchset introduces a stack library, supporting both lock-based and lock-free stacks, and a lock-free stack mempool handler. The lock-based stack code is derived from the existing stack mempool handler, and that handler is refactored to use the stack library. The lock-free stack mempool hand

[dpdk-dev] [PATCH v7 1/8] stack: introduce rte stack library

2019-04-03 Thread Gage Eads
The rte_stack library provides an API for configuration and use of a bounded stack of pointers. Push and pop operations are MT-safe, allowing concurrent access, and the interface supports pushing and popping multiple pointers at a time. The library's interface is modeled after another DPDK data st

Re: [dpdk-dev] [PATCH v2] eal: change init macro as exec environment specific

2019-04-03 Thread Thomas Monjalon
03/04/2019 21:28, Jerin Jacob Kollanukkaran: > From: Jerin Jacob > > baremetal execution environments may have a different > method to enable RTE_INIT instead of using compiler > constructor and/or OS specific linker scheme. > Allow an option to override RTE_INIT* macros using > rte_os.h or appro

Re: [dpdk-dev] [PATCH v6] eal/x86: add 128-bit atomic compare exchange

2019-04-03 Thread Thomas Monjalon
03/04/2019 21:44, Gage Eads: > This operation can be used for non-blocking algorithms, such as a > non-blocking stack or ring. > > It is available only for x86_64. > > Signed-off-by: Gage Eads > Reviewed-by: Honnappa Nagarahalli > --- > This patch addresses x86-64 only; other architectures can/

Re: [dpdk-dev] DPDK ABI/API Stability

2019-04-03 Thread Luca Boccassi
On Wed, 2019-04-03 at 16:42 +0100, Ray Kinsella wrote: > Hi folks, > > Recently I started a discussion with the DPDK Technical Board on DPDK > ABI/API stability. This was born out informal feedback I had received > from a number of users of DPDK about ABI churn. In turn this feedback > then prompt

[dpdk-dev] [PATCH v6] eal/x86: add 128-bit atomic compare exchange

2019-04-03 Thread Gage Eads
This operation can be used for non-blocking algorithms, such as a non-blocking stack or ring. It is available only for x86_64. Signed-off-by: Gage Eads Reviewed-by: Honnappa Nagarahalli --- This patch addresses x86-64 only; other architectures can/will be supported in the future. The __atomic i

[dpdk-dev] [PATCH v5] eal/x86: add 128-bit atomic compare exchange

2019-04-03 Thread Thomas Monjalon
From: Gage Eads This operation can be used for non-blocking algorithms, such as a non-blocking stack or ring. It is available only for x86_64. Signed-off-by: Gage Eads Reviewed-by: Honnappa Nagarahalli --- This patch addresses x86-64 only; other architectures can/will be supported in the fut

[dpdk-dev] [PATCH v2] eal: change init macro as exec environment specific

2019-04-03 Thread Jerin Jacob Kollanukkaran
From: Jerin Jacob baremetal execution environments may have a different method to enable RTE_INIT instead of using compiler constructor and/or OS specific linker scheme. Allow an option to override RTE_INIT* macros using rte_os.h or appropriate header file. Signed-off-by: Jerin Jacob --- v2: -

Re: [dpdk-dev] [PATCH v4 1/1] eal: add 128-bit compare exchange (x86-64 only)

2019-04-03 Thread Thomas Monjalon
03/04/2019 21:21, Eads, Gage: > > 03/04/2019 19:34, Gage Eads: > > > This operation can be used for non-blocking algorithms, such as a > > > non-blocking stack or ring. > > > > > > Signed-off-by: Gage Eads > > > Reviewed-by: Honnappa Nagarahalli > > > --- > > > --- a/lib/librte_eal/common/include

Re: [dpdk-dev] [PATCH v4 1/1] eal: add 128-bit compare exchange (x86-64 only)

2019-04-03 Thread Eads, Gage
> 03/04/2019 19:34, Gage Eads: > > This operation can be used for non-blocking algorithms, such as a > > non-blocking stack or ring. > > > > Signed-off-by: Gage Eads > > Reviewed-by: Honnappa Nagarahalli > > --- > > --- a/lib/librte_eal/common/include/arch/x86/rte_atomic_64.h > > +++ b/lib/librte

Re: [dpdk-dev] [PATCH v4 1/1] eal: add 128-bit compare exchange (x86-64 only)

2019-04-03 Thread Thomas Monjalon
03/04/2019 19:34, Gage Eads: > This operation can be used for non-blocking algorithms, such as a > non-blocking stack or ring. > > Signed-off-by: Gage Eads > Reviewed-by: Honnappa Nagarahalli > --- > --- a/lib/librte_eal/common/include/arch/x86/rte_atomic_64.h > +++ b/lib/librte_eal/common/inclu

Re: [dpdk-dev] DSW eventdev is getting "stuck"?

2019-04-03 Thread Mattias Rönnblom
On 2019-04-03 20:36, Venky Venkatesh wrote: On 4/3/19, 11:34 AM, "Mattias Rönnblom" wrote: On 2019-04-03 20:17, Venky Venkatesh wrote: > Hi, > I am using the DSW code from 18.11 with the default settings for all the #defines. Here are some more details: > I have an 8 por

Re: [dpdk-dev] [PATCH v5 0/2] hash: add lock free support for ext bkt

2019-04-03 Thread Thomas Monjalon
02/04/2019 21:44, Dharmik Thakkar: > This patch series: > - Enables lock-free read-write concurrency support for extendable > bucket feature. > - Adds lock-free read-write concurrency tests for ext bkt > --- > Dharmik Thakkar (2): > hash: add lock free support for extendable bucket > test/hash:

Re: [dpdk-dev] [PATCH v10 1/1] net/af_xdp: introduce AF XDP PMD driver

2019-04-03 Thread Luca Boccassi
On Wed, 2019-04-03 at 18:44 +0100, Ferruh Yigit wrote: > On 4/3/2019 5:59 PM, Xiaolong Ye wrote: > > Add a new PMD driver for AF_XDP which is a proposed faster version > > of > > AF_PACKET interface in Linux. More info about AF_XDP, please refer > > to [1] > > [2]. > > > > This is the vanilla vers

Re: [dpdk-dev] [PATCH 1/3] ethdev: fix null pointer checking

2019-04-03 Thread Stephen Hemminger
On Wed, 3 Apr 2019 17:07:26 +0100 Mohammad Abdul Awal wrote: > Null value for parameter name will cause segfault for the > strnlen and strcmp functions. > > Fixes: 0b33b68d12 ("ethdev: export allocate function") > Fixes: 942661004c ("ethdev: export secondary attach function") > Cc: sta...@dpdk.

Re: [dpdk-dev] [PATCH 1/3] ethdev: fix null pointer checking

2019-04-03 Thread Thomas Monjalon
03/04/2019 19:30, Awal, Mohammad Abdul: > From: Yigit, Ferruh > > On 4/3/2019 5:27 PM, Thomas Monjalon wrote: > > > 03/04/2019 18:07, Mohammad Abdul Awal: > > >> Null value for parameter name will cause segfault for the > > >> strnlen and strcmp functions. > > > > > > I'm not sure we want such obvi

Re: [dpdk-dev] DSW eventdev is getting "stuck"?

2019-04-03 Thread Venky Venkatesh
On 4/3/19, 11:34 AM, "Mattias Rönnblom" wrote: On 2019-04-03 20:17, Venky Venkatesh wrote: > Hi, > I am using the DSW code from 18.11 with the default settings for all the #defines. Here are some more details: > I have an 8 port system with 1 queue. > All ports can inject

Re: [dpdk-dev] DSW eventdev is getting "stuck"?

2019-04-03 Thread Mattias Rönnblom
On 2019-04-03 20:17, Venky Venkatesh wrote: Hi, I am using the DSW code from 18.11 with the default settings for all the #defines. Here are some more details: I have an 8 port system with 1 queue. All ports can inject events. Port 0 and 7 inject events rarely. Ports 1-6 are linked to the queue a

[dpdk-dev] DSW eventdev is getting "stuck"?

2019-04-03 Thread Venky Venkatesh
Hi, I am using the DSW code from 18.11 with the default settings for all the #defines. Here are some more details: I have an 8 port system with 1 queue. All ports can inject events. Port 0 and 7 inject events rarely. Ports 1-6 are linked to the queue and hence dequeue events. I see that in steady

Re: [dpdk-dev] [PATCH v3 3/4] net/mlx5: use port sibling iterators

2019-04-03 Thread Yongseok Koh
> On Apr 3, 2019, at 7:19 AM, Ferruh Yigit wrote: > > On 4/1/2019 3:26 AM, Thomas Monjalon wrote: >> Iterating over siblings was done with RTE_ETH_FOREACH_DEV() >> which skips the owned ports. >> The new iterators RTE_ETH_FOREACH_DEV_SIBLING() >> and RTE_ETH_FOREACH_DEV_OF() are more appropriat

Re: [dpdk-dev] [PATCH 00/12] net/sfc: add Tx prepare and encapsulated TSO

2019-04-03 Thread Ferruh Yigit
On 4/2/2019 10:28 AM, Andrew Rybchenko wrote: > Move and add missing Tx offloads checks to Tx prepare stage. > Keep absolutely required checks in Tx burst to avoid spoil of > memory and segmentation faults. > > There are few checkpatches.sh warnings since positive errno is > used inside driver. >

Re: [dpdk-dev] [PATCH v10 1/1] net/af_xdp: introduce AF XDP PMD driver

2019-04-03 Thread Ferruh Yigit
On 4/3/2019 5:59 PM, Xiaolong Ye wrote: > Add a new PMD driver for AF_XDP which is a proposed faster version of > AF_PACKET interface in Linux. More info about AF_XDP, please refer to [1] > [2]. > > This is the vanilla version PMD which just uses a raw buffer registered as > the umem. > > [1] htt

[dpdk-dev] [PATCH v4 1/1] eal: add 128-bit compare exchange (x86-64 only)

2019-04-03 Thread Gage Eads
This operation can be used for non-blocking algorithms, such as a non-blocking stack or ring. Signed-off-by: Gage Eads Reviewed-by: Honnappa Nagarahalli --- .../common/include/arch/x86/rte_atomic_64.h| 81 ++ 1 file changed, 81 insertions(+) diff --git a/lib/librte_

[dpdk-dev] [PATCH v4 0/1] Add 128-bit compare and set

2019-04-03 Thread Gage Eads
This patch addresses x86-64 only; other architectures can/will be supported in the future. The __atomic intrinsic was considered for the implementation, however libatomic was found[1] to use locks to implement the 128-bit CAS on at least one architecture and so is eschewed here. The interface is mo

Re: [dpdk-dev] [PATCH 1/3] ethdev: fix null pointer checking

2019-04-03 Thread David Marchand
On Wed, Apr 3, 2019 at 6:53 PM Ferruh Yigit wrote: > On 4/3/2019 5:41 PM, Bruce Richardson wrote: > > On Wed, Apr 03, 2019 at 05:35:22PM +0100, Ferruh Yigit wrote: > >> On 4/3/2019 5:27 PM, Thomas Monjalon wrote: > >>> 03/04/2019 18:07, Mohammad Abdul Awal: > Null value for parameter name wi

Re: [dpdk-dev] [PATCH v10 1/1] net/af_xdp: introduce AF XDP PMD driver

2019-04-03 Thread Luca Boccassi
On Thu, 2019-04-04 at 00:59 +0800, Xiaolong Ye wrote: > Add a new PMD driver for AF_XDP which is a proposed faster version of > AF_PACKET interface in Linux. More info about AF_XDP, please refer to > [1] > [2]. > > This is the vanilla version PMD which just uses a raw buffer > registered as > the

Re: [dpdk-dev] [PATCH 1/3] ethdev: fix null pointer checking

2019-04-03 Thread Awal, Mohammad Abdul
The null checks are for the input param "char *name" of APIs rte_eth_dev_allocate and rte_eth_dev_attach_secondary. I will change the err msg to suggested one. > -Original Message- > From: Yigit, Ferruh > Sent: Wednesday, April 3, 2019 5:35 PM > To: Thomas Monjalon ; Awal, Mohammad Abdul

Re: [dpdk-dev] [PATCH v6 1/8] stack: introduce rte stack library

2019-04-03 Thread Thomas Monjalon
03/04/2019 19:13, Eads, Gage: > > 02/04/2019 13:14, Honnappa Nagarahalli: > > > > Subject: [PATCH v6 1/8] stack: introduce rte stack library > > > > > > > > The rte_stack library provides an API for configuration and use of a > > > > bounded stack of pointers. Push and pop operations are MT-safe, >

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] mem: limit use of address hint

2019-04-03 Thread Thomas Monjalon
02/04/2019 19:23, Alejandro Lucero: > On Tue, Apr 2, 2019 at 5:13 PM Burakov, Anatoly > wrote: > > On 31-Mar-19 9:43 AM, Shahaf Shuler wrote: > > > patch[1] added an address hint as starting address for 64 bit systems in > > > case an explicit base virtual address was not set by the user. > > > >

[dpdk-dev] [RFC 5/5] eal: make lcore_config private

2019-04-03 Thread Stephen Hemminger
The internal structure of lcore_config should not be part of visible API/ABI. Make it private to EAL. Rearrange and resize the fields in the structure so it takes less memory (and cache footprint). Signed-off-by: Stephen Hemminger --- lib/librte_eal/common/eal_common_launch.c | 2 ++ lib/librt

[dpdk-dev] [PATCH 4/4] power: add cmd to query CPU freq.

2019-04-03 Thread Hajkowski
From: Marcin Hajkowski Add command and related logic to query CPU frequencies either for specified CPU or all cores. Signed-off-by: Marcin Hajkowski --- .../guest_cli/vm_power_cli_guest.c| 150 -- 1 file changed, 138 insertions(+), 12 deletions(-) diff --git a/exam

[dpdk-dev] [PATCH 3/4] power: add mechanism to disable queries

2019-04-03 Thread Hajkowski
From: Marcin Hajkowski Add new command which gives possibility to enable/disable queries form VM guest. Signed-off-by: Marcin Hajkowski --- examples/vm_power_manager/channel_manager.c | 20 + examples/vm_power_manager/channel_manager.h | 18 examples/vm_power_manager/channel_m

[dpdk-dev] [PATCH 2/4] power: process cpu freq. query

2019-04-03 Thread Hajkowski
From: Marcin Hajkowski On query received from VM guest send CPUs frequencies. Signed-off-by: Marcin Hajkowski --- examples/vm_power_manager/channel_monitor.c | 67 ++--- 1 file changed, 59 insertions(+), 8 deletions(-) diff --git a/examples/vm_power_manager/channel_monitor.c

[dpdk-dev] [RFC 4/5] app/test: use lcore accessor functions

2019-04-03 Thread Stephen Hemminger
Don't refer to lcore_config directly. Signed-off-by: Stephen Hemminger --- app/test/test_cryptodev.c | 2 +- app/test/test_hash_readwrite_lf.c | 12 ++-- app/test/test_ring_perf.c | 22 -- 3 files changed, 19 insertions(+), 17 deletions(-) diff --git

[dpdk-dev] [PATCH 1/4] power: extend guest channel for query freq.

2019-04-03 Thread Hajkowski
From: Marcin Hajkowski Extend incoming packet reading API with new packet type which carries CPU frequencies. Signed-off-by: Marcin Hajkowski --- lib/librte_power/channel_commands.h | 21 + lib/librte_power/guest_channel.c| 27 --- lib/librte_pow

[dpdk-dev] [PATCH 0/4] Frequency list query

2019-04-03 Thread Hajkowski
From: Marcin Hajkowski Extend guest channel and sample apps to query CPU frequncies. Please note that these changes depends on (http://patchwork.dpdk.org/cover/52057/) which should be applied first. Marcin Hajkowski (4): power: extend guest channel for query freq. power: process cpu freq. q

[dpdk-dev] [RFC 3/5] examples/bond: use lcore accessor

2019-04-03 Thread Stephen Hemminger
Refering to lcore_config directly is no longer recommended. Signed-off-by: Stephen Hemminger --- examples/bond/main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/examples/bond/main.c b/examples/bond/main.c index ef86194fff4a..48e6755ea294 100644 --- a/examples/bond/ma

[dpdk-dev] [RFC 2/5] bus: use lcore accessor functions

2019-04-03 Thread Stephen Hemminger
The lcore_config structure will be hidden in future release. Signed-off-by: Stephen Hemminger --- drivers/bus/dpaa/dpaa_bus.c | 6 -- drivers/bus/fslmc/portal/dpaa2_hw_dpio.c | 4 +++- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/bus/dpaa/dpaa_bus.c b/d

[dpdk-dev] [RFC 1/5] eal: add accessor functions for lcore_config

2019-04-03 Thread Stephen Hemminger
The fields of the internal EAL core configuration are currently laid bare as part of the API. This is not good practice and limits fixing issues with layout and sizes. Make new accessor functions for the fields used by current drivers and examples. Mark the state and return code functions as exper

[dpdk-dev] [RFC 0/5] make lcore_config less visible

2019-04-03 Thread Stephen Hemminger
This is a compile tested only set of patches to make the current lcore_config structure internal to EAL. The first 4 would go into current release, and the last would go into later release to make it fully internal. Stephen Hemminger (5): eal: add accessor functions for lcore_config bus: use

Re: [dpdk-dev] [PATCH v6 1/8] stack: introduce rte stack library

2019-04-03 Thread Eads, Gage
> 02/04/2019 13:14, Honnappa Nagarahalli: > > > Subject: [PATCH v6 1/8] stack: introduce rte stack library > > > > > > The rte_stack library provides an API for configuration and use of a > > > bounded stack of pointers. Push and pop operations are MT-safe, > > > allowing concurrent access, and the

Re: [dpdk-dev] [PATCH v6 0/8] Add stack library and new mempool handler

2019-04-03 Thread Eads, Gage
> 01/04/2019 23:14, Gage Eads: > > Note that the lock-free algorithm relies on a 128-bit > > compare-and-swap[1], so it is currently limited to the x86_64 platform. > > I'm waiting for an update of the 128-bit compare-and-swap. > It is blocking the integration of this patch. > Sorry for that; I

Re: [dpdk-dev] [PATCH v6 1/8] stack: introduce rte stack library

2019-04-03 Thread Thomas Monjalon
02/04/2019 13:14, Honnappa Nagarahalli: > > Subject: [PATCH v6 1/8] stack: introduce rte stack library > > > > The rte_stack library provides an API for configuration and use of a bounded > > stack of pointers. Push and pop operations are MT-safe, allowing concurrent > > access, and the interface

[dpdk-dev] [PATCH v10 0/1] Introduce AF_XDP PMD

2019-04-03 Thread Xiaolong Ye
Overview This patchset adds a new PMD driver for AF_XDP which is a proposed faster version of AF_PACKET interface in Linux, see below links [1] [2] for details of AF_XDP introduction: AF_XDP roadmap == - AF_XDP is included in upstream kernel since 4.18, and AF_XDP support i

[dpdk-dev] [PATCH v10 1/1] net/af_xdp: introduce AF XDP PMD driver

2019-04-03 Thread Xiaolong Ye
Add a new PMD driver for AF_XDP which is a proposed faster version of AF_PACKET interface in Linux. More info about AF_XDP, please refer to [1] [2]. This is the vanilla version PMD which just uses a raw buffer registered as the umem. [1] https://fosdem.org/2018/schedule/event/af_xdp/ [2] https://

Re: [dpdk-dev] [PATCH v6 0/8] Add stack library and new mempool handler

2019-04-03 Thread Thomas Monjalon
01/04/2019 23:14, Gage Eads: > Note that the lock-free algorithm relies on a 128-bit compare-and-swap[1], > so it is currently limited to the x86_64 platform. I'm waiting for an update of the 128-bit compare-and-swap. It is blocking the integration of this patch.

Re: [dpdk-dev] [PATCH 1/3] ethdev: fix null pointer checking

2019-04-03 Thread Ferruh Yigit
On 4/3/2019 5:41 PM, Bruce Richardson wrote: > On Wed, Apr 03, 2019 at 05:35:22PM +0100, Ferruh Yigit wrote: >> On 4/3/2019 5:27 PM, Thomas Monjalon wrote: >>> 03/04/2019 18:07, Mohammad Abdul Awal: Null value for parameter name will cause segfault for the strnlen and strcmp functions. >>

Re: [dpdk-dev] [PATCH v8 0/6] Add lock-free ring and mempool handler

2019-04-03 Thread Thomas Monjalon
19/03/2019 02:20, Gage Eads: > This patchset makes one API change; a deprecation notice was posted in a > separate commit[1]. It means this patchset targets the release 19.08. In such case, it is better to use --subject-prefix='PATCH 19.08'

Re: [dpdk-dev] [PATCH v3 0/4] ethdev iterators for multi-ports device

2019-04-03 Thread Ferruh Yigit
On 4/1/2019 3:26 AM, Thomas Monjalon wrote: > Add port iterators in order to allow listing easily > the ports of the same device. > > The iterators can be tested by using mlx5 or testpmd. > > > v3: changes only in the (main) patch 2 > > > Thomas Monjalon (4): > ethdev: simplify port state co

Re: [dpdk-dev] [PATCH 1/3] ethdev: fix null pointer checking

2019-04-03 Thread Bruce Richardson
On Wed, Apr 03, 2019 at 05:35:22PM +0100, Ferruh Yigit wrote: > On 4/3/2019 5:27 PM, Thomas Monjalon wrote: > > 03/04/2019 18:07, Mohammad Abdul Awal: > >> Null value for parameter name will cause segfault for the strnlen and > >> strcmp functions. > > > > I'm not sure we want such obvious checks

Re: [dpdk-dev] [PATCH v2] rte_ring: add newline to error message

2019-04-03 Thread Thomas Monjalon
02/04/2019 17:30, Stephen Hemminger: > Log message should end with newline. > > Fixes: 4e32101f9b01 ("ring: support freeing") > Signed-off-by: Stephen Hemminger > Reviewed-by: Rami Rosen > --- > v2 -- fix punctuation in message as well Applied, thanks

Re: [dpdk-dev] [PATCH v2 0/2] eal: hexdump cleanups

2019-04-03 Thread Thomas Monjalon
02/04/2019 17:23, Stephen Hemminger: > Minor bugfix and source cleanup > > Stephen Hemminger (2): > hexdump: whitespace cleanup > hexdump: align output of string Applied, thanks

Re: [dpdk-dev] [PATCH 1/3] ethdev: fix null pointer checking

2019-04-03 Thread Ferruh Yigit
On 4/3/2019 5:27 PM, Thomas Monjalon wrote: > 03/04/2019 18:07, Mohammad Abdul Awal: >> Null value for parameter name will cause segfault for the >> strnlen and strcmp functions. > > I'm not sure we want such obvious checks for all APIs. > Here I would say yes. These are internal functions, not A

Re: [dpdk-dev] [PATCH v2] kni: add IOVA va support for kni

2019-04-03 Thread Ferruh Yigit
On 4/1/2019 10:51 AM, Kiran Kumar Kokkilagadda wrote: > From: Kiran Kumar K > > With current KNI implementation kernel module will work only in > IOVA=PA mode. This patch will add support for kernel module to work > with IOVA=VA mode. Thanks Kiran for removing the limitation, I have a few questi

  1   2   3   >