Tuesday, April 2, 2019 6:16 PM, Burakov, Anatoly:
> Subject: Re: [dpdk-dev] [PATCH 2/3] app/testpmd: support creation of no
> IOVA contig mempools
>
> On 02-Apr-19 8:02 AM, Shahaf Shuler wrote:
> > Monday, April 1, 2019 4:50 PM, Burakov, Anatoly:
> >> Subject: Re: [dpdk-dev] [PATCH 2/3] app/testpm
Thanks for your reminder, I'll add doc update later.
Qiming
> -Original Message-
> From: Iremonger, Bernard
> Sent: Wednesday, March 27, 2019 7:04 PM
> To: Yang, Qiming ; dev@dpdk.org
> Cc: Zhang, Qi Z ; Yang, Qiming
>
> Subject: RE: [dpdk-dev] [PATCH v4 4/5] app/testpmd: add VXLAN-GPE t
Wednesday, March 27, 2019 8:20 AM, Tom Barbette:
> Subject: [PATCH v2 2/3] mlx5: Implement support for read_clock
>
> Signed-off-by: Tom Barbette
Apart from the compilation issue I am OK w/ this patch.
You can add my acked-by on v3.
> ---
> drivers/net/mlx5/mlx5.c| 1 +
> drivers/net
Hi Reshma,
snipped
> > +
> > + printf(" core (%u); port %u device (%s) queue %u\n",
> > + rte_lcore_id(), pt->port, pt->device_id, pt->queue);
>
> Log message can be improved to be " packet_dump for port running on
> core "
Thanks for the suggestion, but I am comfortable wit
Currently the DPDK Environment Abstraction Layer has its guts on the floor ;-)
The data structure for lcore config is a holey mess and changing it would
break the ABI.
I propose that for 19.05 we introduce accessor functions and change all
internal (out side of eal directory) to use those. And add
HI,
Why not add some more code
"
if (rx_conf->offloads & DEV_RX_OFFLOAD_SCATTER)
dev->data->scattered_rx = 1;
"
Into ixgbevf_dev_rx_init() to enable scatter mode when start device?
Reviewed-by: Wei Zhao
> -Original Message-
> From: dev [mailto:dev-boun...@d
Currently, if requested MTU is bigger than mbuf size and scattered
receive is not enabled, setting MTU to that value fails.
This patch allows setting this special MTU when device is stopped,
because scattered_rx will be re-configured during next port start
and driver may enable scattered receive a
On 4/2/2019 4:25 PM, Thomas Monjalon wrote:
02/04/2019 05:54, Anand Rawat:
Includes Windows-specific EAL changes and meson changes
to build the code on Windows.
[...]
Anand Rawat (10):
eal: eal stub to add windows support
meson: required changes for windows
eal: add new rte_os.h heade
03/04/2019 01:42, Ferruh Yigit:
> On 4/1/2019 3:26 AM, Thomas Monjalon wrote:
> > +__rte_experimental
> > +uint16_t rte_eth_find_next_of(uint16_t port_id_start,
> > + const struct rte_device *parent);
>
> Minor nit, but other instances using the tag as:
>
> uint16_t __rte_experimental
>
On 4/1/2019 3:27 AM, Thomas Monjalon wrote:
> When removing a rte_device on a port-based request,
> all the sibling ports must be marked as closed.
> The iterator loop can be simplified by using the dedicated macro.
>
> Signed-off-by: Thomas Monjalon
Reviewed-by: Ferruh Yigit
On 4/1/2019 3:26 AM, Thomas Monjalon wrote:
> If multiple ports share the same hardware device (rte_device),
> they are siblings and can be found thanks to the new functions
> and loop macros.
> One iterator takes a port id as reference,
> while the other one directly refers to the parent device.
>
03/04/2019 01:35, Ferruh Yigit:
> On 4/1/2019 9:09 AM, Thomas Monjalon wrote:
> > 01/04/2019 08:46, David Marchand:
> >> On Mon, Apr 1, 2019 at 4:16 AM Thomas Monjalon wrote:
> >>
> >>> 19/03/2019 19:04, Ferruh Yigit:
> On 3/19/2019 5:34 PM, Thomas Monjalon wrote:
> >>> +uint16_t __rte_ex
On 4/1/2019 9:09 AM, Thomas Monjalon wrote:
> 01/04/2019 08:46, David Marchand:
>> On Mon, Apr 1, 2019 at 4:16 AM Thomas Monjalon wrote:
>>
>>> 19/03/2019 19:04, Ferruh Yigit:
On 3/19/2019 5:34 PM, Thomas Monjalon wrote:
>>> +uint16_t __rte_experimental
>>
>> Do we need _rte_exper
02/04/2019 05:54, Anand Rawat:
> Includes Windows-specific EAL changes and meson changes
> to build the code on Windows.
[...]
> Anand Rawat (10):
> eal: eal stub to add windows support
> meson: required changes for windows
> eal: add new rte_os.h header to build system
> eal: update commo
On 4/2/2019 4:04 PM, Thomas Monjalon wrote:
02/04/2019 05:54, Anand Rawat:
These are the required meson changes for Windows.
kernel/windows/meson is a stub file added to support
Windows specific source in future releases.
Signed-off-by: Anand Rawat
Signed-off-by: Pallavi Kadam
Reviewed-by:
On 04/02, Stephen Hemminger wrote:
>On Tue, 2 Apr 2019 23:46:53 +0800
>Xiaolong Ye wrote:
>
>> +/* pull from complete qeueu to leave more space */
>
>Overall looks good, one last spelling error
Sorry for the typo, will fix in in next version.
Thanks,
Xiaolong
02/04/2019 05:54, Anand Rawat:
> These are the required meson changes for Windows.
> kernel/windows/meson is a stub file added to support
> Windows specific source in future releases.
>
> Signed-off-by: Anand Rawat
> Signed-off-by: Pallavi Kadam
> Reviewed-by: Jeff Shaw
> Reviewed-by: Ranjit Me
02/04/2019 05:54, Anand Rawat:
> Updated lib/meson.build to create shared libraries on Windows.
> Added DEF files to list the exports for the eal and kvargs libraries.
>
> Signed-off-by: Bruce Richardson
> Signed-off-by: Anand Rawat
> Reviewed-by: Pallavi Kadam
> Reviewed-by: Ranjit Menon
> --
On 4/2/2019 3:51 PM, Thomas Monjalon wrote:
02/04/2019 05:54, Anand Rawat:
Added meson workarounds to build helloworld on Windows.
Windows currently only supports kvargs and eal libraries.
This change restricts the build flow to supported libraries
only.
Signed-off-by: Anand Rawat
Signed-off-b
On 4/2/2019 3:39 PM, Thomas Monjalon wrote:
I think the change below is bad because it is exposing an internal
function in a header file which may be included by apps.
I know you are still looking for pthread integration solutions,
so we can discuss how to fix it later.
Note that there is alread
02/04/2019 05:54, Anand Rawat:
> Added meson workarounds to build helloworld on Windows.
> Windows currently only supports kvargs and eal libraries.
> This change restricts the build flow to supported libraries
> only.
>
> Signed-off-by: Anand Rawat
> Signed-off-by: Pallavi Kadam
> Reviewed-by:
I think the change below is bad because it is exposing an internal
function in a header file which may be included by apps.
I know you are still looking for pthread integration solutions,
so we can discuss how to fix it later.
Note that there is already an EAL function to create normal threads:
On 4/2/2019 3:32 PM, Thomas Monjalon wrote:
03/04/2019 00:11, Anand Rawat:
> On 4/2/2019 1:47 PM, Thomas Monjalon wrote:
>> 02/04/2019 21:56, Thomas Monjalon:
>>> 02/04/2019 05:54, Anand Rawat:
Added rte_os.h files to support OS specific functionality.
Updated build system to contain OS
03/04/2019 00:11, Anand Rawat:
> On 4/2/2019 1:47 PM, Thomas Monjalon wrote:
> > 02/04/2019 21:56, Thomas Monjalon:
> >> 02/04/2019 05:54, Anand Rawat:
> >>> Added rte_os.h files to support OS specific functionality.
> >>> Updated build system to contain OS headers in the include
> >>> path.
> >>>
On 4/2/2019 1:47 PM, Thomas Monjalon wrote:
02/04/2019 21:56, Thomas Monjalon:
02/04/2019 05:54, Anand Rawat:
Added rte_os.h files to support OS specific functionality.
Updated build system to contain OS headers in the include
path.
Signed-off-by: Anand Rawat
Reviewed-by: Pallavi Kadam
---
-
On 4/2/2019 2:38 PM, Thomas Monjalon wrote:
02/04/2019 23:21, Pallavi Kadam:
On 4/2/2019 1:06 PM, Thomas Monjalon wrote:
02/04/2019 05:54, Anand Rawat:
Add windows specific logic for eal.c, eal_lcore.c,
eal_debug.c and eal_thread.c. Updated header files to
contain suitable function declaract
02/04/2019 23:21, Pallavi Kadam:
>
> On 4/2/2019 1:06 PM, Thomas Monjalon wrote:
> > 02/04/2019 05:54, Anand Rawat:
> >> Add windows specific logic for eal.c, eal_lcore.c,
> >> eal_debug.c and eal_thread.c. Updated header files to
> >> contain suitable function declaractions.
> >>
> >> Signed-off-
On 4/2/2019 1:06 PM, Thomas Monjalon wrote:
02/04/2019 05:54, Anand Rawat:
Add windows specific logic for eal.c, eal_lcore.c,
eal_debug.c and eal_thread.c. Updated header files to
contain suitable function declaractions.
Signed-off-by: Anand Rawat
Signed-off-by: Pallavi Kadam
Reviewed-by: J
On Tue, Apr 2, 2019 at 11:07 PM Stephen Hemminger <
step...@networkplumber.org> wrote:
> On Tue, 2 Apr 2019 23:03:06 +0200
> David Marchand wrote:
>
> > On Tue, Apr 2, 2019 at 10:48 PM Stephen Hemminger <
> > step...@networkplumber.org> wrote:
> >
> > > On Tue, 2 Apr 2019 22:15:40 +0200
> > > Dav
On Tue, 2 Apr 2019 23:03:06 +0200
David Marchand wrote:
> On Tue, Apr 2, 2019 at 10:48 PM Stephen Hemminger <
> step...@networkplumber.org> wrote:
>
> > On Tue, 2 Apr 2019 22:15:40 +0200
> > David Marchand wrote:
> >
> > > On Tue, Apr 2, 2019 at 5:57 PM Stephen Hemminger <
> > step...@netwo
On Tue, Apr 2, 2019 at 10:48 PM Stephen Hemminger <
step...@networkplumber.org> wrote:
> On Tue, 2 Apr 2019 22:15:40 +0200
> David Marchand wrote:
>
> > On Tue, Apr 2, 2019 at 5:57 PM Stephen Hemminger <
> step...@networkplumber.org>
> > wrote:
> >
> > > C language does not really treat enum's as
Thank you, Ju!
Some additional information: this test was run via the LISAv2 framework
that Microsoft uses to validate Linux and other applications on Azure.
It can be found on Github:
https://github.com/LIS/LISAv2
For 18.11.1 it was just ran on Ubuntu 18.04, but for the next
validations RHEL an
C language does not really treat enum's as first class symbols.
The values in an enum live in a global namespace. That means if
DPDK defines "RUNNING" it can't be used by another enum in an
application using DPDK.
To solve this add a prefix "RTE_LCORE_" to the enum values, and
make them grammatic
On Tue, 2 Apr 2019 22:15:40 +0200
David Marchand wrote:
> On Tue, Apr 2, 2019 at 5:57 PM Stephen Hemminger
> wrote:
>
> > C language does not really treat enum's as first class symbols.
> > The values in an enum live in a global namespace. That means if
> > DPDK defines "RUNNING" it can't be u
02/04/2019 21:56, Thomas Monjalon:
> 02/04/2019 05:54, Anand Rawat:
> > Added rte_os.h files to support OS specific functionality.
> > Updated build system to contain OS headers in the include
> > path.
> >
> > Signed-off-by: Anand Rawat
> > Reviewed-by: Pallavi Kadam
> > ---
> > --- a/meson.bui
The IP addresses should be formatted using standard routines
rather than dumpin in raw hex.
Signed-off-by: Stephen Hemminger
---
v4 - remove fixes, the original output was raw but not a bug
examples/l3fwd/l3fwd_lpm.c | 15 ++-
1 file changed, 10 insertions(+), 5 deletions(-)
diff -
These patches get rid of the custom addresses used in testpmd
and l3fwd, and instead uses values that are in the existing
RFC's.
Stephen Hemminger (3):
app/testpmd: add ability to set Tx IP and UDP parameters
examples/l3fwd: use reserved IPv4/IPv6 addresses
examples/l3fwd: format the IP addr
The l3fwd example should use the IPv4 addresses defined in RFC5735 and
the IPv6 addresses defined in RFC5180 for the L3 forwarding example
Longest Prefix Match table.
Signed-off-by: Stephen Hemminger
---
v4 - fix IPv6 /48 entries
examples/l3fwd/l3fwd_lpm.c | 34 ++---
Use RFC 2544 standard values for Tx only test as default IP
address and port. But let the user override those values on command line.
Signed-off-by: Stephen Hemminger
---
v4 - update documentation to be more precise
support new tx-multi-flow addresses
app/test-pmd/parameters.c
On Tue, Apr 2, 2019 at 5:57 PM Stephen Hemminger
wrote:
> C language does not really treat enum's as first class symbols.
> The values in an enum live in a global namespace. That means if
> DPDK defines "RUNNING" it can't be used by another enum in an
> application using DPDK.
>
> To solve this
02/04/2019 22:04, David Marchand:
> On Tue, Apr 2, 2019 at 9:58 PM Ferruh Yigit wrote:
> > On 4/2/2019 8:55 PM, David Marchand wrote:
> > > On Tue, Apr 2, 2019 at 9:52 PM Ferruh Yigit
> > wrote:
> > >> On 4/2/2019 8:46 PM, David Marchand wrote:
> > >>> Bruce, while testing with meson, I noticed t
02/04/2019 05:54, Anand Rawat:
> Add windows specific logic for eal.c, eal_lcore.c,
> eal_debug.c and eal_thread.c. Updated header files to
> contain suitable function declaractions.
>
> Signed-off-by: Anand Rawat
> Signed-off-by: Pallavi Kadam
> Reviewed-by: Jeff Shaw
> Reviewed-by: Ranjit Men
On Tue, Apr 2, 2019 at 9:58 PM Ferruh Yigit wrote:
> On 4/2/2019 8:55 PM, David Marchand wrote:
> > On Tue, Apr 2, 2019 at 9:52 PM Ferruh Yigit
> wrote:
> >> On 4/2/2019 8:46 PM, David Marchand wrote:
> >>> Bruce, while testing with meson, I noticed this:
> >>> kernel/linux/kni/meson.build:16: W
On 4/2/2019 8:55 PM, David Marchand wrote:
> On Tue, Apr 2, 2019 at 9:52 PM Ferruh Yigit wrote:
>
>> On 4/2/2019 8:46 PM, David Marchand wrote:
>>> On Tue, Apr 2, 2019 at 9:30 PM Thomas Monjalon
>> wrote:
>>>
Only one header file (rte_kni_common.h) was in the sub-directory
incl
02/04/2019 05:54, Anand Rawat:
> Added rte_os.h files to support OS specific functionality.
> Updated build system to contain OS headers in the include
> path.
>
> Signed-off-by: Anand Rawat
> Reviewed-by: Pallavi Kadam
> ---
> --- a/meson.build
> +++ b/meson.build
> -global_inc = include_direct
On Tue, Apr 2, 2019 at 9:52 PM Ferruh Yigit wrote:
> On 4/2/2019 8:46 PM, David Marchand wrote:
> > On Tue, Apr 2, 2019 at 9:30 PM Thomas Monjalon
> wrote:
> >
> >> Only one header file (rte_kni_common.h) was in the sub-directory
> >> include/exec-env/
> >> This file was installed in a s
On 3/28/2019 6:52 PM, Luca Boccassi wrote:
> On Thu, 2019-03-28 at 17:51 +, Ferruh Yigit wrote:
>>> @@ -143,6 +143,7 @@ _LDLIBS-$(CONFIG_RTE_LIBRTE_DPAA2_MEMPOOL) +=
>>> -lrte_mempool_dpaa2
>>> endif
>>>
>>> _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_AF_PACKET) +=
>>> -lrte_pmd_af_packet
>>> +_LD
On 4/2/2019 8:46 PM, David Marchand wrote:
> On Tue, Apr 2, 2019 at 9:30 PM Thomas Monjalon wrote:
>
>> Only one header file (rte_kni_common.h) was in the sub-directory
>> include/exec-env/
>> This file was installed in a sub-directory of the same name
>> in the makefile-based build.
>> S
02/04/2019 21:46, David Marchand:
> On Tue, Apr 2, 2019 at 9:30 PM Thomas Monjalon wrote:
>
> > Only one header file (rte_kni_common.h) was in the sub-directory
> > include/exec-env/
> > This file was installed in a sub-directory of the same name
> > in the makefile-based build.
> > Sourc
On 4/2/2019 8:30 PM, Thomas Monjalon wrote:
> Only one header file (rte_kni_common.h) was in the sub-directory
> include/exec-env/
> This file was installed in a sub-directory of the same name
> in the makefile-based build.
> Source and install directories are moved as below:
>
>lib/libr
On Tue, Apr 2, 2019 at 9:30 PM Thomas Monjalon wrote:
> Only one header file (rte_kni_common.h) was in the sub-directory
> include/exec-env/
> This file was installed in a sub-directory of the same name
> in the makefile-based build.
> Source and install directories are moved as below:
>
Add unit test to check for hash lookup and bulk-lookup perf for
extendable bucket feature.
It is tested with both lock-free enabled and lock-free disabled case.
Test includes:
- hash lookup on keys in ext bkt
- hash delete causing key-shifts of keys from ext bkt to secondary bkt
Suggested-by: Ho
This patch series:
- Enables lock-free read-write concurrency support for extendable
bucket feature.
- Adds lock-free read-write concurrency tests for ext bkt
---
v5:
* Resolve devtools/test-meson-builds.sh error (Thomas).
v4:
* Add Acked-by tag.
v3:
* Update lib/librte_hash/rte_cuckoo_hash.c
This patch enables lock-free read-write concurrency support for
extendable bucket feature.
Suggested-by: Honnappa Nagarahalli
Signed-off-by: Dharmik Thakkar
Reviewed-by: Ruifeng Wang
Reviewed-by: Gavin Hu
Reviewed-by: Honnappa Nagarahalli
Acked-by: Yipeng Wang
---
doc/guides/prog_guide/hash
Hi Thomas,
Thank you for the review!
> On Apr 1, 2019, at 7:57 PM, Thomas Monjalon wrote:
>
> 02/04/2019 01:08, Dharmik Thakkar:
>> Add unit test to check for hash lookup and bulk-lookup perf for
>> extendable bucket feature.
>> It is tested with both lock-free enabled and lock-free disabled ca
On 4/2/2019 4:46 PM, Xiaolong Ye wrote:
> Add a new PMD driver for AF_XDP which is a proposed faster version of
> AF_PACKET interface in Linux. More info about AF_XDP, please refer to [1]
> [2].
>
> This is the vanilla version PMD which just uses a raw buffer registered as
> the umem.
>
> [1] htt
Le 02/04/2019 à 20:22, Ferruh Yigit a écrit :
Same comment as ethdev one, above code assume if driver announces
'DEV_RX_OFFLOAD_TIMESTAMP' capability, it have to implement 'read_clock'
dev_ops, should it be the case?
Write now only mlx implements it so this is not a problem at all, but I don't
k
Only one header file (rte_kni_common.h) was in the sub-directory
include/exec-env/
This file was installed in a sub-directory of the same name
in the makefile-based build.
Source and install directories are moved as below:
lib/librte_eal/linux/eal/include/exec-env/
-> lib/librte_eal/lin
Le 02/04/2019 à 19:46, Ferruh Yigit a écrit :
+* **[implements] eth_dev_ops**: ``read_clock``.
This means for a PMD to claim 'timestamp' support, it should implement the
'read_clock' dev_ops, is it really the case?
Should we say 'related' instead of 'implements' ?
Ok for me. I guess this wil
On Tue, 2019-04-02 at 23:46 +0800, Xiaolong Ye wrote:
> diff --git a/drivers/net/af_xdp/Makefile
> b/drivers/net/af_xdp/Makefile
> new file mode 100644
> index 0..8343e3016
> --- /dev/null
> +++ b/drivers/net/af_xdp/Makefile
> @@ -0,0 +1,32 @@
> +# SPDX-License-Identifier: BSD-3-Clause
> +#
Tuesday, April 2, 2019 9:23 AM, Viacheslav Ovsiienko:
> Subject: [PATCH 3/4] net/mlx5: share DV/DR flow related structures
Same comment about the title.
>
> DV/DR related structures are moved to the shared context:
> - rx/tx namespaces, shared by master and representors
> - rx/tx flow table
Tuesday, April 2, 2019 9:23 AM, Viacheslav Ovsiienko:
> Subject: [PATCH 4/4] net/mlx5: add mutex for shared DV/DR structures
Same comment about title.
>
> This patch introduces the mutex for shared DV/DR structures.
> Application may have multiple threads (but single dedicated thread per port).
Tuesday, April 2, 2019 9:23 AM, Viacheslav Ovsiienko:
> Subject: [PATCH 1/4] net/mlx5: add DV/DR flow data alloc/free routines
DV and DR are acronyms which are Mellanox specific. The title should be written
in a way that even non-Mellanox developer will easily understand it.
>
> We are going t
Tuesday, April 2, 2019 9:23 AM, Viacheslav Ovsiienko:
> Subject: [PATCH 2/4] net/mlx5: add reference counter for DV/DR structures
Same comment about the title.
>
> This patch introduces the reference counter for DV/DR flow engine
> structure, which we are going to share between master and repre
Le 02/04/2019 à 20:26, Ferruh Yigit a écrit :
error: no member named 'ctx' in 'struct mlx5_priv'
Yes indeed, master changed since my last rebase. This is fixed in v3
(I'll address other comments in related patches before sending v3).
I already addressed Shahaf's comments for this patch in
On Tue, 2 Apr 2019 23:46:53 +0800
Xiaolong Ye wrote:
> + /* pull from complete qeueu to leave more space */
Overall looks good, one last spelling error
Using access followed by open causes a static analysis warning
about Time of check versus Time of use. Also, access() and
open() have different UID permission checks.
This is not a serious problem; but easy to fix by using errno instead.
Coverity issue: 300870
Fixes: 4a928ef9f611 ("bus/pci: enabl
Running the devtools/test-build.sh script on IBM Power systems fails
because the IXGBE_PMD is explicity disabled for Power as an untested
driver, but the examples/vm_power_manager application has a hard
dependency on a function call in the IXGBE_PMD.
Modify the example application so that all depe
On 3/27/2019 6:19 AM, Tom Barbette wrote:
> +int
> +mlx5_read_clock(struct rte_eth_dev *dev, uint64_t *clock)
> +{
> + struct mlx5_priv *priv = dev->data->dev_private;
> + struct ibv_values_ex values;
> + int err = 0;
> +
> + values.comp_mask = IBV_VALUES_MASK_RAW_CLOCK;
> + err = mlx5_glue->query_
On 3/27/2019 6:19 AM, Tom Barbette wrote:
> Use rxtx callback to demonstrate a way to use rte_eth_read_clock to
> convert the hardware timestamps to an amount of cycles.
>
> This allows to get the amount of time the packet spent since its entry
> in the device. While the regular latency only shows
Signed-off-by: David Christensen
---
Running the devtools/test-build.sh script on IBM Power systems fails
because the IXGBE_PMD is explicity disabled for Power as an untested
driver, but the examples/vm_power_manager application has a hard
dependency on a function call in the IXGBE_PMD.
Modify th
On 3/27/2019 6:19 AM, Tom Barbette wrote:
> Signed-off-by: Tom Barbette
Hi Shahaf,
Reminder of this patch waiting for review.
On 3/27/2019 6:19 AM, Tom Barbette wrote:
> Add rte_eth_read_clock to read the raw clock of a devide.
>
> The main use is to get the device clock conversion co-efficients to be
> able to translate the raw clock of the timestamp field of the pkt mbuf
> to a local synced time value.
>
> This functi
On Tue, Apr 2, 2019 at 5:13 PM Burakov, Anatoly
wrote:
> On 31-Mar-19 9:43 AM, Shahaf Shuler wrote:
> > patch[1] added an address hint as starting address for 64 bit systems in
> > case an explicit base virtual address was not set by the user.
> >
> > The justification for such hint was to help d
On 02/04/2019 14:21, Luca Boccassi wrote:
> Thank you, Ju!
>
+1, thanks Ju for running these and sharing. I will add summary of them
to the 18.11.1 release notes.
> Some additional information: this test was run via the LISAv2 framework
> that Microsoft uses to validate Linux and other applicati
Currently PKT_TX_VLAN and PKT_TX_QINQ mbuf flags are documented as
they are to say packet contains VLAN or QINQ information.
Updating the definition as they are requests from application to
driver to insert VLAN or double VLAN tags into packet.
Fixes: dc6c911c9993 ("mbuf: use reserved space for d
> -Original Message-
> From: dev On Behalf Of Dekel Peled
> Sent: Tuesday, April 2, 2019 6:13 PM
> To: Adrien Mazarguil ; wenzhuo...@intel.com;
> jingjing...@intel.com; bernard.iremon...@intel.com; Yongseok Koh
> ; Shahaf Shuler
> Cc: dev@dpdk.org; Ori Kam ; Dekel Peled
>
> Subject: [
> -Original Message-
> From: dev On Behalf Of Dekel Peled
> Sent: Tuesday, April 2, 2019 6:13 PM
> To: Adrien Mazarguil ; wenzhuo...@intel.com;
> jingjing...@intel.com; bernard.iremon...@intel.com; Yongseok Koh
> ; Shahaf Shuler
> Cc: dev@dpdk.org; Ori Kam ; Dekel Peled
>
> Subject: [
> -Original Message-
> From: dev On Behalf Of Dekel Peled
> Sent: Tuesday, April 2, 2019 6:13 PM
> To: Adrien Mazarguil ; wenzhuo...@intel.com;
> jingjing...@intel.com; bernard.iremon...@intel.com; Yongseok Koh
> ; Shahaf Shuler
> Cc: dev@dpdk.org; Ori Kam ; Dekel Peled
>
> Subject: [
> -Original Message-
> From: Varghese, Vipin
>
> @@ -152,7 +157,7 @@ pdump_usage(const char *prgname)
> "[ring-size=default:16384],"
> "[mbuf-size=default:2176],"
> "[total-num-mbufs= mbufs>default:65535]'\n",
> -
On 31-Mar-19 9:43 AM, Shahaf Shuler wrote:
patch[1] added an address hint as starting address for 64 bit systems in
case an explicit base virtual address was not set by the user.
The justification for such hint was to help devices that work in VA
mode and has a address range limitation to work s
The following changes since commit dfc6b2fd8da344095567c53f3e087cae3b4690b9:
mbuf: remove Intel offload checks from generic API (2019-04-02 16:42:52 +0200)
are available in the Git repository at:
http://dpdk.org/git/next/dpdk-next-crypto
for you to fetch changes up to 56e837a425a41a1e095cc
02/04/2019 17:26, Stephen Hemminger:
> On Wed, 27 Mar 2019 12:14:44 +0100
> Thomas Monjalon wrote:
>
> > 21/03/2019 20:59, Stephen Hemminger:
> > > The divisor is not modified here. Doesn't really matter for optimizaton
> > > since the function is inline already; but helps with expressing
> > > i
C language does not really treat enum's as first class symbols.
The values in an enum live in a global namespace. That means if
DPDK defines "RUNNING" it can't be used by another enum in an
application using DPDK.
To solve this add a prefix "RTE_LCORE_" to the enum values, and
make them grammatic
Add a new PMD driver for AF_XDP which is a proposed faster version of
AF_PACKET interface in Linux. More info about AF_XDP, please refer to [1]
[2].
This is the vanilla version PMD which just uses a raw buffer registered as
the umem.
[1] https://fosdem.org/2018/schedule/event/af_xdp/
[2] https://
Overview
This patchset adds a new PMD driver for AF_XDP which is a proposed
faster version of AF_PACKET interface in Linux, see below links [1] [2] for
details of AF_XDP introduction:
AF_XDP roadmap
==
- AF_XDP is included in upstream kernel since 4.18, and AF_XDP support
i
On 4/2/2019 2:04 PM, Konstantin Ananyev wrote:
> v6 -> v5
> Fix endianness issue spotted by Olivier
> Added UT test-case for rte_mbuf_tx_offload()
>
> v5 -> v4
> Few cosmetic changes in mbuf tx_offload patch requested by Olivier
>
> v4 -> v3
> Address Akhil comments:
>- function/param
On 4/1/2019 9:52 AM, Andrew Rybchenko wrote:
> On 3/31/19 1:46 PM, Dekel Peled wrote:
>> Correct minor typing mistake:
>> pre-queue ==> per-queue
>>
>> Fixes: bea1e0c70cfc ("ethdev: convert static log type usage to dynamic")
>> Cc: sta...@dpdk.org
>>
>> Signed-off-by: Dekel Peled
>
>
> Reviewed-
On 4/1/2019 5:05 PM, Iremonger, Bernard wrote:
>> -Original Message-
>> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Dekel Peled
>> Sent: Sunday, March 31, 2019 11:36 AM
>> To: Wu, Jingjing ; Lu, Wenzhuo
>>
>> Cc: dev@dpdk.org; or...@mellanox.com; sta...@dpdk.org
>> Subject: [dpdk-
On 4/1/2019 5:19 PM, Iremonger, Bernard wrote:
>> -Original Message-
>> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Dekel Peled
>> Sent: Sunday, March 31, 2019 11:21 AM
>> To: Wu, Jingjing ; Lu, Wenzhuo
>>
>> Cc: dev@dpdk.org; or...@mellanox.com; sta...@dpdk.org
>> Subject: [dpdk-
Log message should end with newline.
Fixes: 4e32101f9b01 ("ring: support freeing")
Signed-off-by: Stephen Hemminger
Reviewed-by: Rami Rosen
---
v2 -- fix punctuation in message as well
lib/librte_ring/rte_ring.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/lib/librte_r
Hi David,
snipped
#define CMD_LINE_OPT_PDUMP "pdump"
+#define CMD_LINE_OPT_PDUMP_NUM 1
+#define CMD_LINE_OPT_MULTI "multi"
+#define CMD_LINE_OPT_MULTI_NUM 2
#define PDUMP_PORT_ARG "port"
#define PDUMP_PCI_ARG "device_id"
#define PDUMP_QUEUE_ARG "queue"
You'd better map to integers that do not
On Wed, 27 Mar 2019 12:14:44 +0100
Thomas Monjalon wrote:
> 21/03/2019 20:59, Stephen Hemminger:
> > The divisor is not modified here. Doesn't really matter for optimizaton
> > since the function is inline already; but helps with expressing
> > intent.
> >
> > Signed-off-by: Stephen Hemminger
>
The hexdump code obviously came from somewhere else originally.
It is not formatted according to DPDK coding style.
Also, drop the comment which is not useful the docbock comment
is already in the rte_hexdump.h
Signed-off-by: Stephen Hemminger
---
v2 - keep BSD style function definition
lib/li
This fixes the issue where if the length of the output is not
a multiple of 16 the formatting was off.
Before:
: 45 00 00 1C 12 34 2C E0 40 06 B8 2E C0 A8 01 12 | E4,.@...
0010: C0 A8 01 37 | | | | | | | | | | | | | ...7
After:
: 45 00 00 1C 12 34 2C E0 40
Minor bugfix and source cleanup
Stephen Hemminger (2):
hexdump: whitespace cleanup
hexdump: align output of string
lib/librte_eal/common/eal_common_hexdump.c | 114 +
1 file changed, 50 insertions(+), 64 deletions(-)
--
2.17.1
Hi,
The performance issue that we saw in Mellanox is now fixed with latest version:
The issue was with the packet len calculation that was changed in the latest
versions > 4:
diff --git a/app/test-pmd/txonly.c b/app/test-pmd/txonly.c
index af0be89..2f40949 100644
--- a/app/test-pmd/txonly.c
+++
On 02-Apr-19 8:02 AM, Shahaf Shuler wrote:
Monday, April 1, 2019 4:50 PM, Burakov, Anatoly:
Subject: Re: [dpdk-dev] [PATCH 2/3] app/testpmd: support creation of no
IOVA contig mempools
On 01-Apr-19 11:34 AM, Shahaf Shuler wrote:
providing a command line parameter to set the mempool flags accor
On 04/02, Stephen Hemminger wrote:
>On Tue, 2 Apr 2019 18:45:54 +0800
>Xiaolong Ye wrote:
>
>> +
>> +#include
>> +#include
>> +#include
>> +#include
>> +#include
>> +#include
>> +#include
>> +
>> +#include
>> +#include
>> +#include
>> +#include
>> +#include
>> +#include
>> +#include
This patch implements additional actions of packet header
modifications.
Add actions:
- INC_TCP_SEQ - Increase sequence number in the outermost TCP header.
- DEC_TCP_SEQ - Decrease sequence number in the outermost TCP header.
- INC_TCP_ACK - Increase acknowledgment number in the outermost TCP
1 - 100 of 212 matches
Mail list logo
