Re: [dpdk-dev] [PATCH v2 2/3] net/mlx5: remove device register remap

Hi Koh, See my comments below, same comments apply for mlx4 patch. Tuesday, April 2, 2019 12:22 AM, Yongseok Koh: > Subject: [dpdk-dev] [PATCH v2 2/3] net/mlx5: remove device register remap > > UAR (User Access Region) registers will be stored in a process-local table and > a process accesses a

[dpdk-dev] [PATCH 2/4] net/mlx5: add reference counter for DV/DR structures

This patch introduces the reference counter for DV/DR flow engine structure, which we are going to share between master and representors in E-Switch configurations over multiport Infiniband device. Signed-off-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5.c | 26 -- d

[dpdk-dev] [PATCH 0/4] support DR/DV flows over shared IB context

The Direct Rules/Direct Verbs flows support is going to be added [1]. The master/representor over multiport IB device is added [2]. This patchset adds support for DR/DV flows with shared IB context over multiport IB device. The DV/DR flows applied to the master/representors on the same IB device s

[dpdk-dev] [PATCH 4/4] net/mlx5: add mutex for shared DV/DR structures

This patch introduces the mutex for shared DV/DR structures. Application may have multiple threads (but single dedicated thread per port). Due to sharing the IB context in the multiport IB device configurations we should synchronize access to the shared DV/DR flow structures. Signed-off-by: Viache

[dpdk-dev] [PATCH 1/4] net/mlx5: add DV/DR flow data alloc/free routines

We are going to share the DR/DV flow device data structures between master and representors in the E-Switch configurations over multiport IB device. The code of initializing and destroying these data is moved to dedicated routines, this is just a preparation step for actual data sharing. Signed-o

[dpdk-dev] [PATCH 3/4] net/mlx5: share DV/DR flow related structures

DV/DR related structures are moved to the shared context: - rx/tx namespaces, shared by master and representors - rx/tx flow tables - matchers - encap/decap action resources - flow tags (MARK actions) - modify action resources - jump tables Signed-off-by: Viacheslav Ovsiienko --- d

Re: [dpdk-dev] [PATCH v2 1/3] net/mlx5: fix recursive inclusion of header file

Tuesday, April 2, 2019 12:22 AM, Yongseok Koh: > Subject: [PATCH v2 1/3] net/mlx5: fix recursive inclusion of header file > > mlx5.h includes mlx5_rxtx.h and mlx5_rxtx.h includes mlx5.h recursively. > > Signed-off-by: Yongseok Koh Acked-by: Shahaf Shuler > --- > drivers/net/mlx5/mlx5.h

Re: [dpdk-dev] [PATCH] net/mlx5: update counter API for upstream

Tuesday, April 2, 2019 8:25 AM, Ori Kam: > Subject: RE: [PATCH] net/mlx5: update counter API for upstream > > Hi PSB > > > -Original Message- > > From: Shahaf Shuler > > Sent: Tuesday, April 2, 2019 7:57 AM > > To: Ori Kam ; Matan Azrad > ; > > Yongseok Koh > > Cc: dev@dpdk.org > > Subje

Re: [dpdk-dev] [PATCH] net/mlx5: update counter API for upstream

Hi PSB > -Original Message- > From: Shahaf Shuler > Sent: Tuesday, April 2, 2019 7:57 AM > To: Ori Kam ; Matan Azrad ; > Yongseok Koh > Cc: dev@dpdk.org > Subject: RE: [PATCH] net/mlx5: update counter API for upstream > > Hi Ori, > > Monday, April 1, 2019 6:28 PM, Ori Kam: > > Subject:

Re: [dpdk-dev] [PATCH] net/mlx5: update counter API for upstream

Hi Ori, Monday, April 1, 2019 6:28 PM, Ori Kam: > Subject: [PATCH] net/mlx5: update counter API for upstream This is not an update, this is a fix. > > The API that was defined in OFED 4.5 was replaced both in OFED 4.6 and in > upstream. > > This commit updates the API to match the upstream on

Re: [dpdk-dev] [PATCH v4 09/13] net/mlx5: switch to the shared IB device context

Slava, Wednesday, March 27, 2019 3:16 PM, Viacheslav Ovsiienko: > Subject: [PATCH v4 09/13] net/mlx5: switch to the shared IB device context > > The code is updated to use the shared IB device context and device handles. > The IB device context is shared between reprentors created over the singl

[dpdk-dev] [PATCH v4 1/2] app/pdump: remove core restriction

PDUMP application is being limited to run on default first core. The patch removes the restriction, allowing the user to run on any of selected cores in EAL args. If no args are passed, the logic runs on default master core. Signed-off-by: Vipin Varghese --- app/pdump/main.c | 14 ++

[dpdk-dev] [PATCH v4 0/2] app/pdump: enhance to support unique cores

The patch series enhances application to support pdump capture to run on unique cores. Motivation == DPDK pdump capture tool currently runs as secondary on the default core 0. For all --pdump, core 0 iterates and capture packets. This leads to drops and delay in the capture. This introduc

[dpdk-dev] [PATCH v4 2/2] app/pdump: enhance to support multi-core capture

Add option --multi, to enhance the pdump application to allow capture on unique cores for each --pdump option. If option --multi is ignored the default capture occurs on a single core for all --pdump options. Signed-off-by: Vipin Varghese --- app/pdump/main.c | 76 +

[dpdk-dev] [PATCH v8 06/10] eal: sys/queue.h implementation for windows

Adding sys/queue.h on Windows for supporting common code. This implementation has BSD-3-Clause licensing. Signed-off-by: Ranjit Menon Signed-off-by: Anand Rawat Reviewed-by: Jeff Shaw --- .../windows/eal/include/sys/queue.h | 320 ++ 1 file changed, 320 insertions(+)

[dpdk-dev] [PATCH v8 07/10] eal: add headers for compatibility with windows

Added headers to support windows environment for common source. These headers will have windows specific implementions of the system library apis provided in linux and freebsd. Signed-off-by: Anand Rawat Signed-off-by: Pallavi Kadam Reviewed-by: Jeff Shaw Reviewed-by: Ranjit Menon --- lib/lib

[dpdk-dev] [PATCH v8 10/10] build: meson changes to build on windows

Added meson workarounds to build helloworld on Windows. Windows currently only supports kvargs and eal libraries. This change restricts the build flow to supported libraries only. Signed-off-by: Anand Rawat Signed-off-by: Pallavi Kadam Reviewed-by: Jeff Shaw Reviewed-by: Ranjit Menon --- app/

[dpdk-dev] [PATCH v8 09/10] doc: add documentation for windows

Added documentation to build helloworld example on windows using meson and clang. Signed-off-by: Pallavi Kadam Signed-off-by: Anand Rawat Reviewed-by: Jeff Shaw Reviewed-by: Ranjit Menon --- MAINTAINERS | 1 + doc/guides/index.rst | 3 +- doc/guide

Re: [dpdk-dev] [PATCH v7 8/8] build: meson changes to build on windows

On 4/1/2019 4:25 PM, Thomas Monjalon wrote: 29/03/2019 00:24, Anand Rawat: Added meson workarounds to build helloworld on windows. Windows currently only supports kvargs and eal libraries. This change restricts the build flow to supported libraries only. [...] --- a/app/meson.build +++ b/app/m

[dpdk-dev] [PATCH v8 02/10] meson: required changes for windows

These are the required meson changes for Windows. kernel/windows/meson is a stub file added to support Windows specific source in future releases. Signed-off-by: Anand Rawat Signed-off-by: Pallavi Kadam Reviewed-by: Jeff Shaw Reviewed-by: Ranjit Menon --- config/meson.build

[dpdk-dev] [PATCH v8 00/10] HelloWorld example for Windows

Includes Windows-specific EAL changes and meson changes to build the code on Windows. v8 Changes: 1. Fixed rte_os.h not found issue on linux and freebsd. 2. Updated make build system to include path for rte_os.h. 3. Fixed math lib error on linux. 4. Separated eal logic and build changes. v7 Chang

[dpdk-dev] [PATCH v8 05/10] build: add module definition file for windows

Updated lib/meson.build to create shared libraries on Windows. Added DEF files to list the exports for the eal and kvargs libraries. Signed-off-by: Bruce Richardson Signed-off-by: Anand Rawat Reviewed-by: Pallavi Kadam Reviewed-by: Ranjit Menon --- lib/librte_eal/rte_eal_exports.def |

[dpdk-dev] [PATCH v8 08/10] eal: add minimum viable code for eal on windows

Add windows specific logic for eal.c, eal_lcore.c, eal_debug.c and eal_thread.c. Updated header files to contain suitable function declaractions. Signed-off-by: Anand Rawat Signed-off-by: Pallavi Kadam Reviewed-by: Jeff Shaw Reviewed-by: Ranjit Menon --- lib/librte_eal/windows/eal/eal.c

[dpdk-dev] [PATCH v8 03/10] eal: add new rte_os.h header to build system

Added rte_os.h files to support OS specific functionality. Updated build system to contain OS headers in the include path. Signed-off-by: Anand Rawat Reviewed-by: Pallavi Kadam --- lib/librte_eal/freebsd/eal/Makefile | 4 ++-- lib/librte_eal/freebsd/eal/include/rte_os.h | 14 ++

[dpdk-dev] [PATCH v8 04/10] eal: update common headers to use rte_os.h

Updated rte_common.h to include rte_os.h to contain OS specific macros and functions. Updated rte_string_fns.h to include rte_common.h for rte_os.h Signed-off-by: Anand Rawat Reviewed-by: Pallavi Kadam Reviewed-by: Ranjit Menon --- lib/librte_eal/common/include/rte_common.h| 5 - .../

[dpdk-dev] [PATCH v8 01/10] eal: eal stub to add windows support

Added initial stub source files for windows support. Updated the MAINTAINERS list for windows support. Signed-off-by: Pallavi Kadam Signed-off-by: Anand Rawat Reviewed-by: Jeff Shaw Reviewed-by: Ranjit Menon --- MAINTAINERS | 7 ++ lib/librte_eal/windows/eal/e

Re: [dpdk-dev] [PATCH v7 2/8] eal: add header files to support os specifics

On 4/1/2019 4:09 PM, Thomas Monjalon wrote: Hi, An update of the legacy Makefiles is missing. It should be something like that: --- a/lib/librte_eal/freebsd/eal/Makefile +++ b/lib/librte_eal/freebsd/eal/Makefile @@ -86,7 +86,7 @@ CFLAGS_eal_thread.o += -Wno-return-type CFLAGS_eal_hpet.o += -W

Re: [dpdk-dev] [PATCH v2 2/3] test/distributor: replace sync builtins with atomic builtins

> -Original Message- > From: Honnappa Nagarahalli > Sent: Tuesday, April 2, 2019 12:24 AM > To: Phil Yang (Arm Technology China) ; dev@dpdk.org; > tho...@monjalon.net > Cc: david.h...@intel.com; reshma.pat...@intel.com; Gavin Hu (Arm > Technology China) ; Phil Yang (Arm Technology China) >

Re: [dpdk-dev] [PATCH v2 1/3] packet_ordering: add statistics for each worker thread

> -Original Message- > From: Pattan, Reshma > Sent: Monday, April 1, 2019 8:58 PM > To: Phil Yang (Arm Technology China) ; dev@dpdk.org; > tho...@monjalon.net > Cc: Hunt, David ; Gavin Hu (Arm Technology China) > ; Honnappa Nagarahalli > ; nd ; nd > Subject: RE: [PATCH v2 1/3] packet_orde

Re: [dpdk-dev] [PATCH v4] net/iavf: fix Tx interrupt vertor configuration error

> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Zhang, Qi Z > Sent: Tuesday, March 26, 2019 3:03 PM > To: Zhao1, Wei ; dev@dpdk.org > Cc: sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v4] net/iavf: fix Tx interrupt vertor > configuration > error > > > >

Re: [dpdk-dev] [EXT] Re: [PATCH v2 1/2] app/testpmd: fix tx vlan and qinq dependency

Hi, > -Original Message- > From: Yigit, Ferruh > Sent: Tuesday, April 2, 2019 3:10 AM > To: Nithin Kumar Dabilpuram ; Lu, Wenzhuo > ; Wu, Jingjing ; Iremonger, > Bernard > Cc: dev@dpdk.org; Wang, Xiao W > Subject: Re: [EXT] Re: [dpdk-dev] [PATCH v2 1/2] app/testpmd: fix tx vlan and > qin

[dpdk-dev] [pull-request] next-eventdev 19.05 RC1

The following changes since commit 08a710642d1d8bed831ecf2085e041213381fc68: power: fix governor storage to trim newlines (2019-04-01 22:23:44 +0200) are available in the Git repository at: http://dpdk.org/git/next/dpdk-next-eventdev for you to fetch changes up to 7a1ccc24874e251957513aba0

Re: [dpdk-dev] [EXT] Re: [dpdk-stable] [PATCH] test/eventdev: fix sprintf with snprintf

On Mon, 2019-04-01 at 16:37 -0400, Aaron Conole wrote: > > Jerin Jacob Kollanukkaran writes: > > > On Wed, 2019-03-13 at 10:35 -0400, Aaron Conole wrote: > > > > For all cases I expect truncation trigger a functional error > > > > which > > > > should be > > > > already handled properly, like in

Re: [dpdk-dev] [EXT] Re: [PATCH] eal: change init macro as exec environment specific

On Thu, 2019-03-14 at 20:44 +, Jerin Jacob Kollanukkaran wrote: > On Wed, 2019-03-13 at 14:14 +0530, Jerin Jacob wrote: > > On Wed, 2019-03-13 at 09:16 +0100, Thomas Monjalon wrote: > > > 13/03/2019 09:02, Jerin Jacob Kollanukkaran: > > > > On Tue, 2019-03-12 at 21:33 +0100, Thomas Monjalon wro

Re: [dpdk-dev] [PATCH v5 1/2] app/testpmd: optimize testpmd txonly mode

On Mon, 2019-04-01 at 22:53 +0200, Thomas Monjalon wrote: > 01/04/2019 22:25, Ferruh Yigit: > > On 3/31/2019 2:14 PM, Pavan Nikhilesh Bhagavatula wrote: > > > From: Pavan Nikhilesh > > > > > > Optimize testpmd txonly mode by > > > 1. Moving per packet ethernet header copy above the loop. > > > 2.

Re: [dpdk-dev] [PATCH v7 0/8] Support vector instructions on ICE

Hi Thomas, > -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Monday, April 1, 2019 11:14 PM > To: Yigit, Ferruh > Cc: Lu, Wenzhuo ; Zhang, Qi Z > ; dev@dpdk.org; O'Hare, Cathal > ; Mcnamara, John > Subject: Re: [dpdk-dev] [PATCH v7 0/8] Support vector ins

Re: [dpdk-dev] [PATCH v7 7/8] doc: add documentation for windows

On 4/1/2019 4:22 PM, Thomas Monjalon wrote: 29/03/2019 00:24, Anand Rawat: Added documentation to build helloworld example on windows using meson and clang. Updated the maintainers list to include windows maintainers. [...] --- a/MAINTAINERS +++ b/MAINTAINERS +Windows support +M: Harini Rama

Re: [dpdk-dev] [PATCH v4 2/2] test/hash: lock-free rw concurrency test ext bkt

02/04/2019 01:08, Dharmik Thakkar: > Add unit test to check for hash lookup and bulk-lookup perf for > extendable bucket feature. > It is tested with both lock-free enabled and lock-free disabled case. > > Test includes: > > - hash lookup on keys in ext bkt > - hash delete causing key-shifts of k

Re: [dpdk-dev] [EXT] Re: [PATCH] ethdev: fix DMA zone reserve not honoring size

On Mon, 2019-04-01 at 10:30 +0300, Andrew Rybchenko wrote: > External Email > On 3/31/19 7:25 PM, Pavan Nikhilesh Bhagavatula wrote: > > From: Pavan Nikhilesh > > > > The `rte_eth_dma_zone_reserve()` is generally used to create HW > > rings. > > In some scenarios when a driver needs to reconfigur

Re: [dpdk-dev] [PATCH] maintainers: Succeed Chao Zhu as maintainer of EAL for IBM POWER

28/03/2019 03:19, Chao Zhu: > Thanks David for taking over this job. > > > > Signed-off-by: David Christensen +Cc: sta...@dpdk.org for backport. Applied, thanks

Re: [dpdk-dev] [PATCH] maintainers: claim responsibility for timer lib

11/03/2019 17:13, Erik Gabriel Carrillo: > Add myself as co-maintainer for the timer library. > > Signed-off-by: Erik Gabriel Carrillo Acked-by: Robert Sanford Acked-by: Thomas Monjalon Applied, thanks for volunteering.

[dpdk-dev] [Bug 237] Running test-build.sh Fails on ppc_64 fails due to hard-coded requirement for IXGBE_PMD in examples/vm_power_manager

https://bugs.dpdk.org/show_bug.cgi?id=237 Bug ID: 237 Summary: Running test-build.sh Fails on ppc_64 fails due to hard-coded requirement for IXGBE_PMD in examples/vm_power_manager Product: DPDK Version: 19.05

Re: [dpdk-dev] [PATCH v2] app/test: fix sprintf with strlcat

13/03/2019 14:51, Aaron Conole: > Pallantla Poornima writes: > > > sprintf function is not secure as it doesn't check the length of string. > > More secure function strlcat is used. > > > > Fixes: 727909c592 ("app/test: introduce dynamic commands list") > > Cc: sta...@dpdk.org > > > > Signed-off-

Re: [dpdk-dev] [PATCH] telemetry: fix incorrect stat name to id mapping

01/04/2019 19:17, Laatz, Kevin: > On 28/03/2019 15:30, Bruce Richardson wrote: > > If we have two NIC ports which have a different set of NIC stats we can > > end up having two different stats registered with xstats with the same > > name. [Since the stats are updated in bulk as a contiguous set, t

Re: [dpdk-dev] [PATCH v5] lib/metrics: add unregister api for metrics

02/04/2019 02:27, Thomas Monjalon: > 27/02/2019 18:19, Junjie Wan: > > From: junka > > > > The bitmap will help maintain the metrics. We can dynamically > > add and remove metrics data. For example, after uninit latency lib, > > it could remove itself from the metrics. This could make the result

Re: [dpdk-dev] [PATCH v5] lib/metrics: add unregister api for metrics

27/02/2019 18:19, Junjie Wan: > From: junka > > The bitmap will help maintain the metrics. We can dynamically > add and remove metrics data. For example, after uninit latency lib, > it could remove itself from the metrics. This could make the result > from rte_metrics_get_names much more simple t

Re: [dpdk-dev] [PATCH v5 2/2] examples/distributor: detect high frequency cores

02/04/2019 02:06, Thomas Monjalon: > 01/04/2019 18:14, David Hunt: > > The distributor application is bottlenecked by the distributor core, > > so if we can give more frequency to this core, then the overall > > performance of the application may increase. > > > > This patch uses the rte_power_get

Re: [dpdk-dev] [PATCH v5 2/2] examples/distributor: detect high frequency cores

01/04/2019 18:14, David Hunt: > The distributor application is bottlenecked by the distributor core, > so if we can give more frequency to this core, then the overall > performance of the application may increase. > > This patch uses the rte_power_get_capabilities() API to query the > cores provid

[dpdk-dev] 18.11.1 patches review and test

Tested-by @Ju-Hyoung Lee, @Luca Boccassi [LISAv2 Test Results Summary] Test Run On : 04/01/2019 10:14:22 ARM Image Under Test : Canonical : UbuntuServer : 18.04-LTS : latest Total Test Cases : 10 (10 Passed, 0 Faile

Re: [dpdk-dev] [PATCH v7 8/8] build: meson changes to build on windows

29/03/2019 00:24, Anand Rawat: > Added meson workarounds to build helloworld on windows. > Windows currently only supports kvargs and eal libraries. > This change restricts the build flow to supported libraries > only. [...] > --- a/app/meson.build > +++ b/app/meson.build > @@ -1,5 +1,9 @@ > # SPD

Re: [dpdk-dev] [PATCH v7 7/8] doc: add documentation for windows

29/03/2019 00:24, Anand Rawat: > Added documentation to build helloworld example > on windows using meson and clang. Updated the > maintainers list to include windows maintainers. [...] > --- a/MAINTAINERS > +++ b/MAINTAINERS > +Windows support > +M: Harini Ramakrishnan > +M: Omar Cardona > +M: A

Re: [dpdk-dev] [PATCH v7 2/8] eal: add header files to support os specifics

Hi, 29/03/2019 00:24, Anand Rawat: > Added rte_os.h files to support os specific functionality. > Updated rte_common.h to include rte_os.h. Updated lib/meson.build to > inject rte_os.h in every library. > > Signed-off-by: Anand Rawat > Signed-off-by: Pallavi Kadam > Reviewed-by: Jeff Shaw > Re

[dpdk-dev] [PATCH v4 1/2] hash: add lock free support for extendable bucket

This patch enables lock-free read-write concurrency support for extendable bucket feature. Suggested-by: Honnappa Nagarahalli Signed-off-by: Dharmik Thakkar Reviewed-by: Ruifeng Wang Reviewed-by: Gavin Hu Reviewed-by: Honnappa Nagarahalli Acked-by: Yipeng Wang --- v3: - Update lib/librte_has

[dpdk-dev] [PATCH v4 2/2] test/hash: lock-free rw concurrency test ext bkt

Add unit test to check for hash lookup and bulk-lookup perf for extendable bucket feature. It is tested with both lock-free enabled and lock-free disabled case. Test includes: - hash lookup on keys in ext bkt - hash delete causing key-shifts of keys from ext bkt to secondary bkt Suggested-by: Ho

[dpdk-dev] [PATCH v4 0/2] hash: add lock free support for ext bkt

This patch series: - Enables lock-free read-write concurrency support for extendable bucket feature. - Adds lock-free read-write concurrency tests for ext bkt Dharmik Thakkar (2): hash: add lock free support for extendable bucket test/hash: lock-free rw concurrency test ext bkt app/test/tes

[dpdk-dev] [PATCH] eal: remove exec-env directory

Only one header file (rte_kni_common.h) was in the sub-directory include/exec-env/ This file was installed in a sub-directory of the same name. Source and install directories are moved as below: lib/librte_eal/linux/eal/include/exec-env/ -> lib/librte_eal/linux/eal/include/ build/in

Re: [dpdk-dev] [PATCH v3 2/2] test/hash: lock-free rw concurrency test ext bkt

>-Original Message- >From: Dharmik Thakkar [mailto:dharmik.thak...@arm.com] >Sent: Monday, April 1, 2019 3:19 PM >To: Wang, Yipeng1 ; Gobriel, Sameh >; Richardson, Bruce >; De Lara Guarch, Pablo > >Cc: dev@dpdk.org; honnappa.nagaraha...@arm.com; Dharmik Thakkar > >Subject: [PATCH v3 2/2]

[dpdk-dev] [PATCH v3 0/2] hash: add lock free support for ext bkt

This patch series: - Enables lock-free read-write concurrency support for extendable bucket feature. - Adds lock-free read-write concurrency tests for ext bkt Dharmik Thakkar (2): hash: add lock free support for extendable bucket test/hash: lock-free rw concurrency test ext bkt app/test/tes

[dpdk-dev] [PATCH v3 2/2] test/hash: lock-free rw concurrency test ext bkt

Add unit test to check for hash lookup and bulk-lookup perf for extendable bucket feature. It is tested with both lock-free enabled and lock-free disabled case. Test includes: - hash lookup on keys in ext bkt - hash delete causing key-shifts of keys from ext bkt to secondary bkt Suggested-by: Ho

[dpdk-dev] [PATCH v3 1/2] hash: add lock free support for extendable bucket

This patch enables lock-free read-write concurrency support for extendable bucket feature. Suggested-by: Honnappa Nagarahalli Signed-off-by: Dharmik Thakkar Reviewed-by: Ruifeng Wang Reviewed-by: Gavin Hu Reviewed-by: Honnappa Nagarahalli Acked-by: Yipeng Wang --- doc/guides/prog_guide/hash

[dpdk-dev] [PATCH v2 2/3] net/mlx5: remove device register remap

UAR (User Access Region) registers will be stored in a process-local table and a process accesses a register in a table entry with index. Alloc/free of table entry is managed by a global bitmap. When there's a need to store a UAR register such as Tx BlueFlame register for doorbell, an index should

[dpdk-dev] [PATCH v2 3/3] net/mlx4: remove device register remap

UAR (User Access Region) registers will be stored in a process-local table and a process accesses a register in a table entry with index. Alloc/free of table entry is managed by a global bitmap. When there's a need to store a UAR register such as Tx BlueFlame register for doorbell, an index should

[dpdk-dev] [PATCH v2 1/3] net/mlx5: fix recursive inclusion of header file

mlx5.h includes mlx5_rxtx.h and mlx5_rxtx.h includes mlx5.h recursively. Signed-off-by: Yongseok Koh --- drivers/net/mlx5/mlx5.h| 1 - drivers/net/mlx5/mlx5_flow.c | 5 +++-- drivers/net/mlx5/mlx5_flow_dv.c| 3 ++- drivers/net/mlx5/mlx5_flow_verbs.c | 5 +++-- drivers/net/m

[dpdk-dev] [PATCH v2 0/3] net/mlx: remove device register remap

This patchset lifts the requirement of reserving huge virtual address space and remapping device UAR register on to it in order to use the same address between primary and secondary process. v2: * rebase on the latest branch tip * fix a bug Yongseok Koh (3): net/mlx5: fix recursive inclusion of

[dpdk-dev] [PATCH v3 5/6] net/mlx4: add control of excessive memory pinning by kernel

A new PMD parameter (mr_ext_memseg_en) is added to control extension of memseg when creating a MR. It is enabled by default. If enabled, mlx4_mr_create() tries to maximize the range of MR registration so that the LKey lookup tables on datapath become smaller and get the best performance. However,

[dpdk-dev] [PATCH v3 6/6] net/mlx4: enable secondary process to register DMA memory

The Memory Region (MR) for DMA memory can't be created from secondary process due to lib/driver limitation. Whenever it is needed, secondary process can make a request to primary process through the EAL IPC channel (rte_mp_msg) which is established on initialization. Once a MR is created by primary

[dpdk-dev] [PATCH v3 4/6] net/mlx5: enable secondary process to register DMA memory

The Memory Region (MR) for DMA memory can't be created from secondary process due to lib/driver limitation. Whenever it is needed, secondary process can make a request to primary process through the EAL IPC channel (rte_mp_msg) which is established on initialization. Once a MR is created by primary

[dpdk-dev] [PATCH v3 3/6] net/mlx5: add control of excessive memory pinning by kernel

A new PMD parameter (mr_ext_memseg_en) is added to control extension of memseg when creating a MR. It is enabled by default. If enabled, mlx5_mr_create() tries to maximize the range of MR registration so that the LKey lookup tables on datapath become smaller and get the best performance. However,

[dpdk-dev] [PATCH v3 1/6] net/mlx: remove debug messages on datapath

Cc: sta...@dpdk.org Signed-off-by: Yongseok Koh Acked-by: Shahaf Shuler --- drivers/net/mlx4/mlx4_mr.c | 4 drivers/net/mlx5/mlx5_mr.c | 6 -- 2 files changed, 10 deletions(-) diff --git a/drivers/net/mlx4/mlx4_mr.c b/drivers/net/mlx4/mlx4_mr.c index 01894faecf..0ba55fda04 100644 ---

[dpdk-dev] [PATCH v3 2/6] net/mlx5: fix external memory registration

Secondary process is not allowed to register MR due to a restriction of library and kernel driver. Fixes: 7e43a32ee060 ("net/mlx5: support externally allocated static memory") Cc: sta...@dpdk.org Signed-off-by: Yongseok Koh Acked-by: Shahaf Shuler --- doc/guides/nics/mlx5.rst | 5 + dri

[dpdk-dev] [PATCH v3 0/6] net/mlx: enable secondary process to register DMA memory

RFC: https://mails.dpdk.org/archives/dev/2019-March/125517.html v3: * rebase on the latest branch tip v2: * add more sanity check for eth_dev and return value from IPC request * complement commit messages * add MLX5_MP_REQ_TIMEOUT_SEC * keep acked-by: Shahaf Shuler Yongseok Koh (6): net/mlx: r

[dpdk-dev] [PATCH v3 3/3] net/mlx4: add secondary process support

In order to support secondary process, a few features are required. a) rdma-core library should allocate device resources using DPDK's memory allocator. b) UAR should be remapped for secondary processes. Currently, in order not to use different data structure for secondary processes, PMD tr

[dpdk-dev] [PATCH v3 1/3] net/mlx4: change device reference for secondary process

rte_eth_devices[] is not shared between primary and secondary process, but a static array to each process. The reverse pointer of device (priv->dev) becomes invalid if mlx4 supports secondary process. Instead, priv has the pointer to shared data of the device, struct rte_eth_dev_data *dev_data;

[dpdk-dev] [PATCH v6 8/8] mempool/stack: add lock-free stack mempool handler

This commit adds support for lock-free (linked list based) stack mempool handler. In mempool_perf_autotest the lock-based stack outperforms the lock-free handler for certain lcore/alloc count/free count combinations*, however: - For applications with preemptible pthreads, a standard (lock-based)

[dpdk-dev] [PATCH v3 0/3] net/mlx4: add secondary process support

RFC: https://mails.dpdk.org/archives/dev/2019-March/125516.html v3: * rebase on the latest branch tip * remove HAVE_IBV_MLX4_SECONDARY_PROCESS and make it determined in run-time v2: * add more sanity check for eth_dev and return value from IPC request * complement commit messages * add MLX5_MP_RE

[dpdk-dev] [PATCH v3 2/3] net/mlx4: add external allocator for Verbs object

To support secondary process, the memory allocated by library such as completion rings (CQ) and buffer rings (WQ) must be manageable by EAL, in order to share it with secondary processes. With new changes in rdma-core and kernel driver, it is possible to provide an external allocator to the library

[dpdk-dev] [PATCH v6 7/8] test/stack: add lock-free stack tests

This commit adds lock-free stack variants of stack_autotest (stack_lf_autotest) and stack_perf_autotest (stack_lf_perf_autotest), which differ only in that the lock-free versions pass the RTE_STACK_F_LF flag to all rte_stack_create() calls. Signed-off-by: Gage Eads Reviewed-by: Olivier Matz ---

[dpdk-dev] [PATCH v6 6/8] stack: add C11 atomic implementation

This commit adds an implementation of the lock-free stack push, pop, and length functions that use __atomic builtins, for systems that benefit from the finer-grained memory ordering control. Signed-off-by: Gage Eads Reviewed-by: Olivier Matz --- lib/librte_stack/Makefile | 3 +- lib

[dpdk-dev] [PATCH v6 5/8] stack: add lock-free stack implementation

This commit adds support for a lock-free (linked list based) stack to the stack API. This behavior is selected through a new rte_stack_create() flag, RTE_STACK_F_LF. The stack consists of a linked list of elements, each containing a data pointer and a next pointer, and an atomic stack depth counte

[dpdk-dev] [PATCH v6 4/8] test/stack: add stack perf test

stack_perf_autotest tests the following with one lcore: - Cycles to attempt to pop an empty stack - Cycles to push then pop a single object - Cycles to push then pop a burst of 32 objects It also tests the cycles to push then pop a burst of 8 and 32 objects with the following lcore combinations (i

[dpdk-dev] [PATCH v6 3/8] test/stack: add stack test

stack_autotest performs positive and negative testing of the stack API, and exercises the push and pop datapath functions with all available lcores. Signed-off-by: Gage Eads Reviewed-by: Olivier Matz --- MAINTAINERS | 1 + app/test/Makefile | 2 + app/test/meson.build | 3 +

[dpdk-dev] [PATCH v6 2/8] mempool/stack: convert mempool to use rte stack

The new rte_stack library is derived from the mempool handler, so this commit removes duplicated code and simplifies the handler by migrating it to this new API. Signed-off-by: Gage Eads Reviewed-by: Olivier Matz --- MAINTAINERS | 2 +- drivers/mempool/stack/Makef

[dpdk-dev] [PATCH v6 1/8] stack: introduce rte stack library

The rte_stack library provides an API for configuration and use of a bounded stack of pointers. Push and pop operations are MT-safe, allowing concurrent access, and the interface supports pushing and popping multiple pointers at a time. The library's interface is modeled after another DPDK data st

[dpdk-dev] [PATCH v6 0/8] Add stack library and new mempool handler

This patchset introduces a stack library, supporting both lock-based and lock-free stacks, and a lock-free stack mempool handler. The lock-based stack code is derived from the existing stack mempool handler, and that handler is refactored to use the stack library. The lock-free stack mempool hand

[dpdk-dev] [PATCH v3 3/4] net/mlx5: rework PMD global data init

There's more need to have PMD global data structure. This should be initialized once per a process regardless of how many PMD instances are probed. mlx5_init_once() is called during probing and make sure all the init functions are called once per a process. Currently, such global data and its initi

[dpdk-dev] [PATCH v3 4/4] net/mlx5: sync stop/start of datapath with secondary process

Rx/Tx burst function pointers are stored in the rte_eth_dev structure, which is local to a process. Even though primary process replaces the function pointers, secondary will not run the new ones. With rte_mp APIs, primary can easily broadcast a request to stop/start the datapath of secondary proce

[dpdk-dev] [PATCH v3 0/4] net/mlx5: rework IPC socket and PMD global data init

The existing socket-based IPC channel is replaced with the new rte_mp APIs of EAL and extended to request stop/start of dataplane to secondary processes. Also, initialization of PMD global data including the new IPC channel is reworked to provide more generic framework for future use. v3: * rebase

[dpdk-dev] [PATCH v3 2/4] net/mlx5: replace IPC socket with EAL API

Socket API is used for IPC in order for secondary process to acquire Verb command file descriptor. The FD is used to remap UAR address. The new multi-process APIs (rte_mp) in EAL are newly introduced. mlx5_socket.c is replaced with mlx5_mp.c, which uses the new APIs. As it is PMD global infrastruc

[dpdk-dev] [PATCH v3 1/4] net/mlx5: fix memory event on secondary process

As the memory event is propagated to secondary processes, the event is processed redundantly. This should be processed once because the data structure used for MR and the event is global across the processes. Fixes: 974f1e7ef146 ("net/mlx5: add new memory region support") Cc: sta...@dpdk.org Sign

Re: [dpdk-dev] [PATCH v5 1/2] app/testpmd: optimize testpmd txonly mode

01/04/2019 22:25, Ferruh Yigit: > On 3/31/2019 2:14 PM, Pavan Nikhilesh Bhagavatula wrote: > > From: Pavan Nikhilesh > > > > Optimize testpmd txonly mode by > > 1. Moving per packet ethernet header copy above the loop. > > 2. Use bulk ops for allocating segments instead of having a inner loop > >

Re: [dpdk-dev] [dpdk-stable] [PATCH] test/eventdev: fix sprintf with snprintf

Jerin Jacob Kollanukkaran writes: > On Wed, 2019-03-13 at 10:35 -0400, Aaron Conole wrote: >> >> > For all cases I expect truncation trigger a functional error which >> > should be >> > already handled properly, like in this case 'rte_vdev_init()' will >> > fail in >> > second call if buffer is

Re: [dpdk-dev] [PATCH v5 1/2] app/testpmd: optimize testpmd txonly mode

On 3/31/2019 2:14 PM, Pavan Nikhilesh Bhagavatula wrote: > From: Pavan Nikhilesh > > Optimize testpmd txonly mode by > 1. Moving per packet ethernet header copy above the loop. > 2. Use bulk ops for allocating segments instead of having a inner loop > for every segment. > > Also, move the packet

Re: [dpdk-dev] [PATCH v2] lib/power: fix governor storage to trim newlines

29/03/2019 18:56, Burakov, Anatoly: > On 29-Mar-19 4:39 PM, David Hunt wrote: > > Currently the Power Libray stores the governor name with an embedded > > newline read from the scaling_governor sysfs file. This patch strips > > it out. > > > > Fixes: 445c6528b55f ("power: common interface for gues

Re: [dpdk-dev] [PATCH v3 6/8] stack: add C11 atomic implementation

> -Original Message- > From: Honnappa Nagarahalli [mailto:honnappa.nagaraha...@arm.com] > Sent: Monday, April 1, 2019 2:07 PM > To: Eads, Gage ; 'dev@dpdk.org' > Cc: 'olivier.m...@6wind.com' ; > 'arybche...@solarflare.com' ; Richardson, > Bruce ; Ananyev, Konstantin > ; Gavin Hu (Arm Te

Re: [dpdk-dev] [dpdk-stable] [PATCH] net: fix Tx VLAN flag for offload emulation

On 3/26/2019 6:01 PM, Chas Williams wrote: > > > On 3/26/19 12:50 PM, Ferruh Yigit wrote: >> On 3/25/2019 3:05 PM, Chas Williams wrote: >>> From: Bill Hong >>> >>> A PMD might use rte_vlan_insert to implement Tx VLAN offload. Typically >>> the PMD will insert the VLAN header in the transmit pat

Re: [dpdk-dev] [PATCH v2 1/2] hash: add lock free support for extendable bucket

+Honnappa Hi Yipeng, Thank you for the review! > On Apr 1, 2019, at 1:20 PM, Wang, Yipeng1 wrote: > >> -Original Message- >> From: Dharmik Thakkar [mailto:dharmik.thak...@arm.com] >> Sent: Monday, March 25, 2019 2:09 PM >> To: Wang, Yipeng1 ; Gobriel, Sameh >> ; Richardson, Bruce >> ;

Re: [dpdk-dev] [PATCH v7 1/8] eal: eal stub to add windows support

On Mon, Apr 01, 2019 at 10:06:18AM -0700, Anand Rawat wrote: > On 4/1/2019 9:34 AM, Bruce Richardson wrote: > > On Thu, Mar 28, 2019 at 04:24:44PM -0700, Anand Rawat wrote: > > > config/meson.build | 23 -- > > > config/x86/meson.build | 14 +

Re: [dpdk-dev] [PATCH v2 2/2] test/hash: lock-free rw concurrency test ext bkt

+Honnappa Hi Yipeng, Thank you for the review comments! > On Apr 1, 2019, at 1:55 PM, Wang, Yipeng1 wrote: > > A little bit improvement on commit-message maybe needed. > >> -Original Message- >> From: Dharmik Thakkar [mailto:dharmik.thak...@arm.com] >> Sent: Monday, March 25, 2019 2:0

Re: [dpdk-dev] [PATCH] test-meson-builds: allow building outside source dir

01/04/2019 18:23, Luca Boccassi: > On Mon, 2019-04-01 at 17:08 +0100, Bruce Richardson wrote: > > The test-meson-builds.sh script correctly detects the source > > directory and > > builds the native builds successfully in a directory outside of the > > source > > tree. However, the paths to the cro

Re: [dpdk-dev] [RFC 1/3] test/meson: auto detect number of cores

Thomas Monjalon writes: > 01/04/2019 19:48, Aaron Conole: >> "Pattan, Reshma" writes: >> > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Aaron Conole >> >> >> >> Some environments do not provide a minimum 4 cores for running tests. >> >> This >> >> allows those environments to still ex

  1   2   3   >